WebKit-https.git
10 years agoUpdate webkit.org to refer to layoutTestController instead of testRunner
rniwa@webkit.org [Tue, 19 Jun 2012 10:18:21 +0000 (10:18 +0000)]
Update webkit.org to refer to layoutTestController instead of testRunner
https://bugs.webkit.org/show_bug.cgi?id=89445

Reviewed by Kent Tamura.

* quality/testwriting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Modify HTTPS port to 8443 for performance tests
zoltan@webkit.org [Tue, 19 Jun 2012 09:33:25 +0000 (09:33 +0000)]
[Qt] Modify HTTPS port to 8443 for performance tests
https://bugs.webkit.org/show_bug.cgi?id=89442

Reviewed by Ryosuke Niwa.

We should be consistent with the default HTTPS port and with the changelog of r119188.

* Scripts/webkitpy/performance_tests/perftest.py:
(ReplayServer.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIntroduce ENABLE_CSP_NEXT configuration flag.
commit-queue@webkit.org [Tue, 19 Jun 2012 09:13:52 +0000 (09:13 +0000)]
Introduce ENABLE_CSP_NEXT configuration flag.
https://bugs.webkit.org/show_bug.cgi?id=89300

Patch by Mike West <mkwst@chromium.org> on 2012-06-19
Reviewed by Adam Barth.

The 1.0 draft of the Content Security Policy spec is just about to
move to Last Call. We'll hide work on the upcoming 1.1 spec behind
this ENABLE flag, disabled by default.

Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html

.:

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r120552): Many tests timing out on Windows
jhoneycutt@apple.com [Tue, 19 Jun 2012 09:12:19 +0000 (09:12 +0000)]
REGRESSION(r120552): Many tests timing out on Windows
https://bugs.webkit.org/show_bug.cgi?id=89433

Reviewed by Andy Estes.

* wtf/CurrentTime.cpp:
(WTF::lowResUTCTime):
It looks like there were two bugs:
1) the function was converting from 100ths of nanoseconds to seconds
   rather than 100s of nanoseconds to seconds by dividing by
   (nsPerSecond * 100) rather than (nsPerSecond / 100)
2) the function should've been returning milliseconds, not seconds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake StylePropertySet::merge() always override on conflict
commit-queue@webkit.org [Tue, 19 Jun 2012 09:10:09 +0000 (09:10 +0000)]
Make StylePropertySet::merge() always override on conflict
https://bugs.webkit.org/show_bug.cgi?id=89348

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-19
Reviewed by Ryosuke Niwa.

merge() was only used with argOverridesOnConflict = true, which
makes the extra parameter useless. It will also save a boolean check.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::mergeAndOverrideOnConflict):
* css/StylePropertySet.h:
(StylePropertySet):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::overrideWithStyle):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Forms] Move isKeyboardFocusable and isMouseFocusable to InputType from HTMLInputElement
yosin@chromium.org [Tue, 19 Jun 2012 08:57:14 +0000 (08:57 +0000)]
[Forms] Move isKeyboardFocusable and isMouseFocusable to InputType from HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=89425

Reviewed by Kent Tamura.

This patch moves implementation of HTMLInpueElement::isKeyboardFocusable
and isMouseFocusable to InputType class to allow each implementation
of InputType can decide focus-ability.

No new tests. This patch doesn't change behavior.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isKeyboardFocusable): Changed to call InputType::isKeyboardFocusable.
(WebCore::HTMLInputElement::isMouseFocusable): Changed to call InputType::isMouseFocusable.
(WebCore::HTMLInputElement::isTextFormControlFocusable): Added to allow InputType can call a method in HTMLTextFormControlElement.
(WebCore::HTMLInputElement::isTextFormControlKeyboardFocusable): Added to allow InputType can call a method in HTMLTextFormControlElement.
(WebCore::HTMLInputElement::isTextFormControlMouseFocusable): Added to allow InputType can call a method in HTMLTextFormControlElement.
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
(WebCore::InputType::isKeyboardFocusable): Changed to call isTextFormControlKeyboardFocusable.
(WebCore::InputType::isMouseFocusable): Added for default method of derived InputType classes.
* html/InputType.h:
(InputType): Chagned signature of isKeyboardFocusable.
* html/RadioInputType.cpp:
(WebCore::RadioInputType::isKeyboardFocusable): Changed to call isTextFormControlKeyboardFocusable which was done in HTMLInputElement.
* html/RadioInputType.h:
(RadioInputType):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::isKeyboardFocusable): Moved implementation from HTMLInputElement.
(WebCore::TextFieldInputType::isMouseFocusable): Moved implementation from HTMLInputElement.
* html/TextFieldInputType.h:
(TextFieldInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCalling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()
sergio@webkit.org [Tue, 19 Jun 2012 08:55:09 +0000 (08:55 +0000)]
Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()
https://bugs.webkit.org/show_bug.cgi?id=67582

Reviewed by David Levin.

Source/WebCore:

Added a new synchronous method to the IconDatabase that returns a
native image for the platform instead of a WebCore::Image*.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousNativeIconForPageURL):
(WebCore):
* loader/icon/IconDatabase.h:
(IconDatabase):
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
(IconDatabaseBase):

Source/WebKit/blackberry:

Use synchronousNativeIconForPageURL() to retrieve favicons.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):

Source/WebKit/cf:

Fixes windows build.

* WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/efl:

Use synchronousNativeIconForPageURL() to retrieve favicons.

* ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):

Source/WebKit/gtk:

Use synchronousNativeIconForPageURL() to retrieve favicons.

* webkit/webkitfavicondatabase.cpp:
(getIconPixbufSynchronously):

Source/WebKit/qt:

Use synchronousNativeIconForPageURL() to retrieve favicons.

* Api/qwebhistory.cpp:
(QWebHistoryItem::icon):
* Api/qwebsettings.cpp:
(QWebSettings::iconForUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Mac] Use AutodrainedPool instead of NSAutoreleasePool in AudioBus::loadPlatformResou...
aestes@apple.com [Tue, 19 Jun 2012 08:45:40 +0000 (08:45 +0000)]
[Mac] Use AutodrainedPool instead of NSAutoreleasePool in AudioBus::loadPlatformResource()
https://bugs.webkit.org/show_bug.cgi?id=89427

Reviewed by Dan Bernstein.

loadPlatformResource() called -[NSAutoreleasePool release] at each of
its exit points, which is not only an error-prone pattern but is
incorrect in garbage-collected environments. AutodrainedPool solves
both these problems by automatically calling -[NSAutoreleasePool drain]
when going out of scope.

* platform/audio/mac/AudioBusMac.mm:
(WebCore::AudioBus::loadPlatformResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] EFL's LayoutTestController does not support setTextDirection
commit-queue@webkit.org [Tue, 19 Jun 2012 08:38:38 +0000 (08:38 +0000)]
[EFL] EFL's LayoutTestController does not support setTextDirection
https://bugs.webkit.org/show_bug.cgi?id=87481

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-19
Reviewed by Hajime Morita.

Source/WebKit/efl:

Add new Ewk_View method to set the text direction, by calling
Editor::setBaseWritingDirection() internally, as Mac and Chromium
ports do.

* WebCoreSupport/AssertMatchingEnums.cpp:
* ewk/ewk_view.cpp:
(ewk_view_text_direction_set):
* ewk/ewk_view.h:

Tools:

Implement setTextDirection in EFL's LayoutTestController and
properly reset its value between test cases to avoid flakiness.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setTextDirection):

LayoutTests:

Unskip related test case now that EFL's LayoutTestController
implements setTextDirection.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCompilation failure in StyleResolver.cpp
rniwa@webkit.org [Tue, 19 Jun 2012 08:36:28 +0000 (08:36 +0000)]
Compilation failure in StyleResolver.cpp
https://bugs.webkit.org/show_bug.cgi?id=89446

Patch by Mike West <mkwst@chromium.org> on 2012-06-19
Reviewed by Ryosuke Niwa.

Adding 'CSSPropertyWebkitColumnProgression' to a switch statement from
which it was missing.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed build system fix after r120051.
ossy@webkit.org [Tue, 19 Jun 2012 08:23:56 +0000 (08:23 +0000)]
[Qt] Unreviewed build system fix after r120051.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r120586.
commit-queue@webkit.org [Tue, 19 Jun 2012 08:15:21 +0000 (08:15 +0000)]
Unreviewed, rolling out r120586.
http://trac.webkit.org/changeset/120586
https://bugs.webkit.org/show_bug.cgi?id=89444

doesn't fix mac issue (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-19

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::replaceMisspelledRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Temporarily disable xvfb driver in nrwt
kkristof@inf.u-szeged.hu [Tue, 19 Jun 2012 07:40:43 +0000 (07:40 +0000)]
[Qt] Temporarily disable xvfb driver in nrwt
https://bugs.webkit.org/show_bug.cgi?id=88414

Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._build_driver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed expectation update.
morrita@google.com [Tue, 19 Jun 2012 07:35:55 +0000 (07:35 +0000)]
Unreviewed expectation update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Allow the modules file generation to work on Windows.
hausmann@webkit.org [Tue, 19 Jun 2012 07:35:06 +0000 (07:35 +0000)]
[Qt] Allow the modules file generation to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=89010

Patch by Joel Dillon  <joel.dillon@codethink.co.uk>, Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-06-19
Reviewed by Csaba Osztrogonác.

Add calls to toSystemPath and use QMAKE_DIR_SEP where necessary.

* Source/api.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix TARGET not properly being set for QtWebKitd5.dll when building in debug.
hausmann@webkit.org [Tue, 19 Jun 2012 07:32:50 +0000 (07:32 +0000)]
[Qt] Fix TARGET not properly being set for QtWebKitd5.dll when building in debug.
https://bugs.webkit.org/show_bug.cgi?id=88880

load(qt_module_config) adjusts the TARGET to add the "d" suffix when doing
the debug build_pass. When doing the first pass, qt_module_config.prf doesn't
adjust the target since it is in debug_and_release and expects the debug
build_pass to come later. However, since we remove debug_and_release from CONFIG
right after this, the TARGET hasn't been adjusted and the debug build_pass
will not happen.

Work around it by disabling this optimization on Windows.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-06-19
Reviewed by Tor Arne Vestbø.

* Source/api.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a scheme registry for bypassing Content Security Policy.
commit-queue@webkit.org [Tue, 19 Jun 2012 07:27:33 +0000 (07:27 +0000)]
Add a scheme registry for bypassing Content Security Policy.
https://bugs.webkit.org/show_bug.cgi?id=89373

Patch by Mike West <mkwst@chromium.org> on 2012-06-19
Reviewed by Adam Barth.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

The Content Security Policy specification notes that "Enforcing a CSP
policy should not interfere with the operation of user-supplied scripts
such as third-party user-agent add-ons and JavaScript bookmarklets."
(https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#processing-model)
This use case can be at least partially addressed by adding a scheme
registry for certain types of URLs whose resources should be loaded
regardless of a page's defined policy directives.

See http://crbug.com/133223 for additional context.

Test: http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html

* WebCore.exp.in:
    Exporting new symbols for use by Internals.
* page/ContentSecurityPolicy.cpp:
(WebCore::isAllowedByAllWithURL):
    Adding a check against the new SchemeRegistry method to determine
    whether or not we should proceed with checking the URL against the
    policy.
* platform/SchemeRegistry.cpp:
(WebCore::CSPBypassingSchemes):
(WebCore):
(WebCore::SchemeRegistry::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsBypassingContentSecurityPolicy):
(WebCore::SchemeRegistry::schemeShouldBypassContentSecurityPolicy):
* platform/SchemeRegistry.h:
(SchemeRegistry):
    Adding the scheme registry for CSP-bypassing URL schemes.
* testing/Internals.cpp:
(WebCore):
(WebCore::Internals::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebCore::Internals::removeURLSchemeRegisteredAsBypassingContentSecurityPolicy):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
    Adding a method to Internals so that we can write a layout test.

Source/WebKit/chromium:

* public/WebSecurityPolicy.h:
(WebSecurityPolicy):
* src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebKit):

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* http/tests/security/contentSecurityPolicy/register-bypassing-scheme-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse testRunner instead of layoutTestController in fast/canvas, clip, compact, constru...
rniwa@webkit.org [Tue, 19 Jun 2012 07:23:13 +0000 (07:23 +0000)]
Use testRunner instead of layoutTestController in fast/canvas, clip, compact, constructors, cookies, and css* tests
https://bugs.webkit.org/show_bug.cgi?id=89431

Reviewed by Kent Tamura.

* fast/canvas/:
* fast/constructors/constructor-as-function-crash.html:
* fast/css-generated-content/absolute-position-inside-inline.html:
* fast/css-generated-content/after-with-first-letter-float-crash.html:
* fast/css-generated-content/attr-missing.html:
* fast/css-generated-content/before-content-with-list-marker-in-anon-block-crash.html:
* fast/css-generated-content/block-after.html:
* fast/css-generated-content/drag-state.html:
* fast/css-generated-content/empty-content-with-float-crash.html:
* fast/css-generated-content/first-letter-next-sibling-crash.html:
* fast/css-generated-content/first-letter-table-cell-format-block-crash.html:
* fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html:
* fast/css-generated-content/floating-before-content-with-list-marker-crash.html:
* fast/css-generated-content/hit-test-generated-content.html:
* fast/css-generated-content/hover-style-change.html:
* fast/css-generated-content/inline-splitting-with-after-float-crash.html:
* fast/css-generated-content/malformed-url.html:
* fast/css-generated-content/positioned-background-hit-test-crash.html:
* fast/css-generated-content/positioned-div-with-floating-after-content-crash.html:
* fast/css-generated-content/positioned-generated-content-under-run-in-crash.html:
* fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash.html:
* fast/css-generated-content/reset-content-to-initial.html:
* fast/css-generated-content/resources/pass.html:
* fast/css-generated-content/resources/positioned-div-with-floating-after-content-crash-frame2.html:
* fast/css-generated-content/spellingToolTip-assert.html:
* fast/css-generated-content/table-row-after-no-crash.html:
* fast/css-generated-content/table-with-scrollbar-corner.html:
* fast/css-generated-content/text-before-table-col-crash.html:
* fast/css-grid-layout/display-grid-set-get.html:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
* fast/css-grid-layout/grid-columns-rows-get-set.html:
* fast/css-grid-layout/grid-item-column-row-get-set.html:
* fast/css/:
* platform/mac/fast/canvas/canvas-draw-xbm-image.html:
* platform/qt/fast/canvas/toDataURL-jpeg-alpha.html:
* platform/qt/fast/canvas/toDataURL-jpeg-primarycolors.html:
* platform/qt/fast/canvas/toDataURL-jpeg-quality-basic.html:
* platform/qt/fast/canvas/toDataURL-jpeg-quality-notnumber.html:
* platform/qt/fast/canvas/toDataURL-jpeg-quality-outsiderange.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening, skip failing tests.
ossy@webkit.org [Tue, 19 Jun 2012 06:52:57 +0000 (06:52 +0000)]
[Qt] Unreviewed gardening, skip failing tests.

* platform/qt-4.8/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse testRunner instead of layoutTestController in fast/animation, autoresize, backgro...
rniwa@webkit.org [Tue, 19 Jun 2012 06:35:17 +0000 (06:35 +0000)]
Use testRunner instead of layoutTestController in fast/animation, autoresize, backgrounds, block, body-propagation, borders, and box-* tests
https://bugs.webkit.org/show_bug.cgi?id=89422

Reviewed by Kent Tamura.

* fast/animation/request-animation-frame-detach-element.html:
* fast/animation/request-animation-frame-detach-element2.html:
* fast/animation/request-animation-frame-disabled.html:
* fast/animation/request-animation-frame-during-modal.html:
* fast/animation/request-animation-frame-iframe.html:
* fast/animation/script-tests/request-animation-frame-cancel.js:
* fast/animation/script-tests/request-animation-frame-cancel2.js:
* fast/animation/script-tests/request-animation-frame-disabled.js:
* fast/animation/script-tests/request-animation-frame-timestamps-advance.js:
* fast/animation/script-tests/request-animation-frame-timestamps.js:
* fast/animation/script-tests/request-animation-frame-within-callback.js:
* fast/animation/script-tests/request-animation-frame.js:
* fast/autoresize/autoresize-with-iframe.html:
* fast/autoresize/basic.html:
* fast/autoresize/turn-off-autoresize.html:
* fast/backgrounds/animated-gif-as-background.html:
* fast/backgrounds/animated-svg-as-mask.html:
* fast/backgrounds/background-fast-path-simple-color.html:
* fast/backgrounds/background-fill-zero-area-crash.html:
* fast/backgrounds/background-repeat-computed-style.html:
* fast/backgrounds/multiple-backgrounds-assert.html:
* fast/backgrounds/root-background-propagation.html:
* fast/backgrounds/root-background-propagation2.html:
* fast/backgrounds/size/contain-and-cover-zoomed.html:
* fast/backgrounds/solid-color-context-restore.html:
* fast/block/:
* fast/borders/border-image-reset-by-border-shorthand.html:
* fast/borders/border-image-slice-omission.html:
* fast/borders/border-mixed-alpha.html:
* fast/borders/border-radius-complex-inner.html:
* fast/borders/border-radius-parsing.html:
* fast/borders/negative-border-width.html:
* fast/borders/outline-alpha-block.html:
* fast/borders/outline-alpha-inline.html:
* fast/box-shadow/box-shadow-clipped-slices.html:
* fast/box-shadow/box-shadow-currentcolor.html:
* fast/box-shadow/no-blur-multiple-offsets.html:
* fast/box-shadow/resources/box-shadow-overflow-scroll.js:
* fast/box-shadow/spread-multiple-inset.html:
* fast/box-shadow/spread-multiple-normal.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow
aestes@apple.com [Tue, 19 Jun 2012 06:33:44 +0000 (06:33 +0000)]
[Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow
https://bugs.webkit.org/show_bug.cgi?id=89424

Reviewed by Dan Bernstein.

* editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart): Store the NSShadow
in a RetainPtr so that it's released before going out of scope.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactoring: Introduce a class to represent restoring state of a form control
tkent@chromium.org [Tue, 19 Jun 2012 06:20:48 +0000 (06:20 +0000)]
Refactoring: Introduce a class to represent restoring state of a form control
https://bugs.webkit.org/show_bug.cgi?id=89412

Reviewed by Hajime Morita.

HTMLFormControlElementWithState::saveFormControlState had two return
values; One is a boolean to represent whether we should save the state
or not, and another is form control value. This patch introduces
FormControlState class representing these values.

We're going to extend FormControlState class so that it can contain
multiple strings to fix a FileInputType issue and it have another type
to fix Bug 89409.

No new tests. Just a refactoring.

* html/FormController.cpp:
(WebCore::FormController::formElementsState):
Gets a state string from a FormControlState instance.
(WebCore::FormController::takeStateForFormElement):
Creates a FormControlState instance with a state string.
* html/FormController.h:
(WebCore::FormControlState): Added.

* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::saveFormControlState):
Use FormControlState class.
(WebCore::BaseCheckableInputType::restoreFormControlState): ditto.
* html/BaseCheckableInputType.h:
(BaseCheckableInputType): ditto.
* html/FileInputType.cpp:
(WebCore::FileInputType::saveFormControlState): ditto.
(WebCore::FileInputType::restoreFormControlState): ditto.
* html/FileInputType.h:
(FileInputType): ditto.
* html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::saveFormControlState): ditto.
(WebCore::HTMLFormControlElementWithState::finishParsingChildren): ditto.
* html/HTMLFormControlElementWithState.h:
(HTMLFormControlElementWithState): ditto.
(WebCore::HTMLFormControlElementWithState::restoreFormControlState): ditto.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::saveFormControlState): ditto.
(WebCore::HTMLInputElement::restoreFormControlState): ditto.
* html/HTMLInputElement.h:
(HTMLInputElement): ditto.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::saveFormControlState): ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): ditto.
* html/HTMLSelectElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::saveFormControlState): ditto.
(WebCore::HTMLTextAreaElement::restoreFormControlState): ditto.
* html/HTMLTextAreaElement.h:
* html/HiddenInputType.cpp:
(WebCore::HiddenInputType::saveFormControlState): ditto.
(WebCore::HiddenInputType::restoreFormControlState): ditto.
* html/HiddenInputType.h:
(HiddenInputType): ditto.
* html/InputType.cpp:
(WebCore::InputType::saveFormControlState): ditto.
(WebCore::InputType::restoreFormControlState): ditto.
* html/InputType.h:
(InputType): ditto.
* html/PasswordInputType.cpp:
(WebCore::PasswordInputType::saveFormControlState): ditto.
(WebCore::PasswordInputType::restoreFormControlState): ditto.
* html/PasswordInputType.h:
(PasswordInputType): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed GTK gardening, updating baselines after rollouts in r120627.
zandobersek@gmail.com [Tue, 19 Jun 2012 06:16:16 +0000 (06:16 +0000)]
Unreviewed GTK gardening, updating baselines after rollouts in r120627.

* platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
* platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
* platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
* platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening, update expected files.
ossy@webkit.org [Tue, 19 Jun 2012 06:09:29 +0000 (06:09 +0000)]
[Qt] Unreviewed gardening, update expected files.

* platform/qt/Skipped: Skip a new failing test to paint the bot green.
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Updated after r120609.
* platform/qt/fast/multicol/progression-reverse-expected.png: Added after r120609.
* platform/qt/fast/multicol/progression-reverse-expected.txt: Added after r120609.
* platform/qt/svg/css/getComputedStyle-basic-expected.txt: Updated after r120609.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/JavaScriptCore: Changed JSC to always record line number information so that...
commit-queue@webkit.org [Tue, 19 Jun 2012 06:07:28 +0000 (06:07 +0000)]
Source/JavaScriptCore: Changed JSC to always record line number information so that error.stack
and window.onerror() can report proper line numbers.
https://bugs.webkit.org/show_bug.cgi?id=89410

Patch by Mark Lam <mark.lam@apple.com> on 2012-06-18
Reviewed by Geoffrey Garen.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit): m_lineInfo is now available unconditionally.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::addLineInfo):
(JSC::CodeBlock::hasLineInfo): Unused.  Now removed.
(JSC::CodeBlock::needsCallReturnIndices):
(CodeBlock):
(RareData):  Hoisted m_lineInfo out of m_rareData.  m_lineInfo is now
filled in unconditionally.

* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::addLineInfo):

LayoutTests: Ensure that error.stack and window.onerror always have the appropriate
line numbers of the exception being thrown.
https://bugs.webkit.org/show_bug.cgi?id=89410

Patch by Mark Lam <mark.lam@apple.com> on 2012-06-18
Reviewed by Geoffrey Garen.

* fast/js/exception-line-number-expected.txt: Added.
* fast/js/exception-line-number.html: Added.
* fast/js/script-tests/exception-line-number.js: Added.
(foo):
(window.onerror):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Fontconfig can't be linked properly
joone@webkit.org [Tue, 19 Jun 2012 05:47:57 +0000 (05:47 +0000)]
[EFL] Fontconfig can't be linked properly
https://bugs.webkit.org/show_bug.cgi?id=89418

Unreviewed build fix.

Make Fontconfig be linked correctly.

Source/WebCore:

No new tests. This is only a build fix.

* PlatformEfl.cmake: add FONTCONFIG_LIBRARIES to WebCore_LIBRARIES.

Tools:

* MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed test fix (one more) for r120667: skip '.svn' directory from the test results.
kinuko@chromium.org [Tue, 19 Jun 2012 05:47:28 +0000 (05:47 +0000)]
Unreviewed test fix (one more) for r120667: skip '.svn' directory from the test results.

* fast/forms/file/input-file-entries.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Cairo] Fix memory leaks in GLContextGLX.cpp
mrobinson@webkit.org [Tue, 19 Jun 2012 05:34:37 +0000 (05:34 +0000)]
[Cairo] Fix memory leaks in GLContextGLX.cpp
https://bugs.webkit.org/show_bug.cgi?id=89346

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-18
Reviewed by Martin Robinson.

Fix memory leaks found in GLContextGLX.cpp.

* platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::cleanupActiveContextsAtExit): Removing element reduces
size of the vector, so the loop termination condition was failing in the last
iteration, when the vector contains more than one element. This patch fixes the
issue by iterating the vector backwards, so the termination condition doesn't
fail until the size() reaches 0.
(WebCore::GLContextGLX::createPbufferContext): Delete GLXPbuffer
returned by glXCreatePbuffer().
(WebCore::GLContextGLX::createPixmapContext): Delete XVisualInfo
returned by glXChooseVisual().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed gardening. Add missing expectation file.
mikelawther@chromium.org [Tue, 19 Jun 2012 05:19:46 +0000 (05:19 +0000)]
   Unreviewed gardening. Add missing expectation file.

* fast/text/title-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Updating email for committers.py script.
joone@webkit.org [Tue, 19 Jun 2012 05:09:39 +0000 (05:09 +0000)]
Unreviewed. Updating email for committers.py script.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed test fix for r120667: skip '.svn' directory from the test results.
kinuko@chromium.org [Tue, 19 Jun 2012 05:08:26 +0000 (05:08 +0000)]
Unreviewed test fix for r120667: skip '.svn' directory from the test results.

* fast/forms/file/input-file-entries.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a typo that caused TestFailures to have a syntax error.
simon.fraser@apple.com [Tue, 19 Jun 2012 04:56:40 +0000 (04:56 +0000)]
Fix a typo that caused TestFailures to have a syntax error.

Sadly TestFailures is broken for another reason now too:
https://bugs.webkit.org/show_bug.cgi?id=89419

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
(ViewController.prototype._domForBuildName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Expose WEBGL_depth_texture extension to WebGL
commit-queue@webkit.org [Tue, 19 Jun 2012 04:34:35 +0000 (04:34 +0000)]
Source/WebCore: Expose WEBGL_depth_texture extension to WebGL
https://bugs.webkit.org/show_bug.cgi?id=87029

Patch by Gregg Tavares <gman@google.com> on 2012-06-18
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/webgl-depth-texture.html

* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* html/canvas/WebGLDepthTexture.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebCore::WebGLDepthTexture::WebGLDepthTexture):
(WebCore::WebGLDepthTexture::~WebGLDepthTexture):
(WebCore::WebGLDepthTexture::getName):
(WebCore::WebGLDepthTexture::create):
(WebCore::WebGLDepthTexture::supported):
* html/canvas/WebGLDepthTexture.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebGLDepthTexture):
* html/canvas/WebGLDepthTexture.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::initializeAttachments):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::validateSettableTexFormat):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::generateMipmap):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
(WebCore::WebGLRenderingContext::validateTexFuncData):
* html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::getClearBitsByAttachmentType):
(WebCore):
(WebCore::GraphicsContext3D::getClearBitsByFormat):
* platform/graphics/GraphicsContext3D.h:

LayoutTests: Expose WEBGL_depth_texture extension to WebGL
https://bugs.webkit.org/show_bug.cgi?id=87029

Patch by Gregg Tavares <gman@google.com> on 2012-06-18
Reviewed by Kenneth Russell.

* fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils):
* fast/canvas/webgl/webgl-depth-texture-expected.txt: Added.
* fast/canvas/webgl/webgl-depth-texture.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSupport File/DirectoryEntry access for <input type=file> if FileSystem API is enabled
kinuko@chromium.org [Tue, 19 Jun 2012 04:13:44 +0000 (04:13 +0000)]
Support File/DirectoryEntry access for <input type=file> if FileSystem API is enabled
https://bugs.webkit.org/show_bug.cgi?id=88293

Reviewed by Tony Chang.

Source/WebCore:

Proposal email on whatwg: http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033814.html
Proposal draft: http://wiki.whatwg.org/wiki/DragAndDropEntries

Test: fast/forms/file/input-file-entries.html

* Modules/filesystem/HTMLInputElementFileSystem.cpp: Added.
* Modules/filesystem/HTMLInputElementFileSystem.h: Added.
* Modules/filesystem/HTMLInputElementFileSystem.idl: Added.
* WebCore.gypi:
* html/FileInputType.cpp:
(WebCore::FileInputType::receiveDroppedFiles): Retrieves dropped file
system Id if the given DragData has it.
(WebCore::FileInputType::droppedFileSystemId): Added. This returns
dropped file system Id retrieved in receiveDroppedFiles, or an empty
string if the platform does not support isolated file system for
dropped files.
* html/FileInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::droppedFileSystemId): Added.
* html/HTMLInputElement.h:
* html/InputType.cpp:
(WebCore::InputType::droppedFileSystemId): Added.
* html/InputType.h:
* platform/DragData.cpp:
* platform/DragData.h:
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::droppedFileSystemId): Added.

LayoutTests:

* fast/forms/file/input-file-entries-expected.txt: Added.
* fast/forms/file/input-file-entries.html: Added.
* fast/forms/resources/dir1/UTF8-2.txt: Added.
* fast/forms/resources/dir1/UTF8.txt: Added.
* fast/forms/resources/dir2/green.jpg: Added.
* platform/efl/Skipped:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Crash][Editing] VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries...
shinyak@chromium.org [Tue, 19 Jun 2012 04:02:48 +0000 (04:02 +0000)]
[Crash][Editing] VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries() crashes in some Shadow DOM case.
https://bugs.webkit.org/show_bug.cgi?id=88500

Reviewed by Ryosuke Niwa.

Source/WebCore:

When selecting from a child of shadow host to an element in Shadow DOM, the start position of
Selection comes after the end position of Selection in some cases. This caused a crash.

For example, let's think '<div id="host">A</div>D' and host has a Shadow DOM whose innerHTML
is 'B<content></content>C'. When selecting from just after A (p1 = (PositionIsOffsetInAnchor,
#text, 1)) to just before B (p2 = (PositionIsOffsetInAnchor, shadowRoot, 0)), since
comparePosition always judge as p2 is before p1, m_start and m_end in VisibleSelection
will be p2 and p1 respectively.

However, the anchorNodes of p1 and p2 have the different tree scope, we have to adjust p2 to
the same tree scope as p1. Since p2 is m_start, m_start was adjusted to positionAfterNode(div).
This breaks the assumption that m_start is always before (or equal to) m_end.

This patch keeps the assumption. When we cannot move m_start to positionAfterNode(div),
we move m_start to positionBeforeNode(div). Note that we cannot always move m_start to
positionBeforeNode(div), because when selecting just after D (p3 = (PositionIsOffsetInAnchor,
D's parent, 2), we don't want to select A.

In this case, m_start should be adjusted to positionAfterNode(div).

Test: editing/shadow/breaking-editing-boundaries.html

* editing/VisibleSelection.cpp:
(WebCore::adjustPositionForEnd):
(WebCore):
(WebCore::adjustPositionForStart):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
* editing/VisibleSelection.h:
(VisibleSelection):

LayoutTests:

* editing/shadow/breaking-editing-boundaries-expected.txt: Added.
* editing/shadow/breaking-editing-boundaries.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed test marking. Marked border-radius-clip-002.htm as a failure.
morrita@google.com [Tue, 19 Jun 2012 03:54:51 +0000 (03:54 +0000)]
Unreviewed test marking. Marked border-radius-clip-002.htm as a failure.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix r120663, which didn't land the change that was reviewed.
aestes@apple.com [Tue, 19 Jun 2012 03:34:03 +0000 (03:34 +0000)]
Fix r120663, which didn't land the change that was reviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[JSC] In JSGlobalData.cpp, enableAssembler() sometimes leaks two CF objects
aestes@apple.com [Tue, 19 Jun 2012 03:32:30 +0000 (03:32 +0000)]
[JSC] In JSGlobalData.cpp, enableAssembler() sometimes leaks two CF objects
https://bugs.webkit.org/show_bug.cgi?id=89415

Reviewed by Sam Weinig.

In the case where canUseJIT was a non-NULL CFBooleanRef,
enableAssembler() would leak both canUseJITKey and canUseJIT by
returning before calling CFRelease. Fix this by using RetainPtr.

* runtime/JSGlobalData.cpp:
(JSC::enableAssembler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash when setting title dynamically
mikelawther@chromium.org [Tue, 19 Jun 2012 03:20:53 +0000 (03:20 +0000)]
Crash when setting title dynamically
https://bugs.webkit.org/show_bug.cgi?id=88083

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/text/title-crash.html

The crashing code takes a rare branch in StyleResolver::styleForElement() where
m_parentStyle is set to point to m_style. Consequently, while applying properties
to m_style we end up mutating m_parentStyle.

In this situation, we clone style() and point m_parentStyle at the clone. The
clone is destroyed at the end of StyleResolver::styleForElement().

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

* fast/text/title-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRenderLayerBacking sometimes doesn't attach scrollbars to graphics layer tree
enne@google.com [Tue, 19 Jun 2012 03:04:50 +0000 (03:04 +0000)]
RenderLayerBacking sometimes doesn't attach scrollbars to graphics layer tree
https://bugs.webkit.org/show_bug.cgi?id=89402

Reviewed by James Robinson.

Source/WebCore:

RenderLayerBacking only attaches scrollbar layers to the graphics
layer tree if there's a clip layer. This is wrong, because these
scrollbars become orphans and other code expects them to handle
repainting the scrollbars (which now become invisible). Fix by always
attaching scrollbar layers.

Test: compositing/overflow/image-load-overflow-scrollbars.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateInternalHierarchy):

LayoutTests:

Add a test where an image load creates overflow.

* compositing/overflow/image-load-overflow-scrollbars-expected.png: Added.
* compositing/overflow/image-load-overflow-scrollbars-expected.txt: Added.
* compositing/overflow/image-load-overflow-scrollbars.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake serve-video.php serve 206 responses
fischman@chromium.org [Tue, 19 Jun 2012 02:54:19 +0000 (02:54 +0000)]
Make serve-video.php serve 206 responses
https://bugs.webkit.org/show_bug.cgi?id=89252

Reviewed by Adam Barth.

* http/tests/media/resources/serve-video.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] GesturePinchBegin and friends are gesture events
abarth@webkit.org [Tue, 19 Jun 2012 02:51:55 +0000 (02:51 +0000)]
[Chromium] GesturePinchBegin and friends are gesture events
https://bugs.webkit.org/show_bug.cgi?id=89398

Reviewed by James Robinson.

* public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed test marking. Marked border-radius-clip-002.htm as a failure.
morrita@google.com [Tue, 19 Jun 2012 02:25:09 +0000 (02:25 +0000)]
Unreviewed test marking. Marked border-radius-clip-002.htm as a failure.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProvide bug links for suspicious commits
simon.fraser@apple.com [Tue, 19 Jun 2012 02:06:09 +0000 (02:06 +0000)]
Provide bug links for suspicious commits
https://bugs.webkit.org/show_bug.cgi?id=89408

Reviewed by Adam Barth.

Add links to bugs for the suspicious commits if we have bug data.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
(ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
(ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] DeviceOrientation Cleanup
commit-queue@webkit.org [Tue, 19 Jun 2012 01:38:22 +0000 (01:38 +0000)]
[Chromium] DeviceOrientation Cleanup
https://bugs.webkit.org/show_bug.cgi?id=89354

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-18
Reviewed by Kent Tamura.

Source/WebCore:

No new tests because there is no intended change in behavior.

* platform/mock/DeviceOrientationClientMock.h: added OVERRIDE specifier for virtual functions
(DeviceOrientationClientMock):

Source/WebKit/chromium:

* public/WebDeviceOrientation.h: added const-qualifiers to getters, simplified an overly-complicated parameter to two functions
(WebKit::WebDeviceOrientation::isNull):
(WebKit::WebDeviceOrientation::canProvideAlpha):
(WebKit::WebDeviceOrientation::alpha):
(WebKit::WebDeviceOrientation::canProvideBeta):
(WebKit::WebDeviceOrientation::beta):
(WebKit::WebDeviceOrientation::canProvideGamma):
(WebKit::WebDeviceOrientation::gamma):
(WebKit::WebDeviceOrientation::canProvideAbsolute):
(WebKit::WebDeviceOrientation::absolute):
(WebDeviceOrientation):
* public/WebDeviceOrientationClient.h: added WEBKIT_ASSERT_NOT_REACHED to virtual functions
(WebKit::WebDeviceOrientationClient::setController):
(WebKit::WebDeviceOrientationClient::startUpdating):
(WebKit::WebDeviceOrientationClient::stopUpdating):
(WebKit::WebDeviceOrientationClient::lastOrientation):
* public/WebDeviceOrientationClientMock.h: added OVERRIDE specifier for virtual functions
(WebDeviceOrientationClientMock):
* src/DeviceOrientationClientProxy.h: designated functions as 'virtual' and added OVERRIDE specifier
(DeviceOrientationClientProxy):
* src/WebDeviceOrientation.cpp: simplified overly-complicated parameter to two functions
(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::operator=):

Tools:

* DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] media/video-seek-past-end-playing.html is flaky
commit-queue@webkit.org [Tue, 19 Jun 2012 01:32:28 +0000 (01:32 +0000)]
[EFL] media/video-seek-past-end-playing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=89301

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-18
Reviewed by Philippe Normand.

Source/WebCore:

Switch to double for media duration and playback position
calculations to avoid precision problems.
This patch also removes the workaround for the precision
problem in didEnd() which is no longer needed.

Test: media/video-seek-past-end-playing.html

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::duration):

LayoutTests:

Unskip media/video-seek-past-end-playing.html now that the
precision problem in MediaPlayerPrivateGStreamer is fixed.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2012-06-18 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Tue, 19 Jun 2012 01:30:04 +0000 (01:30 +0000)]
2012-06-18  Andrew Scherkus  <scherkus@chromium.org>

        [Chromium] Unreviewed. Rebaseline media layout tests due to updated controls.

        https://bugs.webkit.org/show_bug.cgi?id=89050

        * platform/chromium-linux-x86/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-linux/fast/layers/video-layer-expected.png:
        * platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png:
        * platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
        * platform/chromium-linux/media/audio-controls-rendering-expected.png:
        * platform/chromium-linux/media/audio-repaint-expected.png:
        * platform/chromium-linux/media/controls-after-reload-expected.png:
        * platform/chromium-linux/media/controls-layout-direction-expected.png:
        * platform/chromium-linux/media/controls-strict-expected.png:
        * platform/chromium-linux/media/controls-styling-expected.png:
        * platform/chromium-linux/media/controls-without-preload-expected.png:
        * platform/chromium-linux/media/media-controls-clone-expected.png:
        * platform/chromium-linux/media/media-document-audio-repaint-expected.png:
        * platform/chromium-linux/media/video-controls-rendering-expected.png:
        * platform/chromium-linux/media/video-display-toggle-expected.png:
        * platform/chromium-linux/media/video-empty-source-expected.png:
        * platform/chromium-linux/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-linux/media/video-no-audio-expected.png:
        * platform/chromium-linux/media/video-playing-and-pause-expected.png:
        * platform/chromium-linux/media/video-zoom-controls-expected.png:
        * platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
        * platform/chromium-mac-leopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
        * platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
        * platform/chromium-mac-leopard/media/audio-repaint-expected.png:
        * platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
        * platform/chromium-mac-leopard/media/controls-strict-expected.png:
        * platform/chromium-mac-leopard/media/controls-styling-expected.png:
        * platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
        * platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
        * platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
        * platform/chromium-mac-leopard/media/video-empty-source-expected.png:
        * platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-mac-leopard/media/video-no-audio-expected.png:
        * platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
        * platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
        * platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
        * platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
        * platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
        * platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
        * platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
        * platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
        * platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
        * platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
        * platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
        * platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
        * platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
        * platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
        * platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
        * platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
        * platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
        * platform/chromium-mac/fast/layers/video-layer-expected.png:
        * platform/chromium-mac/fast/layers/video-layer-expected.txt:
        * platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
        * platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
        * platform/chromium-mac/media/audio-controls-rendering-expected.png:
        * platform/chromium-mac/media/audio-controls-rendering-expected.txt:
        * platform/chromium-mac/media/audio-repaint-expected.png:
        * platform/chromium-mac/media/audio-repaint-expected.txt:
        * platform/chromium-mac/media/controls-after-reload-expected.png:
        * platform/chromium-mac/media/controls-after-reload-expected.txt:
        * platform/chromium-mac/media/controls-layout-direction-expected.png:
        * platform/chromium-mac/media/controls-strict-expected.png:
        * platform/chromium-mac/media/controls-strict-expected.txt:
        * platform/chromium-mac/media/controls-styling-expected.png:
        * platform/chromium-mac/media/controls-styling-expected.txt:
        * platform/chromium-mac/media/controls-without-preload-expected.png:
        * platform/chromium-mac/media/controls-without-preload-expected.txt:
        * platform/chromium-mac/media/media-controls-clone-expected.png:
        * platform/chromium-mac/media/media-controls-clone-expected.txt:
        * platform/chromium-mac/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
        * platform/chromium-mac/media/video-controls-rendering-expected.png:
        * platform/chromium-mac/media/video-controls-rendering-expected.txt:
        * platform/chromium-mac/media/video-display-toggle-expected.png:
        * platform/chromium-mac/media/video-display-toggle-expected.txt:
        * platform/chromium-mac/media/video-empty-source-expected.png:
        * platform/chromium-mac/media/video-empty-source-expected.txt:
        * platform/chromium-mac/media/video-no-audio-expected.png:
        * platform/chromium-mac/media/video-no-audio-expected.txt:
        * platform/chromium-mac/media/video-playing-and-pause-expected.png:
        * platform/chromium-mac/media/video-playing-and-pause-expected.txt:
        * platform/chromium-mac/media/video-zoom-controls-expected.png:
        * platform/chromium-mac/media/video-zoom-controls-expected.txt:
        * platform/chromium-win-vista/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-win-xp/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-win/fast/layers/video-layer-expected.png:
        * platform/chromium-win/fast/layers/video-layer-expected.txt:
        * platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
        * platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
        * platform/chromium-win/media/audio-controls-rendering-expected.png:
        * platform/chromium-win/media/audio-controls-rendering-expected.txt:
        * platform/chromium-win/media/audio-repaint-expected.png:
        * platform/chromium-win/media/audio-repaint-expected.txt:
        * platform/chromium-win/media/controls-after-reload-expected.png:
        * platform/chromium-win/media/controls-after-reload-expected.txt:
        * platform/chromium-win/media/controls-layout-direction-expected.png:
        * platform/chromium-win/media/controls-strict-expected.png:
        * platform/chromium-win/media/controls-strict-expected.txt:
        * platform/chromium-win/media/controls-styling-expected.png:
        * platform/chromium-win/media/controls-styling-expected.txt:
        * platform/chromium-win/media/controls-without-preload-expected.png:
        * platform/chromium-win/media/controls-without-preload-expected.txt:
        * platform/chromium-win/media/media-controls-clone-expected.png:
        * platform/chromium-win/media/media-controls-clone-expected.txt:
        * platform/chromium-win/media/media-document-audio-repaint-expected.png:
        * platform/chromium-win/media/media-document-audio-repaint-expected.txt:
        * platform/chromium-win/media/video-controls-rendering-expected.png:
        * platform/chromium-win/media/video-controls-rendering-expected.txt:
        * platform/chromium-win/media/video-display-toggle-expected.png:
        * platform/chromium-win/media/video-display-toggle-expected.txt:
        * platform/chromium-win/media/video-empty-source-expected.png:
        * platform/chromium-win/media/video-empty-source-expected.txt:
        * platform/chromium-win/media/video-no-audio-expected.png:
        * platform/chromium-win/media/video-no-audio-expected.txt:
        * platform/chromium-win/media/video-playing-and-pause-expected.png:
        * platform/chromium-win/media/video-playing-and-pause-expected.txt:
        * platform/chromium-win/media/video-zoom-controls-expected.png:
        * platform/chromium-win/media/video-zoom-controls-expected.txt:
        * platform/chromium/TestExpectations:
        * platform/win-xp/fast/layers/video-layer-expected.txt: Renamed from LayoutTests/platform/win/fast/layers/video-layer-expected.txt.
        * platform/win-xp/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/win/media/audio-controls-rendering-expected.txt.
        * platform/win-xp/media/audio-repaint-expected.txt: Renamed from LayoutTests/platform/win/media/audio-repaint-expected.txt.
        * platform/win-xp/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/win/media/controls-after-reload-expected.txt.
        * platform/win-xp/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/win/media/controls-strict-expected.txt.
        * platform/win-xp/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/win/media/controls-styling-expected.txt.
        * platform/win-xp/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/win/media/controls-without-preload-expected.txt.
        * platform/win-xp/media/media-controls-clone-expected.txt: Renamed from LayoutTests/platform/win/media/media-controls-clone-expected.txt.
        * platform/win-xp/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt.
        * platform/win-xp/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/win/media/video-controls-rendering-expected.txt.
        * platform/win-xp/media/video-display-toggle-expected.txt: Renamed from LayoutTests/platform/win/media/video-display-toggle-expected.txt.
        * platform/win-xp/media/video-empty-source-expected.txt: Renamed from LayoutTests/platform/win/media/video-empty-source-expected.txt.
        * platform/win-xp/media/video-no-audio-expected.txt: Renamed from LayoutTests/platform/win/media/video-no-audio-expected.txt.
        * platform/win-xp/media/video-playing-and-pause-expected.txt: Renamed from LayoutTests/platform/win/media/video-playing-and-pause-expected.txt.
        * platform/win-xp/media/video-zoom-controls-expected.png: Renamed from LayoutTests/platform/win/media/video-zoom-controls-expected.png.
        * platform/win-xp/media/video-zoom-controls-expected.txt: Renamed from LayoutTests/platform/win/media/video-zoom-controls-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rolled DEPS.
fischman@chromium.org [Tue, 19 Jun 2012 01:29:24 +0000 (01:29 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chromium expectations update to mark tests as timing out due to r120627.
atwilson@chromium.org [Tue, 19 Jun 2012 01:21:35 +0000 (01:21 +0000)]
Unreviewed chromium expectations update to mark tests as timing out due to r120627.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphi...
commit-queue@webkit.org [Tue, 19 Jun 2012 01:12:50 +0000 (01:12 +0000)]
[chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=89254

Patch by James Robinson <jamesr@chromium.org> on 2012-06-18
Reviewed by Adrienne Walker.

This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
upstream.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMinor fix suggested by Adam Barth.
simon.fraser@apple.com [Tue, 19 Jun 2012 01:09:37 +0000 (01:09 +0000)]
Minor fix suggested by Adam Barth.

Use $(this._what).empty(); rather than removing children one at a time.
For some reason removeAllChildren() is undefined on this node.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShow TOT revision in garden-o-matic, and make the revisions into links
simon.fraser@apple.com [Tue, 19 Jun 2012 01:03:11 +0000 (01:03 +0000)]
Show TOT revision in garden-o-matic, and make the revisions into links
https://bugs.webkit.org/show_bug.cgi?id=89396

Reviewed by Adam Barth.

The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
where the revisions are links to trac.

To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
the knock-on effect of flipping the target and href attributes for anchors in some test output.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
(ViewController.prototype._displayTesters.updateList.list):
(ViewController.prototype._displayTesters.updateList):
(ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
(ViewController.prototype._domForRegressionRange):
(ViewController.prototype._domForAuxiliaryUIElements):
(ViewController.prototype._domForBuildName):
(ViewController.prototype):
(ViewController.prototype.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chromium expectations.
atwilson@chromium.org [Tue, 19 Jun 2012 01:02:21 +0000 (01:02 +0000)]
Unreviewed chromium expectations.

* platform/chromium-mac/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
* platform/chromium-win/compositing/fixed-position-scroll-offset-history-restore-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/fixed-position-scroll-offset-history-restore-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r100558): NRWT should work without SVN or GIT
dpranke@chromium.org [Tue, 19 Jun 2012 00:58:12 +0000 (00:58 +0000)]
REGRESSION(r100558): NRWT should work without SVN or GIT
https://bugs.webkit.org/show_bug.cgi?id=76630

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2012-06-18
Reviewed by Dirk Pranke.

NRWT is not supposed to have a requirement that we have an
actual SVN or Git checkout, and we were unnecessarily
initializing the checkout. This patch removes that line :).

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r120593.
commit-queue@webkit.org [Tue, 19 Jun 2012 00:50:05 +0000 (00:50 +0000)]
Unreviewed, rolling out r120593.
http://trac.webkit.org/changeset/120593
https://bugs.webkit.org/show_bug.cgi?id=89404

Caused failures in fast/forms/file/input-file-entries.html
(Requested by atwilson on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18

Source/WebCore:

* Modules/filesystem/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createIsolatedFileSystem):
* Modules/filesystem/HTMLInputElementFileSystem.cpp: Removed.
* Modules/filesystem/HTMLInputElementFileSystem.h: Removed.
* Modules/filesystem/HTMLInputElementFileSystem.idl: Removed.
* WebCore.gypi:
* html/FileInputType.cpp:
(WebCore::FileInputType::receiveDroppedFiles):
* html/FileInputType.h:
(FileInputType):
* html/HTMLInputElement.cpp:
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
* html/InputType.h:
(InputType):
* platform/DragData.cpp:
(WebCore::DragData::modifierKeyState):
(WebCore):
* platform/DragData.h:
(DragData):
* platform/chromium/DragDataChromium.cpp:

LayoutTests:

* fast/forms/file/input-file-entries-expected.txt: Removed.
* fast/forms/file/input-file-entries.html: Removed.
* fast/forms/resources/dir1/UTF8-2.txt: Removed.
* fast/forms/resources/dir1/UTF8.txt: Removed.
* fast/forms/resources/dir2/green.jpg: Removed.
* platform/efl/Skipped:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Use WebImageLayer in GraphicsLayerChromium for image layers
jamesr@google.com [Mon, 18 Jun 2012 23:54:22 +0000 (23:54 +0000)]
[chromium] Use WebImageLayer in GraphicsLayerChromium for image layers
https://bugs.webkit.org/show_bug.cgi?id=89150

Reviewed by Adrienne Walker.

Source/Platform:

Adds a WebImageLayer type to represent layers backed by (guess what) Images.

* Platform.gypi:
* chromium/public/WebImageLayer.h: Added.
(WebCore):
(WebKit):
(WebImageLayer):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::~WebImageLayer):

Source/WebCore:

Uses WebImageLayer instead of ImageLayerChromium for GraphicsLayerChromium::setContentsToImage.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):

Source/WebKit/chromium:

Implementation of WebImageLayer. Note: This could (should?) live in WebCore/platform/chromium/support/, but it's
here to be next to the other Web*Layer.cpp implementation files.

* WebKit.gyp:
* src/WebImageLayer.cpp: Added.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::setBitmap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] GraphicsLayerChromium should use WebContentLayer directly
jamesr@google.com [Mon, 18 Jun 2012 23:41:17 +0000 (23:41 +0000)]
[chromium] GraphicsLayerChromium should use WebContentLayer directly
https://bugs.webkit.org/show_bug.cgi?id=89145

Reviewed by Adrienne Walker.

Source/Platform:

Add an opaque rect parameter to WebContentLayerClient::paintContents() for a client to (optionally) provide
information about opaque portions of the painted region for culling optimizations.

* chromium/public/WebContentLayerClient.h:
(WebContentLayerClient):

Source/WebCore:

Ports GraphicsLayerChromium (or more specifically OpaqueRectTrackingContentLayerDelegate) to implement
WebContentLayerClient instead of ContentLayerDelegate. In addition to the mechanical changes, this requires
eagerly setting drawsContent on GraphicsLayerChromium::m_layer since WebContentLayerImpl's default value is
different from LayerChromium's. Covered by all of compositing/

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:
(OpaqueRectTrackingContentLayerDelegate):

Source/WebKit/chromium:

* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::paintContents):
* tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTestMainThreadTypes::createLayer):
* tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::OpaqueRectTrackingContentLayerDelegateTest):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::canvasRect):
(WebCore::TEST_F):
* tests/WebLayerTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkipping dictation tests on WK2.
enrica@apple.com [Mon, 18 Jun 2012 23:35:32 +0000 (23:35 +0000)]
Skipping dictation tests on WK2.

Unreviewed.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd from-image to css3-images image-resolution
commit-queue@webkit.org [Mon, 18 Jun 2012 23:30:29 +0000 (23:30 +0000)]
Add from-image to css3-images image-resolution
https://bugs.webkit.org/show_bug.cgi?id=85451

Patch by David Barr <davidbarr@chromium.org> on 2012-06-18
Reviewed by Tony Chang.

Source/WebCore:

The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-resolution

No new tests; extended fast/css/image-resolution/image-resolution.html

* css/CSSParser.cpp: Accept from-image identifier in image-resolution property.
(WebCore::CSSParser::parseImageResolution): Map CSSValueFromImage to identifier value from cssValuePool.
* css/CSSValueKeywords.in: Add from-image.
* css/StyleBuilder.cpp: Extend ApplyPropertyImageResolution to apply RenderStyle::imageResolutionSource.
(WebCore::ApplyPropertyImageResolution::applyInheritValue): Apply RenderStyle::imageResolutionSource.
(WebCore::ApplyPropertyImageResolution::applyInitialValue): Apply RenderStyle::imageResolutionSource.
(WebCore::ApplyPropertyImageResolution::applyValue): Map CSSValueFromImage to ImageResolutionFromImage.
* rendering/RenderImage.cpp: Extend conditions for recalculation of intrinsic size.
(WebCore::RenderImage::styleDidChange): Update intrinsic size if RenderStyle::imageResolutionSource() has changed.
* rendering/style/RenderStyle.cpp: Include StyleRareInheritedData::m_imageResolutionSource in style diff.
(WebCore::RenderStyle::diff): Map change in StyleRareInheritedData::m_imageResolutionSource to StyleDifferenceLayout.
* rendering/style/RenderStyle.h: Add RenderStyle::imageResolutionSource, RenderStyle::setImageResolutionSource, RenderStyle::initialImageResolutionSource.
* rendering/style/RenderStyleConstants.h: Add enum ImageResolutionSource.
* rendering/style/StyleRareInheritedData.cpp: Add StyleRareInheritedData::m_imageResolutionSource.
(WebCore::StyleRareInheritedData::StyleRareInheritedData): Add m_imageResolutionSource to default and copy constructor.
(WebCore::StyleRareInheritedData::operator==): Include m_imageResolutionSource in comparison.
* rendering/style/StyleRareInheritedData.h: Add StyleRareInheritedData::m_imageResolutionSource.
(StyleRareInheritedData): Add 1-bit field StyleRareInheritedData::m_imageResolutionSource.

LayoutTests:

* fast/css/image-resolution/image-resolution-expected.txt:
* fast/css/image-resolution/image-resolution.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] REGRESSION(r120346) ContentLayerPainter should clear rect to be painted
jamesr@google.com [Mon, 18 Jun 2012 23:16:08 +0000 (23:16 +0000)]
[chromium] REGRESSION(r120346) ContentLayerPainter should clear rect to be painted
https://bugs.webkit.org/show_bug.cgi?id=89376

Reviewed by Adrienne Walker.

In r120346, a refactor moved a clearRect()/clip() call from ContentLayerPainter - which all
ContentLayerChromiums use - out to OpaqueRectTrackingContentLayerDelegate - which all GraphicsLayerChromium
backed layers use, but which callers using WebContentLayer directly do not use. This meant that the canvas
wasn't cleared/clipped as WebContentLayerClient.h claimed it would be. This moves the clear and the clip
into CanvasLayerTextureUpdater which all paths use, including layers that don't use the ContentLayerPainter.

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::paint):
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r120119.
igor.o@sisa.samsung.com [Mon, 18 Jun 2012 23:14:33 +0000 (23:14 +0000)]
Unreviewed, rolling out r120119.
http://trac.webkit.org/changeset/120119

Multiple regressions on ClusterFuzz

* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
(RenderObject):

LayoutTests:

* animations/first-letter-animation-expected.txt: Removed.
* animations/first-letter-animation.html: Removed.
* animations/first-letter-play-state-expected.txt: Removed.
* animations/first-letter-play-state.html: Removed.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* transitions/first-letter-color-transition-expected.txt: Removed.
* transitions/first-letter-color-transition.html: Removed.
* transitions/first-letter-transition-expected.txt: Removed.
 * transitions/first-letter-transition.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r118414): some pages on concursolutions.com doesn't show up
rniwa@webkit.org [Mon, 18 Jun 2012 23:09:36 +0000 (23:09 +0000)]
REGRESSION(r118414): some pages on concursolutions.com doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=89399

Reviewed by Adam Barth.

Source/WebCore:

The bug was caused by insertAdjacentHTML's not passing context element to createFragmentForInnerOuterHTML.

Test: fast/html/adjacent-html-context-element.html

* html/HTMLElement.cpp:
(WebCore::HTMLElement::insertAdjacentHTML):

LayoutTests:

Add a regression test.

* fast/html/adjacent-html-context-element-expected.txt: Added.
* fast/html/adjacent-html-context-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Ensure layout has happened before calling into hasNonEmptyBoundingBox()
isherman@chromium.org [Mon, 18 Jun 2012 23:03:31 +0000 (23:03 +0000)]
[Chromium] Ensure layout has happened before calling into hasNonEmptyBoundingBox()
Also update existing code to use updateLayoutIgnorePendingStylesheets()
https://bugs.webkit.org/show_bug.cgi?id=89258

Reviewed by James Robinson.

* src/WebNode.cpp:
(WebKit::WebNode::isFocusable): Use updateLayoutIgnorePendingStylesheets()
(WebKit::WebNode::hasNonEmptyBoundingBox): Force layout before checking the bounding box

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix framebuffer-object-attachment.html failures
zmo@google.com [Mon, 18 Jun 2012 22:37:55 +0000 (22:37 +0000)]
Fix framebuffer-object-attachment.html failures
https://bugs.webkit.org/show_bug.cgi?id=89387

Reviewed by Kenneth Russell.

* html/canvas/WebGLFramebuffer.cpp: fix detachment behavior with depth/stencil/depth_stencil conflicts
(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
* html/canvas/WebGLFramebuffer.h:
(WebGLFramebuffer):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer): move logic to WebGLFramebuffer
(WebCore::WebGLRenderingContext::framebufferTexture2D): Ditto.
(WebCore::WebGLRenderingContext::getParameter): Correct the wrong assumption that it's always checking the drawingbuffer's DEPTH_BITS/STENCIL_BITS
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed expectations update for chromium after r120602.
atwilson@chromium.org [Mon, 18 Jun 2012 22:17:44 +0000 (22:17 +0000)]
Unreviewed expectations update for chromium after r120602.

* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Ensure that skipping frames during an accelerated animation doesn't cause...
commit-queue@webkit.org [Mon, 18 Jun 2012 22:17:30 +0000 (22:17 +0000)]
[chromium] Ensure that skipping frames during an accelerated animation doesn't cause starvation
https://bugs.webkit.org/show_bug.cgi?id=87766

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-18
Reviewed by James Robinson.

Source/WebCore:

Unit tests:
    CCLayerTreeHostTestCheckerboardDoesNotStarveDraws.runMultiThread
    CCSchedulerStateMachineTest.TestFailedDrawsWillEventuallyForceADrawAfterTheNextCommit

* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::didDrawIfPossibleCompleted):
(WebCore::CCSchedulerStateMachine::setMaximumNumberOfFailedDrawsBeforeDrawIsForced):
(WebCore):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(CCSchedulerStateMachine):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestCheckerboardDoesNotStarveDraws):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::beginTest):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::afterTest):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::animateLayers):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::prepareToDrawOnCCThread):
(WTF::TEST_F):
* tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):
(WebCore):
* tests/CCThreadedTest.cpp:
(WebKitTests::MockLayerTreeHostImpl::prepareToDraw):
* tests/CCThreadedTest.h:
(WebKitTests::TestHooks::prepareToDrawOnCCThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[garden-o-matic] Add support for the GTK builders
zandobersek@gmail.com [Mon, 18 Jun 2012 22:16:36 +0000 (22:16 +0000)]
[garden-o-matic] Add support for the GTK builders
https://bugs.webkit.org/show_bug.cgi?id=89360

Reviewed by Adam Barth.

Add the 'gtk' platform, essentially a copy of the 'apple' platform since
both get their data from build.webkit.org.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Enable LEGACY_VIEWPORT_ADAPTION
rwlbuis@webkit.org [Mon, 18 Jun 2012 22:08:53 +0000 (22:08 +0000)]
[BlackBerry] Enable LEGACY_VIEWPORT_ADAPTION
https://bugs.webkit.org/show_bug.cgi?id=89381

Reviewed by Antonio Gomes.

PR 163598

Enable LEGACY_VIEWPORT_ADAPTION.

* Source/cmake/OptionsBlackBerry.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate baselines after http://trac.webkit.org/changeset/120609.
abarth@webkit.org [Mon, 18 Jun 2012 22:07:47 +0000 (22:07 +0000)]
Update baselines after trac.webkit.org/changeset/120609.

* platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-linux/fast/multicol/progression-reverse-expected.png: Added.
* platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac-leopard/fast/css/getComputedStyle: Removed.
* platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac-snowleopard/fast/multicol/progression-reverse-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-mac/fast/multicol/progression-reverse-expected.png: Added.
* platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/fast/multicol/progression-reverse-expected.png: Added.
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium/mac] Unbreak smooth scrolling.
thakis@chromium.org [Mon, 18 Jun 2012 21:48:58 +0000 (21:48 +0000)]
[chromium/mac] Unbreak smooth scrolling.
https://bugs.webkit.org/show_bug.cgi?id=89327

Reviewed by Dimitri Glazkov.

Broken by Sam in r115589 / r115591.

Source/WebCore:

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::scrollAnimationEnabledForSystem):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
(TestWebKitAPI::InjectedBundleController::platformInitialize):
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdating test results to include flakey cookies tests.
enrica@apple.com [Mon, 18 Jun 2012 21:43:10 +0000 (21:43 +0000)]
Updating test results to include flakey cookies tests.

Unreviewed.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r120541, r120547, and r120548.
commit-queue@webkit.org [Mon, 18 Jun 2012 21:38:09 +0000 (21:38 +0000)]
Unreviewed, rolling out r120541, r120547, and r120548.
http://trac.webkit.org/changeset/120541
http://trac.webkit.org/changeset/120547
http://trac.webkit.org/changeset/120548
https://bugs.webkit.org/show_bug.cgi?id=89383

This approach doesn't work for WebKit2 (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18

Source/WebCore:

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
* testing/InternalSettings.h:
(InternalSettings):

Tools:

* DumpRenderTree/LayoutTestController.cpp:
(setBackingScaleFactorCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::setBackingScaleFactor):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setBackingScaleFactor):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setBackingScaleFactor):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setBackingScaleFactor):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setBackingScaleFactor):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setBackingScaleFactor):
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::postSetBackingScaleFactor):
(WTR):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setBackingScaleFactor):
(WTR):
(WTR::LayoutTestController::callSetBackingScaleFactorCallback):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

* compositing/tiled-layers-hidpi.html:
* fast/canvas/2d.backingStorePixelRatio.html:
* fast/canvas/2d.imageDataHD.html:
* fast/hidpi/broken-image-icon-hidpi.html:
* fast/hidpi/broken-image-with-size-hidpi.html:
* fast/hidpi/clip-text-in-hidpi.html:
* fast/hidpi/focus-rings.html:
* fast/hidpi/image-set-as-background.html:
* fast/hidpi/image-set-background-dynamic.html:
* fast/hidpi/image-set-background-repeat-without-size.html:
* fast/hidpi/image-set-background-repeat.html:
* fast/hidpi/image-set-border-image-comparison.html:
* fast/hidpi/image-set-border-image-dynamic.html:
* fast/hidpi/image-set-border-image-simple.html:
* fast/hidpi/image-set-in-content-dynamic.html:
* fast/hidpi/image-set-out-of-order.html:
* fast/hidpi/image-set-simple.html:
* fast/hidpi/image-set-without-specified-width.html:
* fast/hidpi/resize-corner-hidpi.html:
* fast/hidpi/video-controls-in-hidpi.html:
* platform/mac-wk2/plugins/contents-scale-factor.html:
* svg/as-image/image-respects-deviceScaleFactor.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] NetworkJob::startNewJobWithRequest() should check the frame pointer
commit-queue@webkit.org [Mon, 18 Jun 2012 21:34:46 +0000 (21:34 +0000)]
[BlackBerry] NetworkJob::startNewJobWithRequest() should check the frame pointer
https://bugs.webkit.org/show_bug.cgi?id=89369

Patch by Yong Li <yoli@rim.com> on 2012-06-18
Reviewed by Antonio Gomes.

NetworkJob::startNewJobWithRequest() should stop proceeding if the frame is null,
which means it is a PingLoader job and should just finish now.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::startNewJobWithRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the expected result for this test. This got landed with the wrong expected.txt...
abarth@webkit.org [Mon, 18 Jun 2012 21:08:07 +0000 (21:08 +0000)]
Fix the expected result for this test.  This got landed with the wrong expected.txt file.

* http/tests/security/contentSecurityPolicy/source-list-parsing-malformed-meta-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIdeographic comma and full-stops are mishandled in linebreak
mitz@apple.com [Mon, 18 Jun 2012 20:40:28 +0000 (20:40 +0000)]
Ideographic comma and full-stops are mishandled in linebreak
https://bugs.webkit.org/show_bug.cgi?id=87041

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop-2.html

Specifically, line breaks were always allowed after an ideographic comma or full stop, even
before a closing bracket.

* rendering/break_lines.cpp:
(WebCore::shouldBreakAfter): Removed code that unconditionally allowed line breaks after
ideographic commas and full stops, which was added for <http://webkit.org/b/17411> to work
around an issue in Unicode 5.0. Current line break iterator implementations are based on
newer versions of Unicode, which do not have that issue, so we can use them instead of the
hardcoded approximate rule.

LayoutTests:

* fast/text/line-breaks-after-ideographic-comma-or-full-stop-2-expected.txt: Added.
* fast/text/line-breaks-after-ideographic-comma-or-full-stop-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[TextureMapper] Rename shader variables to match the naming scheme of the newer filte...
commit-queue@webkit.org [Mon, 18 Jun 2012 20:35:50 +0000 (20:35 +0000)]
[TextureMapper] Rename shader variables to match the naming scheme of the newer filter shaders
https://bugs.webkit.org/show_bug.cgi?id=89324

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-18
Reviewed by Noam Rosenthal.

Rename shader variables to align them with those in the new filter shaders.

No new tests. This is just a simple refactor.

* platform/graphics/texmap/TextureMapperShaderManager.cpp:
Rename shader variables so that uniforms are prefixed by "u_", attributes by "a_",
and texture samplers by "s_".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Overscroll can get reset while interacting with a page, due to style...
tonikitoo@webkit.org [Mon, 18 Jun 2012 20:23:25 +0000 (20:23 +0000)]
[BlackBerry] Overscroll can get reset while interacting with a page, due to style recalculations and scroll position clamping
https://bugs.webkit.org/show_bug.cgi?id=89371
PR #166982

Reviewed by Adam Treat.
Patch by Antonio Gomes <agomes@rim.com>

While scrolling, the WebKit thread gets intercalated WebPage::setScrollPosition
calls dispatched from the UI thread. These calls are wrapped with
ScrollableArea::setConstrainsScrollingToContentEdge(false|true) calls, which
can clamp the scroll position (removes overscroll) if set to 'true'.

The following situation can happen: user is scrolling, and WebKit
thread is not in the middle of a WebPage::setScrollPosition call
(so setConstrainsScrollingToContentEdge is 'true'), and a relayout happens.
In this scenario, the scroll position will get clamped to 0,0, removing any
possible overscrolling.

See the stack trace below, paying special attention to frame 16:

Patch fixes this issue by tying ScrollableArea::setConstrainsScrollingToContentEdge
to BackingStore::m_isZoomingOrScrolling, when we are sure clamping should not happen.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setScrollPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Implement native memory bar diagram
loislo@chromium.org [Mon, 18 Jun 2012 20:17:32 +0000 (20:17 +0000)]
Web Inspector: Implement native memory bar diagram
https://bugs.webkit.org/show_bug.cgi?id=89106

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-18
Reviewed by Pavel Feldman.

* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryBarChart):
(WebInspector.NativeMemoryBarChart.prototype._updateStats):
(WebInspector.NativeMemoryBarChart.prototype.willHide):
(WebInspector.NativeMemoryBarChart.prototype.wasShown):
(WebInspector.NativeMemoryBarChart.prototype._updateView):
* inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
* inspector/front-end/nativeMemoryProfiler.css:
(.memory-bar-chart-name):
(.memory-bar-chart-bar):
(.memory-bar-chart-size):
(.memory-bar-chart-total):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r120546): It made 3 webkitpy tests fail
dpranke@chromium.org [Mon, 18 Jun 2012 20:06:59 +0000 (20:06 +0000)]
REGRESSION(r120546): It made 3 webkitpy tests fail
https://bugs.webkit.org/show_bug.cgi?id=89332

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-06-18
Reviewed by Adam Barth.

Update the BaselineOptimizer unittest after r120546.

* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_no_add_mac_future):
(BaselineOptimizerTest.test_mac_future):
(BaselineOptimizerTest.test_complex_shadowing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonew-run-webkit-tests output gets confused when logging
dpranke@chromium.org [Mon, 18 Jun 2012 19:59:53 +0000 (19:59 +0000)]
new-run-webkit-tests output gets confused when logging
https://bugs.webkit.org/show_bug.cgi?id=63793

Reviewed by Adam Barth.

Ship all of the log messages generated in the worker back
to the manager; this allows the messages to be properly
serialized to stderr and for the meter to flush its output correctly.

Note however that this will likely result in messages to be
logged out of order between workers; I'm not sure that there's
an easy way to fix this short of buffering a potentially
unbounded amount of data. It might be better to just log through
stderr unless we're in 'metering' mode, but it's also worth
noting that we already get messages out of order through stderr
on Windows.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.handle_done):
(Manager.handle_finished_test):
(Manager._log_messages):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.__init__):
(Worker._set_up_logging):
(Worker.run):
(Worker._run_test):
(Worker.cleanup):
(Worker.run_single_test):
(_WorkerLogHandler):
(_WorkerLogHandler.__init__):
(_WorkerLogHandler.emit):
* Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream.write):
(MeteredStream.writeln):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.writeln):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: native memory snapshot performance and coverage test implementation.
loislo@chromium.org [Mon, 18 Jun 2012 19:53:38 +0000 (19:53 +0000)]
Web Inspector: native memory snapshot performance and coverage test implementation.
https://bugs.webkit.org/show_bug.cgi?id=89363

We have to track the performance of MemoryAgent.getProcessMemoryDistribution.
Also this test will work as a burn down chart for Unknown memory metric.

Reviewed by Pavel Feldman.

* inspector/native-memory-snapshot.html: Added.
* inspector/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.reportSize):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in CSPSource::parseSource
commit-queue@webkit.org [Mon, 18 Jun 2012 19:51:12 +0000 (19:51 +0000)]
Crash in CSPSource::parseSource
https://bugs.webkit.org/show_bug.cgi?id=89353

Patch by Mike West <mkwst@chromium.org> on 2012-06-18
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/contentSecurityPolicy/source-list-parsing-malformed-meta.html

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSourceList::parseSource):
    Checking that we're not past the end of the string before deref.

LayoutTests:

* http/tests/security/contentSecurityPolicy/source-list-parsing-malformed-meta.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSS 2.1 failure: table-height-algorithm-012 fails
robert@webkit.org [Mon, 18 Jun 2012 19:30:33 +0000 (19:30 +0000)]
CSS 2.1 failure: table-height-algorithm-012 fails
https://bugs.webkit.org/show_bug.cgi?id=85652

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: css2.1/20110323/table-height-algorithm-012.htm
      fast/css/vertical-align-baseline-rowspan-001.htm
      fast/css/vertical-align-baseline-rowspan-002.htm
      fast/css/vertical-align-baseline-rowspan-003.htm
      fast/css/vertical-align-baseline-rowspan-004.htm
      fast/css/vertical-align-baseline-rowspan-005.htm
      fast/css/vertical-align-baseline-rowspan-006.htm
      fast/css/vertical-align-baseline-rowspan-007.htm
      fast/css/vertical-align-baseline-rowspan-008.htm
      fast/css/vertical-align-baseline-rowspan-009.htm

A spanning cell with Vertical-align set to 'baseline' should align the cell's content baseline
(which is the bottom of the first line of text or in-flow content) with the baseline of the first of the rows it spans.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight): Only calculate the baseline for the first row in a rowspan. This
  ensures that any height added to the rowspan from the baseline is only added to the first row in the span rather than
  to each of them.
(WebCore::RenderTableSection::layoutRows): Rather than get the baseline for each row in a rowspan (with the result that
  only the baseline for the last row actually sticks), calculate it for the first row in the rowspan only. This function is
  inefficient when handling rowspans so this doesn't fix the fact that redundant calculations are performed on each subsequent
  row in the span - that should be done separately.

LayoutTests:

* css2.1/20110323/table-height-algorithm-012-expected.html: Added.
* css2.1/20110323/table-height-algorithm-012.htm: Added.
* fast/css/vertical-align-baseline-rowspan-001-expected.html: Added.
* fast/css/vertical-align-baseline-rowspan-001.htm: Added.
* fast/css/vertical-align-baseline-rowspan-002-expected.html: Added.
* fast/css/vertical-align-baseline-rowspan-002.htm: Added.
* fast/css/vertical-align-baseline-rowspan-003-expected.html: Added.
* fast/css/vertical-align-baseline-rowspan-003.htm: Added.
    These are a few variations on table-height-algorithm-012.htm
* fast/css/vertical-align-baseline-rowspan-004-expected.html: Added.
* fast/css/vertical-align-baseline-rowspan-004.htm: Added.
* fast/css/vertical-align-baseline-rowspan-005-expected.html: Added.
* fast/css/vertical-align-baseline-rowspan-005.htm: Added.
* fast/css/vertical-align-baseline-rowspan-006-expected.html: Added.
* fast/css/vertical-align-baseline-rowspan-006.htm: Added.
    These three test the calculation of the baseline RenderTableSection::calcRowLogicalHeight,
    where we now always use the first row in the span. Without this the 'Filler Text' in the middle
    cell aligns beyond the top of the table.
* fast/css/vertical-align-baseline-rowspan-007-expected.html: Added.
* fast/css/vertical-align-baseline-rowspan-007.htm: Added.
* fast/css/vertical-align-baseline-rowspan-008-expected.html: Added.
* fast/css/vertical-align-baseline-rowspan-008.htm: Added.
* fast/css/vertical-align-baseline-rowspan-009-expected.html: Added.
* fast/css/vertical-align-baseline-rowspan-009.htm: Added.
    These make sure the alignment used in the first row of the span is correct when things like
    the height of the cell and the height of the span are specified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEvent dispatcher should use InsertionPoint::hasDistribution instead of InsertinPoint...
hayato@chromium.org [Mon, 18 Jun 2012 19:16:50 +0000 (19:16 +0000)]
Event dispatcher should use InsertionPoint::hasDistribution instead of InsertinPoint::isActive in re-targeting.
https://bugs.webkit.org/show_bug.cgi?id=89180

Reviewed by Dimitri Glazkov.

Source/WebCore:

If an event is fired on a fallback element within a insertion
point which does not select any nodes, the result of event's
re-targeting will be wrong since it uses
InsertionPoint::isActive() to judge an existence of a lower boundary.
That must use InsertionPoint::hasDistribution().

Test: fast/dom/shadow/shadow-dom-event-dispatching.html

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::ensureEventAncestors):

LayoutTests:

* fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
* fast/dom/shadow/shadow-dom-event-dispatching.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[garden-o-matic] Builder names without underscores cause incorrect BuildSelector...
zandobersek@gmail.com [Mon, 18 Jun 2012 19:02:37 +0000 (19:02 +0000)]
[garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
https://bugs.webkit.org/show_bug.cgi?id=89362

Reviewed by Simon Fraser.

Replace white spaces, braces and dots in the builder name with underscores. This
way the JQuery tabs will be properly matched with the according container.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: [chromium] Add iccjpeg and qcms to chromium port
abarth@webkit.org [Mon, 18 Jun 2012 18:52:35 +0000 (18:52 +0000)]
Source/WebCore:        [chromium] Add iccjpeg and qcms to chromium port
       https://bugs.webkit.org/show_bug.cgi?id=81974

       Reviewed by Adam Barth.

       Covered by existing layout tests which will be rebaselined.

       * WebCore.gyp/WebCore.gyp: Add qcms to the build.
       * platform/image-decoders/ImageDecoder.h:
       (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile.
       On OSX, return the default RGB profile. Add FIXME to use the user's
       monitor profile and verify that profile for other platforms.

       * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
       (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the
       two known output color spaces for which the decoder uses a data swizzle.
       (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For
       libjpeg-turbo, alpha may be present in the swizzled output color space.

       (WebCore::JPEGImageReader::JPEGImageReader):
       (WebCore::JPEGImageReader::close):
       (WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
       to use during decoding, and ensure we switch to inputing RGBA data to qcms
       even if the desired output data is BGRA: outputScanlines() sends BGRA data
       to the frame buffer following color correction if needed.
       (JPEGImageReader):
       (WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
       (WebCore::JPEGImageReader::createColorTransform): Create color transform.
       Release the existing transform (if any) and assign to the color transform
       created from the color profile data.
       (WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
       transform to each decoded image row.

       * platform/image-decoders/png/PNGImageDecoder.cpp:
       (WebCore::PNGImageReader::PNGImageReader):
       (WebCore::PNGImageReader::close):
       (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other
       setters and getters.
       (WebCore::PNGImageReader::decodingSizeOnly): Ditto.
       (WebCore::PNGImageReader::setHasAlpha): Ditto.
       (WebCore::PNGImageReader::hasAlpha): Ditto.
       (WebCore::PNGImageReader::interlaceBuffer): Ditto.
       (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer,
       used when a color transform is applied to the decoded image pixels.
       (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer.
       (WebCore::PNGImageReader::colorTransform): qcms color transform getter.
       (WebCore::PNGImageReader::createColorTransform): Create color transform.
       Release the existing transform (if any) and assign to the color transform
       created from the color profile data.
       (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color
       transform to use for decoding. Clear m_colorProfile (not used anymore).
       (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if
       a color transform is needed for decoding. Apply color transform to each
       decoded image row.

       * platform/image-decoders/skia/ImageDecoderSkia.cpp:
       (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no
       longer used. Add a FIXME to remove the old implementation.
       (WebCore::ImageFrame::setStatus): Remove old color correction code.

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-18

Source/WTF: [chromium] Add iccjpeg and qcms to chromium port.
https://bugs.webkit.org/show_bug.cgi?id=81974

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-18

* wtf/Platform.h: Add Chromium USE defines for ICCJPEG and QCMSLIB
to each Chromium platform, excluding Android.

Reviewed by Adam Barth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed GTK gardening, updating baselines after r120596 and r120609.
zandobersek@gmail.com [Mon, 18 Jun 2012 18:45:26 +0000 (18:45 +0000)]
Unreviewed GTK gardening, updating baselines after r120596 and r120609.

* platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/gtk/fast/layers/video-layer-expected.txt:
* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/audio-repaint-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-expected.txt:
* platform/gtk/media/controls-without-preload-expected.txt:
* platform/gtk/media/media-controls-clone-expected.txt:
* platform/gtk/media/media-document-audio-repaint-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-volume-slider-expected.txt:
* platform/gtk/media/video-zoom-controls-expected.txt:
* platform/gtk/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonrwt: metered output doesn't handle ^C cleanly
dpranke@chromium.org [Mon, 18 Jun 2012 18:45:20 +0000 (18:45 +0000)]
nrwt: metered output doesn't handle ^C cleanly
https://bugs.webkit.org/show_bug.cgi?id=89249

Reviewed by Tony Chang.

If you ctrl-c a running nrwt (w/o --verbose), then all but
two characters of the last update are erased, and then we print
"interrupted, exiting" as an update, which itself then gets
erased. Fix this so that we flush the meter (making the last
update persistent, so that we print the ^C for a visual clue),
print the interrupt message, and move on ...

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
* Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream.flush):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._write):
(Printer):
(Printer.flush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening, skip one more failing test to paint.
ossy@webkit.org [Mon, 18 Jun 2012 18:37:46 +0000 (18:37 +0000)]
[Qt] Unreviewed gardening, skip one more failing test to paint.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoColumn progression direction cannot be set independently of writing direction
mitz@apple.com [Mon, 18 Jun 2012 18:05:40 +0000 (18:05 +0000)]
Column progression direction cannot be set independently of writing direction
https://bugs.webkit.org/show_bug.cgi?id=89315

Source/WebCore:

Added a column-progression property, which can have the values 'normal' and 'reverse'. When
set to 'reverse', the first column is positioned at the end side of the block, and
subsequent columns go from the in the start direction (in the inline column axis case; in
the block column axis case, the first column coincides with the block and subsequent columns
go before the block).

Reviewed by Darin Adler.

Test: fast/multicol/progression-reverse.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added handling of the new
property.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Added validity check for the new property. The valid
values are the identifiers 'normal' and 'reverse'.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added this mapping from ColumnProgression
enum values to the identifiers 'normal and 'reverse'.
(WebCore::CSSPrimitiveValue::operator ColumnProgression): Added this mapping from the
identifiers 'normal' and 'reverse' to ColumnProgression enum values.
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty): Added the new property to the set of
non-inherited properties.
* css/CSSPropertyNames.in: Added -webkit-column-progression.
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder): Added a handler for the new property.
* rendering/ColumnInfo.h:
(WebCore::ColumnInfo::ColumnInfo): Added an initializer for the m_progressionIsReversed
member variable.
(WebCore::ColumnInfo::progressionIsReversed): Added this accessor.
(WebCore::ColumnInfo::setProgressionIsReversed): Ditto.
(ColumnInfo): Added a m_progressionIsReversed member variable.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules): Changed to advance in the reverse direction if
needed.
(WebCore::RenderBlock::setDesiredColumnCountAndWidth): Added call to
ColumnInfo::setProgressionIsReversed(), based on the new property.
(WebCore::RenderBlock::columnRectAt): Changed to take the progression direction into
account.
* rendering/style/RenderStyle.h: Added accessors and initial value for column progression.
* rendering/style/RenderStyleConstants.h: Added ColumnProgression enum.
* rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData): Added initializer for the m_progression
member variable.
(WebCore::StyleMultiColData::operator==): Added equality check for m_progression.
* rendering/style/StyleMultiColData.h:
(StyleMultiColData): Added m_progression member variable.

LayoutTests:

Reviewed by Darin Adler.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/multicol/progression-reverse-expected.png: Added.
* fast/multicol/progression-reverse-expected.txt: Added.
* fast/multicol/progression-reverse.html: Added.
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/svg/css/getComputedStyle-basic-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[TextureMapper] Replace the source transform with a flip uniform
commit-queue@webkit.org [Mon, 18 Jun 2012 17:23:55 +0000 (17:23 +0000)]
[TextureMapper] Replace the source transform with a flip uniform
https://bugs.webkit.org/show_bug.cgi?id=89317

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-18
Reviewed by Noam Rosenthal.

No new tests. This should not change any observable behavior.

* platform/graphics/texmap/TextureMapperGL.cpp: Instead of building and passing
the m4src matrix to the shader, just pass a single uniform that says whether or
not the texture should be flipped.
* platform/graphics/texmap/TextureMapperShaderManager.cpp: Change the shader programs
to deal with a flip variable rather than a source matrix.
(WebCore::TextureMapperShaderProgram::TextureMapperShaderProgram): Instead of getting the location
of the source matrix, get the location of the flip uniform.
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple): Ditto.
(WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple): Ditto.
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask): Ditto.
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::TextureMapperShaderProgramRectOpacityAndMask): Ditto.
* platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore::TextureMapperShaderProgram::flipLocation): Added this getter.
(TextureMapperShaderProgram): Rename the source matrix location member to reflect above changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r120598.
zandobersek@gmail.com [Mon, 18 Jun 2012 17:17:51 +0000 (17:17 +0000)]
Unreviewed, rolling out r120598.
http://trac.webkit.org/changeset/120598
https://bugs.webkit.org/show_bug.cgi?id=89359

Patch causes crashes on EFL and GTK release builds (Requested
by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18

Source/WebCore:

* platform/graphics/Pattern.h:
(Pattern):
* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::prepareForFilling):
* platform/graphics/cairo/PlatformContextCairo.h:

LayoutTests:

* platform/efl/Skipped:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r120592.
commit-queue@webkit.org [Mon, 18 Jun 2012 17:15:01 +0000 (17:15 +0000)]
Unreviewed, rolling out r120592.
http://trac.webkit.org/changeset/120592
https://bugs.webkit.org/show_bug.cgi?id=89357

Broke v8 bindings on windows. (Requested by atwilson__ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18

* bindings/js/JSJavaScriptCallFrameCustom.cpp:
* bindings/js/ScriptDebugServer.cpp:
* bindings/js/ScriptDebugServer.h:
(ScriptDebugServer):
* bindings/v8/DebuggerScript.js:
(.):
* bindings/v8/JavaScriptCallFrame.cpp:
* bindings/v8/JavaScriptCallFrame.h:
(JavaScriptCallFrame):
* bindings/v8/ScriptDebugServer.cpp:
* bindings/v8/ScriptDebugServer.h:
* bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
* bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
* inspector/InjectedScript.cpp:
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setScriptSource):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/JavaScriptCallFrame.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRenderTableSection wastes vector capacity
jchaffraix@webkit.org [Mon, 18 Jun 2012 17:11:12 +0000 (17:11 +0000)]
RenderTableSection wastes vector capacity
https://bugs.webkit.org/show_bug.cgi?id=86561

Reviewed by Antti Koivisto.

Memory optimization, covered by existing tests.

The issue is that addChild calls Vector::grow() which can over-allocate our row grid (especially
for small tables as we allocate at least 16 entries). As we don't know if addChild is called
in a loop (e.g. during parsing), we postpone the shrinkToFit call at layout time.

(WebCore::RenderTableSection::layout):
Added a shrinkToFit call with some explanation as to why it's good trade-off to do it now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Rebaseline media tests after r120596
commit-queue@webkit.org [Mon, 18 Jun 2012 17:04:18 +0000 (17:04 +0000)]
[EFL] Rebaseline media tests after r120596
https://bugs.webkit.org/show_bug.cgi?id=89352

Unreviewed EFL gardening. Rebaseline a few media tests
due to r120596.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-18

* platform/efl/fast/layers/video-layer-expected.txt:
* platform/efl/media/audio-controls-rendering-expected.txt:
* platform/efl/media/audio-repaint-expected.png:
* platform/efl/media/audio-repaint-expected.txt:
* platform/efl/media/controls-after-reload-expected.txt:
* platform/efl/media/controls-strict-expected.txt:
* platform/efl/media/controls-styling-expected.txt:
* platform/efl/media/controls-without-preload-expected.txt:
* platform/efl/media/media-controls-clone-expected.png:
* platform/efl/media/media-controls-clone-expected.txt:
* platform/efl/media/media-document-audio-repaint-expected.txt:
* platform/efl/media/video-controls-rendering-expected.png:
* platform/efl/media/video-controls-rendering-expected.txt:
* platform/efl/media/video-display-toggle-expected.txt:
* platform/efl/media/video-empty-source-expected.txt:
* platform/efl/media/video-zoom-controls-expected.png:
* platform/efl/media/video-zoom-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on...
wangxianzhu@chromium.org [Mon, 18 Jun 2012 16:55:20 +0000 (16:55 +0000)]
[Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
https://bugs.webkit.org/show_bug.cgi?id=89228

Reviewed by Tony Chang.

Source/WebKit/chromium:

* WebKit.gyp:
* public/linux/WebFontRendering.h:
(WebKit):
(WebFontRendering):
* public/linuxish/WebFontRendering.h: Removed.
* src/linux/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp.
(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::setLCDOrder):
(WebKit::WebFontRendering::setLCDOrientation):

Tools:

* DumpRenderTree/chromium/LayoutTestController.cpp:
* DumpRenderTree/chromium/TestShellAndroid.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkit fails IETC border-radius-clip-002
commit-queue@webkit.org [Mon, 18 Jun 2012 16:40:07 +0000 (16:40 +0000)]
webkit fails IETC border-radius-clip-002
https://bugs.webkit.org/show_bug.cgi?id=83205

Source/WebCore:

Added addRoundedRectClip instead of just clip when clipToBorderRadius
is true and bgLayer->clip() == ContentFillBox.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-18
Reviewed by Simon Fraser.

This change is covered by the existing test: ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.
However expected images should be updated. I updated chromium-linux
and chromium-mac's expected images and removed chromium-win,
chromium-mac-leopard and chromium-mac-snowleopard's expected images.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
As the code for "clipping to content boxes as necessary" doesn't
consider border-radius or not, added the code for checking
clipToBorderRadius or not, and if so, modified to use
getBackgroundRoundedRect for obtaining rounded rect and to use
addRoundedRectClip by using the obtained rounded rect.

LayoutTests:

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-18
Reviewed by Simon Fraser.

* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
* platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Removed.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Removed.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Allow updateFixedElementsAfterScrolling() to run during layout.
commit-queue@webkit.org [Mon, 18 Jun 2012 16:33:39 +0000 (16:33 +0000)]
Source/WebCore: Allow updateFixedElementsAfterScrolling() to run during layout.
https://bugs.webkit.org/show_bug.cgi?id=84965

This is needed because HistoryController restores the previous scroll
position during layout (because we don't want an ugly flash of wrongly-
scrolled content).

Patch by Iain Merrick <husky@google.com> on 2012-06-18
Reviewed by Simon Fraser.

Test: compositing/fixed-position-scroll-offset-history-restore.html

* page/FrameView.cpp:
(WebCore::FrameView::updateFixedElementsAfterScrolling):

LayoutTests: Allow updateFixedElementsAfterScrolling() to run during layout.
https://bugs.webkit.org/show_bug.cgi?id=84965

This is needed because HistoryController restores the previous scroll
position during layout (because we don't want an ugly flash of wrongly-
scrolled content).

Patch by Iain Merrick <husky@google.com> on 2012-06-18
Reviewed by Simon Fraser.

* compositing/fixed-position-scroll-offset-history-restore-expected.txt: Added.
* compositing/fixed-position-scroll-offset-history-restore.html: Added.
* compositing/resources/fixed-position-scroll-offset-history-restore-2.html: Added.
* platform/chromium-linux/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSOM wrappers are not built for rules in the per-document and page group user styles...
apavlov@chromium.org [Mon, 18 Jun 2012 16:04:11 +0000 (16:04 +0000)]
CSSOM wrappers are not built for rules in the per-document and page group user stylesheets
https://bugs.webkit.org/show_bug.cgi?id=89221

Reviewed by Antti Koivisto.

Source/WebCore:

The issue manifested itself by not displaying injected page group stylesheet data in the Styles pane.

Test: inspector/styles/inject-stylesheet.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

* inspector/styles/inject-stylesheet-expected.txt: Added.
* inspector/styles/inject-stylesheet.html: Added.
* inspector/styles/resources/inject-stylesheet-iframe-data.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening, skip one more failing test. (Less test == less problem...
ossy@webkit.org [Mon, 18 Jun 2012 15:52:23 +0000 (15:52 +0000)]
[Qt] Unreviewed gardening, skip one more failing test. (Less test == less problem. :) )

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120599 268f45cc-cd09-0410-ab3c-d52691b4dbfc