WebKit-https.git
10 years ago2011-04-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 Apr 2011 05:05:50 +0000 (05:05 +0000)]
2011-04-13  Simon Fraser  <simon.fraser@apple.com>

        Revert http://trac.webkit.org/changeset/83750 because it broke PrettyPatch.
        https://bugs.webkit.org/show_bug.cgi?id=58510

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAccidentally made us GC on every allocation.
oliver@apple.com [Thu, 14 Apr 2011 04:01:50 +0000 (04:01 +0000)]
Accidentally made us GC on every allocation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix 32bit tests.
oliver@apple.com [Thu, 14 Apr 2011 03:57:40 +0000 (03:57 +0000)]
Fix 32bit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 14 Apr 2011 03:28:23 +0000 (03:28 +0000)]
2011-04-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoff Garen.

        GC allocate Structure
        https://bugs.webkit.org/show_bug.cgi?id=58483

        Additional structures are allocated beyond the expected threshold
        so we preflight the test to get them allocated.

        * fast/dom/gc-10.html:
2011-04-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoff Garen.

        GC allocate Structure
        https://bugs.webkit.org/show_bug.cgi?id=58483

        Turn Structure into a GC allocated object.  Most of this patch
        is the mechanical change of replacing variations on RefPtr<Structure>
        with either Structure* (for arguments and locals), WriteBarrier<Structure>
        for the few cases where Structures are held by GC allocated objects
        and Strong<Structure> for the root structure objects in GlobalData.

        * API/JSCallbackConstructor.cpp:
        (JSC::JSCallbackConstructor::JSCallbackConstructor):
        * API/JSCallbackConstructor.h:
        (JSC::JSCallbackConstructor::createStructure):
        * API/JSCallbackFunction.h:
        (JSC::JSCallbackFunction::createStructure):
        * API/JSCallbackObject.h:
        (JSC::JSCallbackObject::createStructure):
        * API/JSCallbackObjectFunctions.h:
        (JSC::::JSCallbackObject):
        * API/JSContextRef.cpp:
        * JavaScriptCore.JSVALUE32_64only.exp:
        * JavaScriptCore.JSVALUE64only.exp:
        * JavaScriptCore.exp:
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::~CodeBlock):
        (JSC::CodeBlock::markStructures):
        (JSC::CodeBlock::markAggregate):
        * bytecode/CodeBlock.h:
        (JSC::MethodCallLinkInfo::setSeen):
        (JSC::GlobalResolveInfo::GlobalResolveInfo):
        * bytecode/Instruction.h:
        (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
        (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
        (JSC::PolymorphicAccessStructureList::markAggregate):
        (JSC::Instruction::Instruction):
        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::deref):
        (JSC::StructureStubInfo::markAggregate):
        * bytecode/StructureStubInfo.h:
        (JSC::StructureStubInfo::initGetByIdSelf):
        (JSC::StructureStubInfo::initGetByIdProto):
        (JSC::StructureStubInfo::initGetByIdChain):
        (JSC::StructureStubInfo::initPutByIdTransition):
        (JSC::StructureStubInfo::initPutByIdReplace):
        * debugger/DebuggerActivation.cpp:
        (JSC::DebuggerActivation::DebuggerActivation):
        * debugger/DebuggerActivation.h:
        (JSC::DebuggerActivation::createStructure):
        * heap/Handle.h:
        * heap/MarkStack.cpp:
        (JSC::MarkStack::markChildren):
        (JSC::MarkStack::drain):
        * heap/MarkedBlock.cpp:
        (JSC::MarkedBlock::MarkedBlock):
        (JSC::MarkedBlock::sweep):
        * heap/Strong.h:
        (JSC::Strong::Strong):
        (JSC::Strong::set):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::resolveGlobal):
        (JSC::Interpreter::resolveGlobalDynamic):
        (JSC::Interpreter::tryCachePutByID):
        (JSC::Interpreter::uncachePutByID):
        (JSC::Interpreter::tryCacheGetByID):
        (JSC::Interpreter::uncacheGetByID):
        (JSC::Interpreter::privateExecute):
        * jit/JIT.h:
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::patchMethodCallProto):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdSelfList):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::patchMethodCallProto):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdSelfList):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITStubs.cpp:
        (JSC::JITThunks::tryCachePutByID):
        (JSC::JITThunks::tryCacheGetByID):
        (JSC::DEFINE_STUB_FUNCTION):
        (JSC::getPolymorphicAccessStructureListSlot):
        * jit/JSInterfaceJIT.h:
        (JSC::JSInterfaceJIT::storePtrWithWriteBarrier):
        * jsc.cpp:
        (cleanupGlobalData):
        * runtime/Arguments.h:
        (JSC::Arguments::createStructure):
        (JSC::Arguments::Arguments):
        (JSC::JSActivation::copyRegisters):
        * runtime/ArrayConstructor.cpp:
        (JSC::ArrayConstructor::ArrayConstructor):
        (JSC::constructArrayWithSizeQuirk):
        * runtime/ArrayConstructor.h:
        * runtime/ArrayPrototype.cpp:
        (JSC::ArrayPrototype::ArrayPrototype):
        (JSC::arrayProtoFuncSplice):
        * runtime/ArrayPrototype.h:
        (JSC::ArrayPrototype::createStructure):
        * runtime/BatchedTransitionOptimizer.h:
        (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
        * runtime/BooleanConstructor.cpp:
        (JSC::BooleanConstructor::BooleanConstructor):
        * runtime/BooleanConstructor.h:
        * runtime/BooleanObject.cpp:
        (JSC::BooleanObject::BooleanObject):
        * runtime/BooleanObject.h:
        (JSC::BooleanObject::createStructure):
        * runtime/BooleanPrototype.cpp:
        (JSC::BooleanPrototype::BooleanPrototype):
        * runtime/BooleanPrototype.h:
        * runtime/DateConstructor.cpp:
        (JSC::DateConstructor::DateConstructor):
        * runtime/DateConstructor.h:
        * runtime/DateInstance.cpp:
        (JSC::DateInstance::DateInstance):
        * runtime/DateInstance.h:
        (JSC::DateInstance::createStructure):
        * runtime/DatePrototype.cpp:
        (JSC::DatePrototype::DatePrototype):
        * runtime/DatePrototype.h:
        (JSC::DatePrototype::createStructure):
        * runtime/Error.cpp:
        (JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
        * runtime/ErrorConstructor.cpp:
        (JSC::ErrorConstructor::ErrorConstructor):
        * runtime/ErrorConstructor.h:
        * runtime/ErrorInstance.cpp:
        (JSC::ErrorInstance::ErrorInstance):
        (JSC::ErrorInstance::create):
        * runtime/ErrorInstance.h:
        (JSC::ErrorInstance::createStructure):
        * runtime/ErrorPrototype.cpp:
        (JSC::ErrorPrototype::ErrorPrototype):
        * runtime/ErrorPrototype.h:
        * runtime/ExceptionHelpers.cpp:
        (JSC::InterruptedExecutionError::InterruptedExecutionError):
        (JSC::TerminatedExecutionError::TerminatedExecutionError):
        * runtime/Executable.cpp:
        * runtime/Executable.h:
        (JSC::ExecutableBase::ExecutableBase):
        (JSC::ExecutableBase::createStructure):
        (JSC::NativeExecutable::createStructure):
        (JSC::NativeExecutable::NativeExecutable):
        (JSC::ScriptExecutable::ScriptExecutable):
        (JSC::EvalExecutable::createStructure):
        (JSC::ProgramExecutable::createStructure):
        (JSC::FunctionExecutable::createStructure):
        * runtime/FunctionConstructor.cpp:
        (JSC::FunctionConstructor::FunctionConstructor):
        * runtime/FunctionConstructor.h:
        * runtime/FunctionPrototype.cpp:
        (JSC::FunctionPrototype::FunctionPrototype):
        * runtime/FunctionPrototype.h:
        (JSC::FunctionPrototype::createStructure):
        * runtime/GetterSetter.h:
        (JSC::GetterSetter::GetterSetter):
        (JSC::GetterSetter::createStructure):
        * runtime/InitializeThreading.cpp:
        (JSC::initializeThreadingOnce):
        * runtime/InternalFunction.cpp:
        (JSC::InternalFunction::InternalFunction):
        * runtime/InternalFunction.h:
        (JSC::InternalFunction::createStructure):
        * runtime/JSAPIValueWrapper.h:
        (JSC::JSAPIValueWrapper::createStructure):
        (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::JSActivation):
        * runtime/JSActivation.h:
        (JSC::JSActivation::createStructure):
        * runtime/JSArray.cpp:
        (JSC::JSArray::JSArray):
        * runtime/JSArray.h:
        (JSC::JSArray::createStructure):
        * runtime/JSByteArray.cpp:
        (JSC::JSByteArray::JSByteArray):
        (JSC::JSByteArray::createStructure):
        * runtime/JSByteArray.h:
        (JSC::JSByteArray::JSByteArray):
        * runtime/JSCell.cpp:
        (JSC::isZombie):
        * runtime/JSCell.h:
        (JSC::JSCell::JSCell::JSCell):
        (JSC::JSCell::JSCell::addressOfStructure):
        (JSC::JSCell::JSCell::structure):
        (JSC::JSCell::JSCell::markChildren):
        (JSC::JSCell::JSValue::isZombie):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::JSFunction):
        * runtime/JSFunction.h:
        (JSC::JSFunction::createStructure):
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::storeVPtrs):
        (JSC::JSGlobalData::JSGlobalData):
        (JSC::JSGlobalData::clearBuiltinStructures):
        (JSC::JSGlobalData::createLeaked):
        * runtime/JSGlobalData.h:
        (JSC::allocateGlobalHandle):
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::reset):
        (JSC::JSGlobalObject::markChildren):
        (JSC::JSGlobalObject::copyGlobalsFrom):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::JSGlobalObject):
        (JSC::JSGlobalObject::createStructure):
        (JSC::Structure::prototypeChain):
        (JSC::Structure::isValid):
        (JSC::constructEmptyArray):
        * runtime/JSNotAnObject.h:
        (JSC::JSNotAnObject::JSNotAnObject):
        (JSC::JSNotAnObject::createStructure):
        * runtime/JSONObject.cpp:
        (JSC::JSONObject::JSONObject):
        * runtime/JSONObject.h:
        (JSC::JSONObject::createStructure):
        * runtime/JSObject.cpp:
        (JSC::JSObject::defineGetter):
        (JSC::JSObject::defineSetter):
        (JSC::JSObject::seal):
        (JSC::JSObject::freeze):
        (JSC::JSObject::preventExtensions):
        (JSC::JSObject::removeDirect):
        (JSC::JSObject::createInheritorID):
        * runtime/JSObject.h:
        (JSC::JSObject::createStructure):
        (JSC::JSObject::JSObject):
        (JSC::JSNonFinalObject::createStructure):
        (JSC::JSNonFinalObject::JSNonFinalObject):
        (JSC::JSFinalObject::create):
        (JSC::JSFinalObject::createStructure):
        (JSC::JSFinalObject::JSFinalObject):
        (JSC::constructEmptyObject):
        (JSC::createEmptyObjectStructure):
        (JSC::JSObject::~JSObject):
        (JSC::JSObject::setPrototype):
        (JSC::JSObject::setStructure):
        (JSC::JSObject::inheritorID):
        (JSC::JSObject::putDirectInternal):
        (JSC::JSObject::transitionTo):
        (JSC::JSObject::markChildrenDirect):
        * runtime/JSObjectWithGlobalObject.cpp:
        (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
        * runtime/JSObjectWithGlobalObject.h:
        (JSC::JSObjectWithGlobalObject::createStructure):
        (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
        * runtime/JSPropertyNameIterator.cpp:
        (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
        (JSC::JSPropertyNameIterator::create):
        (JSC::JSPropertyNameIterator::get):
        * runtime/JSPropertyNameIterator.h:
        (JSC::JSPropertyNameIterator::createStructure):
        (JSC::JSPropertyNameIterator::setCachedStructure):
        (JSC::Structure::setEnumerationCache):
        * runtime/JSStaticScopeObject.h:
        (JSC::JSStaticScopeObject::JSStaticScopeObject):
        (JSC::JSStaticScopeObject::createStructure):
        * runtime/JSString.h:
        (JSC::RopeBuilder::JSString):
        (JSC::RopeBuilder::createStructure):
        * runtime/JSType.h:
        * runtime/JSTypeInfo.h:
        (JSC::TypeInfo::TypeInfo):
        * runtime/JSValue.h:
        * runtime/JSVariableObject.h:
        (JSC::JSVariableObject::createStructure):
        (JSC::JSVariableObject::JSVariableObject):
        (JSC::JSVariableObject::copyRegisterArray):
        * runtime/JSWrapperObject.h:
        (JSC::JSWrapperObject::createStructure):
        (JSC::JSWrapperObject::JSWrapperObject):
        * runtime/JSZombie.cpp:
        * runtime/JSZombie.h:
        (JSC::JSZombie::JSZombie):
        (JSC::JSZombie::createStructure):
        * runtime/MathObject.cpp:
        (JSC::MathObject::MathObject):
        * runtime/MathObject.h:
        (JSC::MathObject::createStructure):
        * runtime/NativeErrorConstructor.cpp:
        (JSC::NativeErrorConstructor::NativeErrorConstructor):
        (JSC::NativeErrorConstructor::markChildren):
        * runtime/NativeErrorConstructor.h:
        (JSC::NativeErrorConstructor::createStructure):
        * runtime/NativeErrorPrototype.cpp:
        (JSC::NativeErrorPrototype::NativeErrorPrototype):
        * runtime/NativeErrorPrototype.h:
        * runtime/NumberConstructor.cpp:
        (JSC::NumberConstructor::NumberConstructor):
        * runtime/NumberConstructor.h:
        (JSC::NumberConstructor::createStructure):
        * runtime/NumberObject.cpp:
        (JSC::NumberObject::NumberObject):
        * runtime/NumberObject.h:
        (JSC::NumberObject::createStructure):
        * runtime/NumberPrototype.cpp:
        (JSC::NumberPrototype::NumberPrototype):
        * runtime/NumberPrototype.h:
        * runtime/ObjectConstructor.cpp:
        (JSC::ObjectConstructor::ObjectConstructor):
        * runtime/ObjectConstructor.h:
        (JSC::ObjectConstructor::createStructure):
        * runtime/ObjectPrototype.cpp:
        (JSC::ObjectPrototype::ObjectPrototype):
        * runtime/ObjectPrototype.h:
        * runtime/PropertyMapHashTable.h:
        (JSC::PropertyTable::PropertyTable):
        * runtime/RegExpConstructor.cpp:
        (JSC::RegExpConstructor::RegExpConstructor):
        (JSC::RegExpMatchesArray::RegExpMatchesArray):
        * runtime/RegExpConstructor.h:
        (JSC::RegExpConstructor::createStructure):
        * runtime/RegExpObject.cpp:
        (JSC::RegExpObject::RegExpObject):
        * runtime/RegExpObject.h:
        (JSC::RegExpObject::createStructure):
        * runtime/RegExpPrototype.cpp:
        (JSC::RegExpPrototype::RegExpPrototype):
        * runtime/RegExpPrototype.h:
        * runtime/ScopeChain.h:
        (JSC::ScopeChainNode::ScopeChainNode):
        (JSC::ScopeChainNode::createStructure):
        * runtime/StrictEvalActivation.cpp:
        (JSC::StrictEvalActivation::StrictEvalActivation):
        * runtime/StringConstructor.cpp:
        (JSC::StringConstructor::StringConstructor):
        * runtime/StringConstructor.h:
        * runtime/StringObject.cpp:
        (JSC::StringObject::StringObject):
        * runtime/StringObject.h:
        (JSC::StringObject::createStructure):
        * runtime/StringObjectThatMasqueradesAsUndefined.h:
        (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
        (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
        * runtime/StringPrototype.cpp:
        (JSC::StringPrototype::StringPrototype):
        * runtime/StringPrototype.h:
        (JSC::StringPrototype::createStructure):
        * runtime/Structure.cpp:
        (JSC::StructureTransitionTable::remove):
        (JSC::StructureTransitionTable::add):
        (JSC::Structure::Structure):
        (JSC::Structure::~Structure):
        (JSC::Structure::materializePropertyMap):
        (JSC::Structure::addPropertyTransitionToExistingStructure):
        (JSC::Structure::addPropertyTransition):
        (JSC::Structure::removePropertyTransition):
        (JSC::Structure::changePrototypeTransition):
        (JSC::Structure::despecifyFunctionTransition):
        (JSC::Structure::getterSetterTransition):
        (JSC::Structure::toDictionaryTransition):
        (JSC::Structure::toCacheableDictionaryTransition):
        (JSC::Structure::toUncacheableDictionaryTransition):
        (JSC::Structure::sealTransition):
        (JSC::Structure::freezeTransition):
        (JSC::Structure::preventExtensionsTransition):
        (JSC::Structure::flattenDictionaryStructure):
        (JSC::Structure::copyPropertyTable):
        (JSC::Structure::put):
        (JSC::Structure::markChildren):
        * runtime/Structure.h:
        (JSC::Structure::create):
        (JSC::Structure::setPrototypeWithoutTransition):
        (JSC::Structure::createStructure):
        (JSC::JSCell::createDummyStructure):
        (JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::keyForFinalizer):
        * runtime/StructureChain.cpp:
        (JSC::StructureChain::StructureChain):
        (JSC::StructureChain::markChildren):
        * runtime/StructureChain.h:
        (JSC::StructureChain::create):
        (JSC::StructureChain::head):
        (JSC::StructureChain::createStructure):
        * runtime/StructureTransitionTable.h:
        (JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::finalizerContextFor):
        (JSC::StructureTransitionTable::~StructureTransitionTable):
        (JSC::StructureTransitionTable::slot):
        (JSC::StructureTransitionTable::setMap):
        (JSC::StructureTransitionTable::singleTransition):
        (JSC::StructureTransitionTable::clearSingleTransition):
        (JSC::StructureTransitionTable::setSingleTransition):
        * runtime/WeakGCMap.h:
        (JSC::DefaultWeakGCMapFinalizerCallback::finalizerContextFor):
        (JSC::DefaultWeakGCMapFinalizerCallback::keyForFinalizer):
        (JSC::WeakGCMap::contains):
        (JSC::WeakGCMap::find):
        (JSC::WeakGCMap::remove):
        (JSC::WeakGCMap::add):
        (JSC::WeakGCMap::set):
        (JSC::WeakGCMap::finalize):
        * runtime/WriteBarrier.h:
        (JSC::writeBarrier):
        (JSC::WriteBarrierBase::set):
        (JSC::WriteBarrierBase::operator*):
        (JSC::WriteBarrierBase::operator->):
        (JSC::WriteBarrierBase::setWithoutWriteBarrier):
2011-04-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoff Garen.

        GC allocate Structure
        https://bugs.webkit.org/show_bug.cgi?id=58483

        Fix up JSG to correctly mark Structure, et al.

        * JSRun.cpp:
        (JSGlueGlobalObject::JSGlueGlobalObject):
        * JSRun.h:
        * JSUtils.cpp:
        (JSObjectKJSValue):
        * UserObjectImp.cpp:
        (UserObjectImp::UserObjectImp):
        * UserObjectImp.h:
        (UserObjectImp::createStructure):
2011-04-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoff Garen.

        GC allocate Structure
        https://bugs.webkit.org/show_bug.cgi?id=58483

        Update WebCore for Structure being a GC allocated object

        * WebCore.exp.in:
        * bindings/js/JSAudioConstructor.h:
        (WebCore::JSAudioConstructor::createStructure):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::cacheDOMStructure):
        * bindings/js/JSDOMBinding.h:
        (WebCore::DOMObjectWithGlobalPointer::createStructure):
        (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
        (WebCore::DOMConstructorObject::createStructure):
        (WebCore::DOMConstructorObject::DOMConstructorObject):
        (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
        (WebCore::JSDOMGlobalObject::markChildren):
        * bindings/js/JSDOMGlobalObject.h:
        (WebCore::JSDOMGlobalObject::createStructure):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::JSDOMWindowBase):
        * bindings/js/JSDOMWindowBase.h:
        (WebCore::JSDOMWindowBase::createStructure):
        * bindings/js/JSDOMWindowShell.cpp:
        (WebCore::JSDOMWindowShell::JSDOMWindowShell):
        (WebCore::JSDOMWindowShell::setWindow):
        * bindings/js/JSDOMWindowShell.h:
        (WebCore::JSDOMWindowShell::createStructure):
        * bindings/js/JSDOMWrapper.h:
        (WebCore::DOMObject::DOMObject):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::JSEventListener):
        * bindings/js/JSImageConstructor.h:
        (WebCore::JSImageConstructor::createStructure):
        * bindings/js/JSImageDataCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSOptionConstructor.h:
        (WebCore::JSOptionConstructor::createStructure):
        * bindings/js/JSWorkerContextBase.cpp:
        (WebCore::JSWorkerContextBase::JSWorkerContextBase):
        * bindings/js/JSWorkerContextBase.h:
        (WebCore::JSWorkerContextBase::createStructure):
        * bindings/js/ScriptCachedFrameData.h:
        * bindings/js/SerializedScriptValue.h:
        * bindings/js/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::initScript):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/c/CRuntimeObject.h:
        (JSC::Bindings::CRuntimeObject::createStructure):
        * bridge/c/c_instance.cpp:
        (JSC::Bindings::CRuntimeMethod::createStructure):
        * bridge/jni/jsc/JavaInstanceJSC.cpp:
        (JavaRuntimeMethod::createStructure):
        * bridge/jni/jsc/JavaRuntimeObject.h:
        (JSC::Bindings::JavaRuntimeObject::createStructure):
        * bridge/objc/ObjCRuntimeObject.h:
        (JSC::Bindings::ObjCRuntimeObject::createStructure):
        * bridge/objc/objc_instance.mm:
        (ObjCRuntimeMethod::createStructure):
        * bridge/objc/objc_runtime.h:
        (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
        * bridge/runtime_array.cpp:
        (JSC::RuntimeArray::RuntimeArray):
        * bridge/runtime_array.h:
        (JSC::RuntimeArray::createStructure):
        * bridge/runtime_method.cpp:
        (JSC::RuntimeMethod::RuntimeMethod):
        * bridge/runtime_method.h:
        (JSC::RuntimeMethod::createStructure):
        * bridge/runtime_object.cpp:
        (JSC::Bindings::RuntimeObject::RuntimeObject):
        * bridge/runtime_object.h:
        (JSC::Bindings::RuntimeObject::createStructure):
        * history/HistoryItem.h:
2011-04-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoff Garen.

        GC allocate Structure
        https://bugs.webkit.org/show_bug.cgi?id=58483

        Update WebKit for the world of GC allocated Structure

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyRuntimeMethod::createStructure):
        * Plugins/Hosted/ProxyRuntimeObject.h:
        (WebKit::ProxyRuntimeObject::createStructure):
2011-04-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoff Garen.

        GC allocate Structure
        https://bugs.webkit.org/show_bug.cgi?id=58483

        Update WK2 for the world of GC allocated Structure

        * WebProcess/Plugins/Netscape/JSNPMethod.h:
        (WebKit::JSNPMethod::createStructure):
        * WebProcess/Plugins/Netscape/JSNPObject.h:
        (WebKit::JSNPObject::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 14 Apr 2011 02:20:12 +0000 (02:20 +0000)]
2011-04-13  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        gdb-safari should pass arguments to safari.
        https://bugs.webkit.org/show_bug.cgi?id=58439

        We can do:
          gdb-safari --debug LayoutTests/.../foo.html

        * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 14 Apr 2011 02:14:08 +0000 (02:14 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.
        https://bugs.webkit.org/show_bug.cgi?id=52763

        r83799 broke test-webkitpy because it assumed we always have
        access to a real filesystem (we don't during the unit tests).
        Stubbing out the copy for now but we might need a better
        solution at some point.

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Cary Clark <caryclark@google.com>
commit-queue@webkit.org [Thu, 14 Apr 2011 02:13:31 +0000 (02:13 +0000)]
2011-04-13  Cary Clark  <caryclark@google.com>

        Reviewed by Eric Seidel.

        Allow CG Font support in Chrome Darwin build using Skia
        https://bugs.webkit.org/show_bug.cgi?id=58321

        This allows Chrome to use Skia to do WebKit rendering, while
        using CoreGraphics for glyph creation and computing font metrics.
        It relies on an undefined platform token, WTF_USE_SKIA_ON_MAC_CHROME.

        No new tests needed, no functionality change.

        * loader/cache/CachedFont.cpp: Make CGFontRef functions and
        CG-specific font code available to Chrome builds on Darwin using Skia.
        * platform/graphics/FontPlatformData.h: Ditto.
        (WebCore::FontPlatformData::hash): Ditto.
        * platform/graphics/GlyphBuffer.h: Ditto.
        (WebCore::GlyphBuffer::advanceAt): Ditto.
        (WebCore::GlyphBuffer::add): Ditto.
        (WebCore::GlyphBuffer::expandLastAdvance): Ditto.
        * platform/graphics/SimpleFontData.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Thu, 14 Apr 2011 01:47:26 +0000 (01:47 +0000)]
2011-04-13  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Dimitri Glazkov.

        The timeline of the video controls is unusable if the multimedia backend returns a
        infinite duration.
        https://bugs.webkit.org/show_bug.cgi?id=58452

        In case the underlaying media element backend returns crazy values, e.g.
        an infinite duration for the video we need to bail out and hide the timeline
        rather than in a broken state where you can't use it. The previous code was just
        checking if the duration was NaN.

        We can't control from JS what the backend will return as a duration for the video
        so we can't make an test for it.

        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Thu, 14 Apr 2011 01:41:34 +0000 (01:41 +0000)]
2011-04-13  Abhishek Arya  <inferno@chromium.org>

        Reviewed by James Robinson.

        Tests that iframe outline is drawn.
        https://bugs.webkit.org/show_bug.cgi?id=57439

        * fast/frames/iframe-outline.html: Added.
        * platform/mac/fast/frames/iframe-outline-expected.checksum: Added.
        * platform/mac/fast/frames/iframe-outline-expected.png: Added.
        * platform/mac/fast/frames/iframe-outline-expected.txt: Added.
2011-04-13  Abhishek Arya  <inferno@chromium.org>

        Reviewed by James Robinson.

        Draw outline for render widgets.
        https://bugs.webkit.org/show_bug.cgi?id=57439

        Test: fast/frames/iframe-outline.html

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 14 Apr 2011 01:39:01 +0000 (01:39 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change - remove tests that are no longer
        failing.

        * platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 14 Apr 2011 01:37:18 +0000 (01:37 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests --run-singly option is busted
        https://bugs.webkit.org/show_bug.cgi?id=55909

        Python's broken lexical scoping strikes again :(.

        * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 14 Apr 2011 01:24:48 +0000 (01:24 +0000)]
2011-04-13  Geoffrey Garen  <ggaren@apple.com>

        Try to fix ASSERTs seen on Windows bots.

        * wtf/HashTable.h:
        (WTF::hashTableSwap): Force MSVC to use the right version of swap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 14 Apr 2011 01:13:39 +0000 (01:13 +0000)]
2011-04-13  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        generated unexpected_results.html from unexpected_results.json
        https://bugs.webkit.org/show_bug.cgi?id=52763

        Eventually, we'll merge this with results.html and have a single richer results page.
        For now, I just want to get something checked in that we can iterate on.

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rebaseline 4 tests added as r83787.
jianli@chromium.org [Thu, 14 Apr 2011 01:12:39 +0000 (01:12 +0000)]
Unreviewed, rebaseline 4 tests added as r83787.

* platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
* platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
* platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
* platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
* platform/chromium-win/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
* platform/chromium-win/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
* platform/chromium-win/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
* platform/chromium-win/fast/ruby/before-table-doesnt-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 14 Apr 2011 01:12:01 +0000 (01:12 +0000)]
2011-04-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Up the failure limit to allow the commit-queue to actually land when the tree is red
        https://bugs.webkit.org/show_bug.cgi?id=58499

        This change increases the --exit-after-N-failures limit used by the commit-queue
        from 1 to 10.  This will cause the code added in bug 58494 to actually get
        exercised and the queues should start being able to land when the trees are red.

        When testing I found that test_runtests_leopard_commit_queue_hack_command was the
        only unit test to actually detect this change!  Since we don't actually
        run on leopard anymore, I removed the hack code and repurposed the test.

        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/steps/runtests.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 14 Apr 2011 01:11:46 +0000 (01:11 +0000)]
2011-04-13  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Change the representation of ShadowRoot nodes in render tree dumps
        https://bugs.webkit.org/show_bug.cgi?id=58432

        Show "#shadow-root" for ShadorRoot nodes instead of "#document-fragment"
        in DRT results.

        No new tests. This change doesn't affect existing tests yet.

        * dom/DocumentFragment.h:
          Make nodeName() protected in order that ShdowRoot can override it.
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::nodeName): Returns "#shadow-root".
        * dom/ShadowRoot.h: Declare nodeName().
        * rendering/RenderTreeAsText.cpp:
        (WebCore::nodePosition): Don't show "child N " if the node is a shadow boundary.
          We don't use isShadowRoot() here because the legacy shadow root nodes
          return true for isShadowRoot() and we don't want to update existing
          test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 14 Apr 2011 01:08:25 +0000 (01:08 +0000)]
2011-04-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue should be able to land when tree is red
        https://bugs.webkit.org/show_bug.cgi?id=58494

        There is some yak hair on my hands, I will admit.

        This change is mostly about adding an ExpectedFailures
        class to track when the bots are red and we should be
        ignoring failures when landing from the commit-queue.

        However, to make intelligent decisions about patches we
        need to know whether the run hit the --exit-after-N-failures limit
        or not.  Right now that information is not saved off in results.html
        so we have to pull the information from RunTests.

        I've plumbed the --exit-after-N-failures information into
        LayoutTestResults for now to make the ExpectedFailures code cleaner.

        As a result of adding all these additional calls to delegate.layout_test_results()
        I broke some of our flaky test detection tests and had to re-write them
        to not depend on the number of layout_test_results code.

        At the same time I updated the commit-queue to use the newer filesystem
        API (to allow us to use MockFileSystem) which required further changes
        to the layout tests.  Changes were required in either case, since
        we're now calling layout_test_results() in more cases, which previously
        would try and hit the disk (until I moved it to use tool.filesystem).

        I should note that *all* of this code is disabled for now, since our
        --exit-after-N-failures limit is currently 1!  (Thus were always in the
        case where we can't actually tell if the layout test results are legit.)
        I will up that limit in a second patch (which may require a couple more unit test tweaks).

        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
        * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/queuestest.py:
        * Scripts/webkitpy/tool/steps/runtests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 14 Apr 2011 00:58:40 +0000 (00:58 +0000)]
2011-04-13  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Merge LineOffsets and LineWidth
        https://bugs.webkit.org/show_bug.cgi?id=58411

        Merged lineOffsets into LineWidth.

        After this patch, available width is updated in positionNewFloatOnLine via updateAvailableWidth and
        shrinkAvailableWidthForNewFloatIfNeeded instead of findNextBreak. This is correct because
        - LineOffsets::update and LineOffsets::shrinkWidthForNewFloatIfNeeded were only called in positionNewFloatOnLine
          besides LineOffsets' constructor
        - positionNewFloatOnLine was only called in skipLeadingWhitespace and findNextLineBreak
        - findNextLineBreak updates the available width whenever it calls skipLeadingWhitespace or positionNewFloatOnLine

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineWidth instead of LineOffset
        (WebCore::LineWidth::LineWidth): Takes RenderBlock* and boolean isFirstLine; call updateAvailableWidth
        because the initial available width was used to be computed from lineOffsets.width().
        (WebCore::LineWidth::computeAvailableWidthFromLeftAndRight): Added.
        (WebCore::LineWidth::updateAvailableWidth): Renamed from LineOffsets::update; this function now updates
        m_availableWidth via computeAvailableWidthFromLeftAndRight as well as m_left and m_right.
        (WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Renamed from
        LineOffsets::shrinkWidthForNewFloatIfNeeded. This function also calls computeAvailableWidthFromLeftAndRight.
        (WebCore::LineWidth::applyOverhang): No longer takes arguments since both arguments were member variables
        of LineOffsets.
        (WebCore::LineWidth::fitBelowFloats): No longer takes isFirstLine.
        (WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
        (WebCore::RenderBlock::positionNewFloatOnLine): Takes a reference to LineWidth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build correction.
bfulgham@webkit.org [Thu, 14 Apr 2011 00:45:39 +0000 (00:45 +0000)]
Unreviewed build correction.

* TestWebKitAPI/PlatformWebView.h: Limit include of
  <CoreGraphics/CGGeometry> to PLATFORM(CG) users.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Thu, 14 Apr 2011 00:44:38 +0000 (00:44 +0000)]
2011-04-13  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMAKE] Separate DerivedSources.
        https://bugs.webkit.org/show_bug.cgi?id=58427

        Seperate DerivedSources/ to DerivedSources/WebCore and
        DerivedSources/JavaScriptCore.

        * Source/CMakeLists.txt:
        * Source/cmake/OptionsCommon.cmake:
        * Source/cmake/WebKitFS.cmake:
        * Source/cmake/WebKitHelpers.cmake:
        * Source/cmake/WebKitMacros.cmake:
2011-04-13  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMAKE] Separate DerivedSources.
        https://bugs.webkit.org/show_bug.cgi?id=58427

        * CMakeLists.txt: Change DERIVED_SOURCES_DIR to DERIVED_SOURCES_JAVASCRIPTCORE_DIR.
2011-04-13  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMAKE] Separate DerivedSources.
        https://bugs.webkit.org/show_bug.cgi?id=58427

        No new tests since these are refactoring only.

        * CMakeLists.txt:
        * UseJSC.cmake:
2011-04-13  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMAKE] Separate DerivedSources.
        https://bugs.webkit.org/show_bug.cgi?id=58427

        * CMakeLists.txt: Change DERIVED_SOURCES_DIR to DERIVED_SOURCES_WEBCORE_DIR

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixing burning chromium mac tree.
mdelaney@apple.com [Thu, 14 Apr 2011 00:36:03 +0000 (00:36 +0000)]
Fixing burning chromium mac tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Thu, 14 Apr 2011 00:25:05 +0000 (00:25 +0000)]
2011-04-13  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Kenneth Russell.

        [chromium] Fix canvas.toDataURL mimeType assertion
        https://bugs.webkit.org/show_bug.cgi?id=58425

        Following r81213, reassert expected toDataURL() mimeType, remove an unused variable.

        No new tests. Covered by existing tests.

        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageToDataURL):
        (WebCore::ImageBuffer::toDataURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 13 Apr 2011 23:54:30 +0000 (23:54 +0000)]
2011-04-13  Tony Chang  <tony@chromium.org>

        Ignore files generated from glu.gyp.

        * .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
luiz@webkit.org [Wed, 13 Apr 2011 23:54:03 +0000 (23:54 +0000)]
[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
https://bugs.webkit.org/show_bug.cgi?id=58375

Reviewed by Andreas Kling.

As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.

Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 13 Apr 2011 23:52:15 +0000 (23:52 +0000)]
2011-04-13  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by David Hyatt.

        Bug 55930 - Incorrect handling of 'display:' property within nested <ruby> tags
        https://bugs.webkit.org/show_bug.cgi?id=55930

        Test that 'display: block' and 'display: table' on generated :before/:after content
        within <ruby> doesn't crash.

        * fast/ruby/after-block-doesnt-crash-expected.txt: Added.
        * fast/ruby/after-block-doesnt-crash.html: Added.
        * fast/ruby/after-table-doesnt-crash-expected.txt: Added.
        * fast/ruby/after-table-doesnt-crash.html: Added.
        * fast/ruby/before-block-doesnt-crash-expected.txt: Added.
        * fast/ruby/before-block-doesnt-crash.html: Added.
        * fast/ruby/before-table-doesnt-crash-expected.txt: Added.
        * fast/ruby/before-table-doesnt-crash.html: Added.
2011-04-13  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by David Hyatt.

        Bug 55930 - Incorrect handling of 'display:' property within nested <ruby> tags
        https://bugs.webkit.org/show_bug.cgi?id=55930

        Non-inline :before/:after generated content is now wrapped with an anonymous inline block.

        Also, added an additional check in RenderObjectChildList::updateBeforeAfterContent()
        to verify that the created render object is legal under the parent.

        Tests: fast/ruby/after-block-doesnt-crash.html
               fast/ruby/after-table-doesnt-crash.html
               fast/ruby/before-block-doesnt-crash.html
               fast/ruby/before-table-doesnt-crash.html

        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::updateBeforeAfterContent):
        * rendering/RenderRuby.cpp:
        (WebCore::isAnonymousRubyInlineBlock):
        (WebCore::rubyBeforeBlock):
        (WebCore::rubyAfterBlock):
        (WebCore::createAnonymousRubyInlineBlock):
        (WebCore::lastRubyRun):
        (WebCore::RenderRubyAsInline::addChild):
        (WebCore::RenderRubyAsInline::removeChild):
        (WebCore::RenderRubyAsBlock::addChild):
        (WebCore::RenderRubyAsBlock::removeChild):
        * rendering/RenderRuby.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Wed, 13 Apr 2011 23:49:40 +0000 (23:49 +0000)]
2011-04-13  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        [CG] Refactor get/putImageData routines from ImageBufferCG into a (new) ImageBufferDataCG.cpp
        https://bugs.webkit.org/show_bug.cgi?id=58084

        No new tests. Does not affect outward behavior.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/ImageBufferData.h: Added.
        * platform/graphics/cairo/ImageBufferData.h: Removed.
        * platform/graphics/cairo/ImageBufferDataCairo.h: Added.
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::getUnmultipliedImageData):
        (WebCore::ImageBuffer::getPremultipliedImageData):
        (WebCore::ImageBuffer::putUnmultipliedImageData):
        (WebCore::ImageBuffer::putPremultipliedImageData):
        * platform/graphics/cg/ImageBufferDataCG.cpp: Added.
        (WebCore::ImageBufferData::ImageBufferData):
        (WebCore::haveVImageRoundingErrorFix):
        (WebCore::ImageBufferData::getData):
        (WebCore::ImageBufferData::putData):
        * platform/graphics/cg/ImageBufferData.h: Removed.
        * platform/graphics/cg/ImageBufferDataCG.h: Added.
        * platform/graphics/chromium/ImageBufferData.h: Removed.
        * platform/graphics/chromium/ImageBufferDataSkia.h: Added.
        * platform/graphics/haiku/ImageBufferData.h: Removed.
        * platform/graphics/haiku/ImageBufferDataHaiku.h: Added.
        * platform/graphics/qt/ImageBufferData.h: Removed.
        * platform/graphics/qt/ImageBufferDataQt.h: Added.
        * platform/graphics/wince/ImageBufferData.h: Removed.
        * platform/graphics/wince/ImageBufferDataWince.h: Added.
        * platform/graphics/wx/ImageBufferData.h: Removed.
        * platform/graphics/wx/ImageBufferDataWx.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Wed, 13 Apr 2011 23:36:35 +0000 (23:36 +0000)]
2011-04-13  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Chris Marrin.

        Update layout test expected result files' locations
        https://bugs.webkit.org/show_bug.cgi?id=58492

        * platform/mac-snowleopard/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.miter.lineedge-expected.txt.
        * platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt.
        * platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.shadow.enable.x-expected.txt.
        * platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.shadow.enable.y-expected.txt.
        * platform/mac/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 13 Apr 2011 23:33:08 +0000 (23:33 +0000)]
2011-04-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Remove std:: prefix on some min/max calls
        https://bugs.webkit.org/show_bug.cgi?id=58493

        Remove std:: namespacing on min/max in favor of a 'using' clause.

        * platform/graphics/RoundedIntRect.cpp:
        (WebCore::RoundedIntRect::Radii::expand):
        * rendering/style/RenderStyle.cpp:
        (WebCore::calcConstraintScaleFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 13 Apr 2011 23:04:01 +0000 (23:04 +0000)]
2011-04-13  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
        https://bugs.webkit.org/show_bug.cgi?id=58489

        r83743 added --additional-platform-directory to old-run-webkit-tests,
        rename the equivalent flag in new-run-webkit-tests to be consistent.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Wed, 13 Apr 2011 23:03:34 +0000 (23:03 +0000)]
2011-04-13  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Jian Li.

        [chromium] Remove unnecessary #define now that chrome has rolled to the latest WebKit
        https://bugs.webkit.org/show_bug.cgi?id=58474

        * DEPS:
        * public/WebSpellCheckClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 13 Apr 2011 22:54:25 +0000 (22:54 +0000)]
2011-04-13  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        Rebaseline queue server
        https://bugs.webkit.org/show_bug.cgi?id=57891

        Adds a simple rebaseline queue server (meant to run at
        http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
        builders and their failing tests, and allows those tests to be added to
        a per-builer rebaseline queue.

        A subsequent change will add a mode to NRWT (and/or a wrapper script)
        for pulling the tests to be rebaselined from the server and running them
        with --reset-results (the initial use-case is for the GPU hardware bots,
        which do not have checked-in baselines, therefore there is no need for a
        check-in step yet).

        * RebaselineQueueServer/app.yaml: Added.
        * RebaselineQueueServer/handlers/__init__.py: Added.
        * RebaselineQueueServer/handlers/builderqueue.py: Added.
        * RebaselineQueueServer/handlers/pages.py: Added.
        * RebaselineQueueServer/index.yaml: Added.
        * RebaselineQueueServer/main.py: Added.
        * RebaselineQueueServer/model/__init__.py: Added.
        * RebaselineQueueServer/model/queueentry.py: Added.
        * RebaselineQueueServer/static/builder-frame-empty.html: Added.
        * RebaselineQueueServer/static/styles.css: Added.
        * RebaselineQueueServer/templates/builder-picker.html: Added.
        * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
        * RebaselineQueueServer/templates/builder-queue-list.html: Added.
        * RebaselineQueueServer/templates/home.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, more chromium test expectations update.
jianli@chromium.org [Wed, 13 Apr 2011 22:52:23 +0000 (22:52 +0000)]
Unreviewed, more chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 13 Apr 2011 22:45:36 +0000 (22:45 +0000)]
2011-04-13  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        Replace our own RenderThemeQt::getMediaElementFromRenderObject by
        MediaControlsElement::toParentMediaElement used by every other port.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintMediaFullscreenButton):
        (WebCore::RenderThemeQt::paintMediaMuteButton):
        (WebCore::RenderThemeQt::paintMediaPlayButton):
        (WebCore::RenderThemeQt::paintMediaSliderTrack):
        * platform/qt/RenderThemeQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShould not rely on WKEditableLinkBehavior being in synch
enrica@apple.com [Wed, 13 Apr 2011 22:40:10 +0000 (22:40 +0000)]
Should not rely on WKEditableLinkBehavior being in synch
with WebCore::EditableLinkBehavior.
https://bugs.webkit.org/show_bug.cgi?id=58473

Reviewed by Dan Bernstein.

Adding conversion routines.

* UIProcess/API/C/WKAPICast.h:
(WebKit::toAPI):
(WebKit::toEditableLinkBehavior):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetEditableLinkBehavior):
(WKPreferencesGetEditableLinkBehavior):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 13 Apr 2011 22:38:23 +0000 (22:38 +0000)]
2011-04-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        After closing the last window, re-opening my last visited website is over 2X slower
        https://bugs.webkit.org/show_bug.cgi?id=58488
        <rdar://problem/9233518>

        Give the web process a 60 second termination timeout.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::WebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoinspector/debugger/script-formatter.html broken on a bunch of platforms since introdu...
jberlin@webkit.org [Wed, 13 Apr 2011 22:29:04 +0000 (22:29 +0000)]
inspector/debugger/script-formatter.html broken on a bunch of platforms since introduction
in r83748
https://bugs.webkit.org/show_bug.cgi?id=58487

Disable the test until it is fixed to get the bots green.

* inspector/debugger/script-formatter.html: Removed.
* inspector/debugger/script-formatter.html-disabled: Copied from inspector/debugger/script-formatter.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 13 Apr 2011 22:24:44 +0000 (22:24 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change / build fix. The file had
        multiple checksums which confused NRWT.

        * platform/mac/compositing/framesets/composited-frame-alignment-expected.checksum:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 13 Apr 2011 22:24:28 +0000 (22:24 +0000)]
2011-04-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Convert WebProcess over to using disableTermination/enableTermination
        https://bugs.webkit.org/show_bug.cgi?id=58485

        * PluginProcess/PluginProcess.cpp:
        (WebKit::PluginProcess::getSitesWithData):
        (WebKit::PluginProcess::clearSiteData):
        Use the LocalTerminationDisabler RAII class.

        * Shared/ChildProcess.h:
        (WebKit::ChildProcess::LocalTerminationDisabler::LocalTerminationDisabler):
        (WebKit::ChildProcess::LocalTerminationDisabler::~LocalTerminationDisabler):
        Add RAII class for calling disableTermination/enableTermination.

        * WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
        (WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
        (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
        (WebKit::WebApplicationCacheManager::deleteAllEntries):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/Cookies/WebCookieManager.cpp:
        (WebKit::WebCookieManager::getHostnamesWithCookies):
        (WebKit::WebCookieManager::deleteCookiesForHostname):
        (WebKit::WebCookieManager::deleteAllCookies):
        (WebKit::WebCookieManager::startObservingCookieChanges):
        (WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
        (WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/Downloads/Download.cpp:
        (WebKit::Download::Download):
        Call disableTermination().

        (WebKit::Download::~Download):
        Call enableTermination().

        * WebProcess/Downloads/DownloadManager.cpp:
        (WebKit::DownloadManager::downloadFinished):
        Remove call to terminateIfPossible.

        * WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
        (WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
        (WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
        (WebKit::WebKeyValueStorageManager::deleteAllEntries):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/MediaCache/WebMediaCacheManager.cpp:
        (WebKit::WebMediaCacheManager::getHostnamesWithMediaCache):
        (WebKit::WebMediaCacheManager::clearCacheForHostname):
        (WebKit::WebMediaCacheManager::clearCacheForAllHostnames):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/ResourceCache/WebResourceCacheManager.cpp:
        (WebKit::WebResourceCacheManager::getCacheOrigins):
        (WebKit::WebResourceCacheManager::clearCacheForOrigin):
        (WebKit::WebResourceCacheManager::clearCacheForAllOrigins):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
        (WebKit::WebDatabaseManager::getDatabasesByOrigin):
        (WebKit::WebDatabaseManager::getDatabaseOrigins):
        (WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
        (WebKit::WebDatabaseManager::deleteDatabasesForOrigin):
        (WebKit::WebDatabaseManager::deleteAllDatabases):
        (WebKit::WebDatabaseManager::setQuotaForOrigin):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::createWebPage):
        Call disableTermination().

        (WebKit::WebProcess::removeWebPage):
        Call enableTermination().

        (WebKit::WebProcess::shouldTerminate):
        Move logic from terminateIfPossible over here.

        (WebKit::WebProcess::terminate):
        Move logic from terminateIfPossible over here.

        (WebKit::WebProcess::getSitesWithPluginData):
        (WebKit::WebProcess::clearPluginSiteData):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/WebProcess.h:
        Publically inherit from ChildProcess, LocalTerminationDisabler needs to be accessible
        from the WebProcess class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 13 Apr 2011 22:15:28 +0000 (22:15 +0000)]
2011-04-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Switched DOM wrappers to use HashMap of Weak<T> instead of WeakGCMap<T>
        https://bugs.webkit.org/show_bug.cgi?id=58482

        This will allow wrappers to make individual decisions about their lifetimes.

        * heap/HandleHeap.h:
        (JSC::HandleHeap::copyWeak): New function for copying a weak handle.
        It's wasn't previously possible to perform this operation using HandleHeap
        API because the HandleHeap doesn't expose its underlying Node structure.

        * heap/Local.h:
        (JSC::::set):
        * heap/Strong.h:
        (JSC::Strong::set): Added ASSERTs to verify that dead objects are not
        resurrected by placement into handles.

        (JSC::swap): Added a swap helper, so use of Strong<T> inside a hash table
        is efficient.

        * heap/Weak.h:
        (JSC::Weak::Weak): Fixed a bug where copying a weak pointer would not
        copy its weak callback and context.

        (JSC::Weak::operator=): Added an assignment operator, since the default
        C++ assignment operator did the wrong thing.

        (JSC::Weak::set): Added ASSERTs to verify that dead objects are not
        resurrected by placement into handles.

        (JSC::swap): Added a swap helper, so use of Strong<T> inside a hash table
        is efficient, and can be done without copying, which is illegal during
        the handle finalization phase.
2011-04-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Switched DOM wrappers to use HashMap of Weak<T> instead of WeakGCMap<T>
        https://bugs.webkit.org/show_bug.cgi?id=58482

        This will allow wrappers to make individual decisions about their lifetimes.

        * bindings/js/DOMWrapperWorld.cpp:
        (WebCore::DOMWrapperWorld::DOMWrapperWorld):
        (WebCore::JSNodeHandleOwner::isReachableFromOpaqueRoots):
        (WebCore::JSNodeHandleOwner::finalize):
        (WebCore::DOMObjectHandleOwner::isReachableFromOpaqueRoots):
        (WebCore::DOMObjectHandleOwner::finalize):
        * bindings/js/DOMWrapperWorld.h:
        (WebCore::JSNodeHandleOwner::JSNodeHandleOwner):
        (WebCore::DOMObjectHandleOwner::DOMObjectHandleOwner):
        (WebCore::DOMWrapperWorld::jsNodeHandleOwner):
        (WebCore::DOMWrapperWorld::domObjectHandleOwner): Added handle owners
        for JSNode and DOMObject, our two hash table values. For now, the owners
        just take care to remove their handles from their respective hash tables.

        Changed the hash table type to be a standard HashMap of weak pointers,
        instead of a WeakGCMap.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::getCachedDOMObjectWrapper):
        (WebCore::cacheDOMObjectWrapper):
        (WebCore::cacheDOMNodeWrapper):
        (WebCore::isObservableThroughDOM):
        (WebCore::markDOMNodesForDocument):
        (WebCore::takeWrappers):
        (WebCore::updateDOMNodeDocument):
        (WebCore::markDOMObjectWrapper):
        (WebCore::markDOMNodeWrapper): Updated wrapper hash table access to
        accomodate its new data type.

        * bindings/js/JSNodeCustom.h:
        (WebCore::getCachedDOMNodeWrapper): Ditto.

        * dom/Document.h: Updated declaration to match the above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 13 Apr 2011 22:11:30 +0000 (22:11 +0000)]
2011-04-13  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Follow-up to: WebKit2 will load two copies of the same plugin, but should not
        https://bugs.webkit.org/show_bug.cgi?id=49075

        Use pathGetFileName instead of Win32 PathFindFileNameW.

        * UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
        (WebKit::PluginInfoStore::shouldUsePlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Mac builds.
weinig@apple.com [Wed, 13 Apr 2011 21:50:57 +0000 (21:50 +0000)]
Fix Mac builds.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2 doesn't keep overlay scrollers shown while scroll gesture held
weinig@apple.com [Wed, 13 Apr 2011 21:39:12 +0000 (21:39 +0000)]
WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
<rdar://problem/9260518>

Reviewed by Gavin Barraclough.

Source/WebCore:

Notify the scrollbar painter controller when gesture scrolls begin and end.

* WebCore.exp.in:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::endScrollGesture):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Initialize new WKSI functions.

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Initialize new WKSI functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 13 Apr 2011 21:38:21 +0000 (21:38 +0000)]
2011-04-13  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Oliver Hunt.

        WebKit2 will load two copies of the same plugin, but should not
        https://bugs.webkit.org/show_bug.cgi?id=49075
        <rdar://problem/8635947>

        * UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
        (WebKit::PluginInfoStore::shouldUsePlugin): Don't use a plug-in if we've already allowed a plug-in with the same filename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHide the dictionary panel when navigating or crashing.
timothy@apple.com [Wed, 13 Apr 2011 21:31:35 +0000 (21:31 +0000)]
Hide the dictionary panel when navigating or crashing.

<rdar://problem/9261202>

Reviewed by Sam Weinig.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::dismissDictionaryLookupPanel): Added. Call WKHideWordDefinitionWindow.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame): Call PageClient::dismissDictionaryLookupPanel.
(WebKit::WebPageProxy::processDidCrash): Call dismissCorrectionPanel and PageClient::dismissDictionaryLookupPanel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 13 Apr 2011 21:29:36 +0000 (21:29 +0000)]
2011-04-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Add support for disabling/enabling termination to ChildProcess
        https://bugs.webkit.org/show_bug.cgi?id=58476

        Add ChildProcess::disableTermination and ChildProcess::enableTermination and convert
        the PluginProcess class over to using them.

        * PluginProcess/PluginProcess.cpp:
        (WebKit::PluginProcess::PluginProcess):
        The child process now takes a terminationTimeout argument. Get rid of the shutdown timer.

        (WebKit::PluginProcess::removeWebProcessConnection):
        Call enableTermination().

        (WebKit::PluginProcess::shouldTerminate):
        Always return true.

        (WebKit::PluginProcess::createWebProcessConnection):
        Call disableTermination().

        (WebKit::PluginProcess::getSitesWithData):
        Call disableTermination()/enableTermination().

        (WebKit::PluginProcess::clearSiteData):
        Ditto.

        * Shared/ChildProcess.cpp:
        (WebKit::ChildProcess::disableTermination):
        Increment the counter and stop the timer.

        (WebKit::ChildProcess::enableTermination):
        Decrement the counter; if it's zero, start the timer.

        (WebKit::ChildProcess::terminationTimerFired):
        Call shouldTerminate(). If it returns true, call terminate().

        (WebKit::ChildProcess::terminate):
        Call RunLoop::quit().

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::WebProcess):
        Just initialize the termination timeout to 0 for now.

        (WebKit::WebProcess::shouldTerminate):
        Always return true; this isn't used yet.

        * WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION: Links are clickable when a contentEditable is set to true.
enrica@apple.com [Wed, 13 Apr 2011 21:26:45 +0000 (21:26 +0000)]
REGRESSION: Links are clickable when a contentEditable is set to true.
https://bugs.webkit.org/show_bug.cgi?id=58473
<rdar://problem/9256793>

Reviewed by Dan Bernstein.

Added support for editable link behavior property.

* Shared/WebPreferencesStore.cpp:
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetEditableLinkBehavior):
(WKPreferencesGetEditableLinkBehavior):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 13 Apr 2011 21:24:17 +0000 (21:24 +0000)]
2011-04-13  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Maciej Stachowiak.

        MediaPlayerPrivateAVFoundationObjC should adopt [AVURLAsset isPlayableExtendedMIMEType:]
        https://bugs.webkit.org/show_bug.cgi?id=58451
        <rdar://problem/9278468>

        No new tests, supported MIME types haven't changed.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType): Use
        [AVURLAsset isPlayableExtendedMIMEType] instead of just the list of types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 13 Apr 2011 21:22:49 +0000 (21:22 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        nrwt: enable multiple processes by default on Chromium Win.
        https://bugs.webkit.org/show_bug.cgi?id=55163

        Re-land r79268; it should be more stable now and will hopefully
        work.

        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 13 Apr 2011 21:11:18 +0000 (21:11 +0000)]
2011-04-13  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Alexey Proskuryakov.

        Media engine fallback doesn't always work
        https://bugs.webkit.org/show_bug.cgi?id=58462

        No new tests, this was verified manually with the url noted in the bug.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::networkStateChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 13 Apr 2011 21:08:45 +0000 (21:08 +0000)]
2011-04-13  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Extension3D needs to provide a way to check if an extension is enabled
        https://bugs.webkit.org/show_bug.cgi?id=58410

        Implement isEnabled() in chromium port.

        * src/Extensions3DChromium.cpp:
        (WebCore::Extensions3DChromium::isEnabled):
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::isExtensionEnabled):
        * src/GraphicsContext3DInternal.h:
2011-04-13  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Extension3D needs to provide a way to check if an extension is enabled
        https://bugs.webkit.org/show_bug.cgi?id=58410

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::setupFlags): Use isEnabled() instead of supports().
        * platform/graphics/Extensions3D.h: Add isEnabled().
        * platform/graphics/chromium/Extensions3DChromium.h: Ditto.
        * platform/graphics/opengl/Extensions3DOpenGL.cpp: Ditto.
        (WebCore::Extensions3DOpenGL::isEnabled):
        * platform/graphics/opengl/Extensions3DOpenGL.h: Ditto.
        * platform/graphics/qt/Extensions3DQt.cpp: Ditto.
        (WebCore::Extensions3DQt::isEnabled):
        * platform/graphics/qt/Extensions3DQt.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, update chromium test expectations per change in r83756.
jianli@chromium.org [Wed, 13 Apr 2011 21:04:36 +0000 (21:04 +0000)]
Unreviewed, update chromium test expectations per change in r83756.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 13 Apr 2011 21:01:08 +0000 (21:01 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: configure logging in child processes properly
        https://bugs.webkit.org/show_bug.cgi?id=58296

        Logging propagated properly from manager to worker processes on
        Unix but not on Windows; this fixes that.

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 13 Apr 2011 20:58:13 +0000 (20:58 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: suppress extraneous pretty patch warnings
        https://bugs.webkit.org/show_bug.cgi?id=58295

        NRWT wasn't being careful about when it logged messages from
        PrettyPatch not being available; it should only log during
        check_build(), and be silent otherwise. This was causing us to
        get multiple errors at runtime, which was confusing.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, update chromium test expectations to work around a bug
jianli@chromium.org [Wed, 13 Apr 2011 20:37:30 +0000 (20:37 +0000)]
Unreviewed, update chromium test expectations to work around a bug
in gpu test expectations handling.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, update chromium test expectations.
jianli@chromium.org [Wed, 13 Apr 2011 20:13:50 +0000 (20:13 +0000)]
Unreviewed, update chromium test expectations.

Mark compositing/webgl/webgl-reflection.html as failed for all platforms
in chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 13 Apr 2011 20:11:41 +0000 (20:11 +0000)]
2011-04-12  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        compositing/objects/composited-object-alignment.html causing failures in other tests since its introduction in r83518
        https://bugs.webkit.org/show_bug.cgi?id=58323

        Got rid of unnecessary JS from composited-subframe.html. This was mistakenly left in from previous experiments.
        Also moved pixel results to be platform specific. These are for Mac WebKit and WebKit2. There are color diffs
        between the two platforms, so I will make them all platform specific.

        * compositing/framesets/composited-frame-alignment-expected.checksum: Removed.
        * compositing/framesets/composited-frame-alignment-expected.png: Removed.
        * compositing/objects/composited-object-alignment-expected.checksum: Removed.
        * compositing/objects/composited-object-alignment-expected.png: Removed.
        * compositing/objects/resources/composited-subframe.html:
        * platform/mac-wk2/compositing: Added.
        * platform/mac-wk2/compositing/framesets: Added.
        * platform/mac-wk2/compositing/framesets/composited-frame-alignment-expected.checksum: Added.
        * platform/mac-wk2/compositing/framesets/composited-frame-alignment-expected.png: Added.
        * platform/mac-wk2/compositing/objects: Added.
        * platform/mac-wk2/compositing/objects/composited-object-alignment-expected.checksum: Added.
        * platform/mac-wk2/compositing/objects/composited-object-alignment-expected.png: Added.
        * platform/mac/compositing/framesets: Added.
        * platform/mac/compositing/framesets/composited-frame-alignment-expected.checksum: Added.
        * platform/mac/compositing/framesets/composited-frame-alignment-expected.png: Added.
        * platform/mac/compositing/objects: Added.
        * platform/mac/compositing/objects/composited-object-alignment-expected.checksum: Copied from LayoutTests/compositing/objects/composited-object-alignment-expected.checksum.
        * platform/mac/compositing/objects/composited-object-alignment-expected.png: Copied from LayoutTests/compositing/objects/composited-object-alignment-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
ddkilzer@apple.com [Wed, 13 Apr 2011 19:30:34 +0000 (19:30 +0000)]
<webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm

Reviewed by Anders Carlsson.

Fixes the following warning with -Wcast-align enabled:

    Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
                 archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

* Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage isNativeLibraryData:]): Added
COMPILE_ASSERT() to make sure our pointer math is valid.
Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
by sizeof(uint32_t) to fix the pointer math.  Replaced C-style
casts with reinterpret_cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExclude webkitGetUserMedia from the navigator-detached-no-crash test.
jianli@chromium.org [Wed, 13 Apr 2011 19:08:02 +0000 (19:08 +0000)]
Exclude webkitGetUserMedia from the navigator-detached-no-crash test.
https://bugs.webkit.org/show_bug.cgi?id=58459

Patch by Leandro Gracia Gil <leandrogracia@chromium.org> on 2011-04-13
Reviewed by Jian Li.

Exclude the MediaStream API methods from the test until the feature
is supported by most platforms.

* fast/dom/navigator-detached-no-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rebaseline 2 tests for linux64 in chromium.
jianli@chromium.org [Wed, 13 Apr 2011 18:58:42 +0000 (18:58 +0000)]
Unreviewed, rebaseline 2 tests for linux64 in chromium.

* platform/chromium-linux-x86_64/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
* platform/chromium-linux-x86_64/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 13 Apr 2011 18:52:26 +0000 (18:52 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Jian Li.

        add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=58461

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 13 Apr 2011 18:48:22 +0000 (18:48 +0000)]
2011-04-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make PropertyMapEntry use a WriteBarrier for specificValue
        https://bugs.webkit.org/show_bug.cgi?id=58407

        Make PropertyMapEntry use a WriteBarrier for specificValue, and then
        propagate the required JSGlobalData through all the methods it ends
        up being needed.

        * API/JSClassRef.cpp:
        (OpaqueJSClass::prototype):
        * API/JSContextRef.cpp:
        * API/JSObjectRef.cpp:
        (JSObjectMake):
        (JSObjectSetPrototype):
        * JavaScriptCore.exp:
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::BytecodeGenerator):
        * interpreter/Interpreter.cpp:
        (JSC::appendSourceToError):
        (JSC::Interpreter::tryCacheGetByID):
        (JSC::Interpreter::privateExecute):
        * jit/JITStubs.cpp:
        (JSC::JITThunks::tryCacheGetByID):
        (JSC::DEFINE_STUB_FUNCTION):
        * runtime/BatchedTransitionOptimizer.h:
        (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
        * runtime/InternalFunction.cpp:
        (JSC::InternalFunction::name):
        (JSC::InternalFunction::displayName):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::getOwnPropertySlot):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::name):
        (JSC::JSFunction::displayName):
        (JSC::JSFunction::getOwnPropertySlot):
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::putWithAttributes):
        (JSC::JSGlobalObject::reset):
        (JSC::JSGlobalObject::resetPrototype):
        * runtime/JSGlobalObject.h:
        * runtime/JSObject.cpp:
        (JSC::JSObject::put):
        (JSC::JSObject::deleteProperty):
        (JSC::JSObject::defineGetter):
        (JSC::JSObject::defineSetter):
        (JSC::JSObject::lookupGetter):
        (JSC::JSObject::lookupSetter):
        (JSC::JSObject::getPropertySpecificValue):
        (JSC::JSObject::getOwnPropertyNames):
        (JSC::JSObject::seal):
        (JSC::JSObject::freeze):
        (JSC::JSObject::preventExtensions):
        (JSC::JSObject::removeDirect):
        (JSC::JSObject::getOwnPropertyDescriptor):
        (JSC::JSObject::defineOwnProperty):
        * runtime/JSObject.h:
        (JSC::JSObject::getDirect):
        (JSC::JSObject::getDirectLocation):
        (JSC::JSObject::isSealed):
        (JSC::JSObject::isFrozen):
        (JSC::JSObject::setPrototypeWithCycleCheck):
        (JSC::JSObject::setPrototype):
        (JSC::JSObject::inlineGetOwnPropertySlot):
        (JSC::JSObject::putDirectInternal):
        (JSC::JSObject::putDirectWithoutTransition):
        (JSC::JSObject::putDirectFunctionWithoutTransition):
        * runtime/Lookup.cpp:
        (JSC::setUpStaticFunctionSlot):
        * runtime/ObjectConstructor.cpp:
        (JSC::objectConstructorCreate):
        (JSC::objectConstructorSeal):
        (JSC::objectConstructorFreeze):
        (JSC::objectConstructorPreventExtensions):
        (JSC::objectConstructorIsSealed):
        (JSC::objectConstructorIsFrozen):
        * runtime/Operations.h:
        (JSC::normalizePrototypeChain):
        * runtime/PropertyMapHashTable.h:
        (JSC::PropertyMapEntry::PropertyMapEntry):
        (JSC::PropertyTable::PropertyTable):
        (JSC::PropertyTable::copy):
        * runtime/Structure.cpp:
        (JSC::Structure::materializePropertyMap):
        (JSC::Structure::despecifyDictionaryFunction):
        (JSC::Structure::addPropertyTransition):
        (JSC::Structure::removePropertyTransition):
        (JSC::Structure::changePrototypeTransition):
        (JSC::Structure::despecifyFunctionTransition):
        (JSC::Structure::getterSetterTransition):
        (JSC::Structure::toDictionaryTransition):
        (JSC::Structure::toCacheableDictionaryTransition):
        (JSC::Structure::toUncacheableDictionaryTransition):
        (JSC::Structure::sealTransition):
        (JSC::Structure::freezeTransition):
        (JSC::Structure::preventExtensionsTransition):
        (JSC::Structure::isSealed):
        (JSC::Structure::isFrozen):
        (JSC::Structure::addPropertyWithoutTransition):
        (JSC::Structure::removePropertyWithoutTransition):
        (JSC::Structure::copyPropertyTable):
        (JSC::Structure::get):
        (JSC::Structure::despecifyFunction):
        (JSC::Structure::despecifyAllFunctions):
        (JSC::Structure::put):
        (JSC::Structure::getPropertyNames):
        * runtime/Structure.h:
        (JSC::Structure::get):
        (JSC::Structure::materializePropertyMapIfNecessary):
2011-04-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make PropertyMapEntry use a WriteBarrier for specificValue
        https://bugs.webkit.org/show_bug.cgi?id=58407

        Pass JSGlobalData reference on to APIs that now need them

        * bindings/js/JSDOMWindowShell.h:
        (WebCore::JSDOMWindowShell::setWindow):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::all):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-12 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 13 Apr 2011 18:04:30 +0000 (18:04 +0000)]
2011-04-12  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Roben.

        make PrettyPatch.rb aware of checksums in png files
        https://bugs.webkit.org/show_bug.cgi?id=58387

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 13 Apr 2011 17:22:58 +0000 (17:22 +0000)]
2011-04-13  Tony Chang  <tony@chromium.org>

        Unreviewed, fix NRWT.  Stack:

            return super(ChromiumPort, self).results_directory(self)
        TypeError: results_directory() takes exactly 1 argument (2 given)

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-12 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 13 Apr 2011 16:45:42 +0000 (16:45 +0000)]
2011-04-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix source mapping for deobfuscated scripts.
        https://bugs.webkit.org/show_bug.cgi?id=58231

        * inspector/debugger/resources/obfuscated.js: Added.
        * inspector/debugger/script-formatter-expected.txt:
        * inspector/debugger/script-formatter.html:
2011-04-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix source mapping for de-obfuscated scripts.
        https://bugs.webkit.org/show_bug.cgi?id=58231

        * inspector/front-end/ScriptFormatterWorker.js:
        (buildMapping):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceMapping):
        (WebInspector.SourceMapping.prototype.sourceLineToScriptLocation):
        (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
        (WebInspector):
        (WebInspector.FormattedSourceMapping):
        (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
        (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 13 Apr 2011 16:33:02 +0000 (16:33 +0000)]
2011-04-13  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Consider editable and non editable nodes when calculating selection offsets
        https://bugs.webkit.org/show_bug.cgi?id=58431

        Use firstPositionInOrBeforeNode() and lastPositionInOrAfterNode().

        This is needed to ensure that getSelectionOffsetsForObject() works
        well when non editable nodes are present in the selection, since
        firstPositionInNode() and lastPositionInNode() don't work in those
        cases (they assume the node is editable).

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (getSelectionOffsetsForObject): Updated calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 13 Apr 2011 16:27:23 +0000 (16:27 +0000)]
2011-04-13  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Missing nullchecks in GTK's a11y wrapper
        https://bugs.webkit.org/show_bug.cgi?id=58429

        Add missing nullchecks for coreObject->document().

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkParentOfRootObject): Add missing nullcheck.
        (getPangoLayoutForAtk): Ditto.
        (webkit_accessible_text_get_caret_offset): Ditto.
        (textExtents): Ditto.
        (webkit_accessible_editable_text_insert_text): Ditto.
        (webkit_accessible_editable_text_delete_text): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Thierry Reding <thierry.reding@avionic-design.de>
mrobinson@webkit.org [Wed, 13 Apr 2011 16:17:37 +0000 (16:17 +0000)]
2011-04-13  Thierry Reding  <thierry.reding@avionic-design.de>

        Gtk+ port fails to build when enabling WebGL
        https://bugs.webkit.org/show_bug.cgi?id=58434

        Fix the GTK+ WebGL build after the introduction of PlatformContextCairo.

        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/cairo/GraphicsContext3DCairo.cpp:
        (WebCore::GraphicsContext3D::paintToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 13 Apr 2011 16:15:50 +0000 (16:15 +0000)]
2011-04-13  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK platform results for full-screen-zIndex.html test.

        [GTK] fullscreen/full-screen-zIndex.html fails
        https://bugs.webkit.org/show_bug.cgi?id=58444

        * platform/gtk/Skipped:
        * platform/gtk/fullscreen/full-screen-zIndex-expected.checksum: Added.
        * platform/gtk/fullscreen/full-screen-zIndex-expected.png: Added.
        * platform/gtk/fullscreen/full-screen-zIndex-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTeach ORWT about extra platform-specific directories to be searched before the defaul...
aroben@apple.com [Wed, 13 Apr 2011 16:12:10 +0000 (16:12 +0000)]
Teach ORWT about extra platform-specific directories to be searched before the default ones

Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
platform-specific results

Reviewed by Anders Carlsson.

* Scripts/old-run-webkit-tests:
(top-level): Added @additionalPlatformDirectories and hooked up
--additional-platform-directories to populate it.
(buildPlatformResultHierarchy): Prepend the additional platform directories to the default
list (after filtering out any of the additional directories that don't exist).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttp/tests/inspector/extensions-resources-redirect.html and
jberlin@webkit.org [Wed, 13 Apr 2011 15:55:23 +0000 (15:55 +0000)]
http/tests/inspector/extensions-resources-redirect.html and
inspector/extensions/extensions-resources.html sometimes fail on Windows 7 Release (WebKit2
Tests).
https://bugs.webkit.org/show_bug.cgi?id=57491

Add the tests to the win-wk2 Skipped list to get the bots green.

* platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 13 Apr 2011 15:49:32 +0000 (15:49 +0000)]
2011-04-12  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        REGRESSION(r83561): doesn't pause in-window playback during fullscreen playback
        https://bugs.webkit.org/show_bug.cgi?id=58312

        Make sure to link the videoValve in all cases, fpsdisplaysink
        being used or not.

        No new test, this patch fixes an internal feature of the player,
        not publicly exposed. Having two video sinks and pausing one while
        the other displays the fullscreen video is an implementation
        detail of the GStreamer player.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 13 Apr 2011 15:45:04 +0000 (15:45 +0000)]
2011-04-13  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing fullscreen test on GTK.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 13 Apr 2011 15:44:38 +0000 (15:44 +0000)]
2011-04-13  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: there is a problem if an optional param is not at the end of a params list.
        https://bugs.webkit.org/show_bug.cgi?id=58440

        In InspectorBackend.dispatch method we are converting the message's params object into array of arguments
        for a callback. But in some cases the optional parameter is declared in the middle of the params list.
        That gets us into a problem if this param has been skipped in the message. In that case the tail of the
        event params will be shifted. We can slightly modify dispatcher and it will put the params in right places.

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Windows XP Debug Tests] fast/events/pageshow-pagehide-on-back-cached-with-frames...
jberlin@webkit.org [Wed, 13 Apr 2011 15:33:26 +0000 (15:33 +0000)]
[Windows XP Debug Tests] fast/events/pageshow-pagehide-on-back-cached-with-frames.html
failing since r83699
https://bugs.webkit.org/show_bug.cgi?id=58441

Add the Windows-XP specific expected failing results to get the bots green.

* platform/win-xp/fast/events: Added.
* platform/win-xp/fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 13 Apr 2011 15:02:06 +0000 (15:02 +0000)]
2011-04-13  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline of an svg test updated in r83710 and
        skip an http test using unimplemented DRT features.

        * platform/gtk/Skipped:
        * platform/gtk/svg/custom/text-dom-01-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Wed, 13 Apr 2011 14:58:55 +0000 (14:58 +0000)]
2011-04-13  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=57337

        Work around a bug in ternary opertions in the Solaris Studio
        12/12.1/12.2 compilers, using an if clause.

        * dom/NodeRenderStyle.h:
        (WebCore::Node::renderStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd /T to TaskKill.exe
lforschler@apple.com [Wed, 13 Apr 2011 14:57:13 +0000 (14:57 +0000)]
Add /T to TaskKill.exe

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSort task kill list
lforschler@apple.com [Wed, 13 Apr 2011 14:55:37 +0000 (14:55 +0000)]
Sort task kill list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Brian Salomon <bsalomon@google.com>
commit-queue@webkit.org [Wed, 13 Apr 2011 14:33:25 +0000 (14:33 +0000)]
2011-04-13  Brian Salomon  <bsalomon@google.com>

        Reviewed by Kenneth Russell.

        Use new skia API for wrapping DrawingBuffer's FBO/Tex IDs in skia object
        https://bugs.webkit.org/show_bug.cgi?id=58363

        No new tests needed, exercised by all existing canvas2d tests.

        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::getGrPlatformSurfaceDesc):
        * platform/graphics/gpu/DrawingBuffer.h:
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Wed, 13 Apr 2011 14:28:06 +0000 (14:28 +0000)]
2011-04-13  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=58384
        Update kill-old-processes to include a few new ones.

        * BuildSlaveSupport/win/kill-old-processes:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 13 Apr 2011 14:26:22 +0000 (14:26 +0000)]
2011-04-13  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Fix chromium clang build problem:
        ApplyPropertyExpandingSuppressValue::applyValue() shadows a virtual method
        with a different signature in base class instead of overriding it.

        * css/CSSStyleApplyProperty.cpp:
        (WebCore::ApplyPropertyExpandingSuppressValue::applyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 13 Apr 2011 14:25:47 +0000 (14:25 +0000)]
2011-04-13  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Rebaselined SVG test expectations following mac expectations change in r83710.

        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
        * platform/chromium-linux/svg/custom/text-dom-01-f-expected.checksum: Removed.
        * platform/chromium-linux/svg/custom/text-dom-01-f-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.checksum: Removed.
        * platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
        * platform/chromium-win/svg/custom/text-dom-01-f-expected.checksum: Removed.
        * platform/chromium-win/svg/custom/text-dom-01-f-expected.png:
        * platform/chromium-win/svg/custom/text-dom-01-f-expected.txt:
        * platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
        * platform/chromium-win/svg/text/lengthAdjust-text-metrics-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 13 Apr 2011 14:20:00 +0000 (14:20 +0000)]
2011-04-13  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Add mock implementation and plumbing code for unified Quota API
        https://bugs.webkit.org/show_bug.cgi?id=57927

        Added plumbing code for the quota API, that is based on the
        discussion on public-webapps:
        http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html

        * WebKit.gyp: Added new file entries.
        * src/StorageInfoChromium.cpp: Added.
        * src/WebStorageQuotaCallbacksImpl.cpp: Added. An implementation of
        WebStorageQuotaCallbacks.
        * src/WebStorageQuotaCallbacksImpl.h: Added.
2011-04-13  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Add mock implementation and plumbing code for unified Quota API
        https://bugs.webkit.org/show_bug.cgi?id=57927

        Added mock implementation and some plumbing code for the quota API,
        that is based on the discussion on public-webapps:
        http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html

        No new tests: tests will be added when we expose the API.

        * CMakeLists.txt: Added new file entries.
        * DerivedSources.cpp: Added new file entries.
        * DerivedSources.make: Added new file entries.
        * GNUmakefile.am: Added new file entries.
        * WebCore.gypi: Added new file entries.
        * WebCore.pro: Added new file entries.
        * WebCore.vcproj/WebCore.vcproj: Added new file entries.
        * WebCore.xcodeproj/project.pbxproj: Added new file entries.
        * storage/StorageInfo.cpp: Added.
        * storage/StorageInfo.h: Added.
        * storage/StorageInfoErrorCallback.h: Added.
        * storage/StorageInfoQuotaCallback.h: Added.
        * storage/StorageInfoUsageCallback.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Gustavo Noronha Silva <gns@gnome.org>
commit-queue@webkit.org [Wed, 13 Apr 2011 14:05:15 +0000 (14:05 +0000)]
2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Martin Robinson.

        [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
        https://bugs.webkit.org/show_bug.cgi?id=58297

        Make sure we do not load plugins that use symbols of a different
        GTK+ major version to avoid bugs and crashes.

        * plugins/gtk/PluginPackageGtk.cpp:
        (WebCore::moduleMixesGtkSymbols):
        (WebCore::PluginPackage::load):
2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Martin Robinson.

        [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
        https://bugs.webkit.org/show_bug.cgi?id=58297

        Do not disable flash specifically when built with GTK+ 3 -
        PluginPackage should do the right thing while loading plugins.

        * GtkLauncher/main.c:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Grzegorz Czajkowski <g.czajkowski@samsung.com>
commit-queue@webkit.org [Wed, 13 Apr 2011 14:04:44 +0000 (14:04 +0000)]
2011-04-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Doxygen documentation for ewk_main, ewk_history and tools
        https://bugs.webkit.org/show_bug.cgi?id=58428

        * ewk/EWebKit.h:
        * ewk/ewk_eapi.h:
        * ewk/ewk_history.h:
        * ewk/ewk_logging.h:
        * ewk/ewk_main.cpp:
        * ewk/ewk_main.h:
        * ewk/ewk_private.h:
        * ewk/ewk_util.cpp:
        * ewk/ewk_util.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 13 Apr 2011 14:01:55 +0000 (14:01 +0000)]
2011-04-13  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by David Levin.

        [chromium] Regression(r80861): fast/dom/Window/window-lookup-precedence.html started failing on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=56608

        Previously the test unintentionally navigated the iframe when setting
        window.location. Instead, now, we just skip setting window.location.

        * fast/dom/Window/window-lookup-precedence.html:
        * platform/chromium-win/fast/dom/Window/window-lookup-precedence-expected.txt: Moved to chromium.
        * platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt: Moved from chromium-win.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Andrey Adaikin <aandrey@google.com>
commit-queue@webkit.org [Wed, 13 Apr 2011 13:39:00 +0000 (13:39 +0000)]
2011-04-13  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Implement undo/redo in text editor
        https://bugs.webkit.org/show_bug.cgi?id=58426

        Native undo/redo does not work because we modify DOM structure (highlights, chunks and etc.)
        Implement it via keyboard shortcuts for now (Cmd/Ctrl+Z and Cmd/Ctrl+Shift+Z).
        FIXME: Do something with the popup's Undo and Redo menu options - they invoke native's undo/redo.

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.endEditing):
        * inspector/front-end/TextEditorModel.js:
        (WebInspector.TextEditorModel.prototype.setText):
        (WebInspector.TextEditorModel.prototype._innerSetText):
        (WebInspector.TextEditorModel.prototype._pushUndoableCommand):
        (WebInspector.TextEditorModel.prototype.undo):
        (WebInspector.TextEditorModel.prototype.redo):
        (WebInspector.TextEditorModel.prototype._doUndo):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._textChanged):
        (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
        (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
        (WebInspector.TextViewer.prototype._registerShortcuts):
        (WebInspector.TextViewer.prototype._cancelEditing):
        (WebInspector.TextViewer.prototype._handleUndoRedo):
        (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
        (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
        (WebInspector.TextEditorGutterPanel.prototype.textChanged):
        (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo.callback):
        (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
        (WebInspector.TextEditorMainPanel.prototype._restoreSelection):
        (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
        (WebInspector.TextEditorMainPanel.prototype.textChanged):
        (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 13 Apr 2011 13:24:02 +0000 (13:24 +0000)]
2011-04-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make optional event parameter last to prevent regressions.
        https://bugs.webkit.org/show_bug.cgi?id=58433

        * inspector/Inspector.json:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::willSendRequest):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work in WK2
ossy@webkit.org [Wed, 13 Apr 2011 13:12:49 +0000 (13:12 +0000)]
LayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work in WK2
http://webkit.org/b/58334

Make same changes in Qt WK2 Skipped list as r83595 in Mac WK2 Skipped list.

* platform/qt-wk2/Skipped: Skip a new test due to an identified bug in WKTR and classify
  three other skipped tests with that same bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 13 Apr 2011 12:24:48 +0000 (12:24 +0000)]
2011-04-13  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: revert Inspector.json change for breaking world.

        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 13 Apr 2011 12:14:12 +0000 (12:14 +0000)]
2011-04-13  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: swap methods in the Inspector.json.

        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Csaba Osztrogon√°c <ossy@webkit.org>
ossy@webkit.org [Wed, 13 Apr 2011 11:41:14 +0000 (11:41 +0000)]
2011-04-13  Csaba Osztrogon√°c  <ossy@webkit.org>

        Unreviewed, rolling out r83695.
        http://trac.webkit.org/changeset/83695
        https://bugs.webkit.org/show_bug.cgi?id=58375

        [Qt][WK2]It broke http tests

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::start):
        (WebCore::QNetworkReplyHandler::synchronousLoad):
        * platform/network/qt/QNetworkReplyHandler.h:
        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::WebCoreSynchronousLoader::resourceResponse):
        (WebCore::WebCoreSynchronousLoader::resourceError):
        (WebCore::WebCoreSynchronousLoader::data):
        (WebCore::WebCoreSynchronousLoader::setReplyFinished):
        (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
        (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
        (WebCore::WebCoreSynchronousLoader::didReceiveData):
        (WebCore::WebCoreSynchronousLoader::didFinishLoading):
        (WebCore::WebCoreSynchronousLoader::didFail):
        (WebCore::WebCoreSynchronousLoader::waitForCompletion):
        (WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 13 Apr 2011 11:37:10 +0000 (11:37 +0000)]
2011-04-13  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: inactive style sheets should be read only.
        https://bugs.webkit.org/show_bug.cgi?id=58423

        * inspector/front-end/ResourceView.js:
        (WebInspector.CSSSourceFrame):
        (WebInspector.CSSSourceFrame.prototype.isContentEditable):
        (WebInspector.CSSSourceFrame.prototype._loadStyleSheet.didGetAllStyleSheets.didCreateForId):
        (WebInspector.CSSSourceFrame.prototype._loadStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 13 Apr 2011 11:35:00 +0000 (11:35 +0000)]
2011-04-13  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Prepare to move detailed heap snapshots storage and processing into workers.
        https://bugs.webkit.org/show_bug.cgi?id=58320

        Introduce a proxy object that emulates worker behavior and change UI code to cope with it.

        * inspector/profiler/detailed-heapshots-test.js:
        (initialize_DetailedHeapshotTest):

2011-04-13  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Prepare to move detailed heap snapshots storage and processing into workers.
        https://bugs.webkit.org/show_bug.cgi?id=58320

        Introduce a proxy object that emulates worker behavior and change UI code to cope with it.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate.sorted):
        (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate):
        (WebInspector.HeapSnapshotGridNode.prototype._populate):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
        (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort.afterPopulate):
        (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort):
        (WebInspector.HeapSnapshotGridNode.prototype.sort):
        (WebInspector.HeapSnapshotGenericObjectNode):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype.get _shallowSizePercent):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren):
        (WebInspector.HeapSnapshotObjectNode):
        (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
        (WebInspector.HeapSnapshotInstanceNode):
        (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
        (WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotIteratorsTuple.prototype.sortAndRewind):
        (WebInspector.HeapSnapshotDiffNode.prototype._calculateDiff):
        (WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotDiffNode.prototype._childHashForEntity):
        (WebInspector.HeapSnapshotDiffNode.prototype._childHashForNode):
        (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
        (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
        (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
        (WebInspector.HeapSnapshotDominatorObjectNode):
        (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
        (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
        (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
        (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.baseSnapshotNodeIdsReceived):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.pushBaseSnapshotNodeIds):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.snapshotNodeIdsReceived):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
        (WebInspector.HeapSnapshotRetainingPathsList):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
        (WebInspector.DetailedHeapshotView.profileCallback):
        (WebInspector.DetailedHeapshotView):
        (WebInspector.DetailedHeapshotView.prototype.get profileWrapper):
        (WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper):
        (WebInspector.DetailedHeapshotView.prototype.show.profileCallback1):
        (WebInspector.DetailedHeapshotView.prototype.show.profileCallback2):
        (WebInspector.DetailedHeapshotView.prototype.show):
        (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
        * inspector/front-end/HeapSnapshot.js:
        * inspector/front-end/HeapSnapshotProxy.js: Added.
        * inspector/front-end/PleaseWaitMessage.js:
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._reset):
        (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Qt specific expected results after r83710.
ossy@webkit.org [Wed, 13 Apr 2011 10:45:37 +0000 (10:45 +0000)]
Update Qt specific expected results after r83710.

* platform/qt/svg/custom/text-dom-01-f-expected.txt:
* platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 13 Apr 2011 10:20:35 +0000 (10:20 +0000)]
2011-04-13  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Web Page Performance auditing fails
        https://bugs.webkit.org/show_bug.cgi?id=58322

        * inspector/audits/audits-panel-functional.html:
2011-04-13  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Web Page Performance auditing fails
        https://bugs.webkit.org/show_bug.cgi?id=58322

        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 13 Apr 2011 09:51:26 +0000 (09:51 +0000)]
2011-04-13  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: enumerate properties in Inspector.json using array, not object keys.
        https://bugs.webkit.org/show_bug.cgi?id=58418

        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-12 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Wed, 13 Apr 2011 09:33:25 +0000 (09:33 +0000)]
2011-04-12  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        Chromium: Set ENABLE_LEVELDB=1 and add leveldb and snappy to DEPS
        https://bugs.webkit.org/show_bug.cgi?id=58343

        Set ENABLE_LEVELDB=1 so that code gets compiled by the EWS bots.
        Add the necessary dependencies to the DEPS file.

        * DEPS:
        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-06 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 13 Apr 2011 09:32:15 +0000 (09:32 +0000)]
2011-04-06  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add "De-obfuscate Source" item to source frame text area context menu.
        https://bugs.webkit.org/show_bug.cgi?id=57942

        * English.lproj/localizedStrings.js:
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.formatSourceFilesToggled):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.toggleFormatSourceFiles):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._contextMenu):
        (WebInspector.SourceFrame.prototype._populateLineGutterContextMenu):
        (WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
        (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
        (WebInspector.SourceFrameDelegate.prototype.toggleFormatSourceFiles):
        (WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-13 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 13 Apr 2011 09:22:45 +0000 (09:22 +0000)]
2011-04-13  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg has different output on Windows
        https://bugs.webkit.org/show_bug.cgi?id=58421

        * platform/win/Skipped: Skip svdgdom-over-01-f.svg test. The test is fine, but its missing a line compared to the mac output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83712 268f45cc-cd09-0410-ab3c-d52691b4dbfc