WebKit-https.git
15 years ago Reviewed by Maciej, Darin.
ggaren [Mon, 6 Mar 2006 22:33:33 +0000 (22:33 +0000)]
    Reviewed by Maciej, Darin.

        Added Safari Compatibility Hit List.

        * nav.inc: Link to the hit list.
        * projects/compat/hitlist.html: Added.
        * projects/compat/index.html: Link to the hit list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Patch by David Carson, reviewed by Darin.
ap [Mon, 6 Mar 2006 19:59:09 +0000 (19:59 +0000)]
    Patch by David Carson, reviewed by Darin.

        - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7582
        c_utility.cpp contains CFString OS X platform-dependent code; should use ICU

        Tested with test case from:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5163

        * bindings/c_utility.cpp
        (convertUTF8ToUTF16): Changed to using Unicode converter from ICU, and manual Latin-1 conversion.
        * icu/unicode/ucnv.h: Copied from WebCore.
        * icu/unicode/ucnv_err.h: Ditto.
        * icu/unicode/uenum.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Mon, 6 Mar 2006 19:43:53 +0000 (19:43 +0000)]
LayoutTests:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
        elementAtPoint returns the list when the point is over a list marker

        * fast/lists/drag-into-marker-expected.checksum: Added.
        * fast/lists/drag-into-marker-expected.png: Added.
        * fast/lists/drag-into-marker-expected.txt: Added.
        * fast/lists/drag-into-marker.html: Added.

WebCore:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
        elementAtPoint returns the list when the point is over a list marker

        Call RenderObject::setInnerNode(), which sets both the
        innerNode and the innerNonSharedNode.

        * rendering/render_list.cpp:
        (WebCore::RenderListItem::nodeAtPoint):
        * rendering/render_list.h:

WebKitTools:

        Reviewed by darin

        Sent the windowNumber when sending events.
        Added leapForward so that we don't have to spend time waiting
        in layout tests that do mouse operations that require delays.

        * DumpRenderTree/DumpRenderTree.m:
        (+[EventSendingController isSelectorExcludedFromWebScript:]):
        (+[EventSendingController webScriptNameForSelector:]):
        (-[EventSendingController currentEventTime]):
        (-[EventSendingController leapForward:]):
        (-[EventSendingController mouseDown]):
        (-[EventSendingController mouseUp]):
        (-[EventSendingController mouseMoveToX:Y:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * WebCore.vcproj/WebCore/WebCore.vcproj: Removed a lot of long-ago-deleted...
darin [Mon, 6 Mar 2006 17:11:44 +0000 (17:11 +0000)]
    * WebCore.vcproj/WebCore/WebCore.vcproj: Removed a lot of long-ago-deleted files
        from the kwq directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Mon, 6 Mar 2006 16:50:13 +0000 (16:50 +0000)]
    Reviewed by Maciej.

        - moved all the remnants of the public C++ DOM API out of khtml/dom
        - changed from "int" to "ExceptionCode" for DOM exceptions
        - removed unused CSS_HTML_RELATIVE
        - changed offsetInCharacters to be a member function of NodeImpl
        - changed DOM functions that take a NodeType to use NodeType instead of
          unsigned short for clarity (will still be unsigned short in bindings)
        - changed exception constants so they can be used directly in the
          implementation code (added in the offsets for different types of exceptions)
        - replaced the eventListenerType function with an isHTMLEventListener function
        - got rid of EventListenerEvent, which is a synonym for EventImpl*
        - eliminated handleEventImpl, whish is now the same as handleEvent

        - did other preparation for the "remove Impl suffix" renaming
          (tested by using a script that does the renaming)

        * khtml/dom/css_rule.h: Removed.
        * khtml/dom/css_stylesheet.h: Removed.
        * khtml/dom/css_value.h: Removed.
        * khtml/dom/dom2_events.cpp: Removed.
        * khtml/dom/dom2_events.h: Removed.
        * khtml/dom/dom2_range.h: Removed.
        * khtml/dom/dom2_traversal.cpp: Removed.
        * khtml/dom/dom2_traversal.h: Removed.
        * khtml/dom/dom_exception.h: Removed.
        * khtml/dom/dom_node.h: Removed.

        * dom/EventListener.h: Added.
        * dom/ExceptionCode.h: Added.

        * WebCore+SVG/kdom.h: Removed NodeType and ExceptionCodes
        * WebCore+SVG/kdomevents.h: Removed.

        * WebCore.xcodeproj/project.pbxproj: Updated for file changes.
        * WebCore.xcodeproj/project.pbxproj: Updated for file changes.

        * bindings/scripts/CodeGeneratorJS.pm: Removed unneeded DOM:: prefix. Updated file
        names and exception prefix for changes in DOM exceptions.

        * bindings/js/JSDOMCore.cpp: Touched to cause auto-generated code to be
        recompiled. We need to get this fixed!
        * bindings/js/JSDOMEvents.cpp: Ditto.

        * dom/Attr.idl:
        * dom/CharacterData.idl:
        * dom/DOMImplementation.idl:
        * dom/DocumentType.idl:
        * dom/Element.idl:
        * dom/Entity.idl:
        * dom/MutationEvent.idl:
        * dom/Notation.idl:
        * dom/ProcessingInstruction.idl:
        * dom/Text.idl:
        * dom/WheelEvent.idl:
        Touched all IDL files so that changes in CodeGeneratorJS.pm would take effect.
        Added license headers.

        * bindings/objc/DOM.mm: Fixed garbled license agreement. Updated includes.
        Changed from a single "using namespace WebCore" to individual using statements
        because of the imminent conflict between DOMImplementation in Objective C
        and WebCore::DOMImplementation (currently has an Impl suffix). Added a typedef
        for WebCore::DOMImplementationImpl. Changed to use ExceptionCode instead of int.

        * bindings/objc/DOMCSS.h: Removed DOMCSSException and the special CSS exception
        codes. This is a feature of DOM Level 1 only. In DOM Level 2 these were eliminated
        and use basic DOM exception codes instead. We might have to do something for binary
        compatibility eventually, but perhaps not.

        * bindings/objc/DOMCSS.mm:
        * bindings/objc/DOMEvents.mm:
        * bindings/objc/DOMEventsInternal.h:
        * bindings/objc/DOMHTML.mm:
        * bindings/objc/DOMHTMLInternal.h:
        * bindings/objc/DOMViews.mm:
        * bindings/objc/DOMViewsInternal.h:
        Fixed garbled license agreements.
        Changed to use ExceptionCode instead of int and name the variable "ec".

        * bindings/objc/DOMInternal.h: Changed addDOMWrapperImpl to take NSObject* instead
        of id. This helps with overload resolution when addDOMWrapperImpl is renamed to be
        addDOMWrapper. Changed ALLOW_DOM_CAST to always use "class" in from of the type name
        of the WebCore class. This helps work around what seems like a bug in namespace support
        in Objective-C mode, although the bug only happens after the "remove Impl" renaming.
        * bindings/objc/DOMInternal.mm:
        (getDOMWrapperImpl): Changed to use HashMap.
        (addDOMWrapperImpl): Ditto.
        (removeDOMWrapper): Ditto.
        (raiseDOMException): Update to use new names for exception number ranges.

        * bridge/mac/WebCoreFrameBridge.mm:
        * khtml/ecma/xmlserializer.cpp:
        * kwq/KWQAccObject.mm:
        Removed unneeded includes.

        * css/css_ruleimpl.h: Moved "rule type" into this header.

        * dom/CommentImpl.h:
        * dom/CommentImpl.cpp: (WebCore::CommentImpl::offsetInCharacters): Added. Returns true.

        * khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
        Changed this around so we don't have a local variable named docImpl.

        * khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Updated for new form of exception
        constants.

        * khtml/ecma/kjs_events.h:
        * khtml/ecma/kjs_events.cpp:
        (KJS::JSAbstractEventListener::handleEvent): Changed to no longer use EventListenerEvent.
        (KJS::JSAbstractEventListener::isHTMLEventListener): Added.

        * rendering/RenderTextField.h: Updated includes. Tweaked the code formatting of
        InputMutationListener. (Might be unnecessary since this class might be deleted soon.)

        * bridge/mac/MacFrame.mm:
        * css/css_computedstyle.cpp:
        * css/css_computedstyle.h:
        * css/css_ruleimpl.cpp:
        * css/css_stylesheetimpl.cpp:
        * css/css_stylesheetimpl.h:
        * css/css_valueimpl.cpp:
        * css/css_valueimpl.cpp:
        * css/css_valueimpl.h:
        * css/css_valueimpl.h:
        * css/cssparser.cpp:
        * css/cssstyleselector.cpp:
        * dom/CDATASectionImpl.cpp:
        * dom/CDATASectionImpl.h:
        * dom/CharacterDataImpl.cpp:
        * dom/CharacterDataImpl.h:
        * dom/ContainerNodeImpl.cpp:
        * dom/DOMImplementationImpl.cpp:
        * dom/DocumentFragmentImpl.cpp:
        * dom/DocumentFragmentImpl.h:
        * dom/DocumentImpl.cpp:
        * dom/DocumentImpl.h:
        * dom/DocumentTypeImpl.cpp:
        * dom/DocumentTypeImpl.h:
        * dom/NamedNodeMapImpl.h:
        * dom/NodeImpl.cpp:
        * dom/NodeImpl.h:
        * dom/NodeListImpl.cpp:
        * dom/TextImpl.cpp:
        * dom/TextImpl.h:
        * dom/dom2_eventsimpl.cpp:
        * dom/dom2_eventsimpl.h:
        * dom/dom2_rangeimpl.cpp:
        * dom/dom2_rangeimpl.h:
        * dom/dom2_traversalimpl.cpp:
        * dom/dom2_traversalimpl.h:
        * dom/dom_elementimpl.cpp:
        * dom/dom_elementimpl.h:
        * dom/dom_position.cpp:
        * dom/dom_xmlimpl.cpp:
        * dom/dom_xmlimpl.h:
        * dom/xml_tokenizer.cpp:
        * editing/AppendNodeCommand.cpp:
        * editing/ApplyStyleCommand.cpp:
        * editing/CompositeEditCommand.cpp:
        * editing/DeleteFromTextNodeCommand.cpp:
        * editing/InsertIntoTextNodeCommand.cpp:
        * editing/InsertLineBreakCommand.cpp:
        * editing/InsertNodeBeforeCommand.cpp:
        * editing/InsertParagraphSeparatorCommand.cpp:
        * editing/JoinTextNodesCommand.cpp:
        * editing/MergeIdenticalElementsCommand.cpp:
        * editing/RemoveNodeAttributeCommand.cpp:
        * editing/RemoveNodeCommand.cpp:
        * editing/ReplaceSelectionCommand.cpp:
        * editing/Selection.cpp:
        * editing/SelectionController.cpp:
        * editing/SelectionController.h:
        * editing/SetNodeAttributeCommand.cpp:
        * editing/SplitElementCommand.cpp:
        * editing/SplitTextNodeCommand.cpp:
        * editing/VisiblePosition.cpp:
        * editing/WrapContentsInDummySpanCommand.cpp:
        * editing/htmlediting.cpp:
        * editing/markup.cpp:
        * editing/visible_text.cpp:
        * khtml/ecma/kjs_binding.h:
        * khtml/ecma/kjs_css.cpp:
        * khtml/ecma/kjs_dom.cpp:
        * khtml/ecma/kjs_html.cpp:
        * khtml/ecma/kjs_range.cpp:
        * khtml/ecma/kjs_traversal.cpp:
        * khtml/ecma/kjs_traversal.h:
        * khtml/ecma/kjs_window.cpp:
        * khtml/html/HTMLElementImpl.cpp:
        * khtml/html/HTMLOptionElementImpl.cpp:
        * khtml/html/HTMLOptionElementImpl.h:
        * khtml/html/HTMLOptionsCollectionImpl.cpp:
        * khtml/html/HTMLSelectElementImpl.cpp:
        * khtml/html/HTMLTextAreaElementImpl.cpp:
        * khtml/html/html_documentimpl.cpp:
        * khtml/html/html_documentimpl.h:
        * khtml/html/html_headimpl.cpp:
        * khtml/html/html_tableimpl.cpp:
        * khtml/html/html_tableimpl.h:
        * khtml/html/htmlparser.cpp:
        * khtml/xbl/xbl_tokenizer.cpp:
        * khtml/xsl/xsl_stylesheetimpl.cpp:
        * ksvg2/misc/SVGDocumentExtensions.cpp:
        * ksvg2/svg/SVGAnimationElementImpl.cpp:
        * ksvg2/svg/SVGDOMImplementationImpl.cpp:
        * ksvg2/svg/SVGDOMImplementationImpl.h:
        * ksvg2/svg/SVGDocumentImpl.cpp:
        * ksvg2/svg/SVGDocumentImpl.h:
        * ksvg2/svg/SVGElementImpl.cpp:
        * ksvg2/svg/SVGLengthImpl.cpp:
        * ksvg2/svg/SVGLocatableImpl.cpp:
        * ksvg2/svg/SVGPolyElementImpl.cpp:
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        * ksvg2/svg/SVGStyleElementImpl.cpp:
        * ksvg2/svg/SVGStyleElementImpl.h:
        * ksvg2/svg/SVGUseElementImpl.cpp:
        * page/Frame.cpp:
        * page/FrameView.cpp:
        * rendering/render_object.cpp:
        * xml/xmlhttprequest.cpp:
        Changed to use ExceptionCode instead of int and name the variable "ec".
        Also updated use of exception codes and other constants to get them from
        their new locations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-06 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 6 Mar 2006 10:12:42 +0000 (10:12 +0000)]
2006-03-06  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix more pages (apple.com, yahoo.com) by returning empty error image.
        Empty a couple more stubs and clean up stub style a little.

        * platform/cairo/ImageCairo.cpp:
        (WebCore::Image::loadResource):
        * platform/win/TemporaryLinkStubs.cpp:
        (QListBox::isSelected):
        (QSlider::sizeHint):
        (QScrollBar::~QScrollBar):
        (FrameWin::getObjectInstanceForWidget):
        (FrameWin::getEmbedInstanceForWidget):
        (FrameWin::recordFormValue):
        (FrameWin::getAppletInstanceForWidget):
        (FrameWin::passMouseDownEventToWidget):
        (FrameWin::passWheelEventToChildWidget):
        (FrameWin::createPlugin):
        (BrowserExtensionWin::createNewWindow):
        (Path::Path):
        (QLineEdit::~QLineEdit):
        (QLineEdit::setLiveSearch):
        (QComboBox::~QComboBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-06 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 6 Mar 2006 09:15:32 +0000 (09:15 +0000)]
2006-03-06  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Empty enough stubs to make apple.com load.

        * platform/win/TemporaryLinkStubs.cpp:
        (QTextEdit::sizeWithColumnsAndRows):
        (GraphicsContext::misspellingLineThickness):
        (QTextEdit::selectAll):
        (QTextEdit::setSelectionStart):
        (Widget::unlockDrawingFocus):
        (QLineEdit::setAutoSaveName):
        (ScrollView::scrollYOffset):
        (KWQFileButton::setFilename):
        (QListBox::setFont):
        (GraphicsContext::beginTransparencyLayer):
        (GraphicsContext::endTransparencyLayer):
        (QComboBox::QComboBox):
        (QComboBox::setFont):
        (QComboBox::baselinePosition):
        (QComboBox::setWritingDirection):
        (QComboBox::clear):
        (QComboBox::appendItem):
        (QComboBox::setCurrentItem):
        (QComboBox::sizeHint):
        (QComboBox::frameGeometry):
        (QComboBox::setFrameGeometry):
        (QLineEdit::setLiveSearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-06 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 6 Mar 2006 08:39:31 +0000 (08:39 +0000)]
2006-03-06  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Fix external resource loading.
        Make a bunch of stubs not abort (to fix slashdot).

        * platform/win/TemporaryLinkStubs.cpp:
        (QTextEdit::textWithHardLineBreaks):
        (KWQFileButton::click):
        (QComboBox::setFrameGeometry):
        (QTextEdit::setText):
        (QListBox::appendItem):
        (GraphicsContext::endTransparencyLayer):
        (QLineEdit::selectionStart):
        (QTextEdit::QTextEdit):
        (QListBox::isSelected):
        (QComboBox::focusPolicy):
        (QTextEdit::setCursorPosition):
        (QTextEdit::setAlignment):
        (QLineEdit::selectedText):
        (ScrollView::scrollPointRecursively):
        (QScrollBar::setSteps):
        (QComboBox::appendItem):
        (GraphicsContext::drawLineForMisspelling):
        (KWQFileButton::setFilename):
        (QListBox::setWritingDirection):
        (QListBox::focusPolicy):
        (MouseEvent::MouseEvent):
        (QSlider::setFont):
        (Widget::setEnabled):
        (Widget::paint):
        (ScrollView::addChild):
        (ScrollView::inWindow):
        (GraphicsContext::setShadow):
        (GraphicsContext::clearShadow):
        (RenderThemeWin::paintCheckbox):
        (RenderThemeWin::paintRadio):
        (RenderThemeWin::paintButton):
        (RenderThemeWin::paintTextField):
        (QLineEdit::QLineEdit):
        (QLineEdit::setFont):
        (QLineEdit::setAlignment):
        (QLineEdit::setWritingDirection):
        (QLineEdit::maxLength):
        (QLineEdit::setMaxLength):
        (QLineEdit::text):
        (QLineEdit::setText):
        (QLineEdit::cursorPosition):
        (QLineEdit::setCursorPosition):
        (QLineEdit::setEdited):
        (QLineEdit::setReadOnly):
        (QLineEdit::setPlaceholderString):
        (QLineEdit::setColors):
        (QLineEdit::sizeForCharacterWidth):
        (QLineEdit::baselinePosition):
        * platform/win/TransferJobWin.cpp:
        (WebCore::TransferJob::fileLoadTimer):
        (WebCore::TransferJob::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Checked in new results for the test I just landed. Looks like I
ggaren [Mon, 6 Mar 2006 07:38:35 +0000 (07:38 +0000)]
    - Checked in new results for the test I just landed. Looks like I
        landed an old copy.

        * fast/dom/prototype-chain-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix typo.
darin [Mon, 6 Mar 2006 07:23:04 +0000 (07:23 +0000)]
Fix typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Mon, 6 Mar 2006 07:22:43 +0000 (07:22 +0000)]
    Reviewed by Maciej.

        - fix failure seen running editing layout tests

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        Use selectNodeContents instead of rolling our own.
        It handles the "nothing at all" edget case properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-05 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 6 Mar 2006 07:18:42 +0000 (07:18 +0000)]
2006-03-05  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Make updateContents invalidate entire window for now.
        Fix indentation in fileLoadTimer.

        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::updateContents):
        * platform/win/TransferJobWin.cpp:
        (WebCore::TransferJob::fileLoadTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-05 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 6 Mar 2006 06:26:23 +0000 (06:26 +0000)]
2006-03-05  Eric Seidel  <eseidel@apple.com>

        Reviewed by adele.

        Add missing files to vcproj (fix win32 build).
        Also add svn:eol-style=native to new files.

        * WebCore.vcproj/WebCore/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Updated.
darin [Mon, 6 Mar 2006 06:06:15 +0000 (06:06 +0000)]
    * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix build
darin [Mon, 6 Mar 2006 05:55:55 +0000 (05:55 +0000)]
    - fix build

        * rendering/render_style.h: (compareEqual): Made it inline, fixed variable name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Mon, 6 Mar 2006 05:52:31 +0000 (05:52 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6987
        Implement maxlength for new text fields

        * fast/forms/input-appearance-maxlength-expected.txt: Added.
        * fast/forms/input-appearance-maxlength.html: Added.

WebCore:

        Reviewed by Darin.

        - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6987
        Implement maxlength for new text fields

        Test added:
        * fast/forms/input-appearance-maxlength.html

        * WebCore.xcodeproj/project.pbxproj:
         Added BeforeTextInsertedEventImpl.h, BeforeTextInsertedEventImpl.cpp, HTMLTextFieldInnerElementImpl.h, and HTMLTextFieldInnerElementImpl.cpp

        * khtml/html/HTMLInputElementImpl.cpp:
        (WebCore::HTMLInputElementImpl::init): initialize max length to 1024.
        (WebCore::HTMLInputElementImpl::defaultEventHandler): Added case to use the khtmlBeforeTextInsertedEvent to check for maxlength.
        (WebCore::HTMLInputElementImpl::parseMappedAttribute): Makes sure that maxlength is between 0 and 1024.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment): After doing a test insert of the fragment,
         Send khtmlBeforeTextInsertedEvent to the root editable element so the event handler can update the text, and we can update the fragment.
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::insertText): Send khtmlBeforeTextInsertedEvent to the root editable element so the event handler can update the text if necessary.
        * editing/EditCommand.cpp:
        (WebCore::EditCommand::apply): If we've just applied a command, send the khtmlTextInsertedEvent to the root editable element.
        (WebCore::EditCommand::unapply): ditto.
        (WebCore::EditCommand::reapply): ditto.

        * khtml/html/HTMLTextFieldInnerElementImpl.h: Added this class to store a pointer to the input element for the text field and to handle default events.
        (DOM::HTMLTextFieldInnerElementImpl::shadowParentNode): Added.
        (DOM::HTMLTextFieldInnerElementImpl::setShadowParentNode): Added.
        * khtml/html/HTMLTextFieldInnerElementImpl.cpp: Added.
        (WebCore::HTMLTextFieldInnerElementImpl::HTMLTextFieldInnerElementImpl):
        (WebCore::HTMLTextFieldInnerElementImpl::~HTMLTextFieldInnerElementImpl):
        (WebCore::HTMLTextFieldInnerElementImpl::defaultEventHandler):
         Sends khtmlBeforeTextInsertedEvents to the shadowParentNode,
         and handles khtmlTextInsertedEvents by telling the renderer that the subtree has changed.

        * rendering/RenderTextField.cpp: Removed InputMutationListener since subtreeHasChanged is now called from the editing code.
        (WebCore::RenderTextField::~RenderTextField): removed event listener code.
        (WebCore::RenderTextField::updateFromElement): ditto.  And creates HTMLTextFieldInnerElementImpl.
        (WebCore::RenderTextField::subtreeHasChanged): calls new text() method.
        (WebCore::RenderTextField::text): created to get a String of all text in the RenderTextField.
        * rendering/RenderTextField.h: Removed InputMutationListener class.

        * dom/EventNames.h: Added khtmlTextInserted and khtmlBeforeTextInserted.
        * dom/BeforeTextInsertedEventImpl.cpp: Added.
        (WebCore::BeforeTextInsertedEventImpl::BeforeTextInsertedEventImpl):
        * dom/BeforeTextInsertedEventImpl.h: Added.
        (WebCore::BeforeTextInsertedEventImpl::isBeforeTextInsertedEvent):
        (WebCore::BeforeTextInsertedEventImpl::text):
        * dom/dom2_eventsimpl.cpp: (WebCore::EventImpl::isBeforeTextInsertedEvent): Added.
        * dom/dom2_eventsimpl.h: Added isBeforeTextInsertedEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix build, give this a return type.
mjs [Mon, 6 Mar 2006 05:47:29 +0000 (05:47 +0000)]
    - fix build, give this a return type.

        * rendering/render_style.h:
        (compareEqual):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix by Mitz Pettel and Alexey Proskuryakov, reviewed by Maciej and Hyatt.
ap [Mon, 6 Mar 2006 05:32:57 +0000 (05:32 +0000)]
    Fix by Mitz Pettel and Alexey Proskuryakov, reviewed by Maciej and Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7601
          REGRESSION (r13089): Reproducible crash dereferencing a deallocated element on google image search

        * kxmlcore/Platform.h: Corrected the define to enable USE(MULTIPLE_THREADS) on Mac OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Mon, 6 Mar 2006 05:29:48 +0000 (05:29 +0000)]
    Reviewed by Maciej.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7616
          get all references to KJS::Node out of internal.h

        * JavaScriptCore.xcodeproj/project.pbxproj: Updated for file changes.

        * kjs/Parser.cpp: Added.
        * kjs/Parser.h: Added.

        * kjs/internal.cpp: Removed the Parser class.
        * kjs/internal.h: Ditto. Also removed unnecessary declarations of classes
        not used in this header.

        * kjs/nodes.h: Added an include of "Parser.h".
        * kjs/function.h: Added a declaration of FunctionBodyNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-05 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 6 Mar 2006 04:56:45 +0000 (04:56 +0000)]
2006-03-05  Eric Seidel  <eseidel@apple.com>

        Add "Font.h" to (try to) fix the no-svg build.

        * platform/mac/GraphicsContextMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Darin.
mjs [Mon, 6 Mar 2006 04:55:26 +0000 (04:55 +0000)]
    Rubber stamped by Darin.

        - fix win32 build by avoiding use of typeof

        * rendering/render_style.h:
        (compareEqual):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren [Mon, 6 Mar 2006 03:58:15 +0000 (03:58 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        - JSC support for the fix for <rdar://problem/4467143> JavaScript
        enumeration of HTML element properties skips DOM node properties

        * kjs/lookup.h:
        (1) Added the KJS_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro. The
        class definiton macro needs to know about the prototype's prototype so
        that the class constructor properly sets it.
        (2) Removed the KJS_IMPLEMENT_PROTOTYPE_WITH_PARENT macro. The class
        implementation macro does not need to know about the prototype's
        prototype, since getOwnPropertySlot should only look in the current
        object's property map, and not its prototype's.

LayoutTests:

        Reviewed by Maciej.

        - Layout test for <rdar://problem/4467143> JavaScript enumeration of
        HTML element properties skips DOM node properties

        * fast/dom/prototype-chain-expected.txt: Added.
        * fast/dom/prototype-chain.html: Added.

WebCore:

        Reviewed by Maciej.

        - Second cut at fixing <rdar://problem/4467143> JavaScript enumeration
        of HTML element properties skips DOM node properties

        The approach here is for prototypes, in their constructor methods,
        to set their own prototypes, preserving the prototype
        chain in cases of multiple levels of inheritance. (Previously, our
        code assumed that a prototype never had a prototype of its own,
        and always used an empty object as a prototype's prototype).

        * bindings/scripts/CodeGeneratorJS.pm: Use the new
        DEFINE_PROTOTYPE_WITH_PROTOTYPE macro in place of the
        KJS_IMPLEMENT_PROTOTYPE_WITH_PARENT macro.
        * khtml/ecma/kjs_dom.cpp: Ditto.
        * khtml/ecma/kjs_dom.h: Ditto.
        * khtml/ecma/kjs_events.cpp: Ditto.

        Touched these files to force a rebuild:

        * bindings/js/JSDOMCore.cpp:
        * bindings/js/JSDOMEvents.cpp:
        * dom/Attr.idl:
        * dom/CharacterData.idl:
        * dom/DOMImplementation.idl:
        * dom/DocumentType.idl:
        * dom/Element.idl:
        * dom/Entity.idl:
        * dom/MutationEvent.idl:
        * dom/Notation.idl:
        * dom/ProcessingInstruction.idl:
        * dom/Text.idl:
        * dom/WheelEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
mjs [Mon, 6 Mar 2006 02:53:41 +0000 (02:53 +0000)]
    Reviewed by Darin.

        - use unsigned bitfields when storing enums in them, to avoid mangling on win32 (was causing all layout to be RTL)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7618

        * css/css_base.cpp:
        (WebCore::CSSSelector::operator == ):
        (WebCore::CSSSelector::selectorText):
        * css/css_base.h:
        (WebCore::CSSSelector::CSSSelector):
        (WebCore::CSSSelector::pseudoType):
        (WebCore::CSSSelector::relation):
        * css/css_grammar.y:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::checkSelector):
        (WebCore::CSSStyleSelector::checkOneSelector):
        * kcanvas/KCanvasPath.cpp:
        (WebCore::operator<<):
        * kcanvas/KCanvasPath.h:
        (WebCore::KCClipData::windRule):
        (WebCore::KCClipDataList::addPath):
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        (WebCore::KCanvasClipperQuartz::applyClip):
        * khtml/ecma/kjs_html.h:
        * khtml/html/HTMLButtonElementImpl.h:
        * khtml/html/HTMLInputElementImpl.cpp:
        (WebCore::HTMLInputElementImpl::setInputType):
        * khtml/html/HTMLInputElementImpl.h:
        (DOM::HTMLInputElementImpl::inputType):
        * khtml/html/html_tableimpl.h:
        * khtml/xbl/xbl_protohandler.cpp:
        (XBL::m_button):
        * khtml/xbl/xbl_protohandler.h:
        * ksvg2/css/SVGRenderStyle.h:
        (WebCore::SVGRenderStyle::InheritedFlags::):
        (WebCore::SVGRenderStyle::NonInheritedFlags::):
        (WebCore::SVGRenderStyle::setBitDefaults):
        * ksvg2/svg/SVGAnimateTransformElementImpl.h:
        * ksvg2/svg/SVGAnimationElementImpl.cpp:
        (SVGAnimationElementImpl::targetAttribute):
        (SVGAnimationElementImpl::setTargetAttribute):
        * ksvg2/svg/SVGAnimationElementImpl.h:
        * ksvg2/svg/SVGLengthImpl.cpp:
        (SVGLengthImpl::value):
        * ksvg2/svg/SVGLengthImpl.h:
        * kwq/KWQKHTMLSettings.h:
        * loader/CachedImage.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::setCachePolicy):
        (WebCore::DocLoader::setShowAnimations):
        * loader/DocLoader.h:
        (WebCore::DocLoader::showAnimations):
        * platform/FontDescription.h:
        (WebCore::FontDescription::genericFamily):
        * platform/QString.cpp:
        (HandleNode::):
        * platform/QString.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::setSelectionState):
        (WebCore::RenderBlock::leftRelOffset):
        (WebCore::RenderBlock::rightRelOffset):
        (WebCore::RenderBlock::leftBottom):
        (WebCore::RenderBlock::rightBottom):
        (WebCore::RenderBlock::addOverhangingFloats):
        (WebCore::RenderBlock::addIntrudingFloats):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::selectionState):
        (WebCore::RenderBlock::FloatingObject::FloatingObject):
        (WebCore::RenderBlock::FloatingObject::type):
        * rendering/RenderTable.h:
        (WebCore::RenderTable::getRules):
        * rendering/bidi.cpp:
        (khtml::BidiContext::BidiContext):
        (khtml::operator==):
        (khtml::embed):
        (khtml::RenderBlock::computeHorizontalPositionsForLine):
        (khtml::RenderBlock::bidiReorderLine):
        (khtml::RenderBlock::layoutInlineChildren):
        * rendering/bidi.h:
        (khtml::BidiContext::dir):
        (khtml::BidiContext::basicDir):
        (khtml::BidiRun::BidiRun):
        * rendering/render_canvasimage.h:
        * rendering/render_layer.h:
        (WebCore::Marquee::whiteSpace):
        * rendering/render_object.cpp:
        (WebCore::RenderObject::paintBorderImage):
        * rendering/render_replaced.cpp:
        (WebCore::RenderWidget::setSelectionState):
        * rendering/render_replaced.h:
        (WebCore::RenderReplaced::selectionState):
        * rendering/render_style.cpp:
        (WebCore::RenderStyle::getPseudoStyle):
        * rendering/render_style.h:
        (khtml::BorderValue::BorderValue):
        (khtml::BorderValue::style):
        (khtml::BorderValue::nonZero):
        (khtml::BorderValue::operator==):
        (khtml::OutlineValue::operator==):
        (khtml::CollapsedBorderValue::style):
        (khtml::BorderImage::horizontalRule):
        (khtml::BorderImage::verticalRule):
        (khtml::BorderData::borderLeftWidth):
        (khtml::BorderData::borderRightWidth):
        (khtml::BorderData::borderTopWidth):
        (khtml::BorderData::borderBottomWidth):
        (khtml::BackgroundLayer::backgroundClip):
        (khtml::BackgroundLayer::backgroundOrigin):
        (khtml::BackgroundLayer::backgroundRepeat):
        (khtml::RenderStyle::styleType):
        (khtml::RenderStyle::display):
        (khtml::RenderStyle::originalDisplay):
        (khtml::RenderStyle::position):
        (khtml::RenderStyle::floating):
        (khtml::RenderStyle::borderLeftStyle):
        (khtml::RenderStyle::borderLeftColor):
        (khtml::RenderStyle::borderRightStyle):
        (khtml::RenderStyle::borderRightColor):
        (khtml::RenderStyle::borderTopStyle):
        (khtml::RenderStyle::borderTopColor):
        (khtml::RenderStyle::borderBottomStyle):
        (khtml::RenderStyle::borderBottomColor):
        (khtml::RenderStyle::outlineWidth):
        (khtml::RenderStyle::outlineStyle):
        (khtml::RenderStyle::overflow):
        (khtml::RenderStyle::visibility):
        (khtml::RenderStyle::verticalAlign):
        (khtml::RenderStyle::unicodeBidi):
        (khtml::RenderStyle::clear):
        (khtml::RenderStyle::tableLayout):
        (khtml::RenderStyle::textAlign):
        (khtml::RenderStyle::textTransform):
        (khtml::RenderStyle::direction):
        (khtml::RenderStyle::whiteSpace):
        (khtml::RenderStyle::backgroundRepeat):
        (khtml::RenderStyle::backgroundClip):
        (khtml::RenderStyle::backgroundOrigin):
        (khtml::RenderStyle::emptyCells):
        (khtml::RenderStyle::captionSide):
        (khtml::RenderStyle::listStyleType):
        (khtml::RenderStyle::listStylePosition):
        (khtml::RenderStyle::cursor):
        (khtml::RenderStyle::pageBreakInside):
        (khtml::RenderStyle::pageBreakBefore):
        (khtml::RenderStyle::pageBreakAfter):
        (khtml::RenderStyle::outlineOffset):
        (khtml::RenderStyle::appearance):
        (khtml::RenderStyle::boxAlign):
        (khtml::RenderStyle::boxDirection):
        (khtml::RenderStyle::boxLines):
        (khtml::RenderStyle::boxOrient):
        (khtml::RenderStyle::boxPack):
        (khtml::RenderStyle::boxSizing):
        (khtml::RenderStyle::marqueeBehavior):
        (khtml::RenderStyle::marqueeDirection):
        (khtml::RenderStyle::userModify):
        (khtml::RenderStyle::userDrag):
        (khtml::RenderStyle::userSelect):
        (khtml::RenderStyle::marginTopCollapse):
        (khtml::RenderStyle::marginBottomCollapse):
        (khtml::RenderStyle::wordWrap):
        (khtml::RenderStyle::nbspMode):
        (khtml::RenderStyle::khtmlLineBreak):
        (khtml::RenderStyle::matchNearestMailBlockquoteColor):
        (khtml::RenderStyle::setBorderLeftWidth):
        (khtml::RenderStyle::setBorderLeftStyle):
        (khtml::RenderStyle::setBorderLeftColor):
        (khtml::RenderStyle::setBorderRightWidth):
        (khtml::RenderStyle::setBorderRightStyle):
        (khtml::RenderStyle::setBorderRightColor):
        (khtml::RenderStyle::setBorderTopWidth):
        (khtml::RenderStyle::setBorderTopStyle):
        (khtml::RenderStyle::setBorderTopColor):
        (khtml::RenderStyle::setBorderBottomWidth):
        (khtml::RenderStyle::setBorderBottomStyle):
        (khtml::RenderStyle::setBorderBottomColor):
        (khtml::RenderStyle::setOutlineWidth):
        (khtml::RenderStyle::setOutlineStyle):
        (khtml::RenderStyle::pseudoState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * Scripts/do-webcore-rename: Fix a couple of things found while testing.
darin [Sun, 5 Mar 2006 20:36:17 +0000 (20:36 +0000)]
    * Scripts/do-webcore-rename: Fix a couple of things found while testing.
        Script now works (after landing my two pending patches).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Rolled out the fix for <rdar://problem/4467143> because it's the
ggaren [Sun, 5 Mar 2006 20:25:53 +0000 (20:25 +0000)]
    - Rolled out the fix for <rdar://problem/4467143> because it's the
        wrong approach. Maciej and I discussed this on IRC.

        * khtml/ecma/kjs_dom.cpp:
        (KJS::): Don't use classInfo to express prototype inheritance.
        classInfo is only for representing a c++ superclass relationship.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - check in a script to do a "big" rename in WebCore
darin [Sun, 5 Mar 2006 19:59:38 +0000 (19:59 +0000)]
    - check in a script to do a "big" rename in WebCore
          (can be run whenever we're ready to do it)

        * Scripts/do-webcore-rename: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-05 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 5 Mar 2006 17:11:21 +0000 (17:11 +0000)]
2006-03-05  Eric Seidel  <eseidel@apple.com>

        Move improperly placed #endif causing no-svg build to fail.

        * kcanvas/device/quartz/KRenderingDeviceQuartz.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-05 Alexander Kellett <lypanov@kde.org>
lypanov [Sun, 5 Mar 2006 14:36:45 +0000 (14:36 +0000)]
2006-03-05  Alexander Kellett  <lypanov@kde.org>

        Reviewed by Eric.

        - missing results from previous commit

        * svg/custom/polyline-invalid-points-expected.checksum: Added.
        * svg/custom/polyline-invalid-points-expected.png: Added.
        * svg/custom/polyline-invalid-points-expected.txt: Added.
        * svg/custom/polyline-setattribute-points-null-expected.checksum:
        Added.
        * svg/custom/polyline-setattribute-points-null-expected.png: Added.
        * svg/custom/polyline-setattribute-points-null-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-05 Alexander Kellett <lypanov@kde.org>
lypanov [Sun, 5 Mar 2006 14:33:18 +0000 (14:33 +0000)]
2006-03-05  Alexander Kellett  <lypanov@kde.org>

        Reviewed by Eric.

        - new reduced testcases for:
          http://bugzilla.opendarwin.org/show_bug.cgi?id=6951
          http://bugzilla.opendarwin.org/show_bug.cgi?id=6890

        * svg/custom/polyline-invalid-points.svg: Added.
        * svg/custom/polyline-setattribute-points-null.svg: Added.

2006-03-05  Alexander Kellett  <lypanov@kde.org>

        Reviewed by Eric.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6890
          and http://bugzilla.opendarwin.org/show_bug.cgi?id=6951
          by being more tolerant towards invalid points data

        - new tests:
          svg/custom/polyline-setattribute-points-null.svg
          svg/custom/polyline-invalid-points.svg

        * ksvg2/svg/svgpathparser.cpp:
        (SVGPolyParser::parsePoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Eric.
mjs [Sun, 5 Mar 2006 11:27:06 +0000 (11:27 +0000)]
    Rubber stamped by Eric.

        - remove no longer used KDOMSettings and KSVGSettings

        * WebCore+SVG/KDOMSettings.cpp: Removed.
        * WebCore+SVG/KDOMSettings.h: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * ksvg2/KSVGSettings.h: Removed.
        * ksvg2/svg/SVGStyledElementImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Sun, 5 Mar 2006 11:12:32 +0000 (11:12 +0000)]
    Reviewed by Eric.

        * Spinneret/Spinneret/WebFrame.cpp:
        (WebKit::WebFrame::loadFilePath): Close file when done.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-05 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 5 Mar 2006 10:30:40 +0000 (10:30 +0000)]
2006-03-05  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        * platform/Font.cpp:
        (WebCore::Font::update): remove extra ref causing large leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix by Mitz Pettel, reviewed by Darin.
ap [Sun, 5 Mar 2006 10:10:43 +0000 (10:10 +0000)]
    Fix by Mitz Pettel, reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7589
          Mouse moved events do not work in DumpRenderTree

WebKitTools:
        * DumpRenderTree/DumpRenderTree.m:
        (-[EventSendingController mouseMoveToX:Y:]): Pass the correct windowNumber in the event.

LayoutTests:
        * fast/css/hover-subselector-expected.txt: Updated results.
        * fast/css/hover-subselector.html: Changed to work with the new mechanism.
        * fast/events/event-sender-mouse-moved-expected.checksum: Added.
        * fast/events/event-sender-mouse-moved-expected.png: Added.
        * fast/events/event-sender-mouse-moved-expected.txt: Added.
        * fast/events/event-sender-mouse-moved.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Patch by Andrew Wellington, reviewed by Eric.
ap [Sun, 5 Mar 2006 09:43:45 +0000 (09:43 +0000)]
    Patch by Andrew Wellington, reviewed by Eric.

        - Remove unused breakpoint bool from StatementNodes. No test provided as
        there is no functionality change.

        * kjs/nodes.cpp:
        (StatementNode::StatementNode):
        * kjs/nodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-04 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 5 Mar 2006 09:42:13 +0000 (09:42 +0000)]
2006-03-04  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Take advantage of new GraphicsContext constructor to implement double buffering to avoid tearing.
        Disable background erase to avoid tearing.
        Fix potential memory smasher from extra long urls.

        * Spinneret/Spinneret/Spinneret.cpp:
        (MyRegisterClass):
        * Spinneret/Spinneret/Spinneret.vcproj:
        * Spinneret/Spinneret/WebFrame.cpp:
        (WebKit::WebFrame::loadFilePath):
        (WebKit::WebFrame::paint):
        * Spinneret/Spinneret/WebView.cpp:
        (WebKit::registerWebViewWithInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-04 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 5 Mar 2006 09:41:40 +0000 (09:41 +0000)]
2006-03-04  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Re-work ImageViewer to use GraphicsContext.
        Add GraphicsContext(cairo_t*) constructor to make double-buffering easier.
        Add one more stub to prevent slashdot from crashing.
        Also fixed win32 build after Font change.

        * Viewer.vcproj:
        * Viewer/ImageView.cpp:
        * platform/Color.h:
        * platform/GraphicsContext.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::createPlugin):
        (BrowserExtensionWin::setTypedIconURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix by Mitz Pettel, reviewed by Darin.
ap [Sun, 5 Mar 2006 09:35:58 +0000 (09:35 +0000)]
    Fix by Mitz Pettel, reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4840
        Frames only resize wider, can't make them narrower

        * khtml/html/html_baseimpl.cpp:
        (WebCore::HTMLFrameSetElementImpl::HTMLFrameSetElementImpl): Removed unused m_resizing flag.
        * khtml/html/html_baseimpl.h:
        * manual-tests/bugzilla-4840.html: Added.
        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::reset):
        (WebCore::FrameView::viewportMouseMoveEvent):
        (WebCore::FrameView::viewportMouseReleaseEvent):
        (WebCore::FrameView::setResizingFrameSet): New method. When a resizing frameset is set,
        mouse move and mouse release events target it instead of hit-testing.
        * page/FrameView.h:
        * rendering/render_frames.cpp:
        (WebCore::RenderFrameSet::setResizing): Inform the FrameView that we are resizing (or not).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 7586, eliminate QFontMetrics.
hyatt [Sun, 5 Mar 2006 05:51:37 +0000 (05:51 +0000)]
    Fix for bug 7586, eliminate QFontMetrics.

        Reviewed by eric

        * WebCore.xcodeproj/project.pbxproj:
        * css/css_valueimpl.cpp:
        (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
        * ksvg2/svg/SVGLengthImpl.cpp:
        (SVGLengthImpl::updateValue):
        * kwq/KWQFontMetrics.h: Removed.
        * kwq/KWQFontMetrics.mm: Removed.
        * platform/Font.cpp:
        (WebCore::m_wordSpacing):
        (WebCore::Font::Font):
        (WebCore::Font::operator=):
        (WebCore::Font::~Font):
        (WebCore::Font::update):
        (WebCore::Font::width):
        * platform/Font.h:
        (WebCore::Font::operator==):
        (WebCore::Font::width):
        (WebCore::Font::height):
        * platform/FontRenderer.h: Added.
        (WebCore::FontRenderer::isFixedPitch):
        * platform/GraphicsContext.h:
        * platform/mac/FontMac.mm: Added.
        (WebCore::m_renderer):
        (WebCore::FontRenderer::getWebCoreFont):
        (WebCore::FontRenderer::getRenderer):
        (WebCore::FontRenderer::determinePitch):
        (WebCore::FontRenderer::update):
        (WebCore::Font::getWebCoreFont):
        (WebCore::Font::ascent):
        (WebCore::Font::descent):
        (WebCore::Font::lineSpacing):
        (WebCore::Font::xHeight):
        (WebCore::Font::isFixedPitch):
        (WebCore::Font::selectionRectForText):
        (WebCore::Font::drawHighlightForText):
        (WebCore::Font::drawText):
        (WebCore::Font::floatWidth):
        (WebCore::Font::checkSelectionPoint):
        * platform/mac/GraphicsContextMac.mm:
        * rendering/InlineTextBox.h:
        * rendering/RenderBlock.cpp:
        (WebCore::stripTrailingSpace):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::trimmedMinMaxWidth):
        * rendering/RenderText.h:
        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::calcMinMaxWidth):
        * rendering/bidi.cpp:
        (khtml::RenderBlock::tabWidth):
        (khtml::RenderBlock::checkLinesForTextOverflow):
        * rendering/render_box.cpp:
        (WebCore::RenderBox::caretRect):
        * rendering/render_br.cpp:
        (WebCore::RenderBR::lineHeight):
        * rendering/render_flow.cpp:
        (WebCore::RenderFlow::lineHeight):
        (WebCore::RenderFlow::caretRect):
        * rendering/render_image.cpp:
        (WebCore::RenderImage::imageChanged):
        (WebCore::RenderImage::paint):
        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::placeBoxesVertically):
        * rendering/render_list.cpp:
        (WebCore::toHebrew):
        (WebCore::RenderListMarker::paint):
        (WebCore::RenderListMarker::calcMinMaxWidth):
        (WebCore::RenderListMarker::baselinePosition):
        (WebCore::RenderListMarker::getRelativeMarkerRect):
        * rendering/render_object.cpp:
        (WebCore::RenderObject::getVerticalPosition):
        (WebCore::RenderObject::lineHeight):
        (WebCore::RenderObject::baselinePosition):
        * rendering/render_object.h:
        * rendering/render_style.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-04 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 5 Mar 2006 00:33:53 +0000 (00:33 +0000)]
2006-03-04  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Hang WebView pointer off of HWND (gets rid of global hack).
        Remove MessageBox displayed on url change.

        * Spinneret/Spinneret/Spinneret.cpp:
        (WndProc):
        (MyEditProc):
        * Spinneret/Spinneret/WebView.cpp:
        (WebKit::registerWebViewWithInstance):
        (WebKit::WebView::createWebView):
        (WebKit::WebViewWndProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-04 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 5 Mar 2006 00:28:19 +0000 (00:28 +0000)]
2006-03-04  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Add urlSelected stub, adjust font metrics, and fix view size/move bug.

        * platform/win/TemporaryLinkStubs.cpp:
        (MouseEvent::MouseEvent):
        (FrameWin::urlSelected):
        (QFontMetrics::height):
        (QFontMetrics::xHeight):
        (QFontMetrics::ascent):
        (QFontMetrics::descent):
        (ScrollView::resizeContents):
        (ScrollView::setContentsPos):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoForgot to save these files before I commited my last change.
thatcher [Sat, 4 Mar 2006 23:07:24 +0000 (23:07 +0000)]
Forgot to save these files before I commited my last change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
ap [Sat, 4 Mar 2006 23:07:22 +0000 (23:07 +0000)]
    Reviewed by Eric.

        Automatically kill httpd if it appears to be already running.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Sat, 4 Mar 2006 23:05:24 +0000 (23:05 +0000)]
    Reviewed by Eric.

        - stop background image loads from crashing

        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawTiledImage):
        (WebCore::GraphicsContext::drawScaledAndTiledImage):

        - fix termination condition on file load loop

        * platform/win/TransferJobWin.cpp:
        (WebCore::TransferJob::fileLoadTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
thatcher [Sat, 4 Mar 2006 22:57:48 +0000 (22:57 +0000)]
    Reviewed by Darin.

        <rdar://problem/4411822> wrong element shown in Inspector inspecting main image at apple.com
        <rdar://problem/4411908> in the Web Inspector, state of disclosure triangles should be preserved after search
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6616
        Bug 6616: Double-clicking on a search result seems broken
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6709
        Bug 6709: TypeError: Value undefined (result of expression treeScrollbar.refresh) is not object.

        Code clean up and move more code into JavaScript.
        Removes a few unused ObjC methods.
        Many search fixes. Reveals the focused node when exiting the search.
        Shows a "No Selection" screen when there are no search results.
        Shows a node count for the number of results.
        Fixes a couple of TypeErrors that show on the console.
        Uses the system selection color in the Style pane tables.

        * English.lproj/Localizable.strings: removed localized strings
        * WebInspector.subproj/WebInspector.m:
        (-[WebInspector init]):
        (-[WebInspector dealloc]):
        (-[WebInspector window]):
        (-[WebInspector setSearchQuery:]):
        (-[WebInspector resizeTopArea]):
        (-[WebInspector searchPerformed:]): called from JavaScript when a search happens
        (-[WebInspector _toggleIgnoreWhitespace:]):
        (-[WebInspector _exitSearch:]): exit search results on double click
        (-[WebInspector _focusRootNode:]):
        (-[WebInspector _revealAndSelectNodeInTree:]):
        (-[WebInspector _refreshSearch]):
        (-[WebInspector _update]):
        (-[WebInspector _updateTraversalButtons]):
        (-[WebInspector _updateRoot]):
        (-[WebInspector _updateTreeScrollbar]):
        (-[WebInspector _updateSystemColors]): update CSS with system colors
        (-[WebInspector webView:didFinishLoadForFrame:]):
        (-[WebInspector webView:plugInViewWithArguments:]):
        (-[WebInspector outlineViewSelectionDidChange:]): test for webViewLoaded
        (-[WebInspectorPrivate init]): alloc rightArrowImage and downArrowImage
        (-[WebInspectorPrivate dealloc]): no more matchedRules
        (-[DOMNode _displayName]): removed localization UI_STRING calls.
        * WebInspector.subproj/WebInspectorInternal.h:
        * WebInspector.subproj/webInspector/inspector.css:
        * WebInspector.subproj/webInspector/inspector.html:
        * WebInspector.subproj/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ggaren [Sat, 4 Mar 2006 20:37:27 +0000 (20:37 +0000)]
    Reviewed by Darin.

        - Fixed <rdar://problem/4467143> JavaScript enumeration of HTML
        element properties skips DOM node properties

        No test case yet because this is a preliminary step toward enabling my
        uber test case for DOM support, which will cover this.

        * khtml/ecma/kjs_dom.cpp:
        (KJS::): Make DOMNode's classinfo reflect inheritance from
        DOMNodeProto, so a for in enumeration can properly walk the
        inheritance chain.
        * khtml/ecma/kjs_html.cpp:
        (KJS::): Used a script to sort classInfo data alphbetically.
        (KJS::KJS::HTMLElement::classInfo): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Sat, 4 Mar 2006 11:02:20 +0000 (11:02 +0000)]
    Reviewed by Eric.

        * Spinneret/Spinneret/WebFrame.cpp:
        (WebKit::WebFrame::loadFilePath): Improved local file loading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Sat, 4 Mar 2006 10:58:29 +0000 (10:58 +0000)]
    Reviewed by Eric.

         - fix mistake in TransferJob::start that made it cause a crash
        on non-file URLs

        * platform/win/TransferJobWin.cpp:
        (WebCore::TransferJob::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Sat, 4 Mar 2006 10:26:22 +0000 (10:26 +0000)]
    Reviewed by Eric.

        - make TransferJobWin handle file: URLs, and fix other bugs
        as needed to make local file image loads work
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7587

        * WebCore.vcproj/WebCore/WebCore.vcproj: add TransferJobWin
        to build.
        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::FrameWin): Set autoLoadImages to true.
        * platform/TransferJob.cpp:
        (WebCore::TransferJob::TransferJob): Pass this to internal
        constructor, so windows version can initialize timer
        * platform/TransferJob.h:
        * platform/TransferJobInternal.h:
        (WebCore::TransferJobInternal::TransferJobInternal): On windows,
        prepare a timer for file loads.
        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawFloatImage): If passed-in context
        is null, use our built-in context (this is probably not the best,
        but should work for now).
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::issueRedoCommand): Don't break.
        (WebCore::TransferJob::assembleResponseHeaders): ditto
        (FrameWin::saveDocumentState): ditto
        (FrameWin::clearUndoRedoOperations): ditto
        * platform/win/TransferJobWin.cpp:
        (WebCore::TransferJobInternal::~TransferJobInternal): Close file
        handle if we have one.
        (WebCore::TransferJob::~TransferJob): Empty.
        (WebCore::TransferJob::start): Open a windows file handle.
        (WebCore::TransferJob::fileLoadTimer): Load from windows file
        handle.
        (WebCore::TransferJob::cancel): Stop timer and close windows file
        handle if present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-03 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 4 Mar 2006 07:42:55 +0000 (07:42 +0000)]
2006-03-03  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Fix QString crasher on Win32, also remove c-style casts from file.
        Add a few more stubs to allow more layout tests to not crash.
        Make dlls only copy when changed.
        Add RenderThemeWin stubs.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.vcproj/WebCore/build-generated-files.sh:
        * platform/QString.cpp:
        (QString::stripWhiteSpace):
        (QString::simplifyWhiteSpace):
        (QString::setLatin1):
        (QString::sprintf):
        (QString::insert):
        (QString::fill):
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::usableScreenRect):
        (FrameWin::respondToChangedContents):
        (FrameWin::unfocusWindow):
        (FrameWin::locationbarVisible):
        (FrameWin::clearUndoRedoOperations):
        (FrameWin::issueRedoCommand):
        (FrameWin::canRedo):
        (FrameWin::canUndo):
        (FrameWin::saveDocumentState):
        (FrameWin::print):
        (FrameWin::issueCutCommand):
        (FrameWin::issueCopyCommand):
        (FrameWin::issueUndoCommand):
        (FrameWin::mimeTypeForFileName):
        (FrameWin::clearRecordedFormValues):
        (FrameWin::issuePasteCommand):
        (FrameWin::scheduleClose):
        (FrameWin::menubarVisible):
        (FrameWin::personalbarVisible):
        (FrameWin::statusbarVisible):
        (FrameWin::toolbarVisible):
        (FrameWin::issueTransposeCommand):
        (FrameWin::canPaste):
        (FrameWin::incomingReferrer):
        (FrameWin::canGoBackOrForward):
        (FrameWin::issuePasteAndMatchStyleCommand):
        (FrameWin::createPlugin):
        (BrowserExtensionWin::getHistoryLength):
        (BrowserExtensionWin::canRunModal):
        (BrowserExtensionWin::openURLNotify):
        (BrowserExtensionWin::canRunModalNow):
        (BrowserExtensionWin::runModal):
        (QListBox::setFont):
        (WebCore::TransferJob::assembleResponseHeaders):
        (WebCore::TransferJob::~TransferJob):
        (QFontMetrics::QFontMetrics):
        (QFontMetrics::lineSpacing):
        (QFontMetrics::xHeight):
        (QFontMetrics::ascent):
        (FrameWin::shouldChangeSelection):
        (FrameWin::generateFrameName):
        (FrameWin::createFrame):
        (RenderThemeWin::paintCheckbox):
        (RenderThemeWin::paintRadio):
        (RenderThemeWin::paintButton):
        (RenderThemeWin::paintTextField):
        * rendering/RenderThemeWin.cpp: Added.
        (WebCore::theme):
        * rendering/RenderThemeWin.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-03 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 4 Mar 2006 07:29:18 +0000 (07:29 +0000)]
2006-03-03  Eric Seidel  <eseidel@apple.com>

        Reviewed by NOBODY (OOPS!).

        A few more fixes to make run-webkit-tests really work on win32.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
        (localFileTest):
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-03 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 4 Mar 2006 01:35:56 +0000 (01:35 +0000)]
2006-03-03  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Make run-webkit-tests work on win32.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
        (localFileTest):
        (dumpRenderTreeMain):
        (dumpRenderTreeToStdOut):
        (serializeToStdOut):
        (main):
        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:
        * Spinneret/Spinneret/WebView.cpp:
        (WebKit::WebView::WebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren [Fri, 3 Mar 2006 23:33:05 +0000 (23:33 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - Fixed <rdar://problem/4465598> REGRESSION (TOT): Crash occurs at
        http://maps.google.com/?output=html ( KJS::Identifier::add(KJS::UString::Rep*)

        This regression was caused by my fix for 4448098. I failed to account for the
        deleted entry sentinel in the mehtod that saves the contents of a property map to
        the back/forward cache.

        Manual test in WebCore/manual-tests/property-map-save-crash.html

        * kjs/property_map.cpp:
        (KJS::deletedSentinel): Use 1 instead of -1 to facilitate an easy bit mask
        (KJS::isValid): New function: checks if a key is null or the deleted sentinel
        (KJS::PropertyMap::~PropertyMap): Fixed up the branch logic here for readability
        and a slight performance win
        (KJS::PropertyMap::clear):
        (KJS::PropertyMap::rehash):
        (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList):
        (KJS::PropertyMap::save): Check keys with isValid()

WebCore:

        Test case for <rdar://problem/4465598> REGRESSION (TOT): Crash occurs at
        http://maps.google.com/?output=html ( KJS::Identifier::add(KJS::UString::Rep*)

        * manual-tests/property-map-save-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-03 Alexander Kellett <lypanov@kde.org>
lypanov [Fri, 3 Mar 2006 22:10:10 +0000 (22:10 +0000)]
2006-03-03  Alexander Kellett  <lypanov@kde.org>

        - local machine unfortunately shows slightly differing results to the
        build bots, reverting to fix the built bot.

        * svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-03 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 3 Mar 2006 19:43:22 +0000 (19:43 +0000)]
2006-03-03  Eric Seidel  <eseidel@apple.com>

        Reviewed by adele.

        Fix clearly bogus cairo elipse drawing code.
        Make QFontMetrics stubs slightly more sane.

        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawEllipse):
        * platform/win/TemporaryLinkStubs.cpp:
        (QFontMetrics::floatWidth):
        (QFontMetrics::height):
        (QFontMetrics::width):
        (QFontMetrics::isFixedPitch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Fri, 3 Mar 2006 15:59:49 +0000 (15:59 +0000)]
LayoutTests:

        Reviewed by Eric.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7480
          non-HTML elems w/o children in HTML docs get serialized self-closing
        - update tests for problem where the HTML tokenizer would discard the
          first newline after </pre>

        * fast/innerHTML/innerHTML-custom-tag.html: Added.
        * fast/innerHTML/innerHTML-custom-tag-expected.txt: Added.

        * fast/innerHTML/005-expected.txt: Updated. Now matches the original document as expected.
        Old result had the <div> after a <pre> put on the same line.

        * editing/inserting/4278698-expected.txt: Updated because offset of node changed since we
        have one more text node (from after a /pre).
        * fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: Ditto.

WebCore:

        Reviewed by Eric.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7480
          non-HTML elems w/o children in HTML docs get serialized self-closing
        - fix problem where the HTML tokenizer would discard the first newline after </pre>

        Test: fast/innerHTML/innerHTML-custom-tag.html

        * editing/markup.cpp: (WebCore::shouldSelfClose): Refined rule so that it doesn't
        try to do any self-closing tags in HTML documents at all; updated comment.

        * khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Added a check
        of beginTag in the <pre> tag case. We were accidentally discarding a newline after
        a </pre> tag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-03 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 3 Mar 2006 09:54:37 +0000 (09:54 +0000)]
2006-03-03  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Add WebFrame class (to hold Frame and FrameView).
        Add Location bar support to Spinneret.

        * Spinneret/Spinneret/Spinneret.cpp:
        (resizeSubViews):
        (_tWinMain):
        (WndProc):
        (MyEditProc):
        * Spinneret/Spinneret/Spinneret.vcproj:
        * Spinneret/Spinneret/WebFrame.cpp: Added.
        (WebKit::WebFrame::WebFramePrivate::WebFramePrivate):
        (WebKit::WebFrame::WebFramePrivate::~WebFramePrivate):
        (WebKit::WebFrame::WebFrame):
        (WebKit::WebFrame::loadFilePath):
        (WebKit::WebFrame::loadHTMLString):
        (WebKit::WebFrame::paint):
        (WebKit::WebFrame::impl):
        (WebKit::WebFrame::viewImpl):
        * Spinneret/Spinneret/WebFrame.h: Added.
        * Spinneret/Spinneret/WebView.cpp:
        (WebKit::WebView::WebViewPrivate::~WebViewPrivate):
        (WebKit::WebView::WebView):
        (WebKit::WebView::windowHandle):
        (WebKit::WebView::mainFrame):
        (WebKit::WebView::mouseMoved):
        (WebKit::WebView::mouseDown):
        (WebKit::WebView::mouseUp):
        (WebKit::WebView::mouseDoubleClick):
        (WebKit::WebViewWndProc):
        * Spinneret/Spinneret/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Eric.
mjs [Fri, 3 Mar 2006 09:44:32 +0000 (09:44 +0000)]
    Rubber stamped by Eric.

        - add new files to build, fix link stubs.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * platform/win/TemporaryLinkStubs.cpp:
        (KWQKCookieJar::cookieEnabled):
        (WebCore::TransferJob::retrieveCharset):
        (WebCore::TransferJob::assembleResponseHeaders):
        (WebCore::TransferJob::~TransferJob):
        * platform/win/TransferJobWin.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - add file I forgot in my last commit.
mjs [Fri, 3 Mar 2006 09:31:37 +0000 (09:31 +0000)]
    - add file I forgot in my last commit.

        * platform/TransferJobInternal.h: Added.
        (WebCore::TransferJobInternal::TransferJobInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-03 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 3 Mar 2006 09:30:11 +0000 (09:30 +0000)]
2006-03-03  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Wire up WidgetWin, CursorWin, ScrollViewWin.
        Stub out methods for selection and cursors.

        * Viewer/ImageDocument.h:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * bridge/win/FrameWin.cpp:
        * khtml/ecma/kjs_proxy.cpp:
        (WebCore::KJSProxyImpl::initScriptIfNeeded):
        * platform/IntRect.h:
        (WebCore::IntRect::IntRect):
        * platform/Widget.h:
        * platform/win/CursorWin.cpp:
        (WebCore::eastResizeCursor):
        (WebCore::northResizeCursor):
        (WebCore::northEastResizeCursor):
        (WebCore::northWestResizeCursor):
        (WebCore::southResizeCursor):
        (WebCore::southEastResizeCursor):
        (WebCore::southWestResizeCursor):
        (WebCore::westResizeCursor):
        * platform/win/IntRectWin.cpp:
        (WebCore::IntRect::IntRect):
        (WebCore::IntRect::operator RECT):
        * platform/win/MouseEventWin.cpp:
        * platform/win/ScrollViewWin.cpp: Added.
        (WebCore::ScrollView::updateContents):
        * platform/win/TemporaryLinkStubs.cpp:
        (QTextEdit::textWithHardLineBreaks):
        (QLineEdit::setPlaceholderString):
        (QScrollBar::scroll):
        (GraphicsContext::beginTransparencyLayer):
        (Widget::setIsSelected):
        (QLineEdit::selectedText):
        (QComboBox::sizeHint):
        (KWQFileButton::focusPolicy):
        (QTextEdit::focusPolicy):
        (QSlider::focusPolicy):
        (QListBox::focusPolicy):
        (QLineEdit::focusPolicy):
        (WebCore::moveCursor):
        (ScrollView::scrollBy):
        (KWQKCookieJar::cookieEnabled):
        (WebCore::TransferJob::TransferJob):
        (WebCore::screenDepth):
        (WebCore::usableScreenRect):
        (FrameWin::getObjectInstanceForWidget):
        (FrameWin::getEmbedInstanceForWidget):
        (FrameWin::getAppletInstanceForWidget):
        (FrameWin::passMouseDownEventToWidget):
        (FrameWin::issuePasteCommand):
        (FrameWin::issueTransposeCommand):
        (QSlider::setFont):
        (QLineEdit::setFont):
        (QListBox::setFont):
        (QFontMetrics::QFontMetrics):
        (QComboBox::setFont):
        (QTextEdit::setFont):
        (QTextEdit::setWritingDirection):
        (QFontMetrics::setFontDescription):
        (QFontMetrics::checkSelectionPoint):
        (FrameWin::addMessageToConsole):
        (FrameWin::shouldChangeSelection):
        (ScrollView::resizeContents):
        (ScrollView::visibleHeight):
        (ScrollView::visibleWidth):
        (ScrollView::setContentsPos):
        (ScrollView::contentsX):
        (ScrollView::contentsY):
        (ScrollView::contentsHeight):
        (ScrollView::contentsWidth):
        (ScrollView::viewportToContents):
        * platform/win/WidgetWin.cpp: Added.
        (WebCore::Widget::Widget):
        (WebCore::Widget::~Widget):
        (WebCore::Widget::windowHandle):
        (WebCore::Widget::setWindowHandle):
        (WebCore::Widget::setActiveWindow):
        (WebCore::Widget::frameGeometry):
        (WebCore::Widget::hasFocus):
        (WebCore::Widget::setFocus):
        (WebCore::Widget::clearFocus):
        (WebCore::Widget::font):
        (WebCore::Widget::setFont):
        (WebCore::Widget::setCursor):
        (WebCore::Widget::show):
        (WebCore::Widget::hide):
        (WebCore::Widget::setFrameGeometry):
        (WebCore::Widget::mapFromGlobal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Fri, 3 Mar 2006 09:19:58 +0000 (09:19 +0000)]
    Reviewed by Eric.

        - move TransferJob from kwq to platform, separate platform from non-platform bits

        * ForwardingHeaders/kio/job.h: Removed.
        * ForwardingHeaders/kio/jobclasses.h: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/MacFrame.mm:
        * dom/xml_tokenizer.cpp:
        * khtml/xsl/xslt_processorimpl.cpp:
        * kwq/KWQKJobClasses.h: Removed.
        * kwq/KWQKJobClasses.mm: Removed.
        * kwq/KWQLoader.mm:
        * kwq/KWQResourceLoader.mm:
        * kwq/TransferJobClient.h: Removed.
        * loader/Cache.cpp:
        * loader/loader.cpp:
        * page/Frame.cpp:
        * platform/TransferJob.cpp: Added.
        (WebCore::TransferJob::TransferJob):
        (WebCore::TransferJob::queryMetaData):
        (WebCore::TransferJob::addMetaData):
        * platform/TransferJob.h: Added.
        * platform/TransferJobClient.h: Added.
        * platform/mac/TransferJobMac.mm: Added.
        (WebCore::TransferJobInternal::~TransferJobInternal):
        (WebCore::TransferJob::retrieveCharset):
        (WebCore::TransferJob::cancel):
        * xml/xmlhttprequest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Fri, 3 Mar 2006 09:18:22 +0000 (09:18 +0000)]
    Reviewed by Eric.

        - enough link stubs to "display" local copy of WebKit site w/o hitting breakpoint

        * platform/win/TemporaryLinkStubs.cpp:
        (QLineEdit::setReadOnly):
        (QTextEdit::setCursorPosition):
        (QLineEdit::setCursorPosition):
        (QFontMetrics::width):
        (GraphicsContext::drawText):
        (GraphicsContext::drawLineForText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Eric.
mjs [Fri, 3 Mar 2006 07:44:54 +0000 (07:44 +0000)]
    Rubber stamped by Eric.

        - remove function that is now gone

        * platform/win/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Fri, 3 Mar 2006 07:41:48 +0000 (07:41 +0000)]
    Reviewed by Eric.

        - move logic to kick off load from KWQLoader function to a TransferJob method

        * kwq/KWQKJobClasses.h:
        * kwq/KWQKJobClasses.mm:
        (WebCore::TransferJob::start):
        * kwq/KWQLoader.h:
        * kwq/KWQLoader.mm:
        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Eric.
mjs [Fri, 3 Mar 2006 07:16:03 +0000 (07:16 +0000)]
    Rubber stamped by Eric.

        - remove unused loader parameter to KWQServeRequest.

        * kwq/KWQLoader.h:
        * kwq/KWQLoader.mm:
        (KWQServeRequest):
        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Fri, 3 Mar 2006 06:58:59 +0000 (06:58 +0000)]
    Reviewed by Eric.

        - remove one of the versions of KWQServeRequest.

        * kwq/KWQLoader.h:
        * kwq/KWQLoader.mm:
        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests):
        * platform/win/TemporaryLinkStubs.cpp:
        (Widget::isEnabled):
        (KWQServeRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Eric.
mjs [Fri, 3 Mar 2006 06:13:02 +0000 (06:13 +0000)]
    Rubber stamped by Eric.

        - win32 build fix.

        * platform/win/MouseEventWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-02 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 3 Mar 2006 05:37:46 +0000 (05:37 +0000)]
2006-03-02  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        * quality/reporting.html: display a nicer message to those using 10.2

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by eric
justing [Fri, 3 Mar 2006 02:53:13 +0000 (02:53 +0000)]
    Reviewed by eric

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=3894>
        uses of <cmath> should change to <math>

        * ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
        * ksvg2/svg/SVGAnimationElementImpl.cpp:
        * ksvg2/svg/SVGHelper.cpp:
        * ksvg2/svg/SVGLengthImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin, landed by Beth.
bdakin [Fri, 3 Mar 2006 01:52:56 +0000 (01:52 +0000)]
    Reviewed by Darin, landed by Beth.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3230
        CSS1: Words with inline elements get extra capital letters

        Update existing tests for new results and add new test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin, landed by Beth
bdakin [Fri, 3 Mar 2006 01:46:40 +0000 (01:46 +0000)]
    Reviewed by Darin, landed by Beth

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3230
        CSS1: Words with inline elements get extra capital letters

        Does not use UBreakIterator (yet?) for this, but a relatively
        simple change that fixes our failure in the CSS1 test suite
        (5.4.5).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-02 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 2 Mar 2006 21:46:12 +0000 (21:46 +0000)]
2006-03-02  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        * Spinneret/Spinneret/WebView.cpp:
        (WebKit::registerWebViewWithInstance):
        (WebKit::WebView::WebView):
        (WebKit::WebView::mouseMoved):
        (WebKit::WebView::mouseDown):
        (WebKit::WebView::mouseUp):
        (WebKit::WebView::mouseDoubleClick):
        (WebKit::WebViewWndProc):
        * Spinneret/Spinneret/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 2 Mar 2006 21:45:07 +0000 (21:45 +0000)]
LayoutTests:

        Patch reviewed by sullivan
        Test written by mitz

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7542>
        REGRESSION: (r13028) Scrolling causes incomplete drawing of <ul> bullets

        * fast/lists/scrolled-marker-paint-expected.checksum: Added.
        * fast/lists/scrolled-marker-paint-expected.png: Added.
        * fast/lists/scrolled-marker-paint-expected.txt: Added.
        * fast/lists/scrolled-marker-paint.html: Added.

WebCore:

        Reviewed by sullivan

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7542>
        REGRESSION: (r13028) Scrolling causes incomplete drawing of <ul> bullets

        * rendering/render_list.cpp:
        (WebCore::RenderListMarker::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-02 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 2 Mar 2006 21:41:25 +0000 (21:41 +0000)]
2006-03-02  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Add (partially stubbed out) mouse event handling for Win32.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * platform/IntPoint.h:
        * platform/MouseEvent.h:
        * platform/win/IntPointWin.cpp: Added.
        (WebCore::IntPoint::IntPoint):
        (WebCore::IntPoint::operator POINT):
        * platform/win/MouseEventWin.cpp: Added.
        (WebCore::MouseEvent::MouseEvent):
        * platform/win/TemporaryLinkStubs.cpp:
        (QLineEdit::setMaxLength):
        (ScrollView::scrollBy):
        (WebCore::Widget::setFocus):
        (FrameWin::respondToChangedSelection):
        (FrameWin::runJavaScriptPrompt):
        (FrameWin::recordFormValue):
        (FrameWin::registerCommandForRedo):
        (FrameWin::runJavaScriptAlert):
        (FrameWin::runJavaScriptConfirm):
        (FrameWin::openURL):
        (FrameWin::registerCommandForUndo):
        (FrameWin::addMessageToConsole):
        (FrameWin::mimeTypeForFileName):
        (FrameWin::shouldChangeSelection):
        (FrameWin::markMisspellingsInAdjacentWords):
        (FrameWin::markMisspellings):
        (FrameWin::personalbarVisible):
        (FrameWin::objectContentType):
        (FrameWin::createFrame):
        (FrameWin::createPlugin):
        (BrowserExtensionWin::setTypedIconURL):
        (BrowserExtensionWin::getHistoryLength):
        (BrowserExtensionWin::canRunModal):
        (BrowserExtensionWin::openURLNotify):
        (BrowserExtensionWin::createNewWindow):
        (BrowserExtensionWin::canRunModalNow):
        (BrowserExtensionWin::runModal):
        (BrowserExtensionWin::goBackOrForward):
        (BrowserExtensionWin::setIconURL):
        (FrameWin::passSubframeEventToSubframe):
        (FrameWin::lastEventIsMouseUp):
        (BrowserExtensionWin::BrowserExtensionWin):
        (Widget::setCursor):
        (ScrollView::visibleHeight):
        (ScrollView::visibleWidth):
        (ScrollView::setContentsPos):
        (ScrollView::contentsX):
        (ScrollView::contentsY):
        (ScrollView::contentsHeight):
        (ScrollView::contentsWidth):
        (ScrollView::viewportToContents):
        (TransferJob::TransferJob):
        (TransferJob::addMetaData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 2 Mar 2006 19:40:40 +0000 (19:40 +0000)]
LayoutTests:

        Reviewed by mjs

        <http://tinymce.moxiecode.com/example_full.php?example=true>
        TinyMCE: Undo still enabled after a location change, crashes if performed

        * editing/undo/undo-iframe-location-change-expected.txt: Added.
        * editing/undo/undo-iframe-location-change.html: Added.

WebCore:

        Reviewed by mjs

        <http://tinymce.moxiecode.com/example_full.php?example=true>
        TinyMCE: Undo still enabled after a location change, crashes if performed

        Can't clear undo/redo operations registered by subframes in didOpenURL,
        because subframes have already been detached.

        * page/Frame.cpp:
        (WebCore::Frame::didOpenURL):
        (WebCore::Frame::closeURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - now fix mac build again
mjs [Thu, 2 Mar 2006 10:35:24 +0000 (10:35 +0000)]
    - now fix mac build again

        * kjs/identifier.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Anders and Eric.
mjs [Thu, 2 Mar 2006 10:20:53 +0000 (10:20 +0000)]
    Rubber stamped by Anders and Eric.

- add fpconst.cpp to win32 build, it is now needed

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * kjs/fpconst.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Thu, 2 Mar 2006 10:10:54 +0000 (10:10 +0000)]
    Reviewed by Eric.

- fix windows build, broken by my last patch

        * kjs/JSImmediate.cpp:
        * kjs/identifier.cpp:
        * kxmlcore/FastMalloc.cpp:
        * kxmlcore/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd svn:eol-style=native, and fix line endings.
eseidel [Thu, 2 Mar 2006 09:21:21 +0000 (09:21 +0000)]
Add svn:eol-style=native, and fix line endings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
mjs [Thu, 2 Mar 2006 09:12:06 +0000 (09:12 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - Set up new prototype macros and avoid using #if without defined() in JSC

        Added new PLATFORM macros and related, to make sure #if's all check if relevant macros
        are defined, and to separate core OS-level dependencies from operating environment
        dependencies so you can, e.g., build KDE on Mac or Windows.

        * kxmlcore/Platform.h: Added.

        - deploy them everywhere in JavaScriptCore

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::convertValueToJValue):
        * bindings/objc/WebScriptObject.mm:
        * bindings/objc/objc_instance.mm:
        (ObjcInstance::end):
        * bindings/softlinking.h:
        * bindings/testbindings.mm:
        (main):
        * kjs/JSLock.cpp:
        * kjs/collector.cpp:
        (KJS::Collector::markCurrentThreadConservatively):
        (KJS::Collector::markOtherThreadConservatively):
        (KJS::Collector::markStackObjectsConservatively):
        * kjs/config.h:
        * kjs/date_object.cpp:
        (gmtoffset):
        (KJS::formatTime):
        (KJS::DateProtoFunc::callAsFunction):
        (KJS::DateObjectImp::construct):
        (KJS::makeTime):
        * kjs/dtoa.cpp:
        * kjs/fpconst.cpp:
        (KJS::sizeof):
        (KJS::):
        * kjs/grammar.y:
        * kjs/identifier.cpp:
        * kjs/internal.cpp:
        * kjs/interpreter.cpp:
        (KJS::Interpreter::evaluate):
        (KJS::Interpreter::createLanguageInstanceForValue):
        * kjs/interpreter.h:
        * kjs/lookup.cpp:
        * kjs/lookup.h:
        * kjs/math_object.cpp:
        * kjs/object.cpp:
        * kjs/object.h:
        * kjs/operations.cpp:
        (KJS::isNaN):
        (KJS::isInf):
        (KJS::isPosInf):
        (KJS::isNegInf):
        * kjs/operations.h:
        * kjs/regexp.cpp:
        (KJS::RegExp::RegExp):
        (KJS::RegExp::~RegExp):
        (KJS::RegExp::match):
        * kjs/regexp.h:
        * kjs/testkjs.cpp:
        (StopWatch::start):
        (StopWatch::stop):
        (StopWatch::getElapsedMS):
        * kjs/ustring.cpp:
        * kjs/ustring.h:
        * kxmlcore/AlwaysInline.h:
        * kxmlcore/Assertions.cpp:
        * kxmlcore/Assertions.h:
        * kxmlcore/FastMalloc.cpp:
        (KXMLCore::):
        * kxmlcore/FastMalloc.h:
        * kxmlcore/FastMallocInternal.h:
        * kxmlcore/HashTable.h:
        * kxmlcore/TCPageMap.h:
        * kxmlcore/TCSpinLock.h:
        (TCMalloc_SpinLock::Lock):
        (TCMalloc_SpinLock::Unlock):
        (TCMalloc_SlowLock):
        * kxmlcore/TCSystemAlloc.cpp:
        (TCMalloc_SystemAlloc):
        * os-win32/stdint.h:

JavaScriptGlue:

        Not reviewed, but I noticed these trivial extra changes were needed to avoid
        breaking the build with my reviewed patch for:

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7387

        Add config.h, includes of it, and Platform.h forwarding header.

        * JSBase.cpp:
        * JSObject.cpp:
        * JSRun.cpp:
        * JSUtils.cpp:
        * JSValueWrapper.cpp:
        * JavaScriptGlue.cpp:
        * UserObjectImp.cpp:
        * config.h: Added.
        * kxmlcore/Platform.h: Added.

WebCore:

        Reviewed by Darin.

        - WebCore updates for "Set up new prototype macros and avoid using #if without defined() in JSC"
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7387

        Add Platform.h

        * ForwardingHeaders/kxmlcore/Platform.h: Added.
        * bridge/mac/WebCoreFrameNamespaces.m:
        * bridge/mac/WebCoreViewFactory.m:
        * bridge/mac/WebDashboardRegion.m:
        * config.h:
        * platform/Logging.cpp:
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::addChild):
        * platform/mac/WebCoreCookieAdapter.m:
        * platform/mac/WebCoreGraphicsBridge.m:
        * platform/mac/WebCoreHistory.m:
        * platform/mac/WebCoreImageRendererFactory.m:
        * platform/mac/WebCoreKeyGenerator.m:
        * platform/mac/WebCoreView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-02 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 2 Mar 2006 08:39:25 +0000 (08:39 +0000)]
2006-03-02  Eric Seidel  <eseidel@apple.com>

        * WebCore.xcodeproj/project.pbxproj: update GraphicsContext.cpp path to fix build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-01 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 2 Mar 2006 08:21:23 +0000 (08:21 +0000)]
2006-03-01  Eric Seidel  <eseidel@apple.com>

        Reviewed by NOBODY (OOPS!).

        Make spinneret take advantage of the new GraphicsContextCairo.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
        (main): updated to match style guidelines.
        * Spinneret/Spinneret/Spinneret.cpp:
        (_tWinMain):
        * Spinneret/Spinneret/WebView.cpp:
        (WebKit::registerWebViewWithInstance):
        (WebKit::WebView::WebView):
        (WebKit::WebView::~WebView):
        (WebKit::WebView::drawRect):
        (WebKit::WndProc):
        * Spinneret/Spinneret/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-01 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 2 Mar 2006 08:20:24 +0000 (08:20 +0000)]
2006-03-01  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Add first-stab GraphicsContextCairo.
        Shuffle a few more link stubs around, remove uncessary WebCore::

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * platform/GraphicsContext.cpp: Added.
        * platform/GraphicsContext.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContextState::GraphicsContextState):
        (WebCore::setColor):
        (WebCore::fillRectSourceOver):
        (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
        (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate):
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):
        (WebCore::GraphicsContext::pen):
        (WebCore::GraphicsContext::setPen):
        (WebCore::GraphicsContext::setBrush):
        (WebCore::GraphicsContext::brush):
        (WebCore::GraphicsContext::save):
        (WebCore::GraphicsContext::restore):
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::setColorFromBrush):
        (WebCore::GraphicsContext::setColorFromPen):
        (WebCore::adjustLineToPixelBounderies):
        (WebCore::GraphicsContext::drawLine):
        (WebCore::GraphicsContext::drawEllipse):
        (WebCore::GraphicsContext::drawArc):
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::drawFloatImage):
        (WebCore::GraphicsContext::drawTiledImage):
        (WebCore::GraphicsContext::drawScaledAndTiledImage):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::addClip):
        (WebCore::GraphicsContext::setPaintingDisabled):
        (WebCore::GraphicsContext::paintingDisabled):
        * platform/cairo/ImageCairo.cpp:
        * platform/cg/GraphicsContextCG.cpp: Removed.
        * platform/win/TemporaryLinkStubs.cpp:
        (QLineEdit::selectAll):
        (Widget::mapFromGlobal):
        (QLineEdit::cursorPosition):
        (QTextEdit::setScrollBarModes):
        (QTextEdit::selectAll):
        (QComboBox::focusPolicy):
        (GraphicsContext::clearShadow):
        (QTextEdit::setCursorPosition):
        (GraphicsContext::drawText):
        (QLineEdit::setLiveSearch):
        (QComboBox::QComboBox):
        (Widget::lockDrawingFocus):
        (QTextEdit::setSelectionRange):
        (QSlider::QSlider):
        (ScrollView::scrollYOffset):
        (QComboBox::sizeHint):
        (QLineEdit::edited):
        (QTextEdit::text):
        (QSlider::value):
        (WebCore::Widget::setFocus):
        (WebCore::TransferJob::addMetaData):
        (FrameWin::respondToChangedContents):
        (FrameWin::unfocusWindow):
        (FrameWin::locationbarVisible):
        (FrameWin::respondToChangedSelection):
        (FrameWin::clearUndoRedoOperations):
        (FrameWin::issueRedoCommand):
        (FrameWin::getObjectInstanceForWidget):
        (FrameWin::getEmbedInstanceForWidget):
        (FrameWin::canRedo):
        (FrameWin::canUndo):
        (FrameWin::runJavaScriptPrompt):
        (FrameWin::recordFormValue):
        (FrameWin::registerCommandForRedo):
        (FrameWin::runJavaScriptAlert):
        (FrameWin::runJavaScriptConfirm):
        (FrameWin::openURL):
        (FrameWin::saveDocumentState):
        (FrameWin::print):
        (FrameWin::getAppletInstanceForWidget):
        (FrameWin::passMouseDownEventToWidget):
        (FrameWin::registerCommandForUndo):
        (FrameWin::issueCutCommand):
        (FrameWin::issueCopyCommand):
        (FrameWin::addMessageToConsole):
        (FrameWin::passWheelEventToChildWidget):
        (FrameWin::issueUndoCommand):
        (FrameWin::mimeTypeForFileName):
        (FrameWin::clearRecordedFormValues):
        (FrameWin::issuePasteCommand):
        (FrameWin::shouldChangeSelection):
        (FrameWin::scheduleClose):
        (FrameWin::markMisspellingsInAdjacentWords):
        (FrameWin::markMisspellings):
        (FrameWin::menubarVisible):
        (FrameWin::personalbarVisible):
        (FrameWin::lastEventIsMouseUp):
        (FrameWin::statusbarVisible):
        (FrameWin::toolbarVisible):
        (FrameWin::issueTransposeCommand):
        (FrameWin::userAgent):
        (FrameWin::canPaste):
        (FrameWin::incomingReferrer):
        (FrameWin::objectContentType):
        (FrameWin::passSubframeEventToSubframe):
        (FrameWin::createFrame):
        (FrameWin::canGoBackOrForward):
        (FrameWin::issuePasteAndMatchStyleCommand):
        (FrameWin::createPlugin):
        (FrameWin::generateFrameName):
        (QTextEdit::setWritingDirection):
        (QFontMetrics::checkSelectionPoint):
        (GraphicsContext::GraphicsContext):
        (QFontMetrics::isFixedPitch):
        (FrameWin::restoreDocumentState):
        (FrameWin::partClearedInBegin):
        (FrameWin::createEmptyDocument):
        (FrameWin::overrideMediaType):
        (FrameWin::setTitle):
        (FrameWin::handledOnloadEvents):
        (FrameWin::markedTextRange):
        (GraphicsContext::font):
        (GraphicsContext::setFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fixed a typo in the comments added in the previous checkin.
ap [Thu, 2 Mar 2006 06:24:18 +0000 (06:24 +0000)]
    Fixed a typo in the comments added in the previous checkin.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
        * WebCoreSupport/WebSubresourceLoader.m:
        (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]):
        (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Thu, 2 Mar 2006 05:58:20 +0000 (05:58 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7540
          REGRESSION: frequent cache-related crashes

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7393
          A stale comment about XMLHttpRequest responses being never cached

        * WebCoreSupport/WebFrameBridge.m: Don't call setHTTPHeader if the method is GET.
        (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
        * WebCoreSupport/WebSubresourceLoader.m: Ditto. Also removed a stale comment about
        XMLHTTPRequests.
        (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]):
        (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Thu, 2 Mar 2006 05:55:43 +0000 (05:55 +0000)]
    Reviewed by Darin.

        Changed an Objective-C forward declaration from "class" to "@class".
        This doesn't appear to fix any problems, though.

        * platform/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoharrison forgot to update these pixel results. We should probably move this test...
justing [Thu, 2 Mar 2006 05:24:05 +0000 (05:24 +0000)]
harrison forgot to update these pixel results.  We should probably move this test out of unsupported-content, since lists are no longer unsupported, but i'll let him do that when he gets back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 2 Mar 2006 05:12:24 +0000 (05:12 +0000)]
LayoutTests:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7059>
        TinyMCE: Select All + delete sends you Back intsead of deleting

        * editing/resources/select-all-iframe-src.html: Added.
        * editing/selection/select-all-iframe-expected.checksum: Added.
        * editing/selection/select-all-iframe-expected.png: Added.
        * editing/selection/select-all-iframe-expected.txt: Added.
        * editing/selection/select-all-iframe.html: Added.

WebCore:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7059>
        TinyMCE: Select All + delete sends you Back intsead of deleting

        * page/Frame.cpp:
        (WebCore::Frame::selectFrameElementInParentIfFullySelected):

WebKitTools:

        Reviewed by darin

        Give the events that eventSender sends a unique eventNumber

        * DumpRenderTree/DumpRenderTree.m:
        (-[EventSendingController mouseDown]):
        (-[EventSendingController mouseUp]):
        (-[EventSendingController mouseMoveToX:Y:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Justin.
harrison [Thu, 2 Mar 2006 03:33:44 +0000 (03:33 +0000)]
    Reviewed by Justin.

        <rdar://problem/4359736> Support outlining ability with lists

        Added Mail SPI for list level changes.  It is SPI because it is not complete support
        for outlining.  See <rdar://problem/4457070> "API for html lists as note outlines".

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _canIncreaseSelectionListLevel]):
        (-[WebHTMLView _canDecreaseSelectionListLevel]):
        (-[WebHTMLView _increaseSelectionListLevel]):
        (-[WebHTMLView _decreaseSelectionListLevel]):
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Justin.
harrison [Thu, 2 Mar 2006 03:32:12 +0000 (03:32 +0000)]
    Reviewed by Justin.
        (missed these in my earlier commit for <rdar://problem/4359736>)

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge canIncreaseSelectionListLevel]):
        (-[WebCoreFrameBridge canDecreaseSelectionListLevel]):
        (-[WebCoreFrameBridge increaseSelectionListLevel]):
        (-[WebCoreFrameBridge decreaseSelectionListLevel]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-01 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 2 Mar 2006 02:43:15 +0000 (02:43 +0000)]
2006-03-01  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Add a stub win32 application to test WebCore drawing on windows.

        * Spinneret: Added.
        * Spinneret/Spinneret: Added.
        * Spinneret/Spinneret.sln: Added.
        * Spinneret/Spinneret/Resource.h: Added.
        * Spinneret/Spinneret/Spinneret.cpp: Added.
        (_tWinMain):
        (MyRegisterClass):
        (InitInstance):
        (WndProc):
        (About):
        * Spinneret/Spinneret/Spinneret.h: Added.
        * Spinneret/Spinneret/Spinneret.ico: Added.
        * Spinneret/Spinneret/Spinneret.rc: Added.
        * Spinneret/Spinneret/Spinneret.vcproj: Added.
        * Spinneret/Spinneret/WebView.cpp: Added.
        (WebKit::WebView::WebViewPrivate::WebViewPrivate):
        (WebKit::WebView::WebViewPrivate::~WebViewPrivate):
        (WebKit::registerWebViewWithInstance):
        (WebKit::WebView::createWebView):
        (WebKit::WebView::WebView):
        (WebKit::WebView::~WebView):
        (WebKit::WebView::drawRect):
        (WebKit::WebView::windowHandle):
        (WebKit::WndProc):
        * Spinneret/Spinneret/WebView.h: Added.
        * Spinneret/Spinneret/small.ico: Added.
        * Spinneret/Spinneret/stdafx.cpp: Added.
        * Spinneret/Spinneret/stdafx.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-01 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 2 Mar 2006 02:17:09 +0000 (02:17 +0000)]
2006-03-01  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix win32 build, add IntRectWin and GraphicsContextCairo stub.

        * Viewer/ImageDocument.cpp:
        * Viewer/ImageMainFrame.cpp:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * platform/IntRect.h:
        * platform/cairo/GraphicsContextCairo.cpp: Added.
        * platform/win/TemporaryLinkStubs.cpp:
        (GraphicsContext::drawLineForText):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::TransferJob::TransferJob):
        (GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Updated test case after improving list deletion.
harrison [Thu, 2 Mar 2006 02:12:15 +0000 (02:12 +0000)]
    Updated test case after improving list deletion.
         <rdar://problem/4359736> Support outlining ability with lists

        * unsupported-content/list-delete-002-expected.txt: Updated.
        * unsupported-content/list-delete-002.html: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Justin.
harrison [Thu, 2 Mar 2006 02:05:21 +0000 (02:05 +0000)]
    Reviewed by Justin.

        <rdar://problem/4359736> Support outlining ability with lists

        Added Mail SPI for list level changes.  It is SPI because it is not complete support
        for outlining.  See <rdar://problem/4457070> "API for html lists as note outlines".
        Additional support is to end a list when return is typed on empty list item.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Added ModifySelectionListLevelCommand.cpp and ModifySelectionListLevelCommand.h

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge canIncreaseSelectionListLevel]):
        (-[WebCoreFrameBridge canDecreaseSelectionListLevel]):
        (-[WebCoreFrameBridge increaseSelectionListLevel]):
        (-[WebCoreFrameBridge decreaseSelectionListLevel]):
        Supply list level calls in the bridge.

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::createListItemElement):
        New.  Creates an li.

        (WebCore::InsertParagraphSeparatorCommand::doApply):
        - slight logic cleanup
        - on empty list item, end the list

        * editing/ModifySelectionListLevelCommand.cpp: Added.
        (WebCore::ModifySelectionListLevelCommand::ModifySelectionListLevelCommand):
        (WebCore::ModifySelectionListLevelCommand::preservesTypingStyle):
        (WebCore::ModifySelectionListLevelCommand::doApply):
        (WebCore::ModifySelectionListLevelCommand::canIncreaseSelectionListLevel):
        (WebCore::ModifySelectionListLevelCommand::canDecreaseSelectionListLevel):
        (WebCore::ModifySelectionListLevelCommand::increaseSelectionListLevel):
        (WebCore::ModifySelectionListLevelCommand::decreaseSelectionListLevel):
        (WebCore::modifySelectionListLevel):
        (WebCore::getStartEndListChildren):
        (WebCore::canIncreaseListLevel):
        (WebCore::canDecreaseListLevel):
        (WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeBefore):
        (WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeAfter):
        (WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange):
        (WebCore::ModifySelectionListLevelCommand::increaseListLevel):
        (WebCore::ModifySelectionListLevelCommand::decreaseListLevel):
        * editing/ModifySelectionListLevelCommand.h: Added.
        New editing command for adjusting the list level.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        Slight logic cleanup

        * editing/htmlediting.cpp:
        (WebCore::isListElement):
        (WebCore::enclosingListChild):
        New helpers.

        (WebCore::isTableElement):
        Allow caller to pass 0... return false in that case.

        * editing/htmlediting.h:
        New helpers.

        * rendering/RenderContainer.cpp:
        (WebCore::updateListMarkerNumbers):
        Allow for list children that are not li nodes.  Ignore and continue rather than stopping.

        (WebCore::RenderContainer::addChild):
        Allow for nil beforeChild, meaning "add at end".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-01 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 2 Mar 2006 02:00:04 +0000 (02:00 +0000)]
2006-03-01  Eric Seidel  <eseidel@apple.com>

        Reviewed by justing.

       Update ESelectionGranulartiy enum to use newer CamelCase styling.

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
        * editing/Selection.cpp:
        (WebCore::Selection::Selection):
        (WebCore::Selection::validate):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyExtendingRightForward):
        (WebCore::SelectionController::modifyMovingRightForward):
        (WebCore::SelectionController::modifyExtendingLeftBackward):
        (WebCore::SelectionController::modifyMovingLeftBackward):
        (WebCore::SelectionController::modify):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * editing/jsediting.cpp:
        * editing/text_granularity.h:
        (WebCore::):
        * page/Frame.cpp:
        (WebCore::Frame::selectClosestWordFromMouseEvent):
        (WebCore::Frame::handleMousePressEventTripleClick):
        (WebCore::Frame::handleMousePressEventSingleClick):
        (WebCore::Frame::handleMouseMoveEventSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-03-01 Alexander Kellett <lypanov@kde.org>
lypanov [Wed, 1 Mar 2006 20:55:02 +0000 (20:55 +0000)]
2006-03-01  Alexander Kellett  <lypanov@kde.org>

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5966

        Fixes already existing test:
          svg/W3C-SVG-1.1/coords-viewattr-02-b.svg

        * kcanvas/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
        (WebCore::RenderSVGImage::paint):
        * kcanvas/RenderSVGImage.h:

2006-03-01  Alexander Kellett  <lypanov@kde.org>

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=5966
          Update expected results

        * svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
        * svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
        * svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoForgot to add the radar to my changelog entries.
thatcher [Wed, 1 Mar 2006 17:56:11 +0000 (17:56 +0000)]
Forgot to add the radar to my changelog entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Wed, 1 Mar 2006 17:54:36 +0000 (17:54 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=3812
          XMLHttpRequest: PUT, DELETE, HEAD and all other methods but POST actually do a GET.

        HEAD is currently unimplemented because of what seems to be a bug in NSURLConnection,
        and does a GET instead.

WebCore:
        * kwq/KWQKJobClasses.h: Add a method parameter to TransferJob.
        * kwq/KWQKJobClasses.mm:
        (WebCore::TransferJobPrivate::TransferJobPrivate):
        (WebCore::TransferJob::TransferJob):
        (WebCore::TransferJob::method):
        * bridge/mac/WebCoreFrameBridge.h: URL loading functions now take a method parameter.
        * dom/xml_tokenizer.cpp:
        (WebCore::openFunc):
        * khtml/xsl/xslt_processorimpl.cpp:
        (DOM::docLoaderFunc):
        * kwq/KWQLoader.mm:
        (KWQServeRequest):
        (KWQServeSynchronousRequest):
        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests):
        * page/Frame.cpp:
        (WebCore::Frame::didOpenURL):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send): Honor the method passed in open().
        * khtml/ecma/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Don't serialize null as "null".

WebKit:
        All WebKit changes are to use the method parameter passed from WebCore.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
        (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
        (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
        * WebCoreSupport/WebSubresourceLoader.h:
        * WebCoreSupport/WebSubresourceLoader.m:
        (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]):
        (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):

LayoutTests:
        * http/tests/xmlhttprequest/methods-async-expected.txt: Added.
        * http/tests/xmlhttprequest/methods-async.html: Added.
        * http/tests/xmlhttprequest/methods-expected.txt: Added.
        * http/tests/xmlhttprequest/methods.cgi: Added.
        * http/tests/xmlhttprequest/methods.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
thatcher [Wed, 1 Mar 2006 17:49:47 +0000 (17:49 +0000)]
WebCore:

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7450
        elementAtPoint is expensive and should return a smart dictionary

        Support for WebKit. This removes the old elementAtPoint: on the bridge.
        WebKit now uses the bridge method getInnerNonSharedNode:innerNode:URLElement:atPoint:

        * WebCore.exp: removes the WebCore* dictionary keys
        * bindings/objc/DOM.mm:
        (-[DOMElement image]): new method to get an NSImage if the element has an image renderer
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLElement titleDisplayString]): new method that returns the title after doing the backslash as currency symbol conversion
        (-[DOMHTMLInputElement altDisplayString]): ditto for alt
        (-[DOMHTMLImageElement altDisplayString]): ditto
        (-[DOMHTMLAppletElement altDisplayString]): ditto
        (-[DOMHTMLAreaElement altDisplayString]): ditto
        (-[DOMHTMLAnchorElement absoluteLinkURL]): new method to get the absolute NSURL
        (-[DOMHTMLAreaElement absoluteLinkURL]): ditto
        (-[DOMHTMLLinkElement absoluteLinkURL]): ditto
        (-[DOMHTMLInputElement absoluteImageURL]): new method to get the absolute image location as an NSURL
        (-[DOMHTMLImageElement absoluteImageURL]): ditto
        (-[DOMHTMLObjectElement absoluteImageURL]): ditto
        * bindings/objc/DOMPrivate.h:
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:]):
        (-[WebCoreFrameBridge isPointInsideSelection:]):
        * dom/DocumentImpl.cpp:
        (WebCore::DocumentImpl::prepareMouseEvent):
        (WebCore::DocumentImpl::backslashAsCurrencySymbol):
        * dom/DocumentImpl.h:
        * rendering/render_layer.cpp:
        (WebCore::RenderLayer::hitTest):
        * rendering/render_object.h:
        (WebCore::RenderObject::NodeInfo::URLElement):
        (WebCore::RenderObject::NodeInfo::setURLElement):

WebKit:

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7450
        elementAtPoint is expensive and should return a smart dictionary

        elementAtPoint for WebHTMLView now returns a WebElementDictionary,
        when objectForKey is called it will lookup in the DOM, cache and return the value

        * Misc/WebElementDictionary.h: Added.
        * Misc/WebElementDictionary.m: Added.
        (addLookupKey):
        (cacheValueForKey):
        (+[WebElementDictionary initializeLookupTable]):
        (-[WebElementDictionary initWithInnerNonSharedNode:innerNode:URLElement:andPoint:]):
        (-[WebElementDictionary dealloc]):
        (-[WebElementDictionary _fillCache]):
        (-[WebElementDictionary count]):
        (-[WebElementDictionary keyEnumerator]):
        (-[WebElementDictionary objectForKey:]):
        (-[WebElementDictionary _domNode]):
        (-[WebElementDictionary _webFrame]):
        (-[WebElementDictionary _targetWebFrame]):
        (-[WebElementDictionary _title]):
        (-[WebElementDictionary _imageRect]):
        (-[WebElementDictionary _isSelected]):
        * Misc/WebNSViewExtras.m:
        (-[NSView _web_dragImage:element:rect:event:pasteboard:source:offset:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.m:
        (-[WebHTMLView _updateMouseoverWithEvent:]):
        (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
        (-[NSArray elementAtPoint:]):
        * WebView/WebView.m:
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Wed, 1 Mar 2006 16:33:49 +0000 (16:33 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7327
          REGRESSION (r12869): :hover subselector does not work in quirks mode

        * fast/css/hover-subselector-expected.checksum: Added.
        * fast/css/hover-subselector-expected.png: Added.
        * fast/css/hover-subselector-expected.txt: Added.
        * fast/css/hover-subselector.html: Added.

WebCore:

        Test: fast/css/hover-subselector.html

        Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7327
          REGRESSION (r12869): :hover subselector does not work in quirks mode

        * css/cssstyleselector.h:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::checkSelector): Pass flag to indicate sub-selector.
        (WebCore::CSSStyleSelector::checkOneSelector): Apply the *:hover and *:active quirks only
        when there are no sub-selectors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Hyatt.
mjs [Wed, 1 Mar 2006 09:12:05 +0000 (09:12 +0000)]
    Rubber stamped by Hyatt.

        - fix win32 build (and make dumprendertree run)

        * kwq/KWQComboBox.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (QTextEdit::selectionEnd):
        (Widget::~Widget):
        (GraphicsContext::beginTransparencyLayer):
        (QComboBox::populate):
        (GraphicsContext::drawConvexPolygon):
        (QFontMetrics::selectionRectForText):
        (GraphicsContext::setShadow):
        (GraphicsContext::clearFocusRing):
        (GraphicsContext::drawImageInRect):
        (KWQFileButton::setFilename):
        (KWQFileButton::focusPolicy):
        (KWQFileButton::frameGeometry):
        (QSlider::focusPolicy):
        (WebCore::GraphicsContext::font):
        (QTextEdit::setWritingDirection):
        (QFontMetrics::checkSelectionPoint):
        (QFontMetrics::isFixedPitch):
        (WebCore::TransferJob::addMetaData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13068 268f45cc-cd09-0410-ab3c-d52691b4dbfc