WebKit-https.git
8 years agoUnreviewed, rolling out r143895.
commit-queue@webkit.org [Mon, 25 Feb 2013 15:42:09 +0000 (15:42 +0000)]
Unreviewed, rolling out r143895.
http://trac.webkit.org/changeset/143895
https://bugs.webkit.org/show_bug.cgi?id=110758

broke a bunch of tests (Requested by thakis__ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-25

* Scripts/update-webkit-chromium:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Remove CPU profile from a group causes exception
commit-queue@webkit.org [Mon, 25 Feb 2013 15:22:39 +0000 (15:22 +0000)]
Web Inspector: Remove CPU profile from a group causes exception
https://bugs.webkit.org/show_bug.cgi?id=110466

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-25
Reviewed by Yury Semikhatsky.

WebInspector.ProfilesPanel._removeProfileHandle did not handle
profile removal from a group. The fix takes care of this case.

Test: inspector/profiler/cpu-profiler-profile-removal.html

Source/WebCore:

* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):

LayoutTests:

* inspector/profiler/cpu-profiler-profile-removal-expected.txt: Added.
* inspector/profiler/cpu-profiler-profile-removal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Edit my personal info.
yoli@rim.com [Mon, 25 Feb 2013 15:15:06 +0000 (15:15 +0000)]
Unreviewed. Edit my personal info.

    * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed follow-up to r143725, reduce chances test flakes on a slow box.
caseq@chromium.org [Mon, 25 Feb 2013 15:10:15 +0000 (15:10 +0000)]
Unreviewed follow-up to r143725, reduce chances test flakes on a slow box.

* src/js/Tests.js:
(.TestSuite.prototype.testPageOverlayUpdate.step2):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoXSSAuditor tests shouldn't depend on IFrames's load order.
mkwst@chromium.org [Mon, 25 Feb 2013 14:53:52 +0000 (14:53 +0000)]
XSSAuditor tests shouldn't depend on IFrames's load order.
https://bugs.webkit.org/show_bug.cgi?id=110737

Reviewed by Jochen Eisinger.

Various tests under http/tests/security/xssAuditor actually wrap up
multiple test cases under a single HTML file by loading a variety of
IFrames. Currently, the error messages that these tests expect aren't
detailed enough to distinguish between the order in which the IFrames
load: they all generate the same error, so the ordering is irrelevant.

Before we increase the error message detail in webkit.org/b/110733, we
need to ensure that these tests don't rely on load order. One option
is to serialize the IFrame loading by chaining onload events, but that
seems like a slow way of doing things. This patch takes a different
approach, breaking the multiple-IFrame tests into many single-IFrame
tests (which should be more shardable, and actually execute more quickly
in the long run).

* http/tests/security/xssAuditor/open-iframe-src-expected.txt: Removed.
* http/tests/security/xssAuditor/open-iframe-src.html: Removed.
* http/tests/security/xssAuditor/open-script-src-expected.txt: Removed.
* http/tests/security/xssAuditor/open-script-src.html: Removed.
* http/tests/security/xssAuditor/property-escape-comment-expected.txt: Removed.
* http/tests/security/xssAuditor/property-escape-comment.html: Removed.
* http/tests/security/xssAuditor/property-escape-entity-expected.txt: Removed.
* http/tests/security/xssAuditor/property-escape-entity.html: Removed.
* http/tests/security/xssAuditor/property-escape-quote-expected.txt: Removed.
* http/tests/security/xssAuditor/property-escape-quote.html: Removed.
* http/tests/security/xssAuditor/script-tag-with-comma-expected.txt: Removed.
* http/tests/security/xssAuditor/script-tag-with-comma.html: Removed.
* http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt: Removed.
* http/tests/security/xssAuditor/script-tag-with-source-unterminated.html: Removed.
    Removed these tests, breaking them into multiple single-IFrame HTML files.
* http/tests/security/xssAuditor/open-iframe-src-01.html: Added.
* http/tests/security/xssAuditor/open-iframe-src-02.html: Added.
* http/tests/security/xssAuditor/open-script-src-01-expected.txt: Added.
* http/tests/security/xssAuditor/open-script-src-01.html: Added.
* http/tests/security/xssAuditor/open-script-src-02-expected.txt: Added.
* http/tests/security/xssAuditor/open-script-src-02.html: Added.
* http/tests/security/xssAuditor/open-script-src-03-expected.txt: Added.
* http/tests/security/xssAuditor/open-script-src-03.html: Added.
* http/tests/security/xssAuditor/open-script-src-04-expected.txt: Added.
* http/tests/security/xssAuditor/open-script-src-04.html: Added.
* http/tests/security/xssAuditor/property-escape-comment-01-expected.txt: Added.
* http/tests/security/xssAuditor/property-escape-comment-01.html: Added.
* http/tests/security/xssAuditor/property-escape-comment-02-expected.txt: Added.
* http/tests/security/xssAuditor/property-escape-comment-02.html: Added.
* http/tests/security/xssAuditor/property-escape-comment-03-expected.txt: Added.
* http/tests/security/xssAuditor/property-escape-comment-03.html: Added.
* http/tests/security/xssAuditor/property-escape-entity-01-expected.txt: Added.
* http/tests/security/xssAuditor/property-escape-entity-01.html: Added.
* http/tests/security/xssAuditor/property-escape-entity-02-expected.txt: Added.
* http/tests/security/xssAuditor/property-escape-entity-02.html: Added.
* http/tests/security/xssAuditor/property-escape-entity-03-expected.txt: Added.
* http/tests/security/xssAuditor/property-escape-entity-03.html: Added.
* http/tests/security/xssAuditor/property-escape-quote-01.html: Added.
* http/tests/security/xssAuditor/property-escape-quote-02.html: Added.
* http/tests/security/xssAuditor/property-escape-quote-03.html: Added.
* http/tests/security/xssAuditor/script-tag-with-comma-01-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-comma-01.html: Added.
* http/tests/security/xssAuditor/script-tag-with-comma-02-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-comma-02.html: Added.
* http/tests/security/xssAuditor/script-tag-with-source-unterminated-01-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-source-unterminated-01.html: Added.
* http/tests/security/xssAuditor/script-tag-with-source-unterminated-02-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-source-unterminated-02.html: Added.
* http/tests/security/xssAuditor/script-tag-with-source-unterminated-03-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-source-unterminated-03.html: Added.
* http/tests/security/xssAuditor/script-tag-with-trailing-comment5.html: Added.
    These tests perform the same validation as the combined tests, they
    simply do it without introducing load-order dependencies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, fix simple mistake in r143903.
akling@apple.com [Mon, 25 Feb 2013 14:14:40 +0000 (14:14 +0000)]
Unreviewed, fix simple mistake in r143903.
<http://webkit.org/b/110746>

Reviewed by Andreas Kling.

Pass git revision, not svn revision, to git shell command.

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.timestamp_of_latest_commit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Disable registerProtocolHandler on Android
commit-queue@webkit.org [Mon, 25 Feb 2013 14:06:37 +0000 (14:06 +0000)]
[Chromium] Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=110481

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-25
Reviewed by Julien Chaffraix.

Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
actually wired up internally. Disable the feature to avoid breaking feature detection until
we can implement it properly. Previous attempt is at http://trac.webkit.org/changeset/133465
See the discussion of the future implementation at http://crbug.com/156386

* features.gypi: Disable the flag for Android, enable it only for non-Android platforms.

* src/ChromeClientImpl.h: Declaration is now guarded by the flag, not to break Android.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Mon, 25 Feb 2013 14:06:23 +0000 (14:06 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Let built-product-archive log which directory it's archiving from and...
thakis@chromium.org [Mon, 25 Feb 2013 13:59:17 +0000 (13:59 +0000)]
[chromium] Let built-product-archive log which directory it's archiving from and extracting to
https://bugs.webkit.org/show_bug.cgi?id=110748

Reviewed by Jochen Eisinger.

One of the mac testers runs DRT from out/ but WebKitUnitTests from
xcodebuild. I'm trying to understand what's going on.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
(extractBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Mon, 25 Feb 2013 13:50:33 +0000 (13:50 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Native Memory Instrumentation: replace String with const char* in...
loislo@chromium.org [Mon, 25 Feb 2013 13:37:35 +0000 (13:37 +0000)]
Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
https://bugs.webkit.org/show_bug.cgi?id=110599

Reviewed by Yury Semikhatsky.

Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
that were given us via MemoryInstrumentation calls.
So I extended client api with registerString method that pushes the strings
down to the serializer.

Source/WebCore:

* css/InspectorCSSOMWrappers.h:
* inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportNodeImpl):
(WebCore::HeapGraphSerializer::reportEdgeImpl):
(WebCore::HeapGraphSerializer::registerString):
(WebCore::HeapGraphSerializer::registerTypeString):
(WebCore::HeapGraphSerializer::addRootNode):
* inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::registerString):
(WebCore):
* inspector/MemoryInstrumentationImpl.h:
(MemoryInstrumentationClientImpl):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):

Source/WTF:

* wtf/MemoryInstrumentation.h:
(MemoryInstrumentationClient):
* wtf/MemoryObjectInfo.h:
(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::setClassName):
(WTF::MemoryObjectInfo::classNameId):
(WTF::MemoryObjectInfo::setName):
(WTF::MemoryObjectInfo::nameId):
(MemoryObjectInfo):

Tools:

* TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
* TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
(TestWebKitAPI::Helper::Helper):
(Helper):
(TestWebKitAPI::Helper::addNode):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Mon, 25 Feb 2013 13:21:10 +0000 (13:21 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a scrollbar class for the new calendar picker
keishi@webkit.org [Mon, 25 Feb 2013 13:20:09 +0000 (13:20 +0000)]
Add a scrollbar class for the new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110589

Reviewed by Kent Tamura.

Adding a scrollbar to be used in the new calendar picker (Bug 109439).

No new tests. Code is not used yet.

* Resources/pagepopups/calendarPicker.js:
(ScrubbyScrollBar):
(ScrubbyScrollBar.prototype.height):
(ScrubbyScrollBar.prototype.setHeight):
(ScrubbyScrollBar.prototype.setThumbHeight): Sets the height of the scroll bar thumb.
(ScrubbyScrollBar.prototype._setThumbPositionFromEvent): Sets the thumb position from a mouse event.
(ScrubbyScrollBar.prototype.onMouseDown):
(ScrubbyScrollBar.prototype.onWindowMouseMove):
(ScrubbyScrollBar.prototype.onWindowMouseUp):
(ScrubbyScrollBar.prototype.onThumbStyleTopAnimationStep): Animates the thumb back to the center position.
(ScrubbyScrollBar.prototype.onScrollTimer): Fires repeatedly while the thumb is being dragged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake ScriptError not crash when args is a tuple
thakis@chromium.org [Mon, 25 Feb 2013 13:16:00 +0000 (13:16 +0000)]
Make ScriptError not crash when args is a tuple
https://bugs.webkit.org/show_bug.cgi?id=110747

Reviewed by Jochen Eisinger.

I'm trying to understand the error on
http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
better. I'll likely have to revert the ninja switch on windows, but
having error reporting code that doesn't itself crash sounds like a
good thing to have anyways.

The problem is that '%s' % (1, 2) errors out, and args is sometimes a
tuple not a list.

* Scripts/run-chromium-webkit-unit-tests:
* Scripts/webkitpy/common/system/executive.py:
(ScriptError.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry][ARM] Fix cast-align warnings in JavaScriptCore
commit-queue@webkit.org [Mon, 25 Feb 2013 13:13:43 +0000 (13:13 +0000)]
[BlackBerry][ARM] Fix cast-align warnings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=110738

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-02-25
Reviewed by Rob Buis.

Use reinterpret_cast_ptr instead of reinterpret_cast for
pointers.

* dfg/DFGOperations.cpp:
* heap/CopiedBlock.h:
(JSC::CopiedBlock::zeroFillWilderness):
* heap/WeakBlock.h:
(JSC::WeakBlock::asWeakImpl):
(JSC::WeakBlock::asFreeCell):
(JSC::WeakBlock::weakImpls):
* heap/WeakImpl.h:
(JSC::WeakImpl::asWeakImpl):
* interpreter/JSStack.cpp:
(JSC::JSStack::disableErrorStackReserve):
* interpreter/JSStack.h:
(JSC::JSStack::reservationEnd):
* runtime/ArrayStorage.h:
(JSC::ArrayStorage::from):
* runtime/Butterfly.h:
(JSC::Butterfly::indexingPayload):
* runtime/IndexingHeader.h:
(JSC::IndexingHeader::propertyStorage):
* runtime/JSActivation.h:
(JSC::JSActivation::tearOff):
(JSC::JSActivation::isTornOff):
(JSC::JSActivation::storage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Mon, 25 Feb 2013 13:10:09 +0000 (13:10 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Mon, 25 Feb 2013 13:02:06 +0000 (13:02 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Mon, 25 Feb 2013 12:56:16 +0000 (12:56 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Align feature defaults
commit-queue@webkit.org [Mon, 25 Feb 2013 12:36:00 +0000 (12:36 +0000)]
[EFL] Align feature defaults
https://bugs.webkit.org/show_bug.cgi?id=110715

Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
OptionsEfl.cmake.

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-25
Reviewed by Gyuyoung Kim.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix of closure type annotations.
loislo@chromium.org [Mon, 25 Feb 2013 12:31:18 +0000 (12:31 +0000)]
Unreviewed. Fix of closure type annotations.

* inspector/front-end/UISourceCode.js:
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorun-perf-tests reports wrong commit time
rniwa@webkit.org [Mon, 25 Feb 2013 12:26:14 +0000 (12:26 +0000)]
run-perf-tests reports wrong commit time
https://bugs.webkit.org/show_bug.cgi?id=110746

Reviewed by Andreas Kling.

The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
of when the subdirectory was last modified.

Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
insufficient since running "svn log -r <revision>" on a partial checkout only returns
an empty result if the revision didn't modify the subdirectory.

For git, there is no partial checkout, so we just need to pass in "-r" option to keep
the interface compatible with svn.

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.timestamp_of_latest_commit):
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.timestamp_of_latest_commit):
* Scripts/webkitpy/common/checkout/scm/scm_mock.py:
(MockSCM.timestamp_of_latest_commit):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(test_timestamp_of_latest_commit):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.timestamp_of_latest_commit):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_results_dict):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Network] Timeline bars and dividers are positioned in different coord...
eustas@chromium.org [Mon, 25 Feb 2013 11:45:27 +0000 (11:45 +0000)]
Web Inspector: [Network] Timeline bars and dividers are positioned in different coordinate systems.
https://bugs.webkit.org/show_bug.cgi?id=109943

Reviewed by Pavel Feldman.

Look at network log: red bar (on load) is positioned to the right of
the last required load.

This is incorrect. For exmaple, in case of short event it should be
positioned in the center of the bar.

* inspector/front-end/DataGrid.js:
Fix - hidden columns can have non-zero width.
* inspector/front-end/NetworkPanel.js: Use correct width for calculator.
* inspector/front-end/networkLogView.css: Removed parasite paddinds.
Extracted common absolute "paddings".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd list view for new calendar picker
keishi@webkit.org [Mon, 25 Feb 2013 11:31:09 +0000 (11:31 +0000)]
Add list view for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110140

Reviewed by Kent Tamura.

Adding list view class to be used in the new calendar picker (Bug 109439).

No new tests. Code is not yet used.

* Resources/pagepopups/calendarPicker.js:
(ListCell): One row inside the list view. We reuse
list cells to avoid animation hiccups caused by memory allocation.
(ListCell.prototype._recycleBin): Returns array to
store thrown away list cells so we can reuse them.
(ListCell.prototype.throwAway): Hides the cell and puts it in the recycle bin.
(ListCell.prototype.show):
(ListCell.prototype.hide): Hide the cell when we don't need the cell any more.
(ListCell.prototype.width):
(ListCell.prototype.setWidth):
(ListCell.prototype.position):
(ListCell.prototype.setPosition): Sets the CSS transform to position the cell.
(ListCell.prototype.setSelected): Adds selected CSS class.
(ListView): Shows a scrolling list.
(ListView.prototype.onAnimationFrameWillFinish): Calls updateCells if the cells need to be updated.
(ListView.prototype.setNeedsUpdateCells): Mark the cells as need to be updated.
(ListView.prototype.cellAtRow): Returns the cell at a given row. If the cell is not visible and doesn't exist, returns undefined.
(ListView.prototype.rowAtScrollOffset): The row that is displayed at the given scroll offset.
(ListView.prototype.scrollOffsetForRow): The scroll offset for the top of a given row.
(ListView.prototype.addCellIfNecessary): Adds the cell for a given row.
(ListView.prototype.prepareNewCell): Prepares a new or recycled cell for a given row.
(ListView.prototype.throwAwayCell): Throws a way a cell.
(ListView.prototype.firstVisibleRow): The first visible row at the top of the view.
(ListView.prototype.lastVisibleRow): The last visible row at the bottom of the view.
(ListView.prototype.scrollViewDidChangeContentOffset):
(ListView.prototype.scrollViewDidChangeHeight):
(ListView.prototype.scrollViewDidChangePartition):
(ListView.prototype.updateCells): Updates all the cells that are visible.
(ListView.prototype.width):
(ListView.prototype.setWidth):
(ListView.prototype.height):
(ListView.prototype.setHeight):
(ListView.prototype.onClick): Clicking on a row selects it.
(ListView.prototype.select):
(ListView.prototype.deselect):
(ListView.prototype.scrollToRow): Scrolls to a given row.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move profile type specific code out of ProfilesPanel (refactor)
commit-queue@webkit.org [Mon, 25 Feb 2013 10:53:00 +0000 (10:53 +0000)]
Web Inspector: move profile type specific code out of ProfilesPanel (refactor)
https://bugs.webkit.org/show_bug.cgi?id=110597

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-25
Reviewed by Yury Semikhatsky.

Move profile type specific functionality out of ProfilesPanel class.
This is a first part of WebInspector.ProfilesPanel refactoring.

No new tests as the functionality isn't changed.

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.addProfileHeader):
(WebInspector.CPUProfileType.prototype.removeProfile):
(WebInspector.CPUProfileType.prototype._requestProfilesFromBackend):
(WebInspector.CPUProfileType.prototype.resetProfiles):
(WebInspector.CPUProfileType.prototype.addHeapSnapshotChunk):
(WebInspector.CPUProfileType.prototype.finishHeapSnapshot):
(WebInspector.CPUProfileType.prototype.reportHeapSnapshotProgress):
* inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype._stopRecordingProfile):
* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileType.prototype.buttonClicked):
(WebInspector.CanvasProfileType.prototype._runSingleFrameCapturing):
(WebInspector.CanvasProfileType.prototype._startFrameCapturing):
(WebInspector.CanvasProfileType.prototype._didStartCapturingFrame):
(WebInspector.CanvasProfileType.prototype._reset):
(WebInspector.CanvasProfileType.prototype.removeProfile):
(WebInspector.CanvasProfileHeader.prototype.dispose):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotProfileType):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapSnapshotProfileType.prototype.addProfileHeader):
(WebInspector.HeapSnapshotProfileType.prototype.addHeapSnapshotChunk):
(WebInspector.HeapSnapshotProfileType.prototype.finishHeapSnapshot):
(WebInspector.HeapSnapshotProfileType.prototype.reportHeapSnapshotProgress):
(WebInspector.HeapSnapshotProfileType.prototype.resetProfiles):
(WebInspector.HeapSnapshotProfileType.prototype.removeProfile):
(WebInspector.HeapSnapshotProfileType.prototype._requestProfilesFromBackend):
(WebInspector.HeapProfileHeader.prototype._updateTransferProgress):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotProfileType):
(WebInspector.NativeSnapshotProfileType.prototype.addNativeSnapshotChunk):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType):
(WebInspector.ProfileType.prototype.buttonClicked):
(WebInspector.ProfileType.prototype.get description):
(WebInspector.ProfileType.prototype.getProfiles):
(WebInspector.ProfileType.prototype.getProfile):
(WebInspector.ProfileType.prototype._makeKey):
(WebInspector.ProfileType.prototype.addProfile):
(WebInspector.ProfileType.prototype.removeProfile):
(WebInspector.ProfileType.prototype.findTemporaryProfile):
(WebInspector.ProfileType.prototype._reset):
(WebInspector.ProfileType.prototype._requestProfilesFromBackend):
(WebInspector.ProfileHeader):
(WebInspector.ProfileHeader.prototype.dispose):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._loadFromFile):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype._populateAllProfiles):
(WebInspector.ProfilesPanel.prototype.wasShown):
(WebInspector.ProfilesPanel.prototype._profilerWasEnabled):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._registerProfileType.onAddProfileHeader):
(WebInspector.ProfilesPanel.prototype._registerProfileType.onRemoveProfileHeader):
(WebInspector.ProfilesPanel.prototype._registerProfileType.onProgressUpdated):
(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype._createTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._removeTemporaryProfile):
(WebInspector.ProfilesPanel.prototype.getProfile):
(WebInspector.ProfilesPanel.prototype.showProfile):
(WebInspector.ProfilesPanel.prototype._getAllProfiles):
(WebInspector.ProfilesPanel.prototype._searchableViews):
(WebInspector.ProfilesPanel.prototype.searchCanceled):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype._reportProfileProgress):

LayoutTests:

* inspector/profiler/canvas2d/canvas-replay-log-grid.html:
* inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt:
* inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
* inspector/profiler/heap-snapshot-loader.html:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):
* inspector/profiler/profiler-test.js:
(initialize_ProfilerTest.InspectorTest.startProfilerTest.startTest):
(initialize_ProfilerTest.InspectorTest.startProfilerTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Skipped failing tests.
kadam@inf.u-szeged.hu [Mon, 25 Feb 2013 10:40:45 +0000 (10:40 +0000)]
[Qt] Unreviewed gardening. Skipped failing tests.

* platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/select-baseline-expected.txt: Removed.
* platform/qt-5.0/fast/forms/select-baseline-expected.png: Removed.
* platform/qt-5.0/fast/forms/select-baseline-expected.txt: Removed.
* platform/qt/TestExpectations:
* platform/qt/fast/forms/select-baseline-expected.png: Update after r143836.
* platform/qt/fast/forms/select-baseline-expected.txt: Update after r143836.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] move WebRuntimeFeatures configuration to TestRunner library
jochen@chromium.org [Mon, 25 Feb 2013 10:33:37 +0000 (10:33 +0000)]
[chromium] move WebRuntimeFeatures configuration to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=110712

Reviewed by Nico Weber.

* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Mon, 25 Feb 2013 10:04:57 +0000 (10:04 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Unskip tests after r143800.
zarvai@inf.u-szeged.hu [Mon, 25 Feb 2013 09:56:04 +0000 (09:56 +0000)]
[Qt] Unreviewed gardening. Unskip tests after r143800.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake ninja the default build system for build-webkit --chromium on windows
thakis@chromium.org [Mon, 25 Feb 2013 09:48:43 +0000 (09:48 +0000)]
Make ninja the default build system for build-webkit --chromium on windows
https://bugs.webkit.org/show_bug.cgi?id=110731

Reviewed by Jochen Eisinger.

With http://crbug.com/169945 fixed, this should now work.

* Scripts/update-webkit-chromium:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed fix of type annotation for this._liveLocations.
loislo@chromium.org [Mon, 25 Feb 2013 09:48:29 +0000 (09:48 +0000)]
Unreviewed fix of type annotation for this._liveLocations.

* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix style errors in WebCore/editing/{htmlediting,markup,visible_units}.*
tkent@chromium.org [Mon, 25 Feb 2013 09:42:09 +0000 (09:42 +0000)]
Fix style errors in WebCore/editing/{htmlediting,markup,visible_units}.*
https://bugs.webkit.org/show_bug.cgi?id=110721

Reviewed by Ryosuke Niwa.

No new tests. This should not make any bahevior changes.

* editing/htmlediting.cpp:
(WebCore::lowestEditableAncestor):
(WebCore):
(WebCore::isSpecialElement):
(WebCore::enclosingListChild):
(WebCore::canMergeLists):
(WebCore::tabSpanNode):
(WebCore::isNodeRendered):
(WebCore::caretMaxOffset):
* editing/htmlediting.h:
(WebCore):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendElement):
* editing/markup.h:
(WebCore):
* editing/visible_units.cpp:
(WebCore::previousRootInlineBoxCandidatePosition):
(WebCore::nextRootInlineBoxCandidatePosition):
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::previousBoundary):
(WebCore::endOfLine):
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
(WebCore::nextSentencePositionBoundary):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 25 Feb 2013 09:41:31 +0000 (09:41 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Giving up on individually listing slow sputnik tests, replaced all
the expectations with a single one covering the whole directory in both release and debug builds.
Also removing duplicate expectations and adding an expectation for tests that require custom elements support.
* platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Rebaselining.
* platform/gtk/media/audio-controls-rendering-expected.png: Removed. Requires a new baseline.
* platform/gtk/media/audio-controls-rendering-expected.txt: Removed. Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Mon, 25 Feb 2013 09:29:38 +0000 (09:29 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Improve speed of Linkifier.reset operation.
loislo@chromium.org [Mon, 25 Feb 2013 09:10:11 +0000 (09:10 +0000)]
Web Inspector: Improve speed of Linkifier.reset operation.
https://bugs.webkit.org/show_bug.cgi?id=110696

Reviewed by Yury Semikhatsky.

Linkifier calls Location.dispose N times and each dispose method calls Array.remove
which scans entire array and does splice. So the complexity of Linkifier.reset
is O(N^2). I replaced the arrays with Set and got O(N) complexity.

Drive by fix: The identifier generator was slightly changed.
Now it produces identifiers that couldn't be converted into a number.
So the engine will never convert Set/Map object into an array.

Source/WebCore:

* inspector/front-end/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.updateLocations):
(WebInspector.Script.prototype.createLiveLocation):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.addLiveLocation):
(WebInspector.UISourceCode.prototype.updateLiveLocations):
* inspector/front-end/utilities.js:

LayoutTests:

* inspector/debugger/callstack-placards-discarded.html:
* inspector/debugger/linkifier.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] ChromeClientBlackBerry: fix variable names
commit-queue@webkit.org [Mon, 25 Feb 2013 08:09:17 +0000 (08:09 +0000)]
[BlackBerry] ChromeClientBlackBerry: fix variable names
https://bugs.webkit.org/show_bug.cgi?id=110562

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-25
Reviewed by Rob Buis.

manager was incorrectly renamed back to tracker in r138696:
http://trac.webkit.org/changeset/138696/trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] GeolocationClientBlackBerry: add missing headers
commit-queue@webkit.org [Mon, 25 Feb 2013 07:35:15 +0000 (07:35 +0000)]
[BlackBerry] GeolocationClientBlackBerry: add missing headers
https://bugs.webkit.org/show_bug.cgi?id=110563

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-24
Reviewed by Benjamin Poulain.

Frame.h and SecurityOrigin.h are necessary since r136969.
GeolocationPosition.h since r132360.

* WebCoreSupport/GeolocationClientBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r143797.
commit-queue@webkit.org [Mon, 25 Feb 2013 07:27:04 +0000 (07:27 +0000)]
Unreviewed, rolling out r143797.
http://trac.webkit.org/changeset/143797
https://bugs.webkit.org/show_bug.cgi?id=110724

Causes assertion failures in multiple tests. (Requested by
vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-24

* dom/DocumentParser.h:
(DocumentParser):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
* html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::shouldUseThreading):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRollout r143556, it regressed html5-full-render perf.
morrita@google.com [Mon, 25 Feb 2013 07:00:12 +0000 (07:00 +0000)]
Rollout r143556, it regressed html5-full-render perf.
https://bugs.webkit.org/show_bug.cgi?id=110719

Unreviewed rollout.

* css/BasicShapeFunctions.cpp:
(WebCore::convertToLength):
(WebCore::basicShapeForValue):
* css/BasicShapeFunctions.h:
(WebCore):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::gradientWithStylesResolved):
* css/CSSGradientValue.h:
(CSSGradientValue):
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::style):
(WebCore::CSSToStyleMap::rootElementStyle):
(WebCore::CSSToStyleMap::useSVGZoomRules):
(WebCore::CSSToStyleMap::styleImage):
* css/CSSToStyleMap.h:
(WebCore):
(WebCore::CSSToStyleMap::CSSToStyleMap):
(CSSToStyleMap):
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyExclusionShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
* css/StyleBuilder.h:
(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
* css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::findSiblingForStyleSharing):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::applyPropertyToCurrentStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::checkForZoomChange):
(WebCore::StyleResolver::checkForGenericFamilyChange):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::styleShader):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createCustomFilterOperation):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::loadPendingResources):
(WebCore::StyleResolver::reportMemoryUsage):
* css/StyleResolver.h:
(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::hasParentNode):
(StyleResolver):
(WebCore::StyleResolver::isRightPage):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::document):
(State):
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::styleMap):
(WebCore::StyleResolver::fontDescription):
(WebCore::StyleResolver::parentFontDescription):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] cleanup MediaPlayerPrivateAVFoundation and InbandTextTrackPrivateAVF
eric.carlson@apple.com [Mon, 25 Feb 2013 03:57:26 +0000 (03:57 +0000)]
[Mac] cleanup MediaPlayerPrivateAVFoundation and InbandTextTrackPrivateAVF
https://bugs.webkit.org/show_bug.cgi?id=110716

Reviewed by Alexey Proskuryakov.

No new tests, no functionality changed.

* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF): Take AVFInbandTrackParent*
    instead of MediaPlayerPrivateAVFoundation*.
(WebCore::InbandTextTrackPrivateAVF::processCue): Pass new cues directly to the client.
(WebCore::InbandTextTrackPrivateAVF::disconnect): m_player -> m_owner.
(WebCore::InbandTextTrackPrivateAVF::setMode):  m_player -> m_owner.
* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::addGenericCue): Delete, no longer needed.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Don't include
    CachedResourceClient.h, it isn't needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd an ASSERT to didChangeDeviceProximity
kihong.kwon@samsung.com [Mon, 25 Feb 2013 02:02:13 +0000 (02:02 +0000)]
Add an ASSERT to didChangeDeviceProximity
https://bugs.webkit.org/show_bug.cgi?id=110317

Reviewed by Hajime Morrita.

Source/WebCore:

Add An ASSERT to didChangeDeviceProximity function to check range of value.

Change exist test cases.

* Modules/proximity/DeviceProximityController.cpp:
(WebCore::DeviceProximityController::didChangeDeviceProximity):

LayoutTests:

Fix wrong test cases which are found by ASSERT insertion.

* proximity/basic-operation-expected.txt:
* proximity/basic-operation.html:
* proximity/resources/event-after-navigation-new.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Clarify meaning of default default encoding localizable string
ap@apple.com [Mon, 25 Feb 2013 00:14:24 +0000 (00:14 +0000)]
    Clarify meaning of default default encoding localizable string
        https://bugs.webkit.org/show_bug.cgi?id=110714

        Reviewed by Eric Carlson.

        * English.lproj/Localizable.strings: This string is only used on Windows, and it's
        very confusing to everyone involved.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSP 1.1: Experiment with 'reflected-xss' directive.
mkwst@chromium.org [Sun, 24 Feb 2013 22:40:23 +0000 (22:40 +0000)]
CSP 1.1: Experiment with 'reflected-xss' directive.
https://bugs.webkit.org/show_bug.cgi?id=104479

Reviewed by Adam Barth.

Source/WebCore:

Content Security Policy 1.1 defines a 'reflected-xss' directive that
works in much the same way as WebKit's current 'X-XSS-Protection'
header[1]. This patch implements the new directive by parsing it
inside ContentSecurityPolicy, and exposing that state to XSSAuditor.

XSSAuditor now grabs the CSP directive's state, and mixes it with the
X-XSS-Protection header's state to determine how the page should be
handled. Moreover, both headers' states are now expressed in terms of
ContentSecurityPolicy::ReflectedXSSDisposition.

[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#reflected-xss--experimental

Tests: http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-allow.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-unset.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-allow.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid.html
       http/tests/security/contentSecurityPolicy/1.1/reflected-xss-parsing.html

* html/parser/XSSAuditor.cpp:
(WebCore::combineXSSProtectionHeaderAndCSP):
    Given both headers' states, return the state which the XSSAuditor
    should use when parsing a page. Blocking overrides filtering, which
    overrides disabling.
(WebCore):
(WebCore::XSSAuditor::init):
    Process the 'X-XSS-Protection' header before grabbing the CSP
    header's state. Both are passed into the new
    combineXSSProtectionHeaderAndCSP method to generate the final
    state that ought to be used.
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::filterToken):
* html/parser/XSSAuditor.h:
    Switch to ContentSecurityPolicy::ReflectedXSSDisposition internally
    in XSSAuditor.
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::reflectedXSSDisposition):
    Enum defining the possible state of the 'reflected-xss' CSP directive.
(CSPDirectiveList):
(WebCore::CSPDirectiveList::CSPDirectiveList):
(WebCore::CSPDirectiveList::parseReflectedXSS):
    Given a 'reflected-xss' directive's value, set the
    ReflectedXSSDisposition into a new property on the CSPDirectiveList.
(WebCore):
(WebCore::CSPDirectiveList::addDirective):
    Accept 'reflected-xss' as a valid directive if we're in
    experimental mode.
(WebCore::ContentSecurityPolicy::reflectedXSSDisposition):
    Expose the directive's state via the public API.
(WebCore::ContentSecurityPolicy::reportInvalidReflectedXSS):
    Generate console errors when invalid reflected-xss directive values
    are encounted during parsing.
* page/ContentSecurityPolicy.h:
* platform/network/HTTPParsers.cpp:
(WebCore::parseXSSProtectionHeader):
* platform/network/HTTPParsers.h:
(WebCore):
    Start using ContentSecurityPolicy::ReflectedXSSDisposition rather
    than the XSSProtectionDisposition enum.

LayoutTests:

* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-allow-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-allow.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-unset-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-unset.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-allow-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-allow.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-parsing-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/reflected-xss-parsing.html: Added.
* http/tests/security/contentSecurityPolicy/resources/reflected-xss-and-xss-protection.js: Added.
(testMixedHeader):
(frameLoaded):
(frameErrored):
* http/tests/security/xssAuditor/resources/echo-intertag.pl:
    Added the ability to send an 'X-WebKit-CSP' header to test 'reflected-xss' behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Rename ENABLE_REGIONS to ENABLE_CSS_REGIONS
commit-queue@webkit.org [Sun, 24 Feb 2013 21:11:15 +0000 (21:11 +0000)]
[EFL] Rename ENABLE_REGIONS to ENABLE_CSS_REGIONS
https://bugs.webkit.org/show_bug.cgi?id=110699

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-24
Reviewed by Andreas Kling.

Fix a typo. ENABLE_REGIONS is called ENABLE_CSS_REGIONS
throughout the project.

* Source/cmake/OptionsEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r143837): Broke build on AppleWin http://build.webkit.org/builders/Apple...
benjamin@webkit.org [Sun, 24 Feb 2013 20:33:44 +0000 (20:33 +0000)]
REGRESSION(r143837): Broke build on AppleWin build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29.
https://bugs.webkit.org/show_bug.cgi?id=110713

Unreviewed.

* WebKit.vcproj/WebKitExports.def.in: Add the missing symbol after r143837.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdating GObject bindings baselines after r143863.
zandobersek@gmail.com [Sun, 24 Feb 2013 20:31:36 +0000 (20:31 +0000)]
Updating GObject bindings baselines after r143863.

Unreviewed.

* bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Stop generating UserAgentGtk.h
zandobersek@gmail.com [Sun, 24 Feb 2013 19:01:20 +0000 (19:01 +0000)]
[GTK] Stop generating UserAgentGtk.h
https://bugs.webkit.org/show_bug.cgi?id=110582

Reviewed by Martin Robinson.

.:

* configure.ac: Provide the USER_AGENT_GTK_(MAJOR|MINOR)_VERSION defines in the autotoolsconfig.h
header, containing the user agent versions that are to be used in the user agent string. The
WEBKIT_USER_AGENT_(MAJOR|MINOR)_VERSION name is avoided as the same defines are specified in the
webkitversion.h API header (but are not accessible from the WebCore layer). The UserAgentGtk.h
header is also not generated anymore from the input file.

Source/WebCore:

No new tests - no new functionality.

* GNUmakefile.list.am: Move the UserAgentGtk.h build target from the derived sources list to
the list of the WebCore platform sources.
* platform/gtk/UserAgentGtk.cpp:
(WebCore::standardUserAgent): Rename WEBKIT_USER_AGENT_(MAJOR|MINOR)_VERSION to
USER_AGENT_GTK_(MAJOR|MINOR)_VERSION.
* platform/gtk/UserAgentGtk.h: Renamed from Source/WebCore/platform/gtk/UserAgentGtk.h.in.
Same as the input file expect for removed WEBKIT_USER_AGENT_(MAJOR|MINOR)_VERSION defines that
are now replaced by using the USER_AGENT_GTK_(MAJOR|MINOR)_VERSION defines placed in autotoolsconfig.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
kov@webkit.org [Sun, 24 Feb 2013 17:42:28 +0000 (17:42 +0000)]
[GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
https://bugs.webkit.org/show_bug.cgi?id=110702

Reviewed by Martin Robinson.

Source/WebCore:

No tests. Build fix, no behaviour change.

* platform/gtk/GtkVersioning.h: include the autotoolsconfig.h header,
which contains the GTK_API_VERSION_2 define now.

Source/WebKit/gtk:

* tests/testapplicationcache.c: include autotoolsconfig.h.
* tests/testatk.c: ditto.
* tests/testatkroles.c: ditto.
* tests/testcontextmenu.c: ditto.
* tests/testcopyandpaste.c: ditto.
* tests/testdomdocument.c: ditto.
* tests/testdomdomwindow.c: ditto.
* tests/testdomnode.c: ditto.
* tests/testdownload.c: ditto.
* tests/testfavicondatabase.c: ditto.
* tests/testglobals.c: ditto.
* tests/testhittestresult.c: ditto.
* tests/testhttpbackend.c: ditto.
* tests/testkeyevents.c: ditto.
* tests/testloading.c: ditto.
* tests/testmimehandling.c: ditto.
* tests/testnetworkrequest.c: ditto.
* tests/testnetworkresponse.c: ditto.
* tests/testwebbackforwardlist.c: ditto.
* tests/testwebdatasource.c: ditto.
* tests/testwebframe.c: ditto.
* tests/testwebhistoryitem.c: ditto.
* tests/testwebinspector.c: ditto.
* tests/testwebplugindatabase.c: ditto.
* tests/testwebresource.c: ditto.
* tests/testwebsettings.c: ditto.
* tests/testwebview.c: ditto.
* tests/testwindow.c: ditto.

Tools:

* GtkLauncher/main.c: include autotoolsconfig.h.
* Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
the include ordering check, since it uses autotoolsconfig.h which needs to
come first.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStyledElement: Don't expose a mutable direct interface to the inline style.
akling@apple.com [Sun, 24 Feb 2013 16:45:21 +0000 (16:45 +0000)]
StyledElement: Don't expose a mutable direct interface to the inline style.
<http://webkit.org/b/110711>

Reviewed by Antti Koivisto.

Source/WebCore:

Remove the ability to grab at a mutable StylePropertySet* for a StyledElement's inline style
from the outside world. It's now private and returns MutableStylePropertySet* for future convenience.

Three paths to changing the inline style remain:

    - Setting the "style" attribute
    - Via CSSOM (element.style)
    - setInlineStyleProperty/removeInlineStyleProperty helpers

* dom/StyledElement.cpp:
(WebCore::StyledElement::ensureMutableInlineStyle):
* dom/StyledElement.h:
(StyledElement):
* editing/ApplyStyleCommand.cpp:
(WebCore::copyStyleOrCreateEmpty):
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
* html/canvas/CanvasStyle.cpp:
(WebCore::currentColor):

Source/WebKit/qt:

QWebElement::styleProperty() is a read-only method, so rewrite it to use StyledElement::inlineStyle().

* Api/qwebelement.cpp:
(QWebElement::styleProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd methods to date types for new calendar picker
keishi@webkit.org [Sun, 24 Feb 2013 16:42:41 +0000 (16:42 +0000)]
Add methods to date types for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110454

Reviewed by Kent Tamura.

Source/WebCore:

Adding some methods to date types as part of the calendar picker redesign (Bug 109439).

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types.html

* Resources/pagepopups/calendarPicker.js:
(createUTCDate):
(DateType): Base class for Day, Week and Month.
(Day): Simplified constructor to only accept year, month, date.
(Day.createFromValue): Creates a new Day from a value.
(Day.createFromDate): Throw an error if the given date is invalid.
(Day.createFromDay):
(Day.prototype.equals): Accept non Day objects.
(Day.prototype.previous): Modified to take an offset value.
(Day.prototype.next): Ditto.
(Day.prototype.firstDay): Returns the first day in the range. For Day's case, returns itself.
(Day.prototype.middleDay): Returns the middle day in the range. For Day's case, returns itself.
(Day.prototype.lastDay): Returns the middle day in the range. For Day's case, returns itself.
(Day.prototype.valueOf):
(Day.prototype.weekDay): Returns the week day.
(Week): Simplified constructor to only accept year, month, date.
(Week.createFromValue):
(Week.createFromDate):
(Week.createFromDay):
(Week.weekOneStartDateForYear):
(Week.weekOneStartDayForYear):
(Week._numberOfWeeksSinceDate):
(Week.prototype.equals):
(Week.prototype.previous):
(Week.prototype.next):
(Week.prototype.firstDay): Returns the first day in the week.
(Week.prototype.middleDay): Returns the the day for Thursday.
(Week.prototype.lastDay): Returns the last day in the week.
(Week.prototype.valueOf):
(Month):
(Month.createFromValue):
(Month.createFromDate):
(Month.createFromDay):
(Month.prototype.containsDay):
(Month.prototype.equals):
(Month.prototype.previous):
(Month.prototype.next):
(Month.prototype.firstDay): Returns the first day in the month.
(Month.prototype.middleDay): Returns the middle day in the month.
(Month.prototype.lastDay): Returns the last day in the month.
(Month.prototype.valueOf):
(Month.prototype.toLocaleString): Moved location.
(Month.prototype.toShortLocaleString): Returns the month string in short format.
(CalendarPicker): Use createFromValue.
(YearMonthController.prototype.setMonth): Ditto.
(YearMonthController.prototype.moveRelatively): Ditto.

LayoutTests:

* platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types.html: Added. Unit tests for date types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] FatFingers: move rectForPoint() from HitTestResult to HitTestLocation
commit-queue@webkit.org [Sun, 24 Feb 2013 15:23:26 +0000 (15:23 +0000)]
[BlackBerry] FatFingers: move rectForPoint() from HitTestResult to HitTestLocation
https://bugs.webkit.org/show_bug.cgi?id=110570

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-24
Reviewed by Allan Sandfeld Jensen.

HitTestResult is no longer a HitTestLocation:
http://trac.webkit.org/changeset/135710/trunk/Source/WebCore/rendering/HitTestResult.h

* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::fingerRectForPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Custom Elements] Implement bare-bone document.register()
morrita@google.com [Sun, 24 Feb 2013 13:21:42 +0000 (13:21 +0000)]
[Custom Elements] Implement bare-bone document.register()
https://bugs.webkit.org/show_bug.cgi?id=100229

Reviewed by Adam Barth.

Source/WebCore:

This change implements a prefixed version of document.register(), with minimal feature support.
- The feature is guarded by ENABLE(CUSTOM_ELEMENTS) and RuntimeEnabledFeatures::customDOMElementsEnabled().
- This bare-bone version only recognizes "name" and "prototype" parameters. It doesn't support default value of "prototype" parameter.
- Currently only V8 is supported. JSC binding needs its own binding implementation.

= Major new classes under dom/:

The dom module gets two new classes:
- CustomElementConstructor: A return value of document.register()
  which holds the custom element definition.
- CustomElementRegistry: A collection of CustomElementConstructor objects.
  CustomElementRegistry instance is created per Document and is owned by the Document.

CustomElementConstructor knows the definition of each custom
element, which is registered by document.register(). The name and
other options are held by this object. CustomElementRegistry owns a set
of the registered constructors. The registry guarantees invariants
like validity and uniqueness of the element names.

= A change on make_names.pl

This change tweaks make_names.pl (or generated HTMLElementFactory)
to hook the creations of unknown elements. Some of element names
which come to the fallback path can be one of registered custom
element.

= [V8WrapAsFunction] extended attribute:

The document.register() API returns a constructor
function. However, the V8 binding currently doesn't support it. To
make it possible, this change introduces "V8WrapAsFunction"
extended attribute for annotating CustomElementConstructor IDL
interface.

V8WrapAsFunction wraps the annotated interface with a JavaScript
function, which calls the original object as a function, or as a
constructor depends on the context.

With this wrapper function, there are two levels of indirection
between native C++ object and author-visible JS function:

[JS Adaptor Function] <-(hidden property)-> [JS Wrapper Object] -(internal field)-> [C++ Native object]

The code generator generates the binding code which deals with
this indirection.  Also, there is a set of helper functions in
V8AdaptorFunction.h/cpp which takes care of this indirection.
V8DOMWrapper.cpp/h works as a facade for these APIs and is used from
the generated code.

This redundancy comes from limitations of both V8 bindings and V8
embedding API. See bug 108138 for details.

= V8HTMLCustomElement

Unlike built-in HTML elements, any custom element has no
corresponding C++ class. Instead, document.register() should allow
passing a prototype object for the elements being registered.

V8HTMLCustomElement handles this lack of native class.  It behaves
like a native side proxy of non-native HTMLElement subclasses.  It
connects each custom element to an appropriate native element,
which is HTMLElement at this time. This restriction will be
relaxed later. See Bug 110436 for details.

= Custom DOM elements and multiple worlds

In this patch, custom element registration and instantiation is not allowed
in non-main world and document.register() API just fails there.

Reviewed by Adam Barth.

Tests: fast/dom/custom/document-register-basic.html
       fast/dom/custom/document-register-reentrant-null-constructor.html
       fast/dom/custom/document-register-reentrant-returning-fake.html
       fast/dom/custom/document-register-reentrant-throwing-constructor.html

* DerivedSources.make:
* WebCore.gypi:
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::customDOMElementsEnabled):
(WebCore::RuntimeEnabledFeatures::setCustomDOMElements):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/IDLAttributes.txt:
* bindings/v8/CustomElementHelpers.cpp: Added.
(WebCore::CustomElementHelpers::initializeConstructorWrapper):
(WebCore::hasNoBuiltinsInPrototype):
(WebCore::CustomElementHelpers::isValidPrototypeParameter):
(WebCore::CustomElementHelpers::isFeatureAllowed):
* bindings/v8/CustomElementHelpers.h: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.
(CustomElementHelpers):
* bindings/v8/V8AdaptorFunction.cpp: Added.
(WebCore::V8AdaptorFunction::getTemplate):
(WebCore::V8AdaptorFunction::configureTemplate):
(WebCore::V8AdaptorFunction::invocationCallback):
(WebCore::V8AdaptorFunction::wrap):
* bindings/v8/V8AdaptorFunction.h: Added.
(V8AdaptorFunction):
(WebCore::V8AdaptorFunction::unwrap):
(WebCore::V8AdaptorFunction::get):
* bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::configureTemplate):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::toFunction):
(WebCore::V8DOMWrapper::fromFunction):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
* bindings/v8/V8HTMLCustomElement.cpp: Added.
(WebCore::V8HTMLCustomElement::createWrapper):
* bindings/v8/V8HTMLCustomElement.h: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.
(V8HTMLCustomElement):
(WebCore::V8HTMLCustomElement::toV8):
(WebCore::HTMLCustomElement::toV8):
* bindings/v8/V8HiddenPropertyName.h:
* bindings/v8/custom/V8CustomElementConstructorCustom.cpp: Added.
(WebCore::V8CustomElementConstructor::callAsFunctionCallback):
* dom/CustomElementConstructor.cpp: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.
(WebCore::CustomElementConstructor::create):
(WebCore::CustomElementConstructor::CustomElementConstructor):
(WebCore::CustomElementConstructor::~CustomElementConstructor):
(WebCore::CustomElementConstructor::createElement):
* dom/CustomElementConstructor.h: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.
(CustomElementConstructor):
(WebCore::CustomElementConstructor::document):
(WebCore::CustomElementConstructor::tagName):
(WebCore::CustomElementConstructor::name):
* dom/CustomElementConstructor.idl: Added.
* dom/CustomElementRegistry.cpp: Added.
(WebCore::CustomElementRegistry::CustomElementRegistry):
(WebCore::CustomElementRegistry::~CustomElementRegistry):
(WebCore::CustomElementRegistry::constructorOf):
(WebCore::CustomElementRegistry::isValidName):
(WebCore::CustomElementRegistry::registerElement):
(WebCore::CustomElementRegistry::find):
(WebCore::CustomElementRegistry::createElement):
(WebCore::CustomElementRegistry::document):
* dom/CustomElementRegistry.h: Added.
(CustomElementRegistry):
* dom/Document.cpp:
(WebCore::Document::removedLastRef):
(WebCore::Document::registerElement):
(WebCore::Document::registry):
* dom/Document.h:
(Document):
* dom/make_names.pl:
(printWrapperFactoryCppFile):
* html/HTMLDocument.idl:

Source/WebKit/chromium:

Added enableCustomDOMElements flag.

* features.gypi:
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableCustomDOMElements):
(WebKit):
(WebKit::WebRuntimeFeatures::isCustomDOMElementsEnabled):

Tools:

Added enableCustomDOMElements flag.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

LayoutTests:

* fast/dom/custom/document-register-basic-expected.txt: Added.
* fast/dom/custom/document-register-basic.html: Added.
* fast/dom/custom/document-register-reentrant-null-constructor-expected.txt: Added.
* fast/dom/custom/document-register-reentrant-null-constructor.html: Added.
* fast/dom/custom/document-register-reentrant-returning-fake-expected.txt: Added.
* fast/dom/custom/document-register-reentrant-returning-fake.html: Added.
* fast/dom/custom/document-register-reentrant-throwing-constructor-expected.txt: Added.
* fast/dom/custom/document-register-reentrant-throwing-constructor.html: Added.
* fast/dom/custom/resources/document-register-fuzz.js: Added.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Timeline] Shrink CPU bars to make it easier to see frame information...
eustas@chromium.org [Sun, 24 Feb 2013 13:18:17 +0000 (13:18 +0000)]
Web Inspector: [Timeline] Shrink CPU bars to make it easier to see frame information popup.
https://bugs.webkit.org/show_bug.cgi?id=110561

Reviewed by Pavel Feldman.

Area that causes frame information popup is overly "shaded" by CPU bars.

* inspector/front-end/timelinePanel.css:
(.timeline-cpu-bars .timeline-graph-bar): Reduce height and opacity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReduce include graph of JSDOMBinding.h
akling@apple.com [Sun, 24 Feb 2013 13:01:06 +0000 (13:01 +0000)]
Reduce include graph of JSDOMBinding.h
<http://webkit.org/b/110709>

Reviewed by Antti Koivisto.

Source/WebCore:

Move WebCore::root(Foo*) to the custom JSFooCustom.h headers.
This reduces the number of headers pulled in by JSDOMBinding.h.

* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCSSRuleCustom.cpp:
* bindings/js/JSCSSRuleCustom.h: Added.
(WebCore::root):
* bindings/js/JSCSSRuleListCustom.cpp:
* bindings/js/JSCSSStyleDeclarationCustom.h:
(WebCore::root):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSMediaListCustom.h: Added.
(WebCore::root):
* bindings/js/JSMutationObserverCustom.cpp:
* bindings/js/JSNodeCustom.h:
(WebCore::root):
* bindings/js/JSSVGElementInstanceCustom.cpp:
* bindings/js/JSStyleSheetCustom.h: Added.
(WebCore::root):
* bindings/js/JSTextTrackCustom.h:
* bindings/js/JSTextTrackListCustom.cpp:
* bindings/js/JSXPathResultCustom.cpp:
* bindings/js/SerializedScriptValue.cpp:
* bindings/scripts/CodeGeneratorGObject.pm:
(Generate):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorObjC.pm:
(AddIncludesForType):
* css/CSSRule.idl:
* css/CSSStyleDeclaration.idl:
* css/MediaList.idl:
* css/StyleSheet.idl:
* editing/mac/EditorMac.mm:

Source/WebKit/mac:

* WebView/WebHTMLView.mm:

Source/WebKit2:

* Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::WebRenderObject):
* WebProcess/Storage/StorageAreaProxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd timeout to the Chromium expectation of state-url-sets-links-visited.html
benjamin@webkit.org [Sun, 24 Feb 2013 08:39:36 +0000 (08:39 +0000)]
Add timeout to the Chromium expectation of state-url-sets-links-visited.html

Unreviewed.

* platform/chromium/TestExpectations: Since Chromium's DRT does not support
computedStyleIncludingVisitedInfo, the test can also timeout as it will
raise an exception before invoking finishJSTest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoResourceRequestBase unnecessarily updates when nothing changes
ap@apple.com [Sun, 24 Feb 2013 07:29:13 +0000 (07:29 +0000)]
ResourceRequestBase unnecessarily updates when nothing changes
https://bugs.webkit.org/show_bug.cgi?id=110665

Reviewed by Dan Bernstein.

Don't mark platform data for update if nothing really changed. This avoids ever doing
doUpdatePlatformRequest() in NetworkProcess during normal browsing for me, which is
good for performance.

* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::removeCredentials):
(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::setFirstPartyForCookies):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::ResourceRequestBase::setPriority):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd support for testing states changing asynchronously. Apply it to state-url-sets...
benjamin@webkit.org [Sun, 24 Feb 2013 07:24:12 +0000 (07:24 +0000)]
Add support for testing states changing asynchronously. Apply it to state-url-sets-links-visited.html.
https://bugs.webkit.org/show_bug.cgi?id=109883

Reviewed by Antti Koivisto.

Some tests depends on state change happening asynchronously. This is typically solved by using
timers with a long enough interval.

Timers have the general pitfalls of causing unreliable tests, and forcing unnecessary delays
in the tests.

This patch introduces new testing helpers, shouldBecomeEqual and shouldBecomeEqualToString, to
test a change of state repetively until it succeed (or timeout). Those test functions execute
the condition every 5ms until the test succeed.

The helper shouldBecomeEqualToString is applied on state-url-sets-links-visited.html to illustrate
the concept.

* fast/js/resources/js-test-pre.js:
(_waitForCondition): Generic helper function for the familly shouldBecomeXXX.
(.condition):
(.failureHandler):
(shouldBecomeEqual):
(shouldBecomeEqualToString):

* fast/loader/stateobjects/state-url-sets-links-visited.html:
* platform/wk2/TestExpectations:
state-url-sets-links-visited.html failed on WebKit2 because the visited links table is updated
asynchronously, and the style is only updated after 1 IPC message + 1 timer + 1 IPC message.

The test is changed to use shouldBecomeEqualToString in order to become reliable. If the UIProcess
does not update the style in a reasonable amount of time, the test fails.

* platform/chromium/TestExpectations: Make the test as failing on Chromium until proper test support is added
to DRT or Internals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPrevent crash in animated transform lists
pdr@google.com [Sun, 24 Feb 2013 06:35:10 +0000 (06:35 +0000)]
Prevent crash in animated transform lists
https://bugs.webkit.org/show_bug.cgi?id=110704

Reviewed by Abhishek Arya.

Source/WebCore:

This change prevents accessing values off the end of toAtEndOfDuration by adding a check
for this case. Similar checks were added in r116458 but the author failed to catch this
case. WK110706 has been filed to handle this case in general.

This change also makes a trivial change that marks effectiveFrom as const.

Test: svg/animations/animateTransform-list-crash.html

* svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):

LayoutTests:

* svg/animations/animateTransform-list-crash-expected.txt: Added.
* svg/animations/animateTransform-list-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSelectorChecker should not know about SelectorCheckerFastPath.
dglazkov@chromium.org [Sun, 24 Feb 2013 06:18:41 +0000 (06:18 +0000)]
SelectorChecker should not know about SelectorCheckerFastPath.
https://bugs.webkit.org/show_bug.cgi?id=110663

Both SelectorChecker and it's speedy cousin unfortunately include each other.
Luckily, the particular way in which SelectorQuery uses SelectorChecker yields
to a fairly simple decoupling. Now only the cousin knows of SelectorChecker.

Reviewed by Antti Koivisto.

No new functionality, covered by existing tests.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matches): Removed.
* css/SelectorChecker.h:
(SelectorChecker): Updated the decls to remove fast-path flag.
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches): Added a helper just for SelectorQuery.
(WebCore::SelectorDataList::matches): Changed the callsite to use new helper.
(WebCore::SelectorDataList::execute): Ditto.
* dom/SelectorQuery.h:
(SelectorDataList): Updated decls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] user preference caption style applied incorrectly
eric.carlson@apple.com [Sun, 24 Feb 2013 05:31:10 +0000 (05:31 +0000)]
[Mac] user preference caption style applied incorrectly
https://bugs.webkit.org/show_bug.cgi?id=110707
<rdar://problem/13281096>

Reviewed by Maciej Stachowiak.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::textTrackContainerElementShadowPseudoId): New
    static function so the pseudo ID is available.
(WebCore::MediaControlTextTrackContainerElement::shadowPseudoId): Call textTrackContainerElementShadowPseudoId.
* html/shadow/MediaControlElements.h:

* page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Style the text track container
    element for cue color, edge style, and font name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Generate xxxAttrGetterCallback()
haraken@chromium.org [Sun, 24 Feb 2013 02:54:56 +0000 (02:54 +0000)]
[V8] Generate xxxAttrGetterCallback()
https://bugs.webkit.org/show_bug.cgi?id=110676

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection
function for xxxAttrGetter(), like this:

// For non-custom getters
Handle<Value> xxxAttrGetterCallback(...) {
  return xxxAttrGetter(...);
}

// For custom getters.
Handle<Value> xxxAttrGetterCallback(...) {
  return xxxAttrGetterCustom(...);
}

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateSingleBatchedAttribute):
(GenerateNonStandardFunction):
(GenerateImplementation):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetterCallback):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetterCallback):
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::TestEventConstructorV8Internal::attr1AttrGetterCallback):
(TestEventConstructorV8Internal):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetterCallback):
(WebCore):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::TestExceptionV8Internal::nameAttrGetterCallback):
(TestExceptionV8Internal):
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetterCallback):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetterCallback):
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetterCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::enumAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::shortAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::longAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::longLongAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::stringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::testObjAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::createAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetterCallback):
(WebCore::TestObjV8Internal::customAttrAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetterCallback):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetterCallback):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetterCallback):
(WebCore::TestObjV8Internal::anyAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr1AttrGetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr2AttrGetterCallback):
(WebCore::TestObjV8Internal::floatArrayAttrGetterCallback):
(WebCore::TestObjV8Internal::doubleArrayAttrGetterCallback):
(WebCore::TestObjV8Internal::contentDocumentAttrGetterCallback):
(WebCore::TestObjV8Internal::mutablePointAttrGetterCallback):
(WebCore::TestObjV8Internal::immutablePointAttrGetterCallback):
(WebCore::TestObjV8Internal::strawberryAttrGetterCallback):
(WebCore::TestObjV8Internal::strictFloatAttrGetterCallback):
(WebCore::TestObjV8Internal::descriptionAttrGetterCallback):
(WebCore::TestObjV8Internal::idAttrGetterCallback):
(WebCore::TestObjV8Internal::hashAttrGetterCallback):
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetterCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetterCallback):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetterCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetterCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetterCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetterCallback):
(WebCore):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetterCallback):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrGetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrGetterCallback):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebCore fails to link in Chromium official build
haraken@chromium.org [Sun, 24 Feb 2013 01:38:08 +0000 (01:38 +0000)]
WebCore fails to link in Chromium official build
https://bugs.webkit.org/show_bug.cgi?id=110701

Reviewed by Abhishek Arya.

This is a follow-up fix for r143853. In WebCore.gyp, we need to
increase the shard of 'webcore_rendering' as well.

No tests. No change in behavior.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r143844.
haraken@chromium.org [Sun, 24 Feb 2013 00:17:03 +0000 (00:17 +0000)]
Unreviewed, rolling out r143844.
http://trac.webkit.org/changeset/143844
https://bugs.webkit.org/show_bug.cgi?id=110241

It broke Chromium Mac Release Build

* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/WebCoreGTK.gyp: Removed.
* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebCore fails to link in Chromium official build
abarth@webkit.org [Sat, 23 Feb 2013 23:33:40 +0000 (23:33 +0000)]
WebCore fails to link in Chromium official build
https://bugs.webkit.org/show_bug.cgi?id=110697

Reviewed by Eric Seidel.

Apparently we need to use more shards to work around linker limitations
on Windows again.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKit...
pilgrim@chromium.org [Sat, 23 Feb 2013 23:31:36 +0000 (23:31 +0000)]
[Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110606

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
(WebKitSupportTestEnvironment::mockPlatform):
(WebKitSupportTestEnvironment):
* DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
(MockPlatform::create):
(MockPlatform::MockPlatform):
(MockPlatform::~MockPlatform):
(MockPlatform::setInterfaces):
(MockPlatform::cryptographicallyRandomValues):
(MockPlatform::createMediaStreamCenter):
(MockPlatform::createRTCPeerConnectionHandler):
* DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
(MockPlatform):
* DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
* DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Rename constructorCallbackCustom() to constructorCustom()
haraken@chromium.org [Sat, 23 Feb 2013 22:37:30 +0000 (22:37 +0000)]
[V8] Rename constructorCallbackCustom() to constructorCustom()
https://bugs.webkit.org/show_bug.cgi?id=110671

Reviewed by Adam Barth.

his is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings.
See https://bugs.webkit.org/show_bug.cgi?id=110667#c0

In the new world, "Callback" is used to indicate that it
is a function called back by V8. Currently "Callback" is
used for both V8 callbacks, DOM methods and DOM constructors.
This patch fixes the inconsistency.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateCustomConstructorCallback):
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCustom):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCustom):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCustom):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCustom):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCustom):
* bindings/v8/custom/V8MessageChannelCustom.cpp:
(WebCore::V8MessageChannel::constructorCustom):
* bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCustom):
* bindings/v8/custom/V8WebKitPointCustom.cpp:
(WebCore::V8WebKitPoint::constructorCustom):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::constructorCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Rename xxxCallback() to xxxMethod(), and xxxCallbackCustom() to xxxMethodCustom()
haraken@chromium.org [Sat, 23 Feb 2013 22:23:22 +0000 (22:23 +0000)]
[V8] Rename xxxCallback() to xxxMethod(), and xxxCallbackCustom() to xxxMethodCustom()
https://bugs.webkit.org/show_bug.cgi?id=110669

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE()
macros into DOM bindings.
See https://bugs.webkit.org/show_bug.cgi?id=110667#c0

In the new world, "Callback" is used to refer that it
is a function called back by V8. Currently "Callback" is
used for both V8 callbacks, DOM methods and DOM constructors.
This patch fixes the inconsistency.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::Float64ArrayV8Internal::setMethod):
(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionMethod):
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::itemMethod):
(WebCore::TestEventTargetV8Internal::addEventListenerMethod):
(WebCore::TestEventTargetV8Internal::removeEventListenerMethod):
(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod1Method):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::TestInterfaceV8Internal::supplementalMethod3Method):
(WebCore::TestInterfaceV8Internal::supplementalMethod4Method):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerV8Internal::methodMethod):
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::voidMethodMethod):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodWithSequenceArgMethod):
(WebCore::TestObjV8Internal::methodReturningSequenceMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::serializedValueMethod):
(WebCore::TestObjV8Internal::optionsObjectMethod):
(WebCore::TestObjV8Internal::methodWithExceptionMethod):
(WebCore::TestObjV8Internal::customMethodMethod):
(WebCore::TestObjV8Internal::customMethodWithArgsMethod):
(WebCore::TestObjV8Internal::addEventListenerMethod):
(WebCore::TestObjV8Internal::removeEventListenerMethod):
(WebCore::TestObjV8Internal::withScriptStateVoidMethod):
(WebCore::TestObjV8Internal::withScriptStateObjMethod):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionMethod):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionMethod):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesMethod):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackMethod):
(WebCore::TestObjV8Internal::methodWithOptionalArgMethod):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgMethod):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsMethod):
(WebCore::TestObjV8Internal::methodWithOptionalStringMethod):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedMethod):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringMethod):
(WebCore::TestObjV8Internal::methodWithCallbackArgMethod):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgMethod):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgMethod):
(WebCore::TestObjV8Internal::conditionalMethod1Method):
(WebCore::TestObjV8Internal::conditionalMethod2Method):
(WebCore::TestObjV8Internal::conditionalMethod3Method):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod3Method):
(WebCore::TestObjV8Internal::overloadedMethod4Method):
(WebCore::TestObjV8Internal::overloadedMethod5Method):
(WebCore::TestObjV8Internal::overloadedMethod6Method):
(WebCore::TestObjV8Internal::overloadedMethod7Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethod9Method):
(WebCore::TestObjV8Internal::overloadedMethod10Method):
(WebCore::TestObjV8Internal::overloadedMethod11Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::classMethodMethod):
(WebCore::TestObjV8Internal::classMethodWithOptionalMethod):
(WebCore::TestObjV8Internal::classMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod12Method):
(WebCore::TestObjV8Internal::classMethodWithClampMethod):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Method):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Method):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Method):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Method):
(WebCore::TestObjV8Internal::stringArrayFunctionMethod):
(WebCore::TestObjV8Internal::domStringListFunctionMethod):
(WebCore::TestObjV8Internal::getSVGDocumentMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::mutablePointFunctionMethod):
(WebCore::TestObjV8Internal::immutablePointFunctionMethod):
(WebCore::TestObjV8Internal::orangeMethod):
(WebCore::TestObjV8Internal::strictFunctionMethod):
(WebCore::TestObjV8Internal::variadicStringMethodMethod):
(WebCore::TestObjV8Internal::variadicDoubleMethodMethod):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListMethod):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListMethod):
(WebCore):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::TestTypedefsV8Internal::multiTransferListMethod):
(WebCore::TestTypedefsV8Internal::setShadowMethod):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgMethod):
(WebCore::TestTypedefsV8Internal::nullableArrayArgMethod):
(WebCore::TestTypedefsV8Internal::funcWithClampMethod):
(WebCore::TestTypedefsV8Internal::immutablePointFunctionMethod):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionMethod):
(WebCore::TestTypedefsV8Internal::stringArrayFunction2Method):
(WebCore::TestTypedefsV8Internal::methodWithExceptionMethod):
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::clearDataMethodCustom):
(WebCore::V8Clipboard::setDragImageMethodCustom):
* bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::traceMethodCustom):
(WebCore::V8Console::assertMethodCustom):
(WebCore::V8Console::profileMethodCustom):
(WebCore::V8Console::profileEndMethodCustom):
* bindings/v8/custom/V8CryptoCustom.cpp:
(WebCore::V8Crypto::getRandomValuesMethodCustom):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::appendMethodCustom):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::addEventListenerMethodCustom):
(WebCore::V8DOMWindow::removeEventListenerMethodCustom):
(WebCore::V8DOMWindow::postMessageMethodCustom):
(WebCore::V8DOMWindow::toStringMethodCustom):
(WebCore::V8DOMWindow::releaseEventsMethodCustom):
(WebCore::V8DOMWindow::captureEventsMethodCustom):
(WebCore::V8DOMWindow::showModalDialogMethodCustom):
(WebCore::V8DOMWindow::openMethodCustom):
(WebCore::V8DOMWindow::setTimeoutMethodCustom):
(WebCore::V8DOMWindow::setIntervalMethodCustom):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::getInt8MethodCustom):
(WebCore::V8DataView::getUint8MethodCustom):
(WebCore::V8DataView::setInt8MethodCustom):
(WebCore::V8DataView::setUint8MethodCustom):
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::V8DedicatedWorkerContext::postMessageMethodCustom):
* bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
(WebCore::V8DeviceMotionEvent::initDeviceMotionEventMethodCustom):
* bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventMethodCustom):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateMethodCustom):
(WebCore::V8Document::createTouchListMethodCustom):
* bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::V8Geolocation::getCurrentPositionMethodCustom):
(WebCore::V8Geolocation::watchPositionMethodCustom):
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::V8HTMLAllCollection::itemMethodCustom):
(WebCore::V8HTMLAllCollection::namedItemMethodCustom):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextMethodCustom):
(WebCore::V8HTMLCanvasElement::toDataURLMethodCustom):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::writeMethodCustom):
(WebCore::V8HTMLDocument::writelnMethodCustom):
(WebCore::V8HTMLDocument::openMethodCustom):
* bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:
(WebCore::V8HTMLFormControlsCollection::namedItemMethodCustom):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorMethodCustom):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
* bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::setSelectionRangeMethodCustom):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::namedItemMethodCustom):
(WebCore::V8HTMLOptionsCollection::removeMethodCustom):
(WebCore::V8HTMLOptionsCollection::addMethodCustom):
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::V8HTMLSelectElement::removeMethodCustom):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateMethodCustom):
(WebCore::V8History::replaceStateMethodCustom):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectedObjectMethodCustom):
(WebCore::V8InjectedScriptHost::internalConstructorNameMethodCustom):
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::functionDetailsMethodCustom):
(WebCore::V8InjectedScriptHost::getInternalPropertiesMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):
(WebCore::V8InjectedScriptHost::inspectMethodCustom):
(WebCore::V8InjectedScriptHost::databaseIdMethodCustom):
(WebCore::V8InjectedScriptHost::storageIdMethodCustom):
(WebCore::V8InjectedScriptHost::evaluateMethodCustom):
(WebCore::V8InjectedScriptHost::setFunctionVariableValueMethodCustom):
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::V8InspectorFrontendHost::platformMethodCustom):
(WebCore::V8InspectorFrontendHost::portMethodCustom):
(WebCore::V8InspectorFrontendHost::showContextMenuMethodCustom):
(WebCore::V8InspectorFrontendHost::recordActionTakenMethodCustom):
(WebCore::V8InspectorFrontendHost::recordPanelShownMethodCustom):
(WebCore::V8InspectorFrontendHost::recordSettingChangedMethodCustom):
* bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::evaluateMethodCustom):
(WebCore::V8JavaScriptCallFrame::restartMethodCustom):
(WebCore::V8JavaScriptCallFrame::setVariableValueMethodCustom):
(WebCore::V8JavaScriptCallFrame::scopeTypeMethodCustom):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):
(WebCore::V8Location::reloadMethodCustom):
(WebCore::V8Location::replaceMethodCustom):
(WebCore::V8Location::assignMethodCustom):
(WebCore::V8Location::valueOfMethodCustom):
(WebCore::V8Location::toStringMethodCustom):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventMethodCustom):
(WebCore::V8MessageEvent::webkitInitMessageEventMethodCustom):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::V8MessagePort::postMessageMethodCustom):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::requestPermissionMethodCustom):
* bindings/v8/custom/V8NotificationCustom.cpp:
(WebCore::V8Notification::requestPermissionMethodCustom):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemMethodCustom):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlMethodCustom):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlMethodCustom):
* bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::convertToSpecifiedUnitsMethodCustom):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getBufferParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getExtensionMethodCustom):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getRenderbufferParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsMethodCustom):
(WebCore::V8WebGLRenderingContext::getTexParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::V8WebGLRenderingContext::getVertexAttribMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform1fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform1ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform2fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform2ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform3fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform3ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform4fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniform4ivMethodCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix2fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix3fvMethodCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix4fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib1fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib2fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib3fvMethodCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib4fvMethodCustom):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::importScriptsMethodCustom):
(WebCore::V8WorkerContext::setTimeoutMethodCustom):
(WebCore::V8WorkerContext::setIntervalMethodCustom):
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::postMessageMethodCustom):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::openMethodCustom):
(WebCore::V8XMLHttpRequest::sendMethodCustom):
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
(WebCore::V8XSLTProcessor::setParameterMethodCustom):
(WebCore::V8XSLTProcessor::getParameterMethodCustom):
(WebCore::V8XSLTProcessor::removeParameterMethodCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip javascriptDialogEvents.html since its result bleed into other tests non-determin...
rniwa@webkit.org [Sat, 23 Feb 2013 20:44:25 +0000 (20:44 +0000)]
Skip javascriptDialogEvents.html since its result bleed into other tests non-deterministically per bug 110186.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoScrollbar style resolution arguments should not passed via statics.
dglazkov@chromium.org [Sat, 23 Feb 2013 20:41:26 +0000 (20:41 +0000)]
Scrollbar style resolution arguments should not passed via statics.
https://bugs.webkit.org/show_bug.cgi?id=110690

Use PseudoStyleRequest to pass scrollbar params for style resolve.

Reviewed by Eric Seidel.

No change in functionality, covered by existing tests.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match): Changed to use context params, rather than statics.
(WebCore::SelectorChecker::checkOne): Changed to pass context to checkScrollbarPseudoClass.
(WebCore::SelectorChecker::checkScrollbarPseudoClass): Changed to use context params, rather than statics.
* css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): Added scrollbar style args.
(SelectorCheckingContext): Ditto.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use PseudoStyleRequest.
(WebCore::StyleResolver::State::initForStyleResolve): Ditto.
(WebCore::StyleResolver::pseudoStyleForElement): Ditto.
(WebCore::StyleResolver::ruleMatches): Ditto and added stuffing scrollbar style resolve args into SelectorCheckingContext.
* css/StyleResolver.h:
(PseudoStyleRequest): Added.
(State): Changed to hold and use PseudoStyleRequest instead of just PseudoId
* dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid): Changed to use PseudoStyleRequest.
* page/FrameView.cpp: Ditto.
(WebCore::FrameView::updateScrollCorner): Ditto.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollCornerStyle): Ditto.
(WebCore::RenderLayer::updateResizerStyle): Ditto.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionBackgroundColor): Ditto.
(WebCore::RenderObject::selectionColor): Ditto.
(WebCore::firstLineStyleForCachedUncachedType): Ditto.
(WebCore::RenderObject::getCachedPseudoStyle): Ditto.
(WebCore::RenderObject::getUncachedPseudoStyle): Ditto.
* rendering/RenderObject.h:
(RenderObject): Ditto.
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::getScrollbarPseudoStyle): Ditto.
* rendering/RenderScrollbar.h:
(RenderScrollbar): Removed static members that are now obsolete.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
zandobersek@gmail.com [Sat, 23 Feb 2013 20:00:18 +0000 (20:00 +0000)]
Unreviewed gardening.

* platform/efl/TestExpectations: Adding a failure expectation for the html5lib/runner.html test
that started failing with r143804.
* platform/gtk/TestExpectations: Ditto. Also adding flaky crasher expectations for two http tests,
crashes are originating from IDB code and starter appearing with r143694.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport...
pilgrim@chromium.org [Sat, 23 Feb 2013 19:57:05 +0000 (19:57 +0000)]
[Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
https://bugs.webkit.org/show_bug.cgi?id=110605

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

* public/WebKit.h:
(WebKit):
* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::initializeWithoutV8):
(WebKit::webKitPlatformSupport):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThreaded HTML parser should pass fast/parser/parser-yield-timing.html
abarth@webkit.org [Sat, 23 Feb 2013 18:37:50 +0000 (18:37 +0000)]
Threaded HTML parser should pass fast/parser/parser-yield-timing.html
https://bugs.webkit.org/show_bug.cgi?id=110647

Reviewed by Eric Seidel.

Previously, the threaded HTML parser would run for an arbitrary amount
of time without yielding after speculation succeeded. This might be the
cause of the good DOMContentLoaded numbers.

Note: This patch also demonstrates that the ParseHTML_max numbers
aren't correct currently because they're measuring the interior of this
loop instead of all the time spent in the loop. We should move the
instrumentation in a followup patch.

 * html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
* html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
* html/parser/HTMLParserScheduler.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Allow sharing the WebCore include list with the Chromium build
commit-queue@webkit.org [Sat, 23 Feb 2013 18:22:35 +0000 (18:22 +0000)]
[GTK] Allow sharing the WebCore include list with the Chromium build
https://bugs.webkit.org/show_bug.cgi?id=110241

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-23
Reviewed by Dirk Pranke.

* WebCore.gyp/WebCore.gyp: Moved shared include directories to
WebCore.gypi.
* WebCore.gyp/WebCoreGTK.gyp: Added. A skeleton gyp file for WebCoreGTK+.
* WebCore.gypi: Added shared include directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStyledElement: Tweak signature of collectStyleForPresentationAttribute().
akling@apple.com [Sat, 23 Feb 2013 17:57:50 +0000 (17:57 +0000)]
StyledElement: Tweak signature of collectStyleForPresentationAttribute().
<http://webkit.org/b/110687>

Reviewed by Antti Koivisto.

Out with the old:
    collectStyleForPresentationAttribute(const Attribute&, StylePropertySet*)

In with the new:
    collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*)

This is primarily about switching to using MutableStylePropertySet* in preparation for
removing mutating functions from the StylePropertySet base class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WebGL] Refactor GLPlatformSurface.
commit-queue@webkit.org [Sat, 23 Feb 2013 16:55:20 +0000 (16:55 +0000)]
[EFL][WebGL] Refactor GLPlatformSurface.
https://bugs.webkit.org/show_bug.cgi?id=110616

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-23
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

With recent changes, there is a clear separation between
transport surface and off-screen surface. PlatformSurface
has the logic to render content to transport surface.
We currently rely on EXT_framebuffer_blit for this. This
extension is not exposed on GLES2.0. PlatformSurface was
supposed to be an abstraction layer without any knowledge
of the type of surface. This patch addresses the issues
in PlatformSurface class. We use shaders to draw texture
content to the surface. Any transport surface related
code in PlatformSurface is moved to GLTransportSurface class.

* PlatformEfl.cmake:
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::didResizeCanvas):
* platform/graphics/surfaces/GLTransportSurface.cpp: Added.
(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):
* platform/graphics/surfaces/GLTransportSurface.h:
(WebCore):
(GLTransportSurface):
* platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::destroy):
(WebCore::EGLWindowTransportSurface::setGeometry):
* platform/graphics/surfaces/egl/EGLSurface.h:
* platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXOffScreenSurface::freeResources):
* platform/graphics/surfaces/glx/GLXSurface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove some tests needing to be rebaselined from TestExpectations
mrobinson@webkit.org [Sat, 23 Feb 2013 16:16:52 +0000 (16:16 +0000)]
Remove some tests needing to be rebaselined from TestExpectations

* platform/gtk/TestExpectations: Update the list of tests needing new baselines
and skip some that are timing out on my machine.
* platform/gtk/accessibility/color-well-expected.txt: Added.
* platform/gtk/accessibility/image-link-expected.txt: Added.
* platform/gtk/accessibility/image-map1-expected.txt: Added.
* platform/gtk/accessibility/image-map2-expected.txt: Added.
* platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt: Added.
* platform/gtk/accessibility/multiselect-list-reports-active-option-expected.txt: Added.
* platform/gtk/accessibility/notification-listeners-expected.txt: Added.
* platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.png:
* platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.txt:
* platform/gtk/editing/selection/extend-by-sentence-001-expected.png:
* platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Added.
* platform/gtk/fast/block/float/024-expected.png:
* platform/gtk/fast/block/float/024-expected.txt: Added.
* platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.png:
* platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt: Added.
* platform/gtk/fast/css/resize-corner-tracking-expected.png:
* platform/gtk/fast/css/resize-corner-tracking-expected.txt:
* platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
* platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
* platform/gtk/fast/inline/drawStyledEmptyInlines-expected.png:
* platform/gtk/fast/inline/drawStyledEmptyInlines-expected.txt:
* platform/gtk/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
* platform/gtk/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
* platform/gtk/fast/inline/justify-emphasis-inline-box-expected.png: Added.
* platform/gtk/fast/inline/justify-emphasis-inline-box-expected.txt: Added.
* platform/gtk/fast/repaint/caret-with-transformation-expected.png: Added.
* platform/gtk/fast/repaint/caret-with-transformation-expected.txt: Added.
* platform/gtk/fast/text/capitalize-empty-generated-string-expected.png:
* platform/gtk/fast/text/capitalize-empty-generated-string-expected.txt:
* platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
* platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
* platform/gtk/fast/text/whitespace/006-expected.png:
* platform/gtk/fast/text/whitespace/006-expected.txt:
* platform/gtk/fast/text/whitespace/007-expected.png:
* platform/gtk/fast/text/whitespace/007-expected.txt:
* platform/gtk/media/audio-controls-rendering-expected.png: Added.
* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/controls-after-reload-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-strict-expected.txt:
* platform/gtk/media/controls-without-preload-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-display-toggle-expected.txt:
* platform/gtk/media/video-playing-and-pause-expected.txt:
* platform/gtk/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
* platform/gtk/svg/as-image/image-preserveAspectRatio-all-expected.txt: Added.
* platform/gtk/svg/batik/text/xmlSpace-expected.png:
* platform/gtk/svg/batik/text/xmlSpace-expected.txt:
* platform/gtk/svg/carto.net/combobox-expected.png:
* platform/gtk/svg/carto.net/combobox-expected.txt:
* platform/gtk/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/gtk/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.txt: Added.
* platform/gtk/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/gtk/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Added.
* platform/gtk/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
* platform/gtk/svg/filters/feImage-preserveAspectRatio-all-expected.txt: Added.
* platform/gtk/svg/filters/filter-hidden-content-expected.png: Added.
* platform/gtk/svg/filters/filter-hidden-content-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug113235-3-expected.png:
* platform/gtk/tables/mozilla/bugs/bug113235-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
* platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
* platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShadowRoot needs guardRef() and guardDeref()
morrita@google.com [Sat, 23 Feb 2013 10:49:49 +0000 (10:49 +0000)]
ShadowRoot needs guardRef() and guardDeref()
https://bugs.webkit.org/show_bug.cgi?id=109777

Reviewed by Dimitri Glazkov.

This change moves m_guardRefCount from Document to TreeScope,
which allows ShadowRoot to be guarded by guardRef() mechanism as
Document. After r137524, Node referes TreeScope instead of
Document. This is natural consequence of the change: It no longer
makes sense to guardRef() Document pointer from Node.

Detail:

- Document::m_guardRefCount and related funcdtions are moved to TreeScope
- Document::removedLastRef is factored out into TreeScope::removedLastRefToScope(),
  TreeScope::dispose() and Docuent::dispose(). ShadowRoot also got its own dispose() implementation.
- Moved guardRef() and guardDeref() calls to TreeScope and Node.
  Note that there are two "guarded" TreeScope references. One is
  Node::m_treeScope and another is TreeScope::m_parentTreeScope.
  The guarded-ref management is now encapsulated in these two classes.

No new tests. Covered by existing tests.

* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::dispose): Extracted from removedLastRef()
* dom/Document.h:
(WebCore::Node::isTreeScope):
(WebCore::Node::Node):
* dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::DocumentFragment): Remove ASSERT() and move it to ...
(WebCore::DocumentFragment::create): ... here, to allow NULL document from ShadowRoot.
* dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::removedLastRef):
* dom/Node.h:
(WebCore::Node::setTreeScope):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot): Passed NULL document to superclass. This aligns what Document is doing.
(WebCore::ShadowRoot::dispose): Added.
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/TreeScope.cpp:
(SameSizeAsTreeScope):
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::dispose): Added.
(WebCore::TreeScope::setParentTreeScope):
(WebCore::TreeScope::deletionHasBegun):
(WebCore::TreeScope::beginDeletion):
(WebCore::TreeScope::refCount): Added.
* dom/TreeScope.h: Turned m_rootNode to Node* from ContainerNode* for Node::isTreeScope to be inlined.
(WebCore::TreeScope::guardRef): Pulled up from Document.
(WebCore::TreeScope::guardDeref): Ditto.
(WebCore::TreeScope::hasGuardRefCount): Added to hide m_guardRefCount.
(WebCore::TreeScope::deletionHasBegun): Added.
(WebCore::TreeScope::beginDeletion): Added.
(WebCore::TreeScope::removedLastRefToScope): Pulled up from Document.
* dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the...
rniwa@webkit.org [Sat, 23 Feb 2013 09:03:36 +0000 (09:03 +0000)]
Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.

* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.timestamp_of_latest_commit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't include ResourceHandle.h in ResourceLoaderOptions.h
ap@apple.com [Sat, 23 Feb 2013 08:54:33 +0000 (08:54 +0000)]
Don't include ResourceHandle.h in ResourceLoaderOptions.h
https://bugs.webkit.org/show_bug.cgi?id=110662

Reviewed by Tim Horton.

* loader/ResourceLoaderOptions.h: Include ResourceHandleTypes.h instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Move setAutofilled from TestRunner to WebCore
commit-queue@webkit.org [Sat, 23 Feb 2013 08:14:38 +0000 (08:14 +0000)]
Source/WebCore: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

* testing/Internals.cpp:
(WebCore):
(WebCore::Internals::setAutofilled):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/efl: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/qt: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools: Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

* DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
* DumpRenderTree/TestRunner.h:
(TestRunner):
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
* DumpRenderTree/mac/TestRunnerMac.mm:
* DumpRenderTree/qt/TestRunnerQt.cpp:
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
* DumpRenderTree/win/TestRunnerWin.cpp:
* DumpRenderTree/wx/TestRunnerWx.cpp:

LayoutTests: Moved setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-02-23
Reviewed by Benjamin Poulain.

* fast/forms/input-autofilled.html:
* fast/forms/reset-autofilled.html:
* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline ports after bug 109994
commit-queue@webkit.org [Sat, 23 Feb 2013 06:16:14 +0000 (06:16 +0000)]
Rebaseline ports after bug 109994
https://bugs.webkit.org/show_bug.cgi?id=110551

Unreviewed rebaseline of test expectations.

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-22

* css2.1/20110323/replaced-elements-001-expected.txt: Renamed from LayoutTests/platform/mac/css2.1/20110323/replaced-elements-001-expected.txt.
* fast/forms/button-generated-content-expected.txt:
* fast/forms/select-baseline-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/select-baseline-expected.txt.
* platform/chromium-mac-lion/css2.1/20110323/replaced-elements-001-expected.png:
* platform/chromium-mac-lion/fast/forms/button-generated-content-expected.png:
* platform/chromium-mac-lion/fast/forms/select-baseline-expected.png:
* platform/chromium-mac-lion/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-mac-snowleopard/css2.1/20110323/replaced-elements-001-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/button-generated-content-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-mac/css2.1/20110323/replaced-elements-001-expected.png:
* platform/chromium-mac/fast/forms/button-generated-content-expected.png:
* platform/chromium-mac/fast/forms/select-baseline-expected.png:
* platform/chromium-mac/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.png:
* platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.txt:
* platform/chromium-win/fast/forms/button-generated-content-expected.png:
* platform/chromium-win/fast/forms/button-generated-content-expected.txt:
* platform/chromium-win/fast/forms/select-baseline-expected.png:
* platform/chromium-win/fast/forms/select-baseline-expected.txt:
* platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.txt:
* platform/chromium/TestExpectations:
* platform/chromium/css2.1/20110323/replaced-elements-001-expected.txt: Removed.
* platform/efl/TestExpectations:
* platform/efl/css2.1/20110323/replaced-elements-001-expected.txt:
* platform/efl/fast/forms/button-generated-content-expected.txt:
* platform/efl/fast/forms/select-baseline-expected.txt:
* platform/efl/svg/custom/foreign-object-skew-expected.txt: Renamed from LayoutTests/platform/mac/svg/custom/foreign-object-skew-expected.txt.
* platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:
* platform/gtk/TestExpectations:
* platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
* platform/gtk/fast/forms/button-generated-content-expected.txt:
* platform/gtk/fast/forms/select-baseline-expected.txt:
* platform/gtk/svg/custom/foreign-object-skew-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/fast/forms/select-baseline-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug92647-2-expected.txt: Removed.
* platform/qt/TestExpectations:
* platform/qt/css2.1/20110323/replaced-elements-001-expected.txt:
* platform/qt/fast/forms/button-generated-content-expected.txt:
* platform/qt/fast/forms/select-baseline-expected.txt:
* platform/qt/svg/custom/foreign-object-skew-expected.txt:
* platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
* platform/win-future/fast/forms/button-generated-content-expected.txt: Copied from LayoutTests/fast/forms/button-generated-content-expected.txt.
* svg/custom/foreign-object-skew-expected.txt: Renamed from LayoutTests/platform/chromium/svg/custom/foreign-object-skew-expected.txt.
* tables/mozilla/bugs/bug92647-2-expected.txt: Renamed from LayoutTests/platform/chromium/tables/mozilla/bugs/bug92647-2-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Expose all dependencies to the gyp build
mrobinson@webkit.org [Sat, 23 Feb 2013 05:40:08 +0000 (05:40 +0000)]
[GTK] Expose all dependencies to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=110498

Reviewed by Dirk Pranke.

* gyp/Configuration.gypi.in: Add the missing configuration cflags here.
* gyp/Dependencies.gyp: Add targets for all missing dependencies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttr: Simplify modification callbacks.
akling@apple.com [Sat, 23 Feb 2013 04:47:20 +0000 (04:47 +0000)]
Attr: Simplify modification callbacks.
<http://webkit.org/b/110598>

Reviewed by Antti Koivisto.

Instead of Attr being a friend of Element and grabbing at various internal storage and callbacks,
let Attr simply call Element::setAttribute() when its value is changed, and do all that business
from Element.

* dom/Element.h:
* dom/Element.cpp:
(WebCore::Element::setAttributeInternal):

    Call Attr::recreateTextChildAfterAttributeValueChanged() after modifying an attribute value instead
    of doing the modification through the Attr node.

* dom/Attr.h:
* dom/Attr.cpp:
(WebCore::Attr::Attr):
(WebCore::Attr::childrenChanged):

    Added an m_inChildrenChanged flag so we can prevent infinite callback recursion in childrenChanged().

(WebCore::Attr::setValue):

    Call Element::setAttribute() instead of modifying the attribute storage directly.

(WebCore::Attr::recreateTextChildAfterAttributeValueChanged):

    Factored out the "remove all children / create a new text child with attribute value" logic into
    a separate function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpload results to perf.webkit.org in addition to the one specified by --test-results...
rniwa@webkit.org [Sat, 23 Feb 2013 04:28:47 +0000 (04:28 +0000)]
Upload results to perf.webkit.org in addition to the one specified by --test-results-server
https://bugs.webkit.org/show_bug.cgi?id=108577

Reviewed by Dirk Pranke.

Upload results to perf.webkit.org using new JSON format as well as the host specified by
--test-results-server. The new format is needed to provide extra information perf.webkit.org
need such as the subversion commit time and test URLs. This is a temporarily measure until
we complete the transition and the old JSON format and the code to upload results to
webkit-perf.appspot.com can be deleted.

This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
so that the app can sort performance test results based on the timestamp of the last commit.

It also changes the repository names returned by port objects to be properly capitalized
human readable names such as WebKit instead of lowercased names such as webkit since these names
are displayed on perf.webkit.org for humans. Several users of this feature has been updated
to explicitly lowercase the names.

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
git's timestamp granularity is seconds so we're losing some information compared to using a regular
subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
UTC so we're going to manually fiddle with timezone.

* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.timestamp_of_latest_commit): Added.

* Scripts/webkitpy/common/checkout/scm/scm_mock.py:
(MockSCM.timestamp_of_latest_commit): Added.

* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.

* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
the timestamp which is always in UTC.

* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
'chromium' needs to be substituted by 'chrome' for historical reasons.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.repository_paths): Return WebKit instead of webkit as noted above.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
(PerfTestsRunner._collect_tests):

(PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
and upload them appropriately.

(PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
in revisions_for_perf_webkit and construct an output for perf.webkit.org.

(PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.

(PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
e.g. "processor" would be renamed to "builderProcessor".

(PerfTestsRunner._generate_output_files):

(PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
webkit-perf.appspot.com which spits out a plaintext response.

* Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
(MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.

* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
cases to parse JSON responses.
(MainTest.test_upload_json.MockFileUploader): Refactored.
(MainTest.test_upload_json.MockFileUploader.reset): Added.
(MainTest.test_upload_json.MockFileUploader.__init__):
(MainTest.test_upload_json.MockFileUploader.upload_single_text_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Use EINA_LOG instead of fprintf
gyuyoung.kim@samsung.com [Sat, 23 Feb 2013 04:14:00 +0000 (04:14 +0000)]
[EFL] Use EINA_LOG instead of fprintf
https://bugs.webkit.org/show_bug.cgi?id=110313

Reviewed by Laszlo Gombos.

Replace fprintf with EINA_LOG.

Source/WebCore:

* platform/efl/NetworkInfoProviderEfl.cpp:
(WebCore::NetworkInfoProviderEfl::startUpdating):
* platform/graphics/efl/CairoUtilitiesEfl.cpp:
(WebCore::evasObjectFromCairoImageSurface):

Source/WebKit/efl:

* ewk/ewk_frame.cpp:
(_ewk_frame_debug):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThreaded HTML parser fails resources/plain-text-unsafe.dat
tonyg@chromium.org [Sat, 23 Feb 2013 03:28:41 +0000 (03:28 +0000)]
Threaded HTML parser fails resources/plain-text-unsafe.dat
https://bugs.webkit.org/show_bug.cgi?id=110538

Reviewed by Eric Seidel.

With this patch, the background HTML parser passes all tests in plain-text-unsafe.dat.

No new tests because covered by existing tests.

* html/parser/BackgroundHTMLParser.cpp:
(WebCore::tokenExitsSVG):
(WebCore):
(WebCore::tokenExitsMath):
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd temporary work around for 32-bit plugins not working in production builds as...
weinig@apple.com [Sat, 23 Feb 2013 03:18:36 +0000 (03:18 +0000)]
Add temporary work around for 32-bit plugins not working in production builds as XPCServices
https://bugs.webkit.org/show_bug.cgi?id=110680
<rdar://problem/13236883>

Reviewed by Anders Carlsson.

* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::shouldUseXPC):
Temporarily don't use XPC for plug-ins for Safari while we figure out why the
32-bit XPCService is being built universal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCorrect InspectorInstrumentation for background HTML parser
tonyg@chromium.org [Sat, 23 Feb 2013 03:14:36 +0000 (03:14 +0000)]
Correct InspectorInstrumentation for background HTML parser
https://bugs.webkit.org/show_bug.cgi?id=110678

Reviewed by Adam Barth.

resumeParsingAfterScriptExecution potentially calls processParsedChunkFromBackgroundParser multiple times
without yielding. So it is not correct to count each of those as a separate ParseHTML event.

This patch moves the instrumentation outside of the loop.

No new tests because no new functionality.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached
commit-queue@webkit.org [Sat, 23 Feb 2013 02:54:40 +0000 (02:54 +0000)]
[chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached
https://bugs.webkit.org/show_bug.cgi?id=110668

Patch by David Dorwin <ddorwin@chromium.org> on 2013-02-22
Reviewed by Adam Barth.

This fixes http://crbug.com/172764

* src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::destoryPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFactor MediaSource methods out of MediaPlayer & MediaPlayerPrivate and into a new...
acolwell@chromium.org [Sat, 23 Feb 2013 02:48:57 +0000 (02:48 +0000)]
Factor MediaSource methods out of MediaPlayer & MediaPlayerPrivate and into a new MediaSourcePrivate interface.
https://bugs.webkit.org/show_bug.cgi?id=109857

Reviewed by Adam Barth.

Source/WebCore:

This is a simple refactor that moves MediaSource related methods out of MediaPlayer & MediaPlayerPrivate
so that the MediaSource implementation can be updated without further polluting these interfaces.
MediaSourcePrivate is the new WebCore interface that ports must implement to support the MediaSource API.

No new tests. No user visible behavior has changed.

* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::duration):
(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::removeSourceBuffer):
(WebCore::MediaSource::setReadyState):
(WebCore::MediaSource::endOfStream):
(WebCore::MediaSource::buffered):
(WebCore::MediaSource::append):
(WebCore::MediaSource::abort):
(WebCore::MediaSource::setTimestampOffset):
(WebCore::MediaSource::setPrivateAndOpen):
(WebCore):
(WebCore::MediaSource::hasPendingActivity):
(WebCore::MediaSource::stop):
* Modules/mediasource/MediaSource.h:
(MediaSource):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::reportMemoryUsage):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* platform/graphics/MediaPlayer.cpp:
(NullMediaPlayerPrivate):
(WebCore::NullMediaPlayerPrivate::load):
(WebCore::MediaPlayer::load):
(WebCore):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
* platform/graphics/MediaPlayer.h:
(WebCore):
(MediaPlayerClient):
(MediaPlayer):
* platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
* platform/graphics/MediaSourcePrivate.h: Added.
(WebCore):
(MediaSourcePrivate): Contains the MediaSource methods extracted from MediaPlayer.
(WebCore::MediaSourcePrivate::MediaSourcePrivate):
(WebCore::MediaSourcePrivate::~MediaSourcePrivate):

Source/WebKit/chromium:

WebMediaSource and WebMediaSource client were created to replace the MediaSource methods in WebMediaPlayer and
WebMediaPlayerClient. This allows the MediaSource implementation to be updated without further polluting the
media player interfaces.

* WebKit.gyp:
* public/WebMediaPlayer.h:
(WebMediaPlayer):
(WebKit::WebMediaPlayer::load):
* public/WebMediaPlayerClient.h:
(WebKit):
* public/WebMediaSource.h: Added.
(WebKit):
(WebMediaSource):
(WebKit::WebMediaSource::~WebMediaSource):
* public/WebMediaSourceClient.h: Added.
(WebKit):
(WebMediaSourceClient):
(WebKit::WebMediaSourceClient::~WebMediaSourceClient):
* src/AssertMatchingEnums.cpp:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit):
(WebMediaSourceClientImpl): Temporary WebMediaSourceClient implementation to keep things working until Chromium
                            changes land.
(WebKit::WebMediaSourceClientImpl::WebMediaSourceClientImpl):
(WebKit::WebMediaSourceClientImpl::~WebMediaSourceClientImpl):
(WebKit::WebMediaSourceClientImpl::addId):
(WebKit::WebMediaSourceClientImpl::removeId):
(WebKit::WebMediaSourceClientImpl::buffered):
(WebKit::WebMediaSourceClientImpl::append):
(WebKit::WebMediaSourceClientImpl::abort):
(WebKit::WebMediaSourceClientImpl::duration):
(WebKit::WebMediaSourceClientImpl::setDuration):
(WebKit::WebMediaSourceClientImpl::endOfStream):
(WebKit::WebMediaSourceClientImpl::setTimestampOffset):
(WebKit::WebMediaPlayerClientImpl::sourceOpened):
(WebKit::WebMediaPlayerClientImpl::sourceURL):
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebMediaSourceImpl.cpp: Added.
(WebKit):
(MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::~MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::MediaSourcePrivateImpl):
(WebKit::MediaSourcePrivateImpl::addId):
(WebKit::MediaSourcePrivateImpl::removeId):
(WebKit::MediaSourcePrivateImpl::buffered):
(WebKit::MediaSourcePrivateImpl::append):
(WebKit::MediaSourcePrivateImpl::abort):
(WebKit::MediaSourcePrivateImpl::duration):
(WebKit::MediaSourcePrivateImpl::setDuration):
(WebKit::MediaSourcePrivateImpl::endOfStream):
(WebKit::MediaSourcePrivateImpl::setTimestampOffset):
(WebKit::WebMediaSourceImpl::WebMediaSourceImpl):
(WebKit::WebMediaSourceImpl::~WebMediaSourceImpl):
(WebKit::WebMediaSourceImpl::open):
* src/WebMediaSourceImpl.h: Added.
(WebKit):
(WebMediaSourceImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
bdakin@apple.com [Sat, 23 Feb 2013 02:13:46 +0000 (02:13 +0000)]
RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673
-and corresponding-
<rdar://problem/13258596>

Reviewed by Sam Weinig.

FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages that
have overflow on the body. We can easily address this by calling it at the
end of RenderLayer::scrollTo().

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers...
roger_fong@apple.com [Sat, 23 Feb 2013 02:09:56 +0000 (02:09 +0000)]
Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore rebaselines after http://trac.webkit.org/changeset/143804.
rniwa@webkit.org [Sat, 23 Feb 2013 02:00:05 +0000 (02:00 +0000)]
More rebaselines after trac.webkit.org/changeset/143804.

* html5lib/run-test1-expected.txt:
* html5lib/run-test18-expected.txt:
* html5lib/run-test7-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable MediaSource on Apple Windows port
acolwell@chromium.org [Sat, 23 Feb 2013 01:59:01 +0000 (01:59 +0000)]
Disable MediaSource on Apple Windows port
https://bugs.webkit.org/show_bug.cgi?id=110494

Reviewed by Tim Horton.

Source/WebKit:

* WebKit.vcxproj/FeatureDefines.props:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit can erroneously strip font-size CSS property from font element with size attribute
rniwa@webkit.org [Sat, 23 Feb 2013 01:54:30 +0000 (01:54 +0000)]
WebKit can erroneously strip font-size CSS property from font element with size attribute
https://bugs.webkit.org/show_bug.cgi?id=110657

Reviewed by Justin Garcia.

Source/WebCore:

The bug was caused by ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline
erroneously removing style attributes even on an element such as font that implicitly adds
editing style.

Fixed the bug by removing these elements or attributes when they conflict with the inline
style of the element. This is always safe because implicit style of an element is always
overridden by that of inline style.

Note that when the font element becomes "empty" (i.e. doesn't have any attributes), then
we also want to delete this font element as it doesn't contribute anything to the style.

Test: editing/pasteboard/insert-u-with-text-decoration-none.html
      editing/pasteboard/insert-font-with-size-and-css.html

* editing/ApplyStyleCommand.cpp:
(WebCore::isEmptyFontTag): Added ShouldStyleAttributeBeEmpty as an argument. This will
allow removeRedundantStylesAndKeepStyleSpanInline to ignore style attribute when we know
the attribute can be removed.

* editing/ApplyStyleCommand.h: Expose isEmptyFontTag and ShouldStyleAttributeBeEmpty.

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::InsertedNodes::didReplaceNode): Added.
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): See above.
* editing/ReplaceSelectionCommand.h:
(InsertedNodes): Added a declaration of didReplaceNode.

LayoutTests:

Added two regression tests to ensure WebKit doesn't erroneously remove inline styles of an element
when its implicit styles differ from the inline styles. Also rebaselined some tests as their results
have progressed.

* editing/pasteboard/insert-u-with-text-decoration-none-expected.txt: Added.
* editing/pasteboard/insert-u-with-text-decoration-none.html: Added.
* editing/pasteboard/insert-font-with-size-and-css-expected.txt: Added.
* editing/pasteboard/insert-font-with-size-and-css.html: Added.
* editing/pasteboard/4744008-expected.txt:
* editing/pasteboard/paste-text-with-style-5-expected.txt:
* editing/pasteboard/paste-text-with-style-5.html:
* editing/pasteboard/style-from-rules-expected.txt:
* editing/pasteboard/style-from-rules.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused make variable from DerivedSources.make
commit-queue@webkit.org [Sat, 23 Feb 2013 01:32:31 +0000 (01:32 +0000)]
Remove unused make variable from DerivedSources.make
https://bugs.webkit.org/show_bug.cgi?id=110306

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-22
Reviewed by Alexey Proskuryakov.

r107026 removed the last piece of logic that was guarded with
ENABLE_DASHBOARD_SUPPORT, so now it can be removed from
DerivedSources.make.

Also combined the way ENABLE_ORIENTATION_EVENTS is set to 0
to make it more readable.

No new tests, no new functionality.

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r130089): Scrollbar thumb no longer re-rendered on hover
dglazkov@chromium.org [Sat, 23 Feb 2013 01:15:14 +0000 (01:15 +0000)]
REGRESSION(r130089): Scrollbar thumb no longer re-rendered on hover
https://bugs.webkit.org/show_bug.cgi?id=109230

Source/WebCore:

In r130089, I accidentally removed the extra check that made scrollbar
parts styles sad. I put it back and made them happy.

Reviewed by Eric Seidel.

Test: fast/css/pseudo-element-selector-scrollbar-hover.html

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match): Added the check back.

LayoutTests:

Reviewed by Eric Seidel.

* fast/css/pseudo-element-selector-scrollbar-hover-expected.html: Added.
* fast/css/pseudo-element-selector-scrollbar-hover.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG::SpeculativeJIT::speculateNumber() should just use SpeculateDoubleOperand instead...
fpizlo@apple.com [Sat, 23 Feb 2013 01:10:31 +0000 (01:10 +0000)]
DFG::SpeculativeJIT::speculateNumber() should just use SpeculateDoubleOperand instead of doing its own thing
https://bugs.webkit.org/show_bug.cgi?id=110659

Reviewed by Oliver Hunt and Mark Hahnenberg.

This simplifies the code, and also has the effect that if speculateNumber() is called
prior to someone actually using the number in a double context, then the number will
already be up-converted to double and ready to go.

Previously if this ever came up, the subsequent use would have to again branch to see
if the value is tagged as int or tagged as double.

On the other hand, if you ever did speculateNumber() and then used the value as a
JSValue, this will be a slow down now.

I suspect that the former (speculateNumber() and then use as number) is more likely
than the latter (speculateNumber() and then use as JSValue).

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculateNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG FixupPhase should have one common hook for knowing if a node is ever being specul...
fpizlo@apple.com [Sat, 23 Feb 2013 01:03:10 +0000 (01:03 +0000)]
DFG FixupPhase should have one common hook for knowing if a node is ever being speculated a certain way
https://bugs.webkit.org/show_bug.cgi?id=110650

Reviewed by Mark Hahnenberg.

Changes almost all calls to edge.setUseKind(kind) to be
setUseKindAndUnboxIfProfitable<kind>(edge). This will allow us to use the latter
as a hook for deciding which locals to unbox (webkit.org/b/110433).

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::setUseKindAndUnboxIfProfitable):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::fixDoubleEdge):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] The root and page overlay layers should be the size of the view, not the content
timothy_horton@apple.com [Sat, 23 Feb 2013 00:57:10 +0000 (00:57 +0000)]
[WK2] The root and page overlay layers should be the size of the view, not the content
https://bugs.webkit.org/show_bug.cgi?id=110660
<rdar://problem/13096456>

Reviewed by Simon Fraser.

Use the view size for the size of the root and page overlay layers.
For one, we never update these layers' sizes when the content size changes, causing size mismatches.
In addition, there's no reason an overlay shouldn't be able to draw outside of the bounds of the content.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agopluginLoadStrategy should take a WKDictionaryRef for extensibility
andersca@apple.com [Sat, 23 Feb 2013 00:43:38 +0000 (00:43 +0000)]
pluginLoadStrategy should take a WKDictionaryRef for extensibility
https://bugs.webkit.org/show_bug.cgi?id=110656
<rdar://problem/13265303>

Reviewed by Jessie Berlin.

Source/WebCore:

Export a symbol needed by WebKit2.

* WebCore.exp.in:

Source/WebKit2:

Change pluginLoadStrategy to take a WKDictionaryRef instead of a number of parameters;
this lets us add more plug-in information if needed. Also add the page URL and rename documentURL to frameURL.

* UIProcess/API/C/WKPage.cpp:
(WKPageGetPluginInformationBundleIdentifierKey):
(WKPageGetPluginInformationBundleVersionKey):
(WKPageGetPluginInformationDisplayNameKey):
(WKPageGetPluginInformationFrameURLKey):
(WKPageGetPluginInformationMIMETypeKey):
(WKPageGetPluginInformationPageURLKey):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit):
(WebKit::WebLoaderClient::pluginLoadPolicy):
* UIProcess/WebLoaderClient.h:
(WebLoaderClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath):
(WebKit::WebPageProxy::pluginInformationBundleIdentifierKey):
(WebKit):
(WebKit::WebPageProxy::pluginInformationBundleVersionKey):
(WebKit::WebPageProxy::pluginInformationDisplayNameKey):
(WebKit::WebPageProxy::pluginInformationFrameURLKey):
(WebKit::WebPageProxy::pluginInformationMIMETypeKey):
(WebKit::WebPageProxy::pluginInformationPageURLKey):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143815 268f45cc-cd09-0410-ab3c-d52691b4dbfc