WebKit-https.git
9 years ago2011-07-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 5 Jul 2011 22:59:53 +0000 (22:59 +0000)]
2011-07-05  Eric Seidel  <eric@webkit.org>

        new-run-webkit-tests fails to start http server if one is already running
        https://bugs.webkit.org/show_bug.cgi?id=63956

        Reviewed by Adam Barth.

        * BuildSlaveSupport/kill-old-processes:
         - Removed ^M line endings and sorted the process names.
         - There are no functional changes to this file.
           (except that now that its using unix line endings it can be executed directly!)
        * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
         - Change the name to 'httpd' to match old-run-webkit-test paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 5 Jul 2011 22:54:50 +0000 (22:54 +0000)]
2011-07-05  Adam Barth  <abarth@webkit.org>

        Add basic ajax support to garden-o-matic
        https://bugs.webkit.org/show_bug.cgi?id=63874

        Reviewed by Eric Seidel.

        This patch adds some basic infrastructure to garden-o-matic.
        Currently, the infrastructure is just used to make the "quit" command
        use Ajax, but in the future, this infrastructure will be used to do
        more sophistocated remote proceedure calls.

        * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
        * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added.
        * Scripts/webkitpy/tool/servers/gardeningserver.py:
        * Scripts/webkitpy/tool/servers/reflectionhandler.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 5 Jul 2011 22:52:01 +0000 (22:52 +0000)]
2011-07-05  Adam Barth  <abarth@webkit.org>

        Add trivial garden-o-matic command (with server)
        https://bugs.webkit.org/show_bug.cgi?id=63872

        Reviewed by Eric Seidel.

        This patch adds a trivial "Hello, world" garden-o-matic command,
        complete with an HTTP server.  This command re-uses a bunch of code
        from the existing rebaseline-server command.  Over time, this command
        will grow to be a tool useful for gardening the WebKit tree.

        * Scripts/webkitpy/tool/commands/__init__.py:
        * Scripts/webkitpy/tool/commands/abstractservercommand.py: Added.
        * Scripts/webkitpy/tool/commands/gardenomatic.py: Added.
        * Scripts/webkitpy/tool/commands/rebaselineserver.py:
        * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added.
        * Scripts/webkitpy/tool/servers/gardeningserver.py: Added.
        * Scripts/webkitpy/tool/servers/rebaselineserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake prepare-ChangeLog include modified Perl functions in its ChangeLog template
aroben@apple.com [Tue, 5 Jul 2011 22:20:53 +0000 (22:20 +0000)]
Make prepare-ChangeLog include modified Perl functions in its ChangeLog template

This is a very simple first cut. Functions must start with a line that starts with "sub "
and end with a line that starts with a closing brace. No leading whitespace is allowed.
Package names aren't parsed at all.

Fixes <http://webkit.org/b/21591> prepare-ChangeLog should know how to find functions in
Perl files

Reviewed by David Kilzer.

* Scripts/prepare-ChangeLog: Removed redundant code that ignored certain files when
searching for function line ranges. This is already done inside the get_function_line_ranges
function.
(get_function_line_ranges): Cleaned up coding style a little bit. Call
get_function_line_ranges_for_perl for files with .pl and .pm extensions. For files with an
unknown extension or no extension, read the shebang line to try to determine the script
interpreter. Call get_function_line_ranges_for_perl if the interpreter seems to be Perl.
(get_function_line_ranges_for_perl): Added. Does extremely basic parsing of the file to find
lines starting with "sub " or "}".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up run-api-tests output on Windows
aroben@apple.com [Tue, 5 Jul 2011 22:20:43 +0000 (22:20 +0000)]
Clean up run-api-tests output on Windows

We were mixing run-api-tests output with gtest output, and the result was a mess.

Fixes <http://webkit.org/b/63954> run-api-tests output is very confusing on Windows

Reviewed by Dan Bates.

* Scripts/run-api-tests:
(runTest):
(populateTests):
Made Windows use the formerly-Mac-only codepaths which correctly suppress gtest output
except in verbose mode. Most changes are due to indentation. Use of the arch utility is now
the only Mac-specific thing in these functions. Some other platform-specific code was moved
from here...

(prepareEnvironmentForRunningTestTool):
(testToolPath):
...to here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Tue, 5 Jul 2011 22:13:41 +0000 (22:13 +0000)]
2011-07-05  Hans Wennborg  <hans@chromium.org>

        [V8][Chromium] Remove use of OwnHandle from V8LocalContext
        https://bugs.webkit.org/show_bug.cgi?id=63925

        Reviewed by Adam Barth.

        Replace the OwnHandle<> member in V8LocalContext with
        v8::Persistent<v8::Context>.
        The code that used OwnHandle<> would not correctly Dispose
        of the Context, which would cause the memory to fill up when creating
        and destructing many V8LocalContext objects, such as in the case
        of IndexedDB.

        * bindings/v8/V8Utilities.cpp:
        (WebCore::V8LocalContext::V8LocalContext):
        (WebCore::V8LocalContext::~V8LocalContext):
        * bindings/v8/V8Utilities.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Tue, 5 Jul 2011 21:29:42 +0000 (21:29 +0000)]
2011-07-05  Igor Oliveira  <igor.oliveira@openbossa.org>

        [Qt] Add ShadowBlur support
        https://bugs.webkit.org/show_bug.cgi?id=62997

        Use ShadowBlur instead of ContextShadow to handle canvas and css shadows. ShadowBlur is
        a newer and platform independent shadow implementation.
        Qt QPainter does not have support for shadows so is necessary to create a layer support
        to draw complex shapes and fonts. The beginShadowLayer creates a temporary shadow buffer
        where the canvas can draw onto and endShadowLayer applies the blur filter, colors the
        shadow buffer and draw the final shadow to the graphics context.

        Reviewed by Andreas Kling.

        * WebCore.pro:
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ShadowBlur::ShadowBlur):
        (WebCore::ShadowBlur::setShadowValues):
        (WebCore::ShadowBlur::updateShadowBlurValues):
        (WebCore::ShadowBlur::clear):
        (WebCore::ShadowBlur::blurAndColorShadowBuffer):
        (WebCore::ShadowBlur::beginShadowLayer):
        (WebCore::ShadowBlur::endShadowLayer):
        * platform/graphics/ShadowBlur.h:
        (WebCore::ShadowBlur::type):
        * platform/graphics/qt/ContextShadowQt.cpp: Removed.
        * platform/graphics/qt/FontQt.cpp:
        (WebCore::drawTextCommon):
        (WebCore::Font::drawGlyphs):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContextPlatformPrivate::mustUseShadowBlur):
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContext::savePlatformState):
        (WebCore::GraphicsContext::restorePlatformState):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::shadowBlur):
        (WebCore::GraphicsContext::clipBounds):
        (WebCore::GraphicsContext::setPlatformShadow):
        (WebCore::GraphicsContext::clearPlatformShadow):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::draw):
        * platform/graphics/qt/StillImageQt.cpp:
        (WebCore::StillImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 5 Jul 2011 20:51:06 +0000 (20:51 +0000)]
2011-07-05  Sam Weinig  <sam@webkit.org>

        Null deref accessing CustomEvent.detail
        <rdar://problem/9724577>
        https://bugs.webkit.org/show_bug.cgi?id=63885

        Reviewed by Anders Carlsson.

        Test: fast/events/custom-event-uninitialized.html

        * bindings/scripts/CodeGeneratorJS.pm:
        Guard against uninitialized script value.
2011-07-05  Sam Weinig  <sam@webkit.org>

        Null deref accessing CustomEvent.detail
        <rdar://problem/9724577>
        https://bugs.webkit.org/show_bug.cgi?id=63885

        Reviewed by Anders Carlsson.

        Add test which exercises an initialized details property on
        a CustomEvent instance.

        * fast/events/custom-event-uninitialized-expected.txt: Added.
        * fast/events/custom-event-uninitialized.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix following last patch.
barraclough@apple.com [Tue, 5 Jul 2011 20:09:05 +0000 (20:09 +0000)]
Build fix following last patch.

* runtime/JSFunction.cpp:
(JSC::createPrototypeProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Rafael Brandao <rafael.lobo@openbossa.org>
commit-queue@webkit.org [Tue, 5 Jul 2011 19:45:00 +0000 (19:45 +0000)]
2011-07-05  Rafael Brandao  <rafael.lobo@openbossa.org>

        [Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
        https://bugs.webkit.org/show_bug.cgi?id=63235

        Modified baseUrl to be a local file in order to get a security origin
        that is allowed to request local resources. Removed QSignalSpy from it
        as loadFinished always happens, and the original test was split into two.

        Reviewed by Benjamin Poulain.

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::setHtmlWithImageResource):
        (tst_QWebFrame::setHtmlWithStylesheetResource):
        (tst_QWebFrame::setHtmlWithBaseURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=63947
barraclough@apple.com [Tue, 5 Jul 2011 19:02:44 +0000 (19:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63947
ASSERT running Object.preventExtensions(Math.sin)

Reviewed by Oliver Hunt.

This is due to calling scope() on a hostFunction as a part of
calling createPrototypeProperty to reify the prototype property.
But host functions don't have a prototype property anyway!

Source/JavaScriptCore:

Prevent callling createPrototypeProperty on a host function.

* runtime/JSFunction.cpp:
(JSC::JSFunction::createPrototypeProperty):
(JSC::JSFunction::preventExtensions):

LayoutTests:

Add test case for calling preventExtensions on a host function.

* fast/js/preventExtensions-expected.txt:
* fast/js/script-tests/preventExtensions.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=63880
barraclough@apple.com [Tue, 5 Jul 2011 19:01:41 +0000 (19:01 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63880
Evaluation order of conversions of operands to >, >= incorrect.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Add 'leftFirst' parameter to jsLess, jsLessEq matching that described in the ES5
spec. This allows these methods to be reused to perform >, >= relational compares
with correct ordering of type conversions.

* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Operations.h:
(JSC::jsLess):
(JSC::jsLessEq):

LayoutTests:

Updated layout test results. Two of these tests now pass, however for
the third we now need to check in failing results, since the test is
incorrect!

The problem if that the test author has made the mistake of thinking
that the evaluation order for the operands to '>' is RHS then LHS.
This is due to a quirk in the way the spec is written. The greater
than opeator is defined to call the abstract relational comparison
algorithm with 'leftFirst' set to false, and as such conversion is
performed on the second operand ('y') first (see 11.8.5). However
the abstract relational comparison algorith is performing a less
than comaprison, and the greater than operator calls this algorithm
with the operands to the greater than operator reversed (see 11.8.2).
As such, the second operand to the abstract comaparison is the LHS
of the greater than. This bug also affects the corresponding less
than or equals test, where we already we have failing results checked
in, and again it is the test that is wrong (for the same reason).

* fast/js/exception-sequencing-binops2-expected.txt:
* sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.2_The_Greater_than_Operator/S11.8.2_A2.3_T1-expected.txt:
* sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.4_The_Grater_than_or_equal_Operator/S11.8.4_A2.3_T1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Pratik Solanki <psolanki@apple.com>
psolanki@apple.com [Tue, 5 Jul 2011 17:34:43 +0000 (17:34 +0000)]
2011-07-05  Pratik Solanki  <psolanki@apple.com>

        Reviewed by Dan Bernstein.

        Coalesce data array into one NSData before calling didReceiveData
        https://bugs.webkit.org/show_bug.cgi?id=63916
        <rdar://problem/9715181>

        Instead of calling didReceiveData multiple times with smaller chunks of data, we merge the
        data buffers into one and call it once.

        No new tests because the flag isn't enabled yet.

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Tamas Czene <Czene.Tamas@stud.u-szeged.hu>
commit-queue@webkit.org [Tue, 5 Jul 2011 16:07:35 +0000 (16:07 +0000)]
2011-07-05  Tamas Czene  <Czene.Tamas@stud.u-szeged.hu>

        Reviewed by Simon Fraser.

        Remove virtual functions from StyleImage.
        https://bugs.webkit.org/show_bug.cgi?id=63909

        We can remove the virtual "isChachedImage, isPendingImage, isGeneratedImage" functions to speed up the StyleImage.
        Some profile data shows this part is significant, especially in small CSS-based sites.
        Removing the virtual functions - removing the calls - makes a small performance progression on this part.

        * rendering/style/StyleCachedImage.h:
        (WebCore::StyleCachedImage::StyleCachedImage):
        * rendering/style/StyleGeneratedImage.h:
        (WebCore::StyleGeneratedImage::StyleGeneratedImage):
        * rendering/style/StyleImage.h:
        (WebCore::StyleImage::isCachedImage):
        (WebCore::StyleImage::isPendingImage):
        (WebCore::StyleImage::isGeneratedImage):
        (WebCore::StyleImage::StyleImage):
        * rendering/style/StylePendingImage.h:
        (WebCore::StylePendingImage::StylePendingImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 5 Jul 2011 16:01:45 +0000 (16:01 +0000)]
2011-07-05  Yury Semikhatsky  <yurys@chromium.org>

        [Chromium] Web Inspector: extend WebSharedWorker with inspector transport methods
        https://bugs.webkit.org/show_bug.cgi?id=63942

        Added methods for connecting inspector to shared worker and for passing
        messages between shared worker inspector and corresponding inspector frontend.

        Reviewed by Pavel Feldman.

        * public/WebCommonWorkerClient.h:
        (WebKit::WebCommonWorkerClient::dispatchDevToolsMessage):
        * public/WebSharedWorker.h:
        (WebKit::WebSharedWorker::attachDevTools):
        (WebKit::WebSharedWorker::detachDevTools):
        (WebKit::WebSharedWorker::dispatchDevToolsMessage):
        * public/WebWorkerClient.h:
        * src/WebSharedWorkerImpl.cpp:
        (WebKit::connectToWorkerContextInspectorTask):
        (WebKit::WebSharedWorkerImpl::attachDevTools):
        (WebKit::disconnectFromWorkerContextInspectorTask):
        (WebKit::WebSharedWorkerImpl::detachDevTools):
        (WebKit::dispatchOnInspectorBackendTask):
        (WebKit::WebSharedWorkerImpl::dispatchDevToolsMessage):
        * src/WebSharedWorkerImpl.h:
        * src/WebWorkerBase.cpp:
        (WebKit::WebWorkerBase::postMessageToPageInspectorTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 5 Jul 2011 15:35:19 +0000 (15:35 +0000)]
2011-07-05  Pavel Feldman  <pfeldman@google.com>

        Web Inspector: add "element state" setting to the styles section title.
        https://bugs.webkit.org/show_bug.cgi?id=63932

        Reviewed by Yury Semikhatsky.

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * inspector/front-end/Images/paneElementStateButtons.png: Added.
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.muteEventListener):
        (WebInspector.StylesSidebarPane):
        (WebInspector.StylesSidebarPane.prototype.update):
        (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
        (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
        (WebInspector.StylesSidebarPane.prototype.addBlankSection):
        (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
        (WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
        (WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
        (WebInspector.StylesSidebarPane.prototype._createElementStatePane.createCheckbox):
        (WebInspector.StylesSidebarPane.prototype._createElementStatePane):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (.pane > .title > .pane-title-button:active, .pane > .title > .pane-title-button.toggled):
        (.pane > .title > .pane-title-button.element-state):
        (.styles-element-state-pane):
        (.styles-element-state-pane.expanded):
        (.styles-element-state-pane > table):
        (.styles-element-state-pane input):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 5 Jul 2011 13:41:50 +0000 (13:41 +0000)]
2011-07-05  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Marked css2.1/20110323/replaced-intrinsic-ratio-001.htm as flaky on mac.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 5 Jul 2011 13:31:56 +0000 (13:31 +0000)]
2011-06-22  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extract duplicated code that deals with source mappings.
        https://bugs.webkit.org/show_bug.cgi?id=63139

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleMessage.prototype.isEqual):
        (WebInspector.ConsoleMessage.prototype.get stackTrace):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
        (WebInspector.DebuggerPresentationModel.prototype._updateAnchor):
        (WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
        (WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
        (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
        (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didGetScriptLocation):
        (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.updateSourceFileBreakpointsAndDispatchEvent):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didGetUILocation):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
        (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
        (WebInspector.PresenationCallFrame):
        (WebInspector.PresenationCallFrame.prototype.sourceLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 5 Jul 2011 13:10:11 +0000 (13:10 +0000)]
2011-07-05  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: WebInspector frontend reports a protocol error in remote debugging mode.
        https://bugs.webkit.org/show_bug.cgi?id=63935

        it was error generated for obsolete message "loaded" which was sent from frontend to backend.

        Reviewed by Yury Semikhatsky.

        * inspector/CodeGeneratorInspector.pm:
        * inspector/front-end/inspector.js:
        (WebInspector.loaded.WebInspector.socket.onopen):
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 5 Jul 2011 12:50:58 +0000 (12:50 +0000)]
2011-07-05  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: [refactoring] remove network-sidebar style, add network-log-grid
        https://bugs.webkit.org/show_bug.cgi?id=63913

        Reviewed by Yury Semikhatsky.

        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype._createTable):
        * inspector/front-end/networkPanel.css:
        (.network-log-grid):
        (.network-log-grid table.data):
        (.network-log-grid.small table.data):
        (.network-log-grid td):
        (.network-log-grid.small td):
        (.network-log-grid th):
        (.network-log-grid.small th):
        (.network-log-grid th, .network.panel .data-grid th.sort-descending, .network.panel .data-grid th.sort-ascending):
        (.network-log-grid .data-container):
        (.network-log-grid.small .data-container):
        (.network-log-grid select):
        (.network-log-grid.small tr.offscreen):
        (.network-log-grid tr.offscreen):
        (.network-log-grid tr.offscreen td):
        (.network-log-grid tr.filler):
        (.network-log-grid tr:not(.filler) td.name-column):
        (.network.panel:not(.viewing-resource) .network-log-grid td.name-column:hover):
        (.network-log-grid td.time-column):
        (.network-log-grid.small .network-graph-side):
        (.network-log-grid th.sortable:active):
        (.network-log-grid tr.selected .network-cell-subtitle):
        (.network-log-grid .icon):
        (.network-log-grid.small .icon):
        (.network-log-grid .network-category-scripts .icon):
        (.network-log-grid.small .network-category-scripts .icon):
        (.network-log-grid .network-category-documents .icon):
        (.network-log-grid.small .network-category-documents .icon):
        (.network-log-grid .network-category-stylesheets .icon):
        (.network-log-grid.small .network-category-stylesheets .icon):
        (.network-log-grid .network-category-images .icon):
        (.network-log-grid.small .network-category-images .icon):
        (.network-log-grid .image-network-icon-preview):
        (.network-log-grid.small .image-network-icon-preview):
        (.network-timeline-grid.small .network-event-divider):
        (.network-log-grid .resources-dividers):
        (.network-log-grid .resources-dividers-label-bar):
        (.network-timeline-grid.small .resources-dividers-label-bar):
        (.network-timeline-grid .resources-divider-label):
        (.network-timeline-grid .resources-dividers-label-bar .resources-divider):
        (.network-timeline-grid.small .resources-dividers-label-bar .resources-divider):
        (.network-timeline-grid .resources-divider.first .resources-divider-label):
        (.network-timeline-grid .resources-dividers-label-bar .resources-divider.first):
        (.network-timeline-grid tr.filler td):
        (.network-summary-bar td):
        (.network.panel.viewing-resource .network-log-grid th):
        (.network-log-grid.full-grid-mode .viewer-column):
        (.network-log-grid.brief-grid-mode .time-column):
        (.network-log-grid.viewing-resource-mode .timeline-column):
        (.network.panel .sidebar):
        (.network.panel.viewing-resource .network-log-grid .data-grid-resizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Alexandru Chiculita <achicu@adobe.com>
commit-queue@webkit.org [Tue, 5 Jul 2011 12:49:20 +0000 (12:49 +0000)]
2011-07-05  Alexandru Chiculita  <achicu@adobe.com>

        Reviewed by Simon Hausmann.

        [Qt] "cat" is not available when building.
        https://bugs.webkit.org/show_bug.cgi?id=63924

        Changed 'cat' to 'perl -ne \"print $1\"' because 'cat' is not available on Windows with
        MSVC toolchain. It passed the Qt buildbots, because they run with cygwin.

        Project file change. No tests needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 5 Jul 2011 11:12:40 +0000 (11:12 +0000)]
2011-07-05  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Removed custom chromium-linux baselines for
        navigator-detached-no-crash.html & register-protocol-handler.html

        * platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
        * platform/chromium-linux/fast/dom/register-protocol-handler-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Vsevolod Vlasov <vsevik@chromium.org>
vsevik@chromium.org [Tue, 5 Jul 2011 10:36:06 +0000 (10:36 +0000)]
2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>

        Unreviewed; Qt Linux Release minimal compile fix.

        * testing/Internals.h:
        (WebCore::Internals::setInspectorResourcesDataSizeLimits):
        * testing/Internals.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Vsevolod Vlasov <vsevik@chromium.org>
vsevik@chromium.org [Tue, 5 Jul 2011 10:16:36 +0000 (10:16 +0000)]
2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Show content for plugin requests in network panel.
        https://bugs.webkit.org/show_bug.cgi?id=30080

        Added GTK symbols for new window.internals methods.

        Reviewed by Pavel Feldman.

        * Source/autotools/symbols.filter:
2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Show content for plugin requests in network panel.
        https://bugs.webkit.org/show_bug.cgi?id=30080

        Added tests for plugin content saving and replacing in NetworkResourcesData.
        Adjusted older tests to use new window.internals method setInspectorResourcesDataSizeLimits
        to ensure NetworkResourcesData is in the correct state before test.

        Reviewed by Pavel Feldman.

        * http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
        * http/tests/inspector/network/network-content-replacement-embed.html: Added.
        * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
        * http/tests/inspector/network/network-content-replacement-xhr.html: Added.
        * http/tests/inspector/network/network-embed-expected.txt: Added.
        * http/tests/inspector/network/network-embed.html: Added.
        * http/tests/inspector/network/network-xhr-async-expected.txt:
        * http/tests/inspector/network/network-xhr-async.html:
        * http/tests/inspector/network/network-xhr-sync-expected.txt:
        * http/tests/inspector/network/network-xhr-sync.html:
        * http/tests/inspector/network/resources/cp1251.xml: Added.
        * http/tests/inspector/network/resources/plugin-data.php: Added.
        * http/tests/inspector/network/resources/resource.php:
        * http/tests/inspector/network/resources/utf8.xml: Added.
        * platform/chromium/test_expectations.txt:
2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Show content for plugin requests in network panel.
        https://bugs.webkit.org/show_bug.cgi?id=30080

        Now the data from didReceiveData callback is passed to inspector.
        It is then saved in NetworkResourcesData structure for plugin requests.
        Added window.internals.setInspectorResourcesDataSizeLimits() method
        for testing replacement logic.

        Reviewed by Pavel Feldman.

        Tests: http/tests/inspector/network/network-content-replacement-embed.html
               http/tests/inspector/network/network-content-replacement-xhr.html
               http/tests/inspector/network/network-embed.html

        * WebCore.exp.in:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didReceiveDataImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::didReceiveData):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::didReceiveResponse):
        (WebCore::InspectorResourceAgent::didReceiveData):
        (WebCore::InspectorResourceAgent::didFinishLoading):
        (WebCore::InspectorResourceAgent::setInitialXHRContent):
        (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals):
        (WebCore::InspectorResourceAgent::getResourceContent):
        * inspector/InspectorResourceAgent.h:
        * inspector/NetworkResourcesData.cpp:
        (WebCore::NetworkResourcesData::ResourceData::ResourceData):
        (WebCore::NetworkResourcesData::ResourceData::setContent):
        (WebCore::NetworkResourcesData::ResourceData::purgeContent):
        (WebCore::NetworkResourcesData::ResourceData::createDecoder):
        (WebCore::NetworkResourcesData::ResourceData::dataLength):
        (WebCore::NetworkResourcesData::ResourceData::appendData):
        (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
        (WebCore::NetworkResourcesData::NetworkResourcesData):
        (WebCore::NetworkResourcesData::responseReceived):
        (WebCore::NetworkResourcesData::setResourceContent):
        (WebCore::NetworkResourcesData::maybeAddResourceData):
        (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
        (WebCore::NetworkResourcesData::data):
        (WebCore::NetworkResourcesData::clear):
        (WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
        (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
        (WebCore::NetworkResourcesData::ensureFreeSpace):
        * inspector/NetworkResourcesData.h:
        (WebCore::NetworkResourcesData::ResourceData::hasContent):
        (WebCore::NetworkResourcesData::ResourceData::content):
        (WebCore::NetworkResourcesData::ResourceData::decoder):
        (WebCore::NetworkResourcesData::ResourceData::buffer):
        (WebCore::NetworkResourcesData::ResourceData::setBuffer):
        (WebCore::NetworkResourcesData::ResourceData::hasData):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.get contentEncoded):
        * inspector/front-end/ResourcePreviewView.js:
        (WebInspector.ResourcePreviewView.prototype.contentLoaded):
        (WebInspector.ResourcePreviewView.prototype._createEmptyView):
        (WebInspector.ResourcePreviewView.prototype._createPreviewView):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.hasTextContent):
        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::didReceiveData):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::willLoadMediaElementURL):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::didReceiveData):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
        (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
        * loader/ResourceLoadNotifier.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::didReceiveData):
        * testing/Internals.cpp:
        (WebCore::Internals::setInspectorResourcesDataSizeLimits):
        * testing/Internals.h:
        * testing/Internals.idl:
2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Show content for plugin requests in network panel.
        https://bugs.webkit.org/show_bug.cgi?id=30080

        Added win symbols for new window.internals methods.

        Reviewed by Pavel Feldman.

        * win/WebKit2.def:
        * win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 5 Jul 2011 09:31:24 +0000 (09:31 +0000)]
2011-07-05  Kent Tamura  <tkent@chromium.org>

        Add an assertion that percent height box is unregistered correctly.
        https://bugs.webkit.org/show_bug.cgi?id=62792

        Reviewed by Hajime Morita.

        No new tests. This won't change behavior.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::hasPercentHeightDescendant): Added.
        * rendering/RenderBlock.h: Declare hasPercentHeightDescendant().
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::destroy): Assert !hasPercentHeightDescendant().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 5 Jul 2011 08:44:59 +0000 (08:44 +0000)]
2011-07-04  Pavel Feldman  <pfeldman@google.com>

        Web Inspector: Enable settings screen with settings for console and elements panels.
        https://bugs.webkit.org/show_bug.cgi?id=62853

        Reviewed by Yury Semikhatsky.

        * English.lproj/localizedStrings.js:
        * inspector/front-end/HelpScreen.js:
        (WebInspector.HelpScreen.prototype.hide):
        * inspector/front-end/SettingsScreen.js:
        (WebInspector.SettingsScreen):
        (WebInspector.SettingsScreen.prototype._createRadioSetting.clickListener):
        (WebInspector.SettingsScreen.prototype._createRadioSetting.get for):
        * inspector/front-end/ShortcutsScreen.js:
        (WebInspector.ShortcutsScreen.prototype.hide):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._colorFormatSettingChanged):
        (WebInspector.StylesSidebarPane.prototype._updateColorFormatFilter.get var):
        (WebInspector.StylesSidebarPane.prototype._updateColorFormatFilter):
        (WebInspector.StylesSidebarPane.prototype._changeSetting):
        (WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
        * inspector/front-end/inspector.css:
        (#counters):
        * inspector/front-end/inspector.js:
        (WebInspector._createGlobalStatusBarItems):
        (WebInspector._toggleSettings):
        (WebInspector._showShortcutsScreen):
        (WebInspector._hideShortcutsScreen):
        (WebInspector._showSettingsScreen.onhide):
        (WebInspector._showSettingsScreen):
        (WebInspector._hideSettingsScreen):
        (WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Tue, 5 Jul 2011 08:35:42 +0000 (08:35 +0000)]
2011-07-04  Kinuko Yasuda  <kinuko@chromium.org>

        [Chromium] LayoutTests/fast/filesystem/workers/simple-persistent-sync.html is failing on chromium worker tests
        https://bugs.webkit.org/show_bug.cgi?id=63906

        The expected text file needs to be updated to reflect the recent API change for adding the prefix vendor (i.e. requestFileSystem -> webkitRequestFileSystem).

        Unreviewed; chromium test expectations change.

        * fast/filesystem/workers/simple-persistent-sync-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-05 Shinya Kawanaka <shinyak@google.com>
commit-queue@webkit.org [Tue, 5 Jul 2011 07:18:01 +0000 (07:18 +0000)]
2011-07-05  Shinya Kawanaka  <shinyak@google.com>

        Reviewed by Kent Tamura.

        The default step is used when the step attribute of input[type='number'] is "any".
        https://bugs.webkit.org/show_bug.cgi?id=57723

        Changed Layout tests to use the default step when the step attribute of
        input[type='number'] is "any".

        * fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Regenerated.
        * fast/forms/script-tests/input-stepup-stepdown-from-renderer.js:
2011-07-05  Shinya Kawanaka  <shinyak@google.com>

        Reviewed by Kent Tamura.

        The default step is used when attribute step of input[type='number'] is "any".
        https://bugs.webkit.org/show_bug.cgi?id=57723

        When step is "any", 0 was chosen as step, but this is not intuitive.
        So changed to use the default step.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::getAllowedValueStep):
          Calls getAllowedValueStepWithDecimalPlaces with RejectAny.
        (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces):
          Takes a new arugument AnyStepHandling. If it is AnyIsDefaultStep, this method
          allows "step" attribute to take a value "any" to use the default step as step value.
          Otherwise, INVALID_STATE_ERR will be returned if "step" is "any".
        (WebCore::HTMLInputElement::applyStep): ditto.
        (WebCore::HTMLInputElement::stepUp):
          Calls applyStep with RejectAny.
        (WebCore::HTMLInputElement::stepDown): ditto.
        (WebCore::HTMLInputElement::stepUpFromRenderer):
          Removes a check that step is "any". It is checked in getAllowedValueStepWithDecimalPlaces.
        * html/HTMLInputElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Tue, 5 Jul 2011 04:21:24 +0000 (04:21 +0000)]
2011-07-04  Dominic Cooney   <dominicc@chromium.org>

        Simplify <progress> element's isDeterminate logic.
        https://bugs.webkit.org/show_bug.cgi?id=63889

        Reviewed by Hajime Morita.

        Covered by existing tests
        fast/dom/HTMLProgressElement/indeterminate-progress-*.html

        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::position): don't duplicate isDeterminate
        (WebCore::HTMLProgressElement::isDeterminate): remove redundant tests
        (WebCore::HTMLProgressElement::didElementStateChange): fix formatting
        * html/HTMLProgressElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Sam Weinig.
barraclough@apple.com [Tue, 5 Jul 2011 02:59:02 +0000 (02:59 +0000)]
Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=16652
Firefox and JavaScriptCore differ in Number.toString(integer)

Source/JavaScriptCore:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

* runtime/NumberPrototype.cpp:
(JSC::decomposeDouble):
    - helper function to extract sign, exponent, mantissa from IEEE doubles.
(JSC::Uint16WithFraction::Uint16WithFraction):
    - helper class, u16int with infinite precision fraction, used to convert
      the fractional part of the number to a string.
(JSC::Uint16WithFraction::operator*=):
    - Multiply by a uint16.
(JSC::Uint16WithFraction::operator<):
    - Compare two Uint16WithFractions.
(JSC::Uint16WithFraction::floorAndSubtract):
    - Extract the integer portion of the number, and subtract it (clears the integer portion).
(JSC::Uint16WithFraction::comparePoint5):
    - Compare to 0.5.
(JSC::Uint16WithFraction::sumGreaterThanOne):
    - Passed a second Uint16WithFraction, returns true if the result of adding
      the two values would be greater than one.
(JSC::Uint16WithFraction::isNormalized):
    - Used by ASSERTs to consistency check internal representation.
(JSC::BigInteger::BigInteger):
    - helper class, unbounded integer value, used to convert the integer part
      of the number to a string.
(JSC::BigInteger::divide):
    - Divide this value through by a uint32.
(JSC::BigInteger::operator!):
    - test for zero.
(JSC::toStringWithRadix):
    - Performs number to string conversion, with the given radix (2..36).
(JSC::numberProtoFuncToString):
    - Changed to use toStringWithRadix.

Tools:

Added forwarding header.

* DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.

LayoutTests:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

* fast/js/number-toString-expected.txt:
    - Update expected results from FAIL to PASS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Tue, 5 Jul 2011 02:19:12 +0000 (02:19 +0000)]
2011-07-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Add hasOwnDisabledStateHandlingFor() to RenderThemeEfl
        https://bugs.webkit.org/show_bug.cgi?id=63884

        As MediaControlRootElement decides whether it will display timeline
        according to the return value of RenderTheme's hasOwnDisabledStateHandlingFor(),
        RenderThemeEfl has to implement this function.

        Existing tests cover the visibility of the controls.

        * platform/efl/RenderThemeEfl.h:
        (WebCore::RenderThemeEfl::hasOwnDisabledStateHandlingFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 5 Jul 2011 02:18:51 +0000 (02:18 +0000)]
2011-07-04  Mihai Parparita  <mihaip@chromium.org>

        As of r90372 there are WebKit2 Mac-specific tests; don't expect those to
        pass in Chromium, just like other platform-specific tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMoved handling of frame size changes into its own method.
mitz@apple.com [Tue, 5 Jul 2011 01:54:27 +0000 (01:54 +0000)]
Moved handling of frame size changes into its own method.

Reviewed by Oliver Hunt.

* WebView/WebFrameView.mm:
(-[WebFrameView _frameSizeChanged]): Added. Moved code here...
(-[WebFrameView setFrameSize:]): ...from here.
* WebView/WebFrameViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 5 Jul 2011 01:27:45 +0000 (01:27 +0000)]
2011-07-04  Kent Tamura  <tkent@chromium.org>

        REGRESSION (r87067): Text overflows from short height text field.
        https://bugs.webkit.org/show_bug.cgi?id=61768

        Reviewed by Dimitri Glazkov.

        * fast/forms/textfield-overflow-by-value-update.html: Added.
        * platform/chromium/test_expectations.txt: Add textfield-overflow-by-value-update.html.
        * platform/mac/fast/forms/textfield-overflow-by-value-update-expected.png: Added.
        * platform/mac/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.
2011-07-04  Kent Tamura  <tkent@chromium.org>

        REGRESSION (r87067): Text overflows from short height text field.
        https://bugs.webkit.org/show_bug.cgi?id=61768

        Reviewed by Dimitri Glazkov.

        Since r87067, the RenderStyle for the inner text element is reset
        by the value update, but the renderer for the inner text element
        keeps to have metrics calculated by the previous style. So
        RenderTextControlSingleLine::layout() didn't set a desired height
        to the renderer for the inner text element.

        This patch changes the style creation code so that it has the
        desired height initially.

        Test: fast/forms/textfield-overflow-by-value-update.html

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
        Initialize m_desiredInnerTextHeight.
        (WebCore::RenderTextControlSingleLine::layout):
        Update m_desiredInnerTextHeight.
        (WebCore::RenderTextControlSingleLine::styleDidChange):
        Reset m_desiredInnerTextHeight.
        (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
        Sets the height if m_desiredInnerTextHeight has a concrete value.
        * rendering/RenderTextControlSingleLine.h:
        Declare m_desiredInnerTextHeight.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 5 Jul 2011 01:11:41 +0000 (01:11 +0000)]
2011-07-04  MORITA Hajime  <morrita@google.com>

        Accessing ShadowRoot.nodeList causes an assertion failure.
        http://webkit.org/b/63798

        Reviewed by Dimitri Glazkov.

        * fast/dom/shadow/shadow-root-node-list-expected.txt: Added.
        * fast/dom/shadow/shadow-root-node-list.html: Added.
2011-07-04  MORITA Hajime  <morrita@google.com>

        Accessing ShadowRoot.nodeList causes an assertion failure.
        http://webkit.org/b/63798

        The TreeScope destructor did clear the reference to TreeScope,
        then the Node destructor accessing treeScope(), which results
        an inconsistent state during the NodeList cache cleanup.

        This change clears NodeList cache during the TreeScope destructor.
        The Node destructor no longer does problematic NodeList cache
        manipulation.

        Test: fast/dom/shadow/shadow-root-node-list.html

        Reviewed by Dimitri Glazkov.

        * dom/Node.cpp:
        (WebCore::Node::~Node):
        (WebCore::Node::clearRareData):
        * dom/Node.h:
        * dom/TreeScope.cpp:
        (WebCore::TreeScope::~TreeScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Mon, 4 Jul 2011 20:29:05 +0000 (20:29 +0000)]
2011-07-04  Stephen White  <senorblanco@chromium.org>

        Unreviewed; chromium test expectations change.

        Mark four tests as passing on the GPU step.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>
vsevik@chromium.org [Mon, 4 Jul 2011 20:28:13 +0000 (20:28 +0000)]
2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>

        ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly
        https://bugs.webkit.org/show_bug.cgi?id=63873

        Reviewed by Alexey Proskuryakov.

        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 4 Jul 2011 20:26:37 +0000 (20:26 +0000)]
2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90373.
        http://trac.webkit.org/changeset/90373
        https://bugs.webkit.org/show_bug.cgi?id=63917

        Breaks Qt Linux Release minimal (Requested by vsevik on
        #webkit).

        * Source/autotools/symbols.filter:
2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90373.
        http://trac.webkit.org/changeset/90373
        https://bugs.webkit.org/show_bug.cgi?id=63917

        Breaks Qt Linux Release minimal (Requested by vsevik on
        #webkit).

        * http/tests/inspector/network/network-content-replacement-embed-expected.txt: Removed.
        * http/tests/inspector/network/network-content-replacement-embed.html: Removed.
        * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Removed.
        * http/tests/inspector/network/network-content-replacement-xhr.html: Removed.
        * http/tests/inspector/network/network-embed-expected.txt: Removed.
        * http/tests/inspector/network/network-embed.html: Removed.
        * http/tests/inspector/network/network-xhr-async-expected.txt:
        * http/tests/inspector/network/network-xhr-async.html:
        * http/tests/inspector/network/network-xhr-sync-expected.txt:
        * http/tests/inspector/network/network-xhr-sync.html:
        * http/tests/inspector/network/resources/cp1251.xml: Removed.
        * http/tests/inspector/network/resources/plugin-data.php: Removed.
        * http/tests/inspector/network/resources/resource.php:
        * http/tests/inspector/network/resources/utf8.xml: Removed.
        * platform/chromium/test_expectations.txt:
2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90373.
        http://trac.webkit.org/changeset/90373
        https://bugs.webkit.org/show_bug.cgi?id=63917

        Breaks Qt Linux Release minimal (Requested by vsevik on
        #webkit).

        * WebCore.exp.in:
        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::didReceiveContentLength):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::didReceiveResponse):
        (WebCore::InspectorResourceAgent::didReceiveContentLength):
        (WebCore::InspectorResourceAgent::didFinishLoading):
        (WebCore::InspectorResourceAgent::setInitialXHRContent):
        (WebCore::InspectorResourceAgent::getResourceContent):
        * inspector/InspectorResourceAgent.h:
        * inspector/NetworkResourcesData.cpp:
        (WebCore::NetworkResourcesData::ResourceData::ResourceData):
        (WebCore::NetworkResourcesData::ResourceData::content):
        (WebCore::NetworkResourcesData::ResourceData::appendContent):
        (WebCore::NetworkResourcesData::ResourceData::purgeContent):
        (WebCore::NetworkResourcesData::NetworkResourcesData):
        (WebCore::NetworkResourcesData::responseReceived):
        (WebCore::NetworkResourcesData::addResourceContent):
        (WebCore::NetworkResourcesData::data):
        (WebCore::NetworkResourcesData::clear):
        (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
        (WebCore::NetworkResourcesData::ensureFreeSpace):
        * inspector/NetworkResourcesData.h:
        (WebCore::NetworkResourcesData::ResourceData::hasContent):
        (WebCore::NetworkResourcesData::ResourceData::setIsContentPurged):
        (WebCore::NetworkResourcesData::ResourceData::textEncodingName):
        (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
        * inspector/front-end/Resource.js:
        * inspector/front-end/ResourcePreviewView.js:
        (WebInspector.ResourcePreviewView.prototype.contentLoaded):
        (WebInspector.ResourcePreviewView.prototype._createInnerView):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.hasTextContent):
        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::didReceiveData):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::willLoadMediaElementURL):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::didReceiveData):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
        (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
        * loader/ResourceLoadNotifier.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::didReceiveData):
        * testing/Internals.cpp:
        * testing/Internals.h:
        * testing/Internals.idl:
2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90373.
        http://trac.webkit.org/changeset/90373
        https://bugs.webkit.org/show_bug.cgi?id=63917

        Breaks Qt Linux Release minimal (Requested by vsevik on
        #webkit).

        * win/WebKit2.def:
        * win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix Qt build.
andersca@apple.com [Mon, 4 Jul 2011 20:17:02 +0000 (20:17 +0000)]
Try to fix Qt build.

* DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>
vsevik@chromium.org [Mon, 4 Jul 2011 20:07:20 +0000 (20:07 +0000)]
2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Show content for plugin requests in network panel.
        https://bugs.webkit.org/show_bug.cgi?id=30080

        Reviewed by Pavel Feldman.

        * Source/autotools/symbols.filter:
2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Show content for plugin requests in network panel.
        https://bugs.webkit.org/show_bug.cgi?id=30080

        Reviewed by Pavel Feldman.

        * http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
        * http/tests/inspector/network/network-content-replacement-embed.html: Added.
        * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
        * http/tests/inspector/network/network-content-replacement-xhr.html: Added.
        * http/tests/inspector/network/network-embed-expected.txt: Added.
        * http/tests/inspector/network/network-embed.html: Added.
        * http/tests/inspector/network/network-xhr-async-expected.txt:
        * http/tests/inspector/network/network-xhr-async.html:
        * http/tests/inspector/network/network-xhr-sync-expected.txt:
        * http/tests/inspector/network/network-xhr-sync.html:
        * http/tests/inspector/network/resources/cp1251.xml: Added.
        * http/tests/inspector/network/resources/plugin-data.php: Added.
        * http/tests/inspector/network/resources/resource.php:
        * http/tests/inspector/network/resources/utf8.xml: Added.
        * platform/chromium/test_expectations.txt:
2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Show content for plugin requests in network panel.
        https://bugs.webkit.org/show_bug.cgi?id=30080

        Reviewed by Pavel Feldman.

        Tests: http/tests/inspector/network/network-content-replacement-embed.html
               http/tests/inspector/network/network-content-replacement-xhr.html
               http/tests/inspector/network/network-embed.html

        * WebCore.exp.in:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didReceiveDataImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::didReceiveData):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::didReceiveResponse):
        (WebCore::InspectorResourceAgent::didReceiveData):
        (WebCore::InspectorResourceAgent::didFinishLoading):
        (WebCore::InspectorResourceAgent::setInitialXHRContent):
        (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals):
        (WebCore::InspectorResourceAgent::getResourceContent):
        * inspector/InspectorResourceAgent.h:
        * inspector/NetworkResourcesData.cpp:
        (WebCore::NetworkResourcesData::ResourceData::ResourceData):
        (WebCore::NetworkResourcesData::ResourceData::setContent):
        (WebCore::NetworkResourcesData::ResourceData::purgeContent):
        (WebCore::NetworkResourcesData::ResourceData::createDecoder):
        (WebCore::NetworkResourcesData::ResourceData::dataLength):
        (WebCore::NetworkResourcesData::ResourceData::appendData):
        (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
        (WebCore::NetworkResourcesData::NetworkResourcesData):
        (WebCore::NetworkResourcesData::responseReceived):
        (WebCore::NetworkResourcesData::setResourceContent):
        (WebCore::NetworkResourcesData::maybeAddResourceData):
        (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
        (WebCore::NetworkResourcesData::data):
        (WebCore::NetworkResourcesData::clear):
        (WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
        (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
        (WebCore::NetworkResourcesData::ensureFreeSpace):
        * inspector/NetworkResourcesData.h:
        (WebCore::NetworkResourcesData::ResourceData::hasContent):
        (WebCore::NetworkResourcesData::ResourceData::content):
        (WebCore::NetworkResourcesData::ResourceData::decoder):
        (WebCore::NetworkResourcesData::ResourceData::buffer):
        (WebCore::NetworkResourcesData::ResourceData::setBuffer):
        (WebCore::NetworkResourcesData::ResourceData::hasData):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.get contentEncoded):
        * inspector/front-end/ResourcePreviewView.js:
        (WebInspector.ResourcePreviewView.prototype.contentLoaded):
        (WebInspector.ResourcePreviewView.prototype._createEmptyView):
        (WebInspector.ResourcePreviewView.prototype._createPreviewView):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.hasTextContent):
        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::didReceiveData):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::willLoadMediaElementURL):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::didReceiveData):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
        (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
        * loader/ResourceLoadNotifier.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::didReceiveData):
        * testing/Internals.cpp:
        (WebCore::Internals::setInspectorResourcesDataSizeLimits):
        * testing/Internals.h:
        * testing/Internals.idl:
2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Show content for plugin requests in network panel.
        https://bugs.webkit.org/show_bug.cgi?id=30080

        Reviewed by Pavel Feldman.

        * win/WebKit2.def:
        * win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 4 Jul 2011 19:58:56 +0000 (19:58 +0000)]
2011-07-04  Anders Carlsson  <andersca@apple.com>

        NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
        https://bugs.webkit.org/show_bug.cgi?id=63915
        <rdar://problem/7124300>

        Reviewed by Sam Weinig.

        * WebProcess/Plugins/Netscape/JSNPObject.cpp:
        (WebKit::JSNPObject::deleteProperty):
        Call NP_RemoveProperty on the NPObject.

        * WebProcess/Plugins/Netscape/JSNPObject.h:
        Add deleteProperty.
2011-07-04  Anders Carlsson  <andersca@apple.com>

        NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
        https://bugs.webkit.org/show_bug.cgi?id=63915
        <rdar://problem/7124300>

        Reviewed by Sam Weinig.

        Add a test. I made this Mac-WebKit2 specific for now since no other plug-in implementations support this,
        and there doesn't seem to be a way to make a WebKit2 specific test.

        * platform/mac-wk2/plugins/npruntime/remove-property-from-javascript-expected.txt: Added.
        * platform/mac-wk2/plugins/npruntime/remove-property-from-javascript.html: Added.
2011-07-04  Anders Carlsson  <andersca@apple.com>

        NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
        https://bugs.webkit.org/show_bug.cgi?id=63915
        <rdar://problem/7124300>

        Reviewed by Sam Weinig.

        Extend the NPRuntimeRemoveProperty to handle delete object.property from JavaScript.

        * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
        (PluginTest::NPN_IdentifierIsString):
        (PluginTest::NPN_UTF8FromIdentifier):
        (PluginTest::NPN_IntFromIdentifier):
        (PluginTest::NPN_RetainObject):
        (PluginTest::NPN_ReleaseObject):
        * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
        (PluginTest::Object::removeProperty):
        (PluginTest::Object::identifierIs):
        (PluginTest::Object::NP_RemoveProperty):
        (PluginTest::Object::npClass):
        * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
        (NPRuntimeRemoveProperty::TestObject::TestObject):
        (NPRuntimeRemoveProperty::TestObject::hasProperty):
        (NPRuntimeRemoveProperty::TestObject::getProperty):
        (NPRuntimeRemoveProperty::TestObject::removeProperty):
        (NPRuntimeRemoveProperty::PluginObject::PluginObject):
        (NPRuntimeRemoveProperty::PluginObject::~PluginObject):
        (NPRuntimeRemoveProperty::PluginObject::hasMethod):
        (NPRuntimeRemoveProperty::PluginObject::invoke):
        (NPRuntimeRemoveProperty::PluginObject::hasProperty):
        (NPRuntimeRemoveProperty::PluginObject::getProperty):
        (NPRuntimeRemoveProperty::NPP_GetValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=63881
barraclough@apple.com [Mon, 4 Jul 2011 19:26:05 +0000 (19:26 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63881
Need separate bytecodes for handling >, >= comparisons.

Reviewed by Oliver Hunt.

This clears the way to fix Bug#63880. We currently handle greater-than comparisons
as being using the corresponding op_less, etc opcodes.  This is incorrect with
respect to evaluation ordering of the implicit conversions performed on operands -
we should be calling ToPrimitive on the LHS and RHS operands to the greater than,
but instead convert RHS then LHS.

This patch adds opcodes for greater-than comparisons mirroring existing ones used
for less-than.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
* bytecompiler/NodesCodegen.cpp:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compare):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
(JSC::JIT::emit_op_loop_if_greater):
(JSC::JIT::emitSlow_op_loop_if_greater):
(JSC::JIT::emit_op_loop_if_greatereq):
(JSC::JIT::emitSlow_op_loop_if_greatereq):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jgreater):
(JSC::JIT::emit_op_jgreatereq):
(JSC::JIT::emit_op_jngreater):
(JSC::JIT::emit_op_jngreatereq):
(JSC::JIT::emitSlow_op_jgreater):
(JSC::JIT::emitSlow_op_jgreatereq):
(JSC::JIT::emitSlow_op_jngreater):
(JSC::JIT::emitSlow_op_jngreatereq):
(JSC::JIT::emit_compareAndJumpSlow):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitBinaryDoubleOp):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* parser/NodeConstructors.h:
(JSC::GreaterNode::GreaterNode):
(JSC::GreaterEqNode::GreaterEqNode):
* parser/Nodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Mon, 4 Jul 2011 18:25:19 +0000 (18:25 +0000)]
2011-07-04  Stephen White  <senorblanco@chromium.org>

        Unreviewed; chromium test expectations change.

        Mark two tests as failing on the GPU step.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Jeff Timanus <twiz@chromium.org>
commit-queue@webkit.org [Mon, 4 Jul 2011 18:16:34 +0000 (18:16 +0000)]
2011-07-04  Jeff Timanus  <twiz@chromium.org>

        Reviewed by Stephen White.

        Prevent calls to GrapicsContext3D::deleteTexture with id 0 in DrawingBuffer::clear().
        https://bugs.webkit.org/show_bug.cgi?id=63756

        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Martin Robinson <mrobinson@igalia.com>
commit-queue@webkit.org [Mon, 4 Jul 2011 18:03:56 +0000 (18:03 +0000)]
2011-07-04  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Andreas Kling.

        [GTK] r90148 did not apply to X11 platforms in WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=63862

        Correct the guard for an X11 specific piece of code. TARGET(X11) not
        defined for the GTK+ port.

        No new tests. This is covered by an existing test.

        * plugins/npapi.cpp: Correct the X11 guard.
        (NPN_InvalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>
vsevik@chromium.org [Mon, 4 Jul 2011 15:53:03 +0000 (15:53 +0000)]
2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: network-preflight-options.html test is flaky.
        https://bugs.webkit.org/show_bug.cgi?id=63904

        Unreviewed test fix.

        * http/tests/inspector/network-preflight-options-expected.txt:
        * http/tests/inspector/network-preflight-options.html:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Mon, 4 Jul 2011 15:31:58 +0000 (15:31 +0000)]
2011-07-04  Andras Becsi  <abecsi@webkit.org>

        [Qt] http/tests/inspector/network-preflight-options.html fails frequently
        https://bugs.webkit.org/show_bug.cgi?id=63910

        Unreviewed.

        * platform/qt/Skipped: Skip http/tests/inspector/network-preflight-options.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 4 Jul 2011 14:48:47 +0000 (14:48 +0000)]
2011-07-04  Pavel Feldman  <pfeldman@google.com>

        Web Inspector: implement settings panel.
        https://bugs.webkit.org/show_bug.cgi?id=63907

        Reviewed by Yury Semikhatsky.

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView):
        (WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction):
        (WebInspector.ConsoleView.prototype._handleContextMenuEvent.get preserveLogItemAction):
        (WebInspector.ConsoleView.prototype._monitoringXHREnabledSettingChanged):
        (WebInspector.ConsoleView.prototype._registerShortcuts):
        * inspector/front-end/DOMBreakpointsSidebarPane.js:
        (WebInspector.DOMBreakpointsSidebarPane.prototype._saveBreakpoints):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
        (WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
        (WebInspector.ElementsPanel.prototype._registerShortcuts):
        * inspector/front-end/EventListenersSidebarPane.js:
        (WebInspector.EventListenersSidebarPane.prototype):
        ():
        * inspector/front-end/HelpScreen.js:
        (WebInspector.HelpScreen):
        (WebInspector.HelpScreen.prototype.show):
        (WebInspector.HelpScreen.prototype.hide):
        (WebInspector.HelpScreen.prototype._onKeyDown):
        * inspector/front-end/NetworkItemView.js:
        * inspector/front-end/NetworkPanel.js:
        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.saveSidebarWidth):
        * inspector/front-end/ProfilesPanel.js:
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.BaseStorageTreeElement.prototype.onselect):
        (WebInspector.StorageCategoryTreeElement.prototype.onexpand):
        (WebInspector.StorageCategoryTreeElement.prototype.set oncollapse):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._sourceFileAdded.get if):
        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
        (WebInspector.ScriptsPanel.prototype._createSidebarButtonAndRegisterShortcuts):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        (WebInspector.Settings.prototype.installApplicationSetting):
        (WebInspector.Setting):
        (WebInspector.Setting.prototype.addChangeListener):
        (WebInspector.Setting.prototype.removeChangeListener):
        (WebInspector.Setting.prototype.get var):
        (WebInspector.Setting.prototype):
        (WebInspector.Setting.prototype.set if):
        * inspector/front-end/SettingsScreen.js: Added.
        (WebInspector.SettingsScreen):
        (WebInspector.SettingsScreen.prototype._appendSection):
        (WebInspector.SettingsScreen.prototype._columnElement):
        (WebInspector.SettingsScreen.prototype._createCheckboxSetting.get listener):
        (WebInspector.SettingsScreen.prototype._createRadioSetting):
        * inspector/front-end/ShortcutsScreen.js: Renamed from Source/WebCore/inspector/front-end/ShortcutsHelp.js.
        (WebInspector.ShortcutsScreen):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/helpScreen.css:
        (.help-window-main):
        (body.attached .help-window-main):
        (.help-window-caption):
        (body.attached .help-window-caption):
        (.help-content):
        (.help-close-button):
        (body.attached .help-close-button):
        (body.attached .help-content):
        (.help-table):
        (body.platform-mac .help-key):
        (.help-combine-keys):
        (.help-content p):
        (.help-content fieldset):
        (.help-content fieldset p):
        (.help-content p.help-section):
        (.help-section-title):
        (.help-content input[type=checkbox]):
        * inspector/front-end/inspector.css:
        (button.settings-status-bar-item):
        (.settings-status-bar-item .glyph):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector._createGlobalStatusBarItems):
        (WebInspector._toggleAttach):
        (WebInspector._toggleSettings):
        (WebInspector._registerShortcuts):
        (WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>
vsevik@chromium.org [Mon, 4 Jul 2011 14:09:36 +0000 (14:09 +0000)]
2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Resources loaded to Resources Panel from InspectorPageAgent do not have mime type set.
        https://bugs.webkit.org/show_bug.cgi?id=63701

        Added a test that checks mime type when resources are loaded from cache by InspectorPageAgent.

        Reviewed by Yury Semikhatsky.

        * http/tests/inspector/resource-tree/resource-tree-mimetype-expected.txt: Added.
        * http/tests/inspector/resource-tree/resource-tree-mimetype.html: Added.
        * http/tests/inspector/resource-tree/resources/empty.png: Added.
2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Resources loaded to Resources Panel from InspectorPageAgent do not have mime type set.
        https://bugs.webkit.org/show_bug.cgi?id=63701

        Pass cachedResource/documentLoader mimeType from InspectorPageAgent to frontend.

        Reviewed by Yury Semikhatsky.

        Test: http/tests/inspector/resource-tree/resource-tree-mimetype.html

        * inspector/Inspector.json:
        * inspector/InspectorPageAgent.cpp:
        (WebCore::InspectorPageAgent::buildObjectForFrame):
        (WebCore::InspectorPageAgent::buildObjectForFrameTree):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
        (WebInspector.ResourceTreeModel.prototype._createResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 4 Jul 2011 13:29:50 +0000 (13:29 +0000)]
2011-07-04  Marcus Bulach  <bulach@chromium.org>

        [chromium] Updates expectations for failures on svg/animations/svgtransform-animation-1.html
        https://bugs.webkit.org/show_bug.cgi?id=63902

        Unreviewed expectations fix.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 4 Jul 2011 12:50:14 +0000 (12:50 +0000)]
2011-07-04  Yury Semikhatsky  <yurys@chromium.org>

        Web Inspector: repeated message counter should be aligned with other message icons
        https://bugs.webkit.org/show_bug.cgi?id=63901

        Reviewed by Pavel Feldman.

        * inspector/front-end/inspector.css:
        (.console-message .bubble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Leandro Pereira <leandro@profusion.mobi>
commit-queue@webkit.org [Mon, 4 Jul 2011 12:18:34 +0000 (12:18 +0000)]
2011-07-04  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Kent Tamura.

        [EFL] Add LayoutTestControllerEfl.
        https://bugs.webkit.org/show_bug.cgi?id=61974

        Only the core features are implemented. Most functions are actually
        stubs and will be implemented as soon as its features are needed.
        Build system changes will be made as soon as DRT is completely
        upstreamed.

        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Added.
        (LayoutTestController::~LayoutTestController):
        (LayoutTestController::addDisallowedURL):
        (LayoutTestController::clearBackForwardList):
        (LayoutTestController::copyDecodedHostName):
        (LayoutTestController::copyEncodedHostName):
        (LayoutTestController::dispatchPendingLoadRequests):
        (LayoutTestController::display):
        (LayoutTestController::counterValueForElementById):
        (LayoutTestController::keepWebHistory):
        (LayoutTestController::computedStyleIncludingVisitedInfo):
        (LayoutTestController::nodesFromRect):
        (LayoutTestController::layerTreeAsText):
        (LayoutTestController::pageNumberForElementById):
        (LayoutTestController::numberOfPages):
        (LayoutTestController::pageProperty):
        (LayoutTestController::isPageBoxVisible):
        (LayoutTestController::pageSizeAndMarginsInPixels):
        (LayoutTestController::webHistoryItemCount):
        (LayoutTestController::workerThreadCount):
        (LayoutTestController::notifyDone):
        (LayoutTestController::pathToLocalResource):
        (LayoutTestController::queueLoad):
        (LayoutTestController::setAcceptsEditing):
        (LayoutTestController::setAlwaysAcceptCookies):
        (LayoutTestController::setCustomPolicyDelegate):
        (LayoutTestController::waitForPolicyDelegate):
        (LayoutTestController::setScrollbarPolicy):
        (LayoutTestController::addOriginAccessWhitelistEntry):
        (LayoutTestController::removeOriginAccessWhitelistEntry):
        (LayoutTestController::setMainFrameIsFirstResponder):
        (LayoutTestController::setTabKeyCyclesThroughElements):
        (LayoutTestController::setUseDashboardCompatibilityMode):
        (LayoutTestController::setUserStyleSheetEnabled):
        (LayoutTestController::setUserStyleSheetLocation):
        (LayoutTestController::setValueForUser):
        (LayoutTestController::setViewModeMediaFeature):
        (LayoutTestController::setWindowIsKey):
        (LayoutTestController::setSmartInsertDeleteEnabled):
        (waitToDumpWatchdogFired):
        (LayoutTestController::setWaitToDump):
        (LayoutTestController::windowCount):
        (LayoutTestController::setPrivateBrowsingEnabled):
        (LayoutTestController::setJavaScriptCanAccessClipboard):
        (LayoutTestController::setXSSAuditorEnabled):
        (LayoutTestController::setFrameFlatteningEnabled):
        (LayoutTestController::setSpatialNavigationEnabled):
        (LayoutTestController::setAllowUniversalAccessFromFileURLs):
        (LayoutTestController::setAllowFileAccessFromFileURLs):
        (LayoutTestController::setAuthorAndUserStylesEnabled):
        (LayoutTestController::setAutofilled):
        (LayoutTestController::disableImageLoading):
        (LayoutTestController::setMockDeviceOrientation):
        (LayoutTestController::setMockGeolocationPosition):
        (LayoutTestController::setMockGeolocationError):
        (LayoutTestController::setGeolocationPermission):
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        (LayoutTestController::addMockSpeechInputResult):
        (LayoutTestController::setIconDatabaseEnabled):
        (LayoutTestController::setJavaScriptProfilingEnabled):
        (LayoutTestController::setSelectTrailingWhitespaceEnabled):
        (LayoutTestController::setPopupBlockingEnabled):
        (LayoutTestController::setPluginsEnabled):
        (LayoutTestController::elementDoesAutoCompleteForElementWithId):
        (LayoutTestController::execCommand):
        (LayoutTestController::findString):
        (LayoutTestController::isCommandEnabled):
        (LayoutTestController::setCacheModel):
        (LayoutTestController::setPersistentUserStyleSheetLocation):
        (LayoutTestController::clearPersistentUserStyleSheet):
        (LayoutTestController::clearAllApplicationCaches):
        (LayoutTestController::setApplicationCacheOriginQuota):
        (LayoutTestController::clearApplicationCacheForOrigin):
        (LayoutTestController::localStorageDiskUsageForOrigin):
        (LayoutTestController::originsWithApplicationCache):
        (LayoutTestController::applicationCacheDiskUsageForOrigin):
        (LayoutTestController::clearAllDatabases):
        (LayoutTestController::setDatabaseQuota):
        (LayoutTestController::originsWithLocalStorage):
        (LayoutTestController::deleteAllLocalStorage):
        (LayoutTestController::deleteLocalStorageForOrigin):
        (LayoutTestController::observeStorageTrackerNotifications):
        (LayoutTestController::syncLocalStorage):
        (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
        (LayoutTestController::goBack):
        (LayoutTestController::setDefersLoading):
        (LayoutTestController::setAppCacheMaximumSize):
        (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
        (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
        (LayoutTestController::sampleSVGAnimationForElementAtTime):
        (LayoutTestController::numberOfActiveAnimations):
        (LayoutTestController::suspendAnimations):
        (LayoutTestController::resumeAnimations):
        (LayoutTestController::overridePreference):
        (LayoutTestController::addUserScript):
        (LayoutTestController::addUserStyleSheet):
        (LayoutTestController::setDeveloperExtrasEnabled):
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):
        (LayoutTestController::evaluateInWebInspector):
        (LayoutTestController::evaluateScriptInIsolatedWorld):
        (LayoutTestController::removeAllVisitedLinks):
        (LayoutTestController::callShouldCloseOnWebView):
        (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
        (LayoutTestController::apiTestGoToCurrentBackForwardItem):
        (LayoutTestController::setWebViewEditable):
        (LayoutTestController::markerTextForListItem):
        (LayoutTestController::authenticateSession):
        (LayoutTestController::setEditingBehavior):
        (LayoutTestController::abortModal):
        (LayoutTestController::hasSpellingMarker):
        (LayoutTestController::hasGrammarMarker):
        (LayoutTestController::dumpConfigurationForViewport):
        (LayoutTestController::setSerializeHTTPLoads):
        (LayoutTestController::setMinimumTimerInterval):
        (LayoutTestController::setTextDirection):
        (LayoutTestController::allowRoundingHacks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 4 Jul 2011 11:55:59 +0000 (11:55 +0000)]
2011-07-04  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Adding new CSS rules should be more discoverable in the UI
        https://bugs.webkit.org/show_bug.cgi?id=63803

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._createNewRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk>
commit-queue@webkit.org [Mon, 4 Jul 2011 10:56:47 +0000 (10:56 +0000)]
2011-07-04  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>

        [Qt] Fixing build with --media-stream flag enabled
        https://bugs.webkit.org/show_bug.cgi?id=63831

        Reviewed by Benjamin Poulain.

        * features.pri: Adding support to ENABLE_MEDIA_STREAM flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>
vsevik@chromium.org [Mon, 4 Jul 2011 10:07:50 +0000 (10:07 +0000)]
2011-06-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Unreviewed, add myself as committer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 4 Jul 2011 09:51:24 +0000 (09:51 +0000)]
2011-07-04  Marcus Bulach  <bulach@chromium.org>

        [chromium] Rebaseline following r90338
        https://bugs.webkit.org/show_bug.cgi?id=63896

        Unreviewed rebaseline.

        * platform/chromium-linux/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
        * platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
        * platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
        * platform/chromium-win-vista/plugins/mouse-click-plugin-clears-selection-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Vsevolod Vlasov <vsevik@chromium.org>
vsevik@chromium.org [Mon, 4 Jul 2011 09:36:03 +0000 (09:36 +0000)]
2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Update network resource url from response data.
        https://bugs.webkit.org/show_bug.cgi?id=63736

        * inspector/Inspector.json:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForResourceResponse):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Mon, 4 Jul 2011 09:20:15 +0000 (09:20 +0000)]
2011-07-04  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Extensions API] audit formatter names should begin with create
        https://bugs.webkit.org/show_bug.cgi?id=63802

        * inspector/extensions/extensions-audits-api-expected.txt:
        * inspector/extensions/extensions-audits.html:
2011-07-04  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Extensions API] audit formatter names should begin with create
        https://bugs.webkit.org/show_bug.cgi?id=63802

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.AuditResultImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-04 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Mon, 4 Jul 2011 09:18:37 +0000 (09:18 +0000)]
2011-07-04  Yuta Kitamura  <yutak@chromium.org>

        WebSocket: Use jsTestIsAsync and finishJSTest() wherever possible in WebSocket tests
        https://bugs.webkit.org/show_bug.cgi?id=63892

        Reviewed by Kent Tamura.

        Use jsTestIsAsync and finishJSTest() in WebSocket tests which are run asynchronously.
        Script tags loading js-test-post-function.js must be removed, and instead js-test-post.js
        must be loaded after each test.

        * http/tests/websocket/tests/alert-in-event-handler.html:
        * http/tests/websocket/tests/bad-handshake-crash.html:
        * http/tests/websocket/tests/bad-sub-protocol-control-chars.html:
        This test is done synchronously, thus there is no need to use jsTestIsAsync and
        finishJSTest(). As we are moving away from js-test-post-function.js,
        isSuccessfullyParsed() should not be used anymore.
        * http/tests/websocket/tests/bad-sub-protocol-empty.html:
        * http/tests/websocket/tests/bad-sub-protocol-non-ascii.html:
        * http/tests/websocket/tests/bufferedAmount-after-close.html:
        * http/tests/websocket/tests/close-before-open.html:
        * http/tests/websocket/tests/close-on-navigate-new-location.html:
        * http/tests/websocket/tests/close-on-unload-and-force-gc.html:
        * http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
        * http/tests/websocket/tests/close-on-unload.html:
        * http/tests/websocket/tests/close-unref-websocket.html:
        * http/tests/websocket/tests/cross-origin.html:
        * http/tests/websocket/tests/error-detect.html:
        * http/tests/websocket/tests/frame-length-longer-than-buffer.html:
        * http/tests/websocket/tests/frame-length-overflow.html:
        Add close tags for <body> and <html> elements which were not present for some reason.
        * http/tests/websocket/tests/frame-length-skip.html:
        * http/tests/websocket/tests/handshake-challenge-randomness.html:
        * http/tests/websocket/tests/handshake-error.html:
        * http/tests/websocket/tests/handshake-fail-by-cross-origin.html:
        * http/tests/websocket/tests/handshake-fail-by-maxlength.html:
        * http/tests/websocket/tests/handshake-fail-by-no-connection-header.html:
        * http/tests/websocket/tests/handshake-fail-by-no-cr.html:
        * http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html:
        * http/tests/websocket/tests/handshake-fail-by-prepended-null.html:
        * http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html:
        * http/tests/websocket/tests/long-invalid-header.html:
        * http/tests/websocket/tests/null-character.html:
        * http/tests/websocket/tests/reload-crash.html:
        * http/tests/websocket/tests/send-after-close-on-unload.html:
        * http/tests/websocket/tests/send-throw.html:
        * http/tests/websocket/tests/send.html:
        * http/tests/websocket/tests/simple.html:
        * http/tests/websocket/tests/sub-protocol-with-space.html:
        * http/tests/websocket/tests/sub-protocol.html:
        * http/tests/websocket/tests/unicode.html:
        * http/tests/websocket/tests/url-no-trailing-slash.html:
        * http/tests/websocket/tests/url-parsing.html:
        * http/tests/websocket/tests/url-with-credential.html:
        * http/tests/websocket/tests/url-with-empty-query.html:
        * http/tests/websocket/tests/url-with-query-for-no-query.html:
        * http/tests/websocket/tests/url-with-query.html:
        * http/tests/websocket/tests/websocket-event-target.html:
        * http/tests/websocket/tests/websocket-protocol-ignored.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Mon, 4 Jul 2011 07:49:38 +0000 (07:49 +0000)]
2011-07-03  Balazs Kelemen  <kbalazs@webkit.org>

        [Qt][WK2] Remove passing tests from the qt-wk2 list
        https://bugs.webkit.org/show_bug.cgi?id=63877

        Reviewed by Kenneth Rohde Christiansen.

        * platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=63879
barraclough@apple.com [Mon, 4 Jul 2011 05:59:03 +0000 (05:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63879
Reduce code duplication for op_jless, op_jlesseq, op_jnless, op_jnlesseq.

Reviewed by Sam Weinig.

There is a lot of copy & paste code here; we can reduce duplication by making
a shared implementation.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::commute):
    - Make these function platform agnostic.
* assembler/MacroAssemblerX86Common.h:
    - Moved branch32/commute up to MacroAssembler.
* jit/JIT.h:
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):
    - Add an implementation matching that for op_loop_if_less, which just calls op_jless.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jless):
(JSC::JIT::emit_op_jlesseq):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jlesseq):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):
    - Common implmentations of these methods for JSVALUE64 & JSVALUE32_64.
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):
    - Internal implmementation of jless etc for JSVALUE64.
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):
    - Internal implmementation of jless etc for JSVALUE32_64.
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* jit/JITStubs.cpp:
* jit/JITStubs.h:
    - Remove old implementation of emit_op_loop_if_lesseq.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Mon, 4 Jul 2011 05:56:53 +0000 (05:56 +0000)]
2011-07-03  Dominic Cooney  <dominicc@chromium.org>

        The value property of an indeterminate progress element should be zero
        https://bugs.webkit.org/show_bug.cgi?id=63861

        Reviewed by Kent Tamura.

        Updates test result, and adds a test for setting value < 0.

        * fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js:
        * fast/dom/HTMLProgressElement/set-progress-properties-expected.txt:
2011-07-03  Dominic Cooney  <dominicc@chromium.org>

        The value property of an indeterminate progress element should be zero
        https://bugs.webkit.org/show_bug.cgi?id=63861

        Reviewed by Kent Tamura.

        Test: fast/dom/HTMLProgressElement/set-progress-properties.html

        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Mon, 4 Jul 2011 05:20:03 +0000 (05:20 +0000)]
2011-07-03  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: pywebsocket handlers should raise exception to abort the connection
        https://bugs.webkit.org/show_bug.cgi?id=63794

        pywebsocket automatically sends handshake response when web_socket_do_extra_handshake()
        finishes, and starts closing handshake (sends a close frame and waits for client's response)
        after web_socket_transfer_data() exits. To stop this behavior, a handler must raise an
        exception.

        Some of our handlers send broken handshake in web_socket_do_extra_handshake(). If this handler
        function exits without raising an exception, pywebsocket automatically sends another handshake
        response, which is not really necessary. Normally this extra handshake message is not a problem,
        because the client does not read any data beyond the end of the first (broken) handshake if
        the client is working correctly. However, if the client erroneously accepts the first handshake,
        it will be hard to diagnose the problem because of the extra message. The same can happen for
        web_socket_transfer_data().

        Generally, pywebsocket handlers should raise an exception if they do not want to send any more
        data. However, this fact has been overlooked in past changes, and handlers in many tests exit
        normally where they should raise an exception. This change fix these errors.

        * http/tests/websocket/tests/bad-handshake-crash_wsh.py:
        * http/tests/websocket/tests/frame-length-overflow_wsh.py:
        * http/tests/websocket/tests/handshake-fail-by-maxlength_wsh.py:
        Do not need to cycle until disconnection.
        * http/tests/websocket/tests/handshake-fail-by-no-connection-header_wsh.py:
        * http/tests/websocket/tests/handshake-fail-by-no-cr_wsh.py:
        * http/tests/websocket/tests/handshake-fail-by-no-upgrade-header_wsh.py:
        * http/tests/websocket/tests/long-invalid-header_wsh.py:
        Some ports (Chromium) intercept handshake messages and do not pass server's response
        to WebCore until they find the end of handshake response (i.e. "\r\n\r\n" and 16-byte data).
        If the handler aborts the connection without sending this end-of-response marker, entire
        response is ignored, which causes the test to fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>
tkent@chromium.org [Mon, 4 Jul 2011 03:54:36 +0000 (03:54 +0000)]
2011-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90347.
        http://trac.webkit.org/changeset/90347
        https://bugs.webkit.org/show_bug.cgi?id=63886

        Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
        (Requested by tkent on #webkit).

        * fast/js/number-toString-expected.txt:
2011-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90347.
        http://trac.webkit.org/changeset/90347
        https://bugs.webkit.org/show_bug.cgi?id=63886

        Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
        (Requested by tkent on #webkit).

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/BigInteger.h: Removed.
        * runtime/NumberPrototype.cpp:
        (JSC::numberProtoFuncToPrecision):
        (JSC::numberProtoFuncToString):
        * runtime/Uint16WithFraction.h: Removed.
        * wtf/MathExtras.h:
2011-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90347.
        http://trac.webkit.org/changeset/90347
        https://bugs.webkit.org/show_bug.cgi?id=63886

        Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
        (Requested by tkent on #webkit).

        * DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 4 Jul 2011 02:01:19 +0000 (02:01 +0000)]
2011-07-03  Daniel Bates  <dbates@webkit.org>

        Import Checkout in scm_unittests.py and logging in svn.py to fix
        Python missing global variable errors

        Rubber-stamped by Adam Barth.

        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Import Checkout.
        * Scripts/webkitpy/common/checkout/scm/svn.py: Import logging.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Sam Weinig.
barraclough@apple.com [Sun, 3 Jul 2011 22:27:12 +0000 (22:27 +0000)]
Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=16652
Firefox and JavaScriptCore differ in Number.toString(integer)

Source/JavaScriptCore:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

* runtime/NumberPrototype.cpp:
(JSC::decomposeDouble):
    - helper function to extract sign, exponent, mantissa from IEEE doubles.
(JSC::Uint16WithFraction::Uint16WithFraction):
    - helper class, u16int with infinite precision fraction, used to convert
      the fractional part of the number to a string.
(JSC::Uint16WithFraction::operator*=):
    - Multiply by a uint16.
(JSC::Uint16WithFraction::operator<):
    - Compare two Uint16WithFractions.
(JSC::Uint16WithFraction::floorAndSubtract):
    - Extract the integer portion of the number, and subtract it (clears the integer portion).
(JSC::Uint16WithFraction::comparePoint5):
    - Compare to 0.5.
(JSC::Uint16WithFraction::sumGreaterThanOne):
    - Passed a second Uint16WithFraction, returns true if the result of adding
      the two values would be greater than one.
(JSC::Uint16WithFraction::isNormalized):
    - Used by ASSERTs to consistency check internal representation.
(JSC::BigInteger::BigInteger):
    - helper class, unbounded integer value, used to convert the integer part
      of the number to a string.
(JSC::BigInteger::divide):
    - Divide this value through by a uint32.
(JSC::BigInteger::operator!):
    - test for zero.
(JSC::toStringWithRadix):
    - Performs number to string conversion, with the given radix (2..36).
(JSC::numberProtoFuncToString):
    - Changed to use toStringWithRadix.

Tools:

Added forwarding header.

* DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.

LayoutTests:

Our arbitrary radix (2..36) toString conversion is inaccurate.
This is partly because it uses doubles to perform math that requires
higher accuracy, and partly becasue it does not attempt to correctly
detect where to terminate, instead relying on a simple 'epsilon'.

* fast/js/number-toString-expected.txt:
    - Update expected results from FAIL to PASS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 3 Jul 2011 20:34:14 +0000 (20:34 +0000)]
2011-07-03  Robert Hogan  <robert@webkit.org>

        Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
        https://bugs.webkit.org/show_bug.cgi?id=62482

        If a <meta http-equiv="refresh"> directive schedules a page reload rather than
        a redirect restore the scroll position after the reload. Do the same on location.reload().

        Reviewed by Adam Barth.

        * http/tests/navigation/scrollstate-after-http-equiv-refresh-expected.txt: Added.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2-expected.txt: Added.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html: Added.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-expected.txt: Added.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html: Added.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh.html: Added.
        * http/tests/navigation/scrollstate-after-location-reload-expected.txt: Added.
        * http/tests/navigation/scrollstate-after-location-reload.html: Added.
2011-07-03  Robert Hogan  <robert@webkit.org>

        Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
        https://bugs.webkit.org/show_bug.cgi?id=62482

        If a <meta http-equiv="refresh"> directive schedules a page reload rather than
        a redirect restore the scroll position after the reload. Do the same on location.reload().

        Reviewed by Adam Barth.

        Tests: http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html
               http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
               http/tests/navigation/scrollstate-after-http-equiv-refresh.html
               http/tests/navigation/scrollstate-after-location-reload.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadURL):
        Only make the load FrameLoadTypeSame if it has not already been set as FrameLoadTypeReload*.
        FrameLoadTypeReload* loads are set through http-equiv refreshes, manual reloads, or location.reload()
        and honour the user's scroll position in the frame. A FrameLoadTypeSame is for when the frame is loading
        the same page again, e.g. by clicking a link.

        * loader/NavigationScheduler.cpp:
        (WebCore::ScheduledRedirect::fire): Tell FrameLoader::changeLocation() if this is a reload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 3 Jul 2011 20:22:22 +0000 (20:22 +0000)]
2011-07-03  Dirk Schulze  <krit@webkit.org>

        SVGAnimateTransform accumulate=sum restarts on every repeat
        https://bugs.webkit.org/show_bug.cgi?id=63876

        Reviewed by Nikolas Zimmermann.

        Test accumulate=sum on SVGAnimateTransform. The animation shouldn't start with initial value
        on every repeat for accumulation.

        * svg/animations/script-tests/svgtransform-animation-1.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/svgtransform-animation-1-expected.txt: Added.
        * svg/animations/svgtransform-animation-1.html: Added.
2011-07-03  Dirk Schulze  <krit@webkit.org>

        SVGAnimateTransform accumulate=sum restarts on every repeat
        https://bugs.webkit.org/show_bug.cgi?id=63876

        Reviewed by Nikolas Zimmermann.

        We applied transforms from previous animation repeats to a transform list. The problem is, that we calculated the current
        transform based on the percentage of the current repeat count. This causes an animation starting from scale level 0
        on every repeat. Now I add the repeat count to the current percentage, so that the distance calculation starts from 100% on
        the first repeat, from 200% on the second and so on.

        Test: svg/animations/svgtransform-animation-1.html

        * svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sun, 3 Jul 2011 18:29:08 +0000 (18:29 +0000)]
2011-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90342.
        http://trac.webkit.org/changeset/90342
        https://bugs.webkit.org/show_bug.cgi?id=63875

        Newly added tests fail on Mac, GTK, and Win7 (Requested by
        abarth on #webkit).

        * http/tests/navigation/scrollstate-after-http-equiv-refresh-expected.txt: Removed.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2-expected.txt: Removed.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html: Removed.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-expected.txt: Removed.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html: Removed.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh.html: Removed.
        * http/tests/navigation/scrollstate-after-location-reload-expected.txt: Removed.
        * http/tests/navigation/scrollstate-after-location-reload.html: Removed.
2011-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r90342.
        http://trac.webkit.org/changeset/90342
        https://bugs.webkit.org/show_bug.cgi?id=63875

        Newly added tests fail on Mac, GTK, and Win7 (Requested by
        abarth on #webkit).

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadURL):
        * loader/NavigationScheduler.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 3 Jul 2011 17:42:01 +0000 (17:42 +0000)]
2011-07-03  Robert Hogan  <robert@webkit.org>

        Skip Qt platform-specific test after r90341
        https://bugs.webkit.org/show_bug.cgi?id=45455

        Unreviewed, skip test.

        The Skipped list needs the platform-specific path of the test.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 3 Jul 2011 17:27:51 +0000 (17:27 +0000)]
2011-07-03  Robert Hogan  <robert@webkit.org>

        Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
        https://bugs.webkit.org/show_bug.cgi?id=62482

        If a <meta http-equiv="refresh"> directive schedules a page reload rather than
        a redirect restore the scroll position after the reload. Do the same on location.reload().

        Reviewed by Adam Barth.

        * http/tests/navigation/scrollstate-after-http-equiv-refresh-expected.txt: Added.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2-expected.txt: Added.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html: Added.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-expected.txt: Added.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html: Added.
        * http/tests/navigation/scrollstate-after-http-equiv-refresh.html: Added.
        * http/tests/navigation/scrollstate-after-location-reload-expected.txt: Added.
        * http/tests/navigation/scrollstate-after-location-reload.html: Added.
2011-07-03  Robert Hogan  <robert@webkit.org>

        Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
        https://bugs.webkit.org/show_bug.cgi?id=62482

        If a <meta http-equiv="refresh"> directive schedules a page reload rather than
        a redirect restore the scroll position after the reload. Do the same on location.reload().

        Reviewed by Adam Barth.

        Tests: http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html
               http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
               http/tests/navigation/scrollstate-after-http-equiv-refresh.html
               http/tests/navigation/scrollstate-after-location-reload.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadURL):
        Only make the load FrameLoadTypeSame if it has not already been set as FrameLoadTypeReload*.
        FrameLoadTypeReload* loads are set through http-equiv refreshes, manual reloads, or location.reload()
        and honour the user's scroll position in the frame. A FrameLoadTypeSame is for when the frame is loading
        the same page again, e.g. by clicking a link.

        * loader/NavigationScheduler.cpp:
        (WebCore::ScheduledRedirect::fire): Tell FrameLoader::changeLocation() if this is a reload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-02 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 3 Jul 2011 17:14:16 +0000 (17:14 +0000)]
2011-04-02  Robert Hogan  <robert@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Support third-party cookie policy for Qt clients

        Add a new test and move third-party cookie tests to 'pending
        unskipping' for when bots move to 4.8.

        See also: http://gitorious.org/qt/qt/merge_requests/1205
                   (commit 154402f56dcf8303a6ce601a52215226af8d31ba)
                  http://bugreports.qt.nokia.com/browse/QTBUG-13601

        https://bugs.webkit.org/show_bug.cgi?id=45455

        * platform/qt/http/tests/cookies/strict-third-party-cookie-blocking.html: Added.
        * platform/qt/http/tests/cookies/strict-third-party-cookie-blocking-expected.txt: Added.
          This test is a stricter version of third-party-cookie-relaxing.html with
          the expected behaviour that all third-party cookies are blocked.
        * platform/qt/Skipped: Prepare tests for unskipping on Qt-4.8.
        * platform/qt/http/tests/cookies/third-party-cookie-relaxing-expected.txt: Added.
          Qt returns cookie lists in a different order from other ports.
2011-04-02  Robert Hogan  <robert@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Support third-party cookie policy for Qt clients
        https://bugs.webkit.org/show_bug.cgi?id=45455

        Identifying third-party cookies is facilitated by API new to QUrl from
        Qt 4.8: QUrl::topLevelDomain(). This API uses the Mozilla public suffix
        list to determine the top-level registry-controlled domain of the Url.

        See also: http://gitorious.org/qt/qt/merge_requests/1205
                   (commit 154402f56dcf8303a6ce601a52215226af8d31ba)
                  http://bugreports.qt.nokia.com/browse/QTBUG-13601

        Test: http/tests/cookies/strict-third-party-cookie-blocking.html

        * WebCore.pro:
        * platform/network/qt/ResourceRequestQt.cpp:
        (WebCore::ResourceRequest::toNetworkRequest):
        * platform/qt/CookieJarQt.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        * platform/qt/ThirdPartyCookiesQt.cpp: Added.
        (WebCore::cookieJar):
        (WebCore::isFirstPartyCookie):
        (WebCore::cookieAllowed):
        (WebCore::allowThirdPartyCookies):
        * platform/qt/ThirdPartyCookiesQt.h: Added.
2011-04-02  Robert Hogan  <robert@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Support third-party cookie policy for Qt clients

        This adds new API to QWebSettings that allows clients to
        select one of three third-party cookie blocking policies:

          AlwaysAllowThirdPartyCookies
          AlwaysBlockThirdPartyCookies
          AllowThirdPartyWithExistingCookies

        The first two are self-explanatory, the third mimics Safari's
        default behaviour of permitting third-party cookies when the user
        already has cookies from the third-party site. This was
        introduced to allow third-party cookie blocking to play well with
        facebook sharing etc. AlwaysAllowThirdPartyCookies is the default.

        There is scope for adding an 'exceptions' list API and clients would
        struggle to implement it themselves given the paucity of information
        available from setCookiesForUrl().

        See also: http://gitorious.org/qt/qt/merge_requests/1205
                   (commit 154402f56dcf8303a6ce601a52215226af8d31ba)
                  http://bugreports.qt.nokia.com/browse/QTBUG-13601

        https://bugs.webkit.org/show_bug.cgi?id=45455

        * Api/qwebsettings.cpp:
        (QWebSettings::QWebSettings):
        (QWebSettings::setThirdPartyCookiePolicy):
        (QWebSettings::thirdPartyCookiePolicy):
        * Api/qwebsettings.h:
2011-04-02  Robert Hogan  <robert@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Support third-party cookie policy for Qt clients
        https://bugs.webkit.org/show_bug.cgi?id=45455

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::setAlwaysAcceptCookies):
        (LayoutTestController::setAlwaysBlockCookies):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Vsevolod Vlasov <vsevik@chromium.org>
vsevik@chromium.org [Sun, 3 Jul 2011 15:58:38 +0000 (15:58 +0000)]
2011-07-03  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
        https://bugs.webkit.org/show_bug.cgi?id=63712

        * http/tests/inspector/network-preflight-options-expected.txt:
        * http/tests/inspector/network-preflight-options.html:
2011-07-03  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
        https://bugs.webkit.org/show_bug.cgi?id=63712

        Added InspectorInstrumentation calls to preflight OPTIONS requests callbacks in DocumentThreadableLoader.

        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
        (WebCore::DocumentThreadableLoader::didReceiveResponse):
        (WebCore::DocumentThreadableLoader::didReceiveData):
        (WebCore::DocumentThreadableLoader::didFinishLoading):
        (WebCore::DocumentThreadableLoader::didFail):
        (WebCore::DocumentThreadableLoader::loadRequest):
        * loader/DocumentThreadableLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 3 Jul 2011 15:51:21 +0000 (15:51 +0000)]
2011-07-03  Robert Hogan  <robert@webkit.org>

        Add platform-specific results after r90338

        Unreviewed, add platform-specific results for new rendertree test.
        https://bugs.webkit.org/show_bug.cgi?id=30355

        http://trac.webkit.org/changeset/90338

        * platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
        * platform/qt-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
        * plugins/mouse-click-plugin-clears-selection-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-23 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 3 Jul 2011 15:04:28 +0000 (15:04 +0000)]
2011-06-23  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
        https://bugs.webkit.org/show_bug.cgi?id=30355

        Unfortunately this has to be a rendertree test, as there is no rendertext way of
        determining if a selection is still highlighted.

        * platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
        * platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
        * plugins/mouse-click-plugin-clears-selection.html: Added.
2011-06-23  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
        https://bugs.webkit.org/show_bug.cgi?id=30355

        Test: plugins/mouse-click-plugin-clears-selection.html

        PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
        in order to clear the FrameSelection in the currently focused node. In its platform-specific
        code Chromium already does this (WebPluginContainerImpl.cpp).

        * WebCore.exp.in: Add symbol for FocusController::setFocusedNode
        * plugins/PluginView.cpp:
        (WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes
                                                   the call to FocusController:setFocusedFrame() and Document::setFocusedNode()
                                                   redundant, since it calls both.
2011-06-23  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
        https://bugs.webkit.org/show_bug.cgi?id=30355

        PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
        in order to clear the FrameSelection in the currently focused node. In its platform-specific
        code Chromium already does this (WebPluginContainerImpl.cpp).

        * WebProcess/Plugins/PluginView.cpp:
        (WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes
                                                   the call to FocusController:setFocusedFrame() redundant, since the
                                                   former calls it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 3 Jul 2011 11:09:22 +0000 (11:09 +0000)]
2011-07-03  Adam Barth  <abarth@webkit.org>

        Factor ReflectionHandler out of the rebaseline server.  Just code motion.

        * Scripts/webkitpy/tool/commands/rebaselineserver.py:
        * Scripts/webkitpy/tool/servers/rebaselineserver.py:
        * Scripts/webkitpy/tool/servers/reflectionhandler.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 3 Jul 2011 10:45:21 +0000 (10:45 +0000)]
2011-07-03  Adam Barth  <abarth@webkit.org>

        Move the rebaseline server out of the commands package and into the
        (new) servers package.  This patch prepares for refactoring this code
        to share server infrastructure with the (forthcoming) garden-o-matic
        command.

        * Scripts/webkitpy/tool/commands/rebaselineserver.py:
        * Scripts/webkitpy/tool/servers/__init__.py: Added.
        * Scripts/webkitpy/tool/servers/data/rebaselineserver/loupe.js:
        * Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:
        * Scripts/webkitpy/tool/servers/data/rebaselineserver/queue.js:
        * Scripts/webkitpy/tool/servers/rebaselineserver.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sun, 3 Jul 2011 04:02:24 +0000 (04:02 +0000)]
2011-07-02  Mihai Parparita  <mihaip@chromium.org>

        Remove failing expectation for fast/events/panScroll-click-hyperlink.html
        (Chromium still doesn't pass the test, since it doesn't have pan
        scrolling enabled, but r90235 added failing expectations for the Windows
        port, which Chromium Win and Linux pick up)

        Also remove flaky expectations for some tests that have not failed as
        far back as the flakiness dashboard has data for.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 3 Jul 2011 02:26:43 +0000 (02:26 +0000)]
2011-07-02  Maciej Stachowiak  <mjs@apple.com>

        Update SunSpider versioning to 1.0
        https://bugs.webkit.org/show_bug.cgi?id=63870

        Reviewed by Dan Bernstein.

        * hosted/sunspider.html:
        * hosted/versions.html:
        * resources/driver-TEMPLATE.html:
        * resources/results-TEMPLATE.html:
        * sunspider:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 3 Jul 2011 01:35:32 +0000 (01:35 +0000)]
2011-07-02  Maciej Stachowiak  <mjs@apple.com>

        Sunspider 0.9.1 harness doesn't actually close() its test documents
        https://bugs.webkit.org/show_bug.cgi?id=47045

        Reviewed by Daniel Bates.

        * hosted/versions.html:
        * resources/driver-TEMPLATE.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHave another go at fixing the Windows build.
andersca@apple.com [Sun, 3 Jul 2011 01:19:24 +0000 (01:19 +0000)]
Have another go at fixing the Windows build.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sun, 3 Jul 2011 01:15:49 +0000 (01:15 +0000)]
2011-07-02  Anders Carlsson  <andersca@apple.com>

        Null out the plug-in controller after destroying the plug-in.
        https://bugs.webkit.org/show_bug.cgi?id=63869

        Reviewed by Maciej Stachowiak.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::destroy):
        Call destroyPlugin.

        * WebProcess/Plugins/Plugin.cpp:
        (WebKit::Plugin::destroyPlugin):
        Call destroy and null out the plug-in controller.

        * WebProcess/Plugins/Plugin.h:
        Add destroyPlugin, make destroy private.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::~PluginView):
        Call destroyPlugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate skipped list.
andersca@apple.com [Sun, 3 Jul 2011 00:57:27 +0000 (00:57 +0000)]
Update skipped list.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows build for real.
andersca@apple.com [Sun, 3 Jul 2011 00:51:25 +0000 (00:51 +0000)]
Fix Windows build for real.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 2 Jul 2011 23:55:54 +0000 (23:55 +0000)]
2011-07-02  Anders Carlsson  <andersca@apple.com>

        Implement NPN_PluginThreadAsyncCall
        https://bugs.webkit.org/show_bug.cgi?id=63868

        Reviewed by Dan Bernstein.

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_PluginThreadAsyncCall):
        Call NetscapePlugin::pluginThreadAsyncCall.

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::pluginThreadAsyncCall):
        Schedule a work item to call the function on the main run loop.

        (WebKit::NetscapePlugin::handlePluginThreadAsyncCall):
        If the plug-in is still running, run the function.

        * WebProcess/Plugins/Netscape/NetscapePlugin.h:
        Add new member function.

        * WebProcess/Plugins/Plugin.h:
        Make plug-in inherit from ThreadSafeRefCounted since plug-ins can potentially
        ref the plug-in from other threads.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows build.
andersca@apple.com [Sat, 2 Jul 2011 23:41:26 +0000 (23:41 +0000)]
Fix Windows build.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 2 Jul 2011 23:40:31 +0000 (23:40 +0000)]
2011-07-02  Anders Carlsson  <andersca@apple.com>

        Move the plug-in controller member variable up to the shared Plugin base class
        https://bugs.webkit.org/show_bug.cgi?id=63867

        Reviewed by Sam Weinig.

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::NetscapePlugin):
        Remove m_pluginController.

        (WebKit::NetscapePlugin::invalidate):
        (WebKit::NetscapePlugin::userAgent):
        (WebKit::NetscapePlugin::loadURL):
        (WebKit::NetscapePlugin::setStatusbarText):
        (WebKit::NetscapePlugin::evaluate):
        (WebKit::NetscapePlugin::isPrivateBrowsingEnabled):
        (WebKit::NetscapePlugin::windowScriptNPObject):
        (WebKit::NetscapePlugin::pluginElementNPObject):
        (WebKit::NetscapePlugin::tryToShortCircuitInvoke):
        (WebKit::NetscapePlugin::cancelStreamLoad):
        (WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):
        (WebKit::NetscapePlugin::proxiesForURL):
        (WebKit::NetscapePlugin::cookiesForURL):
        (WebKit::NetscapePlugin::setCookiesForURL):
        (WebKit::NetscapePlugin::getAuthenticationInfo):
        Use controller() instead of m_pluginController.

        (WebKit::NetscapePlugin::initialize):
        This doesn't take a PluginController parameter anymore.

        (WebKit::NetscapePlugin::destroy):
        No need to null out the plug-in controller.

        * WebProcess/Plugins/Netscape/NetscapePlugin.h:
        Remove m_pluginController member variable.

        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        (WebKit::NetscapePlugin::compositingRenderServerPort):
        (WebKit::NetscapePlugin::platformSetFocus):
        (WebKit::NetscapePlugin::windowFocusChanged):
        Use controller() instead of m_pluginController.

        * WebProcess/Plugins/Plugin.cpp:
        (WebKit::Plugin::Plugin):
        Initialize m_pluginController.

        (WebKit::Plugin::initialize):
        New function that initializes the plug-in controller and then calls the real
        virtual initialize member function.

        * WebProcess/Plugins/Plugin.h:
        Add m_pluginController member variable and a new initialize virtual member function that doesn't take a
        PluginController parameter. Make the "old" initialize member function set up the plug-in controller.

        (WebKit::Plugin::controller):
        This is now a simple getter.

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::PluginProxy):
        Remove m_pluginController.

        (WebKit::PluginProxy::pluginProcessCrashed):
        Use controller(), remove a bogus null check.

        (WebKit::PluginProxy::initialize):
        This doesn't take a PluginController parameter now.

        (WebKit::PluginProxy::destroy):
        No need to null out the plug-in controller member variable.

        (WebKit::PluginProxy::loadURL):
        (WebKit::PluginProxy::proxiesForURL):
        (WebKit::PluginProxy::cookiesForURL):
        (WebKit::PluginProxy::setCookiesForURL):
        (WebKit::PluginProxy::getAuthenticationInfo):
        (WebKit::PluginProxy::windowNPObjectID):
        (WebKit::PluginProxy::getPluginElementNPObject):
        (WebKit::PluginProxy::evaluate):
        (WebKit::PluginProxy::cancelStreamLoad):
        (WebKit::PluginProxy::cancelManualStreamLoad):
        (WebKit::PluginProxy::setStatusbarText):
        (WebKit::PluginProxy::setComplexTextInputEnabled):
        (WebKit::PluginProxy::update):
        Use controller() instead of m_pluginController.

        * WebProcess/Plugins/PluginProxy.h:
        Remove m_pluginController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 2 Jul 2011 23:20:11 +0000 (23:20 +0000)]
2011-07-02  Mihai Parparita  <mihaip@chromium.org>

        Remove Chromium Leopard failing expectations for two tests (fast/dom/
        HTMLMeterElement/meter-writing-mode.html and fast/images/
        imagemap-focus-ring-zoom.html) sice they pass now. Fix bug links.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=63866
barraclough@apple.com [Sat, 2 Jul 2011 23:08:23 +0000 (23:08 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63866
DFG JIT - implement instanceof

Reviewed by Sam Weinig.

Add ops CheckHasInstance & InstanceOf to implement bytecodes
op_check_has_instance & op_instanceof. This is an initial
functional implementation, performance is a wash. We can
follow up with changes to fuse the InstanceOf node with
a subsequant branch, as we do with other comparisons.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jitAssertIsCell):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::jitAssertIsCell):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 2 Jul 2011 21:59:17 +0000 (21:59 +0000)]
2011-07-02  Mihai Parparita  <mihaip@chromium.org>

        Meant to actually remove expectations in r90322, not just comment them
        out.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 2 Jul 2011 21:57:46 +0000 (21:57 +0000)]
2011-07-02  Mihai Parparita  <mihaip@chromium.org>

        Add Chromium Mac Snow Leopard baselines for editing/selection/vertical*
        since the regular Mac baselines can't be used due to single-pixel
        differences in character rendering (presumably caused by 32-bit vs.
        64-bit binaries).

        * platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Added.
        * platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
        * platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
        * platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
        * platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
        * platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
        * platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
        * platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot Reviewed.
mjs@apple.com [Sat, 2 Jul 2011 21:12:27 +0000 (21:12 +0000)]
Not Reviewed.

Fix obviou typo in previous commit.

* tests/sunspider-1.0/bitops-bitwise-and.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 2 Jul 2011 21:11:54 +0000 (21:11 +0000)]
2011-07-02  Mihai Parparita  <mihaip@chromium.org>

        Chromium expectations update:
        - Add failing expectation for fast/css/last-of-type-pseudo-class.html,
          which fails in debug only.
        - Remove Chromium-specific baselines for fast/js/reserved-words.html,
          the test now passes with the regular baselines.

        * platform/chromium-mac/fast/js/reserved-words-expected.txt: Removed.
        * platform/chromium-win/fast/js/reserved-words-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 2 Jul 2011 21:09:43 +0000 (21:09 +0000)]
2011-07-02  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders Carlsson.

        SunSpider: all four bitops benchmarks can be replaced with NOP
        https://bugs.webkit.org/show_bug.cgi?id=38446

        * tests/sunspider-1.0/bitops-3bit-bits-in-byte.js:
        (TimeFunc): Save the result.
        * tests/sunspider-1.0/bitops-bits-in-byte.js:
        (TimeFunc): Save the result.
        * tests/sunspider-1.0/bitops-bitwise-and.js: More explicitly
        save the results.
        * tests/sunspider-1.0/bitops-nsieve-bits.js:
        (sieve): Save the result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 2 Jul 2011 20:57:40 +0000 (20:57 +0000)]
2011-07-02  Maciej Stachowiak  <mjs@apple.com>

        SunSpider: string-validate-input.js uses an undeclared variable named 'name', which is a DOM API
        https://bugs.webkit.org/show_bug.cgi?id=60937

        Reviewed by Dan Bernstein.

        * tests/sunspider-1.0/string-validate-input.js:
        (doTest): Rename the variable to username

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-02 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 2 Jul 2011 20:45:55 +0000 (20:45 +0000)]
2011-07-02  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        SunSpider: The main function of math-cordic is dead code
        https://bugs.webkit.org/show_bug.cgi?id=63863

        Try to prevent math-cordic from being eliminated as dead code or
        compiled down to a constant.

        * tests/sunspider-1.0/math-cordic.js:
        (cordicsincos):
        (cordic):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate the header file too.
mrowe@apple.com [Sat, 2 Jul 2011 17:26:21 +0000 (17:26 +0000)]
Update the header file too.

* WebKitSystemInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate WebKitSystemInterface binaries.
mrowe@apple.com [Sat, 2 Jul 2011 16:25:39 +0000 (16:25 +0000)]
Update WebKitSystemInterface binaries.

* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceLion.a: Added.
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Update expectation of fast/forms/input-file-re-render.html
tkent@chromium.org [Sat, 2 Jul 2011 10:46:31 +0000 (10:46 +0000)]
[GTK] Update expectation of fast/forms/input-file-re-render.html
https://bugs.webkit.org/show_bug.cgi?id=49245

* platform/gtk/fast/forms/input-file-re-render-expected.png: Remove a stale image.
* platform/gtk/fast/forms/input-file-re-render-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Sat, 2 Jul 2011 06:00:50 +0000 (06:00 +0000)]
2011-07-01  Kent Tamura  <tkent@chromium.org>

        [Chromium] Rebaseline for fast/forms/input-file-re-render.html
        https://bugs.webkit.org/show_bug.cgi?id=63733

        Also, input-file-label.html passes now.

        * platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
        * platform/chromium-linux/fast/forms/input-file-re-render-expected.txt:
        * platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png:
        * platform/chromium-mac/fast/forms/input-file-re-render-expected.png:
        * platform/chromium-win/fast/forms/input-file-re-render-expected.png:
        * platform/chromium-win/fast/forms/input-file-re-render-expected.txt:
        * platform/chromium/test_expectations.txt:
2011-07-01  Kent Tamura  <tkent@chromium.org>

        [Chromium] Rebaseline for fast/forms/input-file-re-render.html
        https://bugs.webkit.org/show_bug.cgi?id=63733

        * DEPS: Update chromium revision to 91405 to have "Choose Files" string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90313 268f45cc-cd09-0410-ab3c-d52691b4dbfc