WebKit-https.git
11 years ago2010-03-26 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 27 Mar 2010 01:11:48 +0000 (01:11 +0000)]
2010-03-26  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by David Levin.

        Update a bunch of incorrect image checksums, and suppress all of the
        remaining IMAGE failures in platform/mac/test_expectations.txt.

        https://bugs.webkit.org/show_bug.cgi?id=36620

        * platform/mac-leopard/compositing/geometry/root-layer-update-expected.checksum:
        * platform/mac-leopard/compositing/overflow/overflow-positioning-expected.checksum:
        * platform/mac-leopard/compositing/repaint/become-overlay-composited-layer-expected.checksum:
        * platform/mac-leopard/compositing/repaint/layer-repaint-rects-expected.checksum:
        * platform/mac-leopard/media/video-zoom-controls-expected.checksum:
        * platform/mac/animations/3d/change-transform-in-end-event-expected.checksum:
        * platform/mac/animations/3d/state-at-end-event-transform-expected.checksum:
        * platform/mac/animations/state-at-end-event-expected.checksum:
        * platform/mac/compositing/animation/state-at-end-event-transform-layer-expected.checksum:
        * platform/mac/compositing/color-matching/pdf-image-match-expected.checksum:
        * platform/mac/compositing/compositing-visible-descendant-expected.checksum:
        * platform/mac/compositing/generated-content-expected.checksum:
        * platform/mac/compositing/geometry/abs-position-inside-opacity-expected.checksum:
        * platform/mac/compositing/geometry/fixed-position-expected.checksum:
        * platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum:
        * platform/mac/compositing/geometry/outline-change-expected.checksum:
        * platform/mac/compositing/geometry/partial-layout-update-expected.checksum:
        * platform/mac/compositing/geometry/root-layer-update-expected.checksum:
        * platform/mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum:
        * platform/mac/compositing/masks/direct-image-mask-expected.checksum:
        * platform/mac/compositing/masks/masked-ancestor-expected.checksum:
        * platform/mac/compositing/masks/multiple-masks-expected.checksum:
        * platform/mac/compositing/masks/simple-composited-mask-expected.checksum:
        * platform/mac/compositing/overflow/ancestor-overflow-expected.checksum:
        * platform/mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
        * platform/mac/compositing/overflow/overflow-positioning-expected.checksum:
        * platform/mac/compositing/overflow/parent-overflow-expected.checksum:
        * platform/mac/compositing/overflow/scrollbar-painting-expected.checksum:
        * platform/mac/compositing/reflections/reflection-in-composited-expected.checksum:
        * platform/mac/compositing/reflections/reflection-ordering-expected.checksum:
        * platform/mac/compositing/reflections/simple-composited-reflections-expected.checksum:
        * platform/mac/compositing/repaint/become-overlay-composited-layer-expected.checksum:
        * platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
        * platform/mac/compositing/repaint/layer-repaint-expected.checksum:
        * platform/mac/compositing/repaint/layer-repaint-rects-expected.checksum:
        * platform/mac/compositing/repaint/opacity-between-absolute-expected.checksum:
        * platform/mac/compositing/repaint/opacity-between-absolute2-expected.checksum:
        * platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
        * platform/mac/compositing/sibling-positioning-expected.checksum:
        * platform/mac/compositing/transitions/singular-scale-transition-expected.checksum:
        * platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum:
        * platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum:
        * platform/mac/editing/deleting/delete-to-select-table-expected.checksum:
        * platform/mac/editing/deleting/type-delete-after-quote-expected.checksum:
        * platform/mac/editing/inserting/5418891-expected.checksum:
        * platform/mac/editing/selection/4960116-expected.checksum:
        * platform/mac/editing/selection/caret-rtl-2-expected.checksum:
        * platform/mac/editing/selection/extend-by-word-002-expected.checksum:
        * platform/mac/editing/selection/select-all-002-expected.checksum:
        * platform/mac/editing/selection/select-text-overflow-ellipsis-expected.checksum:
        * platform/mac/editing/selection/transformed-selection-rects-expected.checksum:
        * platform/mac/fast/backgrounds/background-clip-text-expected.checksum:
        * platform/mac/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.checksum:
        * platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize15-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
        * platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
        * platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
        * platform/mac/fast/backgrounds/svg-as-mask-expected.checksum:
        * platform/mac/fast/block/float/avoidance-percent-width-compat-expected.checksum:
        * platform/mac/fast/block/float/avoidance-percent-width-strict-expected.checksum:
        * platform/mac/fast/block/margin-collapse/103-expected.checksum:
        * platform/mac/fast/box-shadow/basic-shadows-expected.checksum:
        * platform/mac/fast/box-shadow/transform-fringing-expected.checksum:
        * platform/mac/fast/css/apple-prefix-expected.checksum:
        * platform/mac/fast/css/color-correction-backgrounds-and-text-expected.checksum:
        * platform/mac/fast/css/color-correction-expected.checksum:
        * platform/mac/fast/css/color-correction-on-background-image-expected.checksum:
        * platform/mac/fast/css/color-correction-on-backgrounds-expected.checksum:
        * platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum:
        * platform/mac/fast/css/color-correction-on-text-expected.checksum:
        * platform/mac/fast/css/color-correction-on-text-shadow-expected.checksum:
        * platform/mac/fast/css/color-correction-untagged-images-expected.checksum:
        * platform/mac/fast/css/namespaces/namespaces-comments-expected.checksum:
        * platform/mac/fast/css/namespaces/namespaces-empty-expected.checksum:
        * platform/mac/fast/css/namespaces/namespaces-escapes-expected.checksum:
        * platform/mac/fast/css/namespaces/namespaces-invalid-at-expected.checksum:
        * platform/mac/fast/css/variables/misplaced-import-test-expected.checksum:
        * platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
        * platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum:
        * platform/mac/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum:
        * platform/mac/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum:
        * platform/mac/fast/forms/001-expected.checksum:
        * platform/mac/fast/forms/menulist-clip-expected.checksum:
        * platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
        * platform/mac/fast/forms/menulist-option-wrap-expected.checksum:
        * platform/mac/fast/forms/menulist-restrict-line-height-expected.checksum:
        * platform/mac/fast/forms/menulist-style-color-expected.checksum:
        * platform/mac/fast/forms/select-baseline-expected.checksum:
        * platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
        * platform/mac/fast/frames/viewsource-attribute-expected.checksum:
        * platform/mac/fast/inline/long-wrapped-line-expected.checksum:
        * platform/mac/fast/lists/anonymous-items-expected.checksum:
        * platform/mac/fast/lists/markers-in-selection-expected.checksum:
        * platform/mac/fast/multicol/client-rects-expected.checksum: Added.
        * platform/mac/fast/multicol/float-multicol-expected.checksum:
        * platform/mac/fast/overflow/line-clamp-expected.checksum:
        * platform/mac/fast/overflow/position-fixed-transform-clipping-expected.checksum:
        * platform/mac/fast/reflections/abs-position-in-reflection-expected.checksum:
        * platform/mac/fast/reflections/opacity-reflection-transform-expected.checksum:
        * platform/mac/fast/repaint/backgroundSizeRepaint-expected.checksum:
        * platform/mac/fast/repaint/box-shadow-h-expected.checksum:
        * platform/mac/fast/repaint/box-shadow-v-expected.checksum:
        * platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.checksum:
        * platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum:
        * platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.checksum:
        * platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum:
        * platform/mac/fast/repaint/subtree-layoutstate-transform-expected.checksum:
        * platform/mac/fast/repaint/table-outer-border-expected.checksum:
        * platform/mac/fast/table/fixed-table-with-percent-inside-percent-table-expected.checksum:
        * platform/mac/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.checksum:
        * platform/mac/fast/table/fixed-table-with-percent-width-inside-div-expected.checksum:
        * platform/mac/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.checksum:
        * platform/mac/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.checksum:
        * platform/mac/fast/table/fixed-table-with-small-percent-width-expected.checksum:
        * platform/mac/fast/text/atsui-partial-selection-expected.checksum:
        * platform/mac/fast/text/capitalize-boundaries-expected.checksum:
        * platform/mac/fast/text/drawBidiText-expected.checksum:
        * platform/mac/fast/text/line-breaking-with-kerning-expected.checksum:
        * platform/mac/fast/text/sticky-typesetting-features-expected.checksum:
        * platform/mac/fast/transforms/shadows-expected.checksum:
        * platform/mac/http/tests/misc/slow-loading-mask-expected.checksum:
        * platform/mac/media/video-zoom-controls-expected.checksum:
        * platform/mac/plugins/embed-attributes-style-expected.checksum:
        * platform/mac/plugins/qt-qwidget-plugin-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug106158-1-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug106158-2-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug34176-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug6674-expected.checksum:
        * platform/mac/test_expectations.txt:
        * platform/mac/transforms/2d/transform-fixed-container-expected.checksum:
        * platform/mac/transitions/move-after-transition-expected.checksum:
        * platform/mac/transitions/transition-end-event-rendering-expected.checksum:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 27 Mar 2010 00:15:21 +0000 (00:15 +0000)]
2010-03-25  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Add a test_expectations.txt file for the mac platform so
        new-run-webkit-tests can track IMAGE failures.

        https://bugs.webkit.org/show_bug.cgi?id=36619

        * platform/mac/test_expectations.txt: Added.
2010-03-26  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Change the Mac port of new-run-webkit-tests to look for a
        test_expectations.txt file in addition to the Skipped files, so we
        can track pixel failures.

        https://bugs.webkit.org/show_bug.cgi?id=36619

        * Scripts/webkitpy/layout_tests/port/mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 26 Mar 2010 23:38:37 +0000 (23:38 +0000)]
2010-03-26  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Implement pixel tests (image diff) properly on the Mac port.

        This change introduces a new "ServerPocess" class that can be used
        to manage processes that the run-webkit-tests harness forks off and
        expects to stay up for longer than a single request/response session.
        Both DumpRenderTree and ImageDiff use this style of communication,
        although the current code forks off a new ImageDiff for each diff
        (We need to restructure other parts of the code to be able to do this
        safely in a multi-threaded environment).

        Also, now that the ServerProcess abstraction exists, we can probably
        clean up and simplify some of the thread management logic in
        test_shell_thread as well.

        https://bugs.webkit.org/show_bug.cgi?id=34826

        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/server_process.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 26 Mar 2010 22:23:16 +0000 (22:23 +0000)]
2010-03-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein, Darin Adler.

        Re-entrant layout via plug-ins may cause crashes with bad RenderWidgets
        https://bugs.webkit.org/show_bug.cgi?id=36675
        <rdar://problem/7787617>

        Fix two places in the code where RenderWidgets can get destroyed while being iterated over.
        This can happen when plug-ins execute script from NPP_SetWindow, and that script makes a change
        to the page that destroys a RenderWidget.

        Tests: plugins/reentrant-update-widget-positions.html
               plugins/update-widgets-crash.html

        * page/FrameView.cpp:
        (WebCore::FrameView::updateWidgets): ref() the RenderEmbeddedObjects that are put into the
        vector before iterating of them, and deref() them at the end. Rather than checking the m_widgetUpdateSet
        to see if the RenderWidget is still live, test object->node().

        * rendering/RenderView.cpp:
        (WebCore::RenderView::RenderView): Initialize some data members to make it more obvious in the debugger
        that the object is not garbage.
        (WebCore::RenderView::updateWidgetPositions): Use a Vector of RenderWidget* to keep the RenderWidgets
        alive during iteration, by reffing and dereffing them.
        * rendering/RenderWidget.h:
        (WebCore::RenderWidget::ref): Make this and deref() public.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Sergio Villar Senin <svillar@igalia.com>
eric@webkit.org [Fri, 26 Mar 2010 22:16:09 +0000 (22:16 +0000)]
2010-03-26  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        Print didFinishLoadForFrame outcome in DRT

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewLoadCommitted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Partial fix for https://bugs.webkit.org/show_bug.cgi?id=36564
bdakin@apple.com [Fri, 26 Mar 2010 22:12:47 +0000 (22:12 +0000)]
WebCore: Partial fix for https://bugs.webkit.org/show_bug.cgi?id=36564
Performance regression for setting content of <text> in SVG
-and corresponding-
<rdar://problem/7693963>

Reviewed by Darin Adler.

toClipPath() is extremely inefficient, so this patch removes the
call to it from RenderSVGResourceClipper::resourceBoundingBox()
which is very hot code in SVG with clip-paths. It is sufficient to
call unite with the objectBoundingBox(), which will return early if
objectBoundingBox() is empty.

* rendering/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::resourceBoundingBox):

LayoutTests: Updated test for https://bugs.webkit.org/show_bug.cgi?id=36564
Performance regression for setting content of <text> in SVG
-and corresponding-
<rdar://problem/7693963>

Reviewed by Darin Adler.

* platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 26 Mar 2010 21:51:15 +0000 (21:51 +0000)]
2010-03-26  Eric Seidel  <eric@webkit.org>

        Unreviewed test fix.
        My change conflicted with one of Adam's causing test-webkitpy to fail.

        Move commit_message_for_this_commit from scm to checkout
        https://bugs.webkit.org/show_bug.cgi?id=36629

        * Scripts/webkitpy/common/checkout/api_unittest.py:
         - modified_changelogs is now on Checkout instead of scm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 26 Mar 2010 21:45:56 +0000 (21:45 +0000)]
2010-03-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Refactor IRCBot controller logic to allow for commands
        https://bugs.webkit.org/show_bug.cgi?id=36676

        We need to move the controller logic into the tool package so it can
        know about commands.  The changes to queueengine could go in a
        different patch, but we're going to need it anyway.

        * Scripts/webkitpy/common/config/irc.py: Added.
        * Scripts/webkitpy/common/net/irc/ircbot.py:
        * Scripts/webkitpy/common/net/irc/ircproxy.py:
        * Scripts/webkitpy/tool/bot/queueengine.py:
        * Scripts/webkitpy/tool/bot/sheriffircbot.py: Added.
        * Scripts/webkitpy/tool/commands/sheriffbot.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 26 Mar 2010 20:44:45 +0000 (20:44 +0000)]
2010-03-26  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Dave Hyatt.

        Generated run-in Content is Mistakenly Getting Deleted
        https://bugs.webkit.org/show_bug.cgi?id=36505
        <rdar://problem/7767161>

        Test: fast/runin/generated2.html
        Test: fast/runin/generated3.html
        Test: fast/runin/generated4.html

        Do not destroy :before/:after generated content with display run-in
        when relaying out different nodes. Have their real owners correctly
        handle them.

        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::updateBeforeAfterContent): simplified logic
        (WebCore::RenderObjectChildList::beforeAfterContainer): skip generated run-ins when checking children, check for them in grandchildren

2010-03-26  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Dave Hyatt.

        Generated run-in Content is Mistakenly Getting Deleted
        https://bugs.webkit.org/show_bug.cgi?id=36505
        <rdar://problem/7767161>

          Test dynamic update of the inner block, containing the generated
          run-in, but not owning it with the :before rule, and owners.

        * fast/runin/generated2.html: Added.
        * platform/mac/fast/runin/generated2-expected.txt: Added.

          Test dynamic update of the outer block, this block owns the
          generated run-in, but it is actually contained in a child block.

        * fast/runin/generated3.html: Added.
        * platform/mac/fast/runin/generated3-expected.txt: Added.

          Test dynamic updates affecting generated run-ins both
          in relation to and not in relation to list markers.

        * fast/runin/generated4.html: Added.
        * platform/mac/fast/runin/generated4-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 26 Mar 2010 20:22:20 +0000 (20:22 +0000)]
2010-03-26  Adam Barth  <abarth@webkit.org>

        Rubber stamped by Eric Seidel.

        Move the threading code into its own module.  (It has nothing to do with IRC.)

        * Scripts/webkitpy/common/net/irc/ircbot.py:
        * Scripts/webkitpy/common/net/irc/ircproxy.py:
        * Scripts/webkitpy/common/net/irc/messagepump.py: Removed.
        * Scripts/webkitpy/common/net/irc/messagepump_unittest.py: Removed.
        * Scripts/webkitpy/common/net/irc/threadedmessagequeue.py: Removed.
        * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py: Removed.
        * Scripts/webkitpy/common/net/irc/unittests.py:
        * Scripts/webkitpy/common/thread: Added.
        * Scripts/webkitpy/common/thread/__init__.py: Added.
        * Scripts/webkitpy/common/thread/messagepump.py: Copied from Scripts/webkitpy/common/net/irc/messagepump.py.
        * Scripts/webkitpy/common/thread/messagepump_unittest.py: Copied from Scripts/webkitpy/common/net/irc/messagepump_unittest.py.
        * Scripts/webkitpy/common/thread/threadedmessagequeue.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue.py.
        * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py.
        * Scripts/webkitpy/common/thread/unittests.py: Added.
        * Scripts/webkitpy/common/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 26 Mar 2010 20:19:15 +0000 (20:19 +0000)]
2010-03-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        shift+home/end and cmd+shift+left/right don't extend the selection correctly
        https://bugs.webkit.org/show_bug.cgi?id=36539

        * editing/selection/extend-after-mouse-selection.html:
        * editing/selection/extend-selection-expected.txt:
        Extending forward by lineboundary selects the whole line. Now extending backwards
        by lineboundary after the whole line is selected is a noop instead of collapsed
        the selection to the start.
        * editing/selection/move-begin-end.html:
        Just cleaned up this test.
        * platform/mac/editing/selection/extend-after-mouse-selection-expected.txt:
2010-03-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        shift+home/end and cmd+shift+left/right don't extend the selection correctly
        https://bugs.webkit.org/show_bug.cgi?id=36539

        * WebCore.base.exp:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modify):
        * editing/SelectionController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 26 Mar 2010 19:47:22 +0000 (19:47 +0000)]
2010-03-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Move commit_message_for_this_commit from scm to checkout
        https://bugs.webkit.org/show_bug.cgi?id=36629

        Finally add some basic unit testing for Checkout.commit_message_for_this_commit

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/api_unittest.py: Added.
        * Scripts/webkitpy/common/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-24 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Fri, 26 Mar 2010 19:40:40 +0000 (19:40 +0000)]
2010-03-24  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Implement WebFormControlElement and WebSelectElement.  Add
        a getFormControlElements method to WebFormElement.

        https://bugs.webkit.org/show_bug.cgi?id=36562

        * WebKit.gyp:
        * public/WebElement.h:
        * public/WebFormControlElement.h: Added.
        * public/WebFormElement.h:
        * public/WebInputElement.h:
        (WebKit::WebInputElement::WebInputElement):
        (WebKit::WebInputElement::operator=):
        (WebKit::WebInputElement::assign):
        * public/WebSelectElement.h: Added.
        * src/WebElement.cpp:
        (WebKit::WebElement::isFormControlElement):
        * src/WebFormControlElement.cpp: Added.
        * src/WebFormElement.cpp:
        (WebKit::WebFormElement::getFormControlElements):
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::WebInputElement):
        * src/WebSelectElement.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUser Agent Switcher on QtLauncher https://bugs.webkit.org/show_bug.cgi?id=36451
tonikitoo@webkit.org [Fri, 26 Mar 2010 19:30:49 +0000 (19:30 +0000)]
User Agent Switcher on QtLauncher https://bugs.webkit.org/show_bug.cgi?id=36451

Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-26
Reviewed by Simon Hausmann.

Make possible to change the QtLauncher user agent via
a predefined list.

* QtLauncher/QtLauncher.pro:
* QtLauncher/QtLauncher.qrc: Added.
* QtLauncher/main.cpp:
(LauncherWindow::showUserAgentDialog):
(LauncherWindow::createChrome):
* QtLauncher/useragentlist.txt: Added.
* QtLauncher/webpage.cpp:
(WebPage::userAgentForUrl):
* QtLauncher/webpage.h:
(WebPage::setUserAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Victor Wang <victorw@chromium.org>
eric@webkit.org [Fri, 26 Mar 2010 18:14:42 +0000 (18:14 +0000)]
2010-03-26  Victor Wang  <victorw@chromium.org>

        Reviewed by Adam Barth.

        Host layout test flakiness dashboard in TestResultServer appengine.

        Flakiness dashboard is a tool to monitor layout test status and
        help layout test regression diagnostics.

        https://bugs.webkit.org/show_bug.cgi?id=36195

        * TestResultServer/handlers/dashboardhandler.py: Added.
         - New handler to handle dashboard request
        * TestResultServer/handlers/menu.py:
         - Add new dashboard links
        * TestResultServer/handlers/testfilehandler.py:
         - Request routes refactory
        * TestResultServer/index.yaml:
        * TestResultServer/main.py:
         - Add new dashboard request routes and refactor test result file rountes.
        * TestResultServer/model/dashboardfile.py: Added.
         - Model to access datastore for dashboard files
        * TestResultServer/model/testfile.py:
        * TestResultServer/stylesheets/dashboardfile.css: Added.
        * TestResultServer/templates/dashboardfilelist.html: Added.
        * TestResultServer/templates/showfilelist.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd fast/multicol/hit-test-above-or-below.html, this is failing in the same way as...
bweinstein@apple.com [Fri, 26 Mar 2010 18:06:16 +0000 (18:06 +0000)]
Add fast/multicol/hit-test-above-or-below.html, this is failing in the same way as Qt, and is being
tracked by the same bug (https://bugs.webkit.org/show_bug.cgi?id=35973).

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Nate Chapin.
levin@chromium.org [Fri, 26 Mar 2010 17:38:52 +0000 (17:38 +0000)]
Rubber-stamped by Nate Chapin.

[chromium] Updated test expectations due to recent failures,
added bugs, etc.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 26 Mar 2010 17:32:31 +0000 (17:32 +0000)]
2010-03-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove some evil statics from CommitInfo
        https://bugs.webkit.org/show_bug.cgi?id=36637

        These methods should really be on checkout.  You can tell because they
        know about ChangeLogs and take an SCM as an argument.  :)

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/checkout/commitinfo.py:
        * Scripts/webkitpy/tool/commands/queries.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Fri, 26 Mar 2010 17:04:06 +0000 (17:04 +0000)]
2010-03-26  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Laszlo Gombos.

        Don't undefine SKIP_STATIC_CONSTRUCTORS_ON_GCC for Symbian HW targets.
        https://bugs.webkit.org/show_bug.cgi?id=34081

        Defining StringImpl instances as globals will cause a crash on process exit as
        StringImpl::Remove expects TLS which was already deleted at time of exiting main and ends up
        constructing one exiting thread.

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Andrey Kosyakov <caseq@chromium.org>
eric@webkit.org [Fri, 26 Mar 2010 16:34:12 +0000 (16:34 +0000)]
2010-03-26  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Send worker resource content to inspector to enable display of web
        workers in inspector's resource tab.
        https://bugs.webkit.org/show_bug.cgi?id=36658

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorController::scriptImported):
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::type):
        (WebCore::InspectorResource::setOverrideContent):
        (WebCore::InspectorResource::sourceString):
        * inspector/InspectorResource.h:
        * workers/DefaultSharedWorkerRepository.cpp:
        (WebCore::SharedWorkerScriptLoader::notifyFinished):
        * workers/Worker.cpp:
        (WebCore::Worker::notifyFinished):
2010-03-26  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Send worker resource content to inspector to enable display of web
        workers in inspector's resource tab.
        https://bugs.webkit.org/show_bug.cgi?id=36658

        * src/SharedWorkerRepository.cpp:
        (WebCore::SharedWorkerScriptLoader::notifyFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Fix the rendering of HTMLProgressElement
yael.aharon@nokia.com [Fri, 26 Mar 2010 15:42:41 +0000 (15:42 +0000)]
WebCore: Fix the rendering of HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=36206

Reviewed by Antti Koivisto.

Update the rendering and css to conform to
http://www.whatwg.org/specs/web-apps/current-work/complete.html#the-progress-element-0.
Updated the tests and the expected results accordingly.

* css/html.css:
* rendering/RenderProgress.cpp:
* rendering/RenderProgress.h:

LayoutTests: Fix the rendering of HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=36206
Add dir=rtl test and update the expected results.

Reviewed by Antti Koivisto.

* fast/dom/HTMLProgressElement/progress-element.html:
* platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
* platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png:
* platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed build fix.
jchaffraix@webkit.org [Fri, 26 Mar 2010 15:30:14 +0000 (15:30 +0000)]
Unreviewed build fix.

FontPlatformDataPango.cpp: prototype for
'WebCore::FontPlatformData::FontPlatformData(cairo_font_face_t*, int, bool, bool)'
does not match any in class
https://bugs.webkit.org/show_bug.cgi?id=36496

* platform/graphics/gtk/FontPlatformDataPango.cpp:
(WebCore::FontPlatformData::FontPlatformData): The 'size' parameter
should be a float to match the declaration and the other definitions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Shu Chang <chang.shu@nokia.com>
eric@webkit.org [Fri, 26 Mar 2010 15:22:55 +0000 (15:22 +0000)]
2010-03-26  Shu Chang  <chang.shu@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Prevent referring d->m_job in the future because calling abort()
        deletes the instance itself.
        https://bugs.webkit.org/show_bug.cgi?id=36618

        Test: http/tests/appcache/fallback.html

        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::ResourceHandle::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Compile with QT_USE_FAST_OPERATOR_PLUS
hausmann@webkit.org [Fri, 26 Mar 2010 14:37:39 +0000 (14:37 +0000)]
[Qt] Compile with QT_USE_FAST_OPERATOR_PLUS

Patch by Olivier Goffart <ogoffart@trolltech.com> on 2010-03-26
Reviewed by Simon Hausmann.

* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::populateSetting):
(WebCore::InspectorClientQt::storeSetting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Doc: Simplified Commercial Editions for Qt 4.7.
hausmann@webkit.org [Fri, 26 Mar 2010 14:35:15 +0000 (14:35 +0000)]
[Qt] Doc: Simplified Commercial Editions for Qt 4.7.

Patch by David Boddie <dboddie@trolltech.com> on 2010-03-26
Reviewed by Simon Hausmann.

* docs/qtwebkit.qdoc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Fri, 26 Mar 2010 14:26:19 +0000 (14:26 +0000)]
2010-03-26  Stephen White  <senorblanco@chromium.org>

        Unreviewed; build fix.

        Rolling out 56620; too many layout test failures.

        Covered by fast/css/*.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cleanup):
        (WebCore::CSSPrimitiveValue::cssText):
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::):
2010-03-26  Stephen White  <senorblanco@chromium.org>

        Unreviewed; build fix.

        Rolling out 56620; too many layout test failures.

        * fast/css/cssText-cache-expected.txt: Removed.
        * fast/css/cssText-cache.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Build JavaScriptCore as a static library.
hausmann@webkit.org [Fri, 26 Mar 2010 14:05:09 +0000 (14:05 +0000)]
[Qt] Build JavaScriptCore as a static library.
https://bugs.webkit.org/show_bug.cgi?id=36590

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-03-26
Reviewed by Simon Hausmann.

This patch takes what was left of the unused JavaScriptCore.pro
and moved the compilation logic from JavaScriptCore.pri to
JavaScriptCore.pro.

.:

* WebKit.pro:

JavaScriptCore:

* JavaScriptCore.pri:
* JavaScriptCore.pro:
* jsc.pro:
* qt/api/QtScript.pro:

WebCore:

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix compilation on Windows
hausmann@webkit.org [Fri, 26 Mar 2010 13:44:49 +0000 (13:44 +0000)]
[Qt] Fix compilation on Windows

Patch by Olivier Goffart <ogoffart@trolltech.com> on 2010-03-26
Reviewed by Simon Hausmann.

For some reason, the MSVC compiler choose the
operator+(const QString &, const QString &) instead of
operator+(const WebCore::String &, const WebCore::String &)
resulting in errors when QT_USE_FAST_OPERATOR_PLUS is used.

* dom/XMLTokenizerQt.cpp:
(WebCore::handleElementNamespaces):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 26 Mar 2010 13:28:25 +0000 (13:28 +0000)]
2010-03-26  Philippe Normand  <pnormand@igalia.com>

        fast/parser/xml-declaration-missing-ending-mark.html crashed on Gtk bot
        https://bugs.webkit.org/show_bug.cgi?id=33027

        Skipping test that fails on GTK+ Debug bots.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-24 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Fri, 26 Mar 2010 13:18:27 +0000 (13:18 +0000)]
2010-03-24  Stephen White  <senorblanco@chromium.org>

        Reviewed by Darin Adler.

        In order to speed up multiple calls to CSSPrimitiveValue::cssText(),
        this CL caches the String result.  When m_value is changed, the
        cached string is cleared.  This gives a good speedup on benchmarks
        which do a lot of CSS property gets, such as Peacekeeper.
        The processing cost should be negligible, since the strings are
        refcounted.  The memory cost is an additional 4 bytes per
        CSSPrimitiveValue, and the extended lifetime of the computed string
        (potentially, the same as the lifetime of the CSSPrimitiveValue).

        https://bugs.webkit.org/show_bug.cgi?id=36556

        Covered by fast/css/large-number-round-trip.html, and more.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::cleanup):
        (WebCore::CSSPrimitiveValue::cssText):
        * css/CSSPrimitiveValue.h:
2010-03-25  Stephen White  <senorblanco@chromium.org>

        Reviewed by Darin Adler.

        Added a test for CSSPrimitiveValue::cssText() string cacheing.

        https://bugs.webkit.org/show_bug.cgi?id=36556

        * fast/css/cssText-cache-expected.txt: Added.
        * fast/css/cssText-cache.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Qi Zhang <qi.2.zhang@nokia.com>
eric@webkit.org [Fri, 26 Mar 2010 12:58:06 +0000 (12:58 +0000)]
2010-03-26  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] fast/canvas/drawImage-with-negative-source-destination.html failed
        https://bugs.webkit.org/show_bug.cgi?id=35005

        Enable fast/canvas/drawImage-with-negative-source-destination.html

        * platform/qt/Skipped:
2010-03-26  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] fast/canvas/drawImage-with-negative-source-destination.html failed
        https://bugs.webkit.org/show_bug.cgi?id=35005

        To support negative width or height at context.drawImage

        * platform/graphics/qt/StillImageQt.cpp:
        (WebCore::StillImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Simon Hausmann.
tonikitoo@webkit.org [Fri, 26 Mar 2010 12:52:49 +0000 (12:52 +0000)]
Reviewed by Simon Hausmann.

Add an option to QtLauncher to enable/disable a QGLWidget as Viewport
of the QGraphicsView when the launcher is running on graphicsview mode.

[Qt] QtLauncher needs an option to Enable/Disable a QGLWidget as Viewport
https://bugs.webkit.org/show_bug.cgi?id=36270

* QtLauncher/QtLauncher.pro:
* QtLauncher/main.cpp:
(LauncherWindow::toggleQGLWidgetViewport):
(LauncherWindow::createChrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Mads Ager <ager@chromium.org>
ager@chromium.org [Fri, 26 Mar 2010 11:11:09 +0000 (11:11 +0000)]
2010-03-26  Mads Ager  <ager@chromium.org>

        Reviewed by Jeremy Orlow.

        Tweak Chromium test expectations
        https://bugs.webkit.org/show_bug.cgi?id=36651

        fast/js/large-expressions.html started failing on Linux in release
        mode occassionally.  Also fails on other platforms.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, removing websocket/tests/long-invalid-header.html from Chromium test_expe...
ukai@chromium.org [Fri, 26 Mar 2010 09:21:18 +0000 (09:21 +0000)]
Unreviewed, removing websocket/tests/long-invalid-header.html from Chromium test_expectations.txt

* platform/chromium/test_expectations.txt: remove websocket/tests/long-invalid-header.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-08 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 26 Mar 2010 08:58:45 +0000 (08:58 +0000)]
2010-03-08  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        [GStreamer] soften dependency on libsoup in the http src element
        https://bugs.webkit.org/show_bug.cgi?id=35864

        Replaced SoupURI calls with KURL and pause/resume internal soup
        messages only if the element is compiled for a port depending on
        libsoup.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webkit_web_src_init):
        (webKitWebSrcSetUri):
        (webKitWebSrcNeedDataMainCb):
        (webKitWebSrcEnoughDataMainCb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 26 Mar 2010 08:45:28 +0000 (08:45 +0000)]
2010-03-26  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [Chromium-Win] websocket_server.py failed to start
        https://bugs.webkit.org/show_bug.cgi?id=36586

        subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
        We don't need stdin, so use devnull as stdin.

        * Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Ilya Tikhonovsky <loislo@chromium.org>
pfeldman@chromium.org [Fri, 26 Mar 2010 08:05:08 +0000 (08:05 +0000)]
2010-03-25  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Shot record filter is implemented in Timeline Panel.
        https://bugs.webkit.org/show_bug.cgi?id=36606

        * English.lproj/localizedStrings.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype.get statusBarItems):
        (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
        (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelinePanel.prototype._addToRecordsWindow):
        (WebInspector.TimelineRecordGraphRow.prototype.update):
        (WebInspector.TimelinePanel.FormattedRecord.prototype.get _isLongEvent):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-26 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 26 Mar 2010 07:58:07 +0000 (07:58 +0000)]
2010-03-26  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Add TestNavigationController and TestWebWorker
        https://bugs.webkit.org/show_bug.cgi?id=36520

        Add LayoutTestController class, which is going to be used by
        DumpRenderTree Chromium port. These files are based on:
        - src/webkit/tools/test_shell/layout_test_controller.cc
        - src/webkit/tools/test_shell/layout_test_controller.h
        of Chromium rev.40492.

        * DumpRenderTree/chromium/LayoutTestController.cpp: Added.
        * DumpRenderTree/chromium/LayoutTestController.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSymbian build fix.
hausmann@webkit.org [Fri, 26 Mar 2010 07:55:51 +0000 (07:55 +0000)]
Symbian build fix.

[Qt] Updated the def file with new exports used by QtLauncher.

* symbian/eabi/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRollout r56609. It was accidental commit.
tkent@chromium.org [Fri, 26 Mar 2010 07:43:01 +0000 (07:43 +0000)]
Rollout r56609.  It was accidental commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-10-20 Mikhail Naganov <mnaganov@chromium.org>
tkent@chromium.org [Fri, 26 Mar 2010 07:34:44 +0000 (07:34 +0000)]
2009-10-20  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: populate child nodes before sorting them.

        https://bugs.webkit.org/show_bug.cgi?id=29673

        * inspector/front-end/BottomUpProfileDataGridTree.js:
        (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode.
        (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
        (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
        (WebInspector.BottomUpProfileDataGridNode.prototype._exclude):
        (WebInspector.BottomUpProfileDataGridNode.prototype._merge):
        (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
        (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
        * inspector/front-end/ProfileDataGridTree.js:
        (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses.
        (WebInspector.ProfileDataGridNode.prototype.get _parent):
        (WebInspector.ProfileDataGridNode.prototype._populate):
        * inspector/front-end/TopDownProfileDataGridTree.js:
        (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 26 Mar 2010 07:13:25 +0000 (07:13 +0000)]
2010-03-25  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Implement CSSStyleSelector::pseudoStyleForElement and use it in the InspectorDOMAgent.

        https://bugs.webkit.org/show_bug.cgi?id=36509

        This change provides pseudo elements information into the inspector styles sidebar pane.
        Changes applied:
        - CSSStyleSelector::pseudoStyleRulesForElement implemented. I changed the signature to accept
          PseudoId instead of a String since it better reflected the needs;
        - Accompanied elementStyle checks with m_collectRulesOnly checks;
        - Removed pseudoStyleRulesForElement usage from DOMWindow::getMatchedCSSRules. It was anyways
          returning 0, while I would need to convert String to PseudoId in order to leave the call in place;
        - Needed to introduce AFTER_LAST_INTERNAL_PSEUDOID marker const in RenderStyleConstants' PseudoId enum
        - InspectorDOMAgent is now iterating over all pseudo ids to get all styles (including internal ones).
        - Brushed up front-end code so that proper overriding took place locally within pseudo id categories.

        * English.lproj/localizedStrings.js:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::styleRulesForElement):
        (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        * css/CSSStyleSelector.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::getStyles):
        (WebCore::InspectorDOMAgent::buildObjectForAttributeStyles):
        (WebCore::InspectorDOMAgent::buildArrayForCSSRules):
        (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.update.callback):
        (WebInspector.StylesSidebarPane.prototype.update):
        (WebInspector.StylesSidebarPane.prototype._update):
        (WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
        (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.insertInheritedNodeSeparator):
        (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
        (WebInspector.StylesSidebarPane.prototype._markUsedProperties):
        (WebInspector.StylesSidebarPane.prototype._refreshSectionsForStyleRules):
        (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
        (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
        (WebInspector.StylesSidebarPane.prototype.addBlankSection):
        (WebInspector.StylesSidebarPane.prototype.removeSection):
        * inspector/front-end/inspector.css:
        (.styles-sidebar-separator):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::getMatchedCSSRules):
        * rendering/style/RenderStyleConstants.h:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate WebCoreSQLite3 to SQLite v3.6.12.
mrowe@apple.com [Fri, 26 Mar 2010 07:11:04 +0000 (07:11 +0000)]
Update WebCoreSQLite3 to SQLite v3.6.12.

Rubber-stamped by Dan Bernstein.

* WebCoreSQLite3/sqlite3.h:
* WebCoreSQLite3/sqlite3ext.h:
* libWebCoreSQLite3.a:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Charlie Reis <creis@chromium.org>
abarth@webkit.org [Fri, 26 Mar 2010 06:34:57 +0000 (06:34 +0000)]
2010-03-25  Charlie Reis  <creis@chromium.org>

        Reviewed by Adam Barth.

        onbeforeunload not called at window close + frame or iframe focused
        https://bugs.webkit.org/show_bug.cgi?id=27481

        Adds a layout test for bug 27481.  Requires calling shouldClose on
        the WebView, which is done with a new method on LayoutTestController.

        * fast/events/onbeforeunload-focused-iframe-expected.txt: Added.
        * fast/events/onbeforeunload-focused-iframe.html: Added.
        * fast/events/resources/onbeforeunload-focused-iframe-frame.html: Added.
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
2010-03-25  Charlie Reis  <creis@chromium.org>

        Reviewed by Adam Barth.

        onbeforeunload not called at window close + frame or iframe focused
        https://bugs.webkit.org/show_bug.cgi?id=27481

        Test: fast/events/onbeforeunload-focused-iframe.html

        Replaces initial manual tests with a layout test.

        * manual-tests/onbeforeunload-focused-iframe.html: Removed.
        * manual-tests/resources/focused-iframe.html: Removed.
2010-03-25  Charlie Reis  <creis@chromium.org>

        Reviewed by Adam Barth.

        onbeforeunload not called at window close + frame or iframe focused
        https://bugs.webkit.org/show_bug.cgi?id=27481

        Adds a callShouldCloseOnWebView method to LayoutTestController,
        to allow automated testing for bug 27481.

        * DumpRenderTree/LayoutTestController.cpp:
        (callShouldCloseOnWebViewCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::callShouldCloseOnWebView):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::callShouldCloseOnWebView):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::callShouldCloseOnWebView):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::callShouldCloseOnWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 26 Mar 2010 06:23:50 +0000 (06:23 +0000)]
2010-03-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        REGRESSION: plugins/netscape-construct.html and plugins/mouse-events-fixedpos.html failing on Snow Leopard Bot
        https://bugs.webkit.org/show_bug.cgi?id=36462

        Adding tests to the Skipped list per Alexey's recommendation
        until someone from Apple can update the version of Safari
        on the Snow Leopard bot.

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Eric Uhrhane <ericu@chromium.org>
eric@webkit.org [Fri, 26 Mar 2010 06:06:18 +0000 (06:06 +0000)]
2010-03-25  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        Missing lock in call to doneCreatingDatabase
        https://bugs.webkit.org/show_bug.cgi?id=36473

        Added new test storage/open-database-over-quota.html.

        * storage/open-database-over-quota.html: Added.
        * storage/open-database-over-quota-expected.txt: Added.
2010-03-25  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        Missing lock in call to doneCreatingDatabase
        https://bugs.webkit.org/show_bug.cgi?id=36473

        Added new test storage/open-database-over-quota.html.

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::canEstablishDatabase):  Added missing lock call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Tony Chang <tony@chromium.org>
eric@webkit.org [Fri, 26 Mar 2010 05:48:28 +0000 (05:48 +0000)]
2010-03-25  Tony Chang  <tony@chromium.org>

        Reviewed by David Levin.

        [chromium] correctly handle move drag operations
        https://bugs.webkit.org/show_bug.cgi?id=36484

        * platform/chromium/test_expectations.txt:
2010-03-25  Tony Chang  <tony@chromium.org>

        Reviewed by David Levin.

        [chromium] correctly handle move drag operations
        https://bugs.webkit.org/show_bug.cgi?id=36484

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::dragTargetDragEnter):
        (WebKit::WebViewImpl::dragTargetDragOver):
        (WebKit::WebViewImpl::dragTargetDragEnterOrOver): Combine common code into a helper method
            and properly mask against the drag effect.
        (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Fri, 26 Mar 2010 05:42:55 +0000 (05:42 +0000)]
2010-03-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add webkit-patch lkgr for finding last known good revision
        https://bugs.webkit.org/show_bug.cgi?id=36626

        This is rather slow for now because the command
        has to compute this information from the buildbot.
        A better long-term solution would be to have a server
        somewhere store a pre-computed LKGR and then any
        script (like webkit-patch) could just fetch it.

        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/tool/commands/queries.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 26 Mar 2010 05:38:47 +0000 (05:38 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move modified_changelogs (and friends) from scm to checkout
        https://bugs.webkit.org/show_bug.cgi?id=36636

        These functions know about ChangeLogs, which is forbidden knowledge in
        scm.py.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
        * Scripts/webkitpy/tool/steps/revertrevision.py:
        * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
        * Scripts/webkitpy/tool/steps/validatereviewer.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 26 Mar 2010 05:32:12 +0000 (05:32 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move apply_patch from scm to checkout
        https://bugs.webkit.org/show_bug.cgi?id=36635

        SCM shouldn't have any knowledge of WebKit scripts.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/applypatch.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 26 Mar 2010 04:48:05 +0000 (04:48 +0000)]
2010-03-25  Eric Seidel  <eric@webkit.org>

        Unreviewed build fix to un-break webkit-patch land.
        Test-case coming in follow-up commit.

        Move commit_message_for_this_commit from scm to checkout
        https://bugs.webkit.org/show_bug.cgi?id=36629

        * Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
ojan@chromium.org [Fri, 26 Mar 2010 04:40:40 +0000 (04:40 +0000)]
WebCore:
2010-03-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] REGRESSION: Some LayoutTests fail after r56567
        https://bugs.webkit.org/show_bug.cgi?id=36630

        Fix boolean logic goofup. This was a last minute code review
        change that didn't get tested on Windows before commit.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setIsDirectional):

LayoutTests:
2010-03-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] REGRESSION: Some LayoutTests fail after r56567
        https://bugs.webkit.org/show_bug.cgi?id=36630

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7728903> Support color bitmap fonts
mitz@apple.com [Fri, 26 Mar 2010 04:35:48 +0000 (04:35 +0000)]
<rdar://problem/7728903> Support color bitmap fonts

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/fonts/color-bitmap.html

* platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances): Added. Calls CGContextShowGlyphsWithAdvances()
or CTFontShowGlyphs() depending on whether the font is a color bitmap font.
(WebCore::Font::drawGlyphs): Use showGlyphsWithAdvances(). Don’t include the font’s matrix in
the context’s text matrix when drawing with a color bitmap font, because CTFontShowGlyphs()
factors it in.
* platform/graphics/mac/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData): Added m_isColorBitmapFont member
and initialized it in constructors.
(WebCore::FontPlatformData::isColorBitmapFont): Added this getter.
* platform/graphics/mac/FontPlatformDataMac.mm:
(WebCore::FontPlatformData::FontPlatformData): Initialize m_isColorBitmapFont.
(WebCore::FontPlatformData::operator=): Copy m_isColorBitmapFont.
(WebCore::FontPlatformData::setFont): Set m_isColorBitmapFont.

WebKitTools:

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf
and ColorBits-A.png.
* DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png.
* DumpRenderTree/fonts/ColorBits.ttf: Added.
* DumpRenderTree/mac/DumpRenderTree.mm:
(activateFonts): Activate ColorBits.ttf.

LayoutTests:

* platform/mac-leopard/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-tiger/Skipped:
* platform/mac/fonts/color-bitmap-expected.checksum: Added.
* platform/mac/fonts/color-bitmap-expected.png: Added.
* platform/mac/fonts/color-bitmap-expected.txt: Added.
* platform/mac/fonts/color-bitmap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, another attempt to unblock Chromium Win test bot.
dimich@chromium.org [Fri, 26 Mar 2010 04:28:57 +0000 (04:28 +0000)]
Unreviewed, another attempt to unblock Chromium Win test bot.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, removing stale expectation file for Chromium.
dimich@chromium.org [Fri, 26 Mar 2010 04:23:01 +0000 (04:23 +0000)]
Unreviewed, removing stale expectation file for Chromium.

The test was updated by http://trac.webkit.org/changeset/56506 to a script test.

* platform/chromium-win/editing/inserting/6633727-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, temporarily disabling test on Chromium bots.
dimich@chromium.org [Fri, 26 Mar 2010 04:13:20 +0000 (04:13 +0000)]
Unreviewed, temporarily disabling test on Chromium bots.

http://crbug.com/39423

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove a printf that was causing commit-log-editor to spew the name of the editor
mrowe@apple.com [Fri, 26 Mar 2010 03:04:53 +0000 (03:04 +0000)]
Remove a printf that was causing commit-log-editor to spew the name of the editor
to the terminal many times during a commit.

* Scripts/commit-log-editor:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 26 Mar 2010 03:04:21 +0000 (03:04 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move commit_message_for_this_commit from scm to checkout
        https://bugs.webkit.org/show_bug.cgi?id=36629

        This function requires knowledge of ChangeLogs, but scm shouldn't know
        about ChangeLogs.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
        * Scripts/webkitpy/tool/steps/commit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 26 Mar 2010 02:46:39 +0000 (02:46 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Implement allow-top-navigation for HTML5 sandbox attribute
        https://bugs.webkit.org/show_bug.cgi?id=36549

        Test various cases relating to navigating top level frames and the
        allow-top-navigation directive.  This feature is tricky to test
        exhaustively because there are a lot of permutations.

        * fast/frames/resources/fail-and-notify-done.html: Added.
        * fast/frames/resources/navigate-top-by-constant-name-to-pass.html: Added.
        * fast/frames/resources/navigate-top-by-constant-name2-to-pass.html: Added.
        * fast/frames/resources/navigate-top-by-name-to-fail.html: Added.
        * fast/frames/resources/navigate-top-by-name-to-pass.html: Added.
        * fast/frames/resources/navigate-top-to-fail.html: Added.
        * fast/frames/resources/navigate-top-to-pass.html: Added.
        * fast/frames/resources/pass-and-notify-done.html: Added.
        * fast/frames/sandboxed-iframe-navigation-top-by-constant-name-expected.txt: Added.
        * fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html: Added.
        * fast/frames/sandboxed-iframe-navigation-top-by-constant-name2-expected.txt: Added.
        * fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html: Added.
        * fast/frames/sandboxed-iframe-navigation-top-by-name-denied-expected.txt: Added.
        * fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html: Added.
        * fast/frames/sandboxed-iframe-navigation-top-by-name-expected.txt: Added.
        * fast/frames/sandboxed-iframe-navigation-top-by-name.html: Added.
        * fast/frames/sandboxed-iframe-navigation-top-denied-expected.txt: Added.
        * fast/frames/sandboxed-iframe-navigation-top-denied.html: Added.
        * fast/frames/sandboxed-iframe-navigation-top-expected.txt: Added.
        * fast/frames/sandboxed-iframe-navigation-top.html: Added.
2010-03-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Implement allow-top-navigation for HTML5 sandbox attribute
        https://bugs.webkit.org/show_bug.cgi?id=36549

        Tests: fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html
               fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html
               fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html
               fast/frames/sandboxed-iframe-navigation-top-by-name.html
               fast/frames/sandboxed-iframe-navigation-top-denied.html
               fast/frames/sandboxed-iframe-navigation-top.html

        * bindings/generic/BindingDOMWindow.h:
        (WebCore::::createWindow):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::createWindow):
          Moved the security check to FrameLoader because we need to allow
          window.open navigation to succeed sometimes when the
          SandboxNavigation bit is set.
        * html/HTMLIFrameElement.cpp:
        (WebCore::parseSandboxAttribute):
          Added allow-top-navigation to the parser.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createWindow):
          The SandboxNavigation check now occurs after we search for the frame
          by name.  Notice that the named frame navigation case is caught by
          the generic navigation access check.
        (WebCore::FrameLoader::shouldAllowNavigation):
          Update the navigation access check to allow navigating of top unless
          it's forbidden.
        * loader/FrameLoaderTypes.h:
          Introduce a bit for SandboxedTopNavigation.
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe.
ap@apple.com [Fri, 26 Mar 2010 02:32:36 +0000 (02:32 +0000)]
    Reviewed by Mark Rowe.

        * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): Re-fetch host proxy in
        a way that works in a function that doesn't have a pluginID argument for some reason.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 26 Mar 2010 02:21:07 +0000 (02:21 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION: webkit-patch land can't land "rubber-stamped" patches
        https://bugs.webkit.org/show_bug.cgi?id=36582

        Allow a "-" in rubber stamped.

        * Scripts/webkitpy/tool/steps/validatereviewer.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, Chromium build fix.
dumi@chromium.org [Fri, 26 Mar 2010 02:12:21 +0000 (02:12 +0000)]
Unreviewed, Chromium build fix.

WebCore:

V8CustomVoidCallback should not check if a return value is a
boolean. It should only convert the value to a boolean.

* bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):

LayoutTests:

Update the expectations for statement-error-callback.html for Chromium.

* platform/chromium-mac/storage/statement-error-callback-expected.txt:
* platform/chromium-win/storage/statement-error-callback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert "2010-03-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>"
dimich@chromium.org [Fri, 26 Mar 2010 01:48:26 +0000 (01:48 +0000)]
Revert "2010-03-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>"

This reverts commit 2a3b308efc33f4829fe9717d93a4b245d3b25f6d.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 26 Mar 2010 01:26:44 +0000 (01:26 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Fix some copyright lines to remove extraneous comma and
        python directive.

        * Scripts/webkitpy/tool/bot/patchcollection.py:
        * Scripts/webkitpy/tool/bot/patchcollection_unittest.py:
        * Scripts/webkitpy/tool/bot/queueengine.py:
        * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/sheriffbot.py:
        * Scripts/webkitpy/tool/comments.py:
        * Scripts/webkitpy/tool/grammar.py:
        * Scripts/webkitpy/tool/multicommandtool.py:
        * Scripts/webkitpy/tool/multicommandtool_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Fri, 26 Mar 2010 01:04:04 +0000 (01:04 +0000)]
2010-03-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        Fix build if NPAPI support is disabled
        https://bugs.webkit.org/show_bug.cgi?id=36621

        No new tests, this is a build fix.

        * plugins/PluginView.cpp: Guard getValueStatic() with
        NETSCAPE_PLUGIN_API
        (WebCore::PluginView::getValue):
        * plugins/PluginView.h: Guard getValue() with NETSCAPE_PLUGIN_API
        * plugins/PluginViewNone.cpp: Guard platformGetValue() and
        platformGetValueStatic with NETSCAPE_PLUGIN_API;
        Guard privateBrowsingStateChanged() and setJavaScriptPaused() with
        PLATFORM(MAC)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed, update pixel results for Chromium bots.
dimich@chromium.org [Fri, 26 Mar 2010 00:53:08 +0000 (00:53 +0000)]
Not reviewed, update pixel results for Chromium bots.

The rendering of these tests was changed by http://trac.webkit.org/changeset/56507.
Also updated Chromium's test_expectations.txt.

* platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum:
* platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png:
* platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
* platform/chromium-linux/plugins/embed-attributes-style-expected.png:
* platform/chromium/test_expectations.txt: Use BUG_WKXXXX instead of WKXXXX notation to appease validation on the bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 26 Mar 2010 00:46:55 +0000 (00:46 +0000)]
2010-03-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler, Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=36631
        Allow the test plugin to run scripts in response to NPP_SetWindow calls

        Hook up the ability for the TestNetscapePlugIn to run JavaScript in
        response to NPP_SetWindow.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (pluginAllocate):
        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (NPP_New):
        (NPP_Destroy):
        (NPP_SetWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, fixing Chromium test bots.
dimich@chromium.org [Fri, 26 Mar 2010 00:26:26 +0000 (00:26 +0000)]
Unreviewed, fixing Chromium test bots.

[chromium] REGRESSION: Some LayoutTests fail after r56567
https://bugs.webkit.org/show_bug.cgi?id=36630

* platform/chromium/test_expectations.txt: Update expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Fri, 26 Mar 2010 00:24:34 +0000 (00:24 +0000)]
2010-03-25  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QtLauncher crashes on Mac OS and Linux when exiting with QGraphicsView mode enabled
        https://bugs.webkit.org/show_bug.cgi?id=35251

        Followed the way QWebView registers for the signal QWebPage::destroyed(), to prevent
        QGraphicsWebView from referencing QWebPage after it was deleted.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::_q_pageDestroyed):
        (QGraphicsWebView::setPage):
        * Api/qgraphicswebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Drew Wilson <atwilson@chromium.org>
eric@webkit.org [Fri, 26 Mar 2010 00:06:31 +0000 (00:06 +0000)]
2010-03-25  Drew Wilson  <atwilson@chromium.org>

        Reviewed by Nate Chapin.

        [v8] Error in getScriptExecutionContext() when worker context is terminating.
        https://bugs.webkit.org/show_bug.cgi?id=36565

        Removed WorkerScriptExecutionProxy::retrieve() and added WorkerScriptController::controllerForContext(). This allows
        callers to differentiate between "the current context is shutting down" vs "the current context is not a worker context".

        Test: Existing worker tests suffice.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getConstructor):
        Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
        * bindings/v8/V8Utilities.cpp:
        (WebCore::getScriptExecutionContext):
        Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        Removed WorkerScriptExecutionProxy::retrieve().
        * bindings/v8/WorkerContextExecutionProxy.h:
        Removed WorkerScriptExecutionProxy::retrieve().
        * bindings/v8/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::controllerForContext):
        Added helper function to get the WorkerScriptController for the current context.
        * bindings/v8/WorkerScriptController.h:
        Added declaration for controllerForContext().
2010-03-25  Drew Wilson  <atwilson@chromium.org>

        Reviewed by Nate Chapin.

        [v8] Error in getScriptExecutionContext() when worker context is terminating
        https://bugs.webkit.org/show_bug.cgi?id=36565

        Test: Existing worker tests suffice.

        * src/WebWorkerClientImpl.cpp:
        (WebKit::WebWorkerClientImpl::createWorkerContextProxy):
        Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Jeremy Orlow <jorlow@chromium.org>
eric@webkit.org [Thu, 25 Mar 2010 23:48:30 +0000 (23:48 +0000)]
2010-03-25  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Add an ASSERT macro to the Chromium WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=36545

        * WebKit.gyp:  Add WebCommon.cpp
        * public/WebCommon.h:  Add the Macro.
        * public/WebPrivatePtr.h:
        (WebKit::WebPrivatePtr::~WebPrivatePtr):  Verify the pointer is now 0.
        * src/WebCommon.cpp: Added.
        (WebKit::failedAssertion): Calls the WTF assert function and then crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 25 Mar 2010 23:33:44 +0000 (23:33 +0000)]
2010-03-25  Gustavo Noronha Silva  <gns@gnome.org>

        Needs a "LinuxEditingBehavior", perhaps with a better name
        https://bugs.webkit.org/show_bug.cgi?id=36627

        Skipping tests that started failing after 56567. We need to figure
        out a proper fix, that may involve adding a new editing behavior
        for our platform.

        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Thu, 25 Mar 2010 23:30:01 +0000 (23:30 +0000)]
2010-03-25  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] QWebFrame::pageChanged() signal is not documented
        https://bugs.webkit.org/show_bug.cgi?id=36609

        * Api/qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Simon Hausmann <simon.hausmann@nokia.com>
eric@webkit.org [Thu, 25 Mar 2010 23:12:05 +0000 (23:12 +0000)]
2010-03-25  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix the package build on Maemo 5

        https://bugs.webkit.org/show_bug.cgi?id=36607

        Always embed the stylesheet for the no-listbox rendering. This way it'll be
        included in the generated files for the package generation.

        * WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 25 Mar 2010 23:09:32 +0000 (23:09 +0000)]
2010-03-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed, build fix.

        [Qt] Fix QtLauncher guards.

        * QtLauncher/main.cpp:
        (LauncherWindow::showFPS):
        (LauncherWindow::updateFPS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Reinout van Schouwen <reinouts@gnome.org>
kov@webkit.org [Thu, 25 Mar 2010 22:49:53 +0000 (22:49 +0000)]
2010-03-25  Reinout van Schouwen  <reinouts@gnome.org>

        Reviewed by Gustavo Noronha.

        Updated Dutch translation
        https://bugs.webkit.org/show_bug.cgi?id=36432

        * nl.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 25 Mar 2010 22:38:31 +0000 (22:38 +0000)]
2010-03-25  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, expectations tweak.

        Reorganized and updated comments for media test expectations.

        * platform/chromium/test_expectations.txt: Tweaked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Changing the V8 and JSC implementations of
dumi@chromium.org [Thu, 25 Mar 2010 22:29:39 +0000 (22:29 +0000)]
WebCore: Changing the V8 and JSC implementations of
SQLStatementErrorCallback to interpret as false all results that
could be converted to a false boolean. Pretty much a revert of
r54981.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=36569

* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):
* bindings/v8/custom/V8CustomVoidCallback.h:

LayoutTests: Updating the test to conform to the latest spec changes.

Reviewed by Dimitri Glazkov.

* storage/statement-error-callback-expected.txt:
* storage/statement-error-callback.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Jochen Eisinger <jochen@chromium.org>
eric@webkit.org [Thu, 25 Mar 2010 22:25:42 +0000 (22:25 +0000)]
2010-03-25  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Jeremy Orlow.

        Remove ASSERT(isMainThread()) which is violated for workers and not necessary at this point.
        https://bugs.webkit.org/show_bug.cgi?id=36614

        * src/DatabaseObserver.cpp:
        (WebCore::DatabaseObserver::canEstablishDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, fix Chromium tests.
dimich@chromium.org [Thu, 25 Mar 2010 21:58:00 +0000 (21:58 +0000)]
Unreviewed, fix Chromium tests.

Recent http://trac.webkit.org/changeset/56489 made all urls in Chromium that
have unspecified port to return invalidPortNumber from KURL::port().

* platform/KURLGoogle.cpp: Return 0 for unspecified ports, mimic WebKit KURL behavior for invalid ports.
(WebCore::KURL::port):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 25 Mar 2010 21:39:29 +0000 (21:39 +0000)]
2010-03-25  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        This is a follow up of:
        https://bugs.webkit.org/show_bug.cgi?id=30055
        Bad DOM performance in large SVG files

        Just save and restore the GraphicsContext, if we realy modify it.
        (Cairo)Path::contains checks if a point is in the boundingBox
        as a heuristic. The intention was to make the process faster for
        points outside of this rect, but it rather causes the
        opposite.

        No new test cases added. No change in functionality.

        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::contains):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 25 Mar 2010 21:33:19 +0000 (21:33 +0000)]
2010-03-25  Simon Fraser  <simon.fraser@apple.com>

        Revert r56565 which was based on an incorrect premise.

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::clearRenderer):
        (WebCore::CompositeAnimation::updateKeyframeAnimations):
        (WebCore::CompositeAnimation::getAnimatedStyle):
        (WebCore::CompositeAnimation::setAnimating):
        (WebCore::CompositeAnimation::timeToNextService):
        (WebCore::CompositeAnimation::getAnimationForProperty):
        (WebCore::CompositeAnimation::suspendAnimations):
        (WebCore::CompositeAnimation::resumeAnimations):
        (WebCore::CompositeAnimation::isAnimatingProperty):
        (WebCore::CompositeAnimation::pauseAnimationAtTime):
        (WebCore::CompositeAnimation::numberOfActiveAnimations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 25 Mar 2010 20:21:45 +0000 (20:21 +0000)]
2010-03-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by David Levin.

        mouse-based selections are always directional on Window/Linux
        https://bugs.webkit.org/show_bug.cgi?id=25195

        The tests are modified to expect different things for Win/Linux vs. Mac.

        * editing/selection/5195166-1.html:
        * editing/selection/extend-after-mouse-selection.html:
        * editing/selection/extend-selection-after-double-click-expected.txt:
        * editing/selection/extend-selection-after-double-click.html:
        * platform/chromium-linux/editing/selection/5195166-1-expected.checksum: Removed.
        * platform/chromium-linux/editing/selection/5195166-1-expected.png: Removed.
        * platform/chromium-win/editing/selection/5195166-1-expected.checksum: Removed.
        * platform/chromium-win/editing/selection/5195166-1-expected.png: Removed.
        * platform/chromium-win/editing/selection/5195166-1-expected.txt: Removed.
        * platform/mac/editing/selection/5195166-1-expected.checksum: Removed.
        * platform/mac/editing/selection/5195166-1-expected.png: Removed.
        * platform/mac/editing/selection/5195166-1-expected.txt:
        * platform/qt/editing/selection/5195166-1-expected.txt: Removed.
        * platform/win/editing/selection/extend-after-mouse-selection-expected.txt:
2010-03-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by David Levin.

        mouse-based selections are always directional on Windows/Linux
        https://bugs.webkit.org/show_bug.cgi?id=25195

        Change m_lastChangeWasHorizontalExtension to m_isDirectional
        and make m_isDirectional always be true for Windows/Linux.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::SelectionController):
        (WebCore::SelectionController::setSelection):
        (WebCore::SelectionController::setIsDirectional):
        (WebCore::SelectionController::willBeModified):
        When double-clicking, the base/extent will be in the middle
        of the selection instead of the start/end of it. Changed to
        maintain that modifications after double-click still move the
        start/end of the selection, not the base/extent.
        (WebCore::SelectionController::modify):
        * editing/SelectionController.h:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        (WebCore::EventHandler::updateSelectionForMouseDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 25 Mar 2010 20:20:37 +0000 (20:20 +0000)]
2010-03-25  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled.

        https://bugs.webkit.org/show_bug.cgi?id=36610

        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (shouldEnableDeveloperExtras):
        (runTest):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setJavaScriptProfilingEnabled):
        (LayoutTestController::setDeveloperExtrasEnabled):
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (shouldEnableDeveloperExtras):
        (runTest):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setJavaScriptProfilingEnabled):
        (LayoutTestController::setDeveloperExtrasEnabled):
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::shouldEnableDeveloperExtras):
        (WebCore::DumpRenderTree::open):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::closeWebInspector):
        (LayoutTestController::setDeveloperExtrasEnabled):
        (LayoutTestController::showWebInspector):
        (LayoutTestController::setJavaScriptProfilingEnabled):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (shouldEnableDeveloperExtras):
        (runTest):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setJavaScriptProfilingEnabled):
        (LayoutTestController::setDeveloperExtrasEnabled):
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 25 Mar 2010 19:57:55 +0000 (19:57 +0000)]
2010-03-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Carlson.

        Make calls to m_keyframeAnimations.checkConsistency() debug-only
        https://bugs.webkit.org/show_bug.cgi?id=36555

        Remove lots of calls to m_keyframeAnimations.checkConsistency(); which were left after some earlier
        debugging. Leave one in CompositeAnimation::animate() to catch any future issues, which is OK since
        these calls are no-ops in release builds.

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::clearRenderer):
        (WebCore::CompositeAnimation::updateKeyframeAnimations):
        (WebCore::CompositeAnimation::getAnimatedStyle):
        (WebCore::CompositeAnimation::setAnimating):
        (WebCore::CompositeAnimation::timeToNextService):
        (WebCore::CompositeAnimation::getAnimationForProperty):
        (WebCore::CompositeAnimation::suspendAnimations):
        (WebCore::CompositeAnimation::resumeAnimations):
        (WebCore::CompositeAnimation::isAnimatingProperty):
        (WebCore::CompositeAnimation::pauseAnimationAtTime):
        (WebCore::CompositeAnimation::numberOfActiveAnimations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 25 Mar 2010 19:07:59 +0000 (19:07 +0000)]
2010-03-25  Simon Fraser  <simon.fraser@apple.com>

        Build fix: no review.

        Another c_str() -> data().

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::enumerate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* profiler/ProfileGenerator.cpp:
barraclough@apple.com [Thu, 25 Mar 2010 18:58:17 +0000 (18:58 +0000)]
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):

Reviewed by NOBODY (build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 25 Mar 2010 18:48:50 +0000 (18:48 +0000)]
2010-03-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=36557
        Animations use the wrong timing-function sometimes

        Fix an issue where animations picked the wrong style for their "unanimated" value.

        Previously, the "unanimated" style was considered to be the style before the animation
        was applied. This caused us to pick up stale values for animation timing functions, for
        blending when a property is missing from the first keyframe, and for resuming transitions
        once an animation ends.

        Instead, we need to use the "current" style, which is the one that causes the animation
        to kick off.

        Tests: animations/longhand-timing-function.html
               animations/transition-and-animation-3.html
               animations/unanimated-style.html

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::updateKeyframeAnimations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed expected file fix.
ossy@webkit.org [Thu, 25 Mar 2010 18:29:20 +0000 (18:29 +0000)]
Unreviewed expected file fix.

* platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Needless newline removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 36611 - Cleanup JSC::CString
barraclough@apple.com [Thu, 25 Mar 2010 18:20:17 +0000 (18:20 +0000)]
Bug 36611 - Cleanup JSC::CString
Rename CString::c_str() -> CString::data(), CString::size() -> CString::length(),
remove UString::getCString() (all uses are wrong, should use UString::UTF8String()).

Reviewed by Geoff Garen.

JavaScriptCore:

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
* jsc.cpp:
(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):
* profiler/CallIdentifier.h:
(JSC::CallIdentifier::c_str):
* profiler/Profile.cpp:
(JSC::Profile::debugPrintDataSampleStyle):
* profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):
* runtime/DateConversion.cpp:
(JSC::parseDate):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::globalFuncJSCPrint):
* runtime/UString.cpp:
(JSC::operator==):
(JSC::UString::toDouble):
* runtime/UString.h:
(JSC::CString::length):
(JSC::CString::data):

WebCore:

* bridge/NP_jsobject.cpp:
(_NPN_Enumerate):
* bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
* bridge/jni/jsc/JNIBridgeJSC.cpp:
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::UTF8String):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Jakub Wieczorek <jwieczorek@webkit.org>
jwieczorek@webkit.org [Thu, 25 Mar 2010 18:03:53 +0000 (18:03 +0000)]
2010-03-25  Jakub Wieczorek  <jwieczorek@webkit.org>

        Rubber-stamped by Tor Arne Vestbø.

        [Qt] Update test results after r56555.
        https://bugs.webkit.org/show_bug.cgi?id=36413

        * platform/qt/fast/forms/basic-inputs-expected.txt:
        * platform/qt/fast/forms/isindex-placeholder-expected.txt:
        * platform/qt/fast/forms/text-style-color-expected.txt:
        * platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
        * platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
        * platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe.
ap@apple.com [Thu, 25 Mar 2010 18:00:20 +0000 (18:00 +0000)]
    Reviewed by Mark Rowe.

        Correctness fix after r56493.

        * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): We still need to update
        our hostProxy reference, even though we didn't use to have instanceProxy. Nothing guarantees
        that the host proxy won't go away while the open panel is up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Thu, 25 Mar 2010 17:51:19 +0000 (17:51 +0000)]
2010-03-25  Antonio Gomes  <tonikitoo@webkit.org>

    Unreview expectation result fix.

    After http://trac.webkit.org/changeset/56547, the test needs new (and proper)
    results.

    * platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 25 Mar 2010 17:39:27 +0000 (17:39 +0000)]
2010-03-25  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by David Levin.

        Asking Questions Page Grammar Fixes
        https://bugs.webkit.org/show_bug.cgi?id=36608

        * asking_questions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Jakub Wieczorek <jwieczorek@webkit.org>
jwieczorek@webkit.org [Thu, 25 Mar 2010 17:30:23 +0000 (17:30 +0000)]
2010-03-25  Jakub Wieczorek  <jwieczorek@webkit.org>

        Reviewed by Eric Seidel.

        [Qt] RenderTheme: fix size adjustment for text fields
        https://bugs.webkit.org/show_bug.cgi?id=36413

        Update test results after RenderTheme changes.

        * platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
        * platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
        * platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:
2010-03-25  Jakub Wieczorek  <jwieczorek@webkit.org>

        Reviewed by Eric Seidel.

        [Qt] RenderTheme: fix size adjustment for text fields
        https://bugs.webkit.org/show_bug.cgi?id=36413

        To match other ports, remove the hardcoded dimensions for text fields so that
        the default ones from WebCore can be used.
        Properly apply the correct padding to text areas - this fixes their appearance
        with the Oxygen style.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::computeSizeBasedOnStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 17:21:11 +0000 (17:21 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Rubber stamped by Eric Seidel.

        Tweaks to sheriffbot to improve latency by keeping the working copy up
        to date even when there's no build break.  Also, officially move
        sheriffbot to #webkit.

        (Also teach ValidateReviewer to understand rubber stamps.)

        * Scripts/webkitpy/common/net/irc/ircbot.py:
        * Scripts/webkitpy/tool/commands/sheriffbot.py:
        * Scripts/webkitpy/tool/steps/validatereviewer.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot displaying FPS info on the terminal. On S60 and Maemo the Window title will be...
tonikitoo@webkit.org [Thu, 25 Mar 2010 17:18:07 +0000 (17:18 +0000)]
Not displaying FPS info on the terminal. On S60 and Maemo the Window title will be used and Status bar will used on desktop.

Reviewed by Simon Hausmann.
Patch by Jesus Palencia <jesus.palencia@openbossa.org>

[Qt] QtLauncher's FPS info should not be displayed on the terminal
https://bugs.webkit.org/show_bug.cgi?id=36244

* QtLauncher/main.cpp:
(LauncherWindow::initializeView):
(LauncherWindow::showFPS):
(LauncherWindow::updateFPS):
* QtLauncher/webview.cpp:
(WebViewGraphicsBased::setFrameRateMeasurementEnabled):
(WebViewGraphicsBased::updateFrameRate):
* QtLauncher/webview.h:
(WebViewGraphicsBased::frameRateMeasurementEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Implement ChromeClient::windowResizerRect()
vestbo@webkit.org [Thu, 25 Mar 2010 16:42:45 +0000 (16:42 +0000)]
[Qt] Implement ChromeClient::windowResizerRect()

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=21300

We assume the resize corner to be in the lower right corner of
the window and having the width and height of the scrollbars.

The helper function geometryRelativeToOwnerWidget() in the page
client is used to clip the resize rect to the actual size of the
viewport, not the size of the QGraphicsView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-25 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 25 Mar 2010 16:31:54 +0000 (16:31 +0000)]
2010-03-25  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        New Asking Questions Page is not Valid HTML5
        https://bugs.webkit.org/show_bug.cgi?id=36605

        * asking_questions.html: fixed issues raised by the validator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt][GTK] http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length...
jchaffraix@webkit.org [Thu, 25 Mar 2010 16:18:19 +0000 (16:18 +0000)]
[Qt][GTK] http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html
fails after r56394
https://bugs.webkit.org/show_bug.cgi?id=36531

Reviewed by Alexey Proskuryakov.

The test was assuming that we would receive 3 progress events which may not be the case anymore
due to the event throttling added in r56394.

* http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Removed
the counting as it belonged to the original version of the test and instead use the position
to determine when to reset the XHR.

* platform/gtk/Skipped:
* platform/qt/Skipped:
Removed the test from the Skipped lists now that it should pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56550 268f45cc-cd09-0410-ab3c-d52691b4dbfc