WebKit-https.git
10 years ago2011-01-25 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 26 Jan 2011 01:17:17 +0000 (01:17 +0000)]
2011-01-25  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Move main CMakeLists.txt into Source directory
        https://bugs.webkit.org/show_bug.cgi?id=52888

        * CMakeLists.txt: Removed.
        * Source/CMakeLists.txt: Copied from CMakeLists.txt.
        * Source/cmakeconfig.h.cmake: Copied from cmakeconfig.h.cmake.
        * cmakeconfig.h.cmake: Removed.
2011-01-25  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Move main CMakeLists.txt into Source directory
        https://bugs.webkit.org/show_bug.cgi?id=52888

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 26 Jan 2011 00:50:34 +0000 (00:50 +0000)]
2011-01-25  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Improve label text in submit-to-ews
        https://bugs.webkit.org/show_bug.cgi?id=53130

        * QueueStatusServer/templates/submittoews.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 26 Jan 2011 00:36:39 +0000 (00:36 +0000)]
2011-01-25  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Adam Roben.

        Expose WebGL flag set/get in WK2
        https://bugs.webkit.org/show_bug.cgi?id=53096

        * Shared/WebPreferencesStore.h:
        * UIProcess/API/C/WKPreferences.cpp:
        (WKPreferencesSetWebGLEnabled):
        (WKPreferencesGetWebGLEnabled):
        * UIProcess/API/C/WKPreferencesPrivate.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 26 Jan 2011 00:18:06 +0000 (00:18 +0000)]
2011-01-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Add and implement LayerTreeHost::scheduleLayerFlush
        https://bugs.webkit.org/show_bug.cgi?id=53135

        * WebKit2.xcodeproj/project.pbxproj:
        Add LayerTreeHostMac.mm.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::scheduleCompositingLayerSync):
        Call LayerTreeHost::scheduleLayerFlush.

        * WebProcess/WebPage/LayerTreeHost.cpp:
        (WebKit::LayerTreeHost::~LayerTreeHost):
        Call platformInvalidate().

        (WebKit::LayerTreeHost::flushPendingLayerChanges):
        Rename from syncCompositingLayers.

        * WebProcess/WebPage/mac/LayerTreeHostMac.mm: Added.
        (WebKit::LayerTreeHost::scheduleLayerFlush):
        Create a run loop observer if needed. This code is copied from LayerBackedDrawingAreaMac.mm

        (WebKit::LayerTreeHost::platformInvalidate):
        Invalidate the run loop observer.

        (WebKit::LayerTreeHost::flushPendingLayerChangesRunLoopObserverCallback):
        Call flushPendingChanges() and remove the run loop observer if it succeeded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Cris Neckar <cdn@chromium.org>
inferno@chromium.org [Wed, 26 Jan 2011 00:10:34 +0000 (00:10 +0000)]
2011-01-25  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Test for crash when a window's location changes before creating an object URL.
        https://bugs.webkit.org/show_bug.cgi?id=53038

        * fast/dom/window-domurl-crash-expected.txt: Added.
        * fast/dom/window-domurl-crash.html: Added.
2011-01-25  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Add a hashset of DOMURLs to ScriptExecutionContext to track back references.
        https://bugs.webkit.org/show_bug.cgi?id=53038

        Test: fast/dom/window-domurl-crash.html

        * dom/ScriptExecutionContext.cpp:
        (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
        (WebCore::ScriptExecutionContext::createdDomUrl):
        (WebCore::ScriptExecutionContext::destroyedDomUrl):
        * dom/ScriptExecutionContext.h:
        (WebCore::ScriptExecutionContext::domUrls):
        * html/DOMURL.cpp:
        (WebCore::DOMURL::DOMURL):
        (WebCore::DOMURL::~DOMURL):
        (WebCore::DOMURL::contextDestroyed):
        * html/DOMURL.h:
        (WebCore::DOMURL::scriptExecutionContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows Production build fix
aroben@apple.com [Tue, 25 Jan 2011 23:46:21 +0000 (23:46 +0000)]
Windows Production build fix

Reviewed by Steve Falkenburg.

* JavaScriptCore.vcproj/JavaScriptCore.make: Set BUILDSTYLE to Release_PGO at the very start
of the file so that ConfigurationBuildDir takes that into account. Also set it the right way
(by redefining the macro) rather than the wrong way (by modifying the environment variable).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 25 Jan 2011 23:40:57 +0000 (23:40 +0000)]
2011-01-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Simon Fraser.

        Add LayerTreeHost class
        https://bugs.webkit.org/show_bug.cgi?id=53132

        * WebKit2.xcodeproj/project.pbxproj:
        Add LayerTreeHost files.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::DrawingAreaImpl):
        Initialize m_layerTreeHost.

        (WebKit::DrawingAreaImpl::setRootCompositingLayer):
        Call the m_layerTreeHost.

        * WebProcess/WebPage/LayerTreeHost.cpp: Added.
        (WebKit::LayerTreeHost::attachRootCompositingLayer):
        (WebKit::LayerTreeHost::detachRootCompositingLayer):
        Add stubbed out functions.

        (WebKit::LayerTreeHost::syncCompositingLayers):
        Sync the compositing layers in the main frame.

        * WebProcess/WebPage/LayerTreeHost.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=52983
antti@apple.com [Tue, 25 Jan 2011 23:31:18 +0000 (23:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=52983
Eliminate m_tagHistory pointer from CSSSelector

Reviewed by Darin Adler.

Keep the component selectors in the array in CSSSelectorList instead
of maintaining a linked list between them. This allows eliminating
m_tagHistory pointer, shrinking CSSSelector by 25% (selection performance
seems to improve some too due to better locality).

* WebCore.xcodeproj/project.pbxproj:

    Make CSSSelector.h a private header.

* css/CSSGrammar.y:

    Use CSSParserSelector during parsing to keep the tag history in
    a linked list. This is flattened to an array after parsing.
    Use accessors for setting selector values.
    Use OwnPtr in selector vector.

* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::CSSPageRule):
* css/CSSPageRule.h:
(WebCore::CSSPageRule::create):

    Simplify.

* css/CSSParser.cpp:
(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::createFloatingSelector):
(WebCore::CSSParser::sinkFloatingSelector):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::updateSpecifiersWithElementName):
(WebCore::CSSParser::createPageRule):
* css/CSSParser.h:
(WebCore::CSSParser::reusableSelectorVector):

    CSSSelector -> CSSParserSelector.
    Use OwnPtr in selector vector.

* css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::CSSParserSelector):
(WebCore::CSSParserSelector::~CSSParserSelector):
* css/CSSParserValues.h:
(WebCore::CSSParserSelector::releaseSelector):
(WebCore::CSSParserSelector::setTag):
(WebCore::CSSParserSelector::setValue):
(WebCore::CSSParserSelector::setAttribute):
(WebCore::CSSParserSelector::setArgument):
(WebCore::CSSParserSelector::setSimpleSelector):
(WebCore::CSSParserSelector::setMatch):
(WebCore::CSSParserSelector::setRelation):
(WebCore::CSSParserSelector::setForPage):
(WebCore::CSSParserSelector::pseudoType):
(WebCore::CSSParserSelector::isUnknownPseudoElement):
(WebCore::CSSParserSelector::isSimple):
(WebCore::CSSParserSelector::tagHistory):
(WebCore::CSSParserSelector::setTagHistory):

    Linked list used during parsing.
    Avoid recursive destruction.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::operator==):
(WebCore::CSSSelector::selectorText):
(WebCore::CSSSelector::setSimpleSelector):
* css/CSSSelector.h:
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagHistory):
(WebCore::CSSSelector::tag):
(WebCore::CSSSelector::value):
(WebCore::CSSSelector::setTag):
(WebCore::CSSSelector::isLastInTagHistory):
(WebCore::CSSSelector::setNotLastInTagHistory):
(WebCore::CSSSelector::RareData::RareData):
(WebCore::CSSSelector::RareData::~RareData):
(WebCore::CSSSelector::createRareData):
(WebCore::CSSSelector::setValue):

    Remove m_tagHistory.
    Keep m_value in the union with the rare data pointer instead.
    Make m_value and m_tag private, implement accessors.
    Add a new bit to indicate end of the tag history (multipart selector).
    Eliminate complex destruction. Selectors are now deleted as an array or by a CSSParserSelector chain.

* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::adoptSelectorVector):

    Flatten everything to an array.

(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
* css/CSSSelectorList.h:
(WebCore::CSSSelectorList::hasOneSelector):
(WebCore::CSSSelectorList::next):

    Skip over the subparts of multipart selectors to find the next selector.

* css/CSSStyleRule.h:
(WebCore::CSSStyleRule::adoptSelectorVector):

    CSSSelector -> CSSParserSelector.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSRuleSet::addRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSStyleSelector::matchPageRulesForList):
* dom/Node.cpp:
(WebCore::Node::querySelector):
* dom/SelectorNodeList.cpp:
(WebCore::createSelectorNodeList):

    Use accessors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Mansi Mithal <mansi.mithal@nokia.com>
commit-queue@webkit.org [Tue, 25 Jan 2011 23:20:37 +0000 (23:20 +0000)]
2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>

        Reviewed by Antonio Gomes.

        QtTestBrowser should have a UI Settings to prevent loading images
        https://bugs.webkit.org/show_bug.cgi?id=52409

        Added a new action item named "DisableAutoLoadImages"
        under the "Settings" menu

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::createChrome):
        (LauncherWindow::toggleAutoLoadImages):
        * QtTestBrowser/launcherwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Tue, 25 Jan 2011 23:07:06 +0000 (23:07 +0000)]
2011-01-25  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Support small caps in complex text on linux
        https://bugs.webkit.org/show_bug.cgi?id=53051

        * platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.checksum: Added.
        * platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png: Added.
        * platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt: Added.
        * platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.checksum: Added.
        * platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.png: Added.
        * platform/chromium/test_expectations.txt: Re-enable 2 tests on linux.
2011-01-25  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Support small caps in complex text on linux
        https://bugs.webkit.org/show_bug.cgi?id=53051

        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::nextScriptRun): Break runs at small caps boundaries.
        (WebCore::ComplexTextController::setupFontForScriptRun): Setup small caps font data if needed.
        * platform/graphics/chromium/ComplexTextControllerLinux.h: Store small caps text in separate string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 25 Jan 2011 22:52:17 +0000 (22:52 +0000)]
2011-01-25  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        Minor bug fixes and cleanup for filesystem wrappers, port/* test
        classes, test_expectations.py. This change adds "test-win" and
        "test-mac" variants to the test port so that we can better test
        rebaselining, and adds a MockUser() object for reuse in testing.

        https://bugs.webkit.org/show_bug.cgi?id=53036

        * Scripts/webkitpy/common/system/filesystem.py:
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/port/factory.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix: add failing test to gtk/Skipped.
jer.noble@apple.com [Tue, 25 Jan 2011 22:23:06 +0000 (22:23 +0000)]
Unreviewed build fix: add failing test to gtk/Skipped.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows production build fix.
sfalken@apple.com [Tue, 25 Jan 2011 21:49:57 +0000 (21:49 +0000)]
Windows production build fix.
Use correct environment variable escaping

Rubber-stamped by Adam Roben.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore.make:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:

Source/WebCore:

* WebCore.vcproj/WebCore.make:

Source/WebKit/win:

* WebKit.vcproj/WebKit.make:

Source/WebKit2:

* win/WebKit2.make:
* win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 25 Jan 2011 21:29:14 +0000 (21:29 +0000)]
2011-01-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Empty URLs are never display isolated
        https://bugs.webkit.org/show_bug.cgi?id=53053

        This check mirrors the check in the local case.  There isn't a good way
        to test this with a LayoutTest, but it is tested in Chromium (where
        this registry is used).

        * platform/SchemeRegistry.cpp:
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 25 Jan 2011 21:14:50 +0000 (21:14 +0000)]
2011-01-25  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Pipe a timestamp down into the PlatformWheelEvent for the Mac.
        https://bugs.webkit.org/show_bug.cgi?id=53111

        * platform/PlatformWheelEvent.h:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        (WebCore::PlatformWheelEvent::timestamp):
        Add timestamp member.

        * platform/mac/WheelEventMac.mm:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        Initialize the timestamp from the event.
2011-01-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Don't inform the UI process about compositing changes when using the new drawing area
        https://bugs.webkit.org/show_bug.cgi?id=53120

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::changeAcceleratedCompositingMode):
        Return early if we're using the new drawing area.

        (WebKit::WebPage::exitAcceleratedCompositingMode):
        Call setRootCompositingLayer(0) so the drawing area knows when we leave accelerated compositing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 25 Jan 2011 21:13:55 +0000 (21:13 +0000)]
2011-01-25  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        JSON.stringify processing time exponentially grows with size of object
        https://bugs.webkit.org/show_bug.cgi?id=51922

        Remove last use of reserveCapacity from JSON stringification, as it results
        in appalling append behaviour when there are a large number of property names
        and nothing else.

        * runtime/JSONObject.cpp:
        (JSC::Stringifier::appendQuotedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 25 Jan 2011 21:11:32 +0000 (21:11 +0000)]
2011-01-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Don't inform the UI process about compositing changes when using the new drawing area
        https://bugs.webkit.org/show_bug.cgi?id=53120

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::changeAcceleratedCompositingMode):
        Return early if we're using the new drawing area.

        (WebKit::WebPage::exitAcceleratedCompositingMode):
        Call setRootCompositingLayer(0) so the drawing area knows when we leave accelerated compositing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Sheriff Bot <webkit.review.bot@gmail.com>
rniwa@webkit.org [Tue, 25 Jan 2011 21:08:26 +0000 (21:08 +0000)]
2011-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76625.
        http://trac.webkit.org/changeset/76625
        https://bugs.webkit.org/show_bug.cgi?id=53119

        "incorrect pixel test results" (Requested by rniwa on
        #webkit).

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::localCaretRect):
2011-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76625.
        http://trac.webkit.org/changeset/76625
        https://bugs.webkit.org/show_bug.cgi?id=53119

        "incorrect pixel test results" (Requested by rniwa on
        #webkit).

        * editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
        * editing/selection/caret-painting-after-paste-undo.html: Removed.
        * platform/mac/editing/deleting/5408255-expected.checksum:
        * platform/mac/editing/deleting/5408255-expected.png:
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 25 Jan 2011 21:05:31 +0000 (21:05 +0000)]
2011-01-25  Tony Chang  <tony@chromium.org>

        Unreviewed, debugger-scripts.html is failing on windows too.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Not reviewed, rebaseline for a test.
dimich@chromium.org [Tue, 25 Jan 2011 21:03:09 +0000 (21:03 +0000)]
[Chromium] Not reviewed, rebaseline for a test.
The difference is because V8 has different error messages.

* platform/chromium-mac/fast/js/js-continue-break-restrictions-expected.txt: Added.
* platform/chromium-win/fast/js/js-continue-break-restrictions-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 25 Jan 2011 20:55:39 +0000 (20:55 +0000)]
2011-01-25  James Robinson  <jamesr@chromium.org>

        Remove = TEXT PASS lines for tests that consistently pass.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 25 Jan 2011 20:55:38 +0000 (20:55 +0000)]
2011-01-25  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WINCE] Ensure layouted frame when painting
        https://bugs.webkit.org/show_bug.cgi?id=53108

        * WebView.cpp:
        (WebView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix: rollback untintentional changes in media expected results.
jer.noble@apple.com [Tue, 25 Jan 2011 20:52:02 +0000 (20:52 +0000)]
Unreviewed build fix: rollback untintentional changes in media expected results.

* media/video-source-moved-expected.txt:
* media/video-source-none-supported-expected.txt:
* LayoutTests/platform/win/media/audio-data-url-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 25 Jan 2011 20:48:44 +0000 (20:48 +0000)]
2011-01-25  Tony Chang  <tony@chromium.org>

        Unreviewed, mark inspector/debugger-scripts.html as failing on chromium linux.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 25 Jan 2011 20:41:55 +0000 (20:41 +0000)]
2011-01-25  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r76614.

        * platform/FileSystem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 25 Jan 2011 20:17:08 +0000 (20:17 +0000)]
2011-01-21  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Adler.

        Adding border and padding to the calculation of the local caret rect for RenderBoxes.

        Undo moves caret to invalid position
        https://bugs.webkit.org/show_bug.cgi?id=49744

        Tests: editing/selection/caret-painting-after-paste-undo-rtl.html
               editing/selection/caret-painting-after-paste-undo.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::localCaretRect):
2011-01-21  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Adler.

        Updating the expected result for 5408255 and adding tests for caret positioning at the
        beginning and end of RenderBoxes.

        Undo moves caret to invalid position
        https://bugs.webkit.org/show_bug.cgi?id=49744

        * editing/selection/caret-painting-after-paste-undo-rtl.html: Added.
        * editing/selection/caret-painting-after-paste-undo.html: Added.
        * platform/mac/editing/deleting/5408255-expected.checksum:
        * platform/mac/editing/deleting/5408255-expected.png:
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Added.
        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 25 Jan 2011 20:03:06 +0000 (20:03 +0000)]
2011-01-25  Tony Chang  <tony@chromium.org>

        Unreviewed, add chromium-mac baselines after r76599.

        The platform/mac-leopard results were stale which is why the expected
        text results aren't updated as well.

        * platform/chromium-mac/svg/custom/junk-data-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/junk-data-expected.png: Added.
        * platform/chromium-mac/svg/custom/missing-xlink-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/missing-xlink-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 25 Jan 2011 20:01:12 +0000 (20:01 +0000)]
2011-01-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Mihai Parparita.

        Convert requestAnimationFrame tests to be script-tests
        https://bugs.webkit.org/show_bug.cgi?id=53109

        This converts the new requestAnimationFrame tests to be proper script-tests using make-script-test-wrapper.

        * fast/animation/request-animation-frame-cancel-expected.txt:
        * fast/animation/request-animation-frame-cancel.html:
        * fast/animation/request-animation-frame-cancel2-expected.txt:
        * fast/animation/request-animation-frame-cancel2.html:
        * fast/animation/request-animation-frame-display-expected.txt:
        * fast/animation/request-animation-frame-display.html:
        * fast/animation/request-animation-frame-expected.txt:
        * fast/animation/request-animation-frame-within-callback-expected.txt:
        * fast/animation/request-animation-frame-within-callback.html:
        * fast/animation/request-animation-frame.html:
        * fast/animation/script-tests/TEMPLATE.html: Added.
        * fast/animation/script-tests/request-animation-frame-cancel.js: Copied from LayoutTests/fast/animation/request-animation-frame-cancel.html.
        * fast/animation/script-tests/request-animation-frame-cancel2.js: Copied from LayoutTests/fast/animation/request-animation-frame-cancel2.html.
        (secondCallbackId):
        * fast/animation/script-tests/request-animation-frame-display.js: Added.
        * fast/animation/script-tests/request-animation-frame-within-callback.js: Copied from LayoutTests/fast/animation/request-animation-frame-within-callback.html.
        (window):
        * fast/animation/script-tests/request-animation-frame.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 25 Jan 2011 19:54:58 +0000 (19:54 +0000)]
2011-01-25  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
        https://bugs.webkit.org/show_bug.cgi?id=53107

        * platform/PlatformWheelEvent.h:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        (WebCore::PlatformWheelEvent::hasPreciseScrollingDeltas):
        * platform/mac/WheelEventMac.mm:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2011-01-25  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
        https://bugs.webkit.org/show_bug.cgi?id=53107

        * Shared/WebEvent.h:
        (WebKit::WebWheelEvent::hasPreciseScrollingDeltas):
        * Shared/WebEventConversion.cpp:
        (WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
        * Shared/WebWheelEvent.cpp:
        (WebKit::WebWheelEvent::WebWheelEvent):
        * Shared/mac/WebEventFactory.mm:
        (WebKit::WebEventFactory::createWebWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-20 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Tue, 25 Jan 2011 19:52:17 +0000 (19:52 +0000)]
2011-01-20  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        REGRESSION (r72119): Audio never plays on Star Wars intro animation
        https://bugs.webkit.org/show_bug.cgi?id=52467

        Test the ability to read audio/m4a files.  Disabled this new test
        on the chromium and qt platforms, as they do not support M4A/AAC.

        * media/audio-mpeg4-supported-expected.txt: Added.
        * media/audio-mpeg4-supported.html: Added.
        * media/content/silence.m4a: Added.
        * platform/chromium/test_expectations.txt:
        * platform/qt/Skipped:
2011-01-20  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        REGRESSION (r72119): Audio never plays on Star Wars intro animation
        https://bugs.webkit.org/show_bug.cgi?id=52467

        QuickTime's eat/m4a movie importer compontent doesn't list audio/m4a as a mime
        type which it supports, though it handles .m4a files just fine.  Change the way
        we build the list of supported MIME Types through a new WebKitSystemInterface
        function.

        Caused by r72119, which adds system-specific extension->MIME entries to the cache
        before global entries, and the system-specific entries include QuickTime's registry
        entries which contain the audio/m4a MIME type, while its components do not.

        Test: media/audio-mpeg4-supported.html

        * WebCore.vcproj/QTMovieWinCommon.vsprops:
        * platform/graphics/win/QTMovie.cpp:
        (getMIMETypeCallBack):
        (initializeSupportedTypes):
        (QTMovie::countSupportedTypes): gSupportedTypes is now a CFArrayRef.
        (QTMovie::getSupportedType): Ditto.
2011-01-24  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        REGRESSION (r72119): Audio never plays on Star Wars intro animation
        https://bugs.webkit.org/show_bug.cgi?id=52467

        Add wkGetQuickTimeMIMETypeList() function.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 25 Jan 2011 19:39:58 +0000 (19:39 +0000)]
2011-01-25  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] remove unused layoutTestController callback
        https://bugs.webkit.org/show_bug.cgi?id=53103

        This method is used by a test_shell_test, but not needed by DRT.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        * DumpRenderTree/chromium/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 25 Jan 2011 19:39:04 +0000 (19:39 +0000)]
2011-01-25  Tony Chang  <tony@chromium.org>

        Unreviewed, rebaseline a test on chromium-win.  Part of r76586 rebaselines.

        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 25 Jan 2011 19:25:26 +0000 (19:25 +0000)]
2011-01-25  Ryosuke Niwa  <rniwa@webkit.org>

        Another unreviewed SVG rebaselines for Chromium.

        * platform/chromium-linux/svg/text/text-text-05-t-expected.checksum:
        * platform/chromium-linux/svg/text/text-text-05-t-expected.png:
        * platform/chromium-mac/svg/text/text-text-05-t-expected.checksum:
        * platform/chromium-mac/svg/text/text-text-05-t-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
        * platform/chromium-win/svg/text/text-text-05-t-expected.checksum:
        * platform/chromium-win/svg/text/text-text-05-t-expected.png:
        * platform/chromium-win/svg/text/text-text-05-t-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 25 Jan 2011 19:14:35 +0000 (19:14 +0000)]
2011-01-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        need a way to request the host CALayer render server port
        https://bugs.webkit.org/show_bug.cgi?id=53101
        <rdar://problem/8913620>

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::compositingRenderServerPort):
        Get the render server port from the plug-in process.

        * PluginProcess/PluginControllerProxy.h:
        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_GetValue):
        Call NetscapePlugin::compositingRenderServerPort.

        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        (WebKit::NetscapePlugin::compositingRenderServerPort):
        Call PluginController::compositingRenderServerPort.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::compositingRenderServerPort):
        Get the render server port from the web process.

        * WebProcess/Plugins/PluginView.h:
        Add compositingRenderServerPort.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Tue, 25 Jan 2011 19:07:09 +0000 (19:07 +0000)]
2011-01-25  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Remove PlatformBridge::idbShutdown()
        https://bugs.webkit.org/show_bug.cgi?id=53077

        Since Chromium r72157, this is not used anymore. The previous use was
        to signal to the embedder that IndexedDB was shutting down, but we
        agreed it is better if the embedder keeps track of that itself.

        No new tests: this does not change any functionality.

        * platform/chromium/PlatformBridge.h:
        * storage/IDBFactoryBackendInterface.cpp:
        * storage/IDBFactoryBackendInterface.h:
        (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
        * storage/chromium/IDBFactoryBackendInterface.cpp:
2011-01-25  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Remove PlatformBridge::idbShutdown()
        https://bugs.webkit.org/show_bug.cgi?id=53077

        Since Chromium r72157, this is not used anymore. Chromium keeps track
        of when it shuts down IndexedDB itself.

        * public/WebKitClient.h:
        * src/PlatformBridge.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed.
antti@apple.com [Tue, 25 Jan 2011 19:06:58 +0000 (19:06 +0000)]
Not reviewed.

Try to fix windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Jan 2011 19:03:16 +0000 (19:03 +0000)]
2011-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        WebKit is using CSBackupSetItemExcluded incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=53095
        rdar://problem/8790540

        * Misc/WebIconDatabase.mm:
        (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
        It was incorrect, and this responsibility has been moved to WebCore.
2011-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        WebKit is using CSBackupSetItemExcluded incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=53095
        rdar://problem/8790540

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::performOpenInitialization): Added code to
        exclude the database from backup one time, and record inside the
        database that this has been done.
        (WebCore::IconDatabase::wasExcludedFromBackup): Added.
        (WebCore::IconDatabase::setWasExcludedFromBackup): Added.
        * loader/icon/IconDatabase.h: Added new functions above.

        * platform/FileSystem.cpp:
        (WebCore::canExcludeFromBackup): Added.
        (WebCore::excludeFromBackup): Added.

        * platform/FileSystem.h: Added canExcludeFromBackup, excludeFromBackup,
        and pathAsURL functions. Cleaned up ifdefs and comments a bit and sorted
        things alphabetically, particularly platform-specific sections.

        * platform/cf/FileSystemCF.cpp:
        (WebCore::pathAsURL): Added.

        * platform/mac/FileSystemMac.mm:
        (WebCore::canExcludeFromBackup): Added.
        (WebCore::excludeFromBackup): Added.

        * platform/network/cf/FormDataStreamCFNet.cpp:
        (WebCore::advanceCurrentStream): Changed to call pathAsURL.
        * platform/network/mac/FormDataStreamMac.mm:
        (WebCore::advanceCurrentStream): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 25 Jan 2011 18:56:26 +0000 (18:56 +0000)]
2011-01-25  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        Skip another new test that uses eventSender
        https://bugs.webkit.org/show_bug.cgi?id=53094

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Tue, 25 Jan 2011 18:54:30 +0000 (18:54 +0000)]
2011-01-25  Helder Correia  <helder@sencha.com>

        Reviewed by Dirk Schulze.

        REGRESSION(75139): SVG gradients are not applied to texts
        https://bugs.webkit.org/show_bug.cgi?id=52531

        CGContextConcatCTM should use the CGLayer context, not the
        GraphicsContext. Also, the CTM needs to be adjusted (translated).
        This fixes SVG text gradient fill.

        Test: svg/css/composite-shadow-text.svg

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION: Leak in JSParser::Scope::copyCapturedVariablesToVector()
antti@apple.com [Tue, 25 Jan 2011 18:44:11 +0000 (18:44 +0000)]
REGRESSION: Leak in JSParser::Scope::copyCapturedVariablesToVector()
https://bugs.webkit.org/show_bug.cgi?id=53061

Reviewed by Oliver Hunt.

Cache did not know about the subclass so failed to fully delete the items.
Got rid of the subclass and moved the classes to separate files.

* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* parser/JSParser.cpp:
(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::findCachedFunctionInfo):
(JSC::JSParser::parseFunctionInfo):
* parser/SourceProvider.h:
* parser/SourceProviderCache.cpp: Added.
(JSC::SourceProviderCache::~SourceProviderCache):
(JSC::SourceProviderCache::byteSize):
* parser/SourceProviderCache.h: Added.
(JSC::SourceProviderCache::SourceProviderCache):
(JSC::SourceProviderCache::add):
(JSC::SourceProviderCache::get):
* parser/SourceProviderCacheItem.h: Added.
(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
(JSC::SourceProviderCacheItem::approximateByteSize):
(JSC::SourceProviderCacheItem::closeBraceToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Benjamin Kalman <kalman@chromium.org>
commit-queue@webkit.org [Tue, 25 Jan 2011 18:42:43 +0000 (18:42 +0000)]
2011-01-25  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Cannot extend or modify forward by word over a non-contenteditable region
        https://bugs.webkit.org/show_bug.cgi?id=53070

        Add regression test.

        * editing/selection/extend-forward-by-word-over-non-editable-expected.txt: Added.
        * editing/selection/extend-forward-by-word-over-non-editable.html: Added.
2011-01-25  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Cannot extend or modify forward by word over a non-contenteditable region
        https://bugs.webkit.org/show_bug.cgi?id=53070

        Test: editing/selection/extend-forward-by-word-over-non-editable.html

        Change all instances of honorEditableBoundaryAtOrAfter to honorEditableBoundaryAtOrBefore and vice versa in the
        functions which determine the end/start of words/lines/sentences in visible_units.cpp.

        This fixes the bug where moving forwards by a word over a non-contenteditable region would place the cursor
        inside that region, and then get moved back to the start of the word due to honorEditableBoundaryAtOrBefore.
        The cursor is now moved to the end of the region (which is effectively a noop in this case).

        * editing/visible_units.cpp: Change all instances of honorEditableBoundaryAtOrAfter to
        honorEditableBoundaryAtOrBefore and vice versa.
        (WebCore::previousWordPosition):
        (WebCore::nextWordPosition):
        (WebCore::startOfLine):
        (WebCore::endOfLine):
        (WebCore::previousSentencePosition):
        (WebCore::nextSentencePosition):
        (WebCore::logicalStartOfLine):
        (WebCore::logicalEndOfLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Marcilio Mendonca <mamendonca@rim.com>
commit-queue@webkit.org [Tue, 25 Jan 2011 18:28:35 +0000 (18:28 +0000)]
2011-01-25  Marcilio Mendonca  <mamendonca@rim.com>

        Reviewed by Darin Adler.

        Bug 53087: Refactoring: replaced a hanging "else" with a "return"
        statement
        https://bugs.webkit.org/show_bug.cgi?id=53087.

        Refactoring work: Replaced a hanging "else" within an #if PLATFORM(M
        with a "return" so that the code is more readable and less error pro
        (e.g., "else" doesn't use braces so adding extra lines to the else
        block won't have any effect; even worse, code still compiles
        successfully.

        * wtf/Assertions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange some floating point constants from 1.0 to 1.
mjs@apple.com [Tue, 25 Jan 2011 18:26:51 +0000 (18:26 +0000)]
Change some floating point constants from 1.0 to 1.

Rubber stamped by Dan Bernstein.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 25 Jan 2011 18:19:29 +0000 (18:19 +0000)]
2011-01-25  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed SVG rebaselines for Chromium.

        * platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
        * platform/chromium-linux/svg/batik/text/textEffect-expected.png:
        * platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Removed.
        * platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
        * platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
        * platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Removed.
        * platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum:
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Added.
        * platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
        * platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.png:
        * platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
        * platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.png:
        * platform/chromium-linux/svg/text/text-text-06-t-expected.checksum:
        * platform/chromium-linux/svg/text/text-text-06-t-expected.png:
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-mac/svg/text/text-text-06-t-expected.checksum:
        * platform/chromium-mac/svg/text/text-text-06-t-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
        * platform/chromium-win/svg/batik/text/textEffect-expected.png:
        * platform/chromium-win/svg/batik/text/textEffect-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.png:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
        * platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
        * platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
        * platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
        * platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
        * platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.png:
        * platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
        * platform/chromium-win/svg/text/text-text-06-t-expected.checksum:
        * platform/chromium-win/svg/text/text-text-06-t-expected.png:
        * platform/chromium-win/svg/text/text-text-06-t-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix.
yael.aharon@nokia.com [Tue, 25 Jan 2011 18:18:28 +0000 (18:18 +0000)]
Unreviewed build fix.
After r76466, efsrv.lib is used unconditionally.
Don't guard it with ENABLE_NETSCAPE_PLUGIN_API.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 25 Jan 2011 18:09:41 +0000 (18:09 +0000)]
2011-01-25  Tony Chang  <tony@chromium.org>

        Unreviewed, remove passing chromium win tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 25 Jan 2011 17:54:27 +0000 (17:54 +0000)]
2011-01-25  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders Carlsson.

        Improve scale factor resetting
        https://bugs.webkit.org/show_bug.cgi?id=53093

        Two key changes:
        - Don't set the scale factor to what it already is, as this causes an
        uneeded force layout and scroll
        - Don't ever set the scale factor based on a non-main frame committing

        This fixes two WebKit2 layout tests.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 25 Jan 2011 17:47:30 +0000 (17:47 +0000)]
2011-01-24  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Style cleanup for WebGLRenderingContext
        https://bugs.webkit.org/show_bug.cgi?id=52352

        * html/canvas/WebGLBuffer.cpp:
        * html/canvas/WebGLBuffer.h:
        * html/canvas/WebGLObject.cpp:
        * html/canvas/WebGLProgram.cpp:
        * html/canvas/WebGLRenderbuffer.cpp:
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::create):
        (WebCore::WebGLRenderingContext::blendFunc):
        (WebCore::WebGLRenderingContext::createShader):
        (WebCore::WebGLRenderingContext::deleteBuffer):
        (WebCore::WebGLRenderingContext::deleteShader):
        (WebCore::WebGLRenderingContext::deleteTexture):
        (WebCore::WebGLRenderingContext::disableVertexAttribArray):
        (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
        (WebCore::WebGLRenderingContext::validateRenderingState):
        (WebCore::WebGLRenderingContext::enableVertexAttribArray):
        (WebCore::WebGLRenderingContext::getUniform):
        (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects):
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLShader.cpp:
        * html/canvas/WebGLTexture.cpp:
        * html/canvas/WebGLUniformLocation.cpp:
        * html/canvas/WebGLUniformLocation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Tue, 25 Jan 2011 17:43:34 +0000 (17:43 +0000)]
2011-01-25  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Darin Fisher.

        Chromium WebKit API: Move dispatchFormControlChangeEvent() from WebInputElement to WebFormControlElement
        In service of https://code.google.com/p/chromium/issues/detail?id=42716
        https://bugs.webkit.org/show_bug.cgi?id=53069

        * public/WebFormControlElement.h:
        * public/WebInputElement.h:
        * src/WebFormControlElement.cpp:
        (WebKit::WebFormControlElement::dispatchFormControlChangeEvent): Moved from WebInputElement
        * src/WebInputElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Chris Marrin <cmarrin@apple.com>
zmo@google.com [Tue, 25 Jan 2011 17:34:34 +0000 (17:34 +0000)]
2011-01-24  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Eric Seidel.

        Change ENABLE_3D_CANVAS to ENABLE_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=53041

        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.cpp:
        * GNUmakefile.am:
        * WebCore.pro:
        * bindings/generic/RuntimeEnabledFeatures.h:
        * bindings/js/JSArrayBufferCustom.cpp:
        * bindings/js/JSCanvasRenderingContextCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/JSDataViewCustom.cpp:
        * bindings/js/JSDocumentCustom.cpp:
        * bindings/js/JSFloat32ArrayCustom.cpp:
        * bindings/js/JSHTMLCanvasElementCustom.cpp:
        (WebCore::JSHTMLCanvasElement::getContext):
        * bindings/js/JSInt16ArrayCustom.cpp:
        * bindings/js/JSInt32ArrayCustom.cpp:
        * bindings/js/JSInt8ArrayCustom.cpp:
        * bindings/js/JSUint16ArrayCustom.cpp:
        * bindings/js/JSUint32ArrayCustom.cpp:
        * bindings/js/JSUint8ArrayCustom.cpp:
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::markChildren):
        (WebCore::JSXMLHttpRequest::send):
        (WebCore::JSXMLHttpRequest::response):
        * bindings/v8/custom/V8ArrayBufferCustom.cpp:
        * bindings/v8/custom/V8ArrayBufferViewCustom.h:
        * bindings/v8/custom/V8DataViewCustom.cpp:
        * bindings/v8/custom/V8DocumentCustom.cpp:
        (WebCore::V8Document::getCSSCanvasContextCallback):
        * bindings/v8/custom/V8Float32ArrayCustom.cpp:
        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
        (WebCore::V8HTMLCanvasElement::getContextCallback):
        * bindings/v8/custom/V8Int16ArrayCustom.cpp:
        * bindings/v8/custom/V8Int32ArrayCustom.cpp:
        * bindings/v8/custom/V8Int8ArrayCustom.cpp:
        * bindings/v8/custom/V8Uint16ArrayCustom.cpp:
        * bindings/v8/custom/V8Uint32ArrayCustom.cpp:
        * bindings/v8/custom/V8Uint8ArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::V8XMLHttpRequest::responseAccessorGetter):
        (WebCore::V8XMLHttpRequest::sendCallback):
        * features.pri:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext):
        (WebCore::HTMLCanvasElement::reset):
        * html/HTMLCanvasElement.h:
        * html/canvas/ArrayBuffer.cpp:
        * html/canvas/ArrayBuffer.idl:
        * html/canvas/ArrayBufferView.cpp:
        * html/canvas/ArrayBufferView.idl:
        * html/canvas/DataView.cpp:
        * html/canvas/DataView.idl:
        * html/canvas/Float32Array.cpp:
        * html/canvas/Float32Array.idl:
        * html/canvas/Int16Array.cpp:
        * html/canvas/Int16Array.idl:
        * html/canvas/Int32Array.cpp:
        * html/canvas/Int32Array.idl:
        * html/canvas/Int8Array.cpp:
        * html/canvas/Int8Array.idl:
        * html/canvas/OESStandardDerivatives.cpp:
        * html/canvas/OESStandardDerivatives.idl:
        * html/canvas/OESTextureFloat.cpp:
        * html/canvas/OESTextureFloat.idl:
        * html/canvas/Uint16Array.cpp:
        * html/canvas/Uint16Array.idl:
        * html/canvas/Uint32Array.cpp:
        * html/canvas/Uint32Array.idl:
        * html/canvas/Uint8Array.cpp:
        * html/canvas/Uint8Array.idl:
        * html/canvas/WebGLActiveInfo.idl:
        * html/canvas/WebGLBuffer.cpp:
        * html/canvas/WebGLBuffer.idl:
        * html/canvas/WebGLContextAttributes.cpp:
        * html/canvas/WebGLContextAttributes.idl:
        * html/canvas/WebGLContextEvent.idl:
        * html/canvas/WebGLExtension.cpp:
        * html/canvas/WebGLFramebuffer.cpp:
        * html/canvas/WebGLFramebuffer.idl:
        * html/canvas/WebGLGetInfo.cpp:
        * html/canvas/WebGLObject.cpp:
        * html/canvas/WebGLProgram.cpp:
        * html/canvas/WebGLProgram.idl:
        * html/canvas/WebGLRenderbuffer.cpp:
        * html/canvas/WebGLRenderbuffer.idl:
        * html/canvas/WebGLRenderingContext.cpp:
        * html/canvas/WebGLRenderingContext.idl:
        * html/canvas/WebGLShader.cpp:
        * html/canvas/WebGLShader.idl:
        * html/canvas/WebGLTexture.cpp:
        * html/canvas/WebGLTexture.idl:
        * html/canvas/WebGLUniformLocation.cpp:
        * html/canvas/WebGLUniformLocation.idl:
        * html/canvas/WebKitLoseContext.cpp:
        * html/canvas/WebKitLoseContext.idl:
        * page/DOMWindow.idl:
        * platform/graphics/ANGLEWebKitBridge.cpp:
        * platform/graphics/GraphicsContext3D.cpp:
        * platform/graphics/cg/GraphicsContext3DCG.cpp:
        * platform/graphics/gpu/DrawingBuffer.cpp:
        * platform/graphics/gpu/mac/DrawingBufferMac.mm:
        * platform/graphics/mac/GraphicsContext3DMac.mm:
        * platform/graphics/mac/WebGLLayer.mm:
        * platform/graphics/opengl/Extensions3DOpenGL.cpp:
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
        * platform/graphics/qt/Extensions3DQt.cpp:
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
        (WebCore::GraphicsLayerQtImpl::paint):
        (WebCore::GraphicsLayerQtImpl::flushChanges):
        * platform/graphics/qt/GraphicsLayerQt.h:
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::isAcceleratedCanvas):
        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
        (WebCore::RenderLayerBacking::containsPaintedContent):
        (WebCore::RenderLayerBacking::contentChanged):
        * webaudio/AudioBuffer.cpp:
        * webaudio/AudioBuffer.idl:
        * webaudio/RealtimeAnalyser.cpp:
        * webaudio/RealtimeAnalyser.h:
        * webaudio/RealtimeAnalyserNode.h:
        * webaudio/RealtimeAnalyserNode.idl:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::setResponseType):
        (WebCore::XMLHttpRequest::clearResponse):
        (WebCore::XMLHttpRequest::didReceiveData):
        * xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Tue, 25 Jan 2011 17:27:30 +0000 (17:27 +0000)]
2011-01-24  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Eric Seidel.

        Change ENABLE_3D_CANVAS to ENABLE_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=53041

        * configure.ac:
2011-01-24  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Eric Seidel.

        Change ENABLE_3D_CANVAS to ENABLE_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=53041

        * Configurations/FeatureDefines.xcconfig:
2011-01-24  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Eric Seidel.

        Change ENABLE_3D_CANVAS to ENABLE_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=53041

        * WebKit.gyp:
        * features.gypi:
        * src/Extensions3DChromium.cpp:
        * src/GraphicsContext3DChromium.cpp:
        * src/WebRuntimeFeatures.cpp:
        (WebKit::WebRuntimeFeatures::enableWebGL):
        (WebKit::WebRuntimeFeatures::isWebGLEnabled):
2011-01-24  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Eric Seidel.

        Change ENABLE_3D_CANVAS to ENABLE_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=53041

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
2011-01-24  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Eric Seidel.

        Change ENABLE_3D_CANVAS to ENABLE_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=53041

        * WebView.cpp:
        (WebView::notifyPreferencesChanged):
2011-01-24  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Eric Seidel.

        Change ENABLE_3D_CANVAS to ENABLE_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=53041

        * Configurations/FeatureDefines.xcconfig:
2011-01-24  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Eric Seidel.

        Change ENABLE_3D_CANVAS to ENABLE_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=53041

        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.cpp:
        * GNUmakefile.am:
        * WebCore.pro:
        * bindings/generic/RuntimeEnabledFeatures.h:
        * bindings/js/JSArrayBufferCustom.cpp:
        * bindings/js/JSCanvasRenderingContextCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/JSDataViewCustom.cpp:
        * bindings/js/JSDocumentCustom.cpp:
        * bindings/js/JSFloat32ArrayCustom.cpp:
        * bindings/js/JSHTMLCanvasElementCustom.cpp:
        (WebCore::JSHTMLCanvasElement::getContext):
        * bindings/js/JSInt16ArrayCustom.cpp:
        * bindings/js/JSInt32ArrayCustom.cpp:
        * bindings/js/JSInt8ArrayCustom.cpp:
        * bindings/js/JSUint16ArrayCustom.cpp:
        * bindings/js/JSUint32ArrayCustom.cpp:
        * bindings/js/JSUint8ArrayCustom.cpp:
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::markChildren):
        (WebCore::JSXMLHttpRequest::send):
        (WebCore::JSXMLHttpRequest::response):
        * bindings/v8/custom/V8ArrayBufferCustom.cpp:
        * bindings/v8/custom/V8ArrayBufferViewCustom.h:
        * bindings/v8/custom/V8DataViewCustom.cpp:
        * bindings/v8/custom/V8DocumentCustom.cpp:
        (WebCore::V8Document::getCSSCanvasContextCallback):
        * bindings/v8/custom/V8Float32ArrayCustom.cpp:
        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
        (WebCore::V8HTMLCanvasElement::getContextCallback):
        * bindings/v8/custom/V8Int16ArrayCustom.cpp:
        * bindings/v8/custom/V8Int32ArrayCustom.cpp:
        * bindings/v8/custom/V8Int8ArrayCustom.cpp:
        * bindings/v8/custom/V8Uint16ArrayCustom.cpp:
        * bindings/v8/custom/V8Uint32ArrayCustom.cpp:
        * bindings/v8/custom/V8Uint8ArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::V8XMLHttpRequest::responseAccessorGetter):
        (WebCore::V8XMLHttpRequest::sendCallback):
        * features.pri:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext):
        (WebCore::HTMLCanvasElement::reset):
        * html/HTMLCanvasElement.h:
        * html/canvas/ArrayBuffer.cpp:
        * html/canvas/ArrayBuffer.idl:
        * html/canvas/ArrayBufferView.cpp:
        * html/canvas/ArrayBufferView.idl:
        * html/canvas/DataView.cpp:
        * html/canvas/DataView.idl:
        * html/canvas/Float32Array.cpp:
        * html/canvas/Float32Array.idl:
        * html/canvas/Int16Array.cpp:
        * html/canvas/Int16Array.idl:
        * html/canvas/Int32Array.cpp:
        * html/canvas/Int32Array.idl:
        * html/canvas/Int8Array.cpp:
        * html/canvas/Int8Array.idl:
        * html/canvas/OESStandardDerivatives.cpp:
        * html/canvas/OESStandardDerivatives.idl:
        * html/canvas/OESTextureFloat.cpp:
        * html/canvas/OESTextureFloat.idl:
        * html/canvas/Uint16Array.cpp:
        * html/canvas/Uint16Array.idl:
        * html/canvas/Uint32Array.cpp:
        * html/canvas/Uint32Array.idl:
        * html/canvas/Uint8Array.cpp:
        * html/canvas/Uint8Array.idl:
        * html/canvas/WebGLActiveInfo.idl:
        * html/canvas/WebGLBuffer.cpp:
        * html/canvas/WebGLBuffer.idl:
        * html/canvas/WebGLContextAttributes.cpp:
        * html/canvas/WebGLContextAttributes.idl:
        * html/canvas/WebGLContextEvent.idl:
        * html/canvas/WebGLExtension.cpp:
        * html/canvas/WebGLFramebuffer.cpp:
        * html/canvas/WebGLFramebuffer.idl:
        * html/canvas/WebGLGetInfo.cpp:
        * html/canvas/WebGLObject.cpp:
        * html/canvas/WebGLProgram.cpp:
        * html/canvas/WebGLProgram.idl:
        * html/canvas/WebGLRenderbuffer.cpp:
        * html/canvas/WebGLRenderbuffer.idl:
        * html/canvas/WebGLRenderingContext.cpp:
        * html/canvas/WebGLRenderingContext.idl:
        * html/canvas/WebGLShader.cpp:
        * html/canvas/WebGLShader.idl:
        * html/canvas/WebGLTexture.cpp:
        * html/canvas/WebGLTexture.idl:
        * html/canvas/WebGLUniformLocation.cpp:
        * html/canvas/WebGLUniformLocation.idl:
        * html/canvas/WebKitLoseContext.cpp:
        * html/canvas/WebKitLoseContext.idl:
        * page/DOMWindow.idl:
        * platform/graphics/ANGLEWebKitBridge.cpp:
        * platform/graphics/GraphicsContext3D.cpp:
        * platform/graphics/cg/GraphicsContext3DCG.cpp:
        * platform/graphics/gpu/DrawingBuffer.cpp:
        * platform/graphics/gpu/mac/DrawingBufferMac.mm:
        * platform/graphics/mac/GraphicsContext3DMac.mm:
        * platform/graphics/mac/WebGLLayer.mm:
        * platform/graphics/opengl/Extensions3DOpenGL.cpp:
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
        * platform/graphics/qt/Extensions3DQt.cpp:
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
        (WebCore::GraphicsLayerQtImpl::paint):
        (WebCore::GraphicsLayerQtImpl::flushChanges):
        * platform/graphics/qt/GraphicsLayerQt.h:
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::isAcceleratedCanvas):
        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
        (WebCore::RenderLayerBacking::containsPaintedContent):
        (WebCore::RenderLayerBacking::contentChanged):
        * webaudio/AudioBuffer.cpp:
        * webaudio/AudioBuffer.idl:
        * webaudio/RealtimeAnalyser.cpp:
        * webaudio/RealtimeAnalyser.h:
        * webaudio/RealtimeAnalyserNode.h:
        * webaudio/RealtimeAnalyserNode.idl:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::setResponseType):
        (WebCore::XMLHttpRequest::clearResponse):
        (WebCore::XMLHttpRequest::didReceiveData):
        * xml/XMLHttpRequest.h:
2011-01-24  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Eric Seidel.

        Change ENABLE_3D_CANVAS to ENABLE_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=53041

        * Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 25 Jan 2011 17:22:46 +0000 (17:22 +0000)]
2011-01-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Update Leopard svg/ pixel test baselines, to make run-webkit-tests -p pass again with --tolerance 0.
        Contains only marginal differences, or updates pixel test results that were forgotten to update.

        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
        * platform/mac-leopard/svg/css/text-gradient-shadow-expected.checksum: Added.
        * platform/mac-leopard/svg/css/text-gradient-shadow-expected.png: Added.
        * platform/mac-leopard/svg/custom/image-rescale-clip-expected.checksum:
        * platform/mac-leopard/svg/custom/image-rescale-clip-expected.png:
        * platform/mac-leopard/svg/custom/image-rescale-scroll-expected.checksum: Added.
        * platform/mac-leopard/svg/custom/image-rescale-scroll-expected.png: Added.
        * platform/mac-leopard/svg/custom/junk-data-expected.checksum:
        * platform/mac-leopard/svg/custom/junk-data-expected.png:
        * platform/mac-leopard/svg/custom/missing-xlink-expected.checksum:
        * platform/mac-leopard/svg/custom/missing-xlink-expected.png:
        * platform/mac-leopard/svg/filters/feComposite-expected.checksum:
        * platform/mac-leopard/svg/filters/feComposite-expected.png:
        * platform/mac-leopard/svg/filters/filter-rounding-issues-expected.checksum: Added.
        * platform/mac-leopard/svg/filters/filter-rounding-issues-expected.png: Added.
        * platform/mac-leopard/svg/repaint/filter-repaint-expected.checksum:
        * platform/mac-leopard/svg/repaint/filter-repaint-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows Production build fix
aroben@apple.com [Tue, 25 Jan 2011 17:14:47 +0000 (17:14 +0000)]
Windows Production build fix

* JavaScriptCore.vcproj/JavaScriptCore.make: Added a missing "set".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 25 Jan 2011 17:11:06 +0000 (17:11 +0000)]
2011-01-25  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Prepare for landing of detailed heap snapshots.

        - Introduce Preferences.detailedHeapProfiles flag for controlling
          querying of detailed heap snapshots.
        - Add boilerplate code for the new view.
        - Factor out common code.

        https://bugs.webkit.org/show_bug.cgi?id=52624

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * bindings/js/ScriptProfiler.h:
        (WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl):
        (WebCore::ScriptProfiler::takeHeapSnapshot):
        * bindings/v8/ScriptProfiler.cpp:
        (WebCore::ScriptProfiler::takeHeapSnapshot):
        * bindings/v8/ScriptProfiler.h:
        (WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl):
        * inspector/Inspector.idl:
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
        * inspector/InspectorProfilerAgent.h:
        * inspector/front-end/DetailedHeapshotView.js: Added.
        (WebInspector.DetailedHeapshotView):
        (WebInspector.DetailedHeapshotView.prototype.get statusBarItems):
        (WebInspector.DetailedHeapshotView.prototype.get profile):
        (WebInspector.DetailedHeapshotView.prototype.set profile):
        (WebInspector.DetailedHeapshotView.prototype.show):
        (WebInspector.DetailedHeapshotView.prototype.hide):
        (WebInspector.DetailedHeapshotProfileType):
        (WebInspector.DetailedHeapshotProfileType.prototype.get buttonTooltip):
        (WebInspector.DetailedHeapshotProfileType.prototype.get buttonStyle):
        (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
        (WebInspector.DetailedHeapshotProfileType.prototype.get welcomeMessage):
        (WebInspector.DetailedHeapshotProfileType.prototype.createSidebarTreeElementForProfile):
        (WebInspector.DetailedHeapshotProfileType.prototype.createView):
        * inspector/front-end/HeapSnapshot.js: Added.
        (WebInspector.HeapSnapshotEdgesIterator):
        (WebInspector.HeapSnapshotEdgesIterator.prototype.get done):
        (WebInspector.HeapSnapshotEdgesIterator.prototype.get isElement):
        (WebInspector.HeapSnapshotEdgesIterator.prototype.get isHidden):
        (WebInspector.HeapSnapshotEdgesIterator.prototype.get name):
        (WebInspector.HeapSnapshotEdgesIterator.prototype.next):
        (WebInspector.HeapSnapshotEdgesIterator.prototype.get node):
        (WebInspector.HeapSnapshotEdgesIterator.prototype.get nodeIndex):
        (WebInspector.HeapSnapshotEdgesIterator.prototype._getNameOrIndex):
        (WebInspector.HeapSnapshotEdgesIterator.prototype._getType):
        (WebInspector.HeapSnapshotNodeWrapper):
        (WebInspector.HeapSnapshotNodeWrapper.prototype.get edges):
        (WebInspector.HeapSnapshotNodeWrapper.prototype.get edgesCount):
        (WebInspector.HeapSnapshotNodeWrapper.prototype.get instancesCount):
        (WebInspector.HeapSnapshotNodeWrapper.prototype.get isHidden):
        (WebInspector.HeapSnapshotNodeWrapper.prototype.get name):
        (WebInspector.HeapSnapshotNodeWrapper.prototype.get selfSize):
        (WebInspector.HeapSnapshotNodeWrapper.prototype._getName):
        (WebInspector.HeapSnapshotNodeWrapper.prototype._getEdges):
        (WebInspector.HeapSnapshotNodeWrapper.prototype._getType):
        (WebInspector.HeapSnapshot):
        (WebInspector.HeapSnapshot.prototype._init):
        (WebInspector.HeapSnapshot.prototype.get rootEdges):
        * inspector/front-end/HeapSnapshotView.js:
        (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._setRecordingProfile):
        (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
        (WebInspector.ProfilerDispatcher.prototype.setRecordingProfile):
        (WebInspector.ProfilerDispatcher.prototype.reportHeapSnapshotProgress):
        * inspector/front-end/Settings.js:
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):
        * src/js/DevTools.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 25 Jan 2011 17:10:08 +0000 (17:10 +0000)]
2011-01-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Update Snow Leopard svg/ pixel test baselines, to make run-webkit-tests -p pass again with --tolerance 0.
        Contains only marginal differences, or updates pixel test results that were forgotten to update.

        * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
        * platform/mac/svg/batik/text/textEffect-expected.checksum:
        * platform/mac/svg/batik/text/textEffect-expected.png:
        * platform/mac/svg/batik/text/textEffect3-expected.checksum:
        * platform/mac/svg/batik/text/textEffect3-expected.png:
        * platform/mac/svg/custom/baseval-animval-equality-expected.checksum:
        * platform/mac/svg/custom/baseval-animval-equality-expected.png:
        * platform/mac/svg/custom/foreign-object-skew-expected.checksum:
        * platform/mac/svg/custom/foreign-object-skew-expected.png:
        * platform/mac/svg/custom/image-rescale-expected.checksum:
        * platform/mac/svg/custom/image-rescale-expected.png:
        * platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
        * platform/mac/svg/custom/svg-fonts-in-html-expected.png:
        * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
        * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
        * platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
        * platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
        * platform/mac/svg/filters/feComposite-expected.checksum:
        * platform/mac/svg/filters/feComposite-expected.png:
        * platform/mac/svg/filters/filter-rounding-issues-expected.checksum:
        * platform/mac/svg/filters/filter-rounding-issues-expected.png:
        * platform/mac/svg/filters/filteredImage-expected.checksum:
        * platform/mac/svg/filters/filteredImage-expected.png:
        * platform/mac/svg/repaint/filter-repaint-expected.checksum:
        * platform/mac/svg/repaint/filter-repaint-expected.png:
        * platform/mac/svg/text/text-text-05-t-expected.checksum:
        * platform/mac/svg/text/text-text-05-t-expected.png:
        * platform/mac/svg/text/text-text-06-t-expected.checksum:
        * platform/mac/svg/text/text-text-06-t-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 25 Jan 2011 16:48:44 +0000 (16:48 +0000)]
2011-01-25  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Add missing defines for COMPILER(RVCT) && CPU(ARM_THUMB2)
        https://bugs.webkit.org/show_bug.cgi?id=52949

        * jit/JITStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 25 Jan 2011 16:09:03 +0000 (16:09 +0000)]
2011-01-25  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove "attached" state related methods from InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=53086

        * WebCore.exp.in:
        * inspector/InspectorAgent.cpp:
        * inspector/InspectorAgent.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
        (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
        * inspector/InspectorSettings.cpp:
        (WebCore::InspectorSettings::InspectorSettings):
        * inspector/InspectorSettings.h:
2011-01-25  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove "attached" state related methods from InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=53086

        * WebCoreSupport/WebInspectorClientCF.cpp:
        (WebInspectorClient::sendMessageToFrontend):
        (WebInspectorClient::inspectorStartsAttached):
        (WebInspectorClient::setInspectorStartsAttached):
        (WebInspectorClient::releaseFrontendPage):
2011-01-25  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove "attached" state related methods from InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=53086

        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController showWindow:]):
        (-[WebInspectorWindowController attach]):
        (-[WebInspectorWindowController detach]):
2011-01-25  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove "attached" state related methods from InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=53086

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorFrontendClient::attachWindow):
        (WebInspectorFrontendClient::detachWindow):
        (WebInspectorFrontendClient::showWindowWithoutNotifications):
        * WebCoreSupport/WebInspectorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Tue, 25 Jan 2011 15:46:12 +0000 (15:46 +0000)]
2011-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed, add bug url for failing test on GTK.

        [cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html
        https://bugs.webkit.org/show_bug.cgi?id=53085

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Qi Zhang <qi.2.zhang@nokia.com>
commit-queue@webkit.org [Tue, 25 Jan 2011 15:24:45 +0000 (15:24 +0000)]
2011-01-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Symbian] RVCT fails to compile [U|I]nt[8|16|32]Array.h
        https://bugs.webkit.org/show_bug.cgi?id=51873

        Replace the using declaration, because it doesn't compile on RVCT, and WINSCW has the same issue.
        No new functionality so no new tests.

        * html/canvas/Int32Array.h:
        (WebCore::Int32Array::set):
        * html/canvas/Int8Array.h:
        (WebCore::Int8Array::set):
        * html/canvas/Uint16Array.h:
        (WebCore::Uint16Array::set):
        * html/canvas/Uint32Array.h:
        (WebCore::Uint32Array::set):
        * html/canvas/Uint8Array.h:
        (WebCore::Uint8Array::set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 25 Jan 2011 15:15:33 +0000 (15:15 +0000)]
2011-01-25  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Antonio Gomes.

        fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=53073

        Make the two steps in the flaky test to be executed sequentially.

        * fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
        Fix flaky test by chaining its two steps up.
        * platform/gtk/Skipped: Unskip test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRepaint SVG elements with filter instead of relayout where possible
zherczeg@webkit.org [Tue, 25 Jan 2011 15:10:44 +0000 (15:10 +0000)]
Repaint SVG elements with filter instead of relayout where possible
https://bugs.webkit.org/show_bug.cgi?id=52200

Reviewed by Dirk Schulze.

This patch allows repainting of filters, when their
attribute changes does not require relayout.

Existing dynamic-update tests cover this feature.

* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::clearResult): Clearing the currently stored image
before repainting.
* platform/graphics/filters/FilterEffect.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::isSVGResourceFilter): Not only the filter primitives,
but filters should also be detected to allow safe testing and casting.
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives): Passing the renderer.
(WebCore::RenderSVGResourceFilter::applyResource):
determineFilterPrimitiveSubregion does not require the filter anymore.
(WebCore::RenderSVGResourceFilter::postApplyResource): Repaint
if lastEffect->hasResult() is false.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
Searching for all FilterEffects, whose created by the current FilterElement,
and clearing all resulting images depending on those FilterEffects.
* rendering/svg/RenderSVGResourceFilter.h:
(WebCore::RenderSVGResourceFilter::isSVGResourceFilter):
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
The filter argument is unnecessary anymore. But is is still kept as a static
member, since the primitive renderer still does not know about the
FilterEffect objects.
* rendering/svg/RenderSVGResourceFilterPrimitive.h:
(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):
(WebCore::RenderSVGResourceFilterPrimitive::primitiveAttributeChanged):
Calls RenderSVGResourceFilter::primitiveAttributeChanged.
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
Setting the new attribute value for each FilterEffect.
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):
* svg/SVGFEDiffuseLightingElement.h:
Calling primitiveAttributeChanged.
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute):
This function will be removed when all FilterElement implements
their setFilterEffectAttribute
* svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::primitiveAttributeChanged):
* svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::appendEffectToEffectReferences): The
renderers are assigned to the filter effects.
(WebCore::SVGFilterBuilder::clearEffects):
(WebCore::SVGFilterBuilder::clearResultsRecursive): Recursively
clearing the result images for those filters, whose depend on
the starting filter.
* svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::effectReferences): 'get' is unnecessary
(WebCore::SVGFilterBuilder::effectByRenderer): returns the
FilterEffect belongs to this RenderObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 25 Jan 2011 13:46:18 +0000 (13:46 +0000)]
2011-01-25  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG is missing to-animation support for Path
        https://bugs.webkit.org/show_bug.cgi?id=52982

        Added an animation test to check 'to' animations in combination with SVG paths.

        * svg/animations/animate-path-to-animation-expected.txt: Added.
        * svg/animations/animate-path-to-animation.html: Added.
        * svg/animations/script-tests/animate-path-to-animation.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
2011-01-25  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG is missing to-animation support for Path
        https://bugs.webkit.org/show_bug.cgi?id=52982

        SVG was missing 'to' animation support for SVG paths. Even the fallback to discrete
        animation did not work and an assert was thrown, because of the missing m_fromPath.
        This also influences a test of the W3C test suite. Subtest 2 of animate-elem-83-t.svg passes now.

        Test: svg/animations/animate-path-to-animation.html

        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateAnimatedValue): Take the value of the last SVGAnimateElement for
        m_fromPath, since 'to' animations are accumulative.
        (WebCore::SVGAnimateElement::calculateFromAndToValues): Added support for 'to' animations.
        (WebCore::SVGAnimateElement::resetToBaseValue): Set m_animatedPath on the first animation element to baseVal.
        * svg/SVGPathByteStream.h:
        (WebCore::SVGPathByteStream::copySVGPathByteStream): Return copy of current byte stream.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 25 Jan 2011 13:34:28 +0000 (13:34 +0000)]
2011-01-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Introduce FontMetrics abstraction
        https://bugs.webkit.org/show_bug.cgi?id=51456

        Update gtk/qt baseline.

        * platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
        * platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
        * platform/gtk/svg/text/text-hkern-expected.txt:
        * platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
        * platform/gtk/svg/text/text-vkern-expected.txt:
        * platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
        * platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
        * platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
        * platform/qt/svg/text/text-hkern-expected.txt:
        * platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
        * platform/qt/svg/text/text-vkern-expected.txt:
        * platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
        * platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 25 Jan 2011 13:32:33 +0000 (13:32 +0000)]
2011-01-25  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: bind resources to URLs upon adding them into the tree.
        https://bugs.webkit.org/show_bug.cgi?id=53013

        * inspector/debugger-scripts-expected.txt:
        * inspector/debugger-scripts.html:
2011-01-25  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: bind resources to URLs upon adding them into the tree.
        https://bugs.webkit.org/show_bug.cgi?id=53013

        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype._parsedScriptSource):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager.prototype._processCachedResources):
        (WebInspector.NetworkManager.prototype.inflightResourceForURL):
        (WebInspector.NetworkDispatcher):
        (WebInspector.NetworkDispatcher.prototype.willSendRequest):
        (WebInspector.NetworkDispatcher.prototype.markResourceAsCached):
        (WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
        (WebInspector.NetworkDispatcher.prototype.didReceiveContentLength):
        (WebInspector.NetworkDispatcher.prototype.didFinishLoading):
        (WebInspector.NetworkDispatcher.prototype.didFailLoading):
        (WebInspector.NetworkDispatcher.prototype.willSendWebSocketHandshakeRequest):
        (WebInspector.NetworkDispatcher.prototype.didReceiveWebSocketHandshakeResponse):
        (WebInspector.NetworkDispatcher.prototype.didCloseWebSocket):
        (WebInspector.NetworkDispatcher.prototype._appendRedirect):
        (WebInspector.NetworkDispatcher.prototype._startResource):
        (WebInspector.NetworkDispatcher.prototype._finishResource):
        (WebInspector.NetworkDispatcher.prototype._createResource):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
        (WebInspector.ResourceTreeModel.prototype._bindResourceURL):
        (WebInspector.ResourceTreeModel.prototype._clearResources):
        (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
        (WebInspector.ResourcesPanel.prototype.showSourceLine):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._parsedScriptSource):
        (WebInspector.ScriptsPanel.prototype._addScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 25 Jan 2011 12:47:00 +0000 (12:47 +0000)]
2011-01-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Introduce FontMetrics abstraction
        https://bugs.webkit.org/show_bug.cgi?id=51456

        Use accurate floating-point metrics for SVG Font calculations instead of casting float -> integer.
        This hopefully fixes differences between 32/64 bit bots.

        Needs new layout test results for several platforms, which need to be taken from the bots landing afterwards.

        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::SimpleFontData):
        (WebCore::SimpleFontData::initCharWidths):

2011-01-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Introduce FontMetrics abstraction
        https://bugs.webkit.org/show_bug.cgi?id=51456

        Update mac/mac-leopard pixel baseline after removing the float -> int truncation in the SVG Fonts ascent/descent calculation code.

        * platform/gtk/Skipped: Unskip several tests.
        * platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
        * platform/mac-leopard/svg/batik/text/textEffect-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textEffect-expected.png:
        * platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textEffect3-expected.png:
        * platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
        * platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
        * platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
        * platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png:
        * platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
        * platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png:
        * platform/mac-leopard/svg/text/text-text-05-t-expected.checksum:
        * platform/mac-leopard/svg/text/text-text-05-t-expected.png:
        * platform/mac-leopard/svg/text/text-text-06-t-expected.checksum:
        * platform/mac-leopard/svg/text/text-text-06-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/batik/text/textPosition2-expected.png:
        * platform/mac/svg/batik/text/textPosition2-expected.txt:
        * platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
        * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
        * platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
        * platform/mac/svg/text/text-text-05-t-expected.txt:
        * platform/mac/svg/text/text-text-06-t-expected.txt:
        * svg/custom/glyph-transformation-with-hkern-expected.txt:
-This line, and those below, will be ignored--

M    LayoutTests/platform/mac-leopard/svg/text/text-text-05-t-expected.checksum
M    LayoutTests/platform/mac-leopard/svg/text/text-text-06-t-expected.checksum
M    LayoutTests/platform/mac-leopard/svg/text/text-text-05-t-expected.png
M    LayoutTests/platform/mac-leopard/svg/text/text-text-06-t-expected.png
M    LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png
M    LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum
M    LayoutTests/platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum
M    LayoutTests/platform/mac-leopard/svg/batik/text/textEffect-expected.checksum
M    LayoutTests/platform/mac-leopard/svg/batik/text/textEffect-expected.png
M    LayoutTests/platform/mac-leopard/svg/batik/text/textEffect3-expected.png
M    LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png
M    LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum
M    LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum
M    LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.checksum
M    LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png
M    LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png
M    LayoutTests/platform/mac/svg/text/text-text-06-t-expected.txt
M    LayoutTests/platform/mac/svg/text/text-text-05-t-expected.txt
M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt
M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt
M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt
M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt
M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt
M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png
M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt
M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png
M    LayoutTests/platform/mac/svg/batik/text/textEffect3-expected.txt
M    LayoutTests/platform/mac/svg/batik/text/textPosition2-expected.png
M    LayoutTests/platform/mac/svg/batik/text/textEffect-expected.txt
M    LayoutTests/platform/mac/svg/batik/text/textPosition2-expected.txt
M    LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt
M    LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt
M    LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt
M    LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt
M    LayoutTests/platform/mac/svg/custom/svg-fonts-in-html-expected.txt
M    LayoutTests/platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt
M    LayoutTests/platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt
M    LayoutTests/platform/gtk/Skipped
M    LayoutTests/ChangeLog
M    LayoutTests/svg/custom/glyph-transformation-with-hkern-expected.txt
M    Source/WebCore/ChangeLog
M    Source/WebCore/platform/graphics/SimpleFontData.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 25 Jan 2011 12:43:02 +0000 (12:43 +0000)]
2011-01-25  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Add QWKPage::processCrashed() signal
        https://bugs.webkit.org/show_bug.cgi?id=53076

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::processDidCrash):
        * UIProcess/API/qt/qwkpage.h:
        * UIProcess/API/qt/qwkpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 25 Jan 2011 11:43:11 +0000 (11:43 +0000)]
2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Andreas Kling.

        [GTK] Remove 64 bits release bot from the buildbot master
        https://bugs.webkit.org/show_bug.cgi?id=52899

        Removes the 64 bits release slave from the buildbot configuration,
        so that we can use it as an EWS.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 25 Jan 2011 11:38:27 +0000 (11:38 +0000)]
2011-01-25  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping flaky test on GTK debug bots.

        editing/selection/extend-selection-bidi.html test is flaky
        https://bugs.webkit.org/show_bug.cgi?id=53074

        * platform/gtk/Skipped: Skipped test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 25 Jan 2011 11:09:46 +0000 (11:09 +0000)]
2011-01-25  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping flaky test on GTK debug bots.

        fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=53073

        * platform/gtk/Skipped: Skipped test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 25 Jan 2011 09:44:30 +0000 (09:44 +0000)]
2011-01-24  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: debugger and browser debugger agents should manage sticky breakpoints independently.
        https://bugs.webkit.org/show_bug.cgi?id=52999

        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::enableDebugger):
        (WebCore::InspectorAgent::inspectedURLWithoutFragment):
        * inspector/InspectorAgent.h:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
        (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
        (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
        * inspector/InspectorBrowserDebuggerAgent.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::setAllJavaScriptBreakpoints):
        (WebCore::InspectorDebuggerAgent::inspectedURLChanged):
        (WebCore::InspectorDebuggerAgent::restoreBreakpoints):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        * inspector/InspectorState.h:
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager):
        (WebInspector.BreakpointManager.prototype._projectChanged):
        (WebInspector.BreakpointManager.prototype._saveBreakpoints):
        (WebInspector.BreakpointManager.prototype._pushBreakpointsToBackend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 25 Jan 2011 09:19:00 +0000 (09:19 +0000)]
2011-01-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Nikolas Zimmermann.

        Skip some new tests for WebKit2 that use eventSender
        https://bugs.webkit.org/show_bug.cgi?id=53068

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 25 Jan 2011 09:15:14 +0000 (09:15 +0000)]
2011-01-25  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, trivial debugger test fix.

        * src/js/Tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Tue, 25 Jan 2011 08:43:48 +0000 (08:43 +0000)]
2011-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Crash in some pages containing flash
        https://bugs.webkit.org/show_bug.cgi?id=53016

        Flash plugin can produce X errors that are handled by the GDK X
        error handler, which exits the process. Since we don't want to
        crash due to flash bugs, we install a custom error handler to show
        a warning when a X error happens without aborting.

        * plugins/gtk/PluginPackageGtk.cpp:
        (WebCore::webkitgtkXError):
        (WebCore::PluginPackage::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Tue, 25 Jan 2011 08:33:59 +0000 (08:33 +0000)]
2011-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement spin buttons in RenderThemeGtk
        https://bugs.webkit.org/show_bug.cgi?id=51454

        Paint inner up/down buttons for spin button elements when building
        with GTK+ 3.x.

        Test results will land with the GTK+ 2.x version of this patch.

        * platform/gtk/RenderThemeGtk.h:
        * platform/gtk/RenderThemeGtk2.cpp:
        (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
        (WebCore::RenderThemeGtk::paintInnerSpinButton):
        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::spinButtonArrowSize):
        (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
        (WebCore::paintSpinArrowButton):
        (WebCore::RenderThemeGtk::paintInnerSpinButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 25 Jan 2011 06:44:20 +0000 (06:44 +0000)]
2011-01-24  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed. Missed move of one m_deleted use to be outside NDEBUG block
        in r76575.

        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::~CachedResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 25 Jan 2011 06:17:25 +0000 (06:17 +0000)]
2011-01-24  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Add runtime checks for invariants in memory cache
        https://bugs.webkit.org/show_bug.cgi?id=53059

        To help track down bug 53045, add some CRASH calls in addition to
        ASSERTs, so that we can track down failures in reliability bots.

        Just some checks, no new tests necessary.

        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::cachedImage):
        * loader/cache/CachedResource.h:
        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::~CachedResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 25 Jan 2011 06:15:01 +0000 (06:15 +0000)]
2011-01-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Implement database quota callback to fix storage tests on WebKit2 bot
        https://bugs.webkit.org/show_bug.cgi?id=53064

        * WebKitTestRunner/TestController.cpp:
        (WTR::exceededDatabaseQuota):
        (WTR::TestController::createOtherPage):
        (WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 25 Jan 2011 06:09:06 +0000 (06:09 +0000)]
2011-01-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Leaking CSSRuleDataList objects
        https://bugs.webkit.org/show_bug.cgi?id=53062

        Fix leaked CSSRuleDataLists added to the m_pseudoRules hash.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSRuleSet::~CSSRuleSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 25 Jan 2011 06:05:54 +0000 (06:05 +0000)]
2011-01-24  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        Chromium-Linux rebaseline for r76567.

        * platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum:
        * platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
        * platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum:
        * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
        * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 25 Jan 2011 05:52:29 +0000 (05:52 +0000)]
2011-01-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel.

        Refcount Images used in rendering code
        https://bugs.webkit.org/show_bug.cgi?id=52701

        Change StyleImage::image(RenderObject*, const IntSize&) and
        CSSImageGeneratorValue::image(RenderObject*, const IntSize&) to
        return PassRefPtr<Image>, and adjust other code accordingly.

        This allows us to return one-time images, for example for CSS gradients
        whose appearance may change depending on factors other than the renderer
        and the destination size.

        * css/CSSCanvasValue.cpp:
        (WebCore::CSSCanvasValue::image):
        * css/CSSCanvasValue.h:
        * css/CSSGradientValue.cpp:
        (WebCore::CSSGradientValue::image):
        * css/CSSGradientValue.h:
        * css/CSSImageGeneratorValue.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::paintNinePieceImage):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced):
        (WebCore::RenderImage::paintIntoRect):
        * rendering/RenderImageResource.h:
        (WebCore::RenderImageResource::image):
        * rendering/RenderImageResourceStyleImage.h:
        (WebCore::RenderImageResourceStyleImage::image):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/style/StyleCachedImage.cpp:
        (WebCore::StyleCachedImage::image):
        * rendering/style/StyleCachedImage.h:
        * rendering/style/StyleGeneratedImage.cpp:
        (WebCore::StyleGeneratedImage::image):
        * rendering/style/StyleGeneratedImage.h:
        * rendering/style/StyleImage.h:
        * rendering/style/StylePendingImage.h:
        (WebCore::StylePendingImage::image):
        * rendering/svg/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 25 Jan 2011 05:38:06 +0000 (05:38 +0000)]
2011-01-24  Martin Robinson  <mrobinson@igalia.com>

        Skip a slightly different set of tests after r76555. Seems that some of these
        failures are cascading.

        * platform/gtk/Skipped: Update the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 25 Jan 2011 05:17:09 +0000 (05:17 +0000)]
2011-01-24  Tony Chang  <tony@chromium.org>

        Unreviewed, reverting 5 changes of baselines that are incorrect for Linux.
        Mark win tests as failing for now.

        * platform/chromium-linux/fast/css/acid2-expected.txt: Removed.
        * platform/chromium-linux/fast/css/acid2-pixel-expected.checksum:
        * platform/chromium-linux/fast/css/acid2-pixel-expected.png:
        * platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Removed.
        * platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
        * platform/chromium-linux/fast/forms/button-sizes-expected.png:
        * platform/chromium-linux/fast/forms/button-sizes-expected.txt:
        * platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum:
        * platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
        * platform/chromium-linux/fast/forms/input-button-sizes-expected.txt:
        * platform/chromium-linux/http/tests/misc/acid2-expected.txt: Removed.
        * platform/chromium-linux/http/tests/misc/acid2-pixel-expected.checksum:
        * platform/chromium-linux/http/tests/misc/acid2-pixel-expected.png:
        * platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Removed.
        * platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
        * platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Removed.
        * platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Removed.
        * platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
        * platform/chromium-linux/svg/hixie/perf/003-expected.txt: Added.
        * platform/chromium-linux/svg/hixie/perf/004-expected.txt: Added.
        * platform/chromium-linux/svg/hixie/perf/005-expected.txt: Added.
        * platform/chromium-linux/svg/hixie/perf/006-expected.txt: Added.
        * platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
        * platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
        * platform/chromium-linux/svg/text/text-hkern-expected.txt: Removed.
        * platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.checksum: Removed.
        * platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Removed.
        * platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
        * platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
        * platform/chromium-linux/svg/text/text-text-01-b-expected.png:
        * platform/chromium-linux/svg/text/text-text-01-b-expected.txt:
        * platform/chromium-linux/svg/text/text-text-04-t-expected.txt: Removed.
        * platform/chromium-linux/svg/text/text-vkern-expected.checksum: Removed.
        * platform/chromium-linux/svg/text/text-vkern-expected.txt: Removed.
        * platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
        * platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
        * platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
        * platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
        * platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
        * platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
        * platform/chromium-win/svg/text/text-hkern-expected.txt: Removed.
        * platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum:
        * platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png:
        * platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
        * platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
        * platform/chromium-win/svg/text/text-text-04-t-expected.png:
        * platform/chromium-win/svg/text/text-text-04-t-expected.txt:
        * platform/chromium-win/svg/text/text-vkern-expected.checksum:
        * platform/chromium-win/svg/text/text-vkern-expected.png:
        * platform/chromium-win/svg/text/text-vkern-expected.txt: Removed.
        * platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:
2011-01-24  Tony Chang  <tony@chromium.org>

        Unreviewed, round ascent and descent to match old code.

        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 25 Jan 2011 05:15:56 +0000 (05:15 +0000)]
2011-01-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        perspective() transform function should take lengths
        https://bugs.webkit.org/show_bug.cgi?id=52683

        The argument to the perspective() transform function should
        be a Length, rather than a bare number. Bare numbers are still
        accepted (and treated as px), but this behavior is deprecated.

        Test: animations/3d/transform-perspective.html
              transforms/3d/general/3dtransform-values.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseTransform): Check the units for the perspective()
        function. Allow bare numbers for backwards compatibility.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::createTransformOperations): Convert
        value to Length.
        * platform/graphics/transforms/PerspectiveTransformOperation.cpp:
        (WebCore::clampToPostiveInteger): Helper.
        (WebCore::PerspectiveTransformOperation::blend): Blend via Lengths.
        * platform/graphics/transforms/PerspectiveTransformOperation.h:
        (WebCore::PerspectiveTransformOperation::create): double -> Length.
        (WebCore::PerspectiveTransformOperation::perspective): Ditto.
        (WebCore::PerspectiveTransformOperation::isIdentity): Ditto.
        (WebCore::PerspectiveTransformOperation::apply): Ditto.
        (WebCore::PerspectiveTransformOperation::PerspectiveTransformOperation): Assert
        that the Length is a fixed type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 25 Jan 2011 04:38:29 +0000 (04:38 +0000)]
2011-01-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Windows] Textfield <input>s have different widths.
        https://bugs.webkit.org/show_bug.cgi?id=48405

        * fast/forms/input-widths-expected.txt: Added.
        * fast/forms/input-widths.html: Added.
2011-01-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Windows] Textfield <input>s have different widths.
        https://bugs.webkit.org/show_bug.cgi?id=48405

        - Apply the padding override for type=text to other textfield types too.
        - Reset margin value of outer spin button, which is not used in Windows.
        - Don't add inner spin button width to the preferred text field width.
          Text fields should have the identical widths regardless of the
          existence of spin buttons.

        Test: fast/forms/input-widths.html

        * css/themeWin.css:
        (input[type="week"]):
        (input[type="week"]:disabled):
        (input[type="search"]::-webkit-search-cancel-button):
        (input::-webkit-outer-spin-button):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::preferredContentWidth):
        Don't add inner spin button width to the preferred width.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 25 Jan 2011 04:36:26 +0000 (04:36 +0000)]
2011-01-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Some bugs of search cancel button and spin button about state change in
        an event handler.
        https://bugs.webkit.org/show_bug.cgi?id=46950

        * fast/forms/input-number-change-type-on-focus-expected.txt: Added.
        * fast/forms/input-number-change-type-on-focus.html: Added.
        * fast/forms/search-hide-cancel-on-cancel-expected.txt: Added.
        * fast/forms/search-hide-cancel-on-cancel.html: Added.
2011-01-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Some bugs of search cancel button and spin button about state change in
        an event handler.
        https://bugs.webkit.org/show_bug.cgi?id=46950

        Fix the following problems:
         * Type=search field didn't release event capturing
         * Assertion failure when an input field with spin buttons was changed
           to another type on focus event.
         * A input field with spin button didn't release event capturing when it
           was changed to another type on focus event.

        Tests: fast/forms/input-number-change-type-on-focus.html
               fast/forms/search-hide-cancel-on-cancel.html

        * rendering/TextControlInnerElements.cpp:
        (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
         - Make the variable 'input' RefPtr.  It makes the code simpler.
         - Remove visibility check on mouseup event. We should release capturing
           anyway because the cancel button may be invisible if JavaScript code
           called by the focus event removes the input value.
        (WebCore::SpinButtonElement::detach):
         - Release capturing on detach because it is possible that a spin button
           node is detached while it is capturing events.
        (WebCore::SpinButtonElement::defaultEventHandler):
          Take a reference to this and check renderer() after some functions which
          may run JavaScript code.
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
          Make the variable 'input' RefPtr to align other functions in this file.
        (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): ditto.
        * rendering/TextControlInnerElements.h: Declare SpinButtonElement::detach().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 25 Jan 2011 03:27:14 +0000 (03:27 +0000)]
2011-01-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Ojan Vafai.

        Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.
        https://bugs.webkit.org/show_bug.cgi?id=52781

        The test was rebaselined to have interleaved space and non-breaking space.

        * editing/inserting/insert-composition-whitespace-expected.txt:
        * editing/inserting/insert-composition-whitespace.html:
2011-01-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Ojan Vafai.

        Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.
        https://bugs.webkit.org/show_bug.cgi?id=52781

        The bug was caused by stringWithRebalancedWhitespace's replacing the space at the beginning of a paragraph
        and the end of a paragraph by a non-breaking space after it replaced two consecutive spaces by a space and
        non-breaking space pattern, thereby replacing more spaces by non-breaking spaces than needed.

        Rewrote the function using Vector<UChar> to fix the bug. New function no longer calls String::replace
        multiple times but instead it traverses through the string and replaces a space that immediately follows
        another space or appears at the beginning of a paragraph or at the end of a paragraph by a non-break space.

        * editing/CompositeEditCommand.cpp:
        * editing/htmlediting.cpp:
        (WebCore::stringWithRebalancedWhitespace): Written.
        * editing/htmlediting.h:
        (WebCore::isWhitespace): Removed from CompositeEditCommand.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 25 Jan 2011 02:56:50 +0000 (02:56 +0000)]
2011-01-24  Martin Robinson  <mrobinson@igalia.com>

        Skip one more crashing test.

        * platform/gtk/Skipped: Skip a test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
andersca@apple.com [Tue, 25 Jan 2011 02:48:51 +0000 (02:48 +0000)]
Fix build.

* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 25 Jan 2011 02:39:50 +0000 (02:39 +0000)]
2011-01-24  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Web Audio API: port FFTFrame to FFTW
        https://bugs.webkit.org/show_bug.cgi?id=52989

        Ported FFTFrame class to the open-source FFTW library. Tested with
        unit tests from Chris Rogers. Made preliminary changes to GYP
        files for conditional compilation of these files; will need to be
        adjusted once FFTW is integrated as third-party source.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/audio/FFTFrame.h:
        * platform/audio/fftw: Added.
        * platform/audio/fftw/FFTFrameFFTW.cpp: Added.
        (WebCore::FFTFrame::FFTFrame):
        (WebCore::FFTFrame::~FFTFrame):
        (WebCore::FFTFrame::multiply):
        (WebCore::FFTFrame::doFFT):
        (WebCore::FFTFrame::doInverseFFT):
        (WebCore::FFTFrame::cleanup):
        (WebCore::FFTFrame::realData):
        (WebCore::FFTFrame::imagData):
        (WebCore::FFTFrame::fftwPlanForSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 25 Jan 2011 02:38:10 +0000 (02:38 +0000)]
2011-01-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Reset the page scale factor on standard frame loads
        https://bugs.webkit.org/show_bug.cgi?id=53058
        <rdar://problem/8908844>

        Add a symbol needed by WebKit2.

        * WebCore.exp.in:
2011-01-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Reset the page scale factor on standard frame loads
        https://bugs.webkit.org/show_bug.cgi?id=53058
        <rdar://problem/8908844>

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::scaleWebView):
        Don't set m_viewScaleFactor here. It will be set in viewScaleFactorDidChange.

        (WebKit::WebPageProxy::viewScaleFactorDidChange):
        Update m_viewScaleFactor.

        * UIProcess/WebPageProxy.h:
        Add viewScaleFactorDidChange.

        * UIProcess/WebPageProxy.messages.in:
        Add ViewScaleFactorDidChange message.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
        Set the scale factor.

        (WebKit::WebFrameLoaderClient::restoreViewState):
        Inform the UI process about the new view scale factor.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::scaleWebView):
        Send a ViewScaleFactorDidChange message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 25 Jan 2011 02:21:49 +0000 (02:21 +0000)]
2011-01-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Stop instantiating legacy editing positions in InsertTextCommand, MoveSelectionCommand,
        ReplaceSelectionCommand, SelectionController, SpellChecker, TypingCommand, and markup.cpp
        https://bugs.webkit.org/show_bug.cgi?id=52676

        Stop instantiating legacy editing positions in the following files.

        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::prepareForTextInsertion):
        (WebCore::InsertTextCommand::performTrivialReplace):
        (WebCore::InsertTextCommand::input):
        (WebCore::InsertTextCommand::insertTab):
        * editing/MoveSelectionCommand.cpp:
        (WebCore::MoveSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
        (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded):
        (WebCore::ReplaceSelectionCommand::doApply):
        (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR):
        (WebCore::ReplaceSelectionCommand::performTrivialReplace):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelectionFromNone):
        * editing/SpellChecker.cpp:
        (WebCore::SpellChecker::didCheck):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::makeEditableRootEmpty):
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * editing/markup.cpp:
        (WebCore::StyledMarkupAccumulator::appendText):
        (WebCore::StyledMarkupAccumulator::serializeNodes):
        (WebCore::highestAncestorToWrapMarkup):
        (WebCore::createMarkup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 25 Jan 2011 02:08:52 +0000 (02:08 +0000)]
2011-01-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders Carlsson.

        Use designated temp directory for the database for WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=53052

        Adopt the new WK2 API for this.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::libraryPathForTesting):
        (WTR::TestController::initialize):
        * WebKitTestRunner/TestController.h:
        * WebKitTestRunner/mac/TestControllerMac.mm:
        (WTR::TestController::platformLibraryPathForTesting):
        * WebKitTestRunner/qt/TestControllerQt.cpp:
        (WTR::TestController::platformLibraryPathForTesting):
        * WebKitTestRunner/win/TestControllerWin.cpp:
        (WTR::TestController::platformLibraryPathForTesting):
2011-01-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders Carlsson.

        Use designated temp directory for the database for WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=53052

        Add the API necessary to support this. Database path is now
        determined on the UI process side and passed to the Web process.
        Reviewed by Anders Carlsson.

        * GNUmakefile.am:
        * Shared/WebProcessCreationParameters.cpp:
        (WebKit::WebProcessCreationParameters::encode):
        (WebKit::WebProcessCreationParameters::decode):
        * Shared/WebProcessCreationParameters.h:
        * UIProcess/API/C/WKContext.cpp:
        (WKContextSetDatabaseDirectory):
        * UIProcess/API/C/WKContextPrivate.h:
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::ensureWebProcess):
        (WebKit::WebContext::databaseDirectory):
        * UIProcess/WebContext.h:
        (WebKit::WebContext::setDatabaseDirectory):
        * UIProcess/mac/WebContextMac.mm:
        (WebKit::WebContext::platformDefaultDatabaseDirectory):
        * UIProcess/qt/WebContextQt.cpp:
        (WebKit::WebContext::platformDefaultDatabaseDirectory):
        * UIProcess/win/WebContextWin.cpp:
        (WebKit::WebContext::platformDefaultDatabaseDirectory):
        * WebKit2.pro:
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
        (WebKit::WebDatabaseManager::initialize):
        (WebKit::WebDatabaseManager::WebDatabaseManager):
        * WebProcess/WebCoreSupport/WebDatabaseManager.h:
        * WebProcess/WebCoreSupport/gtk/WebDatabaseManagerGtk.cpp: Removed.
        * WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm: Removed.
        * WebProcess/WebCoreSupport/qt/WebDatabaseManagerQt.cpp: Removed.
        * WebProcess/WebCoreSupport/win/WebDatabaseManagerWin.cpp: Removed.
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::WebProcess):
        (WebKit::WebProcess::initializeWebProcess):
        * WebProcess/com.apple.WebProcess.sb:
        * WebProcess/mac/WebProcessMac.mm:
        (WebKit::initializeSandbox):
        * win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 25 Jan 2011 02:05:30 +0000 (02:05 +0000)]
2011-01-24  Martin Robinson  <mrobinson@igalia.com>

        Skipping failing tests after r76555.

        * platform/gtk/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Peter Kasting <pkasting@google.com>
commit-queue@webkit.org [Tue, 25 Jan 2011 01:36:51 +0000 (01:36 +0000)]
2011-01-24  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Adler.

        Roll back r67261 ("Don't fire onclick on middle clicks") due to
        regressions.
        https://bugs.webkit.org/show_bug.cgi?id=46733

        * fast/events/mouse-click-events-expected.txt:
        * fast/events/script-tests/mouse-click-events.js:
2011-01-24  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Adler.

        Roll back r67261 ("Don't fire onclick on middle clicks") due to
        regressions.
        https://bugs.webkit.org/show_bug.cgi?id=46733

        * html/HTMLAnchorElement.cpp:
        (WebCore::isLinkClick):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::preDispatchEventHandler):
        (WebCore::HTMLInputElement::postDispatchEventHandler):
        (WebCore::HTMLInputElement::defaultEventHandler):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDoubleClickEvent):
        (WebCore::EventHandler::handleMouseReleaseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 25 Jan 2011 00:58:57 +0000 (00:58 +0000)]
2011-01-24  Xiaomei Ji  <xji@chromium.org>

        Unreviewed.

        Skip cjk-segmentation.html (introduced in r76548) in QT.
        QT skipped range-expand.html, skip cjk-segmentation as well.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 25 Jan 2011 00:47:18 +0000 (00:47 +0000)]
2011-01-24  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Many DOM XHTML tests time out
        https://bugs.webkit.org/show_bug.cgi?id=52553

        * platform/gtk/Skipped: Unskip tests which are no longer timing out.
2011-01-24  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Many DOM XHTML tests time out
        https://bugs.webkit.org/show_bug.cgi?id=52553

        Properly handle the situation where a synchronous load fails before the inner
        event loop has started. In this case, we simply do not run the inner event loop,
        or else it will block indefinitely (since no GIO or libsoup callbacks will fire).

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::loadResourceSynchronously): Bail out of a synchronous
        load if it fails up front.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a new Leopard test bot.
lforschler@apple.com [Tue, 25 Jan 2011 00:46:02 +0000 (00:46 +0000)]
Add a new Leopard test bot.

Reviewed by Stephanie Lewis.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Tue, 25 Jan 2011 00:35:38 +0000 (00:35 +0000)]
2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Adam Barth.

        Add EFL Builder to core waterfall
        https://bugs.webkit.org/show_bug.cgi?id=52704

        Add EFL Builder to the core waterfall again.

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 25 Jan 2011 00:09:22 +0000 (00:09 +0000)]
2011-01-24  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectation update for r76548.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix.
bfulgham@webkit.org [Mon, 24 Jan 2011 23:40:38 +0000 (23:40 +0000)]
Unreviewed build fix.

* win/WebKit2.vcproj: Don't build the CG Utilities when building
without CG support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76551 268f45cc-cd09-0410-ab3c-d52691b4dbfc