dcheng@chromium.org [Wed, 1 Jun 2011 21:13:06 +0000 (21:13 +0000)]
2011-06-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887
* fast/events/drag-image-filename-expected.txt: Added.
* fast/events/drag-image-filename.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
2011-06-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887
We try to guess an appropriate filename when dragging out images. In order, we try to use:
- The filename suggested in the HTTP header.
- The last path component of the source URL.
- The alt text.
This matches the behavior of the other WebKit ports.
Test: fast/events/drag-image-filename.html
* platform/chromium/ClipboardChromium.cpp:
(WebCore::writeImageToDataObject):
* platform/chromium/ClipboardChromiumMac.cpp:
(WebCore::isInvalidFileCharacter):
(WebCore::ClipboardChromium::validateFileName):
2011-06-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::dumpFilenameBeingDragged):
* DumpRenderTree/chromium/EventSender.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 1 Jun 2011 21:09:05 +0000 (21:09 +0000)]
2011-06-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
nrwt: make webaudio work w/o content-length header
https://bugs.webkit.org/show_bug.cgi?id=61819
* Scripts/webkitpy/layout_tests/layout_package/printing.py:
* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Wed, 1 Jun 2011 21:00:56 +0000 (21:00 +0000)]
2011-06-01 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Text is scaled in a stair-step pattern
https://bugs.webkit.org/show_bug.cgi?id=60317
Stop scaling the specified font to the actual on-screen value when font-rendering:
geometricPrecision is specified, but instead scale the graphics context. This allows
us to scale text up and down smoothly.
Test: svg/text/scaling-font-with-geometric-precision.html
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
2011-06-01 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Text is scaled in a stair-step pattern
https://bugs.webkit.org/show_bug.cgi?id=60317
Stop scaling the specified font to the actual on-screen value when font-rendering:
geometricPrecision is specified, but instead scale the graphics context. This allows
us to scale text up and down smoothly.
* platform/mac/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
* platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
* svg/text/scaling-font-with-geometric-precision.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Wed, 1 Jun 2011 20:58:34 +0000 (20:58 +0000)]
2011-06-01 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintResizer to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61883
Switch paintResizer to take an IntPoint instead of a pair of ints.
No new tests as this is simple refactoring.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintResizer):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 1 Jun 2011 20:57:15 +0000 (20:57 +0000)]
2011-06-01 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Page layout messed up after exiting full screen at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=61755
* fullscreen/full-screen-zIndex-after-expected.txt: Added.
* fullscreen/full-screen-zIndex-after.html: Added.
* platform/mac/fullscreen/full-screen-zIndex-after-expected.png: Added.
2011-06-01 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Page layout messed up after exiting full screen at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=61755
<rdar://problem/
9525277>
Test: fullscreen/full-screen-zIndex-after.html
Fix the incomplete implementation of r87660. Make parameters to
setContainsFullScreenElementRecursively() in webkitWillExitFullScreenForElement() match those
in webkitWillEnterFullScreenForElement(), so the ancestors' flags do not become
inconsistent..
* dom/Document.cpp:
(WebCore::Document::webkitWillExitFullScreenForElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 1 Jun 2011 20:52:44 +0000 (20:52 +0000)]
2011-06-01 Adam Barth <abarth@webkit.org>
Image baselines for this test. More to follow once the bots catch up.
* platform/chromium-linux-x86/svg/custom/embedding-external-svgs-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/embedding-external-svgs-expected.txt: Added.
* platform/chromium-linux/svg/custom/embedding-external-svgs-expected.png: Added.
* platform/chromium-linux/svg/custom/embedding-external-svgs-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 1 Jun 2011 20:42:30 +0000 (20:42 +0000)]
2011-06-01 Adam Barth <abarth@webkit.org>
Image baselines for these platforms.
* platform/chromium-linux-x86/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-linux-x86/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
* platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
* platform/chromium-win-vista/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-win-vista/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Wed, 1 Jun 2011 20:38:14 +0000 (20:38 +0000)]
2011-06-01 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintScrollCorner to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61874
Changing paintScrollCorner to take an IntPoint representing the paint
offset instead of a pair of ints.
No new tests as this is simple refactoring.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintScrollCorner):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 1 Jun 2011 20:24:28 +0000 (20:24 +0000)]
2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
SVG graphics do not actually work in IMG tags or as background-image properties
https://bugs.webkit.org/show_bug.cgi?id=18228
Adding the nice testcase from the bug 18228, all issues are fully resolved now.
* platform/mac/svg/custom/embedding-external-svgs-expected.png: Added.
* platform/mac/svg/custom/embedding-external-svgs-expected.txt: Added.
* svg/custom/embedding-external-svgs.xhtml: Added.
* svg/custom/resources/spinner.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 1 Jun 2011 20:14:36 +0000 (20:14 +0000)]
2011-06-01 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Flash of old video frame at the end of full screen transition
https://bugs.webkit.org/show_bug.cgi?id=61752
Add a new method and message, DisposeOfLayerClient, which will invalidate and release
the WKRemoteLayerClient used during the full-screen animation. This ensures that
the root layer used for the full-screen animation will be in a clean state at the start
of the next transition.
* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::disposeOfLayerClient): Added.
* UIProcess/WebFullScreenManagerProxy.h:
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): Call disposeOfLayerClient.
* WebProcess/FullScreen/WebFullScreenManager.h:
(WebKit::WebFullScreenManager::disposeOfLayerClient): Added.
* WebProcess/FullScreen/WebFullScreenManager.messages.in: Added DisposeOfLayerClient.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::disposeOfLayerClient): Added, invalidates and clears m_rootLayerClient.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 1 Jun 2011 20:09:04 +0000 (20:09 +0000)]
2011-06-01 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Add single character lookup cache to IdentifierArena
https://bugs.webkit.org/show_bug.cgi?id=61879
Add a simple lookup cache for single ascii character
identifiers. Produces around a 2% improvement in parse
time for my adhoc parser test.
* parser/ParserArena.h:
(JSC::IdentifierArena::IdentifierArena):
(JSC::IdentifierArena::clear):
(JSC::IdentifierArena::makeIdentifier):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Wed, 1 Jun 2011 19:52:13 +0000 (19:52 +0000)]
2011-06-01 Kenneth Russell <kbr@google.com>
Reviewed by Nate Chapin.
[V8] Optimize fetches of indexed properties in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=61821
Avoid allocating garbage in affected custom bindings. This speeds
up one test case by at least a factor of two. No new tests;
covered by existing layout tests (typed array and otherwise).
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::V8InspectorFrontendHost::showContextMenuCallback):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::getMessagePortArray):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::jsArrayToFloatArray):
(WebCore::jsArrayToIntArray):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 1 Jun 2011 19:20:04 +0000 (19:20 +0000)]
2011-06-01 Adam Barth <abarth@webkit.org>
Add new results for this new test. Our results are different by one
pixel. Mac results likely to follow once those bots catch up.
* platform/chromium-linux-x86/svg/as-image: Added.
* platform/chromium-linux-x86/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
* platform/chromium-linux/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
* platform/chromium-win-vista/svg/as-image: Added.
* platform/chromium-win-vista/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 1 Jun 2011 18:58:26 +0000 (18:58 +0000)]
2011-06-01 Ryosuke Niwa <rniwa@webkit.org>
Skip editing/pasteboard/drag-drop-list.html on GTK after r87778
since smart paste isn't supported by GTK (tracked by the bug 61661).
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 1 Jun 2011 18:54:48 +0000 (18:54 +0000)]
Build fix after r87831
* UIProcess/win/WebView.cpp:
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
Added some HAVE(WKQCA) guards.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 1 Jun 2011 18:44:12 +0000 (18:44 +0000)]
2011-06-01 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
LayoutTests/editing/pasteboard/drag-drop-list fails on webkit2
https://bugs.webkit.org/show_bug.cgi?id=61871
Renames editing/pasteboard/
4861080.html to drag-drop-list.html, since it was renamed in r87778.
* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 1 Jun 2011 18:41:23 +0000 (18:41 +0000)]
Delete a bunch of dead code in DrawingAreaImpl
LayerTreeHost::participatesInDisplay always returns false now, which means a bunch of code
in DrawingAreaImpl no longer runs.
Cleanup after fixing <http://webkit.org/b/58054>
<rdar://problem/
9249839> REGRESSION (WebKit2): Accelerated CSS animations have a lower
framerate than in WebKit1
Reviewed by Anders Carlsson.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::didUpdate):
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::scheduleDisplay):
(WebKit::DrawingAreaImpl::displayTimerFired):
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/LayerTreeHost.h:
Reverted r82959.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 1 Jun 2011 18:39:19 +0000 (18:39 +0000)]
Render accelerated content into a web process-owned child HWND
This allows us to use WKCACFView's far more efficient kWKCACFViewDrawingDestinationWindow
mode, which gives us asynchronous rendering on a background thread and doesn't require us to
read bits off the GPU back into system memory.
A new class, WKCACFViewWindow, represents the child HWND. The child HWND is placed at the
bottom of the z-order so it won't obscure any other child HWNDs (i.e., windowed plugins).
The child HWND is made transparent to mouse events so that WKView will continue to receive
mouse events even though it is obscured by the child HWND.
There is now a bunch of dead code in DrawingAreaImpl to handle our old rendering model. I'll
remove that in a future patch.
Fixes <http://webkit.org/b/58054> <rdar://problem/
9249839> REGRESSION (WebKit2): Accelerated
CSS animations have a lower framerate than in WebKit1
Reviewed by Anders Carlsson.
* Shared/LayerTreeContext.h: Added HWND member on Windows.
* Shared/win/CoalescedWindowGeometriesUpdater.cpp:
(WebKit::CoalescedWindowGeometriesUpdater::updateGeometries):
* Shared/win/CoalescedWindowGeometriesUpdater.h:
Added new BringToTopOrNot argument. Allows the caller to specify that all windows being
updated should also be brought to the top of the z-order.
* Shared/win/LayerTreeContextWin.cpp:
(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):
Implemented based on new window member.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Initialize new member.
(WebKit::WebView::onSizeEvent): Resize the layer host window to cover our entire view, if we
have one.
(WebKit::WebView::enterAcceleratedCompositingMode): Store, position, and show the layer host
window.
(WebKit::WebView::exitAcceleratedCompositingMode): Destroy the layer host window.
(WebKit::WebView::updateChildWindowGeometries): Updated for change to
CoalescedWindowGeometriesUpdater.
* UIProcess/win/WebView.h: Added m_layerHostWindow member.
* WebProcess/WebPage/LayerTreeHost.h: Added scheduleChildWindowGeometryUpdate.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::supportsAcceleratedCompositing): Simplified by using
WKCACFViewWindow.
(WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin): Removed initialization of a removed
member.
(WebKit::LayerTreeHostCAWin::platformInitialize): Changed to use WKCACFViewWindow,
kWKCACFViewDrawingDestinationWindow, and to initialize the LayerTreeContext.
(WebKit::LayerTreeHostCAWin::invalidate): Leak our window and tell it to clean up after
itself. The UI process will take care of destroying the window when it finishes switching
out of accelerated compositing mode. Removed a WKCACFViewUpdate call that is now handled by
WKCACFViewWindow.
(WebKit::LayerTreeHostCAWin::scheduleChildWindowGeometryUpdate): Added. Calls through to
m_geometriesUpdater.
(WebKit::LayerTreeHostCAWin::sizeDidChange): Updated to use WKCACFViewWindow.
(WebKit::LayerTreeHostCAWin::contextDidChange): Update child window geometries now to keep
them (almost) in sync with the accelerated content. <http://webkit.org/b/61867> covers the
slight asynchrony that still exists.
(WebKit::LayerTreeHostCAWin::setRootCompositingLayer): Don't flush any changes when we don't
have a root layer. This prevents a flash of white when switching out of compositing mode.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added m_window and m_geometriesUpdater.
Removed code related to the old, synchronous display model.
* WebProcess/WebPage/ca/win/WKCACFViewWindow.cpp: Added.
(WebKit::WKCACFViewWindow::WKCACFViewWindow): Initialize members and create our window.
(WebKit::WKCACFViewWindow::~WKCACFViewWindow): Destroy our window if needed.
(WebKit::WKCACFViewWindow::onCustomDestroy): Just call ::DestroyWindow.
(WebKit::WKCACFViewWindow::onDestroy): Tell our view not to render into our window anymore.
(WebKit::WKCACFViewWindow::onEraseBackground): Tell Windows not to erase us.
(WebKit::WKCACFViewWindow::onNCDestroy): Clear out m_window since it's now pointing to a
destroy window, and destroy ourselves if requested.
(WebKit::WKCACFViewWindow::onPaint): Tell the view to draw, then clear our invalid region.
(WebKit::WKCACFViewWindow::onPrintClient): Tell our view to draw into the given HDC.
(WebKit::WKCACFViewWindow::registerClass): Register our class (duh).
(WebKit::WKCACFViewWindow::staticWndProc): Get the WKCACFViewWindow pointer, or store the
pointer if needed, then call through to wndProc.
(WebKit::WKCACFViewWindow::wndProc): Call out to the appropriate handler function.
* WebProcess/WebPage/ca/win/WKCACFViewWindow.h: Added.
(WebKit::WKCACFViewWindow::setDeletesSelfWhenWindowDestroyed): Simple setter.
(WebKit::WKCACFViewWindow::window): Simple getter.
* WebProcess/WebPage/win/DrawingAreaImplWin.cpp:
(WebKit::DrawingAreaImpl::scheduleChildWindowGeometryUpdate): Let the LayerTreeHost handle
the geometry update, if we have one.
* win/WebKit2.vcproj: Added WKCACFViewWindow files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Wed, 1 Jun 2011 18:38:35 +0000 (18:38 +0000)]
2011-06-01 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Explictly request the size of a pointer in malloc. Otherwise this
explodes in 64bit architectures, at least.
* webkit/webkitwebplugin.cpp:
(webkit_web_plugin_get_mimetypes): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 1 Jun 2011 18:36:13 +0000 (18:36 +0000)]
2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
Permanent red background when SVG is used as a background image (DEBUG ONLY)
https://bugs.webkit.org/show_bug.cgi?id=16518
The problem seems gone, I can't reproduce it anymore, add Beths test to svg/as-image.
* platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
* platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
* svg/as-image/resources/svg-as-background-with-relative-size.svg: Added.
* svg/as-image/svg-as-background-with-relative-size.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Wed, 1 Jun 2011 18:16:14 +0000 (18:16 +0000)]
2011-06-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Fix the Phonon build when logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=61869
No new tests needed.
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Add missing guards.
(WebCore::MediaPlayerPrivatePhonon::networkState):
(WebCore::MediaPlayerPrivatePhonon::readyState):
(WebCore::MediaPlayerPrivatePhonon::updateStates):
(WebCore::MediaPlayerPrivatePhonon::stateChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 1 Jun 2011 18:12:53 +0000 (18:12 +0000)]
2011-06-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Antti Koivisto.
Do not use the pushed style selector if it is not equal to the
parent document's style selector. It usually means that it is
in a bad state, e.g. already cleared.
https://bugs.webkit.org/show_bug.cgi?id=61737
* dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 1 Jun 2011 18:08:07 +0000 (18:08 +0000)]
2011-05-31 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Freezing a function and its prototype causes browser to crash.
https://bugs.webkit.org/show_bug.cgi?id=61758
Add test to ensure correct behaviour
* fast/js/preventExtensions-expected.txt:
* fast/js/script-tests/preventExtensions.js:
(f):
2011-05-31 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Freezing a function and its prototype causes browser to crash.
https://bugs.webkit.org/show_bug.cgi?id=61758
Make JSObject::preventExtensions virtual so that we can override it
and instantiate all lazy
* JavaScriptCore.exp:
* runtime/JSFunction.cpp:
(JSC::createPrototypeProperty):
(JSC::JSFunction::preventExtensions):
(JSC::JSFunction::getOwnPropertySlot):
* runtime/JSFunction.h:
* runtime/JSObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::seal):
(JSC::JSObject::seal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Wed, 1 Jun 2011 17:59:02 +0000 (17:59 +0000)]
2011-06-01 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch RenderLineBoxList intersection functions to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61794
Switching rangeIntersectsRect, anyLineIntersectsRect, and lineIntersectsDirtyRect
to take IntPoint instead of a tx/ty to represent the offset to be applied match
the rect and lines' coordinates.
No new tests since this is merely refactoring.
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
* rendering/RenderLineBoxList.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 17:55:07 +0000 (17:55 +0000)]
2011-06-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Andreas Kling.
[Qt][WK2] Add QGLWidget viewport support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=61802
Add command line parameter and menu item to MiniBrowser application
enabling use of QGLWidget for browser viewport.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::toggleGLViewport):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Wed, 1 Jun 2011 17:41:25 +0000 (17:41 +0000)]
2011-06-01 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Utility methods for UA spellchecking
https://bugs.webkit.org/show_bug.cgi?id=61788
Adds a couple of utility methods needed to implement some aspects
of spell checking support in a browser.
* webkit/webkitwebframe.cpp:
(webkit_web_frame_replace_selection): method to replace the current
selection with a string of text.
(webkit_web_frame_get_range_for_word_around_caret): returns the DOM
range for the word where the caret/selection currently is.
* webkit/webkitwebframe.h: declare new methods.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 1 Jun 2011 17:36:56 +0000 (17:36 +0000)]
2011-05-19 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Don't split long, narrow layers into multiple tiles.
https://bugs.webkit.org/show_bug.cgi?id=60821
These tests have imperceptible pixel changes on horizontal scrollbars
as a result of this patch. Marking them as failing temporarily so
that they can be rebaselined.
* platform/chromium/test_expectations.txt:
2011-05-19 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Don't split long, narrow layers into multiple tiles.
https://bugs.webkit.org/show_bug.cgi?id=60821
This changes the heuristic for when we tile layers to be less bad
about wasting texture space. Long, narrow layers that are tiled with
a large tile size waste texture space. Now layers are only tiled if
they are above 512px in one dimension and extend into a second tile in
the other. If they are not tiled, their layer texture will exactly
fit their layer bounds. In particular, this will help scrollbars.
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::updateLayerSize):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::maxTextureSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 17:19:42 +0000 (17:19 +0000)]
2011-06-01 Cary Clark <caryclark@google.com>
Reviewed by Eric Seidel.
Ready Chromium port for Skia on Mac
https://bugs.webkit.org/show_bug.cgi?id=61800
Skia on Mac is not enabled. The executing
code is unchanged, so there are no new tests.
* platform/chromium/DragImageRef.h:
Use Skia for DragImageRef instead of CG.
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):
Get the total matrix from Skia for the scrollbar.
Convert the SkCanvas into a CGContext to draw.
* platform/chromium/ThemeChromiumMac.mm:
(WebCore::paintStepper):
Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 1 Jun 2011 17:03:55 +0000 (17:03 +0000)]
2011-06-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Print out autogen arguments when they differ from the last set, to help
with debugging build issues.
* Scripts/webkitdirs.pm: Print out previous and current build arguments
when they differ.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Wed, 1 Jun 2011 16:58:35 +0000 (16:58 +0000)]
2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
https://bugs.webkit.org/show_bug.cgi?id=59345
KURL and QUrl disagree whether certain URLs are valid or not. The regression here
was caused by the fact that now KURL accepts "http:/example.com" (note only one
slash) and our test case used a strange edge case that's transformed into a
"one-slash" URL that now KURL can handle.
QtWebKit approach in this case is to do a best effort and accept the QUrl if KURL
can understand it. So I've updated the test to use a more meaningful example and
show that an invalid URL gets converted to a valid URL if possible.
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::setUrlToInvalid):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sjl@chromium.org [Wed, 1 Jun 2011 16:27:21 +0000 (16:27 +0000)]
2011-06-01 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Remove layout test http/tests/media/video-seekable-stall
http/tests/media/video-seekable-stall.html fails on the Leopard Commit Queue Machine
https://bugs.webkit.org/show_bug.cgi?id=35271
* http/tests/media/video-seekable-stall-expected.txt: Removed.
* http/tests/media/video-seekable-stall.html: Removed.
* platform/chromium-linux/http/tests/media/video-seekable-stall-expected.png: Removed.
* platform/chromium-win/http/tests/media/video-seekable-stall-expected.png: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 1 Jun 2011 16:22:22 +0000 (16:22 +0000)]
2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, added new baselines for GTK after r87779.
* platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
* platform/gtk/svg/hixie/intrinsic/001-expected.png: Added.
* platform/gtk/svg/hixie/intrinsic/001-expected.txt: Added.
* platform/gtk/svg/hixie/intrinsic/003-expected.png: Added.
* platform/gtk/svg/hixie/intrinsic/003-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 1 Jun 2011 16:15:31 +0000 (16:15 +0000)]
2011-06-01 Adam Barth <abarth@webkit.org>
Add baselines for these tests.
* platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 1 Jun 2011 16:14:33 +0000 (16:14 +0000)]
2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, added new baseline for GTK after r87726.
* platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.
* platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 1 Jun 2011 16:14:06 +0000 (16:14 +0000)]
2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, added new baselines for GTK after r87721.
* platform/gtk/svg/custom/invalid-stroke-hex-expected.txt: Added.
* platform/gtk/svg/custom/invalid-stroke-hex-expected.png: Added.
* platform/gtk/svg/custom/invalid-uri-stroke-expected.txt: Added.
* platform/gtk/svg/custom/invalid-uri-stroke-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 1 Jun 2011 16:13:16 +0000 (16:13 +0000)]
2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, added new baseline for GTK after r87680.
* platform/gtk/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
* platform/gtk/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 1 Jun 2011 16:12:23 +0000 (16:12 +0000)]
2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, added new baseline for GTK after r87605.
* platform/gtk/svg/wicd/test-scalable-background-image2-expected.txt: Added.
* platform/gtk/svg/wicd/test-scalable-background-image2-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 1 Jun 2011 16:11:40 +0000 (16:11 +0000)]
2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, added new baselines for GTK after r87526.
* platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
* platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
* platform/gtk/svg/custom/object-no-size-attributes-expected.png: Added.
* platform/gtk/svg/custom/object-no-size-attributes-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-explicit-height-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-explicit-height-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-explicit-width-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-explicit-width-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
* platform/gtk/svg/custom/object-sizing-no-width-height-expected.png: Added.
* platform/gtk/svg/custom/object-sizing-no-width-height-expected.txt: Added.
* platform/gtk/svg/wicd/rightsizing-grid-expected.png: Added.
* platform/gtk/svg/wicd/rightsizing-grid-expected.txt: Added.
* platform/gtk/svg/wicd/test-rightsizing-a-expected.png: Added.
* platform/gtk/svg/wicd/test-rightsizing-a-expected.txt: Added.
* platform/gtk/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/gtk/svg/wicd/test-rightsizing-b-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 1 Jun 2011 16:10:16 +0000 (16:10 +0000)]
2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, added new baseline for GTK after r87387.
* platform/gtk/fast/borders/border-antialiasing-expected.txt: Added.
* platform/gtk/fast/borders/border-antialiasing-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 1 Jun 2011 16:08:24 +0000 (16:08 +0000)]
2011-06-01 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] run-launcher should run MiniBrowser in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=61858
* Scripts/run-launcher: Check whether -2 command line option has
been passed and run MiniBrowser instead of GtkLauncher.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 1 Jun 2011 16:01:12 +0000 (16:01 +0000)]
2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
SVGs with a viewbox specified do not seem to work as SVGImages
https://bugs.webkit.org/show_bug.cgi?id=16517
SVGs with a viewBox work as background image nowadays, add a testcase covering it, originally from Beth Dakin.
* platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.png: Added.
* platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
* svg/as-image/resources/green-relative-size-rect-with-viewBox.svg: Added.
* svg/as-image/svg-as-background-with-viewBox.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 1 Jun 2011 15:28:13 +0000 (15:28 +0000)]
Route plugin window geometry updates through the DrawingArea
This will allow the geometry updates to be handled by the LayerTreeHost in compositing mode
in the future.
More rep work for <http://webkit.org/b/58054> <rdar://problem/
9249839> REGRESSION (WebKit2):
Accelerated CSS animations have a lower framerate than in WebKit1
Reviewed by Anders Carlsson.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate): Tell the DrawingArea, not the
WebPage, about the geometry update.
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/win/DrawingAreaImplWin.cpp: Added.
(WebKit::DrawingAreaImpl::scheduleChildWindowGeometryUpdate):
Moved code here...
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/win/WebPageWin.cpp:
...from here.
* win/WebKit2.vcproj: Added DrawingAreaImplWin.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 1 Jun 2011 15:12:16 +0000 (15:12 +0000)]
Move WebView's window geometry updating code to a new class
This will allow us to share this code with LayerTreeHostCAWin.
Prep work for <http://webkit.org/b/58054> <rdar://problem/
9249839> REGRESSION (WebKit2):
Accelerated CSS animations have a lower framerate than in WebKit1
Reviewed by Anders Carlsson.
* Shared/win/CoalescedWindowGeometriesUpdater.cpp: Added.
(WebKit::CoalescedWindowGeometriesUpdater::CoalescedWindowGeometriesUpdater):
(WebKit::CoalescedWindowGeometriesUpdater::~CoalescedWindowGeometriesUpdater):
Simple constructor/destructor.
(WebKit::CoalescedWindowGeometriesUpdater::addPendingUpdate):
(WebKit::setWindowRegion):
(WebKit::CoalescedWindowGeometriesUpdater::updateGeometries):
* Shared/win/CoalescedWindowGeometriesUpdater.h: Added.
Moved code here...
* UIProcess/win/WebView.cpp:
(WebKit::WebView::scheduleChildWindowGeometryUpdate):
(WebKit::WebView::updateChildWindowGeometries):
* UIProcess/win/WebView.h:
...from here.
* win/WebKit2.vcproj: Added new files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 1 Jun 2011 14:51:08 +0000 (14:51 +0000)]
Windows build fix after r87755
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled): Fixed
typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 1 Jun 2011 14:34:11 +0000 (14:34 +0000)]
2011-06-01 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: allow opening inspector for existing workers
https://bugs.webkit.org/show_bug.cgi?id=61853
Added sidebar pane with a list of all workers. Each worker has a check box
that allows opening inspector for the worker.
* inspector/Inspector.json:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didStartWorkerContext):
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::connectToWorkerContext):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::disconnectFromWorkerContext):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::connectToWorker):
(WebCore::InspectorWorkerAgent::disconnectFromWorker):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
* inspector/InspectorWorkerAgent.h:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/Settings.js:
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager):
(WebInspector.WorkerManager.prototype._workerCreated):
(WebInspector.WorkerManager.prototype._sendMessageToWorkerInspector):
(WebInspector.WorkerManager.prototype.openWorkerInspector):
(WebInspector.WorkerManager.prototype.closeWorkerInspector):
(WebInspector.WorkerManager.prototype._workerInspectorClosing):
(WebInspector.WorkerMessageForwarder):
(WebInspector.WorkerMessageForwarder.prototype.workerCreated):
(WebInspector.WorkerMessageForwarder.prototype.dispatchMessageFromWorker):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane):
(WebInspector.WorkersSidebarPane.prototype.addWorker):
(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._workerAdded):
(WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
(WebInspector.WorkerListSidebarPane.prototype._workerInspectorClosed):
(WebInspector.WorkerListSidebarPane.prototype._addWorker):
(WebInspector.WorkerListSidebarPane.prototype._createCheckbox):
(WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
* workers/Worker.cpp:
(WebCore::Worker::notifyFinished):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 14:11:23 +0000 (14:11 +0000)]
2011-06-01 Shishir Agrawal <shishir@chromium.org>
Reviewed by Tony Gentilcore.
Renaming the Page Visibility attributes as per the modified spec draft.
https://bugs.webkit.org/show_bug.cgi?id=61825
Spec draft:
http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html
- Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
- The attribute webkitIsVisible needs to change to webkitHidden
* fast/events/page-visibility-iframe-delete-test.html:
* fast/events/page-visibility-iframe-move-test-expected.txt:
* fast/events/page-visibility-iframe-move-test.html:
* fast/events/page-visibility-iframe-propagation-test-expected.txt:
* fast/events/page-visibility-iframe-propagation-test.html:
* fast/events/page-visibility-transition-test-expected.txt:
* fast/events/page-visibility-transition-test.html:
2011-06-01 Shishir Agrawal <shishir@chromium.org>
Reviewed by Tony Gentilcore.
Renaming the Page Visibility attributes as per the modified spec draft.
https://bugs.webkit.org/show_bug.cgi?id=61825
Spec draft:
http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html
- Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
- The attribute webkitIsVisible needs to change to webkitHidden
* dom/Document.cpp:
(WebCore::Document::webkitHidden):
(WebCore::Document::dispatchVisibilityStateChangeEvent):
* dom/Document.h:
* dom/Document.idl:
* dom/EventNames.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 1 Jun 2011 14:10:15 +0000 (14:10 +0000)]
2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Remove duplicated code in various computeReplacedLogical*() functions
https://bugs.webkit.org/show_bug.cgi?id=61860
Centralize this calculation in RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth:
int minLogicalWidth = computeReplacedLogicalWidthUsing(style()->logicalMinWidth());
int maxLogicalWidth = !includeMaxWidth || style()->logicalMaxWidth().isUndefined() ? logicalWidth : computeReplacedLogicalWidthUsing(style()->logicalMaxWidth());
return max(minLogicalWidth, min(logicalWidth, maxLogicalWidth));
Centralize this calculation in RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight:
int minLogicalHeight = computeReplacedLogicalHeightUsing(style()->logicalMinHeight());
int maxLogicalHeight = style()->logicalMaxHeight().isUndefined() ? logicalHeight : computeReplacedLogicalHeightUsing(style()->logicalMaxHeight());
return max(minLogicalHeight, min(logicalHeight, maxLogicalHeight));
Use the new helper methods where possible, deduplicating lots of code.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
* rendering/RenderBox.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeReplacedLogicalHeight):
* rendering/RenderPart.cpp:
(WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth):
(WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
(WebCore::RenderPart::computeReplacedLogicalWidth):
(WebCore::RenderPart::computeReplacedLogicalHeight):
* rendering/RenderPart.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loki@webkit.org [Wed, 1 Jun 2011 13:48:43 +0000 (13:48 +0000)]
2011-06-01 Gabor Loki <loki@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
Skip a flakey test on ARM.
* platform/qt-arm/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 13:04:43 +0000 (13:04 +0000)]
2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87788.
http://trac.webkit.org/changeset/87788
https://bugs.webkit.org/show_bug.cgi?id=61856
breaks windows chromium canary (Requested by jknotten on
#webkit).
* wtf/DateMath.cpp:
(WTF::timeClip):
* wtf/DateMath.h:
2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87788.
http://trac.webkit.org/changeset/87788
https://bugs.webkit.org/show_bug.cgi?id=61856
breaks windows chromium canary (Requested by jknotten on
#webkit).
* loader/archive/mhtml/MHTMLArchive.cpp:
* loader/archive/mhtml/MHTMLArchive.h:
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):
* platform/SharedBuffer.cpp:
* platform/SharedBuffer.h:
2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87788.
http://trac.webkit.org/changeset/87788
https://bugs.webkit.org/show_bug.cgi?id=61856
breaks windows chromium canary (Requested by jknotten on
#webkit).
* public/WebPageSerializer.h:
* src/WebPageSerializer.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 1 Jun 2011 12:44:40 +0000 (12:44 +0000)]
[WK2] Skip new failing test because of missing SVG animation pause API.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 1 Jun 2011 12:39:46 +0000 (12:39 +0000)]
2011-06-01 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
REGRESSION: [Qt] QNetworkReply delivered by the unsupportedContent() signal does not contain downloaded data
https://bugs.webkit.org/show_bug.cgi?id=49650
Defer emission of QWebPage::unsupportedContent() until we're back in the event loop.
This lets the QNAM backend finish with the reply without handing over ownership to the user code.
No new tests since this doesn't fail for qrc:// or file:// URLs and our tests can't depend on http:// URLs.
To correctly solve this issue, we need changes to Qt, tracked here:
http://bugreports.qt.nokia.com/browse/QTBUG-18718
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::setFrame):
(WebCore::FrameLoaderClientQt::download):
* WebCoreSupport/FrameLoaderClientQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Wed, 1 Jun 2011 12:16:09 +0000 (12:16 +0000)]
2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Tor Arne Vestbø.
[Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals
https://bugs.webkit.org/show_bug.cgi?id=61739
The skipped test was imported from Qt source repository, and used private headers
to peek in the QML Grid element. This patch changes the QML used to expose the
information we want to test: number of pages opened and the first page opened.
* tests/qdeclarativewebview/resources/newwindows.html:
Added <body> tags. We have no reason to not use them in the test.
* tests/qdeclarativewebview/resources/newwindows.qml:
Moved the timer out of the page component, used anchors for setting webview size,
changed the way we count pages opened. Also changed coding style a bit.
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::multipleWindows):
We now look for properties with the information we want in the rootItem: pagesOpened and
firstPageOpened.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 1 Jun 2011 12:01:20 +0000 (12:01 +0000)]
2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping flaky test on GTK 64-bit bot.
* platform/gtk/Skipped: Skipped test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Wed, 1 Jun 2011 11:40:56 +0000 (11:40 +0000)]
2011-06-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Add null checking condition to EditorClientEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=61846
Add null checking condition for using settings() of frame.
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::handleEditingKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Wed, 1 Jun 2011 11:17:59 +0000 (11:17 +0000)]
2011-06-01 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: [JSC] JSLock ASSERTs Seen Under eventListenerHandlerBody
https://bugs.webkit.org/show_bug.cgi?id=61835
Add a JSLock call before possible allocations in jsFunction and toString.
* bindings/js/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerBody):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 1 Jun 2011 11:03:05 +0000 (11:03 +0000)]
[Qt] Unreviewed trivial fix after r87778.
* platform/qt/Skipped: Rename editing/pasteboard/
4861080.html to editing/pasteboard/drag-drop-list.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loki@webkit.org [Wed, 1 Jun 2011 09:53:58 +0000 (09:53 +0000)]
2011-06-01 Gabor Loki <loki@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
[Qt] Skip flakey tests on ARM
* platform/qt-arm/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jknotten@chromium.org [Wed, 1 Jun 2011 09:40:21 +0000 (09:40 +0000)]
2011-06-01 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Add in baselines for new SVG tests following https://bugs.webkit.org/show_bug.cgi?id=15473
https://bugs.webkit.org/show_bug.cgi?id=61849
* platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-linux-x86/svg/hixie/intrinsic/001-expected.png: Added.
* platform/chromium-linux-x86/svg/hixie/intrinsic/001-expected.txt: Added.
* platform/chromium-linux-x86/svg/hixie/intrinsic/002-expected.png: Added.
* platform/chromium-linux-x86/svg/hixie/intrinsic/002-expected.txt: Added.
* platform/chromium-linux-x86/svg/hixie/intrinsic/003-expected.png: Added.
* platform/chromium-linux-x86/svg/hixie/intrinsic/003-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-linux/svg/hixie/intrinsic/001-expected.png: Added.
* platform/chromium-linux/svg/hixie/intrinsic/001-expected.txt: Added.
* platform/chromium-linux/svg/hixie/intrinsic/002-expected.png: Added.
* platform/chromium-linux/svg/hixie/intrinsic/002-expected.txt: Added.
* platform/chromium-linux/svg/hixie/intrinsic/003-expected.png: Added.
* platform/chromium-linux/svg/hixie/intrinsic/003-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-win-vista/svg/hixie/intrinsic/001-expected.png: Added.
* platform/chromium-win-vista/svg/hixie/intrinsic/001-expected.txt: Added.
* platform/chromium-win-vista/svg/hixie/intrinsic/002-expected.png: Added.
* platform/chromium-win-vista/svg/hixie/intrinsic/002-expected.txt: Added.
* platform/chromium-win-vista/svg/hixie/intrinsic/003-expected.png: Added.
* platform/chromium-win-vista/svg/hixie/intrinsic/003-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 1 Jun 2011 09:23:51 +0000 (09:23 +0000)]
2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed. Test rebaselines for GTK after revision 87526.
* platform/gtk/svg/hixie/text/003-expected.png:
* platform/gtk/svg/hixie/text/003-expected.txt:
* platform/gtk/svg/in-html/by-reference-expected.txt:
* platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jcivelli@chromium.org [Wed, 1 Jun 2011 09:17:53 +0000 (09:17 +0000)]
2011-06-01 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Added a method to generate RFC 2822 compliant date strings.
https://bugs.webkit.org/show_bug.cgi?id=7169
* wtf/DateMath.cpp:
(WTF::twoDigitStringFromNumber):
(WTF::makeRFC2822DateString):
* wtf/DateMath.h:
2011-06-01 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Adding MHTML generation support to MHTMLArchive.
https://bugs.webkit.org/show_bug.cgi?id=7169
* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::generateRandomBoundary):
(WebCore::replaceNonPrintableCharacters):
(WebCore::MHTMLArchive::generateMHTMLData):
* loader/archive/mhtml/MHTMLArchive.h:
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):
* platform/SharedBuffer.h:
2011-06-01 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Adding MHTML generation support to MHTMLArchive.
https://bugs.webkit.org/show_bug.cgi?id=7169
* public/WebPageSerializer.h:
* src/WebPageSerializer.cpp:
(WebKit::WebPageSerializer::serializeToMHTML):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 1 Jun 2011 09:10:08 +0000 (09:10 +0000)]
2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
REGRESSION: fast/images/svg-background-crash-on-refresh.html hangs
https://bugs.webkit.org/show_bug.cgi?id=15483
The regression seems gone, I can't reproduce it anymore, reenable svg-background-crash-on-refresh.html.
Convert the test to use dumpAsText() and actually execute the refreshing twice, including forced gc
to see whether we crash on referesh or not, before it didn't actually reload. If a crash happened,
it happened somewhen after executing this test, which is probably why it was flakey.
* platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png: Removed.
* platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt: Removed.
* svg/as-image/svg-background-crash-on-refresh-expected.txt: Copied from platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt.
* svg/as-image/svg-background-crash-on-refresh.html: Copied from svg/as-image/svg-background-crash-on-refresh.html-disabled.
* svg/as-image/svg-background-crash-on-refresh.html-disabled: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Wed, 1 Jun 2011 08:47:03 +0000 (08:47 +0000)]
2011-05-31 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
https://bugs.webkit.org/show_bug.cgi?id=61803
* WebKit.gyp:
* scripts/generate_devtools_zip.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 1 Jun 2011 08:29:22 +0000 (08:29 +0000)]
2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed. Test rebaselines for GTK after revision 87721.
* platform/gtk/svg/custom/invalid-fill-expected.png:
* platform/gtk/svg/custom/invalid-fill-expected.txt:
* platform/gtk/svg/custom/invalid-fill-hex-expected.png:
* platform/gtk/svg/custom/invalid-fill-hex-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 08:07:14 +0000 (08:07 +0000)]
2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87781.
http://trac.webkit.org/changeset/87781
https://bugs.webkit.org/show_bug.cgi?id=61842
breaks chromium linux release (Requested by mnaganov on
#webkit).
* WebKit.gyp:
* scripts/generate_devtools_zip.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 08:04:58 +0000 (08:04 +0000)]
2011-06-01 Oleg Romashin <romaxa@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
platformGeometryDidChange function definition was changed everywhere except Qt.
This is fix for Qt WK2 plugins compilation
https://bugs.webkit.org/show_bug.cgi?id=61832
* PluginProcess/qt/PluginControllerProxyQt.cpp:
(WebKit::PluginControllerProxy::platformGeometryDidChange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 1 Jun 2011 08:02:19 +0000 (08:02 +0000)]
2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Adam Barth.
Move fast/images/*svg* to svg/as-image/
https://bugs.webkit.org/show_bug.cgi?id=61840
The SVG crowd regulary runs pixel tests, and we'd like to also include the SVG-as-image tests in our daily runs.
Also it makes more sense to have these tests in a single place, just like eg. svg/in-html (html5+svg).
* fast/images/animated-svg-as-image.html: Removed.
* fast/images/drag-svg-as-image-expected.txt: Removed.
* fast/images/drag-svg-as-image.html: Removed.
* fast/images/resources/animated-rect-fixed-size.svg: Removed.
* fast/images/resources/animated-rect-relative-size.svg: Removed.
* fast/images/resources/butterfly.svg: Removed.
* fast/images/resources/circle.svg: Removed.
* fast/images/resources/green-fixed-size-rect.svg: Removed.
* fast/images/resources/green-relative-size-rect.svg: Removed.
* fast/images/resources/load-script.html: Removed.
* fast/images/resources/width-100-percent.svg: Removed.
* fast/images/svg-as-background.html: Removed.
* fast/images/svg-as-image.html: Removed.
* fast/images/svg-as-relative-image.html: Removed.
* fast/images/svg-as-tiled-background.html: Removed.
* fast/images/svg-background-crash-on-refresh.html-disabled: Removed.
* fast/images/svg-background-partial-redraw.html: Removed.
* fast/images/svg-image-leak-loader-expected.txt: Removed.
* fast/images/svg-image-leak-loader.html: Removed.
* fast/images/svg-nested-expected.txt: Removed.
* fast/images/svg-nested.html: Removed.
* fast/images/svg-width-100p-as-background.html: Removed.
* platform/chromium-linux/fast/images/animated-svg-as-image-expected.png: Removed.
* platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Removed.
* platform/chromium-linux/svg/as-image: Added.
* platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/chromium-linux/fast/images/animated-svg-as-image-expected.png.
* platform/chromium-linux/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png.
* platform/chromium-mac-leopard/fast/images/svg-background-partial-redraw-expected.png: Removed.
* platform/chromium-mac-leopard/svg/as-image: Added.
* platform/chromium-mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac-leopard/fast/images/svg-background-partial-redraw-expected.png.
* platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png: Removed.
* platform/chromium-mac/svg/as-image: Added.
* platform/chromium-mac/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png.
* platform/chromium-win/fast/images/animated-svg-as-image-expected.png: Removed.
* platform/chromium-win/fast/images/animated-svg-as-image-expected.txt: Removed.
* platform/chromium-win/fast/images/svg-as-background-expected.txt: Removed.
* platform/chromium-win/fast/images/svg-as-tiled-background-expected.txt: Removed.
* platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Removed.
* platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Removed.
* platform/chromium-win/fast/images/svg-width-100p-as-background-expected.txt: Removed.
* platform/chromium-win/svg/as-image: Added.
* platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/chromium-win/fast/images/animated-svg-as-image-expected.png.
* platform/chromium-win/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/chromium-win/fast/images/animated-svg-as-image-expected.txt.
* platform/chromium-win/svg/as-image/svg-as-background-expected.txt: Copied from platform/chromium-win/fast/images/svg-as-background-expected.txt.
* platform/chromium-win/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/chromium-win/fast/images/svg-as-tiled-background-expected.txt.
* platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png.
* platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt.
* platform/chromium-win/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/chromium-win/fast/images/svg-width-100p-as-background-expected.txt.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/images/animated-svg-as-image-expected.png: Removed.
* platform/gtk/fast/images/animated-svg-as-image-expected.txt: Removed.
* platform/gtk/fast/images/svg-as-background-expected.png: Removed.
* platform/gtk/fast/images/svg-as-background-expected.txt: Removed.
* platform/gtk/fast/images/svg-as-image-expected.png: Removed.
* platform/gtk/fast/images/svg-as-image-expected.txt: Removed.
* platform/gtk/fast/images/svg-as-relative-image-expected.png: Removed.
* platform/gtk/fast/images/svg-as-relative-image-expected.txt: Removed.
* platform/gtk/fast/images/svg-as-tiled-background-expected.png: Removed.
* platform/gtk/fast/images/svg-as-tiled-background-expected.txt: Removed.
* platform/gtk/fast/images/svg-background-partial-redraw-expected.txt: Removed.
* platform/gtk/fast/images/svg-width-100p-as-background-expected.png: Removed.
* platform/gtk/fast/images/svg-width-100p-as-background-expected.txt: Removed.
* platform/gtk/svg/as-image: Added.
* platform/gtk/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/gtk/fast/images/animated-svg-as-image-expected.png.
* platform/gtk/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/gtk/fast/images/animated-svg-as-image-expected.txt.
* platform/gtk/svg/as-image/svg-as-background-expected.png: Copied from platform/gtk/fast/images/svg-as-background-expected.png.
* platform/gtk/svg/as-image/svg-as-background-expected.txt: Copied from platform/gtk/fast/images/svg-as-background-expected.txt.
* platform/gtk/svg/as-image/svg-as-image-expected.png: Copied from platform/gtk/fast/images/svg-as-image-expected.png.
* platform/gtk/svg/as-image/svg-as-image-expected.txt: Copied from platform/gtk/fast/images/svg-as-image-expected.txt.
* platform/gtk/svg/as-image/svg-as-relative-image-expected.png: Copied from platform/gtk/fast/images/svg-as-relative-image-expected.png.
* platform/gtk/svg/as-image/svg-as-relative-image-expected.txt: Copied from platform/gtk/fast/images/svg-as-relative-image-expected.txt.
* platform/gtk/svg/as-image/svg-as-tiled-background-expected.png: Copied from platform/gtk/fast/images/svg-as-tiled-background-expected.png.
* platform/gtk/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/gtk/fast/images/svg-as-tiled-background-expected.txt.
* platform/gtk/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/gtk/fast/images/svg-background-partial-redraw-expected.txt.
* platform/gtk/svg/as-image/svg-width-100p-as-background-expected.png: Copied from platform/gtk/fast/images/svg-width-100p-as-background-expected.png.
* platform/gtk/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/gtk/fast/images/svg-width-100p-as-background-expected.txt.
* platform/mac-leopard/fast/images/animated-svg-as-image-expected.png: Removed.
* platform/mac-leopard/fast/images/svg-background-partial-redraw-expected.png: Removed.
* platform/mac-leopard/svg/as-image: Added.
* platform/mac-leopard/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/mac-leopard/fast/images/animated-svg-as-image-expected.png.
* platform/mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/mac-leopard/fast/images/svg-background-partial-redraw-expected.png.
* platform/mac/fast/images/animated-svg-as-image-expected.png: Removed.
* platform/mac/fast/images/animated-svg-as-image-expected.txt: Removed.
* platform/mac/fast/images/svg-as-background-expected.png: Removed.
* platform/mac/fast/images/svg-as-background-expected.txt: Removed.
* platform/mac/fast/images/svg-as-image-expected.png: Removed.
* platform/mac/fast/images/svg-as-image-expected.txt: Removed.
* platform/mac/fast/images/svg-as-relative-image-expected.png: Removed.
* platform/mac/fast/images/svg-as-relative-image-expected.txt: Removed.
* platform/mac/fast/images/svg-as-tiled-background-expected.png: Removed.
* platform/mac/fast/images/svg-as-tiled-background-expected.txt: Removed.
* platform/mac/fast/images/svg-background-crash-on-refresh-expected.png: Removed.
* platform/mac/fast/images/svg-background-crash-on-refresh-expected.txt: Removed.
* platform/mac/fast/images/svg-background-partial-redraw-expected.png: Removed.
* platform/mac/fast/images/svg-background-partial-redraw-expected.txt: Removed.
* platform/mac/fast/images/svg-width-100p-as-background-expected.png: Removed.
* platform/mac/fast/images/svg-width-100p-as-background-expected.txt: Removed.
* platform/mac/svg/as-image: Added.
* platform/mac/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/mac/fast/images/animated-svg-as-image-expected.png.
* platform/mac/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/mac/fast/images/animated-svg-as-image-expected.txt.
* platform/mac/svg/as-image/svg-as-background-expected.png: Copied from platform/mac/fast/images/svg-as-background-expected.png.
* platform/mac/svg/as-image/svg-as-background-expected.txt: Copied from platform/mac/fast/images/svg-as-background-expected.txt.
* platform/mac/svg/as-image/svg-as-image-expected.png: Copied from platform/mac/fast/images/svg-as-image-expected.png.
* platform/mac/svg/as-image/svg-as-image-expected.txt: Copied from platform/mac/fast/images/svg-as-image-expected.txt.
* platform/mac/svg/as-image/svg-as-relative-image-expected.png: Copied from platform/mac/fast/images/svg-as-relative-image-expected.png.
* platform/mac/svg/as-image/svg-as-relative-image-expected.txt: Copied from platform/mac/fast/images/svg-as-relative-image-expected.txt.
* platform/mac/svg/as-image/svg-as-tiled-background-expected.png: Copied from platform/mac/fast/images/svg-as-tiled-background-expected.png.
* platform/mac/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/mac/fast/images/svg-as-tiled-background-expected.txt.
* platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png: Copied from platform/mac/fast/images/svg-background-crash-on-refresh-expected.png.
* platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt: Copied from platform/mac/fast/images/svg-background-crash-on-refresh-expected.txt.
* platform/mac/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/mac/fast/images/svg-background-partial-redraw-expected.png.
* platform/mac/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/mac/fast/images/svg-background-partial-redraw-expected.txt.
* platform/mac/svg/as-image/svg-width-100p-as-background-expected.png: Copied from platform/mac/fast/images/svg-width-100p-as-background-expected.png.
* platform/mac/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/mac/fast/images/svg-width-100p-as-background-expected.txt.
* platform/qt-mac/Skipped:
* platform/qt-wk2/Skipped:
* platform/qt/Skipped:
* platform/qt/fast/images/animated-svg-as-image-expected.txt: Removed.
* platform/qt/fast/images/svg-as-background-expected.txt: Removed.
* platform/qt/fast/images/svg-as-image-expected.txt: Removed.
* platform/qt/fast/images/svg-as-relative-image-expected.txt: Removed.
* platform/qt/fast/images/svg-as-tiled-background-expected.txt: Removed.
* platform/qt/fast/images/svg-background-partial-redraw-expected.png: Removed.
* platform/qt/fast/images/svg-background-partial-redraw-expected.txt: Removed.
* platform/qt/fast/images/svg-width-100p-as-background-expected.txt: Removed.
* platform/qt/svg/as-image: Added.
* platform/qt/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/qt/fast/images/animated-svg-as-image-expected.txt.
* platform/qt/svg/as-image/svg-as-background-expected.txt: Copied from platform/qt/fast/images/svg-as-background-expected.txt.
* platform/qt/svg/as-image/svg-as-image-expected.txt: Copied from platform/qt/fast/images/svg-as-image-expected.txt.
* platform/qt/svg/as-image/svg-as-relative-image-expected.txt: Copied from platform/qt/fast/images/svg-as-relative-image-expected.txt.
* platform/qt/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/qt/fast/images/svg-as-tiled-background-expected.txt.
* platform/qt/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/qt/fast/images/svg-background-partial-redraw-expected.png.
* platform/qt/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/qt/fast/images/svg-background-partial-redraw-expected.txt.
* platform/qt/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/qt/fast/images/svg-width-100p-as-background-expected.txt.
* svg/as-image: Added.
* svg/as-image/animated-svg-as-image.html: Copied from fast/images/animated-svg-as-image.html.
* svg/as-image/drag-svg-as-image-expected.txt: Copied from fast/images/drag-svg-as-image-expected.txt.
* svg/as-image/drag-svg-as-image.html: Copied from fast/images/drag-svg-as-image.html.
* svg/as-image/resources: Added.
* svg/as-image/resources/animated-rect-fixed-size.svg: Copied from fast/images/resources/animated-rect-fixed-size.svg.
* svg/as-image/resources/animated-rect-relative-size.svg: Copied from fast/images/resources/animated-rect-relative-size.svg.
* svg/as-image/resources/butterfly.svg: Copied from fast/images/resources/butterfly.svg.
* svg/as-image/resources/circle.svg: Copied from fast/images/resources/circle.svg.
* svg/as-image/resources/green-fixed-size-rect.svg: Copied from fast/images/resources/green-fixed-size-rect.svg.
* svg/as-image/resources/green-relative-size-rect.svg: Copied from fast/images/resources/green-relative-size-rect.svg.
* svg/as-image/resources/load-script.html: Copied from fast/images/resources/load-script.html.
* svg/as-image/resources/width-100-percent.svg: Copied from fast/images/resources/width-100-percent.svg.
* svg/as-image/svg-as-background.html: Copied from fast/images/svg-as-background.html.
* svg/as-image/svg-as-image.html: Copied from fast/images/svg-as-image.html.
* svg/as-image/svg-as-relative-image.html: Copied from fast/images/svg-as-relative-image.html.
* svg/as-image/svg-as-tiled-background.html: Copied from fast/images/svg-as-tiled-background.html.
* svg/as-image/svg-background-crash-on-refresh.html-disabled: Copied from fast/images/svg-background-crash-on-refresh.html-disabled.
* svg/as-image/svg-background-partial-redraw.html: Copied from fast/images/svg-background-partial-redraw.html.
* svg/as-image/svg-image-leak-loader-expected.txt: Copied from fast/images/svg-image-leak-loader-expected.txt.
* svg/as-image/svg-image-leak-loader.html: Copied from fast/images/svg-image-leak-loader.html.
* svg/as-image/svg-nested-expected.txt: Copied from fast/images/svg-nested-expected.txt.
* svg/as-image/svg-nested.html: Copied from fast/images/svg-nested.html.
* svg/as-image/svg-width-100p-as-background.html: Copied from fast/images/svg-width-100p-as-background.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Wed, 1 Jun 2011 07:46:13 +0000 (07:46 +0000)]
2011-05-31 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
https://bugs.webkit.org/show_bug.cgi?id=61803
* WebKit.gyp:
* scripts/generate_devtools_zip.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 1 Jun 2011 07:40:41 +0000 (07:40 +0000)]
2011-06-01 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
Remove ShadowElement and compact remaining used bits into RenderFileUploadControl.
https://bugs.webkit.org/show_bug.cgi?id=61816
This is a near-mechanical move-and-rename of ShadowElement, which is now only
used by input[type=file]. Next step -- switch it over to new shadow DOM.
Refactoring, no change in behavior.
* CMakeLists.txt: Removed ShadowElement.cpp and ShadowElement.h.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore/WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* WebCore/rendering/RenderingAllInOne.cpp: Ditto.
* rendering/RenderFileUploadControl.cpp:
(WebCore::UploadButton::create): Moved from ShadowElement, renamed as UploadButton.
(WebCore::UploadButton::detach): Ditto.
(WebCore::UploadButton::UploadButton): Ditto.
(WebCore::RenderFileUploadControl::updateFromElement): Changed to use UploadButton.
* rendering/RenderMeter.cpp: Removed ShadowElement.h include, which is no longer used.
* rendering/RenderProgress.cpp: Ditto.
* rendering/ShadowElement.cpp: Removed.
* rendering/ShadowElement.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 1 Jun 2011 07:30:10 +0000 (07:30 +0000)]
2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
SVG fails all 3 of Hixie's CSS intrinsic sizing tests
https://bugs.webkit.org/show_bug.cgi?id=15473
Hixies CSS intrinsic sizing tests cover percentage sizes specified on the target SVG document as width/height attributes
and using width: auto / height: auto on the <object> that hosts the SVG document. Take percentage sizes of the outermost
SVGs width/height attributes into account when determining the intrinsic size of the <object>.
Added several other testcases demonstrating several scenarios. All tests work exactly the same in WebKit and Firefox now.
The *on-target-svg-absolute.xhtml tests look equal to WebKit/FF but Opera fails them, likely a relict of the different
interpretation of the intrinsic size of a SVG document in SVG Tiny 1.2.
* platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
* platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
* platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
* platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
* platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
* platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
* platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
* platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
* platform/mac/svg/hixie/intrinsic: Added.
* platform/mac/svg/hixie/intrinsic/001-expected.png: Added.
* platform/mac/svg/hixie/intrinsic/001-expected.txt: Added.
* platform/mac/svg/hixie/intrinsic/002-expected.png: Added.
* platform/mac/svg/hixie/intrinsic/002-expected.txt: Added.
* platform/mac/svg/hixie/intrinsic/003-expected.png: Added.
* platform/mac/svg/hixie/intrinsic/003-expected.txt: Added.
* svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml: Added.
* svg/custom/object-sizing-height-50p-on-target-svg.xhtml: Added.
* svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml: Added.
* svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml: Added.
* svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml: Added.
* svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml: Added.
* svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml: Added.
* svg/custom/object-sizing-width-50p-on-target-svg.xhtml: Added.
* svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml: Added.
* svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml: Added.
* svg/custom/resources/object-sizing-height-50p.svg: Added.
* svg/custom/resources/object-sizing-width-50p-height-50p.svg: Added.
* svg/custom/resources/object-sizing-width-50p-height-75p.svg: Added.
* svg/custom/resources/object-sizing-width-50p.svg: Added.
* svg/custom/resources/object-sizing-width-75p-height-50p.svg: Added.
* svg/hixie/intrinsic: Added.
* svg/hixie/intrinsic/001.html: Added.
* svg/hixie/intrinsic/002.html: Added.
* svg/hixie/intrinsic/003.html: Added.
* svg/hixie/intrinsic/resources: Added.
* svg/hixie/intrinsic/resources/001.svg: Added.
* svg/hixie/intrinsic/resources/002.svg: Added.
* svg/hixie/intrinsic/resources/003.svg: Added.
* svg/hixie/intrinsic/resources/test-bl: Added.
* svg/hixie/intrinsic/resources/test-br: Added.
* svg/hixie/intrinsic/resources/test-tl: Added.
* svg/hixie/intrinsic/resources/test-tr: Added.
2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
SVG fails all 3 of Hixie's CSS intrinsic sizing tests
https://bugs.webkit.org/show_bug.cgi?id=15473
Hixies CSS intrinsic sizing tests cover percentage sizes specified on the target SVG document as width/height attributes
and using width: auto / height: auto on the <object> that hosts the SVG document. Take percentage sizes of the outermost
SVGs width/height attributes into account when determining the intrinsic size of the <object>.
Added several other testcases demonstrating several scenarios. All tests work exactly the same in WebKit and Firefox now.
The *on-target-svg-absolute.xhtml tests look equal to WebKit/FF but Opera fails them, likely a relict of the different
interpretation of the intrinsic size of a SVG document in SVG Tiny 1.2.
Tests: svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-height-50p-on-target-svg.xhtml
svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml
svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml
svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-width-50p-on-target-svg.xhtml
svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml
svg/hixie/intrinsic/001.html
svg/hixie/intrinsic/002.html
svg/hixie/intrinsic/003.html
* rendering/RenderPart.cpp:
(WebCore::RenderPart::computeReplacedLogicalWidth):
(WebCore::RenderPart::computeReplacedLogicalHeight):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicRatio):
* rendering/svg/RenderSVGRoot.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 07:16:05 +0000 (07:16 +0000)]
2011-06-01 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
Convert editing/pasteboard/
4861010 to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61683
Renamed test to drag-drop-list.html, cleaned up html, and updated description.
* editing/pasteboard/
4861080.html: Removed.
* editing/pasteboard/drag-drop-list.html: Copied from LayoutTests/editing/pasteboard/
4861080.html.
* platform/chromium-linux/editing/pasteboard/
4861080-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/
4861080-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/
4861080-expected.txt: Removed.
* platform/gtk/editing/pasteboard/
4861080-expected.png: Removed.
* platform/gtk/editing/pasteboard/
4861080-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/
4861080-expected.png: Removed.
* platform/mac/editing/pasteboard/
4861080-expected.png: Removed.
* platform/mac/editing/pasteboard/
4861080-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 1 Jun 2011 06:57:51 +0000 (06:57 +0000)]
2011-05-31 Kent Tamura <tkent@chromium.org>
Reviewed by Hajime Morita.
Convert fast/forms/date-input-visible-strings.html to dumpAsText().
https://bugs.webkit.org/show_bug.cgi?id=61777
* fast/forms/date-input-visible-strings.html:
* fast/forms/date-input-visible-strings-expected.txt: Added.
* platform/chromium-linux/fast/forms/date-input-visible-strings-expected.png: Removed.
* platform/chromium-mac-leopard/fast/forms/date-input-visible-strings-expected.png: Removed.
* platform/chromium-win/fast/forms/date-input-visible-strings-expected.png: Removed.
* platform/chromium-win/fast/forms/date-input-visible-strings-expected.txt: Removed.
* platform/gtk/fast/forms/date-input-visible-strings-expected.png: Removed.
* platform/gtk/fast/forms/date-input-visible-strings-expected.txt: Removed.
* platform/mac/fast/forms/date-input-visible-strings-expected.png: Removed.
* platform/mac/fast/forms/date-input-visible-strings-expected.txt: Removed.
* platform/win/fast/forms/date-input-visible-strings-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 06:25:44 +0000 (06:25 +0000)]
2011-05-31 Tonis Tiigi <tonistiigi@gmail.com>
Reviewed by Pavel Feldman.
Web Inspector: Timeline panel improvements for managing current selection
https://bugs.webkit.org/show_bug.cgi?id=61468
Enables X-axis dragging of the selected area.
Double click zoom-out.
Fixes slightly wrong selection area position.
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._dragWindow):
(WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
(WebInspector.TimelineOverviewPane.prototype._resizeWindowMaximum):
(WebInspector.TimelineOverviewPane.prototype.scrollWindow):
(WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 06:18:43 +0000 (06:18 +0000)]
2011-05-31 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
Convert editing/pasteboard/paste-blockquote-into-blockquote-2.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61682
Convert test to dump-as-markup and clean up HTML. Also update test description.
* editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
* editing/pasteboard/paste-blockquote-into-blockquote-2.html:
* platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 05:54:40 +0000 (05:54 +0000)]
2011-05-31 Hao Zheng <zhenghao@chromium.org>
Reviewed by Dirk Pranke.
Fix exception in verbose printing mode.
https://bugs.webkit.org/show_bug.cgi?id=61723
* Scripts/webkitpy/layout_tests/layout_package/printing.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Wed, 1 Jun 2011 05:46:37 +0000 (05:46 +0000)]
2011-05-31 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Fix to enable page scroll of select element
https://bugs.webkit.org/show_bug.cgi?id=53628
Manual test: select-page-scroll.html
* manual-tests/select-page-scroll.html: Added.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computeLogicalHeight): Fix min to max.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Wed, 1 Jun 2011 05:09:52 +0000 (05:09 +0000)]
2011-05-31 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Kent Tamura.
[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823
Added a new test for the fix marked the new test 'skipped' on unsupported platforms.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* storage/storageinfo-no-callbacks-expected.txt: Added.
* storage/storageinfo-no-callbacks.html: Added.
2011-05-31 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Kent Tamura.
[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823
Fixed assertion on errorCallback parameter.
Test: storage/quotainfo-no-callbacks.html
* src/StorageInfoChromium.cpp:
(WebCore::StorageInfo::queryUsageAndQuota):
(WebCore::StorageInfo::requestQuota):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 02:40:27 +0000 (02:40 +0000)]
2011-05-31 Yong Li <yoli@rim.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.
No new test added because this change is not known to fix any issue.
* bytecode/StructureStubInfo.h:
2011-05-31 Yong Li <yoli@rim.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.
No new test added because this change is not known to fix any issue.
* css/CSSPrimitiveValue.h:
* css/CSSProperty.h:
* rendering/InlineBox.h:
* rendering/RenderBlock.h:
2011-05-31 Yong Li <yoli@rim.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.
* Scripts/webkitpy/style/checkers/cpp.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 1 Jun 2011 02:25:47 +0000 (02:25 +0000)]
2011-05-31 Hironori Bono <hbono@chromium.org>
Reviewed by Eric Seidel.
Send an input event when we change the text direction.
https://bugs.webkit.org/show_bug.cgi?id=50952
This adds a new layout test to verify that we can receive input events
when we change the text direction of a <textarea> element and an <input>
element.
* fast/html/set-text-direction-expected.txt: Added.
* fast/html/set-text-direction.html: Added.
* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
2011-05-31 Hironori Bono <hbono@chromium.org>
Reviewed by Eric Seidel.
Send an input event when we change the text direction.
https://bugs.webkit.org/show_bug.cgi?id=50952
Both Safari and Chrome call Editor::setBaseWritingDirection() to change
the text direction of an editable element with their UIs. This change
calls dispatchInputEvent() to send an input event when the function
actually changes the "dir" attribute so we can send an input event as
written in the HTML5 spec.
Test: fast/html/set-text-direction.html
* editing/Editor.cpp:
(WebCore::Editor::setBaseWritingDirection):
2011-05-31 Hironori Bono <hbono@chromium.org>
Reviewed by Eric Seidel.
Add a JavaScript function layoutTestController.setTextDirection().
https://bugs.webkit.org/show_bug.cgi?id=50952
This change adds a new JavaScript function setTextDirection() to the
LayoutTestController class of Safari and Chrome to write layout tests
that changes the text direction of an editable element.
* DumpRenderTree/LayoutTestController.cpp:
(setTextDirectionCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setTextDirection):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setTextDirection):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setTextDirection):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setTextDirection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cevans@google.com [Wed, 1 Jun 2011 02:22:52 +0000 (02:22 +0000)]
2011-05-31 Chris Evans <cevans@chromium.org>
Reviewed by Drew Yao.
Add "Collaboration" to WebKit Security Group Privileges and Responsibilities section.
* security/index.html: Add "Collaboration" section with text discussed on webkit-security.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 1 Jun 2011 01:48:53 +0000 (01:48 +0000)]
2011-05-31 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Flash of black at the end of full screen transition at apple.com product videos
https://bugs.webkit.org/show_bug.cgi?id=61756
Added two new entries to the WebCore exports list.
* WebCore.exp.in:
2011-05-31 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Flash of black at the end of full screen transition at apple.com product videos
https://bugs.webkit.org/show_bug.cgi?id=61756
The @"WebKitLayerHostChanged" notification is causing the QTMovie to tear down its layer
(which is good) at the wrong time (which is bad). Send this notification only after
the dragImage snapshot is taken. This exposed another problem, that the snapshot has
a white background. Set the default background color and transparency for the view (making
sure to reset them afterwards) to transparent.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 01:47:23 +0000 (01:47 +0000)]
2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::render() failing
https://bugs.webkit.org/show_bug.cgi?id=60893
Due a problem on QPicture (http://bugreports.qt.nokia.com/browse/QTBUG-19496),
this test was calculating the final geometry incorrectly. As the order between
a translate and a draw operation could be relevant for it, but not for the
final rendered result, they were changed on ScrollbarThemeQt::paint.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarThemeQt::paint):
2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::render() failing
https://bugs.webkit.org/show_bug.cgi?id=60893
The test was expecting the frame contents to be already loaded
before rendering it into a QPicture. Renamed the test to fit
its real purpose more accordingly.
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::renderGeometry):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 01:26:11 +0000 (01:26 +0000)]
2011-05-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] gtkdoc run produces many warnings about missing declarations
https://bugs.webkit.org/show_bug.cgi?id=61797
* docs/webkitgtk-sections.txt: Remove inexistent symbols from this file
to reduce the number of gtkdoc warnings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 01:05:12 +0000 (01:05 +0000)]
2011-05-31 Raphael Kubo da Costa <kubo@profusion.mobi>
Reviewed by Adam Barth.
[efl] Add ewk API to enable/disable developer extras.
https://bugs.webkit.org/show_bug.cgi?id=61746
Add ewk_view_setting_enable_developer_extras_{get,set}, which is used
to enable or disable developer extras (currently, the Web Inspector)
in a given view.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_setting_enable_developer_extras_get):
(ewk_view_setting_enable_developer_extras_set):
* ewk/ewk_view.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Jun 2011 00:43:32 +0000 (00:43 +0000)]
2011-05-31 Daniel Erat <derat@chromium.org>
Reviewed by Tony Chang.
Make WebScreenInfoFactory return fresh screen dimensions.
https://bugs.webkit.org/show_bug.cgi?id=61679
* public/x11/WebScreenInfoFactory.h:
* src/x11/WebScreenInfoFactory.cpp:
(WebKit::WebScreenInfoFactory::screenInfo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ademar.reis@openbossa.org [Wed, 1 Jun 2011 00:14:56 +0000 (00:14 +0000)]
2011-05-31 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] User-agent list of Qt test browsers is very outdated
https://bugs.webkit.org/show_bug.cgi?id=61531
The user can edit the user-agent manually, so there's no need to have
a super complete and up to date list, but it's nice to have it
minimally updated.
* MiniBrowser/qt/useragentlist.txt:
* QtTestBrowser/useragentlist.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 31 May 2011 23:49:22 +0000 (23:49 +0000)]
2011-05-27 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix crash from empty reflections with masks
https://bugs.webkit.org/show_bug.cgi?id=61654
* compositing/reflections/empty-reflection-with-mask-expected.txt: Added.
* compositing/reflections/empty-reflection-with-mask.html: Added.
2011-05-27 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix crash from empty reflections with masks
https://bugs.webkit.org/show_bug.cgi?id=61654
Change the iteration for updateCompositorResources to match that being
done in the paint and draw steps. This mismatch of iteration style
was causing layers with replica masks to correctly get skipped while
painting but not get skipped during texture upload.
Test: compositing/reflections/empty-reflection-with-mask.html
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::updateCompositorResources):
* platform/graphics/chromium/LayerRendererChromium.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 31 May 2011 23:35:34 +0000 (23:35 +0000)]
2011-03-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Roben.
[GTK] [WebKit2] Implement a basic WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=57068
* GNUmakefile.am: Added reference to WebKitTestRunner GNUmakefile.
2011-03-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Roben.
[GTK] [WebKit2] Implement a basic WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=57068
Added InjectedBundle support for GTK+.
* WebProcess/InjectedBundle/InjectedBundle.h: Added typedef for GTK+.
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: Added implementation.
(WebKit::InjectedBundle::load):
(WebKit::InjectedBundle::activateMacFontAscentHack):
* WebProcess/WebPage/gtk/WebPageGtk.cpp: Remove unnecessary method definition.
2011-03-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Roben.
[GTK] [WebKit2] Implement a basic WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=57068
Add an implementation of WebKitTestRunner for GTK+.
* Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
* Scripts/old-run-webkit-tests: Ditto.
* Scripts/run-launcher: Ditto.
* Scripts/webkitdirs.pm: Ditto.
* WebKitTestRunner/GNUmakefile.am: Added.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
* WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
* WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
* WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
* WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
* WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
(main): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 31 May 2011 22:40:17 +0000 (22:40 +0000)]
2011-05-31 Berend-Jan Wever <skylined@chromium.org>
Reviewed by Adam Barth.
Add test to make sure an error in requestFileSystem or resolveLocalFileSystemURI
when no error callback is supplied does not cause a NULL ptr.
https://bugs.webkit.org/show_bug.cgi?id=49539
* fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Added.
* fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Added.
2011-05-31 B.J. Wever <skylined@chromium.org>
Reviewed by Adam Barth.
requestFileSystem and resolveLocalFileSystemURI are not checking if
errorCallback is NULL before scheduling a callback on error.
https://bugs.webkit.org/show_bug.cgi?id=49539
Test: fast/filesystem/filesystem-no-callback-null-ptr-crash.html
* fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::scheduleCallback): Only call callback if
one is supplied.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 31 May 2011 22:26:55 +0000 (22:26 +0000)]
2011-05-31 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
https://bugs.webkit.org/show_bug.cgi?id=60241
* Scripts/new-run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 31 May 2011 22:13:06 +0000 (22:13 +0000)]
Another swipe at resolving <rdar://problem/
9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494
Reviewed by Darin Adler.
Re-land http://trac.webkit.org/changeset/87566 with invalid ASSERTs removed.
No new tests. No change in behavior.
Instead of storing the DocumentLoader at construction and never changing it,
always calculate it based on the FrameLoader's current DocumentLoader:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::suggestedMIMEType):
(WebCore::Document::lastModified):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::loader):
* dom/Document.h:
Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* html/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
* platform/mac/HTMLConverter.mm:
(fileWrapperForElement):
* WebCore.exp.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 31 May 2011 22:11:28 +0000 (22:11 +0000)]
<rdar://problem/
9523192> REGRESSION (5.0.5-ToT, WebKit2): Flash to white when navigating between pages on wsj.com, other sites (when navigating away from composited page)
https://bugs.webkit.org/show_bug.cgi?id=61808
Reviewed by Simon Fraser.
WebKit1 has a mechanism to prevent the stale bits from the outgoing page from being erased
until the incoming page has layout. Adapt this in WebKit2 to prevent the composited layer tree
of the outgoing page from being torn down or updated until the incoming page has layout.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout): Unfreeze the layer tree state.
(WebKit::WebFrameLoaderClient::frameLoadCompleted): Ditto.
(WebKit::WebFrameLoaderClient::provisionalLoadStarted): Freeze the layer tree state.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setLayerTreeStateIsFrozen): Added.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize new member variables.
(WebKit::DrawingAreaImpl::setLayerTreeStateIsFrozen): Added. When freezing, sets the flag and
disables layer flush scheduling and exiting accelerated compositing mode. When unfreezing,
clears the flag and exits compositing mode if needed.
(WebKit::DrawingAreaImpl::setRootCompositingLayer): Reset m_wantsToExitAcceleratedCompositingMode.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): Ditto.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Ditto.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon): If the layer tree state is frozen,
bail out but set m_wantsToExitAcceleratedCompositingMode.
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/LayerTreeHost.h:
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::LayerTreeHostCA): Initialize m_layerFlushSchedulingEnabled.
* WebProcess/WebPage/ca/LayerTreeHostCA.h:
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::scheduleLayerFlush): Bail out if scheduling is not enabled.
(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled): Added. Sets the flag. If disabling
flushing, cancels the pending flush.
(WebKit::LayerTreeHostCAMac::flushPendingLayerChangesRunLoopObserverCallback): Added an assertion.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::scheduleLayerFlush): Bail out if scheduling is not enabled.
(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled): Added. Sets the flag. If disabling
flushing, cancels the pending flush.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 31 May 2011 22:03:05 +0000 (22:03 +0000)]
2011-05-31 Hao Zheng <zhenghao@chromium.org>
Reviewed by Tony Chang.
Flush output buffer of php.
https://bugs.webkit.org/show_bug.cgi?id=56060
On Lucid, the output buffer is enabled by default, but it's not
enabled on Hardy. Fix test http/tests/loading/preload-slow-loading.php
http://www.php.net/manual/en/function.ob-flush.php
* http/tests/loading/preload-slow-loading.php:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Tue, 31 May 2011 21:55:41 +0000 (21:55 +0000)]
2011-05-31 Levi Weintraub <leviw@chromium.org>
Reviewed by Simon Fraser.
Change InlineBox::paint and its overloaded variants to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61804
Changing InlineBox::paint, its 7 overloaded variants, and RootInlineBox::paintEllipsisBox
to use IntPoint for their paint offset instead of a pair of ints.
No new tests since this is just a refactoring.
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
* rendering/EllipsisBox.h:
* rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
* rendering/InlineBox.h:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/InlineTextBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintEllipsisBoxes):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paintEllipsisBox):
(WebCore::RootInlineBox::paint):
* rendering/RootInlineBox.h:
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paint):
* rendering/svg/SVGInlineFlowBox.h:
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paint):
* rendering/svg/SVGInlineTextBox.h:
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
* rendering/svg/SVGRootInlineBox.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 31 May 2011 21:50:19 +0000 (21:50 +0000)]
2011-05-31 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Clear out LayerChromium's m_ccLayerImpl ptr on CCLayerImpl destruction
https://bugs.webkit.org/show_bug.cgi?id=61593
Whenever a CCLayerImpl is being destroyed, clear out its owner's m_ccLayerImpl pointer.
This is extremely defensive and not strictly necessary, but not harmful either.
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::~CCLayerImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 31 May 2011 21:15:16 +0000 (21:15 +0000)]
2011-05-31 Eric Seidel <eric@webkit.org>
Reviewed by David Kilzer.
webkitpy should create zips with zip -9
https://bugs.webkit.org/show_bug.cgi?id=61789
Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
* Scripts/webkitpy/common/system/workspace.py:
* Scripts/webkitpy/common/system/workspace_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Tue, 31 May 2011 21:02:28 +0000 (21:02 +0000)]
2011-05-31 Stephen White <senorblanco@chromium.org>
Unreviewed; build fix.
Silence some warnings on the Safari/Mac release build.
* platform/graphics/gpu/TilingData.h:
(WebCore::TilingData::assertTile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 31 May 2011 20:53:21 +0000 (20:53 +0000)]
2011-05-31 Adam Barth <abarth@webkit.org>
Add chromium-mac-leopard image results for these SVG tests.
* platform/chromium-mac-leopard/svg/custom/invalid-fill-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/invalid-fill-hex-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/invalid-stroke-hex-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/invalid-uri-stroke-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Tue, 31 May 2011 20:21:30 +0000 (20:21 +0000)]
2011-05-31 Justin Novosad <junov@chromium.org>
Reviewed by Stephen White.
[Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled
https://bugs.webkit.org/show_bug.cgi?id=61790
Changing the build guards in these two files that are required
by the accelerated compositing feature.
* platform/graphics/gpu/LoopBlinnMathUtils.cpp:
* platform/graphics/gpu/TilingData.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Tue, 31 May 2011 19:51:03 +0000 (19:51 +0000)]
2011-05-31 Rob Buis <rbuis@rim.com>
RS=Dirk Schulze.
run-webkit-tests on animate-path-nested-transform.html crashes
https://bugs.webkit.org/show_bug.cgi?id=61798
"Fix" the crashing test by choosing safer values.
* svg/animations/script-tests/animate-path-nested-transforms.js:
(executeTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Tue, 31 May 2011 19:38:11 +0000 (19:38 +0000)]
2011-05-31 Rob Buis <rbuis@rim.com>
Reviewed by Dirk Schulze.
https://bugs.webkit.org/show_bug.cgi?id=34301
Creating <animateMotion> elements via javascript do not execute
https://bugs.webkit.org/show_bug.cgi?id=17043
SVG missing some .idl files
Add missing idl files.
Test: svg/animations/animate-mpath-insert.html
* CMakeLists.txt:
* CodeGenerators.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* svg/SVGAnimateMotionElement.idl: Added.
* svg/SVGMPathElement.idl: Added.
2011-05-31 Rob Buis <rbuis@rim.com>
Reviewed by Dirk Schulze.
https://bugs.webkit.org/show_bug.cgi?id=34301
Creating <animateMotion> elements via javascript do not execute
https://bugs.webkit.org/show_bug.cgi?id=17043
SVG missing some .idl files
Verify that adding mpath via javascript works.
* svg/animations/animate-mpath-insert-expected.txt: Added.
* svg/animations/animate-mpath-insert.html: Added.
* svg/animations/script-tests/animate-mpath-insert.js: Added.
(mpath.setAttributeNS.animateMotion.appendChild.g.appendChild.rootSVGElement.appendChild.passIfCloseEnough):
(startSample):
(endSample):
(executeTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc