WebKit-https.git
10 years ago2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 22 Mar 2011 11:54:17 +0000 (11:54 +0000)]
2011-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed update of database-agent test expectations.
        Empty line added at the end.

        * inspector/protocol/database-agent-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 22 Mar 2011 11:44:06 +0000 (11:44 +0000)]
2011-03-22  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, Skipped one test failing because of the same reason.

        [GTK] Some test results are one pixel different between the x86_64 and i386 bots
        https://bugs.webkit.org/show_bug.cgi?id=39022

        * platform/gtk/Skipped: Skip fast/css/percentage-non-integer.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 10:49:45 +0000 (10:49 +0000)]
2011-03-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Production configuration in GYP isn&apos;t set up correctly
        https://bugs.webkit.org/show_bug.cgi?id=56786

        Update JavaScriptCore.gyp with information mined from
        JavaScriptCore.xcodeproj.

        * JavaScriptCore.gypi:
        * gyp/JavaScriptCore.gyp:
2011-03-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Production configuration in GYP isn&apos;t set up correctly
        https://bugs.webkit.org/show_bug.cgi?id=56786

        Update JavaScriptGlue.gyp with information mined from
        JavaScriptGlue.xcodeproj.

        * gyp/JavaScriptGlue.gyp:
        * gyp/JavaScriptGlue.gypi:
2011-03-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Production configuration in GYP isn&apos;t set up correctly
        https://bugs.webkit.org/show_bug.cgi?id=56786

        Update WebCore.gyp with information mined from WebCore.xcodeproj.

        * WebCore.gypi:
        * gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 22 Mar 2011 10:36:19 +0000 (10:36 +0000)]
2011-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed fix for database-agent test.

        * inspector/protocol/database-agent-expected.txt:
        * platform/chromium/inspector/protocol/database-agent-expected.txt: Copied from LayoutTests/inspector/protocol/database-agent-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Ofri Wolfus <ofri@google.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 10:14:32 +0000 (10:14 +0000)]
2011-03-22  Ofri Wolfus  <ofri@google.com>

        Reviewed by Eric Seidel.

        RTL: Select elements with a size attribute are always left aligned.
        https://bugs.webkit.org/show_bug.cgi?id=50928

        Added support for alignment in RenderListBox.

        * fast/forms/listbox-bidi-align.html: Added.
        * platform/mac/fast/forms/listbox-bidi-align-expected.txt: Added.
2011-03-22  Ofri Wolfus  <ofri@google.com>

        Reviewed by Eric Seidel.

        RTL: Select elements with a size attribute are always left aligned.
        https://bugs.webkit.org/show_bug.cgi?id=50928

        Added support for alignment in RenderListBox.

        Test: fast/forms/listbox-bidi-align.html

        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Tue, 22 Mar 2011 09:48:43 +0000 (09:48 +0000)]
2011-03-22  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Kent Tamura.

        Clear autofilled flag when reseting a form
        https://bugs.webkit.org/show_bug.cgi?id=56802

        * fast/forms/reset-autofilled-expected.txt: Added.
        * fast/forms/reset-autofilled.html: Added.
        * platform/chromium/fast/forms/reset-autofilled-expected.txt: Added.
        * platform/win/fast/forms/reset-autofilled-expected.txt: Added.
2011-03-22  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Kent Tamura.

        Clear autofilled flag when reseting a form
        In service of https://code.google.com/p/chromium/issues/detail?id=70037
        https://bugs.webkit.org/show_bug.cgi?id=56802

        Test: fast/forms/reset-autofilled.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::reset): Clear the autofilled flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 22 Mar 2011 09:42:24 +0000 (09:42 +0000)]
2011-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol cleanup. DatabaseAgent.
        https://bugs.webkit.org/show_bug.cgi?id=56815

        see protocol metabug:
        - All events should use notification wording, not command wording:

        addDatabase was renamed to DatabaseOpened.

        * inspector/protocol/database-agent-expected.txt: Added.
        * inspector/protocol/database-agent.html: Added.
2011-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol cleanup. DatabaseAgent.
        https://bugs.webkit.org/show_bug.cgi?id=56815

        see protocol metabug:
        - All events should use notification wording, not command wording:

        addDatabase was renamed to DatabaseOpened.

        Test: inspector/protocol/database-agent.html

        * inspector/Inspector.json:
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::bind):
        * inspector/front-end/Database.js:
        (WebInspector.DatabaseDispatcher.prototype.DatabaseOpened):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 22 Mar 2011 09:21:58 +0000 (09:21 +0000)]
2011-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol cleanup. ConsoleAgent.
        https://bugs.webkit.org/show_bug.cgi?id=56806

        renamed method: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
        new method: disable()
        deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.

        * inspector/protocol/console-agent-expected.txt:
        * inspector/protocol/console-agent.html:
2011-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol cleanup. ConsoleAgent.
        https://bugs.webkit.org/show_bug.cgi?id=56806

        renamed method: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
        new method: disable()
        deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::updateRepeatCountInConsole):
        * inspector/Inspector.json:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::enable):
        (WebCore::InspectorConsoleAgent::disable):
        * inspector/InspectorConsoleAgent.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdated):
        (WebInspector.ConsoleView.prototype.setConsoleMessageExpiredCount):
        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 22 Mar 2011 07:43:21 +0000 (07:43 +0000)]
2011-03-22  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        REGRESSION(r80096): Number type input unexpectedly rounds fractional values
        https://bugs.webkit.org/show_bug.cgi?id=56367

        Introduce clampToInteger(unsigned).

        * wtf/MathExtras.h:
        (clampToInteger): Added.
2011-03-22  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        REGRESSION(r80096): Number type input unexpectedly rounds fractional values
        https://bugs.webkit.org/show_bug.cgi?id=56367

        Because the default value of the maximum fractional digits of NSNumberFormatter
        and ICU NumberFormat is 3, the value 0.55555 is rounded to 0.556 in a
        localized representation. This bug affects only in Mac and Chromium.

        To fix this bug,
         - Add "maximum fractional digits" parameter to formatLocalizedNumber(), and
         - NumberInputType::visibleValue uses parseToDoubleForNumberTypeWithDecimalPlaces()
          instead of parseToDoubleForNumberType().

        No automated tests because the behavior is locale-dependent. This change
        updates a manual test.

        * html/NumberInputType.cpp:
        (WebCore::NumberInputType::visibleValue):
          Use parseToDoubleForNumberTypeWithDecimalPlaces() and passing fractional
          part length to formatLocalizedNumber().
        * manual-tests/input-number-localization.html:
          Update the test to cover this change.
        * platform/text/LocalizedNumber.h: Add a parameter to formatLocalizedNumber().
        * platform/text/LocalizedNumberICU.cpp:
        (WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().
        * platform/text/LocalizedNumberNone.cpp:
        (WebCore::formatLocalizedNumber):
        * platform/text/mac/LocalizedNumberMac.mm:
        (WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 22 Mar 2011 06:27:50 +0000 (06:27 +0000)]
2011-03-21  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Anonymous blocks need isRenderBlock cast check. Also, need
        to allow display BOX for flexible boxes.
        https://bugs.webkit.org/show_bug.cgi?id=56709

        Test: accessibility/anchor-linked-anonymous-block-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::canMergeContiguousAnonymousBlocks): remove specific
        fix in r81088 which is no longer needed.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isAnonymousBlock): Add isRenderBlock cast
        check.
2011-03-21  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Tests that we do not crash when searching up the render tree
        for an anchor element in accessibility code.
        https://bugs.webkit.org/show_bug.cgi?id=56709

        * accessibility/anchor-linked-anonymous-block-crash-expected.txt: Added.
        * accessibility/anchor-linked-anonymous-block-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 05:39:44 +0000 (05:39 +0000)]
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        GYP build should not have include paths that point within the source tree
        https://bugs.webkit.org/show_bug.cgi?id=56788

        Turns out we don't need these include paths anymore now that we have
        header maps working properly.

        * gyp/JavaScriptCore.gyp:
            - Also, remove jsc.cpp from the excluded list because it's not part
              of the jsc_files variable instead of the javascriptcore_files
              variable.
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        GYP build should not have include paths that point within the source tree
        https://bugs.webkit.org/show_bug.cgi?id=56788

        Turns out we don't need these include paths anymore now that we have
        header maps working properly.

        * gyp/JavaScriptGlue.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 22 Mar 2011 05:24:50 +0000 (05:24 +0000)]
2011-03-21  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: updating Chromium test expectataions.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>
pfeldman@chromium.org [Tue, 22 Mar 2011 05:21:22 +0000 (05:21 +0000)]
2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81597.
        http://trac.webkit.org/changeset/81597
        https://bugs.webkit.org/show_bug.cgi?id=56801

        Change results in lots of unexpected flaky on the dashboard.
        (Requested by pfeldman on #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Tue, 22 Mar 2011 04:59:37 +0000 (04:59 +0000)]
2011-03-21  Hayato Ito  <hayato@chromium.org>

        Reviewed by Ojan Vafai.

        Add the first reftest so that we can make sure that reftests won't cause
        any issues on all buildbots.
        This patch will also act as a sample reftest which a Wiki page will refer.

        https://bugs.webkit.org/show_bug.cgi?id=56450

        * fast/harness/font-weight-bold-expected.html: Added.
        * fast/harness/font-weight-bold.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 22 Mar 2011 04:32:26 +0000 (04:32 +0000)]
2011-03-21  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Tests that we do not crash when adjusting position for inline boxes.
        https://bugs.webkit.org/show_bug.cgi?id=56300

        * fast/inline/inline-box-adjust-position-crash-expected.txt: Added.
        * fast/inline/inline-box-adjust-position-crash.html: Added.
        * fast/inline/inline-box-adjust-position-crash2-expected.txt: Added.
        * fast/inline/inline-box-adjust-position-crash2.html: Added.
2011-03-21  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Revert small change made in r78846 of replacing move with positionLineBox
        in the adjusting position function for inline box.
        https://bugs.webkit.org/show_bug.cgi?id=56300

        The change in r78846 caused positioning line boxes during the step of adjusting
        position for inline box, thereby causing line boxes to be nuked. This happens as
        part of aligning boxes in block direction in RenderBlock::computeBlockDirectionPositionsForLine.
        Later on, we do the positioning of line boxes again later in that function. This
        causes use of removed inline box leading to crash. Also, it is unnecessary to do
        this twice.

        Tests: fast/inline/inline-box-adjust-position-crash.html
               fast/inline/inline-box-adjust-position-crash2.html

        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::adjustPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Tue, 22 Mar 2011 04:14:40 +0000 (04:14 +0000)]
2011-03-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] 1.3.13 release bump
        https://bugs.webkit.org/show_bug.cgi?id=56795

        Version bump for 1.3.13 and updated NEWS file with release notes.

        * configure.ac:

2011-03-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] 1.3.13 release bump
        https://bugs.webkit.org/show_bug.cgi?id=56795

        Version bump for 1.3.13 and updated NEWS file with release notes.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Tue, 22 Mar 2011 03:35:06 +0000 (03:35 +0000)]
2011-03-21  Adam Klein  <adamk@chromium.org>

        Reviewed by David Levin.

        [fileapi] Add URI resolution support to WorkerContext
        https://bugs.webkit.org/show_bug.cgi?id=55644

        Note that these tests do not run as part of new-run-webkit-tests,
        but rather in Chromium's ui_test. I've run them locally and confirmed
        they pass; a subsequent Chromium change will be submitted to run them
        on the Chromium build bots.

        * http/tests/filesystem/resources/fs-worker-common.js: Added.
        * http/tests/filesystem/resources/fs-worker-test-util.js: Added.
        Copied from fast/filesystem/resources for use by HTTP tests.
        * http/tests/filesystem/script-tests/resolve-uri.js:
        Updated to be used either in window or worker context.
        * http/tests/filesystem/workers/resolve-url-expected.txt: Added.
        * http/tests/filesystem/workers/resolve-url-sync-expected.txt: Added.
        * http/tests/filesystem/workers/resolve-url-sync.html: Added.
        * http/tests/filesystem/workers/resolve-url.html: Added.
        * http/tests/filesystem/workers/script-tests/TEMPLATE.html: Added.
        * http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Added.
2011-03-21  Adam Klein  <adamk@chromium.org>

        Reviewed by David Levin.

        [fileapi] Add URI resolution support to WorkerContext
        https://bugs.webkit.org/show_bug.cgi?id=55644

        Tests: http/tests/filesystem/workers/resolve-url-sync.html
               http/tests/filesystem/workers/resolve-url.html

        * fileapi/LocalFileSystem.cpp:
        (WebCore::LocalFileSystem::readFileSystem):
        Add support for workers.
        * fileapi/LocalFileSystem.h:
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::resolveLocalFileSystemURL):
        (WebCore::WorkerContext::resolveLocalFileSystemSyncURL):
        * workers/WorkerContext.h:
        * workers/WorkerContext.idl:
2011-03-21  Adam Klein  <adamk@chromium.org>

        Reviewed by David Levin.

        [fileapi] Add URI resolution support to WorkerContext
        https://bugs.webkit.org/show_bug.cgi?id=55644

        Pass "create" bool through to allow opening
        a filesystem without allowing creation.

        * src/LocalFileSystemChromium.cpp:
        (WebCore::LocalFileSystem::readFileSystem):
        (WebCore::LocalFileSystem::requestFileSystem):
        * src/WebWorkerBase.cpp:
        (WebKit::WebWorkerBase::openFileSystemForWorker):
        * src/WebWorkerBase.h:
        * src/WorkerFileSystemCallbacksBridge.cpp:
        (WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
        * src/WorkerFileSystemCallbacksBridge.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 David Levin <levin@chromium.org>
levin@chromium.org [Tue, 22 Mar 2011 03:28:03 +0000 (03:28 +0000)]
2011-03-21  David Levin  <levin@chromium.org>

        Reviewed by Adam Barth.

        XHR in Workers doesn't set the referrer correctly.
        https://bugs.webkit.org/show_bug.cgi?id=24683

        * http/tests/xmlhttprequest/workers/referer-expected.txt: Fixed expectations now that this works correctly.
        * http/tests/xmlhttprequest/workers/shared-worker-referer-expected.txt: Ditto.
2011-03-21  David Levin  <levin@chromium.org>

        Reviewed by Adam Barth.

        XHR in Workers doesn't set the referrer correctly.
        https://bugs.webkit.org/show_bug.cgi?id=24683

        Tests: http/tests/xmlhttprequest/workers/referer.html
               http/tests/xmlhttprequest/workers/shared-worker-referer.html

        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Fill in empty string for the outgoing referrer.
        (WebCore::DocumentThreadableLoader::create): Added the ability to set the outgoing referrer.
        (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto.
        (WebCore::DocumentThreadableLoader::loadRequest): Ditto.
        * loader/DocumentThreadableLoader.h: Ditto.
        * loader/ResourceLoadScheduler.cpp:
        (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Ditto.
        * loader/ResourceLoadScheduler.h: Ditto.
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create): Fixed bug (caught by the test) in last minute change done in previous check-in.
        * loader/WorkerThreadableLoader.cpp:
        (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): Fill in the outgoing referrer.
        (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Plumbing for the outgoing referrer.
        (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Plumbing for the outgoing referrer.
        * loader/WorkerThreadableLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 03:15:43 +0000 (03:15 +0000)]
2011-03-21  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [CMAKE] Add exception handling when PORT was missing.
        https://bugs.webkit.org/show_bug.cgi?id=56728

        * Source/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Tue, 22 Mar 2011 03:06:19 +0000 (03:06 +0000)]
2011-03-21  Ilya Sherman  <isherman@chromium.org>

        Reviewed by James Robinson.

        Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API
        Clients should instead call into WebFormControlElement::isEnabled().
        https://bugs.webkit.org/show_bug.cgi?id=56364

        * public/WebInputElement.h: Removed isEnabledFormControl().
        * src/WebInputElement.cpp: Removed isEnabledFormControl().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Tue, 22 Mar 2011 02:35:43 +0000 (02:35 +0000)]
2011-03-21  James Simonsen  <simonjam@chromium.org>

        [Chromium] Unreviewed, rebaseline win/linux after r81625.

        * platform/chromium-linux/fast/css/percentage-non-integer-expected.checksum:
        * platform/chromium-linux/fast/css/percentage-non-integer-expected.png:
        * platform/chromium-linux/fast/css/percentage-non-integer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/percentage-non-integer-expected.txt.
        * platform/chromium-win/fast/css/percentage-non-integer-expected.checksum:
        * platform/chromium-win/fast/css/percentage-non-integer-expected.png:
        * platform/chromium-win/fast/css/percentage-non-integer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 22 Mar 2011 02:32:42 +0000 (02:32 +0000)]
2011-03-21  Nate Chapin  <japhet@chromium.org>

        Reviewed by Brady Eidson.

        Tests for https://bugs.webkit.org/show_bug.cgi?id=38690.

        * http/tests/cache/post-redirect-get-expected.txt: Added.
        * http/tests/cache/post-redirect-get.php: Added.
        * http/tests/cache/post-with-cached-subresources-expected.txt: Added.
        * http/tests/cache/post-with-cached-subresources.php: Added.
        * http/tests/cache/resources/post-image-to-verify.php: Added.
2011-03-21  Nate Chapin  <japhet@chromium.org>

        Reviewed by Brady Eidson.

        Do not check the DocumentLoader's request cache policy
        in determining whether we should force revalidation of a cached
        subresource. If the main resource received headers telling it not
        to cache, that policy will be propagated to subresources.

        The previous behavior is left in behind a flag in Settings, since
        QuickLook depends on it.

        https://bugs.webkit.org/show_bug.cgi?id=38690

        Tests: http/tests/cache/post-redirect-get.php
               http/tests/cache/post-with-cached-subresources.php

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::subresourceCachePolicy):
        (WebCore::FrameLoader::loadPostRequest):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        (WebCore::Settings::setUseQuickLookResourceCachingQuirks):
        (WebCore::Settings::useQuickLookResourceCachingQuirks):
2011-03-21  Nate Chapin  <japhet@chromium.org>

        Reviewed by Brady Eidson.

        Expose a preference to use caching quirks for QuickLook,
        and use it if the QuickLook framework is loaded.

        https://bugs.webkit.org/show_bug.cgi?id=38690

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (useQuickLookQuirks):
        (+[WebPreferences initialize]):
        (-[WebPreferences useQuickLookResourceCachingQuirks]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Tue, 22 Mar 2011 01:15:17 +0000 (01:15 +0000)]
2011-03-21  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        Remove dependency on default font from data-transfer-items.html
        https://bugs.webkit.org/show_bug.cgi?id=56791

        * editing/pasteboard/data-transfer-items-expected.txt:
        * editing/pasteboard/data-transfer-items.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Mac release builds after https://bugs.webkit.org/show_bug.cgi?id=56783
beidson@apple.com [Tue, 22 Mar 2011 00:58:41 +0000 (00:58 +0000)]
Fix Mac release builds after https://bugs.webkit.org/show_bug.cgi?id=56783

* Platform/mac/Logging.mac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=56783
beidson@apple.com [Tue, 22 Mar 2011 00:47:05 +0000 (00:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56783
Actually hook up WebKit2 logging on Mac.

Reviewed by Brian Weinstein.

* Platform/Logging.cpp:
(WebKit::initializeLogChannel):
* Platform/Logging.h:
* Platform/mac/Logging.mac.mm: Added.
(WebKit::initializeLogChannel):

       * UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Initialize logging if necessary.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Rik Cabanier <cabanier@gmail.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 00:24:01 +0000 (00:24 +0000)]
2011-03-21  Rik Cabanier  <cabanier@gmail.com>

        Reviewed by James Robinson.

        bug 56052: percentages are incorrectly rounded in WebKit
        https://bugs.webkit.org/show_bug.cgi?id=56052

        * platform/mac/fast/css/percentage-non-integer-expected.txt:
2011-03-21  Rik Cabanier  <cabanier@adobe.com>

        Reviewed by James Robinson.

        bug 56052: percentages are incorrectly rounded in WebKit
        https://bugs.webkit.org/show_bug.cgi?id=56052

        test: fast/css/percentage-non-integer.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * page/PrintContext.cpp:
        (WebCore::PrintContext::pageProperty):
        * platform/Length.h:
        (WebCore::Length::Length):
        (WebCore::Length::operator*=):
        (WebCore::Length::value):
        (WebCore::Length::percent):
        (WebCore::Length::setValue):
        (WebCore::Length::calcValue):
        (WebCore::Length::calcMinValue):
        (WebCore::Length::isUndefined):
        (WebCore::Length::isZero):
        (WebCore::Length::isPositive):
        (WebCore::Length::isNegative):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::computePreferredLogicalWidths):
        (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
        (WebCore::AutoTableLayout::layout):
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):
        (WebCore::FixedTableLayout::layout):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addCell):
        (WebCore::RenderTableSection::layoutRows):
        * rendering/style/BorderData.h:
        (WebCore::BorderData::hasBorderRadius):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 00:16:41 +0000 (00:16 +0000)]
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Solve the Assertions.cpp / -Wno-missing-format-attribute mystery
        https://bugs.webkit.org/show_bug.cgi?id=56780

        The reason we couldn't resolve this warning in the GYP build was that
        the normal build disables this warning specifically for this file.
        This patch takes the same approach as the previous patch to
        WebCoreObjCExtras.mm in that it uses a pragma to suppress the warning
        (rather than a build system configuration).

        * JavaScriptCore.xcodeproj/project.pbxproj:
            - Remove the special-case for this file.
        * gyp/JavaScriptCore.gyp:
            - Remove the work-around for this issue.
        * wtf/Assertions.cpp:
            - Add a pragma disabling this warning for this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 00:14:21 +0000 (00:14 +0000)]
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add WebCoreExportFileGenerator to WebCore GYP build
        https://bugs.webkit.org/show_bug.cgi?id=56778

        This target mirrors the eponymous target from WebCore.xcodeproj.

        * WebCore.gypi:
        * gyp/WebCore.gyp:
        * generate-webcore-export-file-generator.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 22 Mar 2011 00:11:47 +0000 (00:11 +0000)]
    Reviewed by Darin Adler.

        REGRESSION (r81269): WebKit2 gets into an infinite recursion after an unhandled command key
        https://bugs.webkit.org/show_bug.cgi?id=56782
        <rdar://problem/9151993>

        * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent):
        Factored out code for resending an event and moved it to WKView.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView performKeyEquivalent:]): Don't zero out _keyDownEventBeingResent, it's easier
        to just do that in _resendKeyDownEvent:.
        (-[WKView keyDown:]): Ditto.
        (-[WKView _resendKeyDownEvent:]): Moved from PageClientImpl.mm. Added an assertion that we
        are not already resending an event - it would be too confusing if we ever had to do that,
        but looks like this never happens.

        * UIProcess/API/mac/WKViewInternal.h: Exposed _resendKeyDownEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 00:11:44 +0000 (00:11 +0000)]
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        WebCore GYP build shouldn't crash on startup
        https://bugs.webkit.org/show_bug.cgi?id=56776

        Debug builds shouldn't define NDEBUG.  This same logic exists in the
        project.pbxproj file.

        * gyp/JavaScriptCore.gyp:
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        WebCore GYP build shouldn&apos;t crash on startup
        https://bugs.webkit.org/show_bug.cgi?id=56776

        Debug builds shouldn't define NDEBUG.  This same logic exists in the
        project.pbxproj file.

        * gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Tue, 22 Mar 2011 00:03:12 +0000 (00:03 +0000)]
2011-03-21  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Implement glue between DataTransferItems and the pasteboard.
        https://bugs.webkit.org/show_bug.cgi?id=56330

        Update the layout test to take into account that the actual contents of the clipboard
        are exposed in a paste via DataTransferItems now.
        Also fix the flakiness in the layout test.

        * editing/pasteboard/data-transfer-items-expected.txt:
        * editing/pasteboard/data-transfer-items.html:
        * platform/chromium/test_expectations.txt:
2011-03-21  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Implement glue between DataTransferItems and the pasteboard.
        https://bugs.webkit.org/show_bug.cgi?id=56330

        Support retrieving clipboard data in a paste through DataTransferItems.

        Test: editing/pasteboard/data-transfer-items.html

        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::items):
        * platform/chromium/DataTransferItemChromium.cpp:
        (WebCore::DataTransferItemChromium::createFromPasteboard):
        (WebCore::DataTransferItemChromium::create):
        (WebCore::DataTransferItemChromium::DataTransferItemChromium):
        (WebCore::DataTransferItemChromium::getAsString):
        * platform/chromium/DataTransferItemChromium.h:
        * platform/chromium/DataTransferItemsChromium.cpp:
        (WebCore::DataTransferItemsChromium::addPasteboardItem):
        * platform/chromium/DataTransferItemsChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: showContextMenu not working in WK2
cfleizach@apple.com [Mon, 21 Mar 2011 23:34:31 +0000 (23:34 +0000)]
AX: showContextMenu not working in WK2
https://bugs.webkit.org/show_bug.cgi?id=56734

Reviewed by Darin Adler.

../WebCore:

WebKit2 is not able to directly open a context menu because the UI is in the other process.
Instead the chrome client should be used. This also means implementing showContextMenu() in WebKit1
code.

* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityShowContextMenu]):

../WebKit/mac:

Implement showContextMenu() so accessibility related code can call this
independent of whether WK1 or WK2 is running.

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::showContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Robert Kroeger <rjkroege@chromium.org>
commit-queue@webkit.org [Mon, 21 Mar 2011 23:19:13 +0000 (23:19 +0000)]
2011-03-21  Robert Kroeger  <rjkroege@chromium.org>

        Reviewed by Antonio Gomes.

        Flag to enable/disable a GestureReocognizer framework

        https://bugs.webkit.org/show_bug.cgi?id=49345

        * wtf/Platform.h:
2011-03-21  Robert Kroeger  <rjkroege@chromium.org>

        Reviewed by Antonio Gomes.

        Add Support to WebCore to optionally call a platform-specific gesture recognizer
        https://bugs.webkit.org/show_bug.cgi?id=49345

        Added an ability for the EventHandler to invoke an optional platform
        specific gesture recognizer.

        No tests added because the change should be functionally invisible.

        * WebCore.gypi:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::EventHandler):
        (WebCore::EventHandler::handleTouchEvent):
        * page/EventHandler.h:
        * platform/PlatformGestureRecognizer.cpp: Added.
        (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer):
        (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer):
        (WebCore::PlatformGestureRecognizer::create):
        * platform/PlatformGestureRecognizer.h: Added.
2011-03-21  Robert Kroeger  <rjkroege@chromium.org>

        Reviewed by Antonio Gomes.

        Flag to enable a platform specific GestureReocognizer framework in Chromium.

        https://bugs.webkit.org/show_bug.cgi?id=49345

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 21 Mar 2011 23:11:21 +0000 (23:11 +0000)]
2011-03-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        QT plug-in fails to load contextual menu
        https://bugs.webkit.org/show_bug.cgi?id=56777
        <rdar://problem/8979033>

        Open a Carbon resource map and make it the current map when calling NP_Initialize.

        * Platform/Module.cpp:
        (WebKit::Module::Module):
        Initialize m_bundleResourceMap to -1.

        * Platform/Module.h:
        Add m_bundleResourceMap.

        * Platform/mac/ModuleMac.mm:
        (WebKit::Module::unload):
        Close the resource map.

        (WebKit::Module::bundleResourceMap):
        Open a resource map if necessary.

        * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
        (WebKit::NetscapePluginModule::tryLoad):
        Get the resource map and make it current before calling NP_Initialize.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 21 Mar 2011 22:56:12 +0000 (22:56 +0000)]
2011-03-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Plug-in process crashes if it fails to load a plug-in module
        https://bugs.webkit.org/show_bug.cgi?id=56775

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::initialize):
        If NetscapePlugin::create returns null, call removePluginControllerProxy with a null plug-in.

        * PluginProcess/WebProcessConnection.cpp:
        (WebKit::WebProcessConnection::removePluginControllerProxy):
        Remove an incorrect assertion. Don't invalidate the remote object map if the plug-in is null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 21 Mar 2011 22:17:04 +0000 (22:17 +0000)]
2011-03-21  Tony Chang  <tony@chromium.org>

        Reviewed by Pavel Feldman.

        [chromium] remove devtools_html's dependency on WebKit.gypi
        https://bugs.webkit.org/show_bug.cgi?id=56661

        We want to depend on the values in the gypi file, not the gypi file
        itself.  Actually, if someone edits a gypi file, s/he should re-run
        gyp to pick up the new dependencies.

        It turns out that this doesn't matter much for this target anymore
        since we pull the .js dependencies from the inspector html file.

        * WebKit.gyp: cleanup dependencies
        * scripts/generate_devtools_html.py: remove unused param

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Dean Jackson <dino@apple.com>
dino@apple.com [Mon, 21 Mar 2011 22:05:11 +0000 (22:05 +0000)]
2011-03-21  Dean Jackson  <dino@apple.com>

        Reviewed by Chris Marrin and Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=56325
        ASSERTION FAILED: paused() in AnimationBase::updateStateMachine()

        AnimationBase had a custom linked-list/self-pointer for keeping
        track of animations that needed to be notified of style updates
        and start progress. This caused problems when AnimationBase was
        destroyed, since the pointer wasn't managed in any way. I replaced
        these pointers with HashSets and moved the code that removes animations
        from the sets into AnimationControllerPrivate, where it belongs.
        CompositeAnimation is also more careful to tell AnimationControllerPrivate
        when it no longer needs to keep track of waiting animations.

        This should stop the style updates being called on non-active animations
        (which was the cause of the state machine error here) and should also
        stop a few of the related flakey test failures and occasional crashes.

        Test: animations/body-removal-crash.html

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::AnimationBase):
        (WebCore::AnimationBase::updateStateMachine):
        * page/animation/AnimationBase.h:
        (WebCore::AnimationBase::~AnimationBase):
        - Remove the linked-list
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
        (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStyle):
        (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStyle):
        (WebCore::AnimationControllerPrivate::styleAvailable):
        (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse):
        (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse):
        (WebCore::AnimationControllerPrivate::startTimeResponse):
        (WebCore::AnimationControllerPrivate::animationWillBeRemoved):
        - New method to remove animations from the waiting lists
        * page/animation/AnimationControllerPrivate.h:
        - use a HashSet rather than an AnimationBase* pointer.
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::~CompositeAnimation):
        (WebCore::CompositeAnimation::clearRenderer):
        (WebCore::CompositeAnimation::updateTransitions):
        (WebCore::CompositeAnimation::updateKeyframeAnimations):
        - remove the animations and transitions from the lists when we know
          they are no longer active (rather than waiting for the AnimationBase
          to do it when destructing)

2011-03-21  Dean Jackson  <dino@apple.com>

        Reviewed by Chris Marrin and Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=56325
        ASSERTION FAILED: paused() in AnimationBase::updateStateMachine()

        Add a test that triggers the assertion by removing the <body>
        element and re-inserting it.

        While not directly related to this bug, the
        transform-origin-vs-functions test would occasionally fail because it
        depended on the order of events being fired. The update to the way
        animations are keeping their state triggered this more often. Now the
        output is sorted before finishing the test.

        * animations/3d/transform-origin-vs-functions.html:
        * animations/body-removal-crash.html: Added.
        * platform/mac/animations/body-removal-crash-expected.checksum: Added.
        * platform/mac/animations/body-removal-crash-expected.png: Added.
        * platform/mac/animations/body-removal-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Mon, 21 Mar 2011 21:58:01 +0000 (21:58 +0000)]
2011-03-21  James Simonsen  <simonjam@chromium.org>

        [Chromium] Unreviewed, add flaky and failing tests after r81597.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Mon, 21 Mar 2011 21:51:41 +0000 (21:51 +0000)]
2011-03-21  Justin Schuh  <jschuh@chromium.org>

        Reviewed by James Robinson.

        Stop inserting when the parent is removed
        https://bugs.webkit.org/show_bug.cgi?id=56690

        * fast/dom/insertedIntoDocument-child-expected.txt: Added.
        * fast/dom/insertedIntoDocument-child.html: Added.
        * fast/dom/insertedIntoDocument-iframe-expected.txt: Added.
        * fast/dom/insertedIntoDocument-iframe.html: Added.
        * fast/dom/insertedIntoDocument-sibling-expected.txt: Added.
        * fast/dom/insertedIntoDocument-sibling.html: Added.
2011-03-21  Justin Schuh  <jschuh@chromium.org>

        Reviewed by James Robinson.

        Stop inserting when the parent is removed
        https://bugs.webkit.org/show_bug.cgi?id=56690

        Tests: fast/dom/insertedIntoDocument-child.html
               fast/dom/insertedIntoDocument-iframe.html
               fast/dom/insertedIntoDocument-sibling.html

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::insertedIntoDocument):
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::insertedIntoDocument):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::insertedIntoDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 21 Mar 2011 21:44:33 +0000 (21:44 +0000)]
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Add new files to JavaScriptCore.gypi
        https://bugs.webkit.org/show_bug.cgi?id=56766

        * JavaScriptCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 21 Mar 2011 21:41:04 +0000 (21:41 +0000)]
2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81377.
        http://trac.webkit.org/changeset/81377
        https://bugs.webkit.org/show_bug.cgi?id=56765

        WebPageSerializerTest.MultipleFrames is broken (Requested by
        simonjam on #webkit).

        * wtf/Vector.h:
2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81377.
        http://trac.webkit.org/changeset/81377
        https://bugs.webkit.org/show_bug.cgi?id=56765

        WebPageSerializerTest.MultipleFrames is broken (Requested by
        simonjam on #webkit).

        * WebKit.gyp:
        * public/WebPageSerializer.h:
        * public/WebURL.h:
        * public/WebVector.h:
        (WebKit::WebVector::operator[]):
        * src/WebDataSourceImpl.cpp:
        (WebKit::WebDataSourceImpl::WebDataSourceImpl):
        * src/WebPageSerializer.cpp:
        * tests/WebFrameTest.cpp:
        * tests/WebPageSerializerTest.cpp: Removed.
        * tests/data/pageserialization/awesome.png: Removed.
        * tests/data/pageserialization/embed_iframe.html: Removed.
        * tests/data/pageserialization/object_iframe.html: Removed.
        * tests/data/pageserialization/simple_iframe.html: Removed.
        * tests/data/pageserialization/simple_page.html: Removed.
        * tests/data/pageserialization/top_frame.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 21 Mar 2011 21:39:39 +0000 (21:39 +0000)]
2011-03-21  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        Convert fake-drag into a dumpAsText test and remove 1s timeout
        https://bugs.webkit.org/show_bug.cgi?id=56674

        This test was added with eventSender, so there was no leapForward
        at the time.  Also convert to dumpAsText while I'm here.

        * editing/selection/fake-drag.html:
        * platform/chromium-linux/editing/selection/fake-drag-expected.checksum: Removed.
        * platform/chromium-linux/editing/selection/fake-drag-expected.png: Removed.
        * platform/chromium-win/editing/selection/fake-drag-expected.checksum: Removed.
        * platform/chromium-win/editing/selection/fake-drag-expected.png: Removed.
        * platform/chromium-win/editing/selection/fake-drag-expected.txt:
        * platform/gtk/editing/selection/fake-drag-expected.checksum: Removed.
        * platform/gtk/editing/selection/fake-drag-expected.png: Removed.
        * platform/gtk/editing/selection/fake-drag-expected.txt: Removed.
        * platform/mac-leopard/editing/selection/fake-drag-expected.checksum: Removed.
        * platform/mac-leopard/editing/selection/fake-drag-expected.png: Removed.
        * platform/mac/editing/selection/fake-drag-expected.checksum: Removed.
        * platform/mac/editing/selection/fake-drag-expected.png: Removed.
        * platform/mac/editing/selection/fake-drag-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Mar 2011 21:19:59 +0000 (21:19 +0000)]
2011-03-21  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: skipping new inspector test on GTK unless harness is fixed.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix failing tests on the WebKit2 bots.
weinig@apple.com [Mon, 21 Mar 2011 20:54:04 +0000 (20:54 +0000)]
Fix failing tests on the WebKit2 bots.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSubresourceLoader should expose a way to set the outgoing referer/origin
levin@chromium.org [Mon, 21 Mar 2011 20:05:56 +0000 (20:05 +0000)]
SubresourceLoader should expose a way to set the outgoing referer/origin
https://bugs.webkit.org/show_bug.cgi?id=55903

Reviewed by Adam Barth.

No new tests as no new functionality is exposed.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
* loader/SubresourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 21 Mar 2011 20:03:51 +0000 (20:03 +0000)]
2011-03-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        QT plug-in loads controller at top of movie not bottom
        https://bugs.webkit.org/show_bug.cgi?id=56764
        <rdar://problem/8979037>

        Create a layer with geometryFlipped set and add the plug-in layer as a sublayer,
        matching WebKit1.

        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        (WebKit::NetscapePlugin::platformPostInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Daniel Sievers <sievers@google.com>
commit-queue@webkit.org [Mon, 21 Mar 2011 20:01:57 +0000 (20:01 +0000)]
2011-03-21  Daniel Sievers  <sievers@google.com>

        Reviewed by Simon Fraser.

        [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
        https://bugs.webkit.org/show_bug.cgi?id=56139

        * WebCore.exp.in:
        * WebCore.order:
        * page/Frame.cpp:
        (WebCore::Frame::layerTreeAsText):
        * page/Frame.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::layerTreeAsText):
        * rendering/RenderLayerCompositor.h:
2011-03-21  Daniel Sievers  <sievers@google.com>

        Reviewed by Simon Fraser.

        [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
        https://bugs.webkit.org/show_bug.cgi?id=56139

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::renderTreeAsText):
        (WebKit::WebFrameImpl::layerTreeAsText):
        * src/WebFrameImpl.h:
2011-03-21  Daniel Sievers  <sievers@google.com>

        Reviewed by Simon Fraser.

        [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
        https://bugs.webkit.org/show_bug.cgi?id=56139

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main):
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::layerTreeAsText):
        * DumpRenderTree/chromium/LayoutTestController.h:
        (LayoutTestController::setShowDebugLayerTree):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::runFileTest):
        (TestShell::dump):
        * DumpRenderTree/chromium/TestShell.h:
        (TestParams::TestParams):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 21 Mar 2011 19:57:09 +0000 (19:57 +0000)]
2011-03-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        WebKit2 needs preferences to change security knobs
        https://bugs.webkit.org/show_bug.cgi?id=56762

        Add preferences for WebSecurityEnabled, UniversalAccessFromFileURLsAllowed
        and FileAccessFromFileURLsAllowed.

        * Shared/WebPreferencesStore.h:
        * UIProcess/API/C/WKPreferences.cpp:
        (WKPreferencesSetWebSecurityEnabled):
        (WKPreferencesGetWebSecurityEnabled):
        (WKPreferencesSetUniversalAccessFromFileURLsAllowed):
        (WKPreferencesGetUniversalAccessFromFileURLsAllowed):
        (WKPreferencesSetFileAccessFromFileURLsAllowed):
        (WKPreferencesGetFileAccessFromFileURLsAllowed):
        * UIProcess/API/C/WKPreferencesPrivate.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Mon, 21 Mar 2011 19:49:51 +0000 (19:49 +0000)]
2011-03-21  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: http/tests/inspector/network tests sometimes fail on Leopard Intel Release (Tests) and SnowLeopard Intel Leaks
        https://bugs.webkit.org/show_bug.cgi?id=56578

        Fixed and re-enabled http/tests/inspector/network tests

        * http/tests/inspector/network/network-size.html: Renamed from LayoutTests/http/tests/inspector/network/network-size.html-disabled.
        * http/tests/inspector/network/network-timing.html: Renamed from LayoutTests/http/tests/inspector/network/network-timing.html-disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Mon, 21 Mar 2011 19:47:18 +0000 (19:47 +0000)]
2011-03-21  Chang Shu  <cshu@webkit.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION (r79953): Can't type in MS Outlook 2011
        https://bugs.webkit.org/show_bug.cgi?id=56665

        Restore the expected result before r79953. r79953 changed behavior slightly in function
        finishedLoadingWithDataSource in file mac/WebView/WebHTMLRepresentation.mm, where
        core(webFrame)->editor()->applyEditingStyleToBodyElement() was called but not before r79953
        or after this patch.

        * platform/mac/editing/selection/designmode-no-caret-expected.txt:
2011-03-21  Chang Shu  <cshu@webkit.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION (r79953): Can't type in MS Outlook 2011
        https://bugs.webkit.org/show_bug.cgi?id=56665

        r79953 removed the WebView level editablity which is persistent no matter whether
        underlying document itself is changed and editability gets lost. The resolution is to
        set this WebView editable value to WebCore. This avoids the callback from WebCore to
        WebKit which was the main goal in r79953 to improve performance.

        * WebCore.exp.in:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isReadOnly):
        * dom/Node.cpp:
        (WebCore::Node::isContentEditable):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelectionFromNone):
        * page/DragController.cpp:
        (WebCore::DragController::operationForLoad):
        * page/Page.cpp:
        (WebCore::Page::Page):
        * page/Page.h:
        (WebCore::Page::setEditable):
        (WebCore::Page::isEditable):
2011-03-21  Chang Shu  <cshu@webkit.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION (r79953): Can't type in MS Outlook 2011
        https://bugs.webkit.org/show_bug.cgi?id=56665

        r79953 removed the WebView level editablity which is persistent no matter whether
        underlying document itself is changed and editability gets lost. The resolution is to
        set this WebView editable value to WebCore. This avoids the callback from WebCore to
        WebKit which was the main goal in r79953 to improve performance.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_editable):
        (webkit_web_view_set_editable):
2011-03-21  Chang Shu  <cshu@webkit.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION (r79953): Can't type in MS Outlook 2011
        https://bugs.webkit.org/show_bug.cgi?id=56665

        r79953 removed the WebView level editablity which is persistent no matter whether
        underlying document itself is changed and editability gets lost. The resolution is to
        set this WebView editable value to WebCore. This avoids the callback from WebCore to
        WebKit which was the main goal in r79953 to improve performance.

        * WebView/WebView.mm:
        (-[WebView setEditable:]):
        (-[WebView isEditable]):
2011-03-21  Chang Shu  <cshu@webkit.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION (r79953): Can't type in MS Outlook 2011
        https://bugs.webkit.org/show_bug.cgi?id=56665

        r79953 removed the WebView level editablity which is persistent no matter whether
        underlying document itself is changed and editability gets lost. The resolution is to
        set this WebView editable value to WebCore. This avoids the callback from WebCore to
        WebKit which was the main goal in r79953 to improve performance.

        * Api/qwebpage.cpp:
        (QWebPage::setContentEditable):
        (QWebPage::isContentEditable):
2011-03-21  Chang Shu  <cshu@webkit.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION (r79953): Can't type in MS Outlook 2011
        https://bugs.webkit.org/show_bug.cgi?id=56665

        r79953 removed the WebView level editablity which is persistent no matter whether
        underlying document itself is changed and editability gets lost. The resolution is to
        set this WebView editable value to WebCore. This avoids the callback from WebCore to
        WebKit which was the main goal in r79953 to improve performance.

        * WebFrame.cpp:
        (wxWebFrame::MakeEditable):
        (wxWebFrame::IsEditable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Eric Uhrhane <ericu@chromium.org>
ericu@chromium.org [Mon, 21 Mar 2011 19:37:23 +0000 (19:37 +0000)]
2011-03-21  Eric Uhrhane <ericu@chromium.org>

        Reviewed by David Levin.

        [fileapi/chromium] Fetch platform path using GetMetadata before creating File from FileEntry*
        https://bugs.webkit.org/show_bug.cgi?id=56704

        * fileapi/DOMFileSystemSync.cpp
        (DOMFileSystemSync::createFile)
        (class GetPathHelper): Added, to look up path before creating File.
        * fileapi/DOMFileSystem.cpp
        (DOMFileSystem::createFile)
        (GetPathCallback): Added, to look up path before creating File.
        * platform/FileMetadata.h
        (struct FileMetadata): Added new field platformPath.
2011-03-21  Eric Uhrhane <ericu@chromium.org>

        Reviewed by David Levin.

        [fileapi/chromium] Fetch platform path using GetMetadata before creating File from FileEntry*
        https://bugs.webkit.org/show_bug.cgi?id=56704

        * src/WebFileSystemCallbacksImpl.cpp:
        (WebFileSystemCallbacksImpl::didReadMetadata)
        Pass new platformPath member through.

        * src/WorkerFileSystemCallbacksBridge.cpp:
        (CrossThreadCopierBase)
        Copy new platformPath member.

        * public/WebFileInfo.h:
        (struct WebFileInfo)
        Add new platformPath member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML...
aroben@apple.com [Mon, 21 Mar 2011 19:28:20 +0000 (19:28 +0000)]
Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file

Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
output as plain text

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
to the master.
(RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
since we're running on the build master, not the slave. Instead, turn the raw source of
actual.html which the build slave uploaded into an HTML log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 21 Mar 2011 19:10:03 +0000 (19:10 +0000)]
2011-03-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests: run tests in ascending alphabetical order per dir
        https://bugs.webkit.org/show_bug.cgi?id=56760

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
        * Scripts/webkitpy/layout_tests/port/test.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Leandro Gracia Gil <leandrogracia@chromium.org>
commit-queue@webkit.org [Mon, 21 Mar 2011 19:08:24 +0000 (19:08 +0000)]
2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Steve Block.

        Media Stream API patch 0: adding compilation guards.
        https://bugs.webkit.org/show_bug.cgi?id=56458

        Enabling the feature by default for chromium builds.

        * features.gypi:
2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Steve Block.

        Media Stream API patch 0: adding compilation guards.
        https://bugs.webkit.org/show_bug.cgi?id=56458

        Adding options to enable the media stream API feature in Chromium.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove old DrawingArea and LayerHostingView code from WKView.
weinig@apple.com [Mon, 21 Mar 2011 18:41:41 +0000 (18:41 +0000)]
Remove old DrawingArea and LayerHostingView code from WKView.

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
(-[WKView hitTest:]):
(-[WKView WebKit::]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 21 Mar 2011 18:33:58 +0000 (18:33 +0000)]
2011-03-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Need WebKit2 API for creating a page with a specific main frame name
        https://bugs.webkit.org/show_bug.cgi?id=56759

        * Shared/WebPageCreationParameters.cpp:
        (WebKit::WebPageCreationParameters::encode):
        (WebKit::WebPageCreationParameters::decode):
        * Shared/WebPageCreationParameters.h:
        Add mainFrameName to creation parameters.

        * UIProcess/API/mac/WKView.h:
        * UIProcess/API/mac/WKView.mm:
        (-[WKView initWithFrame:]):
        (-[WKView initWithFrame:contextRef:]):
        (-[WKView initWithFrame:contextRef:pageGroupRef:]):
        (-[WKView initWithFrame:contextRef:pageGroupRef:mainFrameName:]):
        Add new initializer which takes a main frame name.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::setMainFrameName):
        (WebKit::WebPageProxy::creationParameters):
        * UIProcess/WebPageProxy.h:
        Store the main frame name for initialization/re-initialization.

        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::createMainFrame):
        * WebProcess/WebPage/WebFrame.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage):
        Pass the name to main frame creation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Dominic Cooney <dominicc@google.com>
commit-queue@webkit.org [Mon, 21 Mar 2011 18:20:03 +0000 (18:20 +0000)]
2011-03-21  Dominic Cooney  <dominicc@google.com>

        Reviewed by Jeremy Orlow.

        Adds a regression test for MediaQueryList listener callbacks in V8.
        https://bugs.webkit.org/show_bug.cgi?id=56166

        * fast/media/media-query-list-callback-expected.txt: Added.
        * fast/media/media-query-list-callback.html: Added.
        * fast/media/resources/media-query-list-callback-frame.html: Added.
2011-03-21  Dominic Cooney  <dominicc@google.com>

        Reviewed by Jeremy Orlow.

        Establishes a V8 context before executing MediaQueryList callbacks.
        https://bugs.webkit.org/show_bug.cgi?id=56166

        MediaQueryList listener callbacks didn't establish a V8 context
        before running script, causing crashes on C++-only
        callstacks (such as user resizing, printing, etc.) I believe this
        could also be contrived to execute media query list listener
        callbacks across domain.

        Test: fast/media/media-query-list-callback.html

        * css/MediaQueryListListener.cpp:
        (WebCore::MediaQueryListListener::queryChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 21 Mar 2011 17:25:12 +0000 (17:25 +0000)]
2011-03-21  Andreas Kling  <kling@webkit.org>

        Reviewed by Tor Arne Vestbø.

        [Qt] Add QNetworkReplyHandler::wasAborted()

        Instead of checking if the ResourceHandle is null everywhere,
        use a wasAborted() method to make the code readable.

        * platform/network/qt/QNetworkReplyHandler.h:
        (WebCore::QNetworkReplyHandler::wasAborted):
        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::finish):
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
        (WebCore::QNetworkReplyHandler::redirect):
        (WebCore::QNetworkReplyHandler::forwardData):
        (WebCore::QNetworkReplyHandler::uploadProgress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoplatform/mac/accessibility/aria-table-with-colspan-cells.html is failing on the Leopa...
cfleizach@apple.com [Mon, 21 Mar 2011 17:11:08 +0000 (17:11 +0000)]
platform/mac/accessibility/aria-table-with-colspan-cells.html is failing on the Leopard Release tester
https://bugs.webkit.org/show_bug.cgi?id=56523

Reviewed by Darin Adler.

List and table functionality is not present on Leopard and should be skipped.

* platform/mac-leopard/Skipped:
* platform/mac-leopard/platform/mac/accessibility: Removed.
* platform/mac-leopard/platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt: Removed.
* platform/mac-leopard/platform/mac/accessibility/list-items-ignored-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitIconDatabase may trigger crash in cairoImageSurfaceToGdkPixbuf
christian@webkit.org [Mon, 21 Mar 2011 17:11:00 +0000 (17:11 +0000)]
WebKitIconDatabase may trigger crash in cairoImageSurfaceToGdkPixbuf
https://bugs.webkit.org/show_bug.cgi?id=56201

Reviewed by Martin Robinson.

* platform/graphics/gtk/ImageGtk.cpp: Don't attempt to make a pixbuf
    if there is no image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Qi Zhang <qi.2.zhang@nokia.com>
qi.2.zhang@nokia.com [Mon, 21 Mar 2011 16:40:15 +0000 (16:40 +0000)]
2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=56323

        Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide
        "--stdout" or "--stderr" option.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::~DumpRenderTree):
        (WebCore::DumpRenderTree::processArgsLine):
        (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        (WebCore::DumpRenderTree::setRedirectOutputFileName):
        (WebCore::DumpRenderTree::setRedirectErrorFileName):
        * DumpRenderTree/qt/main.cpp:
        (isOption):
        (takeOptionValue):
        (printUsage):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Mon, 21 Mar 2011 16:32:27 +0000 (16:32 +0000)]
2011-03-21  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
        https://bugs.webkit.org/show_bug.cgi?id=56737

        Only consider parent objects not ignoring accessibility.

        * accessibility/gtk/WebKitAccessibleHyperlink.cpp:
        (webkitAccessibleHyperlinkGetStartIndex): Look for the parent
        object not ignoring accessibility for the current hyperlink.
        (webkitAccessibleHyperlinkGetEndIndex): Ditto.
2011-03-21  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
        https://bugs.webkit.org/show_bug.cgi?id=56737

        * tests/testatk.c:
        (testWebkitAtkHypertextAndHyperlinks): Updated unit test to also
        check offsets for hyperlinks inside <span> nodes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix exceptions on the buildbot due to my last change
aroben@apple.com [Mon, 21 Mar 2011 16:14:26 +0000 (16:14 +0000)]
Fix exceptions on the buildbot due to my last change

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTeach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
aroben@apple.com [Mon, 21 Mar 2011 16:00:29 +0000 (16:00 +0000)]
Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file

Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
output as plain text

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
logs.
(RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
the build master. This will correctly treat it as HTML.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 21 Mar 2011 15:49:30 +0000 (15:49 +0000)]
2011-03-21  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Remove handling of QNetworkAccessManager::UnknownOperation

        Now that Qt 4.7 is required we never have to fall back to UnknownOperation.
        Custom verb requests are using CustomOperation already, so this was dead code.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix multiple-definition linker warnings on Windows
aroben@apple.com [Mon, 21 Mar 2011 15:41:25 +0000 (15:41 +0000)]
Fix multiple-definition linker warnings on Windows

* WebCore.vcproj/WebCore.vcproj: Exclude RenderSVGPath.cpp from the build, since it is
already being compiled via RenderingAllInOne.cpp. Let VS have its way with the rest of the
file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 21 Mar 2011 15:28:52 +0000 (15:28 +0000)]
2011-03-21  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Clean up QNetworkReplyHandler::release()

        Since QNetworkReplyHandler no longer uses queued connections to
        the QNetworkReply, it's not necessary to mess with the event
        queue when releasing a reply.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::abort):
        (WebCore::QNetworkReplyHandler::release):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip another asserting animations test
aroben@apple.com [Mon, 21 Mar 2011 15:19:39 +0000 (15:19 +0000)]
Skip another asserting animations test

<http://webkit.org/b/56488> tracks the failure

* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Mon, 21 Mar 2011 14:40:33 +0000 (14:40 +0000)]
2011-03-21  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
        https://bugs.webkit.org/show_bug.cgi?id=56691

        Added a test for transfer size for chunked encoding type.

        * http/tests/inspector/network/network-size-chunked.html: Added.
        * http/tests/inspector/network/network-size-expected-chunked.txt: Added.
        * http/tests/inspector/network/resources/resource.php:
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-21  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
        https://bugs.webkit.org/show_bug.cgi?id=56691

        Added transfer size support in inspector for compressed data.

        Test: http/tests/inspector/network/network-size-chunked.html

        * inspector/Inspector.idl:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::didReceiveContentLength):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::didReceiveResponse):
        (WebCore::InspectorResourceAgent::didReceiveContentLength):
        * inspector/InspectorResourceAgent.h:
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype.didReceiveContentLength):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.get transferSize):
        (WebInspector.Resource.prototype.increaseTransferSize):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::didReceiveData):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
        (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
        * loader/ResourceLoadNotifier.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::didReceiveData):
        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::forwardData):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::gotChunkCallback):
        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::ResourceHandle::onRequestComplete):
        (WebCore::ResourceHandle::fileLoadTimer):
2011-03-21  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
        https://bugs.webkit.org/show_bug.cgi?id=56691

        Added transfer size support in inspector for compressed data.

        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::didReceiveData):
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Hao Zheng <zhenghao@google.com>
commit-queue@webkit.org [Mon, 21 Mar 2011 14:36:31 +0000 (14:36 +0000)]
2011-03-21  Hao Zheng  <zhenghao@google.com>

        Reviewed by Darin Adler.

        Bug 15713: Rollout r72533 completely.
        https://bugs.webkit.org/show_bug.cgi?id=15713

        r72599 only rolled out the checksum files, which caused mismatch
        between checksum and png. Some png files had been
        rolled out by some other changes, so rollout the remaining png.

        * platform/chromium-linux/css1/box_properties/margin_right-expected.png:
        * platform/chromium-linux/css1/box_properties/padding_right-expected.png:
        * platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
        * platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
        * platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.png:
        * platform/chromium-linux/fast/doctypes/002-expected.png:
        * platform/chromium-linux/fast/lists/001-vertical-expected.png:
        * platform/chromium-linux/fast/lists/002-expected.png:
        * platform/chromium-linux/fast/lists/003-expected.png:
        * platform/chromium-linux/fast/lists/007-vertical-expected.png:
        * platform/chromium-linux/fast/lists/008-vertical-expected.png:
        * platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.png:
        * platform/chromium-win/css1/box_properties/margin_right-expected.png:
        * platform/chromium-win/css1/box_properties/padding_right-expected.png:
        * platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.png:
        * platform/chromium-win/fast/doctypes/002-expected.png:
        * platform/chromium-win/fast/lists/001-vertical-expected.png:
        * platform/chromium-win/fast/lists/002-expected.png:
        * platform/chromium-win/fast/lists/003-expected.png:
        * platform/chromium-win/fast/lists/007-vertical-expected.png:
        * platform/chromium-win/fast/lists/008-vertical-expected.png:
        * platform/chromium-win/fast/lists/marker-before-empty-inline-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Leo Yang <leo.yang@torchmobile.com.cn>
krit@webkit.org [Mon, 21 Mar 2011 14:21:41 +0000 (14:21 +0000)]
2011-03-21  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        symbol display <use> at wrong scale
        https://bugs.webkit.org/show_bug.cgi?id=54538

        SVG spec: http://www.w3.org/TR/SVG/struct.html#UseElement
        Quotation for referenced <symbol>: "If attributes 'width'
        and/or 'height' are provided on the 'use' element, then
        these attributes will be transferred to the generated 'svg'."
        Quotation for referenced <svg>: "If attributes 'width'
        and/or 'height' are provided on the 'use' element, then
        these values will override the corresponding attributes
        on the 'svg' in the generated tree."
        For above quotations, we should treat 'use' element as referencing
        'use' element, just like Firefox 3.6 and Opera 11, instead of
        corrensponding 'use' element.

        Tests: svg/custom/use-transfer-width-height-properties-to-svg.svg
               svg/custom/use-transfer-width-height-properties-to-svg1.svg
               svg/custom/use-transfer-width-height-properties-to-svg2.svg
               svg/custom/use-transfer-width-height-properties-to-symbol.svg
               svg/custom/use-transfer-width-height-properties-to-symbol1.svg
               svg/custom/use-transfer-width-height-properties-to-symbol2.svg

        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::SVGElementInstance):
        * svg/SVGElementInstance.h:
        (WebCore::SVGElementInstance::create):
        (WebCore::SVGElementInstance::correspondingUseElement):
        (WebCore::SVGElementInstance::directUseElement):
        (WebCore::SVGElementInstance::clearUseElements):
        * svg/SVGUseElement.cpp:
        (WebCore::updateContainerSize):
        (WebCore::SVGUseElement::updateContainerSizes):
        (WebCore::dumpInstanceTree):
        (WebCore::SVGUseElement::detachInstance):
        (WebCore::SVGUseElement::buildInstanceTree):
2011-03-21  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        symbol display <use> at wrong scale
        https://bugs.webkit.org/show_bug.cgi?id=54538

        Test cases for transfering width/height properties from
        'use' element to 'svg' and 'symbol' elements.
        See: http://www.w3.org/TR/SVG/struct.html#UseElement

        * platform/mac/svg/custom/use-transfer-width-height-properties-to-svg-expected.checksum: Added.
        * platform/mac/svg/custom/use-transfer-width-height-properties-to-svg-expected.png: Added.
        * platform/mac/svg/custom/use-transfer-width-height-properties-to-svg1-expected.checksum: Added.
        * platform/mac/svg/custom/use-transfer-width-height-properties-to-svg1-expected.png: Added.
        * platform/mac/svg/custom/use-transfer-width-height-properties-to-svg2-expected.checksum: Added.
        * platform/mac/svg/custom/use-transfer-width-height-properties-to-svg2-expected.png: Added.
        * platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol-expected.checksum: Added.
        * platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol-expected.png: Added.
        * platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.checksum: Added.
        * platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.png: Added.
        * platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.checksum: Added.
        * platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.png: Added.
        * platform/qt/svg/custom/use-transfer-width-height-properties-to-svg-expected.checksum: Added.
        * platform/qt/svg/custom/use-transfer-width-height-properties-to-svg-expected.png: Added.
        * platform/qt/svg/custom/use-transfer-width-height-properties-to-svg1-expected.checksum: Added.
        * platform/qt/svg/custom/use-transfer-width-height-properties-to-svg1-expected.png: Added.
        * platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.checksum: Added.
        * platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.png: Added.
        * platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.checksum: Added.
        * platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.png: Added.
        * platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.checksum: Added.
        * platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.png: Added.
        * platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.checksum: Added.
        * platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.png: Added.
        * svg/custom/use-transfer-width-height-properties-to-svg-expected.txt: Added.
        * svg/custom/use-transfer-width-height-properties-to-svg.svg: Added.
        * svg/custom/use-transfer-width-height-properties-to-svg1-expected.txt: Added.
        * svg/custom/use-transfer-width-height-properties-to-svg1.svg: Added.
        * svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt: Added.
        * svg/custom/use-transfer-width-height-properties-to-svg2.svg: Added.
        * svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt: Added.
        * svg/custom/use-transfer-width-height-properties-to-symbol.svg: Added.
        * svg/custom/use-transfer-width-height-properties-to-symbol1-expected.txt: Added.
        * svg/custom/use-transfer-width-height-properties-to-symbol1.svg: Added.
        * svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt: Added.
        * svg/custom/use-transfer-width-height-properties-to-symbol2.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExtend constant pool to be able to store 16 bit instructions with a constant
loki@webkit.org [Mon, 21 Mar 2011 13:54:35 +0000 (13:54 +0000)]
Extend constant pool to be able to store 16 bit instructions with a constant
https://bugs.webkit.org/show_bug.cgi?id=46796

Reviewed by Csaba Osztrogonác.

The putShortWithConstantInt function inserts a 16 bit instruction which
refers a 32 bits constant or literal. This is a vital function for those
target which loads a PC relative value with a 16 bit instruction (like
Thumb-2 instruction set and SH4 architecture).

* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::putIntegralUnchecked):
* assembler/AssemblerBufferWithConstantPool.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Jaehun Lim <ljaehun.lim@samsung.com>
commit-queue@webkit.org [Mon, 21 Mar 2011 10:53:13 +0000 (10:53 +0000)]
2011-03-21  Jaehun Lim  <ljaehun.lim@samsung.com>

        Reviewed by Pavel Feldman.

        Fix build break when inspector is enabled.
        https://bugs.webkit.org/show_bug.cgi?id=56735

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Add ENABLE(INSPECTOR).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 21 Mar 2011 09:33:36 +0000 (09:33 +0000)]
2011-03-21  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK distcheck build fix.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Mon, 21 Mar 2011 08:20:07 +0000 (08:20 +0000)]
2011-03-21  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric Seidel.

        Test for Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
        ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)

        * fast/css/webkit-empty-transform-preserve3d-crash-expected.txt: Added.
        * fast/css/webkit-empty-transform-preserve3d-crash.html: Added.
2011-03-21  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric Seidel.

        Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
        ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)

        Test: fast/css/webkit-empty-transform-preserve3d-crash.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::layoutOverflowRectForPropagation): Mimicked the
        rest of the code and check that the RenderBox has a layer to avoid
        crashing on the layer() call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Mar 2011 07:56:53 +0000 (07:56 +0000)]
2011-03-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move cookie processing and appcache from DOMAgent.js
        https://bugs.webkit.org/show_bug.cgi?id=56713

        * inspector/front-end/ApplicationCacheItemsView.js:
        (WebInspector.ApplicationCacheDispatcher):
        (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
        (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus):
        (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.Cookies.getCookiesAsync):
        (WebInspector.Cookies.buildCookiesFromString):
        (WebInspector.Cookies.cookieMatchesResourceURL):
        (WebInspector.Cookies.cookieDomainMatchesResourceDomain):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype.eventListeners):
        * inspector/front-end/EventListenersSidebarPane.js:
        (WebInspector.EventListenersSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Mar 2011 07:54:32 +0000 (07:54 +0000)]
2011-03-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: migrate Inspector.json to valid JSON types.
        https://bugs.webkit.org/show_bug.cgi?id=56651

        This change migrates inspector from long to int as
        dom, storage, database and other id types.

        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::inspectedNode):
        (WebCore::InjectedScriptHost::databaseIdImpl):
        (WebCore::InjectedScriptHost::storageIdImpl):
        (WebCore::InjectedScriptHost::didCreateWorker):
        (WebCore::InjectedScriptHost::didDestroyWorker):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::highlightDOMNode):
        * inspector/InspectorAgent.h:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
        (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
        * inspector/InspectorBrowserDebuggerAgent.h:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getStylesForNode):
        (WebCore::InspectorCSSAgent::getInlineStyleForNode):
        (WebCore::InspectorCSSAgent::getComputedStyleForNode):
        (WebCore::InspectorCSSAgent::setPropertyText):
        (WebCore::InspectorCSSAgent::toggleProperty):
        (WebCore::InspectorCSSAgent::addRule):
        (WebCore::InspectorCSSAgent::elementForId):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::count):
        (WebCore::InspectorConsoleAgent::addInspectedNode):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::bind):
        (WebCore::InspectorDOMAgent::unbind):
        (WebCore::InspectorDOMAgent::assertNode):
        (WebCore::InspectorDOMAgent::assertElement):
        (WebCore::InspectorDOMAgent::assertHTMLElement):
        (WebCore::InspectorDOMAgent::nodeToSelectOn):
        (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
        (WebCore::InspectorDOMAgent::nodeForId):
        (WebCore::InspectorDOMAgent::getChildNodes):
        (WebCore::InspectorDOMAgent::querySelector):
        (WebCore::InspectorDOMAgent::querySelectorAll):
        (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
        (WebCore::InspectorDOMAgent::boundNodeId):
        (WebCore::InspectorDOMAgent::setAttribute):
        (WebCore::InspectorDOMAgent::removeAttribute):
        (WebCore::InspectorDOMAgent::removeNode):
        (WebCore::InspectorDOMAgent::setNodeName):
        (WebCore::InspectorDOMAgent::getOuterHTML):
        (WebCore::InspectorDOMAgent::setOuterHTML):
        (WebCore::InspectorDOMAgent::setNodeValue):
        (WebCore::InspectorDOMAgent::getEventListenersForNode):
        (WebCore::InspectorDOMAgent::resolveNode):
        (WebCore::InspectorDOMAgent::pushNodeToFrontend):
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        (WebCore::InspectorDOMAgent::loadEventFired):
        (WebCore::InspectorDOMAgent::didInsertDOMNode):
        (WebCore::InspectorDOMAgent::didRemoveDOMNode):
        (WebCore::InspectorDOMAgent::didModifyDOMAttr):
        (WebCore::InspectorDOMAgent::characterDataModified):
        (WebCore::InspectorDOMAgent::didInvalidateStyleAttr):
        (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
        (WebCore::InspectorDOMAgent::copyNode):
        (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDOMStorageAgent.cpp:
        (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
        (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
        (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
        (WebCore::InspectorDOMStorageAgent::storageId):
        (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
        * inspector/InspectorDOMStorageAgent.h:
        * inspector/InspectorDOMStorageResource.cpp:
        * inspector/InspectorDOMStorageResource.h:
        (WebCore::InspectorDOMStorageResource::id):
        * inspector/InspectorDatabaseAgent.cpp:
        (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
        (WebCore::InspectorDatabaseAgent::executeSQL):
        (WebCore::InspectorDatabaseAgent::databaseId):
        (WebCore::InspectorDatabaseAgent::databaseForId):
        * inspector/InspectorDatabaseAgent.h:
        * inspector/InspectorDatabaseResource.cpp:
        * inspector/InspectorDatabaseResource.h:
        (WebCore::InspectorDatabaseResource::id):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
        * inspector/InspectorProfilerAgent.h:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::identifierForInitialRequest):
        (WebCore::InspectorResourceAgent::willSendRequest):
        (WebCore::InspectorResourceAgent::markResourceAsCached):
        (WebCore::InspectorResourceAgent::didReceiveResponse):
        (WebCore::InspectorResourceAgent::didReceiveContentLength):
        (WebCore::InspectorResourceAgent::didFinishLoading):
        (WebCore::InspectorResourceAgent::didFailLoading):
        (WebCore::InspectorResourceAgent::setInitialContent):
        (WebCore::InspectorResourceAgent::didCreateWebSocket):
        (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
        (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
        (WebCore::InspectorResourceAgent::didCloseWebSocket):
        * inspector/generate-inspector-idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Mar 2011 07:44:51 +0000 (07:44 +0000)]
2011-03-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make frameId in network agent of type string, not unsigned long.
        https://bugs.webkit.org/show_bug.cgi?id=56708

        * inspector/report-protocol-errors-expected.txt:
2011-03-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make frameId in network agent of type string, not unsigned long.
        https://bugs.webkit.org/show_bug.cgi?id=56708

        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::highlightFrame):
        * inspector/InspectorAgent.h:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::pointerAsId):
        (WebCore::buildObjectForDocumentLoader):
        (WebCore::buildObjectForFrame):
        (WebCore::InspectorResourceAgent::frameDetachedFromParent):
        (WebCore::InspectorResourceAgent::frameForId):
        (WebCore::InspectorResourceAgent::resourceContent):
        * inspector/InspectorResourceAgent.h:
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.addOrUpdateFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Mar 2011 07:42:31 +0000 (07:42 +0000)]
2011-03-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: expose object id as string, not JSON struct in the protocol.
        https://bugs.webkit.org/show_bug.cgi?id=56681

        * http/tests/inspector/protocol-test.js:
        (initialize_ProtocolTest.InspectorTest.filterProps):
        (initialize_ProtocolTest.InspectorTest._dumpCallArguments):
        * inspector/protocol/runtime-agent-expected.txt:
        * inspector/protocol/runtime-agent.html:
2011-03-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: expose object id as string, not JSON struct in the protocol.
        https://bugs.webkit.org/show_bug.cgi?id=56681

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::inspect):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::inspectCallback):
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::evaluateOn):
        (WebCore::InjectedScript::evaluateOnCallFrame):
        (WebCore::InjectedScript::getProperties):
        (WebCore::InjectedScript::nodeForObjectId):
        (WebCore::InjectedScript::setPropertyValue):
        (WebCore::InjectedScript::releaseObject):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::inspectImpl):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptManager.cpp:
        (WebCore::InjectedScriptManager::injectedScriptForObjectId):
        (WebCore::InjectedScriptManager::releaseObjectGroup):
        * inspector/InjectedScriptManager.h:
        * inspector/InjectedScriptSource.js:
        * inspector/Inspector.json:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::clearConsoleMessages):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::pushNodeToFrontend):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::evaluateOn):
        (WebCore::InspectorRuntimeAgent::getProperties):
        (WebCore::InspectorRuntimeAgent::setPropertyValue):
        (WebCore::InspectorRuntimeAgent::releaseObject):
        (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
        (WebInspector.ConsoleView.prototype.completions):
        * inspector/front-end/PropertiesSidebarPane.js:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSection.prototype.update):
        * inspector/front-end/inspector.js:
        (WebInspector.inspect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Mar 2011 07:24:20 +0000 (07:24 +0000)]
2011-03-21  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: rebaselined Chromium expectations.

        * platform/chromium-win/svg/text/text-intro-05-t-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-20 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Mar 2011 05:59:45 +0000 (05:59 +0000)]
2011-03-20  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: removing stale Chromium expectations.

        * platform/chromium-win-vista/svg/text/text-intro-05-t-expected.checksum: Removed.
        * platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Removed.
        * platform/chromium-win-xp/svg/text/text-intro-05-t-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-20 Bill Budge <bbudge@chromium.org>
levin@chromium.org [Sun, 20 Mar 2011 23:30:26 +0000 (23:30 +0000)]
2011-03-20  Bill Budge  <bbudge@chromium.org>

        Reviewed by Adam Barth.

        Rename ThreadSafeShared to ThreadSafeRefCounted
        https://bugs.webkit.org/show_bug.cgi?id=56714

        No new tests. Exposes no new functionality.

        * API/JSClassRef.h:
        * API/OpaqueJSString.h:
        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/Atomics.h:
        * wtf/CMakeLists.txt:
        * wtf/CrossThreadRefCounted.h:
        (WTF::CrossThreadRefCounted::CrossThreadRefCounted):
        (WTF::::crossThreadCopy):
        * wtf/ThreadSafeRefCounted.h: Copied from wtf/ThreadSafeShared.h.
        (WTF::ThreadSafeRefCountedBase::ThreadSafeRefCountedBase):
        (WTF::ThreadSafeRefCountedBase::ref):
        (WTF::ThreadSafeRefCountedBase::refCount):
        (WTF::ThreadSafeRefCountedBase::derefBase):
        (WTF::ThreadSafeRefCounted::ThreadSafeRefCounted):
        * wtf/ThreadSafeShared.h: Removed.
        * wtf/Threading.h:

2011-03-20  Bill Budge  <bbudge@chromium.org>

        Reviewed by Adam Barth.

        Rename ThreadSafeShared to ThreadSafeRefCounted
        https://bugs.webkit.org/show_bug.cgi?id=56714

        No new tests. Exposes no new functionality.

        * ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from ForwardingHeaders/wtf/ThreadSafeShared.h.
        * ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
        * gyp/JavaScriptGlue.gypi:

2011-03-20  Bill Budge  <bbudge@chromium.org>

        Reviewed by Adam Barth.

        Rename ThreadSafeShared to ThreadSafeRefCounted
        https://bugs.webkit.org/show_bug.cgi?id=56714

        No new tests. Exposes no new functionality.

        * ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from ForwardingHeaders/wtf/ThreadSafeShared.h.
        * ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
        * bindings/v8/SerializedScriptValue.h:
        * dom/Document.cpp:
        * dom/default/PlatformMessagePortChannel.h:
        * fileapi/FileThread.h:
        * loader/ThreadableLoaderClientWrapper.h:
        (WebCore::ThreadableLoaderClientWrapper::create):
        (WebCore::ThreadableLoaderClientWrapper::clearClient):
        (WebCore::ThreadableLoaderClientWrapper::done):
        (WebCore::ThreadableLoaderClientWrapper::didSendData):
        (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse):
        (WebCore::ThreadableLoaderClientWrapper::didReceiveData):
        (WebCore::ThreadableLoaderClientWrapper::didReceiveCachedMetadata):
        (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
        (WebCore::ThreadableLoaderClientWrapper::didFail):
        (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
        (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancellation):
        (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
        * page/SecurityOrigin.h:
        * platform/CrossThreadCopier.h:
        * platform/network/BlobData.h:
        * platform/network/cf/SocketStreamHandle.h:
        * storage/AbstractDatabase.h:
        * storage/DatabaseAuthorizer.h:
        * storage/DatabaseCallback.h:
        * storage/DatabaseThread.h:
        * storage/IDBCallbacks.h:
        * storage/IDBCursorBackendInterface.h:
        * storage/IDBDatabaseBackendInterface.h:
        * storage/IDBFactoryBackendInterface.h:
        * storage/IDBIndexBackendInterface.h:
        * storage/IDBKey.h:
        * storage/IDBKeyRange.h:
        * storage/IDBObjectStoreBackendInterface.h:
        * storage/IDBRequest.h:
        * storage/IDBTransactionBackendInterface.h:
        * storage/SQLError.h:
        * storage/SQLResultSet.h:
        * storage/SQLStatement.h:
        * storage/SQLStatementCallback.h:
        * storage/SQLStatementErrorCallback.h:
        * storage/SQLTransaction.h:
        * storage/SQLTransactionCallback.h:
        * storage/SQLTransactionErrorCallback.h:
        * websockets/ThreadableWebSocketChannelClientWrapper.h:
        * workers/DefaultSharedWorkerRepository.cpp:

2011-03-20  Bill Budge  <bbudge@chromium.org>

        Reviewed by Adam Barth.

        Rename ThreadSafeShared to ThreadSafeRefCounted
        https://bugs.webkit.org/show_bug.cgi?id=56714

        No new tests. Exposes no new functionality.

        * Platform/CoreIPC/Connection.h:
        * Platform/WorkQueue.h:
        * Platform/win/WorkQueueWin.cpp:
        * UIProcess/Launcher/ProcessLauncher.h:
        * UIProcess/Launcher/ThreadLauncher.h:

2011-03-20  Bill Budge  <bbudge@chromium.org>

        Reviewed by Adam Barth.

        Rename ThreadSafeShared to ThreadSafeRefCounted
        https://bugs.webkit.org/show_bug.cgi?id=56714

        No new tests. Exposes no new functionality.

        * src/PlatformMessagePortChannel.h:
        * src/WebWorkerBase.cpp:
        * src/WorkerFileSystemCallbacksBridge.h:
        * src/WorkerFileWriterCallbacksBridge.h:

2011-03-20  Bill Budge  <bbudge@chromium.org>

        Reviewed by Adam Barth.

        Rename ThreadSafeShared to ThreadSafeRefCounted
        https://bugs.webkit.org/show_bug.cgi?id=56714

        No new tests. Exposes no new functionality.

        * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
        * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
        * Scripts/do-webcore-rename:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd http/tests/appcache/origin-delete.html to the Skipped list for WebKit2,
weinig@apple.com [Sun, 20 Mar 2011 22:25:24 +0000 (22:25 +0000)]
Add http/tests/appcache/origin-delete.html to the Skipped list for WebKit2,
since layoutTestController.clearAllApplicationCaches is not yet implemented
by WebKitTestRunner.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-20 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 20 Mar 2011 10:25:39 +0000 (10:25 +0000)]
2011-03-20  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Clean up redirection logic in QNetworkReplyHandler
        https://bugs.webkit.org/show_bug.cgi?id=56717

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
        Use resetState() when constructing QNRH as well.

        (WebCore::QNetworkReplyHandler::resetState):
        Delete (deferred) the m_reply if one exists (only when redirecting.)

        (WebCore::QNetworkReplyHandler::finish):
        Return early when redirecting.

        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
        (WebCore::QNetworkReplyHandler::redirect):
        Move the redirection logic from sendResponseIfNeeded() into a
        separate redirect() method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Anton D'Auria <adauria@apple.com>
commit-queue@webkit.org [Sun, 20 Mar 2011 03:39:53 +0000 (03:39 +0000)]
2011-03-19  Anton D'Auria  <adauria@apple.com>

        Reviewed by Dan Bernstein.

        Add stub to LayoutTestControllerGtk.cpp to fix GTK build
        https://bugs.webkit.org/show_bug.cgi?id=56719

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
        (LayoutTestController::clearApplicationCacheForOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 20 Mar 2011 00:57:05 +0000 (00:57 +0000)]
2011-03-19  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Remove StringImpl::computeHash()
        https://bugs.webkit.org/show_bug.cgi?id=49894

        Replace remainig StringImpl::computeHash with StringImpl::computeHashStringHasher.

        * wtf/text/AtomicString.cpp:
        (WTF::CStringTranslator::hash):
        (WTF::UCharBufferTranslator::hash):
        (WTF::HashAndCharactersTranslator::hash):
        * wtf/text/StringImpl.h:
        (WTF::StringImpl::setHash):
        (WTF::StringImpl::hash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sat, 19 Mar 2011 22:36:37 +0000 (22:36 +0000)]
2011-03-19  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Rename ignoreHttpError() to shouldIgnoreHttpError()

        The function doesn't ignore anything, thus it shouldn't have an imperative name.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::shouldIgnoreHttpError):
        (WebCore::QNetworkReplyHandler::finish):
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sat, 19 Mar 2011 22:18:05 +0000 (22:18 +0000)]
2011-03-19  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Kill layer violation FIXME in ResourceHandleQt.

        We were including qwebframe_p.h from WebKit/qt for no reason.

        * platform/network/qt/ResourceHandleQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sat, 19 Mar 2011 22:15:17 +0000 (22:15 +0000)]
2011-03-19  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Refactor handling of deferred loads
        https://bugs.webkit.org/show_bug.cgi?id=56715

        Split QNetworkReplyHandler's "load mode" into two parameters
        instead of trying to fit the deferral mechanism into it.

        Loads are now AsynchronousLoad (default) or SynchronousLoad (for sync XHR.)

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
        (WebCore::QNetworkReplyHandler::setLoadingDeferred):
        (WebCore::QNetworkReplyHandler::resumeDeferredLoad):
        (WebCore::QNetworkReplyHandler::finish):
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
        (WebCore::QNetworkReplyHandler::forwardData):
        (WebCore::QNetworkReplyHandler::start):
        (WebCore::QNetworkReplyHandler::resetState):
        * platform/network/qt/QNetworkReplyHandler.h:
        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::loadResourceSynchronously):
        (WebCore::ResourceHandle::platformSetDefersLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Anton D'Auria <adauria@apple.com>
commit-queue@webkit.org [Sat, 19 Mar 2011 21:28:57 +0000 (21:28 +0000)]
2011-03-19  Anton D'Auria  <adauria@apple.com>

        Reviewed by Alexey Proskuryakov.

        ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
        https://bugs.webkit.org/show_bug.cgi?id=56415

        This test creates an Application Cache for the DRT origin, deletes it for the origin,
        and verifies that the Application Cache has obsolete status.

        * http/tests/appcache/origin-delete-expected.txt: Added.
        * http/tests/appcache/origin-delete.html: Added.
        * http/tests/appcache/resources/origin-delete-iframe.html: Added.
        * http/tests/appcache/resources/origin-delete-iframe.manifest: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
2011-03-19  Anton D'Auria  <adauria@apple.com>

        Reviewed by Alexey Proskuryakov.

        ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
        https://bugs.webkit.org/show_bug.cgi?id=56415

        To delete all Application Cache for an origin, we must obsolete all
        in-memory cache groups for that origin. If a cache group isn't in memory,
        then it must be deleted from disk. The previous implementation correctly
        removed on-disk cache groups, but did not mark in-memory cache groups as obsolete.
        This caused an assertion failure in ApplicationCacheStorage::cacheGroupDestroyed()
        when the DocumentLoader was destroyed.

        Test: http/tests/appcache/origin-delete.html

        * WebCore.exp.in:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::clearStorageID):
        (WebCore::ApplicationCache::deleteCacheForOrigin):
        * loader/appcache/ApplicationCache.h:
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::findInMemoryCacheGroup):
        * loader/appcache/ApplicationCacheStorage.h:
2011-03-19  Anton D'Auria  <adauria@apple.com>

        Reviewed by Alexey Proskuryakov.

        ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
        https://bugs.webkit.org/show_bug.cgi?id=56415

        Use new ApplicationCache API to delete all cache for an origin.

        * WebCoreSupport/WebApplicationCache.h:
        * WebCoreSupport/WebApplicationCache.mm:
        (+[WebApplicationCache deleteOrigin:]):
2011-03-19  Anton D'Auria  <adauria@apple.com>

        Reviewed by Alexey Proskuryakov.

        ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
        https://bugs.webkit.org/show_bug.cgi?id=56415

        * WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: calling ApplicationCacheGroup::deleteCacheGroupsForOrigin
        instead of ApplicationCacheStorage::deleteEntriesForOrigin.
        (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
2011-03-19  Anton D'Auria  <adauria@apple.com>

        Reviewed by Alexey Proskuryakov.

        ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
        https://bugs.webkit.org/show_bug.cgi?id=56415

        * DumpRenderTree/LayoutTestController.cpp:
        (clearApplicationCacheForOriginCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::clearAllApplicationCaches):
        (LayoutTestController::clearApplicationCacheForOrigin):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
        (LayoutTestController::clearApplicationCacheForOrigin):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
        (LayoutTestController::clearApplicationCacheForOrigin):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
        (LayoutTestController::clearApplicationCacheForOrigin):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
        (LayoutTestController::clearApplicationCacheForOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Sat, 19 Mar 2011 20:11:55 +0000 (20:11 +0000)]
2011-03-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Add dummy GeolocationServiceEfl. cpp | h
        https://bugs.webkit.org/show_bug.cgi?id=56710

        Add dummy GeolocationServiceEfl.cpp | h to platform/efl.

        * CMakeListsEfl.txt:
        * platform/efl/GeolocationServiceEfl.cpp: Added.
        (WebCore::GeolocationServiceEfl::create):
        (WebCore::GeolocationServiceEfl::GeolocationServiceEfl):
        (WebCore::GeolocationServiceEfl::~GeolocationServiceEfl):
        (WebCore::GeolocationServiceEfl::startUpdating):
        (WebCore::GeolocationServiceEfl::stopUpdating):
        (WebCore::GeolocationServiceEfl::suspend):
        (WebCore::GeolocationServiceEfl::resume):
        (WebCore::GeolocationServiceEfl::lastPosition):
        (WebCore::GeolocationServiceEfl::lastError):
        * platform/efl/GeolocationServiceEfl.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 19 Mar 2011 20:09:56 +0000 (20:09 +0000)]
2011-03-19  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed, rolling out r81551.
        http://trac.webkit.org/changeset/81551
        https://bugs.webkit.org/show_bug.cgi?id=55336

        Broke some storage tests on Win32.

        * platform/win/FileSystemWin.cpp:
        (WebCore::statFile):
        (WebCore::getFileSize):
        (WebCore::getFileModificationTime):
        (WebCore::fileExists):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Sat, 19 Mar 2011 19:22:52 +0000 (19:22 +0000)]
2011-03-19  James Simonsen  <simonjam@chromium.org>

        [Chromium] Unreviewed, remove stale expectations for r81528.

        * platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.checksum:
        * platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png:
        * platform/chromium-win-xp/fast/text/justify-nbsp-expected.checksum: Removed.
        * platform/chromium-win-xp/fast/text/justify-nbsp-expected.png: Removed.
        * platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum: Removed.
        * platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Removed.
        * platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum: Removed.
        * platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sat, 19 Mar 2011 19:07:45 +0000 (19:07 +0000)]
2011-03-19  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Remove support for Qt 4.6
        https://bugs.webkit.org/show_bug.cgi?id=56712

        * Api/qwebframe.cpp:
        (QWebFrame::load):
        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        * Api/qwebsettings.cpp:
        (QWebSettings::QWebSettings):
        * WebCoreSupport/GeolocationClientQt.cpp:
        (WebCore::GeolocationClientQt::positionUpdated):
2011-03-19  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Remove support for Qt 4.6
        https://bugs.webkit.org/show_bug.cgi?id=56712

        * platform/graphics/qt/FontPlatformDataQt.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        * platform/graphics/qt/FontQt.cpp:
        (WebCore::drawTextCommon):
        (WebCore::Font::drawSimpleText):
        (WebCore::Font::floatWidthForSimpleText):
        (WebCore::Font::offsetForPositionForSimpleText):
        (WebCore::Font::selectionRectForSimpleText):
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3DInternal::paint):
        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::getImageData):
        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::internalHandleCurrentImage):
        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::transform):
        * platform/network/qt/DnsPrefetchHelper.h:
        (WebCore::DnsPrefetchHelper::DnsPrefetchHelper):
        (WebCore::DnsPrefetchHelper::lookup):
        * platform/network/qt/NetworkStateNotifierPrivate.h:
        * platform/network/qt/NetworkStateNotifierQt.cpp:
        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::httpMethod):
        (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
        (WebCore::QNetworkReplyHandler::start):
        * platform/network/qt/ResourceRequestQt.cpp:
        (WebCore::ResourceRequest::toNetworkRequest):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintMediaSliderTrack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sat, 19 Mar 2011 18:35:12 +0000 (18:35 +0000)]
2011-03-19  Andreas Kling  <kling@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
        https://bugs.webkit.org/show_bug.cgi?id=56711

        Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
        ownership of the reply is transferred to the receiving slot.

        * Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 19 Mar 2011 17:55:10 +0000 (17:55 +0000)]
2011-03-19  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Use Win32 API to get file information
        https://bugs.webkit.org/show_bug.cgi?id=55336

        Use GetFileInformationByHandle() in favour over _wstat64(), GetFileSizeEx()
        and GetFileAttributesEx() so we can share the code with WinCE.

        * platform/win/FileSystemWin.cpp:
        (WebCore::createFileHandle):
        (WebCore::getFileInformation):
        (WebCore::getFileSize):
        (WebCore::getFileModificationTime):
        (WebCore::fileExists):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 19 Mar 2011 14:25:14 +0000 (14:25 +0000)]
2011-03-19  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Simplify GObjectEventListener
        https://bugs.webkit.org/show_bug.cgi?id=56698

        Get rid of special case for DOMWindow, since it's also an
        EventTarget.

        * bindings/gobject/GObjectEventListener.cpp:
        (WebCore::GObjectEventListener::GObjectEventListener): remove
        DOMWindow special casing.
        (WebCore::GObjectEventListener::~GObjectEventListener): ditto.
        (WebCore::GObjectEventListener::gobjectDestroyed):
        * bindings/gobject/GObjectEventListener.h:
        (WebCore::GObjectEventListener::addEventListener): ditto.
        (WebCore::GObjectEventListener::removeEventListener): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Sat, 19 Mar 2011 13:08:55 +0000 (13:08 +0000)]
2011-03-19  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Nikolas Zimmermann.

        https://bugs.webkit.org/show_bug.cgi?id=56195
        Fix conditional which had an int for one case and a pointer for another.
        Similar fix as https://bugs.webkit.org/show_bug.cgi?id=56198

        No new tests. Fix compilation on Solaris 10 with Sun Studio C++

        * svg/SVGElement.cpp:
        (WebCore::SVGElement::sendSVGLoadEventIfPossible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-19 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 19 Mar 2011 11:42:29 +0000 (11:42 +0000)]
2011-03-19  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Rename WTF::StringHasher methods
        https://bugs.webkit.org/show_bug.cgi?id=53532

        Rename createHash to computeHash and createBlobHash to hashMemory.
        Also add a using WTF::StringHasher in the header file.

        * profiler/CallIdentifier.h:
        (JSC::CallIdentifier::Hash::hash):
        * runtime/Identifier.cpp:
        (JSC::IdentifierCStringTranslator::hash):
        (JSC::IdentifierUCharBufferTranslator::hash):
        * wtf/StringHasher.h:
        (WTF::StringHasher::computeHash):
        (WTF::StringHasher::hashMemory):
        * wtf/text/StringHash.h:
        (WTF::CaseFoldingHash::hash):
        * wtf/text/StringImpl.h:
        (WTF::StringImpl::computeHash):
        * wtf/unicode/UTF8.cpp:
        (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal):
2011-03-19  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Rename WTF::StringHasher methods
        https://bugs.webkit.org/show_bug.cgi?id=53532

        Rename createHash to computeHash and createBlobHash to hashMemory.
        Also add a using WTF::StringHasher in the header file.

        * dom/Document.cpp:
        (WebCore::FormElementKeyHash::hash):
        * dom/QualifiedName.h:
        (WebCore::hashComponents):
        * dom/StyledElement.cpp:
        (WebCore::MappedAttributeHash::hash):
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::urlHostHash):
        * page/SecurityOriginHash.h:
        (WebCore::SecurityOriginHash::hash):
        * platform/LinkHash.cpp:
        (WebCore::visitedLinkHashInline):
        * platform/cf/BinaryPropertyList.cpp:
        (WebCore::IntegerArrayHash::hash):
        * platform/cf/SchedulePair.h:
        (WebCore::SchedulePairHash::hash):
        * platform/graphics/FontCache.cpp:
        (WebCore::computeHash):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
        (WebCore::FontPlatformData::RefCountedHFONT::hash):
        * platform/graphics/cocoa/FontPlatformData.h:
        (WebCore::FontPlatformData::hash):
        * platform/graphics/pango/FontPlatformData.h:
        (WebCore::FontPlatformData::hash):
        * platform/graphics/wince/FontPlatformData.cpp:
        (WebCore::FixedSizeFontDataKeyHash::hash):
        * platform/graphics/wx/FontPlatformDataWx.cpp:
        (WebCore::FontPlatformData::computeHash):
        * platform/network/ProtectionSpaceHash.h:
        (WebCore::ProtectionSpaceHash::hash):
        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::hash):
        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::hash):
        * svg/properties/SVGAnimatedPropertyDescription.h:
        (WebCore::SVGAnimatedPropertyDescriptionHash::hash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevised build fix for r81135.
mitz@apple.com [Sat, 19 Mar 2011 04:52:58 +0000 (04:52 +0000)]
Revised build fix for r81135.

* WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81547 268f45cc-cd09-0410-ab3c-d52691b4dbfc