WebKit-https.git
10 years agoAdd Samsung to security vendor member list
gyuyoung.kim@samsung.com [Wed, 21 Nov 2012 03:58:47 +0000 (03:58 +0000)]
Add Samsung to security vendor member list
https://bugs.webkit.org/show_bug.cgi?id=102863

Reviewed by Sam Weinig.

* security/security-group-members.html: Add Samsung members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL][WK2] Add Ewk_Window_Features API and related UI callbacks
commit-queue@webkit.org [Wed, 21 Nov 2012 03:21:11 +0000 (03:21 +0000)]
[EFL][WK2] Add Ewk_Window_Features API and related UI callbacks
https://bugs.webkit.org/show_bug.cgi?id=99114

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-20
Reviewed by Gyuyoung Kim.

Source/WebKit2:

Added Ewk_Window_Features API so that we can create new windows
with various window features such as location, size, toolbar, menubar,
statusbar, locationbar, scrollbar, resizable, and fullscreen.

UI client callbacks related to window features also implemented
so that it is possible to retrieve the window object property values.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/EwkViewCallbacks.h:
(EwkViewCallbacks):
* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::windowFeatures):
(EwkViewImpl::createNewPage):
(EwkViewImpl::closePage):
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::createNewPage):
(WebKit::PageUIClientEfl::toolbarsAreVisible):
(WebKit):
(WebKit::PageUIClientEfl::setToolbarsAreVisible):
(WebKit::PageUIClientEfl::menuBarIsVisible):
(WebKit::PageUIClientEfl::setMenuBarIsVisible):
(WebKit::PageUIClientEfl::statusBarIsVisible):
(WebKit::PageUIClientEfl::setStatusBarIsVisible):
(WebKit::PageUIClientEfl::isResizable):
(WebKit::PageUIClientEfl::setIsResizable):
(WebKit::PageUIClientEfl::PageUIClientEfl):
* UIProcess/efl/PageUIClientEfl.h:
(PageUIClientEfl):

Tools:

Implemented window_create and window_close smartcallback functions.

* MiniBrowser/efl/main.c:
(on_window_create):
(on_window_close):
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Need spellcheck suggestions even if continuous check is off.
commit-queue@webkit.org [Wed, 21 Nov 2012 03:13:18 +0000 (03:13 +0000)]
[Chromium] Need spellcheck suggestions even if continuous check is off.
https://bugs.webkit.org/show_bug.cgi?id=102535

Patch by Rachel Blum <groby@chromium.org> on 2012-11-20
Reviewed by Hajime Morita.

Make sure the context menu always has suggestions for misspelled words.

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG should be able to cache closure calls
fpizlo@apple.com [Wed, 21 Nov 2012 02:34:46 +0000 (02:34 +0000)]
DFG should be able to cache closure calls
https://bugs.webkit.org/show_bug.cgi?id=102662

Reviewed by Gavin Barraclough.

Added support to the meta allocator for easily querying whether an address falls within
a certain allocated chunk. Also added a useful debug routine to SentinelLinkedList,
which can be used to check if a node is on a particular list.

* wtf/MetaAllocatorHandle.h:
(MetaAllocatorHandle):
(WTF::MetaAllocatorHandle::containsIntegerAddress):
(WTF::MetaAllocatorHandle::contains):
* wtf/SentinelLinkedList.h:
(SentinelLinkedList):
(WTF::::isOnList):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove $outputDir and $outputHeadersDir from global variables of code generators
haraken@chromium.org [Wed, 21 Nov 2012 02:32:58 +0000 (02:32 +0000)]
Remove $outputDir and $outputHeadersDir from global variables of code generators
https://bugs.webkit.org/show_bug.cgi?id=102492

Reviewed by Adam Barth.

$outputDir and $outputHeadersDir are used in WriteData() only.
We don't need to use global variables for them.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(ProcessDocument):
(FileNamePrefix):
* bindings/scripts/CodeGeneratorCPP.pm:
(new):
(GenerateInterface):
(WriteData):
* bindings/scripts/CodeGeneratorGObject.pm:
(new):
(WriteData):
(GenerateInterface):
* bindings/scripts/CodeGeneratorJS.pm:
(new):
(GenerateInterface):
(WriteData):
* bindings/scripts/CodeGeneratorObjC.pm:
(new):
(GenerateInterface):
(WriteData):
* bindings/scripts/CodeGeneratorV8.pm:
(new):
(GenerateInterface):
(WriteData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago7% regression in dromaeo_domcorequery/dom_query_getElementsByTagName__not_in_document
abarth@webkit.org [Wed, 21 Nov 2012 02:15:30 +0000 (02:15 +0000)]
7% regression in dromaeo_domcorequery/dom_query_getElementsByTagName__not_in_document
https://bugs.webkit.org/show_bug.cgi?id=102852

Reviewed by Kentaro Hara.

In http://trac.webkit.org/changeset/135208/, we lost the early-exit
check for whether isolatedWorldsExist() in this code path. This
regression points to benchmarks that we can further improve by
continuing to merge the general ScriptWrappable code path with the Node
code path.

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::current):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] Change a return type of V8Parameter::prepare() from bool to void
haraken@chromium.org [Wed, 21 Nov 2012 01:58:09 +0000 (01:58 +0000)]
[V8] Change a return type of V8Parameter::prepare() from bool to void
https://bugs.webkit.org/show_bug.cgi?id=102805

Reviewed by Adam Barth.

This is an incremental step for V8Parameter refactoring.

V8Parameter::prepare() is always called just after V8Parameter's
constructor. So I want to move the logic of V8Parameter::prepare()
to V8Parameter's constructor. In preparation for that (i.e. because
a constructor cannot return any value), this patch changes the return
type of V8Parameter::prepare() from bool to void.

Tests: fast/workers/worker-constructor.html
       storage/websql/sql-error-codes.html
       inspector/console/alert-toString-exception.html
       http/tests/websocket/tests/hybi/send-throw.html
       etc

* bindings/v8/V8BindingMacros.h:
* bindings/v8/V8StringResource.h:
(V8Parameter):
(WebCore::V8Parameter::prepareBase): This patch removes a TryCatch block.
This change is safe because (1) all V8Parameter::prepareBase() in the code base
is called inside STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(), and because
(2) STRING_TO_V8PARAMETER_EXCEPTION_BLOCK() has a TryCatch block.
(Note: In a follow-up patch I'm planning to refactor the macros.)
(WebCore::::prepare): I will remove this method shortly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[JSC] MutationObserver wrapper should not be collected while still observing
adamk@chromium.org [Wed, 21 Nov 2012 01:35:49 +0000 (01:35 +0000)]
[JSC] MutationObserver wrapper should not be collected while still observing
https://bugs.webkit.org/show_bug.cgi?id=102744

Reviewed by Adam Barth.

Source/WebCore:

This is the JSC side of the change landed for V8 in r135228.
It ensures MutationObserver wrapper objects are kept alive as long as
any observed nodes.

* bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverOwner::isReachableFromOpaqueRoots): Keep MutationObserver wrappers alive
if any of their observed nodes' roots is an opaque root.
* dom/MutationObserver.idl: Add JSCustomIsReachable

LayoutTests:

Remove suppressions for wrapper dropoff tests.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG should be able to cache closure calls (part 2/2)
fpizlo@apple.com [Wed, 21 Nov 2012 01:29:52 +0000 (01:29 +0000)]
DFG should be able to cache closure calls (part 2/2)
https://bugs.webkit.org/show_bug.cgi?id=102662

Reviewed by Gavin Barraclough.

Added caching of calls where the JSFunction* varies, but the Structure* and ExecutableBase*
stay the same. This is accomplished by replacing the branch that compares against a constant
JSFunction* with a jump to a closure call stub. The closure call stub contains a fast path,
and jumps slow directly to the virtual call thunk.

Looks like a 1% win on V8v7.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::unlink):
* bytecode/CallLinkInfo.h:
(CallLinkInfo):
(JSC::CallLinkInfo::isLinked):
(JSC::getCallLinkInfoBytecodeIndex):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally):
(JSC):
(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::codeOriginForReturn):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::getCallLinkInfo):
(CodeBlock):
(JSC::CodeBlock::isIncomingCallAlreadyLinked):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord):
(JSCallRecord):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::linkSlowFor):
(DFG):
(JSC::DFG::dfgLinkFor):
(JSC::DFG::dfgLinkSlowFor):
(JSC::DFG::dfgLinkClosureCall):
* dfg/DFGRepatch.h:
(DFG):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* dfg/DFGThunks.cpp:
(DFG):
(JSC::DFG::linkClosureCallThunkGenerator):
* dfg/DFGThunks.h:
(DFG):
* heap/Heap.h:
(Heap):
(JSC::Heap::jitStubRoutines):
* heap/JITStubRoutineSet.h:
(JSC::JITStubRoutineSet::size):
(JSC::JITStubRoutineSet::at):
(JITStubRoutineSet):
* jit/ClosureCallStubRoutine.cpp: Added.
(JSC):
(JSC::ClosureCallStubRoutine::ClosureCallStubRoutine):
(JSC::ClosureCallStubRoutine::~ClosureCallStubRoutine):
(JSC::ClosureCallStubRoutine::markRequiredObjectsInternal):
* jit/ClosureCallStubRoutine.h: Added.
(JSC):
(ClosureCallStubRoutine):
(JSC::ClosureCallStubRoutine::structure):
(JSC::ClosureCallStubRoutine::executable):
(JSC::ClosureCallStubRoutine::codeOrigin):
* jit/GCAwareJITStubRoutine.cpp:
(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
* jit/GCAwareJITStubRoutine.h:
(GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::isClosureCall):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r131106): magnitude-perf.js calls bind on undefined
rniwa@webkit.org [Wed, 21 Nov 2012 01:11:03 +0000 (01:11 +0000)]
REGRESSION(r131106): magnitude-perf.js calls bind on undefined
https://bugs.webkit.org/show_bug.cgi?id=102848

Reviewed by Tony Gentilcore.

Check the existence of performance.now before calling bind on it.

* resources/magnitude-perf.js:
(Magnitude._runIteration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSimplify builder filters now that we have lists of which builders run which tests
ojan@chromium.org [Wed, 21 Nov 2012 00:45:19 +0000 (00:45 +0000)]
Simplify builder filters now that we have lists of which builders run which tests
https://bugs.webkit.org/show_bug.cgi?id=102849

Reviewed by Dirk Pranke.

We only need filters when we load the same master for multiple groups in the
same test type, i.e. when we need to only include some of the builders that run
a given test suite on a given master.

Also, get rid of the DEFAULT_BUILDER enum. We were always using the first builder anyways.
Now just make it a method on BuilderGroup.

* TestResultServer/static-dashboards/builders.js:
(BuilderGroup.prototype.append):
(BuilderGroup.prototype.setup):
(BuilderGroup.prototype._defaultBuilder):
(BuilderGroup.prototype.master):
(requestBuilderList):
(isChromiumWebkitTipOfTreeTestRunner):
(isChromiumWebkitDepsTestRunner):
(loadBuildersList):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIndexedDB: remove setVersion from pending-version-change-on-exit.html
dgrogan@chromium.org [Wed, 21 Nov 2012 00:45:17 +0000 (00:45 +0000)]
IndexedDB: remove setVersion from pending-version-change-on-exit.html
https://bugs.webkit.org/show_bug.cgi?id=102457

Reviewed by Tony Chang.

This test doesn't work in single-process mode because of
http://wkb.ug/82776. We run it in content_shell in chromium.

* platform/chromium/TestExpectations:
* storage/indexeddb/pending-version-change-on-exit-expected.txt:
* storage/indexeddb/pending-version-change-on-exit.html:
* storage/indexeddb/resources/pending-version-change-on-exit.js:
(request.onblocked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIndexedDB: Move control of transaction completion to front end
jsbell@chromium.org [Wed, 21 Nov 2012 00:35:09 +0000 (00:35 +0000)]
IndexedDB: Move control of transaction completion to front end
https://bugs.webkit.org/show_bug.cgi?id=100903

Reviewed by Tony Chang.

"When a transaction can no longer become active, the implementation must attempt to
commit it" - that is, all requests have dispatched success/error events and no further
requests have been made. Previously, this was done by the back end waiting for events
from the front end, but the front end can more efficiently make the decision.

There should be no detectable behavior change.

Tests: storage/indexeddb/transaction-*.html

* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::setActive):
(WebCore::IDBTransaction::registerRequest):
* Modules/indexeddb/IDBTransaction.h:
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::hasPendingTasks): Added.
(WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents):
(WebCore::IDBTransactionBackendImpl::run):
(WebCore::IDBTransactionBackendImpl::taskEventTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove perfav master for webkit_unit_tests and test_shell_tests.
ojan@chromium.org [Wed, 21 Nov 2012 00:27:00 +0000 (00:27 +0000)]
Remove perfav master for webkit_unit_tests and test_shell_tests.
There are no bots on this master that run these tests.
* TestResultServer/static-dashboards/builders.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG should be able to cache closure calls (part 1/2)
fpizlo@apple.com [Wed, 21 Nov 2012 00:22:08 +0000 (00:22 +0000)]
DFG should be able to cache closure calls (part 1/2)
https://bugs.webkit.org/show_bug.cgi?id=102662

Reviewed by Gavin Barraclough.

Add ability to revert a jump replacement back to
branchPtrWithPatch(Condition, RegisterID, TrustedImmPtr). This is meant to be
a mandatory piece of functionality for all assemblers. I also renamed some of
the functions for reverting jump replacements back to
patchableBranchPtrWithPatch(Condition, Address, TrustedImmPtr), so as to avoid
confusion.

* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::BadReg):
(ARMv7Assembler):
(JSC::ARMv7Assembler::revertJumpTo_movT3):
* assembler/LinkBuffer.h:
(JSC):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::startOfBranchPtrWithPatchOnRegister):
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):
(JSC::MacroAssemblerARMv7::startOfPatchableBranchPtrWithPatchOnAddress):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::startOfBranchPtrWithPatchOnRegister):
(MacroAssemblerX86):
(JSC::MacroAssemblerX86::startOfPatchableBranchPtrWithPatchOnAddress):
(JSC::MacroAssemblerX86::revertJumpReplacementToBranchPtrWithPatch):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::startOfBranchPtrWithPatchOnRegister):
(JSC::MacroAssemblerX86_64::startOfPatchableBranchPtrWithPatchOnAddress):
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::revertJumpReplacementToBranchPtrWithPatch):
* assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::startOfBranchPtrWithPatchOnRegister):
(RepatchBuffer):
(JSC::RepatchBuffer::startOfPatchableBranchPtrWithPatchOnAddress):
(JSC::RepatchBuffer::revertJumpReplacementToBranchPtrWithPatch):
* assembler/X86Assembler.h:
(JSC::X86Assembler::revertJumpTo_cmpl_ir_force32):
(X86Assembler):
* dfg/DFGRepatch.cpp:
(JSC::DFG::replaceWithJump):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rebaselined run-bindings-tests results.
haraken@chromium.org [Wed, 21 Nov 2012 00:20:12 +0000 (00:20 +0000)]
Unreviewed. Rebaselined run-bindings-tests results.

* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Chromium build fix.
hclam@chromium.org [Wed, 21 Nov 2012 00:12:55 +0000 (00:12 +0000)]
Unreviewed. Chromium build fix.

Removed unnecessary mutex unlock that triggered crash on Linux debug build.

Chromium Linux Debug layout tests should be green:
platform/chromium/virtual/deferred/fast/images/image-in-map.html

* platform/graphics/chromium/LazyDecodingPixelRef.cpp:
(WebCore::LazyDecodingPixelRef::onLockPixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix another typo. I need to checking that type() != NodeListCollectionType,
rniwa@webkit.org [Wed, 21 Nov 2012 00:07:02 +0000 (00:07 +0000)]
Fix another typo. I need to checking that type() != NodeListCollectionType,
not that type() >= FirstNodeCollectionType.

* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):
* dom/DynamicNodeList.h:
(WebCore::DynamicNodeListCacheBase::invalidateCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove special case for layout tests when builders fail to load
ojan@chromium.org [Tue, 20 Nov 2012 23:56:48 +0000 (23:56 +0000)]
Remove special case for layout tests when builders fail to load
https://bugs.webkit.org/show_bug.cgi?id=102842

Reviewed by Tony Chang.

Now that we load only builders that actually run the given test
type, we can reliably show errors to the users because it
represents a broken bot.
* TestResultServer/static-dashboards/loader.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] Pass ScriptState::current() to functions marked with CallWith=ScriptState
commit-queue@webkit.org [Tue, 20 Nov 2012 23:50:59 +0000 (23:50 +0000)]
[V8] Pass ScriptState::current() to functions marked with CallWith=ScriptState
https://bugs.webkit.org/show_bug.cgi?id=102739

Patch by Michael Pruett <michael@68k.org> on 2012-11-20
Reviewed by Kentaro Hara.

Previously EmptyScriptState rather than ScriptState::current()
was passed to functions marked with [CallWith=ScriptState].
Since the EmptyScriptState has a null v8::Context, any functions
which depended upon a valid v8::Context would fail.

No new tests. Covered by existing tests.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateCallWith):
(GenerateFunctionCallString):
* bindings/v8/ScriptState.h:
(WebCore::ScriptState::clearException): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Build fix after r135217.
bfulgham@webkit.org [Tue, 20 Nov 2012 23:47:56 +0000 (23:47 +0000)]
[Qt] Build fix after r135217.
https://bugs.webkit.org/show_bug.cgi?id=102787

* platform/win/WindowsExtras.h: Switch to direct include of
  <ObjBase.h>, as is done in other <shlwapi.h> includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix typos. Apparently XCode failed to text-replace earlier when it was busy making...
rniwa@webkit.org [Tue, 20 Nov 2012 23:45:38 +0000 (23:45 +0000)]
Fix typos. Apparently XCode failed to text-replace earlier when it was busy making a snapshot :(

* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):
* dom/DynamicNodeList.h:
(WebCore::DynamicNodeListCacheBase::invalidateCache):
(DynamicNodeListCacheBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] Introduce GenerateConstructorHeader() to CodeGeneratorV8.pm
haraken@chromium.org [Tue, 20 Nov 2012 23:42:16 +0000 (23:42 +0000)]
[V8] Introduce GenerateConstructorHeader() to CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=102806

Reviewed by Adam Barth.

This is an incremental step for introducing constructorCallbackCustom().
(See bug 102763.) This patch adds GenerateConstructorHeader()
that generates a common code for constructors.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateConstructorHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHTMLCollection's cache should not be invalidated when id or name attributes are changed
rniwa@webkit.org [Tue, 20 Nov 2012 23:40:49 +0000 (23:40 +0000)]
HTMLCollection's cache should not be invalidated when id or name attributes are changed
https://bugs.webkit.org/show_bug.cgi?id=102843

Reviewed by Eric Seidel.

When an id or name attribute changes, only invaliate id and name cache maps when the collection
doesn't depend on id and name attributes (e.g. document.images).

Unfortunately, I could not create a reliable test for this performance problem.

* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):
* dom/DynamicNodeList.h:
(WebCore::DynamicNodeListCacheBase::invalidateCache):
(DynamicNodeListCacheBase):
* dom/ElementRareData.h:
(WebCore::ElementRareData::clearHTMLCollectionCaches):
* html/HTMLCollection.cpp:
(WebCore::invalidationTypeExcludingIdAndNameAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[v8] Avoid unnecessary call to ToObject() in Callback constructors
adamk@chromium.org [Tue, 20 Nov 2012 23:38:44 +0000 (23:38 +0000)]
[v8] Avoid unnecessary call to ToObject() in Callback constructors
https://bugs.webkit.org/show_bug.cgi?id=102831

Reviewed by Adam Barth.

The code already asserted that the argument was an object, so calling
ToObject() is unnecessary: a simple Cast() suffices.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackHeader):
* bindings/scripts/test/V8/V8TestCallback.h:
(WebCore::V8TestCallback::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Animated gifs pause on scroll or zoom and sometimes don't resume after...
commit-queue@webkit.org [Tue, 20 Nov 2012 23:34:14 +0000 (23:34 +0000)]
[BlackBerry] Animated gifs pause on scroll or zoom and sometimes don't resume after scroll or zoom completes
https://bugs.webkit.org/show_bug.cgi?id=102838

Patch by Andrew Lo <anlo@rim.com> on 2012-11-20
Reviewed by Rob Buis.

Internally reviewed by Adam Treat.
Internal PR244646
When entering scrolling & zooming, we suspend regular render jobs
in order to pause animations. When finishing scrolling or zooming,
dispatch a render job in order to resume those animations.

If an animation requests a repaint while the backing store is suspended,
add the regular render job to the render queue so that it can be
processed later.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Use embedder-supported gesture curves
rjkroege@chromium.org [Tue, 20 Nov 2012 23:27:39 +0000 (23:27 +0000)]
[chromium] Use embedder-supported gesture curves
https://bugs.webkit.org/show_bug.cgi?id=100884

Reviewed by James Robinson.

Use embedder-provided gesture animation curves via WebKit api interfaces.
Tested by existing tests.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollBy):
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
* src/WebViewImpl.h:
(WebCore):
(WebKit):
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] Build fix after r135316
bfulgham@webkit.org [Tue, 20 Nov 2012 22:54:38 +0000 (22:54 +0000)]
[WinCairo] Build fix after r135316

* platform/network/curl/AuthenticationChallenge.h: Update stub
  implementations to match Apple Windows port.
(WebCore::AuthenticationChallenge::AuthenticationChallenge): Add
  missing identifier argument.
(WebCore::AuthenticationChallenge::setAuthenticationClient): Supply
  missing set method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWhen calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
tony@chromium.org [Tue, 20 Nov 2012 22:50:37 +0000 (22:50 +0000)]
When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
https://bugs.webkit.org/show_bug.cgi?id=102835

Reviewed by Ojan Vafai.

After r135082, Chromium browser_tests were triggering the ASSERT in
StyleResolver::collectRulesFromUserStyleSheets. Add an ASSERT that will
trigger earlier and make it clear in the Chromium code that we're always
inserting user level styles.

Source/WebCore:

No new tests, no behavior change except no longer triggering the StyleResolver ASSERT
in Chromium browser_tests.

* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::addUserSheet):

Source/WebKit/chromium:

* src/WebDocument.cpp:
(WebKit::WebDocument::insertUserStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProvide page/window coordinates to plugin's local coordinates translation in WebPlugi...
commit-queue@webkit.org [Tue, 20 Nov 2012 22:41:29 +0000 (22:41 +0000)]
Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer.
https://bugs.webkit.org/show_bug.cgi?id=102339

Patch by Istiaque Ahmed <lazyboy@chromium.org> on 2012-11-20
Reviewed by Adam Barth.

This change will allow converting a page's window coordinates to plugins's local coordinates,
taking CSS transformations into account. Embedder page of the plugin can use this information
for targetting elements inside the plugin (e.g. devtools can inspect a specific element at the
local coordinate position inside plugin).

* WebKit.gyp:
* WebKit.gypi:
* public/WebNode.h:
(WebKit):
* public/WebPluginContainer.h:
(WebKit):
(WebPluginContainer):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeCommand):
(WebKit::WebFrameImpl::printBegin):
(WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):
* src/WebNode.cpp:
(WebKit::WebNode::pluginContainer):
(WebKit):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::windowToLocalPoint):
(WebKit):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* tests/FakeWebPlugin.cpp: Added.
(WebKit):
(WebKit::FakeWebPlugin::FakeWebPlugin):
(WebKit::FakeWebPlugin::~FakeWebPlugin):
(WebKit::FakeWebPlugin::initialize):
(WebKit::FakeWebPlugin::destroy):
* tests/FakeWebPlugin.h: Added.
(WebKit):
(FakeWebPlugin):
* tests/WebPluginContainerTest.cpp: Added.
(WebKit):
(WebPluginContainerTest):
(WebKit::WebPluginContainerTest::WebPluginContainerTest):
(WebKit::WebPluginContainerTest::TearDown):
(WebKit::getWebPluginContainer):
(WebKit::TEST_F):
* tests/data/plugin_container.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CSS Exclusions] Support outside-shape value on shape-inside
commit-queue@webkit.org [Tue, 20 Nov 2012 22:39:38 +0000 (22:39 +0000)]
[CSS Exclusions] Support outside-shape value on shape-inside
https://bugs.webkit.org/show_bug.cgi?id=101108

Patch by Bear Travis <betravis@adobe.com> on 2012-11-20
Reviewed by Dirk Schulze.

Source/WebCore:

Shape-inside can potentially be: 'auto' | 'outside-shape' | <shape> | <url>.
Webkit currently supports the value 'auto' (null) and <shape> (a BasicShape*).
This patch adds support for the value 'outside-shape.' It adds the ExclusionShapeValue
class, which may be any of the three values: 'auto', 'outside-shape', or <shape>.
Bug 102738 tracks adding <url> support.

Modifying existing tests:
LayoutTests/fast/exclusions/parsing-wrap-shape-inside.html
LayoutTests/fast/exclusions/parsing-wrap-shape-outside.html

* GNUmakefile.list.am: Adding ExclusionShapeValue.h to the build files.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
(WebCore):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Modifying code to use
ExclusionShapeValue* rather than the previous BasicShape* values.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Handle the outside-shape value.
* css/CSSValueKeywords.in: Adding outside-shape value.
* css/StyleBuilder.cpp:
(WebCore):
(WebCore::ApplyPropertyExclusionShape::setValue): Modify code to use
ExclusionShapeValue* rather than BasicShape*.
(WebCore::ApplyPropertyExclusionShape::applyValue): Ditto.
(WebCore::ApplyPropertyExclusionShape::createHandler): Ditto.
* page/animation/CSSPropertyAnimation.cpp: Ditto.
(WebCore::blendFunc): Ditto.
(WebCore::PropertyWrapperExclusionShape::PropertyWrapperExclusionShape): Ditto.
(WebCore::CSSPropertyAnimation::ensurePropertyMap): Ditto.
* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock):
Ditto.
(WebCore::ExclusionShapeInsideInfo::computeShapeSize): Ditto.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Ditto.
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/style/ExclusionShapeValue.h: Added.
(WebCore):
(ExclusionShapeValue): New type to represent the possible values of shape-inside
and shape-outside. Only shape-inside can have a value of 'outside-shape.'
(WebCore::ExclusionShapeValue::~ExclusionShapeValue):
(WebCore::ExclusionShapeValue::type): Returns the value type.
(WebCore::ExclusionShapeValue::shape): Returns <shape> value's BasicShape*.
(WebCore::ExclusionShapeValue::operator==):
(WebCore::ExclusionShapeInfo::createShapeValue):
(WebCore::ExclusionShapeInfo::createOutsideValue):
(WebCore::ExclusionShapeValue::ExclusionShapeValue):
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):

LayoutTests:

Adding tests to make sure the 'outside-shape' value properly applies only to the
shape-inside property.

* fast/exclusions/parsing-wrap-shape-inside-expected.txt:
* fast/exclusions/parsing-wrap-shape-outside-expected.txt:
* fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
* fast/exclusions/script-tests/parsing-wrap-shape-outside.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Make lazy image decoding thread-safe
hclam@chromium.org [Tue, 20 Nov 2012 22:27:07 +0000 (22:27 +0000)]
[chromium] Make lazy image decoding thread-safe
https://bugs.webkit.org/show_bug.cgi?id=102721

Reviewed by Stephen White.

Source/WebCore:

Added mutex to LazyDecodingPixelRef such that there is no parallel
onLockPixels() running on multiple threads.

Added mutex to ImageFrameGenerator to protect the use of raw image
data.

The result is that we can decode on threads other than the main
thread while data is being supplied on the main thread.

New unit test:
DeferredImageDecoderTest.decodeOnOtherThread

* platform/graphics/chromium/ImageFrameGenerator.cpp:
(WebCore::ImageFrameGenerator::setData):
(WebCore::ImageFrameGenerator::decodeAndScale):
* platform/graphics/chromium/ImageFrameGenerator.h:
(ImageFrameGenerator):
* platform/graphics/chromium/LazyDecodingPixelRef.cpp:
(WebCore::LazyDecodingPixelRef::onLockPixels):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):
* platform/graphics/chromium/LazyDecodingPixelRef.h:
(LazyDecodingPixelRef):

Source/WebKit/chromium:

Added a new unit test to verify that lazy image decoding operates
correctly on non-main threads.

* tests/DeferredImageDecoderTest.cpp:
(Rasterizer):
(WebCore):
(WebCore::rasterizeMain):
(WebCore::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Build fix after r135217.
bfulgham@webkit.org [Tue, 20 Nov 2012 22:25:33 +0000 (22:25 +0000)]
[Qt] Build fix after r135217.
https://bugs.webkit.org/show_bug.cgi?id=102787

* platform/win/WindowsExtras.h: Add #undef of NOSHLWAPI to
allow include of <ObjBase.h> needed by Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Updated chromium test expectations.
jianli@chromium.org [Tue, 20 Nov 2012 22:25:14 +0000 (22:25 +0000)]
Unreviewed. Updated chromium test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r135295.
commit-queue@webkit.org [Tue, 20 Nov 2012 22:08:37 +0000 (22:08 +0000)]
Unreviewed, rolling out r135295.
http://trac.webkit.org/changeset/135295
https://bugs.webkit.org/show_bug.cgi?id=102834

This patch causes assertion to some layout tests on chromium
(Requested by jianli on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/FrameLoadRequest.cpp: Removed.
* loader/FrameLoadRequest.h:
(WebCore::FrameLoadRequest::FrameLoadRequest):
(FrameLoadRequest):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::load):
* loader/FrameLoader.h:
(FrameLoader):
* page/DragController.cpp:
(WebCore::DragController::performDrag):
* plugins/PluginView.cpp:
(WebCore::PluginView::performRequest):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPagePrivate::loadString):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

Source/WebKit/chromium:

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadData):
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::initializeLoader):

Source/WebKit/efl:

* ewk/ewk_frame.cpp:
(ewk_frame_uri_set):
(_ewk_frame_contents_set_internal):

Source/WebKit/gtk:

* webkit/webkitwebframe.cpp:
(webkit_web_frame_load_uri):
(webkit_web_frame_load_data):
(webkit_web_frame_load_request):

Source/WebKit/mac:

* Plugins/WebPluginController.mm:
* WebView/WebFrame.mm:
(-[WebFrame loadRequest:]):
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebFrame::QWebFrame):
(QWebFrame::load):
(QWebFrame::setHtml):
(QWebFrame::setContent):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setAlternateHtml):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::callErrorPageExtension):

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::loadRequest):
(WebFrame::loadData):

Source/WebKit/wince:

* WebView.cpp:
(WebView::load):

Source/WebKit/wx:

* WebFrame.cpp:
(WebKit::WebFrame::SetPageSource):

Source/WebKit2:

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performFrameLoadURLRequest):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadData):
(WebKit::WebPage::linkClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r135293.
commit-queue@webkit.org [Tue, 20 Nov 2012 21:47:58 +0000 (21:47 +0000)]
Unreviewed, rolling out r135293.
http://trac.webkit.org/changeset/135293
https://bugs.webkit.org/show_bug.cgi?id=102832

This patch causes crash to some layout tests on chromium
(Requested by jianli on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::current):
* bindings/v8/DOMWrapperWorld.cpp:
* bindings/v8/DOMWrapperWorld.h:
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::collectIsolatedContexts):
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/V8Binding.h:
(WebCore::worldForEnteredContextIfIsolated):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
* bindings/v8/V8DOMWindowShell.h:
(WebCore::V8DOMWindowShell::isolated):
(V8DOMWindowShell):
* bindings/v8/V8PerContextData.h:
* bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIndexedDB: Remove legacy enum-based constants from IDL
dgrogan@chromium.org [Tue, 20 Nov 2012 21:10:23 +0000 (21:10 +0000)]
IndexedDB: Remove legacy enum-based constants from IDL
https://bugs.webkit.org/show_bug.cgi?id=85315

Reviewed by Adam Barth.

Source/WebCore:

These were only present in an earlier working draft of the spec and have
been removed for 8 months. See
http://lists.w3.org/Archives/Public/public-webapps/2012JanMar/0957.html

Tests - legacy-constants.html

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::stringToDirection):
* Modules/indexeddb/IDBCursor.idl:
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::stringToMode):
* Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

* storage/indexeddb/constants-expected.txt:
* storage/indexeddb/cursor-overloads-expected.txt:
* storage/indexeddb/cursor-overloads.html:
* storage/indexeddb/legacy-constants-expected.txt:
* storage/indexeddb/resources/constants.js:
(test):
* storage/indexeddb/resources/legacy-constants.js:
(testObsoleteConstants):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoanimations/stop-animation-on-suspend.html sometimes fails on all platforms
commit-queue@webkit.org [Tue, 20 Nov 2012 21:00:08 +0000 (21:00 +0000)]
animations/stop-animation-on-suspend.html sometimes fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49182

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-20
Reviewed by Antti Koivisto.

stop-animation-on-suspend incorrectly assumed that animation in a subframe would start
roughly at document load. Keep both animations (one in main frame, one in iframe) paused
until the iframe is loaded: this way they should run synchronised enough.

Also increase the tolerance of the test slightly: measuring timing like this is inherently flaky.

Remove failure expectation from all TestExpectations and remove the clearly wrong expected
result for chromium-mac.

* animations/resources/stop-animation-on-suspend-subframe.html:
* animations/stop-animation-on-suspend.html:
* platform/chromium/TestExpectations:
* platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-arm/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoupdate TestExpectations before a skia change
reed@google.com [Tue, 20 Nov 2012 20:33:36 +0000 (20:33 +0000)]
update TestExpectations before a skia change
https://bugs.webkit.org/show_bug.cgi?id=102829

Reviewed by NOBODY. expectations change only.

optimization for rectangular blurs (with holes) changes some images in the low bit. mark for rebaselining.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStore MutationObserver callback in a hidden property for V8
commit-queue@webkit.org [Tue, 20 Nov 2012 19:59:14 +0000 (19:59 +0000)]
Store MutationObserver callback in a hidden property for V8
https://bugs.webkit.org/show_bug.cgi?id=102555

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Adam Barth.

.:

Test for reference cycle leaks with mutation observers. There doesn't seem
to be a way to check this for v8, but if you manually run you can see if it
leaks observers.

* ManualTests/leak-cycle-observer-wrapper.html: Added.

Source/WebCore:

To prevent circular reference leaks we should store the MutationObserver
callback in a hidden property on the wrapper of the observer.

This is done by extending the code generator to support a new owner
argument to ::create() that lets you set the owner of the callback where
the hidden property should be stored.

Test: ManualTests/leak-cycle-observer-wrapper.html

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
* bindings/scripts/test/V8/V8TestCallback.cpp: rebaselined.
* bindings/scripts/test/V8/V8TestCallback.h: rebaselined.
* bindings/v8/V8HiddenPropertyName.h:
* bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGenerate a list of builders/test suites from the buildbot json
ojan@chromium.org [Tue, 20 Nov 2012 19:58:45 +0000 (19:58 +0000)]
Generate a list of builders/test suites from the buildbot json
https://bugs.webkit.org/show_bug.cgi?id=102443

Reviewed by Dirk Pranke.

Instead of the cludgy things we do now to track which bots run which tests,
we generate all that data from the buildbots' json files.
This is the minimal amount to keep everything working. Once this lands,
we can also do a bunch of followup cleanup.

For now we commit the generated data. In theory, in the future, we could
have the test results server generate the data on the fly.

For the sake of easily understanding what changes when we run the generate script,
also checkin a pretty printed version of the output. The pretty printed version
is too large to serve as part of the flakiness dashboard though.

This also has the benefit of making the dashboard load much faster since
we no longer ever need to block on requests to buildbot.

* TestResultServer/generate_builders_json.py: Added.
(master_json_url):
(builder_json_url):
(cached_build_json_url):
(fetch_json):
(insert_builder_and_test_data):
(main):
* TestResultServer/generate_builders_json_unittest.py: Added.
(GenerateBuildersJsonTest):
(GenerateBuildersJsonTest.test_master_json_url):
(GenerateBuildersJsonTest.test_builder_json_url):
(GenerateBuildersJsonTest.test_cached_build_json_url):
(GenerateBuildersJsonTest.test_generate_json_data):
(GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
* TestResultServer/static-dashboards/builders-pretty.jsonp: Added.
* TestResultServer/static-dashboards/builders.js:
(LOAD_BUILDBOT_DATA):
(BuilderGroup):
(BuilderGroup.prototype.append):
(BuilderGroup.prototype.master):
(requestBuilderList):
* TestResultServer/static-dashboards/builders.jsonp: Added.
* TestResultServer/static-dashboards/builders_unittests.js: Added.
* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(showPopupForBuild):
(htmlForTestResults):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):
(loadExpectationsLayoutTests):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(resetGlobals):
(test):
* TestResultServer/static-dashboards/loader.js:
* TestResultServer/static-dashboards/loader_unittests.js:
* TestResultServer/static-dashboards/run-embedded-unittests.html:
* TestResultServer/static-dashboards/run-unittests.html:
* TestResultServer/static-dashboards/timeline_explorer.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in FrameLoader::stopLoading.
inferno@chromium.org [Tue, 20 Nov 2012 19:46:29 +0000 (19:46 +0000)]
Crash in FrameLoader::stopLoading.
https://bugs.webkit.org/show_bug.cgi?id=99504

Reviewed by Nate Chapin.

Source/WebCore:

Frame can be blown away in unload event handler. Need
to protect it with a RefPtr.

Test: fast/frames/frame-unload-crash2.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):

LayoutTests:

* fast/frames/frame-unload-crash2-expected.txt: Added.
* fast/frames/frame-unload-crash2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WTR][Qt] Enable fixedLayout when needed by the test
commit-queue@webkit.org [Tue, 20 Nov 2012 19:29:54 +0000 (19:29 +0000)]
[WTR][Qt] Enable fixedLayout when needed by the test
https://bugs.webkit.org/show_bug.cgi?id=102811

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-20
Reviewed by Kenneth Rohde Christiansen.

Create a flickable view for CSS Device Adaptation tests. This is
crucial for testing them since they will change the size of the
viewport.

* WebKitTestRunner/PlatformWebView.h:
(PlatformWebView):
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
(WTR):
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unnecessary FilterOperations header from RenderBoxModelObject
krit@webkit.org [Tue, 20 Nov 2012 19:12:26 +0000 (19:12 +0000)]
Remove unnecessary FilterOperations header from RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=102821

Reviewed by Ojan Vafai.

No new tests, simple refactoring.

* rendering/RenderBoxModelObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] fix FPS counter disappearing when changing page
commit-queue@webkit.org [Tue, 20 Nov 2012 18:54:37 +0000 (18:54 +0000)]
[Chromium] fix FPS counter disappearing when changing page
https://bugs.webkit.org/show_bug.cgi?id=102532

Patch by Eberhard Graether <egraether@google.com> on 2012-11-20
Reviewed by Pavel Feldman.

When changing the page with opened WebInspector and active FPS counter the WebInspector is
reloaded before the WebView switches to accelerated compositing, so the showFPSCounter call
to WebLayerTreeView is not yet possible. This fix saves the showFPSCounter value in the
WebSettings so it can be read when accelerated compositing is activated.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setShowFPSCounter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoXSSAuditor::decodedSnippetForJavaScript stopping when comma encountered.
tsepez@chromium.org [Tue, 20 Nov 2012 18:49:07 +0000 (18:49 +0000)]
XSSAuditor::decodedSnippetForJavaScript stopping when comma encountered.
https://bugs.webkit.org/show_bug.cgi?id=102587

Reviewed by Adam Barth.

Source/WebCore:

Rather than returning an empty fragment, continue processing the body
of a script tag when the decoded fragment reduces to nothing.

Test: http/tests/security/xssAuditor/script-tag-with-actual-comma.html

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::decodedSnippetForJavaScript):

LayoutTests:

* http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-actual-comma.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CSS Exclusions] writing-mode:vertical-rl shape-inside tests are incorrectly configured
commit-queue@webkit.org [Tue, 20 Nov 2012 18:40:36 +0000 (18:40 +0000)]
[CSS Exclusions] writing-mode:vertical-rl shape-inside tests are incorrectly configured
https://bugs.webkit.org/show_bug.cgi?id=102729

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-20
Reviewed by Dirk Schulze.

Corrected the dimensions of the border elements in two exclusions tests.  They
define a rectangle that's five pixels larger than the tests' rectangular
shape-inside exclusions shapes.  They now enclose the shape-inside element's
text contents.

* fast/exclusions/shape-inside/shape-inside-polygon-rectangle-expected.html:
* fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html:
* fast/exclusions/shape-inside/shape-inside-vertical-text-expected.html:
* fast/exclusions/shape-inside/shape-inside-vertical-text.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConsolidate FrameLoader::load() into one function taking a FrameLoadRequest
simonjam@chromium.org [Tue, 20 Nov 2012 18:30:34 +0000 (18:30 +0000)]
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151

Reviewed by Adam Barth.

Source/WebCore:

There's a FIXME that we have too many FrameLoader::load*() functions. This patch consolidates 3 into 1.
There are still a few more load functions that will be consolidated later. Using FrameLoadRequest as
the interface into FrameLoader will also provide a place to pass in the initiator. Finally, this matches
the refactoring done with CachedResourceRequest and CachedResourceLoader.

No new tests. No change in functionality.

* WebCore.exp.in:
* loader/FrameLoadRequest.h:
(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::setLockHistory): These are former arguments to load().
(WebCore::FrameLoadRequest::lockHistory): Ditto.
(FrameLoadRequest):
(WebCore::FrameLoadRequest::setShouldCheckNewWindowPolicy): Ditto.
(WebCore::FrameLoadRequest::shouldCheckNewWindowPolicy): Ditto.
(WebCore::FrameLoadRequest::substituteData): Ditto.
(WebCore::FrameLoadRequest::setSubstituteData): Ditto.
(WebCore::FrameLoadRequest::hasSubstituteData): Ditto.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::load): No change in behavior, just merged it all into one function.
* loader/FrameLoader.h:
(FrameLoader):
* page/DragController.cpp:
(WebCore::DragController::performDrag):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPagePrivate::loadString):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

Source/WebKit/chromium:

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadData):
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::initializeLoader):

Source/WebKit/efl:

* ewk/ewk_frame.cpp:
(_ewk_frame_contents_set_internal):

Source/WebKit/gtk:

* webkit/webkitwebframe.cpp:
(webkit_web_frame_load_uri):
(webkit_web_frame_load_data):
(webkit_web_frame_load_request):

Source/WebKit/mac:

* Plugins/WebPluginController.mm:
* WebView/WebFrame.mm:
(-[WebFrame loadRequest:]):
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebFrame::QWebFrame):
(QWebFrame::load):
(QWebFrame::setHtml):
(QWebFrame::setContent):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setAlternateHtml):
(qt_dump_set_accepts_editing):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::callErrorPageExtension):

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::loadRequest):
(WebFrame::loadData):

Source/WebKit/wince:

* WebView.cpp:
(WebView::load):

Source/WebKit/wx:

* WebFrame.cpp:
(WebKit::WebFrame::SetPageSource):

Source/WebKit2:

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performFrameLoadURLRequest):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove V8DOMWindowShell::getEntered
commit-queue@webkit.org [Tue, 20 Nov 2012 18:26:32 +0000 (18:26 +0000)]
Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney <dcarney@google.com> on 2012-11-20
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context. Instead, only
the DOMWrapperWorld will be kept alive.

No new tests. No change in functionality.

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::current):
* bindings/v8/DOMWrapperWorld.cpp:
(WebCore::isolatedWorldWeakCallback):
(WebCore):
(WebCore::DOMWrapperWorld::makeContextWeak):
(WebCore::DOMWrapperWorld::setIsolatedWorldField):
* bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::collectIsolatedContexts):
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/V8Binding.h:
(WebCore::worldForEnteredContextIfIsolated):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
* bindings/v8/V8PerContextData.h:
* bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] fast/hidpi/video-controls-in-hidpi.html and fast/layers/video-layer.html need...
commit-queue@webkit.org [Tue, 20 Nov 2012 18:24:05 +0000 (18:24 +0000)]
[GTK] fast/hidpi/video-controls-in-hidpi.html and fast/layers/video-layer.html need new baseline
https://bugs.webkit.org/show_bug.cgi?id=102815

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2012-11-20
Reviewed by Philippe Normand.

Added new GTK baseline for those tests.

* platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
New GTK baseline
* platform/gtk/fast/layers/video-layer-expected.txt: New GTK
baseline

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove '#include "ScriptCallStackFactory.h"' include when unnecessary.
mkwst@chromium.org [Tue, 20 Nov 2012 17:58:47 +0000 (17:58 +0000)]
Remove '#include "ScriptCallStackFactory.h"' include when unnecessary.
https://bugs.webkit.org/show_bug.cgi?id=102812

Reviewed by Jochen Eisinger.

"ScriptCallStackFactory.h" is included in a few files where it doesn't
seem to be required. Since I'm in the process of centralizing stack
trace generation anyway, I'll just clean this up as a drive-by.

* bindings/js/JSConsoleCustom.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8WorkerContextCustom.cpp:
* loader/FrameLoader.cpp:
    Removed "ScriptCallStackFactory.h".
* bindings/js/ScheduledAction.cpp:
    This also included (but didn't use) "ScriptCallStack.h". I've
    removed it as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMerge checks for creating renderers into shouldCreateRenderer
commit-queue@webkit.org [Tue, 20 Nov 2012 17:44:31 +0000 (17:44 +0000)]
Merge checks for creating renderers into shouldCreateRenderer
https://bugs.webkit.org/show_bug.cgi?id=102768

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Ojan Vafai.

Merge the checks for if renderers should be created into shouldCreateRenderer
so simplify the code and ensure correctness if doing
NodeRenderingContext(node).shouldCreateRenderer() in other places in webkit.

No new tests, just refactoring.

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Gardening.
rakuco@webkit.org [Tue, 20 Nov 2012 17:25:14 +0000 (17:25 +0000)]
[EFL] Gardening.

Temporarily mark fast/multicol/span/positioned-child-not-removed-crash.html
as crashing while the regression is addressed.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWinCairo build fails to link.
commit-queue@webkit.org [Tue, 20 Nov 2012 17:16:52 +0000 (17:16 +0000)]
WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=102804

Patch by peavo@outlook.com <peavo@outlook.com> on 2012-11-20
Reviewed by Alexey Proskuryakov.

* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WTR] WebKitTestRunner should be able to run tests using fixed layout
commit-queue@webkit.org [Tue, 20 Nov 2012 17:14:24 +0000 (17:14 +0000)]
[WTR] WebKitTestRunner should be able to run tests using fixed layout
https://bugs.webkit.org/show_bug.cgi?id=102517

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-20
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Update EFL private API so we can create a view with fixed layout. We
can keep this as private as I don't see a real life use case for it
outside WTR and the WebInspector.

* UIProcess/API/C/efl/WKView.cpp:
(WKViewCreate):
(WKViewCreateWithFixedLayout):
* UIProcess/API/C/efl/WKView.h:
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
* UIProcess/API/efl/ewk_view_private.h:
* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools:

WTR will now request the creation of a view that has a page using
fixed layout for CSS Device Adaptation tests, but this feature might
be used in the future by any other test that requires a mobile-like type
of viewport (i.e. Viewport META tests should be ported).

The viewport type of the other tests remains unchanged and is restored
when the runner leaves the device-adapt/ folder.

* WebKitTestRunner/PlatformWebView.h:
(PlatformWebView):
* WebKitTestRunner/TestInvocation.cpp:
(WTR):
(WTR::shouldUseFixedLayout):
(WTR::updateLayoutType):
(WTR::TestInvocation::invoke):
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
(WTR):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[ARMv7] Neither linkCall() nor linkPointer() should flush code.
yoli@rim.com [Tue, 20 Nov 2012 16:32:32 +0000 (16:32 +0000)]
[ARMv7] Neither linkCall() nor linkPointer() should flush code.
https://bugs.webkit.org/show_bug.cgi?id=99213

Reviewed by George Staikos.

LinkBuffer doesn't need to flush code during linking. It will
eventually flush the whole executable. Fixing this gives >%5
sunspider boost (on QNX).

Also make replaceWithLoad() and replaceWithAddressComputation() flush
only when necessary.

* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::linkPointer):
(JSC::ARMv7Assembler::relinkCall):
(JSC::ARMv7Assembler::repatchInt32):
(JSC::ARMv7Assembler::repatchPointer):
(JSC::ARMv7Assembler::replaceWithLoad): Flush only after it did write.
(JSC::ARMv7Assembler::replaceWithAddressComputation): Flush only after it did write.
(JSC::ARMv7Assembler::setInt32):
(JSC::ARMv7Assembler::setPointer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: simplify? damaged region computation in the editor
pfeldman@chromium.org [Tue, 20 Nov 2012 16:31:36 +0000 (16:31 +0000)]
Web Inspector: simplify? damaged region computation in the editor
https://bugs.webkit.org/show_bug.cgi?id=102688

Reviewed by Vsevolod Vlasov.

This change simplifies the damaged region computation. Drive-by make _getSelection work properly.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor):
(WebInspector.DefaultTextEditor.prototype._handleCut):
(WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber.compareLineRowOffsetTops):
(WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._getSelection):
(WebInspector.TextEditorMainPanel.prototype._restoreSelection):
(WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
(WebInspector.TextEditorMainPanel.prototype._positionToSelection):
(WebInspector.TextEditorMainPanel.prototype._handleMutations):
(WebInspector.TextEditorMainPanel.prototype._collectDirtyLines):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._guessEditRangeBasedOnSelection):
(WebInspector.TextEditorMainPanel.prototype._assertDOMMatchesTextModel):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDOM):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype.addDecoration):
(WebInspector.TextEditorMainChunk.prototype.get endLine):
(WebInspector.TextEditorMainChunk.prototype.lineRowContainingLine):
(WebInspector.TextEditorMainChunk.prototype.expandedLineRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] PageViewportControllerClient::didChangeViewportAttributes called twice
allan.jensen@digia.com [Tue, 20 Nov 2012 16:20:52 +0000 (16:20 +0000)]
[Qt] PageViewportControllerClient::didChangeViewportAttributes called twice
https://bugs.webkit.org/show_bug.cgi?id=102790

Reviewed by Kenneth Rohde Christiansen.

Change updateMinimumScaleToFit to no longer call PageViewportControllerClient::didChangeViewportAttributes,
but instead return whether it has changed the minimumScaleToFit.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::updateMinimumScaleToFit):
* UIProcess/PageViewportController.h:
(PageViewportController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] No test of double-click to zoom out
allan.jensen@digia.com [Tue, 20 Nov 2012 16:10:18 +0000 (16:10 +0000)]
[Qt] No test of double-click to zoom out
https://bugs.webkit.org/show_bug.cgi?id=102810

Reviewed by Kenneth Rohde Christiansen.

Adds tests of zoom-stack behaviour, the ability to restore previous zoom levels. It tests
that zoom out always goes to lower zoom levels.

* UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Update NEWS and configure.ac for 1.11.2 release
carlosgc@webkit.org [Tue, 20 Nov 2012 16:08:53 +0000 (16:08 +0000)]
Unreviewed. Update NEWS and configure.ac for 1.11.2 release

* configure.ac: Bump tarball version number, not updated in
previous commit by mistake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Large areas highlighted on touch
allan.jensen@digia.com [Tue, 20 Nov 2012 16:02:23 +0000 (16:02 +0000)]
[Qt] Large areas highlighted on touch
https://bugs.webkit.org/show_bug.cgi?id=97216

Reviewed by Simon Hausmann.

Restrict highlighting of scripted event-handlers to inline elements only.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Update NEWS and configure.ac for 1.11.2 release
carlosgc@webkit.org [Tue, 20 Nov 2012 16:02:19 +0000 (16:02 +0000)]
Unreviewed. Update NEWS and configure.ac for 1.11.2 release

.:

* configure.ac: Bump version numbers.

Source/WebKit/gtk:

* NEWS: Added release notes for 1.11.2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening.
yael@webkit.org [Tue, 20 Nov 2012 15:56:49 +0000 (15:56 +0000)]
Unreviewed gardening.
Update results for compositing/geometry/vertical-scroll-composited.html after 133898.
Mark animations/negative-delay.html as flaky.
Remove a few passing tests from TextExpectations.

* platform/efl/TestExpectations:
* platform/efl/compositing/geometry/vertical-scroll-composited-expected.png: Added.
* platform/efl/compositing/geometry/vertical-scroll-composited-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove historical enums from ExceptionCode.h
arv@chromium.org [Tue, 20 Nov 2012 15:35:38 +0000 (15:35 +0000)]
Remove historical enums from ExceptionCode.h
https://bugs.webkit.org/show_bug.cgi?id=102095

Reviewed by Ojan Vafai.

Remove unused enums from ExceptionCode.

No new tests. No tests affected.

* Modules/intents/NavigatorIntents.cpp:
(WebCore::NavigatorIntents::webkitStartActivity): The error type for this is unspecified.
* dom/DOMCoreException.cpp:
* dom/ExceptionCode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Expectations update
schenney@chromium.org [Tue, 20 Nov 2012 15:34:28 +0000 (15:34 +0000)]
[Chromium] Expectations update

Unreviewed test expectations update.

Some results for calendar and month picker may not be up-to-date for the slow bots.

* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-win-xp/fast/block/float/overhanging-tall-block-expected.png: Removed.
* platform/chromium-win/fast/block/float/overhanging-tall-block-expected.png:
* platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(r128174): Fast build path doesn't work now
ossy@webkit.org [Tue, 20 Nov 2012 14:11:58 +0000 (14:11 +0000)]
[Qt] REGRESSION(r128174): Fast build path doesn't work now
https://bugs.webkit.org/show_bug.cgi?id=100360

Reviewed by Tor Arne Vestbø.

Use a separated .builtRevisions.cache file instead of .qmake.cache to cache built SVN revisions.

* Scripts/webkitdirs.pm:
(buildQMakeProjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeek picker width is too small
keishi@webkit.org [Tue, 20 Nov 2012 14:02:06 +0000 (14:02 +0000)]
Week picker width is too small
https://bugs.webkit.org/show_bug.cgi?id=102766

Reviewed by Kent Tamura.

Source/WebCore:

The width of week picker was too small because we were forgetting about
the week number column when calculating the desired width.

No new tests. Covered by week-picker-appearance*.html.

* Resources/pagepopups/calendarPicker.css:
(.week-mode .week-column): Needs to be table-cell.
* Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize):

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] no volume slider in HTML5 media element controls
philn@webkit.org [Tue, 20 Nov 2012 13:40:50 +0000 (13:40 +0000)]
[GTK] no volume slider in HTML5 media element controls
https://bugs.webkit.org/show_bug.cgi?id=97192

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2012-11-20
Reviewed by Philippe Normand.

r115829 was causing this regression so it was partially
reverted. The revert causes some small regressions, in the tests
but it is better to have the volume slider shown.

Source/WebCore:

* css/mediaControlsGtk.css:
(audio::-webkit-media-controls-panel)
(video::-webkit-media-controls-panel): Partially reverted
r115829.

LayoutTests:

* platform/gtk-wk2/TestExpectations: Updated because it causes
some new regressions
* platform/gtk/TestExpectations: Updated because it causes some
new regressions
* platform/gtk/media/audio-controls-rendering-expected.txt: Updated
* platform/gtk/media/controls-after-reload-expected.txt: Updated
* platform/gtk/media/controls-strict-expected.txt: Updated
* platform/gtk/media/controls-styling-expected.txt: Updated
* platform/gtk/media/controls-styling-strict-expected.txt: Updated
* platform/gtk/media/controls-without-preload-expected.txt: Updated
* platform/gtk/media/media-controls-clone-expected.txt: Updated
* platform/gtk/media/video-controls-rendering-expected.txt: Updated
* platform/gtk/media/video-display-toggle-expected.txt: Updated
* platform/gtk/media/video-empty-source-expected.txt: Updated
* platform/gtk/media/video-no-audio-expected.txt: Updated
* platform/gtk/media/video-volume-slider-expected.txt: Updated
* platform/gtk/media/video-zoom-controls-expected.txt: Updated

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Zoom logic confused by page and pinch resize
allan.jensen@digia.com [Tue, 20 Nov 2012 13:17:48 +0000 (13:17 +0000)]
[Qt] Zoom logic confused by page and pinch resize
https://bugs.webkit.org/show_bug.cgi?id=102803

Reviewed by Kenneth Rohde Christiansen.

Clear the zoom-out stack after page resize, and ensure the zoom logic can still detect
zoom-out and zoom-back when the zoom-out stack is empty.

* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::clearRelativeZoomState):
(WebKit::PageViewportControllerClientQt::setContentsScale):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::didChangeViewportAttributes):
* UIProcess/qt/PageViewportControllerClientQt.h:
(PageViewportControllerClientQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCollect user style sheets in DocumentStyleSheetCollection
antti@apple.com [Tue, 20 Nov 2012 11:36:58 +0000 (11:36 +0000)]
Collect user style sheets in DocumentStyleSheetCollection
https://bugs.webkit.org/show_bug.cgi?id=102683

Reviewed by Andreas Kling.

Move the user stylesheet collection logic from StyleResolver to DocumentStyleSheetCollection.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectRulesFromUserStyleSheets):
(WebCore::collectCSSOMWrappers):
* css/StyleResolver.h:
(StyleResolver):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::pageUserStyleSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserStyleSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserStyleSheet):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::collectActiveStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateStyleResolver):

    Factor the StyleResolver updating code to function.

(WebCore):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

    Collect the user style sheets. Some renaming and other minor refactoring.

(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
* dom/DocumentStyleSheetCollection.h:
(WebCore::DocumentStyleSheetCollection::activeUserStyleSheets):

    Add activeUserStyleSheets vector that contains all user stylesheets from different sources,
    similar to activeAuthorStyleSheets.

(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::documentUserStyleSheets):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unneeded optimization in Element::isInTopLayer
commit-queue@webkit.org [Tue, 20 Nov 2012 11:24:15 +0000 (11:24 +0000)]
Remove unneeded optimization in Element::isInTopLayer
https://bugs.webkit.org/show_bug.cgi?id=102772

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Andreas Kling.

There's no reason to worry about calling elementRareData() multiple
times in this non performance sensitive code path as it's only used
in HTMLDialogElement's showModal and close methods.

No new tests, just simplification.

* dom/Element.cpp:
(WebCore::Element::setIsInTopLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSimplify Element::isSpellCheckingEnabled
commit-queue@webkit.org [Tue, 20 Nov 2012 11:18:30 +0000 (11:18 +0000)]
Simplify Element::isSpellCheckingEnabled
https://bugs.webkit.org/show_bug.cgi?id=102779

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Andreas Kling.

isSpellCheckingEnabled contains logic that duplicates parentOrHostElement
and can be simplified by just calling that.

No new tests, just simplification.

* dom/Element.cpp:
(WebCore::Element::isSpellCheckingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoApply DeviceController as parent class of DeviceMotionController.
kihong.kwon@samsung.com [Tue, 20 Nov 2012 11:09:25 +0000 (11:09 +0000)]
Apply DeviceController as parent class of DeviceMotionController.
https://bugs.webkit.org/show_bug.cgi?id=102578

Reviewed by Hajime Morita.

DeviceController needs to be applied as parent class of DeviceMotionController
because DeviceController which is extracted as parent class of
DeviceMotionController and DeviceOrientationController is already added.
Therefore duplicated implementation can be removed.

Covered by existing tests.

* dom/DeviceMotionClient.h:
* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::DeviceMotionController):
(WebCore::DeviceMotionController::didChangeDeviceMotion):
(WebCore::DeviceMotionController::deviceMotionClient):
(WebCore::DeviceMotionController::hasLastData):
(WebCore::DeviceMotionController::getLastEvent):
(WebCore::DeviceMotionController::from):
(WebCore):
* dom/DeviceMotionController.h:
(WebCore):
(WebCore::DeviceMotionController::~DeviceMotionController):
(DeviceMotionController):
* dom/Document.cpp:
Remove all implementations which are related DeviceOrientationEvnet and DeviceMotionEvent.
Because DeviceController checks suspend and stop status of active dom object before dispatchEvent.
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
* loader/EmptyClients.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL][GTK]Sharing accessibility support in WebKitTestRunner.
commit-queue@webkit.org [Tue, 20 Nov 2012 10:24:31 +0000 (10:24 +0000)]
[EFL][GTK]Sharing accessibility support in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=99011

Patch by Mateusz Leszko <m.leszko@samsung.com> on 2012-11-20
Reviewed by Martin Robinson.

Accessibility files from gtk folder are moved to atk folder due to common implementation. Event Type naming changed to default, from Gtk to ATK.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp.
(WTR::AccessibilityController::logAccessibilityEvents):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] Remove V8ParameterBase
haraken@chromium.org [Tue, 20 Nov 2012 09:56:03 +0000 (09:56 +0000)]
[V8] Remove V8ParameterBase
https://bugs.webkit.org/show_bug.cgi?id=102774

Reviewed by Adam Barth.

V8ParameterBase is a redundant indirection.
We can flatten methods of V8ParameterBase to V8Parameter.

No tests. No change in behavior.

* bindings/v8/V8StringResource.h:
(WebCore::V8Parameter::V8Parameter):
(V8Parameter):
(WebCore::V8Parameter::toString):
(WebCore::::prepare):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Mark inspector/profiler/cpu-profiler-profiling-without-inspector.html
yurys@chromium.org [Tue, 20 Nov 2012 09:21:13 +0000 (09:21 +0000)]
Unreviewed. Mark inspector/profiler/cpu-profiler-profiling-without-inspector.html
as crashing.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkitpy unit tests should run serially when checking code coverage
zandobersek@gmail.com [Tue, 20 Nov 2012 08:20:02 +0000 (08:20 +0000)]
webkitpy unit tests should run serially when checking code coverage
https://bugs.webkit.org/show_bug.cgi?id=102693

Reviewed by Dirk Pranke.

When checking code coverage, the unit tests should not be run in parallel
as this causes the tracing functions (set via sys.settrace in the coverage
module) being overriden, resulting in incorrect coverage reports.

* Scripts/webkitpy/test/main.py:
(Tester._run_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse localized date-time format in datetime input
commit-queue@webkit.org [Tue, 20 Nov 2012 08:16:35 +0000 (08:16 +0000)]
Use localized date-time format in datetime input
https://bugs.webkit.org/show_bug.cgi?id=102769

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-20
Reviewed by Kent Tamura.

Source/WebCore:

Move the implementation of Locale::dateTimeFormatWithSeconds and Locale::dateTimeFormatWithoutSeconds
to its subclasses and use platform-specific methods to get date-time pattern.
Because Windows does not provide an API to get date-time pattern. We use fixed "{date} {time}"
pattern for Windows.

Test: fast/forms/datetime/datetime-appearance-l10n.html

* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeDateTimeFormat): Retrieve datetime formats too.
(WebCore::LocaleICU::dateTimeFormatWithSeconds): Added.
(WebCore):
(WebCore::LocaleICU::dateTimeFormatWithoutSeconds): Added.
* platform/text/LocaleICU.h:
(LocaleICU): Add m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.
* platform/text/LocaleNone.cpp:
(LocaleNone):
(WebCore::LocaleNone::dateTimeFormatWithSeconds): Added. Always returns "dd/MM/yyyyy HH:mm:ss".
(WebCore):
(WebCore::LocaleNone::dateTimeFormatWithoutSeconds): Added. Always returns "dd/MM/yyyyy HH:mm".
* platform/text/PlatformLocale.cpp:
(WebCore): Remove dateTimeFormatWithSeconds() and dateTimeFormatWithoutSeconds() as these are now pure virtual.
* platform/text/PlatformLocale.h:
(Locale): Make dateTimeFormatWithSeconds() and dateTimeFormatWithoutSeconds() pure virtual.
* platform/text/mac/LocaleMac.h:
(LocaleMac): Add m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.
* platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::dateTimeFormatterWithSeconds): Added.
(WebCore):
(WebCore::LocaleMac::dateTimeFormatterWithoutSeconds): Added.
(WebCore::LocaleMac::dateTimeFormatWithSeconds): Added.
(WebCore::LocaleMac::dateTimeFormatWithoutSeconds): Added.
* platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::dateTimeFormatWithSeconds): Copied from original Locale::dateTimeFormatWithSeconds().
(WebCore):
(WebCore::LocaleWin::dateTimeFormatWithoutSeconds): Copied from original Locale::dateTimeFormatWithoutSeconds().
* platform/text/win/LocaleWin.h:
(LocaleWin): Add m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.

LayoutTests:

* fast/forms/datetime/datetime-appearance-l10n-expected.txt: Added.
* fast/forms/datetime/datetime-appearance-l10n.html: Added. We can confirm vi-vn have time-date ordering.
* platform/chromium-mac/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r135257.
yurys@chromium.org [Tue, 20 Nov 2012 08:09:10 +0000 (08:09 +0000)]
Unreviewed, rolling out r135257.
http://trac.webkit.org/changeset/135257
https://bugs.webkit.org/show_bug.cgi?id=102777

Broke Chromium Debug compilation (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::getNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Revert r133149: breaks revision reverting
vsevik@chromium.org [Tue, 20 Nov 2012 08:06:28 +0000 (08:06 +0000)]
Web Inspector: Revert r133149: breaks revision reverting
https://bugs.webkit.org/show_bug.cgi?id=102672

Reviewed by Yury Semikhatsky.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
(WebInspector.JavaScriptSourceFrame.prototype._onWorkingCopyCommitted):
(WebInspector.JavaScriptSourceFrame.prototype._innerSetContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][Win] Unreviewed speculative buildfix after r135217.
ossy@webkit.org [Tue, 20 Nov 2012 07:56:03 +0000 (07:56 +0000)]
[Qt][Win] Unreviewed speculative buildfix after r135217.

* platform/win/WindowsExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fix Chromium Win compilation after r135255.
yurys@chromium.org [Tue, 20 Nov 2012 07:49:40 +0000 (07:49 +0000)]
Unreviewed. Fix Chromium Win compilation after r135255.
https://bugs.webkit.org/show_bug.cgi?id=97803

* WebCore.gypi: removed reference to platform/wince/DragDataWince.cpp which
was deleted in the aforementioned change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] Merge getCachedWrapper(Node*) into DOMDataStore
haraken@chromium.org [Tue, 20 Nov 2012 07:39:56 +0000 (07:39 +0000)]
[V8] Merge getCachedWrapper(Node*) into DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=102158

 Reviewed by Adam Barth.

A follow-up patch for r135230. This patch adds a correct ASSERTION.

No tests. No change in behavior.

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::getNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[JSC] Replace $implClassName with $interfaceName in CodeGeneratorJS.pm
haraken@chromium.org [Tue, 20 Nov 2012 07:38:47 +0000 (07:38 +0000)]
[JSC] Replace $implClassName with $interfaceName in CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=102757

Reviewed by Adam Barth.

In CodeGeneratorJS.pm $implClassName and $interfaceName are
equivalent. We're using them interchangeably. We should replace
$implClassName with $interfaceName.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(AddClassForwardIfNeeded):
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateOverloadedFunction):
(GenerateImplementation):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(NativeToJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPort DragDataWin.cpp to WinCE
paroga@webkit.org [Tue, 20 Nov 2012 07:13:25 +0000 (07:13 +0000)]
Port DragDataWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=97803

Reviewed by Brent Fulgham.

Add two simple #if OS(WINCE) to DragDataWin.cpp, so it can be used by the WinCE port too.

* PlatformWinCE.cmake:
* platform/win/DragDataWin.cpp:
(WebCore::DragData::containsFiles):
(WebCore::DragData::numberOfFiles):
(WebCore::DragData::asFilenames):
* platform/wince/DragDataWinCE.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Web Inspector] This patch makes script line number search-able in Timeline panel.
commit-queue@webkit.org [Tue, 20 Nov 2012 06:51:54 +0000 (06:51 +0000)]
[Web Inspector] This patch makes script line number search-able in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=101910.

Patch by Pan Deng <pan.deng@intel.com> on 2012-11-19
Reviewed by Pavel Feldman.

Script line number is visible in Timeline panel, however, not search-able. This patch makes it search-able.

No new tests.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineRecordListRow.prototype.update):
(WebInspector.TimelineRecordListRow.testContentMatching):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._refreshDetails):
(WebInspector.TimelinePresentationModel.Record.prototype.detailsNode):
(WebInspector.TimelinePresentationModel.Record.prototype._createSpanWithText):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fix Chromium Win compilation after r135196.
yurys@chromium.org [Tue, 20 Nov 2012 06:33:06 +0000 (06:33 +0000)]
Unreviewed. Fix Chromium Win compilation after r135196.
https://bugs.webkit.org/show_bug.cgi?id=102021

* tests/DeferredImageDecoderTest.cpp: changed char to unsigned char in the array
declaration to avoid 'warning C4309' on MSVS when initializing from hex literals.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unneeded null check in NodeRendererFactory::createRendererIfNeeded
commit-queue@webkit.org [Tue, 20 Nov 2012 06:28:56 +0000 (06:28 +0000)]
Remove unneeded null check in NodeRendererFactory::createRendererIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=102765

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-19
Reviewed by Ojan Vafai.

If parentRenderer() was null then we return early from
createRendererIfNeeded() because shouldCreateRenderer() will return false
so there's no reason to check for it again.

Additionally if either parentRenderer() or style() is null then
implementations of rendererIsNeeded() will crash, so add asserts to
make this assumption more clear.

No new tests, just simplification.

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRendererFactory::createRendererIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Refactoring] Remove WebCore::isInsertionPoint(Node*)
shinyak@chromium.org [Tue, 20 Nov 2012 06:09:25 +0000 (06:09 +0000)]
[Refactoring] Remove WebCore::isInsertionPoint(Node*)
https://bugs.webkit.org/show_bug.cgi?id=102756

Reviewed by Hajime Morita.

Now that WebCore::isInsertionPoint(Node* node) does nothing special. We can remove this.

No new tests, simple refactoring.

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):
* dom/ContainerNode.cpp:
(WebCore::childAttachedAllowedWhenAttachingChildren):
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::invalidate):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::isActive):
* html/shadow/InsertionPoint.h:
(WebCore::toInsertionPoint):
(WebCore::isActiveInsertionPoint):
(WebCore::isLowerEncapsulationBoundary):
(WebCore::parentNodeForDistribution):
* testing/Internals.cpp:
(WebCore::Internals::isValidContentSelect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Refactoring] Remove shadowPseudoId() and use setPseudo() in <progress> ElementShadow.
shinyak@chromium.org [Tue, 20 Nov 2012 05:49:45 +0000 (05:49 +0000)]
[Refactoring] Remove shadowPseudoId() and use setPseudo() in <progress> ElementShadow.
https://bugs.webkit.org/show_bug.cgi?id=101703

Reviewed by Hajime Morita.

Source/WebCore:

We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from HTMLKeygenElement and use
setPseudo()/pseudo() instead.

No new tests, simple refactoring.

* html/shadow/ProgressShadowElement.cpp:
(WebCore::ProgressInnerElement::ProgressInnerElement):
* html/shadow/ProgressShadowElement.h:
(ProgressInnerElement):
(WebCore::ProgressBarElement::ProgressBarElement):
(ProgressBarElement):
(WebCore::ProgressValueElement::ProgressValueElement):

LayoutTests:

* editing/style/apply-style-atomic-expected.txt:
* fast/dom/HTMLProgressElement/progress-element-markup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WK2] Unused parameters on CoordinatedGraphicsLayer.cpp
commit-queue@webkit.org [Tue, 20 Nov 2012 05:38:00 +0000 (05:38 +0000)]
[WK2] Unused parameters on CoordinatedGraphicsLayer.cpp
https://bugs.webkit.org/show_bug.cgi?id=102760

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-19
Reviewed by Laszlo Gombos.

Because the 'platformLayer' parameter is not used when !USE(GRAPHICS_SURFACE),
use UNUSED_PARAM macro to fix build warning -Wunused-parameter

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setContentsToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove support for ARMv7 errata from the jump code
fpizlo@apple.com [Tue, 20 Nov 2012 05:37:49 +0000 (05:37 +0000)]
Remove support for ARMv7 errata from the jump code
https://bugs.webkit.org/show_bug.cgi?id=102759

Reviewed by Oliver Hunt.

The jump replacement code was wrong to begin with since it wasn't doing
a cache flush on the inserted padding. And, to my knowledge, we don't need
this anymore, so this patch removes all errata code from the ARMv7 port.

* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
(JSC::ARMv7Assembler::canBeJumpT3):
(JSC::ARMv7Assembler::canBeJumpT4):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Add fallback for WebkitTestRunner if opengl is not available.
commit-queue@webkit.org [Tue, 20 Nov 2012 05:34:45 +0000 (05:34 +0000)]
[EFL] Add fallback for WebkitTestRunner if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=102704

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-19
Reviewed by Laszlo Gombos.

Add fallback to non-opengl evas engine in WebkitTestRunner if opengl is not available.

* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::initEcoreEvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Reenable webaudio/biquad-getFrequencyResponse.html test as it should...
yurys@chromium.org [Tue, 20 Nov 2012 05:24:25 +0000 (05:24 +0000)]
Unreviewed. Reenable webaudio/biquad-getFrequencyResponse.html test as it should pass after r129418
https://bugs.webkit.org/show_bug.cgi?id=97439

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fix Chromium Debug compilation after r135230.
yurys@chromium.org [Tue, 20 Nov 2012 05:00:59 +0000 (05:00 +0000)]
Unreviewed. Fix Chromium Debug compilation after r135230.
https://bugs.webkit.org/show_bug.cgi?id=102158

Removed ASSERT that used instance field in a static method.

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::getWrapperFromObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Blackberry] When a frame is being detached, cancel all its network jobs.
commit-queue@webkit.org [Tue, 20 Nov 2012 04:55:14 +0000 (04:55 +0000)]
[Blackberry] When a frame is being detached, cancel all its network jobs.
https://bugs.webkit.org/show_bug.cgi?id=102758

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-11-19
Reviewed by George Staikos.

I use FrameDestructionObserver to refactor Networkjob code.
NetworkJob is inheriting from FrameDestructionObserver to be
aware of frame's destroyed. When a frame is being detached,
the willDetachPage() can be called in which we can cancel
the job. This patch reverted the fix for RIM PR134207 as well.

Manually test is on
"http://www.reuters.com/article/2012/01/27/us-greece-idUSTRE80P0DE20120127"
which triggers a ping loader.

No behavior changed, no new layout tests.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::handleNotifyHeaderReceived):
(WebCore::NetworkJob::startNewJobWithRequest):
(WebCore::NetworkJob::frameDestroyed):
(WebCore):
(WebCore::NetworkJob::willDetachPage):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
* platform/network/blackberry/NetworkManager.h:
(NetworkManager):
* platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement the new stacking layer needed by the Fullscreen API and the new <dialog...
commit-queue@webkit.org [Tue, 20 Nov 2012 04:45:02 +0000 (04:45 +0000)]
Implement the new stacking layer needed by the Fullscreen API and the new <dialog> element
https://bugs.webkit.org/show_bug.cgi?id=84796

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-11-19
Reviewed by Julien Chaffraix.

Source/WebCore:

This adds the top layer element stack to Document. The Fullscreen
specification mandates that we track the ordering of the DOM nodes in
the top layer, not the renderers. That makes it hard to implement on
the rendering side only.

Elements in the top layer get a layer. Layers in the top layer are
added to the root layer's child list after normal layers and in the
order of the top layer stack. This way, the top layer appears above
all other stacking contexts and in the desired order.

In addition, top layer renderers are added as children of RenderView
in top layer order. This is to satisfy requirements such as the
containing block of an element in the top layer is the initial
containing block. It also allows RenderLayer to know the proper
stacking order of the layers without going directly from the top layer
elements to their layers.

So far, only modal dialog elements can be added to the top layer.
The plan is to make the Fullscreen API also use the top layer.

Tests: fast/dom/HTMLDialogElement/top-layer-containing-block.html
       fast/dom/HTMLDialogElement/top-layer-display-none.html
       fast/dom/HTMLDialogElement/top-layer-nesting.html
       fast/dom/HTMLDialogElement/top-layer-stacking-dynamic.html
       fast/dom/HTMLDialogElement/top-layer-stacking.html

* WebCore.exp.in:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle): Elements in the top layer have a stacking context.
* dom/Document.cpp:
(WebCore):
(WebCore::Document::addToTopLayer):
(WebCore::Document::removeFromTopLayer):
* dom/Document.h:
(Document):
(WebCore::Document::topLayerElements): Add the top layer element stack to Document.
* dom/Element.cpp:
(WebCore::Element::removedFrom):
(WebCore):
(WebCore::Element::isInTopLayer):
(WebCore::Element::setIsInTopLayer):
* dom/Element.h:
* dom/ElementRareData.h:
(ElementRareData):
* dom/Node.cpp:
(WebCore::Node::detach): Add an exception to the assert since top layer elements and their descendants are moved from their
regular position in the render tree.
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(NodeRareData):
(WebCore::NodeRareData::isInTopLayer):
(WebCore::NodeRareData::setIsInTopLayer):
* dom/NodeRenderingContext.cpp:
(WebCore):
(WebCore::adjustInsertionPointForTopLayerElement):
(WebCore::NodeRendererFactory::createRendererIfNeeded): Add renderers for top layer elements as children of RenderView, and
in top layer stacking order.
* html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::showModal):
* rendering/RenderLayer.cpp:
(WebCore):
(WebCore::RenderLayer::isInTopLayer):
(WebCore::RenderLayer::isInTopLayerSubtree):
(WebCore::RenderLayer::rebuildZOrderLists): Add the top layer stack after normal layer collection.
(WebCore::RenderLayer::collectLayers): Avoid adding layers for top layer elements during normal layer collection.
* rendering/RenderLayer.h:
(RenderLayer):

LayoutTests:

Add tests for top layer stacking and rendering.

* fast/dom/HTMLDialogElement/top-layer-containing-block-expected.html: Added.
* fast/dom/HTMLDialogElement/top-layer-containing-block.html: Added.
* fast/dom/HTMLDialogElement/top-layer-display-none-expected.html: Added.
* fast/dom/HTMLDialogElement/top-layer-display-none.html: Added.
* fast/dom/HTMLDialogElement/top-layer-nesting-expected.html: Added.
* fast/dom/HTMLDialogElement/top-layer-nesting.html: Added.
* fast/dom/HTMLDialogElement/top-layer-stacking-dynamic-expected.html: Added.
* fast/dom/HTMLDialogElement/top-layer-stacking-dynamic.html: Added.
* fast/dom/HTMLDialogElement/top-layer-stacking-expected.html: Added.
* fast/dom/HTMLDialogElement/top-layer-stacking.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fix lint errors on chromium TextExpectations after r135205.
yurys@chromium.org [Tue, 20 Nov 2012 04:37:16 +0000 (04:37 +0000)]
Unreviewed. Fix lint errors on chromium TextExpectations after r135205.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIn CodeGeneratorObj.pm we should rename $dataNode to $interface.
haraken@chromium.org [Tue, 20 Nov 2012 04:29:41 +0000 (04:29 +0000)]
In CodeGeneratorObj.pm we should rename $dataNode to $interface.
https://bugs.webkit.org/show_bug.cgi?id=102749

Reviewed by Adam Barth.

$dataNode is misnamed. It should be renamed to $interface.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateInterface):
(GetParentImplClassName):
(GetParentAndProtocols):
(GenerateHeader):
(GenerateImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIn CodeGeneratorV8.pm, we should rename $dataNode to $interface
haraken@chromium.org [Tue, 20 Nov 2012 04:26:08 +0000 (04:26 +0000)]
In CodeGeneratorV8.pm, we should rename $dataNode to $interface
https://bugs.webkit.org/show_bug.cgi?id=102747

Reviewed by Adam Barth.

$dataNode is misnamed. It should be $interface.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateInterface):
(NeedsCustomOpaqueRootForGC):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateOpaqueRootForGC):
(GenerateHeader):
(GetInternalFields):
(GenerateHeaderCustomInternalFieldIndices):
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateHeaderCustomCall):
(IsConstructable):
(GenerateConstructorGetter):
(GenerateNormalAttrGetter):
(GenerateReplaceableAttrSetter):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateArgumentsCountCheck):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateTypedArrayConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateBatchedAttributeData):
(IsStandardFunction):
(GenerateNonStandardFunction):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):
(GenerateImplementationCustomCall):
(GenerateImplementationMasqueradesAsUndefined):
(GenerateImplementation):
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
(BaseInterfaceName):
(GenerateToV8Converters):
(GetNativeTypeForConversions):
(GetTypeNameOfExternalTypedArray):
(WriteData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135239 268f45cc-cd09-0410-ab3c-d52691b4dbfc