WebKit-https.git
10 years ago[Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
vestbo@webkit.org [Mon, 14 Nov 2011 13:19:12 +0000 (13:19 +0000)]
[Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Disable plugins on X11 for WK2
hausmann@webkit.org [Mon, 14 Nov 2011 13:06:13 +0000 (13:06 +0000)]
[Qt] Disable plugins on X11 for WK2

Reviewed by Kenneth Rohde Christiansen.

Currently plugins are in-process and they crash in the likely case of
a plugin installation that uses Qt 4, which beautifully clashes with the
Qt 5 based QtWebProcess.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Replace use of QApplication with QGuiApplication.
hausmann@webkit.org [Mon, 14 Nov 2011 13:01:03 +0000 (13:01 +0000)]
[Qt] Replace use of QApplication with QGuiApplication.

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

* wtf/qt/compat/qguiapplication.h:
(QGuiApplication::styleHints): Introduce styleHints wrapper hack.

Source/WebCore:

Replace use of QApplication by QGuiApplication where applicable.

* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformFocusRingColor):
(WebCore::RenderThemeQt::systemColor):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::caretBlinkInterval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add support for config tests for Qt 5
vestbo@webkit.org [Mon, 14 Nov 2011 12:58:46 +0000 (12:58 +0000)]
[Qt] Add support for config tests for Qt 5

This allows us to build and run configure-tests at build
time to determine if a given platform feature is available.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove reference to QWebNavigationController
caio.oliveira@openbossa.org [Mon, 14 Nov 2011 12:46:56 +0000 (12:46 +0000)]
[Qt] Remove reference to QWebNavigationController
https://bugs.webkit.org/show_bug.cgi?id=72257

Reviewed by Simon Hausmann.

QWebNavigationController was removed in r99946, this is just a leftover.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
* UIProcess/API/qt/qquickwebview_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTests occasionally report missing expectations
tonyg@chromium.org [Mon, 14 Nov 2011 12:44:43 +0000 (12:44 +0000)]
Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

* platform/chromium/test_expectations.txt: Expect form-associated-element-crash3 to flakily go MISSING.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest
commit-queue@webkit.org [Mon, 14 Nov 2011 12:41:03 +0000 (12:41 +0000)]
[chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest
https://bugs.webkit.org/show_bug.cgi?id=72026

ASSERT is stripped out in release builds so it shouldn't be used
in unit tests, except when calling debug-only functions like
isMainThread().

Replacing with ASSERT_TRUE (or EXPECT_TRUE in constructors, where
we can't return a value).

Patch by Iain Merrick <husky@google.com> on 2011-11-14
Reviewed by Tony Gentilcore.

* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CMAKE] Add the UseV8.cmake to WebCore.
commit-queue@webkit.org [Mon, 14 Nov 2011 12:20:19 +0000 (12:20 +0000)]
[CMAKE] Add the UseV8.cmake to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=72000

Patch by Jaehoon Jeong <jh4u.jeong@samsung.com> on 2011-11-14
Reviewed by Daniel Bates.

Add the UseV8.cmake to WebCore to build bindings of V8 and
generate JavaScript codes given IDL input.

* UseV8.cmake: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] the QQuickWebView should support double-tap to zoom
kenneth@webkit.org [Mon, 14 Nov 2011 11:55:36 +0000 (11:55 +0000)]
[Qt] the QQuickWebView should support double-tap to zoom
https://bugs.webkit.org/show_bug.cgi?id=72030

Reviewed by Andreas Kling.

* UIProcess/qt/QtViewInterface.cpp:
* UIProcess/qt/QtViewInterface.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::didFindZoomableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttp/tests/inspector/resource-tree/appcache-iframe-manifests.html failing on some...
vsevik@chromium.org [Mon, 14 Nov 2011 11:52:50 +0000 (11:52 +0000)]
http/tests/inspector/resource-tree/appcache-iframe-manifests.html failing on some chromium bots after r99988
https://bugs.webkit.org/show_bug.cgi?id=72177

Reviewed by Tony Gentilcore.

Added waitForFrameManifestURLAndStatus() call for the second frame
with manifestId=1, fixed sort functions in appcache-test.js

* http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
* http/tests/inspector/resource-tree/appcache-test.js:
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_b...
hausmann@webkit.org [Mon, 14 Nov 2011 11:49:47 +0000 (11:49 +0000)]
[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

* Target.pri:
* platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic
now lives within RenderThemeQtMobile.
* platform/qt/QtMobileWebStyle.h: Removed. Ditto.
* platform/qt/RenderThemeQStyle.cpp: Added.
(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
* platform/qt/RenderThemeQStyle.h: Added.
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):
* platform/qt/RenderThemeQt.h:
(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):
* platform/qt/RenderThemeQtMobile.cpp: Added.
(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):
* platform/qt/RenderThemeQtMobile.h: Added.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::swallowContextMenuEvent):
* tests/tests.pri:

Tools:

* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
based on availability of QtWidgets.
* qmake/mkspecs/features/webcore.prf: cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] r99963 causes inspector/debugger/script-formatter.html to fail text diff
apavlov@chromium.org [Mon, 14 Nov 2011 11:49:29 +0000 (11:49 +0000)]
[chromium] r99963 causes inspector/debugger/script-formatter.html to fail text diff
https://bugs.webkit.org/show_bug.cgi?id=72204

The concatenate_script_formatter_worker_js action (along with concatenate_heap_snapshot_worker_js)
did not depend on their 'input_file' files and, hence, did not get invoked on their input_file changes.

Reviewed by Yury Semikhatsky.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Possible crash when destroying after called widgetSizeChanged.
ryuan.choi@samsung.com [Mon, 14 Nov 2011 11:24:26 +0000 (11:24 +0000)]
[GTK] Possible crash when destroying after called widgetSizeChanged.
https://bugs.webkit.org/show_bug.cgi?id=72237

Reviewed by Martin Robinson.

Crash can occur when ChromeclientGtk is removed before calling repaintEverythingSoonTimeout
registered by widgetSizeChanged.
This patch remove the m_repaintSoonSourceId glib source before destruction
of the ChromeClientGtk to prevent the above crash.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::chromeDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit...
tonyg@chromium.org [Mon, 14 Nov 2011 11:15:05 +0000 (11:15 +0000)]
ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

* platform/chromium/test_expectations.txt: Expect cross-frame-access-custom.html to CRASH or PASS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100116.
tonyg@chromium.org [Mon, 14 Nov 2011 10:53:49 +0000 (10:53 +0000)]
Unreviewed, rolling out r100116.
http://trac.webkit.org/changeset/100116

r100104 was rolled out, so no longer needed

* Scripts/run-bindings-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100104.
tonyg@chromium.org [Mon, 14 Nov 2011 10:48:35 +0000 (10:48 +0000)]
Unreviewed, rolling out r100104.
http://trac.webkit.org/changeset/100104
https://bugs.webkit.org/show_bug.cgi?id=72247

broke windows builds

* Scripts/check-webkit-style:
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
* Scripts/webkitpy/common/checkout/deps.py:
* Scripts/webkitpy/common/checkout/scm/__init__.py:
* Scripts/webkitpy/common/checkout/scm/detection.py:
* Scripts/webkitpy/common/checkout/scm/git.py:
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/common/checkout/scm/svn.py:
* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/common/host_mock.py:
* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/tool/servers/rebaselineserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSecurityContext should track whether the SecurityOrigin has been initialized
abarth@webkit.org [Mon, 14 Nov 2011 10:26:49 +0000 (10:26 +0000)]
SecurityContext should track whether the SecurityOrigin has been initialized
https://bugs.webkit.org/show_bug.cgi?id=72250

Reviewed by Eric Seidel.

This patch is another step towards https://bugs.webkit.org/show_bug.cgi?id=71745.

One of the things we use "empty" SecurityOrigins for is detecting
whether a Document's SecurityOrigin has been initialized.  In this
patch, we track that state directly on SecurityContext (which is a base
class of Document), moving us closer to removing the concept of an
empty SecurityOrigin.

* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
* dom/SecurityContext.cpp:
(WebCore::SecurityContext::SecurityContext):
(WebCore::SecurityContext::setSecurityOrigin):
* dom/SecurityContext.h:
(WebCore::SecurityContext::didFailToInitializeSecurityOrigin):
(WebCore::SecurityContext::haveInitializedSecurityOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, build fix after r100104. run-binding-tests broke.
philn@webkit.org [Mon, 14 Nov 2011 10:00:08 +0000 (10:00 +0000)]
Unreviewed, build fix after r100104. run-binding-tests broke.

* Scripts/run-bindings-tests: Explicitely use scm.detection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fix make distcheck build.
carlosgc@webkit.org [Mon, 14 Nov 2011 09:50:06 +0000 (09:50 +0000)]
Unreviewed. Fix make distcheck build.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing files.

Source/WebCore:

* GNUmakefile.list.am: Add missing files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Give HTML ContextMenu a more Native look
commit-queue@webkit.org [Mon, 14 Nov 2011 09:40:37 +0000 (09:40 +0000)]
Web Inspector: Give HTML ContextMenu a more Native look
https://bugs.webkit.org/show_bug.cgi?id=72207

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-14
Reviewed by Pavel Feldman.

* inspector/front-end/SoftContextMenu.js:
(.WebInspector.SoftContextMenu.prototype._createMenuItem):
Give the checkmark a class name so that it can be styled more
with CSS instead of with JavaScript.

* inspector/front-end/inspector.css:
(.soft-context-menu): tweak the border and shadow.
(.soft-context-menu-item): tweak the font size and positioning.
(.soft-context-menu-separator): tweak the whitespace.
(.soft-context-menu-item-mouse-over): solid blue for non-mac platforms.
(body.platform-mac .soft-context-menu-item-mouse-over): gradient for mac platforms.
(.soft-context-menu-item-checkmark): gray color normally.
(.soft-context-menu-item-mouse-over .soft-context-menu-item-checkmark): white on hover.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: function remote objetct should provide access to function position...
yurys@chromium.org [Mon, 14 Nov 2011 09:27:25 +0000 (09:27 +0000)]
Web Inspector: function remote objetct should provide access to function position in the script
https://bugs.webkit.org/show_bug.cgi?id=71808

Source/JavaScriptCore:

Exposed accessor for function source code.

Reviewed by Pavel Feldman.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSFunction.cpp:
(JSC::JSFunction::sourceCode):
* runtime/JSFunction.h:

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::functionLocation):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::functionLocationCallback):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getFunctionLocation):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
* inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

* inspector/debugger/function-location-expected.txt: Added.
* inspector/debugger/function-location.html: Added.
* platform/chromium/inspector/debugger/function-location-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening after r100050
ossy@webkit.org [Mon, 14 Nov 2011 09:25:37 +0000 (09:25 +0000)]
[Qt] Unreviewed gardening after r100050
https://bugs.webkit.org/show_bug.cgi?id=72251

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-11-14

* platform/qt/Skipped: editing/spelling/spelling-unified-emulation.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCannot select multiple options by mouse dragging in <select multiple="multiple" size...
commit-queue@webkit.org [Mon, 14 Nov 2011 09:18:25 +0000 (09:18 +0000)]
Cannot select multiple options by mouse dragging in <select multiple="multiple" size="7"> list
https://bugs.webkit.org/show_bug.cgi?id=70496

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-14
Reviewed by Kent Tamura.

Source/WebCore:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature

Test: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Handled mouse move event with Left button pressed. We select the options under mouse
when mouse drag happens and the select element cannot autoscroll.

LayoutTests:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature.

* fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size-expected.txt: Added.
* fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [chromium] list dedicated workers in case inspector opened post-worker...
yurys@chromium.org [Mon, 14 Nov 2011 09:16:06 +0000 (09:16 +0000)]
Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didStartWorkerContext):
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
* inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

* http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
* http/tests/inspector-enabled/dedicated-workers-list.html: Added.
* http/tests/inspector-enabled/resources/dedicated-worker.js: Added.
(doWork):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild breaks with --no-javascript-debugger --no-inspector
commit-queue@webkit.org [Mon, 14 Nov 2011 09:14:44 +0000 (09:14 +0000)]
Build breaks with --no-javascript-debugger --no-inspector
https://bugs.webkit.org/show_bug.cgi?id=72228

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-11-14
Reviewed by Simon Hausmann.

Source/WebCore:

* workers/WorkerMessagingProxy.cpp:
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerMessagingProxy::connectToInspector):
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):

Source/WebKit2:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove all custom constructors of Events in V8
haraken@chromium.org [Mon, 14 Nov 2011 08:27:48 +0000 (08:27 +0000)]
Remove all custom constructors of Events in V8
https://bugs.webkit.org/show_bug.cgi?id=72074

Reviewed by Adam Barth.

V8 has [ConstructorTemplate=Event] IDL, which generates
Event constructors. This patch removes all the custom constructors
in V8EventConstructors.cpp and generates them using
[ConstructorTemplate=Event] IDL.

Tests: fast/events/constructors/before-load-event-constructor.html
       fast/events/constructors/close-event-constructor.html
       fast/events/constructors/custom-event-constructor.html
       fast/events/constructors/error-event-constructor.html
       fast/events/constructors/event-constructors.html
       fast/events/constructors/hash-change-event-constructor.html
       fast/events/constructors/message-event-constructor.html
       fast/events/constructors/overflow-event-constructor.html
       fast/events/constructors/page-transition-event-constructor.html
       fast/events/constructors/pop-state-event-constructor.html
       fast/events/constructors/progress-event-constructor.html
       fast/events/constructors/track-event-constructor.html
       fast/events/constructors/webkit-animation-event-constructor.html
       fast/events/constructors/webkit-transition-event-constructor.html

* Target.pri: Removed V8EventConstructors.cpp.
* WebCore.gypi: Ditto.
* bindings/v8/custom/V8EventConstructors.cpp: Removed.
* dom/BeforeLoadEvent.idl: Replaced [V8CustomConstructor] with [V8ConstructorTemplate=Event]. Added [InitializedByConstructor] IDL to attributes that can be initialized by the generated constructor.
* dom/CustomEvent.idl: Ditto.
* dom/ErrorEvent.idl: Ditto.
* dom/HashChangeEvent.idl: Ditto.
* dom/MessageEvent.idl: Ditto.
* dom/OverflowEvent.idl: Ditto.
* dom/PageTransitionEvent.idl: Ditto.
* dom/PopStateEvent.idl: Ditto.
* dom/ProgressEvent.idl: Ditto.
* dom/WebKitAnimationEvent.idl: Ditto.
* dom/WebKitTransitionEvent.idl: Ditto.
* html/track/TrackEvent.idl: Ditto.
* websockets/CloseEvent.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK baselines for 2 new svg tests.
philn@webkit.org [Mon, 14 Nov 2011 08:20:35 +0000 (08:20 +0000)]
Unreviewed, GTK baselines for 2 new svg tests.

* platform/gtk/svg/repaint/filter-child-repaint-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WX] Make FontPlatformData::m_size private
paroga@webkit.org [Mon, 14 Nov 2011 08:16:07 +0000 (08:16 +0000)]
[WX] Make FontPlatformData::m_size private
https://bugs.webkit.org/show_bug.cgi?id=72214

Reviewed by Andreas Kling.

Also change the order of member variables to match
the order in the constructor to fix many warnings.

* platform/graphics/wx/FontPlatformData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skip 2 tests failing on GTK and 2 flaky crashers.
philn@webkit.org [Mon, 14 Nov 2011 08:15:26 +0000 (08:15 +0000)]
Unreviewed, skip 2 tests failing on GTK and 2 flaky crashers.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd SCMDetector object to make scm detection mockable
eric@webkit.org [Mon, 14 Nov 2011 08:07:55 +0000 (08:07 +0000)]
Add SCMDetector object to make scm detection mockable
https://bugs.webkit.org/show_bug.cgi?id=72247

Reviewed by Adam Barth.

I think SCM detection may eventually be rolled into Checkout,
but this patch at least makes it possible to mock code-paths
which rely on scm detection.
In the process of replacing callers of these free-functions
I found that one of the functions was no longer used,
and that one of the callers could instead just use the SCM
object it already had access to through port.host.scm().
I also discovered that I was not calling Host._initialize_scm()
and thus host.scm() was always returning None!

* Scripts/check-webkit-style:
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
* Scripts/webkitpy/common/checkout/deps.py:
* Scripts/webkitpy/common/checkout/scm/__init__.py:
* Scripts/webkitpy/common/checkout/scm/detection.py:
* Scripts/webkitpy/common/checkout/scm/git.py:
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/common/checkout/scm/svn.py:
* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/common/host_mock.py:
* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/tool/servers/rebaselineserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening after r100036.
ossy@webkit.org [Mon, 14 Nov 2011 07:57:42 +0000 (07:57 +0000)]
[Qt] Unreviewed gardening after r100036.

* platform/qt/svg/foreignObject/clip-expected.png: Added.
* platform/qt/svg/foreignObject/clip-expected.txt: Added.
* platform/qt/svg/foreignObject/filter-expected.png: Added.
* platform/qt/svg/foreignObject/filter-expected.txt: Added.
* platform/qt/svg/foreignObject/mask-expected.png: Added.
* platform/qt/svg/foreignObject/mask-expected.txt: Added.
* platform/qt/svg/repaint/filter-child-repaint-expected.png: Added.
* platform/qt/svg/repaint/filter-child-repaint-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDocument::initSecurityOrigin should return earlier more often
abarth@webkit.org [Mon, 14 Nov 2011 07:57:10 +0000 (07:57 +0000)]
Document::initSecurityOrigin should return earlier more often
https://bugs.webkit.org/show_bug.cgi?id=72244

Reviewed by Eric Seidel.

This minor tweak was suggested by Darin to make the subsequent patches
easier to read.

* dom/Document.cpp:
(WebCore::Document::initSecurityContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSecurityPolicy should refer to isUnique rather than isEmpty
abarth@webkit.org [Mon, 14 Nov 2011 07:53:27 +0000 (07:53 +0000)]
SecurityPolicy should refer to isUnique rather than isEmpty
https://bugs.webkit.org/show_bug.cgi?id=72242

Reviewed by Eric Seidel.

It doesn't make sense to tweak the security policy for unique origins
because they're different every time.  Previously, this code checked
for empty origins, which are technically a subset of unique origins.  I
don't think it's possible to call this code in a way that can detect
the difference, but we're eventually going to remove the isEmpty
function.

* page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove isSecureTransitionTo from SecurityOrigin to SecurityContext
abarth@webkit.org [Mon, 14 Nov 2011 07:50:55 +0000 (07:50 +0000)]
Move isSecureTransitionTo from SecurityOrigin to SecurityContext
https://bugs.webkit.org/show_bug.cgi?id=72241

Reviewed by Eric Seidel.

This patch is a step towards breaking the patch for
https://bugs.webkit.org/show_bug.cgi?id=71745 up into tiny,
digestible pieces.

* dom/SecurityContext.cpp:
(WebCore::SecurityContext::isSecureTransitionTo):
* dom/SecurityContext.h:
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
* page/SecurityOrigin.cpp:
* page/SecurityOrigin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] LayerRendererChromium::initialize should fail when GaphicsContext3D::makeC...
nduca@chromium.org [Mon, 14 Nov 2011 05:14:41 +0000 (05:14 +0000)]
[chromium] LayerRendererChromium::initialize should fail when GaphicsContext3D::makeCurrent fails
https://bugs.webkit.org/show_bug.cgi?id=72102

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::makeContextCurrent):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Remove WebFileChooserParams::acceptTypes
tkent@chromium.org [Mon, 14 Nov 2011 03:06:43 +0000 (03:06 +0000)]
[Chromium] Remove WebFileChooserParams::acceptTypes
https://bugs.webkit.org/show_bug.cgi?id=71998

Reviewed by Darin Fisher.

* public/WebFileChooserParams.h: Remove acceptTypes.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::runOpenPanel): Remove acceptTypes generatio code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Improve the documentation of ewk_view_setting_local_storage_*.
commit-queue@webkit.org [Mon, 14 Nov 2011 00:02:06 +0000 (00:02 +0000)]
[EFL] Improve the documentation of ewk_view_setting_local_storage_*.
https://bugs.webkit.org/show_bug.cgi?id=72135

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Add some "see also" pointers, mention the default paths used for local
storage and document how things will not be persisted to disk if a
storage path is not set.

* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Simplify eina_stringshare usage in ewk_settings.
commit-queue@webkit.org [Sun, 13 Nov 2011 23:03:43 +0000 (23:03 +0000)]
[EFL] Simplify eina_stringshare usage in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72127

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-13
Reviewed by Kenneth Rohde Christiansen.

Actually use the eina_stringshare functions in a sane way.

* ewk/ewk_settings.cpp:
(ewk_settings_web_database_path_set): Just use
eina_stringshare_replace instead of doing needless checks and using
eina_stringshare_add.
(ewk_settings_cache_directory_path_set): Ditto.
(ewk_settings_icon_database_path_set): Ditto and always call
eina_stringshare_del, as passing NULL to it is just a NOP.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix silent spilling/filling GPRs in DFG 32_64
yuqiang.xian@intel.com [Sun, 13 Nov 2011 22:44:16 +0000 (22:44 +0000)]
Fix silent spilling/filling GPRs in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=72201

Reviewed by Gavin Barraclough.

Current silentSpillGPR/silentFillGPR may not work as expected for some
cases in 32_64. If there's a JSValue which was retained by two GPRs,
we may end up failing to spill/fill some GPRs or redundantly
spilling/filling some GPRs. For example, if we tend to exclude "eax"
from spilling while a JSValue is retained by both "eax" and "edx",
then "edx" won't be spilled as well (wrong). And if another JSValue is
retained by "ecx" and "ebx", both "ecx" and "ebx" will be spilled
twice. The similar problem applies to silentFillGPR.
The fix is to make silentSpillGPR/silentFillGPR more straightforward,
i.e., spilling/filling based on the GPR instead of the virtual
register. FPR spilling/filling is also modified accordingly to make it
consistent with GPR spilling/filling.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocommand line control of webcore log channels in chromium DumpRenderTree
gavinp@chromium.org [Sun, 13 Nov 2011 21:30:11 +0000 (21:30 +0000)]
command line control of webcore log channels in chromium DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=72126

The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
what chromium takes.

Reviewed by Kent Tamura.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMouse Lock: MouseEvent IDL
scheib@chromium.org [Sun, 13 Nov 2011 21:05:38 +0000 (21:05 +0000)]
Mouse Lock: MouseEvent IDL
https://bugs.webkit.org/show_bug.cgi?id=72158

Reviewed by Dimitri Glazkov.

Tests for movementX/Y pending mock mouse lock test infrastructure.

* dom/MouseEvent.idl:
* dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(99849): NULL-deref in updateLastMediaLine when parsing some media-queries
jchaffraix@webkit.org [Sun, 13 Nov 2011 17:43:28 +0000 (17:43 +0000)]
REGRESSION(99849): NULL-deref in updateLastMediaLine when parsing some media-queries
https://bugs.webkit.org/show_bug.cgi?id=72222

Reviewed by Pavel Feldman.

Source/WebCore:

Test: fast/media/update-media-query-css-parser.html

* css/CSSGrammar.y: Added a proper NULL-check.

LayoutTests:

* fast/media/update-media-query-css-parser-expected.txt: Added.
* fast/media/update-media-query-css-parser.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMouse Lock Navigator IDL
scheib@chromium.org [Sun, 13 Nov 2011 15:26:09 +0000 (15:26 +0000)]
Mouse Lock Navigator IDL
https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

* WebCore.gypi:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):
* page/MouseLockable.cpp: Added.
(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):
* page/MouseLockable.h: Added.
(WebCore::MouseLockable::create):
* page/MouseLockable.idl: Added.
* page/Navigator.cpp:
(WebCore::Navigator::webkitPointer):
* page/Navigator.h:
* page/Navigator.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOnly HTMLAllCollection needs stateful named item traversal.
andreas.kling@nokia.com [Sun, 13 Nov 2011 14:53:48 +0000 (14:53 +0000)]
Only HTMLAllCollection needs stateful named item traversal.
<http://webkit.org/b/71987>

Reviewed by Antti Koivisto.

After the ability to call collections (excluding document.all) was removed
in <http://webkit.org/b/67579>, chunks of code remained in HTMLCollection
and HTMLFormCollection that was only used for this purpose.

Restrict the nextNamedItem() mechanism to HTMLAllCollection, since it's no
longer used by any of the other collections.

* html/HTMLCollection.h:

    Moved nextNamedItem() to HTMLAllCollection (and made it non-virtual.)
    Promoted itemAfter() and checkForNameMatch() to protected methods so
    they can be called from HTMLAllCollection.

* html/HTMLAllCollection.h:
* html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::HTMLAllCollection):
(WebCore::HTMLAllCollection::nextNamedItem):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::namedItem):
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::namedItem):
* html/HTMLFormCollection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the 32-bit build.
mrowe@apple.com [Sun, 13 Nov 2011 09:28:44 +0000 (09:28 +0000)]
Fix the 32-bit build.

* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox): Use a format specifier and cast that works on more architectures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate binding generator tests to use jsCast
caio.oliveira@openbossa.org [Sun, 13 Nov 2011 08:09:46 +0000 (08:09 +0000)]
Update binding generator tests to use jsCast
https://bugs.webkit.org/show_bug.cgi?id=72224

Reviewed by Geoffrey Garen.

Update the expected results for JS generator after r100006 added jsCast.

* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertyDescriptor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100038.
commit-queue@webkit.org [Sun, 13 Nov 2011 07:40:46 +0000 (07:40 +0000)]
Unreviewed, rolling out r100038.
http://trac.webkit.org/changeset/100038
https://bugs.webkit.org/show_bug.cgi?id=72225

It broke more than 500 layout tests on the Qt bots (Requested
by Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-12

* platform/qt/ScrollbarThemeQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][Symbian] Remove support for WINSCW compiler
laszlo.1.gombos@nokia.com [Sun, 13 Nov 2011 04:37:43 +0000 (04:37 +0000)]
[Qt][Symbian] Remove support for WINSCW compiler
https://bugs.webkit.org/show_bug.cgi?id=70178

Reviewed by Chang Shu.

Source/JavaScriptCore:

* API/JSStringRef.h:
* create_hash_table: Revert r45553.
* runtime/JSGlobalData.cpp: Revert r45553.
* runtime/LiteralParser.cpp: Remove WINSCW comment.
(JSC::LiteralParser::Lexer::lexString):
* runtime/Lookup.h: Revert r45553.
* runtime/Structure.h: Revert r48461.
* wtf/Alignment.h:
* wtf/Assertions.h: Revert r52337.
* wtf/Compiler.h:
* wtf/ListRefPtr.h: Revert r48988.
(WTF::ListRefPtr::~ListRefPtr):
* wtf/OwnArrayPtr.h: Revert r45911.
(WTF::OwnArrayPtr::operator UnspecifiedBoolType):
* wtf/PassOwnArrayPtr.h:
(WTF::PassOwnArrayPtr::operator UnspecifiedBoolType):
* wtf/PassRefPtr.h:
* wtf/StaticConstructors.h:
* wtf/unicode/qt4/UnicodeQt4.h:

Source/WebCore:

No new tests as there is no new functionality.

* config.h: Revert r57076.
* loader/cache/CachedResourceHandle.h: Revert r49017 and r49556.
(WebCore::CachedResourceHandle::CachedResourceHandle):
* rendering/style/RenderStyle.h: Revert r52733.
(compareEqual):
* bindings/scripts/CodeGeneratorJS.pm: Revert r45553.
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
* bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
* bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

Source/WebKit2:

* Shared/API/c/WKString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WebVTT parsing layout tests. Patch also includes creating a TextTrackCueList
annacc@chromium.org [Sun, 13 Nov 2011 00:47:57 +0000 (00:47 +0000)]
Add WebVTT parsing layout tests.  Patch also includes creating a TextTrackCueList
in TextTrack::cues() and observing WebVTT chronological cue order.
https://bugs.webkit.org/show_bug.cgi?id=72215

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-webvtt-tc000-empty.html
       media/track/track-webvtt-tc001-utf8.html
       media/track/track-webvtt-tc002-bom.html
       media/track/track-webvtt-tc003-newlines.html
       media/track/track-webvtt-tc004-magic-header.html
       media/track/track-webvtt-tc005-header-comment.html
       media/track/track-webvtt-tc006-cue-identifiers.html
       media/track/track-webvtt-tc007-cue-no-id.html
       media/track/track-webvtt-tc008-timings-no-hours.html
       media/track/track-webvtt-tc009-timings-hour.html
       media/track/track-webvtt-tc010-no-timings.html
       media/track/track-webvtt-tc011-blank-lines.html
       media/track/track-webvtt-tc012-out-of-order.html
       media/track/track-webvtt-tc013-settings.html
       media/track/track-webvtt-tc014-alignment.html
       media/track/track-webvtt-tc015-positioning.html
       media/track/track-webvtt-tc016-align-positioning.html
       media/track/track-webvtt-tc017-line-position.html
       media/track/track-webvtt-tc018-align-text-line-position.html
       media/track/track-webvtt-tc019-cue-size.html
       media/track/track-webvtt-tc020-cue-size-align.html
       media/track/track-webvtt-tc021-valign.html
       media/track/track-webvtt-tc022-entities.html
       media/track/track-webvtt-tc023-markup.html
       media/track/track-webvtt-tc024-timestamp.html
       media/track/track-webvtt-tc025-class-markup.html
       media/track/track-webvtt-tc026-voice.html
       media/track/track-webvtt-tc027-empty-cue.html
       media/track/track-webvtt-tc028-unsupported-markup.html

* html/TextTrack.cpp:
(WebCore::TextTrack::~TextTrack): Only call client if m_cues has been allocated.
(WebCore::TextTrack::cues): Create a TextTrackCueList if we don't already have one.
* html/TextTrack.h: The cues() function can no longer be const.
* html/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::add): Only add the cue if the startTime comes after
    all other startTimes in the list.

LayoutTests:

* media/track/captions-webvtt/tc012-out-of-order.vtt: Fix typo.
* media/track/track-webvtt-tc000-empty-expected.txt: Added.
* media/track/track-webvtt-tc000-empty.html: Added.
* media/track/track-webvtt-tc001-utf8-expected.txt: Added.
* media/track/track-webvtt-tc001-utf8.html: Added.
* media/track/track-webvtt-tc002-bom-expected.txt: Added.
* media/track/track-webvtt-tc002-bom.html: Added.
* media/track/track-webvtt-tc003-newlines-expected.txt: Added.
* media/track/track-webvtt-tc003-newlines.html: Added.
* media/track/track-webvtt-tc004-magic-header-expected.txt: Added.
* media/track/track-webvtt-tc004-magic-header.html: Added.
* media/track/track-webvtt-tc005-header-comment-expected.txt: Added.
* media/track/track-webvtt-tc005-header-comment.html: Added.
* media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Added.
* media/track/track-webvtt-tc006-cue-identifiers.html: Added.
* media/track/track-webvtt-tc007-cue-no-id-expected.txt: Added.
* media/track/track-webvtt-tc007-cue-no-id.html: Added.
* media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Added.
* media/track/track-webvtt-tc008-timings-no-hours.html: Added.
* media/track/track-webvtt-tc009-timings-hour-expected.txt: Added.
* media/track/track-webvtt-tc009-timings-hour.html: Added.
* media/track/track-webvtt-tc010-no-timings-expected.txt: Added.
* media/track/track-webvtt-tc010-no-timings.html: Added.
* media/track/track-webvtt-tc011-blank-lines-expected.txt: Added.
* media/track/track-webvtt-tc011-blank-lines.html: Added.
* media/track/track-webvtt-tc012-out-of-order-expected.txt: Added.
* media/track/track-webvtt-tc012-out-of-order.html: Added.
* media/track/track-webvtt-tc013-settings-expected.txt: Added.
* media/track/track-webvtt-tc013-settings.html: Added.
* media/track/track-webvtt-tc014-alignment-expected.txt: Added.
* media/track/track-webvtt-tc014-alignment.html: Added.
* media/track/track-webvtt-tc015-positioning-expected.txt: Added.
* media/track/track-webvtt-tc015-positioning.html: Added.
* media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
* media/track/track-webvtt-tc016-align-positioning.html: Added.
* media/track/track-webvtt-tc017-line-position-expected.txt: Added.
* media/track/track-webvtt-tc017-line-position.html: Added.
* media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
* media/track/track-webvtt-tc018-align-text-line-position.html: Added.
* media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
* media/track/track-webvtt-tc019-cue-size.html: Added.
* media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
* media/track/track-webvtt-tc020-cue-size-align.html: Added.
* media/track/track-webvtt-tc021-valign-expected.txt: Added.
* media/track/track-webvtt-tc021-valign.html: Added.
* media/track/track-webvtt-tc022-entities-expected.txt: Added.
* media/track/track-webvtt-tc022-entities.html: Added.
* media/track/track-webvtt-tc023-markup-expected.txt: Added.
* media/track/track-webvtt-tc023-markup.html: Added.
* media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
* media/track/track-webvtt-tc024-timestamp.html: Added.
* media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
* media/track/track-webvtt-tc025-class-markup.html: Added.
* media/track/track-webvtt-tc026-voice-expected.txt: Added.
* media/track/track-webvtt-tc026-voice.html: Added.
* media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
* media/track/track-webvtt-tc027-empty-cue.html: Added.
* media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
* media/track/track-webvtt-tc028-unsupported-markup.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixes to GraphicsContext3D::makeCurrent on gtk and mac
nduca@chromium.org [Sat, 12 Nov 2011 23:27:43 +0000 (23:27 +0000)]
Fixes to GraphicsContext3D::makeCurrent on gtk and mac
https://bugs.webkit.org/show_bug.cgi?id=72218

Unreviewed. Forgot to handle corner cases. Thanks Nico!

* platform/graphics/gtk/GraphicsContext3DGtk.cpp:
(WebCore::GraphicsContext3D::makeContextCurrent):
* platform/graphics/gtk/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::makeContextCurrent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/10294191> REGRESSION (WebKit2): Lookup bubble sized and positioned...
mitz@apple.com [Sat, 12 Nov 2011 22:13:00 +0000 (22:13 +0000)]
<rdar://problem/10294191> REGRESSION (WebKit2): Lookup bubble sized and positioned incorrectly (vertically off)
https://bugs.webkit.org/show_bug.cgi?id=72217

Reviewed by Dave Hyatt.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup): Rather than adding the NSFont’s ascender
to the top of the text rect to establish the baseline here...
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange): ...do it here, using the WebCore::Font’s
ascender, which is what’s actually used when drawing the text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Add ENABLE(DFG_JIT) around DFGCorrectableJumpPoint code.
paroga@webkit.org [Sat, 12 Nov 2011 18:43:42 +0000 (18:43 +0000)]
Unreviewed. Add ENABLE(DFG_JIT) around DFGCorrectableJumpPoint code.

* dfg/DFGCorrectableJumpPoint.cpp:
* dfg/DFGCorrectableJumpPoint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CMake] Move list of DFG source files into correct file
paroga@webkit.org [Sat, 12 Nov 2011 17:30:48 +0000 (17:30 +0000)]
[CMake] Move list of DFG source files into correct file
https://bugs.webkit.org/show_bug.cgi?id=72212

Reviewed by Daniel Bates.

The DFG files are platform independent. So move them from
the EFL specific file into the general CMakeLists.txt.

* CMakeLists.txt:
* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix "unused variable" warning in JSLock
paroga@webkit.org [Sat, 12 Nov 2011 16:14:34 +0000 (16:14 +0000)]
Fix "unused variable" warning in JSLock
https://bugs.webkit.org/show_bug.cgi?id=72213

Reviewed by Anders Carlsson.

Use ASSERT_UNUSED() instead of ASSERT() to make sure
that the variable is also used in the release build.

* runtime/JSLock.cpp:
(JSC::JSLock::lock):
(JSC::JSLock::unlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd stub implementation for SVGResources::filter()
paroga@webkit.org [Sat, 12 Nov 2011 13:51:58 +0000 (13:51 +0000)]
Add stub implementation for SVGResources::filter()
https://bugs.webkit.org/show_bug.cgi?id=72211

Reviewed by Dirk Schulze.

Add an empty implementation, which only returns 0 for !ENABLE(FILTERS)
to reduce the #if ENABLE(FILTERS) complexity a bit.

* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::selfWillPaint):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::selfWillPaint):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::filtersForceContainerLayout):
* rendering/svg/SVGResources.h:
(WebCore::SVGResources::filter):
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientLayoutChanged):
(WebCore::SVGResourcesCache::clientUpdatedFromElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r98542): Rendering error on Google maps
antti@apple.com [Sat, 12 Nov 2011 13:33:26 +0000 (13:33 +0000)]
REGRESSION(r98542): Rendering error on Google maps
https://bugs.webkit.org/show_bug.cgi?id=71996

Source/WebCore:

Reviewed by Andreas Kling.

r98542 exposed that StyleBoxData copy constructor and operator== are missing a field.

Test reduction by David Barr.

Test: fast/css/vertical-align-length-copy-bug.html

* rendering/style/StyleBoxData.cpp:
(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

LayoutTests:

Reviewed by Andreas Kling.

Test reduction by David Barr.

* fast/css/vertical-align-length-copy-bug-expected.txt: Added.
* fast/css/vertical-align-length-copy-bug.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix minor config typo in the build tool documentation
commit-queue@webkit.org [Sat, 12 Nov 2011 12:01:43 +0000 (12:01 +0000)]
[Qt] Fix minor config typo in the build tool documentation
https://bugs.webkit.org/show_bug.cgi?id=72194

Patch by Ariya Hidayat <ariya@sencha.com> on 2011-11-12
Reviewed by Andreas Kling.

* qmake/README:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100013.
commit-queue@webkit.org [Sat, 12 Nov 2011 11:09:33 +0000 (11:09 +0000)]
Unreviewed, rolling out r100013.
http://trac.webkit.org/changeset/100013
https://bugs.webkit.org/show_bug.cgi?id=72210

It breaks all mac builds (Requested by WildFox on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-12

Source/WebCore:

* html/HTMLAnchorElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLButtonElement.idl:
* html/HTMLElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLLabelElement.idl:
* html/HTMLLegendElement.idl:
* html/HTMLTextAreaElement.idl:

LayoutTests:

* fast/forms/access-key-for-all-elements-expected.txt: Removed.
* fast/forms/access-key-for-all-elements.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-11-12 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 12 Nov 2011 10:39:17 +0000 (10:39 +0000)]
2011-11-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Finish SVGLengthContext conversion in svg/
        https://bugs.webkit.org/show_bug.cgi?id=72105

        Reviewed by Antti Koivisto.

        Make SVGLengthContext(const SVGElement*) explicit, adapt all remaining call sites.
        Now that this process is finished, SVGLengthContext can be shared across renders,
        so that its possible to override the length context in a single place. This will
        be done in future patches.

        Doesn't affect any tests yet.

        * bindings/js/JSSVGLengthCustom.cpp:
        (WebCore::JSSVGLength::value):
        (WebCore::JSSVGLength::setValue):
        (WebCore::JSSVGLength::convertToSpecifiedUnits):
        * bindings/scripts/CodeGeneratorObjC.pm:
        (GenerateImplementation):
        * bindings/v8/custom/V8SVGLengthCustom.cpp:
        (WebCore::V8SVGLength::valueAccessorGetter):
        (WebCore::V8SVGLength::valueAccessorSetter):
        (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
        * css/CSSCursorImageValue.cpp:
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
        * rendering/svg/RenderSVGForeignObject.cpp:
        (WebCore::RenderSVGForeignObject::layout):
        * rendering/svg/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::updateFromElement):
        * rendering/svg/RenderSVGPath.cpp:
        (WebCore::RenderSVGPath::zeroLengthSubpathRect):
        (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded):
        * rendering/svg/RenderSVGResourceMarker.cpp:
        (WebCore::RenderSVGResourceMarker::referencePoint):
        (WebCore::RenderSVGResourceMarker::calcViewport):
        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::strokeBoundingBox):
        * rendering/svg/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::calcViewport):
        * rendering/svg/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::applyStrokeStyleToContext):
        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::writeStyle):
        (WebCore::operator<<):
        * rendering/svg/SVGShadowTreeElements.cpp:
        (WebCore::SVGShadowTreeContainerElement::containerTranslation):
        * rendering/svg/SVGTextChunkBuilder.cpp:
        (WebCore::SVGTextChunkBuilder::addTextChunk):
        * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
        (WebCore::extractFloatValuesFromSVGLengthList):
        * rendering/svg/SVGTextLayoutEngine.cpp:
        (WebCore::SVGTextLayoutEngine::parentDefinesTextLength):
        (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
        * rendering/svg/SVGTextLayoutEngineBaseline.cpp:
        (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
        * rendering/svg/SVGTextLayoutEngineSpacing.cpp:
        (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
        * svg/SVGElement.h:
        * svg/SVGLengthContext.cpp:
        (WebCore::SVGLengthContext::determineViewport):
        * svg/SVGLengthContext.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::viewport):
        (WebCore::SVGSVGElement::localCoordinateSpaceTransform):
        (WebCore::SVGSVGElement::currentViewBoxRect):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::toClipPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CMake] Use MAIN_DEPENDENCY in GENERATE_* macros
paroga@webkit.org [Sat, 12 Nov 2011 08:52:57 +0000 (08:52 +0000)]
[CMake] Use MAIN_DEPENDENCY in GENERATE_* macros
https://bugs.webkit.org/show_bug.cgi?id=71365

Reviewed by Daniel Bates.

Use the MAIN_DEPENDENCY instead of DEPENDS in the custom build commands.
This adds better IDE support for such targets.

* Source/cmake/WebKitMacros.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for !ENABLE(FILTERS) after r100036.
paroga@webkit.org [Sat, 12 Nov 2011 08:40:41 +0000 (08:40 +0000)]
Unreviewed build fix for !ENABLE(FILTERS) after r100036.

* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::filtersForceContainerLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WIN] Fix build without precompiled header.
paroga@webkit.org [Sat, 12 Nov 2011 07:57:33 +0000 (07:57 +0000)]
[WIN] Fix build without precompiled header.
https://bugs.webkit.org/show_bug.cgi?id=72115

Unreviewed. Add missing includes to fix build without precompiled header.

* platform/ContextMenu.h:
* platform/graphics/win/DIBPixelData.h:
* platform/graphics/win/FontCustomPlatformData.h:
* platform/network/cf/ResourceError.h:
* platform/win/LanguageWin.cpp:
* platform/win/LocalizedStringsWin.cpp:
* platform/win/LoggingWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/72205> Remove Duplicate Symbol Exports
joepeck@webkit.org [Sat, 12 Nov 2011 07:11:13 +0000 (07:11 +0000)]
<webkit.org/b/72205> Remove Duplicate Symbol Exports

Reviewed by Dan Bernstein.

* WebCore.exp.in: Remove duplicate symbols listed.
Each dup in this case was already always exported.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit...
thakis@chromium.org [Sat, 12 Nov 2011 05:24:07 +0000 (05:24 +0000)]
[chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit-time-destructors.
https://bugs.webkit.org/show_bug.cgi?id=72146

Reviewed by Nate Chapin.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

* WebKit.gyp:
* src/DebuggerAgentManager.cpp:
(WebKit::DebuggerAgentManager::debugHostDispatchHandler):
(WebKit::DebuggerAgentManager::onWebViewClosed):
* src/DebuggerAgentManager.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::keyboardShortcut):
* src/WebViewImpl.cpp:
(WebKit::pageGroupLoadDeferrerStack):
(WebKit::WebView::willEnterModalLoop):
(WebKit::WebView::didExitModalLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium layout test rebaselines after http://trac.webkit.org/changeset/100045
ojan@chromium.org [Sat, 12 Nov 2011 04:48:36 +0000 (04:48 +0000)]
Chromium layout test rebaselines after trac.webkit.org/changeset/100045
and http://trac.webkit.org/changeset/100036.

Also add line for failing text test after http://trac.webkit.org/changeset/99963.

* platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
* platform/chromium-win/svg/foreignObject/clip-expected.txt: Added.
* platform/chromium-win/svg/foreignObject/filter-expected.txt: Added.
* platform/chromium-win/svg/foreignObject/mask-expected.txt: Added.
* platform/chromium-win/svg/repaint/filter-child-repaint-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/filter-child-repaint-expected.png.
* platform/chromium/svg/foreignObject/clip-expected.txt: Added.
* platform/chromium/svg/foreignObject/filter-expected.txt: Added.
* platform/chromium/svg/foreignObject/mask-expected.txt: Added.
* platform/chromium/svg/repaint/filter-child-repaint-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/filter-child-repaint-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSince GraphicsContext3D::makeContextCurrent can fail, return bool.
nduca@chromium.org [Sat, 12 Nov 2011 04:45:00 +0000 (04:45 +0000)]
Since GraphicsContext3D::makeContextCurrent can fail, return bool.

https://bugs.webkit.org/show_bug.cgi?id=72101

Reviewed by Kenneth Russell.

Source/WebCore:

* platform/graphics/GraphicsContext3D.h:
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::makeContextCurrent):
* platform/graphics/gtk/GraphicsContext3DGtk.cpp:
(WebCore::GraphicsContext3D::makeContextCurrent):
* platform/graphics/gtk/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
* platform/graphics/gtk/GraphicsContext3DPrivate.h:
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::makeContextCurrent):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::makeContextCurrent):

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Unreviewed. Rollout http://trac.webkit.org/changeset/99744.
ojan@chromium.org [Sat, 12 Nov 2011 04:40:28 +0000 (04:40 +0000)]
Source/WebCore: Unreviewed. Rollout trac.webkit.org/changeset/99744.
https://bugs.webkit.org/show_bug.cgi?id=72203
r99744 causes crash in Chromium's dom_perf test.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::recalcCells):
(WebCore::RenderTableSection::appendColumn):

LayoutTests: Unreviewed. Rollout http://trac.webkit.org/changeset/99744.
https://bugs.webkit.org/show_bug.cgi?id=72203
r99744 causes crash in Chromium's dom_perf test.

* fast/table/crash-splitColumn-2-expected.txt: Removed.
* fast/table/crash-splitColumn-2.html: Removed.
* fast/table/crash-splitColumn-3-expected.txt: Removed.
* fast/table/crash-splitColumn-3.html: Removed.
* fast/table/crash-splitColumn-expected.txt: Removed.
* fast/table/crash-splitColumn.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Removed unused local from CCThreadProxy::scheduledActionCommit
commit-queue@webkit.org [Sat, 12 Nov 2011 04:28:19 +0000 (04:28 +0000)]
[chromium] Removed unused local from CCThreadProxy::scheduledActionCommit
https://bugs.webkit.org/show_bug.cgi?id=72200

Patch by James Robinson <jamesr@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

How did I get here I am not good with computers.

* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Fix a crash when an anonymous render block is in a continuation.
dmazzoni@google.com [Sat, 12 Nov 2011 04:23:59 +0000 (04:23 +0000)]
Source/WebCore: Fix a crash when an anonymous render block is in a continuation.
https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

Test: accessibility/anonymous-render-block-in-continuation-causes-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::renderParentObject):

LayoutTests: Add test to ensure that an anonymous render block in a continuation doesn't crash.
https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

* accessibility/anonymous-render-block-in-continuation-causes-crash.html: Added.
* accessibility/anonymous-render-block-in-continuation-causes-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStorage and retrieval of TextTrackCues during video playback, including
annacc@chromium.org [Sat, 12 Nov 2011 03:37:39 +0000 (03:37 +0000)]
Storage and retrieval of TextTrackCues during video playback, including
cuechange, enter, and exit events.
https://bugs.webkit.org/show_bug.cgi?id=70452

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-cues-cuechange.html
       media/track/track-cues-enter-exit.html
       media/track/track-cues-seeking.html

Add cuechange, enter, and exit events and make TextTrack and
TextTrackCue EventTargets:
* dom/EventNames.h:
* dom/EventTarget.h:
* dom/EventTargetFactory.in:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTimerFired):
    Use scheduleLoad() instead of configureTextTracks() to start an async load.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
    Updates the list of currently active cues during playback.
(WebCore::HTMLMediaElement::textTrackAddCues):
    Adds cues to cueTree.  Called when cues are discovered/loaded.
(WebCore::HTMLMediaElement::textTrackRemoveCues):
    Removes cues from cueTree.  Called when cues and/or tracks die.
(WebCore::HTMLMediaElement::textTrackAddCue):
    Adds a cue to cueTree.  Called when cues are discovered/loaded.
(WebCore::HTMLMediaElement::textTrackRemoveCue):
    Removes a cue from cueTree.  Called when cues and/or tracks die.

(WebCore::HTMLMediaElement::playbackProgressTimerFired):
    Update the active TextTrackCues when playbackProgressTimerFired.
(WebCore::HTMLMediaElement::addTrack):
    Pass along a ScriptExecutionContext to TextTrack::create().
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
    Update the active TextTrackCues when the media player time changes.
* html/HTMLMediaElement.h:
    Use a PodIntervalTree cueTree to store and retrieve TextTrackCues
    during playback.

* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::ensureTrack):
    Pass along a ScriptExecutionContext needed for EventTarget interface.
* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::LoadableTextTrack):
    Pass along a ScriptExecutionContext needed for EventTarget interface.
(WebCore::LoadableTextTrack::fireCueChangeEvent):
    Fire a cue change event on this TextTrack's <track>
* html/LoadableTextTrack.h:
(WebCore::LoadableTextTrack::create):
    Pass along a ScriptExecutionContext needed for EventTarget interface.
* html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack):
    Pass along a ScriptExecutionContext needed for EventTarget interface.
(WebCore::TextTrack::cues):
(WebCore::TextTrack::activeCues):
    Return a TextTrackCueList that represents the currently active cues.
(WebCore::TextTrack::fireCueChangeEvent):
    Fires a cue change event.
* html/TextTrack.h:
(WebCore::TextTrack::create):
    Pass along a ScriptExecutionContext needed for EventTarget interface.
* html/TextTrack.idl:
    Makes TextTrack extend EventTarget interface and add oncuechange.
* html/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
    TextTrackCue should extend EventTarget, not ActiveDOMObject.
(WebCore::TextTrackCue::isActive):
(WebCore::TextTrackCue::setIsActive):
    Dispatch an enter or exit event depending on active state and notify
    the corresponding track to fire a cuechange event.

The following are needed for EventTarget interface:
(WebCore::TextTrackCue::interfaceName):
(WebCore::TextTrackCue::scriptExecutionContext):
(WebCore::TextTrackCue::eventTargetData):
(WebCore::TextTrackCue::ensureEventTargetData):
* html/TextTrackCue.h:
(WebCore::TextTrackCue::refEventTarget):
(WebCore::TextTrackCue::derefEventTarget):

* html/TextTrackCue.idl:
    Extend EventTarget and add onenter and onexit.
* html/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::activeCues):
    Update and return the list of currently active cues.
(WebCore::TextTrackCueList::clear):
    Clear the cues from list (needed to return same object each time).
* html/TextTrackCueList.h:

The following are needed for EventTarget interface:
* html/track/TrackBase.cpp:
(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::interfaceName):
(WebCore::TrackBase::scriptExecutionContext):
(WebCore::TrackBase::eventTargetData):
(WebCore::TrackBase::ensureEventTargetData):
* html/track/TrackBase.h:
(WebCore::TrackBase::refEventTarget):
(WebCore::TrackBase::derefEventTarget):

LayoutTests:

* media/track/captions-webvtt/cues-chrono-order.vtt: Added.
* media/track/captions-webvtt/cues-overlapping.vtt: Added.
* media/track/track-cues-cuechange-expected.txt: Added.
* media/track/track-cues-cuechange.html: Added.
* media/track/track-cues-enter-exit-expected.txt: Added.
* media/track/track-cues-enter-exit.html: Added.
* media/track/track-cues-seeking-expected.txt: Added.
* media/track/track-cues-seeking.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Remove unused variable added by r99813.
commit-queue@webkit.org [Sat, 12 Nov 2011 03:29:48 +0000 (03:29 +0000)]
[Chromium] Remove unused variable added by r99813.
https://bugs.webkit.org/show_bug.cgi?id=72199

Patch by David Reveman <reveman@chromium.org> on 2011-11-11
Reviewed by James Robinson.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rolled DEPS.
ojan@chromium.org [Sat, 12 Nov 2011 03:15:03 +0000 (03:15 +0000)]
Unreviewed. Rolled DEPS.
https://bugs.webkit.org/show_bug.cgi?id=72174

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
commit-queue@webkit.org [Sat, 12 Nov 2011 02:58:11 +0000 (02:58 +0000)]
[Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=72193

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2011-11-11
Reviewed by Noam Rosenthal.

Part of PopupMenuQt.cpp code is guarded by #ifndef QT_NO_COMBOBOX although that
code is not related to the class QComboBox.

* WebCoreSupport/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRollout http://trac.webkit.org/changeset/99844
jamesr@google.com [Sat, 12 Nov 2011 02:56:27 +0000 (02:56 +0000)]
Rollout http://trac.webkit.org/changeset/99844
Solution is more complicated than the problem it was intended to solve.

Source/WebCore:

* platform/graphics/chromium/LayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::applyScrollAndScale):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert Page to operate on integers
leviw@chromium.org [Sat, 12 Nov 2011 02:53:52 +0000 (02:53 +0000)]
Revert Page to operate on integers
https://bugs.webkit.org/show_bug.cgi?id=72185

Reviewed by Eric Seidel.

Reverting the page classes to integers from LayoutUnits. It's not necessary to expose
LayoutUnits in these classes, so we'll avoid doing so.

No new tests, no change in behavior.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::dragHysteresisExceeded):
(WebCore::EventHandler::handleDrag):
* page/EventHandler.h:
* page/Frame.cpp:
(WebCore::Frame::documentAtPoint):
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::FrameView::create):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::invalidateScrollbarRect):
(WebCore::FrameView::getTickmarks):
(WebCore::FrameView::windowResizerRect):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::updateScrollCorner):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::paintOverhangAreas):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
* page/FrameView.h:
* page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
* page/Page.h:
* page/SpatialNavigation.cpp:
(WebCore::scrollInDirection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdating the expected value, missed in r81312
commit-queue@webkit.org [Sat, 12 Nov 2011 02:24:27 +0000 (02:24 +0000)]
Updating the expected value, missed in r81312
https://bugs.webkit.org/show_bug.cgi?id=72170

Patch by Chris Hutten-Czapski <chutten@rim.com> on 2011-11-11
Reviewed by Daniel Bates.

* fast/viewport/viewport-128-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNew iframe content may not be reflected in the ax tree.
dmazzoni@google.com [Sat, 12 Nov 2011 02:23:09 +0000 (02:23 +0000)]
New iframe content may not be reflected in the ax tree.
https://bugs.webkit.org/show_bug.cgi?id=72100

Reviewed by Chris Fleizach.

Source/WebCore:

The core issue was that when childrenChanged was called on a
web area from an iframe that was just detached, it wasn't calling
childrenChanged on its parent scroll area, or that scroll area's
parent iframe element. To fix this, now AccessibilityScrollView
implements setNeedsToUpdateChildren and parentObjectIfExists,
and childrenChanged calls setNeedsToUpdateChildren on every object
in the parent chain, not just AccessibilityRenderObjects.

Test: accessibility/loading-iframe-updates-axtree.html

* accessibility/AXObjectCache.h:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::setNeedsToUpdateChildren):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::childrenChanged):
* accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::setNeedsToUpdateChildren):
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):
* accessibility/AccessibilityScrollView.h:
(WebCore::AccessibilityScrollView::setNeedsToUpdateChildren):

LayoutTests:

Add new test that makes sure that if you explore the accessibility
tree of an iframe and that iframe subsequently loads new content,
the iframe AccessibilityObject's descendants are updated to point
to the new content, not the old content.

* accessibility/loading-iframe-updates-axtree-expected.txt: Added.
* accessibility/loading-iframe-updates-axtree.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK][WEBKIT2] Add font and charset properties to WebKitWebSettings
commit-queue@webkit.org [Sat, 12 Nov 2011 02:10:55 +0000 (02:10 +0000)]
[GTK][WEBKIT2] Add font and charset properties to WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=68996

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-11
Reviewed by Martin Robinson.

Provision to query and set the font related properties (such as
font-family, font-size) and charset properties (such as default-
charset) is added.

* UIProcess/API/gtk/WebKitSettings.cpp: Added font and encoding properties.
(webKitSettingsSetProperty): GObject set property function.
(webKitSettingsGetProperty): GObject get property function.
(webkit_settings_class_init): Few more signals installed.
(webkit_settings_init): Initialization of instance variables.
(webkit_web_settings_get_default_font_family): Get 'default-font-family'.
(webkit_web_settings_set_default_font_family): Set 'default-font-family'.
(webkit_web_settings_get_monospace_font_family): Get 'monospace-font-family'.
(webkit_web_settings_set_monospace_font_family): Set 'monospace-font-family'.
(webkit_web_settings_get_serif_font_family): Get 'serif-font-family'.
(webkit_web_settings_set_serif_font_family): Set 'serif-font-family'.
(webkit_web_settings_get_sans_serif_font_family): Get 'sans-serif-font-family'.
(webkit_web_settings_set_sans_serif_font_family): Get 'sans-serif-font-family'.
(webkit_web_settings_get_cursive_font_family): Get 'cursive-font-family'.
(webkit_web_settings_set_cursive_font_family): Set 'cursive-font-family'.
(webkit_web_settings_get_fantasy_font_family): Get 'fantasy-font-family'.
(webkit_web_settings_set_fantasy_font_family): Set 'fantasy-font-family'.
(webkit_web_settings_get_pictograph_font_family): Get 'pictograph-font-family'.
(webkit_web_settings_set_pictograph_font_family): Set 'pictograph-font-family'.
(webkit_web_settings_get_default_font_size): Get 'default-font-size'.
(webkit_web_settings_set_default_font_size): Set 'default-font-size'.
(webkit_web_settings_get_default_monospace_font_size): Get 'default-monospace-font-size'.
(webkit_web_settings_set_default_monospace_font_size): Set 'default-monospace-font-size'.
(webkit_web_settings_get_minimum_font_size): Get 'minimum-font-size'.
(webkit_web_settings_set_minimum_font_size): Set 'minimum-font-size'.
(webkit_web_settings_get_default_charset): Get 'default-charset'.
(webkit_web_settings_set_default_charset): Set 'default-charset'.
* UIProcess/API/gtk/WebKitSettings.h: Add new sections for gtk-doc generation.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Expose new public APIs.
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings): Add new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix CCThreadProxy::setVisible
commit-queue@webkit.org [Sat, 12 Nov 2011 02:05:39 +0000 (02:05 +0000)]
[chromium] Fix CCThreadProxy::setVisible
https://bugs.webkit.org/show_bug.cgi?id=71903

The behavior is different depending on whether we're showing
or hiding the compositor. This patch fixes both code paths.

Patch by Iain Merrick <husky@google.com> on 2011-11-11
Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCCompletionEvent.h:
(WebCore::CCCompletionEvent::CCCompletionEvent):
(WebCore::CCCompletionEvent::~CCCompletionEvent):
(WebCore::CCCompletionEvent::wait):
(WebCore::CCCompletionEvent::signal):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] CCThreadProxy::finishAllRendering hangs if !visible
commit-queue@webkit.org [Sat, 12 Nov 2011 01:52:27 +0000 (01:52 +0000)]
[chromium] CCThreadProxy::finishAllRendering hangs if !visible
https://bugs.webkit.org/show_bug.cgi?id=71920

Patch by Iain Merrick <husky@google.com> on 2011-11-11
Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setNeedsForcedRedraw):
* platform/graphics/chromium/cc/CCScheduler.h:
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setNeedsForcedRedraw):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):

Source/WebKit/chromium:

* tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Skip tests when no network is present
commit-queue@webkit.org [Sat, 12 Nov 2011 01:38:02 +0000 (01:38 +0000)]
[Qt] Skip tests when no network is present
https://bugs.webkit.org/show_bug.cgi?id=72031

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2011-11-11
Reviewed by Simon Hausmann.

Some benchmark tests requires network connection (they fetch data from
external URL's) and so they fail if no network is present. These tests
should be skipped instead.

* tests/benchmarks/loading/tst_loading.cpp:
(tst_Loading::load): Skip test if no network is present.
* tests/benchmarks/painting/tst_painting.cpp:
(tst_Painting::paint): Skip test if no network is present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Enable building without shared workers.
jknotten@chromium.org [Sat, 12 Nov 2011 01:37:06 +0000 (01:37 +0000)]
[Chromium] Enable building without shared workers.
https://bugs.webkit.org/show_bug.cgi?id=72122

Reviewed by Yury Semikhatsky.

* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::retrieveWorkerContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in styleDidChange when changing a table cell's height.
jchaffraix@webkit.org [Sat, 12 Nov 2011 01:26:22 +0000 (01:26 +0000)]
Crash in styleDidChange when changing a table cell's height.
<http://webkit.org/b/72004>

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/table/crash-table-cell-change-height.html
       fast/table/table-cell-change-height-with-needsCellRecalc-section.html
       fast/table/table-cell-change-last-row-with-needsCellRecalc-section.html
       fast/table/table-row-change-height-with-needsCellRecalc-section.html

r99212 removed our call to recalcCells when the logical height changed. This
means that we could end up with a cells without having set its row() properly
which would crash.

The change exposes the was-the-row-properly-set information so that we don't
try to access a bogus index. This should work properly even if the section
needs a cell recalc as the current section's row structure would still be
accurate in this case.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleDidChange): Check that our row index
was properly set before calling

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::rowWasSet): Helper function to detect
if we have set up our a row.
(WebCore::RenderTableCell::row): Use the previous function in the
ASSERT.

LayoutTests:

* fast/table/crash-table-cell-change-height-expected.txt: Added.
* fast/table/crash-table-cell-change-height.html: Added.

* fast/table/table-cell-change-height-with-needsCellRecalc-section-expected.txt: Added.
* fast/table/table-cell-change-height-with-needsCellRecalc-section.html: Added.
* fast/table/table-cell-change-last-row-with-needsCellRecalc-section-expected.txt: Added.
* fast/table/table-cell-change-last-row-with-needsCellRecalc-section.html: Added.
* fast/table/table-row-change-height-with-needsCellRecalc-section-expected.txt: Added.
* fast/table/table-row-change-height-with-needsCellRecalc-section.html: Added.
Those tests checks that we don't try to access bad rows when the section needs a recalc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement legacy text check emulation in unified text check interface.
commit-queue@webkit.org [Sat, 12 Nov 2011 01:21:44 +0000 (01:21 +0000)]
Implement legacy text check emulation in unified text check interface.
https://bugs.webkit.org/show_bug.cgi?id=70299

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-11
Reviewed by Hajime Morita.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

When UNIFIED_TEXT_CHECKING is off, WebCore::checkTextOfParagraph() emulates
TextCheckerClient::checkTextOfParagraph() using checkSpellingOfString and checkGrammarOfString.

This emulation can be used by setting the flag on.
This can be done by WebCore::Internals::setUnifiedTextCheckingEnabled.

Test: editing/spelling/spelling-unified-emulation.html

* editing/TextCheckingHelper.cpp:
(WebCore::findBadGrammars): Added.
(WebCore::findMisspellings): Added.
(WebCore::checkTextOfParagraph):
  Emulates TextCheckerClients::checkTextOfParagraph if UNIFIED_TEXT_CHECKING is off.
* testing/Internals.cpp:
(WebCore::Internals::setUnifiedTextCheckingEnabled): flag setter.
(WebCore::Internals::unifiedTextCheckingEnabled): flag getter.
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Added tests for the case unified text checker is used when WebCore::checkTextOfParagraph() is not supported.

* editing/spelling/spelling-unified-emulation-expected.txt: Added.
* editing/spelling/spelling-unified-emulation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CMAKE] Add a missing file to PlatformEfl.cmake for curl network backend.
gyuyoung.kim@samsung.com [Sat, 12 Nov 2011 01:15:04 +0000 (01:15 +0000)]
[CMAKE] Add a missing file to PlatformEfl.cmake for curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=72092

Unreviewed. Fix build break when using curl.

ProxyServerCurl.cpp file is not included in PlatformEfl.cmake. So, the file is not built
when EFL port uses curl as network backend.

* PlatformEfl.cmake: Add missing ProxyServerCurl.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch remaining RenderBlock/Box methods to to new layout types
eae@chromium.org [Sat, 12 Nov 2011 01:12:58 +0000 (01:12 +0000)]
Switch remaining RenderBlock/Box methods to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=72075

Reviewed by Eric Seidel.

Move margins, floats and line layout block logic to layout abstraction.

No new tests.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::borderPaddingMarginStart):
(WebCore::borderPaddingMarginEnd):
(WebCore::inlineLogicalWidth):
(WebCore::setStaticPositions):
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
(WebCore::RenderBlock::checkLinesForTextOverflow):
(WebCore::RenderBlock::positionNewFloatOnLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
* rendering/RenderBox.h:
(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Add translation/scaling to WebExternalTextureLayer
commit-queue@webkit.org [Sat, 12 Nov 2011 00:57:48 +0000 (00:57 +0000)]
[chromium] Add translation/scaling to WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=72087

Patch by Antoine Labour <piman@chromium.org> on 2011-11-11
Reviewed by James Robinson.

Source/WebCore:

Covered by WebLayerTest.

* platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::setUVRect):
(WebCore::PluginLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/PluginLayerChromium.h:
(WebCore::PluginLayerChromium::uvRect):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderPosTexStretch::VertexShaderPosTexStretch):
(WebCore::VertexShaderPosTexStretch::init):
(WebCore::VertexShaderPosTexStretch::getShaderString):
* platform/graphics/chromium/ShaderChromium.h:
(WebCore::VertexShaderPosTexStretch::matrixLocation):
(WebCore::VertexShaderPosTexStretch::offsetLocation):
(WebCore::VertexShaderPosTexStretch::scaleLocation):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
(WebCore::CCPluginLayerImpl::setUVRect):

Source/WebKit/chromium:

* public/WebExternalTextureLayer.h:
* src/WebExternalTextureLayer.cpp:
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::uvRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNull deref when no use element exists for SVG element instance
commit-queue@webkit.org [Sat, 12 Nov 2011 00:34:57 +0000 (00:34 +0000)]
Null deref when no use element exists for SVG element instance
https://bugs.webkit.org/show_bug.cgi?id=59136

Second attempt, with a fix to handle JS garbage collection.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/custom/element-instance-held-by-js-crash.svg

* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::~SVGElementInstance): Added call to detach() to clear
  anything not yet cleared.
(WebCore::SVGElementInstance::detach): New method to replace old clear methods. This one
  clears all the pointers it can, and removes the instance from the corresponding elements
  instance list.
* svg/SVGElementInstance.h: Removed clear methods and replaced with detach.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::detachInstance): Modified calls to clean up an SVGElementInstance.

LayoutTests:

* svg/custom/element-instance-held-by-js-crash-expected.txt: Added.
* svg/custom/element-instance-held-by-js-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoclipPath does not work on foreignObject
commit-queue@webkit.org [Sat, 12 Nov 2011 00:30:05 +0000 (00:30 +0000)]
clipPath does not work on foreignObject
https://bugs.webkit.org/show_bug.cgi?id=68251

Patch by Florin Malita <fmalita@google.com> on 2011-11-11
Reviewed by Dirk Schulze.

Source/WebCore:

Add ForeignObject clipping, filtering and masking support using the SVGRenderSupport helpers
(prepareToRenderSVGContent, finishRenderSVGContent) on RenderSVGForeignObject's paint path.
This also allows us to remove explicit transparency handling, since the helpers already cover it.

Tests: svg/foreignObject/clip.html
       svg/foreignObject/filter.html
       svg/foreignObject/mask.html

* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::paint):
* rendering/svg/SVGResources.cpp:
(WebCore::clipperFilterMaskerTags):

LayoutTests:

* svg/foreignObject/clip-expected.png: Added.
* svg/foreignObject/clip-expected.txt: Added.
* svg/foreignObject/clip.html: Added.
* svg/foreignObject/filter-expected.png: Added.
* svg/foreignObject/filter-expected.txt: Added.
* svg/foreignObject/filter.html: Added.
* svg/foreignObject/mask-expected.png: Added.
* svg/foreignObject/mask-expected.txt: Added.
* svg/foreignObject/mask.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert http://trac.webkit.org/changeset/100008.
ojan@chromium.org [Sat, 12 Nov 2011 00:07:11 +0000 (00:07 +0000)]
Revert http://trac.webkit.org/changeset/100008.
Caused hundreds of failures on the Chromium Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=68270

* platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
* platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png:
* platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate expectations for failing test.
ojan@chromium.org [Sat, 12 Nov 2011 00:02:43 +0000 (00:02 +0000)]
Update expectations for failing test.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove no-op StorageNamespace::unlock method
adamk@chromium.org [Fri, 11 Nov 2011 23:54:14 +0000 (23:54 +0000)]
Remove no-op StorageNamespace::unlock method
https://bugs.webkit.org/show_bug.cgi?id=72181

Reviewed by Darin Adler.

Source/WebCore:

The method was meant to support the localStorage mutex,
but the approach of using a mutex for localStorage has never been
implemented (and almost certainly won't be). Even if it were implemented,
it's not being called at the right time, due to bugs in the V8 bindings'
use of V8Proxy (see http://webkit.org/b/72063 for details).

If, in the future, some replacement for a mutex is used to synchronize
localStorage access, it can easily be re-added to the (hopefully
fixed-by-then) replacement for V8Proxy::didLeaveScriptContext.

* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::didLeaveScriptContext): Stop calling unlock().
* page/Navigator.cpp:
(WebCore::Navigator::getStorageUpdates): Remove implementation (a call to unlock), but leave code as it's exposed to the platform.
* page/Navigator.idl: Added a FIXME to remove getStorageUpdates from the platform.
* storage/StorageNamespace.h:
* storage/StorageNamespaceImpl.cpp:
* storage/StorageNamespaceImpl.h:

Source/WebKit/chromium:

* src/StorageNamespaceProxy.cpp:
* src/StorageNamespaceProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
commit-queue@webkit.org [Fri, 11 Nov 2011 23:52:09 +0000 (23:52 +0000)]
[Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=49257

Source/WebKit/chromium:

Add the WebFrame::getPageProperty method for Chromium.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::getPageProperty):
* src/WebFrameImpl.h:

Tools:

Adds the remaining missing layout test functionality for printing.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Add bindings for new JS methods
(parsePageNumber): Method to parse JS arguments for a page number
(parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
(LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
(LayoutTestController::isPageBoxVisible): get the visibility status for printing
(LayoutTestController::pageProperty): get a specific CSS property when in printing mode
* DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods

LayoutTests:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

* platform/chromium/test_expectations.txt: Removed expected fails for
printing tests that were using missing functionality in LayoutTestController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate iOS compiler version.
barraclough@apple.com [Fri, 11 Nov 2011 23:50:19 +0000 (23:50 +0000)]
Update iOS compiler version.

Reviewed by David Kilzer.

* Configurations/CompilerVersion.xcconfig:
    - Update compiler version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Make sure Scrollbars are in their own layer.
alexis.menard@openbossa.org [Fri, 11 Nov 2011 23:44:59 +0000 (23:44 +0000)]
[Qt][WK2] Make sure Scrollbars are in their own layer.
https://bugs.webkit.org/show_bug.cgi?id=72064

Reviewed by Kenneth Rohde Christiansen.

Make sure we render our scrollbars in a separate layer.

No new tests : existing ones should cover.

* platform/qt/ScrollbarThemeQt.h:
(WebCore::ScrollbarThemeQt::usesOverlayScrollbars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate iOS port's configuration setting, particularly in Platform.h
barraclough@apple.com [Fri, 11 Nov 2011 23:43:00 +0000 (23:43 +0000)]
Update iOS port's configuration setting, particularly in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=72187

Reviewed by David Kilzer.

* interpreter/Interpreter.h:
    - Lower the reentry depth.
* runtime/DatePrototype.cpp:
    - iOS also uses CF.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::IncrementalScavenge):
    - Update fastmalloc configuration for iOS.
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
    - Added flag.
* wtf/Platform.h:
    - Update platform configuration for iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRepaint broken when children of filtered SVG elements are updated
commit-queue@webkit.org [Fri, 11 Nov 2011 23:40:57 +0000 (23:40 +0000)]
Repaint broken when children of filtered SVG elements are updated
https://bugs.webkit.org/show_bug.cgi?id=71733

Patch by Joel Webber <jgw@google.com> on 2011-11-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/repaint/filter-child-repaint.svg

* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::setNeedsLayoutForFilteredContainer):

LayoutTests:

* platform/chromium-linux/svg/repaint/filter-child-repaint-expected.png: Added.
* platform/chromium-linux/svg/repaint/filter-child-repaint-expected.txt: Added.
* svg/repaint/filter-child-repaint.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't remove InspectorBackendStub.js in Release builds after it has been
timothy@apple.com [Fri, 11 Nov 2011 23:19:05 +0000 (23:19 +0000)]
Don't remove InspectorBackendStub.js in Release builds after it has been
combined into inspector.js. Also remove any *.qrc file on Mac.

https://webkit.org/b/72186

Reviewed by Joseph Pecoraro.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago WebProcess should use AppSandbox style quarantine
ap@apple.com [Fri, 11 Nov 2011 23:06:35 +0000 (23:06 +0000)]
    WebProcess should use AppSandbox style quarantine
        https://bugs.webkit.org/show_bug.cgi?id=72168
        <rdar://problem/10434292>

        Reviewed by Darin Adler.

        * WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): Just enable it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Patch that implementing the changes required to allow WebGL
commit-queue@webkit.org [Fri, 11 Nov 2011 22:55:11 +0000 (22:55 +0000)]
[chromium] Patch that implementing the changes required to allow WebGL
to share its backing store directly with the compositor.
WebGL rendering contexts create and render to FBOs managed by a
DrawingBuffer instance. All PlatformLayer lifetime management is
performed by the DrawingBuffer.
Changes are only relevant to Chromium ports. Functionality is
unchanged for other ports.
https://bugs.webkit.org/show_bug.cgi?id=53201

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-11
Reviewed by Stephen White.

Source/WebCore:

* html/canvas/WebGLRenderingContext.cpp: Construct a DrawingBuffer
during initialization, and forward all framebuffer management calls to
it.
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::paintRenderingResultsToImageData):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::drawingBufferWidth):
(WebCore::WebGLRenderingContext::drawingBufferHeight):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::deleteFramebuffer):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::platformLayer):
(WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
(WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
* html/canvas/WebGLRenderingContext.h:
* platform/graphics/GraphicsContext3D.cpp:
* platform/graphics/GraphicsContext3D.h:  WebGLLayerChromium instances
are no longer tracked by GraphicsContext3D. Callers can now pass a
DrawingBuffer instance to provide access to the WebGLLayerChromium data.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::initialize):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::platformLayer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::framebuffer):
(WebCore::DrawingBuffer::markContextChanged):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::~WebGLLayerChromium):
(WebCore::WebGLLayerChromium::drawsContent):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::contentChanged):
(WebCore::WebGLLayerChromium::setDrawingBuffer):
(WebCore::WebGLLayerChromium::context):
* platform/graphics/chromium/WebGLLayerChromium.h: WebGLLayerChromium instances
have a raw reference to their owning DrawingBuffer.  This reference is set to NULL on
destruction of the DrawingBuffer.  This follows the old code, which had the WebGLLayerChromium
refer rawly to a GraphicsContext3D instance, which was also revoked during tear-down of the
GraphicsContext3D.
(WebCore::WebGLLayerChromium::drawingBuffer):
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
* platform/graphics/gpu/DrawingBuffer.cpp: The DrawingBuffer is now the
central point between the GraphicsContext3D, WebGLRenderingContext, and
WebGLLayerChromium classes.  GraphicsContext3D, and WebGLLayerChromium only
depend on the DrawingBuffer interface.
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::clearFramebuffer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::commit):
(WebCore::DrawingBuffer::multisample):
(WebCore::DrawingBuffer::paintRenderingResultsToImageData):
(WebCore::DrawingBuffer::discardResources):
* platform/graphics/gpu/DrawingBuffer.h:
(WebCore::DrawingBuffer::setScissorEnabled):
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp: GraphicsContext3DPrivate no longer caches
the WebGLLayerChromium instance.  Instead, it is accessed via DrawingBuffer instances
passed as arguments to the necessary routines.
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
* src/GraphicsContext3DPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100032 268f45cc-cd09-0410-ab3c-d52691b4dbfc