13 years agoSunSpider:
darin@apple.com [Sat, 3 Nov 2007 00:20:01 +0000 (00:20 +0000)]

        * sunspider: Changed "--base" to "--set-baseline".


        * Scripts/run-sunspider: Changed "--base" to "--set-baseline".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSunSpider:
darin@apple.com [Sat, 3 Nov 2007 00:15:02 +0000 (00:15 +0000)]

        Reviewed by Maciej.

        * sunspider: Added a "--base" option that records the current test as a baseline.
        Moved the code to find the newest .mshark file into a function (since I needed to use
        it in the other script and I prefer to copy/paste a function).

        * sunspider-compare-results: Added logic to compare the baseline with the last
        run when you don't pass any parameters.


        Reviewed by Maciej.

        * Scripts/run-sunspider: Pass the "--base" option through.

        * Scripts/sunspider-compare-results: Don't check the number of parameters; let
        the real script do that. Default configuration to Release to match run-sunspider
        so we don't end up building Debug just to compare results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
darin@apple.com [Fri, 2 Nov 2007 23:16:08 +0000 (23:16 +0000)]
    Reviewed by Darin.

        Fix compiler warning "warning: suggest parentheses around && within ||"

        * kjs/value.h: (KJS::JSValue::isNumber): Add parentheses.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Fri, 2 Nov 2007 23:13:36 +0000 (23:13 +0000)]

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15806
          <rdar://problem/5561626> ASSERT(element->isRadioButton()) fires destroying form elements

        Test: fast/forms/remove-radio-button-assert.html

        * html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removeFromForm):
        Added protected function to be used by derived classes that need to do the same sort
        of removal from form that's automatically done by the base class in certain circumstances.
        * html/HTMLGenericFormElement.h: Added removeFromForm.

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement):
        Call removeFromForm here so the element is removed before we destroy the HTMLInputElement
        part of this object. By the time we get to the base class's destructor it's too late.
        The problem is specific to radio buttons so we don't have to worry about other classes
        derived from HTMLGenericFormElement.


        Reviewed by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15806
          <rdar://problem/5561626> ASSERT(element->isRadioButton()) fires destroying form elements

        * fast/forms/remove-radio-button-assert-expected.txt: Added.
        * fast/forms/remove-radio-button-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
darin@apple.com [Fri, 2 Nov 2007 23:11:12 +0000 (23:11 +0000)]
    Reviewed by Mitz.

        - speculative fix for http://bugs.webkit.org/show_bug.cgi?id=15805
          <rdar://problem/5510779> crashes in isLoadingMultipartContent

        * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingMultipartContent):
        Instead of asserting the frame loader is non-0, return false if it is 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Fri, 2 Nov 2007 23:08:41 +0000 (23:08 +0000)]

        Reviewed by Mitz.

        - fix <rdar://problem/5530185> WebKit does not show <object> fallback content when both
          URL and MIME type is omitted

        Already covered by existing tests (that had incorrect results).

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): Return false to indicate
        failure when both URL and MIME type are empty. The old code would not attempt a load, but
        it would indicate success.

        * rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Remove
        non-helpful early exit for the case where there is no URL and no type. Returning early
        prevents the fallback code from running.


        Reviewed by Mitz.

        - fix problem I ran into while doing some testing on Mac for
          <rdar://problem/5530185> WebKit does not show <object>
          fallback content when both URL and MIME type is omitted

        I don't know how to reproduce this failure in DumpRenderTree, so there is no
        regression test.

        * Plugins/WebNullPluginView.h: Removed some unneeded declarations, including
        the didSendError local variable. Instead we just set the error to nil once
        we've sent it.
        * Plugins/WebNullPluginView.mm:
        (-[WebNullPluginView initWithFrame:error:DOMElement:]): Refactored so that
        the null plug-in image code is separate from the rest of the function and
        so that the whole thing is not inside an if statement. Also don't hold a
        reference to the DOM element if there is no error to report.
        (-[WebNullPluginView reportFailure]): Added. Does the actual delegate
        callback. Happens back at the top level of the run loop so it doesn't
        fire deep inside layout. Also wrote this so that it is guaranteed not to
        reenter and so that it can handle the case where the delegate destroys
        the world (including this object). NOTE: This is not a real, general
        solution to the problem of plug-ins that do work inside layout. We will need
        a more general fix that works for other plug-ins, and we'll track that with
        a separate bug report.
        (-[WebNullPluginView viewDidMoveToWindow]): Removed most of the code;
        changed so it just does a performSelector:afterDelay:0.


        Reviewed by Mitz.

        - update tests affected by fix for <rdar://problem/5530185> WebKit does not show
          <object> fallback content when both URL and MIME type is omitted

        * dom/html/level2/html/AppletsCollection-expected.txt: The text "Nothing here!" renders now.
        * fast/dom/HTMLDocument/object-by-name-unknown-child-element-expected.txt: Some blank
        space renders now.
        * platform/mac/fast/invalid/residual-style-expected.txt: A font element renders now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Darin.
alp [Fri, 2 Nov 2007 21:51:49 +0000 (21:51 +0000)]
Reviewed by Darin.

Include Cairo headers properly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-11-02 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 2 Nov 2007 14:07:04 +0000 (14:07 +0000)]
2007-11-02  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        Fix http://bugs.webkit.org/show_bug.cgi?id=15780
        Bug 15780: WebFrameLoaderClient: WebActionElementKey wrong if view is scrolled

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::actionDictionary): Retrieve the mouse event coordinates
        in the page coordinate system rather than the client area coordinate system.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key
oliver [Fri, 2 Nov 2007 06:51:15 +0000 (06:51 +0000)]
Make sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key


        Reviewed by Alexey.

        Make sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key

        * platform/win/KeyEventWin.cpp:


        Reviewed by Alexey.

        Allow Shift, Ctrl, Alt, Meta and Capslock keys to be sent into WebCore.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
mitz [Fri, 2 Nov 2007 06:27:29 +0000 (06:27 +0000)]
    Reviewed by Oliver Hunt.

        - fix an assertion failure when Command-Tabbing out of Safari

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren [Fri, 2 Nov 2007 00:14:04 +0000 (00:14 +0000)]

        Reviewed by Maciej Stachowiak.

        In preparation for making List a simple stack-allocated Vector:

        Removed all instances of List copying and/or assignment, and made List
        inherit from Noncopyable.

        Functions that used to return a List by copy now take List& out

        Layout tests and JS tests pass.

        * kjs/list.cpp:
        (KJS::List::slice): Replaced copyTail with a more generic slice
        alternative. (JavaScriptCore only calls slice(1), but WebCore calls


        Reviewed by Maciej Stachowiak.

        In preparation for making List a simple stack-allocated Vector:

        Removed all instances of List copying, assignment, and/or storage.

        Layout tests and JS tests pass.

        * bindings/js/kjs_window.cpp:
        (KJS::WindowFunc::callAsFunction): Stores a Vector of protected
        JSValue*'s instead of a List now. Converts to List on the fly when
        calling the timer function. This is slightly less efficient, but the
        common case is 0-2 arguments, so it's no biggie.

        (HTML iBench shows no regression. PLT does not use JS timers.)

        (KJS::ScheduledAction::execute): Uses the more efficient and non-copying
        List::slice now.
        (KJS::ScheduledAction::ScheduledAction): ditto

        * bindings/objc/WebScriptObject.mm:
        (getListFromNSArray): Takes a List out parameter now, to avoid copying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCorrect event behaviour on certain control keys
oliver [Thu, 1 Nov 2007 23:30:25 +0000 (23:30 +0000)]
Correct event behaviour on certain control keys

Reviewed by Geoff

Make sure we send the correct keyDown and keyUp events for the
control keys CapsLock, Shift, Ctrl, Alt, and Meta/Command, and
uses Windows key codes for the event keyCode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot part of the patch for my last change.
timothy@apple.com [Thu, 1 Nov 2007 23:10:36 +0000 (23:10 +0000)]
Forgot part of the patch for my last change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
timothy@apple.com [Thu, 1 Nov 2007 23:00:20 +0000 (23:00 +0000)]
    Reviewed by Sam.

        * page/inspector/inspector.css: Use the white disclosure triangles
          when a parent DOM element is sepected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justing [Thu, 1 Nov 2007 22:58:47 +0000 (22:58 +0000)]

        Reviewed by Oliver Hunt.

        <rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): No need to match style when pasting
        into a plaintext-only region, since when we build the fragment to insert from
        plain text, we don't put any style information on it, so it will automatically
        match style with no intervention.
        * editing/markup.cpp:
        (WebCore::createFragmentFromText): Place paragraphs into clones of the
        block being inserted into, instead of default paragraph elements,
        so that when inserted content will match the surrounding paragraph style.
        This was broken before, but I haven't added a layout test yet because
        there currently isn't a way to get only plain text onto the pasteboard
        in a layout test.


        Reviewed by Oliver Hunt.

        <rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply

        No need to match style when pasting plain text, since the fragment we build for plain text
        won't have any style information on it.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): There's no
        longer a need to know whether this function chosePlaintext.
        (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
        (-[WebHTMLView _documentFragmentFromPasteboard:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - Fixed a build failure
kmccullo [Thu, 1 Nov 2007 22:54:11 +0000 (22:54 +0000)]
    - Fixed a build failure

        * WebEditorClient.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
weinig [Thu, 1 Nov 2007 22:31:34 +0000 (22:31 +0000)]
    Reviewed by Adam Roben.

        Add a releaseRef method to COMPtr which matches the behavior
        of the method by the same name in PassRefPtr.  This is in
        preparation of adding autogenerated COM DOM bindings.

        * platform/win/COMPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz [Thu, 1 Nov 2007 22:28:39 +0000 (22:28 +0000)]

        wx impl. for DragController and EventHandler interfaces.

        Reviewed by Adam Roben.

        * page/wx: Added.
        * page/wx/DragControllerWx.cpp: Added.
        * page/wx/EventHandlerWx.cpp: Added.


        - fix typo in test name

        * fast/repaint/layout-state-only-posiitoned.html: Removed.
        * fast/repaint/layout-state-only-positioned.html: Copied from fast/repaint/layout-state-only-posiitoned.html.
        * platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum: Removed.
        * platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png: Removed.
        * platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt: Removed.
        * platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum.
        * platform/mac/fast/repaint/layout-state-only-positioned-expected.png: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png.
        * platform/mac/fast/repaint/layout-state-only-positioned-expected.txt: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx impl. for DragController and EventHandler interfaces.
kevino [Thu, 1 Nov 2007 21:43:43 +0000 (21:43 +0000)]
wx impl. for DragController and EventHandler interfaces.

Reviewed by Adam Roben.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdding files for wx impl. of editing interfaces.
kevino [Thu, 1 Nov 2007 21:36:00 +0000 (21:36 +0000)]
Adding files for wx impl. of editing interfaces.

Reviewed by Adam Roben.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
weinig [Thu, 1 Nov 2007 21:33:33 +0000 (21:33 +0000)]
    Reviewed by Adam Roben.

        Make implicit conversions from LPCSTRs and BSTRs to WebCore string
        types possible in preparation of adding autogenerated COM DOM bindings.

        * platform/AtomicString.cpp:
        * platform/AtomicString.h:
        * platform/PlatformString.h:
        * platform/win/BString.cpp:
        * platform/win/BString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders
beidson@apple.com [Thu, 1 Nov 2007 21:15:22 +0000 (21:15 +0000)]
    Reviewed by Anders

        Renamed a flag inside of SQLiteTransaction and added an accessor (for future work)

        * platform/sql/SQLiteTransaction.cpp:
        * platform/sql/SQLiteTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove all duplicate xcopy commands from WebCore's post-build step
aroben [Thu, 1 Nov 2007 21:01:18 +0000 (21:01 +0000)]
    Remove all duplicate xcopy commands from WebCore's post-build step

        Also add the /d option to the copy of platform/sql.

        Rubberstamped by Sam.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
aroben [Thu, 1 Nov 2007 21:00:49 +0000 (21:00 +0000)]
    Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"

        Reviewed by Sam.

        * Scripts/commit-log-editor: Show all the directories beneath the
        source root, instead of just the last one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren [Thu, 1 Nov 2007 20:50:28 +0000 (20:50 +0000)]

        Reviewed by Maciej Stachowiak.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=15785
        REGRESSION(r27344): Crash on load at finance.yahoo.com

        Reverted a small portion of my last check-in. (The speedup and the List
        removal are still there, though.)

        ActivationImp needs to hold a pointer to its function, and mark that
        pointer (rather than accessing its function through its ExecState, and
        counting on the active scope to mark its function) because a closure
        can cause an ActivationImp to outlive its ExecState along with any
        active scope.

        * kjs/ExecState.cpp:
        * kjs/function.cpp:
        * kjs/function.h:

        Also made HashTable a little more crash-happy in debug builds, so
        problems like this will show up earlier:

        * wtf/HashTable.h:


        Reviewed by Maciej Stachowiak.

        Layout test for http://bugs.webkit.org/show_bug.cgi?id=15785
        REGRESSION(r27344): Crash on load at finance.yahoo.com

        * fast/js/activation-object-function-lifetime-expected.txt: Added.
        * fast/js/activation-object-function-lifetime.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Tim Hatcher.
weinig@apple.com [Thu, 1 Nov 2007 20:35:09 +0000 (20:35 +0000)]
    Rubber-stamped by Tim Hatcher.

        * misc/DatabaseExample.html: Speed up default close speed to .25s

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
weinig@apple.com [Thu, 1 Nov 2007 20:28:25 +0000 (20:28 +0000)]
    Reviewed by Adam Roben.

        - Don't show the close button on the notes unless hovering over the note.
        - Do transformation and fade when closing a note using the new transition properties.

        * misc/DatabaseExample.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix the parameter type of WebLocalizedString to match the UI_STRING macro
aroben [Thu, 1 Nov 2007 20:23:48 +0000 (20:23 +0000)]
    Fix the parameter type of WebLocalizedString to match the UI_STRING macro

        Reviewed by Sam.

        * WebLocalizableStrings.cpp:
        * WebLocalizableStrings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
adele [Thu, 1 Nov 2007 19:01:09 +0000 (19:01 +0000)]
    Reviewed by Maciej.

        Add support for the animation of the -webkit-border-raduis properties.

        * page/AnimationController.cpp:
        (WebCore::blendFunc): Added for IntSize.
        (WebCore::ImplicitAnimation::animate): Added cases for border radius properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-11-01 Alp Toker <alp@atoker.com>
alp [Thu, 1 Nov 2007 18:37:36 +0000 (18:37 +0000)]
2007-11-01  Alp Toker  <alp@atoker.com>

        Reviewed by Mitz Pettel.

        Fix an unbalanced save/restore.

        * platform/graphics/cg/ImageCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add support for the animation of the visibility property.
hyatt [Thu, 1 Nov 2007 18:28:58 +0000 (18:28 +0000)]
    Add support for the animation of the visibility property.

        Reviewed by oliver, aroben

        * page/AnimationController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
kmccullo [Thu, 1 Nov 2007 17:13:59 +0000 (17:13 +0000)]
    Reviewed by Adam.

        - Made COMPtr be able to be used by certain other templates,
        specifically HashSet.

        * platform/win/COMPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz [Thu, 1 Nov 2007 15:30:23 +0000 (15:30 +0000)]

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15015
          <rdar://problem/5420308> Most of www.aol.com redraws unnecessarily when headline/photo section changes

        Test: fast/repaint/overflow-clip-subtree-layout.html

        This patch does not address the bigger issue of doing a full relayout
        of inline flows containing floats, but it addresses the problem on
        aol.com, where the changes that trigger layout are confined to an
        overflow area inside the float.

        * page/FrameView.cpp:
        (WebCore::FrameView::scheduleRelayoutOfSubtree): If the new and old
        layout roots are different but one descends from the other, make (or
        keep) the ancestor as the layout root.
        * rendering/RenderObject.cpp:
        (WebCore::objectIsRelayoutBoundary): Made boxes with overflow
        clipping and non-auto width and height relayout boundaries.


        Reviewed by Dave Hyatt.

        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=15015
          <rdar://problem/5420308> Most of www.aol.com redraws unnecessarily when headline/photo section changes

        * fast/repaint/overflow-clip-subtree-layout.html: Added.
        * platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.checksum: Added.
        * platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
        * platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe.
ap [Thu, 1 Nov 2007 15:01:46 +0000 (15:01 +0000)]
    Reviewed by Mark Rowe.

        Fixed line endings that got confused in this file somehow.

        * platform/network/ResourceResponse.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
ggaren [Thu, 1 Nov 2007 09:58:13 +0000 (09:58 +0000)]
    Reviewed by Adam Roben.

        Addressed some of Darin's review comments.

        Used perl -p, which is the shorthand while(<>) {}.

        Made sure not to suppress bison's output.

        Added line to removed bison_out.txt, since this script removes other
        intermediate files, too.

        * DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-11-01 Kevin Ollivier <kevino@theolliviers.com>
mrowe@apple.com [Thu, 1 Nov 2007 09:30:16 +0000 (09:30 +0000)]
2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>

        Reviewed by Adam Roben.

        Print out an error message when the Windows build fails
        and provide guidance on how to find out what went wrong.

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd some more tests that r27343 fixed
aroben [Thu, 1 Nov 2007 09:30:12 +0000 (09:30 +0000)]
Add some more tests that r27343 fixed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-11-01 Peter Kasting <zerodpx@gmail.com>
mrowe@apple.com [Thu, 1 Nov 2007 09:29:47 +0000 (09:29 +0000)]
2007-11-01  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Dave Hyatt.

        Malformed GIFs should not result in memory corruption.

        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        * platform/image-decoders/gif/GIFImageReader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Adam Roben.
ap [Thu, 1 Nov 2007 09:21:30 +0000 (09:21 +0000)]
    Rubber-stamped by Adam Roben.

        Rolled out r27326 - debug CRT seems to cause no problems after all.

        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
ggaren [Thu, 1 Nov 2007 08:36:58 +0000 (08:36 +0000)]
    Reviewed by Oliver Hunt.

        Removed List from ActivationImp, in preparation for making all lists

        Tests pass.

        1.0% speedup on SunSpider, presumably due to reduced List refcount thrash.

        * kjs/ExecState.cpp:
        * kjs/function.cpp:
        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Use jsNumberCell instead of jsNumber when converting double constants to...
aroben [Thu, 1 Nov 2007 08:28:35 +0000 (08:28 +0000)]
     Use jsNumberCell instead of jsNumber when converting double constants to JSValues

         This fixes fast/js/math.html, which was suffering from a bug in MSVC.
         It also gets rid of an MSVC warning that we previously had to silence.

         Reviewed by Geoff.

         * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Turn
         back on the "overflow in constant arithmetic" warning.
         * kjs/number_object.cpp:
         (NumberObjectImp::getValueProperty): Use jsNumberCell instead of

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add Windows-specific results for window-properties
aroben [Thu, 1 Nov 2007 06:50:58 +0000 (06:50 +0000)]
    Add Windows-specific results for window-properties

        HTML Timed Media elements aren't implemented yet on Windows.

        * platform/win/fast/dom/Window/window-properties-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix
aroben [Thu, 1 Nov 2007 06:20:37 +0000 (06:20 +0000)]
    Windows build fix

        * kjs/ExecState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix ChangeLog entry.
mjs [Thu, 1 Nov 2007 05:05:11 +0000 (05:05 +0000)]
Fix ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
mjs [Thu, 1 Nov 2007 05:02:30 +0000 (05:02 +0000)]
    Reviewed by Oliver.

        - shave some cycles off of local storage access for a 1% SunSpider speedup

        Keep the LocalStorage pointer in the ExecState, not

        * kjs/ExecState.cpp:
        * kjs/ExecState.h:
        * kjs/nodes.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix a crash when parsing a cubic-bezier function
aroben [Thu, 1 Nov 2007 03:51:57 +0000 (03:51 +0000)]
 Fix a crash when parsing a cubic-bezier function


         Fix a crash when parsing a cubic-bezier function

         Reviewed by Hyatt.

         Test: fast/css/parse-timing-function-crash.html

         * WebCore.vcproj/WebCore.vcproj:
         * css/CSSParser.cpp:
         (WebCore::CSSParser::parseTimingFunctionValue): Don't walk off the end
         of the ValueList.


         New test for a crash when parsing a cubic-bezier function

         Reviewed by Hyatt.

         * fast/css/parse-timing-function-crash-expected.txt: Added.
         * fast/css/parse-timing-function-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix a merge error from when I applied my patch to ToT. A couple of lines...
hyatt [Thu, 1 Nov 2007 03:05:41 +0000 (03:05 +0000)]
    Fix a merge error from when I applied my patch to ToT.  A couple of lines should be part of an if.

        * rendering/RenderStyle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix a crash on launch due to a static initializer race
aroben [Thu, 1 Nov 2007 01:22:35 +0000 (01:22 +0000)]
    Fix a crash on launch due to a static initializer race

        We now use fast inline assembler spinlocks which can be statically
        initialized at compile time.

        As a side benefit, this speeds up SunSpider by 0.4%.

        Reviewed by Oliver.

        * wtf/FastMalloc.cpp:
        * wtf/TCSpinLock.h:
        * wtf/TCSystemAlloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca [Thu, 1 Nov 2007 01:16:23 +0000 (01:16 +0000)]
    Reviewed by Sam.

        Add new SQL callback interfaces and JS implementations of them.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSCustomSQLStatementCallback.cpp: Added.
        * bindings/js/JSCustomSQLStatementCallback.h: Added.
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp: Added.
        * bindings/js/JSCustomSQLStatementErrorCallback.h: Added.
        * bindings/js/JSCustomSQLTransactionCallback.cpp: Added.
        * bindings/js/JSCustomSQLTransactionCallback.h: Added.
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp: Added.
        * bindings/js/JSCustomSQLTransactionErrorCallback.h: Added.
        * storage/JSCustomSQLStatementCallback.h: Added.
        * storage/JSCustomSQLStatementErrorCallback.h: Added.
        * storage/JSCustomSQLTransactionCallback.h: Added.
        * storage/JSCustomSQLTransactionErrorCallback.h: Added.
        * storage/SQLStatementCallback.h: Added.
        * storage/SQLStatementCallback.idl: Added.
        * storage/SQLStatementErrorCallback.h: Added.
        * storage/SQLStatementErrorCallback.idl: Added.
        * storage/SQLTransaction.h: Added.
        * storage/SQLTransaction.idl: Added.
        * storage/SQLTransactionCallback.h: Added.
        * storage/SQLTransactionCallback.idl: Added.
        * storage/SQLTransactionErrorCallback.h: Added.
        * storage/SQLTransactionErrorCallback.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
kmccullo [Thu, 1 Nov 2007 00:06:56 +0000 (00:06 +0000)]
    Reviewed by Sam.

        - Corrected spelling.

        * wtf/HashTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justing [Wed, 31 Oct 2007 23:23:26 +0000 (23:23 +0000)]

        Reviewed by Dave Harrison.

        <rdar://problem/5569741> Pasting content with a line break into a list can remove the list

        * editing/htmlediting.cpp:
        (WebCore::enclosingEmptyListItem): A single list item can contain multiple
        paragraphs, so if the incoming VisiblePosition is in an empty paragraph in a
        list item, that list item isn't necessarily empty.


        Reviewed by Dave Harrison.

        * editing/execCommand/5569741.html: Added.
        * platform/mac/editing/execCommand/5569741-expected.checksum: Added.
        * platform/mac/editing/execCommand/5569741-expected.png: Added.
        * platform/mac/editing/execCommand/5569741-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan.
timothy@apple.com [Wed, 31 Oct 2007 23:12:35 +0000 (23:12 +0000)]
    Reviewed by John Sullivan.

        Move the developer extras preference to WebPreferences.

        * WebView/WebPreferenceKeysPrivate.h: Add WebKitDeveloperExtrasEnabledPreferenceKey
        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]): Initialize WebKitDeveloperExtrasEnabledPreferenceKey to NO.
        (-[WebPreferences developerExtrasEnabled]): Check DisableWebKitDeveloperExtras, WebKitDeveloperExtras
          and IncludeDebugMenu in addition to WebKitDeveloperExtrasEnabledPreferenceKey.
        (-[WebPreferences setDeveloperExtrasEnabled:]): Set WebKitDeveloperExtrasEnabledPreferenceKey.
        * WebView/WebPreferencesPrivate.h: Add developerExtrasEnabled and setDeveloperExtrasEnabled:.
        * WebView/WebView.mm:
        (+[WebView _developerExtrasEnabled]): Removed.
        (-[WebView _preferencesChangedNotification:]): Check the WebPreferences object for developerExtrasEnabled.
        * WebView/WebViewPrivate.h: Removed _developerExtrasEnabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Disable style sharing for animating styles.
hyatt [Wed, 31 Oct 2007 21:19:20 +0000 (21:19 +0000)]
    Disable style sharing for animating styles.

        Reviewed by mitzpettel

        * css/CSSStyleSelector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
mitz [Wed, 31 Oct 2007 20:58:10 +0000 (20:58 +0000)]
    Reviewed by Darin Adler.

        - fix intermediate length calculation

        * rendering/Length.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove timing dependent, occasionally failing cue point tests.
antti [Wed, 31 Oct 2007 20:54:27 +0000 (20:54 +0000)]
    Remove timing dependent, occasionally failing cue point tests.
        Cue points will be replaced with cue ranges soon anyway.

        * media/video-cuepoint-pause-expected.txt: Removed.
        * media/video-cuepoint-remove-multiple-expected.txt: Removed.
        * media/video-cuepoint-multiple-expected.txt: Removed.
        * media/video-cuepoint-remove-expected.txt: Removed.
        * media/video-cuepoint-pause.html: Removed.
        * media/video-cuepoint-remove-multiple.html: Removed.
        * media/video-cuepoint-multiple.html: Removed.
        * media/video-cuepoint-remove.html: Removed.
        * media/video-cuepoint-add-expected.txt: Removed.
        * media/video-cuepoint-add.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca [Wed, 31 Oct 2007 20:07:37 +0000 (20:07 +0000)]
    Reviewed by Darin.

        Add new SQLError implementation.

        * DerivedSources.make:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * storage/SQLError.h: Added.
        * storage/SQLError.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change the initial value of transition-property to all. Change the initial...
hyatt [Wed, 31 Oct 2007 18:46:55 +0000 (18:46 +0000)]
    Change the initial value of transition-property to all.  Change the initial value of
        transition-duration to 0.

        Reviewed by antti

        * rendering/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSwitch the Debug configuration to using the non-debug CRT
aroben [Wed, 31 Oct 2007 18:33:17 +0000 (18:33 +0000)]
Switch the Debug configuration to using the non-debug CRT


        Switch the Debug configuration to using the non-debug CRT

        This matches WebKit.

        Reviewed by Steve.

        * DumpRenderTree/win/DumpRenderTree.vcproj:


        Switch the Debug configuration to using the non-debug CRT

        The debug CRT conflicts with what Safari uses, which causes loading

        Reviewed by Steve.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Mark Rowe.
alp [Wed, 31 Oct 2007 16:23:34 +0000 (16:23 +0000)]
Reviewed by Mark Rowe.

The new Color must be marked valid.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by bdash.
antti [Wed, 31 Oct 2007 15:16:42 +0000 (15:16 +0000)]
    Reviewed by bdash.

        Disable media tests when doing leak checking on Tiger.
        They crash in QuickTime (rdar://problem/5537157).

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-10-31 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Wed, 31 Oct 2007 15:05:39 +0000 (15:05 +0000)]
2007-10-31  Mark Rowe  <mrowe@apple.com>

        Further Gtk build fixage.

        * kjs/regexp_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-10-31 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Wed, 31 Oct 2007 14:59:56 +0000 (14:59 +0000)]
2007-10-31  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * kjs/regexp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTweaked formatting of the ChangeLog a bit.
darin [Wed, 31 Oct 2007 14:52:50 +0000 (14:52 +0000)]
Tweaked formatting of the ChangeLog a bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
darin [Wed, 31 Oct 2007 14:46:41 +0000 (14:46 +0000)]
    Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15749
          RegExp/RegExpObjectImp cause needless UString creation

        Speeds things up 0.4% according to SunSpider.

        * kjs/config.h: Define USE(PCRE16) instead of HAVE(PCREPOSIX),
        because this library doesn't use the real PCRE -- it uses its
        own PCRE that works on UTF-16.

        * kjs/regexp.h: Removed a few unused functions. Changed the ifdef.
        Use Noncopyable. Change the return value of match.
        * kjs/regexp.cpp:
        (KJS::RegExp::RegExp): Call pcre_compile2, for a slight speed boost.
        (KJS::RegExp::~RegExp): PCRE16 rather than PCREPOSIX.
        (KJS::RegExp::match): Change to return the position as an int and the
        ovector as a OwnArrayPtr<int> for efficiency and clearer storage management.

        * kjs/regexp_object.h: Change performMatch and arrayOfMatches to no longer
        require a result string.
        * kjs/regexp_object.cpp:
        (RegExpProtoFunc::callAsFunction): Update for new signature of performMatch.
        (RegExpObjectImp::performMatch): Change so it doesn't return a string.
        (RegExpObjectImp::arrayOfMatches): Simplify by unifying the handling of
        the main result with the backreferences; now it doesn't need to take
        a result parameter.
        (RegExpObjectImp::getBackref): Minor tweaks.
        (RegExpObjectImp::getLastParen): Ditto.
        (RegExpObjectImp::getLeftContext): Ditto.
        (RegExpObjectImp::getRightContext): Ditto.
        (RegExpObjectImp::getValueProperty): Change LastMatch case to call
        getBackref(0) so we don't need a separate getLastMatch function.

        * kjs/string_object.cpp:
        (KJS::replace): Update to use new performMatch, including merging the
        matched string section with the other substrings.
        (KJS::StringProtoFunc::callAsFunction): Update functions to use the
        new performMatch and match. Also change to use OwnArrayPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix for non-Qt builds.
hausmann [Wed, 31 Oct 2007 11:42:12 +0000 (11:42 +0000)]
Build fix for non-Qt builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix dependency path to header files of the public API of the Qt port.
hausmann [Wed, 31 Oct 2007 11:18:46 +0000 (11:18 +0000)]
Fix dependency path to header files of the public API of the Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago* QXmlStreamNamespaceDeclaration doesn't have the constructor we
hausmann [Wed, 31 Oct 2007 11:15:28 +0000 (11:15 +0000)]
* QXmlStreamNamespaceDeclaration doesn't have the constructor we
  want to use for Qt4.3. Reenable the old code path which is likely
  to be dead as I have not checked if m_prefixToNamespaceMap is actually
* Guard the entity resolver with the QT_VERSION as well.
* Partially reverts 369506279abdaa863e15efed649ca19e062f2c30 and
  d2b54d0fc1b07a2480f4f7a1417abd7a636b0107 for Qt4.3.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago* QMimeData::removeData will be new in Qt4.4, don't use it for Qt4.3
hausmann [Wed, 31 Oct 2007 11:13:18 +0000 (11:13 +0000)]
* QMimeData::removeData will be new in Qt4.4, don't use it for Qt4.3
* Provide a bad fallback implementation to filter the format list.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoadd an entitiy resolver to QXmlStream.
hausmann [Wed, 31 Oct 2007 11:09:15 +0000 (11:09 +0000)]
add an entitiy resolver to QXmlStream.
Fixes fast/parser/entities-in-attributes.xhtml.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes in the XML tokenizer when using QXmlStream.
hausmann [Wed, 31 Oct 2007 11:09:08 +0000 (11:09 +0000)]
Fixes in the XML tokenizer when using QXmlStream.

Use new functionality of QXmlStream in Qt 4.4 to simplify
the code (but keep the old code for now to still support Qt 4.3).

Add proper support for namespace handling when parsing into
a document fragment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoadd support for dragging images.
hausmann [Wed, 31 Oct 2007 11:08:58 +0000 (11:08 +0000)]
add support for dragging images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofix most of the issues I found with Clipboard and DnD.
hausmann [Wed, 31 Oct 2007 11:08:50 +0000 (11:08 +0000)]
fix most of the issues I found with Clipboard and DnD.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoQDrag objects need to be created on the heap.
hausmann [Wed, 31 Oct 2007 11:08:40 +0000 (11:08 +0000)]
QDrag objects need to be created on the heap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoa dragLeave event is not the same as cancelling a drag.
hausmann [Wed, 31 Oct 2007 11:08:30 +0000 (11:08 +0000)]
a dragLeave event is not the same as cancelling a drag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by NOBODY (qt buildfix)
oliver [Wed, 31 Oct 2007 11:02:36 +0000 (11:02 +0000)]
Reviewed by NOBODY (qt buildfix)

* kjs/nodes.h: include OwnPtr.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove SourceCodeElement class and replaced with a Vector for a 0.8% gain on sunspider
oliver [Wed, 31 Oct 2007 10:54:37 +0000 (10:54 +0000)]
Remove SourceCodeElement class and replaced with a Vector for a 0.8% gain on sunspider

Reviewed by Maciej

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOliver hasn't changed his name to ChangeLog.
mjs [Wed, 31 Oct 2007 10:52:37 +0000 (10:52 +0000)]
Oliver hasn't changed his name to ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-10-30 Mark Rowe <mrowe@apple.com>
bdash [Wed, 31 Oct 2007 09:47:53 +0000 (09:47 +0000)]
2007-10-30  Mark Rowe  <mrowe@apple.com>

        Fix the Gtk and Qt builds by stubbing out PlatformKeyboardEvent::currentCapsLockState.

        * platform/gtk/KeyEventGtk.cpp:
        * platform/qt/PlatformKeyboardEventQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-10-30 Mark Rowe <mrowe@apple.com>
bdash [Wed, 31 Oct 2007 09:33:44 +0000 (09:33 +0000)]
2007-10-30  Mark Rowe  <mrowe@apple.com>

        Build fix for non-Mac ports.

        * kjs/property_map.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed, build fix.
mjs [Wed, 31 Oct 2007 09:17:46 +0000 (09:17 +0000)]
    Not reviewed, build fix.

        - fix builds

        * kjs/property_map.cpp: Include HashTable.h the right way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Wed, 31 Oct 2007 08:29:19 +0000 (08:29 +0000)]
    Reviewed by Darin.

        WebKit doesn't support RegExp.compile method

        Test: fast/js/regexp-compile.html

        * kjs/regexp_object.cpp:
        * kjs/regexp_object.h:
        Added RegExp.compile.

        * tests/mozilla/expected.html: js1_2/regexp/compile.js now passes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
ap [Wed, 31 Oct 2007 08:22:43 +0000 (08:22 +0000)]
    Reviewed by Anders.

        XSLStylesheet loads subresources from a wrong URL

        Covered by corrected existing tests.

        * xml/XSLStyleSheet.cpp:
        (WebCore::XSLStyleSheet::parseString): Pass stylesheet URL, not
        the document one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ChangeLog.
mjs [Wed, 31 Oct 2007 08:22:12 +0000 (08:22 +0000)]
    Reviewed by ChangeLog.

        - get rid of integer divide in PropertyMap and HashTable for 1% SunSpider speedup

        Integer divide sucks. Fortunately, a bunch of shifts and XORs
        biased towards the high bits is sufficient to provide a good
        double hash. Besides the SunSpider win, I used the dump statistics
        mode for both to verify that collisions did not increase and that
        the longest collision chain is not any longer.

        * kjs/property_map.cpp:
        * wtf/HashTable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Wed, 31 Oct 2007 08:20:39 +0000 (08:20 +0000)]
    Reviewed by Darin.

        String::append does 2 full copies instead of 1 (or zero!)

        No change in functionality, thus no test.

        * platform/String.cpp:
        (WebCore::String::append): Rewrote to copy once. Also removed an ancient
        FIXME that doesn't seem to make any sense. Note that append() behavior doesn't
        match documented String behavior ("modifications to one instance will
        also modify all others"), but there are a lot of methods that don't.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix
aroben [Wed, 31 Oct 2007 07:54:41 +0000 (07:54 +0000)]
    Windows build fix

        * WebCore.vcproj/WebCore.vcproj: Add [JS]ProgressEvent.{cpp,h} files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix
aroben [Wed, 31 Oct 2007 07:24:21 +0000 (07:24 +0000)]
    Build fix

        * kjs/collector.h: Make HeapType public.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change ALWAYS_INLINE and WTF_PRIVATE_INLINE to use __forceinline on Windows
aroben [Wed, 31 Oct 2007 07:20:00 +0000 (07:20 +0000)]
     Change ALWAYS_INLINE and WTF_PRIVATE_INLINE to use __forceinline on Windows

         Speeds up SunSpider by 0.4%.

         Reviewed by Steve and Maciej.

         * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable
         a warning during LTCG in release builds about double -> float
         * wtf/AlwaysInline.h:
         * wtf/FastMalloc.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Use GetCurrentThreadId instead of pthread_self in FastMalloc
aroben [Wed, 31 Oct 2007 07:19:37 +0000 (07:19 +0000)]
     Use GetCurrentThreadId instead of pthread_self in FastMalloc

         Speeds up SunSpider by 0.3%.

         Reviewed by Steve.

         * wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Switch to a Win32 critical section implementation of spinlocks
aroben [Wed, 31 Oct 2007 07:19:13 +0000 (07:19 +0000)]
     Switch to a Win32 critical section implementation of spinlocks

         Speeds up SunSpider by 0.4%.

         Reviewed by Steve.

         * wtf/FastMalloc.cpp:
         * wtf/TCSpinLock.h:
         * wtf/TCSystemAlloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 15586: REGRESSION (r26759-r26785): Windows nightly builds crash with...
aroben [Wed, 31 Oct 2007 07:18:46 +0000 (07:18 +0000)]
    Fix Bug 15586: REGRESSION (r26759-r26785): Windows nightly builds crash with Safari 3 Public Beta


        Also fixes: <rdar://5565303> Cannot use regsvr32.exe to register WebKit.dll

        Use Win32 TLS functions instead of __declspec(thread), which breaks

        Reviewed by Steve.

        * wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fixes
aroben [Wed, 31 Oct 2007 06:57:09 +0000 (06:57 +0000)]
    Windows build fixes

        I'm not completely sure why these const issues weren't caught by GCC,
        but MSVC was certainly not happy with them.

        * editing/IndentOutdentCommand.cpp:
        * editing/markup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
mjs [Wed, 31 Oct 2007 06:09:40 +0000 (06:09 +0000)]
    Reviewed by Oliver.

        - allocate numbers in half-size cells, for an 0.5% SunSpider speedup

        We do this by using a single mark bit per two number cells, and
        tweaking marking.

        Besides being an 0.5% win overall, this is a 7.1% win on morph.

        * kjs/collector.cpp:
        * kjs/collector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago transition-property was defaulting to all when it should default to none.
hyatt [Wed, 31 Oct 2007 03:55:37 +0000 (03:55 +0000)]
    transition-property was defaulting to all when it should default to none.

        It was taking a string type.  I figured out how to make it take an ident instead, so you can write:

        transition-property: opacity

        instead of

        transition-property: "opacity"

        Transition layers also weren't properly repeating patterns the way they were supposed to.  I fixed that.

        Finally, I fixed a bug in the code to fix up transition layers where something was misplaced that should have been inside a null check.

        Reviewed by aroben

        * css/CSSHelper.h:
        * css/CSSParser.cpp:
        * css/CSSStyleSelector.cpp:
        * page/AnimationController.cpp:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
antti [Wed, 31 Oct 2007 03:30:05 +0000 (03:30 +0000)]
    Reviewed by Geoff.

        Leak fix

        * platform/graphics/mac/MoviePrivateQTKit.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben, Sam Weinig.
ggaren [Wed, 31 Oct 2007 03:04:55 +0000 (03:04 +0000)]
    Reviewed by Adam Roben, Sam Weinig.

        Made conflicts in grammar.y a persistent build failure.

        * DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Stephanie Lewis.
mitz [Wed, 31 Oct 2007 02:47:25 +0000 (02:47 +0000)]
    Reviewed by Stephanie Lewis.

        - fix <rdar://problem/5547237> REGRESSION (304-ToT): Repro font-related crash in fontdatawin.cpp Line 93 (many sites)

        * platform/win/FontDataWin.cpp:
        (WebCore::FontData::platformInit): Handle the case where the font has no
        glyphs on page zero.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt bustage in AnimationController.cpp
hyatt [Wed, 31 Oct 2007 02:36:53 +0000 (02:36 +0000)]
Fix Qt bustage in AnimationController.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
antti [Wed, 31 Oct 2007 02:35:53 +0000 (02:35 +0000)]
    Reviewed by Maciej.

        Media tests from feature branch.

        * fast/dom/Window/window-properties-expected.txt: Replaced.
        * fast/dom/Window/window-properties.html: Replaced.
        * media: Added.
        * media/audio-constructor-expected.txt: Added.
        * media/audio-constructor-src-expected.txt: Added.
        * media/audio-constructor-src.html: Added.
        * media/audio-constructor.html: Added.
        * media/content: Added.
        * media/content/test.mp4: Added.
        * media/content/test.wav: Added.
        * media/progress-event-expected.txt: Added.
        * media/progress-event.html: Added.
        * media/video-append-source-expected.txt: Added.
        * media/video-append-source.html: Added.
        * media/video-autoplay-expected.txt: Added.
        * media/video-autoplay.html: Added.
        * media/video-buffered-expected.txt: Added.
        * media/video-buffered.html: Added.
        * media/video-cuepoint-add-expected.txt: Added.
        * media/video-cuepoint-add.html: Added.
        * media/video-cuepoint-multiple-expected.txt: Added.
        * media/video-cuepoint-multiple.html: Added.
        * media/video-cuepoint-pause-expected.txt: Added.
        * media/video-cuepoint-pause.html: Added.
        * media/video-cuepoint-remove-expected.txt: Added.
        * media/video-cuepoint-remove-multiple-expected.txt: Added.
        * media/video-cuepoint-remove-multiple.html: Added.
        * media/video-cuepoint-remove.html: Added.
        * media/video-currentTime-expected.txt: Added.
        * media/video-currentTime-set-expected.txt: Added.
        * media/video-currentTime-set.html: Added.
        * media/video-currentTime-set2-expected.txt: Added.
        * media/video-currentTime-set2.html: Added.
        * media/video-currentTime.html: Added.
        * media/video-dom-autoplay-expected.txt: Added.
        * media/video-dom-autoplay.html: Added.
        * media/video-dom-end-expected.txt: Added.
        * media/video-dom-end.html: Added.
        * media/video-dom-loopcount-expected.txt: Added.
        * media/video-dom-loopcount.html: Added.
        * media/video-dom-loopend-expected.txt: Added.
        * media/video-dom-loopend.html: Added.
        * media/video-dom-loopstart-expected.txt: Added.
        * media/video-dom-loopstart.html: Added.
        * media/video-dom-src-expected.txt: Added.
        * media/video-dom-src.html: Added.
        * media/video-dom-start-expected.txt: Added.
        * media/video-dom-start.html: Added.
        * media/video-end-expected.txt: Added.
        * media/video-end.html: Added.
        * media/video-error-abort-expected.txt: Added.
        * media/video-error-abort.html: Added.
        * media/video-error-does-not-exist-expected.txt: Added.
        * media/video-error-does-not-exist.html: Added.
        * media/video-load-networkState-expected.txt: Added.
        * media/video-load-networkState.html: Added.
        * media/video-load-readyState-expected.txt: Added.
        * media/video-load-readyState.html: Added.
        * media/video-loopcount-expected.txt: Added.
        * media/video-loopcount.html: Added.
        * media/video-loopend-expected.txt: Added.
        * media/video-loopend.html: Added.
        * media/video-loopstart-expected.txt: Added.
        * media/video-loopstart.html: Added.
        * media/video-muted-expected.txt: Added.
        * media/video-muted.html: Added.
        * media/video-no-autoplay-expected.txt: Added.
        * media/video-no-autoplay.html: Added.
        * media/video-seekable-expected.txt: Added.
        * media/video-seekable.html: Added.
        * media/video-size-expected.txt: Added.
        * media/video-size.html: Added.
        * media/video-source-expected.txt: Added.
        * media/video-source-media-expected.txt: Added.
        * media/video-source-media.html: Added.
        * media/video-source-type-expected.txt: Added.
        * media/video-source-type.html: Added.
        * media/video-source.html: Added.
        * media/video-src-expected.txt: Added.
        * media/video-src-source-expected.txt: Added.
        * media/video-src-source.html: Added.
        * media/video-src.html: Added.
        * media/video-start-expected.txt: Added.
        * media/video-start.html: Added.
        * media/video-test.js: Added.
        * media/video-volume-expected.txt: Added.
        * media/video-volume.html: Added.
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove unused blendLengths function.
hyatt [Wed, 31 Oct 2007 02:35:13 +0000 (02:35 +0000)]
Remove unused blendLengths function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoEliminate rounding from int-based animation blending.
hyatt [Wed, 31 Oct 2007 02:32:52 +0000 (02:32 +0000)]
Eliminate rounding from int-based animation blending.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27284 268f45cc-cd09-0410-ab3c-d52691b4dbfc