weinig@apple.com [Tue, 1 Jan 2008 18:05:45 +0000 (18:05 +0000)]
Try again to fix the builds
* DerivedSources.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 1 Jan 2008 17:45:22 +0000 (17:45 +0000)]
Fix non-mac builds.
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCoreSources.bkl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 1 Jan 2008 10:40:57 +0000 (10:40 +0000)]
Reviewed by Alexey.
Don't replace \ with / in data: urls
http://bugs.webkit.org/show_bug.cgi?id=16692
Test: fast/loader/url-data-replace-backslash.html
* platform/KURL.cpp:
(WebCore::KURL::init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 1 Jan 2008 09:05:54 +0000 (09:05 +0000)]
2008-01-01 Alp Toker <alp@atoker.com>
GTK+ autotools build fix. Track changes in r29051, r29058 and pass the
correct parameter to AM_INIT_AUTOMAKE.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 1 Jan 2008 08:43:59 +0000 (08:43 +0000)]
Reviewed by Oliver.
- http://bugs.webkit.org/show_bug.cgi?id=16684
eliminate debugger overhead from function body execution
Speeds SunSpider up 1.003x. That's a small amount, but measurable.
* JavaScriptCore.exp: Updated.
* kjs/Parser.h:
(KJS::Parser::parse): Create the node with a static member function named create() instead
of using new explicitly.
* kjs/grammar.y: Changed calls to new FunctionBodyNode to use FunctionBodyNode::create().
* kjs/nodes.cpp:
(KJS::ProgramNode::create): Added. Calls new.
(KJS::EvalNode::create): Ditto.
(KJS::FunctionBodyNode::create): Ditto, but creates FunctionBodyNodeWithDebuggerHooks
when a debugger is present.
(KJS::FunctionBodyNode::execute): Removed debugger hooks.
(KJS::FunctionBodyNodeWithDebuggerHooks::FunctionBodyNodeWithDebuggerHooks): Added.
(KJS::FunctionBodyNodeWithDebuggerHooks::execute): Calls the debugger, then the code,
then the debugger again.
* kjs/nodes.h: Added create functions, made the constructors private and protected.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 1 Jan 2008 03:04:16 +0000 (03:04 +0000)]
WebCore:
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=16637
Acid3 expects ExeceptionCode constants to be defined on DOMException objects
- Make DOMException a real JS object.
Test: fast/dom/DOMException/prototype-object.html
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
This is no longer needed as the autogenerated classes now includes the
constructor.
* bindings/js/JSDOMExceptionConstructor.cpp: Removed.
* bindings/js/JSDOMExceptionConstructor.h: Removed.
Create on demand and use the new class for DOMExceptions.
* bindings/js/kjs_binding.cpp:
(KJS::setDOMException):
Remove no longer needed custom constructor getter.
* bindings/js/kjs_window.cpp:
(KJS::Window::getValueProperty):
Don't expose DOMCoreException as the name of class by special casing
the user visible class name to be DOMException.
* bindings/scripts/CodeGeneratorJS.pm:
The DOMException class/file needs to be named DOMCoreException because there is
name conflict with one of the Objective-C bindings classes. It should be renamed
to DOMException when the Objective-C bindings are moved into WebKit.
* dom/DOMCoreException.cpp: Added.
(WebCore::DOMCoreException::DOMCoreException):
(WebCore::DOMCoreException::toString):
* dom/DOMCoreException.h: Added.
(WebCore::DOMCoreException::):
(WebCore::DOMCoreException::code):
(WebCore::DOMCoreException::name):
(WebCore::DOMCoreException::message):
* dom/DOMCoreException.idl: Added.
* page/DOMWindow.idl:
LayoutTests:
Reviewed by Darin.
Test for http://bugs.webkit.org/show_bug.cgi?id=16637
Acid3 expects ExeceptionCode constants to be defined on DOMException objects
* fast/dom/DOMException: Added.
* fast/dom/DOMException/prototype-object-expected.txt: Added.
* fast/dom/DOMException/prototype-object.html: Added.
* fast/dom/DOMException/resources: Added.
* fast/dom/DOMException/resources/prototype-object.js: Added.
* fast/dom/Window/window-properties-expected.txt:
* http/tests/xmlhttprequest/connection-error-sync-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 1 Jan 2008 02:01:46 +0000 (02:01 +0000)]
Re-enable querySelector and querySelectorAll and touch the necessary files to not
kill the windows build.
* WebCore.vcproj/build-generated-files.sh:
* bindings/scripts/CodeGeneratorCOM.pm:
* dom/Document.idl:
* dom/Element.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 1 Jan 2008 01:45:15 +0000 (01:45 +0000)]
* fast/dom/HTMLFormElement/elements-not-in-document-expected.txt: Updated results to expect success.
I accdidentally landed an expected failure instead!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 1 Jan 2008 01:37:55 +0000 (01:37 +0000)]
- fix Windows build
* dom/Document.idl: Temporarily disable querySelector and querySelectorAll, since they are showing
up as pure virtual functions. Sam can fix this later.
* dom/Element.idl: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 1 Jan 2008 01:32:00 +0000 (01:32 +0000)]
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=14134
<rdar://problem/
5655160> REGRESSION (r25353): Whitespace nodes ignored between inline list items
Test: fast/dynamic/create-renderer-for-whitespace-only-text.html
* dom/Node.cpp:
(WebCore::Node::attach): Added code to check if this node's renderer
has become the "previous renderer" of any sibling text node, and if so,
ensure that that node gets a renderer if it now needs one.
(WebCore::Node::createRendererIfNeeded): Removed the assertion that the
node is not attached.
LayoutTests:
Reviewed by Darin Adler.
- test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14134
<rdar://problem/
5655160> REGRESSION (r25353): Whitespace nodes ignored between inline list items
* fast/dynamic/create-renderer-for-whitespace-only-text.html: Added.
* fast/dynamic/style-access-late-stylesheet-load-expected.txt:
* platform/mac-leopard/fast/dynamic: Added.
* platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.checksum: Added.
* platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.png: Added.
* platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
* platform/mac/editing/inserting/editable-html-element-expected.txt:
* platform/mac/editing/inserting/editing-empty-divs-expected.txt:
* platform/mac/editing/pasteboard/paste-TIFF-expected.txt:
* platform/mac/editing/selection/
4983858-expected.txt:
* platform/mac/editing/selection/
5136696-expected.txt:
* platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
* platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
* platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
* platform/mac/editing/style/remove-underline-after-paragraph-expected.txt:
* platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
* platform/mac/editing/style/remove-underline-from-stylesheet-expected.txt:
* platform/mac/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt: Added.
* platform/mac/fast/dynamic/move-node-with-selection-expected.txt:
* platform/mac/fast/forms/input-align-expected.txt:
* platform/mac/fast/inline/positionedLifetime-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 1 Jan 2008 01:17:22 +0000 (01:17 +0000)]
WebCore:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=16641
Acid3 reveals HTMLFormElement.elements fails to update when element name changes
Test: fast/dom/HTMLFormElement/elements-not-in-document.html
This was a bug specific to forms that are not in the document tree.
The fix was to change the code to increment the document version number to match
up with other document change tracking. Maybe at some point we can clean these up
so we don't have so many competing change notification systems.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild): Removed bogus comment.
(WebCore::ContainerNode::addChild): Added an explicit incDOMTreeVersion
call here, since this code path bypasses the subtree-modified event code.
* dom/Element.cpp:
(WebCore::Element::setAttribute): Remove the inDocument() check -- not all HTML
collections are for things in the document.
(WebCore::Element::setAttributeMap): Ditto.
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::dispatchSubtreeModifiedEvent): Added a call to
incDOMTreeVersion here; covers most cases of tree structure changes.
* dom/Node.cpp:
(WebCore::Node::attach): Remove call to incDOMTreeVersion -- creating a renderer
has nothing to do with changes to the DOM tree!
(WebCore::Node::detach): Ditto.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::registerFormElement): Remove call to incDOMTreeVersion.
This is handled at a lower level and doesn't need to be here.
(WebCore::HTMLFormElement::removeFormElement): Ditto.
LayoutTests:
Reviewed by Mitz.
- test for http://bugs.webkit.org/show_bug.cgi?id=16641
Acid3 reveals HTMLFormElement.elements fails to update when element name changes
* fast/dom/HTMLFormElement: Added.
* fast/dom/HTMLFormElement/elements-not-in-document-expected.txt: Added.
* fast/dom/HTMLFormElement/elements-not-in-document.html: Added.
* fast/dom/HTMLFormElement/resources: Added.
* fast/dom/HTMLFormElement/resources/TEMPLATE.html: Added.
* fast/dom/HTMLFormElement/resources/elements-not-in-document.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 1 Jan 2008 00:20:19 +0000 (00:20 +0000)]
Suggested by Antti.
* Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
we get it installed on the build bots.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 1 Jan 2008 00:18:16 +0000 (00:18 +0000)]
WebCore:
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14994
Support for MessageEvent and cross-domain messaging
Test: http/tests/messaging/cross-domain-message-send.html
* DerivedSources.make:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::customGetOwnPropertySlot): Allow cross-domain access to the
postMessage function.
(WebCore::JSDOMWindow::postMessage):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* dom/Event.cpp:
(WebCore::Event::isMessageEvent):
* dom/Event.h:
* dom/EventNames.h: New event name
* dom/MessageEvent.cpp: Added.
* dom/MessageEvent.h: Added.
* dom/MessageEvent.idl: Added.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage): Added.
* page/DOMWindow.h:
* page/DOMWindow.idl:
LayoutTests:
Reviewed by Darin.
Test for http://bugs.webkit.org/show_bug.cgi?id=14994
Support for MessageEvent and cross-domain messaging
* fast/dom/Window/window-properties-expected.txt:
* http/tests/messaging: Added.
* http/tests/messaging/cross-domain-message-send-expected.txt: Added.
* http/tests/messaging/cross-domain-message-send.html: Added.
* http/tests/messaging/resources: Added.
* http/tests/messaging/resources/cross-domain-message-receive.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29051
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 31 Dec 2007 23:56:16 +0000 (23:56 +0000)]
Suggested by Antti.
- turn ENABLE_VIDEO back off for Windows until we can install QuickTime on the build bots
* WebCore.vcproj/WebCore.vcproj: Removed ENABLE_VIDEO.
* WebCore.vcproj/build-generated-files.sh: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29050
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 31 Dec 2007 07:48:54 +0000 (07:48 +0000)]
2007-12-30 Alp Toker <alp@atoker.com>
Reviewed by Dan Bernstein.
Silence warning.
* dom/NodeList.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Mon, 31 Dec 2007 07:06:01 +0000 (07:06 +0000)]
Reviewed by Darin.
Bug 16578: Windows Web Inspector window needs minimum size
http://bugs.webkit.org/show_bug.cgi?id=16578
* WebInspectorClient.cpp:
(WebInspectorClient::onGetMinMaxInfo):
(WebInspectorWndProc):
* WebInspectorClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 31 Dec 2007 07:03:31 +0000 (07:03 +0000)]
Reviewed by Sam.
More small cleanup to array_object.cpp
* kjs/array_object.cpp:
(KJS::ArrayProtoFuncToString::callAsFunction):
(KJS::ArrayProtoFuncToLocaleString::callAsFunction):
(KJS::ArrayProtoFuncJoin::callAsFunction):
(KJS::ArrayProtoFuncConcat::callAsFunction):
(KJS::ArrayProtoFuncReverse::callAsFunction):
(KJS::ArrayProtoFuncShift::callAsFunction):
(KJS::ArrayProtoFuncSlice::callAsFunction):
(KJS::ArrayProtoFuncSort::callAsFunction):
(KJS::ArrayProtoFuncSplice::callAsFunction):
(KJS::ArrayProtoFuncUnShift::callAsFunction):
(KJS::ArrayProtoFuncFilter::callAsFunction):
(KJS::ArrayProtoFuncMap::callAsFunction):
(KJS::ArrayProtoFuncEvery::callAsFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 31 Dec 2007 07:03:05 +0000 (07:03 +0000)]
Reviewed by Sam.
Apply wkstyle to array_object.cpp
* kjs/array_object.cpp:
(KJS::ArrayPrototype::ArrayPrototype):
(KJS::ArrayPrototype::getOwnPropertySlot):
(KJS::ArrayProtoFuncConcat::callAsFunction):
(KJS::ArrayProtoFuncPop::callAsFunction):
(KJS::ArrayProtoFuncReverse::callAsFunction):
(KJS::ArrayProtoFuncShift::callAsFunction):
(KJS::ArrayProtoFuncSlice::callAsFunction):
(KJS::ArrayProtoFuncSort::callAsFunction):
(KJS::ArrayProtoFuncSplice::callAsFunction):
(KJS::ArrayProtoFuncUnShift::callAsFunction):
(KJS::ArrayProtoFuncFilter::callAsFunction):
(KJS::ArrayProtoFuncMap::callAsFunction):
(KJS::ArrayProtoFuncEvery::callAsFunction):
(KJS::ArrayProtoFuncLastIndexOf::callAsFunction):
(KJS::ArrayObjectImp::ArrayObjectImp):
(KJS::ArrayObjectImp::implementsConstruct):
(KJS::ArrayObjectImp::construct):
(KJS::ArrayObjectImp::callAsFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 31 Dec 2007 07:02:26 +0000 (07:02 +0000)]
Reviewed by Sam.
Remove maxInt/minInt, replacing with std:max/min<int>()
* kjs/array_object.cpp:
(KJS::ArrayProtoFuncSplice::callAsFunction):
* kjs/operations.cpp:
* kjs/operations.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 31 Dec 2007 07:02:05 +0000 (07:02 +0000)]
WebCore:
Reviewed by Oliver Hunt.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16387
Variable names can be enumerated across domains
<rdar://problem/
5640454>
Test: http/tests/security/cross-frame-access-enumeration.html
* bindings/js/kjs_window.cpp:
(KJS::Window::getPropertyNames): Override method to test same-origin policy.
* bindings/js/kjs_window.h:
LayoutTests:
Reviewed by Oliver Hunt.
Test for http://bugs.webkit.org/show_bug.cgi?id=16387
* http/tests/security/cross-frame-access-enumeration-expected.txt: Added.
* http/tests/security/cross-frame-access-enumeration.html: Added.
* http/tests/security/resources/cross-frame-iframe-for-enumeration-test.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 31 Dec 2007 07:01:44 +0000 (07:01 +0000)]
Reviewed by Sam.
* Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 31 Dec 2007 06:37:16 +0000 (06:37 +0000)]
- added missing results file
* fast/events/event-instanceof-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 30 Dec 2007 22:24:47 +0000 (22:24 +0000)]
WebCore:
Reviewed by Oliver Hunt.
Patch for http://bugs.webkit.org/show_bug.cgi?id=10686
event instanceof MouseEvent throws exception
Add JS constructors for all the Event types.
Test: fast/events/event-instanceof.html
* WebCore.xcodeproj/project.pbxproj:
* dom/KeyboardEvent.idl:
* dom/MouseEvent.idl:
* dom/MutationEvent.idl:
* dom/OverflowEvent.idl:
* dom/ProgressEvent.idl:
* dom/TextEvent.idl:
* dom/UIEvent.idl:
* dom/WheelEvent.idl:
* page/DOMWindow.idl:
LayoutTests:
Reviewed by Oliver Hunt.
Test for http://bugs.webkit.org/show_bug.cgi?id=10686
event instanceof MouseEvent throws exception
* fast/dom/Window/window-properties-expected.txt:
* fast/events/event-instanceof.html: Added.
* fast/events/resources/event-instanceof.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 30 Dec 2007 17:44:37 +0000 (17:44 +0000)]
2007-12-30 Alp Toker <alp@atoker.com>
Build fix for older autoconf versions.
* configure.ac:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sun, 30 Dec 2007 17:05:52 +0000 (17:05 +0000)]
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=15359
JPEG image not shown when height is specified as percentage inside a table
The problem occurs when a replaced element (image, canvas, etc.) with
a percent-height attribute is contained by a table cell with an auto-
or percent-height attribute. If there are no other conditions to cause
the table cell's height to expand, an available height of zero will
always be returned. In these cases, the intrinsic height of the
replaced element should be used if it is greater than the available
height of the table cell.
Tests: fast/replaced/table-percent-height.html
tables/mozilla/bugs/bug137388-1.html
tables/mozilla/bugs/bug137388-2.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcReplacedHeightUsing):
LayoutTests:
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=15359
JPEG image not shown when height is specified as percentage inside a table
This test was added specifically for this bug. It tests the height of
replaced elements (canvas, embed, img, object, button, input, isindex,
select, textarea ) within table cells.
* fast/replaced/table-percent-height-expected.txt: Added.
* fast/replaced/table-percent-height.html: Added.
These test results were updated because they are more correct.
* platform/mac/fast/replaced/width100percent-image-expected.checksum: Updated.
* platform/mac/fast/replaced/width100percent-image-expected.png: Updated.
* platform/mac/fast/replaced/width100percent-image-expected.txt: Updated.
Moved tests and results for these two tests from tables/mozilla_expected_failures/bugs
to tables/mozilla/bugs since these results have been fixed.
* platform/mac/tables/mozilla/bugs/bug137388-1-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum.
* platform/mac/tables/mozilla/bugs/bug137388-1-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.png.
* platform/mac/tables/mozilla/bugs/bug137388-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt.
* platform/mac/tables/mozilla/bugs/bug137388-2-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum.
* platform/mac/tables/mozilla/bugs/bug137388-2-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.png.
* platform/mac/tables/mozilla/bugs/bug137388-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt.
* platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum: Removed.
* platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.png: Removed.
* platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt: Removed.
* platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum: Removed.
* platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.png: Removed.
* platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt: Removed.
* tables/mozilla/bugs/bug137388-1.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug137388-1.html.
* tables/mozilla/bugs/bug137388-2.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug137388-2.html.
* tables/mozilla_expected_failures/bugs/bug137388-1.html: Removed.
* tables/mozilla_expected_failures/bugs/bug137388-2.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 30 Dec 2007 16:21:36 +0000 (16:21 +0000)]
2007-12-30 Mark Rowe <mrowe@apple.com>
Unreviewed. Update WordPress to 2.3.2, which includes security fixes.
* blog/wp-admin/admin.php:
* blog/wp-admin/includes/file.php:
* blog/wp-admin/install.php:
* blog/wp-admin/setup-config.php:
* blog/wp-app.php:
* blog/wp-includes/formatting.php:
* blog/wp-includes/functions.php:
* blog/wp-includes/pluggable.php:
* blog/wp-includes/post.php:
* blog/wp-includes/query.php:
* blog/wp-includes/taxonomy.php:
* blog/wp-includes/version.php:
* blog/wp-includes/wp-db.php:
* blog/wp-mail.php:
* blog/wp-settings.php:
* blog/xmlrpc.php:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 30 Dec 2007 11:52:03 +0000 (11:52 +0000)]
2007-12-30 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16099
Crash in CURL for empty POST
We have to set POST even when the data is empty, otherwise cURL will
hang while waiting for a response.
* platform/network/curl/ResourceHandleManager.cpp
(ResourceHandleManager::setupPOST): allow empty POST
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sun, 30 Dec 2007 08:38:39 +0000 (08:38 +0000)]
Reviewed by Sam.
Update Number.toString to properly throw exceptions.
Cleanup code in Number.toString implementation.
* kjs/number_object.cpp:
(KJS::numberToString):
* kjs/object.cpp:
(KJS::Error::create): Remove bogus debug lines.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 30 Dec 2007 06:47:16 +0000 (06:47 +0000)]
2007-12-29 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
Enable Database, XPath and XSLT features by default
Move all SVG related stuff inside SVG block. Don't include
SVGNames, SVGElementFactory, and XLinkNames when SVG is not
enabled
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sun, 30 Dec 2007 06:13:40 +0000 (06:13 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14428
FCKEditor: Images disappear on drag/drop and copy/paste
Test: editing/pasteboard/drag-image-in-about-blank-frame.html
* editing/markup.cpp: (WebCore::createFragmentFromMarkup): Don't use "about:blank" as a
base URL, just like we don't use an empty one.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 30 Dec 2007 03:33:44 +0000 (03:33 +0000)]
2007-12-29 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16669
autotools update and fixes
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 30 Dec 2007 00:33:20 +0000 (00:33 +0000)]
Reviewed by Oliver.
- fix http://bugs.webkit.org/show_bug.cgi?id=16663
leak bot shows createCStringFromNPVariant result leaking
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginInvoke): Added a missing free.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 29 Dec 2007 16:06:23 +0000 (16:06 +0000)]
Reviewed by Alexey.
Respect horiz-origin-x / horiz-origin-y / vert-origin-x / vert-origin-y properties when drawing SVG Fonts.
(Fixes fonts-elem-05-t.svg in a --svg-fonts build)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 29 Dec 2007 14:00:56 +0000 (14:00 +0000)]
2007-12-29 Alp Toker <alp@atoker.com>
Fix typo.
* hosted/sunspider.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 29 Dec 2007 13:50:15 +0000 (13:50 +0000)]
Reviewed by Oliver.
Further SVG Font work. Parse all <glyph> attributes, using SVGGlyphElement::buildGlyphIdentifier.
SVGFontElement::collectGlyphs() now uses this method. Per character advance values work well now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 29 Dec 2007 13:03:59 +0000 (13:03 +0000)]
2007-12-29 Alp Toker <alp@atoker.com>
Reviewed by Maciej.
Provide the current URL in the SunSpider results page. Useful for
copying benchmark results out of browsers without a location bar or
where the location bar can't handle long URLs.
* hosted/sunspider-results.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 29 Dec 2007 12:50:57 +0000 (12:50 +0000)]
Reviewed by Oliver.
Refactor SVGAnimationElement::parseValues into a generic function parseDelimitedString.
SVGAnimationElement needs to parse semicolon-seperated strings, SVGGlyphElement comma-seperated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 29 Dec 2007 11:59:50 +0000 (11:59 +0000)]
Reviewed by Maciej.
Add new helper structure SVGFontData - FontData holds this object as OwnPtr.
Store several attribute values there (horiz-adv-x, horiz-origin-x etc..)
To optimize for the common case ('FontData' used for HTML rendering) it feels
better to hold one OwnPtr in FontData, than several floats.
Parse all <font> attributes in SVGFontFaceElement::createFontData.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 29 Dec 2007 07:42:17 +0000 (07:42 +0000)]
- try to fix Windows and WX builds (broken by SVG Fonts check-in)
* platform/graphics/win/FontWin.cpp:
(WebCore::Font::drawGlyphs): Pass font size to FontData::ascent, now that it requires it.
I can't see how it can be right to require the font size for ascent and descent,
but not for other metrics functions in FontData.
* platform/graphics/wx/FontWx.cpp:
(WebCore::Font::drawGlyphs): Pass font size to FontData::ascent and FontData::descent.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sat, 29 Dec 2007 07:35:17 +0000 (07:35 +0000)]
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=15734
fast/xpath/namespace-vs-predicate.xhtml fails unexpectedly in no-SVG build
* fast/xpath/namespace-vs-predicate.xhtml: Use (hopefully) correct code to remove an SVG element.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 29 Dec 2007 07:27:29 +0000 (07:27 +0000)]
- checked in these files that were supposed to be part of
the previous check-in, but somehow weren't
* fast/js/number-tofixed-expected.txt: Updated.
* fast/js/number-toprecision-expected.txt: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 29 Dec 2007 05:51:32 +0000 (05:51 +0000)]
2007-12-28 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
ASSERT when debugging via Drosera due to missed var lookup optimization.
http://bugs.webkit.org/show_bug.cgi?id=16634
No test case possible.
* kjs/nodes.cpp:
(KJS::BreakpointCheckStatement::optimizeVariableAccess):
* kjs/nodes.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 29 Dec 2007 04:19:30 +0000 (04:19 +0000)]
Reviewed by Mark Rowe.
- fix http://bugs.webkit.org/show_bug.cgi?id=16650
<rdar://problem/
5664872> REGRESSION (r28278-r28314): ATSUI uses LTR writing direction for all text runs
Covered by existing pixel tests.
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawComplexText): Corrected to maintain the style
information in the adjusted text run when passing it to
ATSUILayoutParameters. Prior to r28298 the style was passed separately.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 29 Dec 2007 04:01:13 +0000 (04:01 +0000)]
Reviewed by Oliver.
Fix (-0).toFixed() and re-factor a little
Fix (-0).toExponential() and printing of trailing 0s in toExponential
Fix toPrecision(nan) handling
* kjs/number_object.cpp:
(KJS::numberToFixed):
(KJS::fractionalPartToString):
(KJS::numberToExponential):
(KJS::numberToPrecision):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 29 Dec 2007 03:27:31 +0000 (03:27 +0000)]
Build fix, not reviewed.
Add wtf/OwnPtr.h include, to fix --svg-fonts build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 29 Dec 2007 03:17:11 +0000 (03:17 +0000)]
Reviewed by Sam.
More changes to make number code readable
* kjs/number_object.cpp:
(KJS::integer_part_noexp):
(KJS::numberToFixed):
(KJS::numberToExponential):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 29 Dec 2007 03:16:43 +0000 (03:16 +0000)]
Reviewed by Sam.
More small cleanups to toPrecision
* kjs/number_object.cpp:
(KJS::numberToPrecision):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 29 Dec 2007 03:16:13 +0000 (03:16 +0000)]
Reviewed by Sam.
More small attempts to make number code readable
* kjs/number_object.cpp:
(KJS::exponentialPartToString):
(KJS::numberToExponential):
(KJS::numberToPrecision):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 29 Dec 2007 03:15:39 +0000 (03:15 +0000)]
2007-12-28 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Break out callAsFunction implementations into static functions
* kjs/number_object.cpp:
(KJS::numberToString):
(KJS::numberToFixed):
(KJS::numberToExponential):
(KJS::numberToPrecision):
(KJS::NumberProtoFunc::callAsFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 29 Dec 2007 03:14:52 +0000 (03:14 +0000)]
Reviewed by Sam.
Apply wkstyle/astyle and fix placement of *
* kjs/number_object.cpp:
(KJS::):
(KJS::NumberInstance::NumberInstance):
(KJS::NumberPrototype::NumberPrototype):
(KJS::NumberProtoFunc::NumberProtoFunc):
(KJS::integer_part_noexp):
(KJS::intPow10):
(KJS::NumberProtoFunc::callAsFunction):
(KJS::NumberObjectImp::NumberObjectImp):
(KJS::NumberObjectImp::getOwnPropertySlot):
(KJS::NumberObjectImp::getValueProperty):
(KJS::NumberObjectImp::implementsConstruct):
(KJS::NumberObjectImp::construct):
(KJS::NumberObjectImp::callAsFunction):
* kjs/object.cpp:
(KJS::JSObject::put):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 29 Dec 2007 02:48:38 +0000 (02:48 +0000)]
2007-12-28 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16642
[GTK] webkit_web_view_has_selection returns the opposite result
Invert the return value.
* WebView/webkitwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 29 Dec 2007 02:41:53 +0000 (02:41 +0000)]
Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10649 (WebKit SVG needs SVG Fonts support)
Begin implementation of SVG Fonts module. Basic documents using SVG Fonts already work.
Only local, in-document fonts who declare their glyphs using the <glyph d="..."> path syntax
are supported. (<glyph> containing arbitary SVG content as child elements, not supported yet).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 28 Dec 2007 07:50:44 +0000 (07:50 +0000)]
Reviewed by Alexey Proskuryakov.
- fix http://bugs.webkit.org/show_bug.cgi?id=16628
ASSERTION FAILED: m_resizeLayer (running layout tests)
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::~RenderLayer): Avoid calling
EventHandler::resizeLayerDestroyed() if the document is being destroyed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 28 Dec 2007 03:22:42 +0000 (03:22 +0000)]
WebCore:
Reviewed by Oliver Hunt.
- fix http://bugs.webkit.org/show_bug.cgi?id=16603
<rdar://problem/
5664199> Crash when resizing text field
Test: fast/layers/resize-layer-deletion-crash.html
The event handler has only a weak reference to the layer that is
currently in resize mode, so it is the layer's responsibility to let
the event handler know if it has been destroyed while in that mode.
* page/EventHandler.cpp:
(WebCore::EventHandler::resizeLayerDestroyed): Added. Resets
m_resizeLayer to 0.
* page/EventHandler.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::~RenderLayer): Added a call to
EventHandler::resizeLayerDestroyed() if the layer is in resize mode.
LayoutTests:
Reviewed by Oliver Hunt.
- test for http://bugs.webkit.org/show_bug.cgi?id=16603
<rdar://problem/
5664199> Crash when resizing text field
* fast/layers/resize-layer-deletion-crash-expected.txt: Added.
* fast/layers/resize-layer-deletion-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 28 Dec 2007 01:25:22 +0000 (01:25 +0000)]
Reviewed by Alice Liu.
* platform/win/Skipped: Remove xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame.html
since it is now passing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 28 Dec 2007 00:57:51 +0000 (00:57 +0000)]
WebCore:
Reviewed by Sam Weinig.
http://bugs.webkit.org/show_bug.cgi?id=16539
<rdar://problem/
5659269>
The same-origin check was missing in the implementation of
setTimeout, setInterval, addEventListener, and removeEventListener.
Suppose <http://www.badguy.com/> contains an iframe to
<http://www.goodguy.com/>. Now www.badguy.com can steal
www.goodguy.com cookies by running this code:
setTimeout.call(frames[0], "alert(document.cookie)", 1000);
This patch changes the behavior so that setTimeout to does
nothing and returns an undefined value if the caller is not
permitted to script the window whose setTimeout method is being
called. The same applies to setInterval, addEventListener, and
removeEventListener.
Tests: http/tests/security/cross-frame-access-call.html
* bindings/js/kjs_window.cpp:
(KJS::WindowProtoFuncSetTimeout::callAsFunction)
(KJS::WindowProtoFuncSetInterval::callAsFunction)
(KJS::WindowProtoFuncAddEventListener::callAsFunction)
(KJS::WindowProtoFuncRemoveEventListener::callAsFunction)
LayoutTests:
Reviewed by Sam Weinig.
Tests for http://bugs.webkit.org/show_bug.cgi?id=16539
<rdar://problem/
5659269>
* http/tests/security/cross-frame-access-call-expected.txt: Added.
* http/tests/security/cross-frame-access-call.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 28 Dec 2007 00:11:46 +0000 (00:11 +0000)]
WebCore:
Reviewed by Dave Hyatt and Sam Weinig.
- fix <rdar://problem/
5605937> Inspector: Disclosure triangle not drawn in node's properties panel until click
Test: fast/layers/add-layer-with-nested-stacking.html
Test: fast/layers/remove-layer-with-nested-stacking.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::addChild): If the new child is overflow-only
but has children of its own, dirty the stacking context's z-order lists
since the grandchildren might need to be in them.
(WebCore::RenderLayer::removeChild): Similarly for the old child.
LayoutTests:
Reviewed by Dave Hyatt and Sam Weinig.
- pixel tests for <rdar://problem/
5605937> Inspector: Disclosure triangle not drawn in node's properties panel until click
* fast/layers/add-layer-with-nested-stacking.html: Added.
* fast/layers/remove-layer-with-nested-stacking.html: Added.
* platform/mac/fast/layers/add-layer-with-nested-stacking-expected.checksum: Added.
* platform/mac/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
* platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.checksum: Added.
* platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
* platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 27 Dec 2007 23:14:27 +0000 (23:14 +0000)]
2007-12-27 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16353
[GTK] Check for deprecated API use (G_DISABLE_DEPRECATED etc.)
Added the flags mentioned in the bug only when doing 'debug'
builds. -DGST_DISABLE_DEPRECATED only added when video is enabled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 27 Dec 2007 22:20:18 +0000 (22:20 +0000)]
Reviewed by Sam.
ASSERT in JavaScriptCore while viewing WICD test case
http://bugs.webkit.org/show_bug.cgi?id=16626
* kjs/nodes.cpp:
(KJS::ForInNode::execute): move KJS_CHECK_EXCEPTION to proper place
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 27 Dec 2007 21:58:06 +0000 (21:58 +0000)]
Reviewed by Alice Liu.
* platform/mac-leopard/Skipped: Remove dom/html/level2/html/HTMLDocument12.html
from the Skipped list because it is now passing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 27 Dec 2007 20:55:41 +0000 (20:55 +0000)]
Fix typo in ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 27 Dec 2007 20:54:03 +0000 (20:54 +0000)]
WebCore:
Reviewed by Eric Seidel.
- fix http://bugs.webkit.org/show_bug.cgi?id=16490
ASSERT in ~FrameView while viewing/reloading WICD test case
Test: fast/dynamic/paused-event-dispatch.html
* page/FrameView.cpp:
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::layout): Changed to always pause event dispatch and
always resume event dispatch, regardless of whether the post-layout
task time is active. However, if it is active, assert that event
dispatch is still paused.
LayoutTests:
Reviewed by Eric Seidel.
- test for http://bugs.webkit.org/show_bug.cgi?id=16490
ASSERT in ~FrameView while viewing/reloading WICD test case
* fast/dynamic/paused-event-dispatch-expected.txt: Added.
* fast/dynamic/paused-event-dispatch.html: Added.
* fast/dynamic/resources/paused-event-dispatch-iframe.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 27 Dec 2007 16:54:15 +0000 (16:54 +0000)]
Add another feed to Planet WebKit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 27 Dec 2007 08:34:18 +0000 (08:34 +0000)]
Reviewed by Maciej.
* platform/win/Skipped: Move cross-frame-access-protocol* tests to show that they
are failing because of a lack of ssl on windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 27 Dec 2007 08:28:13 +0000 (08:28 +0000)]
Rubber-stamped by Maciej.
- Change more tests to use the new layoutTestController.globalFlag style polling instead
of the "flag frame hack".
* http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
* http/tests/security/cross-frame-access-port-expected.txt:
* http/tests/security/cross-frame-access-private-browsing-expected.txt:
* http/tests/security/cross-frame-access-protocol-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url.html:
* http/tests/security/host-compare-case-insensitive-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS.html:
* http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessee-iframe.html:
* http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessee-opened-frame.html:
* http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessor-iframe.html:
* http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessor-opened-frame.html:
* http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html:
* http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html:
* http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe.html:
* http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt:
* http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html:
* http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html:
* http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open.html:
* http/tests/security/protocol-compare-case-insensitive-expected.txt:
* http/tests/security/resources/cross-frame-iframe.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 27 Dec 2007 08:22:24 +0000 (08:22 +0000)]
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14500
need to be more generous about charset declaration with meta tag
http://bugs.webkit.org/show_bug.cgi?id=12526
<rdar://problem/
4867183> Safari ignores encoding description "charset=Shift_JIS" in invalid html
<rdar://problem/
4892428> Unlike other browsers, WebKit ignores <meta> charset definitions outside the head
<rdar://problem/
5643774> REGRESSION: Text is garbled when clicking a link inside an Arabic website
Tests: fast/encoding/ahram-org-eg.html
fast/encoding/bandai-co-jp-releases.html
fast/encoding/floraexpress-ru.html
fast/encoding/hanarei-blog32-fc2-com.html
fast/encoding/yahoo-mail.html
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::checkForHeadCharset): Don't stop looking for <meta> until we've
seen at least 512 bytes of input.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 27 Dec 2007 06:05:21 +0000 (06:05 +0000)]
2007-12-26 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16390
Use autotools or GNU make as the build system for the GTK port
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 27 Dec 2007 04:01:31 +0000 (04:01 +0000)]
Rubber-stamped by Anders Carlsson.
- re-categorize some SVG tests the are failing on Windows
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 27 Dec 2007 02:33:25 +0000 (02:33 +0000)]
Reviewed by Alice Liu.
Re-enable disabled tests with new polling logic using layoutTestController.globalFlag.
* http/tests/security/dataURL/resources/foreign-domain-data-url-accessee-iframe.html:
* http/tests/security/dataURL/resources/foreign-domain-data-url-accessee-opened-frame.html:
* http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
* http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-opened-frame.html:
* http/tests/security/dataURL/resources/foreign-domain-data-url-window-location.html:
* http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html-disabled.
* http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html-disabled: Removed.
* http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html-disabled.
* http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html-disabled: Removed.
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html-disabled.
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html-disabled: Removed.
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html-disabled.
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html-disabled: Removed.
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html-disabled.
* http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html-disabled: Removed.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Wed, 26 Dec 2007 23:55:23 +0000 (23:55 +0000)]
removing tests tracked by <rdar://
5463489> A number of layout tests should be using
execCommand instead of textInputController
* platform/win/Skipped:
removing tests fixed by http://trac.webkit.org/projects/webkit/changeset/28626
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28994
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 26 Dec 2007 22:16:10 +0000 (22:16 +0000)]
Reviewed by Sam Weinig.
http://bugs.webkit.org/show_bug.cgi?id=16609
Make manual-tests/xmlhttprequest-contenttype-empty.html test automatic
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28993
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 26 Dec 2007 09:25:27 +0000 (09:25 +0000)]
Windows build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28992
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Wed, 26 Dec 2007 08:40:55 +0000 (08:40 +0000)]
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=15514
<clipPath> with <use> not respected
http://bugs.webkit.org/show_bug.cgi?id=16557
SVG circle elements have been clipped away completely, instead of partially.
Add toClipPath to get clip path data for the clipping paths. Implement it for <use>, thereby allowing clip paths using use.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28991
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 26 Dec 2007 07:25:09 +0000 (07:25 +0000)]
Reviewed by Eric Seidel.
Clean up the files relating to NodeLists.
* dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::ChildNodeList):
(WebCore::ChildNodeList::length):
(WebCore::ChildNodeList::item):
(WebCore::ChildNodeList::nodeMatches):
* dom/ChildNodeList.h:
* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeList::itemForwardsFromCurrent):
(WebCore::DynamicNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicNodeList::itemWithName):
* dom/DynamicNodeList.h:
(WebCore::DynamicNodeList::needsNotifications):
* dom/NameNodeList.cpp:
(WebCore::NameNodeList::NameNodeList):
(WebCore::NameNodeList::rootNodeAttributeChanged):
(WebCore::NameNodeList::nodeMatches):
* dom/NameNodeList.h:
* dom/NodeList.h:
* dom/SelectorNodeList.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28990
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 26 Dec 2007 06:44:02 +0000 (06:44 +0000)]
Fix non-mac builds.
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCoreSources.bkl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 26 Dec 2007 06:33:37 +0000 (06:33 +0000)]
Rubber stamped by Eric Seidel.
Move TagNodeList into its own file.
* WebCore.xcodeproj/project.pbxproj:
* dom/Node.cpp:
* dom/TagNodeList.cpp: Copied from dom/Node.cpp.
(WebCore::TagNodeList::TagNodeList):
* dom/TagNodeList.h: Copied from dom/Node.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28988
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 26 Dec 2007 06:18:08 +0000 (06:18 +0000)]
Reviewed by Eric Seidel.
Simplify the NodeList architecture.
- Rename recursiveItem() to item(), since it is not recursive.
- Make recursiveLength() iterative and rename to length().
- Remove now unneeded overrides of item() and length() that used
to call the recursive variants.
* dom/ClassNodeList.cpp:
* dom/ClassNodeList.h:
* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeList::length):
(WebCore::DynamicNodeList::item):
(WebCore::DynamicNodeList::rootNodeAttributeChanged): Move implementation
into the .cpp file since virtual methods can't be inlined.
* dom/DynamicNodeList.h:
* dom/NameNodeList.cpp:
* dom/NameNodeList.h:
* dom/Node.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 26 Dec 2007 02:55:06 +0000 (02:55 +0000)]
2007-12-25 Alp Toker <alp@atoker.com>
More complete GTK+/Qt/Wx/Win build fixes for breakage introduced in
r28981.
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCoreSources.bkl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28986
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 26 Dec 2007 02:33:44 +0000 (02:33 +0000)]
2007-12-25 Alp Toker <alp@atoker.com>
Win build fix for breakage introduced in r28981.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 26 Dec 2007 02:30:39 +0000 (02:30 +0000)]
2007-12-25 Alp Toker <alp@atoker.com>
Wx build fix for breakage introduced in r28981.
* WebCoreSources.bkl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28984
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 26 Dec 2007 02:28:12 +0000 (02:28 +0000)]
2007-12-25 Alp Toker <alp@atoker.com>
GTK+/Qt build fix for breakage introduced in r28981.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 26 Dec 2007 01:05:55 +0000 (01:05 +0000)]
Reviewed by Oliver Hunt.
- fix an assertion failure when pressing the num lock key
* WebView/WebHTMLView.mm:
(-[WebHTMLView flagsChanged:]): Avoid passing key code 10 down to
WebCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dsmith@webkit.org [Wed, 26 Dec 2007 00:46:46 +0000 (00:46 +0000)]
WebCore:
Reviewed by Oliver.
- http://bugs.webkit.org/show_bug.cgi?id=16587
Implement the most useful part of the W3C Selectors API.
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.h: Make Node a friend of CSSStyleSelector so it can use checkSelector()
* dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::ChildNodeList): Change to being a DynamicNodeList
* dom/ChildNodeList.h:
* dom/ClassNodeList.cpp:
(WebCore::ClassNodeList::ClassNodeList): Change to being a DynamicNodeList
* dom/ClassNodeList.h:
* dom/Document.idl: Add the new functions
* dom/DynamicNodeList.cpp: Copied from WebCore/dom/NodeList.cpp.
(WebCore::DynamicNodeList::DynamicNodeList): Rename NodeList to DynamicNodeList, to differentiate it from the new StaticNodeList
(WebCore::DynamicNodeList::~DynamicNodeList):
(WebCore::DynamicNodeList::recursiveLength):
(WebCore::DynamicNodeList::itemForwardsFromCurrent):
(WebCore::DynamicNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicNodeList::recursiveItem):
(WebCore::DynamicNodeList::itemWithName):
(WebCore::DynamicNodeList::rootNodeChildrenChanged):
(WebCore::DynamicNodeList::Caches::Caches):
(WebCore::DynamicNodeList::Caches::reset):
* dom/DynamicNodeList.h: Copied from WebCore/dom/NodeList.h.
(WebCore::DynamicNodeList::rootNodeAttributeChanged):
* dom/Element.idl: Add the new functions
* dom/NameNodeList.cpp: Change to being a DynamicNodeList
(WebCore::NameNodeList::NameNodeList):
* dom/NameNodeList.h:
(WebCore::NameNodeList::rootNodeAttributeChanged):
* dom/Node.cpp:
(WebCore::TagNodeList::TagNodeList): Change to being a DynamicNodeList
(WebCore::Node::registerDynamicNodeList):
(WebCore::Node::unregisterDynamicNodeList):
(WebCore::Node::getElementsByName):
(WebCore::Node::getElementsByClassName):
(WebCore::Node::querySelector): new
(WebCore::Node::querySelectorAll): new
* dom/Node.h:
* dom/NodeList.cpp: Removed.
* dom/NodeList.h: This is now an abstract superclass of DynamicNodeList and StaticNodeList
(WebCore::NodeList::NodeList):
(WebCore::NodeList::~NodeList):
* dom/SelectorNodeList.cpp: Added.
(WebCore::SelectorNodeList::SelectorNodeList): New StaticNodeList subclass that filters elements by CSS selector
* dom/SelectorNodeList.h: Added.
* dom/StaticNodeList.cpp: Added.
(WebCore::StaticNodeList::length):
(WebCore::StaticNodeList::item):
(WebCore::StaticNodeList::itemWithName):
* dom/StaticNodeList.h: Added.
(WebCore::StaticNodeList::StaticNodeList):
(WebCore::StaticNodeList::~StaticNodeList):
LayoutTests:
Reviewed by Oliver.
- http://bugs.webkit.org/show_bug.cgi?id=16587
Implement the most useful part of the W3C Selectors API.
* fast/dom/SelectorAPI: Copied from LayoutTests/fast/dom/getElementsByClassName.
* fast/dom/SelectorAPI/dumpNodeList-expected.txt:
* fast/dom/SelectorAPI/dumpNodeList.html: Modified to test querySelector and querySelectorAll instead of getElementsByClassName
* fast/dom/Window/window-properties-expected.txt: Added querySelector and querySelectorAll
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 25 Dec 2007 22:54:10 +0000 (22:54 +0000)]
Reviewed by Oliver.
- Remove unnecessary redundant check from property setting
http://bugs.webkit.org/show_bug.cgi?id=16602
1.3% speedup on SunSpider.
* kjs/object.cpp:
(KJS::JSObject::put): Don't do canPut check when not needed; let
the PropertyMap handle it.
(KJS::JSObject::canPut): Don't check the static property
table. lookupPut does that already.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 25 Dec 2007 06:55:23 +0000 (06:55 +0000)]
Fix Bug 16596: ThreadSafeShared should be lock-free where possible.
Reviewed by Sam Weinig.
Implement a lock-free ThreadSafeShared for i386, x86_64, ppc and ppc64.
This is a 1.7x as fast as the lock-based implementation on x86 for a single-threaded use
of ThreadSafeShared but is closer to 280x as fast when there is heavy concurrent multi-threaded
access to a single ThreadSafeShared object.
The atomic operations are based on those used by the Boost C++ library's shared_ptr implementation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 25 Dec 2007 06:00:20 +0000 (06:00 +0000)]
2007-12-24 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp Toker.
http://bugs.webkit.org/attachment.cgi?id=18099
There are no NULL checks for strings in public api
Add missing NULL checks for string parameters.
Provide sensible defaults when NULL is passed for the optional
parameters in webkit_web_view_load_string(). UTF-8 is the default
encoding used by GLib and text/html is a reasonable default content
type.
* WebView/webkitnetworkrequest.cpp:
* WebView/webkitwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 25 Dec 2007 01:05:45 +0000 (01:05 +0000)]
* platform/text/PlatformString.h: Removed now-incorrect comment.
Added a comment about copy().
* platform/text/StringImpl.h: Added a comment about copy().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 25 Dec 2007 01:02:28 +0000 (01:02 +0000)]
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=16550
make StringImpl immutable
I tried to keep the changes to a minimum. In some cases there is
room for optimization -- I didn't try to add in the "single ref count"
optimizations and there might be a tiny bit more string copying than
we had before.
* WebCore.base.exp: Updated.
* dom/CharacterData.cpp:
(WebCore::CharacterData::appendData): Changed to use String since
StringImpl doesn't have mutating functions any more.
(WebCore::CharacterData::insertData): Ditto.
(WebCore::CharacterData::deleteData): Ditto.
(WebCore::CharacterData::replaceData): Ditto.
* dom/Text.cpp:
(WebCore::Text::splitText): Changed to use substring instead of
remove since StringImpl does't have mutating functions any more.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::deleteInsignificantText): Changed
to use String instead of StringImpl so we can use remove.
* platform/text/PlatformString.h: Removed newUninitialized.
Added append that takes a character pointer and length.
* platform/text/String.cpp:
(WebCore::String::insert): Added an implementation that does not
rely on an underlying StringImpl function.
(WebCore::String::append): Ditto.
(WebCore::String::truncate): Ditto.
(WebCore::String::remove): Ditto.
(WebCore::String::charactersWithNullTermination): Added an
implementation that uses the new StringImpl null termination feature,
which does not require modifying a string.
* platform/text/StringImpl.cpp:
(WebCore::isSpace): Fix comment.
(WebCore::StringImpl::StringImpl): Added a new constructor that makes
a string with a trailing null character.
(WebCore::StringImpl::substring): Marked const.
(WebCore::StringImpl::replace): Marked const; had to add quite a few
const_cast. Also rewrote one of these to work without modifying the
existing string.
* platform/text/StringImpl.h: Fixed a mistake where the empty string had
m_hasTerminatingNullCharacter uninitialized. Added a type and constructor
for creating strings that have a trailing null character. Added a
hasTerminatingNullCharacter function. Removed newUninitialized,
charactersWithNullTermination, append, insert, truncate, and remove.
Marked lots of other functions const.
* platform/text/TextCodecLatin1.cpp:
(WebCore::TextCodecLatin1::decode): Rewrote to use a Vector instead of
newUninitialized.
* platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::decode): Ditto.
* platform/text/TextCodecUserDefined.cpp:
(WebCore::TextCodecUserDefined::decode): Ditto.
* rendering/RenderStyle.cpp:
(WebCore::RenderStyle::setContent): Changed to use String since
StringImpl doesn't have mutating functions any more.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 24 Dec 2007 18:31:32 +0000 (18:31 +0000)]
2007-12-24 Alp Toker <alp@atoker.com>
Fix builds that don't use AllInOneFile.cpp following breakage
introduced in r28973.
* kjs/grammar.y:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Mon, 24 Dec 2007 12:16:53 +0000 (12:16 +0000)]
Reviewed by Oliver.
Fix fast/events/arrow-keys-on-body.html, failing on Windows.
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
of 1, even though WebKit currently ignores it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Mon, 24 Dec 2007 10:13:00 +0000 (10:13 +0000)]
Reviewed by Eric.
- Optimize variable declarations
http://bugs.webkit.org/show_bug.cgi?id=16585
3.5% speedup on SunSpider.
var statements now result in either assignments or empty statements.
This allows a couple of optimization opportunities:
- No need to branch at runtime to check if there is an initializer
- EmptyStatementNodes can be removed entirely (also done in this patch)
- Assignment expressions get properly optimized for local variables
This patch also includes some code cleanup:
- Most of the old VarStatement/VarDecl logic is now only used for const declarations,
thus it is renamed appropriately
- AssignExprNode is gone
* JavaScriptCore.exp:
* kjs/NodeInfo.h:
* kjs/grammar.y:
* kjs/nodes.cpp:
(KJS::SourceElements::append):
(KJS::ConstDeclNode::ConstDeclNode):
(KJS::ConstDeclNode::optimizeVariableAccess):
(KJS::ConstDeclNode::handleSlowCase):
(KJS::ConstDeclNode::evaluateSingle):
(KJS::ConstDeclNode::evaluate):
(KJS::ConstStatementNode::optimizeVariableAccess):
(KJS::ConstStatementNode::execute):
(KJS::VarStatementNode::optimizeVariableAccess):
(KJS::VarStatementNode::execute):
(KJS::ForInNode::ForInNode):
(KJS::ForInNode::optimizeVariableAccess):
(KJS::ForInNode::execute):
(KJS::FunctionBodyNode::initializeSymbolTable):
(KJS::ProgramNode::initializeSymbolTable):
(KJS::FunctionBodyNode::processDeclarations):
(KJS::ProgramNode::processDeclarations):
(KJS::EvalNode::processDeclarations):
* kjs/nodes.h:
(KJS::DeclarationStacks::):
(KJS::StatementNode::):
(KJS::ConstDeclNode::):
(KJS::ConstStatementNode::):
(KJS::EmptyStatementNode::):
(KJS::VarStatementNode::):
(KJS::ForNode::):
* kjs/nodes2string.cpp:
(KJS::ConstDeclNode::streamTo):
(KJS::ConstStatementNode::streamTo):
(KJS::ScopeNode::streamTo):
(KJS::VarStatementNode::streamTo):
(KJS::ForNode::streamTo):
(KJS::ForInNode::streamTo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Mon, 24 Dec 2007 06:39:08 +0000 (06:39 +0000)]
Fix Debug and Release QTMovieWin bulds.
* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/debug.vsprops:
* WebCore.vcproj/debug_internal.vsprops:
* WebCore.vcproj/release.vsprops:
Use LibraryConfigSuffix instead of WebKitConfigSuffix for pthreadVC2.
Build release import lib into \lib, not \bin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 24 Dec 2007 03:04:19 +0000 (03:04 +0000)]
2007-12-23 Alp Toker <alp@atoker.com>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=15382
[CAIRO] Canvas pattern support
http://bugs.webkit.org/show_bug.cgi?id=16577
Merge Cairo enhancements from Apollo project
Add support for canvas patterns.
Make Image::nativeImageForCurrentFrame() public.
Fix some typos along the way.
The globalAlpha canvas fixes are not included in this patch as
they're slightly more intrusive and may conflict conceptually with
GraphicsContext::setAlpha().
* html/CanvasPattern.cpp:
(WebCore::CanvasPattern::CanvasPattern):
(WebCore::CanvasPattern::~CanvasPattern):
(WebCore::CanvasPattern::createPattern):
* html/CanvasPattern.h:
(WebCore::CanvasPattern::platformImage):
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::applyShadow):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::applyStrokePattern):
(WebCore::CanvasRenderingContext2D::applyFillPattern):
* platform/graphics/Image.h:
(WebCore::Image::nativeImageForCurrentFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Mon, 24 Dec 2007 02:09:00 +0000 (02:09 +0000)]
Remove getWxBitmap as we have nativeImageForCurrentFrame now, and don't draw a border in fillRect.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 24 Dec 2007 00:47:05 +0000 (00:47 +0000)]
2007-12-23 Alp Toker <alp@atoker.com>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=16577
Merge Cairo enhancements from Apollo project
This patch is based on initial merging work by Brent Fulgham. Adobe's
code has been modified in a few places to better suit the existing
coding style.
Implement more clipping and drawing functions.
Save and restore the fill rule manually when clipping.
Avoid image surface creation when the image buffer has height zero.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::addPath):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipOutEllipseInRect):
(WebCore::GraphicsContext::fillRoundedRect):
* platform/graphics/cairo/ImageSourceCairo.cpp:
(WebCore::ImageSource::createFrameAtIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 23 Dec 2007 23:40:43 +0000 (23:40 +0000)]
- updated results (character used for controls changed in r28945)
* platform/mac/media/audio-controls-rendering-expected.txt: Regenerated.
* platform/mac/media/video-controls-rendering-expected.txt: Regenerated.
* platform/mac/media/video-display-toggle-expected.txt: Regenerated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sun, 23 Dec 2007 17:50:46 +0000 (17:50 +0000)]
wx buildbot fix. Update libpng dl script to the latest version.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sun, 23 Dec 2007 12:30:24 +0000 (12:30 +0000)]
Reviewed by Mark.
Fix wrong placed ifdef - wrapping SVGDefsElement, instead of SVGDefinitionSrcElement in SVG_FONTS block.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 23 Dec 2007 02:18:42 +0000 (02:18 +0000)]
2007-12-22 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
Use webView, web_view, etc for variable names instead of page, which
was left over from the old API.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 22 Dec 2007 23:54:16 +0000 (23:54 +0000)]
2007-12-22 Alp Toker <alp@atoker.com>
GTK+ build fix
GTK_TARGET_OTHER_APP is not available in older GTK+ versions. Pass
empty target flags for now.
Check GTK+, not GLib versions, since they are different.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc