15 years agoMark code coverage scripts as executable.
bdash [Sun, 8 Jul 2007 18:47:47 +0000 (18:47 +0000)]
Mark code coverage scripts as executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Sun, 8 Jul 2007 17:51:28 +0000 (17:51 +0000)]

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12384
          getComputedStyle with td.style.display='none' reports '' for all properties except display

        * fast/css/computed-style-without-renderer-expected.txt: Added.
        * fast/css/computed-style-without-renderer.html: Added.


        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12384
          getComputedStyle with td.style.display='none' reports '' for all properties except display

        Test: fast/css/computed-style-without-renderer.html

        Implement rich computed style for elements that do not have a renderer.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::getPositionOffsetValue): Changed to take a RenderStyle instead of
        a RenderObject.
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to
        use the computed style returned by the node instead of going through the
        renderer. Changed properties that compute by measuring the renderer to
        fall back on returning the length from the RenderStyle if a renderer does
        not exist.
        (WebCore::CSSComputedStyleDeclaration::length): Changed to return the number
        of properties we can compute even if the element has no renderer.
        (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): Changed
        to use the computed style returned by the node instead of going through the
        * dom/Element.cpp:
        (WebCore::ElementRareData::ElementRareData): Added a computed style member,
        used to cache computed style for elements that do not have a renderer.
        (WebCore::ElementRareData::resetComputedStyle): Added.
        (WebCore::Element::~Element): Delete the cached computed style.
        (WebCore::Element::recalcStyle): Added code to delete the cached computed
        style when necessary.
        (WebCore::Element::computedStyle): Added. Returns the style used in rendering
        the element, if available. Otherwise uses the style selector to compute style
        for the element.
        * dom/Element.h:
        * dom/Node.cpp:
        (WebCore::Node::computedStyle): Added. This method returns either the style
        used in rendering the node, or the style that would be used if the node
        had a renderer.
        * dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-08 Mitz Pettel <mitz@webkit.org>
bdash [Sun, 8 Jul 2007 17:40:54 +0000 (17:40 +0000)]
2007-07-08  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14544
          Scroll wheel events are ignored when the cursor is over an iframe's border

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::passWheelEventToWidget): Changed to return false if
        the event coordinates are not inside the widget's NSView hierarchy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
rwlbuis [Sun, 8 Jul 2007 15:37:19 +0000 (15:37 +0000)]
    Reviewed by Mitz.

        The inspector should not respond to Make Text Smaller/Bigger commands

        Use the -webkit-text-size-adjust property to ignore text sizing
        and do not take the zoom factor into account for line height when
        -webkit-text-size-adjust is set to none.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Sun, 8 Jul 2007 11:49:45 +0000 (11:49 +0000)]
    Reviewed by Maciej.

        - fix <rdar://problem/5318994> Integer overflow in WebCore's Base64.cpp:base64Encode

        * platform/Base64.cpp:
        (WebCore::base64Encode): Check against a maximum size.
        (WebCore::base64Decode): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Sun, 8 Jul 2007 11:47:01 +0000 (11:47 +0000)]

        Reviewed by Maciej.

        - fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check

        * platform/ThreadCheck.h: Renamed _WebCoreThreadViolationCheck to reportThreadViolation
        since it's in the WebCore namespace and also we shouldn't use leading underscores since
        those are reserved for the compiler and standard library. Added a new function named
        setDefaultThreadViolationBehavior and an enum for the parameter. Removed the
        threadViolationIsException parameter from WebCoreReportThreadViolation since we use
        a global variable for it now. Got rid of the unnecessary use of do while (0) in the
        WebCoreThreadViolationCheck macro -- since it's only a single function call it's already
        a statement and doesn't need to be turned into one with the do while (0) trick.

        * platform/mac/ThreadCheck.mm:
        (WebCore::readThreadViolationBehaviorFromUserDefaults): Moved the code to read from
        NSUserDefaults into this helper function. Changed it to use stringForKey instead of
        objectForKey so we don't get a "method not found" if someone puts something other than
        a string in there. Updated to use the new globals.
        (WebCore::setDefaultThreadViolationBehavior): Added.
        (WebCore::reportThreadViolation): Simplified, now that most of the work is in the
        readThreadViolationBehaviorFromUserDefaults function.
        (WebCoreReportThreadViolation): Changed to use a global variable instead of parameter
        to determine how to report a violation. Added LogOnFirstThreadViolation, which will
        log only once for each function that violates.

        * WebCore.exp: Updated for above changes.


        Reviewed by Maciej.

        - fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check


        * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): In first-time initialization block,
        check for binaries linked against older versions of WebKit, and set the default thread violation
        behavior to LogOnFirstThreadViolation.

        * WebView/WebView.mm: (+[WebView initialize]): Improved comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-08 Mitz Pettel <mitz@webkit.org>
bdash [Sun, 8 Jul 2007 09:54:42 +0000 (09:54 +0000)]
2007-07-08  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14221
          Repro crash (ASSERTION FAILED: oldText in RenderBlock::updateFirstLetter() during relayout of :before content with first-letter style)

        Test: fast/css-generated-content/before-with-first-letter.html

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::updateBeforeAfterContentForContainer): If a child
        of the existing 'before' container is not text, do not assume that it is an
        image, since it can also be an inline wrapping a first-letter. In that case,
        do not update its style (so in particular, keep it a FIRST_LETTER type style)
        and leave it to updateFirstLetter() to take care of.

2007-07-08  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=14221
          Repro crash (ASSERTION FAILED: oldText in RenderBlock::updateFirstLetter() during relayout of :before content with first-letter style)

        * fast/css-generated-content/before-with-first-letter-expected.checksum: Added.
        * fast/css-generated-content/before-with-first-letter-expected.png: Added.
        * fast/css-generated-content/before-with-first-letter-expected.txt: Added.
        * fast/css-generated-content/before-with-first-letter.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Sun, 8 Jul 2007 01:40:24 +0000 (01:40 +0000)]

        Reviewed by Oliver Hunt.

        - update results after removing extraneous calls to isSafeScript for
          readonly attributes.

        * http/tests/security/cross-frame-access-expected.txt:


        Reviewed by Oliver Hunt.

        Bailout early in Window::put() if attribute is readonly to avoid
        extra calls to isSafeScript().

        * bindings/js/kjs_window.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated results (I changed the test at the last minute, but didn't regenera...
darin [Sat, 7 Jul 2007 21:35:55 +0000 (21:35 +0000)]
    - updated results (I changed the test at the last minute, but didn't regenerate results)

        * fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Updated.
        * fast/canvas/fill-stroke-clip-reset-path-expected.png: Updated.
        * fast/canvas/fill-stroke-clip-reset-path-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Sat, 7 Jul 2007 20:42:50 +0000 (20:42 +0000)]

        - test for <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame

        * fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
        * fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
        * fast/canvas/fill-stroke-clip-reset-path-expected.txt: Added.
        * fast/canvas/fill-stroke-clip-reset-path.html: Added.


        Reviewed by Oliver Hunt.

        - fix <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame

        Updated Dashboard quirk so it affects fill, stroke, and clip, rather than just stroke.

        Test: fast/canvas/fill-stroke-clip-reset-path.html

        * html/CanvasRenderingContext2D.h: Added clearPathForDashboardBackwardCompatibilityMode.
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode): Added.
        (WebCore::CanvasRenderingContext2D::fill): Call the new function.
        (WebCore::CanvasRenderingContext2D::stroke): Replaced in-line code with a call to the new function.
        (WebCore::CanvasRenderingContext2D::clip): Call the new function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Sat, 7 Jul 2007 20:14:41 +0000 (20:14 +0000)]

        Reviewed by Darin.

        Testcase for:
        Canvas doesn't reset on resize

        * fast/canvas/canvas-resize-reset-expected.checksum: Added.
        * fast/canvas/canvas-resize-reset-expected.png: Added.
        * fast/canvas/canvas-resize-reset-expected.txt: Added.
        * fast/canvas/canvas-resize-reset.html: Added.


        Reviewed and tweaked by Darin.

        Canvas doesn't reset on resize

        Also reset the rendering context when resetting the canvas.

        * html/HTMLCanvasElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fixed a mismatch between test output and expected results (a typo that was...
ap [Sat, 7 Jul 2007 10:11:49 +0000 (10:11 +0000)]
    Fixed a mismatch between test output and expected results (a typo that was only fixed in the former).

        * fast/loader/early-load-cancel-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ap [Sat, 7 Jul 2007 10:00:38 +0000 (10:00 +0000)]
    Reviewed by Maciej.

        Support exslt:node-set()

        Test: fast/xsl/exslt-node-set.xml

        * xml/XSLTExtensions.cpp: Added.
        (WebCore::exsltNodeSetFunction): A copy of exslt:node-set() implementation
        from libexslt 1.1.11 (shipped with Tiger).
        (WebCore::registerXSLTExtensions): This function registers any WebCore-provided
        extensions on a context. Currently, the only extension is exslt:node-set().
        * xml/XSLTExtensions.h: Added.

        * xml/XSLTProcessor.cpp:
        Register extensions when creating a context.

        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Add XSLTExtensions.{h,cpp} to projects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Sat, 7 Jul 2007 06:29:08 +0000 (06:29 +0000)]

        Reviewed by Oliver.

        - test case for <rdar://problem/5133420> ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message

        * fast/loader/early-load-cancel-expected.txt: Added.
        * fast/loader/early-load-cancel.html: Added.
        * fast/loader/resources/early-load-cancel-inner.html: Added.


        Reviewed by Oliver.

        - fixed <rdar://problem/5133420> ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message

        test case: fast/loader/early-load-cancel.html

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::didCancel): Don't send cancel-related client callbacks
        if we never even sent willSendRequest because we were deferred.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-07 Mark Rowe <mrowe@apple.com>
bdash [Sat, 7 Jul 2007 04:28:37 +0000 (04:28 +0000)]
2007-07-07  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        * DumpRenderTree/DumpRenderTree.m:
        (convertWebResourceResponseToDictionary): Fix leak of two NSMutableString's introduced in r24076.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
oliver [Sat, 7 Jul 2007 04:01:28 +0000 (04:01 +0000)]

        Reviewed by Maciej.

        Pulled a number of methods from WebKit and WebCoreFrameBridge into
        C++ objects.

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * editing/Editor.cpp:
            From -[WebCoreFrameBridge replaceMarkedTextWithText:]
        * editing/Editor.h:
        * page/Frame.cpp:
            Pulled platform independent logic from Mac specific implementation
            Converted from -[WebHTMLView _selectRangeInMarkedText:]
        * page/Frame.h:
        * page/mac/FrameMac.mm:
            Now only does Mac specific logic when manipulating initial
        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:
            Removed -[WebCoreFrameBridge replaceMarkedTextWithText:]


        Reviewed by Maciej.

        <rdar://problem/5318756> Need to refactor IM/Marked text code to share logic with windows.

        Moved a number of methods from WebHTMLView into WebCore.
        Replaced bridge methods with calls directly into WebCore objects.

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView setMarkedText:selectedRange:]):
          Now calls WebCore object methods directly, rather than calling
          via the bridge.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-06 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 7 Jul 2007 02:37:27 +0000 (02:37 +0000)]
2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14545
          REGRESSION (r21854-r21869): Repro crash in RenderBlock::updateFirstLetter @ nola.com/rose/

        Test: fast/css/first-letter-capitalized.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter): Moved the call to setFirstLetter
        further down so that the first letter is not destroyed if a text transform
        is applied to the remaining text fragment when it is add to the render tree.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::previousCharacter): Factored out of setTextInternal.
        (WebCore::RenderText::setTextInternal): Changed to call previousCharacter().
        * rendering/RenderText.h:
        * rendering/RenderTextFragment.cpp:
        (WebCore::RenderTextFragment::previousCharacter): Override to return the
        character in the original string before the start of the fragment.
        * rendering/RenderTextFragment.h:

2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=14545
          REGRESSION (r21854-r21869): Repro crash in RenderBlock::updateFirstLetter @ nola.com/rose/

        * fast/css/first-letter-capitalized-expected.checksum: Added.
        * fast/css/first-letter-capitalized-expected.png: Added.
        * fast/css/first-letter-capitalized-expected.txt: Added.
        * fast/css/first-letter-capitalized.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-06 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 7 Jul 2007 02:35:07 +0000 (02:35 +0000)]
2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Beth.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14536
          Unnecessary layout done when mousing down in text field

        No test possible because there is no change in functionality.

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::setStyle): Reset the height and the width in
        the old style to avoid getting a layout hint as a result of having mutated
        the old style during layout.
        (WebCore::RenderTextControl::layout): Update children's layout if an inner
        block's dimensions should change. This need for layout was previously masked
        by the bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * mac/leopard/Skipped: Updated bug numbers for some bugs that were duplicates.
darin [Sat, 7 Jul 2007 01:02:28 +0000 (01:02 +0000)]
    * mac/leopard/Skipped: Updated bug numbers for some bugs that were duplicates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix builds that use IconDatabaseNone.cpp - better, this time
beidson [Sat, 7 Jul 2007 00:27:01 +0000 (00:27 +0000)]
    Fix builds that use IconDatabaseNone.cpp - better, this time

        * loader/icon/IconDatabaseNone.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix builds that use IconDatabaseNone.cpp
beidson [Sat, 7 Jul 2007 00:20:42 +0000 (00:20 +0000)]
    Fix builds that use IconDatabaseNone.cpp

        * loader/icon/IconDatabaseNone.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
thatcher [Fri, 6 Jul 2007 23:48:31 +0000 (23:48 +0000)]
    Reviewed by Adam.

        <rdar://problem/5313506> Some attributed string layout tests have an extra space character on Leopard

        Leopard serializes empty attribute dictionaries as "{ }", turn these into "{}" to match Tiger.

        * fast/text/attributed-substring-from-range-001.html:
        * mac/leopard/Skipped: Don't skip this test anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix typo.
thatcher [Fri, 6 Jul 2007 23:44:28 +0000 (23:44 +0000)]
Fix typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sullivan [Fri, 6 Jul 2007 23:43:08 +0000 (23:43 +0000)]

        Reviewed by Brady

        - WebCore part of fix for:
          <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files

        * loader/icon/IconDatabase.h:
        * loader/icon/IconDatabase.cpp:
        made this method const (necessary to make IconDatabase::databasePath const)
        new method, returns SQLDatabase's path if open, otherwise empty string

        * loader/icon/SQLDatabase.cpp:
        don't append a null character to the m_path ivar. The appended null character was making the path()
        method return a String with a trailing null, which is bad. However, there were no callers to the
        path() method until now. Instead of appending a null character to the ivar, use charactersWithNullTermination()
        instead of characters() when opening the database.

        * loader/icon/SQLDatabase.h:
        made this method const (necessary to make IconDatabase::databasePath const)
        made this method const (not required for these changes, but seemed worth doing at the same time)

        * WebCore.exp:
        added symbol for IconDatabase::databasePath


        Reviewed by Brady

        - WebKit part of fix for:
          <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files

        * Misc/WebIconDatabase.mm:
        (-[WebIconDatabase init]):
        Use CSBackupSetItemExcluded to tell Time Machine not to back up the icon database file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Fri, 6 Jul 2007 23:40:57 +0000 (23:40 +0000)]

        Reviewed by David Kilzer.

        Many webarchive tests fail due to different NSURLResponse serialization on Leopard

        * mac/leopard/Skipped:
        * webarchive/archive-with-unencoded-url-expected.txt:
        * webarchive/test-body-background-expected.txt:
        * webarchive/test-duplicate-resources-expected.txt:
        * webarchive/test-frameset-expected.txt:
        * webarchive/test-img-src-expected.txt:
        * webarchive/test-input-src-expected.txt:
        * webarchive/test-link-href-expected.txt:
        * webarchive/test-object-data-expected.txt:
        * webarchive/test-script-src-expected.txt:
        * webarchive/test-table-background-expected.txt:
        * webarchive/test-td-background-expected.txt:


        Reviewed by David Kilzer.

        Many webarchive tests fail due to different NSURLResponse serialization on Leopard

        Don't dump the serialized form of NSURLResponse. Instead, create a dictionary with the
        response's attributes. Also change the JavaScript MIME type to be "text/javascript".

        * DumpRenderTree/DumpRenderTree.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
thatcher [Fri, 6 Jul 2007 23:22:49 +0000 (23:22 +0000)]

        Reviewed by Oliver.

        <rdar://problem/5313506> Some attributed string layout tests have an extra space character on Leopard

        Don't dump the attributed string's description, this isn't helpfull for the test. Just log
        the attribute names at index 0, which we expect to be nothing, to make sure the string
        has no attributes.

        * fast/forms/attributed-strings-expected.txt:
        * fast/forms/attributed-strings.html:


        Reviewed by Oliver.

        Initlize the NSMutableAttributedString directly instead of creating
        a NSAttributedString first.

        * DumpRenderTree/TextInputController.m:
        (-[TextInputController attributedStringWithString:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agomissed in previous checkin
staikos [Fri, 6 Jul 2007 22:44:11 +0000 (22:44 +0000)]
missed in previous checkin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMove locatizations into another file.
staikos [Fri, 6 Jul 2007 22:36:39 +0000 (22:36 +0000)]
Move locatizations into another file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders Carlsson.
ggaren [Fri, 6 Jul 2007 21:54:22 +0000 (21:54 +0000)]
    Reviewed by Anders Carlsson.

        A little more FrameLoader cleanup while working on <rdar://problem/5126396>.

        Moved url() and URL() methods next to each other to highlight their subtlety.

        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Fri, 6 Jul 2007 21:37:56 +0000 (21:37 +0000)]

        Reviewed by David Kilzer.

        Update tests.

        * webarchive/archive-empty-frame-dom-expected.txt:
        * webarchive/archive-empty-frame-source-expected.txt:
        * webarchive/archive-with-unencoded-url-expected.txt:
        * webarchive/test-body-background-expected.txt:
        * webarchive/test-duplicate-resources-expected.txt:
        * webarchive/test-frameset-expected.txt:
        * webarchive/test-img-src-expected.txt:
        * webarchive/test-input-src-expected.txt:
        * webarchive/test-link-href-expected.txt:
        * webarchive/test-object-data-expected.txt:
        * webarchive/test-script-src-expected.txt:
        * webarchive/test-table-background-expected.txt:
        * webarchive/test-td-background-expected.txt:


        Reviewed by David Kilzer.

        Replace "Apple Computer" with "Apple" in the DTD declaration.

        * DumpRenderTree/DumpRenderTree.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders Carlsson.
ggaren [Fri, 6 Jul 2007 21:30:12 +0000 (21:30 +0000)]
    Reviewed by Anders Carlsson.

        A little FrameLoader cleanup while working on <rdar://problem/5126396>.

        Renamed endIfNotLoading() to endIfNotLoadingMainResource() because "loading"
        and "loadingMainResource" have distinct meanings and this function
        honors the latter.

        (WebCore::FrameLoader::endIfNotLoadingMainResource): Protect after the
        early return to avoid ref count churn.
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::isLoadingMainResource): Inlined this function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoPatch from Adam Treat to convert QWebFrame to a QFrame from a QAbstractScrollArea.
staikos [Fri, 6 Jul 2007 21:06:34 +0000 (21:06 +0000)]
Patch from Adam Treat to convert QWebFrame to a QFrame from a QAbstractScrollArea.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Fri, 6 Jul 2007 20:52:42 +0000 (20:52 +0000)]

        Reviewed by Mitz.

        REGRESSION: Can't access nested embed by document.name if object is not immediate parent

        * plugins/embed-inside-object-expected.txt: Added.
        * plugins/embed-inside-object.html: Added.


        Reviewed by Mitz.

        REGRESSION: Can't access nested embed by document.name if object is not immediate parent

        Traverse up the tree looking for an object element.

        * html/HTMLEmbedElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd another Leopard failure
aroben [Fri, 6 Jul 2007 20:29:41 +0000 (20:29 +0000)]
Add another Leopard failure

* mac/leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd another crasher to the Skipped file
aroben [Fri, 6 Jul 2007 18:11:16 +0000 (18:11 +0000)]
Add another crasher to the Skipped file

Also moved a test that had a bug filed about it out of the section of
unfiled failures.

* win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Alexey.
andersca [Fri, 6 Jul 2007 18:00:42 +0000 (18:00 +0000)]
    Reviewed by Alexey.

        <rdar://problem/5313518> fast/events/iframe-object-onload.html shows events out of order on Leopard

        Fix test so that it doesn't matter in what order the frames/objects are loaded. This is done by keeping
        the load logs in an array and sort it before dumping it.

        * fast/events/iframe-object-onload-expected.txt:
        * fast/events/iframe-object-onload.html:
        * mac/leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoDon't clobber variables that are already set, resulting in a broken build.
staikos [Fri, 6 Jul 2007 17:28:27 +0000 (17:28 +0000)]
Don't clobber variables that are already set, resulting in a broken build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Alexey.
andersca [Fri, 6 Jul 2007 17:08:50 +0000 (17:08 +0000)]
    Reviewed by Alexey.

        <rdar://problem/5313512> fast/frames/frame-set-same-{location,src}.html sometimes hang on Leopard

        Make these tests more robust against frames loading in a different order. Also, turn the tests
        into text tests and remove them from the Leopard skipped list.

        * fast/frames/frame-set-same-location-expected.checksum: Removed.
        * fast/frames/frame-set-same-location-expected.png: Removed.
        * fast/frames/frame-set-same-location-expected.txt:
        * fast/frames/frame-set-same-location.html:
        * fast/frames/frame-set-same-src-expected.checksum: Removed.
        * fast/frames/frame-set-same-src-expected.png: Removed.
        * fast/frames/frame-set-same-src-expected.txt:
        * fast/frames/frame-set-same-src.html:
        * mac/leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd --qmakearg=foo to make it possible to configure the build without editing
staikos [Fri, 6 Jul 2007 16:54:37 +0000 (16:54 +0000)]
Add --qmakearg=foo to make it possible to configure the build without editing
the .pro files each time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-07 Mark Rowe <mrowe@apple.com>
bdash [Fri, 6 Jul 2007 14:56:38 +0000 (14:56 +0000)]
2007-07-07  Mark Rowe  <mrowe@apple.com>

        Build fix.  Update WebDynamicScrollBarsView.h to include methods added and used in r24060.

        * WebView/WebDynamicScrollBarsView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John.
thatcher [Fri, 6 Jul 2007 14:40:08 +0000 (14:40 +0000)]
    Reviewed by John.

        <rdar://problem/5236277> REGRESSION-9A458: SPI for setting scroll bar behavior doesn't work

        Calling setHorizontalScrollingMode: calls updateScrollers before returning, this will cause
        WebCore to reset the scrolling mode based on the CSS overflow rules. So the setAlwaysShowHorizontalScroller:
        and setAlwaysShowVerticalScroller: methods needed a way to lock the scrolling mode before
        calling updateScrollers.

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView updateScrollers]):
        (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]):
        (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]):
        (-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
        (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]):
        (-[WebDynamicScrollBarsView setScrollingMode:]):
        (-[WebDynamicScrollBarsView setScrollingMode:andLock:]):
        * WebView/WebView.mm:
        (-[WebView setAlwaysShowVerticalScroller:]):
        (-[WebView setAlwaysShowHorizontalScroller:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
mjs [Fri, 6 Jul 2007 12:09:08 +0000 (12:09 +0000)]

        Reviewed by Antti.

        - <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings

        * Configurations/Base.xcconfig: Re-enable -Wstrict-aliasing
        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::getJNIEnv): Type-pun via a union instead of a pointer cast.
        * wtf/HashMap.h:
        (WTF::): Instead of doing type-punned assignments via pointer cast, do one of three things:
        (1) assign directly w/o cast if storage type matches real type; (2) assign using cast
        via union if type does not need reffing; (3) copy with memcpy and ref/deref manually if type
        needs reffing. This is ok peref-wise because memcpy of a constant length gets optomized.
        HashTraits are now expected to make ref()/deref() take the storage type, not the true type.
        * wtf/HashSet.h:
        (WTF::): Same basic idea.
        * wtf/HashTable.h:
        (WTF::): Added Assigner template for use by HashMap/HashSet. Change RefCounter to call ref()
        and deref() via storage type, avoiding the need to
        (WTF::RefCounter::ref): ditto
        (WTF::RefCounter::deref): ditto
        * wtf/HashTraits.h:
        (WTF::): Change ref() and deref() for RefPtr HashTraits to take the storage type; cast
        via union to pointer type.
        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::init): Changed from constructor to init function so this can go in a union.
        (WTF::): redefine pageheap macro in terms of getPageHeap().
        (WTF::getPageHeap): new inline function, helper for pageheap macro. This hides the cast in a union.
        (WTF::TCMalloc_ThreadCache::InitModule): Call init() instead of using placement new to initialize page
        * wtf/TCPageMap.h:
        (TCMalloc_PageMap1::init): Changed from constructor to init function.
        (TCMalloc_PageMap2::init): ditto
        (TCMalloc_PageMap3::init): ditto


        Reviewed by Antti.

        - <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings

        * platform/StringHash.h:
        (WTF::): Adapt to newer way to do storage types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-06 Bernhard Rosenkraenzer <bero@arklinux.org>
bdash [Fri, 6 Jul 2007 11:42:53 +0000 (11:42 +0000)]
2007-07-06  Bernhard Rosenkraenzer  <bero@arklinux.org>

        Reviewed by Sam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13985
        Bug 13985: WebCore/rendering/RenderTable.cpp fails to compile with gcc 4.2.x

        * rendering/RenderTable.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-06 Maxime Britto <mbritto@pleyo.com>
bdash [Fri, 6 Jul 2007 10:31:35 +0000 (10:31 +0000)]
2007-07-06  Maxime Britto  <mbritto@pleyo.com>

        Reviewed by Maciej.

        Fix http://bugs.webkit.org/show_bug.cgi?id=13038
        Bug 13038: ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame

        Modify an ASSERT in goToItem related to going back/forward in history.  We don't need to check the frameset if the target is _blank.
        The attached test case is a manual one since it relies on having pages opened in tabs in Safari.

        * manual-tests/goBack-blank-tab-page.html: Added.
        * manual-tests/resources/before-go-back.html: Added.
        * manual-tests/resources/will-go-back.html: Added.
        * page/Page.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-06 Mark Rowe <mrowe@apple.com>
bdash [Fri, 6 Jul 2007 10:21:32 +0000 (10:21 +0000)]
2007-07-06  Mark Rowe  <mrowe@apple.com>

        Unreviewed.  Update test results.

        * fast/encoding/utf-32-big-endian-bom-expected.txt:
        * fast/encoding/utf-32-big-endian-nobom-expected.txt:
        * fast/encoding/utf-32-little-endian-bom-expected.txt:
        * fast/encoding/utf-32-little-endian-nobom-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-06 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 6 Jul 2007 10:06:46 +0000 (10:06 +0000)]
2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14400
          Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube

        Test: fast/forms/button-state-restore.html

        * dom/Document.h:
        (WebCore::Document::isFormElementRegistered): Added.
        * html/HTMLGenericFormElement.cpp:
        (WebCore::HTMLGenericFormElement::closeRenderer): Restore saved form
        element state only if the element is registered with the document to
        have its state saved.

2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - test for http://bugs.webkit.org/show_bug.cgi?id=14400
          Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube

        * fast/forms/button-state-restore-expected.txt: Added.
        * fast/forms/button-state-restore.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-06 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 6 Jul 2007 10:05:16 +0000 (10:05 +0000)]
2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14487
          Incomplete repaint of background and border of boxes with -webkit-border-fit:lines

        Test: fast/repaint/border-fit-lines.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Do a full repaint if
        -webkit-border-fit:lines was specified.

2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=14487
          Incomplete repaint of background and border of boxes with -webkit-border-fit:lines

        * fast/repaint/border-fit-lines-expected.checksum: Added.
        * fast/repaint/border-fit-lines-expected.png: Added.
        * fast/repaint/border-fit-lines-expected.txt: Added.
        * fast/repaint/border-fit-lines.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-06 Tony Chang <idealisms@gmail.com>
bdash [Fri, 6 Jul 2007 10:03:38 +0000 (10:03 +0000)]
2007-07-06  Tony Chang  <idealisms@gmail.com>

        Reviewed by Maciej.

        Bug 14516: crash loading multipart/x-mixed-replace data on windows safari

        NULL check m_resourceData to prevent a crash in Safari on Windows.

        * loader/ResourceLoader.cpp:

2007-07-06  Tony Chang  <idealisms@gmail.com>

        Reviewed by Maciej.

        Bug 14516: crash loading multipart/x-mixed-replace data on windows safari

        * http/tests/multipart/resources/multipart-nodashes.php: Added.
        * http/tests/multipart/win-boundary-crash-expected.txt: Added.
        * http/tests/multipart/win-boundary-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-06 Jungshik Shin <jungshik.shin@gmail.com>
bdash [Fri, 6 Jul 2007 10:00:45 +0000 (10:00 +0000)]
2007-07-06  Jungshik Shin  <jungshik.shin@gmail.com>

        Reviewed by Alexey.

        - Add UTF-32 encoding support

         - fast/encoding/utf-32-big-endian-bom.html
         - fast/encoding/utf-32-big-endian-nobom.xml
         - fast/encoding/utf-32-little-endian-bom.html
         - fast/encoding/utf-32-little-endian-nobom.xml

        * loader/TextResourceDecoder.cpp:
        * platform/TextDecoder.cpp:
        * platform/TextDecoder.h:
        * platform/TextEncoding.cpp:
        * platform/TextEncoding.h:

2007-07-06  Jungshik Shin <jungshik.shin@gmail.com>

        Reviewed by Alexey.

       - test for http://bugs.webkit.org/show_bug.cgi?id=13415

        * fast/encoding/utf-32-big-endian-bom-expected.txt: Added.
        * fast/encoding/utf-32-big-endian-bom.html: Added.
        * fast/encoding/utf-32-big-endian-nobom-expected.txt: Added.
        * fast/encoding/utf-32-big-endian-nobom.xml: Added.
        * fast/encoding/utf-32-little-endian-bom-expected.txt: Added.
        * fast/encoding/utf-32-little-endian-bom.html: Added.
        * fast/encoding/utf-32-little-endian-nobom-expected.txt: Added.
        * fast/encoding/utf-32-little-endian-nobom.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-06 Holger Hans Peter Freyther <zecke@selfish.org>
bdash [Fri, 6 Jul 2007 09:56:26 +0000 (09:56 +0000)]
2007-07-06  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Maciej.

        Start implementening RenderThemeGdk/Gtk using GtkStyle. The approach is
        to allocate one native control for each widget type. And use margins, spacing,
        style properties from the Widget. And for drawing use GtkStyle on the rect supplied.

        This should allow nice integration and be relative resource friendly. Mozilla is using
        a similiar approach. They seem to share the GdkPixmap among several operations and this
        will be an obvious candidate for improvements. Create a normally big enough GdkPixmap and
        use that for drawing and then set clip regions for cairo to make sure to not go beyond the
        width and height.

        The next steps will be to introduce states for the widgets, add more widgets, handle focus,
        and various other style attributes, honor the size and margin and use that to propagate this
        back to RenderStyle*.

        * platform/gdk/RenderThemeGdk.cpp:
        * platform/gdk/RenderThemeGdk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-06 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 6 Jul 2007 09:52:54 +0000 (09:52 +0000)]
2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=10267
          Can't scroll page downwards with scroll wheel, when pointer is on top of non-scrolling iframe

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView scrollWheel:]): Override the superclass
        implementation to forward the wheel event to the next responder if this view
        does not allow scrolling in the event's direction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix build.
rwlbuis [Fri, 6 Jul 2007 09:11:45 +0000 (09:11 +0000)]
Fix build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
rwlbuis [Fri, 6 Jul 2007 09:00:13 +0000 (09:00 +0000)]
    Reviewed by Adam.

        Adding a stop with value 1.0 to a gradient that has already been used has no effect

        Implement start and end stop handling differently so they are not
        in the color stop array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix <rdar://problem/5301994> Garbled text still showing on some sites
aroben [Fri, 6 Jul 2007 08:44:11 +0000 (08:44 +0000)]
Fix <rdar://problem/5301994> Garbled text still showing on some sites


        Fix <rdar://problem/5301994> Garbled text still showing on some sites

        Replace calls to GetGlyphIndices with wkGetGlyphs.

        Reviewed by Alice.

        * platform/win/GlyphPageTreeNodeWin.cpp:
        (WebCore::GlyphPage::fill): Use wkGetGlyphs.
        * platform/win/FontDataWin.cpp:


        Update WebKitSystemInterface.{h,lib} for <rdar://problem/5301994>

        Reviewed by Alice.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoForgot ChangeLog description
pewtermoose [Fri, 6 Jul 2007 07:41:23 +0000 (07:41 +0000)]
Forgot ChangeLog description

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
pewtermoose [Fri, 6 Jul 2007 07:37:56 +0000 (07:37 +0000)]
    Reviewed by Adam Roben.

        * building/build.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not reviewed - Windows build fix.
pewtermoose [Fri, 6 Jul 2007 07:01:56 +0000 (07:01 +0000)]
    Not reviewed - Windows build fix.

        * bridge/win/FrameWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd optional --qmake= and --qt arguments to force Qt builds and force with a
staikos [Fri, 6 Jul 2007 06:14:55 +0000 (06:14 +0000)]
Add optional --qmake= and --qt arguments to force Qt builds and force with a
specific qmake binary

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

staikos [Fri, 6 Jul 2007 05:12:47 +0000 (05:12 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sullivan [Fri, 6 Jul 2007 03:49:50 +0000 (03:49 +0000)]

        Reviewed by Adam

        - WebCore part of fix for <rdar://problem/5315033>

        * rendering/RenderObject.h:
        replaced PaintRestrictionSelectionOnlyWhiteText with PaintRestrictionSelectionOnlyBlackText
        replaced forceWhiteText with forceBlackText

        * rendering/RenderObject.cpp:
        added a useSelectionHeight parameter, which defaults to false; this method is unimplemented
        at this level so this has no effect.

        * rendering/RenderText.h:
        * rendering/RenderText.cpp:
        added a useSelectionHeight parameter, which defaults to false. If true, use the vertical position
        and height returned by selectionRect rather than replacing it with the more tight-fitting position
        and height of the line box.

        * dom/Range.h:
        * dom/Range.cpp:
        added a useSelectionHeight parameter, which defaults to false. Passes this along to RenderObject.

        * page/Frame.h:
        renamed parameter to selectionImage
        * page/Frame.cpp:
        pass true for addLineBoxRects new useSelectionHeight parameter, so the rects returned by this new
        method will match the height that the selection would be painted here
        updated for white->black name changes

        * page/mac/FrameMac.mm:
        updated for white->black name changes

        * rendering/InlineFlowBox.cpp:
        updated for white->black name changes

        * rendering/RenderLayer.cpp:
        updated for white->black name changes

        * rendering/InlineTextBox.cpp:
        updated for white->black name changes, and actually use black instead of white. This was the goal
        of all the name changes.


        Reviewed by Adam

        - WebKit part of fix for <rdar://problem/5315033>

        * WebView/WebDocumentPrivate.h:
        new selectionImageForcingBlackText: method. selectionImageForcingWhiteText: is no longer used and was never
        in an official release of WebKit, so it could be removed, except that doing so would cause trouble for people
        using nightly WebKit with Safari 3.0 beta. So I left it in, but made it just force black text instead of
        white text, which will look different for those nightly WebKit/Safari 3.0 beta people but not break anything.

        * Misc/WebSearchableTextView.m:
        (-[WebSearchableTextView selectionImageForcingBlackText:]):
        new unimplemented protocol method for this obsolete class

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView selectionImageForcingBlackText:]):
        calls through to WebCore the way selectionImageForcingWhiteText: used to
        (-[WebHTMLView selectionImageForcingWhiteText:]):
        now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name

        * WebView/WebPDFView.mm:
        (-[WebPDFView selectionImageForcingBlackText:]):
        guts of old selectionImageForcingWhiteText:, but with black substituted for white
        (-[WebPDFView selectionImageForcingWhiteText:]):
        now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoForgot the file extension
aroben [Fri, 6 Jul 2007 03:33:54 +0000 (03:33 +0000)]
Forgot the file extension

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdated the Windows Skipped file
aroben [Fri, 6 Jul 2007 03:31:56 +0000 (03:31 +0000)]
Updated the Windows Skipped file

* win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
andersca [Fri, 6 Jul 2007 02:28:42 +0000 (02:28 +0000)]
    Reviewed by Oliver.

        Fix layout test failures.

        * loader/FrameLoader.cpp:
        Don't make a representation if we're creating the initial document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix Bug 14388: Input in text fields limited to 1024 characters
aroben [Fri, 6 Jul 2007 01:58:37 +0000 (01:58 +0000)]
Fix Bug 14388: Input in text fields limited to 1024 characters


2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>

        Fix Bug 14388: Input in text fields limited to 1024 characters

        Slightly modified by Adam Roben.

        Reviewed by Adele.

        Test: fast/forms/input-length.html

        * html/HTMLInputElement.cpp: Bump limit to 524288.
        * html/HTMLInputElement.h:


        Added two tests for Bug 14388: Input in text fields limited to 1024 characters

        fast/forms/input-maxlength-2.html is obsoleted by

        Reviewed by Adele.

        * fast/forms/input-implicit-length-limit-expected.txt: Added.
        * fast/forms/input-implicit-length-limit.html: Added.
        * fast/forms/input-maxlength-2-expected.checksum: Removed.
        * fast/forms/input-maxlength-2-expected.png: Removed.
        * fast/forms/input-maxlength-2-expected.txt: Removed.
        * fast/forms/input-maxlength-2.html: Removed.
        * fast/forms/input-maxlength-expected.txt: Added.
        * fast/forms/input-maxlength.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd another hanging test to the Leopard Skipped file
aroben [Fri, 6 Jul 2007 01:58:27 +0000 (01:58 +0000)]
Add another hanging test to the Leopard Skipped file

Rubberstamped by Adele.

* mac/leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdating expected results for r24027.
justing [Fri, 6 Jul 2007 01:02:45 +0000 (01:02 +0000)]
Updating expected results for r24027.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
andersca [Thu, 5 Jul 2007 23:12:28 +0000 (23:12 +0000)]
    Build fix.

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Forgot to add this file for the test for <rdar://problem/5303566> REGRESSION:
ggaren [Thu, 5 Jul 2007 23:04:11 +0000 (23:04 +0000)]
    Forgot to add this file for the test for <rdar://problem/5303566> REGRESSION:
        XMLHttpRequest.responseXML. Darin added a dummy file before -- here's the
        real one.

        * fast/loader/resources/plist.app:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
weinig [Thu, 5 Jul 2007 22:56:24 +0000 (22:56 +0000)]
    Reviewed by Geoff.

        Add focus, blur and close functions to DOMWindow implementation class
        and move bindings from Window to JSDOMWindow.

        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:
        * bindings/scripts/CodeGeneratorJS.pm: Move prototype function declaration from
        the implementation to the header.
        * page/DOMWindow.cpp:
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 5 Jul 2007 22:52:38 +0000 (22:52 +0000)]

        Reviewed by Harrison.

        <rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body

        Demonstrates bug:
        * editing/style/5279521-expected.checksum: Added.
        * editing/style/5279521-expected.png: Added.
        * editing/style/5279521-expected.txt: Added.
        * editing/style/5279521.html: Added.

        * fast/forms/radio-check-click-and-drag-expected.txt:
        * fast/forms/textarea-type-spaces-expected.txt:


        Reviewed by Harrison.

        <rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::exitNode): Previously emitted content shouldn't have
        to come from a text node in order to emit a '\n' as we exit block containers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
andersca [Thu, 5 Jul 2007 22:50:52 +0000 (22:50 +0000)]
    Reviewed by Geoff.

        <rdar://problem/5315284> REGRESSION: Leopard Launch Time - plugins are being accessed at startup.

        Set a response that has a MIME type of "text/html" on the document loader so WebKit won't refresh the
        plugin database looking for a plug-in that can handle the document's MIME type (which will be null anyway).

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
andersca [Thu, 5 Jul 2007 22:34:43 +0000 (22:34 +0000)]
    Reviewed by Oliver.

        WebKit loads user style sheets too late as seen in Mail (breaks DataDetectors; Mail flashes wrong font)

        Let the document know when the user style sheet is loading so that it try not to display anything
        until the user style sheet has finished loading.

        * page/Frame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix a leak in WebView::setToolTip
aroben [Thu, 5 Jul 2007 21:02:41 +0000 (21:02 +0000)]
Fix a leak in WebView::setToolTip

Reviewed by Beth.

* WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John.
thatcher [Thu, 5 Jul 2007 20:43:30 +0000 (20:43 +0000)]
    Reviewed by John.

        <rdar://problem/5314993> Shiira 2.1 throws an exception open a new window: -[WebInspector window]: unrecognized selector

        Add an empty implementation of this method to prevent Shiira from throwing an exception.
        Also log that this method is obsolete and the class will be removed.

        * WebInspector/WebInspector.mm:
        (-[WebInspector window]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix Bug 14143: Tooltips not displayed on Windows
aroben [Thu, 5 Jul 2007 20:16:06 +0000 (20:16 +0000)]
Fix Bug 14143: Tooltips not displayed on Windows

Reviewed by Oliver.

* WebChromeClient.cpp:
(WebChromeClient::setToolTip): Call up to WebView.
* WebView.cpp:
(WebView::WebView): Initialize m_toolTipHwnd member.
(WebView::initWithFrame): Set up the tool tip window.
(initCommonControls): Added.
(WebView::initializeToolTipWindow): Added.
(WebView::setToolTip): Set the tool tip text and enable/disable the
tool tip.
* WebView.h: Added/updated declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
weinig [Thu, 5 Jul 2007 18:09:57 +0000 (18:09 +0000)]
    Reviewed by Darin.

        Move JSDOMWindow overriding getOwnPropertySlot logic from KJS::Window
        up into JSDOMWindow.  No change in functionality so no testcase required.

        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - tweaked IDN test and checked in both Tiger results and Leopard
darin [Thu, 5 Jul 2007 17:51:29 +0000 (17:51 +0000)]
    - tweaked IDN test and checked in both Tiger results and Leopard

        * fast/encoding/idn-security.html: Changed test to only test lowercase "a" since the behavior for
        uppercase letters has changed in the new ICU. Also added code to detect the older ICU and expect
        different results.

        * fast/encoding/idn-security-expected.txt: Regenerated results.

        * mac/leopard/fast/encoding/idn-security-expected.txt: Copied from fast/encoding/idn-security-expected.txt.
        The modified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and Landed by Sam.
weinig [Thu, 5 Jul 2007 17:02:49 +0000 (17:02 +0000)]
    Reviewed and Landed by Sam.

        - fix bug 14465 for window.showModalDialog

        * bindings/js/kjs_window.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
weinig [Thu, 5 Jul 2007 16:14:19 +0000 (16:14 +0000)]
    Reviewed by Mitz.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14465
        window.open() uses the literal "undefined" as the URL

        * bindings/js/kjs_window.cpp:
        (KJS::WindowFunc::callAsFunction): add checks for undefined and null values when setting the url.
        * manual-tests/open-url-undefined.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-05 Holger Hans Peter Freyther <zecke@selfish.org>
bdash [Thu, 5 Jul 2007 13:51:33 +0000 (13:51 +0000)]
2007-07-05  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Rob Buis.

        Rework FontData and FontPlatformData for the Gdk work to make valgrind

        Move destroying of FontConfig and Cairo objects held in FontPlatformData
        to FontData::platformDestroy. The ownership of these objects is held by
        FontData. This is following the Mac and Qt port at least.

        Currently it is possible that FontPlatformData will not create cairo resources
        in this case at least make sure the variables are initialized to 0.
        Initialize x,y of the cairo_glyph_t with zero to avoid extents.x_advance depending
        on subtracing with not defined values.

        FontPlatformData::hash. Using FontDescription is a bad idea as we don't have a clue
        about how it is packed, if holes are present, etc. The FcPattern and the m_fontMatrix
        should be good enough to describe the Font. All other objects are created using these

        Replace C-style casts with C++ casts, in this case reinterpret_cast.

        * platform/gdk/FontDataGdk.cpp:
        (WebCore::FontData::platformInit): Don't assert
        (WebCore::FontData::platformDestroy): Take over ownership
        (WebCore::FontData::platformWidthForGlyph): initialize
        (WebCore::FontData::setFont): be paranoid and assert
        * platform/gdk/FontPlatformData.h:
        (WebCore::FontPlatformData::FontPlatformData): Initialize everything
        (WebCore::FontPlatformData::hash): make valgrind happy and don't use m_fontDescription
        * platform/gdk/FontPlatformDataGdk.cpp:
        (WebCore::FontPlatformData::~FontPlatformData): FontData::platformDestroy will do this
        (WebCore::FontPlatformData::list): Don't use C-style casts.
        (WebCore::FontPlatformData::setFont): m_fontFace, m_fontMatrix, m_options might not be initialized
        (WebCore::FontPlatformData::operator==): Don't use C-style casts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-05 Alp Toker <alp.toker@collabora.co.uk>
bdash [Thu, 5 Jul 2007 13:47:47 +0000 (13:47 +0000)]
2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Mark Rowe.

        GraphicsContextCairo code style cleanup

        Follow the cr naming convention for cairo_t*.
        Remove trailing whitespace.
        Replace C casts with C++ casts.
        Avoid needless casts.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::strokeArc): Save/restore the graphics state.
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        * platform/graphics/cairo/ImageCairo.cpp: Avoid the confusing ctxt/context naming scheme.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-05 Alp Toker <alp.toker@collabora.co.uk>
bdash [Thu, 5 Jul 2007 13:45:16 +0000 (13:45 +0000)]
2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Mark Rowe.

        Cairo SVGImage::nativeImageForCurrentFrame() has no return

        Return the Cairo surface from the frame cache.

        Also add a fall-through else macro with notImplemented() so that future
        ports do not make the same mistake.

        * platform/graphics/svg/SVGImage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-05 Alp Toker <alp.toker@collabora.co.uk>
bdash [Thu, 5 Jul 2007 13:43:44 +0000 (13:43 +0000)]
2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Mark Rowe.

        Cairo animated GIF support is broken

        Implement ImageSource::frameIsCompleteAtIndex() to enable animated GIFs.

        * platform/graphics/cairo/ImageSourceCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd a Skipped file for Leopard.
aroben [Thu, 5 Jul 2007 09:15:19 +0000 (09:15 +0000)]
Add a Skipped file for Leopard.

Reviewed by Mark.

* mac/leopard/Skipped: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWarn about tests in the Skipped file that succeeded
aroben [Thu, 5 Jul 2007 08:21:09 +0000 (08:21 +0000)]
Warn about tests in the Skipped file that succeeded

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemoved unused install-win-extras script
aroben [Thu, 5 Jul 2007 08:10:16 +0000 (08:10 +0000)]
Removed unused install-win-extras script

Rubberstamped by Mark.

* Scripts/install-win-extras: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoShow the test's extension in the results page
aroben [Thu, 5 Jul 2007 07:51:52 +0000 (07:51 +0000)]
Show the test's extension in the results page

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd more options for controlling the interpretation of the Skipped file
aroben [Thu, 5 Jul 2007 07:49:57 +0000 (07:49 +0000)]
Add more options for controlling the interpretation of the Skipped file

Reviewed by Mark.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd --skipped-only option to run-webkit-tests
aroben [Thu, 5 Jul 2007 06:56:50 +0000 (06:56 +0000)]
Add --skipped-only option to run-webkit-tests

When this option is specified, only those tests listed in the Skipped
file are run.

Reviewed by Mark.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoClean up/alphabetize the run-webkit-tests help message
aroben [Thu, 5 Jul 2007 06:42:00 +0000 (06:42 +0000)]
Clean up/alphabetize the run-webkit-tests help message

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoEnable a Leopard-specific Skipped list.
aroben [Thu, 5 Jul 2007 06:24:03 +0000 (06:24 +0000)]
Enable a Leopard-specific Skipped list.

Reviewed by Mark.

* Scripts/run-webkit-tests: Check for Leopard.
* Scripts/webkitdirs.pm: Added isTiger/isLeopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago... and it was reviewed by Adam.
bdash [Thu, 5 Jul 2007 06:12:57 +0000 (06:12 +0000)]
... and it was reviewed by Adam.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-07-04 Matt Perry <mpComplete@gmail.com>
bdash [Thu, 5 Jul 2007 06:08:56 +0000 (06:08 +0000)]
2007-07-04  Matt Perry  <mpComplete@gmail.com>

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13400
        Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location

        Treat userGesture as always true for setLocation, forcing a back/forward
        entry to be created.

        * bindings/js/JSHTMLDocumentCustom.cpp:

2007-07-04  Matt Perry  <mpComplete@gmail.com>

        Test for http://bugs.webkit.org/show_bug.cgi?id=13400
        Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location

        Test that assigning to document.location in various ways adds an
        item to the back/forward list.

        * http/tests/navigation/document-location-click-expected.txt: Added.
        * http/tests/navigation/document-location-click-timeout-expected.txt: Added.
        * http/tests/navigation/document-location-click-timeout.html: Added.
        * http/tests/navigation/document-location-click.html: Added.
        * http/tests/navigation/document-location-mouseover-expected.txt: Added.
        * http/tests/navigation/document-location-mouseover.html: Added.
        * http/tests/navigation/document-location-onload-expected.txt: Added.
        * http/tests/navigation/document-location-onload.html: Added.
        * http/tests/navigation/resources/document-location.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRestore MouseEventWithHitTestResults::targetNode's old behavior
aroben [Thu, 5 Jul 2007 06:04:56 +0000 (06:04 +0000)]
Restore MouseEventWithHitTestResults::targetNode's old behavior

Reviewed by Mark.

Fixes fast/images/imagemap-case and fast/replace/image-map.

* page/MouseEventWithHitTestResults.cpp:
(WebCore::MouseEventWithHitTestResults::targetNode): Use the inner
node, not the inner non-shared node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMac, Qt, and Gdk build fixes.
aroben [Thu, 5 Jul 2007 05:21:28 +0000 (05:21 +0000)]
Mac, Qt, and Gdk build fixes.

* page/EventHandler.h:
* page/gdk/EventHandlerGdk.cpp:
* page/mac/EventHandlerMac.mm:
* page/qt/EventHandlerQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the Qt/Gdk builds.
aroben [Thu, 5 Jul 2007 03:23:48 +0000 (03:23 +0000)]
Fix the Qt/Gdk builds.

* page/gdk/EventHandlerGdk.cpp:
* page/qt/EventHandlerQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMove tooltip logic down into WebCore so that it can be shared cross-platform
aroben [Thu, 5 Jul 2007 03:00:55 +0000 (03:00 +0000)]
Move tooltip logic down into WebCore so that it can be shared cross-platform


        Move tooltip logic down into WebCore so that it can be shared cross-platform

        Reviewed by Sam.

        * page/Chrome.cpp:
        (WebCore::Chrome::setToolTip): Added.
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::mouseMoved): Call Chrome::setToolTip.
        * platform/graphics/svg/SVGImageEmptyClients.h:

        Added stubs for Gdk:

        * platform/gdk/ChromeClientGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:


        Move tooltip logic down into WebCore so that it can be shared cross-platform

        Reviewed by Sam.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::setToolTip): Added.
        * WebView/WebHTMLView.mm: Removed _resetCachedWebPreferences.
        (-[WebHTMLView _updateMouseoverWithEvent:]): Removed tooltip code.
        (-[WebHTMLView initWithFrame:]): Removed call to
        (-[WebHTMLView setDataSource:]): Ditto.
        * WebView/WebHTMLViewInternal.h: Removed showsURLsInToolTips ivar.
        * WebView/WebHTMLViewPrivate.h: Added declaration for _setTooltip so
        that WebChromeClient can call it.


        Added a stub for WebChromeClient::setToolTip

        Reviewed by Sam.

        * WebChromeClient.cpp:
        * WebChromeClient.h:


        Added a stub for ChromeClientQt::setToolTip

        Reviewed by Sam.

        * WebCoreSupport/ChromeClientQt.cpp:
        * WebCoreSupport/ChromeClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd/initialize Settings::showsURLsInToolTips
aroben [Thu, 5 Jul 2007 03:00:41 +0000 (03:00 +0000)]
Add/initialize Settings::showsURLsInToolTips


        Add Settings::showsURLsInToolTips

        Reviewed by Sam.

        * WebCore.exp:
        * page/Settings.cpp:
        * page/Settings.h:


        Initialize Settings::showsURLsInToolTips

        Reviewed by Sam.

        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):


        Initialize Settings::showsURLsInToolTips

        Reviewed by Sam.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMove logic for calling mouseDidMoveOverElement into WebCore
aroben [Thu, 5 Jul 2007 03:00:29 +0000 (03:00 +0000)]
Move logic for calling mouseDidMoveOverElement into WebCore


        Move logic for calling mouseDidMoveOverElement into WebCore

        Reviewed by Sam.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::mouseMoved): Added. Calls Chrome::mouseDidMoveOverElement.
        (WebCore::EventHandler::handleMouseMoveEvent): Now takes an optional
        HitTestResult* parameter which is used to communicate to the caller the
        node the mouse is over.
        * page/EventHandler.h:
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::mouseMoved): Changed to call the overloaded
        (WebCore::EventHandler::passMouseMoveEventToSubframe): Pass hoveredNode
        through to the subframe so we can get the deepest node hovered, not
        just the node's parent frame.
        * page/win/EventHandlerWin.cpp:
        (WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.


        Removed call to mouseDidMoveOverElement now that WebCore handles it

        Reviewed by Sam.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _updateMouseoverWithEvent:]):


        Removed call to mouseDidMoveOverElement now that WebCore handles it

        Reviewed by Sam.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd Chrome::mouseDidMoveOverElement
aroben [Thu, 5 Jul 2007 03:00:16 +0000 (03:00 +0000)]
Add Chrome::mouseDidMoveOverElement


        Add Chrome::mouseDidMoveOverElement

        This does the work of calling up to the ChromeClient (which will call
        the UI delegate).

        Reviewed by Sam.

        * page/Chrome.cpp:
        (WebCore::Chrome::mouseDidMoveOverElement): Added.
        * page/Chrome.h:
        * page/ChromeClient.h:
        * platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to
        * platform/gdk/ChromeClientGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:


        Add WebChromeClient::mouseDidMoveOverElement

        This is not called yet.

        Reviewed by Sam.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:


        Add WebChromeClient::mouseDidMoveOverElement

        This is not called yet.

        Reviewed by Sam.

        * WebChromeClient.cpp:
        * WebChromeClient.h:


        Added a stub for ChromeClientQt::mouseDidMoveOverElement

        Reviewed by Sam.

        * WebCoreSupport/ChromeClientQt.cpp:
        * WebCoreSupport/ChromeClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23997 268f45cc-cd09-0410-ab3c-d52691b4dbfc