13 years ago2008-04-30 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Thu, 1 May 2008 00:08:14 +0000 (00:08 +0000)]
2008-04-30  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        This patch does three things:
        1. Adds support for the "img" ARIA role
        2. Switches over to a HashMap for converting ARIA role attributes
        to WebCore's AccessibilityRole type.
        3. Fixes a crash in the new ARIA code that I ran into while
        browsing with VoiceOver enabled.

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::headingLevel): This is the crash
        fix. Make sure the node's renderer is not null before looking up
        its corresponding AccessibilityObject in the cache.
        (WebCore::AccessibilityObject::accessibilityIsIgnored): Account for
        ARIA images.
        (WebCore::createARIARoleMap): Switch to HashMap, and add "img" to
        the Map.
        (WebCore::RoleEntry::): Same.
        (WebCore::ariaRoleToWebCoreRole): Same.
        (WebCore::AccessibilityObject::ariaRoleAttribute): Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 30 Apr 2008 23:16:13 +0000 (23:16 +0000)]
2008-04-30  Brady Eidson  <beidson@apple.com>

        Fix my WebPreferences revert check-in

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 30 Apr 2008 22:33:23 +0000 (22:33 +0000)]
2008-04-30  Brady Eidson  <beidson@apple.com>

        Rubberstamped by John Sullivan

        Revert the remainder of my original preferences changes from last week.
        They caused a massive PLT regression (too many notifications being sent out
        or listened to that weren't previously) and it's not in my schedule to refine
        the preferences code instead of working on my feature!

        * WebView/WebView.mm:
        (-[WebView _updateSettingsFromPreferences:]):
        (-[WebView _commonInitializationWithFrameName:groupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 30 Apr 2008 21:52:38 +0000 (21:52 +0000)]
2008-04-30  Anders Carlsson  <andersca@apple.com>

        Fix the 64-bit build.

        * Plugins/WebNetscapePluginEventHandler.h:
        * Plugins/WebNetscapePluginEventHandler.mm:
        * Plugins/WebNetscapePluginEventHandlerCarbon.h:
        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Nikolas.
rwlbuis@webkit.org [Wed, 30 Apr 2008 20:36:41 +0000 (20:36 +0000)]
    Reviewed by Nikolas.

        onload called too many times for <svg:image>
        SVG wastes time in malloc to send loadEvents to non-existent listeners

        Postpone load event dispatching for image when externalResourcesRequired        is true, delaying parents but not siblings, and make sure the load event        is sent once for image in all cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Wed, 30 Apr 2008 20:21:01 +0000 (20:21 +0000)]

2008-04-30  David Hyatt  <hyatt@apple.com>

        Fix crashes when dynamically removing <video> elements with layers that establish stacking contexts.  This
        won't typically crash release builds because of arena recycling.

        Reviewed by Dan Bernstein

        * rendering/RenderLayer.cpp:
        Make sure to remove the reflection's child layer from its parent.

        * rendering/RenderMedia.cpp:
        * rendering/RenderMedia.h:
        Adjust the teardown of RenderMedia so that it does all of its teardown inside destroy() (this makes it more
        like other renderers and doesn't leave you staring at a trashed layer hierarchy in the RenderMedia


2008-04-30  David Hyatt  <hyatt@apple.com>

        Add test for video crasher.

        Reviewed by Dan Bernstein

        * media/video-layer-crash.html: Added.
        * platform/mac/media/video-layer-crash-expected.checksum: Added.
        * platform/mac/media/video-layer-crash-expected.png: Added.
        * platform/mac/media/video-layer-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the ChangeLogs so it includes the details about r32719.
rwlbuis@webkit.org [Wed, 30 Apr 2008 18:00:34 +0000 (18:00 +0000)]
Fix the ChangeLogs so it includes the details about r32719.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdding Radar link
mitz@apple.com [Wed, 30 Apr 2008 17:57:52 +0000 (17:57 +0000)]
Adding Radar link

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Rémi Zara <remi_zara@mac.com>
mitz@apple.com [Wed, 30 Apr 2008 17:55:08 +0000 (17:55 +0000)]
2008-04-30  Rémi Zara  <remi_zara@mac.com>

        Reviewed by Dave Hyatt.

        fix https://bugs.webkit.org/show_bug.cgi?id=18618
        REGRESSION (r31823-r31847): Patterns are upside down

        * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
        (WebCore::patternCallback): flip the y axis when drawing the tile

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes an undefined type exception that fires when adding a resource to the inspector
timothy@apple.com [Wed, 30 Apr 2008 17:32:20 +0000 (17:32 +0000)]
Fixes an undefined type exception that fires when adding a resource to the inspector
that has a MIME type warning.

Reviewed by Adam Roben.

* page/inspector/Resource.js:
(WebInspector.Resource.prototype._addTip): Call WebInspector.console instead of
(WebInspector.Resource.prototype._checkWarning): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes the bug where the selected resource would be deselected after
timothy@apple.com [Wed, 30 Apr 2008 17:32:09 +0000 (17:32 +0000)]
Fixes the bug where the selected resource would be deselected after
changing the sort order in the Resources panel.

Reviewed by Dan Bernstein.

* page/inspector/ResourcesPanel.js:
Rememebr if the tree element that we are sorting was selected, so
the selection can be restored after it is re-inserted. The onSelect
is suppressed since we don't need to show the resource again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes the regression where error bubbles in source views always show
timothy@apple.com [Wed, 30 Apr 2008 17:31:58 +0000 (17:31 +0000)]
Fixes the regression where error bubbles in source views always show
"undefined" for the content because the message property on
ConsoleMessage was removed. Adds support for a plain text formated
message that is stored in the message proeprty.

Reviewed by Adam Roben.

* page/inspector/Console.js:
(WebInspector.Console.prototype._format): Add a plainText argument that is passed to
the formatters.
(WebInspector.Console.prototype._formatvalue): Add a plainText argument, and a comment
about needing to honor it if the textContent of the output doesn't make sense.
(WebInspector.Console.prototype._formatvalue): Ditto.
(WebInspector.Console.prototype._formatstring): Ditto.
(WebInspector.Console.prototype._formatregexp): Ditto.
(WebInspector.Console.prototype._formatarray): Ditto.
(WebInspector.Console.prototype._formatnode): Ditto.
(WebInspector.Console.prototype._formatobject): Ditto.
(WebInspector.Console.prototype._formaterror): Ditto.
(WebInspector.ConsoleMessage): Call _format passing true for plainText. Get the
textContnet of the result and assign to the message proeprty. This property is
referenced from the SourceView.
(WebInspector.ConsoleMessage.prototype._format): Add a plainText argument. Build the
result element as a local and return it, instead of using formatedMessage directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdds a helper function to convert a JSValueRef to a String.
timothy@apple.com [Wed, 30 Apr 2008 17:31:50 +0000 (17:31 +0000)]
Adds a helper function to convert a JSValueRef to a String.

Reviewed by Adam Roben.

* page/InspectorController.cpp:
(WebCore::toString): Converts a JSValueRef to a String.
(WebCore::search): Use toString.
(WebCore::InspectorController::handleException): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Wed, 30 Apr 2008 16:08:53 +0000 (16:08 +0000)]
2008-04-30  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Rubber-stamped by Simon

        Updated the expected test results to reflect the fact that most render objects now are anonymous.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 30 Apr 2008 13:41:24 +0000 (13:41 +0000)]
2008-04-30  Ariya Hidayat  <ariya.hidayat@trolltech.com>

            Reviewed by Simon.

            Build the Qt port with SVG Foreign Object support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 30 Apr 2008 12:49:09 +0000 (12:49 +0000)]
2008-04-30  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        Fix null pointer deference triggered by

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Wed, 30 Apr 2008 10:25:18 +0000 (10:25 +0000)]
2008-04-30  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Rubber-stamped by Simon.

        Updated the expected test results to the current font metrics.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 30 Apr 2008 10:22:22 +0000 (10:22 +0000)]
2008-04-30  Simon Hausmann  <hausmann@webkit.org>

        Rubber-stamped by Holger.

        Updated the skip list for the Qt port to exclude features currently
        not implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Wed, 30 Apr 2008 09:39:25 +0000 (09:39 +0000)]
2008-04-30  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        In focusIn and focusOut event always update the active state of the
        focus controller. Fixes ~400 failing layout tests due to missing
        editing callbacks that relied on the correct focus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Sean Egan <seanegan@gmail.com>
zecke@webkit.org [Wed, 30 Apr 2008 09:07:32 +0000 (09:07 +0000)]
2008-04-30  Sean Egan  <seanegan@gmail.com>

        Reviewed and modified by Holger.

        Support setting background color and a 16-bit alpha channel.

        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        * webkit/webkitwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 30 Apr 2008 08:12:15 +0000 (08:12 +0000)]
2008-04-29  David Hyatt  <hyatt@apple.com>

        Improve the performance of masks by adding code to set more precise clips on the transparency layers
        used to paint the content under the mask, and then also avoid creating transparency layers for the masks
        themselves in common cases.

        Reviewed by Dan Bernstein

        * platform/graphics/GraphicsContext.cpp:
        Fix a bug in drawTiledImage where the composite mode got lost in the double stretch case for nine piece

        * rendering/InlineFlowBox.cpp:
        Optimize to only push a transparency layer for the mask if multiple images are combining.  Add a new
        composite operator argument for use when painting fill layers to do direct destination-in compositing while
        painting images.

        * rendering/InlineFlowBox.h:
        * rendering/RenderBox.cpp:
        Optimize to only push a transparency layer for the mask if multiple images are combining.

        A new method that attempts to compute a precise clip rect for the mask images.

        * rendering/RenderBox.h:
        Added the composite operator argument to the paintFillLayer methods.

        * rendering/RenderFieldset.cpp:
        Call the new base class paintMaskImages method for optimized mask painting.

        * rendering/RenderLayer.cpp:
        Fix a coordinate space issue with transparencyClipBox when masks were used.  The border box was in the
        wrong coordinate space.  Moved the code into the layer's boundingBox() method instead.

        Removed the code that always pushed a transparency layer before painting masks.

        Call maskClipRect to shrink the bounding box of the layer to fit the mask clip.

        * rendering/RenderObject.cpp:
        Added a composite operator argument for direct destination-in painting of nine piece images.

        * rendering/RenderObject.h:
        Base class stubs for RenderBox-implemented methods.

        * rendering/RenderTable.cpp:
        * rendering/RenderTableCell.cpp:
        Modified to call the new paintMaskImages function.

        * svg/graphics/SVGImage.cpp:
        SVG images now respect composite modes by pushing a transparency layer when the composite mode
        is anything other than source-over.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 30 Apr 2008 07:45:53 +0000 (07:45 +0000)]
2008-04-30  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Rob Buis.

        Fixed crash or assertion if SVG_FOREIGN_OBJECT is not enabled

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 30 Apr 2008 07:45:28 +0000 (07:45 +0000)]
2008-04-30  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Rob Buis.

        Fixed compile, due to API change in XMLSerializer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis@webkit.org [Wed, 30 Apr 2008 06:13:33 +0000 (06:13 +0000)]
    Reviewed by Eric.

        Quirksmode: Ignores media types in stylesheet PIs

        Transfer the xml-stylesheet pseudo attribute media to the css
        stylesheet created from the ProcessingInstruction.

        Tests: fast/css/xml-stylesheet-media-processing.xhtml

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Support text shadow in WebDrawText().
adachan@apple.com [Wed, 30 Apr 2008 03:38:32 +0000 (03:38 +0000)]
    Support text shadow in WebDrawText().
        Remove DrawTextAtPoint() since it is only called by WebDrawText().

        Reviewed by Adam.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:
        * WebKitGraphics.cpp:
        * WebKitGraphics.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago BUILD FIX for export of WTF::RefCounted<WebCore::FormData>::deref()
ddkilzer@apple.com [Wed, 30 Apr 2008 03:27:33 +0000 (03:27 +0000)]
    BUILD FIX for export of WTF::RefCounted<WebCore::FormData>::deref()

        On the buildbot, this is a fatal error:

        ld: symbols names listed in -exported_symbols_list: WebKitBuild/Release/DerivedSources/WebCore/WebCore.exp not in linked objects
        /usr/bin/libtool: internal link edit command failed

        Newer dev tools only produce a warning:

        ld warning: cannot export hidden symbol __ZN3WTF10RefCountedIN7WebCore8FormDataEE5derefEv from WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/i386/DocumentLoader.o

        * WebCore.base.exp: Remove hidden symbol from export list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-29 David D. Kilzer <ddkilzer@apple.com>
ddkilzer@apple.com [Wed, 30 Apr 2008 03:21:19 +0000 (03:21 +0000)]
2008-04-29  David D. Kilzer  <ddkilzer@apple.com>

        BUILD FIX for Release build.

        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
        separately so the compiler doesn't complain about an unused variable.
        (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKit:
andersca@apple.com [Wed, 30 Apr 2008 02:16:31 +0000 (02:16 +0000)]

2008-04-29  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add new event handlers.

        * WebKit.xcodeproj/project.pbxproj:


2008-04-29  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Refactor the Carbon event handling code out into a separate class in preparation for adding
        the Cocoa event handling code.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
        (-[WebBaseNetscapePluginView sendActivateEvent:]):
        (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
        (-[WebBaseNetscapePluginView stopTimers]):
        (-[WebBaseNetscapePluginView restartTimers]):
        (-[WebBaseNetscapePluginView setHasFocus:]):
        (-[WebBaseNetscapePluginView mouseDown:]):
        (-[WebBaseNetscapePluginView mouseUp:]):
        (-[WebBaseNetscapePluginView mouseEntered:]):
        (-[WebBaseNetscapePluginView mouseExited:]):
        (-[WebBaseNetscapePluginView mouseDragged:]):
        (-[WebBaseNetscapePluginView keyUp:]):
        (-[WebBaseNetscapePluginView keyDown:]):
        (-[WebBaseNetscapePluginView cut:]):
        (-[WebBaseNetscapePluginView copy:]):
        (-[WebBaseNetscapePluginView paste:]):
        (-[WebBaseNetscapePluginView selectAll:]):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView stop]):
        (-[WebBaseNetscapePluginView fini]):
        (-[WebBaseNetscapePluginView drawRect:]):
        (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
        (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
        (-[WebBaseNetscapePluginView windowBecameKey:]):
        (-[WebBaseNetscapePluginView windowResignedKey:]):
        (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
        (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
        (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
        (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
        (-[WebBaseNetscapePluginView _viewHasMoved]):
        * Plugins/WebBaseNetscapePluginViewInternal.h:
        * Plugins/WebNetscapePluginEmbeddedView.h:
        * Plugins/WebNetscapePluginEventHandler.h: Added.
        * Plugins/WebNetscapePluginEventHandler.mm: Added.
        * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
        * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ddkilzer@apple.com [Wed, 30 Apr 2008 00:53:29 +0000 (00:53 +0000)]

        * dom/make_names.pl: Added #if ENABLE(DASHBOARD_SUPPORT) to Dashboard code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTop:
ddkilzer@apple.com [Wed, 30 Apr 2008 00:31:10 +0000 (00:31 +0000)]


        * configure.ac: Added conditional for ENABLE_DASHBOARD_SUPPORT.



        * wtf/Platform.h: Defined ENABLE(DASHBOARD_SUPPORT) to 1 only for
        PLATFORM(MAC) and PLATFORM(WIN).  Changed default to 0 for other



        * DerivedSources.make: Removed duplication of targets for
        generating CSSPropertyNames.h and CSSValueKeywords.h.
        * GNUmakefile.am: Ditto.  Added support for ENABLE_DASHBOARD_SUPPORT.
        * WebCore.pro: Added support for ENABLE_DASHBOARD_SUPPORT.
        Made both SVG and non-SVG variables of GENERATOR 6-A use new

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Added missing return.
adachan@apple.com [Wed, 30 Apr 2008 00:13:44 +0000 (00:13 +0000)]
    Added missing return.

        * platform/win/COMPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-29 Alp Toker <alp@nuanti.com>
alp@webkit.org [Wed, 30 Apr 2008 00:07:42 +0000 (00:07 +0000)]
2008-04-29  Alp Toker  <alp@nuanti.com>

        GTK+ build fix attempt following breakage in r32700 which
        conditionalised dashboard support.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Tue, 29 Apr 2008 23:08:14 +0000 (23:08 +0000)]
2008-04-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by David Harrison.

        Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.

        * WebKit.exp:
        * WebView/WebDynamicScrollBarsView.h:
        * WebView/WebDynamicScrollBarsView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-29 Anatoli Papirovski <apapirovski@mac.com>
mitz@apple.com [Tue, 29 Apr 2008 23:00:22 +0000 (23:00 +0000)]
2008-04-29  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dan Bernstein.

        Modified the SVG test case for RGB and RGBA parsing - mixing percentage and
        numerical values is illegal.

        * svg/custom/rgbcolor-syntax.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRestore the beloved COMPtr::operator&
aroben@apple.com [Tue, 29 Apr 2008 22:23:18 +0000 (22:23 +0000)]
Restore the beloved COMPtr::operator&


        Restore the beloved COMPtr::operator&

        * platform/win/COMPtr.h: Removed the HashTableDeletedValueType
        constructor and isHashTableDeletedValue and hashTableDeletedValue
        (WTF::): Changed constructDeletedValue to play nicely with


        Restore the beloved COMPtr::operator&


        Restore the beloved COMPtr::operator&

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixed ChangeLog order
aroben@apple.com [Tue, 29 Apr 2008 21:53:21 +0000 (21:53 +0000)]
Fixed ChangeLog order

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix assertion on launch on Windows
aroben@apple.com [Tue, 29 Apr 2008 21:50:55 +0000 (21:50 +0000)]
    Fix assertion on launch on Windows

        * platform/graphics/win/FontPlatformData.h: Pass
        WTF::HashTableDeletedValue to the m_font constructor instead of a
        bogus -1 value. This is needed because m_font is a RefPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fixes
aroben@apple.com [Tue, 29 Apr 2008 21:48:49 +0000 (21:48 +0000)]
    Windows build fixes

        Replace COMPtr::operator& with COMPtr::adoptionPointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ddkilzer@apple.com [Tue, 29 Apr 2008 21:31:09 +0000 (21:31 +0000)]

2008-04-29  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Darin.

        Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)

        * wtf/Platform.h:


2008-04-29  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Darin.

        Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)

        * DerivedSources.make:
        * WebCore.DashboardSupport.exp: Added.
        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMWindowCustom.cpp:
        * css/CSSComputedStyleDeclaration.cpp:
        * css/CSSParser.cpp:
        * css/CSSPrimitiveValue.cpp:
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        * css/DashboardRegion.h:
        * css/DashboardSupportCSSPropertyNames.in: Added.
        * dom/DOMImplementation.cpp:
        * dom/Document.cpp:
        * dom/Document.h:
        * html/CanvasRenderingContext2D.cpp:
        * html/CanvasRenderingContext2D.h:
        * html/HTMLCanvasElement.cpp:
        * html/HTMLCanvasElement.h:
        * page/Chrome.cpp:
        * page/ChromeClient.h:
        * page/Frame.cpp:
        * page/Frame.h:
        * page/FrameView.cpp:
        * page/FrameView.h:
        * page/Settings.cpp:
        * page/Settings.h:
        * page/mac/EventHandlerMac.mm:
        * page/mac/FrameMac.mm:
        * page/mac/WebDashboardRegion.h:
        * page/mac/WebDashboardRegion.m:
        * rendering/RenderLayer.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:
        * xml/XMLHttpRequest.cpp:


2008-04-29  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Darin.

        Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        * WebView/WebClipView.m:
        (-[WebClipView scrollWheel:]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView addMouseMovedObserver]):
        (-[WebHTMLView removeMouseMovedObserver]):
        (-[WebHTMLView acceptsFirstMouse:]):
        * WebView/WebUIDelegatePrivate.h:
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWindows build fix
aroben@apple.com [Tue, 29 Apr 2008 21:07:07 +0000 (21:07 +0000)]
Windows build fix


        Windows build fix

        This removes COMPtr::operator&, which didn't jive with HashTable. It
        is replaced by COMPtr::adoptionPointer.

        Discussed with Darin Adler and Anders Carlsson.

        * platform/win/COMPtr.h: Replaced operator& with adoptionPointer.


        Windows build fix

        Replaced uses of COMPtr::operator& with COMPtr::adoptionPointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix a Windows build error
aroben@apple.com [Tue, 29 Apr 2008 21:02:37 +0000 (21:02 +0000)]
    Fix a Windows build error

        * WebScriptCallFrame.cpp:
        (WebScriptCallFrame::variableNames): Don't use ::adopt now that
        PropertyNameArray has no swap function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd reflection example photo.
hyatt@apple.com [Tue, 29 Apr 2008 20:49:16 +0000 (20:49 +0000)]
Add reflection example photo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Tue, 29 Apr 2008 20:34:44 +0000 (20:34 +0000)]

2008-04-29  David Hyatt  <hyatt@apple.com>

        Implement the new box-reflect property in CSS.  This property enables real-time reflections on
        objects (yes you can reflect <video>!).

        Reviewed by Dan Bernstein

        Test cases added in fast/reflections/

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * css/CSSComputedStyleDeclaration.cpp:
        * css/CSSParser.cpp:
        * css/CSSParser.h:
        * css/CSSPropertyNames.in:
        * css/CSSReflectValue.cpp: Added.
        * css/CSSReflectValue.h: Added.
        * css/CSSStyleSelector.cpp:
        * css/CSSStyleSelector.h:
        * rendering/InlineFlowBox.cpp:
        * rendering/Length.h:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBox.cpp:
        * rendering/RenderFlexibleBox.cpp:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::operator delete):
        * rendering/RenderLayer.h:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderReplica.cpp: Added.
        * rendering/RenderReplica.h: Added.
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:
        * rendering/RenderTable.cpp:
        * rendering/RenderTableCell.cpp:


2008-04-29  David Hyatt  <hyatt@apple.com>

        Implement support for the new box-reflect property.  Tests of the new property.

        Reviewed by Dan Bernstein

        * fast/reflections: Added.
        * fast/reflections/reflection-computed-style-expected.txt: Added.
        * fast/reflections/reflection-computed-style.html: Added.
        * fast/reflections/reflection-direction.html: Added.
        * fast/reflections/reflection-masks.html: Added.
        * fast/reflections/reflection-nesting.html: Added.
        * fast/reflections/resources: Added.
        * fast/reflections/resources/kate.png: Added.
        * fast/reflections/resources/vignette-mask.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-29 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Tue, 29 Apr 2008 20:27:42 +0000 (20:27 +0000)]
2008-04-29  Beth Dakin  <bdakin@apple.com>

        Reviewed by Alice.

        Initial implementation of the following ARIA roles: button,
        checkbox, heading, link, radio, textbox.

        * html/HTMLAttributeNames.in: Add 'role' to list of attributes.

        * page/AccessibilityObject.cpp:
         When an ARIA role is set, the role overrides whatever the actual

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-29 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 29 Apr 2008 18:09:04 +0000 (18:09 +0000)]
2008-04-29  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Keep call count.

        * profiler/FunctionCallProfile.cpp:
        (KJS::FunctionCallProfile::didExecute): Implements call count and fixed a bug where a stackIndex
        of 0 was causing the assert to be hit.
        * profiler/FunctionCallProfile.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake the exceptions that the InspectorController catches log the
timothy@apple.com [Tue, 29 Apr 2008 17:36:06 +0000 (17:36 +0000)]
Make the exceptions that the InspectorController catches log the
original file and line number, if present on the exception object.

Reviewed by Adam Roben.

* page/InspectorController.cpp:
(WebCore::InspectorController::callFunction): Pass the context to HANDLE_EXCEPTION.
(WebCore::InspectorController::~InspectorController): Ditto.
(WebCore::InspectorController::scriptObjectReady): Ditto.
(WebCore::InspectorController::addScriptResource): Ditto.
(WebCore::InspectorController::updateScriptResourceRequest): Ditto.
(WebCore::InspectorController::updateScriptResourceResponse): Ditto.
(WebCore::InspectorController::updateScriptResource): Ditto.
(WebCore::InspectorController::addDatabaseScriptResource): Ditto.
(WebCore::InspectorController::addScriptConsoleMessage): Ditto.
(WebCore::InspectorController::handleException): Take a context. Pull the line
and sourceURL properties off the exception if it is an object.
* page/InspectorController.h: Change handleException to take a context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove .idl and .in files from WebCore's framework Resources.
timothy@apple.com [Tue, 29 Apr 2008 17:12:09 +0000 (17:12 +0000)]
Remove .idl and .in files from WebCore's framework Resources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes a regression where the Page's debugger would not be reattached
timothy@apple.com [Tue, 29 Apr 2008 17:05:43 +0000 (17:05 +0000)]
Fixes a regression where the Page's debugger would not be reattached
when a new JSDOMWindow is created.

Reviewed by Sam Weinig.

* bindings/js/kjs_proxy.cpp:
(WebCore::KJSProxy::clear): Call attachDebugger after creating the JSDOMWindow.
* history/CachedPage.cpp:
(WebCore::CachedPage::restore): For the case where the CachedPage doesn't
contain a window, reattach the debugger to the new JSDOMWindow by calling
proxy->attachDebugger. Also restore the setPageGroupIdentifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 29 Apr 2008 16:50:58 +0000 (16:50 +0000)]

2008-04-29  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18355
        Fixed RGB and RGBA parsing to ignore the declaration when the value is not
        "either three integer values or three percentage values."

        * css/CSSParser.cpp:


2008-04-29  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18355
        Updated the results of the layout test for "RGB color syntax error handling".

        * platform/mac/css2.1/t040306-syntax-01-f-expected.checksum:
        * platform/mac/css2.1/t040306-syntax-01-f-expected.png:
        * platform/mac/css2.1/t040306-syntax-01-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Tue, 29 Apr 2008 14:41:55 +0000 (14:41 +0000)]
Holger Hans Peter Freyther  <zecke@selfish.org>

Fix crash when setHtml gets called from slots connected to QWebPage::unsupportedContent

Ben found this crash in the demo browser.

In void MainResourceLoader::continueAfterContentPolicy(PolicyAction contentPolicy,

case PolicyDownload:
    frameLoader()->client()->download(m_handle.get(), request(), m_handle.get()->request(), r);

We are in a policy check, the download() call will call setHtml, which will start loading
the data into a frame. The loading will cancel all policy checks and call ResourceLoader::releaseResources
which will set m_frame to 0. Then we return and invoke interruptionForPolicyChangeError() which
will use the m_frame->loader() but it is gone. Do not call into receivedError and
interruptionForPolicyChangeError if we are gone anyway...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoQt/Windows build fix. The externally declared hash tables are actually
hausmann@webkit.org [Tue, 29 Apr 2008 14:34:13 +0000 (14:34 +0000)]
Qt/Windows build fix. The externally declared hash tables are actually
declared const and the const is mangled in the symbol name, so when
importing they also need to be marked const.

When compiling without MULTIPLE_THREADS use a const HashTable&
instead of a HashTable& in ThreadClassInfoHashTables to avoid
initializing the latter with a const reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Tue, 29 Apr 2008 14:16:23 +0000 (14:16 +0000)]
Simon Hausmann  <hausmann@webkit.org>

Updated the layout tests after the latest submits to the Qt port
to our new baseline, after numerous fixes in RenderThemeQt
and assorted.

Updated the Skipped file with new expected failures that need

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLincoln Ramsay <lincoln.ramsay@trolltech.com>
hausmann@webkit.org [Tue, 29 Apr 2008 09:47:55 +0000 (09:47 +0000)]
Lincoln Ramsay <lincoln.ramsay@trolltech.com>

Fix compilation with QT_NO_PRINTER

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Tue, 29 Apr 2008 08:51:42 +0000 (08:51 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Ensure that relative URL is converted to absolute URL.

This is necessary because loading a relative URL is not really supported
(the web page may load, but the subsequent URLs for images and links will
not be resolved properly).
This also fixes https://bugs.webkit.org/show_bug.cgi?id=18484

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Tue, 29 Apr 2008 08:51:29 +0000 (08:51 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Simplification of Qt Launcher (no animation and use standard progress bar widget)

Status bar shows the hovered link without any animation. Progress bar just uses the standard QProgressBar (no custom widget). The launcher is leaner and faster to use under the debugger and/or valgrind.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Tue, 29 Apr 2008 08:51:16 +0000 (08:51 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Update the cursor when the frame/page loading is finished.

This fixes https://bugs.webkit.org/show_bug.cgi?id=18712

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSimon Hausmann <shausman@trolltech.com>
hausmann@webkit.org [Tue, 29 Apr 2008 08:51:02 +0000 (08:51 +0000)]
Simon Hausmann <shausman@trolltech.com>

Fixes: QWebPage::acceptNavigationRequest not being called / linkClicked() not being emitted when clicking on <a href="..." target="_blank"> kind of links.
Call QWebPage::acceptNavigationRequest when the creation of a new window with
URL is requested. The frame pointer is set to null in this case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Tue, 29 Apr 2008 08:47:47 +0000 (08:47 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Rely on auto-boxing of C++ for the QCursor c'tor

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Tue, 29 Apr 2008 08:47:32 +0000 (08:47 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Add the remaining cursors that defaulted to PointerCursor

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Tue, 29 Apr 2008 08:47:12 +0000 (08:47 +0000)]
Holger Hans Peter Freyther  <zecke@selfish.org>

Use the WebCore facility to do the scrolling. Move some code around.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
alice.liu@apple.com [Tue, 29 Apr 2008 08:42:22 +0000 (08:42 +0000)]

2008-04-29  Alice Liu  <alice.liu@apple.com>

        Reviewed by Beth Dakin.

        Comply with HTML5 spec about parsing tabindex property according to
        integer parsing rules

        Test: fast/parser/tabindex-parsing.html

        * html/HTMLElement.cpp:


2008-04-29  Alice Liu  <alice.liu@apple.com>

        Reviewed by Beth Dakin.

        Comply with HTML5 spec about parsing tabindex property according to
        integer parsing rules

        * fast/parser/tabindex-parsing-expected.txt: Added.
        * fast/parser/tabindex-parsing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes: Fix timing problem where scrollbars in subframes were sometimes not property...
hausmann@webkit.org [Tue, 29 Apr 2008 08:36:24 +0000 (08:36 +0000)]
Fixes: Fix timing problem where scrollbars in subframes were sometimes not property repainted.

We need to repaint scrollbars after a geometry change, and also make sure
the computed clipping rect for the corners between scrollbars is propagated
to the chrome client without beeing intersected by the visible content rect
of the frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Tue, 29 Apr 2008 07:49:04 +0000 (07:49 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

fix potential crash when loading image(s)

Crash may occur. If compiled with 4.3, the variable is not initialized.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Tue, 29 Apr 2008 07:43:40 +0000 (07:43 +0000)]
Holger Hans Peter Freyther  <zecke@selfish.org>

Calling QWebView::setCursor will override the WebCore Cursor.
Calling QWebView::setCursor will override the WebCore Cursor using
QWidget::unsetCursor will revert to the WebCore Cursor.

For detecting the unset we have to compare the shape of the
cursor to the default arrow. Qt::WA_SetCursor can not be used
as it is set unconditionally but conditionally removed.

Calling QWidget::setCursor will immediately send the CursorChange
event. We listen to this event to decide if we currently use a
WebCore cursor, got a cursor from outside, or revert to the default.

This should be race free and work reliable, the manual test for this
is WebCore/manual-tests/cursor.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoKavindra Devi Palaraja <kdpalara@trolltech.com>
hausmann@webkit.org [Tue, 29 Apr 2008 07:34:59 +0000 (07:34 +0000)]
Kavindra Devi Palaraja <kdpalara@trolltech.com>

Documentation fixes:

- Fixed a qdoc warning
- Mention that fav icons can be of arbitrary size
- Fix signature of QWebPage::acceptNavigationRequest show in the documentation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
rwlbuis@webkit.org [Tue, 29 Apr 2008 06:14:46 +0000 (06:14 +0000)]
    Reviewed by Maciej.

        Build fix for Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 29 Apr 2008 06:05:37 +0000 (06:05 +0000)]

        Reviewed by Maciej Stachowiak.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18795
          REGRESSION (r32660): Text heavier with text-shadow

        * rendering/InlineTextBox.cpp:
        (WebCore::paintTextWithShadows): The loop was doing one extra pass
        without shadow even in cases where the last pass with a shadow was
        painting the text at the right position (rather than outside the clip).
        Fixed that. The only case where a separate pass without shadow is needed
        is when there is text-stroke, since in that case all shadow passes
        paint the text outside the clip.


        Reviewed by Maciej Stachowiak.

        - updated results for https://bugs.webkit.org/show_bug.cgi?id=18795
          REGRESSION (r32660): Text heavier with text-shadow

        * platform/mac/fast/css/shadow-multiple-expected.checksum:
        * platform/mac/fast/css/shadow-multiple-expected.png:
        * platform/mac/fast/repaint/shadow-multiple-horizontal-expected.checksum:
        * platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png:
        * platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
        * platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
        * platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
        * platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
        * platform/mac/fast/repaint/shadow-multiple-vertical-expected.checksum:
        * platform/mac/fast/repaint/shadow-multiple-vertical-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson@apple.com [Tue, 29 Apr 2008 03:14:28 +0000 (03:14 +0000)]

2008-04-28  Brady Eidson <beidson@apple.com>

        Reviewed by Sam Weinig

        Add Storage.clear(), per updates to HTML5

        Tests: storage/domstorage/localstorage/clear.html

        * storage/LocalStorageArea.cpp:
        * storage/LocalStorageArea.h:

        * storage/SessionStorageArea.cpp:
        * storage/SessionStorageArea.h:

        * storage/Storage.cpp:
        * storage/Storage.h:
        * storage/Storage.idl:

        * storage/StorageArea.cpp:
        * storage/StorageArea.h:


2008-04-28  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Add Storage.clear(), per updates to HTML5

        * storage/domstorage/localstorage/clear-expected.txt: Added.
        * storage/domstorage/localstorage/clear.html: Added.
        * storage/domstorage/sessionstorage/clear-expected.txt: Added.
        * storage/domstorage/sessionstorage/clear.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele@apple.com [Tue, 29 Apr 2008 01:30:20 +0000 (01:30 +0000)]

2008-04-28  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.

        WebCore part of fix for <rdar://problem/3709505>
        Safari should have a way to upload bundles from the file upload control (as zip)

        * WebCore.base.exp: Added symbols.

        * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Ask the application if a file will need to be replaced before it's uploaded.
          It will also give the replacement filename which is used to determine the correct mime-type and to construct the correct header.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::submitForm): Asks the application to generate any files for the form data before a form submission starts.
        (WebCore::FrameLoader::loadItem): ditto.
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::didReceiveResponse): Tells the FormData from the request to remove any generated files if it needs to.
        (WebCore::ResourceLoader::didCancel): ditto.
        (WebCore::ResourceLoader::didFail): ditto.

        * platform/network/FormData.cpp:
        (WebCore::FormData::FormData): Initializes m_hasGeneratedFiles, which keeps track of whether there are files that will need to be removed.
        (WebCore::FormData::~FormData): Added.  Assert that there are no files that need to be removed, but if there are, release builds will still remove them here.
        (WebCore::FormData::appendFile): Passes along a shouldGenerateFile flag to the FormDataElement.
        (WebCore::FormData::generateFiles): Added. Iterates through the FormDataElements, and using the ChromeClient pointer, asks the application to
         create any compressed files so the FormDataElements can store the paths.
        (WebCore::FormData::removeGeneratedFilesIfNeeded): Added.  Removes generated files and their directories (if empty).
        * platform/network/FormData.h:
        (WebCore::FormDataElement::FormDataElement): Added a boolean to track whether the file will need to be generated,
         and a string to hold the path of the generated file.

        * platform/network/mac/FormDataStreamMac.mm:
        (WebCore::advanceCurrentStream): Uses the generated file path instead of the original file path when streaming the file.
        (WebCore::setHTTPBody): Uses the generated file path when determining the size of the file to be uploaded.

        * platform/FileSystem.h: Added directoryName.
        * platform/posix/FileSystemPOSIX.cpp: (WebCore::directoryName): Added.
        * platform/gtk/FileSystemGtk.cpp: (WebCore::directoryName): Added empty implementation.
        * platform/qt/FileSystemQt.cpp: (WebCore::directoryName): ditto.
        * platform/win/FileSystemWin.cpp: (WebCore::directoryName): ditto.
        * platform/wx/FileSystemWx.cpp: (WebCore::directoryName): ditto.

        Added new ChromeClient methods to give the application control over the file compression for uploading.
        * page/Chrome.cpp:
        (WebCore::ChromeClient::shouldReplaceWithGeneratedFileForUpload): Added a default implementation.
        (WebCore::ChromeClient::generateReplacementFile): ditto.
        * page/ChromeClient.h:


2008-04-28  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.

        WebKit part of fix for <rdar://problem/3709505>
        Safari should have a way to upload bundles from the file upload control (as zip)

        Added UIDelegate methods to let the application handle generating replacement files for uploads.
        In this case, Safari will create archived files for bundles so they can be uploaded properly.

        * DefaultDelegates/WebDefaultUIDelegate.m:
        (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
        (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        * WebView/WebUIDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
andersca@apple.com [Tue, 29 Apr 2008 01:28:14 +0000 (01:28 +0000)]

2008-04-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam, Mark, Adele and Darin.

        Add a (currently not called) method for opening the application cache database.

        * WebCore.base.exp:
        * loader/appcache/ApplicationCacheStorage.cpp:
        * loader/appcache/ApplicationCacheStorage.h:


2008-04-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam, Mark, Adele and Darin.

        Initialize the application cache path.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
alice.liu@apple.com [Tue, 29 Apr 2008 01:18:52 +0000 (01:18 +0000)]

2008-04-28  Alice Liu  <alice.liu@apple.com>

        Reviewed by Darin.

        Fix <rdar://problem/4911289> Add tabindex property to all children
        of HTMLElement (7138)

        Test: fast/events/tabindex-focus-blur-all.html

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMPrivate.h:
        -DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h are no
         longer needed

        * bindings/objc/PublicDOMInterfaces.h:
        -Moving focus, blur, tabindex to HTMLElement from its descendants.

        * dom/Node.cpp:
        -The concept of being focusable now needs to account for tabindex

        * dom/Node.h:
        -Need to use a bit to keep track of whether tabindex was explicitly set
         to 0 or was just initialized to 0.
        -Make this virtual so that Anchors and GenericFormElements can determine
         tabindex without accounting for focusability
        -Renamed setTabIndex() to setTabIndexExplicitly() so as not to hide
         behind and/or be confused for HTMLElement::setTabIndex

        * html/HTMLAnchorElement.cpp:
        * html/HTMLAnchorElement.h:
        * html/HTMLGenericFormElement.cpp:
        * html/HTMLGenericFormElement.h:
        -Anchors and form elements are normally focusable, and need to avert the
         check for focusability in HTMLElement::tabIndex
         because tabIndex could be queried before a first layout happens.

        * html/HTMLElement.cpp:
        -Function Node::setTabIndex changed to Node::setTabIndexExplicitly
        -The concept of being focusable now needs to account for tabindex
        -HTML5 specifies that querying tabindex for elements that aren't
         focusable shall return -1
        -New default implementation
        * html/HTMLElement.h:

        * html/HTMLLegendElement.cpp:
        -Now with HTML5's enhanced specification of tabindex, legend elements
         themselves shall focus (if they should), and not the first form element
         they encapsulate.  This matches Firefox behavior.  HTMLLabelElements
         still forward focus to the encapsulated element.  This also matches
         other browsers.

        * html/HTMLAreaElement.cpp:
        * html/HTMLAreaElement.h:
        -HTMLAreaElement isn't subject to the same focusability requirements as
         its parent, HTMLAnchorElement. Default HTMLElement implementation is

        * html/HTMLFieldSetElement.cpp:
        * html/HTMLLegendElement.cpp:
        * html/HTMLOptGroupElement.cpp:
        * html/HTMLOptionElement.cpp:
        -These elements aren't subject to the same focusability requirements as
         their parent, HTMLGenericFormElement. Default HTMLElement
         implementation is desired.

        * html/HTMLAnchorElement.idl:
        * html/HTMLAreaElement.idl:
        * html/HTMLButtonElement.idl:
        * html/HTMLElement.idl:
        * html/HTMLInputElement.idl:
        * html/HTMLLabelElement.idl:
        * html/HTMLLegendElement.idl:
        * html/HTMLObjectElement.idl:
        * html/HTMLSelectElement.idl:
        * html/HTMLTextAreaElement.idl:
        -Moving tabindex attribute, focus and blur methods from descendants of
         HTMLElement to HTMLElement


2008-04-28  Alice Liu  <alice.liu@apple.com>

        Reviewed by Darin.

        Fix <rdar://problem/4911289> Add tabindex property to all children
        of HTMLElement (7138)

        * MigrateHeaders.make:
        Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
        because now that focus() has been moved to DOMHTMLElement.h, these
        files are no longer needed.


2008-04-28  Alice Liu  <alice.liu@apple.com>

        Reviewed by Sam Weinig.

        Fix <rdar://problem/4911289> Add tabindex property to all children
        of HTMLElement (7138)

        minor updates to these existing tests:
        * fast/dom/domListEnumeration-expected.txt:
        * fast/dom/plugin-attributes-enumeration-expected.txt:
        * fast/dom/resources/domListEnumeration.js:

        * fast/events/resources/abe.png: Added.
        * fast/events/resources/tabindex-focus-blur-all-frame1.html: Added.
        * fast/events/resources/tabindex-focus-blur-all-frame2.html: Added.
        * fast/events/resources/tabindex-focus-blur-all-iframe1.html: Added.
        * fast/events/resources/tabindex-focus-blur-all-iframe2.html: Added.
        * fast/events/resources/tabindex-focus-blur-all.js: Added.
        * fast/events/tabindex-focus-blur-all-expected.txt: Added.
        * fast/events/tabindex-focus-blur-all.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Mon, 28 Apr 2008 21:28:51 +0000 (21:28 +0000)]

        Reviewed by Dave Hyatt.

        - support multiple box- and text-shadows

        Tests: fast/css/shadow-multiple.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForShadow): Changed to account for reversing the order
        of the shadow values in the ShadowData list.

        * css/CSSValueList.cpp:
        (WebCore::CSSValueList::prepend): Added.
        * css/CSSValueList.h:

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally): Changed to account for
        all shadows in overflow calculation.
        (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
        (WebCore::InlineFlowBox::paint): Changed to account for all shadows
        when testing for intersection with the damage rect.
        (WebCore::InlineFlowBox::paintTextDecorations): Changed to paint all

        * rendering/InlineTextBox.cpp:
        (WebCore::paintTextWithShadows): Factored out from paint() and changed
        to paint all shadows.
        (WebCore::InlineTextBox::paint): Moved the text painting code out to
        paintTextWithShadows(). Changed to not paint shadows for markers and
        composition underlines and in "force black text" mode.
        (WebCore::InlineTextBox::paintDecoration): Changed to paint all shadows.
        * rendering/InlineTextBox.h: Changed some public methods to private
        or protected.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowHeight): Changed to account for all
        (WebCore::RenderBlock::overflowWidth): Ditto.
        (WebCore::RenderBlock::overflowLeft): Ditto.
        (WebCore::RenderBlock::overflowTop): Ditto.
        (WebCore::RenderBlock::overflowRect): Ditto.
        (WebCore::RenderBlock::layoutBlock): Ditto.

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock): Ditto.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateRects): Ditto.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintBoxShadow): Changed to paint all shadows.
        Changed to avoid clipping out the box if it has a fully opaque
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Changed to account
        for all shadows.
        (WebCore::RenderObject::selectionForegroundColor): Cleaned up.
        (WebCore::RenderObject::adjustRectForOutlineAndShadow): Changed to
        account for all shadows.

        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::adjustOverflowForBoxShadow): Ditto.

        * rendering/RenderStyle.cpp:
        (WebCore::RenderStyle::setTextShadow): Changed to prepend when adding
        so that the stacking order of shadows when painting will be "first o
        (WebCore::RenderStyle::setBoxShadow): Ditto.

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout): Changed to account for all shadows.


        Reviewed by Dave Hyatt.

        - add rendering and invalidation tests for multiple shadows

        * fast/css/shadow-multiple.html: Added.
        * fast/repaint/shadow-multiple-horizontal.html: Added.
        * fast/repaint/shadow-multiple-strict-horizontal.html: Added.
        * fast/repaint/shadow-multiple-strict-vertical.html: Added.
        * fast/repaint/shadow-multiple-vertical.html: Added.
        * platform/mac/fast/css/shadow-multiple-expected.checksum: Added.
        * platform/mac/fast/css/shadow-multiple-expected.png: Added.
        * platform/mac/fast/css/shadow-multiple-expected.txt: Added.
        * platform/mac/fast/repaint/shadow-multiple-horizontal-expected.checksum: Added.
        * platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
        * platform/mac/fast/repaint/shadow-multiple-horizontal-expected.txt: Added.
        * platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
        * platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
        * platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.txt: Added.
        * platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
        * platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
        * platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.txt: Added.
        * platform/mac/fast/repaint/shadow-multiple-vertical-expected.checksum: Added.
        * platform/mac/fast/repaint/shadow-multiple-vertical-expected.png: Added.
        * platform/mac/fast/repaint/shadow-multiple-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix some more Windows build errors in COMPtr
aroben@apple.com [Mon, 28 Apr 2008 19:47:23 +0000 (19:47 +0000)]
    Fix some more Windows build errors in COMPtr

        * platform/win/COMPtr.h:
        (WTF::): Define DefaultHash<COMPtr<P> > by using PtrHash<COMPtr<P> >,
        which is just a copy of PtrHash<RefPtr<P> >.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix some Windows build errors in WebKit
aroben@apple.com [Mon, 28 Apr 2008 19:39:43 +0000 (19:39 +0000)]
    Fix some Windows build errors in WebKit

        * Interfaces/WebKit.idl: Touched to force Interfaces to rebuild.
        * WebKitPrefix.cpp: Touched to force WebKit to rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix some Windows build errors in COMPtr
aroben@apple.com [Mon, 28 Apr 2008 19:28:20 +0000 (19:28 +0000)]
    Fix some Windows build errors in COMPtr

        * platform/win/COMPtr.h: Explicitly name the WTF namespace when using

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix some Windows build errors in FontPlatfomrData
aroben@apple.com [Mon, 28 Apr 2008 19:22:38 +0000 (19:22 +0000)]
    Fix some Windows build errors in FontPlatfomrData

        * platform/graphics/win/FontPlatformData.h: Removed the Deleted
        constructor and replaced it with a HashTableDeletedValueType
        constructor. Also added isHashTableDeletedValue() and

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Mon, 28 Apr 2008 19:14:20 +0000 (19:14 +0000)]

2008-04-28  David Hyatt  <hyatt@apple.com>


        Canvas can't draw itself into its own buffer.  Make sure the dirtying call comes after the image()
        has been accessed.  Technically willDraw should be renamed to didDraw and all calls should be moved
        to after draws have occurred (since if the draw op itself wants to reference the image it shouldn't get
        a dirty copy either), but I'll take that up with olliej when he wakes up. :)

        Reviewed by Dan Bernstein

        Added fast/canvas/canvasDrawsIntoSelf.html

        * html/CanvasRenderingContext2D.cpp:


2008-04-28  David Hyatt  <hyatt@apple.com>

        Add layout test for canvas self-drawing bug.

        Reviewed by Dan Bernstein

        * fast/canvas/canvasDrawingIntoSelf.html: Added.
        * platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.checksum: Added.
        * platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
        * platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix.
ap@webkit.org [Mon, 28 Apr 2008 19:12:43 +0000 (19:12 +0000)]
    Windows build fix.

        * kjs/ExecState.h: For whatever reason, MSVC couldn't generate a default constructor for
        a struct that had a "const List" member. Removing the const qualifier makes the problem go away.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen.
ap@webkit.org [Mon, 28 Apr 2008 18:58:11 +0000 (18:58 +0000)]
    Reviewed by Geoff Garen.

        <rdar://problem/5825192> Replace use of Gestalt with BSD sysctl

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::isAvailable): There is no need to check QuickTime version post-Tiger,
        as it will never be below 7.3 again. This change may make library loading happen earlier in
        some cases, hopefully, that's not a big deal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Mon, 28 Apr 2008 18:22:14 +0000 (18:22 +0000)]
    Reviewed by Darin.

        Fix run-webkit-tests --threading
        and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
        Proxy server issue in Sunday's Nightly

        Changed ClassInfo objects for built-in objects to hold a getter function returning
        a per-thread instance. This makes it safe to share these ClassInfo objects between threads -
        and these are the only ones that need to be shared.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Mon, 28 Apr 2008 18:15:34 +0000 (18:15 +0000)]

2008-04-28  David Hyatt  <hyatt@apple.com>


        The arguments in drawImage were reversed when I switched away from the image buffer method.

        Reviewed by Tim Hatcher

        Added fast/canvas/drawImage.html

        * html/CanvasRenderingContext2D.cpp:


2008-04-28  David Hyatt  <hyatt@apple.com>

        Add layout test for canvas.

        Reviewed by Tim Hatcher

        * fast/canvas/drawImage.html: Added.
        * platform/mac/fast/canvas/drawImage-expected.checksum: Added.
        * platform/mac/fast/canvas/drawImage-expected.png: Added.
        * platform/mac/fast/canvas/drawImage-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-28 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 28 Apr 2008 17:18:15 +0000 (17:18 +0000)]
2008-04-28  Darin Adler  <darin@apple.com>

        Reviewed by Adam.

        - make sure RefPtr's default hash doesn't ref/deref when computing the hash
        - remove remnants of the hash table storage type optimization

        * wtf/HashFunctions.h: Used "using" to get the hash and equal functions
        from PtrHash<P*> into PtrHash<RefPtr<P>>.

        * wtf/HashMap.h: Replaced uses of PairBaseHashTraits with PairHashTraits.
        Eliminated storage-related typedefs. Removed constructor, destructor,
        copy constructor, and destructor since the compiler-generated ones are
        fine. Removed refAll and derefAll. Took out unnnecessary typecasts.
        Removed use of RefCounter.

        * wtf/HashSet.h: Eliminated storage-related typedefs. Removed constructor,
        destructor, copy constructor, and destructor since the compiler-generated
        ones are fine. Removed refAll and derefAll. Removed unneeded template
        arguents from HashSetTranslatorAdapter. Eliminated unneeded HashSetTranslator

        * wtf/HashTable.h: Tweaked formatting. Removed NeedsRef, RefCounterBase,
        RefCounter, HashTableRefCounterBase, HashTableRefCounter, and Assigner
        class templates.

        * wtf/HashTraits.h: Removed StorageTraits, needsRef, PairBaseHashTraits,
        and HashKeyStorageTraits.

        * wtf/RefPtrHashMap.h: Made all the same fixes as in HashMap. Also made
        the corresponding changes to RefPtrHashMapRawKeyTranslator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-28 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 28 Apr 2008 17:06:57 +0000 (17:06 +0000)]
2008-04-28  Darin Adler  <darin@apple.com>

        Reviewed by Adam.

        - fix Windows build

        * win/tools/vsprops/common.vsprops: Add warning 4344 to the list of disabled warnings.
        It's really a warning about a bug they fixed in MSVC -- not helpful to us in WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-28 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 28 Apr 2008 16:54:24 +0000 (16:54 +0000)]
2008-04-28  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - fix assertion hit every time you view www.apple.com

        * kjs/PropertyNameArray.cpp:
        (KJS::PropertyNameArray::add): Changed assertion to allow null and empty strings.
        Now to find out why we have a property named "" and if that's a bug!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Mon, 28 Apr 2008 15:25:12 +0000 (15:25 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Fix the crash on http://www.orad.pl. We called end too early.

    1. we need a ::write that will pause the parser due a pending
    2. we need a second write to queue data (tricky part)
    3. we need to get a finish call (document loaded)
    4. we resume the script and parse, schedule loading of a new script
       and have called end
    5. we resume the new script and we get a crash

This bug is hard to trigger, e.g. if the web server is only allowing
one connection per client/IP. This is why we need to sleep in the scripts. We
want to make sure that the page is first fully received before serving the

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Mon, 28 Apr 2008 15:24:48 +0000 (15:24 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Update the Skipped list, we pass most of the http/tests/misc

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Mon, 28 Apr 2008 15:24:34 +0000 (15:24 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Reset dumping resource load callbacks to false for the next test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAriya Hidayat <ahidayat@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 15:14:58 +0000 (15:14 +0000)]
Ariya Hidayat <ahidayat@trolltech.com>

Fix rounded corner on combo box with CSS border

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 15:14:38 +0000 (15:14 +0000)]
Tor Arne Vestbø  <tavestbo@trolltech.com>

Fix QWebView::loadFinished isn't always emitted

Replaced loadDone() with loadFinished(bool) and moved the signals for progress
tracking (start, progres, and finish) to the page instead of the frame. This
ensures that we emit loadFinished even when a subframe started the actual load.

This causes a few regressions in the layout tests that we for now accept for
the sake of the correct API. Layout tests we can fix any time though, including
patch release, the API however we can't change anymore in patch releases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAriya Hidayat <ahidayat@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 15:09:38 +0000 (15:09 +0000)]
Ariya Hidayat <ahidayat@trolltech.com>

Fix CSS border does not show up for combo boxes

Do not clear the border when painting the combo box for 'select' form element

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoKavindra Devi Palaraja <kdpalara@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 15:09:22 +0000 (15:09 +0000)]
Kavindra Devi Palaraja  <kdpalara@trolltech.com>

Added more documentation for QWebSettings, QWebPluginFactory and QWebFrame

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAriya Hidayat <ahidayat@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 15:09:02 +0000 (15:09 +0000)]
Ariya Hidayat <ahidayat@trolltech.com>

Fix document/frame title not reset when loading a new URI

We should assume first the frame has no title. If it has, then the dispatchDidReceiveTitle()
will be called very soon with the correct title.
This properly resets the title when we navigate to a URI without a title.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOlivier Goffart <ogoffart@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 15:08:46 +0000 (15:08 +0000)]
Olivier Goffart <ogoffart@trolltech.com>

Avoid comparing to 0 in qFuzzyCompare for increased
numeric stability.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDavid Boddie <dboddie@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 14:51:23 +0000 (14:51 +0000)]
David Boddie  <dboddie@trolltech.com>

Minor documentation changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 14:51:11 +0000 (14:51 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fixes: Pages returning 404 with content are not displayed.
A web page that returns 404 can still have content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoPaul Olav Tvete <paul@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 14:50:51 +0000 (14:50 +0000)]
Paul Olav Tvete <paul@trolltech.com>

Fix compiler warning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 14:29:57 +0000 (14:29 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Prevent middle-click from triggering open URL from clipboard when the event has already been accepted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 14:29:32 +0000 (14:29 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Fix scrollbar behavior in QtWebKit to match QScrollBar.

Right click context menu is now supported, along with
middle click to center slider thumb over mouse cursor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 14:24:42 +0000 (14:24 +0000)]
Tor Arne Vestbø  <tavestbo@trolltech.com>

Implemented channel-based logging for QtWebKit.

Comma-separated log channels are read from the QT_WEBKIT_LOG environment variable.
Warnings for notImplemented() is still output by default, but can be disabled

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSimon Hausmann <shausman@trolltech.com>
hausmann@webkit.org [Mon, 28 Apr 2008 13:52:56 +0000 (13:52 +0000)]
Simon Hausmann <shausman@trolltech.com>

Removed setHtml(const QByteArray &) overload as it breaks the common use of the setHtml() API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32632 268f45cc-cd09-0410-ab3c-d52691b4dbfc