adele [Sat, 16 Dec 2006 09:50:46 +0000 (09:50 +0000)]
Reviewed by Adam.
WebKitLibraries part of fix for:
<rdar://problem/
4463829> Switch to use new search field implementation for <input type="search">
Added wkDrawTextFieldCellFocusRing.
* WebKitSystemInterface.h:
* libWebKitSystemInterface.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Sat, 16 Dec 2006 09:33:51 +0000 (09:33 +0000)]
WebCore:
Reviewed by Adam (and partially Geoff).
Primarily, this patch gives WebCore context menus the ability to
enable/disable and set state. It does a few other things along the
way, though. Some of the more noticeable things:
-Re-architects the ContextMenuItem class a bit so that the
ownership model is a bit less confusing. ContextMenuItem is
now *purely* a wrapper for the platformDescription. There
are no other member variables. If you ever need the
platformDescription outside of the MenuItem class, you have
to call releasePlatformDescription(), which transfers
ownership of the platformDescription to the caller.
-Moves fontForSelection() from FrameMac into Editor.cpp.
Turns out I don't need to use this function for my patch
after all, but it doesn't seem like a terrible idea to move
it anyway since we seem to be moving things from FrameMac
into Editor these days anyway.
WebKit:
Reviewed by Adam.
WebKit side of making WebCore context menus support state and
enabled/disabled.
* WebCoreSupport/WebContextMenuClient.h: contextMenuItemSelected
takes a pointer to the parentMenu now since menu items no longer
hold onto it.
* WebCoreSupport/WebContextMenuClient.mm: Same.
(WebContextMenuClient::contextMenuItemSelected): Same.
* WebView/WebHTMLView.m: Must call setAutoenablesItems:NO on our
menu.
(-[NSArray menuForEvent:]):
* WebView/WebUIDelegatePrivate.h: No need for if-def.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 16 Dec 2006 02:50:12 +0000 (02:50 +0000)]
2006-12-15 MorganL <morganl.webkit@yahoo.com>
Reviewed by Oliver.
Allow images to load into frames again. Tidy up code a bit and
add some much needed documentation.
* platform/MimeTypeRegistry.cpp:
(WebCore::initialiseSupportedImageMIMETypes):
(WebCore::initialiseSupportedNonImageMimeTypes):
* platform/MimeTypeRegistry.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 16 Dec 2006 00:41:15 +0000 (00:41 +0000)]
Fix build.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::response):
(WebCore::DocumentLoader::setResponse):
(WebCore::DocumentLoader::isStopping):
(WebCore::DocumentLoader::mainDocumentError):
* loader/DocumentLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 16 Dec 2006 00:05:59 +0000 (00:05 +0000)]
WebCore:
Reviewed by Geoff.
More loader cleanup.
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::isStopping):
(WebCore::DocumentLoader::response):
(WebCore::DocumentLoader::mainDocumentError):
(WebCore::DocumentLoader::setResponse):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/mac/DocumentLoaderMac.mm:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::prepareForLoadStart):
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::setResponse):
* loader/mac/ImageDocumentMac.mm:
(WebCore::finishImageLoad):
WebKit:
Reviewed by Geoff.
Update for WebCore changes.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
* WebView/WebDataSource.mm:
(-[WebDataSource response]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 15 Dec 2006 22:58:57 +0000 (22:58 +0000)]
* loader/DocumentLoader.h:
Whoops, didn't mean to commit this.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 15 Dec 2006 22:57:28 +0000 (22:57 +0000)]
Reviewed by Darin and Brady (in no particular order).
More loader cleanup.
* loader/FrameLoader.h:
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::cancelledError):
(WebCore::FrameLoader::fileDoesNotExistError):
(WebCore::FrameLoader::cannotShowMIMEType):
(WebCore::FrameLoader::interruptionForPolicyChangeError):
* loader/mac/MainResourceLoaderMac.mm:
* loader/mac/NetscapePlugInStreamLoaderMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 15 Dec 2006 22:02:14 +0000 (22:02 +0000)]
Try to fix Windows build: add EventTarget.{h,cpp}.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 15 Dec 2006 21:49:43 +0000 (21:49 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11610
XMLHttpRequest.onreadystatechange doesn't provide access to the request object
Created a separate EventTarget class, now that EventTargetNode isn't the only kind.
WebCore:
* WebCore.xcodeproj/project.pbxproj: Added EventTarget.{h,cpp}
* bindings/js/kjs_dom.cpp:
(KJS::toJS): Added an EventTarget variant.
* bindings/js/kjs_dom.h: Added toJS() for EventTarget; some minor style fixes.
* bindings/objc/DOM.mm:
(+[DOMNode _eventTargetWith:WebCore::]):
* bindings/scripts/CodeGeneratorObjC.pm:
Added an EventTarget->DOMEventTarget converter in DOMNode (WebCoreInternal).
It only works for nodes, since we don't have an ObjC binding for XMLHttpRequest.
Corrected spelling of internalHeaderContent.
* dom/Event.cpp:
(WebCore::Event::setTarget):
* dom/Event.h:
(WebCore::Event::target):
(WebCore::Event::currentTarget):
(WebCore::Event::setCurrentTarget):
These methods now work with EventTargets instead of Nodes.
* dom/EventTarget.cpp: Added.
(WebCore::EventTarget::~EventTarget):
(WebCore::EventTarget::toNode):
(WebCore::EventTarget::toXMLHttpRequest):
* dom/EventTarget.h: Added.
(WebCore::EventTarget::ref):
(WebCore::EventTarget::deref):
Originally, my intention was to share much of the implementation between
EventTargetNode and XHR, but now I don't see anything substantial worth sharing.
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::dispatchGenericEvent): Cast Node to EventTargetNode.
* dom/EventTargetNode.h: Made EventTarget methods virtual.
(WebCore::EventTargetNode::toNode): Added poor man's RTTI to upcast from EventTarget.
(WebCore::EventTargetNode::refEventTarget):
(WebCore::EventTargetNode::derefEventTarget):
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::toElement):
(WebCore::MouseEvent::fromElement):
* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::receivedTarget):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::defaultEventHandler):
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::defaultEventHandler):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::handleContextMenuEvent):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::mouseEventIsInThumb):
Cast from EventTarget to Node as appropriate.
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::dispatchEvent):
(WebCore::XMLHttpRequest::callReadyStateChangeListener):
Set target and currentTarget before dispatching.
* xml/xmlhttprequest.h: Made EventTarget methods virtual, added a bool tempEvent parameter
to match EventTargetNode.
(WebCore::XMLHttpRequest::toXMLHttpRequest): Added poor man's RTTI to upcast from EventTarget.
(WebCore::XMLHttpRequest::refEventTarget):
(WebCore::XMLHttpRequest::derefEventTarget):
LayoutTests:
* fast/dom/xmlhttprequest-get-expected.txt:
* http/tests/xmlhttprequest/event-target-expected.txt:
* http/tests/xmlhttprequest/event-target.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 15 Dec 2006 21:08:11 +0000 (21:08 +0000)]
WebCore:
Reviewed by Darin.
More loader cleanup, use KURL instead of NSURL in a couple of places.
* loader/DocumentLoader.h:
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/ResourceLoader.h:
* loader/mac/DocumentLoaderMac.mm:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::prepareForLoadStart):
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::willUseArchive):
* loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::load):
WebKit:
Reviewed by Darin.
Update for WebCore changes.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::willUseArchive):
* WebView/WebDataSource.mm:
(-[WebDataSource _URLForHistory]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 15 Dec 2006 20:40:38 +0000 (20:40 +0000)]
2006-12-15 Marvin Decker <marv.decker@gmail.com>
Reviewed by Darin and Alexey.
Fix the Windows build, move various Client implementations out of
WebCore and into WebKit.
WebCore:
* WebCore.vcproj/WebCore/WebCore.vcproj:
* bridge/win/ChromeClientWin.h: Removed.
* bridge/win/ContextMenuClientWin.h: Removed.
* bridge/win/EditorClientWin.h: Removed.
* bridge/win/FrameWin.cpp:
(WebCore::FrameWin::FrameWin):
* bridge/win/FrameWin.h:
* loader/win/FrameLoaderClientWin.cpp: Removed.
* loader/win/FrameLoaderClientWin.h: Removed.
* platform/network/win/ResourceHandleWin.cpp:
(WebCore::ResourceHandle::start):
* platform/win/TemporaryLinkStubs.cpp:
(WebCore::DocumentLoader::URL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::createFrame):
(WebCore::FrameLoader::loadResourceSynchronously):
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::~Pasteboard):
(WebCore::PolicyCheck::call):
(WebCore::PopupMenu::PopupMenu):
(WebCore::ResourceHandle::loadsBlocked):
(WebCore::ResourceLoader::cancel):
WebKit:
* COM/ChromeClientWin.cpp: Added.
(ChromeClientWin::~ChromeClientWin):
(ChromeClientWin::chromeDestroyed):
(ChromeClientWin::setWindowRect):
(ChromeClientWin::windowRect):
(ChromeClientWin::pageRect):
(ChromeClientWin::scaleFactor):
(ChromeClientWin::focus):
(ChromeClientWin::unfocus):
(ChromeClientWin::createWindow):
(ChromeClientWin::createModalDialog):
(ChromeClientWin::show):
(ChromeClientWin::canRunModal):
(ChromeClientWin::runModal):
(ChromeClientWin::setToolbarsVisible):
(ChromeClientWin::toolbarsVisible):
(ChromeClientWin::setStatusbarVisible):
(ChromeClientWin::statusbarVisible):
(ChromeClientWin::setScrollbarsVisible):
(ChromeClientWin::scrollbarsVisible):
(ChromeClientWin::setMenubarVisible):
(ChromeClientWin::menubarVisible):
(ChromeClientWin::setResizable):
(ChromeClientWin::addMessageToConsole):
* COM/ChromeClientWin.h: Added.
* COM/ContextMenuClientWin.cpp: Added.
(ContextMenuClientWin::~ContextMenuClientWin):
(ContextMenuClientWin::contextMenuDestroyed):
(ContextMenuClientWin::addCustomContextMenuItems):
(ContextMenuClientWin::contextMenuItemSelected):
(ContextMenuClientWin::copyLinkToClipboard):
(ContextMenuClientWin::downloadURL):
(ContextMenuClientWin::copyImageToClipboard):
(ContextMenuClientWin::lookUpInDictionary):
(ContextMenuClientWin::speak):
(ContextMenuClientWin::stopSpeaking):
* COM/ContextMenuClientWin.h: Added.
* COM/EditorClientWin.cpp: Added.
(EditorClientWin::~EditorClientWin):
(EditorClientWin::pageDestroyed):
(EditorClientWin::shouldDeleteRange):
(EditorClientWin::shouldShowDeleteInterface):
(EditorClientWin::smartInsertDeleteEnabled):
(EditorClientWin::isContinuousSpellCheckingEnabled):
(EditorClientWin::toggleContinuousSpellChecking):
(EditorClientWin::isGrammarCheckingEnabled):
(EditorClientWin::toggleGrammarChecking):
(EditorClientWin::spellCheckerDocumentTag):
(EditorClientWin::selectWordBeforeMenuEvent):
(EditorClientWin::isEditable):
(EditorClientWin::shouldBeginEditing):
(EditorClientWin::shouldEndEditing):
(EditorClientWin::shouldInsertNode):
(EditorClientWin::shouldInsertText):
(EditorClientWin::shouldApplyStyle):
(EditorClientWin::didBeginEditing):
(EditorClientWin::respondToChangedContents):
(EditorClientWin::didEndEditing):
(EditorClientWin::registerCommandForUndo):
(EditorClientWin::registerCommandForRedo):
(EditorClientWin::clearUndoRedoOperations):
(EditorClientWin::canUndo):
(EditorClientWin::canRedo):
(EditorClientWin::undo):
(EditorClientWin::redo):
* COM/EditorClientWin.h: Added.
* COM/WebFrame.cpp:
(WebFrame::WebFrame):
(WebFrame::initWithName):
* COM/WebFrame.h:
* COM/WebFrameLoaderClient.cpp: Added.
(WebFrameLoaderClient::WebFrameLoaderClient):
(WebFrameLoaderClient::~WebFrameLoaderClient):
(WebFrameLoaderClient::frameLoaderDestroyed):
(WebFrameLoaderClient::hasWebView):
(WebFrameLoaderClient::hasFrameView):
(WebFrameLoaderClient::hasBackForwardList):
(WebFrameLoaderClient::resetBackForwardList):
(WebFrameLoaderClient::provisionalItemIsTarget):
(WebFrameLoaderClient::loadProvisionalItemFromPageCache):
(WebFrameLoaderClient::invalidateCurrentItemPageCache):
(WebFrameLoaderClient::privateBrowsingEnabled):
(WebFrameLoaderClient::makeDocumentView):
(WebFrameLoaderClient::makeRepresentation):
(WebFrameLoaderClient::forceLayout):
(WebFrameLoaderClient::forceLayoutForNonHTML):
(WebFrameLoaderClient::updateHistoryForCommit):
(WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
(WebFrameLoaderClient::updateHistoryForReload):
(WebFrameLoaderClient::updateHistoryForStandardLoad):
(WebFrameLoaderClient::updateHistoryForInternalLoad):
(WebFrameLoaderClient::updateHistoryAfterClientRedirect):
(WebFrameLoaderClient::setCopiesOnScroll):
(WebFrameLoaderClient::tokenForLoadErrorReset):
(WebFrameLoaderClient::resetAfterLoadError):
(WebFrameLoaderClient::doNotResetAfterLoadError):
(WebFrameLoaderClient::willCloseDocument):
(WebFrameLoaderClient::detachedFromParent1):
(WebFrameLoaderClient::detachedFromParent2):
(WebFrameLoaderClient::detachedFromParent3):
(WebFrameLoaderClient::detachedFromParent4):
(WebFrameLoaderClient::loadedFromPageCache):
(WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
(WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebFrameLoaderClient::dispatchDidCancelClientRedirect):
(WebFrameLoaderClient::dispatchWillPerformClientRedirect):
(WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebFrameLoaderClient::dispatchWillClose):
(WebFrameLoaderClient::dispatchDidReceiveIcon):
(WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebFrameLoaderClient::dispatchDidCommitLoad):
(WebFrameLoaderClient::dispatchDidFinishLoad):
(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::dispatchShow):
(WebFrameLoaderClient::cancelPolicyCheck):
(WebFrameLoaderClient::dispatchWillSubmitForm):
(WebFrameLoaderClient::dispatchDidLoadMainResource):
(WebFrameLoaderClient::clearLoadingFromPageCache):
(WebFrameLoaderClient::isLoadingFromPageCache):
(WebFrameLoaderClient::revertToProvisionalState):
(WebFrameLoaderClient::clearUnarchivingState):
(WebFrameLoaderClient::progressStarted):
(WebFrameLoaderClient::progressCompleted):
(WebFrameLoaderClient::setMainFrameDocumentReady):
(WebFrameLoaderClient::willChangeTitle):
(WebFrameLoaderClient::didChangeTitle):
(WebFrameLoaderClient::finishedLoading):
(WebFrameLoaderClient::finalSetupForReplace):
(WebFrameLoaderClient::setDefersLoading):
(WebFrameLoaderClient::isArchiveLoadPending):
(WebFrameLoaderClient::cancelPendingArchiveLoad):
(WebFrameLoaderClient::clearArchivedResources):
(WebFrameLoaderClient::canHandleRequest):
(WebFrameLoaderClient::canShowMIMEType):
(WebFrameLoaderClient::representationExistsForURLScheme):
(WebFrameLoaderClient::generatedMIMETypeForURLScheme):
(WebFrameLoaderClient::frameLoadCompleted):
(WebFrameLoaderClient::restoreScrollPositionAndViewState):
(WebFrameLoaderClient::provisionalLoadStarted):
(WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
(WebFrameLoaderClient::addHistoryItemForFragmentScroll):
(WebFrameLoaderClient::didFinishLoad):
(WebFrameLoaderClient::prepareForDataSourceReplacement):
(WebFrameLoaderClient::setTitle):
(WebFrameLoaderClient::userAgent):
* COM/WebFrameLoaderClient.h: Added.
* COM/WebKitDLL.h:
* WebKit.vcproj/WebKit.vcproj:
WebKitTools:
* Spinneret/Spinneret.sln:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 15 Dec 2006 20:11:26 +0000 (20:11 +0000)]
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11842
REGRESSION: Using Safari's snippet editor leaves applewebdata: URLs in history
* loader/mac/DocumentLoaderMac.mm:
(WebCore::DocumentLoader::URLForHistory):
Don't return appleweburls without an unreachable url.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 15 Dec 2006 19:48:34 +0000 (19:48 +0000)]
WebCore:
Reviewed by Darin.
Replace more instances of NSError with ResourceError.
Also remove a check for a selector that was added pre-Tiger.
* WebCore.exp:
* loader/DocumentLoader.h:
* loader/FrameLoader.h:
* loader/ResourceLoader.h:
* loader/mac/DocumentLoaderMac.mm:
(WebCore::DocumentLoader::setMainDocumentError):
(WebCore::DocumentLoader::mainDocumentError):
(WebCore::DocumentLoader::clearErrors):
(WebCore::DocumentLoader::mainReceivedError):
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::cancelMainResourceLoad):
(WebCore::FrameLoader::opened):
(WebCore::FrameLoader::mainReceivedError):
(WebCore::FrameLoader::cancelledError):
(WebCore::FrameLoader::fileDoesNotExistError):
(WebCore::FrameLoader::handleUnimplementablePolicy):
(WebCore::FrameLoader::setMainDocumentError):
(WebCore::FrameLoader::mainReceivedCompleteError):
(WebCore::FrameLoader::sendRemainingDelegateMessages):
(WebCore::FrameLoader::requestFromDelegate):
(WebCore::FrameLoader::loadedResourceFromMemoryCache):
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didCancel):
(WebCore::ResourceLoader::cancel):
(WebCore::ResourceLoader::cancelledError):
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::didCancel):
WebKit:
Reviewed by Darin.
Include ResourceError.h.
* Plugins/WebNetscapePluginStream.mm:
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 15 Dec 2006 19:31:43 +0000 (19:31 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11824
CSSStyleSheet.title property is always null
Set title on the stylesheet just after creating it, for the HTML
elements <link> and <style>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Fri, 15 Dec 2006 12:26:41 +0000 (12:26 +0000)]
Fix compilation (from lars)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 15 Dec 2006 04:04:29 +0000 (04:04 +0000)]
WebCore:
Reviewed by Maciej.
Use char* pointer + length instead of NSData in a bunch of places.
* loader/DocumentLoader.h:
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/MainResourceLoader.h:
* loader/NetscapePlugInStreamLoader.h:
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::willStopBufferingData):
* loader/SubresourceLoader.h:
* loader/mac/DocumentLoaderMac.mm:
(WebCore::DocumentLoader::commitLoad):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::didReceiveData):
(WebCore::FrameLoader::receivedData):
(WebCore::FrameLoader::committedLoad):
* loader/mac/MainResourceLoaderMac.mm:
(WebCore::MainResourceLoader::addData):
(WebCore::MainResourceLoader::didReceiveData):
* loader/mac/NetscapePlugInStreamLoaderMac.mm:
(WebCore::NetscapePlugInStreamLoader::didReceiveData):
* loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::addData):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::willStopBufferingData):
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::didReceiveData):
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::willStopBufferingData):
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
WebKit:
Reviewed by Maciej.
Update for WebCore changes.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::incrementProgress):
(WebFrameLoaderClient::committedLoad):
(WebFrameLoaderClient::deliverArchivedResources):
* WebView/WebView.mm:
(-[WebView _incrementProgressForIdentifier:length:]):
* WebView/WebViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 15 Dec 2006 04:02:56 +0000 (04:02 +0000)]
Reviewed by Adam.
Added PopupMenuClient class so the PopupMenu class no longer needs to know
about the RenderMenuList or the DOM.
* platform/PopupMenu.h:
(WebCore::PopupMenuClient::~PopupMenuClient):
(WebCore::PopupMenu::create): Made this protected so PopupMenu can be subclassed.
(WebCore::PopupMenu::disconnectClient): Renamed from disconnectMenuList.
(WebCore::PopupMenu::client): Added.
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::PopupMenu): Created using PopupMenuClient instead of RenderMenuList.
(WebCore::PopupMenu::populate): Asks the client for info about the list items instead of looking at the DOM or the renderer.
(WebCore::PopupMenu::show): ditto.
(WebCore::PopupMenu::hide): ditto.
* rendering/RenderMenuList.h: Now also inherits from PopupMenuClient.
(WebCore::RenderMenuList::shouldPopOver): Added. Tells the popup whether the menu should pop over the client, or under.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::~RenderMenuList): Calls disconnectClient().
(WebCore::RenderMenuList::calcMinMaxWidth): Removed unnecessary (and harmful) call to updateFromElement. updateFromElmeent
can add children, and you don't want to do that in the middle of calculating width.
(WebCore::RenderMenuList::itemText): Added PopupClient method to provide information about the items in the menu list.
(WebCore::RenderMenuList::itemIsEnabled): ditto.
(WebCore::RenderMenuList::itemStyle): ditto.
(WebCore::RenderMenuList::clientStyle): ditto.
(WebCore::RenderMenuList::clientDocument): ditto.
(WebCore::RenderMenuList::clientPaddingLeft): ditto.
(WebCore::RenderMenuList::clientPaddingRight): ditto.
(WebCore::RenderMenuList::listSize): ditto.
(WebCore::RenderMenuList::selectedIndex): ditto.
(WebCore::RenderMenuList::itemIsSeparator): ditto.
(WebCore::RenderMenuList::itemIsLabel): ditto.
(WebCore::RenderMenuList::itemIsSelected): ditto.
(WebCore::RenderMenuList::setTextFromItem): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 15 Dec 2006 03:43:51 +0000 (03:43 +0000)]
LayoutTests:
Updated these results now that I've rolled out my change to move focus
to the page level:
* editing/undo/undo-iframe-location-change-expected.txt:
* fast/forms/focus2-expected.txt:
Added this test for one of the regressions that moving focus to the page
level caused:
* editing/selection/inactive-selection-expected.txt: Added.
* editing/selection/inactive-selection.html: Added.
WebCore:
Fixed <rdar://problem/
4882713> GMAIL (REGRESSION): Can't apply font style,
foreground or background to selected text
Also <rdar://problem/
4883751> REGRESSION: Caret fails to insert itself
automatically in a new note window
I'm rolling out my change to move focus to the page level because it caused
too many unexpected and bizarre regressions. Our code relies on focus
being per-document so that it can make focus changes that are effectively
no-ops, and so that it can conflate focus and selection in some cases (a bad
idea, since they're not the same).
Hopefully we can revisit this, along with hover and active, in the future.
* dom/Document.cpp:
(WebCore::widgetForNode):
(WebCore::relinquishesEditingFocus):
(WebCore::acceptsEditingFocus):
(WebCore::clearSelectionIfNeeded):
(WebCore::Document::removedLastRef):
(WebCore::Document::detach):
(WebCore::Document::focusedNodeDetached):
(WebCore::Document::setFocusedNode):
* dom/Document.h:
(WebCore::Document::focusedNode):
* page/FocusController.cpp:
* page/FocusController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 15 Dec 2006 03:14:13 +0000 (03:14 +0000)]
Reviewed by Geoff.
- fix failing drag & drop layout tests
* platform/mac/KURLMac.mm:
(WebCore::KURL::getNSURL): Turn empty KURL into empty NSURL, but null KURL into
nil.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 15 Dec 2006 02:25:22 +0000 (02:25 +0000)]
Reviewed by Darin.
<rdar://problem/
4827549> need NSRange-based selection support exposed.
* WebView/WebFrame.mm:
(-[WebFrame _selectedNSRange]):
(-[WebFrame _selectNSRange:]):
* WebView/WebFramePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Fri, 15 Dec 2006 01:30:52 +0000 (01:30 +0000)]
2006-12-14 Steve Falkenburg <sfalken@apple.com>
Build fix.
* loader/MainResourceLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 15 Dec 2006 00:41:29 +0000 (00:41 +0000)]
WebCore:
Reviewed by John.
Convert a bunch of NSErrors to ResourceError.
Make the ResourceError accessor functions const.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/MainResourceLoader.h:
* loader/NetscapePlugInStreamLoader.h:
* loader/ResourceLoader.h:
* loader/SubresourceLoader.h:
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::didFailToLoad):
(WebCore::FrameLoader::receivedMainResourceError):
(WebCore::FrameLoader::interruptionForPolicyChangeError):
* loader/mac/MainResourceLoaderMac.mm:
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::didCancel):
(WebCore::MainResourceLoader::interruptionForPolicyChangeError):
(WebCore::MainResourceLoader::didFail):
* loader/mac/NetscapePlugInStreamLoaderMac.mm:
(WebCore::NetscapePlugInStreamLoader::didFail):
(WebCore::NetscapePlugInStreamLoader::didCancel):
* loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::didCancel):
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::didCancel):
* platform/network/ResourceError.h:
(WebCore::ResourceError::domain):
(WebCore::ResourceError::errorCode):
(WebCore::ResourceError::failingURL):
(WebCore::ResourceError::localizedDescription):
(WebCore::ResourceError::unpackPlatformErrorIfNeeded):
WebKit:
Reviewed by John.
Update for WebKit changes.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidFailLoading):
(WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebFrameLoaderClient::dispatchDidFailLoad):
(WebFrameLoaderClient::dispatchUnableToImplementPolicy):
(WebFrameLoaderClient::setMainDocumentError):
(WebFrameLoaderClient::cancelledError):
(WebFrameLoaderClient::cannotShowURLError):
(WebFrameLoaderClient::interruptForPolicyChangeError):
(WebFrameLoaderClient::cannotShowMIMETypeError):
(WebFrameLoaderClient::fileDoesNotExistError):
(WebFrameLoaderClient::shouldFallBack):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Fri, 15 Dec 2006 00:10:41 +0000 (00:10 +0000)]
Link, after the last loader changes. Please update this directory with stubs when modifying the loader. (also fixes some Changelog typos)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 14 Dec 2006 23:30:11 +0000 (23:30 +0000)]
LayoutTests:
Reviewed by harrison
<rdar://problem/
4866671>
CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()
* editing/deleting/
4866671-expected.checksum: Added.
* editing/deleting/
4866671-expected.png: Added.
* editing/deleting/
4866671-expected.txt: Added.
* editing/deleting/
4866671.html: Added.
* editing/pasteboard/
4866671-expected.checksum: Added.
* editing/pasteboard/
4866671-expected.png: Added.
* editing/pasteboard/
4866671-expected.txt: Added.
* editing/pasteboard/
4866671.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/
4866671>
CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()
Don't allow VisiblePositions inside -webkit-user-select:none regions.
Renamed inRenderedContent to isCandidate.
* dom/Document.cpp:
(WebCore::Document::updateSelection):
* dom/Position.cpp:
(WebCore::Position::previousCharacterPosition):
(WebCore::Position::nextCharacterPosition):
(WebCore::nodeIsUserSelectNone):
(WebCore::Position::isCandidate):
(WebCore::Position::rendersInDifferentPosition):
* dom/Position.h:
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input):
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::canonicalPosition):
* editing/htmlediting.cpp:
(WebCore::nextCandidate):
(WebCore::nextVisuallyDistinctCandidate):
(WebCore::previousCandidate):
(WebCore::previousVisuallyDistinctCandidate):
* editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
(WebCore::startOfParagraph):
* page/Frame.cpp:
(WebCore::Frame::styleForSelectionStart):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 14 Dec 2006 23:16:48 +0000 (23:16 +0000)]
Get rid of the containsStart check and just rely on the selectionState
bits. This allows selection gap filling to behave properly in the presence
of inline blocks and inline tables on lines when the selection originates
inside the inline block.
Reviewed by ggaren
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::fillInlineSelectionGaps):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 14 Dec 2006 22:13:59 +0000 (22:13 +0000)]
Reviewed by John.
General loader cleanup, convert NSURLResponse to ResourceResponse in some places.
* loader/DocumentLoader.h:
* loader/SubresourceLoader.h:
* loader/mac/DocumentLoaderMac.mm:
(WebCore::DocumentLoader::addResponse):
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::opened):
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 14 Dec 2006 20:50:10 +0000 (20:50 +0000)]
Reviewed by Darin.
Add loadResourceSynchronously to ResourceHandle and have FrameLoader use it instead of
calling NSURLConnection directly.
Add an isNull flag to ResourceError so we can convert correctly between nil NSErrors and ResourceErrors.
Get rid of ServeSynchronousRequest and use the loader instead.
* WebCore.exp:
* dom/XMLTokenizer.cpp:
(WebCore::openFunc):
* loader/FrameLoader.h:
* loader/LoaderFunctions.h:
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::canLoad):
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/mac/LoaderFunctionsMac.mm:
* platform/network/ResourceError.h:
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::isNull):
* platform/network/ResourceHandle.h:
* platform/network/ResourceRequest.cpp:
(WebCore::ResourceRequest::isConditional):
* platform/network/ResourceRequest.h:
* platform/network/mac/ResourceErrorMac.mm:
(-[NSError WebCore]):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::loadResourceSynchronously):
* xml/XSLTProcessor.cpp:
(WebCore::docLoaderFunc):
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::send):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Thu, 14 Dec 2006 20:42:10 +0000 (20:42 +0000)]
Reviewed by Darin.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11830
Fix fundamental problems with JS SVG POD types.
(currently: FloatPoint/FloatRect/AffineTransform)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 14 Dec 2006 19:30:36 +0000 (19:30 +0000)]
top level:
Reviewed by Brady.
* Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status
WebKitTools:
Reviewed by Brady.
* Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 14 Dec 2006 18:05:16 +0000 (18:05 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11828
Fix a leak of NSURLRequest on each update - RetainPtr retains the object itself.
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Thu, 14 Dec 2006 17:32:52 +0000 (17:32 +0000)]
2006-12-14 Simon Hausmann <hausmann@kde.org>
Reviewed by Zack.
* QtLauncher/QtLauncher.pro: Link this little test program
with rpath, for convenience. (This is never going to get installed
anyway)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Thu, 14 Dec 2006 16:47:26 +0000 (16:47 +0000)]
2006-12-14 Simon Hausmann <hausmann@kde.org>
Reviewed by Zack Rusin.
* WebCore.pro: Clean up the xpath grammar generation rule.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Thu, 14 Dec 2006 14:22:13 +0000 (14:22 +0000)]
Make it link with temporary stubs (from lars, icefox)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Thu, 14 Dec 2006 11:40:25 +0000 (11:40 +0000)]
Compilation fixes for the Qt port after last nights changes
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Thu, 14 Dec 2006 10:36:15 +0000 (10:36 +0000)]
Reviewed by Oliver.
http://bugs.webkit.org/show_bug.cgi?id=11726
SVG Image do not take into account clip/overflow when hit testing
Take into account the overflowRect when hit-testing <svg> container.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 14 Dec 2006 07:52:14 +0000 (07:52 +0000)]
Fix for bug 11825, dragging elements via -khtml-user-drag is broken (affects Dashboard). Make sure
to clear the paintingRoot properly when recurring into children. It would be nice to find a design
that prevented this mistake from being made and didn't require explicit clearing of the root.
Reviewed by olliej
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paint):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 14 Dec 2006 01:30:02 +0000 (01:30 +0000)]
* loader/FrameLoader.h:
id is mac-only.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 13 Dec 2006 23:34:09 +0000 (23:34 +0000)]
Implicitly reviewed by Darin, Hyatt, Maciej, and others!
Fixes a document tear down crash.
Changes a few long standing assertions to our new style
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::topDocument):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 13 Dec 2006 23:22:44 +0000 (23:22 +0000)]
Reviewed by Brady and Anders.
* Makefile.shared: Stop spewing the environment all the time, at least for command-line builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 13 Dec 2006 23:20:13 +0000 (23:20 +0000)]
JavaScriptCore:
Reviewed by Anders.
- added equality and inequality operations for HashMap and Vector, useful for comparing more complex types
* wtf/HashMap.h:
(WTF::operator==):
(WTF::operator!=):
* wtf/Vector.h:
(WTF::operator==):
(WTF::operator!=):
WebCore:
Reviewed by Anders.
- converted many places to use ResourceRequest instead of NSURLRequest
* WebCore.exp:
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopPolicyCheck):
* loader/FrameLoader.h:
(WebCore::PolicyCheck::request):
* loader/FrameLoaderClient.h:
* loader/MainResourceLoader.h:
* loader/mac/DocumentLoaderMac.mm:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::originalRequest):
(WebCore::DocumentLoader::originalRequestCopy):
(WebCore::DocumentLoader::request):
(WebCore::DocumentLoader::initialRequest):
(WebCore::DocumentLoader::actualRequest):
(WebCore::DocumentLoader::URL):
(WebCore::DocumentLoader::unreachableURL):
(WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
(WebCore::DocumentLoader::setRequest):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::setLastCheckedRequest):
(WebCore::DocumentLoader::lastCheckedRequest):
(WebCore::DocumentLoader::URLForHistory):
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::startLoadingMainResource):
(WebCore::FrameLoader::applyUserAgent):
(WebCore::FrameLoader::originalRequest):
(WebCore::FrameLoader::receivedMainResourceError):
(WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::initialRequest):
(WebCore::FrameLoader::setRequest):
(WebCore::FrameLoader::checkNavigationPolicy):
(WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
(WebCore::FrameLoader::reloadAllowingStaleData):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::checkNewWindowPolicy):
(WebCore::FrameLoader::continueAfterNewWindowPolicy):
(WebCore::FrameLoader::continueAfterNavigationPolicy):
(WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::post):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::isReloading):
(WebCore::FrameLoader::referrer):
(WebCore::FrameLoader::loadEmptyDocumentSynchronously):
(WebCore::FrameLoader::loadResourceSynchronously):
(WebCore::FrameLoader::originalRequestURL):
(WebCore::PolicyCheck::set):
(WebCore::PolicyCheck::call):
(WebCore::PolicyCheck::clearRequest):
* loader/mac/MainResourceLoaderMac.mm:
(WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
(WebCore::MainResourceLoader::continueAfterNavigationPolicy):
(WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::create):
* loader/mac/WebDataProtocol.h:
* loader/mac/WebDataProtocol.mm:
* platform/KURL.cpp:
(WebCore::operator!=):
* platform/KURL.h:
* platform/mac/KURLMac.mm:
(WebCore::KURL::getNSURL):
* platform/network/FormData.h:
(WebCore::operator==):
(WebCore::operator!=):
* platform/network/ResourceRequest.cpp:
(WebCore::operator==):
* platform/network/ResourceRequest.h:
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
WebKit:
Reviewed by Anders.
- adjusted for changes from NSURLRequest to ResourceRequest
* Plugins/WebPluginController.mm:
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::updateHistoryForReload):
(WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
(WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::startDownload):
(WebFrameLoaderClient::cannotShowURLError):
(WebFrameLoaderClient::createDocumentLoader):
* WebView/WebDataSource.mm:
(-[WebDataSource _initWithDocumentLoader:]):
(-[WebDataSource initialRequest]):
(-[WebDataSource request]):
* WebView/WebDocumentLoaderMac.h:
* WebView/WebDocumentLoaderMac.mm:
(WebDocumentLoaderMac::WebDocumentLoaderMac):
* WebView/WebFrame.mm:
(-[WebFrame _createItem:]):
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame loadArchive:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 13 Dec 2006 23:10:32 +0000 (23:10 +0000)]
Reviewed by Darin Adler, Dave Hyatt.
Beefed up FocusController to handle frame focus. Changed implementors to
use FocusController, rather than the widget hierarchy, to focus frames.
(WebCore::FocusController::focusedNode): Made a minor change to focus a frame
before focusing the element inside of it. This matches FF.
(WebCore::FocusController::focusedFrame):
* platform/Widget.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 13 Dec 2006 21:33:23 +0000 (21:33 +0000)]
Reviewed by adele
<rdar://problem/
4818145>
Cannot setSelectedDOMRange to non-editable island unless it has editable content on both sides
There are editable positions before/after a "non-editable island" if its
a table, but the code in canonicalPosition was not using
editableRootForPosition to find root editable elements.
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::canonicalPosition): Use editableRootForPosition
to fix the table case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 13 Dec 2006 20:02:12 +0000 (20:02 +0000)]
2006-12-13 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Added missing forwarding headers.
* ForwardingHeaders/kjs/value.h: Added.
* ForwardingHeaders/wtf/HashTable.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 13 Dec 2006 17:05:33 +0000 (17:05 +0000)]
Updated results to match Justin Garcia's addition of rangeCount to
the selection object.
* fast/dom/Window/window-properties-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Wed, 13 Dec 2006 14:45:38 +0000 (14:45 +0000)]
Make qmake the default build environment for the Qt port.
CMake currently doesn't work and updates to qmake will happen
a lot faster. Review by Rob
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Wed, 13 Dec 2006 13:16:53 +0000 (13:16 +0000)]
make it compile after last nights changes from lars (r=maciej,me)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 13 Dec 2006 02:34:10 +0000 (02:34 +0000)]
Reviewed by Anders.
Changed #import to #include to match the rest of our ForwardingHeaders.
* ForwardingHeaders/wtf/StringExtras.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 13 Dec 2006 00:48:23 +0000 (00:48 +0000)]
LayoutTests:
Reviewed by harrison
<rdar://problem/
4757667>
GoogleDocs: Style menu does not open
* editing/selection/rangeCount-expected.txt: Added.
* editing/selection/rangeCount.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/
4757667>
GoogleDocs: Style menu does not open
* bindings/js/kjs_window.cpp:
(KJS::Selection::getValueProperty): Added rangeCount.
* bindings/js/kjs_window.h:
(KJS::Selection::):
* editing/SelectionController.h:
(WebCore::SelectionController::rangeCount): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Tue, 12 Dec 2006 23:58:55 +0000 (23:58 +0000)]
Reviewed by Oliver.
* bindings/js/JSSVGMatrixCustom.cpp:
added #ifdef SVG_SUPPORT
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 12 Dec 2006 23:45:20 +0000 (23:45 +0000)]
Suggested by Darin.
* loader/ResourceLoader.cpp:
Move down include of ResourceHandle.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 12 Dec 2006 23:30:09 +0000 (23:30 +0000)]
Fixing up svn properties on FocusController.*
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 12 Dec 2006 22:11:18 +0000 (22:11 +0000)]
Reviewed by Adam Roben, Dave Hyatt, Darin Adler.
Factored focus control into a FocusController class. I inted to use this
class for handling window active state and the focused frame, as well.
Layout tests pass.
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::view):
(WebCore::Document::page): New helper function.
* dom/Document.h: Moved setters before getters.
(WebCore::Document::hoverNode):
(WebCore::Document::activeNode):
* dom/Node.cpp:
(WebCore::Node::detach): Use the FocusController.
* page/FocusController.cpp: Added.
(WebCore::shouldFocus): renamed and refactored this helper function.
(WebCore::shouldUnfocus): ditto.
* page/FocusController.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 12 Dec 2006 22:03:27 +0000 (22:03 +0000)]
Rubber Stamped by Geoff.
* platform/Base64.cpp:
* platform/Base64.h:
Put functions inside of the WebCore namespace.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 12 Dec 2006 21:42:24 +0000 (21:42 +0000)]
Try fixing the non-Mac builds.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
* loader/SubresourceLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 12 Dec 2006 21:14:50 +0000 (21:14 +0000)]
WebCore:
Reviewed by Darin.
Turn ResourceLoader into a ResourceHandleClient and stop using NSURLConnection in the loader.
* WebCore.exp:
Add new methods needed by WebKit.
* WebCore.xcodeproj/project.pbxproj:
Make ResourceHandle.h a private header.
* loader/FrameLoaderClient.h:
Change the download method to take a ResourceHandle instead of an NSURLConnection.
* loader/MainResourceLoader.h:
Get rid of the proxy instance variable, that's handled by ResourceHandlw now.
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
(WebCore::ResourceLoader::didCancelAuthenticationChallenge):
(WebCore::ResourceLoader::willStopBufferingData):
(WebCore::ResourceLoader::willCacheResponse):
(WebCore::ResourceLoader::receivedCredential):
(WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
(WebCore::ResourceLoader::receivedCancellation):
(WebCore::ResourceLoader::handle):
* loader/SubresourceLoader.h:
Make ResourceLoader a ResourceHandleClient, moving the methods from SubresourceLoader.
* loader/mac/MainResourceLoaderMac.mm:
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::loadNow):
(WebCore::MainResourceLoader::load):
Use a ResourceHandle instead of an NSURLConnection.
* loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::~ResourceLoader):
(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::load):
(WebCore::ResourceLoader::setDefersLoading):
(WebCore::ResourceLoader::resourceData):
(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
(WebCore::ResourceLoader::didCancel):
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
Remove the WebCoreResourceLoaderAsDelegate class, use a ResourceHandle instead of an NSURLConnection.
* loader/mac/SubresourceLoaderMac.mm:
Remove ResourceHandleClient methods.
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
Add an extra argument denoting whether this ResourceHandle can possibly be "converted" into one used for downloads.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::~ResourceHandle):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::releaseProxy):
(WebCore::ResourceHandle::connection):
New methods for creating a NSURLConnectionDelegateProxy which is used when creating a NSURLDownload from an existing
connection.
WebKit:
Reviewed by Darin.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::download):
Get the handle and proxy from the ResourceHandle now that they aren't passed to us.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 12 Dec 2006 20:09:58 +0000 (20:09 +0000)]
Reviewed by Geoff. Based on a patch by Maks Orlovich.
http://bugs.webkit.org/show_bug.cgi?id=6257
Throw errors on invalid expressions (KJS merge)
JavaScriptCore:
* kjs/regexp.cpp:
(KJS::RegExp::RegExp):
(KJS::RegExp::~RegExp):
(KJS::RegExp::match):
* kjs/regexp.h:
(KJS::RegExp::flags):
(KJS::RegExp::isValid):
(KJS::RegExp::errorMessage):
(KJS::RegExp::subPatterns):
Remember and report RegExp construction failures. Renamed data members not to start with underscores.
* kjs/regexp_object.cpp:
(RegExpObjectImp::construct): Raise an exception if RegExp construction fails.
(RegExpObjectImp::callAsFunction): Removed an obsolete comment.
* tests/mozilla/ecma_3/RegExp/regress-119909.js: Reduced the number of nested parentheses to
a value supported by PCRE.
LayoutTests:
* fast/js/kde/RegExp-expected.txt: One more test passes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 12 Dec 2006 19:42:03 +0000 (19:42 +0000)]
Reviewed by Geoff.
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::load):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
Move the didTellBridgeAboutLoad call to SubresourceLoader in preparation for getting rid of
the DocLoader parameter to ResourceHandle::create.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 12 Dec 2006 19:32:35 +0000 (19:32 +0000)]
Oops. Forgot to check in this file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Tue, 12 Dec 2006 12:09:51 +0000 (12:09 +0000)]
Make the last checkin compile
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Tue, 12 Dec 2006 11:19:34 +0000 (11:19 +0000)]
Fixes: bugs.webkit.org/show_bug.cgi?id=11797
Remove SVGMatrix, replace it by AffineTransform usage everywhere.
Changed AffineTransform API to be able to be used within generation
(m11() -> a(), m12() -> b(), ...). Add some methods needed for SVG.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Tue, 12 Dec 2006 09:55:16 +0000 (09:55 +0000)]
Fix the Qt build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 12 Dec 2006 09:02:13 +0000 (09:02 +0000)]
LayoutTests:
Reviewed by Beth Dakin.
Added some focus-related tests.
* editing/undo/undo-iframe-location-change-expected.txt: Updated to reflect
the fact that we now unfocus nodes when they're removed from the document.
* fast/events/keypress-removed-node-expected.txt: Added.
* fast/events/keypress-removed-node.html: Added.
* fast/forms/focus2-expected.txt: Added.
* fast/forms/focus2.html: Added.
WebCore:
Reviewed by Beth Dakin.
Moved focus control to the page level. Fixed a minor bug where a node
would retain keyboard focus even when removed from the document.
We should probably move this, along with hover and active, into a separate
FocusController. But I'm too tired right now.
* dom/Document.cpp: Migrated code to Page
(WebCore::Document::removedLastRef):
(WebCore::Document::detach):
(WebCore::Document::setFocusedNode):
(WebCore::Document::focusedNode):
* dom/Document.h:
* dom/Node.cpp:
(WebCore::Node::detach): Clear ourselves from keyboard focus. This fixes
the minor bug and was also necessary to prevent regressions caused by hanging
on to a focused node after the document was replaced.
* dom/Node.h:
(WebCore::Node::inDetach):
* page/Page.cpp: Migrated code from Document
(WebCore::shouldAcquireEditingFocus):
(WebCore::shouldRelinquishEditingFocus):
(WebCore::clearSelectionIfNeeded):
(WebCore::widgetForNode):
(WebCore::Page::setFocusedNode):
* page/Page.h:
(WebCore::Page::focusedNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 12 Dec 2006 08:45:48 +0000 (08:45 +0000)]
build fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 12 Dec 2006 08:28:15 +0000 (08:28 +0000)]
Added the new XHR EventTarget methods to test results.
* fast/dom/Window/window-properties-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 12 Dec 2006 07:59:58 +0000 (07:59 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11053
XMLHttpRequest should be an EventTarget
Test: http/tests/xmlhttprequest/event-target.html
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::JSXMLHttpRequest::mark):
(KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
(KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
* bindings/js/JSXMLHttpRequest.h:
(KJS::JSXMLHttpRequest::):
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::addEventListener):
(WebCore::XMLHttpRequest::removeEventListener):
(WebCore::XMLHttpRequest::dispatchEvent):
(WebCore::XMLHttpRequest::callReadyStateChangeListener):
* xml/xmlhttprequest.h:
(WebCore::XMLHttpRequest::eventListeners):
Implement EventTarget methods (except for NS variations, which Firefox doesn't have either).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 12 Dec 2006 07:13:35 +0000 (07:13 +0000)]
Reviewed by Geoff.
- fix http://bugs.webkit.org/show_bug.cgi?id=11809
fast/dom/gc-8.html crash in alternate-thread marking code in ScriptInterpreter
DocumentType objects were getting filed under the wrong document in the
DOM objects structure.
* bindings/js/kjs_binding.h: Added a destructor for debugging purposes only.
* bindings/js/kjs_binding.cpp:
(KJS::wrapperSet): Added. Set of outstanding wrappers for debugging.
(KJS::addWrapper): Added.
(KJS::removeWrapper): Added.
(KJS::removeWrappers): Added.
(KJS::DOMObject::~DOMObject): Added. Asserts that there is no outstanding reference
to this wrapper since it's being destroyed.
(KJS::ScriptInterpreter::putDOMObject): Added a call to ADD_WRAPPER.
(KJS::ScriptInterpreter::forgetDOMObject): Added a call to REMOVE_WRAPPER.
(KJS::ScriptInterpreter::forgetDOMNodeForDocument): Added a call to REMOVE_WRAPPER.
(KJS::ScriptInterpreter::putDOMNodeForDocument): Added a call to ADD_WRAPPER.
(KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Added a call to REMOVE_WRAPPERS.
(KJS::ScriptInterpreter::updateDOMNodeDocument): Added calls to REMOVE_WRAPPER and
ADD_WRAPPER so the out-of-order transaction doesn't upset the assertions in the functions
we're calling. Another solution would be to reorder the two, but I think that would
create a race where another thread could garbage collect after the forget but before the put.
(KJS::ScriptInterpreter::wasRunByUserGesture): Tweaked formatting.
* dom/Document.cpp: (WebCore::Document::adoptNode): Removed call to updateDOMNodeDocument
since setDocument now takes care of that.
* dom/Node.cpp:
(WebCore::Node::setDocument): Added call to updateDOMNodeDocument here.
(WebCore::Node::checkAddChild): Removed call to updateDOMNodeDocument since setDocument
now takes care of that.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 12 Dec 2006 06:47:43 +0000 (06:47 +0000)]
bugs.webkit.org/show_bug.cgi?id=9673
Add support for window.atob() and window.btoa()
Reviewed by Darin.
JavaScriptCore:
* JavaScriptCore.exp: Export UString::is8Bit().
* JavaScriptCore.xcodeproj/project.pbxproj: Added StringExtras.h as
a private header.
WebCore:
* WebCore.xcodeproj/project.pbxproj: Added Base64.{h,cpp}
* bindings/js/kjs_window.cpp:
(KJS::WindowFunc::callAsFunction):
* bindings/js/kjs_window.h:
(KJS::Window::):
* platform/Base64.cpp: Added.
(base64Encode):
(base64Decode):
* platform/Base64.h: Added.
* ForwardingHeaders/wtf/StringExtras.h: Added.
* platform/DeprecatedString.cpp: Use strncasecmp from StringExtras.
LayoutTests:
* fast/dom/Window/atob-btoa-expected.txt: Added.
* fast/dom/Window/atob-btoa.html: Added.
* fast/dom/Window/btoa-pnglet-expected.checksum: Added.
* fast/dom/Window/btoa-pnglet-expected.png: Added.
* fast/dom/Window/btoa-pnglet-expected.txt: Added.
* fast/dom/Window/btoa-pnglet.html: Added.
* fast/dom/Window/window-properties-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 12 Dec 2006 05:56:20 +0000 (05:56 +0000)]
WebCore:
Reviewed by Brady.
- did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list
* WebCore.xcodeproj/project.pbxproj: Updated project for file moves.
* bridge/mac/FrameMac.h: Moved to page/mac.
* bridge/mac/FrameMac.mm: Ditto.
* bridge/mac/WebCoreFrameBridge.h: Ditto.
* bridge/mac/WebCoreFrameBridge.mm: Ditto.
* bridge/mac/WebCoreFrameView.h: Ditto.
* bridge/mac/WebCoreViewFactory.h: Ditto.
* bridge/mac/WebCoreViewFactory.m: Ditto.
* bridge/mac/WebDashboardRegion.h: Ditto.
* bridge/mac/WebDashboardRegion.m: Ditto.
* bridge/mac/WebCoreKeyboardAccess.h: Moved to page/mac,
renamed WebCoreKeyboardUIMode.h, and made a C++ header.
* page/EventHandler.h: Updated for change to WebCoreKeyboardAccess.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::tabsToLinks): Ditto.
(WebCore::EventHandler::tabsToAllControls): Ditto.
(WebCore::EventHandler::keyboardUIMode): Ditto.
WebKit:
Reviewed by Brady.
- did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list
* WebCoreSupport/WebFrameBridge.h: Updated for change to WebCoreKeyboardAccess.
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Ditto.
(-[WebFrameBridge keyboardUIMode]): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 12 Dec 2006 05:47:08 +0000 (05:47 +0000)]
Reviewed by Brady.
* JavaScriptCore.xcodeproj/project.pbxproj: Let Xcode update this
(I think Hyatt is using an old Xcode).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 12 Dec 2006 05:03:32 +0000 (05:03 +0000)]
* fast/frames/iframe-option-crash-expected.txt: Updated results for this test.
My recent change to owner element lifetime management changed these results,
but since the point of the test is simply to check if the page crashes, the
new result is probably OK. Or there could be some problem, but if so we need
some other investigation -- I couldn't see anything.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Tue, 12 Dec 2006 04:27:17 +0000 (04:27 +0000)]
WebCore:
Reviewed by Adam.
Primarily, this patch implements/hooks-up actions for the sub-menu
items in WebCore context menus. I fixed a few other things along
the way too:
-Made BUILDING_ON_TIGER ifdef work within C++ as well as
Obj-C
-Fixed bug where we would throw and Obj-C exception and
fail to pop up menus with more than one separator item.
-Re-named some of the spelling/grammar tags since Tiger and
Leopard share more of the actions than initially
anticipated.
* WebCorePrefix.h: Make BUILDING_ON_TIGER available to C++
* bridge/EditorClient.h: New functions to toggle
spelling/grammar checking.
* editing/Editor.cpp:
(WebCore::Editor::toggleContinuousSpellChecking): Call into client.
(WebCore::Editor::toggleGrammarChecking): Same.
(WebCore::Editor::toggleBold): call execToggleBold()
(WebCore::Editor::toggleUnderline): Create appropriate underline
style and apply to selection.
(WebCore::Editor::setBaseWritingDirection): Create appropriate
writing direction and apply to selection.
* editing/Editor.h:
* editing/mac/EditorMac.mm: New functions to show spelling guesses,
fonts, styles, and color panels.
* page/ContextMenuClient.h: New functions for the speech sub-menu.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected): Fill in
editing sub-menu actions.
* platform/ContextMenu.cpp:
(WebCore::separatorItem): Helper function to create a separator
item.
(WebCore::createFontSubMenu): Put very mac-specific things within a
platform ifdef.
(WebCore::createSpellingAndGrammarSubMenu): Re-named some of the
spelling sub-menu tags.
(WebCore::createSpellingSubMenu): Same.
(WebCore::ContextMenu::populate): We can't share the separator
item. When we do, menus with more than one separator throw and obj-
c exception and fail to pop-up.
* platform/ContextMenuItem.h:
(WebCore::): Re-named some of the spelling sub-menu tags.
WebKit:
Reviewed by Adam.
WebKit support for editing sub-menu actions.
* WebCoreSupport/WebContextMenuClient.h: New functions for the
speech sub-menu.
* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::speak):
(WebContextMenuClient::stopSpeaking):
* WebCoreSupport/WebEditorClient.h: New functions to toggle
spelling/grammar checking.
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::toggleContinuousSpellChecking):
(WebEditorClient::toggleGrammarChecking):
* WebView/WebUIDelegatePrivate.h: Re-named some of the spelling
sub-menu tags.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Tue, 12 Dec 2006 03:17:45 +0000 (03:17 +0000)]
WebCore:
Reviewed by Geoff, Adam.
Switch to use the Editor for copying URLs. Also some Pasteboard and PlatformMouseEvent cleanup.
All layout tests pass as they would without this patch.
* WebCore.exp:
added Editor::copyURL to be called from WebKit
* editing/Editor.cpp:
(WebCore::Editor::tryDHTMLCopy):
(WebCore::Editor::tryDHTMLCut):
Pasteboard::clearTypes() changed to clear()
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::cut):
(WebCore::Editor::copy):
Changed signature of writeSelection to take raw pointer instead of PassRefPtr
(WebCore::Editor::copyURL):
* editing/Editor.h:
Added copyURL.
* page/ContextMenuClient.h:
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
Removed copyLinkToClipboard
* platform/KURL.cpp:
(WebCore::KURL::lastPathComponent):
* platform/KURL.h:
Added lastPathComponent.
* platform/Pasteboard.h:
Changed some function names.
Moved some functions out of class to static.
* platform/PlatformMouseEvent.h:
(WebCore::):
Removed MouseEventType enum, added NoButton to MouseButton without disturbing other button values.
* platform/mac/PasteboardMac.mm:
Added writeURL, and moved some things around
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
Add some calls necessary for Pasteboard::writeURL to work
WebKit:
Reviewed by Geoff, Adam.
switch to use the Editor for copying URLs
* DefaultDelegates/WebDefaultContextMenuDelegate.m:
(-[WebDefaultUIDelegate copyLinkToClipboard:]):
Call down to the editor for this.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
Add some calls necessary for Pasteboard::writeURL to work
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Tue, 12 Dec 2006 01:26:16 +0000 (01:26 +0000)]
Update SVG pixel tests - hasn't been done for a long time.
Mainly tiny text related positioning changes, all fine.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 11 Dec 2006 23:40:47 +0000 (23:40 +0000)]
WebCore:
Reviewed by Brady.
- http://bugs.webkit.org/show_bug.cgi?id=11794
fix lifetime problems affecting Frame's ownerElement pointer
* CMakeLists.txt:
* WebCore.vcproj/WebCore/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
Updated for new source files.
* WebCore.exp: Updated for changes to entry point names.
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
* bridge/win/FrameWin.h:
* bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
* platform/qt/FrameQt.h:
* platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt):
Updated owner element type to HTMLFrameOwnerElement.
* bridge/mac/WebCoreFrameBridge.h: Removed non-C++ case since we don't
use that any more. Updated owner element type to HTMLFrameOwnerElement.
* dom/Document.cpp: Added include so that the ownerElement function can
compile (since it downcasts an HTMLFrameOwnerElement to an Element).
* html/HTMLFrameElement.cpp:
(WebCore::containingFrameSetElement): Moved this function in here; it
doesn't need to be a member function.
(WebCore::HTMLFrameElement::attach): Updated to call this.
* html/HTMLFrameElementBase.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Inherit from
HTMLFrameOwnerElement. Removed contentFrame, contentDocument, and
containingFrameSetElement. Removed friend classes.
* html/HTMLFrameOwnerElement.h: Added.
* html/HTMLFrameOwnerElement.cpp: Added.
* html/HTMLEmbedElement.h:
* html/HTMLEmbedElement.cpp:
* html/HTMLObjectElement.h:
* html/HTMLObjectElement.cpp:
Remove now-unneeded contentDocument functions.
* html/HTMLPlugInElement.h:
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::HTMLPlugInElement): Inherit from
HTMLFrameOwnerElement.
* loader/FormState.h:
* loader/FormState.cpp: Use HTMLFormElement instead of just Element.
* loader/FrameLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::requestFrame): Use HTMLFormElement.
(WebCore::FrameLoader::loadSubframe): Ditto.
(WebCore::FrameLoader::requestObject): Don't pass an element parameter
to shouldUsePlugin, and remove now-unneeded type casts.
(WebCore::FrameLoader::shouldUsePlugin): Removed unneeded element parameter.
(WebCore::FrameLoader::handleFallbackContent): Use HTMLFrameOwnerElement.
(WebCore::FrameLoader::updateBaseURLForEmptyDocument): Ditto.
(WebCore::FrameLoader::isHostedByObjectElement): Ditto.
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::load): Use HTMLFormElement.
(WebCore::FrameLoader::post): Ditto.
(WebCore::FrameLoader::createFrame): Use HTMLFrameOwnerElement.
* page/Frame.h:
* page/FramePrivate.h:
* page/Frame.cpp:
(WebCore::parentFromOwnerElement): Use HTMLFrameOwnerElement.
(WebCore::Frame::Frame): Ditto. Also set m_contentFrame on the owner element.
(WebCore::Frame::ownerElement): Ditto.
(WebCore::Frame::ownerRenderer): Ditto.
(WebCore::Frame::disconnectOwnerElement): Clear m_contentFrame on the owner
element before disconnecting it.
(WebCore::FramePrivate::FramePrivate): Use HTMLFrameOwnerElement.
* page/mac/EventHandlerMac.mm: Include HTMLFrameOwnerElement.h so that
the code here will compile (no code changes needed).
* rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared):
Updated so that RenderFrame doesn't need to be a friend of HTMLFrameElementBase.
* rendering/RenderPart.h:
* rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart):
Use HTMLFrameOwnerElement.
* rendering/RenderPartObject.h:
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::RenderPartObject): Use HTMLFrameOwnerElement.
(WebCore::RenderPartObject::viewCleared): Updated so that RenderFrame doesn't
need to be a friend of HTMLFrameElementBase.
- other changes
* platform/network/ResourceHandleInternal.h: Added Noncopyable and
fixed indentation.
WebKit:
Reviewed by Brady.
- http://bugs.webkit.org/show_bug.cgi?id=11794
fix lifetime problems affecting Frame's ownerElement pointer
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge finishInitializingWithPage:WebCore::frameName:frameView:ownerElement:]):
(-[WebFrameBridge initSubframeWithOwnerElement:frameName:frameView:]):
(-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
Use HTMLFrameOwnerElement.
* WebCoreSupport/WebFrameLoaderClient.mm: Include the relevant headers for the
HTMLFormElement class.
* WebKit.xcodeproj/project.pbxproj: Let Xcode have its way.
* WebView/WebFrame.mm: (-[WebFrame frameElement]): Update includes and types for the
change in return type of ownerElement.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 11 Dec 2006 23:11:49 +0000 (23:11 +0000)]
Fix failing layout test. Remove WTF::Unicode::isSpace and just revert
the caller to the old behavior.
Reviewed by darin
* platform/StringImpl.cpp:
(WebCore::isSpace):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 11 Dec 2006 23:10:39 +0000 (23:10 +0000)]
Fix the failing layout test. Just remove Unicode::isSpace and
revert StringImpl to do the same thing it was doing before.
Reviewed by darin
* wtf/unicode/icu/UnicodeIcu.h:
* wtf/unicode/qt4/UnicodeQt4.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 11 Dec 2006 20:13:58 +0000 (20:13 +0000)]
Reviewed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=11807
Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::autoscrollTimerFired):
* page/EventHandler.h:
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::mouseMoved):
Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed
(WebCore::EventHandler::lastEventIsMouseUp):
Check that the "new" event is newer than the "old" one - that's not always the case
when running in DRT, as [NSApp currentEvent] isn't updated by eventSender.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Mon, 11 Dec 2006 18:52:08 +0000 (18:52 +0000)]
I forgot to remove these in the previous commit, they were only emptied out.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Mon, 11 Dec 2006 18:03:41 +0000 (18:03 +0000)]
Fix previous checkin where I committed the wrong file.
<rdar://problem/
4863611> Xyle Scope crashes at launch due to WebCore-521.29.3
* WebView/WebFrame.mm:
(-[WebFrame frameElement]):
Add nil check.
* WebView/WebPreferences.m:
(-[WebPreferences editableLinkBehavior]):
Reverted to previous.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Mon, 11 Dec 2006 17:55:19 +0000 (17:55 +0000)]
Reviewed by Sam Weinig.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11801
Autogenerate POD types for ObjC/JS.
This removes the need for the hand-written JSSVG*, DOMSVG* wrappers
in bindings/js, bindings/objc. Makes it much easier to convert more
SVG types to POD types (ie. SVGMatrix* -> AffineTransform etc.)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 11 Dec 2006 16:24:03 +0000 (16:24 +0000)]
Reviewed by Mitz.
Make this test faster by eliminating timeouts (which didn't work anyway, now that
mouse dragging events are stored and replayed on mouse-up).
* fast/text/atsui-rtl-override-selection.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Mon, 11 Dec 2006 01:23:57 +0000 (01:23 +0000)]
add missing receive call for resources
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Mon, 11 Dec 2006 01:23:48 +0000 (01:23 +0000)]
Add a default useragent for now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Mon, 11 Dec 2006 01:21:08 +0000 (01:21 +0000)]
Fix a small issue (crash) with resource loading (from lars, r=me)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18147
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Mon, 11 Dec 2006 01:17:36 +0000 (01:17 +0000)]
Make the xpath grammar hack more specific (and work on OS X) until
it's cleaned up.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Mon, 11 Dec 2006 01:12:12 +0000 (01:12 +0000)]
Set the WidgetClient in WidgetQt correctly. We need to make
this platform independent
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Mon, 11 Dec 2006 00:13:41 +0000 (00:13 +0000)]
Fixes loading of local files (from Lars)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18144
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Sun, 10 Dec 2006 22:49:56 +0000 (22:49 +0000)]
Don't use QTransform yet, affine QMatrix is enough for SVG,
plus it makes it work with 4.2.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18143
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Sun, 10 Dec 2006 21:43:39 +0000 (21:43 +0000)]
Fixes for the layout tests regression testing and removal
of few unimplemented warnings (from lars)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18142
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Sun, 10 Dec 2006 21:37:45 +0000 (21:37 +0000)]
Enable the SVG build by default and make it build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18141
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Sun, 10 Dec 2006 20:29:54 +0000 (20:29 +0000)]
This should go in in 18139, it's WebKitQt not WebKit
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18140
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Sun, 10 Dec 2006 20:05:01 +0000 (20:05 +0000)]
Move the "*Client classes to WebKitQt/WebCoreSupport. Uptil
now they were all scattered around the Qt platform build dirs,
this cleans it up.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Sun, 10 Dec 2006 19:14:11 +0000 (19:14 +0000)]
Add WebKitBuild/Release back to the output dir for external build cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Sun, 10 Dec 2006 19:02:46 +0000 (19:02 +0000)]
Some more fixes to the dumprendertree application (from lars)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Sun, 10 Dec 2006 18:57:27 +0000 (18:57 +0000)]
Add the project file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Sun, 10 Dec 2006 18:46:24 +0000 (18:46 +0000)]
Add back some stubs needed to compile (from lars, r=me)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Sun, 10 Dec 2006 18:16:47 +0000 (18:16 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=10996
WebKit needs (possibly private) XML/SVG innerText support (for DumpRenderTree)
Create an internal method to create innerText functionality for non-HTML
nodes. When called from DRT this omits CDATA nodes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sun, 10 Dec 2006 10:17:28 +0000 (10:17 +0000)]
2006-12-10 MorganL <morganl.webkit@yahoo.com>
Reviewed by Maciej.
Fixes http://bugs.webkit.org/show_bug.cgi?id=11790
No way to initialize ResourceResponse::m_httpHeaderFields
* platform/network/ResourceResponse.cpp: impl setHTTPHeaderField
(WebCore::ResourceResponse::setHTTPHeaderField):
* platform/network/ResourceResponse.h: decl setHTTPHeaderField
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Sun, 10 Dec 2006 09:21:56 +0000 (09:21 +0000)]
Cleanup more of the FrameQt crack - mainly finally remove
the methods that have been moved to their proper locations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Sun, 10 Dec 2006 07:13:57 +0000 (07:13 +0000)]
Remove unused/pointless code from FrameQtClient.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc