darin [Fri, 3 Oct 2003 22:38:15 +0000 (22:38 +0000)]
- updated layout tests for recent WebTextRenderer changes
* layout-tests/apple-only/base/www.cnn.com/index-expected.txt:
* layout-tests/apple-only/base/www.sun.com/index-expected.txt:
* layout-tests/css1/font_properties/font_weight-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 3 Oct 2003 22:32:11 +0000 (22:32 +0000)]
Fix for numerous regressions caused by an inadvertent renaming of the recursiveDisplay
override method.
Reviewed by darin
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rjw [Fri, 3 Oct 2003 21:57:15 +0000 (21:57 +0000)]
Fixed some edge case issue (control characters after end of word) with our rounding hack.
Reviewed by Darin.
* WebCoreSupport.subproj/WebTextRenderer.m:
(-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cblu [Fri, 3 Oct 2003 21:51:04 +0000 (21:51 +0000)]
Removed eastCursor.tiff because it was added by mistake.
* Resources/eastCursor.tiff: Removed.
* WebCore.pbproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 3 Oct 2003 21:49:11 +0000 (21:49 +0000)]
Reviewed by Richard.
- fixed
3398420 - crash when creating a new document.body object in <body>
Also included David Faure's improvement to throw an exception.
* khtml/html/html_documentimpl.cpp:
(HTMLDocumentImpl::setBody): Don't remove the body when null is passed in,
as this means type error at the higher level, so throw an exception.
* khtml/html/htmlparser.cpp:
(KHTMLParser::KHTMLParser): Initialize current to 0.
(KHTMLParser::setCurrent): Ref new current and deref old; we need to
keep it ref'd because script execution could drop the current node on the
floor.
(KHTMLParser::reset): Use setCurrent.
(KHTMLParser::insertNode): Likewise.
(KHTMLParser::reopenResidualStyleTags): Likewise.
(KHTMLParser::popOneBlock): Likewise.
(KHTMLParser::finished): Likewise.
* khtml/html/htmlparser.h: Prototype setCurrent.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cblu [Fri, 3 Oct 2003 21:46:13 +0000 (21:46 +0000)]
Ran compress-tiffs on new cursor images.
* Resources/eastCursor.tiff:
* Resources/eastResizeCursor.tiff:
* Resources/helpCursor.tiff:
* Resources/moveCursor.tiff:
* Resources/northEastResizeCursor.tiff:
* Resources/northResizeCursor.tiff:
* Resources/northWestResizeCursor.tiff:
* Resources/southEastResizeCursor.tiff:
* Resources/southResizeCursor.tiff:
* Resources/southWestResizeCursor.tiff:
* Resources/waitCursor.tiff:
* Resources/westResizeCursor.tiff:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kocienda [Fri, 3 Oct 2003 18:46:38 +0000 (18:46 +0000)]
WebCore:
Reviewed by Darin, with much help from Maciej and Hyatt
Fix for these bugs:
<rdar://problem/
3441321>: Form buttons do not respond to key events when focused
<rdar://problem/
3441060>: Form buttons do not scroll to view when focused
* khtml/html/html_formimpl.cpp:
(HTMLInputElementImpl::simulateMouseClickForEvent): Added helper to simulate
mouse clicks in elements. Used to trigger button actions in response to
keyboard events.
(HTMLInputElementImpl::defaultEventHandler): Improved handler to process
key press events for radio, checkbox, image, reset, and submit buttons.
* khtml/html/html_formimpl.h: Added simulateMouseClickForEvent function.
* khtml/xml/dom2_eventsimpl.h:
(DOM::EventImpl::isKeyboardEvent): Added type check virtual function.
(DOM::KeyEventImpl::isKeyboardEvent): Ditto.
* kwq/KWQButton.h:
* kwq/KWQButton.mm:
(-[KWQButton simulateClick]): New method. This makes AppKit do a
button click programatically for button types. For <input type=image>,
we just simulate a the click in the DOM since there is no real "clickable"
AppKit widget.
(-[KWQButton becomeFirstResponder]): Fixes the button scroll to visible when
focused issue.
(-[KWQButton resignFirstResponder]): Correctly give up focus when user clicks
into the page body when a button has the focus.
(QButton::simulateClick): QWidget bridge to the KWQButton simulateClick
method.
WebKit:
Reviewed by Darin, with much help from Maciej and Hyatt
Fix for this bug:
<rdar://problem/
3441321>: Form buttons do not respond to key events when focused
* WebView.subproj/WebFrameView.m:
(-[WebFrameView _firstResponderIsControl]): Added to tell if the focus
is on a form control.
(-[WebFrameView keyDown:]): Call new _firstResponderIsControl method to see
whether space bar key events should propagate. Adding this check keeps us
from blocking the event here and allows AppKit to handle it.
* WebView.subproj/WebFrameViewPrivate.h: Add new _firstResponderIsControl
method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 3 Oct 2003 18:40:21 +0000 (18:40 +0000)]
Removing redundant layouts and adding a few !needsLayout and !normalChildNeedsLayout
checks to prevent extra layouts.
Also, fixing the recalcStyle changed() bottleneck to go through view's layout and to
not do a full repaint. The layout method will then do the right thing (full repaint
without INCREMENTAL_REPAINTING turned on, the precise repainting needed otherwise).
Reviewed by darin
* khtml/html/html_tableimpl.cpp:
(HTMLTableElementImpl::parseAttribute):
* khtml/rendering/render_block.cpp:
* khtml/rendering/render_container.cpp:
(RenderContainer::appendChildNode):
(RenderContainer::insertChildNode):
* khtml/xml/dom_docimpl.cpp:
(DocumentImpl::recalcStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 3 Oct 2003 00:48:08 +0000 (00:48 +0000)]
Folded Private implementation files into the regular ones as the
first step towards pulling in our SPI exposure and other code
cleanup.
* History.subproj/WebHistory.m:
* History.subproj/WebHistoryPrivate.m: Removed.
* Misc.subproj/WebIconDatabasePrivate.h:
* WebKit.pbproj/project.pbxproj:
* WebView.subproj/WebDataSource.m:
* WebView.subproj/WebDataSourcePrivate.m: Removed.
* WebView.subproj/WebFrame.m:
* WebView.subproj/WebFramePrivate.m: Removed.
* WebView.subproj/WebFrameView.m:
* WebView.subproj/WebFrameViewPrivate.m: Removed.
* WebView.subproj/WebHTMLView.m:
* WebView.subproj/WebHTMLViewPrivate.m: Removed.
* WebView.subproj/WebView.m:
* WebView.subproj/WebViewPrivate.m: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 2 Oct 2003 23:28:33 +0000 (23:28 +0000)]
Remove the speed hit from using the UC break locators by not using them when
checking if the current character is and by also using a global text
break locator object.
Reviewed by rjw
* khtml/rendering/break_lines.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cblu [Thu, 2 Oct 2003 23:16:50 +0000 (23:16 +0000)]
Fixed: <rdar://problem/
3440063>: Safari 1.1 won't load new pages after visiting adultswim.com, assertion failure on debug build
Reviewed by rjw.
* Plugins.subproj/WebBaseNetscapePluginStream.m:
(-[WebBaseNetscapePluginStream finishedLoadingWithData:]): if not data was received for a stream, create the temp file anyway. Plug-ins expect this.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vicki [Thu, 2 Oct 2003 22:11:03 +0000 (22:11 +0000)]
tree is open for Safari-109
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vicki [Thu, 2 Oct 2003 22:06:17 +0000 (22:06 +0000)]
Safari-108 stamp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 2 Oct 2003 19:58:51 +0000 (19:58 +0000)]
* English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 2 Oct 2003 18:50:00 +0000 (18:50 +0000)]
Reviewed by Darin.
- fixed
3441466 - REGRESSION: http://www.meyerweb.com/eric/css/edge/complexspiral/glassy.html broken on scroll
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _setState:]): Don't turn on scroll-blitting here when the page is done...
(-[WebFrame _transitionToCommitted:]): Instead do it here, when the page is committed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 2 Oct 2003 18:46:18 +0000 (18:46 +0000)]
Reviewed by Darin.
- fixed
3398622 - Crash when JavaScript changes display style
This was a problem with one of the many global variables in
bidi.cpp, last, having a stale value from the last layout that
pointed to a dead node. I fixed this by refactoring the code to
put most of the global variables in a struct allocated on the
stack, and pass around a reference to the struct. Seems much
cleaner (if somewhat wordier) this way. There are still more
global variables to kill here.
* khtml/rendering/bidi.cpp:
(khtml::BidiIterator::BidiIterator):
(khtml::BidiStatus::BidiStatus):
(khtml::BidiInfo::BidiInfo):
(khtml::Bidinext):
(khtml::first):
(khtml::BidiIterator::increment):
(khtml::checkMidpoints):
(khtml::appendRunsForObject):
(khtml::appendRun):
(khtml::embed):
(khtml::RenderBlock::computeHorizontalPositionsForLine):
(khtml::RenderBlock::bidiReorderLine):
(khtml::buildCompactRuns):
(khtml::RenderBlock::layoutInlineChildren):
(khtml::RenderBlock::findNextLineBreak):
* khtml/rendering/bidi.h:
* khtml/rendering/render_block.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 2 Oct 2003 18:35:05 +0000 (18:35 +0000)]
Reviewed by Ken.
- in preparation for a WebCore whitespace-handling change, made WebTextRenderer draw and measure
newline characters as if they are spaces (just as we already do with non-breaking spaces)
- removed some unused stuff from WebTextRenderer
- other unimportant tweaks (e.g. unsigned int -> unsigned)
* WebCoreSupport.subproj/WebTextRenderer.m:
(kFixedOne), (fixed1), (FixToFloat), (FloatToFixed): Removed these. We can use the standard ones
from <FixMath.h> instead of defining our own.
(isControlCharacter): Added. Inline function that we can use instead of the macro we had before.
(isAlternateSpace): Added. Returns YES for newlines and non-breaking spaces.
(isSpace): Added. Returns YES for real spaces and the two alternate spaces as well.
(initializeCharacterWidthIterator): Use isSpace.
(-[WebTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]): Use isAlternateSpace
and isControlCharacter.
(-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):
Use isControlCharacter, isAlternateSpace, and isSpace. Also fix a small bug where numGlyphs would
not get set up properly when the run length is 0, and used local variables when possible instead
of going back at the run structure.
(-[WebTextRenderer _ATSU_floatWidthForRun:style:]): Use the standard FixedToFloat instead of our
own FixToFloat.
(-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 2 Oct 2003 18:23:53 +0000 (18:23 +0000)]
Work on exposing elements to the Acc API. This patch gets us to the point where text
under the mouse is voiced.
Reviewed by darin
* kwq/KWQAccObject.h:
* kwq/KWQAccObject.mm:
(-[KWQAccObject initWithRenderer:]):
(-[KWQAccObject parentObject]):
(-[KWQAccObject parentObjectUnignored]):
(-[KWQAccObject addChildrenToArray:]):
(-[KWQAccObject role]):
(-[KWQAccObject roleDescription]):
(-[KWQAccObject value]):
(-[KWQAccObject title]):
(-[KWQAccObject position]):
(-[KWQAccObject size]):
(-[KWQAccObject accessibilityIsIgnored]):
(-[KWQAccObject accessibilityAttributeNames]):
(-[KWQAccObject accessibilityActionNames]):
(-[KWQAccObject accessibilityIsAttributeSettable:]):
(-[KWQAccObject accessibilityAttributeValue:]):
(-[KWQAccObject accessibilityHitTest:]):
* kwq/KWQAccObjectCache.mm:
(KWQAccObjectCache::accObject):
(KWQAccObjectCache::setAccObject):
(KWQAccObjectCache::removeAccObject):
* kwq/WebCoreBridge.h:
* kwq/WebCoreBridge.mm:
(-[WebCoreBridge accessibilityTree]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 2 Oct 2003 18:22:26 +0000 (18:22 +0000)]
Work on exposing elements to the Acc API. This patch gets us to the point where text
under the mouse is voiced.
Reviewed by darin
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView accessibilityAttributeValue:]):
(-[WebHTMLView accessibilityHitTest:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 2 Oct 2003 18:19:27 +0000 (18:19 +0000)]
Reviewed by Dave.
- fixed
3441656 -- constructor bad for objs created w/ function as prototype (www.moock.org/asdg/codedepot)
* kjs/nodes.cpp: (FuncDeclNode::processFuncDecl): Set up the constructor as
as specified in the JavaScript spec. We were already doing this right in the
other place we make functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 2 Oct 2003 15:31:23 +0000 (15:31 +0000)]
Reviewed by Ken.
* kwq/KWQRenderTreeDebug.cpp: (quoteAndEscapeNonPrintables): Since our text rendering renders
non-breaking spaces the same as spaces, dump them as spaces. Do the same with newlines since
I am about to change our text rendering to do the same with newlines.
* layout-tests: Updated test results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 2 Oct 2003 01:43:40 +0000 (01:43 +0000)]
Avoid doing extra work when tearing down the document by checking to see if
we're in the destruction of the document.
Reviewed by darin
* khtml/rendering/render_block.cpp:
* khtml/rendering/render_container.cpp:
(RenderContainer::removeChildNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Thu, 2 Oct 2003 00:24:38 +0000 (00:24 +0000)]
Reviewed by Darin
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView viewDidMoveToSuperview]):
skip some work when when we've been removed. This wasn't
causing any trouble before, but was at least conceptually
inefficient.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Thu, 2 Oct 2003 00:07:43 +0000 (00:07 +0000)]
- fixed
3441372: REGRESSION (107+): Plain text document is
initially drawn with proportional font
Reviewed by Hyatt
* WebView.subproj/WebTextView.m:
(-[WebTextView setDataSource:]):
Changed a != to an ==
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rjw [Wed, 1 Oct 2003 23:57:47 +0000 (23:57 +0000)]
WebKit:
Fixed
3438441. If a load is triggered by a onload handling, don't add an entry for it into the b/f or history. The new Google ads use this technique.
Reviewed by Ken.
* Misc.subproj/WebKitLogging.h:
* Misc.subproj/WebKitLogging.m:
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge loadURL:referrer:reload:onLoadEvent:target:triggeringEvent:form:formValues:]):
* WebView.subproj/WebFramePrivate.h:
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _addBackForwardItemClippedAtTarget:]):
(-[WebFrame _transitionToCommitted:]):
(-[WebFrame _isLoadComplete]):
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _itemForRestoringDocState]):
WebCore:
Fixed
3438441. Pass extra info up to WebKit about load type, specifically is a load is triggered by JS running in an onLoad handler.
Reviewed by Ken.
* khtml/ecma/kjs_binding.h:
* kwq/KWQKHTMLPart.mm:
(KWQKHTMLPart::openURL):
(KWQKHTMLPart::openURLRequest):
(KWQKHTMLPart::submitForm):
(KWQKHTMLPart::urlSelected):
* kwq/KWQKHTMLPartBrowserExtension.mm:
(KHTMLPartBrowserExtension::createNewWindow):
* kwq/WebCoreBridge.h:
* kwq/WebCoreBridge.mm:
(-[WebCoreBridge saveDocumentToPageCache]):
Nothing changed. Tweaked spacing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5110
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 1 Oct 2003 23:56:33 +0000 (23:56 +0000)]
Reviewed by John.
* WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _webView]):
Fixed problem where we'd get a nil WebView and pass crazy values for subframe
text multipliers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cblu [Wed, 1 Oct 2003 23:27:11 +0000 (23:27 +0000)]
<rdar://problem/
2942589>: CSS cursors are not implemented
Reviewed by Dave.
* Resources/eastCursor.tiff: Added.
* Resources/eastResizeCursor.tiff: Added.
* Resources/helpCursor.tiff: Added.
* Resources/moveCursor.tiff: Added.
* Resources/northEastResizeCursor.tiff: Added.
* Resources/northResizeCursor.tiff: Added.
* Resources/northWestResizeCursor.tiff: Added.
* Resources/southEastResizeCursor.tiff: Added.
* Resources/southResizeCursor.tiff: Added.
* Resources/southWestResizeCursor.tiff: Added.
* Resources/waitCursor.tiff: Added.
* Resources/westResizeCursor.tiff: Added.
* WebCore.pbproj/project.pbxproj:
* khtml/css/cssparser.cpp: special-case the hand cursor to mean pointer
(CSSParser::parseValue):
* khtml/css/cssvalues.c: generated changes
(hash_val):
(findValue):
* khtml/css/cssvalues.h: generated changes
* khtml/css/cssvalues.in: removed the progress cursor from the list because it was messing up the mapping
* khtml/khtmlview.cpp: call new cursor methods
* kwq/KWQKCursor.h:
* kwq/KWQKCursor.mm:
(+[NSCursor _WebCore_cursorWithName:hotSpot:]): new, loads and caches cursors
(KCursor::crossCursor): get the AppKit cross hair cursor
(KCursor::handCursor): call _WebCore_cursorWithName:hotSpot:
(KCursor::sizeAllCursor): ditto
(KCursor::waitCursor): ditto
(KCursor::whatsThisCursor): ditto
(KCursor::eastResizeCursor): new, call _WebCore_cursorWithName:hotSpot:
(KCursor::northResizeCursor): ditto
(KCursor::northEastResizeCursor): ditto
(KCursor::northWestResizeCursor): ditto
(KCursor::southResizeCursor): ditto
(KCursor::southEastResizeCursor): ditto
(KCursor::southWestResizeCursor): ditto
(KCursor::westResizeCursor): ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 1 Oct 2003 20:58:56 +0000 (20:58 +0000)]
Clean up our detach model so that you can always get to a document, even for
anonymous content. Also stubbing out and adding the accessibility objects.
Reviewed by darin, mjs, john
* ChangeLog:
* WebCore.pbproj/project.pbxproj:
* khtml/rendering/render_block.cpp:
* khtml/rendering/render_box.cpp:
(RenderBox::detach):
* khtml/rendering/render_box.h:
* khtml/rendering/render_canvas.cpp:
(RenderCanvas::RenderCanvas):
* khtml/rendering/render_container.cpp:
(RenderContainer::detach):
(RenderContainer::addChild):
(RenderContainer::updatePseudoChild):
(RenderContainer::insertChildNode):
(RenderContainer::removeLeftoverAnonymousBoxes):
* khtml/rendering/render_container.h:
* khtml/rendering/render_flow.cpp:
(RenderFlow::createAnonymousFlow):
(RenderFlow::deleteLineBoxes):
(RenderFlow::detach):
* khtml/rendering/render_flow.h:
* khtml/rendering/render_form.cpp:
(RenderTextArea::detach):
* khtml/rendering/render_form.h:
* khtml/rendering/render_image.cpp:
(RenderImage::RenderImage):
(RenderImage::detach):
* khtml/rendering/render_image.h:
* khtml/rendering/render_inline.cpp:
(RenderInline::addChildToFlow):
(RenderInline::splitFlow):
(RenderInline::renderName):
* khtml/rendering/render_list.cpp:
(RenderListItem::setStyle):
(RenderListItem::detach):
(RenderListItem::updateMarkerLocation):
(RenderListMarker::RenderListMarker):
* khtml/rendering/render_list.h:
* khtml/rendering/render_object.cpp:
(RenderObject::RenderObject):
(RenderObject::information):
(RenderObject::dump):
(RenderObject::createAnonymousBlock):
(RenderObject::remove):
(RenderObject::detach):
* khtml/rendering/render_object.h:
* khtml/rendering/render_replaced.cpp:
(RenderWidget::detach):
* khtml/rendering/render_replaced.h:
* khtml/rendering/render_table.cpp:
(RenderTable::addChild):
(RenderTableSection::detach):
(RenderTableSection::addChild):
(RenderTableRow::detach):
(RenderTableRow::addChild):
(RenderTableCell::detach):
* khtml/rendering/render_table.h:
* khtml/rendering/render_text.cpp:
(RenderText::detach):
(RenderText::deleteRuns):
* khtml/rendering/render_text.h:
* khtml/xml/dom_docimpl.cpp:
(DocumentImpl::DocumentImpl):
(DocumentImpl::~DocumentImpl):
(DocumentImpl::detach):
(DocumentImpl::getOrCreateAccObjectCache):
* khtml/xml/dom_docimpl.h:
* khtml/xml/dom_nodeimpl.cpp:
(NodeImpl::detach):
* kwq/KWQAccObject.h: Added.
* kwq/KWQAccObject.mm: Added.
(-[KWQAccObject x]):
(-[KWQAccObject y]):
(-[KWQAccObject width]):
(-[KWQAccObject height]):
(-[KWQAccObject detached]):
(-[KWQAccObject detach]):
(-[KWQAccObject data]):
(-[KWQAccObject setData:]):
(-[KWQAccObject firstChild]):
(-[KWQAccObject lastChild]):
(-[KWQAccObject previousSibling]):
(-[KWQAccObject nextSibling]):
(-[KWQAccObject parentObject]):
* kwq/KWQAccObjectCache.h: Added.
* kwq/KWQAccObjectCache.mm: Added.
(KWQAccObjectCache::KWQAccObjectCache):
(KWQAccObjectCache::~KWQAccObjectCache):
(KWQAccObjectCache::accObject):
(KWQAccObjectCache::setAccObject):
(KWQAccObjectCache::removeAccObject):
(KWQAccObjectCache::detach):
* layout-tests/css1/pseudo/firstletter-expected.txt:
* layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
* layout-tests/fast/css-generated-content/002-expected.txt:
* layout-tests/fast/css-generated-content/004-expected.txt:
* layout-tests/fast/css-generated-content/005-expected.txt:
* layout-tests/fast/css-generated-content/006-expected.txt:
* layout-tests/fast/selectors/039-expected.txt:
* layout-tests/fast/selectors/039b-expected.txt:
* layout-tests/fast/selectors/041-expected.txt:
* layout-tests/fast/selectors/042-expected.txt:
* layout-tests/fast/selectors/166a-expected.txt:
* layout-tests/fast/selectors/168-expected.txt:
* layout-tests/fast/selectors/168a-expected.txt:
* layout-tests/fast/selectors/169-expected.txt:
* layout-tests/fast/selectors/169a-expected.txt:
* layout-tests/fast/text/firstline/002-expected.txt:
* layout-tests/fast/text/firstline/003-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 1 Oct 2003 20:36:13 +0000 (20:36 +0000)]
Adding layout test for setting of cssFlaot via a with clause.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 1 Oct 2003 20:30:38 +0000 (20:30 +0000)]
Fix for
3163840, the images are mispositioned on the DHTML menus at the top of
www.aa.com (and in many other places). We needed to support returning the right
value from hasProperty and tryGet for 'cssFloat'.
This patch also adds support for getting/setting our custom CSS properties (-khtml-*)
and just factors the code a bit better for all the special values.
Reviewed by darin
* khtml/ecma/kjs_css.cpp:
(cssPropertyName):
(DOMCSSStyleDeclaration::hasProperty):
(DOMCSSStyleDeclaration::tryGet):
(DOMCSSStyleDeclaration::tryPut):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 1 Oct 2003 20:22:52 +0000 (20:22 +0000)]
Reviewed by Dave.
- fixed
3437309 -- REGRESSION (100-107): Javascript menu doesn't work at www.aa.com
* khtml/xml/dom_elementimpl.cpp: (ElementImpl::removeAttribute): Restored the old behavior
for removeAttribute and removeAttributeNS; these don't give NOT_FOUND_ERR. But keep the
NOT_FOUND_ERR for removeAttributeNode and removedNamedItem.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kocienda [Wed, 1 Oct 2003 19:57:27 +0000 (19:57 +0000)]
Reviewed by me
* kwq/KWQWidget.mm:
(QWidget::focusPolicy): Improved comment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kocienda [Wed, 1 Oct 2003 18:48:13 +0000 (18:48 +0000)]
Reviewed by Maciej
Fix for these bugs:
<rdar://problem/
3439736>: WebCore form button widgets do not accept focus
<rdar://problem/
3440770>: WebCore form button widgets do not take part in tabbing order
* kwq/KWQButton.h: Add focusPolicy function declaration.
* kwq/KWQButton.mm:
(-[KWQButton nextKeyView]): Add tabbing support for buttons.
(-[KWQButton previousKeyView]): Ditto
(-[KWQButton nextValidKeyView]): Ditto
(-[KWQButton previousValidKeyView]): Ditto
(QButton::focusPolicy): Add focusPolicy implementation. This calls through
to the recently-added accessor for full keyboard access to help in the
determination for focus policy. For now, full keyboard access must be
turned on for buttons to receive focus.
* kwq/KWQTextEdit.h: Remove focusPolicy specialization from this class. The
implementation in QWidget now serves this class well.
* kwq/KWQTextEdit.mm: Ditto
* kwq/KWQWidget.h: Added isEnabled function. Small, unrelated cleanup to
move the no-implementation setFocusPolicy() and setFocusProxy() functions
fully into the header file.
* kwq/KWQWidget.mm:
(QWidget::isEnabled): Added. Calls through to the Cocoa view to retrieve
this information.
(QWidget::focusPolicy): Much improved focus policy function is now more
general in stipulating the conditions for focus policy, and will work for
more widgets.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 1 Oct 2003 18:36:57 +0000 (18:36 +0000)]
Fix for
3440804, broken scrollbars in downloads window. Make Auto be the default
value in the enum, so that all scrollviews will be automatically initialized to be
auto.
Reviewed by cblu
* kwq/KWQScrollView.h:
* kwq/WebCoreFrameView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5100
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 1 Oct 2003 18:34:46 +0000 (18:34 +0000)]
Fix for
3440804, broken scrollbars in downloads window. Make Auto be the default
value in the enum, so that all scrollviews will be automatically initialized to be
auto.
Reviewed by cblu
* WebView.subproj/WebDynamicScrollBarsView.m:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5099
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rjw [Wed, 1 Oct 2003 00:47:11 +0000 (00:47 +0000)]
Attempt to find a reasonable font using a simple string matching heuristic if
none of the fonts actually specified are found. In particular we will use
Geeza Pro if "arabic", "urdu", or "pashto" is contained (case-insensitive) in
any of the requested font family names. Geeza Pro is a much better fallback
font for Arabic (and variant languages) than Helvetica.
Reviewed by Chris.
* WebCoreSupport.subproj/WebTextRendererFactory.m:
(-[WebTextRendererFactory fontWithFamilies:traits:size:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Wed, 1 Oct 2003 00:38:25 +0000 (00:38 +0000)]
WebKit:
- fixed
3045617 -- Make Text Bigger/Smaller doesn't affect non-html documents.
I added an internal protocol inside WebKit to make this work, and implemented
it for plain text and RTF. I also slightly shuffled the existing code to
handle this for HTML so that it goes through the new protocol in that case
also.
Reviewed by NOBODY (OOPS!).
* WebView.subproj/WebDocumentInternal.h: Added.
New header file, holds definition of
_web_WebDocumentTextSizing protocol.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _textSizeMultiplierChanged]):
if the document view conforms to the new protocol,
tell it that the multiplier has changed. Also, don't
tell the bridge here anymore; let WebHTMLView do that.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView _updateTextSizeMultiplier]):
tell the bridge here instead of having WebFrame do so
(-[WebHTMLView viewDidMoveToSuperview]):
call _updateTextSizeMultiplier (in case it changed while we were switched out)
(-[WebHTMLView _web_textSizeMultiplierChanged]):
call _updateTextSizeMultiplier
* WebView.subproj/WebTextRepresentation.m:
(-[WebTextRepresentation receivedData:withDataSource:]):
* WebView.subproj/WebTextView.h:
now implements _web_WebDocumentTextSizing protocol;
new ivar for holding local copy of text size multiplier;
new public method appendReceivedData:fromDataSource:
* WebView.subproj/WebTextView.m:
(-[WebTextView initWithFrame:]):
set local copy of text size multiplier to 1.0
(-[WebTextView _textSizeMultiplierFromWebView]):
new method, asks the webview's opinion of the text size multiplier
(-[WebTextView setFixedWidthFont]):
use the text size multiplier when setting font size
(-[WebTextView _adjustRichTextFontSizeByRatio:]):
new method, borrowed from Mail and tweaked, that walks through
the rich text and adjusts the font sizes
(-[WebTextView _updateTextSizeMultiplier]):
new method, updates local copy of text size multiplier to
match webview's opinion
(-[WebTextView setDataSource:]):
set the text size multiplier appropriately before setting the
fixed-width font; this is too early for the RTF case though
since the fonts are embedded in the data
(-[WebTextView appendReceivedData:fromDataSource:]):
new method. Most of this logic was in WebTextRepresentation, but
it's a little better encapsulated here, plus now it handles the
text multiplier for RTF.
(-[WebTextView defaultsChanged:]):
added comment
(-[WebTextView _web_textSizeMultiplierChanged]):
call updateTextSizeMultiplier
* WebView.subproj/WebView.m:
(-[WebView canMakeTextSmaller]):
(-[WebView canMakeTextLarger]):
return NO if the main frame doesn't support the text sizing protocol. This means
that if the main frame doesn't support it but a subframe does, you can't adjust
the text size. This seems fine for now since the only case with subframes is
HTML, where the main frame does support changing text size.
* WebKit.pbproj/project.pbxproj:
updated for new file
WebBrowser:
Reviewed by Darin
* HTMLSourceDocument.h:
removed unused _textSizeMultiplier ivar
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cblu [Wed, 1 Oct 2003 00:08:26 +0000 (00:08 +0000)]
Fixed: <rdar://problem/
3428262>: Plugin loads for static files, but not PHP scripts
Reviewed by rjw.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge frameRequiredForMIMEType:]): load the plug-in DB so this method returns reliable results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kocienda [Tue, 30 Sep 2003 23:17:34 +0000 (23:17 +0000)]
Reviewed by me
* WebCore.pbproj/project.pbxproj: Made WebCoreKeyboardAccess.h a private header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cblu [Tue, 30 Sep 2003 23:07:26 +0000 (23:07 +0000)]
Fixed: <rdar://problem/
3006869>: show image dimensions in title bar when single image is loaded
Reviewed by rjw.
* English.lproj/Localizable.strings:
* WebView.subproj/WebImageRepresentation.m:
(-[WebImageRepresentation title]): return "foo.jpg 50x50 pixels"
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rjw [Tue, 30 Sep 2003 23:04:14 +0000 (23:04 +0000)]
Fixed
3420396. If a frame targets _top and a URL that contains a fragment (very unusual, it's meaningless for a frameset to contain a named anchor point) the frameset won't be reloaded. Our normal path is to just scroll to the anchor point. This is only important because our Help folks oddly depend on the behavior.
Reviewed by Chris.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kocienda [Tue, 30 Sep 2003 22:47:55 +0000 (22:47 +0000)]
I added this file earlier, but a cvs-abandon command removed it. Re-adding and committing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kocienda [Tue, 30 Sep 2003 22:47:03 +0000 (22:47 +0000)]
WebCore:
Reviewed by Maciej
Fix for this bug:
<rdar://problem/
3439688>: WebKit needs to retrieve full keyboard access preference
* WebCore.pbproj/project.pbxproj:
* kwq/KWQKHTMLPart.h: Declare keyboardUIMode accessor.
* kwq/KWQKHTMLPart.mm:
(KWQKHTMLPart::keyboardUIMode): Implement keyboardUIMode accessor (calls through the bridge).
* kwq/WebCoreBridge.h: Declare the bridge accessor.
* kwq/WebCoreKeyboardAccess.h: Added. Header defines keyboard UI mode constants.
WebKit:
Reviewed by Maciej
Fix for this bug:
<rdar://problem/
3439688>: WebKit needs to retrieve full keyboard access preference
* WebCoreSupport.subproj/WebBridge.h: Add two ivars: one to track the keyboard
UI mode, the other a flag we use to register for notifications.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge dealloc]): Remove the notification observer to keyboard UI mode changes.
(-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): New method. Accesses the
preferences to get the current keyboard UI mode.
(-[WebBridge keyboardUIMode]): Returns the current keyboard UI mode. Registers for
notifications of keyboard UI mode changes when called the first time.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 30 Sep 2003 21:58:07 +0000 (21:58 +0000)]
WebCore:
Reviewed by Ken.
- fixed
3375281 - Keyboard event handlers not fired if focus not in form field
- fixed
3242927 - KeyPressed Event in Javascript don't work
- fixed
3375353 - keyboard event.target not updated when blurring from form items
- fixed
3183754 - returning false from key press handlers does not prevent typing or form submission
* khtml/xml/dom_nodeimpl.cpp:
(NodeImpl::dispatchKeyEvent): Force false when defaultHandled instead of
based on a weird rule appropriate for KDE but not for us.
* kwq/KWQKHTMLPart.mm:
(KWQKHTMLPart::keyEvent): If there's no focus node, give the event
to the body element instead of giving up. Also, reverse
expectedsense of return value dispatchKeyEvent, since it returns
true if it *didn't* swallow the event. And finally, let the key press
event as well as the key down event for the initial NSKeyDown block
default handling.
* kwq/KWQListBox.mm:
(-[KWQTableView keyDown:]): Respect return value from interceptKeyEvent:
(-[KWQTableView keyUp:]): ditto
* kwq/KWQTextArea.mm:
(-[KWQTextAreaTextView keyDown:]): ditto
(-[KWQTextAreaTextView keyUp:]): ditto
* kwq/KWQTextField.mm:
(-[KWQTextField textView:shouldHandleEvent:]): ditto
WebKit:
Reviewed by Ken.
- fixed
3375281 - Keyboard event handlers not fired if focus not in form field
- fixed
3242927 - KeyPressed Event in Javascript don't work
- fixed
3375353 - keyboard event.target not updated when blurring from form items
- fixed
3183754 - returning false from key press handlers does not prevent typing or form submission
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView keyDown:]): Ask the bridge before passing the event along.
(-[WebHTMLView keyUp:]): Likewise.
* WebView.subproj/WebHTMLViewPrivate.h:
* WebView.subproj/WebHTMLViewPrivate.m: Remove dead code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rjw [Tue, 30 Sep 2003 21:06:30 +0000 (21:06 +0000)]
Fixed
3422138. We weren't sending a didChange call for isLoading until the load was complete! Also [WebView isLoading] wasn't accounting for provisional datasources.
Reviewed by Chris.
* WebView.subproj/WebView.m:
(-[WebView isLoading]):
* WebView.subproj/WebViewPrivate.h:
* WebView.subproj/WebViewPrivate.m:
(-[WebView _didStartProvisionalLoadForFrame:]):
(-[WebView _didCommitLoadForFrame:]):
(-[WebView _didFinishLoadForFrame:]):
(-[WebView _didFailLoadWithError:forFrame:]):
(-[WebView _didFailProvisionalLoadWithError:forFrame:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 30 Sep 2003 19:53:04 +0000 (19:53 +0000)]
Update layout tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 30 Sep 2003 18:47:22 +0000 (18:47 +0000)]
Backing out an accidental commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 30 Sep 2003 18:46:27 +0000 (18:46 +0000)]
Improvements to scrolling and layout. Also fixing
3264346, body overflow should
apply to document's scrollbars.
Reviewed by darin
* WebView.subproj/WebDynamicScrollBarsView.h:
* WebView.subproj/WebDynamicScrollBarsView.m:
(-[WebDynamicScrollBarsView initWithFrame:]):
(-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView setAllowsScrolling:]):
(-[WebDynamicScrollBarsView allowsScrolling]):
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
(-[WebDynamicScrollBarsView horizontalScrollingMode]):
(-[WebDynamicScrollBarsView verticalScrollingMode]):
(-[WebDynamicScrollBarsView setHorizontalScrollingMode:]):
(-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
(-[WebDynamicScrollBarsView setScrollingMode:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 30 Sep 2003 18:45:47 +0000 (18:45 +0000)]
Improvements to layout transitions and scrollbar appearance/disappearance.
Also implementing a fix for
3264346, overflow applied to body should apply to
the document's scrollers.
Reviewed by darin
* khtml/html/html_baseimpl.cpp:
(HTMLFrameElementImpl::parseAttribute):
* khtml/khtmlview.cpp:
(KHTMLView::KHTMLView):
(KHTMLView::~KHTMLView):
(KHTMLView::resetScrollBars):
(KHTMLView::clear):
(KHTMLView::initScrollBars):
(KHTMLView::applyBodyScrollQuirk):
(KHTMLView::inLayout):
* khtml/khtmlview.h:
* khtml/rendering/render_block.cpp:
* khtml/rendering/render_block.h:
* khtml/rendering/render_canvas.cpp:
(RenderCanvas::layout):
* khtml/rendering/render_form.cpp:
(TextAreaWidget::TextAreaWidget):
* khtml/rendering/render_frames.cpp:
(RenderFrame::slotViewCleared):
(RenderPartObject::slotViewCleared):
* khtml/rendering/render_list.cpp:
(RenderListMarker::calcMinMaxWidth):
* khtml/rendering/render_object.cpp:
(RenderObject::repaint):
(RenderObject::repaintRectangle):
* khtml/xml/dom_docimpl.cpp:
(DocumentImpl::setInPageCache):
* kwq/KWQKHTMLPart.mm:
(KWQKHTMLPart::createPart):
* kwq/KWQRenderTreeDebug.cpp:
(write):
(externalRepresentation):
* kwq/KWQScrollView.h:
* kwq/KWQScrollView.mm:
(QScrollView::setVScrollBarMode):
(QScrollView::setHScrollBarMode):
(QScrollView::setScrollBarsMode):
(QScrollView::vScrollBarMode):
(QScrollView::hScrollBarMode):
(QScrollView::hasVerticalScrollBar):
(QScrollView::hasHorizontalScrollBar):
(QScrollView::suppressScrollBars):
* kwq/WebCoreBridge.mm:
(-[WebCoreBridge installInFrame:]):
* kwq/WebCoreFrameView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 30 Sep 2003 18:39:03 +0000 (18:39 +0000)]
Fix for
3437260, nil deref of the render style because it hasn't been set yet.
Fallout from my incremental repainting landing.
Reviewed by darin
* khtml/rendering/render_replaced.cpp:
(RenderWidget::setQWidget):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 30 Sep 2003 18:35:43 +0000 (18:35 +0000)]
Reviewed by Dave.
Rolled in Harri Porten's change to accept non-breaking space in JavaScript.
* kjs/lexer.cpp: (Lexer::isWhiteSpace): Accept 00A0 as "whitespace".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 30 Sep 2003 18:30:31 +0000 (18:30 +0000)]
Fix for
3438479, tables expand on every layout when a cell has percentage height
children.
Reviewed by darin
* khtml/rendering/render_table.cpp:
(RenderTableSection::calcRowHeight):
(RenderTableRow::layout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cblu [Mon, 29 Sep 2003 23:04:02 +0000 (23:04 +0000)]
Fixed: <rdar://problem/
3332460>: nil-deref in khtml::RenderWidget::eventFilter with onchange handler
Reviewed by darin.
* kwq/KWQTextField.mm:
(-[KWQTextField controlTextDidEndEditing:]): call setHasFocus:NO last so we have the widget that lets us get to the bridge and lets us call controlTextDidEndEditing
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 29 Sep 2003 22:33:45 +0000 (22:33 +0000)]
Fix for
3425053, text past the bottom of a positioned table doesn't repaint.
3426847 is the same bug. Both are fixed by ensuring that calcHeight doesn't actually
do anything other than margin computation and position determination for positioned
elements. In reality, for weird edge cases like implying the height via explicit top and
bottom properties, we'll still be wrong.
Reviewed by darin
* ChangeLog:
* khtml/rendering/render_table.cpp:
(RenderTable::layout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cblu [Mon, 29 Sep 2003 22:05:49 +0000 (22:05 +0000)]
Fixed: <rdar://problem/
3422739>: Plug-in streams not cancelled when plug-in returns error from NPP_NewStream
Reviewed by mjs.
* Plugins.subproj/WebBaseNetscapePluginStream.h: renamed receivedError to cancelWithReason
* Plugins.subproj/WebBaseNetscapePluginStream.m:
(-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): call cancelWithReason if NPP_NewStream returns an error
(-[WebBaseNetscapePluginStream cancelWithReason:]): renamed
(-[WebBaseNetscapePluginStream finishedLoadingWithData:]): tweak
* Plugins.subproj/WebNetscapePluginRepresentation.m:
(-[WebNetscapePluginRepresentation receivedError:withDataSource:]): call renamed cancelWithReason
(-[WebNetscapePluginRepresentation cancelWithReason:]): new override, stop load then call super
* Plugins.subproj/WebNetscapePluginStream.m:
(-[WebNetscapePluginStream cancelWithReason:]): new override, stop load then call super
(-[WebNetscapePluginStream stop]): call cancelWithReason
(-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): call renamed cancelWithReason
(-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): call renamed cancelWithReason
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 29 Sep 2003 21:10:59 +0000 (21:10 +0000)]
Forgot to commit expected.txt for new whitespace test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 29 Sep 2003 21:10:15 +0000 (21:10 +0000)]
Add layout test for abs positioned object inside relpositioned inline containing block
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 29 Sep 2003 20:29:47 +0000 (20:29 +0000)]
Adding layout test for <pre> maxwidth bug.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 29 Sep 2003 20:27:42 +0000 (20:27 +0000)]
Make sure that timeouts updateRendering after they execute the scheduled timer
action.
Also fixing
3429455, maxwidth of pres miscomputed when two blank lines occur at
the end of a pre text run.
Reviewed by darin, mjs (setTimeout fix), darin (pre fix)
* khtml/ecma/kjs_window.cpp:
(ScheduledAction::execute):
* khtml/rendering/render_text.cpp:
(RenderText::trimmedMinMaxWidth):
(RenderText::calcMinMaxWidth):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 29 Sep 2003 16:49:18 +0000 (16:49 +0000)]
Reviewed by John.
- fixed
3437292 -- Safari uses wrong characters for ∧ and ∨ entities
* khtml/html/kentities.gperf: Corrected values for ∧ and ∨ entities.
Checked all the rest against a list on the W3C site, and those are the only two that were wrong.
* khtml/html/kentities.c: Regnenerated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kocienda [Fri, 26 Sep 2003 16:44:51 +0000 (16:44 +0000)]
Reviewed by John
Fix for this bug:
<rdar://problem/
3435532>: REGRESSION: tabbing to textareas causes infinite recursion
Add recursion guards to the becomeFirstResponder method, otherwise calling
eventFilter with a FocusIn event will cause the infinite recursion
described in the bug.
* kwq/KWQTextArea.mm:
(-[KWQTextAreaTextView becomeFirstResponder]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 26 Sep 2003 04:12:32 +0000 (04:12 +0000)]
Reviewed by John.
* khtml/ecma/kjs_window.cpp:
(Window::installTimeout): Variant that takes a function and args.
(WindowFunc::tryCall): If the argument is a function, call the
function variant of installTimeout instead of pointlessly passing
the string. Also, correctly implement the code to pass extra args
along.
* khtml/ecma/kjs_window.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 26 Sep 2003 04:08:15 +0000 (04:08 +0000)]
Tools:
Roll out build system change since it did not actually work. :-(
* Scripts/SourceTools.pm:
* Scripts/embed-into-alex: Added.
* Scripts/embed-into-webkit: Removed.
JavaScriptCore:
Roll out build system change since it did not actually work. :-(
* JavaScriptCore.pbproj/project.pbxproj:
* Makefile.am:
WebCore:
Roll out build system change since it did not actually work. :-(
* WebCore.pbproj/project.pbxproj:
WebKit:
Roll out build system change since it did not actually work. :-(
* WebKit.pbproj/project.pbxproj:
WebBrowser:
Roll out build system change since it did not actually work. :-(
* WebBrowser.pbproj/project.pbxproj:
* add-environment.sh: Removed.
* embed-frameworks.sh: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 26 Sep 2003 01:04:06 +0000 (01:04 +0000)]
Updating the layout tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 26 Sep 2003 00:58:11 +0000 (00:58 +0000)]
Change layout so that it is called from the private _recursive functions instead of
inside drawRect.
Reviewed by kocienda
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView layoutToPageWidth:adjustingViewSize:]):
(-[WebHTMLView drawRect:]):
* WebView.subproj/WebHTMLViewPrivate.m:
(-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:testDirtyRect:]):
(-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
(-[WebHTMLView _web_setPrintingModeRecursive]):
(-[WebHTMLView _web_clearPrintingModeRecursive]):
(-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]):
(-[NSView _web_setPrintingModeRecursive]):
(-[NSView _web_clearPrintingModeRecursive]):
(-[NSView _web_layoutIfNeededRecursive:testDirtyRect:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 26 Sep 2003 00:57:15 +0000 (00:57 +0000)]
Landing the new repainting code. This code eliminates many redundant layouts, makes
layout scheduling work properly when called from WebKit, cleans up relpositioned inlines
that act as containing blocks for absolute positioned children, and eliminates the
repaint timer.
Reviewed by kocienda
* ChangeLog:
* khtml/html/html_documentimpl.cpp:
(HTMLDocumentImpl::close):
* khtml/khtmlview.cpp:
(KHTMLView::KHTMLView):
* khtml/khtmlview.h:
* khtml/rendering/render_block.cpp:
* khtml/rendering/render_block.h:
* khtml/rendering/render_box.cpp:
(RenderBox::setStyle):
(RenderBox::setPixmap):
(RenderBox::getAbsoluteRepaintRect):
(RenderBox::computeAbsoluteRepaintRect):
(RenderBox::repaintIfMoved):
(RenderBox::calcAbsoluteHorizontal):
(RenderBox::calcAbsoluteVertical):
* khtml/rendering/render_box.h:
* khtml/rendering/render_canvas.cpp:
(RenderCanvas::layout):
(RenderCanvas::repaintViewRectangle):
(RenderCanvas::getAbsoluteRepaintRect):
(RenderCanvas::computeAbsoluteRepaintRect):
* khtml/rendering/render_canvas.h:
* khtml/rendering/render_container.cpp:
(RenderContainer::addChild):
(RenderContainer::removeChildNode):
(RenderContainer::removeChild):
(RenderContainer::appendChildNode):
(RenderContainer::insertChildNode):
* khtml/rendering/render_flexbox.cpp:
* khtml/rendering/render_flow.cpp:
(RenderFlow::getAbsoluteRepaintRect):
* khtml/rendering/render_flow.h:
* khtml/rendering/render_image.cpp:
(RenderImage::setPixmap):
(RenderImage::layout):
* khtml/rendering/render_inline.cpp:
(RenderInline::addChildToFlow):
* khtml/rendering/render_layer.cpp:
(RenderLayer::convertToLayerCoords):
* khtml/rendering/render_list.cpp:
(RenderListMarker::setPixmap):
* khtml/rendering/render_object.cpp:
(RenderObject::RenderObject):
(RenderObject::setNeedsLayout):
(RenderObject::setChildNeedsLayout):
(RenderObject::markContainingBlocksForLayout):
(RenderObject::containingBlock):
(RenderObject::repaint):
(RenderObject::repaintRectangle):
(RenderObject::repaintAfterLayoutIfNeeded):
(RenderObject::repaintIfMoved):
(RenderObject::repaintPositionedAndFloatingDescendants):
(RenderObject::getAbsoluteRepaintRect):
(RenderObject::getAbsoluteRepaintRectIncludingDescendants):
(RenderObject::computeAbsoluteRepaintRect):
(RenderObject::setStyle):
(RenderObject::container):
(RenderObject::detach):
(RenderObject::scheduleRelayout):
* khtml/rendering/render_object.h:
* khtml/rendering/render_style.cpp:
(RenderStyle::diff):
* khtml/rendering/render_table.cpp:
(RenderTable::layout):
(RenderTableRow::getAbsoluteRepaintRect):
(RenderTableCell::computeAbsoluteRepaintRect):
* khtml/rendering/render_table.h:
* khtml/xml/dom_nodeimpl.cpp:
(NodeBaseImpl::insertBefore):
(NodeBaseImpl::replaceChild):
(NodeBaseImpl::appendChild):
* kwq/KWQKHTMLPart.mm:
(KWQKHTMLPart::clearTimers):
* kwq/KWQRenderTreeDebug.cpp:
(write):
(externalRepresentation):
* kwq/KWQRenderTreeDebug.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 25 Sep 2003 22:42:00 +0000 (22:42 +0000)]
Fix the css1 failure, since we now pass the test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rjw [Thu, 25 Sep 2003 22:31:00 +0000 (22:31 +0000)]
Fixed
3433802. Written by Ed. Carbon WebView doesn't detach native view when removed.
Reviewed by Richard.
* Carbon.subproj/HIWebView.m:
(OwningWindowChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rjw [Thu, 25 Sep 2003 22:26:47 +0000 (22:26 +0000)]
Fixed
3433488. Written by Ed. WebKit doesn't sync window visibility when new webview added to visible window.
Reviewed by Richard.
* Carbon.subproj/CarbonWindowAdapter.m:
(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rjw [Thu, 25 Sep 2003 22:15:00 +0000 (22:15 +0000)]
Fixed
3434854. Written by Ed. Correctly handle window modality in carbon.
Reviewed by Richard.
* Carbon.subproj/CarbonWindowAdapter.m:
(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2003-09-25 Maciej Stachowiak <mjs@apple.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 25 Sep 2003 21:09:03 +0000 (21:09 +0000)]
Tools:
Reviewed by Darin.
* Scripts/SourceTools.pm: Don't try to install Foundation on the
system any more. The new build setup takes care of it.
* Scripts/embed-into-alex: Removed.
* Scripts/embed-into-webkit: Added.
JavaScriptCore:
Reviewed by Darin.
* JavaScriptCore.pbproj/project.pbxproj: Don't hack install name. Instead
of embedding into Safari, embed into WebKit as sub-umbrella.
* Makefile.am: Don't forget to rebuild if the user removes
JavaScript.framework from symroots manually.
WebCore:
Reviewed by Darin.
* WebCore.pbproj/project.pbxproj: Don't hack install name. Instead
of embedding into Safari, embed into WebKit as sub-umbrella.
WebKit:
Reviewed by Darin.
Updated setup for engineering builds. Don't embed the framework
into Safari or hack the install name. However, do copy WebCore and
JavaScriptCore into the proper sub-umbrella locations.
* WebKit.pbproj/project.pbxproj:
* embed-frameworks.sh: Added.
WebBrowser:
Reviewed by Darin.
Changed things around for the engineering Safari build. Instead of
building frameworks embedded, set DYLD_FRAMEWORK_PATH via the
Info.plist (for engineering builds only). This also removes the
need to install engineering builds of Foundation on the system.
* WebBrowser.pbproj/project.pbxproj:
* add-environment.sh: Added.
* embed-frameworks.sh: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vicki [Thu, 25 Sep 2003 20:43:54 +0000 (20:43 +0000)]
The tree is open for Safari-108!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vicki [Thu, 25 Sep 2003 20:40:57 +0000 (20:40 +0000)]
Safari-107 stamp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 25 Sep 2003 19:59:23 +0000 (19:59 +0000)]
- rolled out change to fix
3390850 because it caused a performance regression
* khtml/misc/decoder.cpp: (Decoder::decode): Rolled out change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kocienda [Thu, 25 Sep 2003 17:06:27 +0000 (17:06 +0000)]
Reviewed by Darin
Fix for this bug:
<rdar://problem/
3341222>: WebView doesn't follow AppKit default nextKeyView pattern
* WebCoreSupport.subproj/WebBridge.h: Added a variable to guard against recursion
in -[WebBridge inNextKeyViewOutsideWebFrameViews].
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge inNextKeyViewOutsideWebFrameViews]): Accessor for recursion guard.
(-[WebBridge nextKeyViewOutsideWebFrameViews]): Do not ask webView for its
next key view, but rather, ask it for the next key view of the last view in
its key view loop. This is what will get us to the next view outside of the
webView.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView nextKeyView]): Ask AppKit, rather than khtml, for the next key
key view if -[WebBridge inNextKeyViewOutsideWebFrameViews] returns YES. Doing
so gives us the correct answer as calculated by AppKit, and makes HTML views
behave like other views. This check also heads off an infinite recursion
through -[WebBridge nextKeyViewOutsideWebFrameViews].
Also did some cleanup of some code that was marked for removal "some day".
That "some day" is today.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 25 Sep 2003 17:00:02 +0000 (17:00 +0000)]
Reviewed by John.
- fixed
3176853 -- can't attach files that have no extensions with Yahoo mail (bad Content-Type headers)
* WebCoreSupport.subproj/WebBridge.m: (-[WebBridge MIMETypeForPath:]):
Return @"application/octet-stream" rather than nil or empty string when the type is not known.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kocienda [Thu, 25 Sep 2003 16:51:11 +0000 (16:51 +0000)]
Reviewed by Dave
Name change: TextRun is now InlineTextBox. Some related names
have been changed as well. There should be no change in
behavior as a result of this patch.
* khtml/khtml_part.cpp:
(KHTMLPart::selectedText):
(firstRunAt):
(lastRunAt):
(startAndEndLineNodesIncludingNode):
* khtml/rendering/bidi.cpp:
* khtml/rendering/render_flow.cpp:
(RenderFlow::paintLineBoxDecorations):
* khtml/rendering/render_line.cpp:
(InlineFlowBox::placeBoxesHorizontally):
(InlineFlowBox::placeBoxesVertically):
* khtml/rendering/render_line.h:
* khtml/rendering/render_text.cpp:
(InlineTextBox::detach):
(throw):
(InlineTextBox::operator delete):
(InlineTextBox::paintSelection):
(InlineTextBox::paintDecoration):
(InlineTextBox::checkSelectionPoint):
(InlineTextBoxArray::InlineTextBoxArray):
(InlineTextBoxArray::compareItems):
(InlineTextBoxArray::findFirstMatching):
(RenderText::deleteRuns):
(RenderText::findNextInlineTextBox):
(RenderText::nodeAtPoint):
(RenderText::checkSelectionPointIgnoringContinuations):
(RenderText::cursorPos):
(RenderText::posOfChar):
(RenderText::paintObject):
(RenderText::createInlineBox):
(RenderText::position):
(RenderText::width):
* khtml/rendering/render_text.h:
* kwq/KWQKHTMLPart.mm:
(KWQKHTMLPart::attributedString):
* kwq/KWQRenderTreeDebug.cpp:
(writeTextRun):
(write):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 25 Sep 2003 14:50:17 +0000 (14:50 +0000)]
Added a new layout test.
* layout-tests/fast/forms/form-element-geometry-expected.txt: Added.
* layout-tests/fast/forms/form-element-geometry.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 25 Sep 2003 06:36:18 +0000 (06:36 +0000)]
* layout-tests/fast/table/003-expected.txt: Updated for textarea width change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 25 Sep 2003 04:34:22 +0000 (04:34 +0000)]
Added marker now that the change was reviewed by Maciej.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 25 Sep 2003 04:28:55 +0000 (04:28 +0000)]
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
Added one more call to _stopAutoscrollTimer for when drags begin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 25 Sep 2003 00:47:40 +0000 (00:47 +0000)]
*** empty log message ***
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5051
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 25 Sep 2003 00:44:44 +0000 (00:44 +0000)]
Adding clipping tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5050
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 25 Sep 2003 00:37:35 +0000 (00:37 +0000)]
Fix for
3429646, <img src="blah"<img src="foo"> should show up as two images.
Reviewed by darin
* khtml/html/htmlparser.cpp:
(KHTMLParser::handleResidualStyleCloseTagAcrossBlocks):
* khtml/html/htmltokenizer.cpp:
(HTMLTokenizer::parseTag):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 25 Sep 2003 00:09:14 +0000 (00:09 +0000)]
Reviewed by Dave.
- fixed a recent regression, and ...
- fixed
3386544 -- ARCH: <object>s don't support transclusion like <iframe>s do
* khtml/khtml_part.cpp: (KHTMLPart::childFrame): Added back a cast I should
not have removed to fix the function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 25 Sep 2003 00:00:28 +0000 (00:00 +0000)]
Fix for
3430612, crash on about:blank in updateHoverActiveState. Just missing
a null-check. Also remove a hover optimization that was bogus.
Reviewed by darin
* khtml/rendering/render_layer.cpp:
(RenderLayer::updateHoverActiveState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rjw [Wed, 24 Sep 2003 23:05:26 +0000 (23:05 +0000)]
WebKit:
Fixed
3420736. Clear renderer caches when get an ATS font changed notification. This fix may be moot depending on progress toward fixing
2695906. Also
3428451 needs to should be resolved.
Also added code to get and log entry point for the function used to get a Java class from plugins. That class is used for LiveConnect support.
Reviewed by John.
* Misc.subproj/WebKitLogging.h:
* Misc.subproj/WebKitLogging.m:
* Plugins.subproj/WebNetscapePluginPackage.h:
* Plugins.subproj/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage load]):
* Plugins.subproj/npapi.h:
* WebCoreSupport.subproj/WebTextRenderer.m:
(FillStyleWithAttributes):
* WebCoreSupport.subproj/WebTextRendererFactory.m:
(-[WebTextRendererFactory clearCaches]):
(fontsChanged):
(+[WebTextRendererFactory createSharedFactory]):
(-[WebTextRendererFactory fontWithFamily:traits:size:]):
(-[WebTextRendererFactory cachedFontFromFamily:traits:size:]):
WebCore:
Fixed
3420736. Clear renderer caches when get an ATS font changed notification. This fix may be moot depending on progress toward fixing
2695906.
* kwq/WebCoreBridge.h:
* kwq/WebCoreBridge.mm:
(+[WebCoreBridge updateAllViews]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Sep 2003 16:37:31 +0000 (16:37 +0000)]
- a new test for JavaScript date parsing
* layout-tests/fast/js/date-parse-test-expected.txt: Added.
* layout-tests/fast/js/date-parse-test.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Sep 2003 16:37:10 +0000 (16:37 +0000)]
Reviewed by Ken.
- fixed
3421107 -- some dates that other browsers can parse can't be parsed by KJS's Date.parse()
* kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Added code to be more strict about month names,
to allow a time zone after date even if the date omits the time, and to understand AM and PM.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Sep 2003 15:55:20 +0000 (15:55 +0000)]
Reviewed by Ken.
- fixed ownerElement for documents in HTML objects (helpful for some work Dave is doing)
* khtml/khtml_part.h: Change name of frame function to childFrame for clarity.
* khtml/khtml_part.cpp:
(KHTMLPart::slotChildStarted): Call the frame function by its new name, childFrame.
(KHTMLPart::slotChildCompleted): Ditto.
(KHTMLPart::slotChildURLRequest): Ditto.
(KHTMLPart::childFrame): Change name from frame to childFrame for clarity, and make it work
for parts inside HTML objects, not just normal frames and iframes. The change in behavior is
the actual fix. Note that for the three callers above, it's an error to call this when the
result would be 0, so there's no harm in doing the extra search of HTML objects in those cases.
* khtml/xml/dom_docimpl.cpp: (DocumentImpl::ownerElement): Call the frame function by its new
name, childFrame. This is the caller that will benefit most from the change in behavior.
* kwq/KWQKHTMLPart.h: Remove childFrameForPart function, which is superseded by the
childFrame function now.
* kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrameHierarchy): Use childFrame instead
of childFrameForPart.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Sep 2003 04:52:35 +0000 (04:52 +0000)]
Reviewed by Ken.
- fixed
3390850 -- Shift_JIS in meta tag ignored because <img> tag in JavaScript comes first (vintagecomp.com)
* khtml/misc/decoder.cpp: (Decoder::decode): Don't let tags inside a script make us think we're in the body.
Later we can enhance this even more.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Sep 2003 23:45:25 +0000 (23:45 +0000)]
Update bug number to
3127833 -- autoscroll only works when mouse is moving.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Sep 2003 23:19:58 +0000 (23:19 +0000)]
Reviewed by John and Richard.
- fixed
3367377 -- autoscroll only works when mouse is moving
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView viewDidMoveToWindow]): Stop the auto-scroll timer. This covers
the case where a view is removed from the view hierarchy while the mouse is down.
(-[WebHTMLView mouseDown:]): Start the auto-scroll timer.
(-[WebHTMLView mouseUp:]): Stop the auto-scroll timer.
* WebView.subproj/WebHTMLViewPrivate.h: Add an auto-scroll timer, and methods
to start and stop it.
* WebView.subproj/WebHTMLViewPrivate.m:
(-[WebHTMLView _startAutoscrollTimer]): Create and schedule a timer. It uses the
same 1/10 second interval that NSTextView uses for its scrolling timer.
(-[WebHTMLView _stopAutoscrollTimer]): Invalidate and release the timer.
(-[WebHTMLView _autoscroll]): Check for a mouse up event in the queue; if one is
there, then no autoscrlling. But if not, then create a fake mouse dragged event
and dispatch it; that will lead to autoscrolling.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Sep 2003 14:47:30 +0000 (14:47 +0000)]
Reviewed by Ken.
- fixed
3292723 -- onBlur() getting called twice on <input type=text>
* khtml/rendering/render_replaced.cpp: (RenderWidget::eventFilter):
Call setFocusNode(0) instead of explicitly sending a blur event, otherwise
setFocusNode will send a second blur event later.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Sep 2003 06:34:09 +0000 (06:34 +0000)]
Fix minor coding style issue in this test; something was being
computed twice.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Sep 2003 06:28:48 +0000 (06:28 +0000)]
Fix check-in snafu.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Sep 2003 06:11:38 +0000 (06:11 +0000)]
Reviewed by Dave.
- worked around
3429631 -- window stops getting mouse moved events after first tooltip appears
* WebView.subproj/WebHTMLViewPrivate.m: (-[NSToolTipPanel setAcceptsMouseMovedEvents:]):
Do nothing, preventing the real setAcceptsMouseMovedEvents: (in class NSWindow) from being called.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Sep 2003 06:09:45 +0000 (06:09 +0000)]
Reviewed by Dave.
- worked around
3429631 -- window stops getting mouse moved events after first tooltip appears
* WebView.subproj/WebHTMLViewPrivate.m: (-[NSToolTipPanel setAcceptsMouseMovedEvents:]):
Do nothing, preventing the real setAcceptsMouseMovedEvents: (in class NSWindow) from being called.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Sep 2003 04:03:16 +0000 (04:03 +0000)]
- fixed
3391837 -- we list ISO-8859-8-E as visual ordering for Hebrew; it's "explicit ordering", not supported
* kwq/mac-encodings.txt: Removed ISO-8859-8-E.
* kwq/KWQCharsetData.c: Regenerated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 22 Sep 2003 23:29:42 +0000 (23:29 +0000)]
* kwq/KWQTextEdit.mm: (QTextEdit::sizeWithColumnsAndRows): Made it compile.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log