WebKit-https.git
11 years ago2010-07-27 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 28 Jul 2010 05:59:06 +0000 (05:59 +0000)]
2010-07-27  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed build fix.

        Add missing webkitdomdefines.h header to the sources list.

        * GNUmakefile.am: Add missing header to the sources list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 28 Jul 2010 05:16:18 +0000 (05:16 +0000)]
2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Ojan Vafai.

        Add FILE_SYSTEM build flag for FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=42915

        * Configurations/FeatureDefines.xcconfig:
2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Ojan Vafai.

        Add FILE_SYSTEM build flag for FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=42915

        * features.gypi:
2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Ojan Vafai.

        Add FILE_SYSTEM build flag for FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=42915

        * Configurations/FeatureDefines.xcconfig:
2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Ojan Vafai.

        Add FILE_SYSTEM build flag for FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=42915

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:
2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Ojan Vafai.

        Add FILE_SYSTEM build flag for FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=42915

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * WebCore.pri:
2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Ojan Vafai.

        Add FILE_SYSTEM build flag for FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=42915

        * configure.ac:
2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Ojan Vafai.

        Add FILE_SYSTEM build flag for FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=42915

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 28 Jul 2010 04:09:22 +0000 (04:09 +0000)]
2010-07-27  Daniel Bates  <dbates@rim.com>

        Unreviewed; remove platform-specific expected results.
        https://bugs.webkit.org/show_bug.cgi?id=42803

        We no longer need the Qt an GTK platform-specific render tree dumps
        as we now dump text.

        * platform/gtk/fast/lists/alpha-boundary-values-expected.txt: Removed.
        * platform/gtk/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
        * platform/qt/fast/lists/alpha-boundary-values-expected.checksum: Removed.
        * platform/qt/fast/lists/alpha-boundary-values-expected.png: Removed.
        * platform/qt/fast/lists/alpha-boundary-values-expected.txt: Removed.
        * platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.
        * platform/qt/fast/lists/w3-list-styles-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 28 Jul 2010 03:48:36 +0000 (03:48 +0000)]
2010-07-26  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        @page rules in media queries should be tested.
        Added tests for such rules.
        https://bugs.webkit.org/show_bug.cgi?id=42971

        * printing/page-rule-selection-expected.txt:
        * printing/page-rule-selection.html:
2010-07-26  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        @page rules in media queries should be tested.
        https://bugs.webkit.org/show_bug.cgi?id=42971

        * page/PrintContext.cpp:
        (WebCore::PrintContext::pageProperty): Fixed to properly begin
        printing. Added support for size property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 28 Jul 2010 03:44:53 +0000 (03:44 +0000)]
2010-07-27  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        Convert DRT list tests from pixel-tests/render tree dumps to text
        https://bugs.webkit.org/show_bug.cgi?id=42803

        With the passing of Bug #37929 and Bug #37930, convert a subset of the
        DRT tests for lists from pixel-tests to text-based tests now that we
        can retrieve the list item marker text in both the Mac and Windows ports.

        * fast/lists/alpha-boundary-values-expected.txt: Added.
        * fast/lists/alpha-boundary-values.html: Modified to dump as text.
        * fast/lists/alpha-list-wrap-expected.txt: Added.
        * fast/lists/alpha-list-wrap.html: Modified to dump as text.
        * fast/lists/decimal-leading-zero-expected.txt: Added.
        * fast/lists/decimal-leading-zero.html: Modified to dump as text.
        * fast/lists/li-values-expected.txt: Added.
        * fast/lists/li-values.html: Modified to dump as text.
        * fast/lists/list-style-type-dynamic-change-expected.txt: Added.
        * fast/lists/list-style-type-dynamic-change.html: Modified to dump as text.
        * fast/lists/resources/dump-list.js:
        (dumpList): Modified to call processList.
        (filterListsWithReplacement): Added.
        (processList): Added.
        (dumpListItemAsHTML): Added.
        (printPassedIfEmptyString): Added.
        (printFailedIfListItemMarkerNotEqualListItemText): Added.
        * fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Added.
        * fast/lists/w3-css3-list-styles-alphabetic.html: Modified to dump as text.
        * fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
        * fast/lists/w3-css3-list-styles-numeric.html: Modified to dump as text.
          Also, fix typos in the binary list-style-type results.
        * fast/lists/w3-list-styles-expected.txt: Added.
        * fast/lists/w3-list-styles.html: Modified to dump as text.
        * platform/mac/fast/lists/alpha-boundary-values-expected.checksum: Removed.
        * platform/mac/fast/lists/alpha-boundary-values-expected.png: Removed.
        * platform/mac/fast/lists/alpha-boundary-values-expected.txt: Removed.
        * platform/mac/fast/lists/alpha-list-wrap-expected.checksum: Removed.
        * platform/mac/fast/lists/alpha-list-wrap-expected.png: Removed.
        * platform/mac/fast/lists/alpha-list-wrap-expected.txt: Removed.
        * platform/mac/fast/lists/decimal-leading-zero-expected.checksum: Removed.
        * platform/mac/fast/lists/decimal-leading-zero-expected.png: Removed.
        * platform/mac/fast/lists/decimal-leading-zero-expected.txt: Removed.
        * platform/mac/fast/lists/li-values-expected.checksum: Removed.
        * platform/mac/fast/lists/li-values-expected.png: Removed.
        * platform/mac/fast/lists/li-values-expected.txt: Removed.
        * platform/mac/fast/lists/list-style-type-dynamic-change-expected.checksum: Removed.
        * platform/mac/fast/lists/list-style-type-dynamic-change-expected.png: Removed.
        * platform/mac/fast/lists/list-style-type-dynamic-change-expected.txt: Removed.
        * platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Removed.
        * platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Removed.
        * platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
        * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Removed.
        * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.png: Removed.
        * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.
        * platform/mac/fast/lists/w3-list-styles-expected.checksum: Removed.
        * platform/mac/fast/lists/w3-list-styles-expected.png: Removed.
        * platform/mac/fast/lists/w3-list-styles-expected.txt: Removed.
        * platform/win/fast/lists: Removed.
        * platform/win/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
        * platform/win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 28 Jul 2010 01:50:40 +0000 (01:50 +0000)]
2010-07-27  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by David Levin.

        Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
        https://bugs.webkit.org/show_bug.cgi?id=43090

        * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTemporarily rolling out http://trac.webkit.org/changeset/64177,
barraclough@apple.com [Wed, 28 Jul 2010 00:36:56 +0000 (00:36 +0000)]
Temporarily rolling out trac.webkit.org/changeset/64177,
this seems to give QT ARM/Win a headache (specifically, looks
like structure layour differs, objects get too large -
"..\..\..\JavaScriptCore\runtime\ArrayPrototype.cpp:41:"
"error: size of array 'dummyclass_fits_in_cell' is negative").

* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
* runtime/JSArray.cpp:
(JSC::increasedVectorLength):
(JSC::JSArray::JSArray):
(JSC::JSArray::~JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::subclassData):
(JSC::JSArray::setSubclassData):
(JSC::JSArray::checkConsistency):
* runtime/JSArray.h:
(JSC::JSArray::length):
(JSC::JSArray::canGetIndex):
(JSC::JSArray::getIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::uncheckedSetIndex):
(JSC::JSArray::markChildrenDirect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpeculative build fix for Chromium/Win
barraclough@apple.com [Wed, 28 Jul 2010 00:30:34 +0000 (00:30 +0000)]
Speculative build fix for Chromium/Win

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoOh! that makes more sense! Maybe C++-style comments are bringing teh bad mojo.
barraclough@apple.com [Wed, 28 Jul 2010 00:04:29 +0000 (00:04 +0000)]
Oh! that makes more sense!  Maybe C++-style comments are bringing teh bad mojo.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Windows build.
andersca@apple.com [Wed, 28 Jul 2010 00:00:16 +0000 (00:00 +0000)]
Fix Windows build.

* WebProcess/Plugins/JSNPObject.cpp:
(WebKit::JSNPObject::propertyGetter):
Remove unreachable code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpeculative build fix for GTK/64 ... seems to be barfing on a comment o_O
barraclough@apple.com [Tue, 27 Jul 2010 23:57:42 +0000 (23:57 +0000)]
Speculative build fix for GTK/64 ... seems to be barfing on a comment o_O

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Tue, 27 Jul 2010 23:41:01 +0000 (23:41 +0000)]
2010-07-27  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed.

        Marking media/controls-drag-timebar.html as flaky due to new seek behaviour.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Tue, 27 Jul 2010 23:38:57 +0000 (23:38 +0000)]
2010-07-27  James Hawkins  <jhawkins@chromium.org>

        Unreviewed Build Fix.

        Add a missing itemIcon() method to TestPopupMenuClient.

        * tests/PopupMenuTest.cpp:
        (WebKit::TestPopupMenuClient::itemIcon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChanged the handling for removing and adding elements at the front
barraclough@apple.com [Tue, 27 Jul 2010 23:26:30 +0000 (23:26 +0000)]
Changed the handling for removing and adding elements at the front
of an array.  The code now keeps a bias that indicates the amount of
JSValue sized holes are prior to the ArrayStorage block.  This means
that shift operations are now memmove's of the header part of
the ArrayStorage and unshift operations are similar, but may require a
realloc first to create the space.  Similar operations are performed
for special cases of splice and slice.
Also optimized the new Array(size) case so that we don't allocate and
initialize array elements until the JS code starts using elements.
The array growth code is slightly more aggressive for initial growth
based on size growth of any previous array.

Patch by Michael Saboff <msaboff@apple.com> on 2010-07-27
Reviewed by Gavin Barraclough.

* Configurations/JavaScriptCore.xcconfig:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
(JSC::JSArray::~JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::getNewVectorLength):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::subclassData):
(JSC::JSArray::setSubclassData):
(JSC::JSArray::checkConsistency):
* runtime/JSArray.h:
(JSC::JSArray::length):
(JSC::JSArray::canGetIndex):
(JSC::JSArray::getIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::uncheckedSetIndex):
(JSC::JSArray::arrayStorage):
(JSC::JSArray::setArrayStorage):
(JSC::JSArray::markChildrenDirect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 43089 - Cleanup JIT related switched in Platform.h
barraclough@apple.com [Tue, 27 Jul 2010 23:19:29 +0000 (23:19 +0000)]
Bug 43089 - Cleanup JIT related switched in Platform.h

Reviewed by Oliver Hunt.

The code the enable to JIT checks every permutation of platform & OS individually, but
now the JIT is enabled on the majority much all x86/x86-64/ARM/MIPS systems.  It should
be cleaner to just enable by default on these platforms, and explicitly disable on configs
that don't aren't supported.

Also, rename ENABLE_JIT_OPTIMIZE_MOD to ENABLE_JIT_USE_SOFT_MODULO.  I always find this
confusing since enabling this "optimization" would be possible, but would be a regression
on x86/x86-64 systems!  I think it's clearer to reserve "JIT_OPTIMIZE" for compiler
technologies applicable to all platforms, and make a more optional behaviour like this a
"USE".

* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 27 Jul 2010 23:16:29 +0000 (23:16 +0000)]
2010-07-27  Kent Tamura  <tkent@chromium.org>

        Unreviewed, trivial typo fix.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
          Fix a wrong method name committed by r64109.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImplement JSNPObject::propertyGetter
andersca@apple.com [Tue, 27 Jul 2010 23:15:41 +0000 (23:15 +0000)]
Implement JSNPObject::propertyGetter
https://bugs.webkit.org/show_bug.cgi?id=43091

Reviewed by Sam Weinig.

WebKit2:

* WebProcess/Plugins/JSNPObject.cpp:
(WebKit::JSNPObject::propertyGetter):
Ask the NPObject for its property.

* WebProcess/Plugins/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::jsNPObjectDestroyed):
Add a stub.

(WebKit::NPRuntimeObjectMap::convertNPVariantToValue):
Implement this for everything except objects.

LayoutTests:

* platform/mac-wk2/Skipped:
Add a test I forgot to add, and remove plugins/npruntime/embed-property.html because it passes now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Tue, 27 Jul 2010 23:02:00 +0000 (23:02 +0000)]
2010-07-27  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Add the ability to show right-aligned icons in the AutoFill popup.
        https://bugs.webkit.org/show_bug.cgi?id=43076

        * public/WebView.h:
        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::getIcon):
        (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex):
        (WebKit::AutoFillPopupMenuClient::itemIcon):
        (WebKit::AutoFillPopupMenuClient::initialize):
        (WebKit::AutoFillPopupMenuClient::setSuggestions):
        * src/AutoFillPopupMenuClient.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::applyAutoFillSuggestions):
        (WebKit::WebViewImpl::applyAutocompleteSuggestions):
        * src/WebViewImpl.h:
2010-07-27  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Darin Fisher.

        Add itemIcon() method to the PopupMenuClient, used by Chrome AutoFill
        to display right-aligned credit card icons in the suggestions popup.
        https://bugs.webkit.org/show_bug.cgi?id=43076

        No new tests as this is only used by the Chromium WebKit API.

        * platform/PopupMenuClient.h:
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::paintRow):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::itemIcon):
        * rendering/RenderMenuList.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::itemIcon):
        * rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=43087
weinig@apple.com [Tue, 27 Jul 2010 22:47:50 +0000 (22:47 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
Clean up handling of strings at the WebKit2 API layer.

Reviewed by Anders Carlsson.

WebKit2:

- Always use the "copy" rule for functions that return WKStringRefs or WKURLRefs.
- Never return a null WKStringRef or WKURLRef.

* UIProcess/API/C/WKAPICast.h:
(toRef):
(toURLRef):
(toCopiedRef):
(toCopiedURLRef):
* UIProcess/API/C/WKBackForwardListItem.cpp:
(WKBackForwardListItemCopyOriginalURL):
(WKBackForwardListItemCopyURL):
(WKBackForwardListItemCopyTitle):
* UIProcess/API/C/WKBackForwardListItem.h:
* UIProcess/API/C/WKFrame.cpp:
(WKFrameIsMainFrame):
(WKFrameCopyProvisionalURL):
(WKFrameCopyURL):
(WKFrameGetPage):
(WKFrameRetain):
(WKFrameRelease):
* UIProcess/API/C/WKFrame.h:
* UIProcess/API/C/WKNavigationData.cpp:
(WKNavigationDataCopyTitle):
(WKNavigationDataCopyURL):
* UIProcess/API/C/WKNavigationData.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageCopyTitle):
* UIProcess/API/C/WKPage.h:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyURL):
(WKBundleFrameCopyName):
(WKBundleFrameCopyCounterValue):
(WKBundleFrameCopyMarkerText):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/InjectedBundle/API/c/WKBundleNode.cpp:
(WKBundleNodeCopyNodeName):
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyRenderTreeExternalRepresentation):

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(didNavigateWithNavigationData):
(-[BrowserWindowController updateProvisionalURLForFrame:]):
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(_didClearWindowForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 27 Jul 2010 22:46:58 +0000 (22:46 +0000)]
2010-07-27  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Unskip a test that is passing and add expected results to another.

        * platform/gtk/Skipped: Unskip passing test.
        * platform/gtk/fast/canvas/set-colors-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/canvas/set-colors-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 27 Jul 2010 22:41:45 +0000 (22:41 +0000)]
2010-07-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Make PLATFORM(CHROMIUM) and not OS(MAC) turn USE(GLES2_RENDERING) on
        https://bugs.webkit.org/show_bug.cgi?id=43084

        This turns USE(GLES2_RENDERING) on for chromium on windows/linux.  This causes no
        change in behavior, that's all controlled by ENABLE() macros that are currently off.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoExplicitly list all skipped tests in plugins/ so we can start removing passing tests.
andersca@apple.com [Tue, 27 Jul 2010 22:36:22 +0000 (22:36 +0000)]
Explicitly list all skipped tests in plugins/ so we can start removing passing tests.

Reviewed by Sam Weinig.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Tue, 27 Jul 2010 22:23:38 +0000 (22:23 +0000)]
2010-07-27  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by David Kilzer.

        Provide a Helpful Link for Web Inspector Bugs in Bugzilla
        https://bugs.webkit.org/show_bug.cgi?id=43065

        * template/en/custom/global/choose-product.html.tmpl: Added. Explicitly added a link for the Web Inspector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd JSNPObject, a JSObject that wraps an NPObject
andersca@apple.com [Tue, 27 Jul 2010 22:20:31 +0000 (22:20 +0000)]
Add JSNPObject, a JSObject that wraps an NPObject
https://bugs.webkit.org/show_bug.cgi?id=43079

Reviewed by Sam Weinig.

* WebKit2.xcodeproj/project.pbxproj:
Add JSNPObject.cpp and JSNPObject.h

* WebProcess/Plugins/JSNPObject.cpp: Added.
(WebKit::npIdentifierFromIdentifier):
(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::~JSNPObject):
(WebKit::JSNPObject::getOwnPropertySlot):
Check if the NPObject has the given property.

(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::throwInvalidAccessError):
* WebProcess/Plugins/JSNPObject.h: Added.
(WebKit::JSNPObject::createStructure):
* WebProcess/Plugins/NPJSObject.h:

* win/WebKit2.vcproj:
Add JSNPObject.cpp and JSNPObject.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Tue, 27 Jul 2010 22:16:58 +0000 (22:16 +0000)]
2010-07-27  Victor Wang  <victorw@chromium.org>

        Unreviewed. Update chromium test expectations for failed test:
        fast/canvas/canvas-ImageData-behaviour.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
commit-queue@webkit.org [Tue, 27 Jul 2010 22:16:09 +0000 (22:16 +0000)]
2010-07-27  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Update the QScriptValue autotests suite.

        QScriptValue generated files were updated, changes are:
         - More tested values (for example QSE::newObject() and QSE::newArray())
         - Tested values are recreated before each test and are not reused.
         The change implies better code coverage and some expected result changes.
         - A new test to check copy and assign functions.
         - Tests are using standard QTestLib interface, without any custom macros.

        [Qt] Improve test coverage for the QScriptValue
        https://bugs.webkit.org/show_bug.cgi?id=42366

        * tests/qscriptvalue/tst_qscriptvalue.cpp:
        (tst_QScriptValue::tst_QScriptValue):
        (tst_QScriptValue::~tst_QScriptValue):
        (tst_QScriptValue::assignAndCopyConstruct_data):
        (tst_QScriptValue::assignAndCopyConstruct):
        * tests/qscriptvalue/tst_qscriptvalue.h:
        * tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp:
        (tst_QScriptValue::equals_data):
        (tst_QScriptValue::equals):
        (tst_QScriptValue::strictlyEquals_data):
        (tst_QScriptValue::strictlyEquals):
        (tst_QScriptValue::instanceOf_data):
        (tst_QScriptValue::instanceOf):
        * tests/qscriptvalue/tst_qscriptvalue_generated_init.cpp:
        (tst_QScriptValue::initScriptValues):
        * tests/qscriptvalue/tst_qscriptvalue_generated_istype.cpp:
        (tst_QScriptValue::isValid_data):
        (tst_QScriptValue::isValid):
        (tst_QScriptValue::isBool_data):
        (tst_QScriptValue::isBool):
        (tst_QScriptValue::isBoolean_data):
        (tst_QScriptValue::isBoolean):
        (tst_QScriptValue::isNumber_data):
        (tst_QScriptValue::isNumber):
        (tst_QScriptValue::isFunction_data):
        (tst_QScriptValue::isFunction):
        (tst_QScriptValue::isNull_data):
        (tst_QScriptValue::isNull):
        (tst_QScriptValue::isString_data):
        (tst_QScriptValue::isString):
        (tst_QScriptValue::isUndefined_data):
        (tst_QScriptValue::isUndefined):
        (tst_QScriptValue::isObject_data):
        (tst_QScriptValue::isObject):
        (tst_QScriptValue::isArray_data):
        (tst_QScriptValue::isArray):
        (tst_QScriptValue::isError_data):
        (tst_QScriptValue::isError):
        * tests/qscriptvalue/tst_qscriptvalue_generated_totype.cpp:
        (tst_QScriptValue::toString_data):
        (tst_QScriptValue::toString):
        (tst_QScriptValue::toNumber_data):
        (tst_QScriptValue::toNumber):
        (tst_QScriptValue::toBool_data):
        (tst_QScriptValue::toBool):
        (tst_QScriptValue::toBoolean_data):
        (tst_QScriptValue::toBoolean):
        (tst_QScriptValue::toInteger_data):
        (tst_QScriptValue::toInteger):
        (tst_QScriptValue::toInt32_data):
        (tst_QScriptValue::toInt32):
        (tst_QScriptValue::toUInt32_data):
        (tst_QScriptValue::toUInt32):
        (tst_QScriptValue::toUInt16_data):
        (tst_QScriptValue::toUInt16):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Tue, 27 Jul 2010 22:07:46 +0000 (22:07 +0000)]
2010-07-27  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] putImageData(): Fast premultiply() if alpha == 255

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::premultiply): Do nothing for opaque pixels.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION: editing/style/remove-underline-from-stylesheet.html fails on Qt platform...
rniwa@webkit.org [Tue, 27 Jul 2010 21:52:11 +0000 (21:52 +0000)]
REGRESSION: editing/style/remove-underline-from-stylesheet.html fails on Qt platform after r64083
https://bugs.webkit.org/show_bug.cgi?id=43061

Reviewed by Justin Garcia.

Added a qt-specific test result because the final range and the generated DOM is same.

* platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoEnhance FileThreadTask to support return type.
jianli@chromium.org [Tue, 27 Jul 2010 21:42:31 +0000 (21:42 +0000)]
Enhance FileThreadTask to support return type.
https://bugs.webkit.org/show_bug.cgi?id=43078

Reviewed by David Levin.

This is needed to support synchronous calls of FileStream methods in
addition to asynchronous calls via FileThreadTask.

* html/FileThreadTask.h:
(WebCore::createFileThreadTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 27 Jul 2010 21:37:41 +0000 (21:37 +0000)]
2010-07-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Let PlatformContextSkia draw to a GLES2Canvas in addition to an SkCanvas
        https://bugs.webkit.org/show_bug.cgi?id=43070

        This adds a GLES2Canvas as drawing surface to PlatformContextSkia and lets callers
        issue draw commands to either.  The PlatformContextSkia keeps track of where
        rendering results are being accumulated and can blend the hardware and software
        backing stores into each other when necessary.

        Still just plumbing, no functionality change.

        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::GLES2Canvas::GLES2Canvas):
        * platform/graphics/chromium/GLES2Canvas.h:
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::PlatformContextSkia):
        (PlatformContextSkia::setGLES2Context):
        (PlatformContextSkia::preSoftwareDraw):
        (PlatformContextSkia::preHardwareDraw):
        (PlatformContextSkia::forceToSoftware):
        (PlatformContextSkia::uploadSoftwareToHardware):
        (PlatformContextSkia::readbackHardwareToSoftware):
        * platform/graphics/skia/PlatformContextSkia.h:
        (PlatformContextSkia::useGPU):
        (PlatformContextSkia::gpuCanvas):
        (PlatformContextSkia::preSoftwareDraw):
        (PlatformContextSkia::preHardwareDraw):
        (PlatformContextSkia::forceToSoftware):
        (PlatformContextSkia::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Brett Wilson <brettw@chromium.org>
brettw@chromium.org [Tue, 27 Jul 2010 21:30:36 +0000 (21:30 +0000)]
2010-07-27  Brett Wilson  <brettw@chromium.org>

        Reviewed by Darin Fisher.

        Add the ability to select fonts and do basic text drawing to the
        Chromium WebKit API.
        https://bugs.webkit.org/show_bug.cgi?id=42999

        * WebKit.gyp:
        * public/WebFloatPoint.h: Added.
        (WebKit::WebFloatPoint::WebFloatPoint):
        (WebKit::WebFloatPoint::operator=):
        (WebKit::WebFloatPoint::operator WebCore::FloatPoint):
        (WebKit::operator==):
        (WebKit::operator!=):
        * public/WebFloatRect.h: Added.
        (WebKit::WebFloatRect::isEmpty):
        (WebKit::WebFloatRect::WebFloatRect):
        (WebKit::WebFloatRect::operator=):
        (WebKit::WebFloatRect::operator WebCore::FloatRect):
        (WebKit::operator==):
        (WebKit::operator!=):
        * public/WebFont.h: Added.
        * public/WebFontDescription.h: Added.
        (WebKit::WebFontDescription::):
        (WebKit::WebFontDescription::WebFontDescription):
        * public/WebTextRun.h: Added.
        (WebKit::WebTextRun::WebTextRun):
        * src/AssertMatchingEnums.cpp:
        * src/WebFontDescription.cpp: Added.
        (WebKit::WebFontDescription::WebFontDescription):
        (WebKit::WebFontDescription::operator WebCore::FontDescription):
        * src/WebFontImpl.cpp: Added.
        (WebKit::WebFont::Create):
        (WebKit::WebFontImpl::WebFontImpl):
        (WebKit::WebFontImpl::fontDescription):
        (WebKit::WebFontImpl::ascent):
        (WebKit::WebFontImpl::descent):
        (WebKit::WebFontImpl::height):
        (WebKit::WebFontImpl::lineSpacing):
        (WebKit::WebFontImpl::xHeight):
        (WebKit::WebFontImpl::drawText):
        (WebKit::WebFontImpl::computeWidth):
        (WebKit::WebFontImpl::offsetForPosition):
        (WebKit::WebFontImpl::selectionRectForText):
        * src/WebFontImpl.h: Added.
        * src/WebTextRun.cpp: Added.
        (WebKit::WebTextRun::operator WebCore::TextRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Tue, 27 Jul 2010 21:23:20 +0000 (21:23 +0000)]
2010-07-27  Victor Wang  <victorw@chromium.org>

        Unreviewed. Update chromium test expectations for failed test on mac:
        fast/dom/prototype-inheritance.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 27 Jul 2010 21:18:02 +0000 (21:18 +0000)]
2010-07-27  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Incomplete repaint of some Safari extension content which falls into a composited iframe
        <rdar://problem/8235044>

        syncCompositingStateRecursive() bails if it thinks that a layout is pending, because
        the layout may update layers and make this sync obsolete. However, it only checked for an
        active layout timer. This ignores other sources of pending style changes and layouts, like
        the document's style recalc timer. So use needsLayout(), which does check this.

        Unable to create a test because it depends on Safari extension behavior.

        * page/FrameView.cpp:
        (WebCore::FrameView::syncCompositingStateRecursive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Tue, 27 Jul 2010 21:17:44 +0000 (21:17 +0000)]
2010-07-27  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] putImageData() optimizations
        https://bugs.webkit.org/show_bug.cgi?id=43059

        - Single-pass premultiplication and BGR->RGB conversion
        - Use ARGB32PM for the temporary image so Qt calls the
          fast Source composition function

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::premultiply): Added (static inline)
        (WebCore::putImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-23 Helder Correia <heldercorreia@codeaurora.org>
andreas.kling@nokia.com [Tue, 27 Jul 2010 21:11:35 +0000 (21:11 +0000)]
2010-07-23  Helder Correia  <heldercorreia@codeaurora.org>

        Reviewed by Darin Adler.

        Canvas tests 2d.imageData.object.round and 2d.imageData.object.wrap are
        failing. For canvas image data manipulation, the values passed should
        be truncated and wrapped. Also fix the canvas-ImageData-behaviour test
        to expect wrapping rather than clamping, and add some new checkings.
        https://bugs.webkit.org/show_bug.cgi?id=40272

        * runtime/JSByteArray.h:
        (JSC::JSByteArray::setIndex):
        (JSC::JSByteArray::JSByteArray):
2010-07-23  Helder Correia  <heldercorreia@codeaurora.org>

        Reviewed by Darin Adler.

        Canvas tests 2d.imageData.object.round and 2d.imageData.object.wrap are
        failing. For canvas image data manipulation, the values passed should
        be truncated and wrapped. Also fix the canvas-ImageData-behaviour test
        to expect wrapping rather than clamping, and add some new checkings.
        https://bugs.webkit.org/show_bug.cgi?id=40272

        * canvas/philip/tests/2d.imageData.object.round-expected.txt:
        * canvas/philip/tests/2d.imageData.object.round.html:
        * canvas/philip/tests/2d.imageData.object.wrap-expected.txt:
        * fast/canvas/canvas-ImageData-behaviour-expected.txt:
        * fast/canvas/canvas-ImageData-behaviour.js:
        * platform/mac/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix PageClient ownership in WebPageProxy
aroben@apple.com [Tue, 27 Jul 2010 21:06:35 +0000 (21:06 +0000)]
Fix PageClient ownership in WebPageProxy

WKView now owns the PageClient, similar to how things work on Windows
(where the WebView is the PageClient).

Fixes <http://webkit.org/b/40185> WebPageProxy should keep a weak
reference to the PageClient

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:pageNamespaceRef:]): Store the PageClientImpl
on our WKViewData object and pass it to the WebPageProxy.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setPageClient):
* UIProcess/WebPageProxy.h:
Removed Mac-specific code that put the PageClient in an OwnPtr. We now
store it in a bare pointer just like on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoExpose interface for returning the plug-in script JSObject
andersca@apple.com [Tue, 27 Jul 2010 20:55:29 +0000 (20:55 +0000)]
Expose interface for returning the plug-in script JSObject
https://bugs.webkit.org/show_bug.cgi?id=43074

Reviewed by Sam Weinig.

WebCore:

PluginViewBase::scriptObject should be a virtual function.

* plugins/PluginViewBase.h:
(WebCore::PluginViewBase::scriptObject):

WebKit2:

* WebProcess/Plugins/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):
Add empty stub.

* WebProcess/Plugins/NPRuntimeObjectMap.h:
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pluginScriptableNPObject):
Ask the plug-in for it's scriptable NPObject.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Plugin.h:
Add pluginScritableNPObject.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
Call PluginViewBase constructor.

(WebKit::PluginView::scriptObject):
Ask the plug-in for its scriptable object and wrap it.

* WebProcess/Plugins/PluginView.h:
PluginView now inherits from PluginViewBase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 27 Jul 2010 20:23:47 +0000 (20:23 +0000)]
2010-07-27  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
        https://bugs.webkit.org/show_bug.cgi?id=42984

        squash and no_squash have been intentionally erroring for a couple weeks now.
        But post-commits was just broken. Just remove squash/no_squash.

        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/options.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd ScriptExecutionContext argument to File/Blob constructors.
jianli@chromium.org [Tue, 27 Jul 2010 20:18:30 +0000 (20:18 +0000)]
Add ScriptExecutionContext argument to File/Blob constructors.
https://bugs.webkit.org/show_bug.cgi?id=40587

Reviewed by David Levin.

Remove DragData::createClipboard and add Clipboard::create for it to be
called directly in DragController. This is because we need to pass
Frame pointer to Clipboard class and use it to get ScriptExecutionContext
in order to construct File objects in Clipboard::files().

* bindings/js/SerializedScriptValue.cpp:
(WebCore::DeserializingTreeWalker::convertIfTerminal):
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::ZigZag::Reader::readBlob):
(WebCore::ZigZag::Reader::readFile):
(WebCore::ZigZag::Reader::readFileList):
* dom/Clipboard.h:
* editing/Editor.cpp:
(WebCore::Editor::dispatchCPPEvent):
* editing/Editor.h:
* editing/android/EditorAndroid.cpp:
(WebCore::Editor::newGeneralClipboard):
* editing/brew/EditorBrew.cpp:
(WebCore::Editor::newGeneralClipboard):
* editing/chromium/EditorChromium.cpp:
(WebCore::Editor::newGeneralClipboard):
* editing/haiku/EditorHaiku.cpp:
(WebCore::Editor::newGeneralClipboard):
* editing/mac/EditorMac.mm:
(WebCore::Editor::newGeneralClipboard):
* editing/qt/EditorQt.cpp:
(WebCore::Editor::newGeneralClipboard):
* editing/wx/EditorWx.cpp:
(WebCore::Editor::newGeneralClipboard):
* html/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::slice):
* html/Blob.h:
(WebCore::Blob::create):
* html/Blob.idl:
* html/BlobBuilder.cpp:
(WebCore::BlobBuilder::getBlob):
* html/BlobBuilder.h:
* html/BlobBuilder.idl:
* html/File.cpp:
(WebCore::File::File):
* html/File.h:
(WebCore::File::create):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::appendFormData):
(WebCore::HTMLInputElement::setFileListFromRenderer):
* page/DragController.cpp:
(WebCore::DragController::dragExited):
(WebCore::DragController::performDrag):
(WebCore::DragController::tryDHTMLDrag):
* page/chromium/EventHandlerChromium.cpp:
(WebCore::EventHandler::createDraggingClipboard):
* page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::createDraggingClipboard):
* page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::createDraggingClipboard):
* platform/DragData.h:
* platform/android/ClipboardAndroid.cpp:
(WebCore::Clipboard::create):
* platform/android/DragDataAndroid.cpp:
* platform/brew/ClipboardBrew.cpp:
(WebCore::Clipboard::create):
* platform/brew/DragDataBrew.cpp:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::Clipboard::create):
(WebCore::ClipboardChromium::ClipboardChromium):
(WebCore::ClipboardChromium::create):
(WebCore::ClipboardChromium::files):
* platform/chromium/ClipboardChromium.h:
* platform/chromium/DragDataChromium.cpp:
* platform/efl/ClipboardEfl.cpp:
(WebCore::Editor::newGeneralClipboard):
(WebCore::Clipboard::create):
* platform/efl/DragDataEfl.cpp:
* platform/gtk/ClipboardGtk.cpp:
(WebCore::Editor::newGeneralClipboard):
(WebCore::Clipboard::create):
(WebCore::ClipboardGtk::ClipboardGtk):
(WebCore::ClipboardGtk::files):
* platform/gtk/ClipboardGtk.h:
(WebCore::ClipboardGtk::create):
* platform/gtk/DragDataGtk.cpp:
* platform/haiku/ClipboardHaiku.cpp:
(WebCore::Clipboard::create):
* platform/haiku/DragDataHaiku.cpp:
* platform/mac/ClipboardMac.mm:
(WebCore::Clipboard::create):
(WebCore::ClipboardMac::files):
* platform/mac/DragDataMac.mm:
* platform/qt/ClipboardQt.cpp:
(WebCore::Clipboard::create):
* platform/qt/DragDataQt.cpp:
* platform/win/ClipboardWin.cpp:
(WebCore::Clipboard::create):
(WebCore::ClipboardWin::ClipboardWin):
(WebCore::ClipboardWin::files):
* platform/win/ClipboardWin.h:
(WebCore::ClipboardWin::create):
* platform/win/DragDataWin.cpp:
* platform/win/EditorWin.cpp:
(WebCore::Editor::newGeneralClipboard):
* platform/wince/DragDataWince.cpp:
* platform/wince/EditorWince.cpp:
(WebCore::Editor::newGeneralClipboard):
* platform/wx/ClipboardWx.cpp:
(WebCore::Clipboard::create):
* platform/wx/DragDataWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove all WebSQLDatabases-specific code behind #if ENABLE(DATABASE).
dumi@chromium.org [Tue, 27 Jul 2010 20:07:42 +0000 (20:07 +0000)]
Move all WebSQLDatabases-specific code behind #if ENABLE(DATABASE).
https://bugs.webkit.org/show_bug.cgi?id=43035

Reviewed by David Levin.

WebCore:

Make Chromium compile with ENABLE_DATABASE=0. The #ifdefs in
DatabaseAuthorizer and ChromiumBridge are removed, because they're
used by non-HTML5 DBs too (the classes in WebCore/platform/sql/),
which are used by other features too. So they need to be compiled
in even if HTML5 DBs are disabled.

* bindings/v8/custom/V8DOMWindowCustom.cpp:
* page/DOMWindow.idl:
* platform/chromium/ChromiumBridge.h:
* storage/DatabaseAuthorizer.cpp:
* storage/chromium/DatabaseObserver.h:
* storage/chromium/DatabaseTrackerChromium.cpp:
* storage/chromium/QuotaTracker.cpp:
* storage/chromium/QuotaTracker.h:
* storage/chromium/SQLTransactionClientChromium.cpp:

WebKit/chromium:

Make Chromium compile with ENABLE_DATABASE=0.

* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::databaseGetFileSize):
* src/DatabaseObserver.cpp:
* src/WebDatabase.cpp:
(WebCore::AbstractDatabase::stringIdentifier):
(WebCore::AbstractDatabase::displayName):
(WebCore::AbstractDatabase::estimatedSize):
(WebCore::AbstractDatabase::securityOrigin):
(WebKit::WebDatabase::updateDatabaseSize):
(WebKit::WebDatabase::closeDatabaseImmediately):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
kevino@webkit.org [Tue, 27 Jul 2010 19:48:00 +0000 (19:48 +0000)]
[wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX: Misspellings not shown in AXAttributedStringForTextMarkerRange when selection...
cfleizach@apple.com [Tue, 27 Jul 2010 19:38:49 +0000 (19:38 +0000)]
AX: Misspellings not shown in AXAttributedStringForTextMarkerRange when selection is on word
https://bugs.webkit.org/show_bug.cgi?id=41817

Reviewed by David Kilzer.

WebCore:

Change how misspelled words are identified for accessibility. No longer rely on the
cached markers in Document. Calculate on the fly, which is more accurate in a variety of
circumstances (like when selection has not moved across words, of if the cursor is in the middle
of a misspelled word).

Test: platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html

* accessibility/mac/AccessibilityObjectWrapper.mm:
(AXAttributeStringSetSpelling):
(AXAttributedStringAppendText):
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):

LayoutTests:

* platform/mac/accessibility/attributed-string-includes-misspelled-with-selection-expected.txt: Added.
* platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Tue, 27 Jul 2010 19:34:53 +0000 (19:34 +0000)]
2010-07-27  Victor Wang  <victorw@chromium.org>

        Unreviewed. Update chromium test expectations.

        * platform/chromium/test_expectations.txt:
        * storage/indexeddb/keyrange-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove NPJSObject out into separate files
andersca@apple.com [Tue, 27 Jul 2010 19:29:45 +0000 (19:29 +0000)]
Move NPJSObject out into separate files
https://bugs.webkit.org/show_bug.cgi?id=43068

Reviewed by Adam Roben.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Plugins/NPJSObject.cpp: Added.
(WebKit::NPJSObject::create):
(WebKit::NPJSObject::NPJSObject):
(WebKit::NPJSObject::~NPJSObject):
(WebKit::NPJSObject::isNPJSObject):
(WebKit::NPJSObject::initialize):
(WebKit::identifierFromIdentifierRep):
(WebKit::NPJSObject::hasProperty):
(WebKit::NPJSObject::getProperty):
(WebKit::NPJSObject::npClass):
(WebKit::NPJSObject::NP_Allocate):
(WebKit::NPJSObject::NP_Deallocate):
(WebKit::NPJSObject::NP_HasProperty):
(WebKit::NPJSObject::NP_GetProperty):
* WebProcess/Plugins/NPJSObject.h: Added.
(WebKit::NPJSObject::jsObject):
(WebKit::NPJSObject::toNPJSObject):
* WebProcess/Plugins/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::npJSObjectDestroyed):
(WebKit::NPRuntimeObjectMap::globalExec):
* WebProcess/Plugins/NPRuntimeObjectMap.h:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 42621 - Add a bump allocator for the YARR interpreter
barraclough@apple.com [Tue, 27 Jul 2010 19:14:40 +0000 (19:14 +0000)]
Bug 42621 - Add a bump allocator for the YARR interpreter

Reviewed by Oliver Hunt.

The regex engine requires lifo allocation, however currently uses the general purpose
malloc/free memory allocation.  A simple bump pointer allocator should provide a lower
overhead allocation solution.

JavaScriptCore:

When using YARR interpreter, 15% progression on v8-regex.

* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSGlobalData.h:
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
* wtf/BumpPointerAllocator.h: Added.
(WTF::BumpPointerPool::ensureCapacity):
(WTF::BumpPointerPool::alloc):
(WTF::BumpPointerPool::dealloc):
(WTF::BumpPointerPool::operator new):
(WTF::BumpPointerPool::BumpPointerPool):
(WTF::BumpPointerPool::create):
(WTF::BumpPointerPool::shrink):
(WTF::BumpPointerPool::destroy):
(WTF::BumpPointerPool::ensureCapacityCrossPool):
(WTF::BumpPointerPool::deallocCrossPool):
(WTF::BumpPointerAllocator::BumpPointerAllocator):
(WTF::BumpPointerAllocator::~BumpPointerAllocator):
(WTF::BumpPointerAllocator::startAllocator):
(WTF::BumpPointerAllocator::stopAllocator):
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::allocDisjunctionContext):
(JSC::Yarr::Interpreter::freeDisjunctionContext):
(JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::interpret):
(JSC::Yarr::Interpreter::Interpreter):
(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::byteCompileRegex):
* yarr/RegexInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):

JavaScriptGlue:

* ForwardingHeaders/wtf/BumpPointerAllocator.h: Added.

WebCore:

* ForwardingHeaders/wtf/BumpPointerAllocator.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRename NPJSObjectMap to NPRuntimeObjectMap
andersca@apple.com [Tue, 27 Jul 2010 19:04:50 +0000 (19:04 +0000)]
Rename NPJSObjectMap to NPRuntimeObjectMap
https://bugs.webkit.org/show_bug.cgi?id=43066

Reviewed by Adam Roben.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Plugins/NPJSObjectMap.cpp: Removed.
* WebProcess/Plugins/NPJSObjectMap.h: Removed.
* WebProcess/Plugins/NPRuntimeObjectMap.cpp: Added.
(WebKit::NPJSObject::NPJSObject):
(WebKit::NPJSObject::~NPJSObject):
(WebKit::NPJSObject::toNPJSObject):
(WebKit::NPJSObject::create):
(WebKit::NPJSObject::isNPJSObject):
(WebKit::NPJSObject::initialize):
(WebKit::identifierFromIdentifierRep):
(WebKit::NPJSObject::hasProperty):
(WebKit::NPJSObject::getProperty):
(WebKit::NPJSObject::npClass):
(WebKit::NPJSObject::NP_Allocate):
(WebKit::NPJSObject::NP_Deallocate):
(WebKit::NPJSObject::NP_HasProperty):
(WebKit::NPJSObject::NP_GetProperty):
(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::getOrCreateNPObject):
(WebKit::NPRuntimeObjectMap::invalidate):
* WebProcess/Plugins/NPRuntimeObjectMap.h: Added.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
(WebKit::PluginView::~PluginView):
(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):
* WebProcess/Plugins/PluginView.h:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 27 Jul 2010 18:32:43 +0000 (18:32 +0000)]
2010-07-27  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: render network timing as gant chart in popover.

        https://bugs.webkit.org/show_bug.cgi?id=43051

        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::buildObjectForTiming):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._showPopover):
        * inspector/front-end/inspector.css:
        (.resource-timing-row):
        (.resource-timing-bar):
        (.resource-timing-bar-title):
        * inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
ossy@webkit.org [Tue, 27 Jul 2010 18:16:26 +0000 (18:16 +0000)]
Unreviewed.

[Qt] Add inspector/debugger-breakpoints-not-activated-on-reload.html (introduced in r64133) to the Skipped list.

* platform/qt/Skipped: inspector/debugger-breakpoints-not-activated-on-reload.html skipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Tue, 27 Jul 2010 18:14:31 +0000 (18:14 +0000)]
2010-07-27  Victor Wang  <victorw@chromium.org>

        Unreviewed, rolling out r64104.
        http://trac.webkit.org/changeset/64104
        https://bugs.webkit.org/show_bug.cgi?id=40768

        The patch causes chromium webkit socket laytest crashes on
        windows randomly

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addResource):
        (WebCore::InspectorController::removeResource):
        * inspector/InspectorController.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::InspectorResource::updateScriptObject):
        (WebCore::InspectorResource::cachedResource):
        (WebCore::InspectorResource::type):
        (WebCore::InspectorResource::resourceData):
        * inspector/InspectorResource.h:
        (WebCore::InspectorResource::):
        (WebCore::InspectorResource::create):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.Type.toString):
        (WebInspector.Resource.prototype.set type):
        (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.prototype._refreshRequestHeaders):
        (WebInspector.ResourceView.prototype._refreshResponseHeaders):
        (WebInspector.ResourceView.prototype._refreshHeaders):
        * inspector/front-end/inspector.css:
        (.resources-category-scripts, .resources-category-xhr, .resources-category-fonts, .resources-category-other):
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):
        (WebInspector.updateResource):
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::WebSocketChannel):
        (WebCore::WebSocketChannel::disconnect):
        (WebCore::WebSocketChannel::didOpen):
        (WebCore::WebSocketChannel::didClose):
        (WebCore::WebSocketChannel::processBuffer):
        * websockets/WebSocketChannel.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Andrei Popescu <andreip@google.com>
andreip@google.com [Tue, 27 Jul 2010 18:04:20 +0000 (18:04 +0000)]
2010-07-27  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        [IndexedDB] Key range methods belong to the IDBKeyRange interface
        https://bugs.webkit.org/show_bug.cgi?id=43052

        * storage/indexeddb/script-tests/keyrange.js:
        (checkSingleKeyRange):
        (checkLeftBoundKeyRange):
        ():
2010-07-27  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        [IndexedDB] Key range methods belong to the IDBKeyRange interface
        https://bugs.webkit.org/show_bug.cgi?id=43052

        Move the key range methods from the IndexedDatabaseRequest interface
        to the IDBKeyRange interface. Also add a global IDBKeyRange object
        that can be used to access the IDBKeyRange constants and factory methods.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::clear):
        (WebCore::DOMWindow::iDBKeyRange):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * storage/IDBKeyRange.cpp:
        (WebCore::IDBKeyRange::only):
        (WebCore::IDBKeyRange::leftBound):
        (WebCore::IDBKeyRange::rightBound):
        (WebCore::IDBKeyRange::bound):
        * storage/IDBKeyRange.h:
        * storage/IDBKeyRange.idl:
        * storage/IndexedDatabaseRequest.cpp:
        * storage/IndexedDatabaseRequest.h:
        * storage/IndexedDatabaseRequest.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake preferences APIs robust against web process crashes
aroben@apple.com [Tue, 27 Jul 2010 17:17:09 +0000 (17:17 +0000)]
Make preferences APIs robust against web process crashes

Fixes <http://webkit.org/b/43049> Crash in
WebPageNamespace::preferencesDidChange if preferences are changed
after the web process crashes

Reviewed by Anders Carlsson.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::preferencesDidChange): Bail out if we don't have
a web process. The new preference values will get propogated to the
web process if and when it launches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX: consolidate parentObjectIfExists() and parentObject() code
cfleizach@apple.com [Tue, 27 Jul 2010 17:14:12 +0000 (17:14 +0000)]
AX: consolidate parentObjectIfExists() and parentObject() code
https://bugs.webkit.org/show_bug.cgi?id=42981

Reviewed by Darin Adler.

Consolidate duplicate code in parentObject and parentObjectIfExists

No tests. No functionality changed.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::renderParentObject):
(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
* accessibility/AccessibilityRenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 ryuan choi <ryuan.choi@samsung.com>
leandro@webkit.org [Tue, 27 Jul 2010 16:44:31 +0000 (16:44 +0000)]
2010-07-26  ryuan choi  <ryuan.choi@samsung.com>

        Unreviewed build fix.

        [EFL]REGRESSION(r63952): build break because of InspectorBackendDispatcher.cpp
        https://bugs.webkit.org/show_bug.cgi?id=43021

        Modify cmake script to fix build break as adding InspectorBackendDispatcher.

        * cmake/WebKitGenerators.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX: replace m_renderer->document->axObjectCache() with just axObjectCache()
cfleizach@apple.com [Tue, 27 Jul 2010 16:33:37 +0000 (16:33 +0000)]
AX: replace m_renderer->document->axObjectCache() with just axObjectCache()
https://bugs.webkit.org/show_bug.cgi?id=42979

Reviewed by Adam Barth.

No new tests. Code cleanup only.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::firstChild):
(WebCore::AccessibilityRenderObject::lastChild):
(WebCore::AccessibilityRenderObject::previousSibling):
(WebCore::AccessibilityRenderObject::nextSibling):
(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::menuForMenuButton):
(WebCore::AccessibilityRenderObject::menuButtonForMenu):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::axObjectCache):
(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore::AccessibilityRenderObject::addChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Tue, 27 Jul 2010 16:30:44 +0000 (16:30 +0000)]
2010-07-27  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Changing library names (appending suffix "_efl")
        https://bugs.webkit.org/show_bug.cgi?id=42902

        Instead of having libwebcore.so, we will have libwebcore_efl.so.
        Same for javascriptcore and wtf when compiled as shared, and for jsc.

        * cmake/OptionsEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 27 Jul 2010 16:19:51 +0000 (16:19 +0000)]
2010-07-27  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Remove some mistakenly skipped tests from the skipped list as well as
        a couple tests that no longer exist.

        * platform/gtk/Skipped: Fix some errors in the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMac build fix
aroben@apple.com [Tue, 27 Jul 2010 16:18:55 +0000 (16:18 +0000)]
Mac build fix

* MiniBrowser/mac/BrowserWindowController.m:
(processDidExit):
(-[BrowserWindowController awakeFromNib]):
Added processDidExit support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Pavel Podivilov <podivilov@chromium.org>
commit-queue@webkit.org [Tue, 27 Jul 2010 16:12:30 +0000 (16:12 +0000)]
2010-07-27  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: do not activate all breakpoints on page reload
        https://bugs.webkit.org/show_bug.cgi?id=41461

        * http/tests/inspector/debugger-test.js:
        (frontend_scriptsAreParsed):
        (frontend_waitUntilScriptsAreParsed.waitForAllScripts):
        (frontend_waitUntilScriptsAreParsed):
        (frontend_ensureSourceFrameLoaded):
        (frontend_showScriptSource):
        * inspector/debugger-breakpoints-not-activated-on-reload-expected.txt: Added.
        * inspector/debugger-breakpoints-not-activated-on-reload.html: Added.
        * platform/gtk/Skipped: skip the test on GTK due to JSC debugger issue
2010-07-27  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: do not activate all breakpoints on page reload
        https://bugs.webkit.org/show_bug.cgi?id=41461

        Test: inspector/debugger-breakpoints-not-activated-on-reload.html

        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView.prototype._addBreakpoint):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._breakpointAdded):
        (WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype._addBreakpoint):
2010-07-27  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: if breakpoints were deactivated, add new breakpoints as disabled.
        https://bugs.webkit.org/show_bug.cgi?id=41461

        * src/js/DebuggerScript.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a ProcessDidExit callback to the WKPageLoaderClient
aroben@apple.com [Tue, 27 Jul 2010 16:06:48 +0000 (16:06 +0000)]
Add a ProcessDidExit callback to the WKPageLoaderClient

Fixes <http://webkit.org/b/43048> UI process needs a way to find out
when the web process crashes

Reviewed by Anders Carlsson.

* UIProcess/API/C/WKPage.h: Added WKPageProcessDidExitCallback, and a
processDidExit member of that type to WKPageLoaderClient.

* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::processDidExit): Added. Calls through to the
WKPageLoaderClient.

* UIProcess/WebLoaderClient.h: Added processDidExit.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidExit): Tell the loader client the
process exited.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Tue, 27 Jul 2010 15:54:19 +0000 (15:54 +0000)]
2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>

        Rubber-stamped by Simon Hausmann.

        [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.

        Move some less useful menu items on Developers menu from the top to the bottom, so
        QGraphicsView menu goes to the top, and becomes more quickly accessible.

        * QtTestBrowser/main.cpp:
        (LauncherWindow::createChrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
commit-queue@webkit.org [Tue, 27 Jul 2010 15:37:25 +0000 (15:37 +0000)]
2010-07-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement QScriptEngine::newFunction() parts that doesn't depend on QScriptContext
        https://bugs.webkit.org/show_bug.cgi?id=42174

        Since our function can be called in Javascript both as a function
        and as a constructor, we couldn't use the existing
        JSObjectMakeFunctionWithCallback() and JSObjectMakeConstructor().

        Instead, a JSClassRef was created, implementing the needed
        callbacks (the callAsConstructor is not there yet because its
        behaviour depends on QScriptContext).

        For the moment, QScriptContext is defined as a void type, since we
        still don't use it.

        The variant of newFunction() that also takes an external argument
        was also implemented. The details of implementation were added to
        the qscriptfunction{.c,_p.h} files.

        This commit also adds tests, some of them from Qt's upstream.

        * api/QtScript.pro:
        * api/qscriptengine.cpp:
        (QScriptEngine::newFunction):
        * api/qscriptengine.h:
        * api/qscriptengine_p.cpp:
        (QScriptEnginePrivate::QScriptEnginePrivate):
        (QScriptEnginePrivate::~QScriptEnginePrivate):
        (QScriptEnginePrivate::newFunction):
        * api/qscriptengine_p.h:
        * api/qscriptfunction.cpp: Added.
        (qt_NativeFunction_finalize):
        (qt_NativeFunction_callAsFunction):
        (qt_NativeFunctionWithArg_finalize):
        (qt_NativeFunctionWithArg_callAsFunction):
        * api/qscriptfunction_p.h: Added.
        (QNativeFunctionData::QNativeFunctionData):
        (QNativeFunctionWithArgData::QNativeFunctionWithArgData):
        * api/qscriptoriginalglobalobject_p.h:
        (QScriptOriginalGlobalObject::QScriptOriginalGlobalObject):
        (QScriptOriginalGlobalObject::~QScriptOriginalGlobalObject):
        (QScriptOriginalGlobalObject::functionPrototype):
        * tests/qscriptengine/tst_qscriptengine.cpp:
        (myFunction):
        (myFunctionWithArg):
        (myFunctionThatReturns):
        (myFunctionThatReturnsWithoutEngine):
        (myFunctionThatReturnsWrongEngine):
        (tst_QScriptEngine::newFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the path to InjectedBundle.dll in Debug_Internal builds
aroben@apple.com [Tue, 27 Jul 2010 15:25:05 +0000 (15:25 +0000)]
Fix the path to InjectedBundle.dll in Debug_Internal builds

Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
InjectedBundle.dll in the Debug_Internal configuration

Reviewed by Anders Carlsson.

* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeInjectedBundlePath): Add the _debug
suffix only in Debug_All builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Pranav Kedia <pranavk@chromium.org>
commit-queue@webkit.org [Tue, 27 Jul 2010 15:06:15 +0000 (15:06 +0000)]
2010-07-27  Pranav Kedia  <pranavk@chromium.org>

        Reviewed by Adam Barth.

        Chrome browser Bug: Pause button stays when <audio> hits end
        https://bugs.webkit.org/show_bug.cgi?id=42677

        The change is just in chromium media. Tested using media part of
        WebKit layout tests. The following test that was failing is passing.
        media/video-duration-known-after-eos.html -> unexpected pass

        * rendering/RenderMediaControlsChromium.cpp:
        (WebCore::paintMediaPlayButton):
        Using mediaElement->canPlay() instead of mediaElement->paused() to
        paint the play/pause button.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Tue, 27 Jul 2010 15:01:31 +0000 (15:01 +0000)]
2010-07-27  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] WebEventFactory::createWebMouseEvent should follow WebKit2 API changes
        https://bugs.webkit.org/show_bug.cgi?id=43042

        * Shared/qt/WebEventFactoryQt.cpp:
        (WebKit::WebEventFactory::createWebMouseEvent):
        Set deltaX, deltaY and deltaZ arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 27 Jul 2010 14:12:25 +0000 (14:12 +0000)]
2010-07-27  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Client-based Geolocation does not pass enableHighAccuracy option to controller and client
        https://bugs.webkit.org/show_bug.cgi?id=40374

        This change passes the enableHighAccuracy request option to the GeolocationController.
        The GeolocationController tracks whether this should be used by the client.

        No new tests possible as the mock provider doesn't support this feature.

        * page/Geolocation.cpp:
        (WebCore::Geolocation::setIsAllowed):
        (WebCore::Geolocation::startUpdating):
        * page/GeolocationController.cpp:
        (WebCore::GeolocationController::addObserver):
        (WebCore::GeolocationController::removeObserver):
        * page/GeolocationController.h:
        * page/GeolocationControllerClient.h:
2010-07-27  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Client-based Geolocation does not pass enableHighAccuracy option to controller and client
        https://bugs.webkit.org/show_bug.cgi?id=40374

        Stub out setEnableHighAccuracy method for the Mac port.

        * WebCoreSupport/WebGeolocationControllerClient.h:
        (WebGeolocationControllerClient::setEnableHighAccuracy):
2010-07-27  Steve Block  <steveblock@google.com>

        Reviewed by Alexey Proskuryakov.

        Client-based Geolocation does not pass enableHighAccuracy option to controller and client
        https://bugs.webkit.org/show_bug.cgi?id=40374

        Stub out setEnableHighAccuracy method for the Win port.

        * WebCoreSupport/WebGeolocationControllerClient.h:
        (WebGeolocationControllerClient::setEnableHighAccuracy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 27 Jul 2010 13:55:51 +0000 (13:55 +0000)]
2010-07-27  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        LayoutTests/fast/dom/DeviceOrientation/window-property.html assumes use of V8
        https://bugs.webkit.org/show_bug.cgi?id=43025

        This change modifies window-property.html and its expected result to work with JSC.
        A V8-specific expected result is added for Android.

        * fast/dom/DeviceOrientation/script-tests/window-property.js:
        * fast/dom/DeviceOrientation/window-property-expected.txt:
        * platform/android-v8: Added.
        * platform/android-v8/fast: Added.
        * platform/android-v8/fast/dom: Added.
        * platform/android-v8/fast/dom/DeviceOrientation: Added.
        * platform/android-v8/fast/dom/DeviceOrientation/window-property-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 27 Jul 2010 13:41:20 +0000 (13:41 +0000)]
2010-07-27  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Current implementation of message based inspector
        transport generated by CodeGeneratorInspector should be upstreamed
        from WebKit/chromium to WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=42983

        * Android.derived.v8bindings.mk:
        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/ScriptObject.cpp:
        * bindings/js/ScriptObject.h:
        * bindings/v8/ScriptObject.cpp:
        * bindings/v8/ScriptObject.h:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InspectorBackend.idl: Removed.
        * inspector/InspectorFrontendClient.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
        (WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
        * inspector/InspectorFrontendClientLocal.h:
        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::sendMessageToBackend):
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub):
        (.WebInspector.InspectorBackendStub.prototype._registerDelegate):
        (.WebInspector.InspectorBackendStub.prototype.sendMessageToBackend):

2010-07-27  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Current implementation of message based inspector
        transport generated by CodeGeneratorInspector should be upstreamed
        from WebKit/chromium to WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=42983

        * WebKit.gypi:
        * src/InspectorFrontendClientImpl.cpp:
        (WebKit::InspectorFrontendClientImpl::sendMessageToBackend):
        * src/InspectorFrontendClientImpl.h:
        * src/ToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController):
        (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost):
        * src/WebDevToolsAgentImpl.h:
        * src/js/InspectorControllerImpl.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-25 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
andreas.kling@nokia.com [Tue, 27 Jul 2010 13:01:04 +0000 (13:01 +0000)]
2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=42947
        Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw
        error. Without which dumpRenderTree crashes.

        * Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Balazs Kelemen <kb@inf.u-szeged.hu>
commit-queue@webkit.org [Tue, 27 Jul 2010 12:27:29 +0000 (12:27 +0000)]
2010-07-27  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] WebKit::PageClient implementation needs a dedicated class

        https://bugs.webkit.org/show_bug.cgi?id=42974

        * UIProcess/API/qt/qwkpage.cpp:
        (PageClientImpl::PageClientImpl): Added.
        (PageClientImpl::pageDidEnterAcceleratedCompositing): Moved from QWKPagePrivate.
        (PageClientImpl::pageDidLeaveAcceleratedCompositing): Ditto.
        (PageClientImpl::processDidExit): Ditto.
        (PageClientImpl::processDidRevive): Ditto.
        (PageClientImpl::setCursor): Ditto.
        (PageClientImpl::takeFocus): Ditto.
        (PageClientImpl::toolTipChanged): Ditto.
        (QWKPagePrivate::QWKPagePrivate): Set a new instance of the PageClientImpl as PageClient rather than 'this'.
        * UIProcess/API/qt/qwkpage_p.h: Removed PageClient implementation methods from QWKPagePrivate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Tue, 27 Jul 2010 12:08:36 +0000 (12:08 +0000)]
2010-07-27  Anton Muhin  <antonm@chromium.org>

        Reviewed by Darin Adler.

        Extend a test checking access to nested elements on the document to cover recent regression in Chromium
        https://bugs.webkit.org/show_bug.cgi?id=42980

        See http://code.google.com/p/chromium/issues/detail?id=48804 for more details.

        * fast/dom/HTMLDocument/document-special-properties-expected.txt:
        * fast/dom/HTMLDocument/document-special-properties.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Incorrect input method hints
hausmann@webkit.org [Tue, 27 Jul 2010 10:55:56 +0000 (10:55 +0000)]
[Qt] Incorrect input method hints
https://bugs.webkit.org/show_bug.cgi?id=43037

Reviewed by Tor Arne Vestbø.

Properly set or reset all input method hints when
activating input fields.

* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::focusInputTypes): Extended unit test to verify that we
reset hints.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix failing layout-tests after r64114
vestbo@webkit.org [Tue, 27 Jul 2010 10:05:22 +0000 (10:05 +0000)]
[Qt] Fix failing layout-tests after r64114

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Kim Grönholm <kim.1.gronholm@nokia.com>
kim.1.gronholm@nokia.com [Tue, 27 Jul 2010 09:51:48 +0000 (09:51 +0000)]
2010-07-27  Kim Grönholm  <kim.1.gronholm@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Decouple QTouchEvent's accepted flag from JS prevent default
        https://bugs.webkit.org/show_bug.cgi?id=42892

        We need to always accept the QTouchEvents in order to get TouchUpdate and
        TouchEnd events. QWebPage::event() return value is used to indicate
        whether the default action was prevented for the touch events.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebView::sceneEvent):
        * Api/qwebpage.cpp:
        (QWebPagePrivate::touchEvent):
        (QWebPage::event):
        * Api/qwebpage_p.h:
        * Api/qwebview.cpp:
        (QWebView::event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed. Trivial test fix.
tkent@chromium.org [Tue, 27 Jul 2010 09:36:05 +0000 (09:36 +0000)]
Unreviewed. Trivial test fix.

* fast/forms/script-tests/input-number-events.js:
 Adjust pixel values in order to work on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate expected result as well to match r64115.
vestbo@webkit.org [Tue, 27 Jul 2010 09:29:03 +0000 (09:29 +0000)]
Update expected result as well to match r64115.

Reviewed by NOBODY.

* fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix GTK layout-test break after r64114
vestbo@webkit.org [Tue, 27 Jul 2010 09:12:40 +0000 (09:12 +0000)]
Fix GTK layout-test break after r64114

Reviewed by NOBODY.

Skipping the test for Qt until we can find a non-fragile way to write
the test.

* fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Change default font from sans-serif to serif
vestbo@webkit.org [Tue, 27 Jul 2010 08:38:23 +0000 (08:38 +0000)]
[Qt] Change default font from sans-serif to serif

Reviewed by Simon Hausmann.

This matches what other ports and browser engines do.

We now also use QFont's defaultFontFamily() to resolve the
correct fonts for each platform. For Qt >= 4.7 we can take
advantage of the new enums for generic font families.

The spatial-navigation test had to be changed due to the
fragile nature of the down-action. By changing the font we
hit the case where the two down actions were not enough to
scroll the link into view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Dominic Mazzoni <dmazzoni@google.com>
commit-queue@webkit.org [Tue, 27 Jul 2010 08:33:42 +0000 (08:33 +0000)]
2010-07-27  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Chris Fleizach.

        Add accessors for node and document to WebAccessibilityObject,
        needed to support some Windows screenreader functionality.

        https://bugs.webkit.org/show_bug.cgi?id=43001

        * public/WebAccessibilityObject.h:
        * src/WebAccessibilityObject.cpp:
        (WebKit::WebAccessibilityObject::node):
        (WebKit::WebAccessibilityObject::document):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Dominic Mazzoni <dmazzoni@google.com>
commit-queue@webkit.org [Tue, 27 Jul 2010 08:07:50 +0000 (08:07 +0000)]
2010-07-27  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Chris Fleizach.

        For Windows accessibility, have WebElement provide access
        to its attributes.

        https://bugs.webkit.org/show_bug.cgi?id=43004

        * WebKit.gyp:
        * public/WebAttribute.h: Added.
        (WebKit::WebAttribute::~WebAttribute):
        (WebKit::WebAttribute::WebAttribute):
        (WebKit::WebAttribute::operator=):
        * public/WebElement.h:
        * public/WebNamedNodeMap.h: Added.
        (WebKit::WebNamedNodeMap::~WebNamedNodeMap):
        (WebKit::WebNamedNodeMap::WebNamedNodeMap):
        (WebKit::WebNamedNodeMap::operator=):
        * src/WebAttribute.cpp: Added.
        (WebKit::WebAttribute::reset):
        (WebKit::WebAttribute::assign):
        (WebKit::WebAttribute::WebAttribute):
        (WebKit::WebAttribute::localName):
        (WebKit::WebAttribute::value):
        * src/WebElement.cpp:
        (WebKit::WebElement::attributes):
        * src/WebNamedNodeMap.cpp: Added.
        (WebKit::WebNamedNodeMap::reset):
        (WebKit::WebNamedNodeMap::assign):
        (WebKit::WebNamedNodeMap::WebNamedNodeMap):
        (WebKit::WebNamedNodeMap::length):
        (WebKit::WebNamedNodeMap::attributeItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Satish Sampath <satish@chromium.org>
commit-queue@webkit.org [Tue, 27 Jul 2010 07:50:57 +0000 (07:50 +0000)]
2010-07-27  Satish Sampath  <satish@chromium.org>

        Reviewed by Kent Tamura.

        Simplify speech input plumbing in webcore and webkit
        https://bugs.webkit.org/show_bug.cgi?id=43008

        No new tests as functionality is not changed.

        * GNUmakefile.am: Removed a header file.
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/Page.cpp:
        (WebCore::Page::speechInput): Creates and returns SpeechInput when needed.
        * page/Page.h:
        * page/SpeechInput.cpp: Added methods to proxy and callbacks between input elements and WebKit
        (WebCore::SpeechInput::SpeechInput):
        (WebCore::SpeechInput::didCompleteRecording):
        (WebCore::SpeechInput::didCompleteRecognition):
        (WebCore::SpeechInput::setRecognitionResult):
        (WebCore::SpeechInput::startRecognition):
        (WebCore::SpeechInput::stopRecording):
        * page/SpeechInput.h:
        * page/SpeechInputClient.h:
        * page/SpeechInputClientListener.h: Removed.
        * page/SpeechInputListener.h:
        * rendering/TextControlInnerElements.cpp: Added one more callback.
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
        (WebCore::InputFieldSpeechButtonElement::speechInput):
        (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition):
        * rendering/TextControlInnerElements.h:
2010-07-27  Satish Sampath  <satish@chromium.org>

        Reviewed by Kent Tamura.

        Simplify speech input plumbing in webcore and webkit
        https://bugs.webkit.org/show_bug.cgi?id=43008

        * src/SpeechInputClientImpl.cpp: Move functionality to WebCore::SpeechInput and make this a dummy proxy.
        (WebKit::SpeechInputClientImpl::startRecognition):
        (WebKit::SpeechInputClientImpl::cancelRecognition):
        (WebKit::SpeechInputClientImpl::didCompleteRecording):
        (WebKit::SpeechInputClientImpl::didCompleteRecognition):
        (WebKit::SpeechInputClientImpl::setRecognitionResult):
        * src/SpeechInputClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a runtime setting for interactive form validation.
tkent@chromium.org [Tue, 27 Jul 2010 07:31:39 +0000 (07:31 +0000)]
Add a runtime setting for interactive form validation.
https://bugs.webkit.org/show_bug.cgi?id=40520

Reviewed by Ojan Vafai.

WebCore:

The interactive validation feature was disabled for non-strict
modes by r61059 to avoid a compatibility issue. This removes the
mode checking and introduce a runtime setting to enable/disable
the feature instead.
The default value is 'disable' and we'll remove the setting when
the compatibility issue is resolved and interactive validation
implementation is completed.

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setInteractiveFormValidationEnabled):
(WebCore::Settings::interactiveFormValidationEnabled):

LayoutTests:

Remove the mode-specific tests and skip tests which don't work
without the interactive validation feature.

* fast/forms/interactive-validation-compat-mode-expected.txt: Removed.
* fast/forms/interactive-validation-compat-mode.html: Removed.
* fast/forms/interactive-validation-html4-expected.txt: Removed.
* fast/forms/interactive-validation-html4.html: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 27 Jul 2010 07:05:28 +0000 (07:05 +0000)]
2010-07-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=42956
        [DRT/Chromium] Fix "out of sync" assertion error

        Fix an assertion error on Windows like the following:
        100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
        |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
        |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        If the url matches with "file:///[a-z]:", does case-ignore comparison.
        GURL capitalize the driver letter of a file: URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix from Chromium/GTK build fix!
barraclough@apple.com [Tue, 27 Jul 2010 06:04:19 +0000 (06:04 +0000)]
Windows build fix from Chromium/GTK build fix!

* wtf/PageAllocation.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChromium/GTK build fix
barraclough@apple.com [Tue, 27 Jul 2010 05:51:10 +0000 (05:51 +0000)]
Chromium/GTK build fix

* wtf/PageAllocation.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for !Mac platforms.
barraclough@apple.com [Tue, 27 Jul 2010 05:23:28 +0000 (05:23 +0000)]
Build fix for !Mac platforms.

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 43009 - Abstract out page allocation from executable allocators
barraclough@apple.com [Tue, 27 Jul 2010 05:02:09 +0000 (05:02 +0000)]
Bug 43009 - Abstract out page allocation from executable allocators

Reviewed by Oliver Hunt.

JavaScriptCore:

It would be great to have a single platform abstraction for block allocation, rather than copy/paste code.

In this initial implementation I've made Symbian fall back to use malloc/free for non-executable memory.
I think this will match current behaviour for the next client we will want to port across (RegisterFile &
Collector).

* CMakeListsEfl.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
* jit/ExecutableAllocatorPosix.cpp: Removed.
* jit/ExecutableAllocatorSymbian.cpp: Removed.
* jit/ExecutableAllocatorWin.cpp: Removed.
* wscript:
* wtf/PageAllocator.cpp: Added.
(WTF::protection):
(WTF::PageAllocation::commit):
(WTF::PageAllocation::decommit):
(WTF::PageAllocator::allocate):
(WTF::PageAllocator::reserve):
(WTF::PageAllocator::deallocate):
(WTF::PageAllocator::pagesize):
* wtf/PageAllocator.h: Added.
(WTF::PageAllocation::PageAllocation):
(WTF::PageAllocation::base):
(WTF::PageAllocation::size):
(WTF::PageAllocation::chunk):
(WTF::PageAllocation::operator!):
(WTF::PageAllocator::):

JavaScriptGlue:

* ForwardingHeaders/wtf/PageAllocation.h: Added.

WebCore:

* ForwardingHeaders/wtf/PageAllocation.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Yuta Kitamura <yutak@chromium.org>
commit-queue@webkit.org [Tue, 27 Jul 2010 04:51:38 +0000 (04:51 +0000)]
2010-07-26  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Pavel Feldman.

        Add WebSocket resource type to Web Inspector.

        When a new WebSocket connection is established, a line for that connection
        will appear in Web Inspector's Resources tab. If the resource name is
        clicked, the details of handshake request and response will be shown.

        Web Inspector: WebSocket in Resources tab
        https://bugs.webkit.org/show_bug.cgi?id=40768

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addResource): WebSocket resource does not
        have an associated loader, thus frame might be null. Need to check it.
        (WebCore::InspectorController::removeResource): Ditto.
        (WebCore::InspectorController::didCreateWebSocket):
        (WebCore::InspectorController::willSendWebSocketHandshakeRequest):
        (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse):
        (WebCore::InspectorController::didCloseWebSocket):
        * inspector/InspectorController.h:
        * inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame,
        because WebSocket does not have a loader and we need to allow null for
        these variables.
        (WebCore::createReadableStringFromBinary):
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::InspectorResource::create): Factory function of
        regular (non-WebSocket) resources.
        (WebCore::InspectorResource::createWebSocket): Factory function of
        WebSocket resources.
        (WebCore::InspectorResource::updateWebSocketRequest):
        (WebCore::InspectorResource::updateWebSocketResponse):
        (WebCore::InspectorResource::updateScriptObject): m_frame->document() becomes
        available when Frame::setDocument() is called. We cannot obtain documentURL
        during the constructor or updateRequest() function, because m_frame->document()
        is not available yet at that point and documentURL will contain a wrong URL.
        As far as I know, updateScriptObject() is the only place where we can safely
        obtain documentURL.
        (WebCore::InspectorResource::cachedResource):
        (WebCore::InspectorResource::type):
        (WebCore::InspectorResource::resourceData):
        * inspector/InspectorResource.h:
        (WebCore::InspectorResource::):
        (WebCore::InspectorResource::markWebSocket):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.Type.toString):
        (WebInspector.Resource.prototype.set type):
        (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.prototype._refreshRequestHeaders):
        (WebInspector.ResourceView.prototype._refreshResponseHeaders):
        (WebInspector.ResourceView.prototype._refreshHeaders):
        * inspector/front-end/inspector.css:
        (.resources-category-websockets, .resources-category-other):
        (.resources-category-websockets .resources-graph-bar):
        (.resources-category-websockets.resource-cached .resources-graph-bar):
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):
        (WebInspector.updateResource):
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::WebSocketChannel):
        (WebCore::WebSocketChannel::disconnect):
        (WebCore::WebSocketChannel::didOpen):
        (WebCore::WebSocketChannel::didClose):
        (WebCore::WebSocketChannel::processBuffer):
        (WebCore::WebSocketChannel::identifier):
        * websockets/WebSocketChannel.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Cosmin Truta <ctruta@chromium.org>
commit-queue@webkit.org [Tue, 27 Jul 2010 04:34:13 +0000 (04:34 +0000)]
2010-07-26  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Eric Seidel.

        Some SVGs with empty <g> elements crash Chromium on Linux
        https://bugs.webkit.org/show_bug.cgi?id=41175

        Remove the suppression of this bug's test on Chromium. The new fix in WebKit no longer requires
        an update in Chromium, making this test safe to expose.

        * platform/chromium/test_expectations.txt:
2010-07-26  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Eric Seidel.

        Some SVGs with empty <g> elements crash Chromium on Linux
        https://bugs.webkit.org/show_bug.cgi?id=41175

        Redo the old fix using a different approach, to avoid regressing
        svg/batik/filters/filterRegions.svg with Chromium on Linux.
        Specifically, handle empty SkBitmap objects by exiting early upon
        encountering unconfigured (i.e. empty) bitmaps.

        No new tests. This bug's old test (svg/filters/filter-empty-g.svg)
        and the above-mentioned regressed test are expected to pass.

        * WebCore/platform/graphics/skia/ImageBufferSkia.cpp:
        (ImageBuffer::ImageBuffer): Undo the old fix.
        (getImageData): The new fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 27 Jul 2010 03:43:10 +0000 (03:43 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Fix a couple of test results after r64095.

        * compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
        * compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRolling out r64097:64100, oops, more b0rked than I relized by my last changes, sorry!
barraclough@apple.com [Tue, 27 Jul 2010 02:53:06 +0000 (02:53 +0000)]
Rolling out r64097:64100, oops, more b0rked than I relized by my last changes, sorry!

* CMakeListsEfl.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::reprotectRegion):
(JSC::ExecutableAllocator::cacheFlush):
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
* jit/ExecutableAllocatorPosix.cpp: Added.
(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):
* jit/ExecutableAllocatorSymbian.cpp: Added.
(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):
* jit/ExecutableAllocatorWin.cpp: Added.
(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):
* wscript:
* wtf/PageAllocation.cpp: Removed.
* wtf/PageAllocation.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpeculative !debug build fix II.
barraclough@apple.com [Tue, 27 Jul 2010 02:39:12 +0000 (02:39 +0000)]
Speculative !debug build fix II.

* wtf/PageAllocation.h:
(WTF::PageAllocation::PageAllocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpeculative !debug build fix.
barraclough@apple.com [Tue, 27 Jul 2010 02:37:53 +0000 (02:37 +0000)]
Speculative !debug build fix.

* wtf/PageAllocation.h:
(WTF::PageAllocation::PageAllocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 43009 - Abstract out page allocation from executable allocators
barraclough@apple.com [Tue, 27 Jul 2010 02:12:40 +0000 (02:12 +0000)]
Bug 43009 - Abstract out page allocation from executable allocators

Reviewed by Oliver Hunt.

It would be great to have a single platform abstraction for block allocation, rather than copy/paste code.

In this initial implementation I've made Symbian fall back to use malloc/free for non-executable memory.
I think this will match current behaviour for the next client we will want to port across (RegisterFile &
Collector).

* CMakeListsEfl.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
* jit/ExecutableAllocatorPosix.cpp: Removed.
* jit/ExecutableAllocatorSymbian.cpp: Removed.
* jit/ExecutableAllocatorWin.cpp: Removed.
* wscript:
* wtf/PageAllocator.cpp: Added.
(WTF::protection):
(WTF::PageAllocation::commit):
(WTF::PageAllocation::decommit):
(WTF::PageAllocator::allocate):
(WTF::PageAllocator::reserve):
(WTF::PageAllocator::deallocate):
(WTF::PageAllocator::pagesize):
* wtf/PageAllocator.h: Added.
(WTF::PageAllocation::PageAllocation):
(WTF::PageAllocation::base):
(WTF::PageAllocation::size):
(WTF::PageAllocation::chunk):
(WTF::PageAllocation::operator!):
(WTF::PageAllocator::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Tue, 27 Jul 2010 02:10:17 +0000 (02:10 +0000)]
2010-07-26  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Move CMakeListsEfl.txt to WebKit/efl/
        https://bugs.webkit.org/show_bug.cgi?id=43002

        This should reduce the noise in WebKit/ChangeLog that comes from EFL
        port. Most of the changes on EFL port should be logged in
        WebKit/efl/ChangeLog.

        * CMakeLists.txt: Just change the path from where to include the file.
2010-07-26  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Move CMakeListsEfl.txt to WebKit/efl/
        https://bugs.webkit.org/show_bug.cgi?id=43002

        This should reduce the noise in WebKit/ChangeLog that comes from EFL
        port. Most of the changes on EFL port should be logged in
        WebKit/efl/ChangeLog.

        * CMakeListsEfl.txt: Renamed from WebKit/CMakeListsEfl.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKitTestRunner needs to support layoutTestController.counterValueForElementById
darin@apple.com [Tue, 27 Jul 2010 01:17:48 +0000 (01:17 +0000)]
WebKitTestRunner needs to support layoutTestController.counterValueForElementById
https://bugs.webkit.org/show_bug.cgi?id=42537

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.markerTextForListItem
https://bugs.webkit.org/show_bug.cgi?id=42549

WebKit2:

* UIProcess/API/C/WKString.cpp:
(WKStringIsEmpty): Added.
* UIProcess/API/C/WKString.h: Added WKStringIsEmpty.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(copiedString): Added. Helper for functions that return a
WKStringRef that follows the copy rule.
(WKBundleFrameCopyName): Use copiedString.
(WKBundleFrameCopyCounterValue): Added. Calls counterValue.
(WKBundleFrameCopyMarkerText): Added. Calls markerText.
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
Added WKBundleFrameCopyCounterValue and WKBundleFrameCopyMarkerText.

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::computedStyleIncludingVisitedInfo):
Renamed argument to streamline function a bit.
(WebKit::WebFrame::counterValue): Added.
(WebKit::WebFrame::markerText): Added.
* WebProcess/WebPage/WebFrame.h: Added counterValue and markerText.

WebKitTools:

* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
Fixed _paramterExpression typo. Improved support for string type as a
return value, so we don't try to include DOMString.h and we can convert
the string to a JSValue by calling JSValueMakeStringOrNull.

* WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
Added JSValueMakeStringOrNull, used by the code generator.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Added counterValueForElementById and markerTextForListItem.

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
Moved constant to the top of the file.
(WTR::toCF): Added. Converts strings to CFStringRef.
(WTR::toWK): Added. Converts strings to WKStringRef.
(WTR::toJS): Added. Converts strings to JSStringRef.
(WTR::setProperty): Moved this function to the top of the file
rather than having it down where it's used inside the class. Also
renamed it so it's a separate function rather than an overload of
JSObjectSetProperty.
(WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
Should move it somewhere we can share it.
(WTR::propertyObject): Ditto.
(WTR::getElementById): Added. Calls getElementById through the magic
of JavaScript.
(WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
Chagned to use toWK instead of four local variables.
(WTR::LayoutTestController::counterValueForElementById): Added.
Calls WKBundleFrameCopyCounterValue.
(WTR::LayoutTestController::markerTextForListItem): Added.
Calls WKBundleFrameCopyMarkerText.

* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
Added counterValueForElementById and markerTextForListItem.

LayoutTests:

* platform/mac-wk2/Skipped: Removed tests that were failing due to one of the above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 27 Jul 2010 00:21:41 +0000 (00:21 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Google image search results broken on pages with Flash
        https://bugs.webkit.org/show_bug.cgi?id=43014

        The test for overflow added in r63452 is wrong in that it ignores the effects
        of positioning on overflow.

        The correct approach is to start by using RenderView's layoutOverflowRect as the largest bounds,
        then getting the oveflow rect via backgroundClipRect() relative to the root layer.

        Test: compositing/geometry/limit-layer-bounds-overflow-root.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::layerOrAncestorIsTransformed):
        (WebCore::RenderLayerBacking::updateCompositedBounds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPlug-in views should be able to return JSObjects directly
andersca@apple.com [Tue, 27 Jul 2010 00:09:07 +0000 (00:09 +0000)]
Plug-in views should be able to return JSObjects directly
https://bugs.webkit.org/show_bug.cgi?id=43019

Reviewed by Sam Weinig.

* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::putDelegate):
(WebCore::JSHTMLAppletElement::getCallData):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::putDelegate):
(WebCore::JSHTMLEmbedElement::getCallData):
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::putDelegate):
(WebCore::JSHTMLObjectElement::getCallData):
runtimeObjectCustomPut and runtimeObjectGetCallData now take a JSHTMLElement instead of a HTMLElement.

* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginScriptObject):
First, ask the PluginViewBase for a JSObject and fall back to getting the JSObject from the instance.

(WebCore::runtimeObjectPropertyGetter):
(WebCore::runtimeObjectCustomGetOwnPropertySlot):
(WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):
Call pluginScriptObject.

(WebCore::runtimeObjectCustomPut):
Change to take a JSHTMLElement. Call pluginScriptObject.

(WebCore::runtimeObjectGetCallData):
Change to take a JSHTMLElement.

* bridge/jsc/BridgeJSC.cpp:
* bridge/jsc/BridgeJSC.h:
(JSC::Bindings::Instance::createRuntimeObject):
Change this to return a JSObject.

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::getInstance):
Call pluginWidget.

(WebCore::HTMLPlugInElement::pluginWidget):
Return the plug-in widget for this element.

* html/HTMLPlugInElement.h:
* plugins/PluginViewBase.h:
(WebCore::PluginViewBase::scriptObject):
Add default implementation of scriptObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Dominic Mazzoni <dmazzoni@google.com>
commit-queue@webkit.org [Tue, 27 Jul 2010 00:01:07 +0000 (00:01 +0000)]
2010-07-26  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Chris Fleizach.

        Add accessor to get the doctype of a WebDocument, needed to
        implement Windows accessibility.

        https://bugs.webkit.org/show_bug.cgi?id=43003

        * WebKit.gyp:
        * public/WebDocument.h:
        * public/WebDocumentType.h: Added.
        (WebKit::WebDocumentType::WebDocumentType):
        (WebKit::WebDocumentType::operator=):
        (WebKit::WebDocumentType::assign):
        * src/WebDocument.cpp:
        (WebKit::WebDocument::doctype):
        * src/WebDocumentType.cpp: Added.
        (WebKit::WebDocumentType::name):
        (WebKit::WebDocumentType::WebDocumentType):
        (WebKit::WebDocumentType::operator=):
        (WebKit::WebDocumentType::operator PassRefPtr<DocumentType>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPart 2 of https://bugs.webkit.org/show_bug.cgi?id=43013
weinig@apple.com [Tue, 27 Jul 2010 00:00:51 +0000 (00:00 +0000)]
Part 2 of https://bugs.webkit.org/show_bug.cgi?id=43013
<rdar://problem/8152434>
Add support for scrolling using the keyboard in WebKit2

Reviewed by Anders Carlsson.

Add support for scrolling with the space bar and ensure that we don't scroll
if WebCore is handling the event in another way.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::keyEvent):
(WebKit::getScrollMapping):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX: Safari does not support ARIA mixed checkboxes
cfleizach@apple.com [Mon, 26 Jul 2010 23:33:31 +0000 (23:33 +0000)]
AX: Safari does not support ARIA mixed checkboxes
https://bugs.webkit.org/show_bug.cgi?id=43016

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/mixed-checkbox.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::checkboxOrRadioValue):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityRenderObject::checkboxOrRadioValue):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

* platform/mac/accessibility/mixed-checkbox-expected.txt: Added.
* platform/mac/accessibility/mixed-checkbox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64088 268f45cc-cd09-0410-ab3c-d52691b4dbfc