WebKit-https.git
9 years agoCrash in WebCore::RenderTableSection::addChild due to assert failure
fsamuel@chromium.org [Tue, 25 Oct 2011 19:10:58 +0000 (19:10 +0000)]
Crash in WebCore::RenderTableSection::addChild due to assert failure
https://bugs.webkit.org/show_bug.cgi?id=70678

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-anonymous-cell-bug.html
       fast/table/table-anonymous-row-bug.html
       fast/table/table-anonymous-section-bug.html

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):

LayoutTests:

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

* fast/table/table-anonymous-cell-bug-expected.txt: Added.
* fast/table/table-anonymous-cell-bug.html: Added.
* fast/table/table-anonymous-row-bug-expected.txt: Added.
* fast/table/table-anonymous-row-bug.html: Added.
* fast/table/table-anonymous-section-bug-expected.txt: Added.
* fast/table/table-anonymous-section-bug.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPDF SUBFRAMES: Incomplete repaint after pinch to zoom
andersca@apple.com [Tue, 25 Oct 2011 19:01:51 +0000 (19:01 +0000)]
PDF SUBFRAMES: Incomplete repaint after pinch to zoom
https://bugs.webkit.org/show_bug.cgi?id=70821
<rdar://problem/10312733>

Reviewed by Simon Fraser.

Add a new pure virtual member function, Plugin::wantsWindowRelativeCoordinates.
If a plug-in subclass returns true, we'll keep giving the plug-in coordinates that
are relative to the containing window. If a plug-in subclass returns false, we'll give it
coordinates in a much more sane coordinate system, with the origin at the top left corner of the plug-in.

Change BuiltinPDFView to return false so that it'll work correctly with pinch to zoom.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Make wantsWindowRelativeCoordinates return true.

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::paint):
Remove translation since the graphics context is already set up in the right way.

(WebKit::BuiltInPDFView::paintContent):
No need to offset by the plug-in view location anymore.

(WebKit::BuiltInPDFView::paintControls):
Account for the scrollbars being children of the parent scroll view here.

(WebKit::BuiltInPDFView::wantsWindowRelativeCoordinates):
Return false.

(WebKit::BuiltInPDFView::convertFromContainingViewToScrollbar):
Implement this so that scrollbar hit testing works correctly.

* WebProcess/Plugins/Plugin.h:
Add wantsWindowRelativeCoordinates.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
Return true for now.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::renderer):
Add simple getter.

(WebKit::PluginView::paint):
Handle the case when the plug-in doesn't want window relative coordinates.

(WebKit::PluginView::transformsAffectFrameRect):
Return true here.

(WebKit::PluginView::viewGeometryDidChange):
No need to adjust the bounds to account for the scale factor now, since the frame rect will always be the
same regardless of the transform.

(WebKit::PluginView::clipRectInWindowCoordinates):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd missing DFG file entries to the make lists for GTK and Qt ports
commit-queue@webkit.org [Tue, 25 Oct 2011 18:59:42 +0000 (18:59 +0000)]
Add missing DFG file entries to the make lists for GTK and Qt ports
https://bugs.webkit.org/show_bug.cgi?id=70806

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-25
Reviewed by Darin Adler.

* GNUmakefile.list.am:
* JavaScriptCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd getOwnPropertySlot to MethodTable
mhahnenberg@apple.com [Tue, 25 Oct 2011 18:51:49 +0000 (18:51 +0000)]
Add getOwnPropertySlot to MethodTable
https://bugs.webkit.org/show_bug.cgi?id=69807

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* JavaScriptCore.exp:
* runtime/ClassInfo.h: Added both versions of getOwnPropertySlot to the MethodTable.
* runtime/JSCell.h: Changed getOwnPropertySlot to be protected so other classes can
reference it in their MethodTables.

Source/WebCore:

No new tests.

* bridge/runtime_method.h: Changed getOwnPropertySlot to be protected so
subclasses can reference it in their MethodTables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd new uri tokenizer tests
zherczeg@webkit.org [Tue, 25 Oct 2011 18:24:04 +0000 (18:24 +0000)]
Add new uri tokenizer tests
https://bugs.webkit.org/show_bug.cgi?id=70807

Reviewed by Darin Adler.

Test more cases!

* fast/css/uri-token-parsing-expected.txt:
* fast/css/uri-token-parsing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed to support marking of multiple nested codeblocks when compiling
oliver@apple.com [Tue, 25 Oct 2011 18:17:37 +0000 (18:17 +0000)]
Need to support marking of multiple nested codeblocks when compiling
https://bugs.webkit.org/show_bug.cgi?id=70832

Reviewed by Gavin Barraclough.

When inlining a function we end up with multiple codeblocks being
compiled at the same time, so we need to support a list of live
codeblocks.

* heap/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 18:10:38 +0000 (18:10 +0000)]
Unreviewed gardening.

The old rebaseline looked wrong and did not match the other baselines. This is now corrected.

* platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 18:06:51 +0000 (18:06 +0000)]
Unreviewed gardening.

Partial rebaselining of fast/css/focus-ring-multiline-writingmode-vertical.html as it looks like it progressed
on some platforms.

* platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
* platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago"Open with" item missing from PDF context menu in some cases
sullivan@apple.com [Tue, 25 Oct 2011 17:54:35 +0000 (17:54 +0000)]
"Open with" item missing from PDF context menu in some cases
https://bugs.webkit.org/show_bug.cgi?id=70828
<rdar://problem/10034302>

Reviewed by Anders Carlsson.

* UIProcess/API/mac/PDFViewController.mm:
(insertOpenWithDefaultPDFMenuItem):
New helper function, extracted from -menuForEvent:. Identical to original code except
that it inserts the item at a specified index, rather than always at the end.
(-[WKPDFView menuForEvent:]):
Now keeps track of whether the Open With item has been inserted while iterating through
the PDFKit-supplied menu items looking for a "Copy" item. If a "Copy" item is not found,
inserts the Open With item at the top of the context menu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups
simon.fraser@apple.com [Tue, 25 Oct 2011 17:54:11 +0000 (17:54 +0000)]
REGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups
https://bugs.webkit.org/show_bug.cgi?id=62797

Source/WebCore:

Reviewed by Chris Marrin.

When hit testing through transformed layers, RenderLayer would simply use
the composited bounds of the layer as the localHitTestRect for hit testing sublayers.
However, this broke hit testing on pages that have a composited, non-transformed layer
which falls outside the bounds of its parent, composited-transformed layer, like Google
Maps.

Fix by mapping the hitTestRect through transforms. However this is tricky, because
mapping a rect into the coordinate system of a layer can result in invalid rectangles
when point projection results in a negative w component. Fix TransformationMatrix::projectPoint()
to detect this case and replace X and Y with large values, and add boundsOfProjectedQuad(), which
maps rectangles with possibly-infinite location or bounds into rects which are representable
in an IntRect.

Tests: transforms/3d/hit-testing/composited-hit-test.html
       transforms/3d/hit-testing/rotated-hit-test-with-child.html
       transforms/3d/hit-testing/rotated-hit-test2.html

* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::projectPoint):
(WebCore::TransformationMatrix::projectQuad):
(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::boundsOfProjectedQuad):
* platform/graphics/transforms/TransformationMatrix.h:
* rendering/HitTestingTransformState.cpp:
(WebCore::HitTestingTransformState::boundsOfMappedQuad):
* rendering/HitTestingTransformState.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):

LayoutTests:

Reviewed by Chris Marrin.

New tests for hit testing through various configurations of 3D transforms.

* platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.png: Removed.
* platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.txt: Removed.
* transforms/3d/hit-testing/composited-hit-test-expected.txt: Added.
* transforms/3d/hit-testing/composited-hit-test.html: Added.
* transforms/3d/hit-testing/resources/hit-test-utils.js: Added.
* transforms/3d/hit-testing/rotated-hit-test-expected.txt: Added.
* transforms/3d/hit-testing/rotated-hit-test-with-child-expected.txt: Added.
* transforms/3d/hit-testing/rotated-hit-test-with-child.html: Added.
* transforms/3d/hit-testing/rotated-hit-test.html:
* transforms/3d/hit-testing/rotated-hit-test2-expected.txt: Added.
* transforms/3d/hit-testing/rotated-hit-test2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Batch up texture uploads so that they can be updated incrementally
enne@google.com [Tue, 25 Oct 2011 17:44:31 +0000 (17:44 +0000)]
[chromium] Batch up texture uploads so that they can be updated incrementally
https://bugs.webkit.org/show_bug.cgi?id=70454

Reviewed by James Robinson.

Because texture uploads can sometimes take more than a frame to
complete, collect all the uploads that need to occur in a
CCTextureUpdater so that we can easily incrementally upload some of
them, interleaving input and drawing so that the compositor thread
continues to appear responsive during a commit.

This change doesn't actually interleave the commits, it just pushes
the infrastructure for doing so up to the CCProxy level so that a
future scheduler can make this decision.

VideoLayerChromium is the only layer type to not use this system. It
needs to be converted to use a texture updater first and it is less of
a priority than the tiled layers.

* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
* platform/graphics/chromium/VideoLayerChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
* platform/graphics/chromium/WebGLLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCTextureUpdater.cpp: Added.
(WebCore::CCTextureUpdater::CCTextureUpdater):
(WebCore::CCTextureUpdater::~CCTextureUpdater):
(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):
* platform/graphics/chromium/cc/CCTextureUpdater.h: Added.
(WebCore::CCTextureUpdater::allocator):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitOnImplThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocompositing/video tests time out on Lion
jer.noble@apple.com [Tue, 25 Oct 2011 17:42:18 +0000 (17:42 +0000)]
compositing/video tests time out on Lion
https://bugs.webkit.org/show_bug.cgi?id=70448

Reviewed by Simon Fraser.

Source/WebCore:

AVFoundation will not begin loading or decoding media until a consumer for that media is present.
For video-only media, this means that an AVPlayerLayer must be created and attached to the
AVPlayer before the load state will ever reach "canPlayThrough". Once the metadata for a media
is loaded, create a AVPlayerLayer if the media has a video track.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

LayoutTests:

* compositing/video/video-poster.html: Seek, instead of play, to trigger
    creation of a layer
* http/tests/media/video-load-twice.html: Use waitForEventOnce so that
    canPlayThrough listener is triggered only once.
* media/video-test.js: Add a new function, waitForEventOnce.
(waitForEventOnce):
(waitForEvent._eventCallback):
(waitForEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMerge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine
rniwa@webkit.org [Tue, 25 Oct 2011 17:22:50 +0000 (17:22 +0000)]
Merge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=70755

Reviewed by Chang Shu.

Merged endOfLine with logicalEndOfLine, and startOfLine with logicalStartOfLine
to reduce the code duplication.

* editing/visible_units.cpp:
(WebCore::startPositionForLine):
(WebCore::startOfLine):
(WebCore::logicalStartOfLine):
(WebCore::endPositionForLine):
(WebCore::inSameLogicalLine):
(WebCore::endOfLine):
(WebCore::logicalEndOfLine):
* editing/visible_units.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-enable touch tests (from 66577)
commit-queue@webkit.org [Tue, 25 Oct 2011 17:22:37 +0000 (17:22 +0000)]
Re-enable touch tests (from 66577)
https://bugs.webkit.org/show_bug.cgi?id=70351

Patch by Gene Girard <girard@chromium.org> on 2011-10-25
Reviewed by Adam Barth.

* tests/InnerGestureRecognizerTest.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
nduca@chromium.org [Tue, 25 Oct 2011 17:18:38 +0000 (17:18 +0000)]
Unreviewed. Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: fifth chunk of baselines for Chromium-Skia
caryclark@google.com [Tue, 25 Oct 2011 17:17:46 +0000 (17:17 +0000)]
Unreviewed gardening: fifth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 736 of 742 files for brevity.]

* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-4-expected.png: Added.
...
* platform/chromium-mac-leopard/transitions: Added.
* platform/chromium-mac-leopard/transitions/default-timing-function-expected.png: Added.
* platform/chromium-mac-leopard/transitions/svg-text-shadow-transition-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable running of track layout tests for Chromium
annacc@chromium.org [Tue, 25 Oct 2011 17:04:05 +0000 (17:04 +0000)]
Enable running of track layout tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70803

Reviewed by Adam Barth.

Make DumpRenderTree/TestShell always run with track enabled
(equivalent of --enable-video-track).

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Microdata: itemtype attribute should be space-separated list to allow...
commit-queue@webkit.org [Tue, 25 Oct 2011 16:53:52 +0000 (16:53 +0000)]
Source/WebCore: Microdata: itemtype attribute should be space-separated list to allow multiple types.
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha <arko@motorola.com> on 2011-10-25
Reviewed by Ryosuke Niwa.

Tests: fast/dom/MicroData/getitems-multiple-itemtypes.html
       fast/dom/MicroData/itemtype-add-remove-tokens.html
       fast/dom/MicroData/itemtype-attribute-test.html

* dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::nodeMatches):
* html/DOMSettableTokenList.h:
(WebCore::DOMSettableTokenList::tokens):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::setItemValueText):
(WebCore::HTMLElement::itemType):
(WebCore::HTMLElement::setItemType):
* html/HTMLElement.h:
* html/HTMLElement.idl:

LayoutTests: Microdata: itemtype attribute should be space-separated list to allow multiple types
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha <arko@motorola.com> on 2011-10-25
Reviewed by Ryosuke Niwa.

* fast/dom/MicroData/006.html:
* fast/dom/MicroData/007.html:
* fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt: Added.
* fast/dom/MicroData/getitems-multiple-itemtypes.html: Added.
* fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt: Added.
* fast/dom/MicroData/itemtype-add-remove-tokens.html: Added.
* fast/dom/MicroData/itemtype-attribute-test-expected.txt: Added.
* fast/dom/MicroData/itemtype-attribute-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] GtkAdjustment watcher updates adjustments too lazily
commit-queue@webkit.org [Tue, 25 Oct 2011 16:52:50 +0000 (16:52 +0000)]
[GTK] GtkAdjustment watcher updates adjustments too lazily
https://bugs.webkit.org/show_bug.cgi?id=70180

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.

Increase the priority of the GtkAdjustments update in GtkAdjustmentWatcher. This
means that adjustments will more quickly represent the state of the WebKitWebView
when it scrolls. This fixes out-of-sync scrollbars and some visual artifacts.

* WebCoreSupport/GtkAdjustmentWatcher.cpp:
(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): Use a timeout
with the default priority.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
commit-queue@webkit.org [Tue, 25 Oct 2011 16:40:29 +0000 (16:40 +0000)]
[WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
https://bugs.webkit.org/show_bug.cgi?id=70603

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.

* MiniBrowser/gtk/BrowserWindow.c:
(focus):
(unFocus):
(browserWindowUIClientInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with ...
mitz@apple.com [Tue, 25 Oct 2011 16:39:23 +0000 (16:39 +0000)]
<rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none

Reviewed by Adam Roben.

Source/WebCore:

Test: added to TestWebKitAPI/Tests/mac/DOMRangeOfString.mm

* page/Page.cpp:
(WebCore::Page::rangeOfString): This function was incorrectly adding the StartInSelection option to
the initial search.

Tools:

* TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: fourth chunk of baselines for Chromium-Skia
caryclark@google.com [Tue, 25 Oct 2011 16:26:15 +0000 (16:26 +0000)]
Unreviewed gardening: fourth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 728 of 734 files for brevity.]

* platform/chromium-mac-leopard/fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
* platform/chromium-mac-leopard/fast/lists/scrolled-marker-paint-expected.png: Added.
* platform/chromium-mac-leopard/fast/media: Added.
...
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tref-01-b-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: redesign workers sidebar pane
yurys@chromium.org [Tue, 25 Oct 2011 15:35:50 +0000 (15:35 +0000)]
Web Inspector: redesign workers sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=70815

Source/WebCore:

Changed workers sidebar pane design.

Now there is a link to worker inspector for each dedicated worker created
by inspected page. The sidebar display a link to a page with list of all
shared workers if there one is supported by the WebKit port. Also there
is a checkbox that allows pause all new workers on first statements.

Reviewed by Pavel Feldman.

* inspector/front-end/Settings.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype.openWorkerInspector):
(WebInspector.WorkerManager.prototype._workerInspectorClosing):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
(WebInspector.WorkerListSidebarPane.prototype._workersCleared):
(WebInspector.WorkerListSidebarPane.prototype._addWorker):
(WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink.link.onclick):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink):
* inspector/front-end/elementsPanel.css:
* inspector/front-end/inspectorCommon.css:
(.sidebar-separator):
(.sidebar-label):
* inspector/front-end/scriptsPanel.css:
(.dedicated-worker-item):
(#shared-workers-list):
(#pause-workers-checkbox > input):

Source/WebKit/chromium:

Reviewed by Pavel Feldman.

* src/js/DevTools.js: Expose link to shared workers inspection page to WebCore.
():

LayoutTests:

Update tests in accord with change of class name from
styles-sidebar-pane to sidebar-pane.

Reviewed by Pavel Feldman.

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [chromium/mac] Fix an ODR violation.
thakis@chromium.org [Tue, 25 Oct 2011 15:21:15 +0000 (15:21 +0000)]
Source/WebCore: [chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753

Reviewed by Anders Carlsson.

Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium: [chromium] Try to fix mac build after r98294
https://bugs.webkit.org/show_bug.cgi?id=70753

Remove test for ScrollAnimatorNone on mac.

Unreviewed, build fix.

* WebKit.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Debugger fails when there is an invalid watch expression.
vsevik@chromium.org [Tue, 25 Oct 2011 15:06:00 +0000 (15:06 +0000)]
Web Inspector: Debugger fails when there is an invalid watch expression.
https://bugs.webkit.org/show_bug.cgi?id=70718

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/watch-expressions-panel-switch.html

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

* inspector/debugger/error-in-watch-expressions.html:
* inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
* inspector/debugger/watch-expressions-panel-switch.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: fix empty line handling in source maps.
podivilov@chromium.org [Tue, 25 Oct 2011 14:26:59 +0000 (14:26 +0000)]
Web Inspector: fix empty line handling in source maps.
https://bugs.webkit.org/show_bug.cgi?id=70726

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):

LayoutTests:

* inspector/debugger/compiler-source-mapping-expected.txt:
* inspector/debugger/compiler-source-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck for empty string in parseArcFlag
jschuh@chromium.org [Tue, 25 Oct 2011 14:24:59 +0000 (14:24 +0000)]
Check for empty string in parseArcFlag
https://bugs.webkit.org/show_bug.cgi?id=70763

Reviewed by Dirk Schulze.

Source/WebCore:

Test: svg/path-invalid.html

* svg/SVGParserUtilities.cpp:
(WebCore::parseArcFlag):

LayoutTests:

* svg/path-arc-invalid-expected.txt: Added.
* svg/path-arc-invalid.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: keep old source mapping when new one could not be loaded.
podivilov@chromium.org [Tue, 25 Oct 2011 14:22:44 +0000 (14:22 +0000)]
Web Inspector: keep old source mapping when new one could not be loaded.
https://bugs.webkit.org/show_bug.cgi?id=70729

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):

LayoutTests:

* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDouble number step=.5 should be considered valid in <input type="number" step=".5">
commit-queue@webkit.org [Tue, 25 Oct 2011 14:04:45 +0000 (14:04 +0000)]
Double number step=.5 should be considered valid in <input type="number" step=".5">
https://bugs.webkit.org/show_bug.cgi?id=70320

Patch by Sachin Puranik <sachin.puranik@motorola.com> on 2011-10-25
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/input-step-as-double.html

* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseToDoubleForNumberType): Changed the function to consider
step as valid even if it starts with "."

LayoutTests:

* fast/forms/ValidityState-typeMismatch-number-expected.txt: Change in result of layout test.
* fast/forms/input-step-as-double-expected.txt: Added, expected output for new test case.
* fast/forms/input-step-as-double.html: Added, testcase to make sure that all ports
consider .5 as a valid double value for step attribute of input element.
* fast/forms/input-valueasnumber-number-expected.txt: Change in result of layout test.
* fast/forms/range/input-valueasnumber-range-expected.txt: Change in result of layout test.
* fast/forms/range/input-valueasnumber-range.html: Consider .2 as valid real number now.
* fast/forms/script-tests/ValidityState-typeMismatch-number.js: Consider
.2 as valid real number now.
* fast/forms/script-tests/input-valueasnumber-number.js: Consider .2 as valid real number now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Chromium] Audits panel context menu for links not working properly
apavlov@chromium.org [Tue, 25 Oct 2011 13:57:54 +0000 (13:57 +0000)]
Web Inspector: [Chromium] Audits panel context menu for links not working properly
https://bugs.webkit.org/show_bug.cgi?id=70813

Reviewed by Pavel Feldman.

* inspector/front-end/AuditResultView.js:
(WebInspector.AuditResultView):
(WebInspector.AuditResultView.prototype._contextMenuEventFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
eric@webkit.org [Tue, 25 Oct 2011 13:49:33 +0000 (13:49 +0000)]
WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
https://bugs.webkit.org/show_bug.cgi?id=64471

Reviewed by Adam Roben.

Speculative fix.

* Scripts/webkitpy/layout_tests/port/win.py:
* Scripts/webkitpy/layout_tests/port/win_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Resources panel: display the current search match index in the toolbar.
vsevik@chromium.org [Tue, 25 Oct 2011 13:49:24 +0000 (13:49 +0000)]
Web Inspector: Resources panel: display the current search match index in the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=66050

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/resources-search-match-index.html

* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):
(WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
(WebInspector.ResourcesPanel.prototype._showSearchResult):
(WebInspector.BaseStorageTreeElement.prototype.get searchMatchesCount):
(WebInspector.ResourcesSearchController):
(WebInspector.ResourcesSearchController.prototype.nextSearchResult):
(WebInspector.ResourcesSearchController.prototype.previousSearchResult):
(WebInspector.ResourcesSearchController.prototype._searchResult):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.next):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.previous):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.matchIndex):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._elementSearchMatchesCount):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):
* inspector/front-end/treeoutline.js:

LayoutTests:

* http/tests/inspector/search/resources-search-match-index-expected.txt: Added.
* http/tests/inspector/search/resources-search-match-index.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoinspector/cookie-parser.html is a flaky crash
ossy@webkit.org [Tue, 25 Oct 2011 13:45:47 +0000 (13:45 +0000)]
inspector/cookie-parser.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=62662

* platform/qt/Skipped: Skip one more test because of this bug: inspector/evaluate-in-page.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system.
commit-queue@webkit.org [Tue, 25 Oct 2011 13:38:28 +0000 (13:38 +0000)]
[Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system.
https://bugs.webkit.org/show_bug.cgi?id=70693

This change allows us to use the template based features of the meta type system
such as using the WebView classes as types for QVariant.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showObjectPopover()
caseq@chromium.org [Tue, 25 Oct 2011 12:59:07 +0000 (12:59 +0000)]
Web Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showObjectPopover()
https://bugs.webkit.org/show_bug.cgi?id=70812

Reviewed by Pavel Feldman.

Check if highlighted element is present while displaying object popover.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.onShowPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype.onShowPopover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Remove redundant setPageIsVisible() API
commit-queue@webkit.org [Tue, 25 Oct 2011 11:01:51 +0000 (11:01 +0000)]
[Qt][WK2] Remove redundant setPageIsVisible() API
https://bugs.webkit.org/show_bug.cgi?id=70520

Use DrawingAreaProxy::visibilityDidChange() instead of DrawingAreaProxy::setPageIsVisible()
Remove DrawingAreaProxy::setPageIsVisible(), not used anymore.
This change disables the ability of suspending and resuming painting for TiledDrawingAreaProxy.
However, TiledDrawingAreaProxy is about to be deprecated by using DrawingAreaProxyImpl
as the UI process drawing area proxy for tiled based rendering.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-25
Reviewed by Simon Hausmann.

* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::QTouchWebPage):
(QTouchWebPagePrivate::setPage):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebView::QTouchWebView):
(QTouchWebView::touchEvent):
(QTouchWebView::onVisibleChanged):
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::deviceScaleFactorDidChange):
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
* UIProcess/qt/QtWebPageProxy.cpp:
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Route Console::time and Console::timeEnd to trace_event
nduca@chromium.org [Tue, 25 Oct 2011 09:54:27 +0000 (09:54 +0000)]
[chromium] Route Console::time and Console::timeEnd to trace_event
https://bugs.webkit.org/show_bug.cgi?id=70620

Reviewed by Pavel Feldman.

* page/Console.cpp:
(WebCore::Console::time):
(WebCore::Console::timeEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove from Skipped list. Test passes: fast/transforms/scrollIntoView-transforme...
ossy@webkit.org [Tue, 25 Oct 2011 09:39:35 +0000 (09:39 +0000)]
[Qt] Remove from Skipped list. Test passes: fast/transforms/scrollIntoView-transformed.html
https://bugs.webkit.org/show_bug.cgi?id=58559

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-25
Reviewed by Simon Hausmann.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Removing test from Skipped list. Test passes: html5lib/runner.html
ossy@webkit.org [Tue, 25 Oct 2011 09:35:48 +0000 (09:35 +0000)]
[Qt] Removing test from Skipped list. Test passes: html5lib/runner.html
https://bugs.webkit.org/show_bug.cgi?id=53030

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-25
Reviewed by Simon Hausmann.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Extensions API] allow extensions to specify script to be injected...
caseq@chromium.org [Tue, 25 Oct 2011 09:25:37 +0000 (09:25 +0000)]
Web Inspector: [Extensions API] allow extensions to specify script to be injected on reload
https://bugs.webkit.org/show_bug.cgi?id=70600

Reviewed by Pavel Feldman.

- change webInspector.inspectedPage.reload() to accept multiple options in an object
- add an ability to inject a script upon a page reload
- return script id in addScriptToEvaluateOnLoad()
- provide removeScriptToEvaluateOnLoad()
- store scripts to evaluate on load in inspector state cookie

Source/WebCore:

Test: inspector/extensions/extensions-reload.html

* inspector/Inspector.json:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameNavigated):
* inspector/InspectorPageAgent.h:
* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.InspectedWindow.prototype.reload):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation.callback):
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation):

LayoutTests:

* inspector/extensions/extensions-reload-expected.txt: Added.
* inspector/extensions/extensions-reload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add go_to_back_forward_list_item() to WebKit2 GTK+ API
carlosgc@webkit.org [Tue, 25 Oct 2011 08:37:35 +0000 (08:37 +0000)]
[GTK] Add go_to_back_forward_list_item() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69825

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
(webkitBackForwardListItemGetWKItem):
* UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_go_to_back_forward_list_item):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/tests/TestBackForwardList.cpp:
(testBackForwardListNavigation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: print expired message count before remaining messages.
pfeldman@chromium.org [Tue, 25 Oct 2011 08:24:14 +0000 (08:24 +0000)]
Web Inspector: print expired message count before remaining messages.
https://bugs.webkit.org/show_bug.cgi?id=70736

Reviewed by Yury Semikhatsky.

* inspector/Inspector-0.1.json:
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::restore):
* inspector/InspectorConsoleAgent.h:
* inspector/front-end/ConsoleModel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2]Critical warning while building WebKit2 GTK+
commit-queue@webkit.org [Tue, 25 Oct 2011 08:19:54 +0000 (08:19 +0000)]
[WK2]Critical warning while building WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=70591

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-25
Reviewed by Martin Robinson.

* WebProcess/WebPage/WebPage.cpp: Included DataObjectGtk.h to avoid warnings for GTK

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r98309.
commit-queue@webkit.org [Tue, 25 Oct 2011 07:06:07 +0000 (07:06 +0000)]
Unreviewed, rolling out r98309.
http://trac.webkit.org/changeset/98309
https://bugs.webkit.org/show_bug.cgi?id=70801

Test fails on mac (Requested by benwells on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):
* html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

* fast/canvas/canvas-composite-image-expected.txt: Removed.
* fast/canvas/canvas-composite-image.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening, add missing result after r98309.
ossy@webkit.org [Tue, 25 Oct 2011 06:59:32 +0000 (06:59 +0000)]
[Qt] Unreviewed gardening, add missing result after r98309.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-10-24

* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
* platform/qt/svg/filters/feColorMatrix-default-type-expected.png: Added.
* platform/qt/svg/filters/feColorMatrix-default-type-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK
mrobinson@webkit.org [Tue, 25 Oct 2011 06:51:35 +0000 (06:51 +0000)]
REGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=70481

Update test results to reflect that the plugin clipping rectangle
is now correct.

* platform/gtk/Skipped: Unskip the test.
* platform/gtk/plugins/resize-from-plugin-expected.txt: Update results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT 32_64 - fillInteger should accept DataFormatJSInteger
commit-queue@webkit.org [Tue, 25 Oct 2011 05:43:15 +0000 (05:43 +0000)]
DFG JIT 32_64 - fillInteger should accept DataFormatJSInteger
https://bugs.webkit.org/show_bug.cgi?id=70798

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Filip Pizlo.

When filling an integer for a known integer node (not speculated), it
should accept DataFormatJSInteger as well.

* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium build fix: #include window.h for HANDLE.
ggaren@apple.com [Tue, 25 Oct 2011 04:57:36 +0000 (04:57 +0000)]
Chromium build fix: #include window.h for HANDLE.

* platform/graphics/opentype/OpenTypeUtilities.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInclude ThreadSafeRefCounted.h since the class declared in this header file
rniwa@webkit.org [Tue, 25 Oct 2011 04:49:18 +0000 (04:49 +0000)]
Include ThreadSafeRefCounted.h since the class declared in this header file
inherits from ThreadSafeRefCounted.

* storage/IDBIndexBackendInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix: removed some cases of threadsafeCopy() that I missed in
ggaren@apple.com [Tue, 25 Oct 2011 04:33:38 +0000 (04:33 +0000)]
Build fix: removed some cases of threadsafeCopy() that I missed in
my previous patch.

Source/JavaScriptCore:

* JavaScriptCore.order:

Source/WebKit/win:

* WebDatabaseManager.cpp:
(DidModifyOriginData::dispatchToMainThread):
* WebDownloadCFNet.cpp:
(WebDownload::initToResumeWithBundle):
* WebIconDatabase.cpp:
(WebIconDatabase::didImportIconURLForPageURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Fix a typo.
rniwa@webkit.org [Tue, 25 Oct 2011 04:26:38 +0000 (04:26 +0000)]
Source/WebCore: Fix a typo.

* bindings/v8/JavaScriptCallFrame.h:

Source/WebKit/win: threadsafeCopy has been renamed to isolatedCopy.

* WebDatabaseManager.cpp:
(DidModifyOriginData::dispatchToMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved SharedUChar and tightened language around its previous uses
ggaren@apple.com [Tue, 25 Oct 2011 03:54:15 +0000 (03:54 +0000)]
Removed SharedUChar and tightened language around its previous uses
https://bugs.webkit.org/show_bug.cgi?id=70698

Reviewed by David Levin.

Source/JavaScriptCore:

- Removed SharedUChar because most of its functionality has moved into
other abstraction layers, and we want remaining clients to choose their
abstractions explicitly instead of relying on StringImpl to provide this
behavior implicitly, since we think they can sometimes make more efficient
choices.

- Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
the former names could give the impression that the resulting object was
thread-safe, but actually it's just an isolated copy, which is not
thread-safe by itself, but can be used to implement a thread-safe
algorithm through isolation.

* wtf/CrossThreadRefCounted.h: Removed.

* JavaScriptCore.exp: Export!

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl): Removed the stuff mentioned above.

* wtf/text/StringImpl.h:
(WTF::StringImpl::length): Ditto.

(WTF::StringImpl::isolatedCopy): Inlined this, since it's now trivial.

* wtf/text/WTFString.cpp:
(WTF::String::isolatedCopy):
* wtf/text/WTFString.h: Updated for StringImpl changes.

* API/OpaqueJSString.h:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.order:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/OwnFastMallocPtr.h:
* wtf/RefCounted.h:
* wtf/SizeLimits.cpp:
* wtf/ThreadSafeRefCounted.h:
* wtf/wtf.pri:
* yarr/YarrPattern.h: Updated these files to accomodate removal of
CrossThreadRefCounted.h.

Source/WebCore:

- Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

- Updated a bunch of files for header dependency changes, now that
CrossThreadRefCounted is gone.

* ForwardingHeaders/wtf/CrossThreadRefCounted.h: Removed.
* WebCore.exp.in:
* bindings/js/ScriptHeapSnapshot.h:
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::release):
(WebCore::SerializedScriptValue::SerializedScriptValue):
* css/CSSPropertySourceData.h:
* css/CSSValue.h:
* css/StyleMedia.h:
* css/WebKitCSSMatrix.h:
* dom/QualifiedName.h:
* fileapi/LocalFileSystem.h:
(WebCore::LocalFileSystem::SystemBasePath::operator String):
* history/CachedFrame.h:
* history/CachedPage.h:
* history/HistoryItem.h:
* html/canvas/CanvasStyle.h:
* inspector/InspectorResourceAgent.h:
* loader/FormState.h:
* loader/TextResourceDecoder.h:
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::open):
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::synchronousIconURLForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::databasePath):
(WebCore::IconDatabase::defaultDatabaseFilename):
(WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem):
* page/ContentSecurityPolicy.h:
* page/Coordinates.h:
(WebCore::Coordinates::isolatedCopy):
* page/Geoposition.h:
(WebCore::Geoposition::isolatedCopy):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::isolatedCopy):
* page/SecurityOrigin.h:
* page/animation/AnimationBase.h:
* platform/CrossThreadCopier.cpp:
(WebCore::::copy):
* platform/FileChooser.h:
* platform/KURL.cpp:
(WebCore::KURL::copy):
* platform/cf/SchedulePair.h:
* platform/network/BlobData.cpp:
(WebCore::BlobDataItem::detachFromCurrentThread):
(WebCore::BlobData::detachFromCurrentThread):
* platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
* platform/network/MIMEHeader.h:
* platform/network/ResourceErrorBase.cpp:
(WebCore::ResourceErrorBase::copy):
* platform/network/ResourceLoadInfo.h:
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::copyData):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::copyData):
* platform/sql/SQLValue.cpp:
(WebCore::SQLValue::SQLValue):
(WebCore::SQLValue::string):
* rendering/style/QuotesData.h:
* storage/AbstractDatabase.cpp:
(WebCore::updateGuidVersionMap):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::stringIdentifier):
(WebCore::AbstractDatabase::displayName):
(WebCore::AbstractDatabase::fileName):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::getCachedVersion):
* storage/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::ChangeVersionWrapper):
* storage/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::tableNames):
* storage/DatabaseDetails.h:
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::setDatabaseDirectoryPath):
(WebCore::DatabaseTracker::databaseDirectoryPath):
(WebCore::DatabaseTracker::trackerDatabasePath):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::originPath):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::recordCreatingDatabase):
(WebCore::DatabaseTracker::recordDeletingDatabase):
(WebCore::DatabaseTracker::recordDeletingOrigin):
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):
* storage/OriginQuotaManager.cpp:
(WebCore::OriginQuotaManager::trackOrigin):
(WebCore::OriginQuotaManager::addDatabase):
* storage/SQLError.h:
(WebCore::SQLError::message):
(WebCore::SQLError::SQLError):
* storage/SQLResultSetRowList.h:
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::SQLStatement):
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::syncTimerFired):
* storage/StorageAreaSync.h:
* storage/StorageMap.cpp:
(WebCore::StorageMap::importItem):
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::StorageNamespaceImpl):
* storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::StorageSyncManager):
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::willDeleteAllOrigins):
* svg/SVGPathSeg.h:
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::url):
(WebCore::SharedWorkerProxy::name):
(WebCore::SharedWorkerProxy::SharedWorkerProxy):
(WebCore::DefaultSharedWorkerRepository::getProxy):
* workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::SharedWorkerThread):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerExceptionTask::WorkerExceptionTask):
(WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask):
* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):

Source/WebKit/chromium:

- Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

* src/WorkerFileSystemCallbacksBridge.cpp:

Source/WebKit/mac:

- Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

* Storage/WebDatabaseTrackerClient.mm:
(DidModifyOriginData::dispatchToMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix bug summary when rolling Chromium DEPS to LKGR.
mnaganov@chromium.org [Tue, 25 Oct 2011 03:36:24 +0000 (03:36 +0000)]
Fix bug summary when rolling Chromium DEPS to LKGR.
https://bugs.webkit.org/show_bug.cgi?id=69917

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/sheriff.py:
* Scripts/webkitpy/tool/commands/roll.py:
* Scripts/webkitpy/tool/commands/roll_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove empty directory.
abarth@webkit.org [Tue, 25 Oct 2011 03:17:25 +0000 (03:17 +0000)]
Remove empty directory.

* p2p: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Refactor painting/updating/drawing code.
commit-queue@webkit.org [Tue, 25 Oct 2011 02:54:22 +0000 (02:54 +0000)]
[chromium] Refactor painting/updating/drawing code.
https://bugs.webkit.org/show_bug.cgi?id=70057

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-24
Reviewed by James Robinson.

This refactoring separates the "early exits" from the actual loop
that draws layers. As part of this, it was also appropriate to
clean up the way that masks and replicas are dealt with when
painting and updating. The purpose of all this is to make things
easier to test, and for a scissoring optimization that needs to
know exatly what gets drawn. Existing layout tests were able to
verify the refactoring did not change behavior.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::layerShouldBeAppended):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 02:53:31 +0000 (02:53 +0000)]
Unreviewed gardening.

Add a new baseline for snow-leopard.

* platform/chromium-mac-snowleopard/svg/filters: Added.
* platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify url accessors on WKBrowsingContextController
weinig@apple.com [Tue, 25 Oct 2011 02:47:22 +0000 (02:47 +0000)]
Simplify url accessors on WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70797

Reviewed by Anders Carlsson.

* UIProcess/API/C/WKPage.cpp:
(WKPageCopyActiveURL):
(WKPageCopyProvisionalURL):
(WKPageCopyCommittedURL):
* UIProcess/API/C/WKPage.h:
Add accessors to C SPI.

* UIProcess/API/mac/WKBrowsingContextController.h:
Remove unreachableURL accessor for now. It may make a glorious return when we have
error page support.

* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController activeURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController committedURL]):
Implement these in terms of the new C SPI.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activeURL):
Add computation of the "active" URL, which is the URL one would show
in an address field. It is the pending URL when there is one, the provisional
URL when there is one, and otherwise the committed/final URL.

(WebKit::WebPageProxy::provisionalURL):
(WebKit::WebPageProxy::committedURL):
Add access to the main frame URL.
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(80893): HTML5 spec takes 2s longer to load due to time spent in CSSStyleSe...
macpherson@chromium.org [Tue, 25 Oct 2011 02:38:26 +0000 (02:38 +0000)]
REGRESSION(80893): HTML5 spec takes 2s longer to load due to time spent in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=68944

Reviewed by Antti Koivisto.

No new tests / Covered by existing tests.

Removes all virtual dispatch from CSSStyleApplyProperty by converting to use static function pointers for dispatch.
Uses class templates instead of function templates to allow default parameters and also to share parameter declarations across static functions.
All constructor parameters become template parameters. This improves the level of compiler optimization that can be achieved.
Overall this achieved a ~2% overall speedup on run-safari PerformanceTests/Parser/html5-full-render.html,
and profiling showed a reduction in the time spent inside CSSStyleSelector::applyProperty().

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyExpanding::createHandler):
(WebCore::ApplyPropertyDefaultBase::setValue):
(WebCore::ApplyPropertyDefaultBase::value):
(WebCore::ApplyPropertyDefaultBase::initial):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefaultBase::createHandler):
(WebCore::ApplyPropertyDefault::setValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyDefault::createHandler):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyStyleImage::createHandler):
(WebCore::ApplyPropertyAuto::setValue):
(WebCore::ApplyPropertyAuto::value):
(WebCore::ApplyPropertyAuto::hasAuto):
(WebCore::ApplyPropertyAuto::setAuto):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyAuto::createHandler):
(WebCore::defaultInitialColor):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::createHandler):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyDirection::createHandler):
(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyLength::createHandler):
(WebCore::ApplyPropertyString::setValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyString::createHandler):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyFillLayer::createHandler):
(WebCore::ApplyPropertyComputeLength::setValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFont::createHandler):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontWeight::createHandler):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCounter::createHandler):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyCursor::createHandler):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::createHandler):
(WebCore::ApplyPropertyAnimation::setValue):
(WebCore::ApplyPropertyAnimation::value):
(WebCore::ApplyPropertyAnimation::test):
(WebCore::ApplyPropertyAnimation::clear):
(WebCore::ApplyPropertyAnimation::initial):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::accessAnimations):
(WebCore::ApplyPropertyAnimation::animations):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyAnimation::createHandler):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyOutlineStyle::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleApplyProperty.h:
(WebCore::PropertyHandler::PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
(WebCore::PropertyHandler::isValid):
(WebCore::PropertyHandler::inheritFunction):
(WebCore::PropertyHandler::initialFunction):
(WebCore::PropertyHandler::applyFunction):
(WebCore::CSSStyleApplyProperty::propertyHandler):
(WebCore::CSSStyleApplyProperty::setPropertyHandler):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::invalidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCanvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy...
commit-queue@webkit.org [Tue, 25 Oct 2011 02:28:48 +0000 (02:28 +0000)]
Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66920

Patch by Ben Wells <benwells@chromium.org> on 2011-10-24
Reviewed by James Robinson.

Source/WebCore:

Test: fast/canvas/canvas-composite-image.html

Use the same method as fills to handle composited drawImage calls that will affect the whole
canvas. To do this code used when doing fills has been factored into seperate functions and
used by drawImage. Some functions used to do these types of operations have also been renamed.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::isFullCanvasCompositeMode):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect):
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
* html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

* fast/canvas/canvas-composite-image-expected.txt: Added.
* fast/canvas/canvas-composite-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK and Windows rebaselines after r98199.
rniwa@webkit.org [Tue, 25 Oct 2011 02:15:18 +0000 (02:15 +0000)]
GTK and Windows rebaselines after r98199.

* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r98294 and r98306.
jchaffraix@webkit.org [Tue, 25 Oct 2011 01:24:05 +0000 (01:24 +0000)]
Unreviewed, rolling out r98294 and r98306.
http://trac.webkit.org/changeset/98294
http://trac.webkit.org/changeset/98306
https://bugs.webkit.org/show_bug.cgi?id=70790

the first patch broke chromium-mac and the second gclient
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-24

Source/WebCore:

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

* WebKit.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Try to fix mac build after r98294
jchaffraix@webkit.org [Tue, 25 Oct 2011 00:44:27 +0000 (00:44 +0000)]
[chromium] Try to fix mac build after r98294
https://bugs.webkit.org/show_bug.cgi?id=70785

Remove test for ScrollAnimatorNone on mac.

Unreviewed, build fix.

Patch by Nico Weber <thakis@chromium.org> on 2011-10-24

* WebKit.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix after r98300.
rniwa@webkit.org [Tue, 25 Oct 2011 00:44:17 +0000 (00:44 +0000)]
Build fix after r98300.

* WebCore.gypi:
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIt should be possible for Widget subclasses to control whether transforms affect...
andersca@apple.com [Tue, 25 Oct 2011 00:33:10 +0000 (00:33 +0000)]
It should be possible for Widget subclasses to control whether transforms affect the frame rect
https://bugs.webkit.org/show_bug.cgi?id=70787

Reviewed by Sam Weinig.

Currently RenderWidget sets the frame rect of it's hosted widget to the bounding box of the transformed
content box rect (unless the Widget is a frame view). It should be possible for Widget subclasses to override
this behavior and have the frame rect set to the absolute content box without any transforms applied.

* platform/Widget.h:
(WebCore::Widget::transformsAffectFrameRect):
Add new member function.

* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetGeometry):
Move shared code from setWidget and updateWidgetPosition out into a new function. If transformsAffectFrameRect returns
false, just set the frame rect to the absolute content box.

(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Call updateWidgetGeometry.

* rendering/RenderWidget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in void JSC::validateCell<JSC::RegExp*>(JSC::RegExp*)
oliver@apple.com [Tue, 25 Oct 2011 00:21:29 +0000 (00:21 +0000)]
Crash in void JSC::validateCell<JSC::RegExp*>(JSC::RegExp*)
https://bugs.webkit.org/show_bug.cgi?id=70689

Reviewed by Filip Pizlo.

While performing codegen we need to make the GlobalData explicitly
aware of the codeblock being compiled, as compilation may trigger GC
and CodeBlock holds GC values, but has not yet been assigned to its
owner executable.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::~BytecodeGenerator):
* bytecompiler/BytecodeGenerator.h:
* heap/AllocationSpace.cpp:
(JSC::AllocationSpace::allocateSlowCase):
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rebaseline after r98293.
jchaffraix@webkit.org [Tue, 25 Oct 2011 00:19:30 +0000 (00:19 +0000)]
Unreviewed rebaseline after r98293.

* platform/chromium-win/svg/filters/feColorMatrix-default-type-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMicrodata: Add itemprop, itemref, itemvalue attributes.
rniwa@webkit.org [Tue, 25 Oct 2011 00:13:34 +0000 (00:13 +0000)]
Microdata: Add itemprop, itemref, itemvalue attributes.
https://bugs.webkit.org/show_bug.cgi?id=69839

Patch by Arko Saha <arko@motorola.com> on 2011-10-24
Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/dom/MicroData/itemprop-add-remove-tokens.html
       fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html
       fast/dom/MicroData/itemprop-must-be-read-only.html
       fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html
       fast/dom/MicroData/itemref-add-remove-tokens.html
       fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html
       fast/dom/MicroData/itemref-for-an-element-must-be-correct.html
       fast/dom/MicroData/itemref-must-be-read-only.html
       fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html
       fast/dom/MicroData/itemvalue-reflects-href-attr.html
       fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html
       fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html
       fast/dom/MicroData/itemvalue-reflects-the-src-attr.html
       fast/dom/MicroData/itemvalue-returns-element-itself.html
       fast/dom/MicroData/itemvalue-returns-null.html
       fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html
       fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/JSHTMLElementCustom.cpp:
(WebCore::toJS):
(WebCore::JSHTMLElement::itemValue):
(WebCore::JSHTMLElement::setItemValue):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8HTMLElement::itemValueAccessorGetter):
(WebCore::V8HTMLElement::itemValueAccessorSetter):
* dom/MicroDataItemList.cpp:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::itemValueText):
(WebCore::HTMLAnchorElement::setItemValueText):
* html/HTMLAnchorElement.h:
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::itemValueText):
(WebCore::HTMLAreaElement::setItemValueText):
* html/HTMLAreaElement.h:
* html/HTMLAttributeNames.in:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::itemProp): Returns element's itemprop content attribute.
(WebCore::HTMLElement::setItemProp): Sets itemprop value on changing elemet's
itemprop attribute.
(WebCore::HTMLElement::itemRef): Returns element's itemref content attribute.
(WebCore::HTMLElement::setItemRef): Sets itemref value on changing elemet's
itemref attribute.
(WebCore::HTMLElement::setItemValue): Sets element's itemvalue. If the element has no
itemprop attribute or if element has an itemscope attribute, it throws INVALID_ACCESS_ERR
exception.
(WebCore::HTMLElement::itemValue): Returns the elements itemvalue.

If the element has no itemprop attribute it returns null.
If the element has an itemscope attribute, it returns the element itself.
If the element is a meta element: It acts as it would if it was reflecting the element's
content content attribute.
If the element is an audio, embed, iframe, img, source, track, or video element: It acts
as it would if it was reflecting the element's src content attribute.
If the element is an a, area, or link element: It act as it would if it was reflecting the
href content attribute.
If the element is an object element: It acts as  it would if it was reflecting the element's
data content attribute.

(WebCore::HTMLElement::itemValueText):
(WebCore::HTMLElement::setItemValueText):
* html/HTMLElement.h:
* html/HTMLElement.idl:
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::itemValueText):
(WebCore::HTMLEmbedElement::setItemValueText):
* html/HTMLEmbedElement.h:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::itemValueText):
(WebCore::HTMLIFrameElement::setItemValueText):
* html/HTMLIFrameElement.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::itemValueText):
(WebCore::HTMLImageElement::setItemValueText):
* html/HTMLImageElement.h:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::itemValueText):
(WebCore::HTMLLinkElement::setItemValueText):
* html/HTMLLinkElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::itemValueText):
(WebCore::HTMLMediaElement::setItemValueText):
* html/HTMLMediaElement.h:
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::itemValueText):
(WebCore::HTMLMetaElement::setItemValueText):
* html/HTMLMetaElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::itemValueText):
(WebCore::HTMLObjectElement::setItemValueText):
* html/HTMLObjectElement.h:
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::itemValueText):
(WebCore::HTMLSourceElement::setItemValueText):
* html/HTMLSourceElement.h:
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::itemValueText):
(WebCore::HTMLTrackElement::setItemValueText):
* html/HTMLTrackElement.h:
* html/MicroDataItemValue.cpp: Added.
(WebCore::MicroDataItemValue::MicroDataItemValue):
(WebCore::MicroDataItemValue::createFromString):
(WebCore::MicroDataItemValue::createFromNode):
* html/MicroDataItemValue.h: Added.
(WebCore::MicroDataItemValue::isNode):
(WebCore::MicroDataItemValue::getNode):
(WebCore::MicroDataItemValue::getString):

LayoutTests:

Added test-cases for Microdata itemprop, itemref, itemvalue attributes.

* fast/dom/MicroData/002-expected.txt:
* fast/dom/MicroData/002.html:
* fast/dom/MicroData/003-expected.txt:
* fast/dom/MicroData/003.html:
* fast/dom/MicroData/005-expected.txt:
* fast/dom/MicroData/005.html:
* fast/dom/MicroData/006-expected.txt:
* fast/dom/MicroData/009.html:
* fast/dom/MicroData/itemprop-add-remove-tokens-expected.txt: Added.
* fast/dom/MicroData/itemprop-add-remove-tokens.html: Added.
* fast/dom/MicroData/itemprop-for-an-element-must-be-correct-expected.txt: Added.
* fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html: Added.
* fast/dom/MicroData/itemprop-must-be-read-only-expected.txt: Added.
* fast/dom/MicroData/itemprop-must-be-read-only.html: Added.
* fast/dom/MicroData/itemprop-reflected-by-itemProp-property-expected.txt: Added.
* fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html: Added.
* fast/dom/MicroData/itemref-add-remove-tokens-expected.txt: Added.
* fast/dom/MicroData/itemref-add-remove-tokens.html: Added.
* fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property-expected.txt: Added.
* fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html: Added.
* fast/dom/MicroData/itemref-for-an-element-must-be-correct-expected.txt: Added.
* fast/dom/MicroData/itemref-for-an-element-must-be-correct.html: Added.
* fast/dom/MicroData/itemref-must-be-read-only-expected.txt: Added.
* fast/dom/MicroData/itemref-must-be-read-only.html: Added.
* fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element-expected.txt: Added.
* fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html: Added.
* fast/dom/MicroData/itemvalue-reflects-href-attr-expected.txt: Added.
* fast/dom/MicroData/itemvalue-reflects-href-attr.html: Added.
* fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element-expected.txt: Added.
* fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html: Added.
* fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element-expected.txt: Added.
* fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html: Added.
* fast/dom/MicroData/itemvalue-reflects-the-src-attr-expected.txt: Added.
* fast/dom/MicroData/itemvalue-reflects-the-src-attr.html: Added.
* fast/dom/MicroData/itemvalue-returns-element-itself-expected.txt: Added.
* fast/dom/MicroData/itemvalue-returns-element-itself.html: Added.
* fast/dom/MicroData/itemvalue-returns-null-expected.txt: Added.
* fast/dom/MicroData/itemvalue-returns-null.html: Added.
* fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001-expected.txt: Added.
* fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html: Added.
* fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002-expected.txt: Added.
* fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html: Added.
* fast/dom/MicroData/resources/microdata-common.js:
(createElement):
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoObject-or-other branch speculation may corrupt the state for OSR if the child of the
fpizlo@apple.com [Tue, 25 Oct 2011 00:00:14 +0000 (00:00 +0000)]
Object-or-other branch speculation may corrupt the state for OSR if the child of the
branch is an integer
https://bugs.webkit.org/show_bug.cgi?id=70777

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

LayoutTests:

* fast/js/dfg-other-branch-expected.txt: Added.
* fast/js/dfg-other-branch.html: Added.
* fast/js/script-tests/dfg-other-branch.js: Added.
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Mon, 24 Oct 2011 23:45:13 +0000 (23:45 +0000)]
Unreviewed gardening.

Bug 58013 has landed 3 months ago and it looks like the rebaseline was forgotten.
The new result is consistent with the other platforms.

* platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Removed.
* platform/chromium-win/fast/repaint/scale-page-shrink-expected.png: Added.
* platform/chromium-win/fast/repaint/scale-page-shrink-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoop_new_array_buffer is not inlined correctly
fpizlo@apple.com [Mon, 24 Oct 2011 23:22:39 +0000 (23:22 +0000)]
op_new_array_buffer is not inlined correctly
https://bugs.webkit.org/show_bug.cgi?id=70770

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Disabled inlining of op_new_array_buffer, for now.

* dfg/DFGCapabilities.h:
(JSC::DFG::canInlineOpcode):

LayoutTests:

Reviewed by Oliver Hunt.

* fast/js/dfg-inline-new-array-buffer-expected.txt: Added.
* fast/js/dfg-inline-new-array-buffer.html: Added.
* fast/js/script-tests/dfg-inline-new-array-buffer.js: Added.
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused instance variable
joepeck@webkit.org [Mon, 24 Oct 2011 23:03:14 +0000 (23:03 +0000)]
Remove unused instance variable
https://bugs.webkit.org/show_bug.cgi?id=70750

Reviewed by Dimitri Glazkov.

* rendering/RenderTextControl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium/mac] Fix an ODR violation.
thakis@chromium.org [Mon, 24 Oct 2011 23:02:05 +0000 (23:02 +0000)]
[chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753

Reviewed by Anders Carlsson.

Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofeColorMatrix doesn't use the correct default "matrix" type when no type attribute...
timothy_horton@apple.com [Mon, 24 Oct 2011 22:56:01 +0000 (22:56 +0000)]
feColorMatrix doesn't use the correct default "matrix" type when no type attribute is specified
https://bugs.webkit.org/show_bug.cgi?id=70035
<rdar://problem/10280177>

Reviewed by Nikolas Zimmermann.

Make feColorMatrix's type attribute be "matrix" by default.

Test: svg/filters/feColorMatrix-default-type.svg

* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Build fix. Rename all instances of a variable when it gets changed
commit-queue@webkit.org [Mon, 24 Oct 2011 22:51:51 +0000 (22:51 +0000)]
[EFL] Build fix. Rename all instances of a variable when it gets changed
https://bugs.webkit.org/show_bug.cgi?id=70732

Unreviewed build fix.

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-24

* ewk/ewk_js.cpp:
(ewk_js_property_set): s/obj/object/
* ewk/ewk_view.cpp:
(ewk_view_js_object_add): s/exec/executeState/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd boolean speculations to DFG JIT 32_64
commit-queue@webkit.org [Mon, 24 Oct 2011 22:51:25 +0000 (22:51 +0000)]
Add boolean speculations to DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=70706

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Filip Pizlo.

Different from the boolean speculations in DFG 64, the boolean
speculations in DFG 32_64 will use a 32bit GPR to hold the primitive
boolean instead of a JSBoolean. This choice is not only for
performance, but also to save a register as we're short of registers on
X86.
To accomplish this we make use of DataFormatBoolean, allow a value to
be represented as a primitive boolean and converted from/to a
JSBoolean.
This patch also fixes SpillOrder in 32_64, which should be different
from 64, and fixes needDataFormatConversion logic in 32_64.

* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchTest32):
    We don't expect byte test actually as it doesn't work for registers
    esp..edi on X86.
* dfg/DFGGenerationInfo.h:
(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::gpr):
(JSC::DFG::GenerationInfo::fillInteger):
(JSC::DFG::GenerationInfo::fillBoolean):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::checkConsistency):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::cellResult):
(JSC::DFG::booleanResult):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedBoolean):
(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::gpr):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Build fix. Add include path to find npapi.h
commit-queue@webkit.org [Mon, 24 Oct 2011 22:49:26 +0000 (22:49 +0000)]
[EFL] Build fix. Add include path to find npapi.h
https://bugs.webkit.org/show_bug.cgi?id=70730

Unreviewed build fix.

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-24

* DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnbreak binding generation tests
tony@chromium.org [Mon, 24 Oct 2011 22:39:16 +0000 (22:39 +0000)]
Unbreak binding generation tests
https://bugs.webkit.org/show_bug.cgi?id=70768

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-24
Reviewed by Darin Adler.

Update the expected output of V8 binding tests to match
results c/o https://bugs.webkit.org/show_bug.cgi?id=70065

* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::idbKeyCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPlugin tests are failing after switching WK2 to NRWT
eric@webkit.org [Mon, 24 Oct 2011 22:26:06 +0000 (22:26 +0000)]
Plugin tests are failing after switching WK2 to NRWT
https://bugs.webkit.org/show_bug.cgi?id=70760

Reviewed by Simon Fraser.

Perpetuate this horrible hack.

* Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding Chromium expectations from http://trac.webkit.org/changeset/98263
leviw@chromium.org [Mon, 24 Oct 2011 22:19:32 +0000 (22:19 +0000)]
Adding Chromium expectations from trac.webkit.org/changeset/98263

Unreviewed.

* platform/chromium-cg-mac-snowleopard/svg/as-object: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/chromium-linux-x86/svg/as-object: Removed.
* platform/chromium-linux/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-object: Added.
* platform/chromium-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixing a collision in Mac results and adding qt results from http://trac.webkit.org...
leviw@chromium.org [Mon, 24 Oct 2011 22:15:51 +0000 (22:15 +0000)]
Fixing a collision in Mac results and adding qt results from trac.webkit.org/changeset/98263

Unreviewed test expectations update.

* platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Fixing collision that removes
an empty text node.
* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-actual.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHook up minimalist load delegate to WKBrowsingContextController
weinig@apple.com [Mon, 24 Oct 2011 22:07:24 +0000 (22:07 +0000)]
Hook up minimalist load delegate to WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70764

Reviewed by Simon Fraser.

* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController setLoadDelegate:]):
Add loadDelegate getter/setter. As per convention, the delegate is not
retained.

(didStartProvisionalLoadForFrame):
(didCommitLoadForFrame):
(didFinishLoadForFrame):
(setUpPageLoaderClient):
(-[WKBrowsingContextController initWithPageRef:]):
Hookup the delegate to a WKPageLoaderClient.

* UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Added.
Add load delegate as a proper protocol.

* WebKit2.xcodeproj/project.pbxproj:
Add new file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r98266.
commit-queue@webkit.org [Mon, 24 Oct 2011 21:58:41 +0000 (21:58 +0000)]
Unreviewed, rolling out r98266.
http://trac.webkit.org/changeset/98266
https://bugs.webkit.org/show_bug.cgi?id=70767

Broke the chromium build. (Requested by dave_levin on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-24

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add isTraceEventEnabled to PlatformSupport.
nduca@chromium.org [Mon, 24 Oct 2011 21:19:24 +0000 (21:19 +0000)]
[chromium] Add isTraceEventEnabled to PlatformSupport.
https://bugs.webkit.org/show_bug.cgi?id=70618

Reviewed by Darin Fisher.

Source/WebCore:

* platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

* public/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::isTraceEventEnabled):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::isTraceEventEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse StringBuilder in CSSRuleList::rulesText()/CSSSelectorList::selectorsText()
mihnea@adobe.com [Mon, 24 Oct 2011 21:01:24 +0000 (21:01 +0000)]
Use StringBuilder in CSSRuleList::rulesText()/CSSSelectorList::selectorsText()
https://bugs.webkit.org/show_bug.cgi?id=70746

Reviewed by Tony Chang.

Covered by existing tests.

* css/CSSRuleList.cpp:
(WebCore::CSSRuleList::rulesText):
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::selectorsText):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::cssText): Use CSSRuleList::rulesText() method instead of explicit loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit doesn't build with recent changes to libdispatch
msaboff@apple.com [Mon, 24 Oct 2011 20:57:59 +0000 (20:57 +0000)]
WebKit doesn't build with recent changes to libdispatch
https://bugs.webkit.org/show_bug.cgi?id=70737

Source/WebCore:

Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue.  Changed MemoryPressureHandler::install
to use new function.

Reviewed by Geoffrey Garen.

No new tests.  Moved functionality to WebKitSystemInterface.

* WebCore.exp.in:
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::install):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue.

Reviewed by Geoffrey Garen.

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue.

Reviewed by Geoffrey Garen.

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNRWT doesn't support ORWT's --root option, but should
eric@webkit.org [Mon, 24 Oct 2011 20:54:14 +0000 (20:54 +0000)]
NRWT doesn't support ORWT's --root option, but should
https://bugs.webkit.org/show_bug.cgi?id=70416

Reviewed by Dirk Pranke.

Add support for ORWT's --root option which is used for
running tests with a nightly build of WebKit.

* Scripts/old-run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/base.py:
 - webkit_build_path was never called by any code, removed.
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Throw DATA_ERR on invalid keys, remove null key support
commit-queue@webkit.org [Mon, 24 Oct 2011 20:51:02 +0000 (20:51 +0000)]
IndexedDB: Throw DATA_ERR on invalid keys, remove null key support
https://bugs.webkit.org/show_bug.cgi?id=70065

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-24
Reviewed by Tony Chang.

Source/WebCore:

Part 1 of a two-sided commit. Renames IDBKey::NullType to
IDBKey::InvalidType. JS binding yields this type rather
than throwing immediately so the correct exception type can
be raised. Checks for invalid keys added to front-end classes.

* bindings/js/JSIDBKeyCustom.cpp:
(WebCore::toJS):
* bindings/scripts/CodeGeneratorV8.pm:
(TypeCanFailConversion):
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::continueFunction):
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::cmp):
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
* storage/IDBKey.cpp:
(WebCore::IDBKey::IDBKey):
(WebCore::IDBKey::compare):
* storage/IDBKey.h:
(WebCore::IDBKey::createInvalid):
* storage/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::only):
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):
* storage/IDBKeyRange.h:
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):
* storage/IDBKeyRange.idl:
* storage/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
* storage/IDBSQLiteBackingStore.cpp:
(WebCore::whereSyntaxForKey):
(WebCore::bindKeyToQuery):
(WebCore::lowerCursorWhereFragment):
(WebCore::upperCursorWhereFragment):
(WebCore::bindKeyToQueryWithNulls):
(WebCore::keyFromQuery):

Source/WebKit/chromium:

Part 1 of a two-sided commit. Renames IDBKey::NullType to
IDBKey::InvalidType. JS binding yields this type rather
than throwing immediately so the correct exception type can
be raised. Checks for invalid keys added to front-end classes.

* src/AssertMatchingEnums.cpp:
* src/WebIDBKey.cpp:
(WebKit::WebIDBKey::assignNull):

LayoutTests:

Updated expectations now that most tests match spec. Includes change to
objectstore-basics test to avoid hitting https://bugs.webkit.org/show_bug.cgi?id=70041
since this CL stops hiding that bug.

* storage/indexeddb/factory-cmp-expected.txt:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
* storage/indexeddb/open-cursor-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Make accelerated drawing work with threaded compositing
alokp@chromium.org [Mon, 24 Oct 2011 20:48:33 +0000 (20:48 +0000)]
[chromium] Make accelerated drawing work with threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=70656

Reviewed by James Robinson.

Make sure that the compositor context is not used outside LayerTextureUpdater::updateTextureRect().
Created a FrameBuffer class that wraps skia gpu canvas and manages GL resources.

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixing Windows build
mhahnenberg@apple.com [Mon, 24 Oct 2011 20:47:45 +0000 (20:47 +0000)]
Fixing Windows build

Unreviewed build fix

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize Node::isInShadowTree to execute in constant-time
adamk@chromium.org [Mon, 24 Oct 2011 20:41:33 +0000 (20:41 +0000)]
Optimize Node::isInShadowTree to execute in constant-time
https://bugs.webkit.org/show_bug.cgi?id=67686

Reviewed by Dimitri Glazkov.

No expected change in behavior, so no new tests.

* dom/Node.cpp:
(WebCore::Node::isInShadowTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSome more fixups from http://trac.webkit.org/changeset/98265.
ojan@chromium.org [Mon, 24 Oct 2011 20:40:28 +0000 (20:40 +0000)]
Some more fixups from trac.webkit.org/changeset/98265.

The leopard bot results are incorrect, but that's because the
chromium leopard bots have not compiled in a few days. Once
the bots are fixed, we'll need to rebaseline this test again for
leopard.

* platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
* platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Expose WebThread::postDelayedTask to CCThread
nduca@chromium.org [Mon, 24 Oct 2011 20:11:56 +0000 (20:11 +0000)]
[chromium] Expose WebThread::postDelayedTask to CCThread
https://bugs.webkit.org/show_bug.cgi?id=70712

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCThread.h:

Source/WebKit/chromium:

* src/CCThreadImpl.cpp:
(WebKit::CCThreadImpl::postDelayedTask):
* src/CCThreadImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd URL getters for the WKBrowsingContextController
weinig@apple.com [Mon, 24 Oct 2011 19:55:26 +0000 (19:55 +0000)]
Add URL getters for the WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70752

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
(autoreleased):
Added helpers for autoreleasing.

(-[WKBrowsingContextController activeURL]):
Added buy not implemented yet.

(-[WKBrowsingContextController pendingURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController commitedURL]):
(-[WKBrowsingContextController unreachableURL]):
Added getters.

(-[WKBrowsingContextController title]):
Convert to new autoreleased helper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Manage webkit_unit_tests TestSuite lifetime explicitly in DLL build
nduca@chromium.org [Mon, 24 Oct 2011 19:53:07 +0000 (19:53 +0000)]
[chromium] Manage webkit_unit_tests TestSuite lifetime explicitly in DLL build
https://bugs.webkit.org/show_bug.cgi?id=70688

Reviewed by Tony Chang.

* tests/RunAllTests.cpp:
(main):
* tests/WebUnitTests.cpp:
(WebKit::InitTestSuite):
(WebKit::RunAllUnitTests):
(WebKit::DeleteTestSuite):
* tests/WebUnitTests.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBitVector isInline check could fail
commit-queue@webkit.org [Mon, 24 Oct 2011 19:41:29 +0000 (19:41 +0000)]
BitVector isInline check could fail
https://bugs.webkit.org/show_bug.cgi?id=70691

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Geoffrey Garen.

Current BitVector uses the highest bit of m_bitsOrPointer to indicate
whether it's an inlined bit set or a pointer to an outOfLine bit set.
This check may fail in case the pointer also has the highest bit set,
which is surely possible on IA32 (Linux).
In this case the check failure can result in unexpected behaviors,
for example if the BitVector is incorrectly determined as having an
inlined bit set, then setting a bit exceeding maxInlineBits will wrongly
modify the memory adjacent to the BitVector object.
This fix is to use the lowest bit of m_bitsOrPointer to indicate inline
or outofline, based on the assumption that the pointer to OutOfLineBits
should be 4 or 8 byte aligned.
We could mark the lowest bit (bit 0) with 1 for inlined bit set,
and bits 1~bitsInPointer are used for bit set/test.
In this case we need do one bit more shift for bit set/test.

* wtf/BitVector.cpp:
(WTF::BitVector::resizeOutOfLine):
* wtf/BitVector.h:
(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::isInline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rebaseline of svg/W3C-SVG-1.1-SE/coords-units-03-b.html
jchaffraix@webkit.org [Mon, 24 Oct 2011 19:40:54 +0000 (19:40 +0000)]
Unreviewed rebaseline of svg/W3C-SVG-1.1-SE/coords-units-03-b.html

The new baselines all match the existing ones. Not sure if we really pass the test as
2 lines should be 200px but at least all the baselines are consistent (within some font
differences).

* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE: Added.
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
* platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
* platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
* svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable MEDIA_SOURCE feature for Chromium
commit-queue@webkit.org [Mon, 24 Oct 2011 19:29:05 +0000 (19:29 +0000)]
Enable MEDIA_SOURCE feature for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70745

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-10-24
Reviewed by David Levin.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleanup some test expectations missed in r98183.
ojan@chromium.org [Mon, 24 Oct 2011 19:22:56 +0000 (19:22 +0000)]
Cleanup some test expectations missed in r98183.

* platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt: Removed.
* platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt: Removed.
* platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt.
* platform/chromium/fast/writing-mode/fallback-orientation-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocheck-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
levin@chromium.org [Mon, 24 Oct 2011 19:02:21 +0000 (19:02 +0000)]
check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
https://bugs.webkit.org/show_bug.cgi?id=70747

Reviewed by Tony Chang.

* Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<svg> fails to use explicit width and height inside <html> inside IFRAME
leviw@chromium.org [Mon, 24 Oct 2011 18:56:16 +0000 (18:56 +0000)]
<svg> fails to use explicit width and height inside <html> inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

* platform/chromium/test_expectations.txt: Will update with results on other platforms.
* platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
* svg/as-object/svg-embedded-in-html-in-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98263 268f45cc-cd09-0410-ab3c-d52691b4dbfc