darin@apple.com [Fri, 24 Dec 2010 19:26:23 +0000 (19:26 +0000)]
Updated makefiles used by Apple engineers to fix build with the
new JavaScriptGlue location.
* Makefile: Told this to build JavaScriptGlue. Some day we might
want it to descend into Sources instead and use the Makefile there,
but there are problems with sequencing the project builds, so that
can wait.
* Sources/Makefile.shared: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 24 Dec 2010 19:02:25 +0000 (19:02 +0000)]
2010-12-24 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Show current time / total in media player
https://bugs.webkit.org/show_bug.cgi?id=51535
* css/mediaControlsGtk.css:
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::formatMediaControlsCurrentTime):
(WebCore::RenderThemeGtk::paintMediaCurrentTime):
* platform/gtk/RenderThemeGtk.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 24 Dec 2010 18:55:35 +0000 (18:55 +0000)]
2010-12-24 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Eric Seidel.
Clean up CSSRuleData in CSSStyleSelector.h
https://bugs.webkit.org/show_bug.cgi?id=27753
Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.
* css/CSSStyleSelector.cpp:
(WebCore::CSSRuleData::CSSRuleData):
(WebCore::CSSRuleData::~CSSRuleData):
(WebCore::CSSRuleData::position):
(WebCore::CSSRuleData::rule):
(WebCore::CSSRuleData::selector):
(WebCore::CSSRuleData::next):
(WebCore::CSSRuleDataList::CSSRuleDataList):
(WebCore::CSSRuleDataList::~CSSRuleDataList):
(WebCore::CSSRuleDataList::first):
(WebCore::CSSRuleDataList::last):
(WebCore::CSSRuleDataList::append):
* css/CSSStyleSelector.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 24 Dec 2010 18:54:17 +0000 (18:54 +0000)]
Skip the new editing/input/ime-composition-clearpreedit.html test since textInputController
is unimplemented in the DRT for Windows. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=32021
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 24 Dec 2010 18:43:36 +0000 (18:43 +0000)]
2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Screen doesn't be rendered when changing size of EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=43528
Remove on_resize because ewk_view_fixed_layout_size_set should not be
called on callback of EVAS_CALLBACK_RESIZE. As it change size of
FrameView, rendering was ignored when _ewk_view_smart_calculate was
called.
* EWebLauncher/main.c:
(browserCreate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 24 Dec 2010 18:21:28 +0000 (18:21 +0000)]
2010-12-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
https://bugs.webkit.org/show_bug.cgi?id=28291
This is a start. At least now webkit-patch will prompt when your ChangeLog looks questionable.
We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
to strings with find in the diff.
Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
* Scripts/webkitpy/common/checkout/api.py:
* Scripts/webkitpy/common/checkout/diff_parser.py:
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
* Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
* Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
* Scripts/webkitpy/tool/steps/validatereviewer.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 24 Dec 2010 18:20:32 +0000 (18:20 +0000)]
2010-12-24 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix compilation on Windows.
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::~InspectorStyle): added explicit empty destructor
* inspector/InspectorStyleSheet.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 24 Dec 2010 17:51:25 +0000 (17:51 +0000)]
2010-12-24 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Darin Adler.
inspector/debugger-step-out.html crashing intermittently in the bots
https://bugs.webkit.org/show_bug.cgi?id=50868
Use RefPtr rather instead of raw pointers when keeping references
to refcounted objects.
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStylesForNode2):
(WebCore::InspectorCSSAgent::getComputedStyleForNode2):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::create):
(WebCore::InspectorStyle::InspectorStyle):
(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::toggleProperty):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyle::populateAllProperties):
(WebCore::InspectorStyle::replacePropertyInStyleText):
(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
* inspector/InspectorStyleSheet.h:
(WebCore::InspectorStyle::cssStyle):
(WebCore::InspectorStyleSheet::pageStyleSheet):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Fri, 24 Dec 2010 17:31:15 +0000 (17:31 +0000)]
2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486
Test: svg/custom/use-instanceRoot-with-use-removed.svg
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::clearUseElement):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::removedFromDocument):
(WebCore::ShadowTreeUpdateBlocker::if):
(WebCore::SVGUseElement::detachInstance):
(WebCore::SVGUseElement::detach):
* svg/SVGUseElement.h:
2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486
* svg/custom/use-instanceRoot-with-use-removed-expected.txt: Added.
* svg/custom/use-instanceRoot-with-use-removed.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 24 Dec 2010 17:01:04 +0000 (17:01 +0000)]
2010-12-23 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Missing Localized Strings
https://bugs.webkit.org/show_bug.cgi?id=51542
Added missing strings: "WebSocket", "Frames", "Text", "Transfer",
"Preserve Log upon Navigation", and "Go to Line".
* English.lproj/localizedStrings.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 24 Dec 2010 16:39:32 +0000 (16:39 +0000)]
2010-12-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Inline HTML style property out of sync with element.style in Sidebar
https://bugs.webkit.org/show_bug.cgi?id=51478
Now the element attribute modifications (including "style") are tracked, which results in the
source offsets update (in the backend) and Styles/Metrics pane updates (in the frontend)
on the "style" attribute modification through the Elements tree. Also, it appears that
a complete "style" attribute removal destroys the inline style declaration
(StyledElement::m_inlineStyleDecl), while the code used to rely on it being immutable (hence a crash).
Test: inspector/elements-delete-inline-style.html
WebCore:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didModifyDOMAttr):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didModifyDOMAttr):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
(WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
(WebCore::InspectorStyleSheetForInlineStyle::text):
(WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
LayoutTests:
* http/tests/inspector/inspector-test2.js:
(initialize_InspectorTest.InspectorTest.addResults):
(initialize_InspectorTest.InspectorTest.createKeyEvent):
* inspector/elements-delete-inline-style-expected.txt: Added.
* inspector/elements-delete-inline-style.html: Added.
* inspector/elements-tests2.js: Added.
(initialize_ElementTest.InspectorTest.expandDOMSubtree.processChildren):
(initialize_ElementTest.InspectorTest.expandDOMSubtree):
(initialize_ElementTest.InspectorTest.expandDOMSubtreeAndRun):
(initialize_ElementTest.InspectorTest.nodeForId):
(initialize_ElementTest.InspectorTest.selectElementAndRun):
(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):
(initialize_ElementTest.InspectorTest.getSelectedElementStyles):
(initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem):
(initialize_ElementTest.InspectorTest.dumpStyleTreeOutline):
(initialize_ElementTest.InspectorTest.dumpStyleTreeItem):
(initialize_ElementTest):
* inspector/styles-add-blank-property.html: Remove unnecessary function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 24 Dec 2010 12:18:04 +0000 (12:18 +0000)]
2010-12-24 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
editing/selection/caret-* tests need rebaseline for gtk
https://bugs.webkit.org/show_bug.cgi?id=51578
Rebaseline editing/selection/caret-* tests for gtk.
* platform/gtk/editing/selection/caret-ltr-2-expected.checksum: Added.
* platform/gtk/editing/selection/caret-ltr-2-expected.png: Added.
* platform/gtk/editing/selection/caret-ltr-2-expected.txt: Added.
* platform/gtk/editing/selection/caret-ltr-2-left-expected.checksum: Added.
* platform/gtk/editing/selection/caret-ltr-2-left-expected.png: Added.
* platform/gtk/editing/selection/caret-ltr-2-left-expected.txt: Added.
* platform/gtk/editing/selection/caret-ltr-expected.checksum: Added.
* platform/gtk/editing/selection/caret-ltr-expected.png: Added.
* platform/gtk/editing/selection/caret-ltr-expected.txt: Added.
* platform/gtk/editing/selection/caret-ltr-right-expected.checksum: Added.
* platform/gtk/editing/selection/caret-ltr-right-expected.png: Added.
* platform/gtk/editing/selection/caret-ltr-right-expected.txt: Added.
* platform/gtk/editing/selection/caret-rtl-2-left-expected.checksum: Added.
* platform/gtk/editing/selection/caret-rtl-2-left-expected.png: Added.
* platform/gtk/editing/selection/caret-rtl-2-left-expected.txt: Added.
* platform/gtk/editing/selection/caret-rtl-right-expected.checksum: Added.
* platform/gtk/editing/selection/caret-rtl-right-expected.png: Added.
* platform/gtk/editing/selection/caret-rtl-right-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 24 Dec 2010 12:12:30 +0000 (12:12 +0000)]
2010-12-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by Kenneth Russell.
Modify new-run-webkit-tests to shut up and exit when all the threads
are wedged so that test runs complete faster and we don't end up
w/ enormous log files.
https://bugs.webkit.org/show_bug.cgi?id=51572
* Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
* Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 24 Dec 2010 12:05:55 +0000 (12:05 +0000)]
2010-12-24 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Andreas Kling.
[chromium] Fix a style nit in the JPEG encoder
https://bugs.webkit.org/show_bug.cgi?id=51574
* platform/image-encoders/skia/JPEGImageEncoder.cpp: nit begone.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 24 Dec 2010 12:02:31 +0000 (12:02 +0000)]
2010-12-23 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Maciej Stachowiak.
Web Inspector: CSS shorthand properties expand unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=36304
"border-radius" is a shorthand property that has a "non-standard" format and longhands, see
http://www.w3.org/TR/css3-background/#border-radius for reference. CSSParser does not use the
standard parseShorthand() or parse4Values() methods but instead a custom parseBorderRadius() method.
This method didn't use to create a ShorthandScope instance and set the m_implicitShorthand value
appropriately when adding implicit longhands, thus they were added as normal properties
found in the CSS (neither implicit, nor longhands). This is now fixed.
WebCore:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseBorderRadius):
LayoutTests:
* inspector/elements-panel-styles-expected.txt:
* inspector/resources/elements-panel-styles.css:
(.foo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Fri, 24 Dec 2010 11:54:24 +0000 (11:54 +0000)]
2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=51576
* svg/custom/animate-disallowed-use-element-expected.txt: Added.
* svg/custom/animate-disallowed-use-element.svg: Added.
2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=51576
Disallowed elements may be pruned from the shadow tree, leaving a null
shadowTreeElement. We should check for that before setting attributes.
Test: svg/custom/animate-disallowed-use-element.svg
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
evan@chromium.org [Fri, 24 Dec 2010 11:50:34 +0000 (11:50 +0000)]
2010-12-24 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
TextMetrics::width is an integer, but the member is a float
https://bugs.webkit.org/show_bug.cgi?id=51566
Change the return type to a float.
No tests, fixing a compiler warning.
(I was unable to produce a difference in the values exposed to pages
with a float versus the previous conversion to an integer.)
* html/TextMetrics.h:
(WebCore::TextMetrics::width):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Fri, 24 Dec 2010 11:47:27 +0000 (11:47 +0000)]
2010-12-24 Andrei Popescu <andreip@google.com>
Unreviewed build fix.
Add Chromium-mac test expectation for the layout test below.
[Chromium] http/tests/xmlhttprequest/basic-auth-nopassword.html needs Mac specific test expectations
https://bugs.webkit.org/show_bug.cgi?id=51589
* platform/chromium-mac/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 24 Dec 2010 11:27:55 +0000 (11:27 +0000)]
2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125
Add ENABLE_TOUCH_EVENTS option.
* cmake/OptionsEfl.cmake:
* cmakeconfig.h.cmake:
2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125
Add files for EFL to support TOUCH_EVENTS.
* CMakeLists.txt:
* CMakeListsEfl.txt:
* platform/PlatformTouchEvent.h: Add EFL related constructor.
* platform/PlatformTouchPoint.h: ditto.
* platform/efl/PlatformTouchEventEfl.cpp: Added.
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
* platform/efl/PlatformTouchPointEfl.cpp: Added.
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125
Implement ewk_frame_feed_touch_event to feed touch events. Because EFL
doesn't have touch events, Application should generate and pass it.
* WebCoreSupport/ChromeClientEfl.h:
(WebCore::ChromeClientEfl::needTouchEvents):
* ewk/ewk_frame.cpp:
(ewk_frame_feed_touch_event):
* ewk/ewk_frame.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Fri, 24 Dec 2010 11:23:17 +0000 (11:23 +0000)]
2010-12-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension()
https://bugs.webkit.org/show_bug.cgi?id=51457
WebKit EFL can't play html5 audio because of wrong mime type checking.
So, 'application/octet-stream' is changed with an empty string.
* platform/efl/MIMETypeRegistryEfl.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
Returns an empty string instead of application/octet-stream when it can't find proper mime type.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Fri, 24 Dec 2010 11:09:12 +0000 (11:09 +0000)]
2010-12-24 Andrei Popescu <andreip@google.com>
Unreviewed. Update Chromium test expectations.
Mark editing/input/ime-composition-clearpreedit.html.html as TEXT.
This test was added in http://trac.webkit.org/changeset/74605 and
fails in Chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 24 Dec 2010 11:05:21 +0000 (11:05 +0000)]
2010-12-24 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
commit-queue should better explain how it will re-open bugs and follow duplicate chains
https://bugs.webkit.org/show_bug.cgi?id=51549
I've had multiple people ask me about the commit-queue's behavior
regarding reporting flaky tests. I figured it would be best to just
have the queue explain itself in the bugs it files.
* Scripts/webkitpy/tool/bot/flakytestreporter.py:
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Fri, 24 Dec 2010 10:38:53 +0000 (10:38 +0000)]
2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
SVGFontFaceElement::rebuildFontFace() should exit when not in document
https://bugs.webkit.org/show_bug.cgi?id=51571
* svg/custom/use-invalid-font-face-expected.txt: Added.
* svg/custom/use-invalid-font-face.svg: Added.
2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
SVGFontFaceElement::rebuildFontFace() should exit when not in document
https://bugs.webkit.org/show_bug.cgi?id=51571
We were hitting a NULL deref crash. Since most of the callers checked
inDocument() anyway, I moved it into the start of rebuildFontFace.
Test: svg/custom/use-invalid-font-face.svg
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::parseMappedAttribute):
(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::childrenChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Fri, 24 Dec 2010 10:19:04 +0000 (10:19 +0000)]
2010-12-24 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
https://bugs.webkit.org/show_bug.cgi?id=51467
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 24 Dec 2010 10:12:24 +0000 (10:12 +0000)]
2010-12-21 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[GTK] minimal build with --database fails
https://bugs.webkit.org/show_bug.cgi?id=51394
* webkit/webkitprivate.cpp:
(webkit_init): Use cacheStorage() only if the
OFFLINE_WEB_APPLICATIONS feature is enabled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Fri, 24 Dec 2010 10:00:08 +0000 (10:00 +0000)]
2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Remove unnecessary check in CSSCanvasValue::canvasDestroyed().
https://bugs.webkit.org/show_bug.cgi?id=51564
This check was duplicating an ASSERT for a case fixed in r73927.
Now that the bug is fixed the check is no longer necessary.
Removing dead code, so no new tests needed.
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::canvasDestroyed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 24 Dec 2010 09:01:54 +0000 (09:01 +0000)]
Move JavaScriptGlue into Sources
https://bugs.webkit.org/show_bug.cgi?id=51583
Rubber-stamped by Eric Seidel.
Actually perform the move.
* JavaScriptGlue: Removed.
* JavaScriptGlue/Configurations: Removed.
* JavaScriptGlue/Configurations/Base.xcconfig: Removed.
* JavaScriptGlue/Configurations/DebugRelease.xcconfig: Removed.
* JavaScriptGlue/Configurations/JavaScriptGlue.xcconfig: Removed.
* JavaScriptGlue/Configurations/Version.xcconfig: Removed.
* JavaScriptGlue/English.lproj: Removed.
* JavaScriptGlue/English.lproj/InfoPlist.strings: Removed.
* JavaScriptGlue/ForwardingHeaders: Removed.
* JavaScriptGlue/ForwardingHeaders/masm: Removed.
* JavaScriptGlue/ForwardingHeaders/masm/X86Assembler.h: Removed.
* JavaScriptGlue/ForwardingHeaders/profiler: Removed.
* JavaScriptGlue/ForwardingHeaders/profiler/Profiler.h: Removed.
* JavaScriptGlue/ForwardingHeaders/runtime: Removed.
* JavaScriptGlue/ForwardingHeaders/runtime/CallFrame.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ASCIICType.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/AlwaysInline.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Assertions.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Atomics.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Bitmap.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/BumpPointerAllocator.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/CrossThreadRefCounted.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/CurrentTime.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/DateInstanceCache.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/DateMath.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/FastAllocBase.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/FixedArray.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Forward.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashCountedSet.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashFunctions.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashMap.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashSet.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashTraits.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ListHashSet.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ListRefPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Locker.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/MainThread.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/MathExtras.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Noncopyable.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/NotFound.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OSAllocator.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnArrayPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnPtrCommon.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PageAllocation.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PageAllocationAligned.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PageBlock.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PageReservation.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PassOwnArrayPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PassOwnPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Platform.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PossiblyNull.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PtrAndFlags.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/RandomNumber.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/StackBounds.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/StdLibExtras.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/StringHasher.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ThreadSpecific.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Threading.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ThreadingPrimitives.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/UnusedParam.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/VMTags.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ValueCheck.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Vector.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/VectorTraits.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/WTFThreadData.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/CString.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/StringHash.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/StringImpl.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/StringImplBase.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/TextPosition.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/WTFString.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/unicode: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/unicode/Unicode.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/unicode/icu: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h: Removed.
* JavaScriptGlue/Info.plist: Removed.
* JavaScriptGlue/JSBase.cpp: Removed.
* JavaScriptGlue/JSBase.h: Removed.
* JavaScriptGlue/JSObject.cpp: Removed.
* JavaScriptGlue/JSObject.h: Removed.
* JavaScriptGlue/JSRun.cpp: Removed.
* JavaScriptGlue/JSRun.h: Removed.
* JavaScriptGlue/JSUtils.cpp: Removed.
* JavaScriptGlue/JSUtils.h: Removed.
* JavaScriptGlue/JSValueWrapper.cpp: Removed.
* JavaScriptGlue/JSValueWrapper.h: Removed.
* JavaScriptGlue/JavaScriptGlue.cpp: Removed.
* JavaScriptGlue/JavaScriptGlue.exp: Removed.
* JavaScriptGlue/JavaScriptGlue.h: Removed.
* JavaScriptGlue/JavaScriptGlue.xcodeproj: Removed.
* JavaScriptGlue/JavaScriptGlue.xcodeproj/project.pbxproj: Removed.
* JavaScriptGlue/LICENSE: Removed.
* JavaScriptGlue/Makefile: Removed.
* JavaScriptGlue/UserObjectImp.cpp: Removed.
* JavaScriptGlue/UserObjectImp.h: Removed.
* JavaScriptGlue/config.h: Removed.
* JavaScriptGlue/icu: Removed.
* JavaScriptGlue/icu/LICENSE: Removed.
* JavaScriptGlue/icu/README: Removed.
* JavaScriptGlue/icu/unicode: Removed.
* JavaScriptGlue/icu/unicode/platform.h: Removed.
* JavaScriptGlue/icu/unicode/putil.h: Removed.
* JavaScriptGlue/icu/unicode/uchar.h: Removed.
* JavaScriptGlue/icu/unicode/ucnv.h: Removed.
* JavaScriptGlue/icu/unicode/ucnv_err.h: Removed.
* JavaScriptGlue/icu/unicode/uconfig.h: Removed.
* JavaScriptGlue/icu/unicode/uenum.h: Removed.
* JavaScriptGlue/icu/unicode/uiter.h: Removed.
* JavaScriptGlue/icu/unicode/umachine.h: Removed.
* JavaScriptGlue/icu/unicode/urename.h: Removed.
* JavaScriptGlue/icu/unicode/ustring.h: Removed.
* JavaScriptGlue/icu/unicode/utf.h: Removed.
* JavaScriptGlue/icu/unicode/utf16.h: Removed.
* JavaScriptGlue/icu/unicode/utf8.h: Removed.
* JavaScriptGlue/icu/unicode/utf_old.h: Removed.
* JavaScriptGlue/icu/unicode/utypes.h: Removed.
* JavaScriptGlue/icu/unicode/uversion.h: Removed.
* JavaScriptGlue/testjsglue.cpp: Removed.
* Makefile:
* Sources: Added.
* Sources/JavaScriptGlue: Copied from JavaScriptGlue.
* Sources/Makefile: Added.
Tools:
These tools refer to JavaScriptGlue and need to be updated to its new
location.
* Scripts/build-webkit:
* Scripts/do-file-rename:
* Scripts/do-webcore-rename:
* Scripts/webkitpy/common/config/build.py:
* Scripts/webkitpy/common/config/build_unittest.py:
Websites/bugs.webkit.org:
PrettyPatch keeps a list of the top-level directories that exist in
trac.
* PrettyPatch/PrettyPatch.rb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 24 Dec 2010 08:06:49 +0000 (08:06 +0000)]
2010-12-24 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
[WINCE] Add CPU(MIPS) detection
https://bugs.webkit.org/show_bug.cgi?id=51342
WinCE usually defines MIPS and _MIPS_.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Fri, 24 Dec 2010 06:14:39 +0000 (06:14 +0000)]
2010-12-23 Lucas Forschler <lforschler@apple.com>
Reviewed by Eric Seidel.
Bug 51539 - update iexploder scripts to point to new location
* Scripts/run-iexploder-tests:
* Scripts/update-iexploder-cssproperties:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 24 Dec 2010 06:11:19 +0000 (06:11 +0000)]
Make dragging work again after r74591.
Reviewed by Sam Weinig.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Fixed a typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Fri, 24 Dec 2010 06:05:13 +0000 (06:05 +0000)]
2010-12-23 Yuta Kitamura <yutak@chromium.org>
Unreviewed. Update GTK's Skipped file.
[GTK] http/tests/inspector/console-websocket-error.html hangs
https://bugs.webkit.org/show_bug.cgi?id=51380
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Fri, 24 Dec 2010 05:26:28 +0000 (05:26 +0000)]
Unreviewed GTK fix after r74609: put the right file name in the Skipped file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Fri, 24 Dec 2010 04:59:58 +0000 (04:59 +0000)]
2010-12-23 Yuta Kitamura <yutak@chromium.org>
Unreviewed. Update Chromium test expectations.
Mark http/tests/inspector/console-websocket-error.html as SLOW on WIN DEBUG.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Fri, 24 Dec 2010 04:50:00 +0000 (04:50 +0000)]
2010-12-22 Yuta Kitamura <yutak@chromium.org>
Reviewed by Alexey Proskuryakov.
[GTK] http/tests/inspector/console-websocket-error.html hangs
https://bugs.webkit.org/show_bug.cgi?id=51380
The test should call dumpConsoleMessages() even if WebSocket is not supported
or a WebSocket object goes to an unexpected state.
* http/tests/inspector/console-websocket-error.html:
* platform/gtk/Skipped:
* platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
* platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
evan@chromium.org [Fri, 24 Dec 2010 04:31:50 +0000 (04:31 +0000)]
2010-12-23 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
ViewportArguments.h uses an enum to intialize a bool
https://bugs.webkit.org/show_bug.cgi?id=50982
Initialize userScalable to true, rather than -1.
No tests; fixes a compiler warning.
* dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Fri, 24 Dec 2010 04:06:26 +0000 (04:06 +0000)]
[Qt] User name/password stripped from URLs
https://bugs.webkit.org/show_bug.cgi?id=36232
Patch by Jan Erik Hanssen <jhanssen@sencha.com> on 2010-12-23
Reviewed by Adam Barth.
WebCore:
If a username but no password or no username but a password is present
in a URL, QtWebKit won't send any authentication information down to Qt
as it should.
Tests: http/tests/xmlhttprequest/basic-auth-nopassword.html
http/tests/xmlhttprequest/basic-auth-nouser.html
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
LayoutTests:
Test authentication cases where a username but no password and
no username but a password is present.
* http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* http/tests/xmlhttprequest/basic-auth-nopassword.html: Added.
* http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added.
* http/tests/xmlhttprequest/basic-auth-nouser.html: Added.
* http/tests/xmlhttprequest/resources/basic-auth-nouserpass/basic-auth-nouserpass.php: Added.
* platform/gtk/Skipped:
* platform/mac-leopard/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* platform/mac-snowleopard/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* platform/mac-tiger/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 24 Dec 2010 03:40:54 +0000 (03:40 +0000)]
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Qt rebaseline for r74593.
Added the forgotten blank line at the end.
* platform/qt/editing/pasteboard/copy-in-password-field-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 24 Dec 2010 03:18:27 +0000 (03:18 +0000)]
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Qt rebaseline for r74593.
* platform/qt/editing/pasteboard/copy-in-password-field-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 24 Dec 2010 02:56:45 +0000 (02:56 +0000)]
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
More unreviewed Chromium rebaselines for r74593.
* platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
* platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 24 Dec 2010 02:53:41 +0000 (02:53 +0000)]
2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Alexey Proskuryakov.
[Qt] Composition text is not removed from the editor when composition is cancelled
https://bugs.webkit.org/show_bug.cgi?id=29391
Ensure that the composition text is cleared when an empty QInputMethodEvent
is received and the editor is in composition mode.
* editing/input/ime-composition-clearpreedit-expected.txt: Added.
* editing/input/ime-composition-clearpreedit.html: Added.
* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:
2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Alexey Proskuryakov.
[Qt] Composition text is not removed from the editor when composition is cancelled
https://bugs.webkit.org/show_bug.cgi?id=29391
Ensure that the composition text is cleared when an empty QInputMethodEvent
is received and the editor is in composition mode.
* Api/qwebpage.cpp:
(QWebPagePrivate::inputMethodEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 24 Dec 2010 02:38:21 +0000 (02:38 +0000)]
2010-12-23 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Selection becomes stale when CharacterData is manipulated directly
https://bugs.webkit.org/show_bug.cgi?id=51389
Rebaseline GTK tests.
* platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
* platform/gtk/editing/deleting/delete-3608430-fix-expected.txt:
* platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
* platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
* platform/gtk/editing/deleting/delete-and-undo-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
* platform/gtk/editing/deleting/delete-br-007-expected.txt:
* platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
* platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
* platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
* platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
* platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
* platform/gtk/editing/deleting/delete-tab-002-expected.txt:
* platform/gtk/editing/deleting/delete-tab-004-expected.txt:
* platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
* platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
* platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
* platform/gtk/editing/deleting/forward-delete-expected.txt:
* platform/gtk/editing/deleting/smart-delete-003-expected.txt:
* platform/gtk/editing/deleting/smart-delete-004-expected.txt:
* platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt:
* platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
* platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
* platform/gtk/editing/inserting/insert-div-003-expected.txt:
* platform/gtk/editing/inserting/insert-div-024-expected.txt:
* platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
* platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
* platform/gtk/editing/inserting/typing-001-expected.txt:
* platform/gtk/editing/inserting/typing-002-expected.txt:
* platform/gtk/editing/inserting/typing-003-expected.txt:
* platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
* platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
* platform/gtk/editing/pasteboard/4076267-2-expected.txt:
* platform/gtk/editing/pasteboard/4076267-3-expected.txt:
* platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
* platform/gtk/editing/pasteboard/paste-xml-expected.txt:
* platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
* platform/gtk/editing/spelling/spelling-expected.txt:
* platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
* platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
* platform/gtk/editing/style/typing-style-001-expected.txt:
* platform/gtk/editing/style/typing-style-002-expected.txt:
* platform/gtk/editing/style/unbold-in-bold-expected.txt:
* platform/gtk/editing/undo/4063751-expected.txt:
* platform/gtk/editing/undo/redo-typing-001-expected.txt:
* platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
* platform/gtk/editing/undo/undo-combined-delete-expected.txt:
* platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
* platform/gtk/editing/undo/undo-delete-expected.txt:
* platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
* platform/gtk/editing/undo/undo-forward-delete-expected.txt:
* platform/gtk/editing/undo/undo-misspellings-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 24 Dec 2010 02:33:40 +0000 (02:33 +0000)]
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandValue("FormatBlock") does not respect editing boundaries
https://bugs.webkit.org/show_bug.cgi?id=51219
Added test cases to ensure queryCommandValue("FormatBlock") respects editing boundaries.
* editing/execCommand/query-format-block-expected.txt:
* editing/execCommand/script-tests/query-format-block.js:
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandValue("FormatBlock") does not respect editing boundaries
https://bugs.webkit.org/show_bug.cgi?id=51219
Fixed the bug by checking the element we found in elementForFormatBlockCommand
does not contain the editable root.
* editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::elementForFormatBlockCommand):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 24 Dec 2010 02:17:57 +0000 (02:17 +0000)]
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium rebaselines for r74593.
* platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
* platform/chromium-linux/editing/deleting/smart-delete-003-expected.txt:
* platform/chromium-linux/editing/deleting/smart-delete-004-expected.txt:
* platform/chromium-win/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-3608430-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-3608445-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-3608462-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-after-span-ws-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.txt:
* platform/chromium-win/editing/deleting/delete-and-undo-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-010-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-table-expected.txt:
* platform/chromium-win/editing/deleting/delete-br-007-expected.txt:
* platform/chromium-win/editing/deleting/delete-character-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-hr-expected.txt:
* platform/chromium-win/editing/deleting/delete-leading-ws-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-end-ws-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-end-ws-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-listitem-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-selection-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-tab-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-tab-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-tab-003-expected.txt:
* platform/chromium-win/editing/deleting/delete-tab-004-expected.txt:
* platform/chromium-win/editing/deleting/delete-trailing-ws-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.txt:
* platform/chromium-win/editing/deleting/forward-delete-expected.txt:
* platform/chromium-win/editing/deleting/non-smart-delete-expected.txt:
* platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
* platform/chromium-win/editing/deleting/smart-delete-003-expected.txt:
* platform/chromium-win/editing/deleting/smart-delete-004-expected.txt:
* platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.txt:
* platform/chromium-win/editing/inserting/4278698-expected.txt:
* platform/chromium-win/editing/inserting/editing-empty-divs-expected.txt:
* platform/chromium-win/editing/inserting/insert-3654864-fix-expected.txt:
* platform/chromium-win/editing/inserting/insert-after-delete-001-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-003-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-006-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-007-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-008-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-009-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-003-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-006-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-008-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-024-expected.txt:
* platform/chromium-win/editing/inserting/insert-space-in-empty-doc-expected.txt:
* platform/chromium-win/editing/inserting/insert-tab-003-expected.txt:
* platform/chromium-win/editing/inserting/insert-text-at-tabspan-001-expected.txt:
* platform/chromium-win/editing/inserting/insert-text-at-tabspan-002-expected.txt:
* platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.txt:
* platform/chromium-win/editing/inserting/typing-001-expected.txt:
* platform/chromium-win/editing/inserting/typing-002-expected.txt:
* platform/chromium-win/editing/inserting/typing-003-expected.txt:
* platform/chromium-win/editing/inserting/typing-around-br-001-expected.txt:
* platform/chromium-win/editing/inserting/typing-around-image-001-expected.txt:
* platform/chromium-win/editing/pasteboard/4076267-2-expected.txt:
* platform/chromium-win/editing/pasteboard/4076267-3-expected.txt:
* platform/chromium-win/editing/pasteboard/bad-placeholder-expected.txt:
* platform/chromium-win/editing/pasteboard/cut-text-001-expected.txt:
* platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-end-1-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-end-2-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-end-4-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-end-table-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-001-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-019-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
* platform/chromium-win/editing/pasteboard/pasting-object-expected.txt:
* platform/chromium-win/editing/pasteboard/smart-paste-002-expected.txt:
* platform/chromium-win/editing/pasteboard/smart-paste-006-expected.txt:
* platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
* platform/chromium-win/editing/spelling/spelling-expected.txt:
* platform/chromium-win/editing/style/style-3681552-fix-001-expected.txt:
* platform/chromium-win/editing/style/style-3681552-fix-002-expected.txt:
* platform/chromium-win/editing/style/style-boundary-002-expected.txt:
* platform/chromium-win/editing/style/style-boundary-005-expected.txt:
* platform/chromium-win/editing/style/typing-style-001-expected.txt:
* platform/chromium-win/editing/style/typing-style-002-expected.txt:
* platform/chromium-win/editing/style/unbold-in-bold-expected.txt:
* platform/chromium-win/editing/undo/4063751-expected.txt:
* platform/chromium-win/editing/undo/redo-typing-001-expected.txt:
* platform/chromium-win/editing/undo/undo-combined-delete-boundary-expected.txt:
* platform/chromium-win/editing/undo/undo-combined-delete-expected.txt:
* platform/chromium-win/editing/undo/undo-delete-boundary-expected.txt:
* platform/chromium-win/editing/undo/undo-delete-expected.txt:
* platform/chromium-win/editing/undo/undo-forward-delete-boundary-expected.txt:
* platform/chromium-win/editing/undo/undo-forward-delete-expected.txt:
* platform/chromium-win/editing/undo/undo-misspellings-expected.txt:
* platform/chromium-win/editing/undo/undo-typing-001-expected.txt:
* platform/chromium-win/editing/unsupported-content/list-type-after-expected.txt:
* platform/chromium-win/editing/unsupported-content/list-type-before-expected.txt:
* platform/chromium-win/editing/unsupported-content/table-type-after-expected.txt:
* platform/chromium-win/editing/unsupported-content/table-type-before-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 24 Dec 2010 02:14:28 +0000 (02:14 +0000)]
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
FormatBlock doesn't preserve typing style but it should
https://bugs.webkit.org/show_bug.cgi?id=51140
Added a test to type text after bolding the typing style and executing a FormatBlock command.
Because FormatBlock command preserves typing style, the typed text should be in bold.
* editing/execCommand/format-block-typing-style.html: Added.
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
FormatBlock doesn't preserve typing style but it should
https://bugs.webkit.org/show_bug.cgi?id=51140
Fixed the bug by making preserveTypingStyle return true.
Test: editing/execCommand/format-block-typing-style.html
* editing/FormatBlockCommand.h:
(WebCore::FormatBlockCommand::preservesTypingStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 24 Dec 2010 01:40:54 +0000 (01:40 +0000)]
Rename RegexCompiler.cpp to RegexPattern.cpp.
Implicitly call compileRegex from RegexPattern's constructor.
Reviewed by Sam Weinig.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
* yarr/RegexCompiler.cpp: Removed.
* yarr/RegexCompiler.h: Removed.
* yarr/RegexInterpreter.cpp:
* yarr/RegexJIT.cpp:
* yarr/RegexPattern.cpp: Copied from JavaScriptCore/yarr/RegexCompiler.cpp.
(JSC::Yarr::compileRegex):
(JSC::Yarr::RegexPattern::RegexPattern):
* yarr/RegexPattern.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 24 Dec 2010 01:36:39 +0000 (01:36 +0000)]
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Qt rebaselines for r74593.
* platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
* platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
* platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
* platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
* platform/qt/editing/deleting/delete-character-001-expected.txt:
* platform/qt/editing/deleting/delete-hr-expected.txt:
* platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
* platform/qt/editing/deleting/delete-selection-001-expected.txt:
* platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
* platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
* platform/qt/editing/deleting/non-smart-delete-expected.txt:
* platform/qt/editing/deleting/smart-delete-001-expected.txt:
* platform/qt/editing/deleting/smart-delete-003-expected.txt:
* platform/qt/editing/deleting/smart-delete-004-expected.txt:
* platform/qt/editing/inserting/insert-3654864-fix-expected.txt:
* platform/qt/editing/inserting/insert-after-delete-001-expected.txt:
* platform/qt/editing/inserting/insert-br-003-expected.txt:
* platform/qt/editing/inserting/insert-br-006-expected.txt:
* platform/qt/editing/inserting/insert-br-007-expected.txt:
* platform/qt/editing/inserting/insert-br-008-expected.txt:
* platform/qt/editing/inserting/insert-br-009-expected.txt:
* platform/qt/editing/inserting/insert-br-at-tabspan-002-expected.txt:
* platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.txt:
* platform/qt/editing/inserting/insert-div-003-expected.txt:
* platform/qt/editing/inserting/insert-div-006-expected.txt:
* platform/qt/editing/inserting/insert-div-008-expected.txt:
* platform/qt/editing/inserting/insert-div-024-expected.txt:
* platform/qt/editing/inserting/insert-space-in-empty-doc-expected.txt:
* platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.txt:
* platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.txt:
* platform/qt/editing/inserting/typing-001-expected.txt:
* platform/qt/editing/inserting/typing-002-expected.txt:
* platform/qt/editing/inserting/typing-003-expected.txt:
* platform/qt/editing/inserting/typing-around-br-001-expected.txt:
* platform/qt/editing/inserting/typing-around-image-001-expected.txt:
* platform/qt/editing/pasteboard/4076267-3-expected.txt:
* platform/qt/editing/pasteboard/cut-text-001-expected.txt:
* platform/qt/editing/pasteboard/interchange-newline-1-expected.txt:
* platform/qt/editing/pasteboard/merge-end-1-expected.txt:
* platform/qt/editing/pasteboard/merge-end-2-expected.txt:
* platform/qt/editing/pasteboard/merge-end-4-expected.txt:
* platform/qt/editing/pasteboard/merge-end-list-expected.txt:
* platform/qt/editing/pasteboard/merge-end-table-expected.txt:
* platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/qt/editing/pasteboard/paste-text-019-expected.txt:
* platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
* platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
* platform/qt/editing/pasteboard/pasting-object-expected.txt:
* platform/qt/editing/pasteboard/smart-paste-002-expected.txt:
* platform/qt/editing/pasteboard/smart-paste-006-expected.txt:
* platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
* platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt:
* platform/qt/editing/undo/redo-style-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
evan@chromium.org [Fri, 24 Dec 2010 01:19:00 +0000 (01:19 +0000)]
2010-12-23 Evan Martin <evan@chromium.org>
Reviewed by Ryosuke Niwa.
[chromium] LayoutTestController warning in float->int conversion
https://bugs.webkit.org/show_bug.cgi?id=51553
Rather than reading an int, converting to a float, then getting a compiler
warning on passing the float to something that expects an int, instead
just pass around ints.
No tests, fixes a compiler warning.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(parsePageSizeParameters):
(LayoutTestController::pageNumberForElementById):
(LayoutTestController::numberOfPages):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 24 Dec 2010 01:16:19 +0000 (01:16 +0000)]
Need WebKit2 API to create a SecurityOrigin from protocol, host, and port
https://bugs.webkit.org/show_bug.cgi?id=51563
Reviewed by Sam Weinig.
WebCore:
Add SecurityOrigin::create(const String& protocol, const String& host, int port).
* WebCore.exp.in:
Export the symbols for WebCore::SecurityOrigin::create(String, String, int).
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
Use the constant MaxAllowedPort.
(WebCore::SecurityOrigin::create):
Sanitizing based off of that done in createFromDatabaseIdentifier.
* page/SecurityOrigin.h:
WebKit2:
Add WKSecurityOriginCreate(WKStringRef protocol, WKStringRef host, int port).
* Shared/API/c/WKSecurityOrigin.cpp:
(WKSecurityOriginCreateFromIdentifier):
Renamed so as not to clash with the new WKSecurityOriginCreate.
(WKSecurityOriginCreate):
* Shared/API/c/WKSecurityOrigin.h:
* Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 24 Dec 2010 01:11:04 +0000 (01:11 +0000)]
2010-12-23 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix for WinCE after r73802.
Reapply r70812:
Port ContextMenuItemWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48407
* platform/win/ContextMenuItemWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 24 Dec 2010 01:03:23 +0000 (01:03 +0000)]
2010-12-23 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix for WinCE after r74360.
Move the OS(WINDOWS) section after the OS(WINCE) section
and add missing argument to the getStackMax call.
* wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 24 Dec 2010 00:55:48 +0000 (00:55 +0000)]
2010-12-23 Adam Barth <abarth@webkit.org>
Remove include of non-existant file.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 24 Dec 2010 00:22:00 +0000 (00:22 +0000)]
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Selection becomes stale when CharacterData is manipulated directly
https://bugs.webkit.org/show_bug.cgi?id=51389
The bug was caused by SelectionController's not adjusting selection when CharacterData's
m_data is modified by its API.
Fixed the bug by adding textWillBeReplaced to SelectionController and calling it in
CharacterData::textWillBeReplaced. Added newLength to setDataAndUpdate, which is passed to
textWillBeReplaced because inserting, replacing, or removing data may require moving
the offset of the selection end points (done by shouldRemovePositionAfterAdoptingTextReplacement).
Also fixed the condition for determining whether or not a node intersects the selection
in respondToNodeModification, which is extracted from nodeWillBeRemoved. The old condition
failed to recognize certain cases when selection started and ended with non-zero offsets.
Tests: editing/selection/character-data-mutation-crash.html
editing/selection/character-data-mutation.html
* dom/CharacterData.cpp:
(WebCore::CharacterData::setData): Passes newLegnth to setDataAndUpdate.
(WebCore::CharacterData::appendData): Ditto.
(WebCore::CharacterData::insertData): Ditto.
(WebCore::CharacterData::deleteData): Ditto.
(WebCore::CharacterData::replaceData): Ditto.
(WebCore::CharacterData::setDataAndUpdate): Added newLegnth to the argument list,
and renamed lengthOfReplacedData to oldLength; calls textWillBeReplaced.
* dom/CharacterData.h:
* editing/SelectionController.cpp:
(WebCore::removingNodeRemovesPosition): Removed indentations from blank lines.
(WebCore::SelectionController::nodeWillBeRemoved): Calls nodeWillBeRemoved.
(WebCore::SelectionController::respondToNodeModification): Extracted from nodeWillBeRemoved;
fixed the logic to figure out whether a node is inside the range or not.
(WebCore::shouldRemovePositionAfterAdoptingTextReplacement): Added.
(WebCore::SelectionController::textWillBeReplaced): Added.
* editing/SelectionController.h:
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Selection becomes stale when CharacterData is manipulated directly
https://bugs.webkit.org/show_bug.cgi?id=51389
Added tests to ensure WebKit adjusts or clears selection when the start container
or the end container of the selection's first range is modified by CharacterData's API.
Many editing tests had to be rebaselined due to different editing delegate dumps
caused by WebKit's properly adjusting selection's offsets as editing commands modify the DOM.
* editing/deleting/delete-by-word-001-expected.txt:
* editing/deleting/delete-by-word-002-expected.txt:
* editing/deleting/delete-ligature-001-expected.txt:
* editing/deleting/delete-ligature-002-expected.txt:
* editing/deleting/delete-ligature-003-expected.txt:
* editing/deleting/skip-virama-001-expected.txt:
* editing/execCommand/createLink-expected.txt:
* editing/execCommand/hilitecolor-expected.txt:
* editing/execCommand/unlink-expected.txt:
* editing/inserting/insert-thai-characters-001-expected.txt:
* editing/pasteboard/copy-in-password-field-expected.txt:
* editing/pasteboard/paste-into-anchor-text-expected.txt:
* editing/selection/character-data-mutation-crash-expected.txt: Added.
* editing/selection/character-data-mutation-crash.html: Added.
* editing/selection/character-data-mutation-expected.txt: Added.
* editing/selection/character-data-mutation.html: Added.
* editing/style/remove-underline-from-stylesheet-expected.txt:
* editing/style/typing-style-003-expected.txt:
* editing/undo/redo-style-expected.txt:
* platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
* platform/mac/editing/deleting/delete-3608430-fix-expected.txt:
* platform/mac/editing/deleting/delete-3608445-fix-expected.txt:
* platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
* platform/mac/editing/deleting/delete-after-span-ws-001-expected.txt:
* platform/mac/editing/deleting/delete-after-span-ws-002-expected.txt:
* platform/mac/editing/deleting/delete-after-span-ws-003-expected.txt:
* platform/mac/editing/deleting/delete-and-undo-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
* platform/mac/editing/deleting/delete-block-table-expected.txt:
* platform/mac/editing/deleting/delete-br-007-expected.txt:
* platform/mac/editing/deleting/delete-character-001-expected.txt:
* platform/mac/editing/deleting/delete-contiguous-ws-001-expected.txt:
* platform/mac/editing/deleting/delete-hr-expected.txt:
* platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
* platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
* platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
* platform/mac/editing/deleting/delete-listitem-001-expected.txt:
* platform/mac/editing/deleting/delete-selection-001-expected.txt:
* platform/mac/editing/deleting/delete-tab-001-expected.txt:
* platform/mac/editing/deleting/delete-tab-002-expected.txt:
* platform/mac/editing/deleting/delete-tab-003-expected.txt:
* platform/mac/editing/deleting/delete-tab-004-expected.txt:
* platform/mac/editing/deleting/delete-trailing-ws-001-expected.txt:
* platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
* platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
* platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
* platform/mac/editing/deleting/forward-delete-expected.txt:
* platform/mac/editing/deleting/non-smart-delete-expected.txt:
* platform/mac/editing/deleting/smart-delete-001-expected.txt:
* platform/mac/editing/deleting/smart-delete-002-expected.txt:
* platform/mac/editing/deleting/smart-delete-003-expected.txt:
* platform/mac/editing/deleting/smart-delete-004-expected.txt:
* platform/mac/editing/execCommand/insertHorizontalRule-expected.txt:
* platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
* platform/mac/editing/input/text-input-controller-expected.txt:
* platform/mac/editing/inserting/4278698-expected.txt:
* platform/mac/editing/inserting/editing-empty-divs-expected.txt:
* platform/mac/editing/inserting/insert-3654864-fix-expected.txt:
* platform/mac/editing/inserting/insert-after-delete-001-expected.txt:
* platform/mac/editing/inserting/insert-br-003-expected.txt:
* platform/mac/editing/inserting/insert-br-006-expected.txt:
* platform/mac/editing/inserting/insert-br-007-expected.txt:
* platform/mac/editing/inserting/insert-br-008-expected.txt:
* platform/mac/editing/inserting/insert-br-009-expected.txt:
* platform/mac/editing/inserting/insert-br-at-tabspan-002-expected.txt:
* platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
* platform/mac/editing/inserting/insert-div-003-expected.txt:
* platform/mac/editing/inserting/insert-div-006-expected.txt:
* platform/mac/editing/inserting/insert-div-008-expected.txt:
* platform/mac/editing/inserting/insert-div-024-expected.txt:
* platform/mac/editing/inserting/insert-space-in-empty-doc-expected.txt:
* platform/mac/editing/inserting/insert-tab-003-expected.txt:
* platform/mac/editing/inserting/insert-text-at-tabspan-001-expected.txt:
* platform/mac/editing/inserting/insert-text-at-tabspan-002-expected.txt:
* platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
* platform/mac/editing/inserting/typing-001-expected.txt:
* platform/mac/editing/inserting/typing-002-expected.txt:
* platform/mac/editing/inserting/typing-003-expected.txt:
* platform/mac/editing/inserting/typing-around-br-001-expected.txt:
* platform/mac/editing/inserting/typing-around-image-001-expected.txt:
* platform/mac/editing/pasteboard/4076267-2-expected.txt:
* platform/mac/editing/pasteboard/4076267-3-expected.txt:
* platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
* platform/mac/editing/pasteboard/cut-text-001-expected.txt:
* platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
* platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
* platform/mac/editing/pasteboard/interchange-newline-1-expected.txt:
* platform/mac/editing/pasteboard/merge-end-1-expected.txt:
* platform/mac/editing/pasteboard/merge-end-2-expected.txt:
* platform/mac/editing/pasteboard/merge-end-4-expected.txt:
* platform/mac/editing/pasteboard/merge-end-list-expected.txt:
* platform/mac/editing/pasteboard/merge-end-table-expected.txt:
* platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/mac/editing/pasteboard/paste-text-001-expected.txt:
* platform/mac/editing/pasteboard/paste-text-019-expected.txt:
* platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
* platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
* platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
* platform/mac/editing/pasteboard/paste-xml-expected.txt:
* platform/mac/editing/pasteboard/pasting-object-expected.txt:
* platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
* platform/mac/editing/pasteboard/smart-paste-006-expected.txt:
* platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
* platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
* platform/mac/editing/spelling/spelling-expected.txt:
* platform/mac/editing/style/style-3681552-fix-001-expected.txt:
* platform/mac/editing/style/style-3681552-fix-002-expected.txt:
* platform/mac/editing/style/style-boundary-002-expected.txt:
* platform/mac/editing/style/style-boundary-005-expected.txt:
* platform/mac/editing/style/typing-style-001-expected.txt:
* platform/mac/editing/style/typing-style-002-expected.txt:
* platform/mac/editing/style/unbold-in-bold-expected.txt:
* platform/mac/editing/undo/4063751-expected.txt:
* platform/mac/editing/undo/redo-typing-001-expected.txt:
* platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
* platform/mac/editing/undo/undo-combined-delete-expected.txt:
* platform/mac/editing/undo/undo-delete-boundary-expected.txt:
* platform/mac/editing/undo/undo-delete-expected.txt:
* platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
* platform/mac/editing/undo/undo-forward-delete-expected.txt:
* platform/mac/editing/undo/undo-misspellings-expected.txt:
* platform/mac/editing/undo/undo-typing-001-expected.txt:
* platform/mac/editing/unsupported-content/list-type-after-expected.txt:
* platform/mac/editing/unsupported-content/list-type-before-expected.txt:
* platform/mac/editing/unsupported-content/table-type-after-expected.txt:
* platform/mac/editing/unsupported-content/table-type-before-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 24 Dec 2010 00:00:38 +0000 (00:00 +0000)]
2010-12-23 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove unneeded V8 bindings files
https://bugs.webkit.org/show_bug.cgi?id=51570
* WebCore.gypi:
* bindings/generic/BindingDOMWindow.h: Removed.
* bindings/v8/specialization/V8BindingDOMWindow.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 23 Dec 2010 23:55:41 +0000 (23:55 +0000)]
2010-12-23 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Ensure that we are not getting too many mouse move events
https://bugs.webkit.org/show_bug.cgi?id=51568
<rdar://problem/7881470>
<rdar://problem/8735512>
Implement throttling of mouse move events.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Initialize m_processingMouseMoveEvent to false.
(WebKit::WebPageProxy::handleMouseEvent):
If we're already processing a mouse move events, just update
m_nextMouseMoveEvent and return.
(WebKit::WebPageProxy::didReceiveEvent):
If we received a mouse move event, send the next mouse move event if there is one.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 23 Dec 2010 23:43:15 +0000 (23:43 +0000)]
Build fix.
* editing/EditorCommand.cpp:
(WebCore::enabledDismissCorrectionPanel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 23 Dec 2010 23:42:11 +0000 (23:42 +0000)]
Try to fix crash seen on GTK bot.
* editing/EditorCommand.cpp:
(WebCore::internalCommand): Add back empty string check I accidentally deleted in r74580.
* WebCore.xcodeproj/project.pbxproj: Let Xcode edit the file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Thu, 23 Dec 2010 23:36:16 +0000 (23:36 +0000)]
Assertion when loading yahoo.com in WebKit2 under decodeResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=51562
Reviewed by Anders Carlsson.
Don't assert that our data reference isn't empty when we try to get the data from it.
If it is empty, just return 0.
All callers are safe with this function returning 0.
* Platform/CoreIPC/DataReference.h:
(CoreIPC::DataReference::data): Change the assert to an early return.
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode): Add an assert, and remove a ternarny operator because the function now does
this for us (if the data is empty, return 0).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Thu, 23 Dec 2010 23:15:32 +0000 (23:15 +0000)]
2010-12-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74561.
http://trac.webkit.org/changeset/74561
https://bugs.webkit.org/show_bug.cgi?id=51565
"Broke Chromium UI tests on Vista" (Requested by kbr_google on
#webkit).
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
2010-12-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74561.
http://trac.webkit.org/changeset/74561
https://bugs.webkit.org/show_bug.cgi?id=51565
"Broke Chromium UI tests on Vista" (Requested by kbr_google on
#webkit).
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContentsIfDirty):
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 23 Dec 2010 23:10:45 +0000 (23:10 +0000)]
2010-12-23 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Darin Adler.
WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
https://bugs.webkit.org/show_bug.cgi?id=38535
WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram. As a result,
if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
WebScriptDebugger's callframe stack is wrong from this point. That could cause crash if we trying to access the top
call frame from this stack when an exception throws because the saved top frame could be invalid.
To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
callEvent and returnEvent.
* WebView/WebScriptDebugger.mm:
(WebScriptDebugger::willExecuteProgram):
(WebScriptDebugger::didExecuteProgram):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Thu, 23 Dec 2010 23:08:37 +0000 (23:08 +0000)]
2010-12-23 Kenneth Russell <kbr@google.com>
Unreviewed Chromium test expectations update. Fix botched update
of fast/css/box-shadow.html expectation; needed to be FAIL, not
IMAGE+TEXT IMAGE.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 23 Dec 2010 22:49:10 +0000 (22:49 +0000)]
Fix incorrect assertion causing all pages with subframes to crash.
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::appendChild):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 23 Dec 2010 22:40:19 +0000 (22:40 +0000)]
Fixed out-of-order ChangeLog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 23 Dec 2010 22:34:52 +0000 (22:34 +0000)]
2010-12-23 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WKView should not try to do asynchronous validation for selectors that are not editor commands
https://bugs.webkit.org/show_bug.cgi?id=51555
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]): Removed the special case for startSpeaking.
Added call to commandIsSupportedFromMenuOrKeyBinding so we only try to do validation
for commands that are supported. Tweaked comments and added some bug numbers.
(-[WKView _setUserInterfaceItemState:enabled:state:]): Tweaked comment and added
bug number.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 23 Dec 2010 22:23:58 +0000 (22:23 +0000)]
2010-12-23 Mihai Parparita <mihaip@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
https://bugs.webkit.org/show_bug.cgi?id=51507
Adds WebThemeEngine for the Mac (it already has parallel definitions for
Windows and Linux) so that scrollbar thumb rendering can be overridden
for the DRT (to be consistent with the NSScroller-based rendering
used by the Mac port).
No new tests since the functionality is not exposed yet. Eventually will
result in the Chromium/Mac port being able to use the same pixel
baselines for layout tests as the Mac port.
* platform/chromium/ChromiumBridge.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):
2010-12-23 Mihai Parparita <mihaip@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
https://bugs.webkit.org/show_bug.cgi?id=51507
Adds WebThemeEngine for the Mac (it already has parallel definitions for
Windows and Linux) so that scrollbar thumb rendering can be overridden
for the DRT (to be consistent with the NSScroller-based rendering
used by the Mac port).
* public/mac/WebThemeEngine.h: Added.
(WebKit::WebThemeEngine::paintScrollbarThumb):
* src/AssertMatchingEnums.cpp:
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::paintScrollbarThumb):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 23 Dec 2010 22:20:43 +0000 (22:20 +0000)]
2010-12-23 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WKView should not try to do asynchronous validation for selectors that are not editor commands
https://bugs.webkit.org/show_bug.cgi?id=51555
* WebCore.exp.in: Added commandIsSupportedFromMenuOrKeyBinding.
* editing/Editor.h: Reordered arguments in the Editor::Command constructor
and the data members too so the frame is last. Added
commandIsSupportedFromMenuOrKeyBinding.
* editing/EditorCommand.cpp:
(WebCore::supported): Removed the EditorCommandSource argument. These
functions are now only used when called from DOM.
(WebCore::supportedFromMenuOrKeyBinding): Ditto.
(WebCore::supportedCopyCut): Ditto.
(WebCore::supportedPaste): Ditto.
(WebCore::enabledDismissCorrectionPanel): Changed the supported function to
an enabled function. It was incorrect to say that this is "supported" only
when the correction panel is up. Correct to say that it is "enabled" only
then. And also probably OK to enable it even when the selection is not in
editable text, as long as the panel is up.
(WebCore::createCommandMap): Moved conditional commands out of the main
array into a separate section at the end.
(WebCore::internalCommand): Added.
(WebCore::Editor::command): Changed to use the new internalCommand function
and simplified by relying on the null check in the Command constructor.
(WebCore::Editor::commandIsSupportedFromMenuOrKeyBinding): Added.
(WebCore::Editor::Command::Command): Removed unneeded initialization of
m_source, which is never looked at if m_command is 0. Added feature of
passing a null command pointer to the non-default constructor.
(WebCore::Editor::Command::isSupported): Changed to only call the
per-command isSupported function when the command source is DOM.
Accordingly that function is now called isSupportedFromDOM.
2010-12-23 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WKView should not try to do asynchronous validation for selectors that are not editor commands
https://bugs.webkit.org/show_bug.cgi?id=51555
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]): Removed the special case for startSpeaking.
Added call to commandIsSupportedFromMenuOrKeyBinding so we only try to do validation
for commands that are supported. Tweaked comments and added some bug numbers.
(-[WKView _setUserInterfaceItemState:enabled:state:]): Tweaked comment and added
bug number.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Thu, 23 Dec 2010 22:15:12 +0000 (22:15 +0000)]
2010-12-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Incorrect layer property used noted as changed in GraphicsLayerCA::setAcceleratesDrawing
https://bugs.webkit.org/show_bug.cgi?id=51560
No new tests.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setAcceleratesDrawing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ajwong@chromium.org [Thu, 23 Dec 2010 21:28:25 +0000 (21:28 +0000)]
Unreviewed. Chromium layout test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=51500
Rebaseline media control layout tests due to pixel diff from r74535
* platform/chromium-linux/media/audio-controls-rendering-expected.checksum:
* platform/chromium-linux/media/audio-controls-rendering-expected.png:
* platform/chromium-linux/media/controls-after-reload-expected.checksum:
* platform/chromium-linux/media/controls-after-reload-expected.png:
* platform/chromium-linux/media/controls-strict-expected.checksum:
* platform/chromium-linux/media/controls-strict-expected.png:
* platform/chromium-linux/media/controls-styling-expected.checksum:
* platform/chromium-linux/media/controls-styling-expected.png:
* platform/chromium-linux/media/controls-without-preload-expected.checksum:
* platform/chromium-linux/media/controls-without-preload-expected.png:
* platform/chromium-linux/media/video-controls-rendering-expected.checksum:
* platform/chromium-linux/media/video-controls-rendering-expected.png:
* platform/chromium-linux/media/video-display-toggle-expected.checksum:
* platform/chromium-linux/media/video-display-toggle-expected.png:
* platform/chromium-linux/media/video-empty-source-expected.checksum:
* platform/chromium-linux/media/video-empty-source-expected.png:
* platform/chromium-linux/media/video-no-audio-expected.checksum:
* platform/chromium-linux/media/video-no-audio-expected.png:
* platform/chromium-linux/media/video-volume-slider-expected.checksum:
* platform/chromium-linux/media/video-volume-slider-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.checksum:
* platform/chromium-mac/media/audio-controls-rendering-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.txt:
* platform/chromium-mac/media/controls-after-reload-expected.checksum:
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.txt:
* platform/chromium-mac/media/controls-strict-expected.checksum:
* platform/chromium-mac/media/controls-strict-expected.png:
* platform/chromium-mac/media/controls-strict-expected.txt:
* platform/chromium-mac/media/controls-styling-expected.checksum:
* platform/chromium-mac/media/controls-styling-expected.png:
* platform/chromium-mac/media/controls-styling-expected.txt:
* platform/chromium-mac/media/controls-without-preload-expected.checksum:
* platform/chromium-mac/media/controls-without-preload-expected.png:
* platform/chromium-mac/media/controls-without-preload-expected.txt:
* platform/chromium-mac/media/video-display-toggle-expected.checksum:
* platform/chromium-mac/media/video-display-toggle-expected.png:
* platform/chromium-mac/media/video-display-toggle-expected.txt:
* platform/chromium-mac/media/video-empty-source-expected.checksum:
* platform/chromium-mac/media/video-empty-source-expected.png:
* platform/chromium-mac/media/video-empty-source-expected.txt:
* platform/chromium-mac/media/video-no-audio-expected.checksum:
* platform/chromium-mac/media/video-no-audio-expected.png:
* platform/chromium-mac/media/video-no-audio-expected.txt:
* platform/chromium-mac/media/video-volume-slider-expected.checksum:
* platform/chromium-mac/media/video-volume-slider-expected.png:
* platform/chromium-mac/media/video-volume-slider-expected.txt:
* platform/chromium-win/media/audio-controls-rendering-expected.checksum:
* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/audio-controls-rendering-expected.txt:
* platform/chromium-win/media/controls-after-reload-expected.checksum:
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.txt:
* platform/chromium-win/media/controls-strict-expected.checksum:
* platform/chromium-win/media/controls-strict-expected.png:
* platform/chromium-win/media/controls-strict-expected.txt:
* platform/chromium-win/media/controls-styling-expected.checksum:
* platform/chromium-win/media/controls-styling-expected.png:
* platform/chromium-win/media/controls-styling-expected.txt:
* platform/chromium-win/media/controls-without-preload-expected.checksum:
* platform/chromium-win/media/controls-without-preload-expected.png:
* platform/chromium-win/media/controls-without-preload-expected.txt:
* platform/chromium-win/media/video-controls-rendering-expected.checksum:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.txt:
* platform/chromium-win/media/video-display-toggle-expected.checksum:
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.txt:
* platform/chromium-win/media/video-empty-source-expected.checksum:
* platform/chromium-win/media/video-empty-source-expected.png:
* platform/chromium-win/media/video-empty-source-expected.txt:
* platform/chromium-win/media/video-no-audio-expected.checksum:
* platform/chromium-win/media/video-no-audio-expected.png:
* platform/chromium-win/media/video-no-audio-expected.txt:
* platform/chromium-win/media/video-volume-slider-expected.checksum:
* platform/chromium-win/media/video-volume-slider-expected.png:
* platform/chromium-win/media/video-volume-slider-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 23 Dec 2010 21:08:12 +0000 (21:08 +0000)]
2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Andreas Kling.
[Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown
https://bugs.webkit.org/show_bug.cgi?id=35635
Explicitly set text/html data on QClipboard as UTF-8 and also include a <meta>
tag informing the OS that the data is in UTF-8 format.
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeSelection):
2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Andreas Kling.
[Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown
https://bugs.webkit.org/show_bug.cgi?id=35635
Test that QClipboard contains the charset information and unicode data
after copying unicode text.
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::macCopyUnicodeToClipboard):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Thu, 23 Dec 2010 21:02:57 +0000 (21:02 +0000)]
2010-12-23 Kenneth Russell <kbr@google.com>
Unreviewed Chromium expectations update. Suppress crashes seen on
Windows with fast/canvas/webgl/canvas-test.html and
fast/canvas/webgl/gl-pixelstorei.html.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 23 Dec 2010 20:58:47 +0000 (20:58 +0000)]
<rdar://problem/8799032>
REGRESSION(r74436) Crash opening many pages with WebKit2
Reviewed by Anders Carlsson.
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
Fix paste-o. Decode into a CFDataRef not a CFDictionaryRef
when decoding CFDataRefs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Thu, 23 Dec 2010 20:38:09 +0000 (20:38 +0000)]
2010-12-23 Justin Schuh <jschuh@chromium.org>
Reviewed by Eric Seidel.
CSSCursorImageValue destructor should clear referenced element.
https://bugs.webkit.org/show_bug.cgi?id=51417
Calls correct method to clear image and renames method to avoid future confusion.
Test: svg/css/cursor-image-replace.svg
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
* svg/SVGElement.cpp:
(WebCore::SVGElement::cursorImageValueRemoved):
* svg/SVGElement.h:
2010-12-23 Justin Schuh <jschuh@chromium.org>
Reviewed by Eric Seidel.
CSSCursorImageValue destructor should clear referenced element.
https://bugs.webkit.org/show_bug.cgi?id=51417
* svg/css/cursor-image-replace-expected.txt: Added.
* svg/css/cursor-image-replace.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Thu, 23 Dec 2010 20:22:07 +0000 (20:22 +0000)]
2010-12-23 Kenneth Russell <kbr@google.com>
Unreviewed Chromium expectations update. Allow
fast/css/box-shadow.html to fail with IMAGE as well as IMAGE+TEXT.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 23 Dec 2010 20:11:16 +0000 (20:11 +0000)]
Fix build.
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didSaveToPageCache):
(WebKit::FrameLoaderClientImpl::didRestoreFromPageCache):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 23 Dec 2010 20:10:01 +0000 (20:10 +0000)]
WebKit2 needs to mirror the frame tree in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=51546
Reviewed by Darin Adler.
WebCore:
- Add client functions to notify that a frame has been added or
removed from the page cache.
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::CachedFrame):
* history/CachedFrame.h:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didSaveToPageCache):
(WebCore::EmptyFrameLoaderClient::didRestoreFromPageCache):
* loader/FrameLoaderClient.h:
WebKit/chromium:
- Add client functions to notify that a frame has been added or
removed from the page cache.
* src/FrameLoaderClientImpl.cpp:
(WebKit::WebFrameLoaderClientImpl::didSaveToPageCache):
(WebKit::WebFrameLoaderClientImpl::didRestoreFromPageCache):
* src/FrameLoaderClientImpl.h:
WebKit/efl:
- Add client functions to notify that a frame has been added or
removed from the page cache.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::didSaveToPageCache):
(WebCore::FrameLoaderClientEfl::didRestoreFromPageCache):
* WebCoreSupport/FrameLoaderClientEfl.h:
WebKit/gtk:
- Add client functions to notify that a frame has been added or
removed from the page cache.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::didSaveToPageCache):
(WebKit::FrameLoaderClient::didRestoreFromPageCache):
* WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/haiku:
- Add client functions to notify that a frame has been added or
removed from the page cache.
* WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::didSaveToPageCache):
(WebCore::FrameLoaderClientHaiku::didRestoreFromPageCache):
* WebCoreSupport/FrameLoaderClientHaiku.h:
WebKit/mac:
- Add client functions to notify that a frame has been added or
removed from the page cache.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::didSaveToPageCache):
(WebFrameLoaderClient::didRestoreFromPageCache):
WebKit/qt:
- Add client functions to notify that a frame has been added or
removed from the page cache.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::didSaveToPageCache):
(WebCore::FrameLoaderClientQt::didRestoreFromPageCache):
* WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
- Add client functions to notify that a frame has been added or
removed from the page cache.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didSaveToPageCache):
(WebFrameLoaderClient::didRestoreFromPageCache):
* WebCoreSupport/WebFrameLoaderClient.h:
WebKit/wince:
- Add client functions to notify that a frame has been added or
removed from the page cache.
* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::didSaveToPageCache):
(WebKit::FrameLoaderClientWinCE::didRestoreFromPageCache):
* WebCoreSupport/FrameLoaderClientWinCE.h:
WebKit/wx:
- Add client functions to notify that a frame has been added or
removed from the page cache.
* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::didSaveToPageCache):
(WebCore::FrameLoaderClientWx::didRestoreFromPageCache):
* WebKitSupport/FrameLoaderClientWx.h:
WebKit2:
* UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyChildFrames):
* UIProcess/API/C/WKFrame.h:
Add API to get the child frames of a frame.
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::disconnect):
(WebKit::WebFrameProxy::appendChild):
(WebKit::WebFrameProxy::removeChild):
(WebKit::WebFrameProxy::isDescendantOf):
(WebKit::WebFrameProxy::dumpFrameTree):
(WebKit::WebFrameProxy::didRemoveFromHierarchy):
(WebKit::WebFrameProxy::childFrames):
* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::parentFrame): Add getter.
(WebKit::WebFrameProxy::nextSibling): Add getter.
(WebKit::WebFrameProxy::previousSibling): Add getter.
(WebKit::WebFrameProxy::firstChild): Add getter.
(WebKit::WebFrameProxy::lastChild): Add getter.
Make frames keep track of their subframes.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCreateSubframe):
Use the now passed parentID to insert the frame into the hierarchy
(WebKit::WebPageProxy::didSaveFrameToPageCache):
When a frame is added to the page cache, remove it from the hierarchy.
(WebKit::WebPageProxy::didRestoreFrameFromPageCache):
When a frame is restored from the page cache, add it back to the hierarchy.
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
Detached frames should also be removed from the hierarchy.
* UIProcess/WebPageProxy.h:
Add new declarations for didSaveFrameToPageCache and didRestoreFrameFromPageCache.
* UIProcess/WebPageProxy.messages.in:
Add messages for DidSaveFrameToPageCache and DidRestoreFrameFromPageCache.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::savePlatformDataToCachedFrame):
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
Remove notImplemented, there is no work we need to do here.
(WebKit::WebFrameLoaderClient::didSaveToPageCache):
(WebKit::WebFrameLoaderClient::didRestoreFromPageCache):
Send message to UIProcess to indicate this happened.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createSubframe):
Send parent frameID in addition to our own in the message to UIProcess.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Thu, 23 Dec 2010 19:57:15 +0000 (19:57 +0000)]
2010-12-22 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces
This patch also changes USE_IOSURFACE to instead follow USE(IOSURFACE)
https://bugs.webkit.org/show_bug.cgi?id=51279
* html/HTMLCanvasElement.cpp: For IOSurface, use setNeedsStyleRecalc
* html/canvas/CanvasRenderingContext2D.cpp: Use new flag
* platform/graphics/ImageBuffer.h: Use new flag
* platform/graphics/cg/ImageBufferCG.cpp: Use new flag
2010-12-22 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=51279
* platform/mac-snowleopard/platform/mac/compositing: Added.
* platform/mac-snowleopard/platform/mac/compositing/canvas: Added.
* platform/mac-snowleopard/platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
* platform/mac/compositing/canvas: Added.
* platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
* platform/mac/compositing/canvas/accelerated-canvas-compositing.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 23 Dec 2010 19:33:41 +0000 (19:33 +0000)]
2010-12-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
New popup windows open disproportionately big
https://bugs.webkit.org/show_bug.cgi?id=51547
<rdar://problem/8637029>
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):
Pass the correct size back to the UI process.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::pageRect):
Implement this and return the size of the page.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 23 Dec 2010 19:16:59 +0000 (19:16 +0000)]
2010-12-20 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Tile root layer of the compositor.
https://bugs.webkit.org/show_bug.cgi?id=49947
Refactor root layer update and drawing from LayerRendererChromium into
LayerTilerChromium. The root layer is now drawn as multiple tiles
rather than as one single large texture. Scrollbars are now drawn
separately rather than as part of the root layer.
Test: LayoutTests/compositing/
* WebCore.gypi:
* page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::setClipsRepaints):
* platform/ScrollView.h:
(WebCore::ScrollView::clipsRepaints):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::useShader):
(WebCore::LayerRendererChromium::verticalScrollbarRect):
(WebCore::LayerRendererChromium::horizontalScrollbarRect):
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
(WebCore::LayerRendererChromium::updateAndDrawRootLayer):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::setRootLayer):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTilerChromium.cpp: Added.
(WebCore::LayerTilerChromium::create):
(WebCore::LayerTilerChromium::LayerTilerChromium):
(WebCore::LayerTilerChromium::~LayerTilerChromium):
(WebCore::LayerTilerChromium::layerRendererContext):
(WebCore::LayerTilerChromium::setTileSize):
(WebCore::LayerTilerChromium::reset):
(WebCore::LayerTilerChromium::createTile):
(WebCore::LayerTilerChromium::invalidateTiles):
(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::contentRectToLayerRect):
(WebCore::LayerTilerChromium::layerRectToContentRect):
(WebCore::LayerTilerChromium::tileIndex):
(WebCore::LayerTilerChromium::tileContentRect):
(WebCore::LayerTilerChromium::tileLayerRect):
(WebCore::LayerTilerChromium::invalidateRect):
(WebCore::LayerTilerChromium::invalidateEntireLayer):
(WebCore::LayerTilerChromium::update):
(WebCore::LayerTilerChromium::setLayerPosition):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::resizeLayer):
(WebCore::LayerTilerChromium::growLayerToContain):
(WebCore::LayerTilerChromium::Tile::~Tile):
(WebCore::LayerTilerChromium::Tile::releaseTextureId):
* platform/graphics/chromium/LayerTilerChromium.h: Added.
(WebCore::LayerTilerChromium::Tile::Tile):
(WebCore::LayerTilerChromium::Tile::textureId):
(WebCore::LayerTilerChromium::Tile::dirty):
(WebCore::LayerTilerChromium::Tile::clearDirty):
(WebCore::LayerTilerChromium::layerRenderer):
2010-12-20 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Tile root layer of the compositor.
https://bugs.webkit.org/show_bug.cgi?id=49947
Refactor root layer logic out of WebViewImpl and into
LayerTilerChromium. The painting is now done through an interface
rather than directly in WebViewImpl.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollRootLayerRect):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImplTilePaintInterface::WebViewImplTilePaintInterface):
(WebKit::WebViewImplTilePaintInterface::paint):
(WebKit::WebViewImplScrollbarPaintInterface::WebViewImplScrollbarPaintInterface):
(WebKit::WebViewImplScrollbarPaintInterface::paint):
(WebKit::WebViewImpl::doComposite):
* src/WebViewImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Thu, 23 Dec 2010 19:06:08 +0000 (19:06 +0000)]
2010-12-23 Kenneth Russell <kbr@google.com>
Unreviewed Chromium expectations update. Fix incorrect syntax for
fast/css/box-shadow.html suppression and state that
fast/events/touch/touch-target.html may timeout.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 23 Dec 2010 18:59:52 +0000 (18:59 +0000)]
2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441
Renamed SelectionController::EDirection to SelectionDirection.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeCommand):
2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441
Renamed SelectionController::EDirection to SelectionDirection.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleKeyboardEvent):
2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441
Renamed SelectionController::EDirection to SelectionDirection.
* WebView/WebFrame.mm:
(-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
Takes SelectionDirection instead of SelectionController::EDirection.
* WebView/WebFrameInternal.h:
* WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441
Renamed SelectionController::EDirection to SelectionDirection.
* WebCoreSupport/EditorClientHaiku.cpp:
(WebCore::EditorClientHaiku::handleKeyboardEvent):
2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441
Renamed SelectionController::EDirection to SelectionDirection.
* WebCoreSupport/EditorClientWinCE.cpp:
(WebKit::EditorClientWinCE::handleEditingKeyboardEvent):
2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441
Renamed SelectionController::EDirection to SelectionDirection.
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::handleEditingKeyboardEvent):
2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441
Removed #include <Selection.h> from Editor.h.
Also extracted WritingDirection.h from EditingStyle.h and renamed SelectionController::EDirection
to SelectionDirection and moved its declaration from SelectionController.h to VisibleSelection.h
* WebCore.exp.in: Signature changes.
* WebCore.xcodeproj/project.pbxproj: Added WritingDirection.h
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): Change due to SelectionDirection.
* editing/EditingStyle.h: Removed WritingDirection and included WritingDirection.h
* editing/Editor.cpp:
(WebCore::Editor::deleteWithDirection): Change due to SelectionDirection.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
(WebCore::Editor::markMisspellingsAfterTypingToWord): Ditto.
* editing/Editor.h: Removed SelectionController.h; added DocumentMarker.h, Timer.h, VisibleSelection.h
and WritingDirection.h; forward declared CSSMutableStyleDeclaration.
* editing/EditorCommand.cpp:
(WebCore::executeDeleteBackward): Change due to SelectionDirection.
(WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto.
(WebCore::executeDeleteForward): Ditto.
(WebCore::executeDeleteToBeginningOfLine): Ditto.
(WebCore::executeDeleteToBeginningOfParagraph): Ditto.
(WebCore::executeDeleteToEndOfLine): Ditto.
(WebCore::executeDeleteToEndOfParagraph): Ditto.
(WebCore::executeDeleteWordBackward): Ditto.
(WebCore::executeDeleteWordForward): Ditto.
(WebCore::executeForwardDelete): Ditto.
(WebCore::executeMoveBackward): Ditto.
(WebCore::executeMoveBackwardAndModifySelection): Ditto.
(WebCore::executeMoveDown): Ditto.
(WebCore::executeMoveDownAndModifySelection): Ditto.
(WebCore::executeMoveForward): Ditto.
(WebCore::executeMoveForwardAndModifySelection): Ditto.
(WebCore::executeMoveLeft): Ditto.
(WebCore::executeMoveLeftAndModifySelection): Ditto.
(WebCore::executeMoveRight): Ditto.
(WebCore::executeMoveRightAndModifySelection): Ditto.
(WebCore::executeMoveToBeginningOfDocument): Ditto.
(WebCore::executeMoveToBeginningOfDocumentAndModifySelection): Ditto.
(WebCore::executeMoveToBeginningOfLine): Ditto.
(WebCore::executeMoveToBeginningOfLineAndModifySelection): Ditto.
(WebCore::executeMoveToBeginningOfParagraph): Ditto.
(WebCore::executeMoveToBeginningOfParagraphAndModifySelection): Ditto.
(WebCore::executeMoveToBeginningOfSentence): Ditto.
(WebCore::executeMoveToBeginningOfSentenceAndModifySelection): Ditto.
(WebCore::executeMoveToEndOfDocument): Ditto.
(WebCore::executeMoveToEndOfDocumentAndModifySelection): Ditto.
(WebCore::executeMoveToEndOfSentence): Ditto.
(WebCore::executeMoveToEndOfSentenceAndModifySelection): Ditto.
(WebCore::executeMoveToEndOfLine): Ditto.
(WebCore::executeMoveToEndOfLineAndModifySelection): Ditto.
(WebCore::executeMoveToEndOfParagraph): Ditto.
(WebCore::executeMoveToEndOfParagraphAndModifySelection): Ditto.
(WebCore::executeMoveParagraphBackwardAndModifySelection): Ditto.
(WebCore::executeMoveParagraphForwardAndModifySelection): Ditto.
(WebCore::executeMoveUp): Ditto.
(WebCore::executeMoveUpAndModifySelection): Ditto.
(WebCore::executeMoveWordBackward): Ditto.
(WebCore::executeMoveWordBackwardAndModifySelection): Ditto.
(WebCore::executeMoveWordForward): Ditto.
(WebCore::executeMoveWordForwardAndModifySelection): Ditto.
(WebCore::executeMoveWordLeft): Ditto.
(WebCore::executeMoveWordLeftAndModifySelection): Ditto.
(WebCore::executeMoveWordRight): Ditto.
(WebCore::executeMoveWordRightAndModifySelection): Ditto.
(WebCore::executeMoveToLeftEndOfLine): Ditto.
(WebCore::executeMoveToLeftEndOfLineAndModifySelection): Ditto.
(WebCore::executeMoveToRightEndOfLine): Ditto.
(WebCore::executeMoveToRightEndOfLineAndModifySelection): Ditto.
* editing/SelectionController.cpp:
(WebCore::SelectionController::willBeModified): Takes SelectionDirection instead of EDirection.
(WebCore::SelectionController::modify): Ditto.
* editing/SelectionController.h: Change due to SelectionDirection.
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Ditto.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
* editing/VisibleSelection.h: Added SelectionDirection, renamed and moved from EDirection
in SelectionController.h
* editing/WritingDirection.h: Added.
* page/DOMSelection.cpp:
(WebCore::DOMSelection::modify): Change due to SelectionDirection.
(WebCore::DOMSelection::deleteFromDocument): Ditto.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleKeyboardSelectionMovement): Ditto.
* page/Frame.h: Includes SelectionController.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Thu, 23 Dec 2010 18:17:38 +0000 (18:17 +0000)]
2010-12-23 Lucas Forschler <lforschler@apple.com>
Reviewed by Darin Adler.
Bug 51537 - iexploder needs cleanup
* iExploder/htdocs: Removed.
* iExploder/htdocs/config.rb: Removed.
* iExploder/htdocs/cssproperties.in: Removed.
* iExploder/htdocs/cssvalues.in: Removed.
* iExploder/htdocs/htmlattrs.in: Removed.
* iExploder/htdocs/htmltags.in: Removed.
* iExploder/htdocs/htmlvalues.in: Removed.
* iExploder/htdocs/iexploder.cgi: Removed.
* iExploder/htdocs/iexploder.rb: Removed.
* iExploder/htdocs/index.html: Removed.
* iExploder/htdocs/webserver.rb: Removed.
* iExploder/iexploder-1.7.2/output: Removed.
* iExploder/tools: Removed.
* iExploder/tools/lasthit.rb: Removed.
* iExploder/tools/osx_last_crash.rb: Removed.
* iExploder/tools/showtest.rb: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 23 Dec 2010 18:16:02 +0000 (18:16 +0000)]
2010-12-23 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan.
Nothing happens clicking "launch live player" on live.cnn.com
https://bugs.webkit.org/show_bug.cgi?id=51540
<rdar://problem/8791086>
Implement NPN_PushPopupsEnabledState/NPN_PopPopupsEnabledState.
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_PushPopupsEnabledState):
Call NetscapePlugin::pushPopupsEnabledState.
(WebKit::NPN_PopPopupsEnabledState):
Call NetscapePlugin::popPopupsEnabledState.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pushPopupsEnabledState):
Append the boolean to the vector.
(WebKit::NetscapePlugin::popPopupsEnabledState):
Remove the last boolean from the vector.
(WebKit::NetscapePlugin::allowPopups):
Return the last boolean from the vector.
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performJavaScriptURLRequest):
Update the "allowPopupsFromPlugin" state.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 23 Dec 2010 17:45:08 +0000 (17:45 +0000)]
2010-12-23 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Move V8 to WebCore's implementation of showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=51527
This code is basically verbatim translation from the JavaScriptCore
bindings. The only intentional difference is in the world selection
for the dialog's frame. I suspect JavaScriptCore's bindings have a
subtle bug there.
In this patch, I also remove a bunch of now-unneeded code in the
generic bindings.
* bindings/generic/BindingDOMWindow.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::DialogHandler::dialogCreated):
(WebCore::setUpDialog):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::DialogHandler::DialogHandler):
(WebCore::DialogHandler::dialogCreated):
(WebCore::DialogHandler::returnValue):
(WebCore::setUpDialog):
(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):
* bindings/v8/specialization/V8BindingDOMWindow.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 23 Dec 2010 17:26:16 +0000 (17:26 +0000)]
2010-12-23 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: Can't backspace from CSS value to CSS key field
https://bugs.webkit.org/show_bug.cgi?id=51476
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.):
(WebInspector.StylePropertyTreeElement.prototype):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 23 Dec 2010 16:56:36 +0000 (16:56 +0000)]
2010-12-23 W. James MacLean <wjmaclean@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=51186
No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContentsIfDirty):
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
2010-12-23 W. James MacLean <wjmaclean@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=51186
Add asserts to detect if assumptions (about contiguous pixels in Skia bitmaps) are violated.
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 23 Dec 2010 16:53:35 +0000 (16:53 +0000)]
Add Windows-XP-specific (failing) expected results for
fast/profiler/throw-exception-from-eval-expected.html in order to get the Windows XP Debug
test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=49801
* platform/win-xp/fast/profiler: Added.
* platform/win-xp/fast/profiler/throw-exception-from-eval-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 23 Dec 2010 16:39:57 +0000 (16:39 +0000)]
2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Make 'single' the default backing store in EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=51534
'single' is the simplest backing store and the one intended to be the
default in the test browser. By mistake the tiled backing store was
left as default in r72617.
* EWebLauncher/main.c:
(browserCreate): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 23 Dec 2010 16:23:24 +0000 (16:23 +0000)]
2010-12-23 Dawit Alemayehu <adawit@kde.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add a 'hasSelection' function to QWebView and QWebPage.
https://bugs.webkit.org/show_bug.cgi?id=48722
This is a convenience API that optimizes the case where checking for
the presence of selected content and accessing the selected content
are two separate actions in the client. See comment #12 in the above
bug report link for details.
* Api/qwebpage.cpp:
(QWebPage::hasSelection):
* Api/qwebpage.h:
* Api/qwebview.cpp:
(QWebView::hasSelection):
* Api/qwebview.h:
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::textSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeremy@chromium.org [Thu, 23 Dec 2010 14:45:45 +0000 (14:45 +0000)]
2010-12-23 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed new Chromium baselines and test expectations update.
* platform/chromium-linux/fast/layers/video-layer-expected.checksum:
* platform/chromium-linux/fast/layers/video-layer-expected.png:
* platform/chromium-mac/fast/layers/video-layer-expected.checksum:
* platform/chromium-mac/fast/layers/video-layer-expected.png:
* platform/chromium-mac/fast/layers/video-layer-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/fast/layers/video-layer-expected.checksum:
* platform/chromium-win/fast/layers/video-layer-expected.png:
* platform/chromium-win/fast/layers/video-layer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 23 Dec 2010 14:41:31 +0000 (14:41 +0000)]
2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Fix ContextMenu removal
https://bugs.webkit.org/show_bug.cgi?id=51530
Fix ContextMenu removal
In r74207 the support for ContextMenu was removed from EFL while the
code is being ported to the new CROSS_PLATFORM_MENUS due to build
breakage. However there were some missing removals in the shutdown
logic that introduced a bug, leading to a segmentation fault when
ContexController was destroyed.
The best way to effectively disable the ContextMenu is to conditionally
compile the meaningful stuff by surrounding with "#if
ENABLE(CONTEXT_MENUS)" and then disabling it in CMake.
* cmake/OptionsEfl.cmake: Disable ContextMenu and don't pretend we
implement CROSS_PLATFORM_MENUS yet.
2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Fix ContextMenu removal
https://bugs.webkit.org/show_bug.cgi?id=51530
Fix ContextMenu removal
In r74207 the support for ContextMenu was removed from EFL while the
code is being ported to the new CROSS_PLATFORM_MENUS due to build
breakage. However there were some missing removals in the shutdown
logic that introduced a bug, leading to a segmentation fault when
ContexController was destroyed.
The best way to effectively disable the ContextMenu is to conditionally
compile the meaningful stuff by surrounding with "#if
ENABLE(CONTEXT_MENUS)" and then disabling it in CMake.
* ewk/ewk_contextmenu.cpp: surround need parts with #if
ENABLE(CONTEXT_MENUS).
(ewk_context_menu_destroy): ditto.
(ewk_context_menu_item_select): ditto.
* ewk/ewk_private.h: ditto.
* ewk/ewk_view.cpp: ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 23 Dec 2010 14:24:50 +0000 (14:24 +0000)]
2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Fix check by undefined macro
https://bugs.webkit.org/show_bug.cgi?id=51531
Fix check by undefined macro
When building EFL port with libsoup, BUILDING_GTK__ is not defined,
leading to warnings during compile. We actually have to use an #ifdef
instead of an #if.
No change in functionality so no new tests.
* platform/network/soup/cache/webkit/soup-cache.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 23 Dec 2010 14:08:31 +0000 (14:08 +0000)]
2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Clean warnings in Tiled Backing Store
https://bugs.webkit.org/show_bug.cgi?id=51529
Tiled backing store in EFL was giving the following warnings that are
gone now:
- Static function defined but not used;
- Comparison between signed and unsigned integer expressions;
* ewk/ewk_tiled_backing_store.c:
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_smart_calculate):
* ewk/ewk_tiled_matrix.c:
(_ewk_tile_matrix_slicer_setup):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 23 Dec 2010 13:49:46 +0000 (13:49 +0000)]
2010-12-23 Jonathan Dixon <joth@chromium.org>
Reviewed by Steve Block.
TouchEvents does not support multi-touch on a page with multiple touch targets
https://bugs.webkit.org/show_bug.cgi?id=51258
* fast/events/touch/multi-touch-grouped-targets-expected.txt: Added.
* fast/events/touch/multi-touch-grouped-targets.html: Added.
* fast/events/touch/script-tests/multi-touch-grouped-targets.js: Added.
(declareTouchHandler.return.shouldBe):
(declareTouchHandler):
(touchEndHandler):
Added new test that ensures both test targets receive events when hit by multiple
touch points from the same platform event.
* fast/events/touch/script-tests/touch-target-limited.js:
(declareTouchStart.return.touchStartHandler):
(declareTouchStart):
(declareTouchMove.return.touchMoveHandler):
(declareTouchMove):
* fast/events/touch/script-tests/touch-target.js:
(declareTouchStart.return.touchStartHandler):
(declareTouchStart):
(declareTouchMove.return.touchMoveHandler):
(declareTouchMove):
* fast/events/touch/touch-target-expected.txt:
* fast/events/touch/touch-target-limited-expected.txt:
Updated & rebaselined existing tests to reflect new expectations.
2010-12-23 Jonathan Dixon <joth@chromium.org>
Reviewed by Steve Block.
TouchEvents does not support multi-touch on a page with multiple touch targets
https://bugs.webkit.org/show_bug.cgi?id=51258
Test: fast/events/touch/multi-touch-grouped-targets.html
* page/EventHandler.cpp:
(WebCore::eventNameForTouchPointState):
(WebCore::EventHandler::handleTouchEvent):
Redesigned event handler to ensure all event targets involved in a given
multitouch event get the appropriate event(s) fired.
* platform/PlatformTouchPoint.h: Added end-stop marker for State enum.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 23 Dec 2010 13:23:04 +0000 (13:23 +0000)]
2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
https://bugs.webkit.org/show_bug.cgi?id=51533
There's no point in concatenating env("HOME") with "blah", so remove
option from EWebLauncher.
* EWebLauncher/main.c:
(main): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 23 Dec 2010 13:14:48 +0000 (13:14 +0000)]
2010-12-23 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] media/audio-data-url.html fails since r75504
https://bugs.webkit.org/show_bug.cgi?id=51525
Make the GStreamer media-player advertize 3gpp mime-types as
supported if the 3gp caps are in the typefind factories.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeremy@chromium.org [Thu, 23 Dec 2010 13:09:42 +0000 (13:09 +0000)]
2010-12-23 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed test expectations update.
Fix duplicate expectation warning for media/video-controls-rendering.html introduced in r74535.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 23 Dec 2010 12:56:55 +0000 (12:56 +0000)]
Refactor HTMLInputElement: Move a part of HTMLInputElement::defaultEventHandler()
to InputTypes.
https://bugs.webkit.org/show_bug.cgi?id=51093
Reviewed by Dimitri Glazkov.
Move BeforeTextInserted and Wheel event handling, event forwarding to
renderers, and the isindex form submission quirk code to InputTypes.
Also, change the return types of InputType event handlers from 'bool'
to 'void'. We use Event::defaultHandled() to decide whether event
handling should be stopped.
No new tests because this is just a refactoring.
* html/BaseButtonInputType.cpp: bool->void changes
(WebCore::BaseButtonInputType::handleKeydownEvent):
(WebCore::BaseButtonInputType::handleKeypressEvent):
(WebCore::BaseButtonInputType::handleKeyupEvent):
* html/BaseButtonInputType.h: ditto.
* html/BaseCheckableInputType.cpp: ditto.
(WebCore::BaseCheckableInputType::handleKeydownEvent):
(WebCore::BaseCheckableInputType::handleKeypressEvent):
* html/BaseCheckableInputType.h: ditto.
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::handleKeydownEvent): ditto.
(WebCore::BaseDateAndTimeInputType::handleWheelEvent): Just calls handleWheelEventForSpinButton().
* html/BaseDateAndTimeInputType.h: bool->void change and handleWhellEvent() addition.
* html/CheckboxInputType.cpp: bool->void change
(WebCore::CheckboxInputType::handleKeyupEvent):
* html/CheckboxInputType.h: ditto.
* html/FileInputType.cpp: ditto.
(WebCore::FileInputType::handleDOMActivateEvent):
* html/FileInputType.h: ditto.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
- Change return-value handling of InputType event handlers
- Move out beforeTextInserted/wheel event handling and isindex form quirk.
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
Added so that InputType can call InputElement::handleBeforeTextInsertedEvent().
* html/ImageInputType.cpp: bool->void change
(WebCore::ImageInputType::handleDOMActivateEvent):
* html/ImageInputType.h: ditto.
* html/InputType.cpp: ditto.
(WebCore::InputType::handleClickEvent):
(WebCore::InputType::handleDOMActivateEvent):
(WebCore::InputType::handleKeydownEvent):
(WebCore::InputType::handleKeypressEvent):
(WebCore::InputType::handleKeyupEvent):
(WebCore::InputType::handleBeforeTextInsertedEvent):
(WebCore::InputType::handleWheelEvent): Added default implementation.
(WebCore::InputType::forwardEvent): ditto.
(WebCore::InputType::formForSubmission): ditto.
* html/InputType.h:
* html/IsIndexInputType.cpp:
(WebCore::IsIndexInputType::formForSubmission): Moved from HTMLInputElement.cpp.
* html/IsIndexInputType.h:
* html/NumberInputType.cpp:
(WebCore::isNumberCharacter): Moved from HTMLInputElement.cpp.
(WebCore::NumberInputType::handleKeydownEvent): bool->void change.
(WebCore::NumberInputType::handleBeforeTextInsertedEvent): Moved from HTMInputElement.cpp.
(WebCore::NumberInputType::handleWheelEvent): Added. Just calls handleWheelEventForSpinButton().
* html/NumberInputType.h:
* html/RadioInputType.cpp: bool->void changes.
(WebCore::RadioInputType::handleClickEvent):
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::handleKeyupEvent):
* html/RadioInputType.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::forwardEvent): Moved from HTMLInputElement.cpp.
* html/RangeInputType.h:
* html/ResetInputType.cpp: bool->void change.
(WebCore::ResetInputType::handleDOMActivateEvent):
* html/ResetInputType.h: ditto.
* html/SubmitInputType.cpp: ditto.
(WebCore::SubmitInputType::handleDOMActivateEvent):
* html/SubmitInputType.h: ditto.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleKeydownEvent): bool->void change.
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto.
(WebCore::TextFieldInputType::handleWheelEventForSpinButton): Moved from HTMLInputElement.cpp.
(WebCore::TextFieldInputType::forwardEvent): ditto.
* html/TextFieldInputType.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 23 Dec 2010 11:12:09 +0000 (11:12 +0000)]
2010-12-23 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: After scrolling new property value and cancelling, removed property remains active in page style
https://bugs.webkit.org/show_bug.cgi?id=51390
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 23 Dec 2010 10:38:19 +0000 (10:38 +0000)]
Unreviewed. Update Qt specific expected file after r74539.
* platform/qt/fast/dom/Window/window-properties-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 23 Dec 2010 10:20:53 +0000 (10:20 +0000)]
2010-12-23 Benjamin Kalman <kalman@chromium.org>
Reviewed by Eric Seidel.
QT linux has RTL line movement bug that causes editing/selection/extend-to-line-boundary.html to fail
https://bugs.webkit.org/show_bug.cgi?id=51514
Add different baseline to editing/selection/extend-to-line-boundary.html for qt-linux that
takes into account the RTL bug.
* platform/qt-linux/editing/selection/extend-to-line-boundary-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 23 Dec 2010 09:54:13 +0000 (09:54 +0000)]
Not reviewed.
Another attempt.
* http/tests/local/slow-css-pass.cgi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log