WebKit-https.git
18 years agoWebCore:
sullivan [Mon, 22 Dec 2003 19:32:49 +0000 (19:32 +0000)]
WebCore:

- WebCore part of fix for <rdar://problem/3515706>:
REGRESSION (100-118): Web Kit printing does not honor Page Setup scale factor

        Reviewed by Darin.

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge computePageRectsWithPrintWidth:printHeight:]):
renamed method for clarity; now iterates over pages horizontally as well
as vertically; assume x starts at 0 as we were already assuming that y
starts at 0; now returns autoreleased result

WebKit:

- WebKit part of fix for <rdar://problem/3515706>:
REGRESSION (100-118): Web Kit printing does not honor Page Setup scale factor

        Reviewed by Darin.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _userScaleFactorForPrintOperation:]):
new method, extracts the scale factor provided by the user in
the Page Setup dialog
        (-[WebHTMLView _scaleFactorForPrintOperation:]):
take user scale factor into account
        (-[WebHTMLView knowsPageRange:]):
renamed local var scaleFactor -> totalScaleFactor for clarity;
take user scale factor into account for print width; now assumes
        computePageRects returns autoreleased result.

        * WebKit.pbproj/project.pbxproj:
Xcode version wars; Darin says these don't affect the build.

WebBrowser:

        Reviewed by Darin.

        * WebBrowser.pbproj/project.pbxproj:
Xcode version wars; Darin says these don't affect the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Mon, 22 Dec 2003 19:26:16 +0000 (19:26 +0000)]
    Reviewed by John.

        - follow-on to my fix for 3467919: handle collapsed spaces at the starts of runs too, not just at the
          end, and make sure that a space inherits style from the run it was collapsed from rather than always
          from the run it precedes

        * khtml/khtml_part.cpp: (KHTMLPart::text): Add code to deal with collapsed spaces at the start of runs.
        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Change code to keep the style of a space that
        was collapsed at the end of the run, and use that styled space if necessary. Also add the code to deal
        with collapsed spaces at the start of runs. Also remove comment that refers to long-since-deleted code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Mon, 22 Dec 2003 17:42:56 +0000 (17:42 +0000)]
    Reviewed by John.

        - fixed 3467919: REGRESSION (91-92): space missing when copying text with link at start or end of line

        * khtml/khtml_part.cpp: (KHTMLPart::text):
        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
        Changed both "turn HTML into text" code paths to generate spaces in a different way.
        First, corrected the logic so it notices spaces left out at the end of a RenderText object.
        Second, don't emit the space until we are emitting more text, to prevent emitting trailing
        spaces. To get this completely right for the attributed string case, I had to add code to
        adjust the offset used to mark links.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Mon, 22 Dec 2003 17:40:38 +0000 (17:40 +0000)]
    Reviewed by John.

        - fixed 3477453: nowrap in a fixed-width TD is ignored on screen but not when printed (Williams-Sonoma)

        * khtml/rendering/render_table.cpp: (RenderTableCell::setStyle):
        Compute the proper whitespace mode before calling the base class setStyle,
        since the base class setStyle may create styles that inherit from our style,
        and we want them to inherit the computed whitespace mode.

        * WebCore.pbproj/project.pbxproj: Let Xcode be 1.1, as it was meant to be.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Sun, 21 Dec 2003 20:42:30 +0000 (20:42 +0000)]
    Reviewed by John.

        - fixed a storage leak

        * WebView.subproj/WebFrame.m:
        (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        Move the release of the request out of an if statement, since it's always needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Sun, 21 Dec 2003 20:40:23 +0000 (20:40 +0000)]
    Reviewed by Dave.

        - fixed a storage leak

        * khtml/rendering/render_style.h: Added a destructor and a private unimplemented assignment
        operator to StyleCSS3InheritedData, since the textShadow field that needs to be allocated
        and deallocated and the default destructor and assignment operator don't do that.
        * khtml/rendering/render_style.cpp: (StyleCSS3InheritedData::~StyleCSS3InheritedData):
        Added destructor that deletes the textShadow object.

        - fixed locking for JavaScript debugging tools in Caches window

        * kwq/WebCoreJavaScript.mm:
        (+[WebCoreJavaScript rootObjectClasses]): Lock and unlock around call to JavaScriptCore.
        (+[WebCoreJavaScript garbageCollect]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3483130, repaint doesn't occur when font is decreased dynamically when at...
hyatt [Sat, 20 Dec 2003 05:16:32 +0000 (05:16 +0000)]
Fix for 3483130, repaint doesn't occur when font is decreased dynamically when at the bottom of
amazon.com.

        Reviewed by john

        * khtml/khtml_part.cpp:
        (KHTMLPart::setZoomFactor):
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge setTextSizeMultiplier:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3515590. Return Undefined to JS for applet if
rjw [Fri, 19 Dec 2003 23:06:41 +0000 (23:06 +0000)]
Fixed 3515590.  Return Undefined to JS for applet if
Java is disabled.

        Reviewed by Chris.

        * khtml/html/html_objectimpl.cpp:
        (HTMLAppletElementImpl::getAppletInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3515597. When an error occurs we need
rjw [Fri, 19 Dec 2003 21:55:27 +0000 (21:55 +0000)]
Fixed 3515597.  When an error occurs we need
to make sure result values are zeroed.

Cleaned up logs by adding a newline.

        Reviewed by John.

        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::getJavaVM):
        (KJS::Bindings::getJNIEnv):
        (callJNIMethod):
        (callJNIMethodA):
        (KJS::Bindings::getJNIField):
        * bindings/jni_jsobject.cpp:
        (JSObject::convertValueToJObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Chris.
mjs [Fri, 19 Dec 2003 21:25:31 +0000 (21:25 +0000)]
    Reviewed by Chris.

<rdar://problem/3512545>: reproducible assertion failure in KWQKHTMLPart::addData scrolling to anchor while page loads

* kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::scrollToAnchor): Don't pretend we finished loading,
because we don't actually make anchor scrolling stop the current
page load.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3515255>: Standalone image drag makes ocassionally makes...
cblu [Fri, 19 Dec 2003 17:59:05 +0000 (17:59 +0000)]
Fixed: <rdar://problem/3515255>: Standalone image drag makes ocassionally makes 2 copies

        Reviewed by john.

* WebKit.pbproj/project.pbxproj: Xcode 1.1 file format change
        * WebView.subproj/WebImageView.h:
        * WebView.subproj/WebImageView.m: copied double-drag protection code from WebHTMLView
        (-[WebImageView mouseDown:]): set ignoringMouseDraggedEvents to NO
        (-[WebImageView mouseDragged:]): if ignoringMouseDraggedEvents, return
        (-[WebImageView draggedImage:endedAt:operation:]): set ignoringMouseDraggedEvents to YES

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago*** empty log message ***
vicki [Fri, 19 Dec 2003 17:46:35 +0000 (17:46 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agotop level:
vicki [Fri, 19 Dec 2003 17:37:48 +0000 (17:37 +0000)]
top level:

        Reviewed by me

        * Site/Internal/Design/html-editing-tasks.fp5: Added.

Tools:

- disallow installation on 10.3.2 and later; update strings with better error messages

* Install_resources/InstallationCheck:
        * Install_resources/InstallationCheck.strings:

JavaScriptCore:

Ensure that all the symbols we export are in the KJS
namespace (3512245).

Also renamed JavaString.characters() to JavaString.UTF8String()
for enhanced clarity.

Added some sanity checking to constructor of JObjectWrapper.

        Reviewed by Dave.

        * ChangeLog:
        * bindings/jni/jni_class.cpp:
        * bindings/jni/jni_class.h:
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        (JObjectWrapper::JObjectWrapper):
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        (JavaParameter::JavaParameter):
        (JavaField::JavaField):
        (JavaMethod::JavaMethod):
        (JavaMethod::signature):
        * bindings/jni/jni_runtime.h:
        (KJS::Bindings::JavaString::ascii):
        (KJS::Bindings::JavaString::UTF8String):
        (KJS::Bindings::JavaString::JavaString):
        (KJS::Bindings::JavaString::_commonInit):
        (KJS::Bindings::JavaString::uchars):
        (KJS::Bindings::JavaString::length):
        (KJS::Bindings::JavaString::ustring):
        (KJS::Bindings::JavaParameter::type):
        (KJS::Bindings::JavaField::name):
        (KJS::Bindings::JavaField::type):
        (KJS::Bindings::JavaMethod::name):
        (KJS::Bindings::JavaMethod::returnType):
        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::getJavaVM):
        (KJS::Bindings::getJNIEnv):
        (KJS::Bindings::callJNIVoidMethod):
        (KJS::Bindings::callJNIObjectMethod):
        (KJS::Bindings::callJNIBooleanMethod):
        (KJS::Bindings::callJNIByteMethod):
        (KJS::Bindings::callJNICharMethod):
        (KJS::Bindings::callJNIShortMethod):
        (KJS::Bindings::callJNIIntMethod):
        (KJS::Bindings::callJNILongMethod):
        (KJS::Bindings::callJNIFloatMethod):
        (KJS::Bindings::callJNIDoubleMethod):
        (KJS::Bindings::callJNIVoidMethodA):
        (KJS::Bindings::callJNIObjectMethodA):
        (KJS::Bindings::callJNIByteMethodA):
        (KJS::Bindings::callJNICharMethodA):
        (KJS::Bindings::callJNIShortMethodA):
        (KJS::Bindings::callJNIIntMethodA):
        (KJS::Bindings::callJNILongMethodA):
        (KJS::Bindings::callJNIFloatMethodA):
        (KJS::Bindings::callJNIDoubleMethodA):
        (KJS::Bindings::callJNIBooleanMethodA):
        (KJS::Bindings::getCharactersFromJString):
        (KJS::Bindings::releaseCharactersForJString):
        (KJS::Bindings::getCharactersFromJStringInEnv):
        (KJS::Bindings::releaseCharactersForJStringInEnv):
        (KJS::Bindings::getUCharactersFromJStringInEnv):
        (KJS::Bindings::releaseUCharactersForJStringInEnv):
        (KJS::Bindings::JNITypeFromClassName):
        (KJS::Bindings::signatureFromPrimitiveType):
        (KJS::Bindings::JNITypeFromPrimitiveType):
        (KJS::Bindings::getJNIField):
        (KJS::Bindings::convertValueToJValue):
        * bindings/jni/jni_utility.h:
        * bindings/jni_jsobject.cpp:
        (KJS::Bindings::JSObject::invoke):
        (KJS::Bindings::JSObject::JSObject):
        (KJS::Bindings::JSObject::call):
        (KJS::Bindings::JSObject::eval):
        (KJS::Bindings::JSObject::getMember):
        (KJS::Bindings::JSObject::setMember):
        (KJS::Bindings::JSObject::removeMember):
        (KJS::Bindings::JSObject::getSlot):
        (KJS::Bindings::JSObject::setSlot):
        (KJS::Bindings::JSObject::toString):
        (KJS::Bindings::JSObject::finalize):
        (KJS::Bindings::JSObject::createNative):
        (KJS::Bindings::JSObject::convertValueToJObject):
        (KJS::Bindings::JSObject::convertJObjectToValue):
        (KJS::Bindings::JSObject::listFromJArray):
        * bindings/jni_jsobject.h:
        * bindings/runtime.cpp:
        * bindings/runtime.h:
        * bindings/runtime_method.cpp:
        * bindings/runtime_method.h:

Tests:

        LiveConnect:  Added tests for JavaScript to Java
        array access.

        Reviewed by John.

        * LiveConnect/Blink/Blink.java:
        (Blink):
        (Blink.init):
        * LiveConnect/Blink/test.html:

WebCore:

Fixed 3511415.  We have to un-visually order visually ordered text
before passing to ATSU.

        Reviewed by John.

        * khtml/rendering/font.cpp:
        (Font::drawHighlightForText):
        (Font::drawText):
        * khtml/rendering/font.h:
        * khtml/rendering/render_text.cpp:
        (InlineTextBox::paintSelection):
        (RenderText::paintObject):
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        (QPainter::drawText):
        (QPainter::drawHighlightForText):
        * kwq/WebCoreTextRenderer.h:
        * kwq/WebCoreTextRendererFactory.m:
        (WebCoreInitializeEmptyTextStyle):

WebKit:

Fixed 3511415.  We have to un-visually order visually ordered text
before passing to ATSU.

        Reviewed by John.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (reverseCharactersInRun):
        (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

WebBrowser:

        Reviewed by Chris

        * BrowserNSDataExtras.m:
        (-[NSData certificateFromMultipartData]): Fix off-by-one error
in code to strip trailing CRLFs off certificate data.

WebKitExamples:

Fixed 3455347.  WEBVIEW: Dragging links from a Carbon HIWebView crash with NSException raise
Written be Ed.  This code is often copy/pasted by developers, so this problem propagates.

        Reviewed by Richard.

        * CarbonWeb/CarbonWeb.pbproj/project.pbxproj:
        * CarbonWeb/TWebWindow.cp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebKit:
rjw [Thu, 18 Dec 2003 23:14:44 +0000 (23:14 +0000)]
WebKit:
Fixed 3511415.  We have to un-visually order visually ordered text
before passing to ATSU.

        Reviewed by John.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (reverseCharactersInRun):
        (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

WebCore:
Fixed 3511415.  We have to un-visually order visually ordered text
before passing to ATSU.

        Reviewed by John.

        * khtml/rendering/font.cpp:
        (Font::drawHighlightForText):
        (Font::drawText):
        * khtml/rendering/font.h:
        * khtml/rendering/render_text.cpp:
        (InlineTextBox::paintSelection):
        (RenderText::paintObject):
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        (QPainter::drawText):
        (QPainter::drawHighlightForText):
        * kwq/WebCoreTextRenderer.h:
        * kwq/WebCoreTextRendererFactory.m:
        (WebCoreInitializeEmptyTextStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFixed build problem resulting from addition of KJS to Bindings namespace.
rjw [Thu, 18 Dec 2003 03:56:28 +0000 (03:56 +0000)]
Fixed build problem resulting from addition of KJS to Bindings namespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Ensure that all the symbols we export are in the KJS
rjw [Thu, 18 Dec 2003 02:49:17 +0000 (02:49 +0000)]
Ensure that all the symbols we export are in the KJS
namespace (3512245).

Also renamed JavaString.characters() to JavaString.UTF8String()
for enhanced clarity.

Added some sanity checking to constructor of JObjectWrapper.

        Reviewed by Dave.

        * ChangeLog:
        * bindings/jni/jni_class.cpp:
        * bindings/jni/jni_class.h:
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        (JObjectWrapper::JObjectWrapper):
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        (JavaParameter::JavaParameter):
        (JavaField::JavaField):
        (JavaMethod::JavaMethod):
        (JavaMethod::signature):
        * bindings/jni/jni_runtime.h:
        (KJS::Bindings::JavaString::ascii):
        (KJS::Bindings::JavaString::UTF8String):
        (KJS::Bindings::JavaString::JavaString):
        (KJS::Bindings::JavaString::_commonInit):
        (KJS::Bindings::JavaString::uchars):
        (KJS::Bindings::JavaString::length):
        (KJS::Bindings::JavaString::ustring):
        (KJS::Bindings::JavaParameter::type):
        (KJS::Bindings::JavaField::name):
        (KJS::Bindings::JavaField::type):
        (KJS::Bindings::JavaMethod::name):
        (KJS::Bindings::JavaMethod::returnType):
        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::getJavaVM):
        (KJS::Bindings::getJNIEnv):
        (KJS::Bindings::callJNIVoidMethod):
        (KJS::Bindings::callJNIObjectMethod):
        (KJS::Bindings::callJNIBooleanMethod):
        (KJS::Bindings::callJNIByteMethod):
        (KJS::Bindings::callJNICharMethod):
        (KJS::Bindings::callJNIShortMethod):
        (KJS::Bindings::callJNIIntMethod):
        (KJS::Bindings::callJNILongMethod):
        (KJS::Bindings::callJNIFloatMethod):
        (KJS::Bindings::callJNIDoubleMethod):
        (KJS::Bindings::callJNIVoidMethodA):
        (KJS::Bindings::callJNIObjectMethodA):
        (KJS::Bindings::callJNIByteMethodA):
        (KJS::Bindings::callJNICharMethodA):
        (KJS::Bindings::callJNIShortMethodA):
        (KJS::Bindings::callJNIIntMethodA):
        (KJS::Bindings::callJNILongMethodA):
        (KJS::Bindings::callJNIFloatMethodA):
        (KJS::Bindings::callJNIDoubleMethodA):
        (KJS::Bindings::callJNIBooleanMethodA):
        (KJS::Bindings::getCharactersFromJString):
        (KJS::Bindings::releaseCharactersForJString):
        (KJS::Bindings::getCharactersFromJStringInEnv):
        (KJS::Bindings::releaseCharactersForJStringInEnv):
        (KJS::Bindings::getUCharactersFromJStringInEnv):
        (KJS::Bindings::releaseUCharactersForJStringInEnv):
        (KJS::Bindings::JNITypeFromClassName):
        (KJS::Bindings::signatureFromPrimitiveType):
        (KJS::Bindings::JNITypeFromPrimitiveType):
        (KJS::Bindings::getJNIField):
        (KJS::Bindings::convertValueToJValue):
        * bindings/jni/jni_utility.h:
        * bindings/jni_jsobject.cpp:
        (KJS::Bindings::JSObject::invoke):
        (KJS::Bindings::JSObject::JSObject):
        (KJS::Bindings::JSObject::call):
        (KJS::Bindings::JSObject::eval):
        (KJS::Bindings::JSObject::getMember):
        (KJS::Bindings::JSObject::setMember):
        (KJS::Bindings::JSObject::removeMember):
        (KJS::Bindings::JSObject::getSlot):
        (KJS::Bindings::JSObject::setSlot):
        (KJS::Bindings::JSObject::toString):
        (KJS::Bindings::JSObject::finalize):
        (KJS::Bindings::JSObject::createNative):
        (KJS::Bindings::JSObject::convertValueToJObject):
        (KJS::Bindings::JSObject::convertJObjectToValue):
        (KJS::Bindings::JSObject::listFromJArray):
        * bindings/jni_jsobject.h:
        * bindings/runtime.cpp:
        * bindings/runtime.h:
        * bindings/runtime_method.cpp:
        * bindings/runtime_method.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3503011 (really, this time). Always use integer width for '-' and '?', as...
rjw [Thu, 18 Dec 2003 01:41:41 +0000 (01:41 +0000)]
Fixed 3503011 (really, this time).  Always use integer width for '-' and '?', as we do for spaces, to ensure that 'words' (as defined by out rounding hack) start on integer boundaries.

        Reviewed by John.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (widthForNextCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed:
cblu [Thu, 18 Dec 2003 00:44:19 +0000 (00:44 +0000)]
Fixed:
<rdar://problem/3393758>: REGRESSION (85-100): Flash onKeyUp event non-functional
<rdar://problem/3479020>: REGRESSION (85-100): Safari sends plug-in key events to wrong instance of plug-in

        Reviewed by darin.

        * Plugins.subproj/WebBaseNetscapePluginView.h:
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView sendEvent:]): set suspendKeyUpEvents to NO
        (-[WebBaseNetscapePluginView keyMessageForEvent:]): copied from CVS
        (-[WebBaseNetscapePluginView keyUp:]): if !suspendKeyUpEvents, send the keyUp event
        (-[WebBaseNetscapePluginView keyDown:]): set suspendKeyUpEvents to YES
        (-[WebBaseNetscapePluginView windowBecameKey:]): call SetUserFocusWindow

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Richard.
darin [Thu, 18 Dec 2003 00:38:32 +0000 (00:38 +0000)]
    Reviewed by Richard.

        - fixed 3513274: REGRESSION: anchor navigation within frames with "Back" is broken at tivofaq.com

        * WebView.subproj/WebDataSource.m: (-[WebDataSource _setURL:]):
        Since this method is only used when you do a fragment scroll, we need to update
        the original request as well as the request. This ensure that the fragment gets
        recorded in the history item (which goes in the back/forward history).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Wed, 17 Dec 2003 23:48:54 +0000 (23:48 +0000)]
    Reviewed by Dave.

        - fixed 3469085: can't tab to all links on aintitcool.com

        * khtml/html/html_inlineimpl.cpp:
        (HTMLAnchorElementImpl::isFocusable): Re-implemented this to check width and height of
        all continuations, not just the main render object. Also, check the absoluteRects after
        checking all the render objects to catch things like floats.
        (HTMLAnchorElementImpl::isMouseFocusable): Clean up the code here a bit.

        * khtml/rendering/render_inline.h:
        * khtml/rendering/render_inline.cpp: (RenderInline::absoluteRects):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_object.cpp: (RenderObject::absoluteRects):
        * khtml/rendering/render_text.h:
        * khtml/rendering/render_text.cpp: (RenderText::absoluteRects):
        * kwq/KWQAccObject.mm: (boundingBoxRect):
        Use QValueList instead of QPtrList for clarity and to fix storage leaks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoThe tree is open for Safari-119!
vicki [Wed, 17 Dec 2003 18:45:03 +0000 (18:45 +0000)]
The tree is open for Safari-119!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-118 stamp
vicki [Wed, 17 Dec 2003 18:25:13 +0000 (18:25 +0000)]
Safari-118 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed <rdar://problem/3512801>: REGRESSION (Safari 100-116):
sullivan [Wed, 17 Dec 2003 17:36:57 +0000 (17:36 +0000)]
    - fixed <rdar://problem/3512801>: REGRESSION (Safari 100-116):
        Mike Hay's Magic 8-ball game ignores slow clicks

        Reviewed by Darin.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _handleAutoscrollForMouseDragged:]):
        start the autoscroll timer here, so the timer only runs when KHTML is
        handling the event.
        (-[WebHTMLView mouseDown:]):
        don't start the autoscroll timer here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by me
kocienda [Wed, 17 Dec 2003 04:03:09 +0000 (04:03 +0000)]
    Reviewed by me

        * WebCoreSupport.subproj/WebBridge.m: ObjC runtime needs a declaration for new
_calculatedExpiration SPI in NSURLResponse in Foundation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3512348: Rewrote _CG_drawHighlightForRun:style:atPoint: to use width
rjw [Wed, 17 Dec 2003 03:21:37 +0000 (03:21 +0000)]
Fixed 3512348:  Rewrote _CG_drawHighlightForRun:style:atPoint: to use width
iterators.  Much faster, better cheaper, etc.

        Reviewed by Dave.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3510956, crash on mezzoblue.com. Relax the float-list searching code that...
hyatt [Wed, 17 Dec 2003 01:46:18 +0000 (01:46 +0000)]
Fix for 3510956, crash on mezzoblue.com.  Relax the float-list searching code that runs when
a float is removed.

        Reviewed by darin

        * khtml/rendering/render_object.cpp:
        (checkFloats):
        (RenderObject::removeFromObjectLists):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3503011. Added '-' and '?' to rounding hack.
rjw [Wed, 17 Dec 2003 01:33:45 +0000 (01:33 +0000)]
Fixed 3503011.  Added '-' and '?' to rounding hack.

        Reviewed by John.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (isRoundingHackCharacter):
        (widthForNextCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Richard.
darin [Wed, 17 Dec 2003 01:30:12 +0000 (01:30 +0000)]
    Reviewed by Richard.

        - finished fix to 3109132: can't open movie file via open panel

        * WebView.subproj/WebView.m: (+[WebView _supportedFileExtensions]):
        Include all the extensions for each MIME type, not jus the preferred one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin
kocienda [Wed, 17 Dec 2003 00:53:37 +0000 (00:53 +0000)]
    Reviewed by Darin

Fix for this bug:

<rdar://problem/3512199>: WebBridge expiresTimeForResponse can be
improved to use better expiration calculations

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge expiresTimeForResponse:]): Switch to use new
_calculatedExpiration SPI method on NSURLResponse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Ack! More assertions. Lock ALL entry points into the interpreter!
rjw [Tue, 16 Dec 2003 21:19:03 +0000 (21:19 +0000)]
Ack!  More assertions.  Lock ALL entry points into the interpreter!
(3511733).

        Reviewed by Ken.

        * bindings/jni_jsobject.cpp:
        (Bindings::JSObject::call):
        (Bindings::JSObject::eval):
        (Bindings::JSObject::getMember):
        (Bindings::JSObject::setMember):
        (Bindings::JSObject::removeMember):
        (Bindings::JSObject::getSlot):
        (Bindings::JSObject::setSlot):
        (Bindings::JSObject::convertJObjectToValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago fixed <rdar://problem/3482852>: oft-seen, non-repro, nil-deref in
sullivan [Tue, 16 Dec 2003 19:33:46 +0000 (19:33 +0000)]
    fixed <rdar://problem/3482852>: oft-seen, non-repro, nil-deref in
        HTMLTokenizer::notifyFinished (snapfish.com, etc.)

        At least one of the dupes of this bug is a separate (still reproducible) issue;
        I'll clone it back to life and test the others.

        Reviewed by Darin.

        * khtml/html/htmltokenizer.cpp:
        (HTMLTokenizer::notifyFinished):
        Move check of cachedScript.isEmpty() until after scriptExecution()
        call, because cachedScript.isEmpty() value can be changed by that call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed a couple of snafus and removed some logging.
rjw [Tue, 16 Dec 2003 06:24:55 +0000 (06:24 +0000)]
Fixed a couple of snafus and removed some logging.

        Reviewed by Maciej.

        * bindings/jni_jsobject.cpp:
        (Bindings::performJavaScriptAccess):
        (Bindings::completedJavaScriptAccess):
        (Bindings::dispatchToJavaScriptThread):
Removed some annoying JS_LOG clutter.

        (Bindings::RootObject::removeAllJavaReferencesForRoot):
Fixed allocation of key buffer that was called after it was needed.

        (Bindings::JSObject::invoke):
        (Bindings::JSObject::JSObject):
        (Bindings::JSObject::getMember):
        (Bindings::JSObject::getSlot):
Added additional interpreter locks around getMember and getSlot.
These functions may cause allocation of JS impls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago args weren't passed to 'call' invocation. d'oh.
rjw [Tue, 16 Dec 2003 01:27:59 +0000 (01:27 +0000)]
args weren't passed to 'call' invocation.  d'oh.
lock interpreter when we create instances of JS impls.

        Reviewed by Maciej.

        * bindings/jni_jsobject.cpp:
        (Bindings::JSObject::call):
        (Bindings::JSObject::eval):
        (Bindings::JSObject::getMember):
        (Bindings::JSObject::setMember):
        (Bindings::JSObject::getSlot):
        (Bindings::JSObject::convertValueToJObject):
        (Bindings::JSObject::convertJObjectToValue):
        (Bindings::JSObject::listFromJArray):
        * bindings/jni_jsobject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3508807, positions/sizes wrong for text elts and multi-line elts for accessi...
hyatt [Tue, 16 Dec 2003 00:45:11 +0000 (00:45 +0000)]
Fix for 3508807, positions/sizes wrong for text elts and multi-line elts for accessibility.

        Reviewed by john

        * khtml/rendering/render_inline.cpp:
        (RenderInline::absoluteRects):
        * khtml/rendering/render_inline.h:
        * khtml/rendering/render_object.cpp:
        (RenderObject::absoluteRects):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_text.cpp:
        (RenderText::absoluteRects):
        * khtml/rendering/render_text.h:
        * kwq/KWQAccObject.mm:
        (boundingBoxRect):
        (-[KWQAccObject position]):
        (-[KWQAccObject size]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoJavaScriptCore:
rjw [Mon, 15 Dec 2003 23:14:03 +0000 (23:14 +0000)]
JavaScriptCore:
Last piece of LiveConnect!  This checkin adds implementation
of the Java to JavaScript object conversion functions.

        Reviewed by John.

        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bindings/jni/jni_utility.cpp:
        * bindings/jni/jni_utility.h:
        * bindings/jni_jsobject.cpp:
        (Bindings::JSObject::invoke):
        (Bindings::JSObject::call):
        (Bindings::JSObject::eval):
        (Bindings::JSObject::getMember):
        (Bindings::JSObject::setMember):
        (Bindings::JSObject::getSlot):
        (Bindings::JSObject::setSlot):
        (Bindings::JSObject::createNative):
        (Bindings::JSObject::convertValueToJObject):
        (Bindings::JSObject::convertJObjectToValue):
        (Bindings::JSObject::listFromJArray):
        * bindings/jni_jsobject.h:
        (Bindings::):
        * bindings/runtime_method.cpp:
        (RuntimeMethodImp::get):
        (RuntimeMethodImp::codeType):
        (RuntimeMethodImp::execute):

WebCore:
Return 0 if the view doesn't have a bridge.

        Reviewed by John.

        * kwq/WebCoreBridge.mm:
        (rootForView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3505546>: always get keychain prompt when sending mail using...
cblu [Mon, 15 Dec 2003 21:44:54 +0000 (21:44 +0000)]
Fixed: <rdar://problem/3505546>: always get keychain prompt when sending mail using cert downloaded with Safari

        Reviewed by john.

        * WebCoreSupport.subproj/WebKeyGeneration.cpp:
        (signedPublicKeyAndChallengeString): set up the SecAccessRef with "everything goes" restrictions

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3508792. Remove tables and cells as AxObjects.
hyatt [Mon, 15 Dec 2003 21:38:20 +0000 (21:38 +0000)]
Fix for 3508792.  Remove tables and cells as AxObjects.

        Reviewed by john

        * kwq/KWQAccObject.mm:
        (-[KWQAccObject role]):
        (-[KWQAccObject accessibilityIsIgnored]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed <rdar://problem/3510459>: REGRESSION (100-113): Pressing button at...
sullivan [Mon, 15 Dec 2003 21:28:27 +0000 (21:28 +0000)]
    - fixed <rdar://problem/3510459>: REGRESSION (100-113): Pressing button at google.com
        removes focus from text field

        Reviewed by Dave.

        * khtml/khtmlview.cpp:
        (KHTMLView::dispatchMouseEvent):
        Don't clear the focused widget when a mousedown occurs on a widget that is focusable
        in the abstract sense but is not mouse focusable or currently keyboard focusable. This
        matches the behavior of older Safaris (clicking in background or page text will make the
        webview itself be first responder, but clicking on a button won't).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
darin [Mon, 15 Dec 2003 04:58:58 +0000 (04:58 +0000)]
    Reviewed by Maciej.

        - fixed 3458937: nil-deref in timed layout

        * khtml/khtmlview.cpp: (KHTMLView::layout): Add a nil check for m_part.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
darin [Mon, 15 Dec 2003 00:46:46 +0000 (00:46 +0000)]
WebCore:

        Reviewed by Maciej.

        - fixed 3311205: click() on a file input type form element does not work bring up the file chooser as it does in IE

        * khtml/html/html_formimpl.cpp:
        (HTMLInputElementImpl::click): Add a case for FILE that calls RenderFileButton's click() function.
        Get rid of the default case and list more cases explicitly.
        (HTMLInputElementImpl::accessKeyAction): Change FILE from just focus to focus/click.

        * khtml/rendering/render_form.h: Added a click() function to RenderFileButton.
        * khtml/rendering/render_form.cpp:
        (RenderFileButton::slotTextChanged): Added call to onChange on the element to match text input
        fields; helpful for the test case Adobe supplied.
        (RenderFileButton::click): Added. Calls click() on KWQFileButton.

        * kwq/KWQFileButton.h: Added a click function.
        * kwq/KWQFileButton.mm: (KWQFileButton::click): Added. Calls performClick on the file button.

        * kwq/WebCoreBridge.h: Add a performClick method to WebCoreFileButton.

WebKit:

        Reviewed by Maciej.

        - fixed 3311205: click() on a file input type form element does not work bring up the file chooser as it does in IE

        * WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton performClick]):
        Add method for clicking, now part of the WebCoreFileButton protocol.
        The rest of the fix is in WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
mjs [Sun, 14 Dec 2003 23:50:33 +0000 (23:50 +0000)]
    Reviewed by Darin.

<rdar://problem/3269212>: FILEMAKER: can't use Option objects created in a different window

        * khtml/ecma/kjs_binding.cpp:
        (ScriptInterpreter::updateDOMObjectDocument): Update per-document
caching for the DOM object - let it be protected by both the old
and the new document.
        * khtml/ecma/kjs_binding.h: Prototype new method.
        * khtml/xml/dom_nodeimpl.cpp:
        (NodeImpl::setDocument): New method to change a node's document pointer.
        (NodeImpl::checkAddChild): If the new child node is owned by the
wrong document but not actually in it, change its document (using
the two aforementioned methods) instead of throwing an exception.
* khtml/xml/dom_nodeimpl.h: Prototype new method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
darin [Sun, 14 Dec 2003 17:10:12 +0000 (17:10 +0000)]
    Reviewed by Maciej.

        - fixed 3332280: REGRESSION (74-85): setting src of iframe results in two GETs

        * khtml/html/html_baseimpl.h: Added openURL virtual function.
        * khtml/html/html_baseimpl.cpp:
        (HTMLFrameElementImpl::updateForNewURL): Call openURL to do the meat of the work,
        since it's different for frames and iframes.
        (HTMLFrameElementImpl::openURL): Move the part that's different for frames in here.
        (HTMLFrameElementImpl::parseAttribute): Call setLocation to share code.
        (HTMLFrameElementImpl::setLocation): Do nothing if the location is not changing.
        Not needed to fix this bug, but could eliminate other cases of extra GETs.
        (HTMLIFrameElementImpl::parseAttribute): Remove special handling of SRC, because now
        we will end up calling openURL, which will do the right thing for iframes.
        (HTMLIFrameElementImpl::openURL): Instead of doing the change to the frame directly,
        use updateWidget, since that's what we do for other changes to iframes. To trigger a
        call to updateWidget(), set needWidgetUpdate and mark the node changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
mjs [Sun, 14 Dec 2003 06:43:46 +0000 (06:43 +0000)]
    Reviewed by Darin.

<rdar://problem/3507885>: REGRESSION (100-116): frames missing due to cross-domain check (derstandard.at)

* khtml/ecma/kjs_window.cpp:
        (Window::isSafeScript): Loosen the frame access rules a bit. We already allowed access to
a document loaded as empty from the parent or opener. Now also allow access from any document
in the same domain as the parent or opener, so that, for instance, a sibling frame can access it
so long as it is in the same domain as the parent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
darin [Sun, 14 Dec 2003 00:43:13 +0000 (00:43 +0000)]
    Reviewed by Maciej.

        - fixed 3506204: homepage.mac slide show window is wrong size on 2nd monitor

        * kwq/KWQApplication.mm: (QDesktopWidget::screenGeometry): Add code to flip the Y coordinate.
        This has no effect on the main screen, but a big effect on others. I used the same code to
        flip Y screen coordinates that is used KWQWindowWidget.mm and KWQKHTMLPartBrowserExtension.mm.
        * kwq/KWQKWinModule.mm: (KWinModule::workArea): Replaced the incorrect code to flip the Y
        coordinate here with correct code. The code flipped based on the frame of the main screen,
        but it needs to flip based on the frame of screen 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed by Ed Voas, reviewed by me.
darin [Sat, 13 Dec 2003 18:06:26 +0000 (18:06 +0000)]
    Fixed by Ed Voas, reviewed by me.

        - fixed 3278443: CARBON: grow box obscures scroll bar knob

        * Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter _growBoxRect]):
        Return the grow box so AppKit's scroll bar code will know where it is.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by me
kocienda [Sat, 13 Dec 2003 03:23:22 +0000 (03:23 +0000)]
    Reviewed by me

        * WebCoreSupport.subproj/WebKeyGeneration.cpp:
        (signedPublicKeyAndChallengeString): Fix build-bustin' typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Added implementation of stubs in JSObject. All that
rjw [Sat, 13 Dec 2003 01:37:13 +0000 (01:37 +0000)]
Added implementation of stubs in JSObject.  All that
remains is a couple of simple conversion functions stubs and
we're done with LiveConnect.  Also, changed string passing to
JS to use uchars instead of chars.

        Reviewed by Maciej.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
cblu [Sat, 13 Dec 2003 00:57:46 +0000 (00:57 +0000)]
WebCore:

Fixed: <rdar://problem/3505208>: keys added to keychain from KEYGEN need better UI names

        Reviewed by rjw.

        * khtml/html/html_formimpl.cpp:
        (HTMLKeygenElementImpl::encoding): pass the page URL to signedPublicKeyAndChallengeString
        * kwq/KWQKSSLKeyGen.h:
        * kwq/KWQKSSLKeyGen.mm:
        (KSSLKeyGen::signedPublicKeyAndChallengeString): take a URL
        * kwq/WebCoreKeyGenerator.h:
        * kwq/WebCoreKeyGenerator.m:
        (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): take a URL

WebKit:

Fixed:
<rdar://problem/3396936>: can't obtain a digital ID from Verisign, form submission fails
<rdar://problem/3505208>: keys added to keychain from KEYGEN need better UI names

        Reviewed by rjw.

        * English.lproj/Localizable.strings:
        * WebCoreSupport.subproj/WebKeyGeneration.cpp:
        (signedPublicKeyAndChallengeString): take a key description arg and use it, take and return CFStrings, handle the empty string case
        (addCertificatesToKeychainFromData): return a WebCertificateParseResult so WB knows how to handle the cert
        * WebCoreSupport.subproj/WebKeyGeneration.h:
        * WebCoreSupport.subproj/WebKeyGenerator.h:
        * WebCoreSupport.subproj/WebKeyGenerator.m:
        (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): take a page URL so we can use its host name in the key description
        * WebKit.pbproj/project.pbxproj:

WebBrowser:

Fixed:  <rdar://problem/3506645>: open PKCS7 encoded certificates downloaded from Verisign in Keychain Access

        Reviewed by rjw.

        * DownloadProgressEntry.m:
        (-[DownloadProgressEntry _addCertificateToKeyChain]): open PKCS7 files in Keychain Access
        * English.lproj/StringsNotToBeLocalized.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3254534, CSS background-image style should be loaded lazily only when used.
hyatt [Sat, 13 Dec 2003 00:23:54 +0000 (00:23 +0000)]
Fix for 3254534, CSS background-image style should be loaded lazily only when used.

        Reviewed by rjw

        * ChangeLog:
        * khtml/css/css_valueimpl.cpp:
        (CSSImageValueImpl::CSSImageValueImpl):
        (CSSImageValueImpl::~CSSImageValueImpl):
        (CSSImageValueImpl::image):
        * khtml/css/css_valueimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed <rdar://problem/3508825>: REGRESSION (100-116): crash in
sullivan [Fri, 12 Dec 2003 23:25:54 +0000 (23:25 +0000)]
    - fixed <rdar://problem/3508825>: REGRESSION (100-116): crash in
        HTMLGenericFormElementImpl::attach at sonyericsson.com

        Reviewed by Maciej.

        * khtml/html/html_formimpl.cpp:
        (HTMLGenericFormElementImpl::attach):
        Move a few lines inside an existing nil check to prevent nil dereference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed <rdar://problem/3508760>: tabbing to out-of-sight link behaves
sullivan [Fri, 12 Dec 2003 22:01:33 +0000 (22:01 +0000)]
    - fixed <rdar://problem/3508760>: tabbing to out-of-sight link behaves
        differently than tabbing to out-of-sight form control

        Reviewed by Dave.

        * kwq/KWQScrollView.h:
        * kwq/KWQScrollView.mm:
        (QScrollView::ensureVisible):
        added comments and changed parameter names to reveal differences between
        what we've implemented and what QScrollView was intended to do.
        (QScrollView::ensureRectVisibleCentered):
        New method that calls _KWQ_scrollRectToVisible, which is the method
        we use when scrolling to reveal form controls.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::nextKeyViewInFrame):
        call ensureRectVisibleCentered so tabbing to a link will use the
        same scroll-to-reveal code as tabbing to a form control

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
mjs [Fri, 12 Dec 2003 20:18:46 +0000 (20:18 +0000)]
    Reviewed by John.

<rdar://problem/3507856>: XMLHttpRequest xhtml test displays but doesn't load

        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequestProtoFunc::tryCall): complete the URL using the document,
not the htmlDocument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by me.
vicki [Fri, 12 Dec 2003 20:01:00 +0000 (20:01 +0000)]
    Reviewed by me.

- change the WebKit version number back to 118u for tip of tree builds

        * WebKit.pbproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by NOBODY (OOPS!).
vicki [Fri, 12 Dec 2003 19:14:25 +0000 (19:14 +0000)]
    Reviewed by NOBODY (OOPS!).

- fix version number for submission (117)

        * WebKit.pbproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by kocienda.
vicki [Fri, 12 Dec 2003 18:14:24 +0000 (18:14 +0000)]
    Reviewed by kocienda.

- fix buildit build bustage.  INSTALL_PATH should be '=', not '+=' (probably changed unintentionally)

        * WebKit.pbproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoJavaScriptCore:
rjw [Fri, 12 Dec 2003 17:32:00 +0000 (17:32 +0000)]
JavaScriptCore:
Ensure that all calls from Java into JavaScript are
performed on a designated thread (the main thread).

        Reviewed by Ken.

        * bindings/jni_jsobject.cpp:
        (isJavaScriptThread):
        (rootForImp):
        (Bindings::performJavaScriptAccess):
        (Bindings::completedJavaScriptAccess):
        (Bindings::initializeJavaScriptAccessLock):
        (Bindings::lockJavaScriptAccess):
        (Bindings::unlockJavaScriptAccess):
        (Bindings::dispatchToJavaScriptThread):
        (Bindings::RootObject::setFindRootObjectForNativeHandleFunction):
        (Bindings::RootObject::removeAllJavaReferencesForRoot):
        (Bindings::JSObject::invoke):
        (Bindings::JSObject::JSObject):
        (Bindings::JSObject::call):
        (Bindings::JSObject::eval):
        (Bindings::JSObject::getMember):
        (Bindings::JSObject::setMember):
        (Bindings::JSObject::removeMember):
        (Bindings::JSObject::getSlot):
        (Bindings::JSObject::setSlot):
        (Bindings::JSObject::toString):
        (Bindings::JSObject::finalize):
        (Bindings::JSObject::getWindow):
        * bindings/jni_jsobject.h:
        (Bindings::RootObject::~RootObject):
        (Bindings::RootObject::findRootObjectForNativeHandleFunction):
        (Bindings::RootObject::runLoop):
        (Bindings::RootObject::performJavaScriptSource):
        (Bindings::):

WebCore:
Replace calls to global functions with static member functions.

        Reviewed by Ken.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::cleanupPluginRootObjects):
        * kwq/WebCoreBridge.mm:
        (rootForView):
        (-[WebCoreBridge init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
mjs [Fri, 12 Dec 2003 01:54:56 +0000 (01:54 +0000)]
    Reviewed by Darin.

<rdar://problem/3464315>: createDocument creates document with initial child element, unlike other browsers

        * khtml/xml/dom_docimpl.cpp:
        (DOMImplementationImpl::createDocument): Don;t add initial element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
mjs [Fri, 12 Dec 2003 01:32:59 +0000 (01:32 +0000)]
    Reviewed by Darin.

<rdar://problem/3507863>: XMLHttpRequest should not parse response if HTML

* khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::getValueProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoJavaScriptCore:
rjw [Fri, 12 Dec 2003 00:48:31 +0000 (00:48 +0000)]
JavaScriptCore:
Added support for calling a JavaScript function from
Java.  Right now this only works for void func(void)
functions, but the conversion of args and return values
will come shortly.

Cleaned up and verified reference counting scheme, and
dereferencing of vended JavaScript objects when applet is
destroyed (actually when part is destroyed).

Removed link hack for testkjs now that the Java folks think
they have a solution for the 1.4.2 JavaVM link problem.  Although
Greg B. thinks his solution may cause problems for the 1.3.1
version of the VM!?!

        Reviewed by Ken.

        * Makefile.am:
        * bindings/jni/jni_runtime.h:
        (Bindings::JavaString::JavaString):
        * bindings/jni/jni_utility.cpp:
        (convertValueToJValue):
        (convertValueToJObject):
        (listFromJArray):
        * bindings/jni/jni_utility.h:
        * bindings/jni_jsobject.cpp:
        (KJS_setFindRootObjectForNativeHandleFunction):
        (KJS_findRootObjectForNativeHandleFunction):
        (getReferencesByRootDictionary):
        (getReferencesDictionary):
        (findReferenceDictionary):
        (rootForImp):
        (addJavaReference):
        (removeJavaReference):
        * bindings/jni_jsobject.h:
        (Bindings::RootObject::RootObject):
        (Bindings::RootObject::~RootObject):
        (Bindings::RootObject::setRootObjectImp):
        (Bindings::RootObject::rootObjectImp):
        (Bindings::RootObject::setInterpreter):
        (Bindings::RootObject::interpreter):

WebCore:
Cleaned up and verified reference counting scheme, and
dereferencing of vended JavaScript objects when applet is
destroyed (actually when part is destroyed).

        Reviewed by Ken.

        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::~KWQKHTMLPart):
        (KWQKHTMLPart::getAppletInstanceForView):
        (KWQKHTMLPart::addPluginRootObject):
        (KWQKHTMLPart::cleanupPluginRootObjects):
        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (rootForView):
        (-[WebCoreBridge init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin
kocienda [Thu, 11 Dec 2003 23:56:37 +0000 (23:56 +0000)]
    Reviewed by Darin

Fix for this bug:

<rdar://problem/3489280>: redirect via post blows cache, causing everything to get reloaded

Now POST requests reload the main document by default, but will not reload
all subresources.

        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (+[WebSubresourceClient startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
Take the cache policy for subresources from the original request, rather than
the data source's current request.
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient _isPostOrRedirectAfterPost:redirectResponse:]): New helper.
        (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]):
Call new helper to set the cache policy on the main resource load.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
mjs [Thu, 11 Dec 2003 23:50:09 +0000 (23:50 +0000)]
    Reviewed by John.

<rdar://problem/3507862>: XMLHttpRequest documents that reference external resources (e.g. stylesheets) cause crash

        * khtml/html/html_headimpl.cpp:
        (HTMLLinkElementImpl::process):
        * khtml/html/htmltokenizer.cpp:
        (HTMLTokenizer::scriptHandler):
        * khtml/xml/dom_xmlimpl.cpp:
        (ProcessingInstructionImpl::checkStyleSheet):
        * khtml/xml/xml_tokenizer.cpp:
        (XMLHandler::processingInstruction):
        (XMLTokenizer::executeScripts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Chris.
mjs [Thu, 11 Dec 2003 23:30:30 +0000 (23:30 +0000)]
    Reviewed by Chris.

<rdar://problem/3507859>: Status text should only include "OK", not full "HTTP/1.0 200 OK" status line

        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::getStatusText): Include only the status
text, not the full status line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agothe tree is open for Safari-118
vicki [Thu, 11 Dec 2003 22:59:49 +0000 (22:59 +0000)]
the tree is open for Safari-118

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-117 stamp, plus a few site changes
vicki [Thu, 11 Dec 2003 22:55:10 +0000 (22:55 +0000)]
Safari-117 stamp, plus a few site changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin
kocienda [Thu, 11 Dec 2003 21:43:40 +0000 (21:43 +0000)]
    Reviewed by Darin

        * WebCoreSupport.subproj/WebBridge.m: time_t is a signed type, so
casting -1 to a time_t does not work to make a max value.
We'll go with INT_MAX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFix duplicate changelog entry
hyatt [Thu, 11 Dec 2003 19:48:42 +0000 (19:48 +0000)]
Fix duplicate changelog entry

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoLanding changed layout tests that don't dump incorrect backgrounds.
hyatt [Thu, 11 Dec 2003 19:46:18 +0000 (19:46 +0000)]
Landing changed layout tests that don't dump incorrect backgrounds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3507164, scrolling really slow on hixie's web forms spec page. Hixie has...
hyatt [Thu, 11 Dec 2003 19:39:28 +0000 (19:39 +0000)]
Fix for 3507164, scrolling really slow on hixie's web forms spec page.  Hixie has 12 little transparent layers
        at various points on this page, and beginning/ending transparency on only those 12 layers as you scroll
        is enough to kill scrolling performance.

This patch works around the issue by lazily beginning transparency layers only when we determine that
we're actually painting a descendant layer of a transparent ancestor or a transparent layer.

Also fixing QColor's comparison operator.  It was broken and not comparing the "valid" bit, so invalid and
valid colors were being assumed to be the same.

Also fixed the render dumper to not dump transparent and invalid background colors and fixed it do dump the
alpha for colors with an alpha < 0xFF.

Reviewed by mjs (opacity changes), darin (color changes) and john (render tree dumper changes)

        * ChangeLog:
        * khtml/rendering/render_layer.cpp:
        (RenderLayer::RenderLayer):
        (RenderLayer::beginTransparencyLayers):
        (RenderLayer::paint):
        (RenderLayer::paintLayer):
        * khtml/rendering/render_layer.h:
        * kwq/KWQColor.h:
        (operator==):
        (operator!=):
        * kwq/KWQColor.mm:
        (QColor::name):
        * kwq/KWQRenderTreeDebug.cpp:
        (operator<<):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed and C++ heavy-lifting by Darin
kocienda [Thu, 11 Dec 2003 19:12:27 +0000 (19:12 +0000)]
    Reviewed and C++ heavy-lifting by Darin

Fix warnings in C++ files.

        * WebCoreSupport.subproj/WebKeyGeneration.cpp:
        (signedPublicKeyAndChallengeString): Add cast to remove warning.
        (addCertificatesToKeychainFromData): Add cast to remove warning.
        * WebKit.pbproj/project.pbxproj: Add back warnings to C++ files.
        * WebKitPrefix.h: Add define for NULL that works for C++.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by me
kocienda [Thu, 11 Dec 2003 19:00:36 +0000 (19:00 +0000)]
    Reviewed by me

        * kwq/KWQLoader.mm:
        (KWQCacheObjectExpiresTime): Fixed deployment build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
kocienda [Thu, 11 Dec 2003 16:11:47 +0000 (16:11 +0000)]
WebCore:

        Reviewed by Darin

        <rdar://problem/3505444>: WebCore cache does not use expiration dates on cache items

        * khtml/misc/loader.cpp:
        (Loader::slotFinished): Don't reset expiration date. We set this once in
        slotReceivedResponse.
        (Loader::slotReceivedResponse): Call new KWQ function to get a cache object's
        expiration date using its NSURLResponse data.
        (Cache::requestImage): Don't reset expiration date. We set this once in
        slotReceivedResponse, and we do not want the value from the DocLoader
anyway.
        (Cache::requestStyleSheet): Ditto.
        (Cache::requestScript): Ditto.
        * kwq/KWQLoader.h:
        * kwq/KWQLoader.mm:
        (KWQCacheObjectExpiresTime): New function. Call over bridge to get access
        to SPI in NSURLResponse to calculate expiration time.
        * kwq/WebCoreBridge.h: Declare bridge method.

WebKit:

        Reviewed by Darin

        <rdar://problem/3505444>: WebCore cache does not use expiration dates on cache items

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge expiresTimeForResponse:]): New method. Call response
        freshness lifetime method and add it to the current time to yield
        an expiration time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Darin.
mjs [Thu, 11 Dec 2003 06:56:10 +0000 (06:56 +0000)]
    Reviewed by Darin.

<rdar://problem/3504156>: XMLHttpRequest reuse test fails
<rdar://problem/3505158>: XMLHttpRequest "abort with open" test fails

        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::open):
        (KJS::XMLHttpRequest::abort):
        (KJS::XMLHttpRequestProtoFunc::tryCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Darin.
mjs [Thu, 11 Dec 2003 06:50:24 +0000 (06:50 +0000)]
    Reviewed by Darin.

<rdar://problem/3507175>: Setting timeout function can allocate JS objects without lock

        * khtml/ecma/kjs_window.cpp:
        (ScheduledAction::execute): Lock interpreter around code that
might allocate JS objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoAdding overflow test with auto height.
hyatt [Thu, 11 Dec 2003 06:26:08 +0000 (06:26 +0000)]
Adding overflow test with auto height.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for 3507097, overflow:auto should include the height of the horizontal scrollbar...
hyatt [Thu, 11 Dec 2003 06:25:17 +0000 (06:25 +0000)]
Fix for 3507097, overflow:auto should include the height of the horizontal scrollbar when the height
of the block is auto.

        Reviewed by darin

        * khtml/rendering/bidi.cpp:
        (khtml::RenderBlock::layoutInlineChildren):
        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::layoutBlock):
        (khtml::RenderBlock::layoutBlockChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Thu, 11 Dec 2003 05:15:54 +0000 (05:15 +0000)]
    Reviewed by Maciej.

        - fixed 3506739: nil-deref in DocumentImpl::setSelection triple clicking (generated content)

        * khtml/khtml_part.cpp: (KHTMLPart::khtmlMousePressEvent): Check for the case where
        m_selectionEnd is 0. This doesn't fix the behavior completely, but it does prevent a crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebCore:
mjs [Thu, 11 Dec 2003 04:55:47 +0000 (04:55 +0000)]
WebCore:

        Reviewed by Richard.

<rdar://problem/3487160>: Implement synchronous loading for XMLHttpRequest

* khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::XMLHttpRequest):
        (KJS::XMLHttpRequest::send):
        (KJS::XMLHttpRequest::abort):
        (KJS::XMLHttpRequest::processSyncLoadResults):
        (KJS::XMLHttpRequest::slotRedirection):
        (KJS::XMLHttpRequest::slotData):
        * khtml/ecma/xmlhttprequest.h:
        * kwq/KWQLoader.h:
        * kwq/KWQLoader.mm:
        (KWQHeaderStringFromDictionary):
        (KWQServeSynchronousRequest):
        (KWQResponseHeaderString):
        * kwq/WebCoreBridge.h:

WebKit:

        Reviewed by Richard.

WebKit part of fix for:

<rdar://problem/3487160>: Implement synchronous loading for XMLHttpRequest

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Thu, 11 Dec 2003 04:55:12 +0000 (04:55 +0000)]
    Reviewed by Maciej.

        - fixed regression in JavaScript tests reported by the KDE guys
        - fixed 3506345: REGRESSION (115-116): VIP: chordfind.com no longer displays chords

        * kjs/ustring.h: Add tolerateEmptyString parameter to toDouble and toULong.
        * kjs/ustring.cpp:
        (KJS::UString::toDouble): Separate the "tolerant" parameter into two separate ones:
        tolerateTrailingJunk and tolerateEmptyString. Add new overloads; better for code size
        and binary compatibility than default parameter values.
        (KJS::UString::toULong): Pass tolerateEmptyString down to toDouble. Add new overload.

        * kjs/string_object.cpp: (StringProtoFuncImp::call): Pass false for the new
        "tolerate empty string" parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Thu, 11 Dec 2003 04:49:51 +0000 (04:49 +0000)]
    Reviewed by Maciej.

        - fixed 3506706: REGRESSION (100-115): onkeyup handlers called twice for active input fields

        * kwq/KWQTextArea.mm: (-[KWQTextAreaTextView keyUp:]): Don't call super because we
        don't want to pass the event down the responder chain.
        * kwq/KWQTextField.mm: (-[KWQTextField textView:shouldHandleEvent:]): Return NO for
        key up events because we don't want to pass the event down the responder chain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoFix optimized build bustage.
hyatt [Thu, 11 Dec 2003 04:47:55 +0000 (04:47 +0000)]
Fix optimized build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebKit:
rjw [Thu, 11 Dec 2003 02:20:43 +0000 (02:20 +0000)]
WebKit:
Added method to get to the bridge from a view.  This is
used to ultimately get the part and KJS::Window for a
particular applet.

        Reviewed by Hyatt.

        * WebCoreSupport.subproj/WebViewFactory.m:
        (-[WebViewFactory refreshPlugins:]):
        (-[WebViewFactory bridgeForView:]):

WebCore:
Added method to get to the bridge from a view.  This is
used to ultimately get the part and KJS::Window for a
particular applet.

        Reviewed by Hyatt.

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (rootForView):
        (-[WebCoreBridge init]):
        * kwq/WebCoreViewFactory.h:
        * kwq/WebCoreViewFactory.m:

JavaScriptCore:
Added code to manage reference counting of JavaScript
objects passed to Java.   Also added implementation of
KJS_JSCreateNativeJSObject.  This is the function that
provides the root object to Java (KJS::Window).

        Reviewed by Hyatt.

        * JavaScriptCore.pbproj/project.pbxproj:
        * bindings/jni_jsobject.cpp:
        (KJS_setFindObjectForNativeHandleFunction):
        (KJS_findObjectForNativeHandleFunction):
        (getReferencesByOwnerDictionary):
        (getReferencesDictionary):
        (findReferenceDictionary):
        (addJavaReference):
        (removeJavaReference):
        (removeAllJavaReferencesForOwner):
        * bindings/jni_jsobject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebCore:
sullivan [Thu, 11 Dec 2003 01:47:13 +0000 (01:47 +0000)]
WebCore:

        - WebCore part of fix for:
        <rdar://problem/3505231>: REGRESSION (100-114): Some sites autoscroll to bottom of page when loading

        Reviewed by Darin.

        * kwq/KWQNSViewExtras.h:
        * kwq/KWQNSViewExtras.m:
        (-[NSView _KWQ_scrollPointRecursive:]):
        (-[NSView _KWQ_scrollPointRecursive:inView:]):
        new methods, similar to existing scrollRect methods
        except that the preferred position for the point is
        the top-left corner rather than centered in the visible area

        * kwq/KWQScrollView.h:
        * kwq/KWQScrollView.mm:
        (QScrollView::setContentsPosRecursive):
        new method, calls _KWQ_scrollPointRecursive:

        * khtml/khtml_part.cpp:
        (KHTMLPart::gotoAnchor):
        call setContentsPosRecursive instead of setContentsPos; also remove
        the 50 pixel offset that upset Hyatt so.

WebKit:

        - WebKit part of fix for:
        <rdar://problem/3505231>: REGRESSION (100-114): Some sites autoscroll to bottom of page when loading

        Reviewed by Darin

        * Misc.subproj/WebNSViewExtras.h:
        * Misc.subproj/WebNSViewExtras.m:
        removed _web_scrollPointToVisible:fromView:

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView scrollPoint:]):
        removed call to _web_scrollPointToVisible:fromView:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebKit:
cblu [Thu, 11 Dec 2003 00:34:01 +0000 (00:34 +0000)]
WebKit:

Fixed: <rdar://problem/3505537>: certificates downloaded from Verisign are multipart/mixed, must be parsed out

        Reviewed by kocienda.

        * WebCoreSupport.subproj/WebKeyGeneration.cpp:
        (signedPublicKeyAndChallengeString): tweak
        (addCertificateToKeychainFromData): renamed to use lowercase "c" in "keychain"
        (addCertificatesToKeychainFromData): take data instead of a path to a file
        * WebCoreSupport.subproj/WebKeyGeneration.h:
        * WebCoreSupport.subproj/WebKeyGenerator.h:
        * WebCoreSupport.subproj/WebKeyGenerator.m:
        (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]): added temporary workaround for 3396936

WebBrowser:

Fixed: <rdar://problem/3505537>: certificates downloaded from Verisign are multipart/mixed, must be parsed out

        Reviewed by me, kocienda.

        * BrowserNSDataExtras.h:
        * BrowserNSDataExtras.m: new categories implemented by kocienda.
        (-[NSData indexOfCharacterInCString:]):
        (-[NSData indexOfCString:]):
        (-[NSData indexOfCString:startOffset:]):
        (-[NSData indexOfByteString:length:]):
        (-[NSData indexOfByteString:length:startOffset:]):
        (-[NSData certificateFromMultipartData]): extracts the cert
        * DownloadProgressEntry.m:
        (-[DownloadProgressEntry _addCertificateToKeyChain]): if the file is multipart/mixed, attempt to extract the cert using certificateFromMultipartData

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago * kwq/KWQKSSLKeyGen.mm:
cblu [Wed, 10 Dec 2003 22:39:49 +0000 (22:39 +0000)]
    * kwq/KWQKSSLKeyGen.mm:
        (KSSLKeyGen::signedPublicKeyAndChallengeString): removed unnecessary includes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for 3505846, overflow:auto region doesn't update when scrolled. The child layer...
hyatt [Wed, 10 Dec 2003 22:34:27 +0000 (22:34 +0000)]
Fix for 3505846, overflow:auto region doesn't update when scrolled.  The child layers inside an overflow:auto
block were not updating their positions.

        Reviewed by john

        * khtml/khtmlview.cpp:
        (KHTMLView::layout):
        * khtml/rendering/render_layer.cpp:
        (RenderLayer::updateLayerPositions):
        (RenderLayer::scrollToOffset):
        * khtml/rendering/render_layer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoCorrected ChangeLog entry.
mjs [Wed, 10 Dec 2003 21:47:30 +0000 (21:47 +0000)]
Corrected ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by John.
mjs [Wed, 10 Dec 2003 21:46:45 +0000 (21:46 +0000)]
    Reviewed by John.

<rdar://problem/3505795>: loading invalid XML document crashes trying to create h1 element

* khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::isValidName): include "0123456789" instead of
"0-9", it's not a regexp it's just a list of characters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by John.
mjs [Wed, 10 Dec 2003 21:42:25 +0000 (21:42 +0000)]
    Reviewed by John.

<rdar://problem/3504155>: Safari fails XMLHttpRequest abort test

* khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequestProtoFunc::tryCall): Avoid throwing an
exception after send().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Rename -apple-aqua to auto for outline styles.
hyatt [Wed, 10 Dec 2003 21:14:01 +0000 (21:14 +0000)]
Rename -apple-aqua to auto for outline styles.

        Reviewed by darin

        * khtml/css/cssparser.cpp:
        (CSSParser::parseValue):
        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::applyRule):
        * khtml/css/cssvalues.c:
        (hash_val):
        (findValue):
        * khtml/css/cssvalues.h:
        * khtml/css/cssvalues.in:
        * khtml/css/html4.css:
        * khtml/rendering/render_inline.cpp:
        (RenderInline::paintObject):
        * khtml/rendering/render_object.cpp:
        (RenderObject::drawBorder):
        (RenderObject::paintOutline):
        * khtml/rendering/render_style.h:
        (khtml::):
        (khtml::OutlineValue::OutlineValue):
        (khtml::RenderStyle::outlineStyleIsAuto):
        (khtml::RenderStyle::outlineOffset):
        (khtml::RenderStyle::setOutlineStyle):
        (khtml::RenderStyle::setOutlineOffset):
        * kwq/KWQRenderTreeDebug.cpp:
        (printBorderStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by John.
mjs [Wed, 10 Dec 2003 04:09:52 +0000 (04:09 +0000)]
    Reviewed by John.

<rdar://problem/3487195>: Implement responseXML property for XMLHttpRequest

        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::getValueProperty): Implemented responseXML by parsing the
document and returning it.
        (KJS::XMLHttpRequest::XMLHttpRequest): Initialize new field
        * khtml/ecma/xmlhttprequest.h:

        * khtml/ecma/kjs_window.cpp:
(Windw::get): Forgot this in last commit; add XMLSerializer
constructor.
        * khtml/ecma/kjs_window.lut.h:
* khtml/ecma/Makefile.am: Forgot to include this in the last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Richard.
mjs [Wed, 10 Dec 2003 04:05:47 +0000 (04:05 +0000)]
    Reviewed by Richard.

<rdar://problem/3504049>: XMLSerializer object and serializeToString method needed for XMLHttpRequest testing

Also fixed some lasst-minute mistakes in the DOM serialization
code that was already there.

        * WebCore.pbproj/project.pbxproj:
        * khtml/dom/dom_doc.h:
        * khtml/ecma/Makefile.am:
        * khtml/ecma/kjs_window.cpp:
        (Window::get):
        * khtml/ecma/kjs_window.h:
        (KJS::Window::):
        * khtml/ecma/kjs_window.lut.h:
        (KJS::):
        * khtml/ecma/xmlserializer.cpp: Added.
        (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp):
        (KJS::XMLSerializerConstructorImp::implementsConstruct):
        (KJS::XMLSerializerConstructorImp::construct):
        (KJS::):
        (KJS::XMLSerializer::XMLSerializer):
        (KJS::XMLSerializerProtoFunc::tryCall):
        * khtml/ecma/xmlserializer.h: Added.
        (KJS::XMLSerializer::toBoolean):
        (KJS::XMLSerializer::classInfo):
        (KJS::XMLSerializer::):
        * khtml/ecma/xmlserializer.lut.h: Added.
        (KJS::):
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::toString):
        (DocumentFragmentImpl::toString):
        * khtml/xml/dom_elementimpl.cpp:
        (AttrImpl::toString):
        (ElementImpl::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Implement start() and stop() for marquees.
hyatt [Wed, 10 Dec 2003 01:23:53 +0000 (01:23 +0000)]
Implement start() and stop() for marquees.

        Reviewed by darin

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLElement::classInfo):
        (KJS::HTMLElementFunction::tryCall):
        * khtml/ecma/kjs_html.h:
        (KJS::HTMLElement::):
        * khtml/ecma/kjs_html.lut.h:
        (KJS::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago LiveConnect stubs that correspond to the native methods
rjw [Wed, 10 Dec 2003 01:05:57 +0000 (01:05 +0000)]
LiveConnect stubs that correspond to the native methods
on JSObject.  These will be called from the new Java plugin
when an instance of JSObject is instantiated and messaged.
When these are implemented the Java will be able to originate
calls into JavaScript.

Also a temporary work-around added to Makefile.am to solve
a link problem.  The 1.4.2 JavaVM accidentally links against
libobjc.  This call a failure linking testkjs.  Mike Hay is
working with someone to fix the problem (3505587).

        Reviewed by Chris.

        * JavaScriptCore.pbproj/project.pbxproj:
        * Makefile.am:
        * bindings/jni_jsobject.cpp: Added.
        (KJS_JSCreateNativeJSObject):
        (KJS_JSObject_JSFinalize):
        (KJS_JSObject_JSObjectCall):
        (KJS_JSObject_JSObjectEval):
        (KJS_JSObject_JSObjectGetMember):
        (KJS_JSObject_JSObjectSetMember):
        (KJS_JSObject_JSObjectRemoveMember):
        (KJS_JSObject_JSObjectGetSlot):
        (KJS_JSObject_JSObjectSetSlot):
        (KJS_JSObject_JSObjectToString):
        * bindings/jni_jsobject.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by John.
darin [Wed, 10 Dec 2003 00:53:40 +0000 (00:53 +0000)]
    Reviewed by John.

        - fixed 3505277: nil-deref in ownerElement after choosing item from menu at projectnissan.com

        * khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent): Add check for nil.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Wed, 10 Dec 2003 00:46:10 +0000 (00:46 +0000)]
    Reviewed by Maciej.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::saveLocationProperties): Add locking around the call to get the location
        since it can allocate.
        (KWQKHTMLPart::restoreLocationProperties): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for mojibake bg painting problem on bofa.com. The bug # is 3487144. Transparen...
hyatt [Wed, 10 Dec 2003 00:29:03 +0000 (00:29 +0000)]
Fix for mojibake bg painting problem on bofa.com.  The bug # is 3487144.  Transparent colors were not
being handled properly when specified on the body.

        Reviewed by darin

        * khtml/rendering/render_box.cpp:
        (RenderBox::paintRootBoxDecorations):
        (RenderBox::paintBackgroundExtended):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Dave.
darin [Tue, 9 Dec 2003 23:39:56 +0000 (23:39 +0000)]
    Reviewed by Dave.

        - fixed 3505391: REGRESSION (100-116): pages that move cells around don't repaint correctly

        * khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows): Added code
        similar to the code in RenderBlock::layoutBlock, but for table cells.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Tue, 9 Dec 2003 23:38:02 +0000 (23:38 +0000)]
    Reviewed by Maciej.

        * khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Add locking around the call to
        push event handler scope. Without this, we hit the "allocated without locking" assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix the dirty rect checks on various render_objects to be more accurate so that...
hyatt [Tue, 9 Dec 2003 23:15:57 +0000 (23:15 +0000)]
Fix the dirty rect checks on various render_objects to be more accurate so that page-break properties don't
have mojibake when printing.

        Reviewed by john

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::paint):
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::paintLineBoxBackgroundBorder):
        (RenderFlow::paintLineBoxDecorations):
        * khtml/rendering/render_replaced.cpp:
        (RenderReplaced::paint):
        * khtml/rendering/render_table.cpp:
        (RenderTable::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Richard.
darin [Tue, 9 Dec 2003 23:01:09 +0000 (23:01 +0000)]
    Reviewed by Richard.

        - fixed 3500408: Web Kit should pass the MAYSCRIPT attribute from the APPLET tag to the Java plug-in

        * khtml/html/html_objectimpl.cpp:
        (HTMLAppletElementImpl::parseAttribute): Allow the "mayscript" attribute.
        (HTMLAppletElementImpl::createRenderer): Pass the value of the "mayscript" attribute
        as an argument named "mayScript".

        * khtml/misc/htmlattrs.in: Added "mayscript".
        * khtml/misc/htmlattrs.c: Regenerated.
        * khtml/misc/htmlattrs.h: Regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5731 268f45cc-cd09-0410-ab3c-d52691b4dbfc