WebKit-https.git
6 years ago<rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
mitz@apple.com [Fri, 26 Dec 2014 15:45:44 +0000 (15:45 +0000)]
<rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
https://bugs.webkit.org/show_bug.cgi?id=139950

Reviewed by David Kilzer.

Source/bmalloc:

* Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.

Source/JavaScriptCore:

* Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.

Source/WebCore:

* Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.

Source/WebInspectorUI:

* Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.

Source/WebKit/mac:

* Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.

Source/WebKit2:

* Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.

Source/WTF:

* Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.

Tools:

* asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
in a manner that works with Xcode 5.1.1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore:
commit-queue@webkit.org [Fri, 26 Dec 2014 07:34:39 +0000 (07:34 +0000)]
Source/WebCore:
Allow strings as argument to :lang()
https://bugs.webkit.org/show_bug.cgi?id=139678

Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-12-25
Reviewed by Benjamin Poulain.

Allow strings as argument to :lang()[1]. The selector with empty string argument (e.g. :lang(""))
is handled as never matching.

[1] http://www.w3.org/blog/CSS/2014/12/11/minutes-telecon-231/

Test: fast/css/css-lang-selector-with-string-arguments-text.html
      fast/selectors/lang-extended-filtering-with-string-arguments.html

* css/CSSGrammar.y.in:
* css/SelectorCheckerTestFunctions.h:
(WebCore::matchesLangPseudoClass):

LayoutTests:
Extend :lang() with string arguments
https://bugs.webkit.org/show_bug.cgi?id=139678

Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-12-25
Reviewed by Benjamin Poulain.

* fast/css/css-lang-selector-with-string-arguments-text-expected.txt: Added.
* fast/css/css-lang-selector-with-string-arguments-text.html: Added.
* fast/selectors/lang-extended-filtering-with-string-arguments-expected.txt: Added.
* fast/selectors/lang-extended-filtering-with-string-arguments.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDOM exception creator functions should return Ref.
akling@apple.com [Fri, 26 Dec 2014 04:23:28 +0000 (04:23 +0000)]
DOM exception creator functions should return Ref.
<https://webkit.org/b/139947>

Reviewed by Chris Dumez.

Tweak all the FooException::create() to return Ref instead of
PassRefPtr since construction always succeeds.

Also add a toJS() overload for ImplType& to keep bindings building.

* Modules/indexeddb/IDBDatabaseException.h:
(WebCore::IDBDatabaseException::create):
* Modules/webdatabase/SQLException.h:
(WebCore::SQLException::create):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* dom/DOMCoreException.h:
(WebCore::DOMCoreException::create):
* dom/EventException.h:
(WebCore::EventException::create):
* dom/RangeException.h:
(WebCore::RangeException::create):
* fileapi/FileException.h:
(WebCore::FileException::create):
* svg/SVGException.h:
(WebCore::SVGException::create):
* xml/XMLHttpRequestException.h:
(WebCore::XMLHttpRequestException::create):
* xml/XPathException.h:
(WebCore::XPathException::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build warning after r177700
commit-queue@webkit.org [Fri, 26 Dec 2014 03:51:56 +0000 (03:51 +0000)]
Fix build warning after r177700
https://bugs.webkit.org/show_bug.cgi?id=139948

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2014-12-25
Reviewed by Alexey Proskuryakov.

* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::transformHandlesToObjects):
(WebKit::WebConnectionToWebProcess::transformObjectsToHandles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, fix build break on win debug build since r177737.
gyuyoung.kim@samsung.com [Fri, 26 Dec 2014 03:31:32 +0000 (03:31 +0000)]
Unreviewed, fix build break on win debug build since r177737.

Partial revert some code in r177737 because it causes build error on win debug buildbot.

* dom/ElementIteratorAssertions.h:
(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGive extract-localizable-strings an option to treat warnings as errors
mitz@apple.com [Thu, 25 Dec 2014 22:45:31 +0000 (22:45 +0000)]
Give extract-localizable-strings an option to treat warnings as errors
https://bugs.webkit.org/show_bug.cgi?id=139943

Reviewed by Darin Adler.

Add a --treat-warnings-as-errors option, which makes the script emit its warnings as errors
and exit with a non-0 return code if it emitted any warnings.

* extract-localizable-strings.pl:
Added $treatWarningsAsErrors variable, set to true if the option is passed in.

(emitWarning): Added. If $treatWarningsAsErrors is true, omits the "warning: " token from
the message, which makes it appear as an error in Xcode, and sets $sawError to 1.

Replaced all print statements that printed warnings with calls to emitWarning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix the Windows build after r177733.
mitz@apple.com [Thu, 25 Dec 2014 22:01:19 +0000 (22:01 +0000)]
Try to fix the Windows build after r177733.

* wtf/Ref.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBring the state of WEBCORE_EXPORT annotations closer to what the exports file specifies.
mitz@apple.com [Thu, 25 Dec 2014 21:25:15 +0000 (21:25 +0000)]
Bring the state of WEBCORE_EXPORT annotations closer to what the exports file specifies.
https://bugs.webkit.org/show_bug.cgi?id=136172

Reviewed by Darin Adler.

* bridge/NP_jsobject.cpp: Give functions from npruntime_impl.h defined in this file default
using a compiler pragma, in lieu of introducing WebCore-specific macros into that header.
* bridge/npruntime.cpp: Ditto.

* platform/mac/WebCoreSystemInterface.mm: Similarly for WebCoreSystemInterface.h.

Added or removed WEBCORE_EXPORT in these files as necessary to match what is currently in
the exports file:

* Modules/mediasource/SourceBuffer.h:
* bindings/js/JSDOMBinding.h:
* css/CSSComputedStyleDeclaration.h:
* dom/ContainerNode.h:
* dom/Document.h:
* dom/MouseEvent.h:
* dom/Range.h:
* dom/SecurityContext.h:
* editing/Editor.h:
* editing/mac/DictionaryLookup.h:
* loader/FrameLoaderClient.h:
* loader/LoaderStrategy.h:
* loader/icon/IconDatabaseBase.h:
* page/ChromeClient.h:
* page/EventHandler.h:
* page/FrameSnapshotting.h:
* page/Page.h:
* page/PageOverlay.h:
* page/PageOverlayController.h:
* page/TextIndicator.h:
* page/UserContentController.h:
* page/WheelEventDeltaTracker.h:
* page/mac/TextIndicatorWindow.h:
* platform/DatabaseStrategy.h:
* platform/ScrollableArea.h:
* platform/SuddenTermination.h:
* platform/URL.h:
* platform/animation/Animation.h:
* platform/cocoa/MachSendRight.h:
* platform/graphics/FloatRoundedRect.h:
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsLayer.h:
* platform/graphics/Path.h:
* platform/graphics/TextRun.h:
* platform/graphics/ca/TileController.h:
* platform/graphics/cocoa/IOSurface.h:
* platform/graphics/mac/ColorMac.h:
* platform/mac/SoftLinking.h:
* platform/mac/WebCoreNSStringExtras.h:
* platform/mock/mediasource/MockMediaPlayerMediaSource.h:
* platform/network/BlobRegistry.h:
* platform/network/ResourceRequestBase.h:
* platform/network/ResourceResponseBase.h:
* rendering/HitTestResult.h:
* rendering/RenderInline.h:
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
* rendering/RenderView.h:
* storage/StorageNamespaceImpl.h:
* storage/StorageNamespaceProvider.h:
* testing/Internals.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Log better using FeatureCounter why PageCache is failing due to pruned resources
cdumez@apple.com [Thu, 25 Dec 2014 21:09:40 +0000 (21:09 +0000)]
[iOS] Log better using FeatureCounter why PageCache is failing due to pruned resources
https://bugs.webkit.org/show_bug.cgi?id=139921

Reviewed by Gavin Barraclough and Alexey Proskuryakov.

Source/WebCore:

Log better using FeatureCounter why PageCache is failing due to pruned
resources. In particular, we now distinguish if the resource was pruned
due to:
- Memory pressure
- Page cache capacity reached
- WebProcess suspended (WK2)

* WebCore.exp.in:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
* history/HistoryItem.h:
* history/PageCache.cpp:
(WebCore::PageCache::pruneToCapacityNow):
(WebCore::PageCache::setCapacity):
(WebCore::pruningReasonToFeatureCounterKey):
(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::get):
(WebCore::PageCache::prune):
* history/PageCache.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
* platform/FeatureCounterKeys.h:
* platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseCriticalMemory):

Source/WebKit2:

Call PageCache::pruneToCapacityNow() instead of multiple calls to
setCapacity() as it does exactly what we want. Also pass the new
PrunedReason argument so help us do better logging.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::releasePageCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse std::unique_ptr<> in WebCore/dom, plugin, and graphics
gyuyoung.kim@samsung.com [Thu, 25 Dec 2014 18:55:21 +0000 (18:55 +0000)]
Use std::unique_ptr<> in WebCore/dom, plugin, and graphics
https://bugs.webkit.org/show_bug.cgi?id=139938

Reviewed by Darin Adler.

Replace OwnPtr with std::unique_ptr<> and std::make_unique<>.

* dom/ElementIteratorAssertions.h:
(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):
* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
* dom/MutationObserverRegistration.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::boundsForGlyph):
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):
* plugins/PluginStream.cpp:
(WebCore::PluginStream::didReceiveData):
* plugins/PluginStream.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify saturated integer add/sub
ap@apple.com [Thu, 25 Dec 2014 18:48:41 +0000 (18:48 +0000)]
Simplify saturated integer add/sub
https://bugs.webkit.org/show_bug.cgi?id=139854

Address Darin's post-commit feedback to fix API tests.

* wtf/SaturatedArithmetic.h: (saturatedSubtraction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r177712 and r177717.
commit-queue@webkit.org [Thu, 25 Dec 2014 16:23:47 +0000 (16:23 +0000)]
Unreviewed, rolling out r177712 and r177717.
https://bugs.webkit.org/show_bug.cgi?id=139944

Caused flaky assertion failures (Requested by ap on #webkit).

Reverted changesets:

"[iOS] Log better using FeatureCounter why PageCache is
failing due to pruned resources"
https://bugs.webkit.org/show_bug.cgi?id=139921
http://trac.webkit.org/changeset/177712

"Unreviewed, fix build warning after r177712"
http://trac.webkit.org/changeset/177717

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRebaseline bindings tests after r177733.
akling@apple.com [Thu, 25 Dec 2014 10:03:14 +0000 (10:03 +0000)]
Rebaseline bindings tests after r177733.

* bindings/scripts/test/JS/JSTestCallback.h:
(WebCore::JSTestCallback::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoConvert more creator functions to return Ref instead of PassRefPtr.
akling@apple.com [Thu, 25 Dec 2014 07:50:20 +0000 (07:50 +0000)]
Convert more creator functions to return Ref instead of PassRefPtr.
<https://webkit.org/b/139939>

Reviewed by Darin Adler.

Convert a slew of functions to return Ref<T> instead of PassRefPtr<T>
where the result is guaranteed to never be null.

* Modules/geolocation/Coordinates.h:
(WebCore::Coordinates::create):
(WebCore::Coordinates::isolatedCopy):
* Modules/plugins/QuickTimePluginReplacement.mm:
(WebCore::QuickTimePluginReplacement::isolatedWorld):
* Modules/webaudio/AnalyserNode.h:
(WebCore::AnalyserNode::create):
* Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::create):
(WebCore::AudioBuffer::createFromAudioFileData):
* Modules/webaudio/AudioBuffer.h:
* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::create):
* Modules/webaudio/AudioBufferSourceNode.h:
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::create):
* Modules/webaudio/AudioContext.h:
* Modules/webaudio/AudioListener.h:
(WebCore::AudioListener::create):
* Modules/webaudio/AudioParam.h:
(WebCore::AudioParam::create):
* Modules/webaudio/BiquadFilterNode.h:
(WebCore::BiquadFilterNode::create):
* Modules/webaudio/ConvolverNode.h:
(WebCore::ConvolverNode::create):
* Modules/webaudio/DelayNode.h:
(WebCore::DelayNode::create):
* Modules/webaudio/DynamicsCompressorNode.h:
(WebCore::DynamicsCompressorNode::create):
* Modules/webdatabase/ChangeVersionWrapper.h:
(WebCore::ChangeVersionWrapper::create):
* Modules/webdatabase/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::create):
* Modules/webdatabase/DatabaseAuthorizer.h:
* Modules/webdatabase/DatabaseThread.h:
(WebCore::DatabaseThread::create):
* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
* accessibility/AXObjectCache.cpp:
(WebCore::createFromRenderer):
(WebCore::createFromNode):
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::create):
* accessibility/AccessibilityARIAGrid.h:
* accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::create):
* accessibility/AccessibilityARIAGridCell.h:
* accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::create):
* accessibility/AccessibilityARIAGridRow.h:
* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::create):
* accessibility/AccessibilityImageMapLink.h:
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::create):
* accessibility/AccessibilityList.h:
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::create):
* accessibility/AccessibilityListBox.h:
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::create):
* accessibility/AccessibilityListBoxOption.h:
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::create):
(WebCore::AccessibilityMediaControlsContainer::create):
(WebCore::AccessibilityMediaTimeline::create):
(WebCore::AccessibilityMediaTimeDisplay::create):
* accessibility/AccessibilityMediaControls.h:
* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::create):
* accessibility/AccessibilityMenuList.h:
* accessibility/AccessibilityMenuListOption.h:
* accessibility/AccessibilityMenuListPopup.h:
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::create):
* accessibility/AccessibilityNodeObject.h:
* accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::create):
* accessibility/AccessibilityProgressIndicator.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::create):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilitySVGRoot.cpp:
(WebCore::AccessibilitySVGRoot::create):
* accessibility/AccessibilitySVGRoot.h:
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::create):
* accessibility/AccessibilityScrollView.h:
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::create):
* accessibility/AccessibilityScrollbar.h:
* accessibility/AccessibilitySearchFieldButtons.cpp:
(WebCore::AccessibilitySearchFieldCancelButton::create):
* accessibility/AccessibilitySearchFieldButtons.h:
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::create):
(WebCore::AccessibilitySliderThumb::create):
* accessibility/AccessibilitySlider.h:
* accessibility/AccessibilitySpinButton.cpp:
(WebCore::AccessibilitySpinButton::create):
(WebCore::AccessibilitySpinButtonPart::create):
* accessibility/AccessibilitySpinButton.h:
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::create):
* accessibility/AccessibilityTable.h:
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::create):
* accessibility/AccessibilityTableCell.h:
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::create):
* accessibility/AccessibilityTableColumn.h:
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::create):
* accessibility/AccessibilityTableHeaderContainer.h:
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::create):
* accessibility/AccessibilityTableRow.h:
* bindings/js/CachedScriptSourceProvider.h:
(WebCore::CachedScriptSourceProvider::create):
* bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::create):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::getJSValue):
* bindings/objc/DOMCustomXPathNSResolver.h:
(WebCore::DOMCustomXPathNSResolver::create):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackHeader):
* bridge/c/c_instance.h:
(JSC::Bindings::CInstance::create):
* crypto/CryptoKeyPair.h:
(WebCore::CryptoKeyPair::create):
* crypto/keys/CryptoKeyAES.h:
* crypto/keys/CryptoKeyHMAC.h:
* crypto/keys/CryptoKeyRSA.h:
* crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::generatePair):
* css/DOMWindowCSS.cpp:
(WebCore::DOMWindowCSS::create):
* css/DOMWindowCSS.h:
* css/DashboardRegion.h:
(WebCore::DashboardRegion::create):
* css/FontLoader.h:
* dom/DOMError.h:
(WebCore::DOMError::create):
* dom/DOMStringList.h:
(WebCore::DOMStringList::create):
* dom/DataTransfer.cpp:
(WebCore::DataTransfer::createForCopyAndPaste):
(WebCore::DataTransfer::createForDragAndDrop):
* dom/DataTransfer.h:
* dom/DeviceMotionData.cpp:
(WebCore::DeviceMotionData::Acceleration::create):
(WebCore::DeviceMotionData::RotationRate::create):
(WebCore::DeviceMotionData::create):
* dom/DeviceMotionData.h:
* dom/DeviceOrientationData.cpp:
(WebCore::DeviceOrientationData::create):
* dom/DeviceOrientationData.h:
* dom/DocumentMarker.cpp:
(WebCore::DocumentMarkerDescription::create):
* editing/AlternativeTextController.cpp:
(WebCore::AutocorrectionAlternativeDetails::create):
(WebCore::DictationAlternativeDetails::create):
* editing/AlternativeTextController.h:
(WebCore::DictationMarkerDetails::create):
* editing/AppendNodeCommand.h:
(WebCore::AppendNodeCommand::create):
* editing/ApplyStyleCommand.h:
(WebCore::ApplyStyleCommand::create):
* editing/BreakBlockquoteCommand.h:
(WebCore::BreakBlockquoteCommand::create):
* editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::create):
* editing/CompositeEditCommand.h:
* editing/CreateLinkCommand.h:
(WebCore::CreateLinkCommand::create):
* editing/DeleteFromTextNodeCommand.h:
(WebCore::DeleteFromTextNodeCommand::create):
* editing/DeleteSelectionCommand.h:
(WebCore::DeleteSelectionCommand::create):
* editing/DictationCommand.cpp:
(WebCore::DictationMarkerSupplier::create):
* editing/DictationCommand.h:
(WebCore::DictationCommand::create):
* editing/EditingStyle.h:
(WebCore::EditingStyle::create):
* editing/Editor.cpp:
(WebCore::Editor::applyStyle):
(WebCore::Editor::applyParagraphStyle):
* editing/FormatBlockCommand.h:
(WebCore::FormatBlockCommand::create):
* editing/IndentOutdentCommand.h:
(WebCore::IndentOutdentCommand::create):
* editing/InsertIntoTextNodeCommand.h:
(WebCore::InsertIntoTextNodeCommand::create):
* editing/InsertLineBreakCommand.h:
(WebCore::InsertLineBreakCommand::create):
* editing/InsertNodeBeforeCommand.h:
(WebCore::InsertNodeBeforeCommand::create):
* editing/InsertParagraphSeparatorCommand.h:
(WebCore::InsertParagraphSeparatorCommand::create):
* editing/InsertTextCommand.h:
(WebCore::InsertTextCommand::create):
(WebCore::InsertTextCommand::createWithMarkerSupplier):
* editing/MergeIdenticalElementsCommand.h:
(WebCore::MergeIdenticalElementsCommand::create):
* editing/ModifySelectionListLevel.h:
(WebCore::IncreaseSelectionListLevelCommand::create):
(WebCore::DecreaseSelectionListLevelCommand::create):
* editing/MoveSelectionCommand.h:
(WebCore::MoveSelectionCommand::create):
* editing/RemoveCSSPropertyCommand.h:
(WebCore::RemoveCSSPropertyCommand::create):
* editing/RemoveFormatCommand.h:
(WebCore::RemoveFormatCommand::create):
* editing/RemoveNodeCommand.h:
(WebCore::RemoveNodeCommand::create):
* editing/RemoveNodePreservingChildrenCommand.h:
(WebCore::RemoveNodePreservingChildrenCommand::create):
* editing/ReplaceNodeWithSpanCommand.h:
(WebCore::ReplaceNodeWithSpanCommand::create):
* editing/ReplaceSelectionCommand.h:
(WebCore::ReplaceSelectionCommand::create):
* editing/SetNodeAttributeCommand.h:
(WebCore::SetNodeAttributeCommand::create):
* editing/SetSelectionCommand.h:
(WebCore::SetSelectionCommand::create):
* editing/SimplifyMarkupCommand.h:
(WebCore::SimplifyMarkupCommand::create):
* editing/SpellChecker.cpp:
(WebCore::SpellCheckRequest::create):
* editing/SpellChecker.h:
* editing/SpellingCorrectionCommand.cpp:
(WebCore::SpellingCorrectionRecordUndoCommand::create):
* editing/SpellingCorrectionCommand.h:
(WebCore::SpellingCorrectionCommand::create):
* editing/SplitElementCommand.h:
(WebCore::SplitElementCommand::create):
* editing/SplitTextNodeCommand.h:
(WebCore::SplitTextNodeCommand::create):
* editing/SplitTextNodeContainingElementCommand.h:
(WebCore::SplitTextNodeContainingElementCommand::create):
* editing/TypingCommand.h:
(WebCore::TypingCommand::create):
* editing/UnlinkCommand.h:
(WebCore::UnlinkCommand::create):
* editing/WrapContentsInDummySpanCommand.h:
(WebCore::WrapContentsInDummySpanCommand::create):
* editing/ios/DictationCommandIOS.h:
(WebCore::DictationCommandIOS::create):
* fileapi/Blob.h:
(WebCore::Blob::create):
(WebCore::Blob::deserialize):
(WebCore::Blob::slice):
* fileapi/File.h:
* fileapi/FileList.h:
(WebCore::FileList::create):
* fileapi/FileReader.cpp:
(WebCore::FileReader::create):
* fileapi/FileReader.h:
* fileapi/FileReaderSync.h:
(WebCore::FileReaderSync::create):
* history/BackForwardList.h:
(WebCore::BackForwardList::create):
* history/HistoryItem.h:
(WebCore::HistoryItem::create):
* html/DOMURL.cpp:
(WebCore::DOMURL::create):
* html/DOMURL.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::plugInImageElementIsolatedWorld):
* html/canvas/CanvasGradient.h:
(WebCore::CanvasGradient::create):
* html/canvas/CanvasPattern.cpp:
(WebCore::CanvasPattern::create):
* html/canvas/CanvasPattern.h:
* html/canvas/DOMPath.h:
* html/shadow/DetailsMarkerControl.cpp:
(WebCore::DetailsMarkerControl::create):
* html/shadow/DetailsMarkerControl.h:
* html/track/AudioTrack.h:
* html/track/AudioTrackList.h:
* html/track/DataCue.h:
* inspector/CommandLineAPIHost.cpp:
(WebCore::CommandLineAPIHost::create):
* inspector/CommandLineAPIHost.h:
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::create):
* loader/FormState.cpp:
(WebCore::FormState::create):
* loader/FormState.h:
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
* loader/FormSubmission.h:
* loader/TextResourceDecoder.h:
(WebCore::TextResourceDecoder::create):
* loader/ThreadableLoaderClientWrapper.h:
(WebCore::ThreadableLoaderClientWrapper::create):
* loader/WorkerThreadableLoader.h:
(WebCore::WorkerThreadableLoader::create):
* loader/appcache/ApplicationCache.h:
(WebCore::ApplicationCache::create):
* loader/appcache/ApplicationCacheResource.h:
(WebCore::ApplicationCacheResource::create):
* loader/appcache/DOMApplicationCache.h:
* loader/archive/ArchiveResource.cpp:
(WebCore::ArchiveResource::create):
* loader/archive/ArchiveResource.h:
* loader/icon/IconDatabaseBase.h:
(WebCore::EnumCallback::create):
(WebCore::ObjectCallback::create):
* loader/icon/IconRecord.h:
(WebCore::IconRecord::create):
* mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::create):
* mathml/MathMLInlineContainerElement.h:
* mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::create):
* mathml/MathMLMathElement.h:
* mathml/MathMLMencloseElement.cpp:
(WebCore::MathMLMencloseElement::create):
* mathml/MathMLMencloseElement.h:
* mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::create):
* mathml/MathMLSelectElement.h:
* mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::create):
* mathml/MathMLTextElement.h:
* page/BarProp.h:
(WebCore::BarProp::create):
* page/Crypto.h:
(WebCore::Crypto::create):
* page/DOMSecurityPolicy.h:
(WebCore::DOMSecurityPolicy::create):
* page/DOMSelection.h:
(WebCore::DOMSelection::create):
* page/DOMWindow.h:
* page/DOMWindowExtension.h:
(WebCore::DOMWindowExtension::create):
* page/FrameView.cpp:
(WebCore::FrameView::create):
* page/FrameView.h:
* page/animation/CompositeAnimation.h:
(WebCore::CompositeAnimation::create):
* page/scrolling/AsyncScrollingCoordinator.h:
* platform/Cursor.h:
(WebCore::SharedCursor::create):
* platform/FileChooser.cpp:
(WebCore::FileChooser::create):
* platform/FileChooser.h:
* platform/animation/Animation.h:
(WebCore::Animation::create):
* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::create):
(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):
* platform/audio/AudioBus.h:
* platform/audio/AudioHardwareListener.cpp:
(WebCore::AudioHardwareListener::create):
* platform/audio/AudioHardwareListener.h:
* platform/audio/mac/AudioHardwareListenerMac.cpp:
(WebCore::AudioHardwareListener::create):
(WebCore::AudioHardwareListenerMac::create):
* platform/audio/mac/AudioHardwareListenerMac.h:
* platform/graphics/AudioTrackPrivate.h:
(WebCore::AudioTrackPrivate::create):
* platform/graphics/BitmapImage.h:
* platform/graphics/CrossfadeGeneratedImage.h:
* platform/graphics/FontFeatureSettings.h:
(WebCore::FontFeatureSettings::create):
* platform/graphics/Image.cpp:
(WebCore::Image::nullImage):
* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::create):
* platform/graphics/filters/DistantLightSource.h:
(WebCore::DistantLightSource::create):
* platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::create):
* platform/graphics/filters/FEBlend.h:
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::create):
* platform/graphics/filters/FEColorMatrix.h:
* platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::create):
* platform/graphics/filters/FEComponentTransfer.h:
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::create):
* platform/graphics/filters/FEComposite.h:
* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::create):
* platform/graphics/filters/FEConvolveMatrix.h:
* platform/graphics/filters/FEDiffuseLighting.cpp:
(WebCore::FEDiffuseLighting::create):
* platform/graphics/filters/FEDiffuseLighting.h:
* platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::create):
* platform/graphics/filters/FEDisplacementMap.h:
* platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::create):
* platform/graphics/filters/FEDropShadow.h:
* platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::create):
* platform/graphics/filters/FEFlood.h:
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::create):
* platform/graphics/filters/FEGaussianBlur.h:
* platform/graphics/filters/FEMerge.cpp:
(WebCore::FEMerge::create):
* platform/graphics/filters/FEMerge.h:
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::create):
* platform/graphics/filters/FEMorphology.h:
* platform/graphics/filters/FEOffset.cpp:
(WebCore::FEOffset::create):
* platform/graphics/filters/FEOffset.h:
* platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::create):
* platform/graphics/filters/FESpecularLighting.h:
* platform/graphics/filters/FETile.cpp:
(WebCore::FETile::create):
* platform/graphics/filters/FETile.h:
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::create):
* platform/graphics/filters/FETurbulence.h:
* platform/graphics/ios/DisplayRefreshMonitorIOS.h:
(WebCore::DisplayRefreshMonitorIOS::create):
* platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::create):
* platform/network/BlobData.h:
(WebCore::RawData::create):
(WebCore::BlobData::create):
* platform/network/BlobDataFileReference.h:
(WebCore::BlobDataFileReference::create):
* platform/network/cf/FormDataStreamCFNet.cpp:
* platform/text/BidiContext.cpp:
(WebCore::BidiContext::createUncached):
(WebCore::BidiContext::create):
* platform/text/BidiContext.h:
* plugins/DOMMimeType.h:
(WebCore::DOMMimeType::create):
* plugins/DOMMimeTypeArray.cpp:
(WebCore::DOMMimeTypeArray::item):
(WebCore::DOMMimeTypeArray::namedItem):
* plugins/DOMMimeTypeArray.h:
(WebCore::DOMMimeTypeArray::create):
* plugins/DOMPlugin.cpp:
(WebCore::DOMPlugin::item):
(WebCore::DOMPlugin::namedItem):
* plugins/DOMPlugin.h:
(WebCore::DOMPlugin::create):
* plugins/DOMPluginArray.cpp:
(WebCore::DOMPluginArray::item):
(WebCore::DOMPluginArray::namedItem):
* plugins/DOMPluginArray.h:
(WebCore::DOMPluginArray::create):
* plugins/PluginData.h:
(WebCore::PluginData::create):
* rendering/ClipPathOperation.h:
* rendering/CounterNode.cpp:
(WebCore::CounterNode::create):
* rendering/CounterNode.h:
* rendering/style/BasicShapes.h:
* rendering/style/CursorList.h:
(WebCore::CursorList::create):
* replay/CapturingInputCursor.cpp:
(WebCore::CapturingInputCursor::create):
* replay/CapturingInputCursor.h:
* storage/Storage.cpp:
(WebCore::Storage::create):
* storage/Storage.h:
* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::create):
* storage/StorageAreaImpl.h:
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::create):
* storage/StorageAreaSync.h:
* storage/StorageMap.cpp:
(WebCore::StorageMap::create):
* storage/StorageMap.h:
* storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::create):
* storage/StorageSyncManager.h:
* workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::create):
* workers/DedicatedWorkerGlobalScope.h:
* workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):
* workers/DedicatedWorkerThread.h:
* workers/DefaultSharedWorkerRepository.cpp:
* workers/SharedWorkerGlobalScope.cpp:
(WebCore::SharedWorkerGlobalScope::create):
* workers/SharedWorkerGlobalScope.h:
* workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::createWorkerGlobalScope):
* workers/SharedWorkerThread.h:
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::importScripts):
* workers/WorkerLocation.h:
(WebCore::WorkerLocation::create):
* workers/WorkerScriptLoader.h:
(WebCore::WorkerScriptLoader::create):
* workers/WorkerThread.h:
* xml/DOMParser.h:
(WebCore::DOMParser::create):
* xml/NativeXPathNSResolver.h:
(WebCore::NativeXPathNSResolver::create):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::create):
* xml/XMLHttpRequest.h:
* xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):
* xml/XMLSerializer.h:
(WebCore::XMLSerializer::create):
* xml/XPathEvaluator.h:
(WebCore::XPathEvaluator::create):
* xml/XPathResult.h:
(WebCore::XPathResult::create):
* xml/XSLStyleSheet.h:
* xml/XSLTProcessor.h:
(WebCore::XSLTProcessor::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] WebKit private headers shouldn’t contain “inappropriate” macros
mitz@apple.com [Thu, 25 Dec 2014 06:28:55 +0000 (06:28 +0000)]
[Cocoa] WebKit private headers shouldn’t contain “inappropriate” macros
https://bugs.webkit.org/show_bug.cgi?id=139942

Reviewed by Darin Adler.

* WebKit2.xcodeproj/project.pbxproj: In the Check For Inappropriate Macros in External
Headers script build phase, check the PrivateHeaders directory as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEngineering builds of MiniBrowser ignore deprecated declaration warnings
mitz@apple.com [Thu, 25 Dec 2014 06:26:38 +0000 (06:26 +0000)]
Engineering builds of MiniBrowser ignore deprecated declaration warnings
https://bugs.webkit.org/show_bug.cgi?id=139941

Reviewed by Darin Adler.

* MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
* MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
to YES.
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
deprecated NSOKButton.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSmall cleanup of RenderBlock::paint()
benjamin@webkit.org [Thu, 25 Dec 2014 02:48:11 +0000 (02:48 +0000)]
Small cleanup of RenderBlock::paint()
https://bugs.webkit.org/show_bug.cgi?id=139849

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-24
Reviewed by Daniel Bates.

Remove a couple of instructions by putting variable in the right scope.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify saturated integer add/sub
benjamin@webkit.org [Thu, 25 Dec 2014 02:46:32 +0000 (02:46 +0000)]
Simplify saturated integer add/sub
https://bugs.webkit.org/show_bug.cgi?id=139854

Reviewed by Darin Adler.

* wtf/Compiler.h:
Make a wrapper for __has_builtin for compilers that do not support it.

* wtf/SaturatedArithmetic.h:
(saturatedAddition):
(saturatedSubtraction):
Use the builtins when possible instead of reinventing the wheel.
On ARMv7, use the saturated math instructions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImport the tests for :valid/:invalid on form/fieldset from blink
benjamin@webkit.org [Thu, 25 Dec 2014 02:31:36 +0000 (02:31 +0000)]
Import the tests for :valid/:invalid on form/fieldset from blink
https://bugs.webkit.org/show_bug.cgi?id=139899

Reviewed by Darin Adler.

blink's tests are incredibly basic but it is better to include them
for completeness.

* fast/forms/fieldset-pseudo-valid-style-expected.txt: Added.
* fast/forms/fieldset-pseudo-valid-style.html: Added.
* fast/forms/form-pseudo-valid-style-expected.txt: Added.
* fast/forms/form-pseudo-valid-style.html: Added.
Both tests are from Bartek Nowierski.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoW3C test importer should have an option to disable testharness.js/testharnessreport...
commit-queue@webkit.org [Thu, 25 Dec 2014 00:54:11 +0000 (00:54 +0000)]
W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
https://bugs.webkit.org/show_bug.cgi?id=134763

Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-12-24
Reviewed by Ryosuke Niwa.

Adding an option to disable test harness link conversion.

* Scripts/webkitpy/w3c/test_converter.py:
(convert_for_webkit):
(_W3CTestConverter.__init__):
(_W3CTestConverter.convert_attributes_if_needed):
* Scripts/webkitpy/w3c/test_importer.py:
(parse_args):
(TestImporter.import_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] WebCoreSystemInterface.h declares two unused symbols
mitz@apple.com [Thu, 25 Dec 2014 00:21:52 +0000 (00:21 +0000)]
[Cocoa] WebCoreSystemInterface.h declares two unused symbols
https://bugs.webkit.org/show_bug.cgi?id=139937

Reviewed by Tim Horton.

* platform/graphics/FontPlatformData.h: Removed unused typedefs.

* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData): Stop passing always-zero containerRef parameter to
FontCustomPlatformData constructor.

* platform/graphics/mac/FontCustomPlatformData.h: Removed unused typedefs.
(WebCore::FontCustomPlatformData::FontCustomPlatformData): Removed unused container
parameter and m_atsContainer member variable.

* platform/mac/WebCoreSystemInterface.h: Removed unused typedefs and symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAddressed a linker warning about the definition of a method in a category overridng...
mitz@apple.com [Wed, 24 Dec 2014 23:21:34 +0000 (23:21 +0000)]
Addressed a linker warning about the definition of a method in a category overridng a method from the class.

* UIProcess/API/mac/WKView.mm:
(-[WKView(Private) _targetWindowForMovePreparation]): Deleted. This was identical to the
definition in the main WKView implementation above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoANGLE extern symbols are not hidden by default, but should be
mitz@apple.com [Wed, 24 Dec 2014 23:10:21 +0000 (23:10 +0000)]
ANGLE extern symbols are not hidden by default, but should be
https://bugs.webkit.org/show_bug.cgi?id=139936

Reviewed by Mark Rowe.

* Configurations/Base.xcconfig: Changed GCC_SYMBOLS_PRIVATE_EXTERN to YES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved the Derived Sources target.
mitz@apple.com [Wed, 24 Dec 2014 22:39:50 +0000 (22:39 +0000)]
Removed the Derived Sources target.

It has been empty since r159533.

* ANGLE.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDumpRenderTree crashes are mis-reported as timeouts on Yosemite
ap@apple.com [Wed, 24 Dec 2014 08:34:55 +0000 (08:34 +0000)]
DumpRenderTree crashes are mis-reported as timeouts on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=139933

Reviewed by Daniel Bates.

Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
and there is no way for run-webkit-tests to tell a crashed process from a frozen one
until ReportCrash lets it go.

Reuse existing machinery that tells run-webkit-tests about crashes. The script may
even get the actual crash log eventually - even when it times out waiting for the log, it
makes a second lookup at the very end, after all tests finish. There may be further
improvements needed here, but this small fix addresses most cases that happen in practice.

* DumpRenderTree/mac/DumpRenderTree.mm:
(writeCrashedMessageOnFatalError):
(dumpRenderTree):
Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.

* Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
unhelpful comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Build fix after r177692
changseok.oh@collabora.com [Wed, 24 Dec 2014 05:34:39 +0000 (05:34 +0000)]
[GTK] Build fix after r177692
https://bugs.webkit.org/show_bug.cgi?id=139919

Reviewed by Gyuyoung Kim.

This change addresses build failures introduced after r177692.

* PlatformEfl.cmake: Renamed WebContextSoup to WebProcessPoolSoup.cpp
* PlatformGTK.cmake: ditto.
* UIProcess/API/gtk/PageClientImpl.cpp:
* UIProcess/API/gtk/WebKitDownloadClient.cpp:
* UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp:
(webkitFormSubmissionRequestCreate):
(webkit_form_submission_request_get_text_fields):
* UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h:
* UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
(didReceiveWebViewMessageFromInjectedBundle):
(didReceiveMessageFromInjectedBundle):
* UIProcess/API/gtk/WebKitSecurityManager.cpp:
(registerSecurityPolicyForURIScheme):
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed):
(webkit_web_context_prefetch_dns):
(webkitWebContextGetContext):
* UIProcess/API/gtk/WebKitWebContextPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_snapshot):
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreate):
(webkitWebViewBaseCreateWebPage):
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
* UIProcess/API/gtk/WebKitWindowProperties.cpp:
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* UIProcess/gtk/WebProcessPoolGtk.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp.
(WebKit::initInspectorServer):
(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInvalidateContext):
(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIconDatabasePath):
(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory):
(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory):
(WebKit::WebProcessPool::platformDefaultDiskCacheDirectory):
(WebKit::WebProcessPool::platformDefaultCookieStorageDirectory):
(WebKit::WebProcessPool::setIgnoreTLSErrors):
* UIProcess/soup/WebProcessPoolSoup.cpp: Renamed from Source/WebKit2/UIProcess/soup/WebContextSoup.cpp.
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
* WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(webkitWebExtensionDidReceiveMessage):
* WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(didInitiateLoadForResource):
(willSendRequestForFrame):
(didReceiveResponseForResource):
(didReceiveContentLengthForResource):
(didFinishLoadForResource):
(didFailLoadForResource):
(webkitWebPageDidReceiveMessage):
* WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify RenderStyle::invalidColor() function
cdumez@apple.com [Wed, 24 Dec 2014 04:58:51 +0000 (04:58 +0000)]
Simplify RenderStyle::invalidColor() function
https://bugs.webkit.org/show_bug.cgi?id=139898

Reviewed by Andreas Kling.

Simplify RenderStyle::invalidColor() function by getting rid of the
static variable. The default constructor for Color is very cheap
anyway.

* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS build fix
mitz@apple.com [Wed, 24 Dec 2014 04:50:15 +0000 (04:50 +0000)]
iOS build fix

* UIProcess/API/Cocoa/WKProcessGroup.mm:
(-[WKProcessGroup _geolocationProvider]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't force -O1 for debug ASan builds
ap@apple.com [Wed, 24 Dec 2014 04:43:05 +0000 (04:43 +0000)]
Don't force -O1 for debug ASan builds
https://bugs.webkit.org/show_bug.cgi?id=139926

Reviewed by Darin Adler.

* asan/asan.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, fix build warning after r177712
ljaehun.lim@samsung.com [Wed, 24 Dec 2014 04:33:59 +0000 (04:33 +0000)]
Unreviewed, fix build warning after r177712

../../Source/WebCore/history/PageCache.cpp: In function ‘const char* WebCore::pruningReasonToFeatureCounterKey(WebCore::PruningReason)’:
../../Source/WebCore/history/PageCache.cpp:449:1: error: control reaches end of non-void function [-Werror=return-type]

No new tests, no behavior changes.

* history/PageCache.cpp:
(WebCore::pruningReasonToFeatureCounterKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Fix a lot of build break since r177692
gyuyoung.kim@samsung.com [Wed, 24 Dec 2014 04:09:10 +0000 (04:09 +0000)]
[EFL][WK2] Fix a lot of build break since r177692
https://bugs.webkit.org/show_bug.cgi?id=139932

Unreviewed EFL build fix.

Rename WebContext with WebProcessPool in EFL port files.

* CMakeLists.txt:
* UIProcess/API/efl/EwkView.cpp:
* UIProcess/API/efl/ewk_context.cpp:
* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::WebView):
* UIProcess/CoordinatedGraphics/WebView.h:
* UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp:
(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):
(WebKit::CustomProtocolManagerProxy::startLoading):
(WebKit::CustomProtocolManagerProxy::stopLoading):
* UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp:
(WebKit::WebSoupCustomProtocolRequestManager::create):
(WebKit::WebSoupCustomProtocolRequestManager::WebSoupCustomProtocolRequestManager):
(WebKit::WebSoupCustomProtocolRequestManager::registerSchemeForCustomProtocol):
(WebKit::WebSoupCustomProtocolRequestManager::unregisterSchemeForCustomProtocol):
(WebKit::WebSoupCustomProtocolRequestManager::didReceiveResponse):
(WebKit::WebSoupCustomProtocolRequestManager::didLoadData):
(WebKit::WebSoupCustomProtocolRequestManager::didFailWithError):
(WebKit::WebSoupCustomProtocolRequestManager::didFinishLoading):
* UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.h:
* UIProcess/WebBatteryManagerProxy.cpp:
(WebKit::WebBatteryManagerProxy::create):
(WebKit::WebBatteryManagerProxy::WebBatteryManagerProxy):
(WebKit::WebBatteryManagerProxy::providerDidChangeBatteryStatus):
(WebKit::WebBatteryManagerProxy::providerUpdateBatteryStatus):
* UIProcess/WebBatteryManagerProxy.h:
* UIProcess/WebTextChecker.cpp:
(WebKit::updateStateForAllContexts):
* UIProcess/WebVibrationProxy.cpp:
(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):
* UIProcess/efl/RequestManagerClientEfl.h:
* UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInvalidateContext):
(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIconDatabasePath):
(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory):
(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory):
(WebKit::WebProcessPool::platformDefaultDiskCacheDirectory):
(WebKit::WebProcessPool::platformDefaultCookieStorageDirectory):
(WebKit::WebProcessPool::setIgnoreTLSErrors):
(WebKit::WebContext::platformDefaultApplicationCacheDirectory): Deleted.
(WebKit::WebContext::platformInitializeWebProcess): Deleted.
(WebKit::WebContext::platformInvalidateContext): Deleted.
(WebKit::WebContext::platformDefaultWebSQLDatabaseDirectory): Deleted.
(WebKit::WebContext::platformDefaultIndexedDBDatabaseDirectory): Deleted.
(WebKit::WebContext::platformDefaultIconDatabasePath): Deleted.
(WebKit::WebContext::platformDefaultLocalStorageDirectory): Deleted.
(WebKit::WebContext::platformDefaultMediaKeysStorageDirectory): Deleted.
(WebKit::WebContext::platformDefaultDiskCacheDirectory): Deleted.
(WebKit::WebContext::platformDefaultCookieStorageDirectory): Deleted.
(WebKit::WebContext::setIgnoreTLSErrors): Deleted.
* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebView::create):
(WebKit::WebViewEfl::WebViewEfl):
* UIProcess/efl/WebViewEfl.h:
* UIProcess/soup/WebContextSoup.cpp:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebContext::platformInitializeNetworkProcess): Deleted.
* UIProcess/soup/WebCookieManagerProxySoup.cpp:
(WebKit::WebCookieManagerProxy::setCookiePersistentStorage):
* UIProcess/soup/WebSoupRequestManagerProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove telephone number context support from ContextMenuContextData, it is unused
weinig@apple.com [Wed, 24 Dec 2014 03:09:04 +0000 (03:09 +0000)]
Remove telephone number context support from ContextMenuContextData, it is unused
https://bugs.webkit.org/show_bug.cgi?id=139931

Reviewed by Alexey Proskuryakov.

m_isTelephoneNumberContext was only ever set to true in the ContextMenuContextData
constructor that took a TelephoneNumberContextTag, which never got called. Remove it
all.

* Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):
* Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::isTelephoneNumberContext): Deleted.
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAttempt to fix the Mountain Lion build.
weinig@apple.com [Wed, 24 Dec 2014 02:51:14 +0000 (02:51 +0000)]
Attempt to fix the Mountain Lion build.

* Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::isTelephoneNumberContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHandle WKTypeRefWrapper when converting object graphs
andersca@apple.com [Wed, 24 Dec 2014 01:20:33 +0000 (01:20 +0000)]
Handle WKTypeRefWrapper when converting object graphs
https://bugs.webkit.org/show_bug.cgi?id=139927

Reviewed by Tim Horton.

* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Log better using FeatureCounter why PageCache is failing due to pruned resources
cdumez@apple.com [Wed, 24 Dec 2014 01:14:01 +0000 (01:14 +0000)]
[iOS] Log better using FeatureCounter why PageCache is failing due to pruned resources
https://bugs.webkit.org/show_bug.cgi?id=139921
<rdar://problem/19255690>

Reviewed by Gavin Barraclough.

Source/WebCore:

Log better using FeatureCounter why PageCache is failing due to pruned
resources. In particular, we now distinguish if the resource was pruned
due to:
- Memory pressure
- Page cache capacity reached
- WebProcess suspended (WK2)

* WebCore.exp.in:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
* history/HistoryItem.h:
* history/PageCache.cpp:
(WebCore::PageCache::pruneToCapacityNow):
(WebCore::PageCache::setCapacity):
(WebCore::pruningReasonToFeatureCounterKey):
(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::get):
(WebCore::PageCache::prune):
* history/PageCache.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
* platform/FeatureCounterKeys.h:
* platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseCriticalMemory):

Source/WebKit2:

Call PageCache::pruneToCapacityNow() instead of multiple calls to
setCapacity() as it does exactly what we want. Also pass the new
PrunedReason argument so help us do better logging.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::releasePageCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Fix nullptr dereference in EventHandler::platformPrepareForWheelEvents().
akling@apple.com [Wed, 24 Dec 2014 01:11:17 +0000 (01:11 +0000)]
[Mac] Fix nullptr dereference in EventHandler::platformPrepareForWheelEvents().
<https://webkit.org/b/139923>
<rdar://problem/19182531>

Reviewed by Chris Dumez.

Don't dereference 'wheelEventTarget' until we know it's non-null.
This manifested as a crash in Node::renderBox() with some versions of LLVM.

The compiler was free to assume that the ContainerNode* 'candidate' in
findEnclosingScrollableContainer() would always be non-null on the first
iteration of the loop.

I suspect that we can get here with a null 'wheelEventTarget' during the
rubberbanding phase of a wheel scroll; if the cursor is sitting over the
exposed "gutter" area.

* page/mac/EventHandlerMac.mm:
(WebCore::findEnclosingScrollableContainer):
(WebCore::EventHandler::platformPrepareForWheelEvents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAttempt to fix the iOS build.
weinig@apple.com [Wed, 24 Dec 2014 01:09:14 +0000 (01:09 +0000)]
Attempt to fix the iOS build.

* UIProcess/API/Cocoa/WKProcessGroup.mm:
(-[WKProcessGroup _geolocationProvider]):
* UIProcess/API/ios/WKViewIOS.mm:
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHandle coding object graphs in the UI process
andersca@apple.com [Wed, 24 Dec 2014 01:01:18 +0000 (01:01 +0000)]
Handle coding object graphs in the UI process
https://bugs.webkit.org/show_bug.cgi?id=139925

Reviewed by Sam Weinig.

* UIProcess/Cocoa/WebProcessProxyCocoa.mm: Added.
(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):
* UIProcess/WebProcessProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::transformObjectsToHandles):
* WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoContextMenuContextData should store a ShareableBitmap not a ShareableBitmap::Handle
weinig@apple.com [Wed, 24 Dec 2014 01:00:20 +0000 (01:00 +0000)]
ContextMenuContextData should store a ShareableBitmap not a ShareableBitmap::Handle
https://bugs.webkit.org/show_bug.cgi?id=139924

Reviewed by Anders Carlsson.

Replaces the ShareableBitmap::Handle in ContextMenuContextData with a RefPtr<ShareableBitmap>.
Removes the now unnecessary override copy-constructor and assignment-operator.

* Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):
(WebKit::ContextMenuContextData::controlledDataIsEditable):
(WebKit::ContextMenuContextData::operator=): Deleted.
* Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::controlledImage):
(WebKit::ContextMenuContextData::needsServicesMenu):
(WebKit::ContextMenuContextData::controlledImageHandle): Deleted.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::internalShowContextMenu):
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed iOS build fix after 177692.
cdumez@apple.com [Wed, 24 Dec 2014 00:46:18 +0000 (00:46 +0000)]
Unreviewed iOS build fix after 177692.

Missing WebKit:: namespace.

* UIProcess/ios/WKContentView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix 32-build.
andersca@apple.com [Wed, 24 Dec 2014 00:37:09 +0000 (00:37 +0000)]
Fix 32-build.

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoInstall a TextIndicator for link immediate actions
timothy_horton@apple.com [Wed, 24 Dec 2014 00:14:53 +0000 (00:14 +0000)]
Install a TextIndicator for link immediate actions
https://bugs.webkit.org/show_bug.cgi?id=139897
<rdar://problem/19333076>

Reviewed by Anders Carlsson.

* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _defaultAnimationController]):
Install the link's TextIndicator.

(-[WKImmediateActionController menuItemDidClose:]):
Dismiss the TextIndicator and clean up when the item closes.

* WebView/WebImmediateActionController.h:
* WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _clearImmediateActionState]):
Tear down the TextIndicator, just like WebKit2.

(-[WebImmediateActionController _defaultAnimationController]):
Install a TextIndicator for links.

(-[WebImmediateActionController menuItemDidClose:]):
Tear down the TextIndicator when the QL preview closes.

(-[WebImmediateActionController _menuItemForDataDetectedText]):
Directly install and uninstall the TextIndicator for DataDetectors.

(-[WebImmediateActionController _showTextIndicator]): Deleted.
(-[WebImmediateActionController _hideTextIndicator]): Deleted.
Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.

* platform/spi/mac/QuickLookMacSPI.h:
Add a new piece of SPI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpose ElementBoundingBox on WKHitTestResult
timothy_horton@apple.com [Wed, 24 Dec 2014 00:13:48 +0000 (00:13 +0000)]
Expose ElementBoundingBox on WKHitTestResult
https://bugs.webkit.org/show_bug.cgi?id=139895
<rdar://problem/19333075>

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKHitTestResult.cpp:
(WKHitTestResultGetElementBoundingBox):
* UIProcess/API/C/WKHitTestResult.h:
Expose the rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify building with ASan
ap@apple.com [Wed, 24 Dec 2014 00:13:16 +0000 (00:13 +0000)]
Simplify building with ASan
https://bugs.webkit.org/show_bug.cgi?id=139916

Reviewed by Mark Rowe.

.:

* Makefile.shared: Invoke set-webkit-configuration to store ASan choice as appropriate.

Tools:

* Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
We could also update Configuration file format, but that's a little scary because
of how many places in code read it.

* Scripts/webkitdirs.pm:
(determineASanIsEnabled): Read it from ASan configuration file.
(argumentsForConfiguration): Added a FIXME.
(asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
(XcodeOptions): Pass the options needed for ASan.

* asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
that automatically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the custom web page preview code
timothy_horton@apple.com [Wed, 24 Dec 2014 00:13:03 +0000 (00:13 +0000)]
Remove the custom web page preview code
https://bugs.webkit.org/show_bug.cgi?id=139894
<rdar://problem/19333074>

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKViewPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _dismissContentRelativeChildWindows]):
(-[WKView _viewForPreviewingURL:initialFrameSize:]): Deleted.
(-[WKView _titleForPreviewOfURL:]): Deleted.
(-[WKView _setPreviewTitle:]): Deleted.
(-[WKView _setPreviewLoading:]): Deleted.
(-[WKView _setPreviewOverrideImage:]): Deleted.
(-[WKView _finishPreviewingURL:withPreviewView:]): Deleted.
(-[WKView _handleClickInPreviewView:URL:]): Deleted.
(-[WKView _shouldUseStandardQuickLookPreview]): Deleted.
* UIProcess/mac/WKImmediateActionController.h:
* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController willDestroyView:]):
(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WKImmediateActionController _defaultAnimationController]):
(-[WKImmediateActionController hidePreview]): Deleted.
(-[WKImmediateActionController setPreviewTitle:]): Deleted.
(-[WKImmediateActionController setPreviewLoading:]): Deleted.
(-[WKImmediateActionController setPreviewOverrideImage:]): Deleted.
(-[WKImmediateActionController _animationControllerForCustomPreview]): Deleted.
* UIProcess/mac/WKPagePreviewViewController.h: Removed.
* UIProcess/mac/WKPagePreviewViewController.mm: Removed.
* UIProcess/mac/WKPreviewPopoverAnimationController.h: Removed.
* UIProcess/mac/WKPreviewPopoverAnimationController.mm: Removed.
* WebKit2.xcodeproj/project.pbxproj:
Remove all of the custom web page preview code. Clients that want the custom
preview can implement it by overriding the immediate action.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd WebProcessProxy::transformHandlesToObjects
andersca@apple.com [Tue, 23 Dec 2014 23:58:27 +0000 (23:58 +0000)]
Add WebProcessProxy::transformHandlesToObjects
https://bugs.webkit.org/show_bug.cgi?id=139922

Reviewed by Tim Horton.

This will be used to convert between the handles and their respective UI side objects.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::transformHandlesToObjects):
(WebKit::WebProcessProxy::transformObjectsToHandles):
(WebKit::WebProcessProxy::apiObjectByConvertingToHandles): Deleted.
* UIProcess/WebProcessProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd handle transform functions to WebConnection
andersca@apple.com [Tue, 23 Dec 2014 23:35:33 +0000 (23:35 +0000)]
Add handle transform functions to WebConnection
https://bugs.webkit.org/show_bug.cgi?id=139920

Reviewed by Sam Weinig.

This will be used by the web connection code to convert between objects and their respective handles.

* Shared/WebConnection.h:
* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::transformHandlesToObjects):
(WebKit::WebConnectionToWebProcess::transformObjectsToHandles):
* UIProcess/WebConnectionToWebProcess.h:
* WebProcess/WebConnectionToUIProcess.cpp:
(WebKit::WebConnectionToUIProcess::transformHandlesToObjects):
(WebKit::WebConnectionToUIProcess::transformObjectsToHandles):
* WebProcess/WebConnectionToUIProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename ImmutableDictionary to API::Dictionary and merge MutableDictionary into it
weinig@apple.com [Tue, 23 Dec 2014 23:07:40 +0000 (23:07 +0000)]
Rename ImmutableDictionary to API::Dictionary and merge MutableDictionary into it
https://bugs.webkit.org/show_bug.cgi?id=139917

Reviewed by Anders Carlsson.

- Renames ImmutableDictionary -> API::Dictionary
- Merges MutableDictionary into the new API::Dictionary
    (as a result WKDictionaryIsMutable() now always returns true)

* File list elided *

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd WebProcess::transformObjectsToHandles
andersca@apple.com [Tue, 23 Dec 2014 23:06:10 +0000 (23:06 +0000)]
Add WebProcess::transformObjectsToHandles
https://bugs.webkit.org/show_bug.cgi?id=139918

Reviewed by Tim Horton.

This function will be used for transforming bundle objects to their respective handle types
when sending messages to the UI process.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):
* WebProcess/WebProcess.h:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove dynamic_objc_cast to RetainPtr.h
andersca@apple.com [Tue, 23 Dec 2014 22:27:11 +0000 (22:27 +0000)]
Move dynamic_objc_cast to RetainPtr.h
https://bugs.webkit.org/show_bug.cgi?id=139915

Reviewed by Sam Weinig.

Source/WebKit2:

* Shared/mac/ObjCObjectGraph.mm:
(WebKit::dynamic_objc_cast): Deleted.

Source/WTF:

* wtf/RetainPtr.h:
(WTF::dynamic_objc_cast):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRe-indent RefPtr.h and RetainPtr.h.
andersca@apple.com [Tue, 23 Dec 2014 22:16:46 +0000 (22:16 +0000)]
Re-indent RefPtr.h and RetainPtr.h.

Rubber-stamped by Sam Weinig.

* wtf/RefPtr.h:
* wtf/RetainPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd WebProcess::transformHandlesToObjects
andersca@apple.com [Tue, 23 Dec 2014 22:14:48 +0000 (22:14 +0000)]
Add WebProcess::transformHandlesToObjects
https://bugs.webkit.org/show_bug.cgi?id=139913

Reviewed by Tim Horton.

Rename objectGraphByTransformingObjectsToHandles to transformObjectsToHandles and add
transformHandlesToObjects that will try to convert handles to the actual bundle type objects.

* WebProcess/WebProcess.h:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::transformObjectsToHandles):
(WebKit::WebProcess::objectGraphByTransformingObjectsToHandles): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd WebProcess::objectGraphByTransformingObjectsToHandles
andersca@apple.com [Tue, 23 Dec 2014 21:53:07 +0000 (21:53 +0000)]
Add WebProcess::objectGraphByTransformingObjectsToHandles
https://bugs.webkit.org/show_bug.cgi?id=139912

Reviewed by Tim Horton.

This will be used to convert Objective-C object graphs containing bundle types to their handle counterparts.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::transformHandlesToObjects):
(WebKit::WebProcess::apiObjectByConvertingFromHandles): Deleted.
Rename apiObjectByConvertingFromHandles to transformHandlesToObjects.

* WebProcess/WebProcess.h:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::objectGraphByTransformingObjectsToHandles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix UserMessage::transform to only call shouldTransform once
andersca@apple.com [Tue, 23 Dec 2014 20:44:25 +0000 (20:44 +0000)]
Fix UserMessage::transform to only call shouldTransform once
https://bugs.webkit.org/show_bug.cgi?id=139911

Reviewed by Sam Weinig.

Also, make it possible for transformers to return null objects and change the transformers
to return the passed in object when there's no need to do a transform.

* Shared/UserData.cpp:
(WebKit::transformGraph):
(WebKit::UserData::transform):
(WebKit::UserData::encode): Deleted.
(WebKit::UserData::decode): Deleted.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::apiObjectByConvertingFromHandles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename WebContext to WebProcessPool
weinig@apple.com [Tue, 23 Dec 2014 20:29:26 +0000 (20:29 +0000)]
Rename WebContext to WebProcessPool
https://bugs.webkit.org/show_bug.cgi?id=139909

Rubber-stamped by Anders Carlsson.

Source/WebCore:

Merge SessionID and SessionIDHash into one file to make auto-generation of
HashMaps with SessionIDs easier.

* WebCore.xcodeproj/project.pbxproj:
* loader/cache/MemoryCache.h:
* page/SessionID.h:
(WTF::SessionIDHash::hash):
(WTF::SessionIDHash::equal):
(WTF::HashTraits<WebCore::SessionID>::emptyValue):
(WTF::HashTraits<WebCore::SessionID>::constructDeletedValue):
(WTF::HashTraits<WebCore::SessionID>::isDeletedValue):
* page/SessionIDHash.h: Removed.

Source/WebKit2:

- Major renames:
    WebContext -> WebProcessPool
    WebContextConfiguration -> WebProcessPoolConfiguration
    API::ContextConfiguration -> API::ProcessPoolConfiguration

* File list elided *

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOnly call shouldTransformGraph once per graph
andersca@apple.com [Tue, 23 Dec 2014 20:15:48 +0000 (20:15 +0000)]
Only call shouldTransformGraph once per graph
https://bugs.webkit.org/show_bug.cgi?id=139910

Reviewed by Sam Weinig.

Don't call shouldTransformGraph for each node in the object graph. Instead, call it once
and then transform the entire graph if needed.

* Shared/mac/ObjCObjectGraph.h:
* Shared/mac/ObjCObjectGraph.mm:
(WebKit::shouldTransformGraph):
(WebKit::transformGraph):
(WebKit::ObjCObjectGraph::transform):
(WebKit::shouldTransform): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTestWebKitAPI build is broken when ASan is enabled
ap@apple.com [Tue, 23 Dec 2014 20:01:42 +0000 (20:01 +0000)]
TestWebKitAPI build is broken when ASan is enabled
https://bugs.webkit.org/show_bug.cgi?id=139902

Reviewed by Darin Adler.

* TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
* TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
Inherit linker flags from DebugRelease, which respects ASAN.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoplatform/mac/editing/input/devanagari-ligature.html is flaky on Yosemite, ligature...
mmaxfield@apple.com [Tue, 23 Dec 2014 19:23:48 +0000 (19:23 +0000)]
platform/mac/editing/input/devanagari-ligature.html is flaky on Yosemite, ligature fails to form
https://bugs.webkit.org/show_bug.cgi?id=138683

Reviewed by Darin Adler.

This patch changes how we check fonts for equality. In particular, this patch adds a
objectForEqualityCheck() to Cocoa's FontPlatformData, and callers should pass this object
to CFEqual() to determine if two platform fonts are equal. This patch also migrates all
call sites to using this function.

I don't want to implement operator==() because there are many cases where the same font
is compared against many others, and this solution is cleaner than caching a comparison
object inside the font object itself.

No new tests because this is covered by platform/mac/editing/input/devanagari-ligature.html.

* platform/graphics/FontPlatformData.h:
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::objectForEqualityCheck):
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::GlyphPage::fill):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):
* platform/spi/cocoa/CoreTextSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[SVG -> OTF Converter] Make Placeholder a move-only type
mmaxfield@apple.com [Tue, 23 Dec 2014 18:45:05 +0000 (18:45 +0000)]
[SVG -> OTF Converter] Make Placeholder a move-only type
https://bugs.webkit.org/show_bug.cgi?id=139870

Reviewed by Anders Carlsson.

No new tests because there is no behavior change.

* svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::Placeholder::Placeholder):
(WebCore::SVGToOTFFontConverter::Placeholder::populate):
(WebCore::SVGToOTFFontConverter::Placeholder::~Placeholder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove color CSS properties to the new StyleBuilder
cdumez@apple.com [Tue, 23 Dec 2014 18:37:21 +0000 (18:37 +0000)]
Move color CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139898

Reviewed by Antti Koivisto.

Move color CSS properties to the new StyleBuilder by teaching the
StyleBuilder generator how to handle them.

* css/CSSPropertyNames.in:
- Move color properties to the new StyleBuilder.

* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::defaultInitialColor): Deleted.
(WebCore::ApplyPropertyColor::applyInheritValue): Deleted.
(WebCore::ApplyPropertyColor::applyInitialValue): Deleted.
(WebCore::ApplyPropertyColor::applyValue): Deleted.
(WebCore::ApplyPropertyColor::applyColorValue): Deleted.
(WebCore::ApplyPropertyColor::createHandler): Deleted.
- Drop color properties support from the DeprecatedStyleBuilder.

* css/makeprop.pl:
- Teach the StyleBuilder generator how to handle color properties.
- Use a class for StyleBuilderFunctions instead of a namespace so
  that it can be made a friend of RenderStyle class.

* rendering/style/RenderStyle.h:
- Mark StyleBuilderFunctions class as friend as its functions
  can set RenderStyle members directly. This is similar to what
  is already done for StyleBuilderCustom class. The new color
  properties handling calls private methods on RenderStyle.
- Mark invalidColor() method as static as it does not require
  an instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIncorrect dashed and dotted border painting.
zalan@apple.com [Tue, 23 Dec 2014 18:04:39 +0000 (18:04 +0000)]
Incorrect dashed and dotted border painting.
https://bugs.webkit.org/show_bug.cgi?id=139872
rdar://problem/18024205

Reviewed by Simon Fraser.

This patch makes dashed/dotted border painting symmetric and consistent.
It also works with subpixel positioning.

Source/WebCore:

Tests: fast/borders/border-painting-correctness-dashed.html
       fast/borders/border-painting-correctness-dotted.html

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLine):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

* fast/borders/border-painting-correctness-dashed-expected.html: Added.
* fast/borders/border-painting-correctness-dashed.html: Added.
* fast/borders/border-painting-correctness-dotted-expected.html: Added.
* fast/borders/border-painting-correctness-dotted.html: Added.
* fast/borders/resources/border-painting-correctness-dashed-expected.png: Added.
* fast/borders/resources/border-painting-correctness-dotted-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse a Transformer for UserData as well, to avoid always copying arrays and dictionaries
andersca@apple.com [Tue, 23 Dec 2014 16:52:54 +0000 (16:52 +0000)]
Use a Transformer for UserData as well, to avoid always copying arrays and dictionaries
https://bugs.webkit.org/show_bug.cgi?id=139896

Reviewed by Darin Adler.

* Shared/UserData.cpp:
(WebKit::shouldTransform):
(WebKit::UserData::transform):
* Shared/UserData.h:
(WebKit::UserData::Transformer::~Transformer):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::apiObjectByConvertingFromHandles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoediting/spelling/grammar-paste.html is flaky in debug after r177682
g.czajkowski@samsung.com [Tue, 23 Dec 2014 10:29:14 +0000 (10:29 +0000)]
editing/spelling/grammar-paste.html is flaky in debug after r177682
https://bugs.webkit.org/show_bug.cgi?id=139903

Unreviewed gardening.

* TestExpectations:
Mark it as flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd proper expectations for two spelling/ tests after r177682
g.czajkowski@samsung.com [Tue, 23 Dec 2014 09:36:44 +0000 (09:36 +0000)]
Add proper expectations for two spelling/ tests after r177682

Unreviewed gardening.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoshouldBecomeEqual() behaves as shouldBe() if the testing expression returns the expec...
g.czajkowski@samsung.com [Tue, 23 Dec 2014 08:26:49 +0000 (08:26 +0000)]
shouldBecomeEqual() behaves as shouldBe() if the testing expression returns the expected value
https://bugs.webkit.org/show_bug.cgi?id=133939

Reviewed by Darin Adler.

First call of eval(expression) inside shouldBecomeEqual was always
made synchronously. If the testing expression returns the same value
as expected one then shouldBecomeEqual() will immediately report PASS,
for example,

shouldBecomeEqual(internals.hasSpellingMarker("wellcome"), false);

in consequence, assuming asynchronous path of spellchecking, spelling markers
may appear after a while.

The bug was caused by checking a condition at the beginning of shouldBecomeEqual(),
before calling a timer. As a result, queued asynchronous events doesn't effect
this checking.

* TestExpectations:
This fix reveals new bugs in execDeleteCommand() behaviour, two tests need
to marked as failure now.

* resources/js-test-pre.js:
(.condition):
(shouldBecomeEqual):
(shouldBecomeDifferent):
* resources/js-test.js:
(.condition):
(shouldBecomeEqual):
(shouldBecomeDifferent):
Always check a condition on timer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Log which type of resources are commonly loaded using FeatureCounter
cdumez@apple.com [Tue, 23 Dec 2014 07:28:53 +0000 (07:28 +0000)]
[iOS] Log which type of resources are commonly loaded using FeatureCounter
https://bugs.webkit.org/show_bug.cgi?id=139890

Reviewed by Darin Adler.

Log which type of resources are commonly loaded using FeatureCounter
(e.g. stylesheets, scripts, fonts, images, ...).

* loader/SubresourceLoader.cpp:
(WebCore::logResourceLoadedUsingFeatureCounter):
(WebCore::SubresourceLoader::didFinishLoading):
* platform/FeatureCounterKeys.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Log using FeatureCounter when a PacheCache fails due to memory pressure
cdumez@apple.com [Tue, 23 Dec 2014 07:23:14 +0000 (07:23 +0000)]
[iOS] Log using FeatureCounter when a PacheCache fails due to memory pressure
https://bugs.webkit.org/show_bug.cgi?id=139874
<rdar://problem/19255690>

Reviewed by Darin Adler.

Log using FeatureCounter when a PacheCache fails due to memory
pressure. To detect this, a flag is added to HistoryItem to mark
items that are no longer in the page becaused they were pruned
(either because of a low memory handling or because the page cache
reached its maximum capacity).

* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
* history/HistoryItem.h:
* history/PageCache.cpp:
(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::get):
(WebCore::PageCache::prune):
* platform/FeatureCounterKeys.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoplatform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability.html...
ap@apple.com [Tue, 23 Dec 2014 07:17:54 +0000 (07:17 +0000)]
platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139901

* platform/mac-wk2/TestExpectations: Mark it as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r177658.
commit-queue@webkit.org [Tue, 23 Dec 2014 07:15:54 +0000 (07:15 +0000)]
Unreviewed, rolling out r177658.
https://bugs.webkit.org/show_bug.cgi?id=139900

Caused many assertion failures (Requested by ap on #webkit).

Reverted changeset:

"Incorrect dashed and dotted border painting."
https://bugs.webkit.org/show_bug.cgi?id=139872
http://trac.webkit.org/changeset/177658

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake it possible to transform Objective-C object graphs, replacing certain elements...
andersca@apple.com [Tue, 23 Dec 2014 03:24:06 +0000 (03:24 +0000)]
Make it possible to transform Objective-C object graphs, replacing certain elements with others
https://bugs.webkit.org/show_bug.cgi?id=139893

Reviewed by Sam Weinig.

* Shared/mac/ObjCObjectGraph.h:
(WebKit::ObjCObjectGraph::Transformer::~Transformer):
* Shared/mac/ObjCObjectGraph.mm:
(WebKit::dynamic_objc_cast):
(WebKit::shouldTransform):
(WebKit::ObjCObjectGraph::transform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r177661 and r177662
ljaehun.lim@samsung.com [Tue, 23 Dec 2014 03:21:58 +0000 (03:21 +0000)]
Unreviewed build fix after r177661 and r177662

Source/WebCore:

* dom/SecurityOriginPolicy.cpp: Modify #include path.

Source/WebKit2:

* CMakeLists.txt: Add APIPageGroupHandle.cpp to the source list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse ctiPatchCallByReturnAddress() in JITOperations.cpp.
mark.lam@apple.com [Tue, 23 Dec 2014 02:48:00 +0000 (02:48 +0000)]
Use ctiPatchCallByReturnAddress() in JITOperations.cpp.
<https://webkit.org/b/139892>

Reviewed by Michael Saboff.

The code in JITOperations.cpp sometimes calls RepatchBuffer::relinkCallerToFunction()
directly, and sometimes uses a helper function, ctiPatchCallByReturnAddress().
This patch changes it to use the helper function consistently.

* jit/JITOperations.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Engineering builds of WebCore on OS X 10.8 and 10.9 shouldn't build with -gline...
mrowe@apple.com [Tue, 23 Dec 2014 02:24:23 +0000 (02:24 +0000)]
[Mac] Engineering builds of WebCore on OS X 10.8 and 10.9 shouldn't build with -gline-tables-only
<https://webkit.org/b/139883> / <rdar://problem/19297261>

Reviewed by Alexey Proskuryakov.

* Configurations/DebugRelease.xcconfig: Override the setting using conditional settings
so that they take precedence over the conditional settings in Base.xcconfig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoConvert pages and page groups to their respective handle objects
andersca@apple.com [Tue, 23 Dec 2014 01:59:21 +0000 (01:59 +0000)]
Convert pages and page groups to their respective handle objects
https://bugs.webkit.org/show_bug.cgi?id=139891

Reviewed by Tim Horton.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::apiObjectByConvertingFromHandles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Build fix after r177668.
bfulgham@apple.com [Tue, 23 Dec 2014 01:54:09 +0000 (01:54 +0000)]
[Win] Build fix after r177668.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing export definition
for new symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a bunch of missing header includes in preparation for making toImpl require the...
andersca@apple.com [Tue, 23 Dec 2014 01:32:36 +0000 (01:32 +0000)]
Add a bunch of missing header includes in preparation for making toImpl require the complete type
https://bugs.webkit.org/show_bug.cgi?id=139887

Reviewed by Andreas Kling.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix.
ap@apple.com [Tue, 23 Dec 2014 01:23:41 +0000 (01:23 +0000)]
Unreviewed build fix.

* WebCore.exp.in: Move SQLiteDatabaseTracker::setClient export out of PLATFORM(IOS) section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove two functions from SecurityOrigin
andersca@apple.com [Tue, 23 Dec 2014 00:54:18 +0000 (00:54 +0000)]
Remove two functions from SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=139885

Reviewed by Andreas Kling.

* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canAccessPasswordManager): Deleted.
(WebCore::SecurityOrigin::canAccessFileSystem): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix some typos in a comment.
mark.lam@apple.com [Tue, 23 Dec 2014 00:50:24 +0000 (00:50 +0000)]
Fix some typos in a comment.
<https://webkit.org/b/139882>

Reviewed by Michael Saboff.

* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Log using FeatureCounter user-triggered zooming
cdumez@apple.com [Tue, 23 Dec 2014 00:48:55 +0000 (00:48 +0000)]
[iOS] Log using FeatureCounter user-triggered zooming
https://bugs.webkit.org/show_bug.cgi?id=139879
<rdar://problem/19329130>

Reviewed by Benjamin Poulain.

Log using FeatureCounter user-triggered zooming on iOS.

Source/WebCore:

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/FeatureCounter.h:
* platform/FeatureCounterKeys.h:

Source/WebKit2:

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::willStartUserTriggeredZooming):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoForm elements should match :valid and :invalid based on their associated elements
benjamin@webkit.org [Tue, 23 Dec 2014 00:38:52 +0000 (00:38 +0000)]
Form elements should match :valid and :invalid based on their associated elements
https://bugs.webkit.org/show_bug.cgi?id=139850

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-22
Reviewed by Darin Adler.

Source/WebCore:

In the latest HTML spec, form elements can match :valid or :invalid based
on their associated element.

The tricky part is that object lifetime is a mess. When elements are associated
with forms by the parser, the form is set by the constructor of HTMLFormControlElement.
At that point, the real object has not been initialized yet which
makes it impossible to find its validity.

To work around the lifetime problem, the code of HTMLFormControlElement::didChangeForm()
uses m_willValidateInitialized and m_willValidate direclty instead
of invoking willValidate(). That way we don't try to validate an incomplete object.

When the object really validates, HTMLFormControlElement::setNeedsWillValidateCheck()
takes care of updating the form.

Tests: fast/css/pseudo-invalid-form-and-fieldset-basics.html
       fast/css/pseudo-invalid-form-basics.html
       fast/css/pseudo-invalid-form-dynamically-created-basics.html
       fast/css/pseudo-invalid-form-invalidation-optimization.html
       fast/css/pseudo-valid-form-and-fieldset-basics.html
       fast/css/pseudo-valid-form-basics.html
       fast/css/pseudo-valid-form-dynamically-created-basics.html
       fast/css/pseudo-valid-form-invalidation-optimization.html
       fast/selectors/invalid-form-style-update-1.html
       fast/selectors/invalid-form-style-update-2.html
       fast/selectors/invalid-form-style-update-3.html
       fast/selectors/valid-form-style-update-1.html
       fast/selectors/valid-form-style-update-2.html
       fast/selectors/valid-form-style-update-3.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::canShareStyleWithElement):
HTMLFormElement is not a FormControl, we have to generalize the test
for :valid/:invalid with style sharing.

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::~HTMLFormControlElement):
Since we now have willChangeForm(), didChangeForm(), we have to null
the form ourself, as documented by FormAssociatedElement.

(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
(WebCore::HTMLFormControlElement::willChangeForm):
(WebCore::HTMLFormControlElement::didChangeForm):
(WebCore::HTMLFormControlElement::updateValidity):
Update the owner form when any of the associated form element changes
to invalid.

* html/HTMLFormControlElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::registerInvalidAssociatedFormControl):
(WebCore::HTMLFormElement::removeInvalidAssociatedFormControlIfNeeded):
(WebCore::HTMLFormElement::matchesValidPseudoClass):
(WebCore::HTMLFormElement::matchesInvalidPseudoClass):
This is very similar to the code of fieldset, but we have much weaker
invariants due to the insane way FormAssociatedElement initializes.

* html/HTMLFormElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::initializeInputType):
For completeness, we should always validate when changing the type.
The code was only doing that when the element was inserted into the tree,
that was too fragile.

LayoutTests:

The style update tests are largely based on the fieldset test suite.
The other tests are for various aspects of the patch.

* fast/css/pseudo-invalid-form-and-fieldset-basics-expected.html: Added.
* fast/css/pseudo-invalid-form-and-fieldset-basics.html: Added.
* fast/css/pseudo-invalid-form-basics-expected.html: Added.
* fast/css/pseudo-invalid-form-basics.html: Added.
* fast/css/pseudo-invalid-form-dynamically-created-basics-expected.html: Added.
* fast/css/pseudo-invalid-form-dynamically-created-basics.html: Added.
* fast/css/pseudo-invalid-form-invalidation-optimization-expected.txt: Added.
* fast/css/pseudo-invalid-form-invalidation-optimization.html: Added.
* fast/css/pseudo-valid-form-and-fieldset-basics-expected.html: Added.
* fast/css/pseudo-valid-form-and-fieldset-basics.html: Added.
* fast/css/pseudo-valid-form-basics-expected.html: Added.
* fast/css/pseudo-valid-form-basics.html: Added.
* fast/css/pseudo-valid-form-dynamically-created-basics-expected.html: Added.
* fast/css/pseudo-valid-form-dynamically-created-basics.html: Added.
* fast/css/pseudo-valid-form-invalidation-optimization-expected.txt: Added.
* fast/css/pseudo-valid-form-invalidation-optimization.html: Added.
* fast/selectors/invalid-form-style-update-1-expected.txt: Added.
* fast/selectors/invalid-form-style-update-1.html: Added.
* fast/selectors/invalid-form-style-update-2-expected.txt: Added.
* fast/selectors/invalid-form-style-update-2.html: Added.
* fast/selectors/invalid-form-style-update-3-expected.txt: Added.
* fast/selectors/invalid-form-style-update-3.html: Added.
* fast/selectors/valid-form-style-update-1-expected.txt: Added.
* fast/selectors/valid-form-style-update-1.html: Added.
* fast/selectors/valid-form-style-update-2-expected.txt: Added.
* fast/selectors/valid-form-style-update-2.html: Added.
* fast/selectors/valid-form-style-update-3-expected.txt: Added.
* fast/selectors/valid-form-style-update-3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix the Windows build.
andersca@apple.com [Tue, 23 Dec 2014 00:02:45 +0000 (00:02 +0000)]
Try to fix the Windows build.

* dom/DOMAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd an API::PageGroupHandle object
andersca@apple.com [Mon, 22 Dec 2014 23:56:22 +0000 (23:56 +0000)]
Add an API::PageGroupHandle object
https://bugs.webkit.org/show_bug.cgi?id=139881

Reviewed by Sam Weinig.

API::PageGroupHandle won't be exposed to any API, it will only be used to facilitate passing page groups
between the UI and web process inside UserData objects.

* Shared/API/APIObject.h:
* Shared/API/APIPageGroupHandle.cpp: Added.
(API::PageGroupHandle::create):
(API::PageGroupHandle::~PageGroupHandle):
(API::PageGroupHandle::PageGroupHandle):
* Shared/API/APIPageGroupHandle.h: Added.
(API::PageGroupHandle::webPageGroupData):
* Shared/UserData.cpp:
(WebKit::UserData::UserData):
(WebKit::UserData::encode):
(WebKit::UserData::decode):
* Shared/UserData.h:
* UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::data):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a SecurityOriginPolicy class
andersca@apple.com [Mon, 22 Dec 2014 23:42:30 +0000 (23:42 +0000)]
Add a SecurityOriginPolicy class
https://bugs.webkit.org/show_bug.cgi?id=139875

Reviewed by Sam Weinig.

This is the first step towards making SecurityOrigin immutable. SecurityOriginPolicy will hold a
SecurityOrigin and will handle things that would otherwise mutate SecurityOrigin.

* CMakeLists.txt:
* WebCore.exp.in:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):
* dom/Document.cpp:
(WebCore::Document::create):
(WebCore::Document::open):
(WebCore::Document::cloneDataFromDocument):
(WebCore::Document::initSecurityContext):
* dom/ScriptExecutionContext.h:
* dom/SecurityContext.cpp:
(WebCore::SecurityContext::setSecurityOriginPolicy):
(WebCore::SecurityContext::securityOrigin):
(WebCore::SecurityContext::isSecureTransitionTo):
(WebCore::SecurityContext::enforceSandboxFlags):
(WebCore::SecurityContext::setSecurityOrigin): Deleted.
* dom/SecurityContext.h:
(WebCore::SecurityContext::securityOriginPolicy):
(WebCore::SecurityContext::securityOrigin): Deleted.
* dom/SecurityOriginPolicy.cpp: Added.
(WebCore::SecurityOriginPolicy::create):
(WebCore::SecurityOriginPolicy::SecurityOriginPolicy):
(WebCore::SecurityOriginPolicy::~SecurityOriginPolicy):
* dom/SecurityOriginPolicy.h: Added.
(WebCore::SecurityOriginPolicy::origin):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseXML):
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agocompositing/rtl/rtl-fixed-overflow-scrolled.html had a 1600x1200 expected PNG
ap@apple.com [Mon, 22 Dec 2014 23:30:29 +0000 (23:30 +0000)]
compositing/rtl/rtl-fixed-overflow-scrolled.html had a 1600x1200 expected PNG
accidentally checked in, let's land 800x600 again.

* platform/mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSort the Xcode project file.
simon.fraser@apple.com [Mon, 22 Dec 2014 23:27:49 +0000 (23:27 +0000)]
Sort the Xcode project file.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIncorrect dashed and dotted border painting.
zalan@apple.com [Mon, 22 Dec 2014 23:18:59 +0000 (23:18 +0000)]
Incorrect dashed and dotted border painting.
https://bugs.webkit.org/show_bug.cgi?id=139872
rdar://problem/18024205

Reviewed by Simon Fraser.

This patch makes dashed/dotted border painting symmetric and consistent.
It also works with subpixel positioning.

Source/WebCore:

Tests: fast/borders/border-painting-correctness-dashed.html
       fast/borders/border-painting-correctness-dotted.html

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLine):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

* fast/borders/border-painting-correctness-dashed-expected.html: Added.
* fast/borders/border-painting-correctness-dashed.html: Added.
* fast/borders/border-painting-correctness-dotted-expected.html: Added.
* fast/borders/border-painting-correctness-dotted.html: Added.
* fast/borders/resources/border-painting-correctness-dashed-expected.png: Added.
* fast/borders/resources/border-painting-correctness-dotted-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAssert that Array elements not copied when changing shape to ArrayStorage type are...
mark.lam@apple.com [Mon, 22 Dec 2014 23:09:22 +0000 (23:09 +0000)]
Assert that Array elements not copied when changing shape to ArrayStorage type are indeed holes.
<https://webkit.org/b/138118>

Reviewed by Michael Saboff.

* runtime/JSObject.cpp:
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTextIndicatorWindow is larger than it needs to be, especially when not bouncing
timothy_horton@apple.com [Mon, 22 Dec 2014 22:17:42 +0000 (22:17 +0000)]
TextIndicatorWindow is larger than it needs to be, especially when not bouncing
https://bugs.webkit.org/show_bug.cgi?id=139876
<rdar://problem/19311017>

Reviewed by Sam Weinig.

* page/TextIndicator.cpp:
(WebCore::TextIndicator::wantsBounce):
(WebCore::TextIndicator::wantsContentCrossfade):
(WebCore::TextIndicator::wantsFadeIn):
* page/TextIndicator.h:
* page/mac/TextIndicatorWindow.mm:
(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
(-[WebTextIndicatorView _animationDuration]):
(-[WebTextIndicatorView present]):
(WebCore::TextIndicatorWindow::setTextIndicator):
(-[WebTextIndicatorView _textIndicatorWantsBounce]): Deleted.
(-[WebTextIndicatorView _textIndicatorWantsContentCrossfade]): Deleted.
(-[WebTextIndicatorView _textIndicatorWantsFadeIn]): Deleted.
Move the various switches over TextIndicatorPresentationTransition into TextIndicator.
Adjust the margin; only inflate by the shadow if we're not bouncing.
If we are bouncing, fix the math to more tightly fit the bounce.
Previously we were inflating by way too much, and even when we didn't need to.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate apple-mac-114 to bot629.
lforschler@apple.com [Mon, 22 Dec 2014 21:45:18 +0000 (21:45 +0000)]
Update apple-mac-114 to bot629.

Unreviewed.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace Apple bot104 with bot124.
lforschler@apple.com [Mon, 22 Dec 2014 21:37:59 +0000 (21:37 +0000)]
Replace Apple bot104 with bot124.

Unreviewed.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION: fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html is flaky
ap@apple.com [Mon, 22 Dec 2014 21:20:23 +0000 (21:20 +0000)]
REGRESSION: fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139840

* TestExpectations: Marking as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the iOS build after <https://trac.webkit.org/changeset/177639>
dbates@webkit.org [Mon, 22 Dec 2014 21:12:43 +0000 (21:12 +0000)]
Fix the iOS build after <https://trac.webkit.org/changeset/177639>
(https://bugs.webkit.org/show_bug.cgi?id=139866)

Substitute APISecurityOrigin.h for WebSecurityOrigin.h as the latter was renamed to the former.

* UIProcess/ios/WKGeolocationProviderIOS.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoURTBF after r177649.
ossy@webkit.org [Mon, 22 Dec 2014 20:55:48 +0000 (20:55 +0000)]
URTBF after r177649.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLast URTBF after r177639, GTK builds now.
ossy@webkit.org [Mon, 22 Dec 2014 20:48:53 +0000 (20:48 +0000)]
Last URTBF after r177639, GTK builds now.

* UIProcess/API/gtk/WebKitJavascriptResult.cpp:
* UIProcess/API/gtk/WebKitUIClient.cpp:
* UIProcess/API/gtk/WebKitUserContentManager.cpp:
* UIProcess/API/gtk/WebKitUserMediaPermissionRequest.cpp:
(webkitUserMediaPermissionRequestCreate):
* UIProcess/API/gtk/WebKitUserMediaPermissionRequestPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewRunJavaScriptCallback):
(webkit_web_view_run_javascript):
(resourcesStreamReadCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove more API classes from Shared to Shared/API.
andersca@apple.com [Mon, 22 Dec 2014 20:39:02 +0000 (20:39 +0000)]
Move more API classes from Shared to Shared/API.

Rubber-stamped by Sam Weinig.

* Shared/API/APIArray.cpp: Renamed from Source/WebKit2/Shared/APIArray.cpp.
* Shared/API/APIArray.h: Renamed from Source/WebKit2/Shared/APIArray.h.
* Shared/API/APIClient.h: Renamed from Source/WebKit2/Shared/APIClient.h.
* Shared/API/APIData.cpp: Renamed from Source/WebKit2/Shared/APIData.cpp.
* Shared/API/APIData.h: Renamed from Source/WebKit2/Shared/APIData.h.
* Shared/API/APIError.cpp: Renamed from Source/WebKit2/Shared/APIError.cpp.
* Shared/API/APIError.h: Renamed from Source/WebKit2/Shared/APIError.h.
* Shared/API/APIFrameHandle.cpp: Renamed from Source/WebKit2/Shared/APIFrameHandle.cpp.
* Shared/API/APIFrameHandle.h: Renamed from Source/WebKit2/Shared/APIFrameHandle.h.
* Shared/API/APIGeometry.cpp: Renamed from Source/WebKit2/Shared/APIGeometry.cpp.
* Shared/API/APIGeometry.h: Renamed from Source/WebKit2/Shared/APIGeometry.h.
* Shared/API/APINumber.h: Renamed from Source/WebKit2/Shared/APINumber.h.
* Shared/API/APIObject.cpp: Renamed from Source/WebKit2/Shared/APIObject.cpp.
* Shared/API/APIObject.h: Renamed from Source/WebKit2/Shared/APIObject.h.
* Shared/API/APIPageHandle.cpp: Renamed from Source/WebKit2/Shared/APIPageHandle.cpp.
* Shared/API/APIPageHandle.h: Renamed from Source/WebKit2/Shared/APIPageHandle.h.
* Shared/API/APIString.h: Renamed from Source/WebKit2/Shared/APIString.h.
* Shared/API/APIURL.h: Renamed from Source/WebKit2/Shared/APIURL.h.
* Shared/API/APIURLRequest.cpp: Renamed from Source/WebKit2/Shared/APIURLRequest.cpp.
* Shared/API/APIURLRequest.h: Renamed from Source/WebKit2/Shared/APIURLRequest.h.
* Shared/API/APIURLResponse.cpp: Renamed from Source/WebKit2/Shared/APIURLResponse.cpp.
* Shared/API/APIURLResponse.h: Renamed from Source/WebKit2/Shared/APIURLResponse.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate some inspector test expectations for the new timeout detection.
ap@apple.com [Mon, 22 Dec 2014 20:13:12 +0000 (20:13 +0000)]
Update some inspector test expectations for the new timeout detection.
Also, unmarked some tests that appear stable on bots now.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Log using FeatureCounter when a PacheCache entry is not reused because it expired
cdumez@apple.com [Mon, 22 Dec 2014 20:13:07 +0000 (20:13 +0000)]
[iOS] Log using FeatureCounter when a PacheCache entry is not reused because it expired
https://bugs.webkit.org/show_bug.cgi?id=139869
<rdar://problem/19255690>

Reviewed by Darin Adler.

Log using FeatureCounter when a PacheCache entry is not reused because
it expired.

* history/PageCache.cpp:
(WebCore::PageCache::take):
(WebCore::PageCache::get):
* history/PageCache.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::loadDifferentDocumentItem):
* loader/HistoryController.cpp:
(WebCore::HistoryController::invalidateCurrentItemCachedPage):
* platform/FeatureCounterKeys.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOne more URTBF after r177639 to try to make GTK happy.
ossy@webkit.org [Mon, 22 Dec 2014 20:13:02 +0000 (20:13 +0000)]
One more URTBF after r177639 to try to make GTK happy.

* UIProcess/API/gtk/WebKitUserContentManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoURTBF after r177639 to try to make GTK happy.
ossy@webkit.org [Mon, 22 Dec 2014 20:08:08 +0000 (20:08 +0000)]
URTBF after r177639 to try to make GTK happy.

* UIProcess/API/gtk/WebKitJavascriptResult.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177643 268f45cc-cd09-0410-ab3c-d52691b4dbfc