14 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 7 May 2008 00:52:56 +0000 (00:52 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Add NPN_PopUpContextMenu example.

        * NetscapeCocoaPlugin/MenuHandler.h: Added.
        * NetscapeCocoaPlugin/MenuHandler.m: Added.
        (-[MenuHandler _openURL:]):
        (-[MenuHandler _disabledItem:]):
        (-[MenuHandler validateUserInterfaceItem:]):
        (-[MenuHandler initWithBrowserFuncs:instance:]):
        (-[MenuHandler dealloc]):
        (-[MenuHandler menu]):
        * NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
        * NetscapeCocoaPlugin/main.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 7 May 2008 00:32:36 +0000 (00:32 +0000)]
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Make LocalStorage persistent using a SQLite database.

        There's a few things going on here.  Whenever an item is changed, we add it to a set of
        "items to be sync'ed."  Instead of immediately scheduling the sync'ing on the background
        thread, we set a "sync timer" instead.  This is to shield against a series of rapid changes
        to avoid thread churn.

        When the sync timer fires, we move the "items to be sync'ed" set to a background thread set
        and schedule the sync task which is where the items are actually committed to disk.

        Current design for reading items back in from disk is to be as aggressive as possible.
        When a page first accesses it's LocalStorage area, we begin to import all items in from disk so
        they are immediately available.  A future enhancement will be to being this pre-fetching the
        moment we start loading a page when we know that page has LocalStorage.

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::length): Return the length, or wait for the import to complete then return it.
        (WebCore::LocalStorageArea::key): Return the key, or wait for the import to complete then return it.
        (WebCore::LocalStorageArea::getItem): Return the item, or wait for the import to complete then return it.
        (WebCore::LocalStorageArea::setItem): Set the item, or hold the import lock and set it.  The second case is
          because if the item is set while the import is still in progress, the new value should override whatever
          the imported value is.
        (WebCore::LocalStorageArea::removeItem): Remove the item, or hold the import lock and remove it.  See the
          explanation for setItem()
        (WebCore::LocalStorageArea::contains): Return whether or not the item is contained.  Do the same dance with
          the import flag, import lock, and import condition that the above methods do.

        (WebCore::LocalStorageArea::itemChanged): Schedule the item for sync'ing
        (WebCore::LocalStorageArea::itemRemoved): Schedule the removal of the item for sync'ing
        (WebCore::LocalStorageArea::areaCleared): Schedule the clear for sync'ing, and clear all previously
          scheduled items.

        (WebCore::LocalStorageArea::scheduleItemForSync): Add an item to the sync set.
        (WebCore::LocalStorageArea::scheduleClear): Set a bool flag denoting "All items removed."  If any
          items are later set before the actual removal takes place, they will be written *after* the removal.
        (WebCore::LocalStorageArea::syncTimerFired): Move the current sync-set to the background thread sync set, then
          schedule a sync task.  Also transfer the "items cleared" flag to the "background thread items cleared" flag
        (WebCore::LocalStorageArea::performImport): Import all items from disk, then signal the import complete.
        (WebCore::LocalStorageArea::markImported): Set the imported flag and signal the import complete
        (WebCore::LocalStorageArea::performSync): If the clear flag is set then drop all items.  Then update or delete
          each item waiting to be sync'ed
        * storage/LocalStorageArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 23:42:56 +0000 (23:42 +0000)]
2008-05-06  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Mitz Pettel RTL

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::fullDatabaseFilename): Filename extensions for localstorage = all lowercase

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 23:32:49 +0000 (23:32 +0000)]
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin, Sam Weinig, and Anders

        Preparation for upcoming work making LocalStorage persistent.

        The final step before code that actually does storage and retrieval of LocalStorage items.

        The LocalStorage set is responsible for controlling the path and filenames that individual
        LocalStorageAreas will use for their persistent store.  This adds the ability to return that

        Also, add the scheduling methods that LocalStorageArea will use for importing and syncing
        it's persistent items.

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):  Add some comments re: the future direction of this
          method once we actually do quota tracking.
        * storage/LocalStorage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agordar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjob...
cfleizach@apple.com [Tue, 6 May 2008 23:27:40 +0000 (23:27 +0000)]
rdar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjobs.com)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/5455287> AXWebArea should include AXURL
cfleizach@apple.com [Tue, 6 May 2008 22:44:25 +0000 (22:44 +0000)]
<rdar://problem/5455287> AXWebArea should include AXURL

Now it does

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Tue, 6 May 2008 22:17:24 +0000 (22:17 +0000)]
2008-05-06  Alice Liu  <alice.liu@apple.com>

        Rubber-stamped by Beth

        stab-in-the-dark attempt at fixing non-mac builds.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWhoops, I did not intend to commit this right now.
andersca@apple.com [Tue, 6 May 2008 22:16:59 +0000 (22:16 +0000)]
Whoops, I did not intend to commit this right now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 22:15:52 +0000 (22:15 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Only use the toplevel application cache when loading subframes.

        * loader/MainResourceLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig@apple.com [Tue, 6 May 2008 22:00:05 +0000 (22:00 +0000)]

2008-05-06  Adam Barth  <abarth-webkit@adambarth.com>

        Reviewed by Sam Weinig.

        Implement asynchronous postMessage.
        MessageEvent no longer bubbles as per r1237 in the HTML 5 working draft.

        Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.

        Test: http/tests/security/postMessage/delivery-order.html

        * dom/MessageEvent.cpp:
        * page/DOMWindow.cpp:
        * page/DOMWindow.h:
        * page/DOMWindow.idl:


2008-05-06  Adam Barth  <abarth-webkit@adambarth.com>

        Reviewed by Sam Weinig.

        Update tests for asynchronous postMessage.

        Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.

        * http/tests/messaging/cross-domain-message-send.html:
        * http/tests/messaging/resources/cross-domain-message-receive.html:
        * http/tests/security/cross-frame-access-delete.html:
        * http/tests/security/cross-frame-access-history-put.html:
        * http/tests/security/cross-frame-access-location-put.html:
        * http/tests/security/postMessage/delivery-order-expected.txt: Added.
        * http/tests/security/postMessage/delivery-order.html: Added.
        * http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
        * http/tests/security/postMessage/invalid-origin-throws-exception.html:
        * http/tests/security/postMessage/origin-unaffected-by-base-tag-expected.txt:
        * http/tests/security/postMessage/origin-unaffected-by-base-tag.html:
        * http/tests/security/postMessage/origin-unaffected-by-document-domain-expected.txt:
        * http/tests/security/postMessage/origin-unaffected-by-document-domain.html:
        * http/tests/security/postMessage/resources/javascript-post-message-sender.html:
        * http/tests/security/postMessage/resources/post-message-listener.html:
        * http/tests/security/postMessage/resources/recv.js: Added.
        * http/tests/security/postMessage/target-origin-expected.txt:
        * http/tests/security/postMessage/target-origin.html:
        * http/tests/security/resources/cross-frame-iframe-for-delete-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-history-put-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-location-put-test.html:
        * http/tests/security/resources/xss-eval3.html:
        * http/tests/security/xss-eval.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 21:01:32 +0000 (21:01 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Store cache to the database.

        * loader/appcache/ApplicationCache.cpp:
        If the cache has been saved to disk, save the resource as well.

        * loader/appcache/ApplicationCache.h:
        New method which returns the online whitelist.

        Setter/getter for the application cache storage ID.

        * loader/appcache/ApplicationCacheGroup.cpp:
        Save the cache/group to disk.

        * loader/appcache/ApplicationCacheGroup.h:
        Setter/getter for the application cache group storage ID.

        * loader/appcache/ApplicationCacheResource.cpp:
        We can't add a new type if the resource has been saved to disk.

        * loader/appcache/ApplicationCacheResource.h:
        Setter/getter for the application cache resource storage ID.

        * loader/appcache/ApplicationCacheStorage.cpp:
        * loader/appcache/ApplicationCacheStorage.cpp:
        New method for executing SQL and logging any errors.

        Create new tables.

        New method for executing an SQL statement and logging any errors.

        New methods for storing a cache group, cache and cache resource to the store.

        New method which stores the newest cache and updates the newest cache field in the cache group.

        * loader/appcache/ApplicationCacheStorage.h:
        Add new methods.

        * platform/sql/SQLiteStatement.h:
        Getter for the SQL query.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 20:47:58 +0000 (20:47 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Initialize numArchs to 0.

        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage isNativeLibraryData:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 20:46:51 +0000 (20:46 +0000)]
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Preparation for upcoming work making LocalStorage persistent.

        Writing persistent values for LocalStorage will take place on a background thread.
        Here is that background thread, as well as most of the hooks that will be utilized to
        make the whole song and dance work.

        The thread itself is very simple and MessageQueue based.  LocalStorageTasks are what
        mark the work that needs to be done and come in 5 flavors:  Import and Sync a LocalStorage set,
        Import and Sync a LocalStorageArea, and terminate the thread.

        This patch accomplished 2 things:

        1 - Each PageGroup has its own LocalStorage set.  Upon its creation its LocalStorageThread is
            created and started.

        2 - At application shutdown, each thread is synchronously terminated.

        What happens between steps 1 and 2 will come later.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * storage/LocalStorage.cpp: Add some threading ASSERTs to make it clear which thread each
          method is meant to be called from.
        (WebCore::LocalStorage::performImport): Placeholder for importing known origins and quotas
        (WebCore::LocalStorage::performSync): Placeholder for writing out updated origins and quotas
        (WebCore::LocalStorage::close): Synchronously terminate the thread.
        * storage/LocalStorage.h:

        * storage/LocalStorageArea.cpp: Add some threading ASSERTs to make it clear which thread each
          method is meant to be called from.
        (WebCore::LocalStorageArea::performImport): Placeholder for importing all items for this
          LocalStorageArea to prime the page before the items are needed
        (WebCore::LocalStorageArea::performSync): Placeholder for writing out dirty items to disk
        * storage/LocalStorageArea.h:

        * storage/LocalStorageTask.cpp: Added.
        * storage/LocalStorageTask.h: Added.

        * storage/LocalStorageThread.cpp: Added.
        * storage/LocalStorageThread.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 20:40:45 +0000 (20:40 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add implementation of NPN_PopUpContextMenu.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView popUpContextMenu:]):
        * Plugins/WebBaseNetscapePluginViewPrivate.h:
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]):
        * Plugins/npapi.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 20:40:22 +0000 (20:40 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add NPN_PopUpContextMenu.

        * bridge/npapi.h:
        * plugins/npfunctions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 6 May 2008 20:35:53 +0000 (20:35 +0000)]
2008-05-06  Alp Toker  <alp@nuanti.com>

        GTK+ build fix. Add file from r32911 to the build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Alp.
christian@webkit.org [Tue, 6 May 2008 20:21:44 +0000 (20:21 +0000)]
     Rubber stamped by Alp.

         Back out 17626. It wasn't ready for commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Gwenole Beauchesne <gbeauchesne@splitted-desktop.org>
alp@webkit.org [Tue, 6 May 2008 20:17:12 +0000 (20:17 +0000)]
2008-05-06  Gwenole Beauchesne  <gbeauchesne@splitted-desktop.org>

        Reviewed by Alp Toker.

        [GTK] Fix varargs terminator in g_build_filename()

        * plugins/gtk/PluginDatabaseGtk.cpp:
        (WebCore::PluginDatabase::isPreferredPluginDirectory): Fix varargs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 6 May 2008 18:44:05 +0000 (18:44 +0000)]
2008-05-06  Kevin McCullough  <kmccullough@apple.com>

        - Forgot to update localized Strings from previous checkin.

        * English.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjo...
cfleizach@apple.com [Tue, 6 May 2008 18:39:48 +0000 (18:39 +0000)]
<rdar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjobs.com)
<rdar://problem/5895634> AX: AccessibilityObjectWrapper is being leaked all over the place
<rdar://problem/5893907> CrashTracer: [REGRESSION] 44 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityObject::clearChildren + 9

Initial prep work to support accessibility objects that do not have renderers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 18:16:30 +0000 (18:16 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Fix typo (don't read random memory).

        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage isNativeLibraryData:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 17:55:50 +0000 (17:55 +0000)]
2008-05-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Change the isNativeLibraryData: method to handle universal binaries.

        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage isNativeLibraryData:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Jon, Tim and Mark.
andersca@apple.com [Tue, 6 May 2008 17:54:58 +0000 (17:54 +0000)]
    Reviewed by Jon, Tim and Mark.

        Add a sample NPAPI plugin that uses the Cocoa event model.

        * .: Added.
        * ChangeLog: Added.
        * NetscapeCocoaPlugin: Added.
        * NetscapeCocoaPlugin/English.lproj: Added.
        * NetscapeCocoaPlugin/English.lproj/InfoPlist.strings: Added.
        * NetscapeCocoaPlugin/Info.plist: Added.
        * NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Added.
        * NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj: Added.
        * NetscapeCocoaPlugin/main.m: Added.
        * NetscapeCocoaPlugin/test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Rob Buis.
rwlbuis@webkit.org [Tue, 6 May 2008 17:32:54 +0000 (17:32 +0000)]
    Reviewed by Rob Buis.

        Prevented SVGRootInlineBox from static_casting a
        node to a class it doesn't inherit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
beidson@apple.com [Tue, 6 May 2008 17:28:24 +0000 (17:28 +0000)]

2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Preparation for upcoming work making LocalStorage persistent.

        When the application terminates, all pending local storage writes need to be
        sync'ed out to disk.
        This works n combination with platform specific code in WebKit that calls it.

        * WebCore.base.exp:

        * page/PageGroup.cpp:
        (WebCore::PageGroup::closeLocalStorage): Close all open LocalStorage objects
        * page/PageGroup.h:

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::close): Placeholder for what will sync and terminate the
          local storage thread in the future.
        * storage/LocalStorage.h:


2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Preparation for upcoming work making LocalStorage persistent.

        When the application terminates, all LocalStorage areas must be sync'ed out to disk first.

        * WebView/WebView.mm:
        (+[WebView _applicationWillTerminate]):  Close all LocalStorage areas before quitting.


2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Preparation for upcoming work making LocalStorage persistent.

        When the application terminates, all LocalStorage areas must be sync'ed out to disk first.

        * WebKitDLL.cpp:
        (shutDownWebKit): Close all LocalStorage areas before quitting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 17:24:44 +0000 (17:24 +0000)]
2008-05-06  Brady Eidson  <beidson@apple.com>

        Rubberstamped by David Kilzer

        * WebCore.base.exp:  Sort this mess!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 17:07:35 +0000 (17:07 +0000)]
2008-05-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        Add preference for enabling the offline web application cache.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        * WebPreferences.h:
        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLanding an updated test that was supposed to be part of r32879.
ap@webkit.org [Tue, 6 May 2008 14:21:06 +0000 (14:21 +0000)]
Landing an updated test that was supposed to be part of r32879.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-06 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Tue, 6 May 2008 13:12:42 +0000 (13:12 +0000)]
2008-05-06  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        Fix logic error in QWebHitTestResult::isNull().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix 60 crashes seen on the buildbots that were misreported as hangs.
mrowe@apple.com [Tue, 6 May 2008 05:01:24 +0000 (05:01 +0000)]
Fix 60 crashes seen on the buildbots that were misreported as hangs.

Reviewed by Dan Bernstein.

* dom/Document.cpp:
(WebCore::Document::detachNodeIterator): Null-check page() before dereferencing it.
(WebCore::Document::nodeWillBeRemoved): Ditto.
(WebCore::Document::textInserted): Ditto.
(WebCore::Document::textNodesMerged): Ditto.
(WebCore::Document::textRemoved): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 04:09:17 +0000 (04:09 +0000)]
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        The other half of the StorageMap::importItem() addition.

        * storage/StorageArea.cpp:
        * storage/StorageArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 04:03:06 +0000 (04:03 +0000)]
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        - Create the LocalStorage object for a PageGroup the moment the first Page is added to it
          The Settings of the first Page define what persistent path the LocalStorage will use
        - Add a Frame argument for the LocalStorageArea request - this will allow a client object
          to be queried before the LocalStorageArea is established

        * page/DOMWindow.cpp:

        * page/PageGroup.cpp:

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::LocalStorage): Take the path as a constructor argument.  Deep copy
          the path as it will be used from another thread.
        * storage/LocalStorage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 03:14:22 +0000 (03:14 +0000)]
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        StorageMaps normally have copy-on-write semantics to help support SessionStorage.
        For LocalStorage, we never want this behavior.  When we forcefully import items into
        a StorageMap from the LocalStorage background thread, this new import method will be used.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::importItem): Add a deep-copy of the item to the map without worrying
          about copy-on-write.
        * storage/StorageMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Copy dependencies of ImageDiff, DumpRenderTree in post-build step.
sfalken@apple.com [Tue, 6 May 2008 00:45:03 +0000 (00:45 +0000)]
    Copy dependencies of ImageDiff, DumpRenderTree in post-build step.

        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 6 May 2008 00:01:19 +0000 (00:01 +0000)]
2008-05-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Begininings of a UI for the Profiler in the WebInspector.

        * English.lproj/InspectorLocalizedStrings.js: Add new strings to be
        * page/inspector/DatabasesPanel.js: Changed the name of the Databae's
        results table to be more generic as it is now also used by the profiler.
        * page/inspector/Images/glossySelected.png: Added.
        * page/inspector/Images/profilesIcon.png: Added.
        * page/inspector/Images/treeUpTriangleBlack.png: Added.
        * page/inspector/Images/treeUpTriangleWhite.png: Added.
        * page/inspector/ProfileView.js: Added. Sets up the header of the table.
        * page/inspector/ProfilesPanel.js: Added.
        * page/inspector/ProfilesPanel.js: Added. Sets up the containers of the
        profiler's content.
        * page/inspector/inspector.css: Change database-result-table to be more
        generic as well as add the styles needed by the profiler.
        * page/inspector/inspector.html: Add profiler support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 5 May 2008 23:42:43 +0000 (23:42 +0000)]
2008-05-05  Brady Eidson  <beidson@apple.com>

        Change by Darin, reviewed by Brady

        Small efficiency improvement Darin just spotted

        * storage/StorageMap.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 5 May 2008 23:31:01 +0000 (23:31 +0000)]
2008-05-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.

        Fix https://bugs.webkit.org/show_bug.cgi?id=18899
        Bug 18899: REGRESSION (r32871): Non-Safari crash in WTF::HashTable on startup

        * loader/loader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 5 May 2008 23:04:53 +0000 (23:04 +0000)]
2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/5884383>
        Escape look-a-like characters from the the entire url.

        * Misc/WebNSURLExtras.mm:
        (-[NSURL _web_userVisibleString]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 5 May 2008 22:57:51 +0000 (22:57 +0000)]
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix a bug in StorageMap iterator tracking where the iterator was not successfully
        invalidated at an appropriate time.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setItem): ALWAYS invalidate it here

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justin.garcia@apple.com [Mon, 5 May 2008 22:50:56 +0000 (22:50 +0000)]

2008-05-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end

        Disable Range mutation on document modifications in Tiger and Leopard Mail,
        since they do their own mutation which interferes with ours.

        * WebCore.base.exp:
        * dom/Document.cpp:
        * page/Settings.cpp:
        * page/Settings.h:


2008-05-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end

        * WebView/WebView.mm:
        (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
        the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
        the two interfere.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig@apple.com [Mon, 5 May 2008 22:47:21 +0000 (22:47 +0000)]

2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * English.lproj/InspectorLocalizedStrings.js: Removed.
        * English.lproj/localizedStrings.js: Added.
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/inspector/inspector.js:


2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * WebCoreSupport/WebInspectorClient.mm:


2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * WebCoreSupport/WebInspectorClient.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Mon, 5 May 2008 20:51:32 +0000 (20:51 +0000)]
2008-05-05  Steve Falkenburg  <sfalken@apple.com>

        Add WebPreference for application chrome mode.

        Reviewed by Dave Hyatt.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        * WebPreferences.h:
        * WebView.cpp:

2008-05-05  Steve Falkenburg  <sfalken@apple.com>

        Add support for default button appearance.
        Add WebCore setting for app chrome mode.

        Reviewed by Dave Hyatt.

        * css/CSSPrimitiveValueMappings.h:
        * css/CSSValueKeywords.in: Added default-button value keyword.
        * page/Settings.cpp:
        * page/Settings.h:
        * rendering/RenderButton.cpp:
        * rendering/RenderButton.h:
        * rendering/RenderStyle.h:
        * rendering/RenderTheme.cpp:
        * rendering/RenderTheme.h:
        * rendering/RenderThemeSafari.cpp:
        * rendering/RenderThemeWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Adele Peterson <adele@apple.com>
adele@apple.com [Mon, 5 May 2008 20:35:15 +0000 (20:35 +0000)]
2008-05-05  Adele Peterson  <adele@apple.com>

        Reviewed by Adam.

        Look for the right ImageDiff executable for debug builds.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Mon, 5 May 2008 18:29:09 +0000 (18:29 +0000)]
    Reviewed by Darin.

        nbsps should be converted to entities in innerHTML

        replacing &nbsp; with spaces using regexp creates inconsistent result

        Tests: fast/dom/innerHTML-nbsp.html

        * editing/markup.cpp:
        Added U+00a0/nbsp to the list of characters to escape.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
hyatt@apple.com [Mon, 5 May 2008 18:26:17 +0000 (18:26 +0000)]

2008-05-05  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18821.  Fix some bugs in both get/PutImageData of <canvas>.

        Reviewed by Eric

        New tests added in fast/canvas/

        * platform/graphics/cg/ImageBufferCG.cpp:


2008-05-05  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18821, putImageData incorrect when data has alpha.

        Reviewed by Eric

        * fast/canvas/canvas-alphaImageData-behavior-expected.txt: Added.
        * fast/canvas/canvas-alphaImageData-behavior.html: Added.
        * fast/canvas/canvas-alphaImageData-behavior.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 May 2008 16:59:05 +0000 (16:59 +0000)]
2008-05-05  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - fix debug-only leak seen on buildbot

        * wtf/HashTable.h:
        (WTF::HashTable::checkKey): After writing an empty value in, but before constructing a
        deleted value on top of it, call the destructor so the empty value doesn't leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 5 May 2008 16:47:21 +0000 (16:47 +0000)]
2008-05-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jess.

        Apparently preflighting can cause hangs for some reason. Revert this for now.

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _initWithPath:]):
        * Plugins/WebPluginPackage.m:
        (-[WebPluginPackage initWithPath:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 May 2008 16:44:16 +0000 (16:44 +0000)]
2008-05-05  Darin Adler  <darin@apple.com>

        * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
        leak tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 May 2008 16:34:03 +0000 (16:34 +0000)]
2008-05-05  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - https://bugs.webkit.org/show_bug.cgi?id=18789
          fix some shouldCloseWithWindow edge cases

        * WebView/WebView.mm:
        (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
        NSWindowWillCloseNotification if the view was moved out of the window but still
        had that window set as the host window. Also make sure this function doesn't do
        anything if the WebView is already closed.
        (-[WebView setHostWindow:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Adam Roben.
mitz@apple.com [Mon, 5 May 2008 16:31:24 +0000 (16:31 +0000)]
    Rubber-stamped by Adam Roben.

        - fix test failure due to Windows' preference for Mac results over
          generic results

        * platform/win/editing/selection/move-left-right-expected.txt: Copied from LayoutTests/editing/selection/move-left-right-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Mon, 5 May 2008 16:27:51 +0000 (16:27 +0000)]

        Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18809
          Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)

        Test: fast/block/basic/adding-near-anonymous-block.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addChildToFlow): When adding a floating or
        positioned object, if it follows an anonymous block, put it
        inside the anonymous block. When adding an inline, check if it comes
        after an anonymous block and put it in the anonymous block.


        Reviewed by Dave Hyatt.

        - test, updated test and updated results for https://bugs.webkit.org/show_bug.cgi?id=18809
          Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)

        * fast/block/basic/adding-near-anonymous-block.html: Added.
        * media/video-controls-rendering.html: Changed to work around
        https://bugs.webkit.org/show_bug.cgi?id=18857 which now affects this
        test in its original form.
        * platform/mac/css1/box_properties/clear-expected.txt:
        * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.checksum: Added.
        * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.png: Added.
        * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.txt: Added.
        * platform/mac/fast/forms/input-align-image-expected.txt:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/video-controls-rendering-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug51140-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 5 May 2008 16:09:00 +0000 (16:09 +0000)]
2008-05-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin.

        Speculative fix for <rdar://problem/5906790>
        Crash in Loader::servePendingRequests() due to hash table being modified during iteration

        I don't know how to reproduce this. It would require the load to fail (or succeed)
        synchronously, something that should not usually happen.

        * loader/loader.cpp:
        * loader/loader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Mon, 5 May 2008 10:26:33 +0000 (10:26 +0000)]
Ariya Hidayat  <ariya.hidayat@trolltech.com>

In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG
tests expect to be 480x360)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Mon, 5 May 2008 09:59:34 +0000 (09:59 +0000)]
Ariya Hidayat  <ariya.hidayat@trolltech.com>

Disable SVG As Image support in the Qt port again, as it
requires more work. Right now the chrome client is
assumed to be a ChromeClientQt, which the SVG Image support

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 5 May 2008 05:30:44 +0000 (05:30 +0000)]
Reviewed by Kevin Ollivier.

Allow events to specify the ID of the particular wxWebView they are to be sent to.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-02 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 5 May 2008 04:46:26 +0000 (04:46 +0000)]
2008-05-02  Antti Koivisto  <antti@apple.com>

        Reviewed by Mitz.

        Test for <rdar://problem/5840475>
        CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::RenderBlock::insertPositionedObject

        * fast/transforms/container-transform-crash-expected.txt: Added.
        * fast/transforms/container-transform-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-02 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 5 May 2008 04:44:54 +0000 (04:44 +0000)]
2008-05-02  Antti Koivisto  <antti@apple.com>

        Reviewed by Mitz.

        Fix <rdar://problem/5840475>
        CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::RenderBlock::insertPositionedObject

        Non-block objects can have transforms so containingBlock() could end up returning null.
        RenderObject::container() needs to match.

        Test: fast/transforms/container-transform-crash.html

        * rendering/RenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 5 May 2008 01:48:09 +0000 (01:48 +0000)]
2008-05-04  Sam Weinig  <sam@webkit.org>

        Roll out r32851.  It broke tiger builds.

        * bindings/objc/DOMUtility.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Sun, 4 May 2008 22:03:42 +0000 (22:03 +0000)]

        Reviewed by Sam Weinig.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18879
          <rdar://problem/5909481> Reproducible crash when removing a gradient

        Test: fast/gradients/crash-on-remove.html

        * css/CSSImageGeneratorValue.cpp:
        (WebCore::CSSImageGeneratorValue::addClient): Added a call to ref() the
        (WebCore::CSSImageGeneratorValue::removeClient): Added code to deref()
        the value.


        Reviewed by Sam Weinig.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18879
          <rdar://problem/5909481> Reproducible crash when removing a gradient

        * fast/gradients/crash-on-remove-expected.txt: Added.
        * fast/gradients/crash-on-remove.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 21:52:43 +0000 (21:52 +0000)]
2008-05-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Don't print out the full url.

        * fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
        * fast/dom/Window/dom-access-from-closure-window-expected.txt:
        * fast/dom/Window/resources/dom-access-from-closure-iframe-child.html:
        * fast/dom/Window/resources/dom-access-from-closure-window-child.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make parameters match for WebChromeClient::addMessageToConsole()
ddkilzer@apple.com [Sun, 4 May 2008 21:52:21 +0000 (21:52 +0000)]
    Make parameters match for WebChromeClient::addMessageToConsole()

        Reviewed by John.

        * WebCoreSupport/WebChromeClient.h:
        (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
        to sourceURL to match implementation in WebChromeClient.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 21:29:03 +0000 (21:29 +0000)]
2008-05-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Move createDOMWrapper(JSObject* object) out of the KJS namespace and into
        the WebCore namespace now that the required compilers don't freak out about
        this anymore.

        * bindings/objc/DOMUtility.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
rwlbuis@webkit.org [Sun, 4 May 2008 06:36:19 +0000 (06:36 +0000)]
    Reviewed by Sam.

        onchange events don't seem to fire for input[type=range] controls.

        Fire changeEvent when clicking the slider outside the current
        thumb position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 01:04:29 +0000 (01:04 +0000)]
2008-05-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove unused enums from JSDOMWindowBase.

        * bindings/js/JSDOMWindowBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 00:59:14 +0000 (00:59 +0000)]
2008-05-03  Sam Weinig  <sam@webkit.org>

        Real build fix.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 00:48:40 +0000 (00:48 +0000)]
2008-05-03  Sam Weinig  <sam@webkit.org>

        Build fix.

        * bindings/js/kjs_events.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 00:36:06 +0000 (00:36 +0000)]
2008-05-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Add tests that show our behavior when using closures from a global object
        whose frame has been navigated.

        Related to https://bugs.webkit.org/show_bug.cgi?id=17249.

        * fast/dom/Window/closure-access-after-navigation-iframe-expected.txt: Added.
        * fast/dom/Window/closure-access-after-navigation-iframe.html: Added.
        * fast/dom/Window/closure-access-after-navigation-window-expected.txt: Added.
        * fast/dom/Window/closure-access-after-navigation-window.html: Added.
        * fast/dom/Window/dom-access-from-closure-iframe-expected.txt: Added.
        * fast/dom/Window/dom-access-from-closure-iframe.html: Added.
        * fast/dom/Window/dom-access-from-closure-window-expected.txt: Added.
        * fast/dom/Window/dom-access-from-closure-window.html: Added.
        * fast/dom/Window/resources/closure-access-after-navigation-iframe-child-1.html: Added.
        * fast/dom/Window/resources/closure-access-after-navigation-iframe-child-2.html: Added.
        * fast/dom/Window/resources/closure-access-after-navigation-window-child-1.html: Added.
        * fast/dom/Window/resources/closure-access-after-navigation-window-child-2.html: Added.
        * fast/dom/Window/resources/dom-access-from-closure-iframe-child.html: Added.
        * fast/dom/Window/resources/dom-access-from-closure-window-child.html: Added.
        * fast/dom/Window/resources/notify-opener-done.html: Added.
        * fast/dom/Window/resources/notify-parent-done.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 00:02:10 +0000 (00:02 +0000)]
2008-05-03  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Geoffrey Garen.

        Rename JSDOMWindowWrapper to JSDOMWindowShell.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
rwlbuis@webkit.org [Sat, 3 May 2008 06:44:58 +0000 (06:44 +0000)]
    Reviewed by Eric.

        background: currentColor fails

        Implement currentColor from CSS3 color module.

        Tests: fast/css/background-currentcolor.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca@apple.com [Sat, 3 May 2008 00:44:21 +0000 (00:44 +0000)]

2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Turns out calling locationInWindow on keyboard events will not throw an exception,
        but the point returned is completely bogus, so remove coordinates from the keyboard event struct.

        * bridge/npapi.h:


2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Various Cocoa event model and 64-bit plug-in fixes.

        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        Set click count.

        Don't try to get the mouse location for keyboard events.

        * Plugins/WebPluginPackage.m:
        (-[WebPluginPackage initWithPath:]):
        Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 3 May 2008 00:21:05 +0000 (00:21 +0000)]
2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Add an "x86_64" make rule.

        * Makefile.shared:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-02 Benjamin Otte <otte@gnome.org>
alp@webkit.org [Fri, 2 May 2008 23:10:41 +0000 (23:10 +0000)]
2008-05-02  Benjamin Otte  <otte@gnome.org>

        Reviewed by Alp Toker.

        [GTK] variable initialization missing

        Not initializing the m_needsXEmbed variable could have very funny
        results. Most often those results would be crashes.

        * plugins/PluginView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-02 Jan Michael Alonzo <jmalonzo@unpluggable.com>
alp@webkit.org [Fri, 2 May 2008 22:21:09 +0000 (22:21 +0000)]
2008-05-02  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Eric.

        Enable dashboard and offline web apps in autotools

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoffrey Garen.
ap@webkit.org [Fri, 2 May 2008 20:05:47 +0000 (20:05 +0000)]
    Reviewed by Geoffrey Garen.

        Get rid of static data in nodes.cpp (well, at least of non-debug one).

        No measurable change on SunSpider.

        * kjs/InitializeThreading.cpp:
        * kjs/nodes.cpp:
        * kjs/nodes.h:
        Made newTrackedObjects and trackedObjectExtraRefCounts per-thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca@apple.com [Fri, 2 May 2008 19:23:50 +0000 (19:23 +0000)]

2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Name the event union so it will work in plain C.

        * bridge/npapi.h:


2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        The event union is now named.

        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 2 May 2008 18:15:53 +0000 (18:15 +0000)]
2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.

        Call preflightAndReturnError on the bundle, which will check if any of the architectures
        in the bundle match the current architecture.

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _initWithPath:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Fri, 2 May 2008 18:10:33 +0000 (18:10 +0000)]
    Reviewed by Darin.

        Move call stack depth counter to global object.

        * kjs/ExecState.h: (KJS::ExecState::functionCallDepth): Added a recursion depth counter to
        per-thread data.
        * kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init): Initialize PerThreadData.functionCallDepth.
        * kjs/JSGlobalObject.h: (KJS::JSGlobalObject::perThreadData): Made the result non-const.

        * kjs/object.cpp:
        (KJS::throwStackSizeExceededError): Moved throwError to a separate function, since it is now
        the only thing in JSObject::call that needs a PIC branch.
        (KJS::JSObject::call): Use a per-thread variable instead of local static for recursion depth

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
mitz@apple.com [Fri, 2 May 2008 17:53:59 +0000 (17:53 +0000)]
    Reviewed by Adam Roben.

        - add an option to svn-apply to set the reviewer name in change logs

        * Scripts/svn-apply: Added a [-r|--reviewer name] option.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Fri, 2 May 2008 16:15:25 +0000 (16:15 +0000)]

        Reviewed by John Sullivan.

        - render text shadows with zero offset, as the shadow can be seen behind
          the text if the text is translucent

        Test: fast/text/shadow-no-blur.html

        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawComplexText): Removed the isEmpty() condition on the
        shadow offset. Since isEmpty() is also true for sizes that have one or
        more non-positive components, this also ensures that subpixel
        antialiasing of the text is maintained with shadows in all directions.
        (WebCore::Font::drawGlyphs): Ditto.
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): Ditto.


        Reviewed by John Sullivan.

        - add pixel test for text shadows with zero blur and various offsets,
          including zero offset

        * fast/text/shadow-no-blur.html: Added.
        * platform/mac/fast/text/shadow-no-blur-expected.checksum: Added.
        * platform/mac/fast/text/shadow-no-blur-expected.png: Added.
        * platform/mac/fast/text/shadow-no-blur-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-02 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Fri, 2 May 2008 14:48:36 +0000 (14:48 +0000)]
2008-05-02  Tor Arne Vestbø  <tavestbo@trolltech.com>

Updated Qt layout-tests to match changes in font metrics.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 2 May 2008 14:09:47 +0000 (14:09 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Build the Qt port with SVG Use and As Image support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 2 May 2008 13:40:34 +0000 (13:40 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Fixed potential crash on SVG animation (added more checks to the assert).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Fri, 2 May 2008 13:21:36 +0000 (13:21 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Doc: Mention that you have to enable plugins in QWebSettings for them to work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by John Sullivan.
ap@webkit.org [Fri, 2 May 2008 13:07:43 +0000 (13:07 +0000)]
    Rubber-stamped by John Sullivan.

        Fix a debug-only crash in layout tests.

        * loader/CachedResource.cpp:
        (WebCore::CachedResource::~CachedResource): Don't call resourceForURL() for null URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the Qt build on Windows when Phonon is enabled for Audio/Video support
hausmann@webkit.org [Fri, 2 May 2008 12:07:18 +0000 (12:07 +0000)]
Fix the Qt build on Windows when Phonon is enabled for Audio/Video support

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the Qt build, add ExecState where required.
hausmann@webkit.org [Fri, 2 May 2008 11:04:26 +0000 (11:04 +0000)]
Fix the Qt build, add ExecState where required.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the Qt/Win build.
hausmann@webkit.org [Fri, 2 May 2008 10:32:49 +0000 (10:32 +0000)]
Fix the Qt/Win build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Fri, 2 May 2008 10:29:47 +0000 (10:29 +0000)]
    Reviewed by Darin.

        Make JavaScriptGlue and JavaScriptCore API functions implicitly call initializeThreading
        for the sake of non-WebKit clients.

        * API/JSBase.cpp:
        * API/JSContextRef.cpp:
        These are the JavaScriptCore API bottlenecks. There are a few other JSStringRef
        and JSClassRef functions that can be called earlier, but they do not do anything that
        requires initializeThreading.

        * kjs/InitializeThreading.cpp:
        On Darwin, make the initialization happen under pthread_once, since there is no guarantee
        that non-WebKit clients won't try to call this function re-entrantly.

        * kjs/InitializeThreading.h:
        * wtf/Threading.h:
        Spell out initializeThreading contract.

        * wtf/ThreadingPthreads.cpp: (WTF::isMainThread): Make sure that results are correct on
        Darwin, even if threading was initialized from a secondary thread.

        * JavaScriptGlue.cpp:
        These are all possible JavaScriptGlue entry points.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoffrey Garen.
ap@webkit.org [Fri, 2 May 2008 10:07:53 +0000 (10:07 +0000)]
    Reviewed by Geoffrey Garen.

        Make JavaScript heap per-thread

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-02 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 2 May 2008 09:55:43 +0000 (09:55 +0000)]
2008-05-02  Ariya Hidayat  <ariya.hidayat@trolltech.com>

Reviewed by Simon.

Build the Qt port with SVG Animation support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej Stachowiak.
mitz@apple.com [Fri, 2 May 2008 07:55:04 +0000 (07:55 +0000)]
    Reviewed by Maciej Stachowiak.

        - Mac build fix

        * wtf/StrHash.h: Added header guards and removed #include "config.h".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix for Qt/Gtk. Don't declare NP_InitializeFuncPtr twice
hausmann@webkit.org [Fri, 2 May 2008 07:39:35 +0000 (07:39 +0000)]
Build fix for Qt/Gtk. Don't declare NP_InitializeFuncPtr twice
with different signatures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Fri, 2 May 2008 06:37:23 +0000 (06:37 +0000)]
Reviewed by Kevin Ollivier.

Explicitly set the pen style in wx port to keep pen style changes from affecting URL underline or text field drawing.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Fri, 2 May 2008 06:24:18 +0000 (06:24 +0000)]
Reviewed by Kevin Ollivier.

Implement popup menu support for wx port.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago #include <wtf/StrHash.h> in identifier.cpp.
adachan@apple.com [Fri, 2 May 2008 05:48:24 +0000 (05:48 +0000)]
    #include <wtf/StrHash.h> in identifier.cpp.

        Reviewed by Maciej.

        * kjs/identifier.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Eric Seidel.
kevino@webkit.org [Fri, 2 May 2008 05:16:42 +0000 (05:16 +0000)]
Reviewed by Eric Seidel.

Make sure we properly set the button for all mouse events, not just mouse down, set the click count to 0 for non-click events, and finally set the timestamp.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 2 May 2008 03:00:36 +0000 (03:00 +0000)]
2008-05-01  Sam Weinig  <sam@webkit.org>

        Add missing result.

        * fast/canvas/canvas-path-with-inf-nan-dimensions-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 2 May 2008 02:34:52 +0000 (02:34 +0000)]
2008-05-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe (in his infinite wisdom).

        Auto-generate the JSXSLTProcessor binding.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSXSLTProcessor.cpp: Removed.
        * bindings/js/JSXSLTProcessor.h: Removed.
        * xml/XSLTProcessor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig@apple.com [Fri, 2 May 2008 02:08:43 +0000 (02:08 +0000)]

2008-05-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

          - https://bugs.webkit.org/show_bug.cgi?id=17249
            Incorrect lexical scope after navigation leads to UXSS

          - https://bugs.webkit.org/show_bug.cgi?id=16824
            Script authorization should follow lexical (not dynamic) scope

        This patch changes us to perform same-origin checks based on the lexical global object)
        rather than dynamic global object, which is now possible we don't re-use the window on
        navigations, but rather switch in a new one and re-use the outer shell.  This is both
        more secure and conforms with the HTML5 specification.  Now that all the checks are
        done based on the lexical global object, we can remove the SecurityOrigin::Reason
        concept, as it was only around to work around an ebay.com bug that required the check to
        be done that way.

        An important thing to note is that we currently implement a stricter than necessary policy
        and perform the same-origin check based on the currently active global object to avoid leaking
        the document in cases when the target frame is navigated before access.  This will be fixed in
        an upcoming patch.

        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/JSDOMWindowBase.h:
        * html/CanvasRenderingContext2D.cpp:
        * loader/FrameLoader.cpp:
        * page/DOMWindow.h:
        * platform/SecurityOrigin.cpp:
        * platform/SecurityOrigin.h:


2008-05-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        * http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
        * http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
        * http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
        * http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
        * http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
        * http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
        * http/tests/security/xss-eval-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca@apple.com [Fri, 2 May 2008 01:34:28 +0000 (01:34 +0000)]

2008-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Enable 64-bit NPAPI plugins.

        * WebCore.xcodeproj/project.pbxproj:
        Don't remove NPAPI related symbols from the 64-bit .exp file.

        * bridge/npruntime.h:
        Remove now unnecessary #error.


2008-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        64-bit NPAPI plugin build fixes.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView updateAndSetWindow]):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView windowBecameKey:]):
        * Plugins/WebNetscapeDeprecatedFunctions.c:
        * Plugins/WebNetscapeDeprecatedFunctions.h:
        * Plugins/WebNetscapePluginEventHandler.mm:
        * Plugins/WebNetscapePluginEventHandlerCarbon.h:
        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32790 268f45cc-cd09-0410-ab3c-d52691b4dbfc