WebKit-https.git
12 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 1 Dec 2009 23:35:08 +0000 (23:35 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=32036
        Implement CredentialStorage::getFromPersistentStorage for CFNetwork

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Simplify zoom-related APIs and add a zoom level getter,
pkasting@chromium.org [Tue, 1 Dec 2009 23:34:28 +0000 (23:34 +0000)]
[Chromium] Simplify zoom-related APIs and add a zoom level getter,
part one: Add new APIs.  (Old APIs will be removed in a second pass.)
https://bugs.webkit.org/show_bug.cgi?id=31893

Reviewed by Darin Fisher.

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Daniel Bates <dbates@webkit.org>
eric@webkit.org [Tue, 1 Dec 2009 22:12:00 +0000 (22:12 +0000)]
2009-12-01  Daniel Bates  <dbates@webkit.org>

        Reviewed by Pavel Feldman.

        https://bugs.webkit.org/show_bug.cgi?id=32001

        Updated layout test to reflect change to localized string and
        rebased the result.

        * inspector/elements-img-tooltip-expected.txt:
        * inspector/elements-img-tooltip.html:
2009-12-01  Daniel Bates  <dbates@webkit.org>

        Reviewed by Pavel Feldman.

        https://bugs.webkit.org/show_bug.cgi?id=32001

        Added missing localized strings (that I left out of the patch for bug #21554):
        %d × %d pixels
        %d × %d pixels (Natural: %d × %d pixels)

        Also, changed formatting of these stings to conform with existing ones (added
        a space on both sides of the multiply sign).

        * English.lproj/localizedStrings.js: Added stings.
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Daniel Bates <dbates@webkit.org>
eric@webkit.org [Tue, 1 Dec 2009 22:05:02 +0000 (22:05 +0000)]
2009-12-01  Daniel Bates  <dbates@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        https://bugs.webkit.org/show_bug.cgi?id=31898

        Makes QtLauncher default to the http scheme for URLs.

        * QtLauncher/main.cpp:
        (MainWindow::MainWindow):
        (MainWindow::changeLocation):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSkip a test that fails with some versions of CFNetwork on Windows
aroben@apple.com [Tue, 1 Dec 2009 21:33:04 +0000 (21:33 +0000)]
Skip a test that fails with some versions of CFNetwork on Windows

Rubber-stamped by Brady Eidson.

* platform/win/Skipped: Skip http/tests/plugins/post-url-file.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix for bug 32032, empty namespaces should be allowed in @namespace directives in...
hyatt@apple.com [Tue, 1 Dec 2009 21:32:07 +0000 (21:32 +0000)]
Fix for bug 32032, empty namespaces should be allowed in @namespace directives in CSS.

Reviewed by Simon Fraser.

Added fast/css/namespaces/namespaces-empty.xml

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addNamespace):
(WebCore::CSSStyleSheet::determineNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRevert 51551 because it broke GTK+.
kov@webkit.org [Tue, 1 Dec 2009 21:17:06 +0000 (21:17 +0000)]
Revert 51551 because it broke GTK+.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove user content before running each test on Windows
aroben@apple.com [Tue, 1 Dec 2009 20:59:15 +0000 (20:59 +0000)]
Remove user content before running each test on Windows

Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows

Reviewed by Alexey Proskuryakov.

* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting): Remove all user content
before each test, which matches Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Tue, 1 Dec 2009 20:08:18 +0000 (20:08 +0000)]
2009-12-01  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Escape key in the Search Field should be more User Friendly
        https://bugs.webkit.org/show_bug.cgi?id=32005

        * inspector/front-end/inspector.js:
        (WebInspector.loaded): add mousedown listener on the search field
        (WebInspector.searchFieldManualFocus): user clicked to focus on the search field
        (WebInspector.searchKeyDown): handle escape

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Enabling WebSocket tests on Windows again - let's see what errors get logged.
ap@apple.com [Tue, 1 Dec 2009 19:08:20 +0000 (19:08 +0000)]
    Enabling WebSocket tests on Windows again - let's see what errors get logged.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Tue, 1 Dec 2009 19:01:07 +0000 (19:01 +0000)]
2009-12-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        PLATFORM(CAIRO) should be defined by WIN_CAIRO define
        https://bugs.webkit.org/show_bug.cgi?id=22250

        * wtf/Platform.h: Remove WTF_PLATFORM_CAIRO as it is
        already define in config.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Yuzo Fujishima <yuzo@google.com>
ap@apple.com [Tue, 1 Dec 2009 18:56:09 +0000 (18:56 +0000)]
2009-12-01  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Alexey Proskuryakov.

        Make pywebsocket log errors to a file
        https://bugs.webkit.org/show_bug.cgi?id=31604

        * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
        (by passing the path to the server via a recently added -l option).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago@namespace directives need to use "maybe_space" in the "maybe_ns_prefix" portion...
hyatt@apple.com [Tue, 1 Dec 2009 18:55:09 +0000 (18:55 +0000)]
@namespace directives need to use "maybe_space" in the "maybe_ns_prefix" portion of the grammar to match
the spec.  Not doing so prevent comments from being used immmediately after the namespace prefix.

Reviewed by David Kilzer.

Added fast/css/namespaces-comments.xml

* css/CSSGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Xiyuan Xia <xiyuan@chromium.org>
eric@webkit.org [Tue, 1 Dec 2009 18:41:36 +0000 (18:41 +0000)]
2009-12-01  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Darin Fisher.

        Only fire start/stop events when main frame is not loading.

        https://bugs.webkit.org/show_bug.cgi?id=31838

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a timing-out test to the Skipped file on Windows
aroben@apple.com [Tue, 1 Dec 2009 18:38:42 +0000 (18:38 +0000)]
Add a timing-out test to the Skipped file on Windows

Rubber-stamped by Ada Chan.

* platform/win/Skipped: Added
fast/dom/Window/window-postmessage-clone.html, which was timing out
due to eventSender.beginDragFiles being unimplemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix tests that use the TestNetscapePlugin in Debug_Internal builds
aroben@apple.com [Tue, 1 Dec 2009 18:35:29 +0000 (18:35 +0000)]
Fix tests that use the TestNetscapePlugin in Debug_Internal builds

Reviewed by Ada Chan.

Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
TestNetscapePlugin fail in Debug_Internal builds

* DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
directory in Debug and Debug_All builds, but not in Debug_Internal
builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRe-enable DRT's watchdog timer on Windows
aroben@apple.com [Tue, 1 Dec 2009 18:01:24 +0000 (18:01 +0000)]
Re-enable DRT's watchdog timer on Windows

It was accidentally disabled in r50907.

* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
into an if condition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Tue, 1 Dec 2009 17:24:08 +0000 (17:24 +0000)]
2009-12-01  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Timothy Hatcher.

        Reloading WebInspector from context menu is closing it instead of reloading.
        https://bugs.webkit.org/show_bug.cgi?id=32004

        When reloading WebInspector, don't delete its m_page.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd expected Windows failure results for tests that use textInputController
aroben@apple.com [Tue, 1 Dec 2009 17:20:05 +0000 (17:20 +0000)]
Add expected Windows failure results for tests that use textInputController

<http://webkit.org/b/32021> covers fixing these tests.

Rubber-stamped by Sam Weinig.

* platform/win/Skipped: Removed tests that use textInputController.

* platform/win/editing/selection/5825350-1-expected.txt: Added.
* platform/win/editing/selection/5825350-2-expected.txt: Added.
* platform/win/editing/selection/mixed-editability-10-expected.txt: Added.
* platform/win/fast/events/ime-composition-events-001-expected.txt: Added.
* platform/win/fast/forms/input-maxlength-ime-completed-expected.txt: Added.
* platform/win/fast/forms/input-maxlength-ime-preedit-expected.txt: Added.
* platform/win/fast/text/international/thai-cursor-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInsp...
ossy@webkit.org [Tue, 1 Dec 2009 16:51:43 +0000 (16:51 +0000)]
[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector().

* platform/qt/Skipped: inspector/timeline-network-resource.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 1 Dec 2009 16:46:48 +0000 (16:46 +0000)]
2009-12-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        check-webkit-style complains about #imports with / in them
        https://bugs.webkit.org/show_bug.cgi?id=32022

        We need to exclude #import directives in addition to #include from the
        binary operator whitespace checks.

        * Scripts/modules/cpp_style.py:
        * Scripts/modules/cpp_style_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Steve Block <steveblock@google.com>
eric@webkit.org [Tue, 1 Dec 2009 16:46:38 +0000 (16:46 +0000)]
2009-12-01  Steve Block  <steveblock@google.com>

        Reviewed by Dimitri Glazkov.

        Adds V8 bindings for Geolocation.
        https://bugs.webkit.org/show_bug.cgi?id=30206

        Also adds Geolocation files to Chrome build files.

        * WebCore.gyp/WebCore.gyp: Modified. Corrects list of Geolocation IDL files.
        * WebCore.gypi: Modified. Adds Geolocation files.
        * bindings/v8/DOMObjectsInclude.h: Modified. Adds Geolocation includes.
        * bindings/v8/DerivedSourcesAllInOne.cpp: Modified. Adds Geolocation files.
        * bindings/v8/V8Index.cpp: Modified. Includes Geolocation generated headers.
        * bindings/v8/V8Index.h: Modified. Adds Geolocation types to DOM_OBJECT_TYPES.
        * bindings/v8/custom/V8CoordinatesCustom.cpp: Added. Handles optional properties.
        * bindings/v8/custom/V8CustomBinding.h: Modified. Declares callbacks and getters.
        * bindings/v8/custom/V8CustomPositionCallback.cpp: Added.
        (WebCore::V8CustomPositionCallback::V8CustomPositionCallback): Added. Constructor.
        (WebCore::V8CustomPositionCallback::~V8CustomPositionCallback): Added. Destructor.
        (WebCore::V8CustomPositionCallback::handleEvent): Added. Invokes callback.
        * bindings/v8/custom/V8CustomPositionCallback.h: Added.
        (WebCore::V8CustomPositionCallback::create): Added. Factory method.
        * bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Added.
        (WebCore::V8CustomPositionErrorCallback::V8CustomPositionErrorCallback): Added. Constructor.
        (WebCore::V8CustomPositionErrorCallback::~V8CustomPositionErrorCallback): Added. Destructor.
        (WebCore::V8CustomPositionErrorCallback::handleEvent): Added. Invokes callback.
        * bindings/v8/custom/V8CustomPositionErrorCallback.h: Added.
        (WebCore::V8CustomPositionErrorCallback::create): Added. Factory method.
        * bindings/v8/custom/V8GeolocationCustom.cpp: Added.
        (WebCore::throwTypeMismatchException): Added. Throws a type mismatch error.
        (WebCore::createPositionCallback): Added. Handles type checking for successCallback argument.
        (WebCore::createPositionErrorCallback): Added. Handles type checking for errorCallback argument.
        (WebCore::createPositionOptions): Added. Handles type checking for positionOptions argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Eric Z. Ayers <zundel@google.com>
eric@webkit.org [Tue, 1 Dec 2009 16:19:23 +0000 (16:19 +0000)]
2009-12-01  Eric Z. Ayers  <zundel@google.com>

        Reviewed by Pavel Feldman.

        Adds test for Timeline network resource records.

        https://bugs.webkit.org/show_bug.cgi?id=31378

        * inspector/timeline-network-resource-expected.txt: Added.
        * inspector/timeline-network-resource.html: Added.
        * inspector/timeline-network-resource.js: Added.
        * inspector/timeline-test.js:
        (printTimelineRecords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 1 Dec 2009 16:17:42 +0000 (16:17 +0000)]
2009-12-01  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        Provide a way to get ScriptState for the inspected page.

        https://bugs.webkit.org/show_bug.cgi?id=32020

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::mainWorldScriptState):
        * bindings/v8/ScriptController.h:
        * bindings/v8/ScriptState.cpp:
        (WebCore::scriptStateFromPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Changed mallocs to fastMallocs and frees to fastFrees in GraphicsContext3D...
cmarrin@apple.com [Tue, 1 Dec 2009 16:09:27 +0000 (16:09 +0000)]
    Changed mallocs to fastMallocs and frees to fastFrees in GraphicsContext3D. Also added error returns
        https://bugs.webkit.org/show_bug.cgi?id=30778

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Mads Ager <ager@chromium.org>
eric@webkit.org [Tue, 1 Dec 2009 15:45:23 +0000 (15:45 +0000)]
2009-12-01  Mads Ager  <ager@chromium.org>

        Reviewed by Eric Seidel.

        [V8] Don't crash in DOMWindow event getter in OOM situations
        https://bugs.webkit.org/show_bug.cgi?id=32017

        Add missing null handle checks in DOMWindow event property
        accessors.  V8Proxy::context(frame) can return a null handle in
        OOM situations either if failing to initialize a context or if an
        OOM is handled gracefully and javascript is disabled.

        No new tests because we don't have a good way to test
        out-of-memory bugs.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Updated HTMLCanvasElement to accept "experimental-webgl" as the context name.
cmarrin@apple.com [Tue, 1 Dec 2009 14:44:59 +0000 (14:44 +0000)]
    Updated HTMLCanvasElement to accept "experimental-webgl" as the context name.
        https://bugs.webkit.org/show_bug.cgi?id=31672

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
pfeldman@chromium.org [Tue, 1 Dec 2009 14:22:41 +0000 (14:22 +0000)]
2009-12-01  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

        Not reviewed: chromium build fix, added missing import.

        * inspector/InspectorFrontendHost.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Put tests into skiplist because of missing textInputController.selectedRange().
ossy@webkit.org [Tue, 1 Dec 2009 11:26:13 +0000 (11:26 +0000)]
[Qt] Put tests into skiplist because of missing textInputController.selectedRange().

* platform/qt/Skipped:
- editing/selection/mixed-editability-10.html added.
- editing/selection/5825350-1.html added.
- editing/selection/5825350-2.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 1 Dec 2009 09:45:56 +0000 (09:45 +0000)]
2009-12-01  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: fix windows build via unexcluding generated files from
        project.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoStop copying IDL files in to the WebCore framework wrapper.
mrowe@apple.com [Tue, 1 Dec 2009 09:33:25 +0000 (09:33 +0000)]
Stop copying IDL files in to the WebCore framework wrapper.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Tiger build by making the Xcode project compatible with Xcode 2.4.
mrowe@apple.com [Tue, 1 Dec 2009 09:28:55 +0000 (09:28 +0000)]
Fix the Tiger build by making the Xcode project compatible with Xcode 2.4.

This was probably broken by hand-editing the project file as Xcode itself
knows how to keep project files to a backwards-compatible subset of its format.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-01 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 1 Dec 2009 08:45:16 +0000 (08:45 +0000)]
2009-12-01  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: windows build fix (bad vcproj in r51528).

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
pfeldman@chromium.org [Tue, 1 Dec 2009 08:07:16 +0000 (08:07 +0000)]
2009-11-27  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: Split InspectorBackend into three parts: backend,
        injected script host and frontend host.

        https://bugs.webkit.org/show_bug.cgi?id=31888

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSInspectorBackendCustom.cpp: Removed.
        * bindings/js/JSInspectorFrontendHostCustom.cpp: Added.
        (WebCore::JSInspectorFrontendHost::search):
        (WebCore::JSInspectorFrontendHost::setting):
        (WebCore::JSInspectorFrontendHost::setSetting):
        * bindings/js/ScriptObject.cpp:
        (WebCore::ScriptGlobalObject::set):
        * bindings/js/ScriptObject.h:
        * bindings/v8/DOMObjectsInclude.h:
        * bindings/v8/DerivedSourcesAllInOne.cpp:
        * bindings/v8/ScriptObject.cpp:
        (WebCore::ScriptGlobalObject::set):
        * bindings/v8/ScriptObject.h:
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8InspectorBackendCustom.cpp: Removed.
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * inspector/InjectedScriptHost.cpp: Added.
        (WebCore::InjectedScriptHost::InjectedScriptHost):
        (WebCore::InjectedScriptHost::~InjectedScriptHost):
        (WebCore::InjectedScriptHost::copyText):
        (WebCore::InjectedScriptHost::nodeForId):
        (WebCore::InjectedScriptHost::wrapObject):
        (WebCore::InjectedScriptHost::unwrapObject):
        (WebCore::InjectedScriptHost::pushNodePathToFrontend):
        (WebCore::InjectedScriptHost::addNodesToSearchResult):
        (WebCore::InjectedScriptHost::currentCallFrame):
        (WebCore::InjectedScriptHost::databaseForId):
        (WebCore::InjectedScriptHost::selectDatabase):
        (WebCore::InjectedScriptHost::selectDOMStorage):
        (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
        (WebCore::InjectedScriptHost::inspectorDOMAgent):
        (WebCore::InjectedScriptHost::inspectorFrontend):
        * inspector/InjectedScriptHost.h: Added.
        (WebCore::InjectedScriptHost::create):
        (WebCore::InjectedScriptHost::inspectorController):
        (WebCore::InjectedScriptHost::disconnectController):
        * inspector/InjectedScriptHost.idl: Added.
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::InspectorBackend):
        (WebCore::InspectorBackend::storeLastActivePanel):
        (WebCore::InspectorBackend::toggleNodeSearch):
        (WebCore::InspectorBackend::resourceTrackingEnabled):
        (WebCore::InspectorBackend::debuggerEnabled):
        (WebCore::InspectorBackend::enableDebugger):
        (WebCore::InspectorBackend::disableDebugger):
        (WebCore::InspectorBackend::addBreakpoint):
        (WebCore::InspectorBackend::updateBreakpoint):
        (WebCore::InspectorBackend::removeBreakpoint):
        (WebCore::InspectorBackend::pauseInDebugger):
        (WebCore::InspectorBackend::resumeDebugger):
        (WebCore::InspectorBackend::stepOverStatementInDebugger):
        (WebCore::InspectorBackend::stepIntoStatementInDebugger):
        (WebCore::InspectorBackend::stepOutOfFunctionInDebugger):
        (WebCore::InspectorBackend::pauseOnExceptions):
        (WebCore::InspectorBackend::setPauseOnExceptions):
        (WebCore::InspectorBackend::profilerEnabled):
        (WebCore::InspectorBackend::enableProfiler):
        (WebCore::InspectorBackend::disableProfiler):
        (WebCore::InspectorBackend::startProfiling):
        (WebCore::InspectorBackend::stopProfiling):
        (WebCore::InspectorBackend::getProfileHeaders):
        (WebCore::InspectorBackend::getProfile):
        (WebCore::InspectorBackend::currentCallFrame):
        (WebCore::InspectorBackend::highlightDOMNode):
        (WebCore::InspectorBackend::hideDOMNodeHighlight):
        (WebCore::InspectorBackend::getCookies):
        (WebCore::InspectorBackend::deleteCookie):
        (WebCore::InspectorBackend::didEvaluateForTestInFrontend):
        (WebCore::InspectorBackend::nodeForId):
        * inspector/InspectorBackend.h:
        (WebCore::InspectorBackend::create):
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::inspectorFrontendHost):
        (WebCore::InspectorController::injectedScriptHost):
        * inspector/InspectorFrontendHost.cpp: Added.
        (WebCore::InspectorFrontendHost::InspectorFrontendHost):
        (WebCore::InspectorFrontendHost::~InspectorFrontendHost):
        (WebCore::InspectorFrontendHost::loaded):
        (WebCore::InspectorFrontendHost::attach):
        (WebCore::InspectorFrontendHost::detach):
        (WebCore::InspectorFrontendHost::closeWindow):
        (WebCore::InspectorFrontendHost::windowUnloading):
        (WebCore::InspectorFrontendHost::setAttachedWindowHeight):
        (WebCore::InspectorFrontendHost::moveWindowBy):
        (WebCore::InspectorFrontendHost::localizedStringsURL):
        (WebCore::InspectorFrontendHost::hiddenPanels):
        (WebCore::InspectorFrontendHost::platform):
        (WebCore::InspectorFrontendHost::port):
        (WebCore::InspectorFrontendHost::addResourceSourceToFrame):
        (WebCore::InspectorFrontendHost::addSourceToFrame):
        * inspector/InspectorFrontendHost.h: Added.
        (WebCore::InspectorFrontendHost::create):
        (WebCore::InspectorFrontendHost::inspectorController):
        (WebCore::InspectorFrontendHost::disconnectController):
        * inspector/InspectorFrontendHost.idl: Added.
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint.prototype.set condition):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
        (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
        (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.clearMessages):
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent.prototype.getChildNodesAsync):
        (WebInspector.DOMAgent.prototype.setAttributeAsync):
        (WebInspector.DOMAgent.prototype.removeAttributeAsync):
        (WebInspector.DOMAgent.prototype.setTextNodeValueAsync):
        (WebInspector.Cookies.getCookiesAsync):
        (WebInspector.EventListeners.getEventListenersForNodeAsync):
        * inspector/front-end/DOMStorage.js:
        (WebInspector.DOMStorage.prototype.getEntries):
        (WebInspector.DOMStorage.prototype.setItem):
        (WebInspector.DOMStorage.prototype.removeItem):
        * inspector/front-end/Database.js:
        (WebInspector.Database.prototype.getTableNames):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel.prototype.hide):
        (WebInspector.ElementsPanel.prototype.reset):
        (WebInspector.ElementsPanel.prototype.handleCopyEvent):
        (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode):
        (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
        ():
        * inspector/front-end/EventListenersSidebarPane.js:
        (WebInspector.EventListenersSidebarPane.prototype):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript._evaluateAndWrap):
        (InjectedScript.performSearch.addNodesToResults):
        (InjectedScript.getCallFrames):
        (InjectedScript._callFrameForId):
        (InjectedScript._clearConsoleMessages):
        (InjectedScript._inspectObject):
        (InjectedScript._copy):
        (InjectedScript._ensureCommandLineAPIInstalled):
        (InjectedScript._window):
        (InjectedScript._nodeForId):
        (InjectedScript._objectForId):
        (InjectedScript.pushNodeToFrontend):
        (InjectedScript.executeSql):
        (InjectedScript.executeSql.errorCallback):
        (InjectedScript.executeSql.queryTransaction):
        * inspector/front-end/InjectedScriptAccess.js:
        (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName):
        (InjectedScriptAccess._installHandler):
        * inspector/front-end/InspectorBackendStub.js: Added.
        (.WebInspector.InspectorBackendStub):
        (.WebInspector.InspectorBackendStub.prototype.wrapCallback):
        (.WebInspector.InspectorBackendStub.prototype.platform):
        (.WebInspector.InspectorBackendStub.prototype.port):
        (.WebInspector.InspectorBackendStub.prototype.closeWindow):
        (.WebInspector.InspectorBackendStub.prototype.attach):
        (.WebInspector.InspectorBackendStub.prototype.detach):
        (.WebInspector.InspectorBackendStub.prototype.storeLastActivePanel):
        (.WebInspector.InspectorBackendStub.prototype.clearMessages):
        (.WebInspector.InspectorBackendStub.prototype.searchingForNode):
        (.WebInspector.InspectorBackendStub.prototype.search):
        (.WebInspector.InspectorBackendStub.prototype.toggleNodeSearch):
        (.WebInspector.InspectorBackendStub.prototype.setAttachedWindowHeight):
        (.WebInspector.InspectorBackendStub.prototype.moveByUnrestricted):
        (.WebInspector.InspectorBackendStub.prototype.addResourceSourceToFrame):
        (.WebInspector.InspectorBackendStub.prototype.addSourceToFrame):
        (.WebInspector.InspectorBackendStub.prototype.getResourceDocumentNode):
        (.WebInspector.InspectorBackendStub.prototype.highlightDOMNode):
        (.WebInspector.InspectorBackendStub.prototype.hideDOMNodeHighlight):
        (.WebInspector.InspectorBackendStub.prototype.inspectedWindow):
        (.WebInspector.InspectorBackendStub.prototype.loaded):
        (.WebInspector.InspectorBackendStub.prototype.localizedStringsURL):
        (.WebInspector.InspectorBackendStub.prototype.windowUnloading):
        (.WebInspector.InspectorBackendStub.prototype.hiddenPanels):
        (.WebInspector.InspectorBackendStub.prototype.debuggerEnabled):
        (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking):
        (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking):
        (.WebInspector.InspectorBackendStub.prototype.resourceTrackingEnabled):
        (.WebInspector.InspectorBackendStub.prototype.enableDebugger):
        (.WebInspector.InspectorBackendStub.prototype.disableDebugger):
        (.WebInspector.InspectorBackendStub.prototype.addBreakpoint):
        (.WebInspector.InspectorBackendStub.prototype.removeBreakpoint):
        (.WebInspector.InspectorBackendStub.prototype.updateBreakpoint):
        (.WebInspector.InspectorBackendStub.prototype.pauseInDebugger):
        (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptions):
        (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptions):
        (.WebInspector.InspectorBackendStub.prototype.resumeDebugger):
        (.WebInspector.InspectorBackendStub.prototype.profilerEnabled):
        (.WebInspector.InspectorBackendStub.prototype.enableProfiler):
        (.WebInspector.InspectorBackendStub.prototype.disableProfiler):
        (.WebInspector.InspectorBackendStub.prototype.startProfiling):
        (.WebInspector.InspectorBackendStub.prototype.stopProfiling):
        (.WebInspector.InspectorBackendStub.prototype.getProfileHeaders):
        (.WebInspector.InspectorBackendStub.prototype.getProfile):
        (.WebInspector.InspectorBackendStub.prototype.takeHeapSnapshot):
        (.WebInspector.InspectorBackendStub.prototype.databaseTableNames):
        (.WebInspector.InspectorBackendStub.prototype.stepIntoStatementInDebugger):
        (.WebInspector.InspectorBackendStub.prototype.stepOutOfFunctionInDebugger):
        (.WebInspector.InspectorBackendStub.prototype.stepOverStatementInDebugger):
        (.WebInspector.InspectorBackendStub.prototype.setSetting):
        (.WebInspector.InspectorBackendStub.prototype.dispatchOnInjectedScript):
        (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
        (.WebInspector.InspectorBackendStub.prototype.setting):
        * inspector/front-end/InspectorControllerStub.js:
        * inspector/front-end/InspectorFrontendHostStub.js: Added.
        (.WebInspector.InspectorFrontendHostStub):
        (.WebInspector.InspectorFrontendHostStub.prototype.platform):
        (.WebInspector.InspectorFrontendHostStub.prototype.port):
        (.WebInspector.InspectorFrontendHostStub.prototype.closeWindow):
        (.WebInspector.InspectorFrontendHostStub.prototype.attach):
        (.WebInspector.InspectorFrontendHostStub.prototype.detach):
        (.WebInspector.InspectorFrontendHostStub.prototype.search):
        (.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight):
        (.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy):
        (.WebInspector.InspectorFrontendHostStub.prototype.addResourceSourceToFrame):
        (.WebInspector.InspectorFrontendHostStub.prototype.addSourceToFrame):
        (.WebInspector.InspectorFrontendHostStub.prototype.loaded):
        (.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL):
        (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
        (.WebInspector.InspectorFrontendHostStub.prototype.setSetting):
        (.WebInspector.InspectorFrontendHostStub.prototype.setting):
        * inspector/front-end/ProfileView.js:
        (WebInspector.CPUProfileView):
        (WebInspector.CPUProfileType.prototype.buttonClicked):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._updateInterface):
        (WebInspector.ProfilesPanel.prototype._enableProfiling):
        (WebInspector.ProfilesPanel.prototype._toggleProfiling):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.reset):
        (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
        (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
        (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.show):
        (WebInspector.ScriptsPanel.prototype.addScript):
        (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
        (WebInspector.ScriptsPanel.prototype.reset):
        (WebInspector.ScriptsPanel.prototype.canShowResource):
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
        (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
        (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
        (WebInspector.ScriptsPanel.prototype._enableDebugging):
        (WebInspector.ScriptsPanel.prototype._toggleDebugging):
        (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
        (WebInspector.ScriptsPanel.prototype._togglePause):
        (WebInspector.ScriptsPanel.prototype._stepOverClicked):
        (WebInspector.ScriptsPanel.prototype._stepIntoClicked):
        (WebInspector.ScriptsPanel.prototype._stepOutClicked):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
        (WebInspector.SourceView.prototype.performSearch.findSearchMatches):
        (WebInspector.SourceView.prototype.performSearch):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
        * inspector/front-end/TestController.js:
        (WebInspector.TestController.prototype.notifyDone):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSection.prototype.update):
        (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions):
        (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.pendingDispatches.0.get platform):
        (WebInspector.get port):
        (WebInspector.set currentPanel):
        (WebInspector._createPanels):
        (WebInspector._loadPreferences):
        (WebInspector.set attached):
        (WebInspector._updateHoverHighlight):
        (WebInspector.loaded):
        (windowLoaded):
        (WebInspector.windowUnload):
        (WebInspector.close):
        (WebInspector.toolbarDrag):
        (WebInspector.UIString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 1 Dec 2009 07:37:14 +0000 (07:37 +0000)]
2009-11-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        css2.1/t1205-c566-list-stl-00-e-ag.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=23264
        css2.1/t1205-c565-list-pos-00-b.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=23263

        Ignore whitespaces after list markers.
        Rendering of this was already done for the case where inside=false.
        This fixes the rendering of inside=true case and calcInlinePrefWidths.

        Test: fast/lists/calc-width-with-space.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::calcInlinePrefWidths):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak):
2009-11-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        css2.1/t1205-c566-list-stl-00-e-ag.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=23264

        * editing/pasteboard/copy-crash-expected.txt:
        * fast/lists/calc-width-with-space-expected.txt: Added.
        * fast/lists/calc-width-with-space.html: Added.
        * platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.checksum:
        * platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.png:
        * platform/mac/css2.1/t1205-c561-list-displ-00-b-expected.txt:
        * platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.checksum:
        * platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.png:
        * platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt:
        * platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.checksum:
        * platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.png:
        * platform/mac/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
        * platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum:
        * platform/mac/fast/block/positioning/complex-percentage-height-expected.png:
        * platform/mac/fast/block/positioning/complex-percentage-height-expected.txt:
        * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum:
        * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png:
        * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt:
        * platform/mac/fast/repaint/list-marker-expected.checksum:
        * platform/mac/fast/repaint/list-marker-expected.png:
        * platform/mac/fast/repaint/list-marker-expected.txt:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 1 Dec 2009 07:25:13 +0000 (07:25 +0000)]
2009-11-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        check-webkit-style is slightly too verbose
        https://bugs.webkit.org/show_bug.cgi?id=32010

        check-webkit-style prints out a bunch of "done" lines that seem redundant,
        especially for the style-queue.

        * Scripts/modules/cpp_style.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Tue, 1 Dec 2009 06:41:14 +0000 (06:41 +0000)]
2009-11-30  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Moved the functions that are closing the result log of the
        tests to the last line of the runTest function, this avoids
        reporting crashes in the wrong test if there is a problem when
        reseting the state after the test.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dump):
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 1 Dec 2009 03:33:00 +0000 (03:33 +0000)]
2009-11-30  Fumitoshi Ukai  <ukai@chromium.org>

        Unreviewed Chromium build fix introduced by r51212

        Fix scriptStateFromNode and ScriptStateFromPage to take DOMWrapperWorld
        as the first argument.
        Move mainThreadNormalWorld() to ScriptState.{h,cpp}.
        Add debuggerWorld() and pluginWorld() in ScriptState.h.

        * bindings/v8/ScriptController.cpp:
        * bindings/v8/ScriptController.h:
        * bindings/v8/ScriptState.cpp:
        (WebCore::scriptStateFromNode):
        (WebCore::scriptStateFromPage):
        (WebCore::mainThreadNormalWorld):
        * bindings/v8/ScriptState.h:
        (WebCore::debuggerWorld):
        (WebCore::pluginWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=31286
weinig@apple.com [Tue, 1 Dec 2009 01:18:50 +0000 (01:18 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
fast/js/date-proto-generic-invocation breaks another test

Reviewed by Geoffrey Garen.

Don't cache JSClassRefs, a change to the prototype chain will
last between tests.

* DumpRenderTree/AccessibilityController.cpp:
(AccessibilityController::getJSClass):
* DumpRenderTree/GCController.cpp:
(GCController::getJSClass):
* DumpRenderTree/GCController.h:
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::getJSClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Can focus but not type into content editable block that contains only non...
enrica@apple.com [Tue, 1 Dec 2009 00:44:30 +0000 (00:44 +0000)]
WebCore: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750

Reviewed by Darin Adler.

The goal is to change the way we choose a visible position
after hit detection, by preferring a visually equivalent editable
position if available. By doing this, it is possible to add content
to an editable block that initially contains only non editable elements.

Test: editing/selection/mixed-editability-10.html

* WebCore.base.exp: Changed to match the new signature of downstream
and upstream in the Position class.
* dom/Position.cpp:
(WebCore::Position::atEditingBoundary): Added.
(WebCore::Position::upstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::downstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
(WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box
to be used in calculating the caret rectangle.
* dom/Position.h:
(WebCore::Position::):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::atEditingBoundary): Added.
(WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
* dom/PositionIterator.h:
* editing/htmlediting.cpp:
(WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
(WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position,
if available.
* rendering/RenderText.cpp:
(WebCore::RenderText::isAllCollapsibleWhitespace): Added.
* rendering/RenderText.h:

LayoutTests: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750

Reviewed by Darin Adler.

* editing/selection/5825350-1-expected.txt:
* editing/selection/5825350-1.html: Modified to use caret rectangle.
* editing/selection/5825350-2-expected.txt:
* editing/selection/5825350-2.html: Modified to use caret rectangle.
* editing/selection/mixed-editability-10-expected.txt: Added.
* editing/selection/mixed-editability-10.html: Added.
* platform/mac/editing/deleting/5390681-2-expected.txt: Re-baselined
to account for the new possible caret position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Tue, 1 Dec 2009 00:40:04 +0000 (00:40 +0000)]
2009-11-30  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Alexey Proskuryakov.

        Update pywebsocket to 0.4.2.1.
        This is to fix a bug that some messages are logged to stderr even when the log file is specified.
        https://bugs.webkit.org/show_bug.cgi?id=31976

        * pywebsocket/mod_pywebsocket/standalone.py:
        * pywebsocket/setup.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix, add header needed for wx build.
kevino@webkit.org [Tue, 1 Dec 2009 00:12:44 +0000 (00:12 +0000)]
wx build fix, add header needed for wx build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from...
mrowe@apple.com [Tue, 1 Dec 2009 00:08:39 +0000 (00:08 +0000)]
<rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from a machine that cannot run x86_64 binaries

Reviewed by David Kilzer.

The check for whether WTF_USE_PLUGIN_HOST_PROCESS is defined occurs under the native architecture of the build machine.
If that is 32-bit then WTF_USE_PLUGIN_HOST_PROCESS will not be defined.  We work around this by forcing the check to
be performed against the x86_64 architecture.

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Adam Barth <abarth@webkit.org>
eric@webkit.org [Tue, 1 Dec 2009 00:07:41 +0000 (00:07 +0000)]
2009-11-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Generate pass messages for style-queue
        https://bugs.webkit.org/show_bug.cgi?id=31995

        With this change, the style-queue posts "pass" messages to bugs as
        well.  Also, added more information to the state store w.r.t. passing
        and failing.

        * Scripts/modules/commands/queues.py:
        * Scripts/modules/patchcollection.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
bdakin@apple.com [Mon, 30 Nov 2009 23:55:38 +0000 (23:55 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
Safari caused by extreme column-gap and column-width values
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

Prevent desiredColumnCount from being less than 1 since it is used
as a divisor.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
Safari caused by extreme column-gap and column-width values
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

* fast/multicol/huge-column-gap-crash-expected.txt: Added.
* fast/multicol/huge-column-gap-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
ap@apple.com [Mon, 30 Nov 2009 23:48:50 +0000 (23:48 +0000)]
    Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=31659
        Connection must be closed in case of Web Socket handshake error

        The network connection was closed, but the close event wasn't dispatched.

        Tested by websocket/tests/handshake-error.html, which is un-skipped now.

        * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
        Call client didHandle() method. This looks strange in CFNetwork implementation, because
        it's the client that asked to close the stream, so it shouldn't need the callback. It makes
        more sense in cross-process implementation, because closing is async there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Abhinav Mithal <abhinav.mithal@nokia.com>
eric@webkit.org [Mon, 30 Nov 2009 23:20:04 +0000 (23:20 +0000)]
2009-11-30  Abhinav Mithal  <abhinav.mithal@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt][Symbian] Report SymbianOS in user agent string for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=31961

        * Api/qwebpage.cpp:
        (QWebPage::userAgentForUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows Build fix. Reviewed by NOBODY.
barraclough@apple.com [Mon, 30 Nov 2009 22:10:30 +0000 (22:10 +0000)]
Windows Build fix.  Reviewed by NOBODY.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse the correct path to Info.plist to avoid creating an empty file at the top of...
mrowe@apple.com [Mon, 30 Nov 2009 22:02:14 +0000 (22:02 +0000)]
Use the correct path to Info.plist to avoid creating an empty file at the top of the WebKit directory.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 31859 - Make world selection for JSC IsolatedWorlds automagical.
barraclough@apple.com [Mon, 30 Nov 2009 21:48:23 +0000 (21:48 +0000)]
Bug 31859 - Make world selection for JSC IsolatedWorlds automagical.

Reviewed by Geoff Garen.

JavaScriptCore:

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Remove the temporary duct tape of willExecute/didExecute virtual hooks on the JSGlobalData::ClientData - these are no longer necessary.

* API/JSBase.cpp:
(JSEvaluateScript):
* API/JSObjectRef.cpp:
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalData.h:

WebCore:

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Remove the last uses of mainThreadCurrentWorld(), so the world is always obtained via
currentWorld().  Switch this to obtain the world from the ExecsState's lexical global
object instead.  Remove the call/construct/evaluate 'InWorld' methods, since these
are no longer necessary.

* WebCore.base.exp:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/js/JSDOMBinding.cpp:
(WebCore::currentWorld):
(WebCore::mainThreadNormalWorld):
* bindings/js/JSDOMBinding.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::updateDocument):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
* bindings/js/ScriptObjectQuarantine.cpp:
(WebCore::getQuarantinedScriptObject):
* bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):
* bindings/js/ScriptState.h:
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
* bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
* dom/NodeFilter.h:
(WebCore::NodeFilter::acceptNode):
* dom/NodeIterator.h:
(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
* dom/TreeWalker.h:
(WebCore::TreeWalker::parentNode):
(WebCore::TreeWalker::firstChild):
(WebCore::TreeWalker::lastChild):
(WebCore::TreeWalker::previousSibling):
(WebCore::TreeWalker::nextSibling):
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::didEvaluateForTestInFrontend):
* inspector/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):

WebKit/mac:

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Since WebCore no longer needs to explicitly specify the world on entry to JSC DebuggerCallFrame::evaluate can be called directly.

* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 30 Nov 2009 21:43:57 +0000 (21:43 +0000)]
2009-11-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        All HTML5 media element events should be regular events
        https://bugs.webkit.org/show_bug.cgi?id=30513

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::selectMediaResource):
        (WebCore::HTMLMediaElement::noneSupported):
        (WebCore::HTMLMediaElement::mediaEngineError):
        (WebCore::HTMLMediaElement::setNetworkState):
        (WebCore::HTMLMediaElement::userCancelledLoad):
            Call scheduleEvent instead of scheduleProgressEvent.
        (WebCore::HTMLMediaElement::progressEventTimerFired):
            Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement
            after scheduling a 'progress' event so the controller will update download
            progress indicator.
        * html/HTMLMediaElement.h:
            Remove scheduleProgressEvent prototype.

2009-11-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        All HTML5 media element events should be regular events
        https://bugs.webkit.org/show_bug.cgi?id=30513

        Remove progress event tests.

        * media/progress-event-at-least-one-expected.txt: Removed.
        * media/progress-event-at-least-one.html: Removed.
        * media/progress-event-expected.txt: Removed.
        * media/progress-event-total-expected.txt: Removed.
        * media/progress-event-total.html: Removed.
        * media/progress-event.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix double-free of BSTRs passed to WebNavigationData::createInstance
aroben@apple.com [Mon, 30 Nov 2009 21:41:03 +0000 (21:41 +0000)]
Fix double-free of BSTRs passed to WebNavigationData::createInstance

WebFrameLoaderClient::updateGlobalHistory was converting
WebCore::Strings to WebCore::BStrings, then passing them to
WebNavigationData::createInstance. But the latter function takes BSTR
parameters and adopts them into WebCore::BStrings. So the end result
was that two WebCore::BStrings would end up freeing each underlying
BSTR.

The fix is to only convert to WebCore::BString inside
WebNavigationData.

Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
(r49564): Crash in updateGlobalHistory when running Javascript iBench
test

I couldn't find a way to reproduce this in DumpRenderTree.

Reviewed by Steve Falkenburg.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
WebNavigationData::createInstance.

* WebNavigationData.cpp:
(WebNavigationData::WebNavigationData):
(WebNavigationData::createInstance):
* WebNavigationData.h:
Changed to take const WebCore::String&s instead of BSTRs and to
convert the Strings to BStrings at this level.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIt was me who reviewed the patch, not Eric! Alas, some tools we use cause wrong revie...
ap@apple.com [Mon, 30 Nov 2009 21:38:19 +0000 (21:38 +0000)]
It was me who reviewed the patch, not Eric! Alas, some tools we use cause wrong reviewer information in Bugzilla.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Yuzo Fujishima <yuzo@google.com>
ap@apple.com [Mon, 30 Nov 2009 21:35:04 +0000 (21:35 +0000)]
2009-11-30  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        In testing handshake-error case, web_socket_do_extra_handshake calls a non-existent method
        https://bugs.webkit.org/show_bug.cgi?id=31465

        * platform/mac/Skipped: websocket/tests/handshake-error.html now fails on Mac, added to
        Skipped list, and filed bug 31659 to investigate.

        * websocket/tests/handshake-error_wsh.py: Call write() on a correct object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove file git invisibly added
joepeck@webkit.org [Mon, 30 Nov 2009 21:27:23 +0000 (21:27 +0000)]
Remove file git invisibly added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Mon, 30 Nov 2009 21:19:42 +0000 (21:19 +0000)]
2009-11-30  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Wrong console output for Regexp escape sequence
        https://bugs.webkit.org/show_bug.cgi?id=31538

        Updated inspector/console-format.html

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.createDividerElement): style issues.
        (WebInspector.ConsoleView.createFilterElement): style issues.
        (WebInspector.ConsoleView): added _customFormatters table.
        (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses.
        (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues.
        (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic.
        (WebInspector.ConsoleView.prototype._formatobject):
        (WebInspector.ConsoleView.prototype._formatnode):
        (WebInspector.ConsoleView.prototype._printArray):
        (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts.
        (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting.
        (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting.
        (WebInspector.ConsoleCommandResult):
        * inspector/front-end/InjectedScript.js: simplified regex formatting.
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
        * inspector/front-end/utilities.js:
        (Element.prototype.hasStyleClass): update inaccurate comment.
        (String.prototype.trimURL): converted new RegExp to literal for performance benefits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 30 Nov 2009 20:42:19 +0000 (20:42 +0000)]
2009-11-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove obsolete PLATFORM(KDE) code
        https://bugs.webkit.org/show_bug.cgi?id=31958

        KDE is now using unpatched QtWebKit.

        * parser/Lexer.cpp: Remove obsolete KDE_USE_FINAL guard
        * wtf/Platform.h: Remove PLATFORM(KDE) definition and code
        section that is guarded with it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSkipping test that fails because of broken DND, and some tests
kov@webkit.org [Mon, 30 Nov 2009 19:55:42 +0000 (19:55 +0000)]
Skipping test that fails because of broken DND, and some tests
requiring new results.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Xan Lopez.
kov@webkit.org [Mon, 30 Nov 2009 19:27:53 +0000 (19:27 +0000)]
Rubber-stamped by Xan Lopez.

Make sure we distribute and install GObject Introspection files.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Erik Arvidsson <arv@chromium.org>
eric@webkit.org [Mon, 30 Nov 2009 18:59:36 +0000 (18:59 +0000)]
2009-11-30  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Adam Barth.

        Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
        https://bugs.webkit.org/show_bug.cgi?id=31895

        No new tests. This is already covered by:
                fast/dom/CSSStyleDeclaration/css-computed-style-item.html
                fast/dom/CSSStyleDeclaration/css-style-item.html

        * bindings/v8/V8Collection.h:
        (WebCore::collectionStringIndexedPropertyGetter):
        (WebCore::setCollectionStringIndexedGetter):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should...
sfalken@apple.com [Mon, 30 Nov 2009 18:50:40 +0000 (18:50 +0000)]
WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
https://bugs.webkit.org/show_bug.cgi?id=31986

Reviewed by Adam Roben.

* WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Simon Fraser.
kov@webkit.org [Mon, 30 Nov 2009 17:54:10 +0000 (17:54 +0000)]
Reviewed by Simon Fraser.

Check for WEBKIT_TESTFONTS environment variable in
run-webkit-tests, for GTK+, to have a more prominent error
message.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 30 Nov 2009 17:41:56 +0000 (17:41 +0000)]
2009-11-30  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Adds include of wtf/StdLibExtras.h for DEFINE_STATIC_LOCAL in V8 ScriptController.
        https://bugs.webkit.org/show_bug.cgi?id=31932

        Build fix only, no new tests.

        * bindings/v8/ScriptController.cpp: Modified. Adds include of wtf/StdLibExtras.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 30 Nov 2009 17:34:59 +0000 (17:34 +0000)]
2009-11-30  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Adds PassOwnPtr include to ScriptExecutionContext.h.
        https://bugs.webkit.org/show_bug.cgi?id=31929

        Build fix only, no new tests.

        * dom/ScriptExecutionContext.h: Modified. Adds PassOwnPtr include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Mon, 30 Nov 2009 17:25:00 +0000 (17:25 +0000)]
2009-11-30  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Complex test of mask with every combination of maskUnits and maskContentUnits
        as well as different values for size and position of the mask and it's content.

        * platform/mac/svg/custom/mask-with-all-units-expected.checksum: Added.
        * platform/mac/svg/custom/mask-with-all-units-expected.png: Added.
        * platform/mac/svg/custom/mask-with-all-units-expected.txt: Added.
        * svg/custom/mask-with-all-units.svg: Added.
2009-11-30  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
        [https://bugs.webkit.org/show_bug.cgi?id=31980]

        It turns out, that we did not handle maskUnits="userSpaceOnUse"
        correctly. We just need to move the context of the maskImage
        if maskContentUnits="objectBoundingBox". The context gets scaled
        on this unit combination, so we have to substract the position of
        the targetRect. On userSpaceOnUse the position just depends on the
        position of the mask element.
        I added a test with some senseless and reasonable values for size
        and postion of the mask and it's contents. I also used every
        combination of maskUnits and maskContentUnits to be sure, that it
        is fixed this time.

        Test: svg/custom/mask-with-all-units.svg

        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 30 Nov 2009 17:17:42 +0000 (17:17 +0000)]
2009-11-30  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
        https://bugs.webkit.org/show_bug.cgi?id=31928

        Build fix only, no new tests.

        * page/DOMWindow.cpp: Modified. Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 30 Nov 2009 17:10:36 +0000 (17:10 +0000)]
2009-11-30  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        update-webkit --chromium forces gclient sync

        https://bugs.webkit.org/show_bug.cgi?id=31967

        * Scripts/update-webkit-chromium:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 30 Nov 2009 17:03:32 +0000 (17:03 +0000)]
2009-11-30  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Adds SHARED_WORKERS guards to V8 WorkerContextExecutionProxy.
        https://bugs.webkit.org/show_bug.cgi?id=31926

        Build fix only, no new tests.

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
        (WebCore::WorkerContextExecutionProxy::convertToV8Object):
        (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Mon, 30 Nov 2009 16:56:24 +0000 (16:56 +0000)]
2009-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Chrome::contentsSizeChanged() is called when the content size has not changed
        https://bugs.webkit.org/show_bug.cgi?id=31978

        Do not trigger contentsSizeChaned() is the new size is the same as the old one.

        * page/FrameView.cpp:
        (WebCore::FrameView::setContentsSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 30 Nov 2009 16:49:20 +0000 (16:49 +0000)]
2009-11-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix minor waning in QtWebKit
        https://bugs.webkit.org/show_bug.cgi?id=31963

        * tests/qwebpage/tst_qwebpage.cpp:
        (ErrorPage::extension): Remove info wariable as it is
        not used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 30 Nov 2009 16:42:26 +0000 (16:42 +0000)]
2009-11-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix some compiler warnings seen on QtWebKit/Mac
        https://bugs.webkit.org/show_bug.cgi?id=31962

        No new tests as there is no functional change.

        * platform/network/ResourceHandle.h: Make destructor virtual as
        after r50772 ResourceHandle has virtual functions.

        * plugins/mac/PluginPackageMac.cpp:
        (WebCore::PluginPackage::fetchInfo): Fix typo WTF is a namespace
        not a label

        * plugins/mac/PluginViewMac.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded): Add l to the format
        specifier

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Mon, 30 Nov 2009 15:31:22 +0000 (15:31 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix. Make sure JSCore-1.0.gir is added to the distributed
kov@webkit.org [Mon, 30 Nov 2009 15:13:44 +0000 (15:13 +0000)]
Build fix. Make sure JSCore-1.0.gir is added to the distributed
tarball.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 30 Nov 2009 13:53:52 +0000 (13:53 +0000)]
2009-11-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Bump versions for 1.1.17 release.

        * configure.ac:

WebCore:

2009-11-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Add new headers to sources list.

        * GNUmakefile.am:

WebKit/gtk:

2009-11-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Prepare for 1.1.17 release.

        * NEWS:
        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Mac Plugins : Get context menu to work in QGraphicsView
girish@forwardbias.in [Mon, 30 Nov 2009 12:08:20 +0000 (12:08 +0000)]
[Qt] Mac Plugins : Get context menu to work in QGraphicsView

Reviewed by Holger Freyther.

Flash expects the value in record.where to be the global position for
displaying the context menu.

https://bugs.webkit.org/show_bug.cgi?id=31979

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Fix compilation with win32-icc
hausmann@webkit.org [Mon, 30 Nov 2009 11:27:51 +0000 (11:27 +0000)]
[Qt] Fix compilation with win32-icc

Patch by Jan-Arve Sæther <jan-arve.saether@nokia.com> on 2009-11-30
Reviewed by Simon Hausmann.

.:

Include os-win32 for stdint.h since MS does not ship that in their PSDK.

* WebKit.pri:

JavaScriptCore:

The Intel compiler does not support the __has_trivial_constructor type
trait.  The Intel Compiler can report itself as _MSC_VER >= 1400. The
reason for that is that the Intel Compiler depends on the Microsoft
Platform SDK, and in order to try to be "fully" MS compatible it will
"pretend" to be the same MS compiler as was shipped with the MS PSDK.
(Thus, compiling with win32-icc with VC8 SDK will make the source code
"think" the compiler at hand supports this type trait).

* wtf/TypeTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController.
steveblock@google.com [Mon, 30 Nov 2009 10:39:23 +0000 (10:39 +0000)]
Adds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController.
https://bugs.webkit.org/show_bug.cgi?id=31925

Reviewed by Eric Seidel.

This code uses ChromiumBridge and Chromium-specific constant values not
appropriate for other platforms such as Android.

Build fix only, no new tests.

* bindings/v8/V8GCController.cpp: Modified. Adds PLATFORM(CHROMIUM) around Chromium-specific code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Put tests into skiplist because of missing features.
ossy@webkit.org [Mon, 30 Nov 2009 09:41:02 +0000 (09:41 +0000)]
[Qt] Put tests into skiplist because of missing features.

* platform/qt/Skipped:
- fast/dom/Window/window-postmessage-clone.html added
- inspector/elements-img-tooltip.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix.
bfulgham@webkit.org [Mon, 30 Nov 2009 04:50:00 +0000 (04:50 +0000)]
Build fix.

Correct draw signature used in ImageCairoWin.cpp.

* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agopostMessage should serialize File objects
oliver@apple.com [Mon, 30 Nov 2009 04:15:40 +0000 (04:15 +0000)]
postMessage should serialize File objects
https://bugs.webkit.org/show_bug.cgi?id=31955

Reviewed by Sam Weinig.

Update SerializedScriptValue to include support for
File objects in the serialized object graph.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 30 Nov 2009 03:54:19 +0000 (03:54 +0000)]
2009-11-29  Eric Seidel  <eric@webkit.org>

        Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 30 Nov 2009 03:45:56 +0000 (03:45 +0000)]
2009-11-29  Simon Fraser  <simon.fraser@apple.com>

        Rubber-stamped by Eric Seidel.

        Fix up some compositing layout tests.

        * compositing/layers-inside-overflow-scroll.html:
        * compositing/self-painting-layers.html:
        Use the 'loadeddata' event, instead of 'load', to know when the video loads.

        * platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
        * platform/mac/compositing/repaint/content-into-overflow-expected.png:
        * platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
        * platform/mac/compositing/repaint/overflow-into-content-expected.png:
        * platform/mac/compositing/self-painting-layers-expected.checksum:
        * platform/mac/compositing/self-painting-layers-expected.png:
        Update with correct pixel results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 30 Nov 2009 03:26:30 +0000 (03:26 +0000)]
2009-11-29  Eric Seidel  <eric@webkit.org>

        No review, just adding missing svn property.

        Set svn:executable property on new scripts.
        These were added by commit-queue commits, but the executable
        property was lost due to a bug in svn-apply:
        https://bugs.webkit.org/show_bug.cgi?id=27204

        * Scripts/update-webkit-chromium: Added property svn:executable.
        * Scripts/validate-committer-lists: Added property svn:executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 30 Nov 2009 03:21:55 +0000 (03:21 +0000)]
2009-11-29  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Optimize the hierarchy rebuilding of compositing layers
        https://bugs.webkit.org/show_bug.cgi?id=31879

        When updating the compositing layer hierarchy, instead of removing all
        child layers and then re-adding them one by one, build a vector of child
        layers, and set them in one go.

        * platform/graphics/GraphicsLayer.h:
        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::setChildren): New method that takes a Vector of child
        GraphicsLayers.

        * platform/graphics/mac/GraphicsLayerCA.h: Override setChildren().
        * platform/graphics/win/GraphicsLayerCACF.h: Ditto.
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setChildren): Implement setChildren() to
        set the bit that notes that sublayers changed.
        * platform/graphics/win/GraphicsLayerCACF.cpp:
        (WebCore::GraphicsLayerCACF::setChildren): Implement setChildren() to
        udpate sublayers, with a note that this is not efficient.

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateCompositingLayers):
        When updating compositing layers, use the faster updateLayerTreeGeometry() if
        we know that no layer hierarchy changes are needed, and, at the root, use
        the vector returned from rebuildCompositingLayerTree() to attach the root
        layer.
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Changed to
        collect child layers into Vectors of GraphicsLayers, which can be set as
        layer children in one go.
        (WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Split out from
        rebuildCompositingLayerTree() for simplicity, and called when we just need to
        update layer geometry, without doing any reparenting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 30 Nov 2009 03:12:11 +0000 (03:12 +0000)]
2009-11-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Need a way to validate that committers.py includes all committers/reviewers
        https://bugs.webkit.org/show_bug.cgi?id=30970

        Add a script which knows how to compare our public committer/reviewer
        lists and show discrepancies between them.

        Validates mailing lists vs. committers.py:
        - committers.py committers missing from webkit-committers@lists
        - webkit-committers@lists members missing from committers.py
        - committers.py reviewers missing from webkit-reviewers@lists
        - webkit-reviewers@lists members missing from committers.py
        - webkit-reviewers@lists members missing from committers.py reviewer list

        Validates committers.py vs. trunk/ SVN history:
        - committers who have not committed in over a year
        - SVN committers missing from committers.py
        - committers.py members who have no record in SVN.

        All of these lists still show "false positives" until a few more committers.py updates are made, like:
        https://bugs.webkit.org/show_bug.cgi?id=31366

        * Scripts/validate-committer-lists: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 30 Nov 2009 03:10:36 +0000 (03:10 +0000)]
2009-11-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=31971

        Updated comment to reflect latest XSSAuditor bindings.

        No functionality was changed. So, no new tests.

        * page/XSSAuditor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 30 Nov 2009 02:45:52 +0000 (02:45 +0000)]
2009-11-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31969

        Removes unnecessary #include files.

        No functionality was changed. So, no new tests.

        * css/CSSComputedStyleDeclaration.cpp: Removed include CachedImage.h, and
        Pair.h
        * css/CSSCursorImageValue.cpp: Removed include RenderStyle.h
        * css/CSSFontFaceSrcValue.cpp: Removed include Node.h
        * css/CSSFontSelector.cpp: Removed include NodeList.h
        * css/CSSGradientValue.cpp: Removed include GraphicsContext.h, ImageBuffer.h
        * css/CSSImageValue.cpp: Removed include RenderStyle.h
        * css/CSSImportRule.cpp: Removed include MediaList.h
        * css/CSSMutableStyleDeclaration.cpp: Removed include CSSProperty.h
        * css/CSSRule.cpp: Removed include CSSStyleSheet.h
        * css/CSSStyleSelector.cpp: Removed include CSSFontFace.h,
        CSSFontFaceSource.h, and CSSProperty.h
        * page/EventSource.h: Removed include EventListener.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 30 Nov 2009 01:32:38 +0000 (01:32 +0000)]
2009-11-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31965

        Removed #include KeyframeList.h from CSSStyleSelector.h. Instead,
        forward declared it.

        As a side effect, we need to #include KeyframeList.h in
        RenderLayerBacking.cpp.

        No functionality was changed. So, no new tests.

        * css/CSSStyleSelector.cpp:
        * css/CSSStyleSelector.h: Removed #include KeyframeList.h
        * rendering/RenderLayerBacking.cpp: Added #include KeyframeList.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Mon, 30 Nov 2009 01:02:43 +0000 (01:02 +0000)]
2009-11-29  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Eric Seidel.

        Test using Id as index of node list.
        https://bugs.webkit.org/show_bug.cgi?id=31428

        * fast/dom/Element/id-in-node-list-index01-expected.txt: Added.
        * fast/dom/Element/id-in-node-list-index01.html: Added.
2009-11-29  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Eric Seidel.

        Continue to search for matching node in the case where multiple nodes
        have the same id.
        https://bugs.webkit.org/show_bug.cgi?id=31428

        Test: fast/dom/Element/id-in-node-list-index01.html

        * dom/DynamicNodeList.cpp:
        (WebCore::DynamicNodeList::itemWithName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 30 Nov 2009 00:50:35 +0000 (00:50 +0000)]
2009-11-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31966

        Removed #include RenderStyle.h from file KeyframeAnimation.h. Instead,
        forward declared it.

        No functionality was changed. So, no new tests.

        * page/animation/KeyframeAnimation.cpp:
        * page/animation/KeyframeAnimation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 30 Nov 2009 00:06:06 +0000 (00:06 +0000)]
2009-11-29  Daniel Bates  <dbates@webkit.org>

        Unreviewed, fix change log entry date.

        For some reason, bugzilla-tool did not update the date in the change
        log entry for my last commit (r51468). So, this commit fixes the date
        of that entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 29 Nov 2009 23:55:17 +0000 (23:55 +0000)]
2009-11-28  Daniel Bates  <dbates@webkit.org>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=31964

        Removed #include StringImpl, StyleImage. Instead, forward declared them.
        Also, we can substitute #include <wtf/PassRefPtr.h> for #include PlatformString.h,
        since it seems we only really used it to include PassRefPtr.h.

        No functionality was changed. So, no new tests.

        * rendering/style/ContentData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sun, 29 Nov 2009 20:11:22 +0000 (20:11 +0000)]
2009-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Mac build has JIT disabled
        https://bugs.webkit.org/show_bug.cgi?id=31828

        * wtf/Platform.h: Enable JIT for Qt Mac builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Sun, 29 Nov 2009 15:57:19 +0000 (15:57 +0000)]
2009-11-29  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Eric Seidel.

        Allow custom memory allocation control for classes of the rendering and storage directory in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=31906

        Inherits the following classes from Noncopyable because these are instantiated
        by 'new' and no need to be copyable:

        class/struct name               - instantiated at: WebCore/'location'

        class SQLTransactionClient      - storage/DatabaseThread.cpp:45
        class SQLTransactionCoordinator - storage/DatabaseThread.cpp:46
        class OriginUsageRecord         - storage/OriginQuotaManager.cpp:66
        class DatabaseTracker           - storage/DatabaseTracker.cpp:62
        class ScrollbarTheme            - (its child class) rendering/RenderScrollbarTheme.cpp:35
        class RenderSelectionInfoBase   - (its child class) rendering/RenderView.cpp:310
        class RenderOverflow            - rendering/RenderBox.cpp:2846

        Inherits the following classes from FastAllocBase because these are instantiated by 'new':

        struct FillLayer                - css/CSSStyleSelector.cpp:197
        struct ShadowData               - rendering/style/ShadowData.cpp:35
        class CounterContent            - css/CSSStyleSelector.cpp:4111

        * platform/ScrollbarTheme.h:
        * rendering/RenderOverflow.h:
        * rendering/RenderSelectionInfo.h:
        * rendering/style/CounterContent.h:
        * rendering/style/FillLayer.h:
        * rendering/style/ShadowData.h:
        * storage/DatabaseTracker.h:
        * storage/OriginUsageRecord.h:
        * storage/SQLTransactionClient.h:
        * storage/SQLTransactionCoordinator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 29 Nov 2009 01:53:38 +0000 (01:53 +0000)]
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
        https://bugs.webkit.org/show_bug.cgi?id=31950

        Now we cache the last status that we get back from QueueStatusServer.
        Eventually we'll have to do something more fancy if we want to support
        a "try again" button on QueueStatusServer, but we can cross that bridge
        when we come to it.

        * Scripts/modules/patchcollection.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 29 Nov 2009 01:50:48 +0000 (01:50 +0000)]
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        StyleQueue scans ~100 bug pages every 5 minutes
        https://bugs.webkit.org/show_bug.cgi?id=31947

        Instead of getting the pending-review attachment ids by scanning each
        bug (which results in a network request), we should just get them all
        from webkit.org/pending-review in one shot.

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/bugzilla_unittest.py:
        * Scripts/modules/commands/queries.py:
        * Scripts/modules/commands/queries_unittest.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/mock_bugzillatool.py:
        * Scripts/modules/patchcollection.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 29 Nov 2009 00:20:45 +0000 (00:20 +0000)]
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] CC webkit-bot-watchers whenever the bots touch bugs
        https://bugs.webkit.org/show_bug.cgi?id=31952

        The mailing list is open for anyone to subscribe.

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 29 Nov 2009 00:17:33 +0000 (00:17 +0000)]
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] style-queue should report style errors to bugzilla
        https://bugs.webkit.org/show_bug.cgi?id=31945

        Currently, we're just logging the style errors locally.  With this
        patch we'll actually log the errors to bugzilla.  Note: I plan to run
        with the "local-only" logging during development.

        * Scripts/modules/commands/queues.py:
        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sat, 28 Nov 2009 21:48:18 +0000 (21:48 +0000)]
2009-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Apply workaround for the limitation of VirtualFree with MEM_RELEASE to all ports running on Windows
        https://bugs.webkit.org/show_bug.cgi?id=31943

        * runtime/MarkStack.h:
        (JSC::MarkStack::MarkStackArray::shrinkAllocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 28 Nov 2009 18:27:29 +0000 (18:27 +0000)]
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] style-queue shouldn't reject patches from the commit-queue
        https://bugs.webkit.org/show_bug.cgi?id=31944

        Currently the style-queue subprocess gets confused and thinks its the
        commit-queue.  If the patch has an error, it rejects it from the
        commit-queue.  Instead, we should have style-queue specific logic.
        This patch doesn't add that logic, but it gives us a callback we can
        use to add that logic.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/landingsequence.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51460 268f45cc-cd09-0410-ab3c-d52691b4dbfc