WebKit-https.git
9 years agoMassive SVG rebaselining on Chromium after bug 77736 and al.
jchaffraix@webkit.org [Fri, 10 Feb 2012 19:16:39 +0000 (19:16 +0000)]
Massive SVG rebaselining on Chromium after bug 77736 and al.

Output trimmed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNRWT should categorize options in --help
timothy_horton@apple.com [Fri, 10 Feb 2012 18:50:53 +0000 (18:50 +0000)]
NRWT should categorize options in --help
https://bugs.webkit.org/show_bug.cgi?id=76221

Reviewed by Eric Seidel.

Use optparse's OptionGroup mechanism to logically group NRWT's options,
providing a better experience when scanning all the options.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: CodeGeneratorInspector.py: properly resolve output types of commands
commit-queue@webkit.org [Fri, 10 Feb 2012 18:39:58 +0000 (18:39 +0000)]
Web Inspector: CodeGeneratorInspector.py: properly resolve output types of commands
https://bugs.webkit.org/show_bug.cgi?id=78025

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-10
Reviewed by Vsevolod Vlasov.

Code for generating ad-hoc types is added. It was reused from event
generator part.

* inspector/CodeGeneratorInspector.py:
(Generator.process_event):
(Generator.process_command):
(Generator.resolve_type_and_generate_ad_hoc):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.get_type_name_fix):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.get_type_name_fix.NameFix):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.add_type):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceForwardListener):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceForwardListener.add_type_data):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceResolveContext):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceGenerateContext):
(Generator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [CustomPropertyNames] to [CustomEnumerateProperty]
haraken@chromium.org [Fri, 10 Feb 2012 18:28:34 +0000 (18:28 +0000)]
Rename [CustomPropertyNames] to [CustomEnumerateProperty]
https://bugs.webkit.org/show_bug.cgi?id=78351

Reviewed by Adam Barth.

This patch renames [CustomPropertyNames] to [CustomEnumerateProperty],
for clarification and for naming consistency with [CustomDeleteProperty].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):

* css/CSSStyleDeclaration.idl:
* dom/DOMStringMap.idl:
* page/DOMWindow.idl:
* page/History.idl:
* page/Location.idl:
* storage/Storage.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse underlying property set to refcount PropertySetCSSStyleDeclaration
antti@apple.com [Fri, 10 Feb 2012 18:22:24 +0000 (18:22 +0000)]
Use underlying property set to refcount PropertySetCSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=78257

Reviewed by Andreas Kling.

Clean up the PropertySetCSSStyleDeclaration refcounting. PropertySetCSSStyleDeclaration now
forwards the ref/deref to the underlying StylePropertySet.

Also made CSSComputedStyleDeclaration construction use the standard create() pattern.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::ref):
(WebCore):
(WebCore::CSSComputedStyleDeclaration::deref):
* css/CSSComputedStyleDeclaration.h:
(WebCore::CSSComputedStyleDeclaration::create):
(CSSComputedStyleDeclaration):
(WebCore):
* css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
* css/StylePropertySet.cpp:
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
* css/StylePropertySet.h:
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::highestEmbeddingAncestor):
(WebCore::ApplyStyleCommand::computedFontSize):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::init):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::backgroundColorInEffect):
* editing/Editor.cpp:
(WebCore::Editor::textDirectionForSelection):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::getComputedStyle):
* svg/SVGAnimateElement.cpp:
(WebCore::getPropertyValue):
* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::baseValueFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Fri, 10 Feb 2012 17:27:04 +0000 (17:27 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt:
The test is not finishing on windows so now we are waiting 30 seconds
before killing it. Replacing the SLOW keyword with TIMEOUT as it did
not help.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowin test_expectations and Skipped have duplicates
jchaffraix@webkit.org [Fri, 10 Feb 2012 17:19:17 +0000 (17:19 +0000)]
win test_expectations and Skipped have duplicates
https://bugs.webkit.org/show_bug.cgi?id=78260

Reviewed by Anders Carlsson.

* platform/win/test_expectations.txt: Remove duplicated entries
from this file. They were wrongly added to Skipped too and looking
at the comment in r103876, it's better to keep the Skipped entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix compiler warning in Visual Studio 2010 about TR1
commit-queue@webkit.org [Fri, 10 Feb 2012 16:32:12 +0000 (16:32 +0000)]
[Qt] Fix compiler warning in Visual Studio 2010 about TR1
https://bugs.webkit.org/show_bug.cgi?id=63642

Patch by Aron Rosenberg <arosenberg@logitech.com> on 2012-02-10
Reviewed by Simon Hausmann.

* JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Fri, 10 Feb 2012 15:41:46 +0000 (15:41 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-10

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [TextPrompt] TAB should complete suggestions up to their common prefix...
apavlov@chromium.org [Fri, 10 Feb 2012 15:41:41 +0000 (15:41 +0000)]
Web Inspector: [TextPrompt] TAB should complete suggestions up to their common prefix in Console
https://bugs.webkit.org/show_bug.cgi?id=78236

Reviewed by Vsevolod Vlasov.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype._completeCommonPrefix):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.prototype.tabKeyPressed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream graphics helper classes in WebKitSupport
rwlbuis@webkit.org [Fri, 10 Feb 2012 15:41:22 +0000 (15:41 +0000)]
[BlackBerry] Upstream graphics helper classes in WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=78278

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

* blackberry/WebKitSupport/SurfacePool.cpp: Added.
* blackberry/WebKitSupport/SurfacePool.h: Added.
* blackberry/WebKitSupport/TileIndex.h: Added.
* blackberry/WebKitSupport/TileIndexHash.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoYarr assert with regexp where alternative in *-quantified group matches empty
msaboff@apple.com [Fri, 10 Feb 2012 15:31:10 +0000 (15:31 +0000)]
Yarr assert with regexp where alternative in *-quantified group matches empty
https://bugs.webkit.org/show_bug.cgi?id=67752

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Added backtracking for the prior alternative if it matched
but didn't consume any input characters.

* yarr/YarrJIT.cpp:
(YarrOp): New jump.
(JSC::Yarr::YarrGenerator::generate): Emit conditional jump
when an alternative matches and no input was consumed.  Moved the
zero length match check for a set of alternatives to the alternative
code from the parentheses cases to the alternative end cases.
Converted the existing zero length checks in the parentheses cases
to runtime assertion checks.
(JSC::Yarr::YarrGenerator::backtrack): Link new jump to backtrack
to prior term.

LayoutTests:

Added new tests for alternatives that match without consuming
any input characters.

* fast/js/regexp-zero-length-alternatives-expected.txt: Added.
* fast/js/regexp-zero-length-alternatives.html: Added.
* fast/js/script-tests/regexp-zero-length-alternatives.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: implement undo for setOuterHTML via undo-ing nested primitive commands.
pfeldman@chromium.org [Fri, 10 Feb 2012 13:15:12 +0000 (13:15 +0000)]
Web Inspector: implement undo for setOuterHTML via undo-ing nested primitive commands.
https://bugs.webkit.org/show_bug.cgi?id=78346

Reviewed by Yury Semikhatsky.

Source/WebCore:

Tests: inspector/elements/undo-set-outer-html-2.html
       inspector/elements/undo-set-outer-html.html

* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::RemoveChildAction::RemoveChildAction):
(WebCore::DOMEditor::InsertBeforeAction::InsertBeforeAction):
(WebCore::DOMEditor::InsertBeforeAction::undo):
(WebCore::DOMEditor::RemoveAttributeAction::RemoveAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::SetAttributeAction):
(WebCore::DOMEditor::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::DOMEditor::SetOuterHTMLAction::perform):
(WebCore::DOMEditor::SetOuterHTMLAction::undo):
(DOMEditor::SetOuterHTMLAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::ReplaceWholeTextAction):
(DOMEditor::ReplaceChildNodeAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::ReplaceChildNodeAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::perform):
(WebCore::DOMEditor::ReplaceChildNodeAction::undo):
(WebCore):
(DOMEditor::SetNodeValueAction):
(WebCore::DOMEditor::SetNodeValueAction::SetNodeValueAction):
(WebCore::DOMEditor::SetNodeValueAction::perform):
(WebCore::DOMEditor::SetNodeValueAction::undo):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::setAttribute):
(WebCore::DOMEditor::removeAttribute):
(WebCore::DOMEditor::setOuterHTML):
(WebCore::DOMEditor::replaceWholeText):
(WebCore::DOMEditor::replaceChild):
(WebCore::DOMEditor::setNodeValue):
(WebCore::populateErrorString):
* inspector/DOMEditor.h:
(DOMEditor):
* inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
(WebCore):
(WebCore::DOMPatchSupport::DOMPatchSupport):
(WebCore::DOMPatchSupport::patchNode):
(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::insertBeforeAndMarkAsUsed):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):
* inspector/DOMPatchSupport.h:
(WebCore):
(DOMPatchSupport):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::toErrorString):
(WebCore):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::undo):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::undo):
* inspector/InspectorHistory.h:
(WebCore):
(Action):
(InspectorHistory):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setDocumentContent):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::toggleProperty):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):
* inspector/InspectorStyleSheet.h:
(InspectorStyle):
(InspectorStyleSheet):

LayoutTests:

* inspector/elements/set-outer-html-2-expected.txt:
* inspector/elements/set-outer-html-test.js:
(initialize_SetOuterHTMLTest.InspectorTest.patchOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.patchOuterHTMLUseUndo):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo.bringBack):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest._dumpOuterHTML.dumpIdentity):
(initialize_SetOuterHTMLTest.InspectorTest._dumpOuterHTML.callback):
(initialize_SetOuterHTMLTest.InspectorTest._dumpOuterHTML):
(initialize_SetOuterHTMLTest):
* inspector/elements/undo-dom-edits-expected.txt:
* inspector/elements/undo-set-outer-html-2-expected.txt: Copied from LayoutTests/inspector/elements/set-outer-html-2-expected.txt.
* inspector/elements/undo-set-outer-html-2.html: Added.
* inspector/elements/undo-set-outer-html-expected.txt: Copied from LayoutTests/inspector/elements/set-outer-html-2-expected.txt.
* inspector/elements/undo-set-outer-html.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Refactor on Qt5 Layout tests' structure
ossy@webkit.org [Fri, 10 Feb 2012 13:04:37 +0000 (13:04 +0000)]
[Qt][WK2] Refactor on Qt5 Layout tests' structure
https://bugs.webkit.org/show_bug.cgi?id=77450

* platform/qt-4.8/Skipped: Add after r107397, because it was missing accidentally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Refactor on Qt5 Layout tests' structure
ossy@webkit.org [Fri, 10 Feb 2012 12:48:04 +0000 (12:48 +0000)]
[Qt][WK2] Refactor on Qt5 Layout tests' structure
https://bugs.webkit.org/show_bug.cgi?id=77450

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-02-10
Reviewed by Csaba Osztrogon√°c.

Tools:

Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
to qt-5.0-wk2 and qt-5.0-wk1.

* Scripts/old-run-webkit-tests:
(buildPlatformResultHierarchy):
(readSkippedFiles):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._wk2_port_name):
(QtPort._skipped_file_search_paths):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_baseline_search_path):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._wk2_port_name):

LayoutTests:

The folders qt-wk2 and qt-wk1 have been renamed to qt-5.0-wk2 and qt-5.0-wk1, respectively,
and the skipped list from qt-wk1 has been copied into qt-4.8/Skipped.

* platform/qt-4.8/Skipped: Copy entries from platform/qt-wk1.
* platform/qt-5.0-wk1/: Renamed from platform/qt-wk1.
* platform/qt-5.0-wk2/: Renamed from platform/qt-wk1.
* platform/qt-wk1/: Removed.
* platform/qt-wk2/: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack]
haraken@chromium.org [Fri, 10 Feb 2012 12:38:28 +0000 (12:38 +0000)]
Replace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack]
https://bugs.webkit.org/show_bug.cgi?id=78327

Reviewed by Adam Barth.

This patch replaces [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack],
and removes [CustomArgumentHandling].

Test: bindings/scripts/test/TestObj.idl

* bindings/scripts/CodeGeneratorJS.pm: Modified to replace
[CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack].
(GenerateCallWith):
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateCallWith):
* bindings/scripts/CodeGeneratorGObject.pm: Ditto.
(SkipFunction):
(GenerateFunction):
* bindings/scripts/CodeGeneratorCPP.pm: Simply removed [CustomArgumentHandling]
from the skipped list. By this fix, CodeGeneratorCPP.pm will generate
meaningless code for attributes or methods which was previously marked as
[CustomArgumentHandling], but this change will be harmless.
(ShouldSkipType):

* bindings/v8/custom/V8ConsoleCustom.cpp: Changed the argument order.
(WebCore::V8Console::assertCallback):
* page/Console.cpp: Ditto.
(WebCore::Console::assertCondition):
(WebCore::Console::timeEnd):
* page/Console.h: Ditto.
(Console):

* bindings/scripts/test/TestObj.idl: Added test cases for [CallWith=ScriptArguments|CallStack].

* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::withScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::setWithScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::withScriptArgumentsAndCallStack):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_with_script_arguments_and_call_stack):
(webkit_dom_test_obj_get_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_set_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj withScriptArgumentsAndCallStackAttribute]):
(-[DOMTestObj setWithScriptArgumentsAndCallStackAttribute:]):
(-[DOMTestObj withScriptArgumentsAndCallStack]):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] KURL::fileSystemPath() doesn't work if uri contains #
carlosgc@webkit.org [Fri, 10 Feb 2012 11:51:05 +0000 (11:51 +0000)]
[GTK] KURL::fileSystemPath() doesn't work if uri contains #
https://bugs.webkit.org/show_bug.cgi?id=78339

Reviewed by Philippe Normand.

* platform/gtk/KURLGtk.cpp:
(WebCore::KURL::fileSystemPath): Use GFile API instead of
g_filename_from_uri() to convert the uri to a local
path. g_file_get_path() removes the anchor from the uri and
returns a valid path instead of NULL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCodeGeneratorJS doesn't always generate visitChildren() implementation when required
commit-queue@webkit.org [Fri, 10 Feb 2012 11:46:28 +0000 (11:46 +0000)]
CodeGeneratorJS doesn't always generate visitChildren() implementation when required
https://bugs.webkit.org/show_bug.cgi?id=78336

Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-10
Reviewed by Kentaro Hara.

In an IDL for an interface that declares no functions, but has
attributes with [CachedAttribute], the implementation of visitChildren()
is not generated by the JSC code generator.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterface::visitChildren):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerf-o-matic build fix after r107386.
rniwa@webkit.org [Fri, 10 Feb 2012 11:25:33 +0000 (11:25 +0000)]
Perf-o-matic build fix after r107386.

* Websites/webkit-perf.appspot.com/app.yaml:
* Websites/webkit-perf.appspot.com/controller.py:
(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):
* Websites/webkit-perf.appspot.com/merge_tests_handler.py:
(MergeTestsHandler.get):
* Websites/webkit-perf.appspot.com/report_logs_handler.py:
(ReportLogsHandler.get):
(ReportLogsHandler.post):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Fri, 10 Feb 2012 11:23:55 +0000 (11:23 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/Skipped:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline and skipping another svg test
philn@webkit.org [Fri, 10 Feb 2012 11:04:18 +0000 (11:04 +0000)]
Unreviewed, GTK rebaseline and skipping another svg test
presenting floating-point issues.

* platform/gtk/Skipped:
* platform/gtk/editing/execCommand/insertImage-expected.txt:
* platform/gtk/security/block-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] GC should be parallel on Qt platform
commit-queue@webkit.org [Fri, 10 Feb 2012 10:48:50 +0000 (10:48 +0000)]
[Qt] GC should be parallel on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=73309

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-02-10
Reviewed by Zoltan Herczeg.

These changes made the parallel gc feature available for Qt port.
The implementation of "registerGCThread" and "isMainThreadOrGCThread",
and a local static function [initializeGCThreads] is moved from
MainThreadMac.mm to the common MainThread.cpp to make them available
for other platforms.

Measurement results:
V8           speed-up:  1.025x as fast  [From: 663.4ms  To: 647.0ms ]
V8 Splay     speed-up:  1.185x as fast  [From: 138.4ms  To: 116.8ms ]

Tested on Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz with 4-core.

* JavaScriptCore.order:
* wtf/MainThread.cpp:
(WTF::initializeMainThread):
(WTF):
(WTF::initializeGCThreads):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):
* wtf/MainThread.h:
(WTF):
* wtf/Platform.h:
* wtf/mac/MainThreadMac.mm:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Increase JPEG decoding performance some more
noel.gordon@gmail.com [Fri, 10 Feb 2012 10:46:09 +0000 (10:46 +0000)]
[chromium] Increase JPEG decoding performance some more
https://bugs.webkit.org/show_bug.cgi?id=78323

Reviewed by Adam Barth.

Source/WebCore:

Increase JPEG image decoding speed by another 9% (avg) according to libjpeg-turbo tjbench.

No new tests. Covered by many existing tests, all requiring subsequent rebaselines.

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(dctMethod): Fast decode on the jpeg-turbo using ports (Chrome Android, Chrome, Chromium).
(WebCore::JPEGImageReader::decode): Select DCT method via a helper routine.

LayoutTests:

* platform/chromium/test_expectations.txt: tests containing jpeg images that will require
rebaselines, mostly together in a group, but some other expectations unattended to at the
current time, spread changes throughout the file.  The following lists changed tests for
chrome mac and win:

compositing/geometry/horizontal-scroll-composited.html
compositing/geometry/vertical-scroll-composited.html
compositing/overflow/overflow-scaled-descendant-overlapping.html
fast/backgrounds/size/backgroundSize17.html
fast/backgrounds/size/backgroundSize18.html
fast/backgrounds/size/backgroundSize19.html
fast/backgrounds/size/backgroundSize20.html
fast/backgrounds/size/backgroundSize21.html
fast/backgrounds/size/backgroundSize22.html
fast/block/float/014.html
fast/images/color-jpeg-with-color-profile.html
fast/images/gray-scale-jpeg-with-color-profile.html
fast/images/image-css3-content-data.html
fast/images/ycbcr-with-cmyk-color-profile.html
fast/repaint/backgroundSizeRepaint.html
fast/repaint/block-layout-inline-children-replaced.html
fast/repaint/clipped-relative.html
fast/repaint/selected-replaced.html
fast/replaced/absolute-image-sizing.html
fast/replaced/image-onload.html
fast/replaced/image-sizing.html
fast/replaced/image-tag.html
fast/replaced/width100percent-image.html
fast/writing-mode/background-horizontal-bt.html
fast/writing-mode/background-vertical-lr.html
fast/writing-mode/background-vertical-rl.html
platform/chromium/compositing/img-layer-grow.html
svg/W3C-SVG-1.1/animate-elem-30-t.svg
svg/W3C-SVG-1.1/animate-elem-36-t.svg
svg/W3C-SVG-1.1/animate-elem-39-t.svg
svg/W3C-SVG-1.1/animate-elem-40-t.svg
svg/W3C-SVG-1.1/coords-viewattr-02-b.svg
svg/W3C-SVG-1.1/filters-image-01-b.svg
svg/W3C-SVG-1.1/struct-image-01-t.svg
svg/W3C-SVG-1.1/struct-image-02-b.svg
svg/W3C-SVG-1.1/struct-image-04-t.svg
svg/carto.net/scrollbar.svg
svg/carto.net/selectionlist.svg
svg/custom/image-rescale-clip.html
svg/custom/image-rescale-scroll.html
svg/custom/image-rescale.svg
svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html
svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html
tables/mozilla/bugs/bug101674.html
tables/mozilla/bugs/bug10565.html
tables/mozilla/bugs/bug11026.html
tables/mozilla/bugs/bug1188.html
tables/mozilla/bugs/bug120107.html
tables/mozilla/bugs/bug1271.html
tables/mozilla/bugs/bug12908-1.html
tables/mozilla/bugs/bug12908-2.html
tables/mozilla/bugs/bug1296.html
tables/mozilla/bugs/bug13169.html
tables/mozilla/bugs/bug1430.html
tables/mozilla/bugs/bug15544.html
tables/mozilla/bugs/bug17138.html
tables/mozilla/bugs/bug196870.html
tables/mozilla/bugs/bug29314.html
tables/mozilla/bugs/bug2981-2.html
tables/mozilla/bugs/bug4093.html
tables/mozilla/bugs/bug4284.html
tables/mozilla/bugs/bug4427.html
tables/mozilla/bugs/bug50695-2.html
tables/mozilla/bugs/bug56563.html
tables/mozilla/bugs/bug5797.html
tables/mozilla/bugs/bug625.html
tables/mozilla/bugs/bug6404.html
tables/mozilla/bugs/bug82946-2.html
tables/mozilla/bugs/bug86708.html
tables/mozilla/core/bloomberg.html
tables/mozilla/core/col_widths_auto_autoFix.html
tables/mozilla/core/misc.html
tables/mozilla/core/row_span.html
tables/mozilla/marvin/tbody_valign_baseline.html
tables/mozilla/marvin/tbody_valign_bottom.html
tables/mozilla/marvin/tbody_valign_middle.html
tables/mozilla/marvin/tbody_valign_top.html
tables/mozilla/marvin/td_valign_baseline.html
tables/mozilla/marvin/td_valign_bottom.html
tables/mozilla/marvin/td_valign_middle.html
tables/mozilla/marvin/td_valign_top.html
tables/mozilla/marvin/tfoot_valign_baseline.html
tables/mozilla/marvin/tfoot_valign_bottom.html
tables/mozilla/marvin/tfoot_valign_middle.html
tables/mozilla/marvin/tfoot_valign_top.html
tables/mozilla/marvin/th_valign_baseline.html
tables/mozilla/marvin/th_valign_bottom.html
tables/mozilla/marvin/th_valign_middle.html
tables/mozilla/marvin/th_valign_top.html
tables/mozilla/marvin/thead_valign_baseline.html
tables/mozilla/marvin/thead_valign_bottom.html
tables/mozilla/marvin/thead_valign_middle.html
tables/mozilla/marvin/thead_valign_top.html
tables/mozilla/marvin/tr_valign_baseline.html
tables/mozilla/marvin/tr_valign_bottom.html
tables/mozilla/marvin/tr_valign_middle.html
tables/mozilla/marvin/tr_valign_top.html
tables/mozilla/other/cell_widths.html
tables/mozilla_expected_failures/bugs/bug6933.html
tables/mozilla_expected_failures/bugs/bug85016.html
tables/mozilla_expected_failures/other/test4.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rebaseline svg/carto.net/selectionlist.svg.
podivilov@chromium.org [Fri, 10 Feb 2012 10:10:18 +0000 (10:10 +0000)]
Unreviewed, rebaseline svg/carto.net/selectionlist.svg.

* platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt: Removed.
* platform/chromium-win-xp/svg/carto.net/selectionlist-expected.png: Removed.
* platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rebaseline svg/carto.net/scrollbar-expected.png on chromium mac.
podivilov@chromium.org [Fri, 10 Feb 2012 10:02:14 +0000 (10:02 +0000)]
Unreviewed, rebaseline svg/carto.net/scrollbar-expected.png on chromium mac.

* platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
* platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt:
* platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.txt: Copied from LayoutTests/platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt.
* platform/mac/svg/carto.net/scrollbar-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerf-o-matic should process reports in background
rniwa@webkit.org [Fri, 10 Feb 2012 09:56:08 +0000 (09:56 +0000)]
Perf-o-matic should process reports in background
https://bugs.webkit.org/show_bug.cgi?id=78309

Reviewed by Hajime Morita.

Split the logic to create Build, Test, and TestResult objects from ReportHandler into ReportProcessHandler.
ReportHandler now merely creates ReportLog and schedules a task to process it.

Also added ReportLogHandler to manage stale ReportLogs.

* Websites/webkit-perf.appspot.com/app.yaml:
* Websites/webkit-perf.appspot.com/controller.py:
(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):
(CachedRunsHandler.get):
(schedule_report_process):
* Websites/webkit-perf.appspot.com/main.py:
* Websites/webkit-perf.appspot.com/merge_tests.html: Renamed from Websites/webkit-perf.appspot.com/merge_tests.yaml.
* Websites/webkit-perf.appspot.com/models.py:
(ReportLog):
(ReportLog._parsed_payload):
(ReportLog.get_value):
(ReportLog.results):
(ReportLog.builder):
(ReportLog.branch):
(ReportLog.platform):
(ReportLog.build_number):
(ReportLog.webkit_revision):
(ReportLog.chromium_revision):
(ReportLog._model_by_key_name_in_payload):
(ReportLog._integer_in_payload):
(ReportLog.timestamp):
* Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post):
(ReportHandler._output):
(ReportHandler._results_are_valid):
(ReportHandler._results_are_valid._is_float_convertible):
(ReportHandler):
* Websites/webkit-perf.appspot.com/report_logs.html: Added.
* Websites/webkit-perf.appspot.com/report_logs_handler.py: Added.
(ReportLogsHandler):
(ReportLogsHandler.get):
(ReportLogsHandler.post):
(ReportLogsHandler._error):
* Websites/webkit-perf.appspot.com/report_process_handler.py: Copied from Websites/webkit-perf.appspot.com/report_handler.py.
(ReportProcessHandler):
(ReportProcessHandler.post):
(ReportProcessHandler._create_build_if_possible):
(ReportProcessHandler._create_build_if_possible.execute):
(ReportProcessHandler._add_test_if_needed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test fix following r107373.
caseq@chromium.org [Fri, 10 Feb 2012 09:41:20 +0000 (09:41 +0000)]
Unreviewed test fix following r107373.
https://bugs.webkit.org/show_bug.cgi?id=78254

This also resolves https://bugs.webkit.org/show_bug.cgi?id=77416.

* inspector/timeline/timeline-receive-response-event.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: FileSelector should not depend on DebuggerPresentationModel.
vsevik@chromium.org [Fri, 10 Feb 2012 09:34:33 +0000 (09:34 +0000)]
Web Inspector: FileSelector should not depend on DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=78337

Reviewed by Pavel Feldman.

* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype.reset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.FileSelector.prototype.replaceUISourceCodes):
(WebInspector.ScriptsPanel.FileSelector.prototype.reset):
(WebInspector.ScriptsPanel.ComboBoxFileSelector):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed attempt to fix the test failure.
morrita@google.com [Fri, 10 Feb 2012 09:29:43 +0000 (09:29 +0000)]
Unreviewed attempt to fix the test failure.

* editing/spelling/spelling-marker-description.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove [ConvertingNullStringTo] from CloseEvent.idl
haraken@chromium.org [Fri, 10 Feb 2012 09:28:05 +0000 (09:28 +0000)]
Remove [ConvertingNullStringTo] from CloseEvent.idl
https://bugs.webkit.org/show_bug.cgi?id=78328

Reviewed by Adam Barth.

In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo],
(although in bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]).

Anyway, the spec says that "The reason attribute must return the value it was
initialized to. When the object is created, this attribute must be initialized to empty string."
http://dev.w3.org/html5/websockets/#event-definitions
Thus, this patch removes [ConvertingNullStringTo] from CloseEvent.idl.

Test: fast/events/constructors/close-event-constructor.html

* websockets/CloseEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-10 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 10 Feb 2012 09:13:36 +0000 (09:13 +0000)]
2012-02-10  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, fix error in test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode
pfeldman@chromium.org [Fri, 10 Feb 2012 09:06:04 +0000 (09:06 +0000)]
[Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode
https://bugs.webkit.org/show_bug.cgi?id=78330

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchChildren):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* platform/chromium-mac/storage/domstorage/quota-expected.txt: Removed.
abarth@webkit.org [Fri, 10 Feb 2012 09:04:15 +0000 (09:04 +0000)]
* platform/chromium-mac/storage/domstorage/quota-expected.txt: Removed.
* platform/chromium-win/storage/domstorage/quota-expected.txt: Removed.
    - These baselines are wrong.  Removing them shows that we pass this
      test now.
* platform/chromium/test_expectations.txt:
    - According to the flakiness dashboard, these tests always pass now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Skip new asserting tests to paint the debug bot green.
ossy@webkit.org [Fri, 10 Feb 2012 08:56:00 +0000 (08:56 +0000)]
[Qt] Unreviewed gardening. Skip new asserting tests to paint the debug bot green.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate a large number of baselines for svg/custom. These baselines all
abarth@webkit.org [Fri, 10 Feb 2012 08:52:25 +0000 (08:52 +0000)]
Update a large number of baselines for svg/custom.  These baselines all
appear to be correct (or at least no less correct than the previous
baselines).  There are a number of svg/custom tests that appear to be
actually failing, which I haven't rebaselined.

This patch does not update the test_expectations.txt file.  Once this
patch has cycled through the bots, I'll clean up the expectations file
as appropriate.

* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-linux/svg/custom/SVGPoint-matrixTransform-expected.png:
* platform/chromium-linux/svg/custom/absolute-root-position-masking-expected.png: Added.
* platform/chromium-linux/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
* platform/chromium-linux/svg/custom/getTransformToElement-expected.png:
* platform/chromium-linux/svg/custom/gradient-stroke-width-expected.png:
* platform/chromium-linux/svg/custom/js-update-style-expected.txt: Removed.
* platform/chromium-linux/svg/custom/marker-changes-expected.png: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.png:
* platform/chromium-linux/svg/custom/text-ctm-expected.png:
* platform/chromium-linux/svg/custom/text-hit-test-expected.png:
* platform/chromium-linux/svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
* platform/chromium-linux/svg/custom/use-font-face-crash-expected.png: Added.
* platform/chromium-linux/svg/custom/use-property-changes-through-svg-dom-expected.png:
* platform/chromium-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png:
* platform/chromium-mac-leopard/svg/custom/createImageElement2-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
* platform/chromium-mac-leopard/svg/custom/getTransformToElement-expected.png:
* platform/chromium-mac-leopard/svg/custom/path-bad-data-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/path-bad-data-expected.txt: Added.
* platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/svg-fonts-fallback-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/use-font-face-crash-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/use-font-face-crash-expected.txt: Added.
* platform/chromium-mac-leopard/svg/custom/use-invalid-pattern-expected.txt: Added.
* platform/chromium-mac-leopard/svg/custom/use-invalid-style-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/absolute-root-position-masking-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/getTransformToElement-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/gradient-stroke-width-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/path-bad-data-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/pointer-events-text-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/repaint-on-image-bounds-change-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-fallback-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-font-face-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-forward-refs-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Added.
* platform/chromium-mac/svg/custom/gradient-stroke-width-expected.png: Removed.
* platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png: Removed.
* platform/chromium-mac/svg/custom/pointer-events-image-expected.png: Removed.
* platform/chromium-mac/svg/custom/pointer-events-text-expected.png: Removed.
* platform/chromium-mac/svg/custom/svg-fonts-fallback-expected.png: Removed.
* platform/chromium-mac/svg/custom/svg-fonts-without-missing-glyph-expected.png: Removed.
* platform/chromium-mac/svg/custom/use-font-face-crash-expected.png: Removed.
* platform/chromium-mac/svg/custom/use-forward-refs-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
* platform/chromium-win/svg/custom/SVGPoint-matrixTransform-expected.png:
* platform/chromium-win/svg/custom/SVGPoint-matrixTransform-expected.txt:
* platform/chromium-win/svg/custom/absolute-root-position-masking-expected.png: Added.
* platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
* platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.txt:
* platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
* platform/chromium-win/svg/custom/getTransformToElement-expected.png:
* platform/chromium-win/svg/custom/getTransformToElement-expected.txt:
* platform/chromium-win/svg/custom/gradient-stroke-width-expected.png:
* platform/chromium-win/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
* platform/chromium-win/svg/custom/grayscale-gradient-mask-expected.png:
* platform/chromium-win/svg/custom/linking-uri-01-b-expected.png:
* platform/chromium-win/svg/custom/marker-changes-expected.png: Added.
* platform/chromium-win/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
* platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
* platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
* platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
* platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
* platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.txt:
* platform/chromium-win/svg/custom/pointer-events-image-expected.txt:
* platform/chromium-win/svg/custom/pointer-events-text-expected.txt:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/chromium-win/svg/custom/text-ctm-expected.png:
* platform/chromium-win/svg/custom/text-ctm-expected.txt:
* platform/chromium-win/svg/custom/text-hit-test-expected.png:
* platform/chromium-win/svg/custom/text-hit-test-expected.txt:
* platform/chromium-win/svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
* platform/chromium-win/svg/custom/use-font-face-crash-expected.png: Added.
* platform/chromium-win/svg/custom/use-font-face-crash-expected.txt: Added.
* platform/chromium-win/svg/custom/use-forward-refs-expected.png:
* platform/chromium/svg/custom/js-update-style-expected.txt: Removed.
* platform/gtk/svg/custom/absolute-root-position-masking-expected.txt: Removed.
* platform/gtk/svg/custom/gradient-stroke-width-expected.txt: Removed.
* platform/gtk/svg/custom/grayscale-gradient-mask-2-expected.txt: Removed.
* platform/gtk/svg/custom/repaint-on-image-bounds-change-expected.txt: Removed.
* platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
* platform/gtk/svg/custom/use-forward-refs-expected.txt: Removed.
* platform/gtk/svg/custom/use-invalid-style-expected.txt: Removed.
* platform/gtk/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
* platform/mac/svg/custom/absolute-root-position-masking-expected.png: Removed.
* platform/mac/svg/custom/absolute-root-position-masking-expected.txt: Removed.
* platform/mac/svg/custom/gradient-stroke-width-expected.txt: Removed.
* platform/mac/svg/custom/grayscale-gradient-mask-2-expected.txt: Removed.
* platform/mac/svg/custom/repaint-on-image-bounds-change-expected.txt: Removed.
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
* platform/mac/svg/custom/use-forward-refs-expected.txt: Removed.
* platform/mac/svg/custom/use-invalid-style-expected.txt: Removed.
* platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
* platform/qt/svg/custom/absolute-root-position-masking-expected.png: Removed.
* platform/qt/svg/custom/absolute-root-position-masking-expected.txt: Removed.
* platform/qt/svg/custom/gradient-stroke-width-expected.txt: Removed.
* platform/qt/svg/custom/grayscale-gradient-mask-2-expected.txt: Removed.
* platform/qt/svg/custom/repaint-on-image-bounds-change-expected.txt: Removed.
* platform/qt/svg/custom/use-forward-refs-expected.txt: Removed.
* platform/qt/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
* svg/custom/absolute-root-position-masking-expected.png: Added.
* svg/custom/absolute-root-position-masking-expected.txt: Added.
* svg/custom/gradient-stroke-width-expected.txt: Added.
* svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
* svg/custom/repaint-on-image-bounds-change-expected.txt: Added.
* svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
* svg/custom/use-forward-refs-expected.txt: Added.
* svg/custom/use-invalid-style-expected.txt: Added.
* svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-10 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 10 Feb 2012 08:32:54 +0000 (08:32 +0000)]
2012-02-10  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, gardening, mark editing/spelling/spelling-marker-description.html as failing.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate baselines for svg/batik. These baselines either look quite
abarth@webkit.org [Fri, 10 Feb 2012 08:21:01 +0000 (08:21 +0000)]
Update baselines for svg/batik.  These baselines either look quite
similar to the previous baselines or look like improvements (e.g., text
masking seems to work now).

* platform/chromium-linux/svg/batik/masking/maskRegions-expected.png: Added.
* platform/chromium-linux/svg/batik/text/textEffect-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
* platform/chromium-linux/svg/batik/text/xmlSpace-expected.png:
* platform/chromium-linux/svg/batik/text/xmlSpace-expected.txt: Added.
* platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textEffect-expected.png: Added.
* platform/chromium-mac-leopard/svg/batik/text/textEffect3-expected.png: Added.
* platform/chromium-mac-leopard/svg/batik/text/textProperties-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/xmlSpace-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect3-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/xmlSpace-expected.png: Added.
* platform/chromium-mac/svg/batik/filters: Removed.
* platform/chromium-mac/svg/batik/filters/feTile-expected.png: Removed.
* platform/chromium-mac/svg/batik/text/textStyles-expected.png: Removed.
* platform/chromium-mac/svg/batik/text/verticalText-expected.png: Removed.
* platform/chromium-mac/svg/batik/text/xmlSpace-expected.png: Removed.
* platform/chromium-win-xp/svg/batik/masking: Removed.
* platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
* platform/chromium-win/svg/batik/filters/feTile-expected.png:
* platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-win/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
* platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-win/svg/batik/text/textAnchor-expected.png:
* platform/chromium-win/svg/batik/text/textEffect-expected.png:
* platform/chromium-win/svg/batik/text/textEffect-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect3-expected.png:
* platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
* platform/chromium-win/svg/batik/text/textFeatures-expected.png:
* platform/chromium-win/svg/batik/text/textLayout-expected.png:
* platform/chromium-win/svg/batik/text/textPCDATA-expected.png:
* platform/chromium-win/svg/batik/text/textProperties-expected.png:
* platform/chromium-win/svg/batik/text/textProperties2-expected.png:
* platform/chromium-win/svg/batik/text/textStyles-expected.png:
* platform/chromium-win/svg/batik/text/verticalText-expected.png:
* platform/chromium-win/svg/batik/text/xmlSpace-expected.png:
* platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] EWS command-line option to run the tests
philn@webkit.org [Fri, 10 Feb 2012 08:05:53 +0000 (08:05 +0000)]
[GTK] EWS command-line option to run the tests
https://bugs.webkit.org/show_bug.cgi?id=78211

Reviewed by Adam Barth.

New --run-tests option (defaults to False) for the EWS commands.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.__init__):
(AbstractEarlyWarningSystem.review_patch):
(ChromiumLinuxEWS):
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSytemTest._test_builder_ews):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [refactoring] TimelineModel should not depend on TimelinePanel
caseq@chromium.org [Fri, 10 Feb 2012 08:05:49 +0000 (08:05 +0000)]
Web Inspector: [refactoring] TimelineModel should not depend on TimelinePanel
https://bugs.webkit.org/show_bug.cgi?id=78254

Reviewed by Yury Semikhatsky.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._loadFromFile):
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype.startRecord):
(WebInspector.TimelineModel.prototype.stopRecord):
(WebInspector.TimelineModel.prototype._onRecordAdded):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype._loadNextChunk):
(WebInspector.TimelineModel.prototype._loadFromFile):
(WebInspector.TimelineModel.prototype._reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening after r107289.
ossy@webkit.org [Fri, 10 Feb 2012 07:58:54 +0000 (07:58 +0000)]
Unreviewed gardening after r107289.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r107368.
haraken@chromium.org [Fri, 10 Feb 2012 07:55:36 +0000 (07:55 +0000)]
Unreviewed, rolling out r107368.
http://trac.webkit.org/changeset/107368
https://bugs.webkit.org/show_bug.cgi?id=78327

break GTK build

* bindings/scripts/CodeGeneratorCPP.pm:
(ShouldSkipType):
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction):
(GenerateFunction):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
(GenerateCallWith):
(GenerateFunctionCallString):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj customArgsAndException:]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(TestObjInternal):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
* bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::assertCallback):
* page/Console.cpp:
(WebCore::Console::assertCondition):
(WebCore::Console::timeEnd):
* page/Console.h:
(Console):
* page/Console.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate baselines for W3C-SVG-1.1-SE. These new baselines all appear to
abarth@webkit.org [Fri, 10 Feb 2012 07:55:09 +0000 (07:55 +0000)]
Update baselines for W3C-SVG-1.1-SE.  These new baselines all appear to
be correct.

* platform/chromium-linux/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
* platform/chromium/test_expectations.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
* platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
* platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
* platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
* platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
* platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
* platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
* platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
* svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
* svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
* svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
* svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
* svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHeap-buffer-overflow in WebCore::CSSParser::lex
zherczeg@webkit.org [Fri, 10 Feb 2012 07:49:35 +0000 (07:49 +0000)]
Heap-buffer-overflow in WebCore::CSSParser::lex
https://bugs.webkit.org/show_bug.cgi?id=77402

Reviewed by Antti Koivisto.

Source/WebCore:

Comments should check only a single \0 terminator.

Test: fast/css/parsing-css-comment.html

* css/CSSParser.cpp:
(WebCore::CSSParser::lex):

LayoutTests:

Test various comment types.

* fast/css/parsing-css-comment-expected.txt: Added.
* fast/css/parsing-css-comment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack]
haraken@chromium.org [Fri, 10 Feb 2012 07:38:15 +0000 (07:38 +0000)]
Replace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack]
https://bugs.webkit.org/show_bug.cgi?id=78327

Reviewed by Adam Barth.

This patch replaces [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack],
and removes [CustomArgumentHandling].

Test: bindings/scripts/test/TestObj.idl

* bindings/scripts/CodeGeneratorJS.pm: Modified to replace
[CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack].
(GenerateCallWith):
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateCallWith):
* bindings/scripts/CodeGeneratorCPP.pm: Simply removed [CustomArgumentHandling]
from the skipped list. By this fix, CodeGeneratorCPP.pm will generate
meaningless code for attributes or methods which was previously marked as
[CustomArgumentHandling], but this change will be harmless.
(ShouldSkipType):
* bindings/scripts/CodeGeneratorGObject.pm: Ditto.
(SkipFunction):
(GenerateFunction):

* bindings/v8/custom/V8ConsoleCustom.cpp: Changed the argument order.
(WebCore::V8Console::assertCallback):
* page/Console.cpp: Ditto.
(WebCore::Console::assertCondition):
(WebCore::Console::timeEnd):
* page/Console.h: Ditto.
(Console):

* bindings/scripts/test/TestObj.idl: Added test cases for [CallWith=ScriptArguments|CallStack].

* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::withScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::setWithScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::withScriptArgumentsAndCallStack):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_with_script_arguments_and_call_stack):
(webkit_dom_test_obj_get_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_set_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj withScriptArgumentsAndCallStackAttribute]):
(-[DOMTestObj setWithScriptArgumentsAndCallStackAttribute:]):
(-[DOMTestObj withScriptArgumentsAndCallStack]):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDromaeo/dom-traverse.html should go fast
abarth@webkit.org [Fri, 10 Feb 2012 07:09:50 +0000 (07:09 +0000)]
Dromaeo/dom-traverse.html should go fast
https://bugs.webkit.org/show_bug.cgi?id=78307

Reviewed by Eric Seidel.

This patch improves Dromaeo/dom-traverse.html by roughly 2.5% by
removing a branch.  Previously, we null-checked the result of
V8DOMWrapper::getWrapper in a hot code path, but the only case where we
return a non-empty wrapper comes from a cold code path.  By pushing the
null check into the cold codepath, we eliminate the branch from the
hot code path.

This patch also annotates the branches in the hot code path with their
likely outcome.  I didn't measure a statistically significant
improvement with that aspect of the change, but it seems worthwhile.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::getExistingWrapperInline):
(WebCore):
(WebCore::V8DOMWrapper::getExistingWrapperSlow):
(WebCore::V8DOMWrapper::getWrapperSlow):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getExistingWrapper):
(V8DOMWrapper):
(WebCore::V8DOMWrapper::getWrapper):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert Frame/FrameView to LayoutUnits in preparation for turning on subpixel layout
eae@chromium.org [Fri, 10 Feb 2012 07:07:21 +0000 (07:07 +0000)]
Convert Frame/FrameView to LayoutUnits in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=78311

Reviewed by Eric Seidel.

No new tests, no new functionality.

* page/Frame.cpp:
(WebCore::Frame::nodeImage):
Pixel snap painting rect for image to ensure that it is painted aligned
to device pixels. This avoids avoid unwanted anti-aliasing.

* page/FrameView.cpp:
(WebCore::FrameView::windowClipRectForLayer):
Pixel snap clip rects as all window coordinates and sizes are exposed as
integers.

* page/GestureTapHighlighter.cpp:
* page/Page.cpp:
(WebCore::Page::addRelevantRepaintedObject):
As the painting is done aligned on pixel boundaries we need to pixel snap
the view rect when checking if it intersects the objects paint rect.

* page/mac/FrameMac.mm:
(WebCore::Frame::snapshotDragImage):
(WebCore::Frame::nodeImage):
Pixel snap painting rect for image to ensure that it is painted aligned
to device pixels. This avoids avoid unwanted anti-aliasing.

* page/win/FrameCGWin.cpp:
(WebCore::Frame::nodeImage):
Pixel snap painting rect for image to ensure that it is painted aligned
to device pixels. This avoids avoid unwanted anti-aliasing.

* rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntRect):
(WebCore):
No-op implementation of pixelSnappedIntRect for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WebSocket extension support
bashi@chromium.org [Fri, 10 Feb 2012 06:44:29 +0000 (06:44 +0000)]
Add WebSocket extension support
https://bugs.webkit.org/show_bug.cgi?id=78079

Source/WebCore:

This patch introduces WebSocketExtensionDispatcher class, which creates client's
Sec-WebSocket-Extensions header field and parses the server response.
This patch doesn't add any actual extension, so no changes in behavior.

Reviewed by Kent Tamura.

No new tests except for chromium port.

* CMakeLists.txt: Added WebSocketExtensionDispatcher.(cpp|h) and WebSocketExtensionProcessor.h.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* websockets/WebSocketExtensionDispatcher.cpp: Added.
(WebCore):
(ExtensionParser):
(WebCore::ExtensionParser::ExtensionParser):
(WebCore::ExtensionParser::currentToken):
(WebCore::ExtensionParser::finished):
(WebCore::ExtensionParser::parsedSuccessfully):
(WebCore::isTokenCharacter):
(WebCore::isSeparator):
(WebCore::ExtensionParser::skipSpaces):
(WebCore::ExtensionParser::consumeToken):
(WebCore::ExtensionParser::consumeQuotedString):
(WebCore::ExtensionParser::consumeQuotedStringOrToken):
(WebCore::ExtensionParser::consumeCharacter):
(WebCore::WebSocketExtensionDispatcher::reset):
(WebCore::WebSocketExtensionDispatcher::addProcessor):
(WebCore::WebSocketExtensionDispatcher::createHeaderValue):
(WebCore::WebSocketExtensionDispatcher::processHeaderValue):
(WebCore::WebSocketExtensionDispatcher::failureReason):
* websockets/WebSocketExtensionDispatcher.h: Added.
(WebCore):
(WebSocketExtensionDispatcher):
(WebCore::WebSocketExtensionDispatcher::WebSocketExtensionDispatcher):
* websockets/WebSocketExtensionProcessor.h: Added.
(WebCore):
(WebSocketExtensionProcessor):
(WebCore::WebSocketExtensionProcessor::~WebSocketExtensionProcessor):
(WebCore::WebSocketExtensionProcessor::extensionToken):
(WebCore::WebSocketExtensionProcessor::failureReason):
(WebCore::WebSocketExtensionProcessor::WebSocketExtensionProcessor):
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeMessage): Adds extension header value if exists.
(WebCore::WebSocketHandshake::clientHandshakeRequest): Ditto.
(WebCore::WebSocketHandshake::reset): Resets WebSocketExtensionDispatcher object.
(WebCore::WebSocketHandshake::serverHandshakeResponse): Removed.
(WebCore::WebSocketHandshake::addExtensionProcessor): Added.
(WebCore::WebSocketHandshake::readHTTPHeaders): Parses and checks every time Sec-WebSocket-Extensions header appears.
(WebCore::WebSocketHandshake::checkResponseHeaders): Removed the check of Sec-WebSocket-Extensions.
* websockets/WebSocketHandshake.h: Removed serverHandshakeResponse().

Source/WebKit/chromium:

Add some tests which check WebSocketExtensions::processHeaderValue()
parses the given response correctly.

Reviewed by Kent Tamura.

* WebKit.gypi:
* tests/WebSocketExtensionDispatcherTest.cpp: Added.
(WebCore):
(MockWebSocketExtensionProcessor):
(WebCore::MockWebSocketExtensionProcessor::MockWebSocketExtensionProcessor):
(WebSocketExtensionDispatcherTest):
(WebCore::WebSocketExtensionDispatcherTest::WebSocketExtensionDispatcherTest):
(WebCore::WebSocketExtensionDispatcherTest::SetUp):
(WebCore::WebSocketExtensionDispatcherTest::TearDown):
(WebCore::WebSocketExtensionDispatcherTest::addMockProcessor):
(WebCore::WebSocketExtensionDispatcherTest::appendResult):
(WebCore::MockWebSocketExtensionProcessor::processResponse):
(WebCore::TEST_F):

LayoutTests:

Reviewed by Kent Tamura.

* http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt: Rebaselined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAvoid compositing invisible fixed positioned elements
wangxianzhu@chromium.org [Fri, 10 Feb 2012 06:34:52 +0000 (06:34 +0000)]
Avoid compositing invisible fixed positioned elements
https://bugs.webkit.org/show_bug.cgi?id=78186

Reviewed by James Robinson.

Source/WebCore:

Test: compositing/layer-creation/fixed-position-out-of-view.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

* compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
* compositing/layer-creation/fixed-position-out-of-view.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update compositing test baselines for mock scrollbars
jamesr@google.com [Fri, 10 Feb 2012 06:26:38 +0000 (06:26 +0000)]
[chromium] Update compositing test baselines for mock scrollbars

* platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-mac/compositing/direct-image-compositing-expected.png: Added.
* platform/chromium-mac/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-mac/compositing/iframes/iframe-copy-on-scroll-expected.png:
* platform/chromium-mac/compositing/masks/multiple-masks-expected.png:
* platform/chromium-mac/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-mac/compositing/overflow/overflow-scroll-expected.png:
* platform/chromium-mac/compositing/overflow/scrollbar-painting-expected.png:
* platform/chromium-win/compositing/direct-image-compositing-expected.png:
* platform/chromium-win/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-win/compositing/iframes/iframe-copy-on-scroll-expected.png:
* platform/chromium-win/compositing/masks/multiple-masks-expected.png:
* platform/chromium-win/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-win/compositing/overflow/overflow-scroll-expected.png:
* platform/chromium-win/compositing/overflow/scrollbar-painting-expected.png:
* platform/chromium-win/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPrevent attaching when inspecting the Web Inspector.
timothy@apple.com [Fri, 10 Feb 2012 06:23:49 +0000 (06:23 +0000)]
Prevent attaching when inspecting the Web Inspector.

Source/WebCore:

https://webkit.org/b/78304

Reviewed by Brian Weinstein.

* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::canAttachWindow): Prevent attaching when the page is an inspector page.

Source/WebKit2:

Also adds some comments about keeping in sync with InspectorFrontendClientLocal::canAttachWindow
and why there are two implementations of the same function.

https://webkit.org/b/78304

Reviewed by Brian Weinstein.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::canAttach): Prevent attaching when the page is an inspector page.
Added comments about InspectorFrontendClientLocal::canAttachWindow.
* UIProcess/WebInspectorProxy.h:
(WebInspectorProxy): Added comment about keeping in sync with InspectorFrontendClientLocal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename compare_text and compare_audio to make it clear that they're !=
eric@webkit.org [Fri, 10 Feb 2012 06:18:09 +0000 (06:18 +0000)]
Rename compare_text and compare_audio to make it clear that they're !=
https://bugs.webkit.org/show_bug.cgi?id=78301

Reviewed by Adam Barth.

I also removed the maybe_create_directory function which was redundant.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.set_up_run):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter._make_output_directory):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.do_text_results_differ):
(Port.do_audio_results_differ):
(Port.diff_text):
(Port.driver_name):
(Port.skips_perf_test):
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort.do_text_results_differ):
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest.test_do_text_results_differ):
* Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd.__init__):
* Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase.__init__):
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
(Rebaseliner._diff_baselines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Assertion failure minX <= maxX in Region.cpp
commit-queue@webkit.org [Fri, 10 Feb 2012 06:08:40 +0000 (06:08 +0000)]
[Chromium] Assertion failure minX <= maxX in Region.cpp
https://bugs.webkit.org/show_bug.cgi?id=78038

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-09
Reviewed by James Robinson.

Covered by existing tests (should make them stop asserting).

Clamp sizes for composited layers coming out of WebCore to make sure they are valid non-negative values.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoManaged network proxy settings are not used in WebProcess
ap@apple.com [Fri, 10 Feb 2012 05:59:03 +0000 (05:59 +0000)]
Managed network proxy settings are not used in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=78288
<rdar://problem/9962116>

Reviewed by Anders Carlsson.

* WebProcess/com.apple.WebProcess.sb: Allow reading managed preferences.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake WebGLRenderingContext::printWarningToConsole safer
commit-queue@webkit.org [Fri, 10 Feb 2012 05:58:51 +0000 (05:58 +0000)]
Make WebGLRenderingContext::printWarningToConsole safer
https://bugs.webkit.org/show_bug.cgi?id=78284

Patch by Gregg Tavares <gman@google.com> on 2012-02-09
Reviewed by Kenneth Russell.

No new tests because no change in functionality.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add support for starting page/scale animations on CC impl thread from...
wjmaclean@chromium.org [Fri, 10 Feb 2012 05:51:57 +0000 (05:51 +0000)]
[chromium] Add support for starting page/scale animations on CC impl thread from WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=77872

Reviewed by James Robinson.

Source/WebCore:

Added unit test.

Provides a pathway to invoke CCLayerTreeHostImpl::startPageScaleAnimation() from
WebViewImpl. This is intended to support scale and scroll animations, such as WebInputEvent::GestureDoubleTap.

* platform/CrossThreadCopier.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::startPageScaleAnimation):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::startPageScaleAnimation):
(WebCore):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::startPageScaleAnimation):
(WebCore):
(WebCore::CCThreadProxy::requestStartPageScaleAnimationOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

Provides a pathway to invoke CCLayerTreeHostImpl::startPageScaleAnimation() from
WebViewImpl. This is intended to support scale and scroll animations, such as WebInputEvent::GestureDoubleTap.

* src/WebViewImpl.cpp:
(WebKit):
(WebKit::WebViewImpl::startPageScaleAnimation):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestStartPageScaleAnimation):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::CCLayerTreeHostTestStartPageScaleAnimation):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::beginTest):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::requestStartPageScaleAnimation):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::applyScrollAndScale):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::afterTest):
(WTF::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoASSERTION FAILED: checkURLReceivedFromWebProcess(originalURL) loading a local file...
ap@apple.com [Fri, 10 Feb 2012 05:45:10 +0000 (05:45 +0000)]
ASSERTION FAILED: checkURLReceivedFromWebProcess(originalURL) loading a local file, if the WebProcess crashed
https://bugs.webkit.org/show_bug.cgi?id=70845
<rdar://problem/10269985>

Reviewed by Anders Carlsson.

This also fixes some case where WebProcess did not get a sandbox extension after a crash.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcessWithItem): We no longer need to pass a sandbox
extension here, we're now passing it at b/f navigation bottleneck.
(WebKit::WebPageProxy::reload): Pass a sandbox extension - reload may mean reloading an error
page after a crash, so WebProcess may no longer have the extension.
(WebKit::WebPageProxy::goForward): We no longer need to pass a sandbox extension here,
we're now passing it at b/f navigation bottleneck. Also, fixed a bug where we first null checked
a WebBackForwardListItem pointer, and then used it anyway.
(WebKit::WebPageProxy::goBack): Ditto.
(WebKit::WebPageProxy::goToBackForwardItem): Ditto.
(WebKit::WebPageProxy::backForwardGoToItem): This is the bottleneck. We get here both for UI
actions like pressing the Back button, and for window.history.go() navigations. JS navigations
previously didn't open up the sandbox. URLs in UI process b/f list are trusted, so it's
always OK to grant a sandbox extension if one of them is a file: one.

* UIProcess/WebPageProxy.h: backForwardGoToItem() now returns a sandbox extension handle.

* UIProcess/WebPageProxy.messages.in: Ditto.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess): If a URL is in UI process b/f
list, then it has been already vetted as something the Web process knows about. No need to
crash if it actually attempts going there.
(WebKit::WebProcessProxy::didReceiveInvalidMessage): Removed a useless comment (we have tons
of fprintfs besides this one). Fixed log message syntax.

* UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::restoreFromSessionStateData):
We no longer need to pass a sandbox extension here, we're now passing it at b/f navigation
bottleneck.

* WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::WebBackForwardListProxy::goToItem):
We now get an extension here, when telling UI process that we're navigating to a b/f list item.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::reload): Use the extension we're getting.
(WebKit::WebPage::goForward): Don't use one we're not getting.
(WebKit::WebPage::goBack): Ditto.
(WebKit::WebPage::goToBackForwardItem): Ditto.
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem): Ditto.

* WebProcess/WebPage/WebPage.h: Adjusted signatures accordingly.

* WebProcess/WebPage/WebPage.messages.in: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r104885): Articles not displayed in Vienna RSS reader
ap@apple.com [Fri, 10 Feb 2012 05:42:55 +0000 (05:42 +0000)]
REGRESSION (r104885): Articles not displayed in Vienna RSS reader
https://bugs.webkit.org/show_bug.cgi?id=78280
<rdar://problem/10762545>

Reviewed by Oliver Hunt.

* Misc/WebNSURLExtras.h:
* Misc/WebNSURLExtras.mm: (-[NSURL _webkit_URLFromURLOrPath]):
Added a method to create a URL from a path, similarly to what KURL used to do.

* WebView/WebFrame.mm: (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
Use it in an API where a known regression occurred.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Gtk] http/tests/workers/terminate-during-sync-operation.html fails locally
commit-queue@webkit.org [Fri, 10 Feb 2012 05:28:58 +0000 (05:28 +0000)]
[Gtk] http/tests/workers/terminate-during-sync-operation.html fails locally
https://bugs.webkit.org/show_bug.cgi?id=78270

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-02-09
Reviewed by Martin Robinson.

Skip a workers http test that utilizes not-yet-supported File System API.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] skip tests affected by deprecation of in-url identities.
tsepez@chromium.org [Fri, 10 Feb 2012 05:23:32 +0000 (05:23 +0000)]
[chromium] skip tests affected by deprecation of in-url identities.
https://bugs.webkit.org/show_bug.cgi?id=78259

Reviewed by Adam Barth.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] TiledLayerChromium::protectVisibleTileTextures() should only protect the...
wangxianzhu@chromium.org [Fri, 10 Feb 2012 05:02:54 +0000 (05:02 +0000)]
[Chromium] TiledLayerChromium::protectVisibleTileTextures() should only protect the visible textures
https://bugs.webkit.org/show_bug.cgi?id=78249

Reviewed by James Robinson.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::protectVisibleTileTextures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add DRT support for modal dialogs
commit-queue@webkit.org [Fri, 10 Feb 2012 04:33:33 +0000 (04:33 +0000)]
[GTK] Add DRT support for modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=53600

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-02-09
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add support for running modal dialogs.

A new signal is added to the WebKitWebView. When emitted, the web view
is requesting to be displayed as a modal dialog. If accepted, the
ChromeClient then establishes a loop that is run until the chrome is destroyed.
If denied, nothing is done.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::ChromeClient):
(WebKit::ChromeClient::chromeDestroyed):
(WebKit::ChromeClient::canRunModal):
(WebKit::ChromeClient::runModal):
* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init):

Tools:

Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
Most significantly, when creating a new web view in GtkLauncher, the window
of the web view opener is passed around. In DumpRenderTree, the window of
the main web view is always considered as the opener. This is required so
the modal dialog's toplevel can be made transient for the opener's toplevel.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewRunModalDialog):
(createWebView):
* GtkLauncher/main.c:
(createWebViewCb):
(runModalDialogCb):
(createBrowser):
(createWindow):
(main):

LayoutTests:

Unskip the passing modal dialogs tests and log the remaining skipped test.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Gtk] security/set-form-autocomplete-attribute.html fails
commit-queue@webkit.org [Fri, 10 Feb 2012 04:30:52 +0000 (04:30 +0000)]
[Gtk] security/set-form-autocomplete-attribute.html fails
https://bugs.webkit.org/show_bug.cgi?id=78261

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-02-09
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add a helper function to DumpRenderTreeSupportGtk, returning
whether or not an element does perform autocompletion.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::elementDoesAutoCompleteForElementWithId):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

Use the new helper in DumpRenderTreeSupportGtk to properly
test whether an element performs autocompletion.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::elementDoesAutoCompleteForElementWithId):

LayoutTests:

Unskip the newly-passing test

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed attempt to fix a test flakiness.
morrita@google.com [Fri, 10 Feb 2012 04:14:57 +0000 (04:14 +0000)]
Unreviewed attempt to fix a test flakiness.

* editing/spelling/spelling-marker-description.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEliminate dead code in BytecodeGenerator::resolve()
commit-queue@webkit.org [Fri, 10 Feb 2012 03:48:54 +0000 (03:48 +0000)]
Eliminate dead code in BytecodeGenerator::resolve()
https://bugs.webkit.org/show_bug.cgi?id=78242

Patch by Andy Wingo <wingo@igalia.com> on 2012-02-09
Reviewed by Gavin Barraclough.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::resolve):
BytecodeGenerator::shouldOptimizeLocals() is only true for
FunctionCode, and thus cannot be true for GlobalCode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Node::isShadowElement() member function.
hayato@chromium.org [Fri, 10 Feb 2012 03:45:06 +0000 (03:45 +0000)]
Add Node::isShadowElement() member function.
https://bugs.webkit.org/show_bug.cgi?id=78201

Reviewed by Dimitri Glazkov.

No tests. No change in behavior. An upcoming change requires this to detect HTMLShadowElement.

* dom/Node.h:
(Node):
(WebCore::Node::isShadowElement):
* html/shadow/HTMLShadowElement.h:
(WebCore::HTMLShadowElement::isShadowElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCachedResourceLoader is destroyed before CSSFontSelector is destroyed
rniwa@webkit.org [Fri, 10 Feb 2012 03:34:21 +0000 (03:34 +0000)]
CachedResourceLoader is destroyed before CSSFontSelector is destroyed
https://bugs.webkit.org/show_bug.cgi?id=77817

Reviewed by Adam Barth.

Explicitly clear style selector before destorying the cached resource loader.

No new tests but PerformanceTests/Parser/html5-full-render.html was crashing
on performance bots due to this bug.

* dom/Document.cpp:
(WebCore::Document::~Document):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove BytecodeGenerator::isLocal
commit-queue@webkit.org [Fri, 10 Feb 2012 03:14:34 +0000 (03:14 +0000)]
Remove BytecodeGenerator::isLocal
https://bugs.webkit.org/show_bug.cgi?id=78241

Minor refactor to BytecodeGenerator.

Patch by Andy Wingo <wingo@igalia.com> on 2012-02-09
Reviewed by Gavin Barraclough.

* bytecompiler/BytecodeGenerator.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::isLocal):
(JSC::BytecodeGenerator::isLocalConstant): Remove now-unused
methods.
* bytecompiler/NodesCodegen.cpp:
(JSC::ResolveNode::isPure): Use the ResolveResult mechanism
instead of isLocal.  This will recognize more resolve nodes as
being pure.
(JSC::PrefixResolveNode::emitBytecode): Use isReadOnly on the
location instead of isLocalConstant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream JavaScriptDebuggerBlackBerry.{h, cpp}
leo.yang@torchmobile.com.cn [Fri, 10 Feb 2012 02:55:42 +0000 (02:55 +0000)]
[BlackBerry] Upstream JavaScriptDebuggerBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=78203

Reviewed by Rob Buis.

Initial upstream, no new tests.

* blackberry/WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/JavaScriptDebuggerBlackBerry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed expectation followup for r107329
jamesr@google.com [Fri, 10 Feb 2012 02:33:31 +0000 (02:33 +0000)]
[chromium] Unreviewed expectation followup for r107329

* platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe JS Parser scope object needs a VectorTrait specialization
oliver@apple.com [Fri, 10 Feb 2012 02:26:04 +0000 (02:26 +0000)]
The JS Parser scope object needs a VectorTrait specialization
https://bugs.webkit.org/show_bug.cgi?id=78308

Reviewed by Gavin Barraclough.

This showed up as a periodic crash in various bits of generated code
originally, but I've added an assertion in the bytecode generator
that makes the effected code much more crash-happy should it go
wrong again.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):
* parser/Parser.cpp:
* parser/Parser.h:
(JSC):
* runtime/JSActivation.h:
(JSC::JSActivation::isValidScopedLookup):
(JSActivation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerf-o-matic shouldn't rely on memcache to store cached JSON responses
rniwa@webkit.org [Fri, 10 Feb 2012 02:19:55 +0000 (02:19 +0000)]
Perf-o-matic shouldn't rely on memcache to store cached JSON responses
https://bugs.webkit.org/show_bug.cgi?id=78306

Reviewed by Adam Barth.

Added PersistentCache model that stores the generated JSON responses.

* Websites/webkit-perf.appspot.com/controller.py:
(set_persistent_cache):
(set_persistent_cache.execute):
(get_persistent_cache):
(cache_manifest):
(CachedManifestHandler.get):
(cache_dashboard):
(CachedDashboardHandler.get):
(cache_runs):
(CachedRunsHandler.get):
* Websites/webkit-perf.appspot.com/models.py:
(TestResult):
(ReportLog):
(PersistentCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate the scroll layer position on the main thread when we have slow repaint objects
andersca@apple.com [Fri, 10 Feb 2012 02:10:13 +0000 (02:10 +0000)]
Update the scroll layer position on the main thread when we have slow repaint objects
https://bugs.webkit.org/show_bug.cgi?id=78300
<rdar://problem/10710754>

Reviewed by Dan Bernstein.

When we have slow repaint objects (background-attachment: fixed), we need to update the
scroll layer position on the main thread, otherwise the web page will appear to jiggle.

* page/FrameView.cpp:
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
Call ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange if needed.

* page/FrameView.h:
(WebCore::FrameView::hasSlowRepaintObjects):
Add new getter.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
Call ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
New function that will update both the main frame scroll position and the scroll layer position.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateMainFrameScrollPositionAndScrollLayerPosition):
Dispatch a call to ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition on the main thread.

* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
Initialize m_shouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingTreeNode::update):
Set m_shouldUpdateScrollLayerPositionOnMainThread.

* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::ScrollingTreeState):
Initialize m_shouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingTreeState::setShouldUpdateScrollLayerPositionOnMainThread):
Update m_shouldUpdateScrollLayerPositionOnMainThread if needed.

* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Assert that we're not supposed to update the scroll layer position on the main thread.

(WebCore::ScrollingTreeNodeMac::scrollBy):
If we're supposed to update the scroll layer position on the main thread,
call ScrollingTree::updateMainFrameScrollPositionAndScrollLayerPosition.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
If the frame view has its scrolling coordinated by a scrolling coordinator, don't update the scroll layer position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly
andersca@apple.com [Fri, 10 Feb 2012 01:54:43 +0000 (01:54 +0000)]
FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly
https://bugs.webkit.org/show_bug.cgi?id=78291

Reviewed by Dan Bernstein.

m_slowRepaintObjectCount needs to be incremented before calling updateCanBlitOnScrollRecursively(),
because otherwise useSlowRepaints() will return false even though we have to use slow repaints.

I was unable to make a layout test for this because it requires that updateCanBlitOnScrollRecursively() isn't
called again after m_slowRepaintObjectCount has been incremented.

* page/FrameView.cpp:
(WebCore::FrameView::addSlowRepaintObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Enable mock scrollbars for compositing layout tests
jamesr@google.com [Fri, 10 Feb 2012 01:45:39 +0000 (01:45 +0000)]
[chromium] Enable mock scrollbars for compositing layout tests
https://bugs.webkit.org/show_bug.cgi?id=78299

Reviewed by Dirk Pranke.

Tools:

This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::runFileTest):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):

LayoutTests:

* platform/chromium-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
* platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png: Removed.
* platform/chromium-linux/compositing/iframes/iframe-copy-on-scroll-expected.png:
* platform/chromium-linux/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
* platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
* platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-linux/compositing/overflow/overflow-scroll-expected.png:
* platform/chromium-linux/compositing/overflow/scrollbar-painting-expected.png:
* platform/chromium-mac/compositing/geometry/tall-page-composited-expected.png: Removed.
* platform/chromium-mac/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
* platform/chromium-win/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
* platform/chromium-win/compositing/geometry/tall-page-composited-expected.png: Removed.
* platform/chromium-win/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
* platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
* platform/chromium/compositing/geometry/ancestor-overflow-change-expected.png:
* platform/chromium/compositing/geometry/tall-page-composited-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
* platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
lforschler@apple.com [Fri, 10 Feb 2012 01:17:23 +0000 (01:17 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoQuick fix for an omission from r107301 caught by jchaffraix
mdelaney@apple.com [Fri, 10 Feb 2012 01:16:46 +0000 (01:16 +0000)]
Quick fix for an omission from r107301 caught by jchaffraix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove TreeOrderIterator and iterate over the child boxes directly.
ojan@chromium.org [Fri, 10 Feb 2012 01:15:16 +0000 (01:15 +0000)]
Remove TreeOrderIterator and iterate over the child boxes directly.
https://bugs.webkit.org/show_bug.cgi?id=78294

Reviewed by Tony Chang.

No new tests. This is purely a refactor. No change in behavior.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
(FlexOrderHashTraits):
(WebCore::RenderFlexibleBox::FlexOrderHashTraits::emptyValue):
(WebCore::RenderFlexibleBox::FlexOrderHashTraits::constructDeletedValue):
(WebCore::RenderFlexibleBox::FlexOrderHashTraits::isDeletedValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCode generators should support multiple values for the [CallWith=] attribute
haraken@chromium.org [Fri, 10 Feb 2012 01:11:32 +0000 (01:11 +0000)]
Code generators should support multiple values for the [CallWith=] attribute
https://bugs.webkit.org/show_bug.cgi?id=78224

Reviewed by Adam Barth.

Currently we can specify only one value for one [CallWith=],
like [CallWith=ScriptExecutionContext] or [CallWith=ScriptState].
To reduce redundant IDL attributes, we are planning to support multiple
values for [CallWith=], like [CallWith=ScriptExecutionContext|ScriptArguments|CallStack].
This patch makes a change on code generators to support it.

Test: bindings/scripts/test/TestObj.idl
No change in WebKit behavior since IDL files have not yet used [CallWith=X|Y|Z].

* bindings/scripts/CodeGenerator.pm: Modified to support [CallWith=X|Y|Z].
(ExtendedAttributeContains):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateCallWith):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateCallWith):
(GenerateFunctionCallString):

* bindings/scripts/test/TestObj.idl: Added test cases for [CallWith=X|Y|Z].

* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::withScriptExecutionContextAndScriptStateAttribute):
(WebDOMTestObj::setWithScriptExecutionContextAndScriptStateAttribute):
(WebDOMTestObj::withScriptExecutionContextAndScriptStateAttributeRaises):
(WebDOMTestObj::setWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebDOMTestObj::withScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebDOMTestObj::setWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebDOMTestObj::withScriptExecutionContextAndScriptState):
(WebDOMTestObj::withScriptExecutionContextAndScriptStateObjException):
(WebDOMTestObj::withScriptExecutionContextAndScriptStateWithSpaces):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_with_script_execution_context_and_script_state):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_with_spaces):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj withScriptExecutionContextAndScriptStateAttribute]):
(-[DOMTestObj setWithScriptExecutionContextAndScriptStateAttribute:]):
(-[DOMTestObj withScriptExecutionContextAndScriptStateAttributeRaises]):
(-[DOMTestObj setWithScriptExecutionContextAndScriptStateAttributeRaises:]):
(-[DOMTestObj withScriptExecutionContextAndScriptStateWithSpacesAttribute]):
(-[DOMTestObj setWithScriptExecutionContextAndScriptStateWithSpacesAttribute:]):
(-[DOMTestObj withScriptExecutionContextAndScriptState]):
(-[DOMTestObj withScriptExecutionContextAndScriptStateObjException]):
(-[DOMTestObj withScriptExecutionContextAndScriptStateWithSpaces]):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateCallback):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
haraken@chromium.org [Fri, 10 Feb 2012 00:56:29 +0000 (00:56 +0000)]
Rename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
https://bugs.webkit.org/show_bug.cgi?id=78108

Reviewed by Adam Barth.

[ConvertNullStringTo=] is not descriptive. To clarify that it specifies
the behavior when the null string is returned by WebCore, this patch renames
[ConvertNullStringTo=] to [TreatReturnedNullStringAs=]. This change is also
for naming consistency with [TreatNullAs] and [TreatUndefinedAs].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementationIndexer):
(NativeToJSValue):
* bindings/scripts/test/TestObj.idl:
* css/CSSCharsetRule.idl:
* css/CSSImportRule.idl:
* css/CSSPageRule.idl:
* css/CSSRule.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleRule.idl:
* css/CSSValue.idl:
* css/MediaList.idl:
* css/StyleSheet.idl:
* css/WebKitCSSKeyframesRule.idl:
* dom/Attr.idl:
* dom/CharacterData.idl:
* dom/Clipboard.idl:
* dom/DOMStringList.idl:
* dom/Document.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Entity.idl:
* dom/MutationRecord.idl:
* dom/Node.idl:
* dom/Notation.idl:
* dom/ProcessingInstruction.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLMediaElement.idl:
* html/canvas/WebGLDebugShaders.idl:
* html/canvas/WebGLRenderingContext.idl:
* page/DOMWindow.idl:
* storage/IDBObjectStore.idl:
* storage/IDBRequest.idl:
* storage/Storage.idl:
* storage/StorageEvent.idl:
* websockets/WebSocket.idl:
* xml/XMLHttpRequest.idl:
* xml/XPathNSResolver.idl:
* xml/XSLTProcessor.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomore refactoring of RenderFlexibleBox in preparation for multiline
tony@chromium.org [Fri, 10 Feb 2012 00:42:46 +0000 (00:42 +0000)]
more refactoring of RenderFlexibleBox in preparation for multiline
https://bugs.webkit.org/show_bug.cgi?id=78281

Reviewed by Ojan Vafai.

Previously, we were creating Vector of each flex item's preferred size in document order,
but for multiline, we need to break the lines in the flex order.  I just removed this code
since it was the wrong order.

Instead, have 2 funtions, computeMainAxisPreferredSizes which only does the necessary
layouts and margin computations to compute preferred sizes and computeFlexOrder which
does the work of computing the flex order, preferred sizes, positive/negative flex.

For multiline, we will have computeFlexOrder drive a while loop and it will return the
flex items, preferred size, and positive/negative flex values for each line.

No new tests, just refactoring.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Only layout auto sized children and set margins.
(WebCore::RenderFlexibleBox::computeFlexOrder): Compute flex order, preferred size, positive/negative flex.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Use the precomputed flex order.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Use the precomputed flex order.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Use the precomputed flex order.
(WebCore::RenderFlexibleBox::alignChildren): Use the precomputed flex order.
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother unreviewed massive SVG rebaseline (all our windows bots that I missed).
jchaffraix@webkit.org [Fri, 10 Feb 2012 00:40:56 +0000 (00:40 +0000)]
Another unreviewed massive SVG rebaseline (all our windows bots that I missed).

* platform/chromium-linux/svg/custom/animate-target-id-changed-expected.png: Removed.
* platform/chromium-linux/svg/custom/animate-target-id-changed-expected.txt: Removed.
* platform/chromium-linux/svg/custom/clip-path-href-changes-expected.png: Removed.
* platform/chromium-linux/svg/custom/clip-path-href-changes-expected.txt: Removed.
* platform/chromium-linux/svg/custom/fill-opacity-update-expected.txt: Removed.
* platform/chromium-linux/svg/custom/js-late-clipPath-and-object-creation-expected.txt: Removed.
* platform/chromium-linux/svg/custom/js-update-container-expected.txt: Removed.
* platform/chromium-linux/svg/custom/js-update-gradient-expected.txt: Removed.
* platform/chromium-linux/svg/custom/marker-child-changes-expected.txt: Removed.
* platform/chromium-linux/svg/custom/marker-strokeWidth-changes-expected.txt: Removed.
* platform/chromium-linux/svg/custom/prevent-default-expected.png: Removed.
* platform/chromium-linux/svg/custom/prevent-default-expected.txt: Removed.
* platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png: Removed.
* platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.txt: Removed.
* platform/chromium-linux/svg/custom/stroke-opacity-update-expected.txt: Removed.
* platform/chromium-linux/svg/custom/use-elementInstance-event-target-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/custom/use-setAttribute-crash-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/repaint-stroke-width-changes-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.txt:
* platform/chromium-win-vista/svg/custom/use-setAttribute-crash-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/use-setAttribute-crash-expected.txt: Added.
* platform/chromium-win/svg/custom/animate-target-id-changed-expected.png:
* platform/chromium-win/svg/custom/animate-target-id-changed-expected.txt: Removed.
* platform/chromium-win/svg/custom/clip-path-href-changes-expected.png:
* platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
* platform/chromium-win/svg/custom/prevent-default-expected.png:
* platform/chromium-win/svg/custom/repaint-stroke-width-changes-expected.png:
* platform/chromium-win/svg/custom/use-elementInstance-event-target-expected.txt:
* platform/chromium-win/svg/custom/use-setAttribute-crash-expected.txt:
* platform/chromium/svg/custom/clip-path-href-changes-expected.txt: Removed.
* platform/chromium/svg/custom/fill-opacity-update-expected.txt: Removed.
* platform/chromium/svg/custom/js-update-container-expected.txt: Removed.
* platform/chromium/svg/custom/js-update-gradient-expected.txt: Removed.
* platform/chromium/svg/custom/marker-child-changes-expected.txt: Removed.
* platform/chromium/svg/custom/marker-strokeWidth-changes-expected.txt: Removed.
* platform/chromium/svg/custom/prevent-default-expected.txt: Removed.
* platform/chromium/svg/custom/repaint-stroke-width-changes-expected.txt: Removed.
* platform/chromium/svg/custom/stroke-opacity-update-expected.txt: Removed.

* platform/chromium/test_expectations.txt:
Marked the really fishy rebaseline here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHiDPI: WebKit2's drag images are blurry
mdelaney@apple.com [Fri, 10 Feb 2012 00:36:09 +0000 (00:36 +0000)]
HiDPI: WebKit2's drag images are blurry
https://bugs.webkit.org/show_bug.cgi?id=67779

Use the proper deviceScaleFactor() instead of accessing _intrinsicDeviceScaleFactor

Reviewed by Beth Dakin.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setDragImage:at:linkDrag:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSplit one MutationObserver layout test into two
adamk@chromium.org [Fri, 10 Feb 2012 00:35:43 +0000 (00:35 +0000)]
Split one MutationObserver layout test into two
https://bugs.webkit.org/show_bug.cgi?id=78285

Reviewed by Ojan Vafai.

Rather than a single non-event-delivery.html test,
created seperate tests for SQL database and FileSystem,
making it easy to skip them separately if the underlying
feature isn't supported by a particular platform.

* fast/mutation/database-callback-delivery-expected.txt: Added.
* fast/mutation/database-callback-delivery.html: Added.
* fast/mutation/filesystem-callback-delivery-expected.txt: Added.
* fast/mutation/filesystem-callback-delivery.html: Added.
* fast/mutation/non-event-delivery-expected.txt: Removed.
* fast/mutation/non-event-delivery.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [Optional=CallWithDefaultValue] and [Optional=CallWithNullValue]
haraken@chromium.org [Fri, 10 Feb 2012 00:25:00 +0000 (00:25 +0000)]
Rename [Optional=CallWithDefaultValue] and [Optional=CallWithNullValue]
https://bugs.webkit.org/show_bug.cgi?id=78200

Reviewed by Adam Barth.

[Optional=CallWithDefaultValue] and [Optional=CallWithNullValue] are confusing.

- [Optional=CallWithDefaultValue] indicates that a missing value should be treated
as if the JavaScript undefined is passed.
- [Optional=CallWithNullValue] indicates that a missing value should be treated as
the WebKit null value (i.e. JSValue() or v8::Local<v8::Value>()).
- Actually, the difference between [Optional=CallWithDefaultValue] and
[Optional=CallWithNullValue] will appear only when the type of the missing value
is DOMString. In case of [Optional=CallWithDefaultValue], the missing value is
converted to the string "undefined". On the other hand, in case of
[Optional=CallWithNullValue], the missing value is converted to the WebKit null string.

With these observations, this patch renames as follows:

- Rename [Optional=CallWithDefaultValue] to [Optional=DefaultIsUndefined].
- Rename [Optional=CallWithNullValue] to [Optional=DefaultIsNullString].

Test: bindings/scripts/test/TestObj.idl

* bindings/js/JSDOMBinding.h: Renamed MissingIsEmpty to DefaultIsNullString,
renamed MissingIsUndefined to DefaultIsUndefined.
* bindings/v8/V8Binding.h: Ditto.
* bindings/v8/custom/V8BindingMacros.h: Ditto.

* bindings/scripts/CodeGeneratorJS.pm: Modified to support the renaming.
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateParametersCheck):
(RequiresCustomSignature):

* bindings/scripts/test/TestObj.idl: Renamed [Optional=...] as described above.
* bindings/scripts/test/TestInterface.idl: Ditto.
* bindings/scripts/test/TestNamedConstructor.idl: Ditto.

* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::methodWithOptionalString):
(WebDOMTestObj::methodWithOptionalStringIsUndefinedString):
(WebDOMTestObj::methodWithOptionalStringIsNullString):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_with_optional_string):
(webkit_dom_test_obj_method_with_optional_string_is_undefined_string):
(webkit_dom_test_obj_method_with_optional_string_is_null_string):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefinedString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj methodWithOptionalString:]):
(-[DOMTestObj methodWithOptionalStringIsUndefinedString:]):
(-[DOMTestObj methodWithOptionalStringIsNullString:]):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::methodWithOptionalStringCallback):
(TestObjInternal):
(WebCore::TestObjInternal::methodWithOptionalStringIsUndefinedStringCallback):
(WebCore::TestObjInternal::methodWithOptionalStringIsNullStringCallback):
(WebCore):

* Modules/gamepad/GamepadList.idl: Renamed [Optional=...] as described above.
* Modules/intents/Intent.idl:
* css/CSSMediaRule.idl:
* css/CSSPrimitiveValue.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleSheet.idl:
* css/CSSValueList.idl:
* css/MediaList.idl:
* css/MediaQueryList.idl:
* css/MediaQueryListListener.idl:
* css/StyleMedia.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSMatrix.idl:
* dom/CharacterData.idl:
* dom/ClientRectList.idl:
* dom/CompositionEvent.idl:
* dom/CustomEvent.idl:
* dom/DOMImplementation.idl:
* dom/DOMStringList.idl:
* dom/DataTransferItem.idl:
* dom/DataTransferItemList.idl:
* dom/DeviceMotionEvent.idl:
* dom/DeviceOrientationEvent.idl:
* dom/Document.idl:
* dom/Element.idl:
* dom/Event.idl:
* dom/HashChangeEvent.idl:
* dom/KeyboardEvent.idl:
* dom/MessageEvent.idl:
* dom/MouseEvent.idl:
* dom/MutationEvent.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeFilter.idl:
* dom/NodeList.idl:
* dom/OverflowEvent.idl:
* dom/Range.idl:
* dom/ShadowRoot.idl:
* dom/Text.idl:
* dom/TextEvent.idl:
* dom/TouchEvent.idl:
* dom/UIEvent.idl:
* dom/WheelEvent.idl:
* html/DOMFormData.idl:
* html/HTMLAllCollection.idl:
* html/HTMLAudioElement.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLCollection.idl:
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTableRowElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLTextAreaElement.idl:
* html/TextTrackCue.idl:
* html/canvas/CanvasGradient.idl:
* html/canvas/CanvasRenderingContext2D.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* page/Console.idl:
* page/DOMSelection.idl:
* page/DOMWindow.idl:
* page/History.idl:
* page/Location.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:
* storage/IDBDatabase.idl:
* storage/StorageEvent.idl:
* svg/ElementTimeControl.idl:
* svg/SVGDocument.idl:
* svg/SVGElementInstanceList.idl:
* svg/SVGFEDropShadowElement.idl:
* svg/SVGFEGaussianBlurElement.idl:
* svg/SVGFEMorphologyElement.idl:
* svg/SVGFilterElement.idl:
* svg/SVGLocatable.idl:
* svg/SVGMarkerElement.idl:
* svg/SVGPathElement.idl:
* svg/SVGSVGElement.idl:
* svg/SVGStylable.idl:
* svg/SVGTests.idl:
* svg/SVGTextContentElement.idl:
* webaudio/AudioNode.idl:
* workers/SharedWorker.idl:
* workers/WorkerContext.idl:
* xml/DOMParser.idl:
* xml/XMLSerializer.idl:
* xml/XPathEvaluator.idl:
* xml/XPathExpression.idl:
* xml/XPathNSResolver.idl:
* xml/XPathResult.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove more uses of "os" from our webkitpy code
eric@webkit.org [Fri, 10 Feb 2012 00:09:31 +0000 (00:09 +0000)]
Remove more uses of "os" from our webkitpy code
https://bugs.webkit.org/show_bug.cgi?id=78292

Reviewed by Adam Barth.

* Scripts/webkitpy/common/checkout/checkout_mock.py:
(MockCheckout.__init__):
(MockCheckout.is_path_to_changelog):
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem._split):
* Scripts/webkitpy/common/system/zipfileset_unittest.py:
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/tool/bot/queueengine.py:
* Scripts/webkitpy/tool/bot/sheriff_unittest.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
* Scripts/webkitpy/tool/commands/rebaselineserver.py:
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
* Scripts/webkitpy/tool/commands/upload.py:
(CreateBug.prompt_for_bug_title_and_comment):
* Scripts/webkitpy/tool/servers/reflectionhandler.py:
* Scripts/webkitpy/tool/steps/attachtobug.py:
(AttachToBug.run):
* Scripts/webkitpy/tool/steps/checkstyle.py:
* Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
* Scripts/webkitpy/tool/steps/commit_unittest.py:
* Scripts/webkitpy/tool/steps/editchangelog.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(PrepareChangeLogTest.test_ensure_bug_url):
* Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
* Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
* Scripts/webkitpy/tool/steps/validatereviewer.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogetComputedStyle() returns different values for different zoom levels
mdelaney@apple.com [Fri, 10 Feb 2012 00:05:10 +0000 (00:05 +0000)]
getComputedStyle() returns different values for different zoom levels
https://bugs.webkit.org/show_bug.cgi?id=32230

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::fillSizeToCSSValue): Pass down the RenderStyle for use in adjusting
values to account for zoom.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Adjust additional
properties that are affected by zoom.

LayoutTests:

* fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [Return] to [CustomReturn]
haraken@chromium.org [Thu, 9 Feb 2012 23:41:30 +0000 (23:41 +0000)]
Rename [Return] to [CustomReturn]
https://bugs.webkit.org/show_bug.cgi?id=78225

Reviewed by Adam Barth.

[Return] is used to handle custom code for a returned value.
To clarify it, this patch renames [Return] to [CustomReturn].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* dom/Node.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Thu, 9 Feb 2012 23:33:13 +0000 (23:33 +0000)]
Unreviewed gardening.

* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Replaced.
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Removed.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
Updated those baseline for line-grid-snap to line-snap renaming.

* platform/chromium/test_expectations.txt:
Added another crasher following r107242.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the cr-mac-ews (it's long been dead)
eric@webkit.org [Thu, 9 Feb 2012 23:09:51 +0000 (23:09 +0000)]
Remove the cr-mac-ews (it's long been dead)
https://bugs.webkit.org/show_bug.cgi?id=78267

Reviewed by Adam Barth.

* QueueStatusServer/model/queues.py:
(Queue):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(ChromiumWindowsEWS):
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSytemTest._test_builder_ews):
(EarlyWarningSytemTest._test_testing_ews):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd roundedIntPoint method for LayoutPoints
leviw@chromium.org [Thu, 9 Feb 2012 23:09:38 +0000 (23:09 +0000)]
Add roundedIntPoint method for LayoutPoints
https://bugs.webkit.org/show_bug.cgi?id=78262

Reviewed by Eric Seidel.

Adding a roundedIntPoint method that operates on a LayoutPoint. Currently, this does
nothing as LayoutPoint is a typedef to IntPoint. When we enable sub-pixel LayoutUnits,
this is a critical part in our pixel snapping strategy, where we round the logical top-
left point, then snap the right and bottom edges.

Also using this new method where we wish to convert LayoutPoints to IntPoints, which
we're currently doing implicitly (since they're the same thing).

No new tests. No change in functionality.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
* page/EventHandler.cpp:
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::selectCursor):
* rendering/LayoutTypes.h:
(WebCore::roundedIntPoint):
(WebCore):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintIntoRegion):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::getCursor):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::offsetFromResizeCorner):
(WebCore::RenderLayer::isPointInResizeControl):
(WebCore::RenderLayer::paintLayerContents):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::paintContents):
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::paint):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::paint):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::paint):
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update baselines for compositing/iframes/iframe-content-flipping.html
jamesr@google.com [Thu, 9 Feb 2012 23:06:09 +0000 (23:06 +0000)]
[chromium] Update baselines for compositing/iframes/iframe-content-flipping.html

* platform/chromium-mac-snowleopard/compositing/iframes/iframe-content-flipping-expected.png: Renamed from LayoutTests/platform/chromium-mac/compositing/iframes/iframe-content-flipping-expected.png.
* platform/chromium-win/compositing/iframes/iframe-content-flipping-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream BlackBerry WebKitSupport WebPageCompositor class
rwlbuis@webkit.org [Thu, 9 Feb 2012 22:46:57 +0000 (22:46 +0000)]
[BlackBerry] Upstream BlackBerry WebKitSupport WebPageCompositor class
https://bugs.webkit.org/show_bug.cgi?id=78276

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

* blackberry/WebKitSupport/WebPageCompositor.cpp: Added.
* blackberry/WebKitSupport/WebPageCompositor.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agosome tests in webkitpy are being run three times
dpranke@chromium.org [Thu, 9 Feb 2012 22:33:16 +0000 (22:33 +0000)]
some tests in webkitpy are being run three times
https://bugs.webkit.org/show_bug.cgi?id=78283

Reviewed by Ryosuke Niwa.

It turns out that if you import a class derived from
unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
the unittest framework treats it as if the class was defined in
the file (as well in the original file). This led us to running
the tests in ChangeLogTest three times.

* Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(PrepareChangeLogTest):
* Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
(_assert_message_for_revert_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add chromium-style tracing support
commit-queue@webkit.org [Thu, 9 Feb 2012 22:18:25 +0000 (22:18 +0000)]
[Chromium] Add chromium-style tracing support
https://bugs.webkit.org/show_bug.cgi?id=76885

Patch by John Bates <jbates@google.com> on 2012-02-09
Reviewed by Darin Fisher.

This code enables WebKit trace events to pass through more data to the
chromium platform tracing API and generally to use the full tracing
API provided by chromium.

Source/WebCore:

* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluate): Replace old tracing API.
* page/Console.cpp:
(WebCore::Console::time): Replace old tracing API.
(WebCore::Console::timeEnd): Replace old tracing API.
* platform/chromium/PlatformSupport.h:
* platform/chromium/TraceEvent.h:
(WebCore::TraceEvent::TraceID::TraceID):
(WebCore::TraceEvent::TraceID::data):
(WebCore::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):
(WebCore::TraceEvent::TraceStringWithCopy::operator const char* ):
(WebCore::TraceEvent::setTraceValue):
(WebCore::TraceEvent::addTraceEvent):
(WebCore::TraceEvent::TraceEndOnScopeClose::TraceEndOnScopeClose):
(WebCore::TraceEvent::TraceEndOnScopeClose::~TraceEndOnScopeClose):
(WebCore::TraceEvent::TraceEndOnScopeClose::initialize):
(WebCore::TraceEvent::TraceEndOnScopeClose::addEventIfEnabled):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::TraceEndOnScopeCloseThreshold):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::~TraceEndOnScopeCloseThreshold):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::initialize):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::addEventIfEnabled):

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::getTraceCategoryEnabledFlag):
(WebKit::WebKitPlatformSupport::addTraceEvent):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::getTraceCategoryEnabledFlag):
(WebCore::PlatformSupport::addTraceEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78256
hyatt@apple.com [Thu, 9 Feb 2012 21:59:07 +0000 (21:59 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78256

Rename line-grid-snap to line-snap so that it matches the draft proposal for the
property.

Reviewed by Dan Bernstein.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineSnap):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineSnapAdjustment):
* rendering/RootInlineBox.h:
(RootInlineBox):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=78256

Rename line-grid-snap to line-snap so that it matches the draft proposal for the
property.

Reviewed by Dan Bernstein.

* fast/line-grid/line-grid-contains-value.html:
* fast/line-grid/line-grid-floating.html:
* fast/line-grid/line-grid-inside-columns.html:
* fast/line-grid/line-grid-into-columns.html:
* fast/line-grid/line-grid-into-floats.html:
* fast/line-grid/line-grid-nested.html:
* fast/line-grid/line-grid-positioned.html:
* fast/line-grid/line-grid-snap-parsing.html: Removed.
* fast/line-grid/line-snap-parsing-expected.txt: Added.
* fast/line-grid/line-snap-parsing.html: Added.
* fast/line-grid/script-tests/line-grid-snap-parsing.js: Removed.
* fast/line-grid/script-tests/line-snap-parsing.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe localization of htmlSelectMultipleItems() needs better support of pluralization
benjamin@webkit.org [Thu, 9 Feb 2012 21:47:58 +0000 (21:47 +0000)]
The localization of htmlSelectMultipleItems() needs better support of pluralization
https://bugs.webkit.org/show_bug.cgi?id=78197

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-09
Reviewed by Joseph Pecoraro.

For translation, the localization of 0 and 1 depends on the language.

* English.lproj/Localizable.strings:
* platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Plumb setNeedsRedraw.
commit-queue@webkit.org [Thu, 9 Feb 2012 21:40:03 +0000 (21:40 +0000)]
[chromium] Plumb setNeedsRedraw.
https://bugs.webkit.org/show_bug.cgi?id=78248

Patch by Jonathan Backer <backer@chromium.org> on 2012-02-09
Reviewed by James Robinson.

* public/platform/WebLayerTreeView.h:
(WebLayerTreeView):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setNeedsRedraw):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove extraneous line in previous patch. I forgot to remove this
abarth@webkit.org [Thu, 9 Feb 2012 21:37:09 +0000 (21:37 +0000)]
Remove extraneous line in previous patch.  I forgot to remove this
before landing.

* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverProxy.start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScrollingTreeNodeMac should implement ScrollElasticityController
andersca@apple.com [Thu, 9 Feb 2012 21:31:33 +0000 (21:31 +0000)]
ScrollingTreeNodeMac should implement ScrollElasticityController
https://bugs.webkit.org/show_bug.cgi?id=78277

Reviewed by Andreas Kling.

Add stubbed out implementations of the ScrollElasticityController member functions.

* page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::allowsHorizontalStretching):
(WebCore):
(WebCore::ScrollingTreeNodeMac::allowsVerticalStretching):
(WebCore::ScrollingTreeNodeMac::stretchAmount):
(WebCore::ScrollingTreeNodeMac::pinnedInDirection):
(WebCore::ScrollingTreeNodeMac::canScrollHorizontally):
(WebCore::ScrollingTreeNodeMac::canScrollVertically):
(WebCore::ScrollingTreeNodeMac::shouldRubberBandInDirection):
(WebCore::ScrollingTreeNodeMac::absoluteScrollPosition):
(WebCore::ScrollingTreeNodeMac::immediateScrollBy):
(WebCore::ScrollingTreeNodeMac::immediateScrollByWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::startSnapRubberbandTimer):
(WebCore::ScrollingTreeNodeMac::stopSnapRubberbandTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorun-perf-tests should have an option to pause before running tests so we can attach...
abarth@webkit.org [Thu, 9 Feb 2012 21:26:34 +0000 (21:26 +0000)]
run-perf-tests should have an option to pause before running tests so we can attach Instruments
https://bugs.webkit.org/show_bug.cgi?id=78271

Reviewed by Ryosuke Niwa.

This lets me attach instruments to profile the performance of the test.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.start):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.start):
(DriverProxy.start):
* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess.start):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.start):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.start):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(get_tests_run.RecordingTestDriver.start):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._run_tests_set):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(start):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
(test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107284 268f45cc-cd09-0410-ab3c-d52691b4dbfc