aroben@apple.com [Wed, 18 May 2011 15:38:14 +0000 (15:38 +0000)]
Add a new page to build.webkit.org to help find when tests started failing
The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
right now, but already shows some useful information. It's somewhat similar to webkit-patch
failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
little more convenient than either of them, though, because it's all done in the browser
(and thus it's easy to go directly to the relevant test results).
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
(Buildbot): This class represents a Buildbot server.
(Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
(Buildbot.prototype.builderNamed): Returns a Builder with the given name.
(Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
callback.
(Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
be implemented by a derived class that understands this server's build naming scheme.
(Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
particular build.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
(Builder): This class represents one builder on the buildbot.
(Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
(Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
information about a particular test failure.
(Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
information about when tests started failing.
(Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
particular build.
(Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
callback.
(Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
extracts all the failing tests listed in it, passing them to the callback.
(Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
build, merges them into the build history, and calls the callback telling it whether the
next build should be fetched to provide more information.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
Added. Just some simple styles.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
(createDefinitionList): Takes an array of pairs and turns them into a DL element.
(getResource): Wrapper around XMLHttpRequest.
(Array.prototype.findFirst): Finds the first element matching the given predicate and
returns it.
(Array.prototype.last): Returns the last element of the array.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
(ViewController): This class contains the main logic for displaying the page.
(ViewController.loaded): Just calls through to parseHash.
(ViewController.parseHash): Either starts analyzing failures on a particular builder, or
shows the list of all testers so one can be chosen. This function is called when the page
loads and whenever we get a hashchange event.
(ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
as it is fetched. The display ends up grouping tests by when they started failing.
(ViewController._displayTesters): Gets the list of testers and displays it.
(ViewController._domForBuildName):
(ViewController._domForFailedTest):
Helper functions to create descriptions and links for a particular build or failed test.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
(WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
(WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
loads all the files and sets up a ViewController, which does the rest.
* BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
page.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 18 May 2011 15:35:36 +0000 (15:35 +0000)]
2011-05-18 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
All animated SVG enum properties are now ints
https://bugs.webkit.org/show_bug.cgi?id=10749
Add tests for all elements using SVGAnimatedEnumeration in the SVG DOM API.
* platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Update result, progression.
* svg/dom/SVGAnimatedEnumeration-SVGClipPathElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFilterElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGGradientElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGMarkerElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGMaskElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGPatternElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGTextContentElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-SVGTextPathElement-expected.txt: Added.
* svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html: Added.
* svg/dom/SVGAnimatedEnumeration-expected.txt:
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGClipPathElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEBlendElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEColorMatrixElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGFECompositeElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEMorphologyElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGFETurbulenceElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGFilterElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGGradientElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGMarkerElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGMaskElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGPatternElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGTextContentElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration-SVGTextPathElement.js: Added.
* svg/dom/script-tests/SVGAnimatedEnumeration.js:
* svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt:
* svg/dynamic-updates/script-tests/SVGTextElement-svgdom-lengthAdjust-prop.js:
(executeTest):
* svg/filters/feBlend-invalid-mode-expected.txt:
* svg/filters/feComponentTransfer-style-crash-expected.txt:
* svg/filters/feComponentTransfer-style-crash.xhtml:
* svg/filters/feDisplacementMap-crash-test-expected.txt:
* svg/filters/feDisplacementMap-crash-test.xhtml:
2011-05-18 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
All animated SVG enum properties are now ints
https://bugs.webkit.org/show_bug.cgi?id=10749
DECLARE/DEFINE_ANIMATED_ENUMERATION created fooBaseVal()/setFooBaseVal() methods that take int parameters, and stored all enum types as integers.
Modify the SVG DOM API to store real enums, and get rid of any int<->enum conversions. It's now impossible to change any enum values to undefined
types, which is the root of several filter security bugs in the past, that were fixed by adding workarounds.
(Usual workaround: svgAttributeChanged(): if fooAttr has been changed from SVG DOM, and if it's an enum, check whether the enum is in range, or fix it up.)
Using a type-safe internal representation for these enum values we can get rid of ugly int<->enum conversions.
A lot of parseMappedAttribute() functions duplicated the code for parsing enum values (eg. userSpaceOnUse/objectBoundingBox unit values, in pattern/filter/mask/etc..)
Add dozens of new SVGPropertyTraits<EnumType> specializations for all enums we expose to JS, and offer static fromString/toString conversion methods in single places.
Use the new SVGPropertyTraits everywhere in svg/.
This also fixes SVG DOM <-> XML DOM synchronization for SVGAnimatedEnumeration types.
Example: <clipPath clipPathUnits="objectBoundingBox">
myClipPath.clipPathUnits.baseVal = SVGUnitTypes.SVG_UNIT_TYPE_USERSPACEONUSE;
alert(myClipPath.getAttribute('clipPathUnits')); <- without this patch it says "1", now it says "userSpaceOnUse" as expected, and as other browsers do.
We're now properly converting the enum values to strings.
Add testcases for all SVGAnimatedEnumeration objects used in the SVG DOM API. Found several small bugs:
- SVGFEConvolveMatrix 'edgeMode' SVG DOM <-> XML DOM synchronization was not working, because of a typo: s/operatorAttr/edgeModeAttr
- SVGFEConvolveMatrix was missing an synchronizeProperty() implementation, disabling SVG <-> XML DOM synchronization completly.
Tests: svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html
svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html
svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html
svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html
svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html
svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html
svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html
svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html
svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html
svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html
svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html
Fixes existing svg/dynamic-update/SVGTextContentElement-svgdom-lengthAdjust-prop.html where I found the bug initially.
* GNUmakefile.list.am: Add svg/properties/SVGAnimatedEnumerationPropertyTearOff.h to build.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/scripts/CodeGeneratorV8.pm: Add V8 magic, to avoid ambigious conversion warning in toV8(PassRefPtr<SVGAnimatedEnumeration>).
* platform/graphics/GraphicsTypes.h: Cleanup GradientSpreadMethod, as the SVG dependency is gone.
* platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::apply): Turn early-returns (introduce in security patches a while ago) into ASSERTs, as the underlying bug has been fixed.
* platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::apply): Ditto.
* rendering/svg/RenderSVGResourceClipper.h: Remove toUnitType() usage, the clipPathUnits() provided by SVGClipPathElement have the correct enum type now.
(WebCore::RenderSVGResourceClipper::clipPathUnits):
* rendering/svg/RenderSVGResourceFilter.h: Remove toUnitType() usage, the filterUnits()/primitiveUnits() provided by SVGFilterElement have the correct enum type now.
(WebCore::RenderSVGResourceFilter::filterUnits):
(WebCore::RenderSVGResourceFilter::primitiveUnits):
* rendering/svg/RenderSVGResourceGradient.cpp: Add helper method platformSpreadMethodFromSVGType() converting from SVGGradientElement::SVGSpreadMethodType to GradientSpreadMethod (platform).
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/svg/RenderSVGResourceGradient.h: Ditto.
* rendering/svg/RenderSVGResourceLinearGradient.cpp:
(WebCore::RenderSVGResourceLinearGradient::buildGradient): Use platformSpreadMethodFromSVGType().
* rendering/svg/RenderSVGResourceMarker.h: Remove toUnitType() usage, the markerUnits() provided by SVGMarkerElement have the correct enum type now.
(WebCore::RenderSVGResourceMarker::markerUnits):
* rendering/svg/RenderSVGResourceMasker.h: Remove toUnitType() usage, the maskUnits()/maskContentUnits() provided by SVGMaskElement have the correct enum type now.
(WebCore::RenderSVGResourceMasker::maskUnits):
(WebCore::RenderSVGResourceMasker::maskContentUnits):
* rendering/svg/RenderSVGResourceRadialGradient.cpp:
(WebCore::RenderSVGResourceRadialGradient::buildGradient): Use platformSpreadMethodFromSVGType().
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<): Use SVGPropertyTraits<SomeSVGEnumType>::toString() to convert from enum to string, remove code duplication.
(WebCore::writeCommonGradientProperties):
* rendering/svg/SVGTextChunkBuilder.cpp:
(WebCore::SVGTextChunkBuilder::addTextChunk): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::parentDefinesTextLength): Ditto.
(WebCore::SVGTextLayoutEngine::beginTextPathLayout): Ditto.
* svg/GradientAttributes.h: Change spread method type from platform GradientSpreadMethod to SVGSpreadMethodType.
(WebCore::GradientAttributes::GradientAttributes):
(WebCore::GradientAttributes::spreadMethod):
(WebCore::GradientAttributes::setSpreadMethod):
* svg/SVGAnimatedBoolean.idl: Enable potential exception raising on baseVal setting for the primitive types.
* svg/SVGAnimatedEnumeration.h: Switch from generic SVGAnimatedStaticPropertyTearOff<int> to new SVGAnimatedEnumerationPropertyTearOff<EnumType>.
* svg/SVGAnimatedEnumeration.idl: Enable potential exception raising on baseVal setting for the primitive types.
Only SVGAnimatedEnumeration makes use of this if the assigned value is out of range.
* svg/SVGAnimatedInteger.idl: Ditto.
* svg/SVGAnimatedNumber.idl: Ditto.
* svg/SVGAnimatedString.idl: Ditto.
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
* svg/SVGClipPathElement.h:
* svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): Initialize type to identity, not unknown, as per spec.
(WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
(WebCore::SVGComponentTransferFunctionElement::transferFunction): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
* svg/SVGComponentTransferFunctionElement.h: Remove svgAttributeChanged() method, that verified the enum value is not out of range.
It's not possible anymore for these values to go out of range.
* svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<BlendModeType>::fromString(attr->value()).
(WebCore::SVGFEBlendElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
(WebCore::SVGFEBlendElement::build): Ditto.
* svg/SVGFEBlendElement.h: Add SVGPropertyTraits<BlendModeType> specializations.
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<ColorMatrixType>::fromString(attr->value()).
(WebCore::SVGFEColorMatrixElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now..
(WebCore::SVGFEColorMatrixElement::build): Ditto.
* svg/SVGFEColorMatrixElement.h: Add SVGPropertyTraits<ColorMatrixType> specializations.
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<CompositeOperationType>::fromString(attr->value()).
(WebCore::SVGFECompositeElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
(WebCore::SVGFECompositeElement::build): Ditto.
* svg/SVGFECompositeElement.h: Add SVGPropertyTraits<CompositeOperationType> specializations.
* svg/SVGFEConvolveMatrixElement.cpp: Fix typo, edgeMode needs to be associated with SVGNames::edgeModeAttr, not SVGNames::operatorAttr.
(WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EdgeModeType>::fromString(attr->value()).
(WebCore::SVGFEConvolveMatrixElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
(WebCore::SVGFEConvolveMatrixElement::synchronizeProperty): Add missing synchronizeProperty() implementation, otherwhise SVG DOM <-> XML DOM is not in sync.
(WebCore::SVGFEConvolveMatrixElement::build): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
* svg/SVGFEConvolveMatrixElement.h: Add SVGPropertyTraits<EdgeModeType> specializations.
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<ChannelSelectorType>::fromString(attr->value()).
(WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
(WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): Remove range validation for enum types, they are always in range now.
(WebCore::SVGFEDisplacementMapElement::build): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
* svg/SVGFEDisplacementMapElement.h: Add SVGPropertyTraits<ChannelSelectorType> specializations.
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<MorphologyOperatorType>::fromString(attr->value()).
(WebCore::SVGFEMorphologyElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
(WebCore::SVGFEMorphologyElement::build): Ditto.
* svg/SVGFEMorphologyElement.h: Add SVGPropertyTraits<MorphologyOperatorType> specializations.
* svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGStitchOptions/TurbulenceType>::fromString(attr->value()).
(WebCore::SVGFETurbulenceElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
(WebCore::SVGFETurbulenceElement::build): Ditto.
* svg/SVGFETurbulenceElement.h: Add SVGPropertyTraits<SVGStitchOptions/TurbulenceType> specializations.
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGUnitType>::fromString(attr->value()).
* svg/SVGFilterElement.h:
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::SVGGradientElement): Missing spread method default initialization: set it to 'pad' as per spec.
(WebCore::SVGGradientElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGUnitType/SVGSpreadMethodType>::fromString(attr->value()).
* svg/SVGGradientElement.h: Add SVGPropertyTraits<SVGSpreadMethodType> specializations.
* svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::collectGradientAttributes): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
(WebCore::SVGMarkerElement::synchronizeOrientType): Add a custom synchronization method, that handles orientType/orientAngle -> orientAttr synchronization, which is special
as it depends on to other SVG DOM objects (SVGAnimatedAngle and SVGAnimatedEnumeration). All covered by new tests.
(WebCore::SVGMarkerElement::orientTypeAnimated): Custom tear off creation method, which would usually be generated by the DECLARE_ANIMATED_... macros.
* svg/SVGMarkerElement.h: Add SVGPropertyTraits<SVGMarkerUnitsType/SVGMarkerOrientType> specializations.
(WebCore::SVGMarkerElement::orientType): Add custom property handling for the 'orientType' SVGAnimatedEnumeration object, as it has special demands, based on 'orientAngle'.
(WebCore::SVGMarkerElement::orientTypeBaseValue): Ditto.
(WebCore::SVGMarkerElement::setOrientTypeBaseValue): Ditto.
* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
* svg/SVGMaskElement.h:
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
* svg/SVGPatternElement.h:
* svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::collectGradientAttributes): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGLengthAdjustType>::fromString(attr->value()).
* svg/SVGTextContentElement.h: Add SVGPropertyTraits<SVGLengthAdjustType> specializations.
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGTextPathMethodType/SVGTextPathSpacingType>::fromString(attr->value()).
* svg/SVGTextPathElement.h: Add SVGPropertyTraits<SVGTextPathMethodType/SVGTextPathSpacingType> specializations.
* svg/SVGUnitTypes.h: Add SVGPropertyTraits<SVGUnitType> specializations.
* svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Added. SVGAnimatedEnumerationPropertyTearOff inherits from SVGAnimatedStaticPropertyTearOff<int>.
SVGAnimatedEnumeration remains a typedef to SVGAnimatedStaticPropertyTearOff<int>, to have a common base
class for all enum types. This special tear off object, overrides setBaseVal, to verify the incoming int
is within the enum range, otherwhise raise an SVG DOM exception. This makes it impossible to make any of
the enums go out of range anymore (which lead to security bugs in the past).
(WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::SVGAnimatedEnumerationPropertyTearOff):
* svg/properties/SVGAnimatedStaticPropertyTearOff.h:
(WebCore::SVGAnimatedStaticPropertyTearOff::setBaseVal): Made this method virtual, to SVGAnimatedEnumerationPropertyTearOff can override the default behaviour. Also added an ExceptionCode param.
(WebCore::SVGAnimatedStaticPropertyTearOff::~SVGAnimatedStaticPropertyTearOff):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Wed, 18 May 2011 15:31:33 +0000 (15:31 +0000)]
2011-05-18 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Expose webkitStorageInfo.requestQuota() for Quota API if QUOTA flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=59681
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* storage/script-tests/storageinfo-request-quota.js: Added.
* storage/storageinfo-request-quota-expected.txt: Added.
* storage/storageinfo-request-quota.html: Added.
2011-05-18 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Expose webkitStorageInfo.requestQuota() for Quota API if QUOTA flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=59681
Test: storage/storageinfo-request-quota.html
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* storage/StorageInfo.idl: Added requestQuota().
* storage/StorageInfoQuotaCallback.idl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Wed, 18 May 2011 15:20:04 +0000 (15:20 +0000)]
2011-05-18 Renata Hodovan <reni@webkit.org>
Reviewed by Nikolas Zimmermann.
Apply the ParallelJobs support to FEGaussianBlur
https://bugs.webkit.org/show_bug.cgi?id=61049
The Gaussian blur filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is about 15% on dual-core machines.
Developed in cooperation with Gabor Loki and Zoltan Herczeg.
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):
* platform/graphics/filters/FEGaussianBlur.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 18 May 2011 15:06:14 +0000 (15:06 +0000)]
[Qt][WK2] Skip two failing tests.
* platform/qt-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 18 May 2011 15:04:23 +0000 (15:04 +0000)]
2011-05-18 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Don't lie about supporting accelerated compositing.
https://bugs.webkit.org/show_bug.cgi?id=61054
Until we have an implementation of LayerTreeHost, we shouldn't lie about it.
* WebKit2.pro:
* WebProcess/WebPage/LayerTreeHost.h:
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp: Added.
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 18 May 2011 14:31:10 +0000 (14:31 +0000)]
2011-05-18 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: make parentId for frame optional.
https://bugs.webkit.org/show_bug.cgi?id=61032
* inspector/Inspector.json:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._addFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loki@webkit.org [Wed, 18 May 2011 14:27:28 +0000 (14:27 +0000)]
2011-05-18 Gabor Loki <loki@webkit.org>
Reviewed by Nikolas Zimmermann.
Apply the ParallelJobs support to FELighting
https://bugs.webkit.org/show_bug.cgi?id=61048
The lighting filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is 10-20% on dual-core machines.
Developed in cooperation with Zoltan Herczeg.
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGenericPaint):
(WebCore::FELighting::platformApplyGenericWorker):
(WebCore::FELighting::platformApplyGeneric):
* platform/graphics/filters/FELighting.h:
* platform/graphics/filters/arm/FELightingNEON.cpp:
(WebCore::FELighting::platformApplyNeonWorker):
* platform/graphics/filters/arm/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Wed, 18 May 2011 14:12:56 +0000 (14:12 +0000)]
2011-05-18 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Fix tst_QWebFrame::getSetStaticProperty() autotest
https://bugs.webkit.org/show_bug.cgi?id=60984
The code for converting objects to QVariantMap was causing exception,
that was "leaking" to the next evaluation. One situation was reading
the property 'localStorage' when we do not have a proper security
origin, which throws a SECURITY_ERR.
Now, we will simply not include on the QVariantMap those properties,
and make sure that we clean the exception if necessary.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariantMap):
Extracted function that performs conversion from JSObject to a QVariantMap. This
functions makes sure that exception is clean after its execution.
(JSC::Bindings::convertValueToQVariant):
Use the previous function. Add a comment explaining the choice of distance value.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 18 May 2011 14:11:55 +0000 (14:11 +0000)]
2011-05-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: scripts panel file selector element doesn't track keyboard events
https://bugs.webkit.org/show_bug.cgi?id=61047
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Wed, 18 May 2011 13:50:56 +0000 (13:50 +0000)]
2011-05-16 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactoring: ScriptDebugListener::didParseSource has too many parameters.
https://bugs.webkit.org/show_bug.cgi?id=60900
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/ScriptDebugListener.h:
(WebCore::ScriptDebugListener::Script::Script):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Wed, 18 May 2011 13:42:24 +0000 (13:42 +0000)]
Remove whitespace from the line of fast/forms/ValidityState-valueMissing-002.html
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 18 May 2011 13:32:07 +0000 (13:32 +0000)]
2011-05-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: model-based CSS editing does not update @import-ed stylesheet resources
https://bugs.webkit.org/show_bug.cgi?id=60966
* inspector/styles/resources/styles-new-API-1.css:
* inspector/styles/resources/styles-new-API-2.css: Copied from LayoutTests/inspector/styles/resources/styles-new-API-1.css.
(@page):
(@page :first):
(#absent-id):
(@font-face):
(body):
* inspector/styles/styles-new-API-expected.txt:
2011-05-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: model-based CSS editing does not update @import-ed stylesheet resources
https://bugs.webkit.org/show_bug.cgi?id=60966
Imported stylesheets didn't use to be returned by InspectorCSSAgent.
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::collectStyleSheets):
* inspector/InspectorCSSAgent.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Wed, 18 May 2011 12:56:22 +0000 (12:56 +0000)]
Add fast/forms/ValidityState-valueMissing-002.html to the Skipped list since
eventSender.keyDown is unimplemented.
Reviewed by Csaba Osztrogonác.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 18 May 2011 12:04:35 +0000 (12:04 +0000)]
2011-05-18 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: make "Id" suffixes use consistent case.
https://bugs.webkit.org/show_bug.cgi?id=61028
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::editScriptSource):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
* inspector/InspectorInstrumentation.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForResourceResponse):
* inspector/ScriptDebugListener.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.scriptForSourceID):
(WebInspector.DebuggerModel.prototype.queryScripts):
(WebInspector.DebuggerModel.prototype.editScriptSource):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource):
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
(WebInspector.PresenationCallFrame):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
* inspector/front-end/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.editSource):
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile.prototype.forceLoadContent):
(WebInspector.SourceFile.prototype._concatenateScriptsContent):
(WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
(WebInspector):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 May 2011 11:33:52 +0000 (11:33 +0000)]
2011-05-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r86747.
http://trac.webkit.org/changeset/86747
https://bugs.webkit.org/show_bug.cgi?id=61039
Breaks JSC debugger tests. (Requested by pfeldman on #webkit).
* inspector/InjectedScriptSource.js:
():
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::editScriptSource):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
* inspector/InspectorInstrumentation.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForResourceResponse):
* inspector/ScriptDebugListener.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.scriptForSourceID):
(WebInspector.DebuggerModel.prototype.queryScripts):
(WebInspector.DebuggerModel.prototype.editScriptSource):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource):
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
(WebInspector.PresenationCallFrame):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
* inspector/front-end/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.editSource):
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile.prototype.forceLoadContent):
(WebInspector.SourceFile.prototype._concatenateScriptsContent):
(WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
(WebInspector):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Wed, 18 May 2011 11:03:12 +0000 (11:03 +0000)]
2011-05-18 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
Removed duplcate entries added by r86749
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Wed, 18 May 2011 10:49:14 +0000 (10:49 +0000)]
2011-05-18 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
Since Chromium r85744, tests for <details> element pass on Mac and TEXT mismatch on Linux.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 18 May 2011 10:45:07 +0000 (10:45 +0000)]
2011-05-18 Abhishek Arya <inferno@chromium.org>
Reviewed by Dirk Schulze.
Tests that we do not crash when trying to access a removed
smil element in animated elements list.
https://bugs.webkit.org/show_bug.cgi?id=60980
* svg/animations/smil-element-not-removed-crash-expected.txt: Added.
* svg/animations/smil-element-not-removed-crash.html: Added.
2011-05-18 Abhishek Arya <inferno@chromium.org>
Reviewed by Dirk Schulze.
When SMIL element is getting removed, make sure to remove it
from target's animation elements list.
https://bugs.webkit.org/show_bug.cgi?id=60980
Test: svg/animations/smil-element-not-removed-crash.html
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::~SVGSMILElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 18 May 2011 09:48:35 +0000 (09:48 +0000)]
2011-05-18 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: make "Id" suffixes use consistent case.
https://bugs.webkit.org/show_bug.cgi?id=61028
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::editScriptSource):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
* inspector/InspectorInstrumentation.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForResourceResponse):
* inspector/ScriptDebugListener.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.scriptForSourceID):
(WebInspector.DebuggerModel.prototype.queryScripts):
(WebInspector.DebuggerModel.prototype.editScriptSource):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource):
(WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
(WebInspector.PresenationCallFrame):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
* inspector/front-end/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.editSource):
* inspector/front-end/SourceFile.js:
(WebInspector.SourceFile.prototype.forceLoadContent):
(WebInspector.SourceFile.prototype._concatenateScriptsContent):
(WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
(WebInspector):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Wed, 18 May 2011 09:46:51 +0000 (09:46 +0000)]
2011-05-17 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Enable detailed heap snapshots by default.
https://bugs.webkit.org/show_bug.cgi?id=60286
* inspector/front-end/ProfilesPanel.js:
2011-05-17 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Enable detailed heap snapshots by default.
https://bugs.webkit.org/show_bug.cgi?id=60286
* src/js/DevTools.js:
():
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 18 May 2011 09:45:17 +0000 (09:45 +0000)]
2011-05-18 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: do not reveal line -1 when navigating to anchor without line specified.
https://bugs.webkit.org/show_bug.cgi?id=60971
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showAnchorLocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.showAnchorLocation.):
(WebInspector.ScriptsPanel.prototype.showAnchorLocation):
* inspector/front-end/inspector.js:
(WebInspector._showAnchorLocation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 18 May 2011 09:33:42 +0000 (09:33 +0000)]
2011-05-18 Kent Tamura <tkent@chromium.org>
Reviewed by Hajime Morita.
valueMissing validity for <select> is lame when selecting a value by a key operation
https://bugs.webkit.org/show_bug.cgi?id=61021
Add test cases for the bug.
* fast/forms/ValidityState-valueMissing-002-expected.txt:
* fast/forms/ValidityState-valueMissing-002.html:
2011-05-18 Kent Tamura <tkent@chromium.org>
Reviewed by Hajime Morita.
valueMissing validity for <select> is lame when selecting a value by a key operation
https://bugs.webkit.org/show_bug.cgi?id=61021
We missed updating validity in case that SelectElement::defaultEventHandler
update selections. So, SelectElement::setSelectedIndex() updates validity.
* dom/SelectElement.cpp:
(WebCore::SelectElement::setSelectedIndex): Call SelectElement::updateValidity().
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setSelectedIndex):
Remove unnecessary setNeedsValidityCheck() call.
SelectElement::setSlectedIndex() calls it.
(WebCore::HTMLSelectElement::setSelectedIndexByUser): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Wed, 18 May 2011 09:31:32 +0000 (09:31 +0000)]
2011-05-17 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Make retaining paths list of the Detailed
heap snapshots view resizable.
https://bugs.webkit.org/show_bug.cgi?id=60960
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.resize):
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):
(WebInspector.DetailedHeapshotView.prototype._retainersHeaderDragging):
(WebInspector.DetailedHeapshotView.prototype._endRetainersHeaderDragging):
(WebInspector.DetailedHeapshotView.prototype._updateRetainmentViewHeight):
* inspector/front-end/heapProfiler.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 May 2011 09:10:49 +0000 (09:10 +0000)]
2011-05-18 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
[Qt] Implement layoutTestController.setValueForUser()
https://bugs.webkit.org/show_bug.cgi?id=60956
* platform/qt/Skipped: Unskip fast/forms/onchange-setvalueforuser.html
2011-05-18 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
[Qt] Implement layoutTestController.setValueForUser()
https://bugs.webkit.org/show_bug.cgi?id=60956
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setValueForUser):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-05-18 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
[Qt] Implement layoutTestController.setValueForUser()
https://bugs.webkit.org/show_bug.cgi?id=60956
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setValueForUser):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 18 May 2011 07:38:30 +0000 (07:38 +0000)]
2011-05-16 Jeremy Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Disable keyboard input (with exceptions) in full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=60943
* fullscreen/full-screen-keyboard-disabled-expected.txt: Added.
* fullscreen/full-screen-keyboard-disabled.html: Added.
* fullscreen/full-screen-keyboard-enabled-expected.txt: Added.
* fullscreen/full-screen-keyboard-enabled.html: Added.
2011-05-16 Jeremy Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Disable keyboard input (with exceptions) in full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=60943
Tests: fullscreen/full-screen-keyboard-disabled.html
fullscreen/full-screen-keyboard-enabled.html
* page/EventHandler.cpp:
(WebCore::EventHandler::isKeyEventAllowedInFullScreen): Added. Implements the
list of allowed keyboard events in the proposed API.
(WebCore::EventHandler::keyEvent): Discard events which are not allowed in
full-screen mode.
* page/EventHandler.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Wed, 18 May 2011 07:34:07 +0000 (07:34 +0000)]
2011-05-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed. Fix build break.
* Source/cmake/WebKitMacros.cmake: Add -i option in order to include Lookup.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 18 May 2011 07:19:48 +0000 (07:19 +0000)]
-2011-05-17 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Refactor TextRun creation
https://bugs.webkit.org/show_bug.cgi?id=60255
Add constructTextRun() methods to RenderBlock/InlineTextBox and use it in various places in rendering/.
The long-term goal is to remove the ugly eight parameters catch-it-all TextRun constructor, and
replace it with explicit setters/getters. To avoid expanding dozens of callsites, when removing
the catch-it-all constructor, these helper functions are introduced, which hide the details of
creating a TextRun.
Furthermore it will be used to remove the platform layering violation, that TextRun stores
RenderObject pointers for the sake of SVG Fonts support, see bug 60254.
No change in functionaliy, no new tests.
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
(WebCore::InlineTextBox::constructTextRun):
* rendering/InlineTextBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRunAllowTrailingExpansion):
* rendering/RenderBlock.h:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::setImageSizeForAltText):
(WebCore::RenderImage::paintReplaced):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::getAvgCharWidth):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 18 May 2011 06:16:29 +0000 (06:16 +0000)]
2011-05-17 Jeremy Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Exiting full screen will leave up invisible full-screen window, blocking all mouse clicks.
https://bugs.webkit.org/show_bug.cgi?id=60982
The GraphicsLayer tree has unparented m_fullScreenRootLayer behind our backs, replacing the
tiled layer with a normal one. Instead of holding on to a specific layer, assume that the
w_rootLayer will only have 0 or 1 children, and if a child is present, then that is our full-
screen layer.
Additionally, check to see if the animating layer's presentationLayer is nil
before calling it; asking a nil object for a CATransform3D will give back a struct full of
garbage.
In WKFullScreenWindowController, when the exit animation completes, ignore the "completed"
parameter. This eliminates the possibility that the full screen window will end up left
on top of the screen if the animation is cancelled and a enter full screen animation isn't
forthcoming.
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 18 May 2011 06:12:12 +0000 (06:12 +0000)]
2011-05-17 Jeremy Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Removing a full-screen element or ancestor from the DOM should trigger exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=60997
Updated the following tests with the new expectation that removing an element from the DOM will trigger
full screen mode to exit.
* fullscreen/full-screen-remove-ancestor-expected.txt:
* fullscreen/full-screen-remove-ancestor.html:
* fullscreen/full-screen-remove-children-expected.txt:
* fullscreen/full-screen-remove-children.html:
* fullscreen/full-screen-remove-expected.txt:
* fullscreen/full-screen-remove.html:
2011-05-17 Jeremy Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Removing a full-screen element or ancestor from the DOM should trigger exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=60997
Tests: fullscreen/full-screen-remove-ancestor.html
fullscreen/full-screen-remove-children.html
fullscreen/full-screen-remove.html
* dom/Document.cpp:
(WebCore::Document::fullScreenChangeDelayTimerFired): If the target node was removed from the document
make sure to message the documentElement() as well.
(WebCore::Document::fullScreenElementRemoved): Cancel full screen mode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 18 May 2011 05:50:53 +0000 (05:50 +0000)]
[Qt] Skip failing tests on minor Qt platforms.
* platform/qt-arm/Skipped:
* platform/qt-mac/Skipped:
* platform/qt-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Wed, 18 May 2011 05:22:47 +0000 (05:22 +0000)]
2011-05-17 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
The following tests now pass:
fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-strictcode.html
fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-normalcode.html
fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-strictcode.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 18 May 2011 04:43:44 +0000 (04:43 +0000)]
<rdar://problem/
9458300> REGRESSION (r86724): Repro crash loading any webpage in WebKit2 on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=61022
Reviewed by Alice Liu.
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain): As long as we are not loading the shim on Snow Leopard, we should not
try to initialize it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Wed, 18 May 2011 03:56:41 +0000 (03:56 +0000)]
2011-05-17 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
plugins/windowless_plugin_paint_test.html now passes on Linux, timeouts on Mac.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Wed, 18 May 2011 03:50:34 +0000 (03:50 +0000)]
2011-05-17 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket: Add CLOSING state
https://bugs.webkit.org/show_bug.cgi?id=60878
The value of WebSocket.CLOSED has been changed from 2 to 3, we have to update
expected results of tests that dump WebSocket.readyState.
* fast/dom/Window/window-properties-expected.txt:
* http/tests/websocket/tests/bufferedAmount-after-close-expected.txt:
* http/tests/websocket/tests/close-on-unload-reference-in-parent-expected.txt:
* http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
* http/tests/websocket/tests/handshake-error-expected.txt:
* http/tests/websocket/tests/script-tests/bufferedAmount-after-close.js:
(ws.onclose):
* http/tests/websocket/tests/script-tests/handshake-error.js:
(ws.onclose):
* http/tests/websocket/tests/send-after-close-on-unload-expected.txt:
* http/tests/websocket/tests/send-after-close-on-unload.html:
* http/tests/websocket/tests/simple-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
2011-05-17 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket: Add CLOSING state
https://bugs.webkit.org/show_bug.cgi?id=60878
No new tests are added because there is no change in functionality.
* platform/network/SocketStreamHandleBase.h:
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Wed, 18 May 2011 03:47:01 +0000 (03:47 +0000)]
2011-05-17 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
plugins/invalidate_rect.html now passes on Linux.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 18 May 2011 03:23:10 +0000 (03:23 +0000)]
Rolled out attempts to fix EFL build because they're not enough -- the
build script needs to be fixed.
* runtime/BooleanPrototype.cpp:
* runtime/DateConstructor.cpp:
* runtime/ErrorPrototype.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 18 May 2011 03:07:23 +0000 (03:07 +0000)]
More attempts to work around the EFL build system being borken.
* runtime/DateConstructor.cpp:
* runtime/ErrorPrototype.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 18 May 2011 03:03:42 +0000 (03:03 +0000)]
Try to fix the EFL build.
* runtime/BooleanPrototype.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 18 May 2011 02:39:00 +0000 (02:39 +0000)]
Source/JavaScriptCore: Rolling back in r86653 with build fixed.
Reviewed by Gavin Barraclough and Oliver Hunt.
Global object initialization is expensive
https://bugs.webkit.org/show_bug.cgi?id=60933
Changed a bunch of globals to allocate their properties lazily, and changed
the global object to allocate a bunch of its globals lazily.
This reduces the footprint of a global object from 287 objects with 58
functions for 24K to 173 objects with 20 functions for 15K.
Large patch, but it's all mechanical.
* DerivedSources.make:
* JavaScriptCore.exp: Build!
* create_hash_table: Added a special case for fromCharCode, since it uses
a custom "thunk generator".
* heap/Heap.cpp:
(JSC::TypeCounter::operator()): Fixed a bug where the type counter would
overcount objects that were owned through more than one mechanism because
it was getting in the way of counting the results for this patch.
* interpreter/CallFrame.h:
(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectPrototypeTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable): Added new tables.
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::createStructure):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::createStructure):
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DateConstructor.h:
(JSC::DateConstructor::createStructure):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::createStructure): Standardized these objects
to use static tables for function properties.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h: Added new tables.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
* runtime/JSGlobalObject.h:
* runtime/JSGlobalObjectFunctions.cpp:
* runtime/JSGlobalObjectFunctions.h: Changed JSGlobalObject to use a
static table for its global functions. This required uninlining some
things to avoid a circular header dependency. However, those things
probably shouldn't have been inlined in the first place.
Even more global object properties can be made lazy, but that requires
more in-depth changes.
* runtime/MathObject.cpp:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/NumberPrototype.h:
(JSC::NumberPrototype::createStructure):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::createStructure):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::createStructure):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringConstructor.h:
(JSC::StringConstructor::createStructure): Standardized these objects
to use static tables for function properties.
LayoutTests: Global object initialization is expensive
https://bugs.webkit.org/show_bug.cgi?id=60933
Reviewed by Gavin Barraclough.
Added a few more expected failures, now that more code uses static hash
tables.
The fact that built-ins are not deletable, but should be, is covered by
https://bugs.webkit.org/show_bug.cgi?id=61014
* sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.2/S15.6.2.1_A4-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.3/15.6.3.1_Boolean.prototype/S15.6.3.1_A1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.4/S15.6.4_A1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.2/S15.7.2.1_A4-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.3/15.7.3.1_Number.prototype/S15.7.3.1_A2_T1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.4/S15.7.4_A1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.2_Date.parse/S15.9.4.2_A1_T2-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.3_Date.UTC/S15.9.4.3_A1_T2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 18 May 2011 01:48:39 +0000 (01:48 +0000)]
2011-05-16 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
[Refactoring] ShadowContentElement should be part of dom/
https://bugs.webkit.org/show_bug.cgi?id=59117
- Moved html/shadow/ShadowContentElement.h to dom/ShadowContentElement.h
- Pulled ShadowContentElement up to a subclass of StyledElement, from HTMLDivElement
- Added ShadowContentElement.cpp
- Extracted ShadowContentSelector.{cpp,h} from ShadowRoot.{cpp,h}
No new tests, no behavior change.
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp: Added new ShadowContentSelector.cpp and ShadowContentElement.cpp.
* dom/Node.h:
(WebCore::Node::forceReattach): Moved from static local function to share between classes.
* dom/ShadowContentElement.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h.
(WebCore::ShadowContentElement::attach):
* dom/ShadowContentElement.h: Copied from Source/WebCore/html/shadow/ShadowContentElement.h.
(WebCore::ShadowContentElement::ShadowContentElement):
(WebCore::ShadowContentElement::isShadowBoundary):
(WebCore::ShadowContentElement::rendererIsNeeded):
(WebCore::ShadowContentElement::createRenderer):
* dom/ShadowContentSelector.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h.
(WebCore::ShadowContentSelector::ShadowContentSelector):
(WebCore::ShadowContentSelector::~ShadowContentSelector):
(WebCore::ShadowContentSelector::attachChildrenFor):
* dom/ShadowContentSelector.h: Renamed from Source/WebCore/html/shadow/ShadowContentElement.h.
(WebCore::ShadowContentSelector::shadowRoot):
(WebCore::ShadowContentSelector::activeElement):
(WebCore::ShadowContentSelector::currentInstance):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::recalcStyle):
* html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
* html/HTMLSummaryElement.cpp:
(WebCore::SummaryContentElement::SummaryContentElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdn@chromium.org [Wed, 18 May 2011 00:53:22 +0000 (00:53 +0000)]
2011-05-17 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Clear the image from ImageLoader rather than clearing the ImageLoader in HTMLObjectElement::renderFallbackContent.
https://bugs.webkit.org/show_bug.cgi?id=61005
Test: http/tests/loading/nested_bad_objects.php
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderFallbackContent):
2011-05-17 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Tests for crash when two nested image objects with invalid data are loaded.
https://bugs.webkit.org/show_bug.cgi?id=61005
* http/tests/loading/nested_bad_objects-expected.txt: Added.
* http/tests/loading/nested_bad_objects.php: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 18 May 2011 00:29:36 +0000 (00:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60595
Fix the rampant WebProcess crashing because we're trying to install the WebProcess shim
into QTKitServer when we launch it.
Rubberstamped by Sam Weinig.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): This is only happening on SnowLeopard, so put
SnowLeopard build guards around the shim install path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 18 May 2011 00:21:33 +0000 (00:21 +0000)]
2011-05-17 Adam Barth <abarth@webkit.org>
Rubber-stamped by Simon Fraser.
Remove empty directory.
* fast/inspector: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Wed, 18 May 2011 00:12:46 +0000 (00:12 +0000)]
2011-05-17 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Make sure that AudioNode gets re-enabled after having been disconnected and re-connected.
https://bugs.webkit.org/show_bug.cgi?id=60995
No new tests since audio API is not yet implemented.
* webaudio/AudioNode.cpp:
(WebCore::AudioNode::ref):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 May 2011 00:08:47 +0000 (00:08 +0000)]
2011-05-17 Tao Bai <michaelbai@chromium.org>
Reviewed by Darin Fisher.
Clear deprecated icon APIs from chromium port.
https://bugs.webkit.org/show_bug.cgi?id=60989
* public/WebFrame.h: Removed faviconURL()
* public/WebFrameClient.h: Removed didChangeIcons()
* src/FrameLoaderClientImpl.cpp:
Removed the code to support deprecated API
(WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
* src/WebFrameImpl.cpp: Removed faviconURL()
* src/WebFrameImpl.h: Removed faviconURL()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 17 May 2011 23:42:36 +0000 (23:42 +0000)]
2011-05-17 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/
9366728> and https://webkit.org/b/60796
Crash when code inside a ResourceLoadDelegate method calls [WebView stopLoading:]
Break up ResourceLoader::didCancel() into willCancel() and didCancel(), and making them pure virtual.
This change has the following benefits:
- Managing ResourceLoader state can be in the base class; Subclasses no longer need to protect
themselves, check these variables as often, or ASSERT them.
- ResourceLoader subclasses no longer have to call the base class ::didCancel
- ResourceLoader::cancel becomes more capable of handling reentrancy with the design that the
cancellation is completed inside the last call.
No new tests - No change in behavior for previous tests, and new test would require API usage outside
the scope of DumpRenderTree.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::ResourceLoader):
(WebCore::ResourceLoader::cancel): Moved from ResourceLoader::didCancel, and does all of that same work
except it interposes calls to "willCancel" and "didCancel" as required to maintain the same behavior.
* loader/ResourceLoader.h: Added pure virtual didCancel() and willCancel().
Split-up into willCancel() and didCancel(), based on when the base class didCancel() used to be called:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::willCancel):
(WebCore::MainResourceLoader::didCancel):
* loader/MainResourceLoader.h:
Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:
* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Call the entry point cancel() instead of the old didCancel()
(WebCore::NetscapePlugInStreamLoader::willCancel):
(WebCore::NetscapePlugInStreamLoader::didCancel):
* loader/NetscapePlugInStreamLoader.h:
Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willCancel):
(WebCore::SubresourceLoader::didCancel):
* loader/SubresourceLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 May 2011 23:39:57 +0000 (23:39 +0000)]
2011-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r86668.
http://trac.webkit.org/changeset/86668
https://bugs.webkit.org/show_bug.cgi?id=61001
It made 52 tests crash on Qt WK2 bot (Requested by Ossy on
#webkit).
* UIProcess/API/qt/qgraphicswkview.cpp:
* UIProcess/API/qt/qgraphicswkview.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::createDrawingAreaProxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Tue, 17 May 2011 23:21:39 +0000 (23:21 +0000)]
Build fix after r86717.
* UIProcess/API/C/win/WKView.h: Add a forward declaration of IDropTarget
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Tue, 17 May 2011 23:15:06 +0000 (23:15 +0000)]
WebKit2: Needs API to set a custom drop target
https://bugs.webkit.org/show_bug.cgi?id=60991
<rdar://problem/
9090868>
Reviewed by Adam Roben.
Add API to set a custom drop target on a WKView.
* UIProcess/API/C/win/WKView.cpp:
(WKViewSetCustomDropTarget): Call through to WebView::setCustomDropTarget.
* UIProcess/API/C/win/WKView.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::setCustomDropTarget): Revoke the current drop target, and register the
custom one.
* UIProcess/win/WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 17 May 2011 23:10:14 +0000 (23:10 +0000)]
2011-05-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Enrica Casucci.
editing/pasteboard/paste-blockquote-2.html and paste-blockquote-3.html should be dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=60998
Converted the tests.
* editing/pasteboard/paste-blockquote-2-expected.txt: Added.
* editing/pasteboard/paste-blockquote-2.html:
* editing/pasteboard/paste-blockquote-3-expected.txt: Added.
* editing/pasteboard/paste-blockquote-3.html:
* platform/chromium-linux/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
* platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
* platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 17 May 2011 23:03:43 +0000 (23:03 +0000)]
2011-05-17 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Enrica Casucci.
editing/pasteboard/paste-text-012.html should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=60996
Converted the test.
* editing/pasteboard/paste-text-012-expected.txt: Added.
* editing/pasteboard/paste-text-012.html:
* platform/chromium-linux/editing/pasteboard/paste-text-012-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-012-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-012-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-text-012-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-text-012-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/paste-text-012-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-012-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-text-012-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-text-012-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 17 May 2011 22:49:36 +0000 (22:49 +0000)]
2011-05-17 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Add API to determine if a frame has any form elements without going to javascript
https://bugs.webkit.org/show_bug.cgi?id=60999
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameContainsAnyFormElements):
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormElements):
* WebProcess/WebPage/WebFrame.h:
Add WKBundleFrameContainsAnyFormElements which does a walk of the document to determine
if there are any form elements.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 May 2011 22:34:22 +0000 (22:34 +0000)]
2011-05-17 Nat Duca <nduca@chromium.org>
Reviewed by James Robinson.
[chromium] Always set layerRenderer, even on non-drawn-layers
https://bugs.webkit.org/show_bug.cgi?id=60977
This is a defensive fixe for crbug.com/82799, in which
a RenderLayer could not prepare itself because its owning layerImpl
had no associated layerRenderer. The underlying issue is that we
sometimes put renderSurfaces onto the list that won't actually render.
For now, the priority is to reduce fragility so that invisible layers
dont lead to crashers. We do this by being more agressive about
binding CCLayerImpls to the LayerRenderer, doing it all the time rather
than only when we think it will get rendered.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::paintLayerContents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 17 May 2011 22:32:47 +0000 (22:32 +0000)]
2011-05-17 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
JSGlobalContextRelease should not trigger a synchronous garbage collection
https://bugs.webkit.org/show_bug.cgi?id=60990
* API/JSContextRef.cpp:
Change synchronous call to collectAllGarbage to a call to trigger the
activityCallback.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Tue, 17 May 2011 22:07:53 +0000 (22:07 +0000)]
2011-05-17 Daniel Cheng <dcheng@chromium.org>
Reviewed by Ryosuke Niwa.
[chromium] Clipboard policy callbacks from EditorClientImpl are reversed
https://bugs.webkit.org/show_bug.cgi?id=60994
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::canCopyCut):
(WebKit::EditorClientImpl::canPaste):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Tue, 17 May 2011 22:00:31 +0000 (22:00 +0000)]
2011-05-17 Robert Hogan <robert@webkit.org>
Rubber-stamped by Csaba Osztrogonac.
[Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
Skip on qt-mac
http://bugs.webkit.org/show_bug.cgi?id=60838
* platform/qt-mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 17 May 2011 21:45:07 +0000 (21:45 +0000)]
Fix the clang build.
* rendering/RenderText.h:
(WebCore::RenderText::nodeAtPoint):
nodeAtPoint should take a const IntPoint reference.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Tue, 17 May 2011 21:33:23 +0000 (21:33 +0000)]
2011-05-17 Erik Arvidsson <arv@chromium.org>
Reviewed by Ryosuke Niwa.
document.activeElement doesn't point to the focused frame
https://bugs.webkit.org/show_bug.cgi?id=49509
This tests that an iframe is the activeElement when focus is inside that frame.
* fast/dom/HTMLDocument/active-element-frames-expected.txt: Added.
* fast/dom/HTMLDocument/active-element-frames.html: Added.
2011-05-17 Erik Arvidsson <arv@chromium.org>
Reviewed by Ryosuke Niwa.
document.activeElement doesn't point to the focused frame
https://bugs.webkit.org/show_bug.cgi?id=49509
This makes us match IE and Firefox and there is an ongoing WHATWG discussion to make the spec match this.
Test: fast/dom/HTMLDocument/active-element-frames.html
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::activeElement): Walk up the frame tree from the focusedFrame to find the active frame if any.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Tue, 17 May 2011 20:57:56 +0000 (20:57 +0000)]
2011-05-16 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
plugins/invalidate_rect.html fails on linux ports
https://bugs.webkit.org/show_bug.cgi?id=54051
* platform/qt/Skipped: Unskip plugins/invalidate_rect.html
* platform/qt-mac/Skipped: Skip plugins/invalidate_rect.html
2011-05-16 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
plugins/invalidate_rect.html fails on linux ports
Add ChromeClientQt::allowsAcceleratedCompositing().
https://bugs.webkit.org/show_bug.cgi?id=54051
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::allowsAcceleratedCompositing):
* WebCoreSupport/ChromeClientQt.h:
2011-05-16 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
plugins/invalidate_rect.html fails on linux ports
- Make the unix test netscape plugin recognize the onPaintEvent
and windowedPlugin parameters.
https://bugs.webkit.org/show_bug.cgi?id=54051
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventX11):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::displayInvalidatedRegion):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_instance):
(webkit_test_plugin_handle_event):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 17 May 2011 20:57:28 +0000 (20:57 +0000)]
2011-05-17 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Change nodeAtPoint to take IntPoint instead of int x, int y
https://bugs.webkit.org/show_bug.cgi?id=60663
Change nodeAtPoint to take a single const IntPoint& instead of a pair of
ints for the location.
Covered by existing tests.
* platform/graphics/FloatPoint.h:
(WebCore::flooredIntPoint):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::nodeAtPoint):
* rendering/EllipsisBox.h:
* rendering/InlineBox.cpp:
(WebCore::InlineBox::nodeAtPoint):
* rendering/InlineBox.h:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
* rendering/InlineTextBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestContents):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
* rendering/RenderBox.h:
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::nodeAtPoint):
* rendering/RenderFrameSet.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):
* rendering/RenderImage.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::nodeAtPoint):
* rendering/RenderInline.h:
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::hitTest):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::nodeAtPoint):
* rendering/RenderListBox.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::hitTest):
(WebCore::RenderObject::nodeAtPoint):
* rendering/RenderObject.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
* rendering/RenderTable.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::nodeAtPoint):
* rendering/RenderTableRow.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
* rendering/RenderTableSection.h:
* rendering/RenderText.h:
(WebCore::RenderText::nodeAtPoint):
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::nodeAtPoint):
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
* rendering/RenderTextControlSingleLine.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::nodeAtPoint):
* rendering/RenderWidget.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::nodeAtPoint):
* rendering/RootInlineBox.h:
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
(WebCore::RenderSVGForeignObject::nodeAtPoint):
* rendering/svg/RenderSVGForeignObject.h:
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::nodeAtPoint):
* rendering/svg/RenderSVGModelObject.h:
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):
* rendering/svg/RenderSVGRoot.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::nodeAtFloatPoint):
(WebCore::RenderSVGText::nodeAtPoint):
* rendering/svg/RenderSVGText.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Tue, 17 May 2011 20:39:18 +0000 (20:39 +0000)]
2011-05-17 Andrew Wilson <atwilson@chromium.org>
Unreviewed, rolling out r86647.
http://trac.webkit.org/changeset/86647
https://bugs.webkit.org/show_bug.cgi?id=56814
Broke tests downstream in Chromium
* dom/DocumentMarker.h:
(WebCore::DocumentMarker::operator==):
(WebCore::DocumentMarker::operator!=):
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::copyMarkers):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::markersInRange):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::removeMarkersFromList):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::shiftMarkers):
(WebCore::DocumentMarkerController::setMarkersActive):
(WebCore::DocumentMarkerController::hasMarkers):
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
(WebCore::DocumentMarkerController::showMarkers):
* dom/DocumentMarkerController.h:
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
* editing/Editor.cpp:
(WebCore::Editor::selectionStartHasMarkerFor):
* editing/SpellingCorrectionController.cpp:
(WebCore::SpellingCorrectionController::respondToChangedSelection):
* editing/SpellingCorrectionController.h:
(WebCore::SpellingCorrectionController::shouldStartTimerFor):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::spellingToolTip):
(WebCore::HitTestResult::replacedString):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintDocumentMarkers):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
2011-05-17 Andrew Wilson <atwilson@chromium.org>
Unreviewed, rolling out r86647.
http://trac.webkit.org/changeset/86647
https://bugs.webkit.org/show_bug.cgi?id=56814
Broke tests downstream in Chromium
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::addMarker):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Tue, 17 May 2011 20:38:23 +0000 (20:38 +0000)]
2011-05-17 Andrew Wilson <atwilson@chromium.org>
Unreviewed, rolling out r86656.
http://trac.webkit.org/changeset/86656
Broke tests downstream in Chromium
* editing/SpellingCorrectionController.cpp:
(WebCore::markersHaveIdenticalDescription):
(WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
(WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 17 May 2011 20:30:42 +0000 (20:30 +0000)]
2011-05-17 Tony Chang <tony@chromium.org>
Land linux 32 bit results.
* platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.txt: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
* platform/chromium-linux-x86/svg/css/composite-shadow-example-expected.txt: Added.
* platform/chromium-linux-x86/svg/css/composite-shadow-with-opacity-expected.txt: Added.
* platform/chromium-linux-x86/svg/css/stars-with-shadow-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
* platform/chromium-linux-x86/svg/hixie/perf/001-expected.png: Added.
* platform/chromium-linux-x86/svg/hixie/perf/001-expected.txt: Added.
* platform/chromium-linux-x86/svg/hixie/perf/002-expected.png: Added.
* platform/chromium-linux-x86/svg/hixie/perf/002-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Tue, 17 May 2011 20:26:11 +0000 (20:26 +0000)]
Unreviewed chromium test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 May 2011 20:04:41 +0000 (20:04 +0000)]
2011-05-17 Yufeng Shen <miletus@chromium.org>
Reviewed by Darin Fisher.
Make WebKit expose extra touch information
https://bugs.webkit.org/show_bug.cgi?id=59030
* fast/events/touch/document-create-touch-expected.txt:
* fast/events/touch/script-tests/document-create-touch.js:
2011-05-17 Yufeng Shen <miletus@chromium.org>
Reviewed by Darin Fisher.
Make WebKit expose extra touch information
https://bugs.webkit.org/show_bug.cgi?id=59030
* dom/Document.cpp:
(WebCore::Document::createTouch):
* dom/Document.h:
* dom/Document.idl:
* dom/Touch.cpp:
(WebCore::Touch::Touch):
* dom/Touch.h:
(WebCore::Touch::create):
(WebCore::Touch::webkitRadiusX):
(WebCore::Touch::webkitRadiusY):
(WebCore::Touch::webkitRotationAngle):
* dom/Touch.idl:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
* platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::radiusX):
(WebCore::PlatformTouchPoint::radiusY):
(WebCore::PlatformTouchPoint::rotationAngle):
2011-05-17 Yufeng Shen <miletus@chromium.org>
Reviewed by Darin Fisher.
Make WebKit expose extra touch information
https://bugs.webkit.org/show_bug.cgi?id=59030
* public/WebTouchPoint.h:
(WebKit::WebTouchPoint::WebTouchPoint):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 17 May 2011 20:02:41 +0000 (20:02 +0000)]
2011-05-16 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Reduce code size for inline cache
https://bugs.webkit.org/show_bug.cgi?id=60942
This patch introduces the concept of a "compact" address that
allows individual architectures to control the maximum offset
used for the inline path of get_by_id. This reduces the code
size of get_by_id by 3 bytes on x86 and x86_64 and slightly
improves performance on v8 tests.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::repatchCompact):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::repatchCompact):
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::DataLabelCompact::DataLabelCompact):
(JSC::AbstractMacroAssembler::differenceBetween):
(JSC::AbstractMacroAssembler::repatchCompact):
* assembler/CodeLocation.h:
(JSC::CodeLocationDataLabelCompact::CodeLocationDataLabelCompact):
(JSC::CodeLocationCommon::dataLabelCompactAtOffset):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::locationOf):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::repatchCompact):
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::loadPtrWithCompactAddressOffsetPatch):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load32WithCompactAddressOffsetPatch):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load32WithCompactAddressOffsetPatch):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load32WithAddressOffsetPatch):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::repatchCompact):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::loadCompactWithAddressOffsetPatch):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::loadPtrWithCompactAddressOffsetPatch):
* assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::repatch):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::repatchCompact):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movl_mr_disp8):
(JSC::X86Assembler::movq_mr_disp8):
(JSC::X86Assembler::repatchCompact):
(JSC::X86Assembler::setInt8):
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp8):
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp8):
(JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 17 May 2011 19:45:24 +0000 (19:45 +0000)]
2011-05-17 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Add a LineLayoutState object to hold global state during line layout
https://bugs.webkit.org/show_bug.cgi?id=60113
Like LayoutState for layout(), LineLayoutState keeps track of global information
during an entire linebox tree layout pass (aka layoutInlineChildren).
For now it just holds isFullLayout and the logicalRepaintTop/Bottom.
It's possible we should hold the useRepaintBounds bool as well as
the startLine and endLine RootInlineBox pointers.
No change in behavior, thus no tests.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::markForFullLayout):
(WebCore::LineLayoutState::isFullLayout):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::LineLayoutState::startLine):
(WebCore::LineLayoutState::endLine):
(WebCore::deleteLineRange):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::determineEndPosition):
(WebCore::RenderBlock::matchedEndLine):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Tue, 17 May 2011 19:35:37 +0000 (19:35 +0000)]
2011-05-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Simplify syntax in test code to make prepare-ChangeLog less confused
https://bugs.webkit.org/show_bug.cgi?id=60978
Backslash to escape newlines was confusing both prepare-ChangeLog and the
QtCreator highlight system.
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::evalJSV):
Remove usage of backslash to escape newlines in string literal.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 17 May 2011 19:29:25 +0000 (19:29 +0000)]
2011-05-17 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=60895
Update the tools to handle the move. Lucid 32 results now go in
chromium-linux-x86 and the default platform on Linux is now x86_64.
* Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
* Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
* Scripts/webkitpy/layout_tests/port/base.py: ditto
* Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
* Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 17 May 2011 19:26:11 +0000 (19:26 +0000)]
2011-05-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Area element doesn't update region when dynamically altered.
https://bugs.webkit.org/show_bug.cgi?id=54636
* fast/images/imagemap-dynamic-area-updates-expected.txt: Added.
* fast/images/imagemap-dynamic-area-updates.html: Added.
* fast/images/script-tests/imagemap-dynamic-area-updates.js: Added.
(setArea):
(checkForArea):
2011-05-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Area element doesn't update region when dynamically altered.
https://bugs.webkit.org/show_bug.cgi?id=54636
Recompute the clickable region after the "shape" or "coords" attribute
of an area element is changed.
Test: fast/images/imagemap-dynamic-area-updates.html
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::parseMappedAttribute):
(WebCore::HTMLAreaElement::invalidateCachedRegion):
* html/HTMLAreaElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 17 May 2011 19:00:51 +0000 (19:00 +0000)]
2011-05-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Initial support for favicons.
https://bugs.webkit.org/show_bug.cgi?id=58937
Add the following API to QWKContext:
- void setIconDatabasePath(QString)
- void iconChangedForPageURL(QUrl) [signal]
- QIcon iconForPageURL(QUrl)
This is mostly analogous to the QWebSettings/QWebFrame icon API we had in WebKit1.
* UIProcess/API/qt/ClientImpl.h: Added WKIconDatabaseClient methods.
* UIProcess/API/qt/ClientImpl.cpp:
(toQWKContext): Helper to cast from "void* clientInfo" to a QWKContext*.
(qt_wk_didChangeIconForPageURL): Emits QWKContext::iconChangedForPageURL(QUrl).
(qt_wk_didRemoveAllIcons): Stub.
* UIProcess/API/qt/qwkcontext.h:
* UIProcess/API/qt/qwkcontext_p.h:
* UIProcess/API/qt/qwkcontext.cpp:
(QWKContextPrivate::QWKContextPrivate): Set up and register a WKIconDatabaseClient.
(QWKContext::QWKContext): Minor refactor to avoid code duplication in constructors.
(QWKContext::setIconDatabasePath): Exactly what it sounds like.
(QWKContext::iconForPageURL): Retrieves the favicon for a given page URL as a QIcon.
* WebKit2API.pri: Add WKIconDatabase.cpp and WKIconDatabase.h to build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Tue, 17 May 2011 19:00:37 +0000 (19:00 +0000)]
[Qt] Redirection of HTTP POST (3xx) incorrectly includes original POST data
https://bugs.webkit.org/show_bug.cgi?id=60440
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Makes sure that the HTTP headers Content-type and Content-length are not included in
the requests that do not have any content.
Tests: http/tests/navigation/post-301-response.html
http/tests/navigation/post-302-response.html
http/tests/navigation/post-303-response.html
http/tests/navigation/post-307-response.html
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
LayoutTests:
These new tests check that no POST content is sent to the new URL after receiving http
status codes 301, 302 and 303, and checks that the POST content is sent to the new URL
after receiving a 307 http status code.
* http/tests/navigation/post-301-response-expected.txt: Added.
* http/tests/navigation/post-301-response.html: Added.
* http/tests/navigation/post-302-response-expected.txt: Added.
* http/tests/navigation/post-302-response.html: Added.
* http/tests/navigation/post-303-response-expected.txt: Added.
* http/tests/navigation/post-303-response.html: Added.
* http/tests/navigation/post-307-response-expected.txt: Added.
* http/tests/navigation/post-307-response.html: Added.
* http/tests/navigation/resources/redirected-post-request-contents.php: Added.
* http/tests/navigation/resources/redirection-response.php: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 17 May 2011 18:57:54 +0000 (18:57 +0000)]
Part 4 of <rdar://problem/
8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess
Reviewed by Anders Carlsson.
This patch actually hooks up the shim to the WebProcess shim callbacks, which messages these
4 calls up to the UIProcess and returns the result.
Note that this patch uncovered the fact that CoreIPC can't sync message out from a secondary thread,
so I filed https://bugs.webkit.org/show_bug.cgi?id=60975 as a followup to allow that.
* Shared/mac/SecItemResponseData.cpp:
(WebKit::SecItemResponseData::SecItemResponseData): Reorder the constructor arguments to be
a little cleaner.
* Shared/mac/SecItemResponseData.h:
Call the shim callbacks for each method:
* WebProcess/mac/WebProcessShim.mm:
(WebKit::shimSecItemCopyMatching):
(WebKit::shimSecItemAdd):
(WebKit::shimSecItemUpdate):
(WebKit::shimSecItemDelete):
Implement the shim callbacks, which each marshall to the main thread, which then calls out to CoreIPC:
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebSecItemCopyMatchingMainThread):
(WebKit::WebSecItemCopyMatching):
(WebKit::WebSecItemAddOnMainThread):
(WebKit::WebSecItemAdd):
(WebKit::WebSecItemUpdateOnMainThread):
(WebKit::WebSecItemUpdate):
(WebKit::WebSecItemDeleteOnMainThread):
(WebKit::WebSecItemDelete):
Add the 4 messages and their implementations in the UIProcess:
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
* UIProcess/mac/WebProcessProxyMac.mm: Added.
(WebKit::WebProcessProxy::secItemCopyMatching):
(WebKit::WebProcessProxy::secItemAdd):
(WebKit::WebProcessProxy::secItemUpdate):
(WebKit::WebProcessProxy::secItemDelete):
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 17 May 2011 18:37:32 +0000 (18:37 +0000)]
2011-05-17 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] GraphicsLayerQtImpl: Remove an unused variable.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 17 May 2011 18:08:02 +0000 (18:08 +0000)]
2011-05-17 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Incomplete page painting at dropbox.com
https://bugs.webkit.org/show_bug.cgi?id=60974
<rdar://problem/
9448213>
When we're exiting compositing mode and haven't sent an EnterAcceleratedCompositingMode
message to the UI process, we still need to send the updated bits to the ui process.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 17 May 2011 18:06:20 +0000 (18:06 +0000)]
Part 3 of <rdar://problem/
8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess
Reviewed by Anders Carlsson.
Add CoreIPC stuff we'll need to marshall the SecItem calls to the UIProcess and back.
Teach ArgumentCodersCF about CFDateRef, SecKeychainItemRef, and generic CFTypeRefs:
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::typeFromCFTypeRef):
(CoreIPC::encode):
(CoreIPC::decode):
* Shared/cf/ArgumentCodersCF.h:
Serializable object that contains the query CFDictionaryRef and optionally the
"attributesToMatch" CFDictionaryRef:
* Shared/mac/SecItemRequestData.cpp: Added.
(WebKit::SecItemRequestData::SecItemRequestData):
(WebKit::SecItemRequestData::encode):
(WebKit::SecItemRequestData::decode):
* Shared/mac/SecItemRequestData.h: Added.
(WebKit::SecItemRequestData::query):
(WebKit::SecItemRequestData::attributesToMatch):
Serializable object that returns an OSStatus and optionally a "result object" CFTypeRef:
* Shared/mac/SecItemResponseData.cpp: Added.
(WebKit::SecItemResponseData::SecItemResponseData):
(WebKit::SecItemResponseData::encode):
(WebKit::SecItemResponseData::decode):
* Shared/mac/SecItemResponseData.h: Added.
(WebKit::SecItemResponseData::resultObject):
(WebKit::SecItemResponseData::resultCode):
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 17 May 2011 17:39:59 +0000 (17:39 +0000)]
Part 2 of <rdar://problem/
8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess
Reviewed by Anders Carlsson.
Hookup some of the methods we plan to shim in the patch, but just have them call through
to the actual implementations for now.
Also stub-out the future shimmed versions of the methods.
* WebProcess/mac/WebProcessShim.h: Add the methods to the shim callbacks.
* WebProcess/mac/WebProcessShim.mm:
(WebKit::shimSecItemCopyMatching): Call through to the actual function for now.
(WebKit::shimSecItemAdd): Ditto.
(WebKit::shimSecItemUpdate): Ditto.
(WebKit::shimSecItemDelete): Ditto.
(WebKit::WebKitWebProcessShimInitialize): Copy over the shim callbacks.
* WebKit2.xcodeproj/project.pbxproj: Link the shim to required frameworks.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebSecItemCopyMatching): Add placeholders for the future to-be-shimmed functions.
(WebKit::WebSecItemAdd): Ditto.
(WebKit::WebSecItemUpdate): Ditto.
(WebKit::WebSecItemDelete): Ditto.
(WebKit::WebProcess::initializeShim): Pass along those placeholders to the shim initializer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 17 May 2011 17:27:19 +0000 (17:27 +0000)]
2011-05-17 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: navigating from elements panel does not show source view.
https://bugs.webkit.org/show_bug.cgi?id=60970
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.highlightLine):
(WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 May 2011 17:25:15 +0000 (17:25 +0000)]
2011-05-17 Sakamuri Ramakrishna <ramakrishna.sakamuri@nokia.com>
Reviewed by Andreas Kling.
[Qt] 4 of the skipped storage layout tests pass on Qt Linux- skip list to be modified
https://bugs.webkit.org/show_bug.cgi?id=60715
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Tue, 17 May 2011 17:23:35 +0000 (17:23 +0000)]
2011-05-17 Anton Muhin <antonm@chromium.org>
Unreviewed.
Improving test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 17 May 2011 17:16:26 +0000 (17:16 +0000)]
2011-05-17 Sam Magnuson <smagnuson@netflix.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Node that have both an opacity and a transform animation on them seem not to fire.
https://bugs.webkit.org/show_bug.cgi?id=40841
Test: compositing/animation/busy-indicator.html
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::recache):
(WebCore::GraphicsLayerQtImpl::flushChanges):
(WebCore::GraphicsLayerQt::setContentsToImage):
(WebCore::TransformAnimationQt::getAnimatedProperty):
(WebCore::OpacityAnimationQt::getAnimatedProperty):
(WebCore::GraphicsLayerQt::addAnimation):
2011-05-17 Sam Magnuson <smagnuson@netflix.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Node that have both an opacity and a transform animation on them seem not to fire.
https://bugs.webkit.org/show_bug.cgi?id=40841
* compositing/animation/busy-indicator-no.png: Added.
* compositing/animation/busy-indicator.html: Added.
* compositing/animation/busy-indicator.png: Added.
* compositing/animation/busy-indicator-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 May 2011 17:13:03 +0000 (17:13 +0000)]
2011-05-17 Grace Kloba <klobag@chromium.org>
Reviewed by Kenneth Russell.
GraphicsContext3DSkia needs to honor the platform Sk_x_SHIFT value instead of assuming BGRA color
https://bugs.webkit.org/show_bug.cgi?id=60965
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 17 May 2011 17:12:37 +0000 (17:12 +0000)]
Part one of <rdar://problem/
8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess
Reviewed by Anders Carlsson.
Add am empty shim for a new WebProcess shim and install it at launch.
Use the same Shim.xcconfig for both the web and plugin processes:
* Configurations/PluginProcessShim.xcconfig: Removed.
* Configurations/Shim.xcconfig: Copied from Configurations/PluginProcessShim.xcconfig.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebProcess.h: Add initializeShim() for Mac-only
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::initializeShim): Initialize the (empty) shim callbacks.
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain): Call initializeShim()
* WebProcess/mac/WebProcessShim.h: Added.
* WebProcess/mac/WebProcessShim.mm: Added.
(WebKit::WebKitWebProcessShimInitialize): Empty for now.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Install the Plugin Process shim for plugin processes
and the WebProcess shim for the web content process.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 17 May 2011 17:05:55 +0000 (17:05 +0000)]
2011-05-17 Andreas Kling <kling@webkit.org>
Bot-matching rebaseline after r86675.
* platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Tue, 17 May 2011 16:57:11 +0000 (16:57 +0000)]
Loose end from fix for https://bugs.webkit.org/show_bug.cgi?id=60938
Reviewed by Adam Roben.
* WebKit2.xcodeproj/project.pbxproj:
Made new header file "private" instead of "project" so clients can access it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 May 2011 16:34:39 +0000 (16:34 +0000)]
2011-05-17 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] rebaseline skipped tests after r83871
https://bugs.webkit.org/show_bug.cgi?id=60961
Rebaseline tests after r83871 and remove them from Qt Skipped file.
* platform/qt/Skipped:
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt:
* platform/qt/http/tests/misc/error404-expected.txt:
* platform/qt/http/tests/misc/frame-access-during-load-expected.txt:
* platform/qt/http/tests/misc/generated-content-inside-table-expected.txt:
* platform/qt/http/tests/misc/iframe404-expected.txt:
* platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt:
* platform/qt/http/tests/uri/css-href-expected.txt:
* platform/qt/tables/layering/paint-test-layering-1-expected.txt:
* platform/qt/tables/layering/paint-test-layering-2-expected.txt:
* platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
* platform/qt/tables/mozilla/bugs/bug56201-expected.txt:
* platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
* platform/qt/tables/mozilla/other/slashlogo-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
* platform/qt/transforms/2d/transform-fixed-container-expected.txt:
* platform/qt/transitions/svg-text-shadow-transition-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 17 May 2011 16:24:53 +0000 (16:24 +0000)]
2011-05-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Enter/Tab after editing a CSS property does not invoke editor on next field
https://bugs.webkit.org/show_bug.cgi?id=60962
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateStyles):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Tue, 17 May 2011 16:03:18 +0000 (16:03 +0000)]
WebKit2 needs layoutTestController.overridePreference.
https://bugs.webkit.org/show_bug.cgi?id=42197
Add fast/images/animated-gif-restored-from-bfcache.html to the mac-wk2 Skipped list to get
the bots green.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 17 May 2011 14:39:09 +0000 (14:39 +0000)]
2011-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r86660.
http://trac.webkit.org/changeset/86660
https://bugs.webkit.org/show_bug.cgi?id=60958
broke search in console panel (Requested by podivilov on
#webkit).
* http/tests/inspector/change-iframe-src.html:
* http/tests/inspector/console-resource-errors.html:
* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.evaluateInConsole):
* http/tests/inspector/network/network-size-chunked.html:
* http/tests/inspector/network/network-size-sync.html:
* http/tests/inspector/network/network-size.html:
* http/tests/inspector/network/network-timing.html:
* http/tests/inspector/resource-tree/resource-tree-frame-add.html:
* http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
* inspector/console/console-assert.html:
* inspector/console/console-trace-in-eval.html:
* inspector/console/console-trace.html:
* inspector/console/console-uncaught-exception.html:
* inspector/debugger/debugger-autocontinue-on-syntax-error.html:
* inspector/styles/styles-iframe.html:
* inspector/timeline/timeline-network-resource.html:
* inspector/timeline/timeline-script-tag-1.html:
* inspector/timeline/timeline-script-tag-2.html:
2011-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r86660.
http://trac.webkit.org/changeset/86660
https://bugs.webkit.org/show_bug.cgi?id=60958
broke search in console panel (Requested by podivilov on
#webkit).
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.show):
(WebInspector.ConsoleView.prototype.afterShow):
(WebInspector.ConsoleView.prototype.hide):
(WebInspector.ConsoleView.prototype.addMessage):
(WebInspector.ConsoleView.prototype.clearMessages):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.set visibleView):
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
* inspector/front-end/Panel.js:
(WebInspector.Panel):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 17 May 2011 13:29:57 +0000 (13:29 +0000)]
Make run-api-tests work on Windows when there are spaces in the path
Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
spaces in the path to TestWebKitAPI.exe
Reviewed by David Levin.
* Scripts/run-api-tests:
(runTestTool): Use the "direct object" form of system() to avoid having the path to
TestWebKitAPI.exe be split by the shell.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Tue, 17 May 2011 13:06:59 +0000 (13:06 +0000)]
2011-05-17 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed warning fix introduced by r86377.
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintMask):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Tue, 17 May 2011 11:51:10 +0000 (11:51 +0000)]
2011-05-17 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket: Uninline methods in ThreadableWebSocketChannelClientWrapper
https://bugs.webkit.org/show_bug.cgi?id=60945
Add ThreadableWebSocketChannelClientWrapper.cpp. Uninline methods in this class and
move these definitions into .cpp in order to allow further modifications in this class.
No new tests, as this is just refactoring.
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* websockets/ThreadableWebSocketChannelClientWrapper.cpp: Added.
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::create):
(WebCore::ThreadableWebSocketChannelClientWrapper::clearSyncMethodDone):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSyncMethodDone):
(WebCore::ThreadableWebSocketChannelClientWrapper::syncMethodDone):
(WebCore::ThreadableWebSocketChannelClientWrapper::sent):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSent):
(WebCore::ThreadableWebSocketChannelClientWrapper::bufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::setBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::clearClient):
(WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::suspend):
(WebCore::ThreadableWebSocketChannelClientWrapper::resume):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
* websockets/ThreadableWebSocketChannelClientWrapper.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 17 May 2011 11:39:33 +0000 (11:39 +0000)]
2011-05-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Remove usage of ChunkedUpdateDrawingArea.
https://bugs.webkit.org/show_bug.cgi?id=60901
To prepare for the eventual removal of the ChunkedUpdateDrawingArea,
make QGraphicsWKView's "Simple" backing store type map to DrawingAreaImpl.
* UIProcess/API/qt/qgraphicswkview.cpp:
* UIProcess/API/qt/qgraphicswkview.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::createDrawingAreaProxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 17 May 2011 11:36:55 +0000 (11:36 +0000)]
2011-05-17 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Support shadowed text in fast font path.
https://bugs.webkit.org/show_bug.cgi?id=60462
* platform/graphics/Font.cpp:
(WebCore::Font::drawText): Remove complex path shortcut for shadowed text.
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::drawGlyphs): Paint shadows for simple text.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 17 May 2011 11:34:53 +0000 (11:34 +0000)]
2011-05-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Construct GraphicsLayerQtImpl::State with correct values.
https://bugs.webkit.org/show_bug.cgi?id=60902
The GraphicsLayerQtImpl initial state should match the initial values
of the corresponding GraphicsLayer flags.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::State::State):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Tue, 17 May 2011 10:12:12 +0000 (10:12 +0000)]
2011-05-12 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
IndexedDB: Index population should ignore records without key for index
https://bugs.webkit.org/show_bug.cgi?id=60697
Test that we can create a new index for which not all current records
have a key.
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics.html:
2011-05-12 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
IndexedDB: Index population should ignore records without key for index
https://bugs.webkit.org/show_bug.cgi?id=60697
When populating a new index, records which do not have a key on the
index's key path should be ignored.
* storage/IDBObjectStoreBackendImpl.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 May 2011 09:46:54 +0000 (09:46 +0000)]
2011-05-17 Young Han Lee <joybro@company100.net>
Reviewed by Csaba Osztrogonác.
[Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
https://bugs.webkit.org/show_bug.cgi?id=60947
No new tests. Build fix.
* platform/graphics/qt/TextureMapperQt.cpp:
(WebCore::TextureMapper::create):
* platform/graphics/qt/TextureMapperQt.h:
(WebCore::TextureMapperQt::create):
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayer::create):
2011-05-17 Young Han Lee <joybro@company100.net>
Reviewed by Csaba Osztrogonác.
[Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
https://bugs.webkit.org/show_bug.cgi?id=60947
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::setRootGraphicsLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 17 May 2011 09:34:49 +0000 (09:34 +0000)]
2011-05-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Increment/decrement of very big CSS numeric values results in invalid CSS
https://bugs.webkit.org/show_bug.cgi?id=60890
* inspector/styles/up-down-numerics-and-colors-expected.txt:
* inspector/styles/up-down-numerics-and-colors.html:
2011-05-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Increment/decrement of very big CSS numeric values results in invalid CSS
https://bugs.webkit.org/show_bug.cgi?id=60890
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.alteredFloatNumber):
(WebInspector.StylePropertyTreeElement.prototype):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Tue, 17 May 2011 09:31:52 +0000 (09:31 +0000)]
2011-05-17 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
The following tests are flaky on Linux.
fast/speech/input-appearance-numberandspeech.html
fast/speech/input-appearance-searchandspeech.html
fast/speech/input-appearance-speechbutton.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log