WebKit-https.git
14 years ago2007-11-04 Alp Toker <alp@atoker.com>
alp [Sun, 4 Nov 2007 15:03:13 +0000 (15:03 +0000)]
2007-11-04  Alp Toker  <alp@atoker.com>

        Reviewed by Alexey Proskuryakov.

        Fix a crash when no clipboard text is available

        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::plainText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-04 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Sun, 4 Nov 2007 09:48:02 +0000 (09:48 +0000)]
2007-11-04  Mark Rowe  <mrowe@apple.com>

        Build fix.  Don't use Carbon.h as the prefix header as it triggers
        warnings that would otherwise be suppressed due to it being a system header.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * hosted/sunspider.html: Tweaked formatting a bit.
darin@apple.com [Sun, 4 Nov 2007 08:58:15 +0000 (08:58 +0000)]
    * hosted/sunspider.html: Tweaked formatting a bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin@apple.com [Sun, 4 Nov 2007 08:28:22 +0000 (08:28 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15826
          optimize opcode loop and case insensitive ASCII compares for a 30% speedup

        SunSpider says it's 2.6% faster overall, 32.5% in the regular expression tests.

        * pcre/pcre_internal.h: Added OP_ASCII_CHAR and OP_ASCII_LETTER_NC.

        * pcre/pcre_compile.c:
        (find_fixedlength): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC. Also
        added OP_NOT since there was no reason it should not be in here.
        (could_be_empty_branch): Ditto.
        (compile_branch): Streamlined all the single-character cases; there was a bit of
        duplicate code. Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC as needed.
        But in particular, compile to those opcodes when the single character match is
        ASCII.
        (find_firstassertedchar): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC.

        * pcre/pcre_exec.c: (match): Removed the "min", "minimize", and "op" fields from
        the matchframe, after I discovered that none of them needed to be saved and restored
        across recursive match calls. Also eliminated the ignored result field from the
        matchframe, since I discovered that rrc ("recursive result code") was already the
        exact same thing. Moved the handling of opcodes higher than OP_BRA into the default
        statement of the switch instead of doing them before the switch. This removes a
        branch from each iteration of the opcode interpreter, just as removal of "op"
        removed at least one store from each iteration. Last, but not least, add the
        OP_ASCII_CHAR and OP_ASCII_LETTER_NC functions. Neither can ever match a
        surrogate pair and the letter case can be handled efficiently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * pcre/pcre_exec.c: (match): Try to fix the Windows build by removing unreach...
darin@apple.com [Sun, 4 Nov 2007 07:54:56 +0000 (07:54 +0000)]
    * pcre/pcre_exec.c: (match): Try to fix the Windows build by removing unreachable code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix non-Mac builds; remove some more unused PCRE stuff
darin@apple.com [Sun, 4 Nov 2007 06:18:31 +0000 (06:18 +0000)]
    - fix non-Mac builds; remove some more unused PCRE stuff

        * pcre/pcre_compile.c:
        (compile_branch): Removed branch chain and some unused ESC values.
        (compile_regex): Ditto.
        (jsRegExpCompile): Ditto.
        * pcre/pcre_exec.c:
        (match): Removed unused branch targets. Don't use macros any more.
        (jsRegExpExecute): More of the same.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update for removed files.
        * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
        * pcre/pcre.pri: Ditto.

        * pcre/MERGING: Removed.
        * pcre/pcre_fullinfo.c: Removed.
        * pcre/pcre_get.c: Removed.
        * pcre/pcre_internal.h:
        * pcre/ucp.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin@apple.com [Sun, 4 Nov 2007 05:22:44 +0000 (05:22 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15821
          remove unused PCRE features for speed

        A first step toward removing the PCRE features we don't use.
        This gives a 0.8% speedup on SunSpider, and a 6.5% speedup on
        the SunSpider regular expression test.

        Replaced the public interface with one that doesn't use the
        name PCRE. Removed code we don't need for JavaScript and various
        configurations we don't use. This is in preparation for still
        more changes in the future. We'll probably switch to C++ and
        make some even more significant changes to the regexp engine
        to get some additional speed.

        There's probably additional unused stuff that I haven't
        deleted yet.

        This does mean that our PCRE is now a fork, but I think that's
        not really a big deal.

        * JavaScriptCore.exp: Remove the 5 old entry points and add
        the 3 new entry points for WebCore's direct use of the regular
        expression engine.

        * kjs/config.h: Remove the USE(PCRE16) define. I decided to flip
        its sense and now there's a USE(POSIX_REGEX) instead, which should
        probably not be set by anyone. Maybe later we'll just get rid of it
        altogether.

        * kjs/regexp.h:
        * kjs/regexp.cpp:
        (KJS::RegExp::RegExp): Switch to new jsRegExp function names and
        defines. Cut down on the number of functions used.
        (KJS::RegExp::~RegExp): Ditto.
        (KJS::RegExp::match): Ditto.

        * pcre/dftables.c: (main): Get rid of ctype_letter and ctype_meta,
        which are unused.

        * pcre/pcre-config.h: Get rid of EBCIDIC, PCRE_DATA_SCOPE, const,
        size_t, HAVE_STRERROR, HAVE_MEMMOVE, HAVE_BCOPY, NEWLINE,
        POSIX_MALLOC_THRESHOLD, NO_RECURSE, SUPPORT_UCP, SUPPORT_UTF8,
        and JAVASCRIPT. These are all no longer configurable in our copy
        of the library.

        * pcre/pcre.h: Remove the macro-based kjs prefix hack, the PCRE
        version macros, PCRE_UTF16, the code to set up PCRE_DATA_SCOPE,
        the include of <stdlib.h>, and most of the constants and
        functions defined in this header. Changed the naming scheme to
        use a JSRegExp prefix rather than a pcre prefix. In the future,
        we'll probably change this to be a C++ header.

        * pcre/pcre_compile.c: Removed all unused code branches,
        including many whole functions and various byte codes.
        Kept changes outside of removal to a minimum.
        (check_escape):
        (first_significant_code):
        (find_fixedlength):
        (find_recurse):
        (could_be_empty_branch):
        (compile_branch):
        (compile_regex):
        (is_anchored):
        (is_startline):
        (find_firstassertedchar):
        (jsRegExpCompile): Renamed from pcre_compile2 and changed the
        parameters around a bit.
        (jsRegExpFree): Added.

        * pcre/pcre_exec.c: Removed many unused opcodes and variables.
        Also started tearing down the NO_RECURSE mechanism since it's
        now the default. In some cases there were things in the explicit
        frame that could be turned into plain old local variables and
        other small like optimizations.
        (pchars):
        (match_ref):
        (match): Changed parameters quite a bit since it's now not used
        recursively.
        (jsRegExpExecute): Renamed from pcre_exec.

        * pcre/pcre_internal.h: Get rid of PCRE_DEFINITION, PCRE_SPTR,
        PCRE_IMS, PCRE_ICHANGED, PCRE_NOPARTIAL, PCRE_STUDY_MAPPED,
        PUBLIC_OPTIONS, PUBLIC_EXEC_OPTIONS, PUBLIC_DFA_EXEC_OPTIONS,
        PUBLIC_STUDY_OPTIONS, MAGIC_NUMBER, 16 of the opcodes,
        _pcre_utt, _pcre_utt_size, _pcre_try_flipped, _pcre_ucp_findprop,
        and _pcre_valid_utf8. Also moved pcre_malloc and pcre_free here.

        * pcre/pcre_maketables.c: Changed to only compile in dftables.
        Also got rid of many of the tables that we don't use.

        * pcre/pcre_tables.c: Removed the unused Unicode property tables.

        * pcre/pcre_ucp_searchfuncs.c: Removed everything except for
        _pcre_ucp_othercase.

        * pcre/pcre_xclass.c: (_pcre_xclass): Removed uneeded support
        for classes based on Unicode properties.

        * wtf/FastMallocPCRE.cpp: Removed unused bits. It would be good
        to eliminate this completely, but we need the regular expression
        code to be C++ first.

        * pcre/pcre_fullinfo.c:
        * pcre/pcre_get.c:
        * pcre/ucp.h:
        Files that are no longer needed. I didn't remove them with this
        check-in, because I didn't want to modify all the project files.

WebCore:

        Reviewed by Maciej.

        - WebCore part of http://bugs.webkit.org/show_bug.cgi?id=15821
          remove unused PCRE features for speed

        * page/Frame.cpp: (WebCore::Frame::matchLabelsAgainstElement):
        * page/mac/FrameMac.mm: (WebCore::Frame::matchLabelsAgainstElement):
        Remove use of "[[:digit:]]" syntax. This hasn't worked for some time.
        Use "\d" instead.

        * platform/RegularExpression.h: Remove the unused cap function. We can
        add it back later if we find we need it.
        * platform/RegularExpression.cpp:
        (WebCore::RegularExpression::Private::compile): Update for JavaScriptCore
        regular expression entry point changes.
        (WebCore::RegularExpression::Private::~Private): Ditto.
        (WebCore::RegularExpression::match): Remove the code to set PCRE_NOTBOL.
        This means that regular expressions with metacharactesr like ^ in them
        won't work any more with non-whole-string searches, but we don't use
        any regular expressions like that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate the link stubs to match the current build, and fix coding style issues.
kevino [Sun, 4 Nov 2007 05:15:26 +0000 (05:15 +0000)]
Update the link stubs to match the current build, and fix coding style issues.

Reviewed by Mark Rowe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build-fix.
weinig@apple.com [Sun, 4 Nov 2007 04:17:58 +0000 (04:17 +0000)]
    Build-fix.

        * UserObjectImp.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
mjs [Sun, 4 Nov 2007 03:37:21 +0000 (03:37 +0000)]
    Reviewed by Sam.

        - remove NaN check from JSImmediate::fromDouble for 0.5% SunSpider speedup

        It turns out that doing this check costs more than it saves.

        * kjs/JSImmediate.h:
        (KJS::JSImmediate::fromDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agowx <-> WebKit conversions for IntPoint, IntRect and FloatRect
kevino [Sun, 4 Nov 2007 02:21:09 +0000 (02:21 +0000)]
wx <-> WebKit conversions for IntPoint, IntRect and FloatRect

Reviewed by Mark Rowe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agowx <-> WebKit data type conversions for Pen and Color.
kevino [Sun, 4 Nov 2007 02:05:51 +0000 (02:05 +0000)]
wx <-> WebKit data type conversions for Pen and Color.

Reviewed by Darin Adler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
weinig@apple.com [Sun, 4 Nov 2007 01:08:04 +0000 (01:08 +0000)]
JavaScriptCore:

        Reviewed by Oliver.

        Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
        The variable had been kept around for binary compatibility, but since nothing
        else is there is no point in continuing to keep it around.

        * API/JSCallbackConstructor.cpp:
        (KJS::):
        * API/JSCallbackFunction.cpp:
        (KJS::):
        * API/JSCallbackObject.cpp:
        (KJS::):
        * bindings/objc/objc_runtime.mm:
        * bindings/runtime_array.cpp:
        * bindings/runtime_object.cpp:
        * kjs/array_instance.cpp:
        (KJS::):
        * kjs/array_object.cpp:
        (KJS::):
        * kjs/bool_object.cpp:
        * kjs/date_object.cpp:
        (KJS::):
        * kjs/error_object.cpp:
        * kjs/function.cpp:
        (KJS::):
        * kjs/internal.cpp:
        (KJS::):
        * kjs/lookup.h:
        * kjs/math_object.cpp:
        * kjs/number_object.cpp:
        * kjs/object.h:
        * kjs/regexp_object.cpp:
        * kjs/string_object.cpp:
        (KJS::):

WebCore:

        Reviewed by Oliver.

        Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
        The variable had been kept around for binary compatibility, but since nothing
        else is there is no point in continuing to keep it around.

        * bindings/js/JSDOMExceptionConstructor.cpp:
        (WebCore::):
        * bindings/js/JSHTMLInputElementBase.cpp:
        (WebCore::):
        * bindings/js/JSNamedNodesCollection.cpp:
        (WebCore::):
        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::):
        * bindings/js/JSXSLTProcessor.cpp:
        (KJS::):
        * bindings/js/kjs_css.cpp:
        (WebCore::):
        * bindings/js/kjs_events.cpp:
        (WebCore::):
        * bindings/js/kjs_navigator.cpp:
        (KJS::):
        * bindings/js/kjs_window.cpp:
        (KJS::):
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - Updated testkjs results to make the build bots green until we
kmccullo [Sat, 3 Nov 2007 23:52:57 +0000 (23:52 +0000)]
    - Updated testkjs results to make the build bots green until we
        can fix the tests that are failing.  The new failures are in DST.

        * tests/mozilla/expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Sat, 3 Nov 2007 22:58:41 +0000 (22:58 +0000)]
    Reviewed by Darin.

        - Add compare mode and a description of the benchmark to the hosted version.

        * hosted/sunspider-results.html: Add compare mode - you can just paste in another results URL.
        * hosted/sunspider.html: Added intro text.
        * make-hosted: Copy new file.
        * resources/sunspider-compare-results.js: Made more reusable by putting the implementation in
        a function.
        * resources/sunspider-standalone-compare.js: Added. Calls the function in the way standalone mode
        expects.
        * sunspider-compare-results: Use sunspider-standalone-compare.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
mjs [Sat, 3 Nov 2007 21:13:36 +0000 (21:13 +0000)]
    Reviewed by Adam.

        - don't print the var twice for ForInNodes with a var declaration

        * kjs/nodes2string.cpp:
        (KJS::ForInNode::streamTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Adam.
mjs [Sat, 3 Nov 2007 20:54:57 +0000 (20:54 +0000)]
    Rubber stamped by Adam.

        - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * pcre/pcre_compile.c: (check_escape): Windows build fix. Get rid of
darin@apple.com [Sat, 3 Nov 2007 16:44:00 +0000 (16:44 +0000)]
    * pcre/pcre_compile.c: (check_escape): Windows build fix. Get rid of
        C-incompatible declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-03 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Sat, 3 Nov 2007 16:42:26 +0000 (16:42 +0000)]
2007-11-03  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * kjs/nodes.cpp:  Add missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin@apple.com [Sat, 3 Nov 2007 16:40:32 +0000 (16:40 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15814
          <rdar://problem/5536644> fast/js/kde/encode_decode_uri.html fails

        These changes cause us to match the JavaScript specification and pass the
        fast/js/kde/encode_decode_uri.html test.

        * kjs/function.cpp: (KJS::encode): Call the UTF-8 string conversion in its
        new strict mode, throwing an exception if there are malformed UTF-16 surrogate
        pairs in the text.

        * kjs/ustring.h: Added a strict version of the UTF-8 string conversion.
        * kjs/ustring.cpp:
        (KJS::decodeUTF8Sequence): Removed code to disallow U+FFFE and U+FFFF; while
        those might be illegal in some sense, they aren't supposed to get any special
        handling in the place where this function is currently used.
        (KJS::UString::UTF8String): Added the strictness.

LayoutTests:

        Reviewed by Maciej.

        - updates for http://bugs.webkit.org/show_bug.cgi?id=15814
          <rdar://problem/5536644> fast/js/kde/encode_decode_uri.html fails

        * fast/js/kde/resources/encode_decode_uri.js: Rewrote the test to cover edges better,
        and use the should functions in a way that makes failures easier to understand.
        * fast/js/kde/encode_decode_uri-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin@apple.com [Sat, 3 Nov 2007 16:28:51 +0000 (16:28 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15812
          some JavaScript tests (from the Mozilla test suite) are failing

        Two or three fixes get 7 more of the Mozilla tests passing.
        This gets us down from 61 failing tests to 54.

        * kjs/interpreter.h: (KJS::Interpreter::builtinRegExp):
        Made this inline and gave it a more specific type. Some day we should
        probably do that for all of these -- might even get a bit of a speed
        boost from it.
        * kjs/interpreter.cpp: Removed Interpreter::builtinRegExp now that it's
        inline in the header.

        * kjs/regexp_object.h:
        * kjs/regexp_object.cpp:
        (KJS::RegExpProtoFunc::callAsFunction): Moved test and exec out of the
        switch statement into the RegExpImp object, so they can be shared with
        RegExpImp::callAsFunction.
        (KJS::RegExpImp::match): Added. Common code used by both test and exec.
        (KJS::RegExpImp::test): Added.
        (KJS::RegExpImp::exec): Added.
        (KJS::RegExpImp::implementsCall): Added.
        (KJS::RegExpImp::callAsFunction): Added.
        (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): Initialize
        lastInput to null rather than empty string -- we take advantage of the
        difference in RegExpImp::match.
        (KJS::RegExpObjectImp::input): Added. No reason to go through hash tables
        just to get at a field like this.

        * pcre/pcre_compile.c: (check_escape): Changed the \u handling to match
        the JavaScript specification. If there are not 4 hex digits after the \u,
        then it's processed as if it wasn't an escape sequence at all.

        * pcre/pcre_internal.h: Added IS_NEWLINE, with the appropriate definition
        for JavaScript (4 specific Unicode values).
        * pcre/pcre_exec.c:
        (match): Changed all call sites to use IS_NEWLINE.
        (pcre_exec): Ditto.

        * tests/mozilla/expected.html: Updated to expect 7 more successful tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Mark Rowe.
alp [Sat, 3 Nov 2007 15:52:08 +0000 (15:52 +0000)]
Reviewed by Mark Rowe.

Restore correct double and triple click behaviour

We ended up ignoring GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS after
recent refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fixes to get wx impls. building on trunk.
kevino [Sat, 3 Nov 2007 15:26:58 +0000 (15:26 +0000)]
Build fixes to get wx impls. building on trunk.

Reviewed by Mark Rowe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ddkilzer [Sat, 3 Nov 2007 15:10:51 +0000 (15:10 +0000)]
JavaScriptCore:

        Sort files(...); sections of Xcode project files.

        Rubber-stamped by Darin.

        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Sort files(...); sections of Xcode project files.

        Rubber-stamped by Darin.

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Sort files(...); sections of Xcode project files.

        Rubber-stamped by Darin.

        * WebCore.xcodeproj/project.pbxproj:
        * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:

WebKit:

        Sort files(...); sections of Xcode project files.

        Rubber-stamped by Darin.

        * WebKit.xcodeproj/project.pbxproj:

WebKitTools:

        Sort files(...); sections of Xcode project files.

        Rubber-stamped by Darin.

        * DrawTest/DrawTest.xcodeproj/project.pbxproj:
        * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCoding style fixes for platform/wx files.
kevino [Sat, 3 Nov 2007 14:57:18 +0000 (14:57 +0000)]
Coding style fixes for platform/wx files.

Reviewed by Mark Rowe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Mark Rowe.
alp [Sat, 3 Nov 2007 14:33:54 +0000 (14:33 +0000)]
Reviewed by Mark Rowe.

Implement platform scrollbar static width/height getters

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Mark Rowe.
alp [Sat, 3 Nov 2007 14:33:41 +0000 (14:33 +0000)]
Reviewed by Mark Rowe.

Cast function pointers to gpointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Adam Roben.
alp [Sat, 3 Nov 2007 14:33:25 +0000 (14:33 +0000)]
Reviewed by Adam Roben.

RenderThemeGtk implementation based on Mozilla's GTK+ style code

There is still work needed to complete this feature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Mark Rowe.
alp [Sat, 3 Nov 2007 14:33:02 +0000 (14:33 +0000)]
Reviewed by Mark Rowe.

Do not allow scrollbars to handle wheel events

We bubble the wheel event up so the parent can handle it instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Mark Rowe.
alp [Sat, 3 Nov 2007 14:32:43 +0000 (14:32 +0000)]
Reviewed by Mark Rowe.

Frame scrolling and invalidation fixes

Make upward scroll events have a positive delta to match other ports.

Fix the invalidation rect offset for frames so that scrolling works properly.

Avoid allocating negative sizes to widgets to avoid GTK+ warnings.

Allow tabbing to all widgets and links.

Fix event returns, improving the focus situation and correcting scroll wheel
behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Sat, 3 Nov 2007 13:35:52 +0000 (13:35 +0000)]
WebCore:

        LGPL'ed files contain incorrect FSF address
        <http://bugs.webkit.org/show_bug.cgi?id=14885>

        Reviewed by NOBODY (follow-up fix).

        * bindings/js/JSSVGTransformListCustom.cpp:
        * ksvg2/svg/SVGException.idl:
        * ksvg2/svg/SVGTextPathElement.cpp:
        * ksvg2/svg/SVGTextPathElement.h:
        * ksvg2/svg/SVGViewSpec.cpp:
        * ksvg2/svg/SVGViewSpec.h:
        * platform/mac/FontCustomPlatformData.cpp:
        * platform/mac/FontCustomPlatformData.h:
        * platform/mac/FontPlatformDataMac.mm:
        * platform/win/FontCustomPlatformData.cpp:
        * platform/win/FontCustomPlatformData.h:
        * rendering/RenderSVGRoot.cpp:
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGTextPath.cpp:
        * rendering/RenderSVGTextPath.h:
        * rendering/RenderSVGTransformableContainer.h:
        * rendering/RenderSVGViewportContainer.cpp:
        * rendering/RenderSVGViewportContainer.h:
        * rendering/SVGCharacterLayoutInfo.cpp:
        * rendering/SVGCharacterLayoutInfo.h:
        * rendering/SVGRenderSupport.cpp:
        * rendering/SVGRenderSupport.h:

WebKitSite:

        LGPL'ed files contain incorrect FSF address
        <http://bugs.webkit.org/show_bug.cgi?id=14885>

        Reviewed by NOBODY (follow-up fix).

        * blog/wp-includes/class-snoopy.php:
        * blog/wp-includes/gettext.php:
        * blog/wp-includes/streams.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
mjs [Sat, 3 Nov 2007 10:09:45 +0000 (10:09 +0000)]
    Reviewed by Oliver.

        - remove VarDeclListNode and simplify VarDeclNode evaluation for 0.4% SunSpider speedup

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (KJS::VarDeclNode::optimizeVariableAccess):
        (KJS::VarDeclNode::getDeclarations):
        (KJS::VarDeclNode::handleSlowCase):
        (KJS::VarDeclNode::evaluateSingle):
        (KJS::VarDeclNode::evaluate):
        (KJS::VarStatementNode::execute):
        * kjs/nodes.h:
        (KJS::VarDeclNode::):
        (KJS::VarStatementNode::):
        * kjs/nodes2string.cpp:
        (KJS::VarDeclNode::streamTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Sat, 3 Nov 2007 08:36:48 +0000 (08:36 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=15800
        REGRESSION (r27303): RegExp leaks

        * kjs/regexp_object.h:
        (KJS::RegExpImp::setRegExp):
        (KJS::RegExpImp::regExp):
        (KJS::RegExpImp::classInfo):
        * kjs/regexp_object.cpp:
        (RegExpImp::RegExpImp):
        (RegExpImp::~RegExpImp):
        Renamed reg member variable to m_regExp, changed it to use OwnPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoVersioning.
mrowe@apple.com [Sat, 3 Nov 2007 07:27:50 +0000 (07:27 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Script to sort "files(...);" sections in Xcode project.pbxproj files.
ddkilzer [Sat, 3 Nov 2007 06:58:34 +0000 (06:58 +0000)]
    Script to sort "files(...);" sections in Xcode project.pbxproj files.

        Rubber-stamped by Darin.

        * Scripts/sort-Xcode-project-file: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti [Sat, 3 Nov 2007 04:17:47 +0000 (04:17 +0000)]
WebCore:

        Reviewed by Adam.

        Add video width/height DOM and content attributes from latest HTML5 draft.

        Test: media/video-width-height.html

        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::parseMappedAttribute):
        (WebCore::HTMLVideoElement::width):
        (WebCore::HTMLVideoElement::setWidth):
        (WebCore::HTMLVideoElement::height):
        (WebCore::HTMLVideoElement::setHeight):
        * html/HTMLVideoElement.h:
        * html/HTMLVideoElement.idl:

LayoutTests:

        Reviewed by Adam.

        Test for video width/height DOM and content attributes.

        * media/video-width-height-expected.txt: Added.
        * media/video-width-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
mjs [Sat, 3 Nov 2007 03:24:28 +0000 (03:24 +0000)]
    Reviewed by Oliver.

        - add SourceElements as a typedef for Vector<RefPtr<StatementNode> >.

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (KJS::statementListPushFIFO):
        (KJS::statementListGetDeclarations):
        (KJS::statementListInitializeDeclarationStacks):
        (KJS::statementListInitializeVariableAccessStack):
        (KJS::statementListExecute):
        (KJS::BlockNode::BlockNode):
        (KJS::FunctionBodyNode::FunctionBodyNode):
        (KJS::ProgramNode::ProgramNode):
        * kjs/nodes.h:
        (KJS::CaseClauseNode::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin@apple.com [Sat, 3 Nov 2007 00:48:56 +0000 (00:48 +0000)]
    Reviewed by Maciej.

        * DerivedSources.make: Remove a few explicit filenames from some rules by using
        make variables a little more.
        * WebCore.LP64.exp: Fix typo, grammar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin@apple.com [Sat, 3 Nov 2007 00:46:32 +0000 (00:46 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15791
          change property map data structure for less memory use, better speed

        The property map now has an array of indices and a separate array of
        property map entries. This slightly slows down lookup because of a second
        memory acess, but makes property maps smaller and faster to iterate in
        functions like mark().

        SunSpider says this is 1.2% faster, although it makes the bitwise-end test
        more than 10% slower. To fix that we'll need to optimize global variable lookup.

        * kjs/property_map.cpp:
        (KJS::PropertyMapEntry::PropertyMapEntry):
        (KJS::PropertyMapHashTable::entries):
        (KJS::PropertyMapHashTable::allocationSize):
        (KJS::SavedProperties::SavedProperties):
        (KJS::SavedProperties::~SavedProperties):
        (KJS::PropertyMap::checkConsistency):
        (KJS::PropertyMap::~PropertyMap):
        (KJS::PropertyMap::clear):
        (KJS::PropertyMap::get):
        (KJS::PropertyMap::getLocation):
        (KJS::PropertyMap::put):
        (KJS::PropertyMap::insert):
        (KJS::PropertyMap::createTable):
        (KJS::PropertyMap::rehash):
        (KJS::PropertyMap::remove):
        (KJS::PropertyMap::mark):
        (KJS::comparePropertyMapEntryIndices):
        (KJS::PropertyMap::containsGettersOrSetters):
        (KJS::PropertyMap::getEnumerablePropertyNames):
        (KJS::PropertyMap::save):
        (KJS::PropertyMap::restore):
        * kjs/property_map.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
antti [Sat, 3 Nov 2007 00:39:57 +0000 (00:39 +0000)]
    Reviewed by Darin.

        Update to add WKQTMovieViewSetDrawSynchronously

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin@apple.com [Sat, 3 Nov 2007 00:30:44 +0000 (00:30 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15807
          HashMap needs a take() function that combines get and remove

        * wtf/HashMap.h: Added take function. Simplistic implementation for now,
        but still does only one hash table lookup.

        * kjs/array_instance.cpp: (KJS::ArrayInstance::put): Use take rather than
        a find followed by a remove.

WebCore:

        Reviewed by Maciej.

        - use the new HashMap::take function where appropriate

        * bindings/js/kjs_binding.cpp:
        (KJS::addWrapper): Made an inline rather than a macro; inlines good, macros bad.
        (KJS::removeWrapper): Ditto.
        (KJS::removeWrappers): Ditto.
        (KJS::ScriptInterpreter::putDOMObject): Use the inline instead of the macro.
        (KJS::ScriptInterpreter::forgetDOMObject): Ditto. This involves using take instead
        of remove -- in theory ever so slightly less efficient, but I think it's fine.
        (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Ditto.
        (KJS::ScriptInterpreter::putDOMNodeForDocument): Use the inline instead of the macro.
        (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Use take instead of find/remove.
        (KJS::ScriptInterpreter::updateDOMNodeDocument): Use the inlines instead of the macros.

        * bindings/js/kjs_window.cpp: (KJS::Window::clearTimeout): Use take instead of find/remove.
        * bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::remove): Ditto.
        * page/AnimationController.cpp: (WebCore::AnimationControllerPrivate::clear): Ditto.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::~RenderBlock): Ditto.
        (WebCore::RenderBlock::setDesiredColumnCountAndWidth): Ditto.
        * rendering/RootInlineBox.cpp: Ditto.(WebCore::RootInlineBox::detachEllipsisBox): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti [Sat, 3 Nov 2007 00:23:43 +0000 (00:23 +0000)]
WebCore:

        Reviewed by Darin.

        Enable video composition.

        * WebCore.base.exp:
        * platform/graphics/mac/MoviePrivateQTKit.mm:
        (WebCore::MoviePrivate::createQTMovieView):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:

WebKit:

        Reviewed by Darin.

        Add method to enable video composition.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSunSpider:
darin@apple.com [Sat, 3 Nov 2007 00:20:01 +0000 (00:20 +0000)]
SunSpider:

        * sunspider: Changed "--base" to "--set-baseline".

WebKitTools:

        * Scripts/run-sunspider: Changed "--base" to "--set-baseline".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSunSpider:
darin@apple.com [Sat, 3 Nov 2007 00:15:02 +0000 (00:15 +0000)]
SunSpider:

        Reviewed by Maciej.

        * sunspider: Added a "--base" option that records the current test as a baseline.
        Moved the code to find the newest .mshark file into a function (since I needed to use
        it in the other script and I prefer to copy/paste a function).

        * sunspider-compare-results: Added logic to compare the baseline with the last
        run when you don't pass any parameters.

WebKitTools:

        Reviewed by Maciej.

        * Scripts/run-sunspider: Pass the "--base" option through.

        * Scripts/sunspider-compare-results: Don't check the number of parameters; let
        the real script do that. Default configuration to Release to match run-sunspider
        so we don't end up building Debug just to compare results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin@apple.com [Fri, 2 Nov 2007 23:16:08 +0000 (23:16 +0000)]
    Reviewed by Darin.

        Fix compiler warning "warning: suggest parentheses around && within ||"
        http://bugs.webkit.org/show_bug.cgi?id=15764

        * kjs/value.h: (KJS::JSValue::isNumber): Add parentheses.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Fri, 2 Nov 2007 23:13:36 +0000 (23:13 +0000)]
WebCore:

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15806
          <rdar://problem/5561626> ASSERT(element->isRadioButton()) fires destroying form elements

        Test: fast/forms/remove-radio-button-assert.html

        * html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removeFromForm):
        Added protected function to be used by derived classes that need to do the same sort
        of removal from form that's automatically done by the base class in certain circumstances.
        * html/HTMLGenericFormElement.h: Added removeFromForm.

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement):
        Call removeFromForm here so the element is removed before we destroy the HTMLInputElement
        part of this object. By the time we get to the base class's destructor it's too late.
        The problem is specific to radio buttons so we don't have to worry about other classes
        derived from HTMLGenericFormElement.

LayoutTests:

        Reviewed by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15806
          <rdar://problem/5561626> ASSERT(element->isRadioButton()) fires destroying form elements

        * fast/forms/remove-radio-button-assert-expected.txt: Added.
        * fast/forms/remove-radio-button-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mitz.
darin@apple.com [Fri, 2 Nov 2007 23:11:12 +0000 (23:11 +0000)]
    Reviewed by Mitz.

        - speculative fix for http://bugs.webkit.org/show_bug.cgi?id=15805
          <rdar://problem/5510779> crashes in isLoadingMultipartContent

        * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingMultipartContent):
        Instead of asserting the frame loader is non-0, return false if it is 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Fri, 2 Nov 2007 23:08:41 +0000 (23:08 +0000)]
WebCore:

        Reviewed by Mitz.

        - fix <rdar://problem/5530185> WebKit does not show <object> fallback content when both
          URL and MIME type is omitted

        Already covered by existing tests (that had incorrect results).

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): Return false to indicate
        failure when both URL and MIME type are empty. The old code would not attempt a load, but
        it would indicate success.

        * rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Remove
        non-helpful early exit for the case where there is no URL and no type. Returning early
        prevents the fallback code from running.

WebKit:

        Reviewed by Mitz.

        - fix problem I ran into while doing some testing on Mac for
          <rdar://problem/5530185> WebKit does not show <object>
          fallback content when both URL and MIME type is omitted

        I don't know how to reproduce this failure in DumpRenderTree, so there is no
        regression test.

        * Plugins/WebNullPluginView.h: Removed some unneeded declarations, including
        the didSendError local variable. Instead we just set the error to nil once
        we've sent it.
        * Plugins/WebNullPluginView.mm:
        (-[WebNullPluginView initWithFrame:error:DOMElement:]): Refactored so that
        the null plug-in image code is separate from the rest of the function and
        so that the whole thing is not inside an if statement. Also don't hold a
        reference to the DOM element if there is no error to report.
        (-[WebNullPluginView reportFailure]): Added. Does the actual delegate
        callback. Happens back at the top level of the run loop so it doesn't
        fire deep inside layout. Also wrote this so that it is guaranteed not to
        reenter and so that it can handle the case where the delegate destroys
        the world (including this object). NOTE: This is not a real, general
        solution to the problem of plug-ins that do work inside layout. We will need
        a more general fix that works for other plug-ins, and we'll track that with
        a separate bug report.
        (-[WebNullPluginView viewDidMoveToWindow]): Removed most of the code;
        changed so it just does a performSelector:afterDelay:0.

LayoutTests:

        Reviewed by Mitz.

        - update tests affected by fix for <rdar://problem/5530185> WebKit does not show
          <object> fallback content when both URL and MIME type is omitted

        * dom/html/level2/html/AppletsCollection-expected.txt: The text "Nothing here!" renders now.
        * fast/dom/HTMLDocument/object-by-name-unknown-child-element-expected.txt: Some blank
        space renders now.
        * platform/mac/fast/invalid/residual-style-expected.txt: A font element renders now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Darin.
alp [Fri, 2 Nov 2007 21:51:49 +0000 (21:51 +0000)]
Reviewed by Darin.

Include Cairo headers properly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-02 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 2 Nov 2007 14:07:04 +0000 (14:07 +0000)]
2007-11-02  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin Adler.

        Fix http://bugs.webkit.org/show_bug.cgi?id=15780
        Bug 15780: WebFrameLoaderClient: WebActionElementKey wrong if view is scrolled

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::actionDictionary): Retrieve the mouse event coordinates
        in the page coordinate system rather than the client area coordinate system.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key
oliver [Fri, 2 Nov 2007 06:51:15 +0000 (06:51 +0000)]
Make sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key

WebCore:

        Reviewed by Alexey.

        Make sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key

        * platform/win/KeyEventWin.cpp:
        (WebCore::keyIdentifierForWindowsKeyCode):
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

WebKit/win:

        Reviewed by Alexey.

        Allow Shift, Ctrl, Alt, Meta and Capslock keys to be sent into WebCore.

        * WebView.cpp:
        (WebView::keyDown):
        (WebView::keyUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver Hunt.
mitz [Fri, 2 Nov 2007 06:27:29 +0000 (06:27 +0000)]
    Reviewed by Oliver Hunt.

        - fix an assertion failure when Command-Tabbing out of Safari

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to
        webCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren [Fri, 2 Nov 2007 00:14:04 +0000 (00:14 +0000)]
JavaScriptCore:

        Reviewed by Maciej Stachowiak.

        In preparation for making List a simple stack-allocated Vector:

        Removed all instances of List copying and/or assignment, and made List
        inherit from Noncopyable.

        Functions that used to return a List by copy now take List& out
        parameters.

        Layout tests and JS tests pass.

        * kjs/list.cpp:
        (KJS::List::slice): Replaced copyTail with a more generic slice
        alternative. (JavaScriptCore only calls slice(1), but WebCore calls
        slice(2)).

WebCore:

        Reviewed by Maciej Stachowiak.

        In preparation for making List a simple stack-allocated Vector:

        Removed all instances of List copying, assignment, and/or storage.

        Layout tests and JS tests pass.

        * bindings/js/kjs_window.cpp:
        (KJS::WindowFunc::callAsFunction): Stores a Vector of protected
        JSValue*'s instead of a List now. Converts to List on the fly when
        calling the timer function. This is slightly less efficient, but the
        common case is 0-2 arguments, so it's no biggie.

        (HTML iBench shows no regression. PLT does not use JS timers.)

        (KJS::ScheduledAction::execute): Uses the more efficient and non-copying
        List::slice now.
        (KJS::ScheduledAction::ScheduledAction): ditto

        * bindings/objc/WebScriptObject.mm:
        (getListFromNSArray): Takes a List out parameter now, to avoid copying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCorrect event behaviour on certain control keys
oliver [Thu, 1 Nov 2007 23:30:25 +0000 (23:30 +0000)]
Correct event behaviour on certain control keys

Reviewed by Geoff

Make sure we send the correct keyDown and keyUp events for the
control keys CapsLock, Shift, Ctrl, Alt, and Meta/Command, and
uses Windows key codes for the event keyCode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoForgot part of the patch for my last change.
timothy@apple.com [Thu, 1 Nov 2007 23:10:36 +0000 (23:10 +0000)]
Forgot part of the patch for my last change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
timothy@apple.com [Thu, 1 Nov 2007 23:00:20 +0000 (23:00 +0000)]
    Reviewed by Sam.

        * page/inspector/inspector.css: Use the white disclosure triangles
          when a parent DOM element is sepected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justing [Thu, 1 Nov 2007 22:58:47 +0000 (22:58 +0000)]
WebCore:

        Reviewed by Oliver Hunt.

        <rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): No need to match style when pasting
        into a plaintext-only region, since when we build the fragment to insert from
        plain text, we don't put any style information on it, so it will automatically
        match style with no intervention.
        * editing/markup.cpp:
        (WebCore::createFragmentFromText): Place paragraphs into clones of the
        block being inserted into, instead of default paragraph elements,
        so that when inserted content will match the surrounding paragraph style.
        This was broken before, but I haven't added a layout test yet because
        there currently isn't a way to get only plain text onto the pasteboard
        in a layout test.

WebKit:

        Reviewed by Oliver Hunt.

        <rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply

        No need to match style when pasting plain text, since the fragment we build for plain text
        won't have any style information on it.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): There's no
        longer a need to know whether this function chosePlaintext.
        (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
        (-[WebHTMLView _documentFragmentFromPasteboard:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - Fixed a build failure
kmccullo [Thu, 1 Nov 2007 22:54:11 +0000 (22:54 +0000)]
    - Fixed a build failure

        * WebEditorClient.cpp:
        (WebEditorClient::textWillBeDeletedInTextField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
weinig [Thu, 1 Nov 2007 22:31:34 +0000 (22:31 +0000)]
    Reviewed by Adam Roben.

        Add a releaseRef method to COMPtr which matches the behavior
        of the method by the same name in PassRefPtr.  This is in
        preparation of adding autogenerated COM DOM bindings.

        * platform/win/COMPtr.h:
        (COMPtr::releaseRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz [Thu, 1 Nov 2007 22:28:39 +0000 (22:28 +0000)]
WebCore:

        wx impl. for DragController and EventHandler interfaces.

        Reviewed by Adam Roben.

        * page/wx: Added.
        * page/wx/DragControllerWx.cpp: Added.
        (WebCore::DragController::isCopyKeyDown):
        (WebCore::DragController::dragOperation):
        (WebCore::DragController::maxDragImageSize):
        * page/wx/EventHandlerWx.cpp: Added.
        (WebCore::EventHandler::passMousePressEventToSubframe):
        (WebCore::EventHandler::passMouseMoveEventToSubframe):
        (WebCore::EventHandler::passMouseReleaseEventToSubframe):
        (WebCore::EventHandler::passMousePressEventToScrollbar):
        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
        (WebCore::EventHandler::focusDocumentView):
        (WebCore::EventHandler::eventActivatedView):
        (WebCore::EventHandler::createDraggingClipboard):

LayoutTests:

        - fix typo in test name

        * fast/repaint/layout-state-only-posiitoned.html: Removed.
        * fast/repaint/layout-state-only-positioned.html: Copied from fast/repaint/layout-state-only-posiitoned.html.
        * platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum: Removed.
        * platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png: Removed.
        * platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt: Removed.
        * platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum.
        * platform/mac/fast/repaint/layout-state-only-positioned-expected.png: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png.
        * platform/mac/fast/repaint/layout-state-only-positioned-expected.txt: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agowx impl. for DragController and EventHandler interfaces.
kevino [Thu, 1 Nov 2007 21:43:43 +0000 (21:43 +0000)]
wx impl. for DragController and EventHandler interfaces.

Reviewed by Adam Roben.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdding files for wx impl. of editing interfaces.
kevino [Thu, 1 Nov 2007 21:36:00 +0000 (21:36 +0000)]
Adding files for wx impl. of editing interfaces.

Reviewed by Adam Roben.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
weinig [Thu, 1 Nov 2007 21:33:33 +0000 (21:33 +0000)]
    Reviewed by Adam Roben.

        Make implicit conversions from LPCSTRs and BSTRs to WebCore string
        types possible in preparation of adding autogenerated COM DOM bindings.

        * platform/AtomicString.cpp:
        (WebCore::AtomicString::add):
        * platform/AtomicString.h:
        (WebCore::AtomicString::AtomicString):
        * platform/PlatformString.h:
        * platform/win/BString.cpp:
        (WebCore::BString::BString):
        * platform/win/BString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders
beidson@apple.com [Thu, 1 Nov 2007 21:15:22 +0000 (21:15 +0000)]
    Reviewed by Anders

        Renamed a flag inside of SQLiteTransaction and added an accessor (for future work)

        * platform/sql/SQLiteTransaction.cpp:
        (WebCore::SQLiteTransaction::SQLiteTransaction):
        (WebCore::SQLiteTransaction::~SQLiteTransaction):
        (WebCore::SQLiteTransaction::begin):
        (WebCore::SQLiteTransaction::commit):
        (WebCore::SQLiteTransaction::rollback):
        * platform/sql/SQLiteTransaction.h:
        (WebCore::SQLiteTransaction::inProgress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Remove all duplicate xcopy commands from WebCore's post-build step
aroben [Thu, 1 Nov 2007 21:01:18 +0000 (21:01 +0000)]
    Remove all duplicate xcopy commands from WebCore's post-build step

        Also add the /d option to the copy of platform/sql.

        Rubberstamped by Sam.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
aroben [Thu, 1 Nov 2007 21:00:49 +0000 (21:00 +0000)]
    Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"

        Reviewed by Sam.

        * Scripts/commit-log-editor: Show all the directories beneath the
        source root, instead of just the last one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren [Thu, 1 Nov 2007 20:50:28 +0000 (20:50 +0000)]
JavaScriptCore:

        Reviewed by Maciej Stachowiak.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=15785
        REGRESSION(r27344): Crash on load at finance.yahoo.com

        Reverted a small portion of my last check-in. (The speedup and the List
        removal are still there, though.)

        ActivationImp needs to hold a pointer to its function, and mark that
        pointer (rather than accessing its function through its ExecState, and
        counting on the active scope to mark its function) because a closure
        can cause an ActivationImp to outlive its ExecState along with any
        active scope.

        * kjs/ExecState.cpp:
        (KJS::ExecState::ExecState):
        * kjs/function.cpp:
        (KJS::FunctionImp::~FunctionImp):
        (KJS::ActivationImp::ActivationImp):
        * kjs/function.h:
        (KJS::ActivationImp::ActivationImpPrivate::ActivationImpPrivate):

        Also made HashTable a little more crash-happy in debug builds, so
        problems like this will show up earlier:

        * wtf/HashTable.h:
        (WTF::HashTable::~HashTable):

LayoutTests:

        Reviewed by Maciej Stachowiak.

        Layout test for http://bugs.webkit.org/show_bug.cgi?id=15785
        REGRESSION(r27344): Crash on load at finance.yahoo.com

        * fast/js/activation-object-function-lifetime-expected.txt: Added.
        * fast/js/activation-object-function-lifetime.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Tim Hatcher.
weinig@apple.com [Thu, 1 Nov 2007 20:35:09 +0000 (20:35 +0000)]
    Rubber-stamped by Tim Hatcher.

        * misc/DatabaseExample.html: Speed up default close speed to .25s

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
weinig@apple.com [Thu, 1 Nov 2007 20:28:25 +0000 (20:28 +0000)]
    Reviewed by Adam Roben.

        - Don't show the close button on the notes unless hovering over the note.
        - Do transformation and fade when closing a note using the new transition properties.

        * misc/DatabaseExample.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix the parameter type of WebLocalizedString to match the UI_STRING macro
aroben [Thu, 1 Nov 2007 20:23:48 +0000 (20:23 +0000)]
    Fix the parameter type of WebLocalizedString to match the UI_STRING macro

        Reviewed by Sam.

        * WebLocalizableStrings.cpp:
        (WebLocalizedString):
        (WebLocalizedLPCTSTR):
        * WebLocalizableStrings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
adele [Thu, 1 Nov 2007 19:01:09 +0000 (19:01 +0000)]
    Reviewed by Maciej.

        Add support for the animation of the -webkit-border-raduis properties.

        * page/AnimationController.cpp:
        (WebCore::blendFunc): Added for IntSize.
        (WebCore::ImplicitAnimation::animate): Added cases for border radius properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-01 Alp Toker <alp@atoker.com>
alp [Thu, 1 Nov 2007 18:37:36 +0000 (18:37 +0000)]
2007-11-01  Alp Toker  <alp@atoker.com>

        Reviewed by Mitz Pettel.

        Fix an unbalanced save/restore.

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add support for the animation of the visibility property.
hyatt [Thu, 1 Nov 2007 18:28:58 +0000 (18:28 +0000)]
    Add support for the animation of the visibility property.

        Reviewed by oliver, aroben

        * page/AnimationController.cpp:
        (WebCore::blendFunc):
        (WebCore::ImplicitAnimation::animate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
kmccullo [Thu, 1 Nov 2007 17:13:59 +0000 (17:13 +0000)]
    Reviewed by Adam.

        - Made COMPtr be able to be used by certain other templates,
        specifically HashSet.

        * platform/win/COMPtr.h:
        (WTF::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz [Thu, 1 Nov 2007 15:30:23 +0000 (15:30 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15015
          <rdar://problem/5420308> Most of www.aol.com redraws unnecessarily when headline/photo section changes

        Test: fast/repaint/overflow-clip-subtree-layout.html

        This patch does not address the bigger issue of doing a full relayout
        of inline flows containing floats, but it addresses the problem on
        aol.com, where the changes that trigger layout are confined to an
        overflow area inside the float.

        * page/FrameView.cpp:
        (WebCore::FrameView::scheduleRelayoutOfSubtree): If the new and old
        layout roots are different but one descends from the other, make (or
        keep) the ancestor as the layout root.
        * rendering/RenderObject.cpp:
        (WebCore::objectIsRelayoutBoundary): Made boxes with overflow
        clipping and non-auto width and height relayout boundaries.

LayoutTests:

        Reviewed by Dave Hyatt.

        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=15015
          <rdar://problem/5420308> Most of www.aol.com redraws unnecessarily when headline/photo section changes

        * fast/repaint/overflow-clip-subtree-layout.html: Added.
        * platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.checksum: Added.
        * platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
        * platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe.
ap [Thu, 1 Nov 2007 15:01:46 +0000 (15:01 +0000)]
    Reviewed by Mark Rowe.

        Fixed line endings that got confused in this file somehow.

        * platform/network/ResourceResponse.cpp:
        (WebCore::ResourceResponse::isAttachment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
ggaren [Thu, 1 Nov 2007 09:58:13 +0000 (09:58 +0000)]
    Reviewed by Adam Roben.

        Addressed some of Darin's review comments.

        Used perl -p, which is the shorthand while(<>) {}.

        Made sure not to suppress bison's output.

        Added line to removed bison_out.txt, since this script removes other
        intermediate files, too.

        * DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-01 Kevin Ollivier <kevino@theolliviers.com>
mrowe@apple.com [Thu, 1 Nov 2007 09:30:16 +0000 (09:30 +0000)]
2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>

        Reviewed by Adam Roben.

        Print out an error message when the Windows build fails
        and provide guidance on how to find out what went wrong.

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd some more tests that r27343 fixed
aroben [Thu, 1 Nov 2007 09:30:12 +0000 (09:30 +0000)]
Add some more tests that r27343 fixed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-01 Peter Kasting <zerodpx@gmail.com>
mrowe@apple.com [Thu, 1 Nov 2007 09:29:47 +0000 (09:29 +0000)]
2007-11-01  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Dave Hyatt.

        http://bugs.webkit.org/show_bug.cgi?id=15778
        Malformed GIFs should not result in memory corruption.

        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::haveDecodedRow):
        * platform/image-decoders/gif/GIFImageReader.cpp:
        (GIFImageReader::output_row):
        (GIFImageReader::read):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Adam Roben.
ap [Thu, 1 Nov 2007 09:21:30 +0000 (09:21 +0000)]
    Rubber-stamped by Adam Roben.

        Rolled out r27326 - debug CRT seems to cause no problems after all.

        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver Hunt.
ggaren [Thu, 1 Nov 2007 08:36:58 +0000 (08:36 +0000)]
    Reviewed by Oliver Hunt.

        Removed List from ActivationImp, in preparation for making all lists
        stack-allocated.

        Tests pass.

        1.0% speedup on SunSpider, presumably due to reduced List refcount thrash.

        * kjs/ExecState.cpp:
        (KJS::ExecState::ExecState):
        (KJS::ExecState::~ExecState):
        * kjs/function.cpp:
        (KJS::ActivationImp::ActivationImp):
        (KJS::ActivationImp::createArgumentsObject):
        * kjs/function.h:
        (KJS::ActivationImp::ActivationImpPrivate::ActivationImpPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Use jsNumberCell instead of jsNumber when converting double constants to...
aroben [Thu, 1 Nov 2007 08:28:35 +0000 (08:28 +0000)]
     Use jsNumberCell instead of jsNumber when converting double constants to JSValues

         This fixes fast/js/math.html, which was suffering from a bug in MSVC.
         It also gets rid of an MSVC warning that we previously had to silence.

         Reviewed by Geoff.

         * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Turn
         back on the "overflow in constant arithmetic" warning.
         * kjs/number_object.cpp:
         (NumberObjectImp::getValueProperty): Use jsNumberCell instead of
         jsNumber.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add Windows-specific results for window-properties
aroben [Thu, 1 Nov 2007 06:50:58 +0000 (06:50 +0000)]
    Add Windows-specific results for window-properties

        HTML Timed Media elements aren't implemented yet on Windows.

        * platform/win/fast/dom/Window/window-properties-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix
aroben [Thu, 1 Nov 2007 06:20:37 +0000 (06:20 +0000)]
    Windows build fix

        * kjs/ExecState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix ChangeLog entry.
mjs [Thu, 1 Nov 2007 05:05:11 +0000 (05:05 +0000)]
Fix ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
mjs [Thu, 1 Nov 2007 05:02:30 +0000 (05:02 +0000)]
    Reviewed by Oliver.

        - shave some cycles off of local storage access for a 1% SunSpider speedup

        Keep the LocalStorage pointer in the ExecState, not

        * kjs/ExecState.cpp:
        (KJS::ExecState::updateLocalStorage):
        * kjs/ExecState.h:
        (KJS::ExecState::localStorage):
        * kjs/nodes.cpp:
        (KJS::LocalVarAccessNode::evaluate):
        (KJS::LocalVarFunctionCallNode::evaluate):
        (KJS::PostIncLocalVarNode::evaluate):
        (KJS::PostDecLocalVarNode::evaluate):
        (KJS::LocalVarTypeOfNode::evaluate):
        (KJS::PreIncLocalVarNode::evaluate):
        (KJS::PreDecLocalVarNode::evaluate):
        (KJS::ReadModifyLocalVarNode::evaluate):
        (KJS::AssignLocalVarNode::evaluate):
        (KJS::FunctionBodyNode::processDeclarationsForFunctionCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix a crash when parsing a cubic-bezier function
aroben [Thu, 1 Nov 2007 03:51:57 +0000 (03:51 +0000)]
 Fix a crash when parsing a cubic-bezier function

 WebCore:

         Fix a crash when parsing a cubic-bezier function

         Reviewed by Hyatt.

         Test: fast/css/parse-timing-function-crash.html

         * WebCore.vcproj/WebCore.vcproj:
         * css/CSSParser.cpp:
         (WebCore::CSSParser::parseTimingFunctionValue): Don't walk off the end
         of the ValueList.

 LayoutTests:

         New test for a crash when parsing a cubic-bezier function

         Reviewed by Hyatt.

         * fast/css/parse-timing-function-crash-expected.txt: Added.
         * fast/css/parse-timing-function-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix a merge error from when I applied my patch to ToT. A couple of lines...
hyatt [Thu, 1 Nov 2007 03:05:41 +0000 (03:05 +0000)]
    Fix a merge error from when I applied my patch to ToT.  A couple of lines should be part of an if.

        * rendering/RenderStyle.cpp:
        (WebCore::RenderStyle::adjustTransitions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix a crash on launch due to a static initializer race
aroben [Thu, 1 Nov 2007 01:22:35 +0000 (01:22 +0000)]
    Fix a crash on launch due to a static initializer race

        We now use fast inline assembler spinlocks which can be statically
        initialized at compile time.

        As a side benefit, this speeds up SunSpider by 0.4%.

        Reviewed by Oliver.

        * wtf/FastMalloc.cpp:
        * wtf/TCSpinLock.h:
        (TCMalloc_SpinLock::Lock):
        (TCMalloc_SpinLock::Unlock):
        (TCMalloc_SlowLock):
        * wtf/TCSystemAlloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
andersca [Thu, 1 Nov 2007 01:16:23 +0000 (01:16 +0000)]
    Reviewed by Sam.

        Add new SQL callback interfaces and JS implementations of them.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSCustomSQLStatementCallback.cpp: Added.
        (WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
        (WebCore::JSCustomSQLStatementCallback::handleEvent):
        * bindings/js/JSCustomSQLStatementCallback.h: Added.
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp: Added.
        (WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
        (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
        * bindings/js/JSCustomSQLStatementErrorCallback.h: Added.
        * bindings/js/JSCustomSQLTransactionCallback.cpp: Added.
        (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
        (WebCore::JSCustomSQLTransactionCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionCallback.h: Added.
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp: Added.
        (WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
        (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionErrorCallback.h: Added.
        * storage/JSCustomSQLStatementCallback.h: Added.
        * storage/JSCustomSQLStatementErrorCallback.h: Added.
        * storage/JSCustomSQLTransactionCallback.h: Added.
        * storage/JSCustomSQLTransactionErrorCallback.h: Added.
        * storage/SQLStatementCallback.h: Added.
        (WebCore::SQLStatementCallback::~SQLStatementCallback):
        * storage/SQLStatementCallback.idl: Added.
        * storage/SQLStatementErrorCallback.h: Added.
        (WebCore::SQLStatementErrorCallback::~SQLStatementErrorCallback):
        * storage/SQLStatementErrorCallback.idl: Added.
        * storage/SQLTransaction.h: Added.
        * storage/SQLTransaction.idl: Added.
        * storage/SQLTransactionCallback.h: Added.
        (WebCore::SQLTransactionCallback::~SQLTransactionCallback):
        * storage/SQLTransactionCallback.idl: Added.
        * storage/SQLTransactionErrorCallback.h: Added.
        (WebCore::SQLTransactionErrorCallback::~SQLTransactionErrorCallback):
        * storage/SQLTransactionErrorCallback.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
kmccullo [Thu, 1 Nov 2007 00:06:56 +0000 (00:06 +0000)]
    Reviewed by Sam.

        - Corrected spelling.

        * wtf/HashTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justing [Wed, 31 Oct 2007 23:23:26 +0000 (23:23 +0000)]
WebCore:

        Reviewed by Dave Harrison.

        <rdar://problem/5569741> Pasting content with a line break into a list can remove the list

        * editing/htmlediting.cpp:
        (WebCore::enclosingEmptyListItem): A single list item can contain multiple
        paragraphs, so if the incoming VisiblePosition is in an empty paragraph in a
        list item, that list item isn't necessarily empty.

LayoutTests:

        Reviewed by Dave Harrison.

        * editing/execCommand/5569741.html: Added.
        * platform/mac/editing/execCommand/5569741-expected.checksum: Added.
        * platform/mac/editing/execCommand/5569741-expected.png: Added.
        * platform/mac/editing/execCommand/5569741-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
timothy@apple.com [Wed, 31 Oct 2007 23:12:35 +0000 (23:12 +0000)]
    Reviewed by John Sullivan.

        Move the developer extras preference to WebPreferences.

        * WebView/WebPreferenceKeysPrivate.h: Add WebKitDeveloperExtrasEnabledPreferenceKey
        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]): Initialize WebKitDeveloperExtrasEnabledPreferenceKey to NO.
        (-[WebPreferences developerExtrasEnabled]): Check DisableWebKitDeveloperExtras, WebKitDeveloperExtras
          and IncludeDebugMenu in addition to WebKitDeveloperExtrasEnabledPreferenceKey.
        (-[WebPreferences setDeveloperExtrasEnabled:]): Set WebKitDeveloperExtrasEnabledPreferenceKey.
        * WebView/WebPreferencesPrivate.h: Add developerExtrasEnabled and setDeveloperExtrasEnabled:.
        * WebView/WebView.mm:
        (+[WebView _developerExtrasEnabled]): Removed.
        (-[WebView _preferencesChangedNotification:]): Check the WebPreferences object for developerExtrasEnabled.
        * WebView/WebViewPrivate.h: Removed _developerExtrasEnabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Disable style sharing for animating styles.
hyatt [Wed, 31 Oct 2007 21:19:20 +0000 (21:19 +0000)]
    Disable style sharing for animating styles.

        Reviewed by mitzpettel

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::canShareStyleWithElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
mitz [Wed, 31 Oct 2007 20:58:10 +0000 (20:58 +0000)]
    Reviewed by Darin Adler.

        - fix intermediate length calculation

        * rendering/Length.h:
        (WebCore::Length::blend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Remove timing dependent, occasionally failing cue point tests.
antti [Wed, 31 Oct 2007 20:54:27 +0000 (20:54 +0000)]
    Remove timing dependent, occasionally failing cue point tests.
        Cue points will be replaced with cue ranges soon anyway.

        * media/video-cuepoint-pause-expected.txt: Removed.
        * media/video-cuepoint-remove-multiple-expected.txt: Removed.
        * media/video-cuepoint-multiple-expected.txt: Removed.
        * media/video-cuepoint-remove-expected.txt: Removed.
        * media/video-cuepoint-pause.html: Removed.
        * media/video-cuepoint-remove-multiple.html: Removed.
        * media/video-cuepoint-multiple.html: Removed.
        * media/video-cuepoint-remove.html: Removed.
        * media/video-cuepoint-add-expected.txt: Removed.
        * media/video-cuepoint-add.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
andersca [Wed, 31 Oct 2007 20:07:37 +0000 (20:07 +0000)]
    Reviewed by Darin.

        Add new SQLError implementation.

        * DerivedSources.make:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * storage/SQLError.h: Added.
        (WebCore::SQLError::SQLError):
        (WebCore::SQLError::code):
        (WebCore::SQLError::message):
        * storage/SQLError.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Change the initial value of transition-property to all. Change the initial...
hyatt [Wed, 31 Oct 2007 18:46:55 +0000 (18:46 +0000)]
    Change the initial value of transition-property to all.  Change the initial value of
        transition-duration to 0.

        Reviewed by antti

        * rendering/RenderStyle.h:
        (WebCore::RenderStyle::initialTransitionDuration):
        (WebCore::RenderStyle::initialTransitionProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSwitch the Debug configuration to using the non-debug CRT
aroben [Wed, 31 Oct 2007 18:33:17 +0000 (18:33 +0000)]
Switch the Debug configuration to using the non-debug CRT

WebKitTools:

        Switch the Debug configuration to using the non-debug CRT

        This matches WebKit.

        Reviewed by Steve.

        * DumpRenderTree/win/DumpRenderTree.vcproj:

WebKit/win:

        Switch the Debug configuration to using the non-debug CRT

        The debug CRT conflicts with what Safari uses, which causes loading
        problems.

        Reviewed by Steve.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27326 268f45cc-cd09-0410-ab3c-d52691b4dbfc