thatcher [Wed, 15 Nov 2006 19:41:26 +0000 (19:41 +0000)]
Explicitly set GCC 4 for all of our projects, since the system default can be GCC 3.3.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Wed, 15 Nov 2006 19:35:42 +0000 (19:35 +0000)]
Reviewed by Darin.
<rdar://problem/
4836034> REGRESSION: Hang while spell-checking (advanceToNextMisspelling)
Test:
* manual-tests/keep_spelling_markers.html:
Updated to include checking for this bug.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::advanceToNextMisspelling):
it.advance() even when current string is a single space.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 15 Nov 2006 19:24:35 +0000 (19:24 +0000)]
Reviewed by lamadio
Backing out macro expansion
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::isRecognizedTagName):
* ksvg2/scripts/make_names.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Wed, 15 Nov 2006 18:41:41 +0000 (18:41 +0000)]
Reviewed by Darin.
<rdar://problem/
4770453> VO not honoring secure edit fields in web pages
The remaining problem was the password fields would return their contents
even though they did not advertise that they could. Apparently, VoiceOver
does not read the ads.
* bridge/mac/WebCoreAXObject.mm:
(isPasswordFieldElement):
(-[WebCoreAXObject isPasswordField]):
(-[WebCoreAXObject textMarkerForVisiblePosition:]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
(-[WebCoreAXObject doAXStringForRange:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lamadio [Wed, 15 Nov 2006 18:19:37 +0000 (18:19 +0000)]
2006-11-13 Lou Amadio <lamadio@apple.com>
Reviewed by Darin Adler, Maciej Stachowiak
Cleanup: Expanded macros in generated files
* html/HTMLElement.cpp:
(WebCore::HTMLElement::isRecognizedTagName):
* ksvg2/scripts/make_names.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 17:34:13 +0000 (17:34 +0000)]
Reviewed by Geoff.
Use Vector instead of DeprecatedPtrList.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
* editing/BreakBlockquoteCommand.cpp:
* rendering/RenderFlow.cpp:
(WebCore::RenderFlow::paintOutline):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 17:24:05 +0000 (17:24 +0000)]
Reviewed by Adele.
isTargetItem is used by DRT, so make it private instead of internal.
* History/WebHistoryItem.m:
(-[WebHistoryItem isTargetItem]):
* History/WebHistoryItemInternal.h:
* History/WebHistoryItemPrivate.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 15 Nov 2006 09:45:48 +0000 (09:45 +0000)]
Build fix.
* page/EventHandler.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 15 Nov 2006 09:29:28 +0000 (09:29 +0000)]
Reviewed by Maciej
Split much of unused WebHistoryItemPrivate.h SPI into WebHistoryItemInternal.h
* History/WebBackForwardList.m:
* History/WebHistory.m:
* History/WebHistoryItem.m:
(-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
(-[WebHistoryItem initWithURL:title:]):
(-[WebHistoryItem visitCount]):
(-[WebHistoryItem RSSFeedReferrer]):
(-[WebHistoryItem setRSSFeedReferrer:]):
(-[WebHistoryItem children]):
(-[WebHistoryItem dictionaryRepresentation]):
(-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
(+[WebHistoryItem _releaseAllPendingPageCaches]):
(-[WebHistoryItem URL]):
(-[WebHistoryItem target]):
(-[WebHistoryItem _setLastVisitedTimeInterval:]):
(-[WebHistoryItem _lastVisitedDate]):
(-[WebHistoryItem targetItem]):
* History/WebHistoryItemInternal.h: Added.
* History/WebHistoryItemPrivate.h:
* WebCoreSupport/WebFrameBridge.mm:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebFrame.mm:
* WebView/WebView.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 15 Nov 2006 06:57:15 +0000 (06:57 +0000)]
2006-11-14 Matt Lilek <pewtermoose@gmail.com>
Reviewed by Tim Hatcher.
Moved the web developer page to the wiki, adding link to the Drosera page.
* .htaccess: Add permanent redirect to the new page on the wiki.
* contact.html: Trac numbers are no longer one off.
* nav.inc:
* webdevelopers/index.html: Removed.
* webdevelopers/webkit_version.html: Removed.
* webdevelopers/webkit_version.js: Removed.
* webdevelopers/webkit_version_xl.html: Removed.
* webdevelopers/webkit_version_xl.js: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 15 Nov 2006 06:09:32 +0000 (06:09 +0000)]
WebCore:
Reviewed by Geoff.
Moving things off the bridge and onto clients.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::selectWordBeforeMenuEvent):
(WebEditorClient::isEditable):
* WebCoreSupport/WebFrameBridge.mm:
* WebKit.xcodeproj/project.pbxproj:
WebKit:
Reviewed by Geoff.
Move things off the bridge, and move sendContextMenuEvent() from
EventHandlerMac to EventHandler.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bridge/EditorClient.h:
* bridge/mac/WebCoreFrameBridge.h:
* editing/Editor.cpp:
(WebCore::Editor::selectWordBeforeMenuEvent):
(WebCore::Editor::clientIsEditable):
* editing/Editor.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):
* page/EventHandler.h:
* page/mac/EventHandlerMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 15 Nov 2006 05:42:44 +0000 (05:42 +0000)]
WebCore:
Reviewed by Harrison.
<rdar://problem/
4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
Adds an EditableLinkNeverLive setting that will make links in editable areas always dead.
* bridge/mac/WebCoreSettings.mm:
(-[WebCoreSettings setEditableLinkBehavior:]):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::setActive):
(WebCore::HTMLAnchorElement::isLiveLink):
* page/FrameView.cpp:
(WebCore::selectCursor):
* page/Settings.h:
(WebCore::Settings::):
WebKit:
Reviewed by Harrison.
<rdar://problem/
4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
Adds an Open Link, Open Link in New Window and Copy Link to the editing context menu.
Adds a new WebKitEditableLinkNeverLive preference value that maps to WebCore's EditableLinkNeverLive.
* DefaultDelegates/WebDefaultContextMenuDelegate.m:
(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
(-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
(-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
(-[WebDefaultUIDelegate requestWithURL:includingReferrerFromFrame:]):
(-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
(-[WebDefaultUIDelegate openLink:]):
* English.lproj/Localizable.strings:
* WebKit.exp:
* WebView/WebPreferences.m:
(-[WebPreferences editableLinkBehavior]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebUIDelegatePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 15 Nov 2006 05:17:41 +0000 (05:17 +0000)]
2006-11-14 Mark Rowe <bdash@webkit.org>
Reviewed by Oliver.
Build fix
* bindings/scripts/CodeGenerator.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 05:06:24 +0000 (05:06 +0000)]
WebCore:
Turns out I wasn't forcing DWARF on the world at all,
it's now the default!
* WebCore.xcodeproj/project.pbxproj:
WebKit:
Turns out I wasn't forcing DWARF on the world at all,
it's now the default!
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 05:01:15 +0000 (05:01 +0000)]
WebCore:
I must stop trying to force DWARF on the world.
* WebCore.xcodeproj/project.pbxproj:
WebKit:
I must stop trying to force DWARF on the world.
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 15 Nov 2006 03:52:19 +0000 (03:52 +0000)]
LayoutTests:
Reviewed by harrison
<rdar://problem/
4806874>
Missing background image after paste
Checking in new expected results for fixes:
* editing/inserting/insert-
3851164-fix-expected.checksum:
* editing/inserting/insert-
3851164-fix-expected.png:
* editing/selection/drag-in-iframe-expected.checksum:
* editing/selection/drag-in-iframe-expected.png:
Same, but also removing an outdated comment about a bug:
* editing/pasteboard/paste-text-019-expected.checksum:
* editing/pasteboard/paste-text-019-expected.png:
* editing/pasteboard/paste-text-019-expected.txt:
* editing/pasteboard/paste-text-019.html:
Added:
* editing/pasteboard/
4806874-expected.checksum: Added.
* editing/pasteboard/
4806874-expected.png: Added.
* editing/pasteboard/
4806874-expected.txt: Added.
* editing/pasteboard/
4806874.html: Added.
Equivalent render trees:
* editing/inserting/insert-
3907422-fix-expected.txt:
* editing/pasteboard/paste-text-011-expected.txt:
* editing/pasteboard/paste-text-015-expected.txt:
WebCore:
Reviewed by harrison
<rdar://problem/
4806874>
Missing background image after paste
* editing/markup.cpp:
(WebCore::createMarkup): If the body is fully selected, add a
div with its CSS properties to the markup. Migrated a use of
enclosingBlockFlowElement to enclosingBlock to fix an infinite
loop when pasting <div><input></div>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 03:20:06 +0000 (03:20 +0000)]
2006-11-14 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
Add Undo/Redo to execCommand.
* editing/Editor.cpp:
(WebCore::execRedo):
(WebCore::execUndo):
(WebCore::canRedo):
(WebCore::canUndo):
(WebCore::CommandEntry::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 15 Nov 2006 01:29:46 +0000 (01:29 +0000)]
WebCore:
Reviewed by Anders.
- created EventHandler class, moved event handling code from both
Frame and FrameView in there
- added ScrollTypes.h header so you can include the scroller-related
enums without all of Scrollbar.h
* page/EventHandler.cpp: Added.
* page/EventHandler.h: Added.
* page/mac/EventHandlerMac.mm: Added.
* platform/ScrollBarMode.h: Removed.
* platform/ScrollTypes.h: Added.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::FrameMac):
(WebCore::FrameMac::~FrameMac):
(WebCore::FrameMac::bridgeForWidget):
(WebCore::FrameMac::imageFromRect):
* bridge/mac/FrameViewMac.mm:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge scrollOverflowInDirection:granularity:]):
(-[WebCoreFrameBridge nextKeyView]):
(-[WebCoreFrameBridge previousKeyView]):
(-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]):
(-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):
(-[WebCoreFrameBridge _visiblePositionForPoint:]):
(-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
(-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
(-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
(-[WebCoreFrameBridge dragSourceMovedTo:]):
(-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
* dom/Document.cpp:
(WebCore::Document::hoveredNodeDetached):
* dom/Element.h:
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::defaultEventHandler):
* editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController):
* editing/SelectionController.h:
(WebCore::SelectionController::setCaretBlinkingSuspended):
(WebCore::SelectionController::isCaretBlinkingSuspended):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isKeyboardFocusable):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setFocus):
* html/HTMLFrameElementBase.h:
* html/HTMLGenericFormElement.cpp:
(WebCore::HTMLGenericFormElement::isKeyboardFocusable):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::open):
* page/Frame.cpp:
(WebCore::Frame::caretBlinkTimerFired):
(WebCore::Frame::frameForWidget):
(WebCore::Frame::eventHandler):
(WebCore::Frame::setProhibitsScrolling):
(WebCore::FramePrivate::FramePrivate):
* page/Frame.h:
* page/FramePrivate.h:
* page/FrameView.cpp:
(WebCore::FrameViewPrivate::FrameViewPrivate):
(WebCore::FrameViewPrivate::reset):
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::clear):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::addRepaintInfo):
(WebCore::FrameView::layout):
(WebCore::FrameView::scrollPointRecursively):
(WebCore::FrameView::setContentsPos):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::scheduleEvent):
(WebCore::FrameView::updateOverflowStatus):
(WebCore::FrameView::dispatchScheduledEvents):
(WebCore::FrameView::windowClipRectForLayer):
(WebCore::FrameView::handleMouseMoveEvent):
(WebCore::FrameView::handleMouseReleaseEvent):
* page/FrameView.h:
* page/PageState.cpp:
(WebCore::PageState::PageState):
(WebCore::PageState::restore):
* page/PageState.h:
* platform/ScrollBar.h:
* platform/ScrollView.h:
* platform/mac/ClipboardMac.mm:
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::show):
* platform/mac/SliderMac.mm:
(-[WebCoreSlider becomeFirstResponder]):
(-[WebCoreSlider nextKeyView]):
(-[WebCoreSlider previousKeyView]):
(-[WebCoreSlider canBecomeKeyView]):
(Slider::focusPolicy):
* platform/mac/WebCoreTextField.mm:
(-[WebCoreTextFieldController textView:shouldHandleEvent:]):
(-[WebCoreTextFieldController setHasFocus:]):
(-[WebCoreSearchField nextKeyView]):
(-[WebCoreSearchField previousKeyView]):
(-[WebCoreSearchFieldCell _addStringToRecentSearches:]):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::hasFocus):
(WebCore::Widget::clearFocus):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::setResizing):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::autoscroll):
(WebCore::RenderLayer::resize):
(WebCore::RenderLayer::updateOverflowStatus):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::autoscroll):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::draggableNode):
(WebCore::RenderObject::destroy):
* rendering/RenderObject.h:
(WebCore::RenderObject::RepaintInfo::RepaintInfo):
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::viewCleared):
WebKit:
Reviewed by Anders.
- update for creation of EventHandler
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::actionDictionary):
* WebView/WebHTMLView.m:
(-[WebHTMLView _updateMouseoverWithEvent:]):
(-[NSArray menuForEvent:]):
(-[NSArray scrollWheel:]):
(-[NSArray acceptsFirstMouse:]):
(-[NSArray shouldDelayWindowOrderingForEvent:]):
(-[NSArray mouseDown:]):
(-[NSArray mouseDragged:]):
(-[NSArray mouseUp:]):
(-[NSArray keyDown:]):
(-[NSArray keyUp:]):
(-[NSArray performKeyEquivalent:]):
(-[WebHTMLView elementAtPoint:allowShadowContent:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 01:21:36 +0000 (01:21 +0000)]
Fix build for real this time.
* WebCoreSupport/WebEditorClient.mm:
(-[WebEditCommand initWithEditCommand:WebCore::]):
(-[WebEditCommand dealloc]):
(-[WebEditCommand finalize]):
(+[WebEditCommand commandWithEditCommand:]):
(-[WebEditCommand command]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 01:07:43 +0000 (01:07 +0000)]
2006-11-14 Anders Carlsson <acarlsson@apple.com>
Try fixing the build.
* WebCoreSupport/WebEditorClient.mm:
(-[WebEditorUndoTarget undoEditing:]):
(-[WebEditorUndoTarget redoEditing:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 00:36:50 +0000 (00:36 +0000)]
WebCore:
Reviewed by Darin.
Let the editor client handle undo/redo.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bridge/EditorClient.h:
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::canUndo):
(WebCore::FrameMac::canRedo):
* bridge/mac/WebCoreEditCommand.h: Removed.
* bridge/mac/WebCoreEditCommand.mm: Removed.
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
* editing/JSEditor.cpp:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::closeURL):
* page/Frame.cpp:
* page/Frame.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::updateFromElement):
WebKit:
Reviewed by Darin.
Move undo/redo handling into WebEditorClient.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::WebEditorClient):
(WebEditorClient::~WebEditorClient):
(-[WebEditCommand initWithEditCommand:WebCore::]):
(-[WebEditCommand dealloc]):
(-[WebEditCommand finalize]):
(+[WebEditCommand commandWithEditCommand:]):
(-[WebEditCommand command]):
(-[WebEditorUndoTarget undoEditing:]):
(-[WebEditorUndoTarget redoEditing:]):
(undoNameForEditAction):
(WebEditorClient::registerCommandForUndoOrRedo):
(WebEditorClient::registerCommandForUndo):
(WebEditorClient::registerCommandForRedo):
(WebEditorClient::clearUndoRedoOperations):
(WebEditorClient::canUndo):
(WebEditorClient::canRedo):
(WebEditorClient::undo):
(WebEditorClient::redo):
* WebCoreSupport/WebFrameBridge.mm:
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 14 Nov 2006 22:33:49 +0000 (22:33 +0000)]
Reviewed and landed by Brady
Fix Qt/Linux build.
* ChangeLog:
* loader/qt/FrameLoaderQt.cpp:
(WebCore::FrameLoader::submitForm):
* platform/network/qt/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::add):
* platform/qt/FrameQtClient.cpp:
(WebCore::FrameQtClientDefault::submitForm):
* platform/qt/FrameQtClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 14 Nov 2006 21:51:02 +0000 (21:51 +0000)]
Fixing the site.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 14 Nov 2006 21:44:01 +0000 (21:44 +0000)]
2006-11-14 Mark Rowe <bdash@webkit.org>
Reviewed by Tim Hatcher.
http://bugs.webkit.org/show_bug.cgi?id=9529
Bug 9529: Navigation HTML duplicated on webkit.org web site
* blog/wp-content/themes/webkit/sidebar.php: Include navigation from nav.inc rather than duplicating it here.
* nav.inc: Generate WordPress archive list if included from within WordPress.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 14 Nov 2006 19:52:07 +0000 (19:52 +0000)]
Reviewed by Anders
Cleanup of my patch last night and merging with aroben-style changes from this morning
(More ref-counted FormData stuff)
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::postData):
* platform/network/ResourceHandle.h:
* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::setHTTPBody):
* platform/network/mac/FormDataStreamMac.h:
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::getStreamFormDatas):
(WebCore::formCreate):
(WebCore::formFinalize):
(WebCore::setHTTPBody):
(WebCore::httpBodyFromStream):
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::getResourceRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 14 Nov 2006 18:57:01 +0000 (18:57 +0000)]
2006-11-14 Rob Buis <buis@kde.org>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11575
Bug 11575: REGRESSION: WebCore crash in CSSParser/HTMLTokenizer
Test: fast/css/css-imports.html
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::insertedIntoParent):
Fix the crash by testing for null pointer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 14 Nov 2006 18:11:51 +0000 (18:11 +0000)]
Reviewed by Tim H.
http://bugs.webkit.org/show_bug.cgi?id=3387
Redundant keydown, keypress, keyup events sent for arrow keys
Added another layer of ugly hacks around AppKit event dispatching.
1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store
_private->keyDownEvent in both methods, and make it persist after leaving them.
2. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind,
use [NSApp currentEvent] to check for this to prevent it from being passed to WebCore.
Test: manual-tests/arrow-key-events.html
* WebView/WebHTMLView.m:
(-[NSMutableDictionary dealloc]):
(-[NSArray keyDown:]):
(-[NSArray keyUp:]):
(-[NSArray performKeyEquivalent:]):
* WebView/WebHTMLViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 14 Nov 2006 18:06:07 +0000 (18:06 +0000)]
2006-11-14 Darin Adler <darin@apple.com>
Reviewed by Adam.
Fix up usages of FormData within CFNet loader code.
* platform/network/ResourceRequest.h:
(WebCore::ResourceRequest::httpBody):
* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::getStreamFormDatas): Store RefPtr<FormData>s in the
streamFormDatas HashMap.
(WebCore::formCreate):
(WebCore::formFinalize): Removed delete because the remove() will deref
and delete if necessary.
(WebCore::setHTTPBody): Changed parameter to PassRefPtr.
(WebCore::httpBodyFromStream):
* platform/network/cf/FormDataStreamCFNet.h: Fix declarations.
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::getResourceRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 14 Nov 2006 11:55:34 +0000 (11:55 +0000)]
2006-11-14 Greg Jackson <gjspanner@gmail.com>
Reviewed by Darin.
Preserves any pre-existing value for WEBCORE_NAVIGATOR_PLATFORM
rather than overriding it based on platform detection.
* bindings/js/kjs_navigator.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 14 Nov 2006 03:54:33 +0000 (03:54 +0000)]
Reviewed by Maciej
Made FormData Shared, and pass it around as such.
* WebCore.xcodeproj/project.pbxproj: Reordered some items
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formData):
(WebCore::HTMLFormElement::submit):
* html/HTMLFormElement.h:
* loader/FrameLoader.cpp:
(WebCore::FormSubmission::FormSubmission):
(WebCore::FrameLoader::submitForm):
* loader/FrameLoader.h:
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::post):
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::create):
* platform/network/FormData.h: Made FormData shared
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::postData):
* platform/network/ResourceRequest.h:
(WebCore::ResourceRequest::httpBody):
(WebCore::ResourceRequest::setHTTPBody):
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::getResourceRequest):
(WebCore::nsURLRequest):
* platform/network/mac/FormDataStreamMac.h:
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::getStreamFormDatas): Hash Streams to RefPtr<FormData>s
(WebCore::formCreate):
(WebCore::formFinalize):
(WebCore::setHTTPBody):
(WebCore::httpBodyFromStream):
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::send):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 14 Nov 2006 02:45:08 +0000 (02:45 +0000)]
I accidently checked in old expected results in my previous checkin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 14 Nov 2006 02:37:58 +0000 (02:37 +0000)]
LayoutTests:
Reviewed by harrison
* editing/selection/drag-select-1-expected.checksum: Added.
* editing/selection/drag-select-1-expected.png: Added.
* editing/selection/drag-select-1-expected.txt: Added.
* editing/selection/drag-select-1.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/
4828264>
In Mail, a crash occurs at WebCore::Selection::toRange() when selecting this web content (http://www.cnet.com/)
The start of the selection is in an editable area, and the end is in an
input field inside that editable area. The code that should pull the end
of such a selection outside the input field didn't escape shadow nodes,
it would leave a dangling end, causing the crash in toRange.
* editing/Selection.cpp:
(WebCore::Selection::adjustForEditableContent): Added an ASSERT and a fixup
to prevent crashes like this in future Release builds.
* editing/htmlediting.cpp:
(WebCore::firstEditablePositionAfterPositionInRoot): Let this function
escape shadow nodes. We might eventually push this code down into
next/previous{VisuallyDistinct}Canditate.
(WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Mon, 13 Nov 2006 23:56:01 +0000 (23:56 +0000)]
Reviewed by darin
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
* editing/Editor.h:
(WebCore::Editor::setRemovedAnchor): Pass a PassRefPtr.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Mon, 13 Nov 2006 23:37:43 +0000 (23:37 +0000)]
LayoutTests:
Reviewed by Oliver
* editing/pasteboard/paste-unrendered-select-expected.checksum: Added.
* editing/pasteboard/paste-unrendered-select-expected.png: Added.
* editing/pasteboard/paste-unrendered-select-expected.txt: Added.
* editing/pasteboard/paste-unrendered-select.html: Added.
WebCore:
Reviewed by Oliver
<rdar://problem/
4820026>
copy/paste of news.google.com yields text from hidden select element options
We were adding descendants of unrendered select elements.
* editing/markup.cpp:
(WebCore::createMarkup): Don't traverse into nodes without renderers, unless
they are grandfathered in by a rendered select element.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 13 Nov 2006 21:46:59 +0000 (21:46 +0000)]
Explicitly set Dwarf for projects that didn't specify the debugging format.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 13 Nov 2006 21:38:23 +0000 (21:38 +0000)]
Switching to Dwarf for Debug and Production. Debuggign will work best with Xcode 2.4.1 or later.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 13 Nov 2006 07:13:39 +0000 (07:13 +0000)]
Rubberstamped by Anders
Changed some #includes from <WebKit/foo.h> to "foo.h"
* History/WebBackForwardList.m:
* History/WebHistory.m:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sun, 12 Nov 2006 23:44:42 +0000 (23:44 +0000)]
Reviewed by Beth Dakin.
Added project-wide setting to disable Microsoft's made-up deprecation
warnings related to std:: functions. (Doesn't have any affect yet,
since we currently disable all deprecation warnings.)
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 12 Nov 2006 15:18:32 +0000 (15:18 +0000)]
2006-11-12 Simon Hausmann <hausmann@kde.org>
Reviewed by Sam Weinig.
Fix Qt build. Missing AbstractShared implementation.
http://bugs.webkit.org/show_bug.cgi?id=11581
* loader/qt/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::ref):
(WebCore::FrameLoaderClientQt::deref):
* loader/qt/FrameLoaderClientQt.h:
* platform/qt/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::ref):
(WebCore::ChromeClientQt::deref):
* platform/qt/ChromeClientQt.h:
* platform/qt/EditorClientQt.cpp:
(WebCore::EditorClientQt::ref):
(WebCore::EditorClientQt::deref):
* platform/qt/EditorClientQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 12 Nov 2006 12:29:58 +0000 (12:29 +0000)]
2006-11-13 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Fix some Linux/Gdk build issues noted by Alp Toker.
* Projects/gdk/webcore-gdk.bkl:
* WebCoreSources.bkl:
* platform/graphics/gdk/ImageGdk.cpp:
(WebCore::Image::loadPlatformResource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sun, 12 Nov 2006 09:31:36 +0000 (09:31 +0000)]
Reviewed by Anders
Logging channel plumbing for future work
* platform/Logging.cpp:
(WebCore::):
* platform/Logging.h:
* platform/mac/LoggingMac.mm:
(WebCore::InitializeLoggingChannelsIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 12 Nov 2006 08:47:51 +0000 (08:47 +0000)]
2006-11-12 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Linux/Gdk compilation fixes, and bakefile cleanups. Based on patches by
Alp Toker.
* Projects/gdk/webcore-gdk.bkl:
* WebCoreSources.bkl:
* page/PageState.cpp:
* platform/gdk/ChromeClientGdk.h:
(WebCore::ChromeClientGdk::ref):
(WebCore::ChromeClientGdk::deref):
* platform/gdk/FrameGdk.cpp:
(WebCore::FrameGdkClientDefault::openURL):
(WebCore::FrameGdkClientDefault::didReceiveData):
(WebCore::FrameGdkClientDefault::receivedAllData):
(WebCore::FrameGdk::FrameGdk):
(WebCore::FrameGdk::~FrameGdk):
* platform/gdk/FrameGdk.h:
* platform/gdk/KeyEventGdk.cpp:
(WebCore::keyIdentifierForGdkKeyCode):
* platform/gdk/ScreenClientGdk.h: Removed.
* platform/gdk/TemporaryLinkStubs.cpp:
(FrameGdk::canPaste):
(FrameGdk::originalRequestURL):
(TextField::TextField):
* platform/network/gdk/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::add):
(WebCore::ResourceHandleManager::cancel):
* webcore-base.bkl:
2006-11-12 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Clean up of JavaScriptCore bakefiles.
* JavaScriptCoreSources.bkl:
* jscore.bkl:
2006-11-12 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Clean up of GdkLauncher bakefile.
* GdkLauncher/gdklauncher.bkl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sun, 12 Nov 2006 04:53:17 +0000 (04:53 +0000)]
WebCore:
Reviewed by Maciej Stachowiak.
- Fixed loader crash by clarifying ownership of WebKit client objects.
WebCore objects own their WebKit clients, and ref and deref through
virtual methods, leaving WebKit free to use whatever client / reference-counting
implementation it likes.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bridge/EditorClient.h: Fixed up function prototypes for style.
* loader/FrameLoader.cpp: Removed detachFrameLoader, since its real purpose
was to implement an alternative ownership model.
(WebCore::FrameLoader::~FrameLoader): Removed empty destructor.
(WebCore::FrameLoader::setClient): This function now takes ownership
(WebCore::FrameLoader::client):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* page/ChromeClient.h:
* platform/AbstractShared.h: Added. This is the virtual function-based refcounting
complement to Shared.
(WebCore::AbstractShared::~AbstractShared):
WebKit:
Reviewed by Maciej Stachowiak.
- Fixed loader crash by clarifying ownership of WebKit client objects.
WebCore objects own their WebKit clients, and ref and deref through
virtual methods, leaving WebKit free to use whatever client / reference-counting
implementation it likes.
WebKit on Mac just uses the same refcounting class that WebCore uses (Shared),
but other platforms may choose to do other things.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::ref):
(WebChromeClient::deref):
(WebChromeClient::refCount):
* WebCoreSupport/WebEditorClient.h: Nixed commented-out function prototypes.
The ones in WebCore make clear what remains to be implemented. Replaced constructor
with factory function to avoid leaks.
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::create):
(WebEditorClient::WebEditorClient):
(WebEditorClient::setWebFrame):
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
(-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
* WebCoreSupport/WebFrameLoaderClient.h: Replaced constructor with factory
function to avoid leaks.
(WebFrameLoaderClient::ref):
(WebFrameLoaderClient::deref):
(WebFrameLoaderClient::refCount):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::create):
* WebView/WebFrame.mm:
(-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Sun, 12 Nov 2006 00:13:29 +0000 (00:13 +0000)]
Reviewed by Maciej.
Fix uninitialized variable.
* rendering/RenderStyle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sat, 11 Nov 2006 21:34:15 +0000 (21:34 +0000)]
Grammar fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sat, 11 Nov 2006 21:32:58 +0000 (21:32 +0000)]
Reviewed/landed by Adam.
Complete cleanup of the CMakeLists.txt.
Now all files to be build are sorted in alphabetic order.
General style cleanup, remove all tabs etc.
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 11 Nov 2006 21:32:07 +0000 (21:32 +0000)]
Changed one last bugzilla.opendarwin.org URL to bugs.webkit.org.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 11 Nov 2006 21:28:20 +0000 (21:28 +0000)]
Changed bugzilla.opendarwin.org URLs to bugs.webkit.org in ChangeLog files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 11 Nov 2006 19:10:29 +0000 (19:10 +0000)]
Reviewed and landed by Anders.
Make DRT work again on Qt/Linux.
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sat, 11 Nov 2006 18:36:23 +0000 (18:36 +0000)]
Reviewed by Maciej Stachowiak.
Added missing initializer to ResourceRequest -- fixes some loader crashes
due to assuming a request always has a non-null httpMethod.
* platform/network/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 11 Nov 2006 18:08:40 +0000 (18:08 +0000)]
Reviewed by Maciej
Fixed header guard
* loader/FrameLoaderClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 11 Nov 2006 16:48:47 +0000 (16:48 +0000)]
- attempt to fix Qt build
* platform/qt/CursorQt.cpp:
(WebCore::verticalTextCursor): Added. Just returns pointer cursor.
(WebCore::cellCursor): Ditto.
(WebCore::contextMenuCursor): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Sat, 11 Nov 2006 15:49:45 +0000 (15:49 +0000)]
Reviewed by hyatt.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
InsertRule can not handle @import statements
Allow @import as part of a css rule.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 11 Nov 2006 15:31:13 +0000 (15:31 +0000)]
Attempt to fix Qt build.
* CMakeLists.txt: PathQt.cpp is in graphics/qt now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 11 Nov 2006 15:15:53 +0000 (15:15 +0000)]
2006-11-11 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)
[CSS 3] support for vertical-text, cell and context-menu cursors
http://bugs.webkit.org/show_bug.cgi?id=11494
* Resources/cellCursor.png: Added.
* Resources/contextMenuCursor.png: Added.
* Resources/verticalTextCursor.png: Added.
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSValueKeywords.in:
* manual-tests/cursor.html:
* page/FrameView.cpp:
(WebCore::selectCursor):
* platform/Cursor.h:
* platform/mac/CursorMac.mm:
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
* rendering/RenderStyle.h:
(WebCore::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 11 Nov 2006 14:31:46 +0000 (14:31 +0000)]
2006-11-11 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by aroben and ap, landed by ap.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468
Group graphics related files in platform/graphics.
Move certain files from certain subdirectories
into platform/graphics/{win,mac,cg,gdk,qt}
* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/AffineTransform.cpp: Removed.
* platform/AffineTransform.h: Removed.
* platform/Color.cpp: Removed.
* platform/Color.h: Removed.
* platform/FloatPoint.cpp: Removed.
* platform/FloatPoint.h: Removed.
* platform/FloatRect.cpp: Removed.
* platform/FloatRect.h: Removed.
* platform/FloatSize.cpp: Removed.
* platform/FloatSize.h: Removed.
* platform/Icon.h: Removed.
* platform/Image.cpp: Removed.
* platform/Image.h: Removed.
* platform/ImageSource.h: Removed.
* platform/IntPoint.h: Removed.
* platform/IntRect.cpp: Removed.
* platform/IntRect.h: Removed.
* platform/IntSize.h: Removed.
* platform/IntSizeHash.h: Removed.
* platform/Path.cpp: Removed.
* platform/Path.h: Removed.
* platform/Pen.cpp: Removed.
* platform/Pen.h: Removed.
* platform/cairo/AffineTransformCairo.cpp: Removed.
* platform/cairo/GraphicsContextCairo.cpp: Removed.
* platform/cairo/ImageCairo.cpp: Removed.
* platform/cairo/ImageSourceCairo.cpp: Removed.
* platform/cairo/cairo/AUTHORS: Removed.
* platform/cairo/cairo/COPYING: Removed.
* platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
* platform/cairo/cairo/COPYING-MPL-1.1: Removed.
* platform/cairo/cairo/INSTALL: Removed.
* platform/cairo/cairo/NEWS: Removed.
* platform/cairo/cairo/README: Removed.
* platform/cairo/cairo/TODO: Removed.
* platform/cairo/cairo/src/Makefile.in: Removed.
* platform/cairo/cairo/src/cairo-arc-private.h: Removed.
* platform/cairo/cairo/src/cairo-arc.c: Removed.
* platform/cairo/cairo/src/cairo-array.c: Removed.
* platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
* platform/cairo/cairo/src/cairo-atsui.h: Removed.
* platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
* platform/cairo/cairo/src/cairo-beos.h: Removed.
* platform/cairo/cairo/src/cairo-cache-private.h: Removed.
* platform/cairo/cairo/src/cairo-cache.c: Removed.
* platform/cairo/cairo/src/cairo-clip-private.h: Removed.
* platform/cairo/cairo/src/cairo-clip.c: Removed.
* platform/cairo/cairo/src/cairo-color.c: Removed.
* platform/cairo/cairo/src/cairo-debug.c: Removed.
* platform/cairo/cairo/src/cairo-debug.h: Removed.
* platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
* platform/cairo/cairo/src/cairo-directfb.h: Removed.
* platform/cairo/cairo/src/cairo-features.h: Removed.
* platform/cairo/cairo/src/cairo-features.h.in: Removed.
* platform/cairo/cairo/src/cairo-fixed.c: Removed.
* platform/cairo/cairo/src/cairo-font-options.c: Removed.
* platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
* platform/cairo/cairo/src/cairo-font-subset.c: Removed.
* platform/cairo/cairo/src/cairo-font.c: Removed.
* platform/cairo/cairo/src/cairo-ft-font.c: Removed.
* platform/cairo/cairo/src/cairo-ft-private.h: Removed.
* platform/cairo/cairo/src/cairo-ft.h: Removed.
* platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
* platform/cairo/cairo/src/cairo-glitz.h: Removed.
* platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
* platform/cairo/cairo/src/cairo-gstate.c: Removed.
* platform/cairo/cairo/src/cairo-hash-private.h: Removed.
* platform/cairo/cairo/src/cairo-hash.c: Removed.
* platform/cairo/cairo/src/cairo-hull.c: Removed.
* platform/cairo/cairo/src/cairo-image-surface.c: Removed.
* platform/cairo/cairo/src/cairo-matrix.c: Removed.
* platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
* platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
* platform/cairo/cairo/src/cairo-output-stream.c: Removed.
* platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
* platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
* platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
* platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
* platform/cairo/cairo/src/cairo-path-data.c: Removed.
* platform/cairo/cairo/src/cairo-path-fill.c: Removed.
* platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
* platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
* platform/cairo/cairo/src/cairo-path.c: Removed.
* platform/cairo/cairo/src/cairo-pattern.c: Removed.
* platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
* platform/cairo/cairo/src/cairo-pdf.h: Removed.
* platform/cairo/cairo/src/cairo-pen.c: Removed.
* platform/cairo/cairo/src/cairo-platform.h: Removed.
* platform/cairo/cairo/src/cairo-png.c: Removed.
* platform/cairo/cairo/src/cairo-polygon.c: Removed.
* platform/cairo/cairo/src/cairo-private.h: Removed.
* platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
* platform/cairo/cairo/src/cairo-ps.h: Removed.
* platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
* platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
* platform/cairo/cairo/src/cairo-quartz.h: Removed.
* platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
* platform/cairo/cairo/src/cairo-quartz2.h: Removed.
* platform/cairo/cairo/src/cairo-region.c: Removed.
* platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
* platform/cairo/cairo/src/cairo-slope.c: Removed.
* platform/cairo/cairo/src/cairo-spline.c: Removed.
* platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
* platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
* platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
* platform/cairo/cairo/src/cairo-surface.c: Removed.
* platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
* platform/cairo/cairo/src/cairo-svg.h: Removed.
* platform/cairo/cairo/src/cairo-traps.c: Removed.
* platform/cairo/cairo/src/cairo-unicode.c: Removed.
* platform/cairo/cairo/src/cairo-wideint.c: Removed.
* platform/cairo/cairo/src/cairo-wideint.h: Removed.
* platform/cairo/cairo/src/cairo-win32-font.c: Removed.
* platform/cairo/cairo/src/cairo-win32-private.h: Removed.
* platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
* platform/cairo/cairo/src/cairo-win32.h: Removed.
* platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
* platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
* platform/cairo/cairo/src/cairo-xcb.h: Removed.
* platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
* platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
* platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
* platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
* platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
* platform/cairo/cairo/src/cairo-xlib.h: Removed.
* platform/cairo/cairo/src/cairo.c: Removed.
* platform/cairo/cairo/src/cairo.h: Removed.
* platform/cairo/cairo/src/cairoint.h: Removed.
* platform/cairo/cairo/src/test-fallback-surface.c: Removed.
* platform/cairo/cairo/src/test-fallback-surface.h: Removed.
* platform/cairo/cairo/src/test-meta-surface.c: Removed.
* platform/cairo/cairo/src/test-meta-surface.h: Removed.
* platform/cairo/cairo/src/test-paginated-surface.c: Removed.
* platform/cairo/cairo/src/test-paginated-surface.h: Removed.
* platform/cairo/pixman/AUTHORS: Removed.
* platform/cairo/pixman/COPYING: Removed.
* platform/cairo/pixman/README: Removed.
* platform/cairo/pixman/src/Makefile.in: Removed.
* platform/cairo/pixman/src/fbcompose.c: Removed.
* platform/cairo/pixman/src/fbedge.c: Removed.
* platform/cairo/pixman/src/fbedgeimp.h: Removed.
* platform/cairo/pixman/src/fbmmx.c: Removed.
* platform/cairo/pixman/src/fbmmx.h: Removed.
* platform/cairo/pixman/src/fbpict.c: Removed.
* platform/cairo/pixman/src/fbpict.h: Removed.
* platform/cairo/pixman/src/fbtrap.c: Removed.
* platform/cairo/pixman/src/icblt.c: Removed.
* platform/cairo/pixman/src/icbltone.c: Removed.
* platform/cairo/pixman/src/iccolor.c: Removed.
* platform/cairo/pixman/src/icformat.c: Removed.
* platform/cairo/pixman/src/icimage.c: Removed.
* platform/cairo/pixman/src/icimage.h: Removed.
* platform/cairo/pixman/src/icint.h: Removed.
* platform/cairo/pixman/src/icpixels.c: Removed.
* platform/cairo/pixman/src/icrect.c: Removed.
* platform/cairo/pixman/src/icrop.h: Removed.
* platform/cairo/pixman/src/icstipple.c: Removed.
* platform/cairo/pixman/src/ictransform.c: Removed.
* platform/cairo/pixman/src/ictrap.c: Removed.
* platform/cairo/pixman/src/ictri.c: Removed.
* platform/cairo/pixman/src/icutil.c: Removed.
* platform/cairo/pixman/src/pixman-remap.h: Removed.
* platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
* platform/cairo/pixman/src/pixman.h: Removed.
* platform/cairo/pixman/src/pixregion.c: Removed.
* platform/cairo/pixman/src/pixregionint.h: Removed.
* platform/cairo/pixman/src/renderedge.c: Removed.
* platform/cairo/pixman/src/renderedge.h: Removed.
* platform/cairo/pixman/src/slim_internal.h: Removed.
* platform/cairo/rgb24-hacks.txt: Removed.
* platform/cairo/scale-removal.txt: Removed.
* platform/cg/AffineTransformCG.cpp: Removed.
* platform/cg/FloatPointCG.cpp: Removed.
* platform/cg/FloatRectCG.cpp: Removed.
* platform/cg/FloatSizeCG.cpp: Removed.
* platform/cg/GraphicsContextCG.cpp: Removed.
* platform/cg/GraphicsContextPlatformPrivate.h: Removed.
* platform/cg/ImageCG.cpp: Removed.
* platform/cg/ImageSourceCG.cpp: Removed.
* platform/cg/IntPointCG.cpp: Removed.
* platform/cg/IntRectCG.cpp: Removed.
* platform/cg/IntSizeCG.cpp: Removed.
* platform/cg/PDFDocumentImage.cpp: Removed.
* platform/cg/PDFDocumentImage.h: Removed.
* platform/cg/PathCG.cpp: Removed.
* platform/gdk/ImageGdk.cpp: Removed.
* platform/mac/ColorMac.mm: Removed.
* platform/mac/FloatPointMac.mm: Removed.
* platform/mac/FloatRectMac.mm: Removed.
* platform/mac/FloatSizeMac.mm: Removed.
* platform/mac/GraphicsContextMac.mm:
* platform/mac/IconMac.mm: Removed.
* platform/mac/ImageMac.mm: Removed.
* platform/mac/IntPointMac.mm: Removed.
* platform/mac/IntRectMac.mm: Removed.
* platform/mac/IntSizeMac.mm: Removed.
* platform/qt/AffineTransformQt.cpp: Removed.
* platform/qt/ColorQt.cpp: Removed.
* platform/qt/FloatPointQt.cpp: Removed.
* platform/qt/FloatRectQt.cpp: Removed.
* platform/qt/IconQt.cpp: Removed.
* platform/qt/ImageQt.cpp: Removed.
* platform/qt/ImageSourceQt.cpp: Removed.
* platform/qt/IntPointQt.cpp: Removed.
* platform/qt/IntRectQt.cpp: Removed.
* platform/qt/IntSizeQt.cpp: Removed.
* platform/qt/PathQt.cpp: Removed.
* platform/win/ImageWin.cpp: Removed.
* platform/win/IntPointWin.cpp: Removed.
* platform/win/IntRectWin.cpp: Removed.
* platform/win/IntSizeWin.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gdennis [Sat, 11 Nov 2006 13:10:33 +0000 (13:10 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gdennis [Sat, 11 Nov 2006 12:34:25 +0000 (12:34 +0000)]
WebCore:
Reviewed by hyatt.
A layout test was added when this bug was fixed, so none needed now.
Cleanup after:
REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
http://bugs.webkit.org/show_bug.cgi?id=11570
* rendering/RenderStyle.h:
(WebCore::RenderStyle::isSpace): Removed.
* rendering/RenderText.cpp:
(WebCore::isSpace): Added.
(WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gdennis [Sat, 11 Nov 2006 12:04:50 +0000 (12:04 +0000)]
WebCore:
Reviewed by mitz.
REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
http://bugs.webkit.org/show_bug.cgi?id=11570
* rendering/RenderStyle.h:
(WebCore::RenderStyle::isSpace): Added.
* rendering/RenderText.cpp:
(WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths,
treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'
LayoutTests:
Reviewed by mitz.
REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
http://bugs.webkit.org/show_bug.cgi?id=11570
* fast/text/whitespace/nbsp-mode-and-linewraps-expected.checksum: Added.
* fast/text/whitespace/nbsp-mode-and-linewraps-expected.png: Added.
* fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt: Added.
* fast/text/whitespace/nbsp-mode-and-linewraps.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 11 Nov 2006 08:50:38 +0000 (08:50 +0000)]
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11508
Undisable some warnings for JSImmediate.h
Fix suggested by Don Gibson.
* kjs/JSImmediate.h:
Re-enable all MSVC warnings, move the remaining runtime checks
to compile-time.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 11 Nov 2006 02:55:57 +0000 (02:55 +0000)]
2006-11-10 Zalan Bujtas <zalan.bujtas@nokia.com>
Reviewed by Maciej.
Added s60/symbian platform defines.
http://bugs.webkit.org/show_bug.cgi?id=11540
* wtf/Platform.h:
2006-11-10 Zalan Bujtas <zalan.bujtas@nokia.com>
Reviewed by Maciej.
Added basic types for symbian platform.
http://bugs.webkit.org/show_bug.cgi?id=11540
* config.h:
* platform/AtomicString.h:
(WebCore::AtomicString::AtomicString):
(WebCore::AtomicString::operator TPtrC):
* platform/DeprecatedString.cpp:
(WebCore::initializeHandleNodeBlock):
* platform/DeprecatedString.h: char _internalBuffer has to be in front of
the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with
bitfields and breaks byte aligment
* platform/FloatPoint.h:
* platform/FloatRect.h:
* platform/IntPoint.h:
* platform/IntRect.h:
* platform/IntSize.h:
* platform/PlatformString.h:
(WebCore::String::operator TPtrC):
(WebCore::String::des):
* platform/StringImpl.h:
* platform/symbian/DeprecatedStringSymbian.cpp: Added.
(WebCore::DeprecatedString::setBufferFromDes):
(WebCore::DeprecatedString::fromDes):
(WebCore::DeprecatedString::des):
(WebCore::DeprecatedString::des8):
* platform/symbian/FloatPointSymbian.cpp: Added.
(WebCore::FloatPoint::FloatPoint):
(WebCore::FloatPoint::operator TPoint):
* platform/symbian/FloatRectSymbian.cpp: Added.
(WebCore::FloatRect::FloatRect):
(WebCore::FloatRect::operator TRect):
(WebCore::FloatRect::rect):
* platform/symbian/IntPointSymbian.cpp: Added.
(WebCore::IntPoint::IntPoint):
(WebCore::IntPoint::operator TPoint):
* platform/symbian/IntRectSymbian.cpp: Added.
(WebCore::IntRect::IntRect):
(WebCore::IntRect::operator TRect):
(WebCore::IntRect::Rect):
* platform/symbian/IntSizeSymbian.cpp: Added.
(WebCore::IntSize::IntSize):
(WebCore::IntSize::operator TSize):
* platform/symbian/StringImplSymbian.cpp: Added.
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::des):
* platform/symbian/StringSymbian.cpp: Added.
(WebCore::String::String):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 11 Nov 2006 02:33:16 +0000 (02:33 +0000)]
2006-11-10 Zack Rusin <zack@kde.org>
Reviewed by Anders.
Adjust to the changes Brady made in the Qt code.
* loader/qt/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
* loader/qt/FrameLoaderClientQt.h:
2006-11-10 Zack Rusin <zack@kde.org>
Reviewed by Anders.
Making the Qt code work after refactorings in WebCore.
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::checkLoaded):
* DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Sat, 11 Nov 2006 01:56:24 +0000 (01:56 +0000)]
LayoutTests:
Reviewed by harrison
<rdar://problem/
4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself
* editing/deleting/delete-link-1-expected.checksum: Added.
* editing/deleting/delete-link-1-expected.png: Added.
* editing/deleting/delete-link-1-expected.txt: Added.
* editing/deleting/delete-link-1.html: Added.
* editing/inserting/insert-before-link-1-expected.checksum: Added.
* editing/inserting/insert-before-link-1-expected.png: Added.
* editing/inserting/insert-before-link-1-expected.txt: Added.
* editing/inserting/insert-before-link-1.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/
4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself
The removed anchor element needs to stick around temporarily, in the same way
that the typing style hangs off the caret until the user moves it. Also text
insertion around anchors didn't match TextEdit.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added.
(WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
* editing/DeleteSelectionCommand.h:
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply): Clear the removed anchor after any top level
editing command that doesn't preserve the typing style (matches TextEdit).
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call
setSelection with a message telling it to clear the typing style
(and the saved anchor) here. Save/restore the saved anchor because of this.
* editing/Editor.h:
(WebCore::Editor::removedAnchor): Getter.
(WebCore::Editor::setRemovedAnchor): Setter.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor
if one exists.
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection): Clear the removed anchor whenever
we make a selection change that clears the typing style.
(WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
* editing/htmlediting.cpp:
(WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and
made some changes to match TextEdit's behavior. First, insert content
inside the anchor when the caret is after it, unless the caret is at the
end of the document, or if the caret is before it and at the start of a
paragraph.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 11 Nov 2006 01:18:02 +0000 (01:18 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 11 Nov 2006 01:15:33 +0000 (01:15 +0000)]
Reviewed by Hyatt.
Check for BHIDDEN in isVisible() also.
* rendering/RenderStyle.h:
(WebCore::BorderValue::isVisible):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 11 Nov 2006 00:51:41 +0000 (00:51 +0000)]
Reviewed by Adam.
<rdar://problem/
4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders
Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().
* editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
* rendering/RenderStyle.h:
(WebCore::BorderValue::isVisible):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 11 Nov 2006 00:20:57 +0000 (00:20 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 11 Nov 2006 00:10:13 +0000 (00:10 +0000)]
64-bit build fix. Generates a derived export file for 64-bit architectures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 10 Nov 2006 23:45:47 +0000 (23:45 +0000)]
Rubberstamped by Anders.
Back out some accidentally-committed changes from r17711.
* page/Frame.cpp:
(WebCore::Frame::command):
(WebCore::FramePrivate::FramePrivate):
* page/Frame.h:
* page/FramePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 10 Nov 2006 23:36:56 +0000 (23:36 +0000)]
Reviewed by Anders.
- remove some unnecessary uses of WebDataProtocol
* WebView/WebDataSource.mm: Remove the unneeded include.
* WebView/WebView.mm:
(+[WebView _canHandleRequest:]): Don't bother to check for unreachable URL here.
Any request that has one will be an applewebdata: request, which will pass the check anyway.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 10 Nov 2006 23:20:59 +0000 (23:20 +0000)]
WebCore:
Reviewed by Geoff.
Add more commands, make toggleBold and toggleItalic executable commands.
* WebCore.exp:
* editing/Editor.cpp:
(WebCore::execCopy):
(WebCore::execCut):
(WebCore::execDelete):
(WebCore::execForwardDelete):
(WebCore::execPaste):
(WebCore::execSelectAll):
(WebCore::execToggleBold):
(WebCore::execToggleItalic):
(WebCore::enabled):
(WebCore::canPaste):
(WebCore::hasEditableSelection):
(WebCore::hasEditableRangeSelection):
(WebCore::hasRangeSelection):
(WebCore::hasRichlyEditableSelection):
(WebCore::CommandEntry::):
* editing/Editor.h:
WebKit:
Reviewed by Geoff.
Update for changes to WebCore
* WebView/WebHTMLView.m:
(-[NSArray _applyStyleToSelection:withUndoAction:]):
(-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
(-[NSArray _toggleBold]):
(-[NSArray _toggleItalic]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 10 Nov 2006 21:12:15 +0000 (21:12 +0000)]
Fixed platform #ifs
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 10 Nov 2006 19:45:25 +0000 (19:45 +0000)]
WebCore:
Reviewed by Maciej, Geoff.
Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.
* WebCore.exp:
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
* editing/Editor.cpp:
(WebCore::execMoveBackward):
(WebCore::execMoveBackwardAndModifySelection):
(WebCore::execMoveDown):
(WebCore::execMoveDownAndModifySelection):
(WebCore::execMoveForward):
(WebCore::execMoveForwardAndModifySelection):
(WebCore::execMoveLeft):
(WebCore::execMoveLeftAndModifySelection):
(WebCore::execMoveRight):
(WebCore::execMoveRightAndModifySelection):
(WebCore::execMoveToBeginningOfDocument):
(WebCore::execMoveToBeginningOfDocumentAndModifySelection):
(WebCore::execMoveToBeginningOfSentence):
(WebCore::execMoveToBeginningOfSentenceAndModifySelection):
(WebCore::execMoveToBeginningOfLine):
(WebCore::execMoveToBeginningOfLineAndModifySelection):
(WebCore::execMoveToBeginningOfParagraph):
(WebCore::execMoveToBeginningOfParagraphAndModifySelection):
(WebCore::execMoveToEndOfDocument):
(WebCore::execMoveToEndOfDocumentAndModifySelection):
(WebCore::execMoveToEndOfSentence):
(WebCore::execMoveToEndOfSentenceAndModifySelection):
(WebCore::execMoveToEndOfLine):
(WebCore::execMoveToEndOfLineAndModifySelection):
(WebCore::execMoveToEndOfParagraph):
(WebCore::execMoveToEndOfParagraphAndModifySelection):
(WebCore::execMoveParagraphBackwardAndModifySelection):
(WebCore::execMoveParagraphForwardAndModifySelection):
(WebCore::execMoveUp):
(WebCore::execMoveUpAndModifySelection):
(WebCore::execMoveWordBackward):
(WebCore::execMoveWordBackwardAndModifySelection):
(WebCore::execMoveWordForward):
(WebCore::execMoveWordForwardAndModifySelection):
(WebCore::execMoveWordLeft):
(WebCore::execMoveWordLeftAndModifySelection):
(WebCore::execMoveWordRight):
(WebCore::execMoveWordRightAndModifySelection):
(WebCore::enabledAnySelection):
(WebCore::createCommandMap):
(WebCore::CommandEntry::):
(WebCore::Editor::execCommand):
* editing/Editor.h:
WebKit:
Reviewed by Maciej, Geoff.
Call execCommand directly here instead of going through the bridge.
* WebView/WebHTMLView.m:
(-[NSArray moveBackward:]):
(-[NSArray moveBackwardAndModifySelection:]):
(-[NSArray moveDown:]):
(-[NSArray moveDownAndModifySelection:]):
(-[NSArray moveForward:]):
(-[NSArray moveForwardAndModifySelection:]):
(-[NSArray moveLeft:]):
(-[NSArray moveLeftAndModifySelection:]):
(-[NSArray moveRight:]):
(-[NSArray moveRightAndModifySelection:]):
(-[NSArray moveToBeginningOfDocument:]):
(-[NSArray moveToBeginningOfDocumentAndModifySelection:]):
(-[NSArray moveToBeginningOfSentence:]):
(-[NSArray moveToBeginningOfSentenceAndModifySelection:]):
(-[NSArray moveToBeginningOfLine:]):
(-[NSArray moveToBeginningOfLineAndModifySelection:]):
(-[NSArray moveToBeginningOfParagraph:]):
(-[NSArray moveToBeginningOfParagraphAndModifySelection:]):
(-[NSArray moveToEndOfDocument:]):
(-[NSArray moveToEndOfDocumentAndModifySelection:]):
(-[NSArray moveToEndOfSentence:]):
(-[NSArray moveToEndOfSentenceAndModifySelection:]):
(-[NSArray moveToEndOfLine:]):
(-[NSArray moveToEndOfLineAndModifySelection:]):
(-[NSArray moveToEndOfParagraph:]):
(-[NSArray moveToEndOfParagraphAndModifySelection:]):
(-[NSArray moveParagraphBackwardAndModifySelection:]):
(-[NSArray moveParagraphForwardAndModifySelection:]):
(-[NSArray moveUp:]):
(-[NSArray moveUpAndModifySelection:]):
(-[NSArray moveWordBackward:]):
(-[NSArray moveWordBackwardAndModifySelection:]):
(-[NSArray moveWordForward:]):
(-[NSArray moveWordForwardAndModifySelection:]):
(-[NSArray moveWordLeft:]):
(-[NSArray moveWordLeftAndModifySelection:]):
(-[NSArray moveWordRight:]):
(-[NSArray moveWordRightAndModifySelection:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 10 Nov 2006 19:24:52 +0000 (19:24 +0000)]
WebCore:
Reviewed by Darin
Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
* bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
* loader/FrameLoaderClient.h:
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::sharedIconDatabase):
(WebCore::IconDatabase::~IconDatabase):
* loader/icon/IconDatabase.h:
(WebCore::IconDatabase::isPrivateBrowsingEnabled):
(WebCore::IconDatabase::enabled):
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::finishLoading):
* loader/mac/FrameLoaderMac.mm:
WebKit:
Reviewed by Darin
Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
* Misc/WebIconDatabase.m:
(-[WebIconDatabase init]):
(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconURLForURL:]):
(-[WebIconDatabase defaultIconWithSize:]):
(-[WebIconDatabase defaultIconForURL:withSize:]):
(-[WebIconDatabase retainIconForURL:]):
(-[WebIconDatabase releaseIconForURL:]):
(-[WebIconDatabase setDelegate:]):
(-[WebIconDatabase removeAllIcons]):
(-[WebIconDatabase isIconExpiredForIconURL:]):
(-[WebIconDatabase _isEnabled]):
(-[WebIconDatabase _setIconData:forIconURL:]):
(-[WebIconDatabase _setHaveNoIconForIconURL:]):
(-[WebIconDatabase _setIconURL:forURL:]):
(-[WebIconDatabase _hasEntryForIconURL:]):
(-[WebIconDatabase _applicationWillTerminate:]):
(-[WebIconDatabase _resetCachedWebPreferences:]):
(-[WebIconDatabase _convertToWebCoreFormat]):
(webGetNSImage):
* Misc/WebIconDatabaseInternal.h: Added.
* Misc/WebIconDatabasePrivate.h:
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidReceiveIcon):
* WebCoreSupport/WebIconDatabaseBridge.h: Removed.
* WebCoreSupport/WebIconDatabaseBridge.m: Removed.
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 10 Nov 2006 19:16:18 +0000 (19:16 +0000)]
WebCore:
Reviewed and landed by Anders.
Adjust platform Qt/KDE code to the recent loader
changes.
* CMakeLists.txt:
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::createEmptyDocument):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/qt/DocumentLoaderQt.cpp: Added.
(WebCore::canonicalizedTitle):
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::frameLoader):
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::URL):
(WebCore::DocumentLoader::unreachableURL):
(WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
(WebCore::DocumentLoader::isStopping):
(WebCore::DocumentLoader::clearErrors):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::setupForReplace):
(WebCore::DocumentLoader::commitIfReady):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setCommitted):
(WebCore::DocumentLoader::isCommitted):
(WebCore::DocumentLoader::setLoading):
(WebCore::DocumentLoader::isLoading):
(WebCore::DocumentLoader::doesProgressiveLoad):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::updateLoading):
(WebCore::DocumentLoader::setFrame):
(WebCore::DocumentLoader::attachToFrame):
(WebCore::DocumentLoader::detachFromFrame):
(WebCore::DocumentLoader::prepareForLoadStart):
(WebCore::DocumentLoader::loadingStartedTime):
(WebCore::DocumentLoader::setIsClientRedirect):
(WebCore::DocumentLoader::isClientRedirect):
(WebCore::DocumentLoader::setPrimaryLoadComplete):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::stopRecordingResponses):
(WebCore::DocumentLoader::title):
(WebCore::DocumentLoader::triggeringAction):
(WebCore::DocumentLoader::setTriggeringAction):
(WebCore::DocumentLoader::setOverrideEncoding):
(WebCore::DocumentLoader::overrideEncoding):
(WebCore::DocumentLoader::setTitle):
(WebCore::DocumentLoader::URLForHistory):
* loader/qt/FrameLoaderClientQt.cpp: Added.
(WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
(WebCore::FrameLoaderClientQt::~FrameLoaderClientQt):
(WebCore::FrameLoaderClientQt::detachFrameLoader):
(WebCore::FrameLoaderClientQt::hasWebView):
(WebCore::FrameLoaderClientQt::hasFrameView):
(WebCore::FrameLoaderClientQt::hasBackForwardList):
(WebCore::FrameLoaderClientQt::resetBackForwardList):
(WebCore::FrameLoaderClientQt::provisionalItemIsTarget):
(WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache):
(WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache):
(WebCore::FrameLoaderClientQt::privateBrowsingEnabled):
(WebCore::FrameLoaderClientQt::makeDocumentView):
(WebCore::FrameLoaderClientQt::makeRepresentation):
(WebCore::FrameLoaderClientQt::forceLayout):
(WebCore::FrameLoaderClientQt::forceLayoutForNonHTML):
(WebCore::FrameLoaderClientQt::updateHistoryForCommit):
(WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation):
(WebCore::FrameLoaderClientQt::updateHistoryForReload):
(WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad):
(WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad):
(WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect):
(WebCore::FrameLoaderClientQt::setCopiesOnScroll):
(WebCore::FrameLoaderClientQt::tokenForLoadErrorReset):
(WebCore::FrameLoaderClientQt::resetAfterLoadError):
(WebCore::FrameLoaderClientQt::doNotResetAfterLoadError):
(WebCore::FrameLoaderClientQt::willCloseDocument):
(WebCore::FrameLoaderClientQt::detachedFromParent1):
(WebCore::FrameLoaderClientQt::detachedFromParent2):
(WebCore::FrameLoaderClientQt::detachedFromParent3):
(WebCore::FrameLoaderClientQt::detachedFromParent4):
(WebCore::FrameLoaderClientQt::loadedFromPageCache):
(WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect):
(WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
(WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
(WebCore::FrameLoaderClientQt::dispatchWillClose):
(WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
(WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
(WebCore::FrameLoaderClientQt::dispatchShow):
(WebCore::FrameLoaderClientQt::cancelPolicyCheck):
(WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource):
(WebCore::FrameLoaderClientQt::clearLoadingFromPageCache):
(WebCore::FrameLoaderClientQt::isLoadingFromPageCache):
(WebCore::FrameLoaderClientQt::revertToProvisionalState):
(WebCore::FrameLoaderClientQt::clearUnarchivingState):
(WebCore::FrameLoaderClientQt::progressStarted):
(WebCore::FrameLoaderClientQt::progressCompleted):
(WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
(WebCore::FrameLoaderClientQt::willChangeTitle):
(WebCore::FrameLoaderClientQt::didChangeTitle):
(WebCore::FrameLoaderClientQt::finishedLoading):
(WebCore::FrameLoaderClientQt::finalSetupForReplace):
(WebCore::FrameLoaderClientQt::setDefersLoading):
(WebCore::FrameLoaderClientQt::isArchiveLoadPending):
(WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad):
(WebCore::FrameLoaderClientQt::clearArchivedResources):
(WebCore::FrameLoaderClientQt::canShowMIMEType):
(WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
(WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
(WebCore::FrameLoaderClientQt::frameLoadCompleted):
(WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState):
(WebCore::FrameLoaderClientQt::provisionalLoadStarted):
(WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent):
(WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll):
(WebCore::FrameLoaderClientQt::didFinishLoad):
(WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement):
(WebCore::FrameLoaderClientQt::setTitle):
(WebCore::FrameLoaderClientQt::userAgent):
* loader/qt/FrameLoaderClientQt.h: Added.
* loader/qt/FrameLoaderQt.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::overrideMediaType):
(WebCore::FrameLoader::getHistoryLength):
(WebCore::FrameLoader::referrer):
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::goBackOrForward):
(WebCore::FrameLoader::historyURL):
(WebCore::FrameLoader::didFirstLayout):
(WebCore::FrameLoader::canGoBackOrForward):
(WebCore::FrameLoader::partClearedInBegin):
(WebCore::FrameLoader::saveDocumentState):
(WebCore::FrameLoader::restoreDocumentState):
(WebCore::FrameLoader::didChangeTitle):
(WebCore::FrameLoader::redirectDataToPlugin):
(WebCore::PolicyCheck::PolicyCheck):
(WebCore::PolicyCheck::clear):
(WebCore::PolicyCheck::set):
(WebCore::PolicyCheck::call):
(WebCore::PolicyCheck::clearRequest):
* loader/qt/NavigationActionQt.cpp: Added.
(WebCore::navigationType):
(WebCore::NavigationAction::NavigationAction):
* loader/qt/ResourceLoaderQt.cpp: Added.
(WebCore::ResourceLoader::ResourceLoader):
(WebCore::ResourceLoader::~ResourceLoader):
(WebCore::ResourceLoader::setDefersLoading):
(WebCore::ResourceLoader::cancel):
(WebCore::ResourceLoader::loadsBlocked):
* platform/MimeTypeRegistry.cpp:
(WebCore::initialiseSupportedImageMIMETypes):
* platform/network/qt/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::slotResult):
(WebCore::ResourceHandleManager::cancel):
* platform/qt/ChromeClientQt.cpp: Added.
(WebCore::rootWindowForFrame):
(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):
(WebCore::ChromeClientQt::setWindowRect):
(WebCore::ChromeClientQt::windowRect):
(WebCore::ChromeClientQt::pageRect):
(WebCore::ChromeClientQt::scaleFactor):
(WebCore::ChromeClientQt::focus):
(WebCore::ChromeClientQt::unfocus):
(WebCore::ChromeClientQt::createWindow):
(WebCore::ChromeClientQt::createModalDialog):
(WebCore::ChromeClientQt::show):
(WebCore::ChromeClientQt::canRunModal):
(WebCore::ChromeClientQt::runModal):
(WebCore::ChromeClientQt::setToolbarsVisible):
(WebCore::ChromeClientQt::toolbarsVisible):
(WebCore::ChromeClientQt::setStatusbarVisible):
(WebCore::ChromeClientQt::statusbarVisible):
(WebCore::ChromeClientQt::setScrollbarsVisible):
(WebCore::ChromeClientQt::scrollbarsVisible):
(WebCore::ChromeClientQt::setMenubarVisible):
(WebCore::ChromeClientQt::menubarVisible):
(WebCore::ChromeClientQt::setResizable):
* platform/qt/ChromeClientQt.h: Added.
* platform/qt/EditorClientQt.cpp:
(WebCore::EditorClientQt::shouldBeginEditing):
(WebCore::EditorClientQt::shouldEndEditing):
(WebCore::EditorClientQt::shouldApplyStyle):
(WebCore::EditorClientQt::didBeginEditing):
(WebCore::EditorClientQt::respondToChangedContents):
(WebCore::EditorClientQt::didEndEditing):
* platform/qt/EditorClientQt.h:
* platform/qt/FrameQt.cpp:
(WebCore::FrameQt::FrameQt):
(WebCore::FrameQt::~FrameQt):
(WebCore::FrameQt::keyEvent):
* platform/qt/FrameQt.h:
* platform/qt/FrameQtClient.cpp:
(WebCore::FrameQtClientDefault::openURL):
(WebCore::FrameQtClientDefault::didReceiveData):
(WebCore::FrameQtClientDefault::receivedAllData):
* platform/qt/ImageQt.cpp:
* platform/qt/MimeTypeRegistryQt.cpp: Added.
(WebCore::getMIMETypeForUTI):
(WebCore::MimeTypeRegistry::getMIMETypeForExtension):
* platform/qt/PageQt.cpp:
* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::keyIdentifierForQtKeyCode):
* platform/qt/ScreenQt.cpp:
* platform/qt/TemporaryLinkStubs.cpp:
(WebCore::TextField::TextField):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
WebKitQt:
Reviewed and landed by Anders.
Adjusting to the recent loader changes, making it compile
and work.
* QtLauncher/main.cpp:
(main):
* WebKitPart/WebKitPart.cpp:
(WebKitPart::closeUrl):
(WebKitPart::initView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 10 Nov 2006 08:42:20 +0000 (08:42 +0000)]
Reviewed by Mitz
http://bugs.webkit.org/show_bug.cgi?id=11554
Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
in case the icon load fails after some data has been received.
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB
on error. Also, as a loader re-factoring sanity check, added an assertion
(WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon
is already committed to the DB. Skip doing that step twice.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Fri, 10 Nov 2006 07:31:04 +0000 (07:31 +0000)]
2006-11-09 Oliver Hunt <oliver@apple.com>
Reviewed by Brady.
Pulled MIME type handling out of WebFrameBridge and added
a general C++ class to store/query MIME info
Added an Obj-C bridge to provide WebKit with access to the
MimeTypeRegistry for non-Obj-C++ classes.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
* bridge/mac/WebMimeTypeRegistryBridge.h: Added.
* bridge/mac/WebMimeTypeRegistryBridge.mm: Added.
(+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]):
(+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]):
(+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]):
(+[WebMimeTypeRegistryBridge supportedImageMIMETypes]):
(+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
* platform/Image.cpp:
(WebCore::Image::supportsType):
* platform/Image.h:
* platform/MimeTypeRegistry.cpp: Added.
(WebCore::initialiseSupportedImageMIMETypes):
(WebCore::initialiseSupportedNonImageMimeTypes):
(WebCore::initialiseMimeTypeRegistry):
(WebCore::MimeTypeRegistry::isSupportedImageMIMEType):
(WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType):
(WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType):
(WebCore::MimeTypeRegistry::getSupportedImageMIMETypes):
(WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes):
(WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
* platform/MimeTypeRegistry.h: Added.
* platform/mac/ImageMac.mm:
* platform/mac/MimeTypeRegistryMac.mm: Added.
(WebCore::getMIMETypeForUTI):
(WebCore::MimeTypeRegistry::getMIMETypeForExtension):
Updated to make use of MimeTypeRegistry/bridge
* Misc/WebNSPasteboardExtras.m:
(-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge determineObjectFromMIMEType:URL:]):
* WebView/WebDataSource.mm:
(-[WebDataSource _documentFragmentWithArchive:]):
* WebView/WebHTMLRepresentation.m:
(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
* WebView/WebHTMLView.m:
(-[WebHTMLView _imageExistsAtPaths:]):
(-[WebHTMLView _documentFragmentWithPaths:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 10 Nov 2006 05:17:06 +0000 (05:17 +0000)]
Reviewed by Oliver.
- rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search
for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size
for you and use vsnprintf.
* bindings/js/kjs_window.cpp:
(KJS::Window::isSafeScript):
* css/cssparser.cpp:
(WebCore::CSSParser::parseColorFromValue):
* dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSColor):
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::handleError):
* ksvg2/css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGPaint):
(WebCore::CSSParser::parseSVGColor):
* ksvg2/svg/SVGPathSegArc.h:
(WebCore::SVGPathSegArcAbs::toString):
(WebCore::SVGPathSegArcRel::toString):
* ksvg2/svg/SVGPathSegCurvetoCubic.h:
(WebCore::SVGPathSegCurvetoCubicAbs::toString):
(WebCore::SVGPathSegCurvetoCubicRel::toString):
* ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
* ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
(WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
(WebCore::SVGPathSegCurvetoQuadraticRel::toString):
* ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
* ksvg2/svg/SVGPathSegLineto.h:
(WebCore::SVGPathSegLinetoAbs::toString):
(WebCore::SVGPathSegLinetoRel::toString):
* ksvg2/svg/SVGPathSegLinetoHorizontal.h:
(WebCore::SVGPathSegLinetoHorizontalAbs::toString):
(WebCore::SVGPathSegLinetoHorizontalRel::toString):
* ksvg2/svg/SVGPathSegLinetoVertical.h:
(WebCore::SVGPathSegLinetoVerticalAbs::toString):
(WebCore::SVGPathSegLinetoVerticalRel::toString):
* ksvg2/svg/SVGPathSegMoveto.h:
(WebCore::SVGPathSegMovetoAbs::toString):
(WebCore::SVGPathSegMovetoRel::toString):
* ksvg2/svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::notifyAttributeChange):
* ksvg2/svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::closeRenderer):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
* loader/icon/SQLDatabase.cpp:
(WebCore::SQLDatabase::setSynchronous):
* platform/Color.cpp:
(WebCore::Color::name):
* platform/DeprecatedString.cpp:
(WebCore::DeprecatedString::setNum):
(WebCore::DeprecatedString::format):
* platform/DeprecatedString.h:
* platform/PlatformString.h:
* platform/String.cpp:
(WebCore::String::format):
(WebCore::String::number):
* platform/mac/KeyEventMac.mm:
(WebCore::keyIdentifierForKeyEvent):
* platform/win/KeyEventWin.cpp:
(WebCore::keyIdentifierForWindowsKeyCode):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::calcMinMaxWidth):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 10 Nov 2006 00:30:21 +0000 (00:30 +0000)]
Reviewed by Anders.
- fixed "Regression: Can't log into gmail.com"
- fixed "iBench doesn't report results - tests run but no number is recorded"
* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::setHTTPBody): Removed extra ! character.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Thu, 9 Nov 2006 23:21:06 +0000 (23:21 +0000)]
Reviewed by Darin
<rdar://problem/
4829080>
More loader re-factoring cleanup - WebFramePolicyListener was over-released
* WebCoreSupport/WebFrameLoaderClient.h: Changed vanilla ptr to a RetainPtr<>
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto
(WebFrameLoaderClient::dispatchWillSubmitForm): Ditto
(WebFrameLoaderClient::setUpPolicyListener): Ditto
(-[WebFramePolicyListener receivedPolicyDecision:]): Ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Thu, 9 Nov 2006 22:58:29 +0000 (22:58 +0000)]
Reviewed by Hyatt.
Fix for <rdar://problem/
4805409> REGRESSION: Reproducible crash in
WebCore::RenderBlock::skipWhitespace
Note that this will still crash on Debug builds because it will hit
an assertion failure in editing. (One of the reasons there is no
layout test along with this fix.) There is definitely some editing
wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
id=10144 for updates on the assertion failure bug.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::childRemoved): It is possible for a
prevRootBox and its prevRootBox to share a lineBreakObj. So instead
of just clearing the lineBreakObj of the prevRootBox, cycle through
all prevRootBoxs with the same lineBreakObj.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 9 Nov 2006 21:48:19 +0000 (21:48 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 9 Nov 2006 20:51:39 +0000 (20:51 +0000)]
LayoutTests:
Reviewed by Geoff.
New test to keep the mistake I made in r17680 from happening again.
* fast/block/margin-collapse/negative-margins-expected.checksum: Added.
* fast/block/margin-collapse/negative-margins-expected.png: Added.
* fast/block/margin-collapse/negative-margins-expected.txt: Added.
* fast/block/margin-collapse/negative-margins.html: Added.
WebCore:
Reviewed by Geoff.
Fix the change in behavior I caused in r17680 with my build fix.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::maxTopMargin):
(WebCore::RenderObject::maxBottomMargin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 9 Nov 2006 19:48:13 +0000 (19:48 +0000)]
WebCore:
Reviewed by Adam, Oliver.
Move more functions to Editor.
* bridge/EditorClient.h:
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
* bridge/mac/WebCoreFrameBridge.h:
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply):
(WebCore::EditCommand::unapply):
(WebCore::EditCommand::reapply):
* editing/Editor.cpp:
(WebCore::Editor::respondToChangedContents):
(WebCore::dispatchEditableContentChangedEvents):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
* editing/Editor.h:
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::typingAddedToOpenCommand):
* page/Frame.cpp:
* page/Frame.h:
WebKit:
Reviewed by Adam, Oliver.
Update for changes to WebCore. Pass a specific WebFrame to WebEditorClient
instead of just passing the WebView.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::WebEditorClient):
(WebEditorClient::setWebFrame):
(WebEditorClient::isContinuousSpellCheckingEnabled):
(WebEditorClient::spellCheckerDocumentTag):
(WebEditorClient::shouldDeleteRange):
(WebEditorClient::shouldShowDeleteInterface):
(WebEditorClient::shouldApplyStyle):
(WebEditorClient::shouldBeginEditing):
(WebEditorClient::shouldEndEditing):
(WebEditorClient::didBeginEditing):
(WebEditorClient::respondToChangedContents):
(WebEditorClient::didEndEditing):
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
(-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Nov 2006 16:31:08 +0000 (16:31 +0000)]
* rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Thu, 9 Nov 2006 16:17:18 +0000 (16:17 +0000)]
Reviewed by Beth Dakin.
Fixed <rdar://problem/
4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
All existing layout tests pass
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::deleteRow):
check lastSection before deleting row
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Nov 2006 15:41:25 +0000 (15:41 +0000)]
- improved version of last night's build fix (should not do using namespace in a header)
* rendering/RenderObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::maxTopMargin):
(WebCore::RenderObject::maxBottomMargin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 9 Nov 2006 06:49:17 +0000 (06:49 +0000)]
Reviewed by Geoff.
- added ResourceError class and didFailWithError client method
* WebCore.xcodeproj/project.pbxproj:
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::didFailWithError):
(WebCore::IconLoader::didFinishLoading):
* loader/icon/IconLoader.h:
* loader/loader.cpp:
(WebCore::Loader::receivedAllData):
(WebCore::Loader::didFailWithError):
* loader/loader.h:
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::didCancel):
* platform/cf/RetainPtr.h:
(WebCore::):
(WebCore::adoptCFReference):
(WebCore::RetainPtr::RetainPtr):
(WebCore::::adopt):
* platform/network/ResourceError.cpp: Added.
* platform/network/ResourceError.h: Added.
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::domain):
(WebCore::ResourceError::errorCode):
(WebCore::ResourceError::failingURL):
(WebCore::ResourceError::localizedDescription):
(WebCore::ResourceError::unpackPlatformErrorIfNeeded):
* platform/network/ResourceHandle.cpp:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didFailWithError):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::didFail):
(WebCore::ResourceHandle::cancel):
* platform/network/mac/ResourceErrorMac.mm: Added.
(-[NSError WebCore]):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::reportError):
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::didFailWithError):
(WebCore::XMLHttpRequest::didFinishLoading):
* xml/xmlhttprequest.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 9 Nov 2006 06:39:26 +0000 (06:39 +0000)]
2006-11-08 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Maciej.
Linux\Gdk fixes.
* platform/gdk/ChromeClientGdk.h:
(WebCore::ChromeClientGdk::~ChromeClientGdk):
* platform/gdk/CursorGdk.cpp:
(WebCore::Cursor::Cursor):
(WebCore::moveCursor):
* platform/gdk/FrameGdk.cpp:
(WebCore::FrameGdk::FrameGdk):
(WebCore::FrameGdk::submitForm):
(WebCore::FrameGdk::urlSelected):
* platform/gdk/PageGdk.cpp:
* platform/gdk/ScreenClientGdk.h: Added.
(WebCore::ScreenClientGdk::~ScreenClientGdk):
* platform/gdk/ScreenGdk.cpp:
(WebCore::ScreenClientGdk::depth):
(WebCore::ScreenClientGdk::depthPerComponent):
(WebCore::ScreenClientGdk::isMonochrome):
(WebCore::ScreenClientGdk::rect):
(WebCore::ScreenClientGdk::usableRect):
* platform/gdk/TemporaryLinkStubs.cpp:
(FrameGdk::historyURL):
(ChromeClientGdk::windowRect):
(ChromeClientGdk::setWindowRect):
(ChromeClientGdk::pageRect):
(ChromeClientGdk::scaleFactor):
(ChromeClientGdk::focus):
(ChromeClientGdk::unfocus):
(ChromeClientGdk::createWindow):
(ChromeClientGdk::createModalDialog):
(ChromeClientGdk::show):
(ChromeClientGdk::canRunModal):
(ChromeClientGdk::runModal):
(ChromeClientGdk::setToolbarsVisible):
(ChromeClientGdk::toolbarsVisible):
(ChromeClientGdk::setStatusbarVisible):
(ChromeClientGdk::statusbarVisible):
(ChromeClientGdk::setScrollbarsVisible):
(ChromeClientGdk::scrollbarsVisible):
(ChromeClientGdk::setMenubarVisible):
(ChromeClientGdk::menubarVisible):
(ChromeClientGdk::setResizable):
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::client):
* platform/network/gdk/ResourceHandleManager.cpp:
(WebCore::writeCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::remove):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 9 Nov 2006 05:58:27 +0000 (05:58 +0000)]
Build fix.
* rendering/RenderObject.h:
(WebCore::RenderObject::maxTopMargin):
(WebCore::RenderObject::maxBottomMargin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 9 Nov 2006 05:18:01 +0000 (05:18 +0000)]
Reviewed by Anders Carlsson.
Made Screen a good platform citizen by removing its reference to Page. This
made a class unnecessary, so all screen fuctions are stand-alone now.
* bindings/js/kjs_window.cpp: Removed unnecessary subtractions
when computing the screen's available dimensions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 9 Nov 2006 03:55:58 +0000 (03:55 +0000)]
Reviewed by Mitz.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
Cleanup RenderObject
* rendering/RenderObject.cpp:
(WebCore::RenderObject::operator delete):
(WebCore::RenderObject::createObject):
(WebCore::RenderObjectCounter::~RenderObjectCounter):
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::isDescendantOf):
(WebCore::RenderObject::isRoot):
(WebCore::RenderObject::addChild):
(WebCore::RenderObject::removeChildNode):
(WebCore::RenderObject::removeChild):
(WebCore::RenderObject::appendChildNode):
(WebCore::RenderObject::insertChildNode):
(WebCore::RenderObject::nextInPreOrder):
(WebCore::RenderObject::nextInPreOrderAfterChildren):
(WebCore::RenderObject::previousInPreOrder):
(WebCore::RenderObject::isEditable):
(WebCore::RenderObject::nextEditable):
(WebCore::RenderObject::previousEditable):
(WebCore::RenderObject::firstLeafChild):
(WebCore::RenderObject::lastLeafChild):
(WebCore::RenderObject::addLayers):
(WebCore::RenderObject::removeLayers):
(WebCore::RenderObject::moveLayers):
(WebCore::RenderObject::findNextLayer):
(WebCore::RenderObject::enclosingLayer):
(WebCore::RenderObject::updateFirstLetter):
(WebCore::RenderObject::offsetParent):
(WebCore::RenderObject::scroll):
(WebCore::RenderObject::hasStaticX):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::containingBlockWidth):
(WebCore::RenderObject::containingBlockHeight):
(WebCore::RenderObject::mustRepaintBackgroundOrBorder):
(WebCore::RenderObject::drawBorderArc):
(WebCore::RenderObject::drawBorder):
(WebCore::RenderObject::paintBorderImage):
(WebCore::RenderObject::paintBorder):
(WebCore::RenderObject::absoluteRects):
(WebCore::RenderObject::addPDFURLRect):
(WebCore::RenderObject::addFocusRingRects):
(WebCore::RenderObject::paintOutline):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::repaintObjectsBeforeLayout):
(WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
(WebCore::RenderObject::information):
(WebCore::RenderObject::dump):
(WebCore::selectStartNode):
(WebCore::RenderObject::shouldSelect):
(WebCore::RenderObject::draggableNode):
(WebCore::RenderObject::createAnonymousBlock):
(WebCore::RenderObject::handleDynamicFloatPositionChange):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::setStyleInternal):
(WebCore::RenderObject::updateBackgroundImages):
(WebCore::RenderObject::absolutePosition):
(WebCore::RenderObject::caretRect):
(WebCore::RenderObject::paddingTop):
(WebCore::RenderObject::paddingBottom):
(WebCore::RenderObject::paddingLeft):
(WebCore::RenderObject::paddingRight):
(WebCore::RenderObject::tabWidth):
(WebCore::RenderObject::container):
(WebCore::RenderObject::removeFromObjectLists):
(WebCore::RenderObject::destroy):
(WebCore::RenderObject::arenaDelete):
(WebCore::RenderObject::hitTest):
(WebCore::RenderObject::setInnerNode):
(WebCore::RenderObject::nodeAtPoint):
(WebCore::RenderObject::verticalPositionHint):
(WebCore::RenderObject::getVerticalPosition):
(WebCore::RenderObject::lineHeight):
(WebCore::RenderObject::invalidateVerticalPositions):
(WebCore::RenderObject::recalcMinMaxWidths):
(WebCore::RenderObject::scheduleRelayout):
(WebCore::RenderObject::setInlineBoxWrapper):
(WebCore::RenderObject::firstLineStyle):
(WebCore::RenderObject::getPseudoStyle):
(WebCore::RenderObject::getTextDecorationColors):
(WebCore::RenderObject::addDashboardRegions):
(WebCore::RenderObject::collectDashboardRegions):
(WebCore::RenderObject::avoidsFloats):
(WebCore::RenderObject::findCounter):
(WebCore::RenderObject::backslashAsCurrencySymbol):
(WebCore::RenderObject::imageChanged):
(WebCore::RenderObject::previousOffset):
(WebCore::RenderObject::nextOffset):
(WebCore::RenderObject::inlineBox):
* rendering/RenderObject.h:
(WebCore::):
(WebCore::RenderObject::renderName):
(WebCore::RenderObject::parent):
(WebCore::RenderObject::previousSibling):
(WebCore::RenderObject::nextSibling):
(WebCore::RenderObject::firstChild):
(WebCore::RenderObject::lastChild):
(WebCore::RenderObject::getOverflowClipRect):
(WebCore::RenderObject::getClipRect):
(WebCore::RenderObject::getBaselineOfFirstLineBox):
(WebCore::RenderObject::setEdited):
(WebCore::RenderObject::setStaticX):
(WebCore::RenderObject::setStaticY):
(WebCore::RenderObject::setPreviousSibling):
(WebCore::RenderObject::setNextSibling):
(WebCore::RenderObject::setParent):
(WebCore::RenderObject::isInlineBlockOrInlineTable):
(WebCore::RenderObject::isRenderView):
(WebCore::RenderObject::childrenInline):
(WebCore::RenderObject::setChildrenInline):
(WebCore::RenderObject::isAnonymousBlock):
(WebCore::RenderObject::isDragging):
(WebCore::RenderObject::needsLayout):
(WebCore::RenderObject::setMinMaxKnown):
(WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc):
(WebCore::RenderObject::setPositioned):
(WebCore::RenderObject::setRelPositioned):
(WebCore::RenderObject::setFloating):
(WebCore::RenderObject::setInline):
(WebCore::RenderObject::setShouldPaintBackgroundOrBorder):
(WebCore::RenderObject::setReplaced):
(WebCore::RenderObject::PaintInfo::PaintInfo):
(WebCore::RenderObject::paintBackgroundExtended):
(WebCore::RenderObject::calcWidth):
(WebCore::RenderObject::updateFromElement):
(WebCore::RenderObject::RepaintInfo::RepaintInfo):
(WebCore::RenderObject::setOverrideSize):
(WebCore::RenderObject::setPos):
(WebCore::RenderObject::setWidth):
(WebCore::RenderObject::setHeight):
(WebCore::RenderObject::absolutePositionForContent):
(WebCore::RenderObject::overflowHeight):
(WebCore::RenderObject::overflowWidth):
(WebCore::RenderObject::setOverflowHeight):
(WebCore::RenderObject::setOverflowWidth):
(WebCore::RenderObject::overflowLeft):
(WebCore::RenderObject::overflowTop):
(WebCore::RenderObject::overflowRect):
(WebCore::RenderObject::stopAutoscroll):
(WebCore::RenderObject::collapsedMarginTop):
(WebCore::RenderObject::collapsedMarginBottom):
(WebCore::RenderObject::maxTopMargin):
(WebCore::RenderObject::maxBottomMargin):
(WebCore::RenderObject::):
(WebCore::RenderObject::setTable):
(WebCore::RenderObject::isFloatingOrPositioned):
(WebCore::RenderObject::containsFloat):
(WebCore::RenderObject::setSelectionState):
(WebCore::RenderObject::SelectionInfo::SelectionInfo):
(WebCore::RenderObject::lowestPosition):
(WebCore::RenderObject::rightmostPosition):
(WebCore::RenderObject::leftmostPosition):
(WebCore::RenderObject::calcVerticalMargins):
(WebCore::RenderObject::font):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Nov 2006 02:00:10 +0000 (02:00 +0000)]
LayoutTests:
Reviewed by Anders.
- added test for option-tab
* fast/events/option-tab.html: Added.
* fast/events/option-tab-expected.txt: Added.
WebCore:
Reviewed by Anders.
- added event parameters to focus-related functions so we can
implement the "option-tab to all links" behavior without relying
on a global "current event" -- also makes it work with DOM events
* page/Frame.h: Removed unneeded includes. Moved some functions
that were misplaced into the appropriate sections.
* page/Frame.cpp:
(WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
PlatformKeyboardEvent to the DOM keyboard event class.
(WebCore::Frame::tabsToLinks): Added event parameter.
(WebCore::Frame::tabsToAllControls): Ditto.
(WebCore::scanForForm): Fixed code that incorrectly assumes
that an iframe is an HTMLFrameElement (no longer true since Geoff
changed the class hierarchy a bit).
(WebCore::Frame::hitTestResultAtPoint): Ditto.
* bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
that were misplaced into the appropriate sections.
* bridge/mac/FrameMac.mm:
(WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
a PlatformKeyboardEvent.
(WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
and pass event into next/previousFocusNode.
(WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
the AppKit current event, if it's a keyboard event. Really just a hack that's
needed to preserve some code we can remove once we deal with the last NSView-
based form control.
(WebCore::isKeyboardOptionTab): Added.
(WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
option (alt) key is down.
(WebCore::FrameMac::tabsToAllControls): Ditto.
(WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
call resetMultipleFormSubmissionProtection() explicitly instead.
(WebCore::FrameMac::mouseDown): Ditto.
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
changed the class hierarchy a bit).
(-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
prepareForUserAction() to call resetMultipleFormSubmissionProtection()
explicitly instead.
* page/FrameView.h:
* page/FrameView.cpp:
(WebCore::FrameView::advanceFocus): Changed function to take an
event parameter, and decide the direction based on the shift key
modifier instead of a passed-in boolean.
* dom/Document.h:
* dom/Document.cpp:
(WebCore::Document::nextFocusNode): Added event parameter.
(WebCore::Document::previousFocusNode): Ditto.
* dom/Node.h:
* dom/Node.cpp:
(WebCore::Node::isKeyboardFocusable): Ditto.
* html/HTMLAnchorElement.h:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
* html/HTMLGenericFormElement.h:
* html/HTMLGenericFormElement.cpp:
(WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
* html/HTMLInputElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
(WebCore::HTMLInputElement::defaultEventHandler): Ditto.
* html/HTMLSelectElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
* html/HTMLTextAreaElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::defaultEventHandler): Pass event to the
advanceFocus function.
* platform/TextField.h:
* platform/mac/TextFieldMac.mm: Removed the non-search field code.
* platform/mac/WebCoreTextField.h:
* platform/mac/WebCoreTextField.mm: Removed the non-search field code.
(-[WebCoreTextFieldController controlTextDidChange:]): Removed the
call to FrameMac::handleKeyboardOptionTabInView, which is no longer
needed since the default handler in HTMLInputElement takes care of
option-tab.
* platform/mac/SliderMac.mm:
(-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
and pass event into tabsToAllControls.
(Slider::focusPolicy): Ditto.
* rendering/RenderLineEdit.cpp:
(WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
(WebCore::RenderLineEdit::updateFromElement): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Nov 2006 01:33:55 +0000 (01:33 +0000)]
Reviewed by Anders.
- same change as below, only tested this time
* DumpRenderTree/DumpRenderTree.m: (main): Explicitly turn "tab to links"
mode off. I think we need to do this because WebPreferences saves things
for us automatically. It would be good to turn that off for DumpRenderTree,
but for now lets handle this like the other preferences (set it explicitly
each time).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Nov 2006 01:21:14 +0000 (01:21 +0000)]
Reviewed by Anders.
* DumpRenderTree/DumpRenderTree.m: (main): Get rid of code to turn on
"tab to links" mode. No current tests depend on this, and there's a new
test I want to land that depends on the default setting.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Thu, 9 Nov 2006 01:16:10 +0000 (01:16 +0000)]
Reviewed by Dave Harrison, Oliver, and Darin
(oh my! where was superkevin on this one?)
<rdar://problem/
4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)
More "free nil checking" we lost in the transition from ObjC to C++
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 9 Nov 2006 00:51:35 +0000 (00:51 +0000)]
WebCore:
Reviewed by Adam.
Move more code into editor.
* WebCore.exp:
* bridge/EditorClient.h:
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
* bridge/mac/WebCoreFrameBridge.h:
* dom/Document.cpp:
(WebCore::Document::relinquishesEditingFocus):
(WebCore::Document::acceptsEditingFocus):
(WebCore::Document::didBeginEditing):
(WebCore::Document::didEndEditing):
* editing/Editor.cpp:
(WebCore::Editor::indent):
(WebCore::Editor::outdent):
* editing/Editor.h:
* page/Frame.cpp:
* page/Frame.h:
WebKit:
Reviewed by Adam.
Move more code into editor.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldBeginEditing):
(WebEditorClient::shouldEndEditing):
(WebEditorClient::didBeginEditing):
(WebEditorClient::didEndEditing):
* WebCoreSupport/WebFrameBridge.mm:
* WebView/WebHTMLView.m:
(-[NSArray indent:]):
(-[NSArray outdent:]):
* WebView/WebView.mm:
* WebView/WebViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 8 Nov 2006 22:58:31 +0000 (22:58 +0000)]
WebCore:
Reviewed by Adam.
Add ability to HitTestResult to ask if the inner non-shared node is
content editable.
* WebCore.exp: Export HitTestResult::isContentEditable()
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isContentEditable):
* rendering/HitTestResult.h:
WebKit:
Reviewed by Adam.
Add WebElementIsContentEditableKey to the WebElementDictionary, and
use it!
* DefaultDelegates/WebDefaultContextMenuDelegate.m:
(-[WebDefaultUIDelegate
webView:contextMenuItemsForElement:defaultMenuItems:]): Use new
WebElementIsContentEditableKey.
* Misc/WebElementDictionary.m:
(+[WebElementDictionary initializeLookupTable]):
(-[WebElementDictionary _isContentEditable]): Call into
HitTestResult::isContentEditable()
* WebView/WebView.mm: Add new key.
* WebView/WebViewPrivate.h: Add new key.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 8 Nov 2006 22:50:00 +0000 (22:50 +0000)]
Build fix.
* WebCore.xcodeproj/project.pbxproj:
Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 8 Nov 2006 22:24:26 +0000 (22:24 +0000)]
Reviewed by Darin.
<rdar://problem/
4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
<rdar://problem/
4804317> Would like SPI to get bounding box for a DOM range without having to change the selection
Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.
* bindings/objc/DOM.mm:
(WebCore::kit):
(-[DOMNode lineBoxRects]):
(-[DOMRange boundingBox]):
(-[DOMRange lineBoxRects]):
* bindings/objc/DOMPrivate.h:
* dom/Range.cpp:
(WebCore::Range::boundingBox):
(WebCore::Range::addLineBoxRects):
* dom/Range.h:
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::addLineBoxRects):
* rendering/RenderContainer.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addLineBoxRects):
* rendering/RenderObject.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::addLineBoxRects):
* rendering/RenderText.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log