darin@chromium.org [Wed, 15 Oct 2008 05:22:03 +0000 (05:22 +0000)]
2008-10-09 Darin Fisher <darin@chromium.org>
Reviewed by Sam Weinig.
Make pan scrolling a platform configurable option
https://bugs.webkit.org/show_bug.cgi?id=21515
* page/EventHandler.cpp:
(WebCore::EventHandler::handleAutoscroll):
(WebCore::EventHandler::autoscrollTimerFired):
(WebCore::EventHandler::stopAutoscrollTimer):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::keyEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Wed, 15 Oct 2008 05:21:30 +0000 (05:21 +0000)]
2008-10-09 Darin Fisher <darin@chromium.org>
Reviewed by Sam Weinig.
Make pan scrolling a platform configurable option.
https://bugs.webkit.org/show_bug.cgi?id=21515
* wtf/Platform.h: Add ENABLE_PAN_SCROLLING
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Wed, 15 Oct 2008 05:15:47 +0000 (05:15 +0000)]
2008-10-10 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
Add some PLATFORM(CHROMIUM) ifdefs to WebCore
https://bugs.webkit.org/show_bug.cgi?id=21511
* loader/FTPDirectoryDocument.cpp:
* loader/FTPDirectoryParser.cpp:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedLoadingDocument):
* platform/ContextMenuItem.h:
* platform/Cursor.h:
* platform/DragData.h:
* platform/DragImage.h:
* platform/Pasteboard.h:
* platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::isSystemKey):
* platform/PlatformMenuDescription.h:
* platform/PlatformMouseEvent.h:
* platform/PlatformWheelEvent.h:
* platform/PopupMenu.h:
* platform/ScrollView.h:
* platform/Widget.h:
* platform/network/NetworkStateNotifier.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 15 Oct 2008 03:41:18 +0000 (03:41 +0000)]
Make the user agent generation method a class method and cache the WebKit
version in a static to prevent generating it every time. This is needed
clean up to fix <rdar://problem/
6292331>. Moved all code to WebPrivate so
the class method can be in the WebViewPrivate.h header.
Reviewed by John Sullivan.
* WebView/WebView.mm:
(callGestalt): Moved. Same code.
(createMacOSXVersionString): Moved. Same code.
(createUserVisibleWebKitVersionString): Moved from _userVisibleBundleVersionFromFullVersion:
and returns a copied string.
(+[WebView _standardUserAgentWithApplicationName:andWebKitVersion:]): Made into a class method.
(-[WebView WebCore::_userAgentForURL:]): Changed to cache the WebKit version.
* WebView/WebViewPrivate.h: Added +_standardUserAgentWithApplicationName:andWebKitVersion:.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Wed, 15 Oct 2008 02:39:52 +0000 (02:39 +0000)]
2008-10-14 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Sam Weinig.
- revert r37572 and r37581 for now
Turns out GCC 4.2 is still a (small) regression, we'll have to do
more work to turn it on.
* Configurations/DebugRelease.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:
* VM/CTI.cpp:
* VM/CTI.h:
* VM/Machine.cpp:
(JSC::Machine::cti_op_convert_this):
(JSC::Machine::cti_op_end):
(JSC::Machine::cti_op_add):
(JSC::Machine::cti_op_pre_inc):
(JSC::Machine::cti_timeout_check):
(JSC::Machine::cti_register_file_check):
(JSC::Machine::cti_op_loop_if_less):
(JSC::Machine::cti_op_loop_if_lesseq):
(JSC::Machine::cti_op_new_object):
(JSC::Machine::cti_op_put_by_id):
(JSC::Machine::cti_op_put_by_id_second):
(JSC::Machine::cti_op_put_by_id_generic):
(JSC::Machine::cti_op_put_by_id_fail):
(JSC::Machine::cti_op_get_by_id):
(JSC::Machine::cti_op_get_by_id_second):
(JSC::Machine::cti_op_get_by_id_generic):
(JSC::Machine::cti_op_get_by_id_fail):
(JSC::Machine::cti_op_instanceof):
(JSC::Machine::cti_op_del_by_id):
(JSC::Machine::cti_op_mul):
(JSC::Machine::cti_op_new_func):
(JSC::Machine::cti_op_call_JSFunction):
(JSC::Machine::cti_vm_compile):
(JSC::Machine::cti_op_push_activation):
(JSC::Machine::cti_op_call_NotJSFunction):
(JSC::Machine::cti_op_create_arguments):
(JSC::Machine::cti_op_tear_off_activation):
(JSC::Machine::cti_op_tear_off_arguments):
(JSC::Machine::cti_op_ret_profiler):
(JSC::Machine::cti_op_ret_scopeChain):
(JSC::Machine::cti_op_new_array):
(JSC::Machine::cti_op_resolve):
(JSC::Machine::cti_op_construct_JSConstruct):
(JSC::Machine::cti_op_construct_NotJSConstruct):
(JSC::Machine::cti_op_get_by_val):
(JSC::Machine::cti_op_resolve_func):
(JSC::Machine::cti_op_sub):
(JSC::Machine::cti_op_put_by_val):
(JSC::Machine::cti_op_put_by_val_array):
(JSC::Machine::cti_op_lesseq):
(JSC::Machine::cti_op_loop_if_true):
(JSC::Machine::cti_op_negate):
(JSC::Machine::cti_op_resolve_base):
(JSC::Machine::cti_op_resolve_skip):
(JSC::Machine::cti_op_resolve_global):
(JSC::Machine::cti_op_div):
(JSC::Machine::cti_op_pre_dec):
(JSC::Machine::cti_op_jless):
(JSC::Machine::cti_op_not):
(JSC::Machine::cti_op_jtrue):
(JSC::Machine::cti_op_post_inc):
(JSC::Machine::cti_op_eq):
(JSC::Machine::cti_op_lshift):
(JSC::Machine::cti_op_bitand):
(JSC::Machine::cti_op_rshift):
(JSC::Machine::cti_op_bitnot):
(JSC::Machine::cti_op_resolve_with_base):
(JSC::Machine::cti_op_new_func_exp):
(JSC::Machine::cti_op_mod):
(JSC::Machine::cti_op_less):
(JSC::Machine::cti_op_neq):
(JSC::Machine::cti_op_post_dec):
(JSC::Machine::cti_op_urshift):
(JSC::Machine::cti_op_bitxor):
(JSC::Machine::cti_op_new_regexp):
(JSC::Machine::cti_op_bitor):
(JSC::Machine::cti_op_call_eval):
(JSC::Machine::cti_op_throw):
(JSC::Machine::cti_op_get_pnames):
(JSC::Machine::cti_op_next_pname):
(JSC::Machine::cti_op_push_scope):
(JSC::Machine::cti_op_pop_scope):
(JSC::Machine::cti_op_typeof):
(JSC::Machine::cti_op_is_undefined):
(JSC::Machine::cti_op_is_boolean):
(JSC::Machine::cti_op_is_number):
(JSC::Machine::cti_op_is_string):
(JSC::Machine::cti_op_is_object):
(JSC::Machine::cti_op_is_function):
(JSC::Machine::cti_op_stricteq):
(JSC::Machine::cti_op_nstricteq):
(JSC::Machine::cti_op_to_jsnumber):
(JSC::Machine::cti_op_in):
(JSC::Machine::cti_op_push_new_scope):
(JSC::Machine::cti_op_jmp_scopes):
(JSC::Machine::cti_op_put_by_index):
(JSC::Machine::cti_op_switch_imm):
(JSC::Machine::cti_op_switch_char):
(JSC::Machine::cti_op_switch_string):
(JSC::Machine::cti_op_del_by_val):
(JSC::Machine::cti_op_put_getter):
(JSC::Machine::cti_op_put_setter):
(JSC::Machine::cti_op_new_error):
(JSC::Machine::cti_op_debug):
(JSC::Machine::cti_vm_throw):
* VM/Machine.h:
* masm/X86Assembler.h:
(JSC::X86Assembler::emitRestoreArgumentReference):
(JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 15 Oct 2008 00:23:35 +0000 (00:23 +0000)]
Build fix. Fix dependency chain in sln file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pam@chromium.org [Tue, 14 Oct 2008 22:43:04 +0000 (22:43 +0000)]
2008-10-14 Pamela Greene <pam@chromium.org>
Add test to verify popup properties while they're opening.
The expected result is currently not the desired result.
See https://bugs.webkit.org/show_bug.cgi?id=21419 and
https://bugs.webkit.org/show_bug.cgi?id=21597 .
Reviewed by Eric Seidel.
* fast/dom/Window/window-open-pending-url-expected.txt: Added.
* fast/dom/Window/window-open-pending-url.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Tue, 14 Oct 2008 22:16:30 +0000 (22:16 +0000)]
Fix windows build.
Reviewed by Sam Weinig.
* DumpRenderTree/cg/PixelDumpSupportCG.cpp:
* DumpRenderTree/config.h:
* DumpRenderTree/win/DumpRenderTreeWin.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/win/UIDelegate.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 14 Oct 2008 22:11:36 +0000 (22:11 +0000)]
Fix Bug 21602: Bugzilla times out trying to display formatted diff for attachment 24345
https://bugs.webkit.org/show_bug.cgi?id=21602
Reviewed by Dave Kilzer.
* PrettyPatch/PrettyPatch.rb:
(PrettyPatch.BINARY_FILE_MARKER_FORMAT): Added.
(PrettyPatch.FileDiff.initialize): If any of the lines in the diff
are a binary file marker, mark this FileDiff as binary and stop trying
to process the lines.
(PrettyDiff.FileDiff.to_html): If we're binary, just print a string
saying so.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Tue, 14 Oct 2008 21:31:40 +0000 (21:31 +0000)]
2008-10-14 Chris Marrin <cmarrin@apple.com>
Reviewed by Darin Adler.
Fixed https://bugs.webkit.org/show_bug.cgi?id=21490
Optimize keyframe style sheet changes by avoiding styleSheetChanged()
Test: css3/change-keyframes.html
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::append):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 14 Oct 2008 20:35:36 +0000 (20:35 +0000)]
WebCore:
2008-10-14 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21595
Clean up background and overflow propagation from the body to the viewport. Make it match the
latest CSS2.1 spec thinking.
Reviewed by Adam Roben
Added many tests at fast/body-propagation/. These are Simon Pieters' tests of propagation handling
(available at http://simon.html5.org/test/css/magic-body/).
* dom/Document.cpp:
(WebCore::Document::body):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::paintRootBoxDecorations):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::repaintLayerRectsForImage):
LayoutTests:
2008-10-14 David Hyatt <hyatt@apple.com>
Add layout tests for body propagation of overflow and background to the viewport.
Reviewed by Adam Roben
* fast/body-propagation: Added.
* fast/body-propagation/background-color: Added.
* fast/body-propagation/background-color/001-xhtml.xhtml: Added.
* fast/body-propagation/background-color/001.html: Added.
* fast/body-propagation/background-color/002-xhtml.xhtml: Added.
* fast/body-propagation/background-color/002.html: Added.
* fast/body-propagation/background-color/003-declarative.xhtml: Added.
* fast/body-propagation/background-color/003-xhtml.xhtml: Added.
* fast/body-propagation/background-color/003.html: Added.
* fast/body-propagation/background-color/004-declarative.xhtml: Added.
* fast/body-propagation/background-color/004-xhtml.xhtml: Added.
* fast/body-propagation/background-color/004.html: Added.
* fast/body-propagation/background-color/005-declarative.xhtml: Added.
* fast/body-propagation/background-color/005-xhtml.xhtml: Added.
* fast/body-propagation/background-color/005.html: Added.
* fast/body-propagation/background-color/006-declarative.xhtml: Added.
* fast/body-propagation/background-color/006-xhtml.xhtml: Added.
* fast/body-propagation/background-color/006.html: Added.
* fast/body-propagation/background-color/007-declarative.xhtml: Added.
* fast/body-propagation/background-color/007-xhtml.xhtml: Added.
* fast/body-propagation/background-color/007.html: Added.
* fast/body-propagation/background-color/008-xhtml.xhtml: Added.
* fast/body-propagation/background-color/008.html: Added.
* fast/body-propagation/background-image: Added.
* fast/body-propagation/background-image/001-xhtml.xhtml: Added.
* fast/body-propagation/background-image/001.html: Added.
* fast/body-propagation/background-image/002-xhtml.xhtml: Added.
* fast/body-propagation/background-image/002.html: Added.
* fast/body-propagation/background-image/003-declarative.xhtml: Added.
* fast/body-propagation/background-image/003-xhtml.xhtml: Added.
* fast/body-propagation/background-image/003.html: Added.
* fast/body-propagation/background-image/004-declarative.xhtml: Added.
* fast/body-propagation/background-image/004-xhtml.xhtml: Added.
* fast/body-propagation/background-image/004.html: Added.
* fast/body-propagation/background-image/005-declarative.xhtml: Added.
* fast/body-propagation/background-image/005-xhtml.xhtml: Added.
* fast/body-propagation/background-image/005.html: Added.
* fast/body-propagation/background-image/006-declarative.xhtml: Added.
* fast/body-propagation/background-image/006-xhtml.xhtml: Added.
* fast/body-propagation/background-image/006.html: Added.
* fast/body-propagation/background-image/007-declarative.xhtml: Added.
* fast/body-propagation/background-image/007-xhtml.xhtml: Added.
* fast/body-propagation/background-image/007.html: Added.
* fast/body-propagation/background-image/008-xhtml.xhtml: Added.
* fast/body-propagation/background-image/008.html: Added.
* fast/body-propagation/background-image/009-xhtml.xhtml: Added.
* fast/body-propagation/background-image/009.html: Added.
* fast/body-propagation/background-image/010-xhtml.xhtml: Added.
* fast/body-propagation/background-image/010.html: Added.
* fast/body-propagation/background-image/resources: Added.
* fast/body-propagation/background-image/resources/lime.png: Added.
* fast/body-propagation/background-image/resources/red.png: Added.
* fast/body-propagation/background-image/resources/white.png: Added.
* fast/body-propagation/background-image/resources/yellow.png: Added.
* fast/body-propagation/overflow: Added.
* fast/body-propagation/overflow/001-xhtml.xhtml: Added.
* fast/body-propagation/overflow/001.html: Added.
* fast/body-propagation/overflow/002-xhtml.xhtml: Added.
* fast/body-propagation/overflow/002.html: Added.
* fast/body-propagation/overflow/003-declarative.xhtml: Added.
* fast/body-propagation/overflow/003-xhtml.xhtml: Added.
* fast/body-propagation/overflow/003.html: Added.
* fast/body-propagation/overflow/004-declarative.xhtml: Added.
* fast/body-propagation/overflow/004-xhtml.xhtml: Added.
* fast/body-propagation/overflow/004.html: Added.
* fast/body-propagation/overflow/005-declarative.xhtml: Added.
* fast/body-propagation/overflow/005-xhtml.xhtml: Added.
* fast/body-propagation/overflow/005.html: Added.
* fast/body-propagation/overflow/006-declarative.xhtml: Added.
* fast/body-propagation/overflow/006-xhtml.xhtml: Added.
* fast/body-propagation/overflow/006.html: Added.
* fast/body-propagation/overflow/007-declarative.xhtml: Added.
* fast/body-propagation/overflow/007-xhtml.xhtml: Added.
* fast/body-propagation/overflow/007.html: Added.
* platform/mac/fast/body-propagation: Added.
* platform/mac/fast/body-propagation/background-color: Added.
* platform/mac/fast/body-propagation/background-color/001-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/001-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/001-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/001-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/001-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/001-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/002-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/002-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/002-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/002-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/002-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/002-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/003-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/003-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/003-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/003-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/003-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/003-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/003-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/003-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/003-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/004-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/004-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/004-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/004-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/004-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/004-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/004-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/004-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/004-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/005-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/005-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/005-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/005-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/005-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/005-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/005-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/005-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/005-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/006-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/006-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/006-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/006-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/006-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/006-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/006-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/006-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/006-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/007-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/007-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/007-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/007-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/007-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/007-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/007-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/007-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/007-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/008-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/008-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/008-expected.txt: Added.
* platform/mac/fast/body-propagation/background-color/008-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-color/008-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-color/008-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image: Added.
* platform/mac/fast/body-propagation/background-image/001-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/001-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/001-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/001-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/001-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/001-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/002-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/002-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/002-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/002-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/002-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/002-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/003-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/003-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/003-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/003-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/003-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/003-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/003-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/003-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/003-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/004-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/004-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/004-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/004-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/004-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/004-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/004-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/004-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/004-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/005-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/005-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/005-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/005-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/005-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/005-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/005-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/005-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/005-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/006-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/006-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/006-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/006-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/006-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/006-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/006-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/006-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/006-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/007-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/007-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/007-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/007-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/007-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/007-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/007-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/007-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/007-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/008-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/008-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/008-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/008-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/008-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/008-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/009-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/009-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/009-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/009-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/009-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/009-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/010-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/010-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/010-expected.txt: Added.
* platform/mac/fast/body-propagation/background-image/010-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/background-image/010-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/background-image/010-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow: Added.
* platform/mac/fast/body-propagation/overflow/001-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/001-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/001-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/001-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/001-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/001-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/002-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/002-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/002-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/002-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/003-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/003-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/003-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/003-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/003-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/003-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/004-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/004-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/004-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/004-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/004-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/004-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/005-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/005-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/005-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/005-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/005-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/005-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/005-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/005-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/005-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/006-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/006-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/006-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/006-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/006-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/006-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/006-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/006-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/006-xhtml-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/007-declarative-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/007-declarative-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/007-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/007-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/007-expected.txt: Added.
* platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum: Added.
* platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png: Added.
* platform/mac/fast/body-propagation/overflow/007-xhtml-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 14 Oct 2008 19:55:12 +0000 (19:55 +0000)]
WebCore:
2008-10-14 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed and landed by Sam Weinig.
Due to change in spec (http://dev.w3.org/2006/webapi/selectors-api/#namespace),
remove NSResolver code, leaving only checking for selectors that need
NS resolution and throwing a coresponding error.
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* bindings/js/JSDocumentCustom.cpp:
* bindings/js/JSDocumentFragmentCustom.cpp:
* bindings/js/JSElementCustom.cpp:
* bindings/js/JSNSResolver.cpp: Removed.
* bindings/js/JSNSResolver.h: Removed.
* dom/Document.idl:
* dom/DocumentFragment.idl:
* dom/Element.idl:
* dom/NSResolver.h: Removed.
* dom/NSResolver.idl: Removed.
* dom/Node.h:
* dom/Node.cpp:
(WebCore::forEachTagSelector):
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
(WebCore::selectorNeedsNamespaceResolution):
(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
LayoutTests:
2008-10-14 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed and landed by Sam Weinig.
Due to change in spec (http://dev.w3.org/2006/webapi/selectors-api/#namespace),
remove no longer relevant NSResolver tests.
* fast/dom/SelectorAPI/NSResolver-basic-expected.txt: Removed.
* fast/dom/SelectorAPI/NSResolver-basic.xhtml: Removed.
* fast/dom/SelectorAPI/NSResolver-exceptions-expected.txt: Removed.
* fast/dom/SelectorAPI/NSResolver-exceptions.xhtml: Removed.
* fast/dom/SelectorAPI/resources/NSResolver-exceptions.js: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 14 Oct 2008 19:19:33 +0000 (19:19 +0000)]
2008-10-14 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig (all but the FormDataListItem rename).
- https://bugs.webkit.org/show_bug.cgi?id=21593
Bug 21593: add multiple-file support to HTMLFormElement
* html/FormDataList.cpp: Removed appendFile since it's now inline.
Also took incorrect old copyrights off of this file that are left
over from when it was split.
* html/FormDataList.h: Ditto. Renamed FormDataListItem to Item and
made it a member of FormDataList. Changed it to hold a File object
instead of a path. And made its data members private. Changed
FormDataList::appendFile accordingly.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formData): Updated for above changes.
Removed the code that special-cases HTMLInputElement, because now
the FormDataListItem has everything we need. And if there are
multiple files, we'll get multiple list items for them.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::appendFormData): Changed the code for
<input type=file> to use File objects instead of path strings and
also to append multiple files if the file list has them.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 14 Oct 2008 19:17:08 +0000 (19:17 +0000)]
Make prepare-ChangeLog populate the changed functions for JavaScript files.
https://bugs.webkit.org/show_bug.cgi?id=21567
Reviewed by David Kilzer.
* Scripts/prepare-ChangeLog:
(get_function_line_ranges): Call get_function_line_ranges_for_javascript for
files that end with ".js".
(get_function_line_ranges_for_javascript): Find functions, anonymous functions
and getters/setters.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 14 Oct 2008 18:43:24 +0000 (18:43 +0000)]
2008-10-14 Alp Toker <alp@nuanti.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=16299
Add a config.h file to DRT
Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
an ad-hoc config header.
* DumpRenderTree/AccessibilityController.cpp:
* DumpRenderTree/AccessibilityUIElement.cpp:
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/DumpRenderTree.h:
* DumpRenderTree/GCController.cpp:
* DumpRenderTree/LayoutTestController.cpp:
* DumpRenderTree/WorkQueue.cpp:
* DumpRenderTree/config.h: Added.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
* DumpRenderTree/gtk/GCControllerGtk.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
* DumpRenderTree/win/AccessibilityControllerWin.cpp:
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
* DumpRenderTree/win/DumpRenderTree.cpp:
* DumpRenderTree/win/DumpRenderTreeWin.h:
* DumpRenderTree/win/EditingDelegate.cpp:
* DumpRenderTree/win/EventSender.cpp:
* DumpRenderTree/win/FrameLoadDelegate.cpp:
* DumpRenderTree/win/GCControllerWin.cpp:
* DumpRenderTree/win/MD5.cpp:
* DumpRenderTree/win/PixelDumpSupportWin.cpp:
* DumpRenderTree/win/PolicyDelegate.cpp:
* DumpRenderTree/win/ResourceLoadDelegate.cpp:
* DumpRenderTree/win/WorkQueueItemWin.cpp:
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Tue, 14 Oct 2008 16:22:20 +0000 (16:22 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20256
Array.push and other standard methods disappear
* kjs/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
Don't use static hash tables even on platforms that don't enable JSC_MULTIPLE_THREADS -
these tables reference IdentifierTable, which is always per-GlobalData.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 14 Oct 2008 12:50:51 +0000 (12:50 +0000)]
2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Fix QtWebKit scrollbar painting errors
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 14 Oct 2008 08:46:28 +0000 (08:46 +0000)]
2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Clip painter to dirty rect before passing on to WebKit
This was previously done in ScrollViewQt, but after the
refactoring of ScrollView we need to do it in QWebFrame
instead, similar to Safari/Win.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 14 Oct 2008 08:43:01 +0000 (08:43 +0000)]
2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Fix scrollbar arrows for horizontal scrollbars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 14 Oct 2008 08:38:41 +0000 (08:38 +0000)]
2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Use style-painter to draw scrollbars in ScrollbarThemeQt
This has the benefit of setting up the painter properly without
antialiasing and saving and restoring the brush. It also ensures
that we use the style of the QWebView over the QApplication style
if possible.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 14 Oct 2008 08:21:19 +0000 (08:21 +0000)]
2008-10-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- always use CTI_ARGUMENTS and CTI_ARGUMENTS_FASTCALL
This is a small regression for GCC 4.0, but simplifies the code
for future improvements and lets us focus on GCC 4.2+ and MSVC.
* VM/CTI.cpp:
* VM/CTI.h:
* VM/Machine.cpp:
(JSC::Machine::cti_op_convert_this):
(JSC::Machine::cti_op_end):
(JSC::Machine::cti_op_add):
(JSC::Machine::cti_op_pre_inc):
(JSC::Machine::cti_timeout_check):
(JSC::Machine::cti_register_file_check):
(JSC::Machine::cti_op_loop_if_less):
(JSC::Machine::cti_op_loop_if_lesseq):
(JSC::Machine::cti_op_new_object):
(JSC::Machine::cti_op_put_by_id):
(JSC::Machine::cti_op_put_by_id_second):
(JSC::Machine::cti_op_put_by_id_generic):
(JSC::Machine::cti_op_put_by_id_fail):
(JSC::Machine::cti_op_get_by_id):
(JSC::Machine::cti_op_get_by_id_second):
(JSC::Machine::cti_op_get_by_id_generic):
(JSC::Machine::cti_op_get_by_id_fail):
(JSC::Machine::cti_op_instanceof):
(JSC::Machine::cti_op_del_by_id):
(JSC::Machine::cti_op_mul):
(JSC::Machine::cti_op_new_func):
(JSC::Machine::cti_op_call_JSFunction):
(JSC::Machine::cti_vm_compile):
(JSC::Machine::cti_op_push_activation):
(JSC::Machine::cti_op_call_NotJSFunction):
(JSC::Machine::cti_op_create_arguments):
(JSC::Machine::cti_op_tear_off_activation):
(JSC::Machine::cti_op_tear_off_arguments):
(JSC::Machine::cti_op_ret_profiler):
(JSC::Machine::cti_op_ret_scopeChain):
(JSC::Machine::cti_op_new_array):
(JSC::Machine::cti_op_resolve):
(JSC::Machine::cti_op_construct_JSConstruct):
(JSC::Machine::cti_op_construct_NotJSConstruct):
(JSC::Machine::cti_op_get_by_val):
(JSC::Machine::cti_op_resolve_func):
(JSC::Machine::cti_op_sub):
(JSC::Machine::cti_op_put_by_val):
(JSC::Machine::cti_op_put_by_val_array):
(JSC::Machine::cti_op_lesseq):
(JSC::Machine::cti_op_loop_if_true):
(JSC::Machine::cti_op_negate):
(JSC::Machine::cti_op_resolve_base):
(JSC::Machine::cti_op_resolve_skip):
(JSC::Machine::cti_op_resolve_global):
(JSC::Machine::cti_op_div):
(JSC::Machine::cti_op_pre_dec):
(JSC::Machine::cti_op_jless):
(JSC::Machine::cti_op_not):
(JSC::Machine::cti_op_jtrue):
(JSC::Machine::cti_op_post_inc):
(JSC::Machine::cti_op_eq):
(JSC::Machine::cti_op_lshift):
(JSC::Machine::cti_op_bitand):
(JSC::Machine::cti_op_rshift):
(JSC::Machine::cti_op_bitnot):
(JSC::Machine::cti_op_resolve_with_base):
(JSC::Machine::cti_op_new_func_exp):
(JSC::Machine::cti_op_mod):
(JSC::Machine::cti_op_less):
(JSC::Machine::cti_op_neq):
(JSC::Machine::cti_op_post_dec):
(JSC::Machine::cti_op_urshift):
(JSC::Machine::cti_op_bitxor):
(JSC::Machine::cti_op_new_regexp):
(JSC::Machine::cti_op_bitor):
(JSC::Machine::cti_op_call_eval):
(JSC::Machine::cti_op_throw):
(JSC::Machine::cti_op_get_pnames):
(JSC::Machine::cti_op_next_pname):
(JSC::Machine::cti_op_push_scope):
(JSC::Machine::cti_op_pop_scope):
(JSC::Machine::cti_op_typeof):
(JSC::Machine::cti_op_is_undefined):
(JSC::Machine::cti_op_is_boolean):
(JSC::Machine::cti_op_is_number):
(JSC::Machine::cti_op_is_string):
(JSC::Machine::cti_op_is_object):
(JSC::Machine::cti_op_is_function):
(JSC::Machine::cti_op_stricteq):
(JSC::Machine::cti_op_nstricteq):
(JSC::Machine::cti_op_to_jsnumber):
(JSC::Machine::cti_op_in):
(JSC::Machine::cti_op_push_new_scope):
(JSC::Machine::cti_op_jmp_scopes):
(JSC::Machine::cti_op_put_by_index):
(JSC::Machine::cti_op_switch_imm):
(JSC::Machine::cti_op_switch_char):
(JSC::Machine::cti_op_switch_string):
(JSC::Machine::cti_op_del_by_val):
(JSC::Machine::cti_op_put_getter):
(JSC::Machine::cti_op_put_setter):
(JSC::Machine::cti_op_new_error):
(JSC::Machine::cti_op_debug):
(JSC::Machine::cti_vm_throw):
* VM/Machine.h:
* masm/X86Assembler.h:
(JSC::X86Assembler::emitRestoreArgumentReference):
(JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Tue, 14 Oct 2008 07:49:51 +0000 (07:49 +0000)]
2008-10-14 Jon Honeycutt <jhoneycutt@apple.com>
Export currentThread.
Rubber-stamped by Dan Bernstein.
* WebKit.vcproj/WebKit.def:
* WebKit.vcproj/WebKit_debug.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 14 Oct 2008 06:45:52 +0000 (06:45 +0000)]
2008-10-13 David Hyatt <hyatt@apple.com>
Add support for CSS transitions on some SVG properties. This patch is intended to be a guideline
for how to add support for the rest.
Reviewed by Oliver Hunt
* page/animation/AnimationBase.cpp:
(WebCore::ensurePropertyMap):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::fillOpacity):
(WebCore::RenderStyle::setFillOpacity):
(WebCore::RenderStyle::strokeOpacity):
(WebCore::RenderStyle::setStrokeOpacity):
(WebCore::RenderStyle::floodOpacity):
(WebCore::RenderStyle::setFloodOpacity):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 14 Oct 2008 06:29:36 +0000 (06:29 +0000)]
2008-10-13 David Hyatt <hyatt@apple.com>
<rdar://problem/
6289712> REGRESSION(r37432-37490): Scroll bar is not drawn in Bookmark View, Preferences sheets.
Fix for disabled scrollbars not painting in Windows Safari. Make sure that the Windows theme
implements paintTrackBackground so that when the thumb is not present the track still paints.
Reviewed by Oliver Hunt
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::paintTrackBackground):
* platform/win/ScrollbarThemeWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 14 Oct 2008 06:12:14 +0000 (06:12 +0000)]
2008-10-13 David Hyatt <hyatt@apple.com>
Fix over-invalidation of native scrollbars.
Reviewed by Oliver Hunt
* platform/Scrollbar.h:
(WebCore::Scrollbar::styleChanged):
* platform/mac/ScrollbarThemeMac.mm:
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::styleChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 14 Oct 2008 05:29:39 +0000 (05:29 +0000)]
2008-10-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- make Machine::getArgumentsData an Arguments method and inline it
~2% on v8 raytrace
* VM/Machine.cpp:
* kjs/Arguments.h:
(JSC::Machine::getArgumentsData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 14 Oct 2008 04:14:38 +0000 (04:14 +0000)]
2008-10-13 Alp Toker <alp@nuanti.com>
Fix autotools dist build target by listing recently added header
files only. Not reviewed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 14 Oct 2008 02:28:46 +0000 (02:28 +0000)]
Don't run a SQLite query on every iteration of the sync thread when the query
will touch a large portion of the icon database while performing no useful work.
Reviewed by Brady Eidson.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::writeToDatabase): Don't call checkForDanglingPageURLs unless
we modified the database.
(WebCore::IconDatabase::checkForDanglingPageURLs): Don't do any work in a release build
unless we've been asked to prune any dangling pageURLs that we find.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 14 Oct 2008 02:16:13 +0000 (02:16 +0000)]
2008-10-13 Alp Toker <alp@nuanti.com>
GTK+ build fix: Ensure correct builds when debugging is
enabled/disabled by defining NDEBUG in autotoolsconfig.h as needed.
It's still passed as a compiler flag since some sources (DRT) don't
use config.h yet.
* configure.ac:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 14 Oct 2008 01:21:43 +0000 (01:21 +0000)]
JavaScriptCore:
2008-10-13 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Mark Rowe.
- fixed <rdar://problem/
5806316> JavaScriptCore should not force building with gcc 4.0
- use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
* Configurations/DebugRelease.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptGlue:
2008-10-13 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Mark Rowe.
- use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
* Configurations/DebugRelease.xcconfig:
WebCore:
2008-10-13 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Mark Rowe.
- use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
* Configurations/DebugRelease.xcconfig:
WebKit/mac:
2008-10-13 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Mark Rowe.
- use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
* Configurations/DebugRelease.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 14 Oct 2008 00:59:46 +0000 (00:59 +0000)]
2008-10-13 David Hyatt <hyatt@apple.com>
Make dropdown lists on Windows work with CSS custom scrollbars.
Reviewed by Adele
* platform/PopupMenu.h:
(WebCore::PopupMenu::scrollbarCornerPresent):
* platform/PopupMenuClient.h:
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::createScrollbar):
* rendering/RenderMenuList.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::createScrollbar):
* rendering/RenderTextControl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Tue, 14 Oct 2008 00:20:49 +0000 (00:20 +0000)]
2008-10-13 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Bug 21541: Move RegisterFile growth check to callee
<https://bugs.webkit.org/show_bug.cgi?id=21541>
Move the RegisterFile growth check to the callee in the common case,
where some of the information is known statically at JIT time. There is
still a check in the caller in the case where the caller provides too
few arguments.
This is a 2.1% speedup on the V8 benchmark, including a 5.1% speedup on
the Richards benchmark, a 4.1% speedup on the DeltaBlue benchmark, and a
1.4% speedup on the Earley-Boyer benchmark. It is also a 0.5% speedup on
SunSpider.
* VM/CTI.cpp:
(JSC::CTI::privateCompile):
* VM/Machine.cpp:
(JSC::Machine::cti_register_file_check):
(JSC::Machine::cti_op_call_JSFunction):
(JSC::Machine::cti_op_construct_JSConstruct):
* VM/Machine.h:
* VM/RegisterFile.h:
* masm/X86Assembler.h:
(JSC::X86Assembler::):
(JSC::X86Assembler::cmpl_mr):
(JSC::X86Assembler::emitUnlinkedJg):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 13 Oct 2008 23:39:43 +0000 (23:39 +0000)]
Fix Windows build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 13 Oct 2008 23:39:06 +0000 (23:39 +0000)]
Fix Windows build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 13 Oct 2008 22:48:19 +0000 (22:48 +0000)]
<rdar://problem/
6271864> Links from image maps not being included in AXLinkUIElements
This also fixes the positions of image map links
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 13 Oct 2008 22:42:59 +0000 (22:42 +0000)]
WebCore:
2008-10-13 David Hyatt <hyatt@apple.com>
Make RenderListBox work with CSS scrollbars. Refactoring this code to support creation/destruction in
the same way RenderLayer does also fixes a bug where the PLT would assert on the next-to-last page (no
idea how to make a test case for that, though, since I couldn't repro without running the whole PLT).
Reviewed by Tim Hatcher
Added scrollbars/listbox-scrollbar-combinations.html
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::~RenderListBox):
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::createScrollbar):
(WebCore::RenderListBox::destroyScrollbar):
(WebCore::RenderListBox::setHasVerticalScrollbar):
* rendering/RenderListBox.h:
LayoutTests:
2008-10-13 David Hyatt <hyatt@apple.com>
Add test case for custom CSS listbox scrollbars.
Reviewed by Tim Hatcher
* platform/mac/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
* platform/mac/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
* platform/mac/scrollbars/listbox-scrollbar-combinations-expected.txt: Added.
* scrollbars/listbox-scrollbar-combinations.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Mon, 13 Oct 2008 22:25:39 +0000 (22:25 +0000)]
Adds an complex styled scrollbar test that exercises all pseudo-elements and pseudo-classes.
Also uses positive and negative margins on the scrollbar track and track pieces.
Tests all the combinations of scrollbars for overflow elements, with and without resizers.
Rubber-stamped by Dave Hyatt.
* platform/mac/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
* platform/mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
* platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt: Added.
* scrollbars/overflow-scrollbar-combinations.html: Added.
* scrollbars/resources: Added.
* scrollbars/resources/corner-inactive.png: Added.
* scrollbars/resources/corner.png: Added.
* scrollbars/resources/horizontal-button-active.png: Added.
* scrollbars/resources/horizontal-button-background-active.png: Added.
* scrollbars/resources/horizontal-button-background-hover.png: Added.
* scrollbars/resources/horizontal-button-background-inactive.png: Added.
* scrollbars/resources/horizontal-button-background.png: Added.
* scrollbars/resources/horizontal-button-hover.png: Added.
* scrollbars/resources/horizontal-button-inactive.png: Added.
* scrollbars/resources/horizontal-button.png: Added.
* scrollbars/resources/horizontal-decrement-arrow.png: Added.
* scrollbars/resources/horizontal-increment-arrow.png: Added.
* scrollbars/resources/horizontal-thumb-active.png: Added.
* scrollbars/resources/horizontal-thumb-hover.png: Added.
* scrollbars/resources/horizontal-thumb-inactive.png: Added.
* scrollbars/resources/horizontal-thumb.png: Added.
* scrollbars/resources/horizontal-track-active.png: Added.
* scrollbars/resources/horizontal-track-disabled.png: Added.
* scrollbars/resources/horizontal-track-hover.png: Added.
* scrollbars/resources/horizontal-track.png: Added.
* scrollbars/resources/resizer-inactive.png: Added.
* scrollbars/resources/resizer.png: Added.
* scrollbars/resources/vertical-button-active.png: Added.
* scrollbars/resources/vertical-button-background-active.png: Added.
* scrollbars/resources/vertical-button-background-hover.png: Added.
* scrollbars/resources/vertical-button-background-inactive.png: Added.
* scrollbars/resources/vertical-button-background.png: Added.
* scrollbars/resources/vertical-button-hover.png: Added.
* scrollbars/resources/vertical-button-inactive.png: Added.
* scrollbars/resources/vertical-button.png: Added.
* scrollbars/resources/vertical-decrement-arrow.png: Added.
* scrollbars/resources/vertical-increment-arrow.png: Added.
* scrollbars/resources/vertical-thumb-active.png: Added.
* scrollbars/resources/vertical-thumb-hover.png: Added.
* scrollbars/resources/vertical-thumb-inactive.png: Added.
* scrollbars/resources/vertical-thumb.png: Added.
* scrollbars/resources/vertical-track-active.png: Added.
* scrollbars/resources/vertical-track-disabled.png: Added.
* scrollbars/resources/vertical-track-hover.png: Added.
* scrollbars/resources/vertical-track.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 13 Oct 2008 21:53:07 +0000 (21:53 +0000)]
2008-10-13 David Hyatt <hyatt@apple.com>
In order to always match the :corner-present pseudo-class properly, delay initial updating of
scrollbar styles until the layer has the scrollbars in its member variables.
Reviewed by Tim Hatcher
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::RenderScrollbar):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 13 Oct 2008 21:41:40 +0000 (21:41 +0000)]
JavaScriptCore:
2008-10-13 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21577
5 false positive StructureID leaks
- Add leak ignore set to StructureID to selectively ignore leaking some StructureIDs.
- Add create method to JSGlolalData to be used when the data will be intentionally
leaked and ignore all leaks caused the StructureIDs stored in it.
* JavaScriptCore.exp:
* kjs/JSGlobalData.cpp:
(JSC::JSGlobalData::createLeaked):
* kjs/JSGlobalData.h:
* kjs/StructureID.cpp:
(JSC::StructureID::StructureID):
(JSC::StructureID::~StructureID):
(JSC::StructureID::startIgnoringLeaks):
(JSC::StructureID::stopIgnoringLeaks):
* kjs/StructureID.h:
WebCore:
2008-10-13 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21577
5 false positive StructureID leaks
In WebCore, we intentionally leak the common JSGlobalData which in turn
leaks 5 StructureIDs. Use the new JSGlobalData::createLeaked in order to
ignore the StructureIDs leaked within.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 13 Oct 2008 21:23:21 +0000 (21:23 +0000)]
2008-10-13 David Hyatt <hyatt@apple.com>
Add support for the :corner-present pseudoclass, which enables scrollbar pieces to change their
artwork based on whether there is a scrollbar corner present.
Reviewed by Tim Hatcher
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollbarCornerPresent):
* platform/ScrollView.h:
* platform/ScrollbarClient.h:
* rendering/RenderLayer.cpp:
(WebCore::cornerRect):
(WebCore::scrollCornerRect):
(WebCore::resizerCornerRect):
(WebCore::RenderLayer::scrollbarCornerPresent):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::horizontalScrollbar):
(WebCore::RenderLayer::verticalScrollbar):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::scrollbarCornerPresent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 13 Oct 2008 20:56:29 +0000 (20:56 +0000)]
2008-10-13 David Hyatt <hyatt@apple.com>
Make resizers and scrollbar corners respect :window-inactive (one more bug fix and then Tim's master
test case for all this can land).
Reviewed by Tim Hatcher
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::styleChanged):
(WebCore::RenderLayer::updateScrollCornerStyle):
(WebCore::RenderLayer::updateResizerStyle):
* rendering/RenderLayer.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::paint):
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::paintIntoRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 13 Oct 2008 20:21:35 +0000 (20:21 +0000)]
2008-10-13 David Hyatt <hyatt@apple.com>
Rework resizer and scroll corner painting so that custom resizers and scroll corners will paint
and invalidate properly as images load, etc.
Reviewed by Tim Hatcher
* rendering/RenderLayer.cpp:
(WebCore::cornerRect):
(WebCore::scrollCornerRect):
(WebCore::resizerCornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::isPointInResizeControl):
(WebCore::RenderLayer::hitTestOverflowControls):
(WebCore::RenderLayer::styleChanged):
* rendering/RenderLayer.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::setRect):
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::styleDidChange):
(WebCore::RenderScrollbarPart::imageChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Mon, 13 Oct 2008 18:55:48 +0000 (18:55 +0000)]
Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range
<https://bugs.webkit.org/show_bug.cgi?id=21457>
Reviewed by Adam.
* Scripts/resolve-ChangeLogs: Added optional parameter to
-f|--fix-merged switch to run the script on a revision range.
Updated command-line validation checks.
(findChangeLog): Fixed long-standing bug that should have used
$_[0] instead of $_.
(fixMergedChangeLog): Renamed to fixOneMergedChangeLog($). Updated
to work when called from git filter-branch. It always restores a
copy of the previous revision before reapplying the patch.
(fixMergedChangeLogs): Added. Calls itself through git filter-branch
to re-merge ChangeLog files across a revision range. Removes
.git/refs/original directory on success.
(parseFixMerged): Added. Custom method to parse the -f|--fix-merged
switch.
(removeChangeLogArguments): Added. Removes items from @ARGV when
they are ChangeLog paths, and return a list of paths. This makes it
easier to validate the command-line.
(resolveChangeLog): Added. Extracted from main code block. Runs
the traditional single-file merge algorithm.
(usageAndExit): Added. Extracted from main code block. Prints
usage statement and exits with error status.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Mon, 13 Oct 2008 18:23:41 +0000 (18:23 +0000)]
2008-10-13 Steve Falkenburg <sfalken@apple.com>
Reorder methods to preserve compatibility.
Rubber stamped by Oliver Hunt.
* Interfaces/IWebViewPrivate.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jmalonzo@webkit.org [Mon, 13 Oct 2008 11:44:35 +0000 (11:44 +0000)]
2008-10-13 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Darin Adler. Landed by Jan Alonzo.
WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
http://bugs.webkit.org/show_bug.cgi?id=20483
Start the conversion to use GOwnPtr and fix a memory leak.
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateErrorCallback):
2008-10-13 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Darin Adler. Landed by Jan Alonzo.
WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
http://bugs.webkit.org/show_bug.cgi?id=20483
Add a GOwnPtr smart pointer (similar to OwnPtr) to handle memory
allocated by GLib and start the conversion to use it.
* GNUmakefile.am:
* wtf/GOwnPtr.cpp: Added.
(WTF::GError):
(WTF::GList):
(WTF::GCond):
(WTF::GMutex):
(WTF::GPatternSpec):
(WTF::GDir):
* wtf/GOwnPtr.h: Added.
(WTF::freeOwnedPtr):
(WTF::GOwnPtr::GOwnPtr):
(WTF::GOwnPtr::~GOwnPtr):
(WTF::GOwnPtr::get):
(WTF::GOwnPtr::release):
(WTF::GOwnPtr::rawPtr):
(WTF::GOwnPtr::set):
(WTF::GOwnPtr::clear):
(WTF::GOwnPtr::operator*):
(WTF::GOwnPtr::operator->):
(WTF::GOwnPtr::operator!):
(WTF::GOwnPtr::operator UnspecifiedBoolType):
(WTF::GOwnPtr::swap):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
(WTF::getPtr):
* wtf/Threading.h:
* wtf/ThreadingGtk.cpp:
(WTF::Mutex::~Mutex):
(WTF::Mutex::lock):
(WTF::Mutex::tryLock):
(WTF::Mutex::unlock):
(WTF::ThreadCondition::~ThreadCondition):
(WTF::ThreadCondition::wait):
(WTF::ThreadCondition::timedWait):
(WTF::ThreadCondition::signal):
(WTF::ThreadCondition::broadcast):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Mon, 13 Oct 2008 02:43:30 +0000 (02:43 +0000)]
2008-10-12 Jon Honeycutt <jhoneycutt@apple.com>
Windows build fix.
* loader/TextResourceDecoder.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 13 Oct 2008 02:20:31 +0000 (02:20 +0000)]
2008-10-12 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=21523
Add tests to cover more gradient edge cases: missing endpoints, only
endpoints, only one stop.
* fast/canvas/fillrect_gradient.html:
* platform/mac/fast/canvas/fillrect_gradient-expected.checksum:
* platform/mac/fast/canvas/fillrect_gradient-expected.png:
* platform/mac/fast/canvas/fillrect_gradient-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 13 Oct 2008 02:16:09 +0000 (02:16 +0000)]
2008-10-12 Gabriella Toth <gtoth@inf.u-szeged.hu>
Reviewed by Darin Adler.
- part of https://bugs.webkit.org/show_bug.cgi?id=21055
Bug 21055: not invoked functions
* kjs/nodes.cpp: Deleted a function that is not invoked:
statementListInitializeVariableAccessStack.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 13 Oct 2008 02:13:47 +0000 (02:13 +0000)]
2008-10-12 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=21229
Bug 21229: NetworkStateNotifier.h lacks a #include <windows.h> for PLATFORM(WIN)
* platform/network/NetworkStateNotifier.h: Add the #include.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Oct 2008 01:41:08 +0000 (01:41 +0000)]
Fix typo in LayoutTests/ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 13 Oct 2008 01:37:13 +0000 (01:37 +0000)]
2008-10-12 Darin Adler <darin@apple.com>
Based on work by Holger Freyther.
- part of https://bugs.webkit.org/show_bug.cgi?id=20953
Split WidthIterator into its own source file.
* GNUmakefile.am: Added new source files.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* WebCoreSources.bkl: Ditto.
* platform/graphics/Font.cpp: Use WidthIterator from its new place.
* platform/graphics/WidthIterator.cpp: Added.
* platform/graphics/WidthIterator.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Oct 2008 01:29:37 +0000 (01:29 +0000)]
2008-10-12 Pamela Greene <pam@chromium.org>
Fixed 'completed' variable name to match 'running' one.
See https://bugs.webkit.org/show_bug.cgi?21506
Reviewed by Darin Adler.
Landed by Adam Barth.
* dom/html/level2/html/HTMLFrameElement09.js:
* dom/html/level2/html/HTMLIFrameElement11.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Oct 2008 01:15:32 +0000 (01:15 +0000)]
2008-10-12 Pamela Greene <pam@chromium.org>
Remove a race condition in a test by promoting layoutTestController
calls outside document.write(). Add document.close().
See https://bugs.webkit.org/show_bug.cgi?id=21524
Reviewed by Darin Adler.
Landed by Adam Barth.
* fast/encoding/script-in-head.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Oct 2008 01:15:22 +0000 (01:15 +0000)]
2008-10-12 Pamela Greene <pam@chromium.org>
Remove data: URLs to avoid cross-domain security restrictions.
See https://bugs.webkit.org/show_bug.cgi?id=21528
Reviewed by Darin Adler.
Landed by Adam Barth.
* fast/events/resources/tabindex-focus-blur-all-frame1.html:
* fast/events/resources/tabindex-focus-blur-all-frame2.html:
* fast/events/resources/tabindex-focus-blur-all-frame3.html: Added.
* fast/events/tabindex-focus-blur-all.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Oct 2008 01:15:11 +0000 (01:15 +0000)]
2008-10-12 Pamela Greene <pam@chromium.org>
Fix test when removesExtraParentheses == false.
See https://bugs.webkit.org/show_bug.cgi?id=21529
Reviewed by Darin Adler.
Landed by Adam Barth.
* fast/js/resources/function-toString-parentheses.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Oct 2008 01:15:01 +0000 (01:15 +0000)]
2008-10-12 Pamela Greene <pam@chromium.org>
Fix a race condition by waiting for all create functions to be called
before terminating.
See https://bugs.webkit.org/show_bug.cgi?id=21531
Reviewed by Darin Adler.
Landed by Adam Barth.
* platform/mac/svg/carto.net/window-expected.checksum:
* platform/mac/svg/carto.net/window-expected.png:
* platform/mac/svg/carto.net/window-expected.txt:
* svg/carto.net/window.svg:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Oct 2008 01:14:51 +0000 (01:14 +0000)]
2008-10-12 Pamela Greene <pam@chromium.org>
Remove inadvertent const redefinition, and add specific test for it.
See https://bugs.webkit.org/show_bug.cgi?id=21532
Reviewed by Darin Adler.
Landed by Adam Barth.
* fast/js/const-expected.txt:
* fast/js/resources/const.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 13 Oct 2008 01:14:27 +0000 (01:14 +0000)]
2008-10-12 Pamela Greene <pam@chromium.org>
Add a test for null character data.
See https://bugs.webkit.org/show_bug.cgi?id=21535
Reviewed by Darin Adler.
Landed by Adam Barth.
* fast/dom/null-chardata-crash-expected.txt: Added.
* fast/dom/null-chardata-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 13 Oct 2008 01:13:29 +0000 (01:13 +0000)]
2008-10-12 Tony Chang <tony@chromium.org>
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=21480
Remove duplicate definitions of MimeClassInfo and PluginInfo.
* plugins/PluginInfoStore.cpp: Added an include.
* plugins/PluginInfoStore.h: Removed struct declarations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 13 Oct 2008 01:07:04 +0000 (01:07 +0000)]
2008-10-12 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- https://bugs.webkit.org/show_bug.cgi?id=21563
Bug 21563: platform Gradient class should not use the CSS parser
* platform/graphics/Gradient.cpp: Removed the overload of addColorStop
that accepts a CSS color string. That's handled in the DOM now, not here.
(WebCore::Gradient::addColorStop): Use getRGBA instead of having our own
copy of it here.
* platform/graphics/Gradient.h: More of the same. Tweak formatting a bit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 13 Oct 2008 00:58:00 +0000 (00:58 +0000)]
WebCore:
2008-10-12 Glenn Wilson <gwilson@google.com>
Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=20461
Added feature to allow multi-line inputs into text fields.
HTMLInputElement would cut the set text at the first 'system' character,
so it would truncate at the first carriage return or newline.
This fix modifies that behavior to truncate at any non-space system character
but changes \r, \n, and \r\n to a single space.
Tests: editing/pasteboard/paste-multiline-text-input.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::constrainValue):
LayoutTests:
2008-10-12 Glenn Wilson <gwilson@google.com>
Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=20461
Added new test to verify that the user can cut and paste multiple lines of text
into a single line text field.
* fast/forms/paste-multiline-text-input-expected.txt: Added.
* fast/forms/paste-multiline-text-input.html: Added.
* fast/forms/input-truncate-newline-expected.txt: Removed.
* fast/forms/input-truncate-newline.html: Removed.
* fast/forms/8250-expected.txt: Added.
* fast/forms/8250.html: Updated test to be text-only and expect new results.
* platform/mac/fast/forms/8250-expected.checksum: Removed.
* platform/mac/fast/forms/8250-expected.png: Removed.
* platform/mac/fast/forms/8250-expected.txt: Removed.
* platform/qt/fast/forms/8250-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 13 Oct 2008 00:25:00 +0000 (00:25 +0000)]
WebCore:
2008-10-12 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
- https://bugs.webkit.org/show_bug.cgi?id=20435
Added exception codes to canvas gradients to match current specification.
Tests: fast/canvas/gradient-addColorStop-with-invalid-color.html
fast/canvas/linearGradient-infinite-values.html
fast/canvas/radialGradient-infinite-values.html
* html/CanvasGradient.cpp:
(WebCore::CanvasGradient::addColorStop):
* html/CanvasGradient.h:
* html/CanvasGradient.idl:
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createLinearGradient):
(WebCore::CanvasRenderingContext2D::createRadialGradient):
* html/CanvasRenderingContext2D.h:
* html/CanvasRenderingContext2D.idl:
LayoutTests:
2008-10-12 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
- test for https://bugs.webkit.org/show_bug.cgi?id=20435
Added new tests to check behavior of canvas gradients to infinite values
or invalid colors.
* fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt: Added.
* fast/canvas/gradient-addColorStop-with-invalid-color.html: Added.
* fast/canvas/linearGradient-infinite-values-expected.txt: Added.
* fast/canvas/linearGradient-infinite-values.html: Added.
* fast/canvas/radialGradient-infinite-values-expected.txt: Added.
* fast/canvas/radialGradient-infinite-values.html: Added.
* fast/canvas/resources/gradient-addColorStop-with-invalid-color.js: Added.
* fast/canvas/resources/linearGradient-infinite-values.js: Added.
* fast/canvas/resources/radialGradient-infinite-values.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 12 Oct 2008 23:59:09 +0000 (23:59 +0000)]
2008-10-12 Eric Roman <eroman@chromium.org>
- https://bugs.webkit.org/show_bug.cgi?id=20246
Implement RenderThemeWin::systemColor() to match Windows colors.
Reviewed by David Hyatt.
* rendering/RenderThemeWin.cpp:
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWin::systemColor):
* rendering/RenderThemeWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 12 Oct 2008 23:50:45 +0000 (23:50 +0000)]
2008-10-12 Aaron Bockover <abockover@novell.com>
Reviewed by Alp Toker.
Add version parsing for Flash, and the PluginQuirkDontSetNullWindowHandleOnDestroy
plugin quirk if Flash 10 or newer since at least in b218, setting a NULL window
handler on destroy crashes WebKit <https://bugs.webkit.org/show_bug.cgi?id=19859>
* plugins/gtk/PluginPackageGtk.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 12 Oct 2008 23:01:25 +0000 (23:01 +0000)]
2008-10-12 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
Reviewed by Oliver Hunt.
- https://bugs.webkit.org/show_bug.cgi?id=19331
<rdar://problem/
5984433>: Drag and drop of links in edit mode violates assert in MoveSelectionCommand::doApply()
* page/DragController.cpp:
(WebCore::DragController::startDrag): When a link is dragged without any
text selected (note: for this to work, the EditableLinkBehavior setting must be
set to 'live' or 'default') and then dropped into an editable html document it
will eventually violate an ASSERT in MoveSelectionCommand that requires that there
is a selection. To prevent this, expand the selection to the enclosing anchor tag
when the drag begins.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 12 Oct 2008 22:53:15 +0000 (22:53 +0000)]
2008-10-12 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
- fix https://bugs.webkit.org/show_bug.cgi?id=21557
Bug 21557: REGRESSION: generated-layer-scrollbar-crash.html is crashing
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getPseudoStyle): Keep walking up the parent chain
until we hit an Element. Nowadays, Node::isElementNode() is just as efficient
as RenderObject::isText(), and this guarantees that the node can be cast to
Element*, which is done just below. The reason this is hit is that RenderLayer
can call getPseudoStyle on a RenderView, which has the document as its
element() -- and a document is neither a Text node nor an Element. A loose
end is that this seems to mean you can't style the scrollbar corner or the
resizer on a RenderView. Hyatt may want to look into that later.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 12 Oct 2008 22:51:13 +0000 (22:51 +0000)]
2008-10-12 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
* wtf/unicode/icu/UnicodeIcu.h: Fixed indentation to match WebKit coding style.
* wtf/unicode/qt4/UnicodeQt4.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 12 Oct 2008 22:49:46 +0000 (22:49 +0000)]
JavaScriptCore:
2008-10-12 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=21556
Bug 21556: non-ASCII digits are allowed in places where only ASCII should be
* wtf/unicode/icu/UnicodeIcu.h: Removed isDigit, digitValue, and isFormatChar.
* wtf/unicode/qt4/UnicodeQt4.h: Ditto.
WebCore:
2008-10-12 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=21556
Bug 21556: non-ASCII digits are allowed in places where only ASCII should be
Tests: fast/dom/HTMLFontElement/size-attribute.html
fast/dom/HTMLInputElement/size-attribute.html
fast/dom/HTMLTableElement/cellpadding-attribute.html
* html/HTMLFontElement.cpp:
(WebCore::parseFontSizeNumber): Use isASCIIDigit instead of
Unicode::isDigit, since non-ASCII digits are not valid here.
* html/HTMLFontElement.h: Tweaked formatting a bit and removed
the unneeded destructor declaration.
* platform/text/String.cpp:
(WebCore::lengthOfCharactersAsInteger): Use isASCIIDigit instead
of Unicode::isDigit, since non-ASCII digits are not valid.
LayoutTests:
2008-10-12 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
- tests for https://bugs.webkit.org/show_bug.cgi?id=21556
Bug 21556: non-ASCII digits are allowed in places where only ASCII should be
The fix was in a function used all over the place. I set a breakpoint in the
function and made some regression tests for the first few places it was used.
* fast/dom/HTMLFontElement: Added.
* fast/dom/HTMLFontElement/resources: Added.
* fast/dom/HTMLFontElement/resources/TEMPLATE.html: Added.
* fast/dom/HTMLFontElement/resources/size-attribute.js: Added.
* fast/dom/HTMLFontElement/size-attribute-expected.txt: Added.
* fast/dom/HTMLFontElement/size-attribute.html: Added.
* fast/dom/HTMLInputElement/resources/size-attribute.js: Added.
* fast/dom/HTMLInputElement/size-attribute-expected.txt: Added.
* fast/dom/HTMLInputElement/size-attribute.html: Added.
* fast/dom/HTMLTableElement/cellpadding-attribute-expected.txt: Added.
* fast/dom/HTMLTableElement/cellpadding-attribute.html: Added.
* fast/dom/HTMLTableElement/resources/cellpadding-attribute.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 12 Oct 2008 22:38:23 +0000 (22:38 +0000)]
WebCore:
2008-10-12 Jungshik Shin <jshin@chromium.org>
Reviewed by Darin Adler.
Treat x-user-defined as windows-1252 for html files with meta charset
declaration to be compatible with Indian web sites.
( https://bugs.webkit.org/show_bug.cgi?id=18270 )
Test: fast/encoding/charset-xuser-defined.html
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::setEncoding):
LayoutTests:
2008-10-12 Jungshik Shin <jshin@chromium.org>
Reviewed by Darin Adler.
Treat x-user-defined as windows-1252 for html files with meta charset
declaration to be compatible with Indian web sites.
( https://bugs.webkit.org/show_bug.cgi?id=18270 )
* fast/encoding/charset-xuser-defined-expected.txt: Added.
* fast/encoding/charset-xuser-defined.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 12 Oct 2008 22:24:25 +0000 (22:24 +0000)]
2008-10-12 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- https://bugs.webkit.org/show_bug.cgi?id=21559
Bug 21559: many SVG tests are slightly different from what make-js-test-wrappers would make
* svg/custom/immutable-properties.html: Updated path to test resources so it
does not go up out of and back into LayoutTests.
* svg/custom/svg-modify-currentTranslate.html: Ditto.
* svg/custom/svg-xml-dom-sync.html: Ditto.
* svg/custom/tearoffs-with-tearoffs.html: Ditto.
* svg/dynamic-updates/resources/*.js: Allow the make-js-test-wrappers script to
add var successfullyParsed = true; to these files. It's not helpful for the tests,
but it's not harmful either.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 12 Oct 2008 21:32:38 +0000 (21:32 +0000)]
2008-10-12 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Remove unneeded forward declaration.
* platform/graphics/ImageBuffer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 12 Oct 2008 20:43:15 +0000 (20:43 +0000)]
2008-10-12 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21560
Layering violation: String should not be responsible for creating Lengths
It was a layering violation for String to know haw to parse
into Lengths, LengthArrays, and CoordsArrays.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::parseMappedAttribute):
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
* platform/text/AtomicString.h:
(WebCore::AtomicString::percentage):
* platform/text/PlatformString.h:
* platform/text/String.cpp:
* platform/text/StringImpl.cpp:
* platform/text/StringImpl.h:
* rendering/Length.cpp: Added.
(WebCore::parseLength):
(WebCore::countCharacter):
(WebCore::newCoordsArray):
(WebCore::newLengthArray):
* rendering/Length.h:
(WebCore::LengthSize::LengthSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sun, 12 Oct 2008 19:51:33 +0000 (19:51 +0000)]
2008-10-12 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Make the append method that takes a Vector more strict - it now requires the elements
of the vector to be appended same type as the elements of the Vector they're being appended to.
This would cause problems when dealing with Vectors containing other Vectors.
* wtf/Vector.h:
(WTF::::append):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 12 Oct 2008 19:34:42 +0000 (19:34 +0000)]
2008-10-12 Darin Adler <darin@apple.com>
* Scripts/make-js-test-wrappers: Update exceptions list so the script
won't overwrite files and mangle tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 12 Oct 2008 18:23:56 +0000 (18:23 +0000)]
WebCore:
2008-10-12 Brad Garcia <bgarcia@google.com>
Reviewed by Darin Adler.
Interpret fractional percentage values for %MultiLength values.
Fix for https://bugs.webkit.org/show_bug.cgi?id=3591
Test: fast/frames/frame-length-fractional-percentage.html
* platform/text/StringImpl.cpp:
(WebCore::parseLength):
LayoutTests:
2008-10-12 Brad Garcia <bgarcia@google.com>
Reviewed by Darin Adler.
Testcases for fractional frame lengths.
https://bugs.webkit.org/show_bug.cgi?id=3591
* fast/frames/frame-length-fractional.html: Added.
* fast/frames/frame-length-fractional-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sun, 12 Oct 2008 17:04:51 +0000 (17:04 +0000)]
Remember the expanded state of the rules in the Styles pane. So
collapsing a rule will persist across all the elements that have
that same rule. The same applies to Computed Style, so the Computed
Style rule is now collapsed by default. This should help lessen the
confusion on why Computed Style can't be edited (a common confusion.)
https://bugs.webkit.org/show_bug.cgi?id=21553
Reviewed by Darin Adler.
* inspector/front-end/PropertiesSection.js:
(WebInspector.PropertiesSection): Set the _expanded property directly,
instead of using the setter. Expanded is the default, so no work is needed.
This prevents calling StylesSidebarPane.collapse before object initialization
is complete.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update): Check the Preferences object
for the expanded state of the StylePropertiesSection. Collapse computed style
by default and expand everything else.
(WebInspector.StylePropertiesSection): Make a semi unique identifier to be used
when remembering expanded state.
(WebInspector.StylePropertiesSection.prototype.expand): Set the expanded state
to true for this identifier in Preferences.styleRulesExpandedState. Don't remember
the state if the dontRememberState property is true.
(WebInspector.StylePropertiesSection.prototype.collapse): Set the expanded state
to false for this identifier in Preferences.styleRulesExpandedState.
* inspector/front-end/inspector.js:
(Preferences.styleRulesExpandedState): Initialize to an empty object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jmalonzo@webkit.org [Sun, 12 Oct 2008 11:47:04 +0000 (11:47 +0000)]
2008-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Alp Toker.
[Gtk] Remove libWebCoreJS.la when doing make clean
https://bugs.webkit.org/show_bug.cgi?id=21544
Remove libWebCoreJS.la when doing a clean target
* GNUmakefile.am: add libWebCoreJS.la to CLEANFILES
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 12 Oct 2008 06:50:21 +0000 (06:50 +0000)]
2008-10-11 Alp Toker <alp@nuanti.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20592
The focus ring is not shown while navigating on some pages
Fix drawFocusRing() so it doesn't depend on the current graphics
state, thus matching other platforms which already work this way.
This patch provides two code paths: one using straight Cairo and
one specialised for the GTK+ port with a more conventional appearance.
Also change focusRingColor() to return a null color, allowing the
focus ring to pick up the style's current color if it isn't overridden
with CSS.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawFocusRing):
* platform/gtk/TemporaryLinkStubs.cpp:
(WebCore::focusRingColor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Sun, 12 Oct 2008 05:00:28 +0000 (05:00 +0000)]
2008-10-11 Cameron Zwarich <zwarich@apple.com>
Reviewed by Sam Weinig.
Clean up RegExpMatchesArray.h to match our coding style.
* kjs/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::getPropertyNames):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 12 Oct 2008 04:56:20 +0000 (04:56 +0000)]
Rubber-stamped by Sam Weinig.
- change all internal callers to use Cache::evict() instead of remove()
* loader/Cache.cpp:
(WebCore::Cache::revalidateResource):
(WebCore::Cache::revalidationSucceeded):
(WebCore::Cache::pruneDeadResources):
(WebCore::Cache::setDisabled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 12 Oct 2008 04:26:47 +0000 (04:26 +0000)]
2008-10-11 David Hyatt <hyatt@apple.com>
Make sure invalidatePart knows how to invalidate the track and scrollbar backgrounds.
Reviewed by Tim Hatcher
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::invalidatePart):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 12 Oct 2008 04:20:26 +0000 (04:20 +0000)]
2008-10-11 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21549 (regression in before/after track pieces).
Also fixed resizer positioning problems.
Reviewed by Tim Hatcher
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::splitTrack):
(WebCore::ScrollbarThemeComposite::trackPosition):
(WebCore::ScrollbarThemeComposite::trackLength):
* platform/ScrollbarThemeComposite.h:
(WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
* rendering/RenderLayer.cpp:
(WebCore::scrollCornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::isPointInResizeControl):
(WebCore::RenderLayer::hitTestOverflowControls):
* rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
* rendering/RenderScrollbarTheme.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 12 Oct 2008 03:33:28 +0000 (03:33 +0000)]
2008-10-11 Alp Toker <alp@nuanti.com>
Reviewed by David Hyatt.
Implement release/retain for Widget GTK+.
* platform/Widget.cpp:
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::~Widget):
(WebCore::Widget::releasePlatformWidget):
(WebCore::Widget::retainPlatformWidget):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 12 Oct 2008 01:38:08 +0000 (01:38 +0000)]
Fix ChangeLog header that was mangled in r37484.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 12 Oct 2008 01:31:19 +0000 (01:31 +0000)]
Disable animations/font-size-using-ems.html as it has been causing the following test, animatinos/generic-from-to.html, to hang since it was added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 11 Oct 2008 23:10:43 +0000 (23:10 +0000)]
Reviewed by Sam Weinig and Anders Carlsson.
- update Mac DumpRenderTree to use the new WebView SPI for forcing the
complex text code path
- add --complex-text support to Windows DumpRenderTree
* DumpRenderTree/mac/DumpRenderTree.mm:
(dumpRenderTree):
* DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):
(main):
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 11 Oct 2008 22:53:28 +0000 (22:53 +0000)]
WebCore:
Reviewed by Sam Weinig.
- rename WebCoreSetAlwaysUseATSU to WebCoreSetAlwaysUsesComplexTextCodePath
and add a corresponding getter; add the same functions on Windows
* WebCore.base.exp:
* platform/graphics/Font.cpp:
(WebCore::Font::setCodePath):
(WebCore::codePath):
(WebCore::Font::canUseGlyphCache):
* platform/graphics/Font.h:
* platform/mac/WebCoreTextRenderer.h:
* platform/mac/WebCoreTextRenderer.mm:
(WebCoreSetAlwaysUsesComplexTextCodePath):
(WebCoreAlwaysUsesComplexTextCodePath):
* platform/win/WebCoreTextRenderer.cpp:
(WebCore::WebCoreSetAlwaysUsesComplexTextCodePath):
(WebCore::WebCoreAlwaysUsesComplexTextCodePath):
* platform/win/WebCoreTextRenderer.h:
WebKit/mac:
Reviewed by Sam Weinig.
- rename _setAlwaysUseATSU to _setAlwaysUsesComplexTextCodePath and
update it for the renamed WebCoreTextRenderer method; keep the old
method around for clients that use it
* WebView/WebView.mm:
(+[WebView _setAlwaysUseATSU:]):
(+[WebView _setAlwaysUsesComplexTextCodePath:]):
* WebView/WebViewPrivate.h:
WebKit/win:
Reviewed by Sam Weinig.
- add SPI for forcing the complex text code path to be used for all text
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::setAlwaysUsesComplexTextCodePath):
(WebView::alwaysUsesComplexTextCodePath):
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 11 Oct 2008 22:20:09 +0000 (22:20 +0000)]
2008-10-11 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Stop leaking the event parameter names. The protected strings were showing up
in the caches window after one use. No measurable performance loss.
* bindings/js/JSEventListener.cpp:
(WebCore::eventParameterName):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 11 Oct 2008 22:10:38 +0000 (22:10 +0000)]
2008-10-11 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Remove unused function getNodeEventListener.
* bindings/js/JSEventListener.cpp:
* bindings/js/JSEventListener.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Sat, 11 Oct 2008 20:58:35 +0000 (20:58 +0000)]
2008-10-11 Cameron Zwarich <zwarich@apple.com>
Reviewed by Sam Weinig.
Bug 21525: 55 StructureID leaks on Wikitravel's main page
<https://bugs.webkit.org/show_bug.cgi?id=21525>
Bug 21533: Simple JavaScript code leaks StructureIDs
<https://bugs.webkit.org/show_bug.cgi?id=21533>
StructureID::getEnumerablePropertyNames() ends up calling back to itself
via JSObject::getPropertyNames(), which causes the PropertyNameArray to
be cached twice. This leads to a memory leak in almost every use of
JSObject::getPropertyNames() on an object. The fix here is based on a
suggestion of Sam Weinig.
This patch also fixes every StructureID leaks that occurs while running
the Mozilla MemBuster test.
* kjs/PropertyNameArray.h:
(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::setCacheable):
(JSC::PropertyNameArray::cacheable):
* kjs/StructureID.cpp:
(JSC::StructureID::getEnumerablePropertyNames):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 11 Oct 2008 07:50:03 +0000 (07:50 +0000)]
2008-10-11 David Hyatt <hyatt@apple.com>
Add support for both positive and negative margins to tracks and track pieces.
Reviewed by Tim Hatcher
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::hitTest):
(WebCore::ScrollbarThemeComposite::splitTrack):
(WebCore::ScrollbarThemeComposite::trackPieceRects):
(WebCore::ScrollbarThemeComposite::trackPosition):
(WebCore::ScrollbarThemeComposite::trackLength):
* platform/ScrollbarThemeComposite.h:
(WebCore::ScrollbarThemeComposite::adjustTrackPieceRect):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::trackRect):
(WebCore::RenderScrollbar::trackPieceRectWithMargins):
* rendering/RenderScrollbar.h:
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
* rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::adjustTrackPieceRect):
* rendering/RenderScrollbarTheme.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 11 Oct 2008 06:33:35 +0000 (06:33 +0000)]
Update scrollbars layout tests to new syntax.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 11 Oct 2008 06:30:47 +0000 (06:30 +0000)]
2008-10-10 David Hyatt <hyatt@apple.com>
Drop -webkit-scrollbar- from all the scrollbar pseudo-classes, since they are scoped to
the scrollbar pseudo-elements anyway.
Reviewed by Tim Hatcher
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 11 Oct 2008 06:26:59 +0000 (06:26 +0000)]
Reviewed by Sam Weinig.
- separate Cache::remove() into a private method and a public interface,
then make Cache::pruneDeadResources() use the private method.
* loader/Cache.cpp:
(WebCore::Cache::pruneDeadResources):
(WebCore::Cache::evict):
* loader/Cache.h:
(WebCore::Cache::remove):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 11 Oct 2008 06:12:14 +0000 (06:12 +0000)]
2008-10-10 David Hyatt <hyatt@apple.com>
Fix a math error when splitting a vertical track. Clean up more of ScrollbarThemeComposite
now that the track pieces meet under the thumb.
Reviewed by Tim Hatcher
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::splitTrack):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 11 Oct 2008 06:04:02 +0000 (06:04 +0000)]
2008-10-10 David Hyatt <hyatt@apple.com>
Make the track pieces of a scrollbar extend under the thumb (each gets half the thumb).
Reviewed by Tim Hatcher
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::hitTest):
(WebCore::ScrollbarThemeComposite::splitTrack):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 11 Oct 2008 05:54:35 +0000 (05:54 +0000)]
2008-10-10 David Hyatt <hyatt@apple.com>
Make sure specialized ::scrollbar rules are still triggering custom scrollbar creation.
Reviewed by Tim Hatcher
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::createCustomScrollbar):
(WebCore::RenderScrollbar::RenderScrollbar):
(WebCore::RenderScrollbar::setParent):
(WebCore::RenderScrollbar::updateScrollbarParts):
(WebCore::RenderScrollbar::updateScrollbarPart):
* rendering/RenderScrollbar.h:
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 11 Oct 2008 05:49:39 +0000 (05:49 +0000)]
Use fastcall calling convention on GCC > 4.0
Reviewed by Cameron Zwarich
Results in a 2-3% improvement in GCC 4.2 performance, so
that it is no longer a regression vs. GCC 4.0
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 11 Oct 2008 05:30:39 +0000 (05:30 +0000)]
2008-10-10 David Hyatt <hyatt@apple.com>
Make sure scrollbar background images cause proper part invalidation to occur.
Reviewed by Tim Hatcher
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::setHoveredPart):
(WebCore::RenderScrollbar::setPressedPart):
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::styleDidChange):
(WebCore::RenderScrollbarPart::imageChanged):
* rendering/RenderScrollbarPart.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 11 Oct 2008 02:53:03 +0000 (02:53 +0000)]
JavaScriptCore:
2008-10-10 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
- Add a workaround for a bug in ceil in Darwin libc.
- Remove old workarounds for JS math functions that are not needed
anymore.
The math functions are heavily tested by fast/js/math.html.
* kjs/MathObject.cpp:
(JSC::mathProtoFuncAbs): Remove workaround.
(JSC::mathProtoFuncCeil): Ditto.
(JSC::mathProtoFuncFloor): Ditto.
* wtf/MathExtras.h:
(wtf_ceil): Add ceil workaround for darwin.
LayoutTests:
2008-10-10 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
- Update tests after fixing ceil(-0.1) behavior on darwin.
* fast/js/math-expected.txt:
* fast/js/resources/math.js: Remove code to detect sign of 0 now that the harness can handle it.
* fast/xpath/4XPath/Core/test_core_functions-expected.txt:
* fast/xpath/4XPath/Core/test_core_functions.html: Update test expect correct result of -0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log