WebKit-https.git
11 years ago2010-10-19 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Tue, 19 Oct 2010 08:57:14 +0000 (08:57 +0000)]
2010-10-19  Hayato Ito  <hayato@chromium.org>

        Reviewed by Darin Adler.

        Make CSS style selector non-recursive.
        https://bugs.webkit.org/show_bug.cgi?id=43783

        This change is one of the required changes to fix the following master bug:
        https://bugs.webkit.org/show_bug.cgi?id=42806

        To avoid recursion, we prepare a call stack and maintain a list of
        function call state by ourselves and try matching iteratively.

        * fast/css/long-css-selector-matches-expected.txt: Added.
        * fast/css/long-css-selector-matches.html: Added.
2010-10-19  Hayato Ito  <hayato@chromium.org>

        Reviewed by Darin Adler.

        Make CSS style selector non-recursive.
        https://bugs.webkit.org/show_bug.cgi?id=43783

        This change is one of the required changes to fix the following master bug:
        https://bugs.webkit.org/show_bug.cgi?id=42806

        To avoid recursion, we prepare a call stack and maintain a list of
        function call state by ourselves and try matching iteratively.

        Test: fast/css/long-css-selector-matches.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
        (WebCore::CSSStyleSelector::checkSelector):
        * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-19 Sergio Villar Senín <svillar@igalia.com>
commit-queue@webkit.org [Tue, 19 Oct 2010 08:48:57 +0000 (08:48 +0000)]
2010-10-19  Sergio Villar Senín  <svillar@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] http/history tests are failing
        https://bugs.webkit.org/show_bug.cgi?id=36173

        Removed skipped tests from http/history

        * platform/gtk/Skipped:
2010-10-19  Sergio Villar Senín  <svillar@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] http/history tests are failing
        https://bugs.webkit.org/show_bug.cgi?id=36173

        Clear the history each time a test is run. Return the actual
        history item count when calling
        LayoutTestController::webHistoryItemCount

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::webHistoryItemCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-19 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 19 Oct 2010 08:30:03 +0000 (08:30 +0000)]
2010-10-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r70034.
        http://trac.webkit.org/changeset/70034
        https://bugs.webkit.org/show_bug.cgi?id=47889

        "Gustavo's bot is lame" (Requested by xan_ on #webkit).

        * configure.ac:
2010-10-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r70034.
        http://trac.webkit.org/changeset/70034
        https://bugs.webkit.org/show_bug.cgi?id=47889

        "Gustavo's bot is lame" (Requested by xan_ on #webkit).

        * platform/network/soup/CookieJarSoup.cpp:
        (WebCore::defaultCookieJar):
        (WebCore::setCookies):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::prepareForURL):
        (WebCore::restartedCallback):
        (WebCore::startHttp):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-19 Joone Hur <joone@kldp.org>
commit-queue@webkit.org [Tue, 19 Oct 2010 08:17:22 +0000 (08:17 +0000)]
2010-10-19  Joone Hur  <joone@kldp.org>

        Reviewed by Martin Robinson.

        [GTK] Needs fixing mistyped comments in the API documentation
        https://bugs.webkit.org/show_bug.cgi?id=47656

        Fixed mistyped comments in the API documenentation.

        * webkit/webkitwebsettings.cpp: Fixed a mistyped comment in the the section block.
        * webkit/webkitwebwindowfeatures.cpp: Fixed a mistyped comment in the section block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-19 Prof. MAAD <himself@prof-maad.org>
commit-queue@webkit.org [Tue, 19 Oct 2010 07:58:38 +0000 (07:58 +0000)]
2010-10-19  Prof. MAAD  <himself@prof-maad.org>

        Reviewed by Xan Lopez.

        [GTK] Correct erroneous documentation for webkit_web_navigation_action_get_button()
        https://bugs.webkit.org/show_bug.cgi?id=46723

        * WebKit/gtk/webkit/webkitwebnavigationaction.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-19 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 19 Oct 2010 07:50:55 +0000 (07:50 +0000)]
2010-10-19  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Bump minimum requirement for libsoup to 2.30
        https://bugs.webkit.org/show_bug.cgi?id=46176

        Bump minimum libsoup to required version to 2.30.0.

        * configure.ac:

WebCore:

2010-10-19  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Bump minimum requirement for libsoup to 2.30
        https://bugs.webkit.org/show_bug.cgi?id=46176

        Bump minimum required libsoup version to 2.30.

        * platform/network/soup/CookieJarSoup.cpp:
        (WebCore::defaultCookieJar):
        (WebCore::setCookies):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::prepareForURL):
        (WebCore::restartedCallback):
        (WebCore::startHttp):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-19 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 19 Oct 2010 07:15:07 +0000 (07:15 +0000)]
2010-10-19  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Fix distcheck, take 2.

        * GNUmakefile.am: also move the generated CSS hash files to the
        build dir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 19 Oct 2010 06:54:17 +0000 (06:54 +0000)]
2010-10-18  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed.

        Re-enabled editing/execCommand/remove-formatting.html and editing/execCommand/remove-formatting-2.html on Qt platforms.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 19 Oct 2010 06:34:20 +0000 (06:34 +0000)]
2010-10-18  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        dump-as-markup conversion: editing/execCommand/remove-formatting.html and remove-formatting-2.html
        https://bugs.webkit.org/show_bug.cgi?id=47792

        Converted editing/execCommand/remove-formatting.html and remove-formatting-2.html to dump-as-markup tests.

        * editing/execCommand/remove-formatting-2-expected.txt: Added.
        * editing/execCommand/remove-formatting-2.html:
        * editing/execCommand/remove-formatting-expected.txt: Added.
        * editing/execCommand/remove-formatting.html:
        * platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
        * platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.png: Removed.
        * platform/chromium-linux/editing/execCommand/remove-formatting-expected.checksum: Removed.
        * platform/chromium-linux/editing/execCommand/remove-formatting-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
        * platform/chromium-win/editing/execCommand/remove-formatting-2-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/remove-formatting-2-expected.txt: Removed.
        * platform/chromium-win/editing/execCommand/remove-formatting-expected.checksum: Removed.
        * platform/chromium-win/editing/execCommand/remove-formatting-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/remove-formatting-expected.txt: Removed.
        * platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
        * platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.png: Removed.
        * platform/mac-leopard/editing/execCommand/remove-formatting-expected.checksum: Removed.
        * platform/mac-leopard/editing/execCommand/remove-formatting-expected.png: Removed.
        * platform/mac/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
        * platform/mac/editing/execCommand/remove-formatting-2-expected.png: Removed.
        * platform/mac/editing/execCommand/remove-formatting-2-expected.txt: Removed.
        * platform/mac/editing/execCommand/remove-formatting-expected.checksum: Removed.
        * platform/mac/editing/execCommand/remove-formatting-expected.png: Removed.
        * platform/mac/editing/execCommand/remove-formatting-expected.txt: Removed.
        * platform/qt/editing/execCommand/remove-formatting-2-expected.txt: Removed.
        * platform/qt/editing/execCommand/remove-formatting-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue@webkit.org [Tue, 19 Oct 2010 05:37:04 +0000 (05:37 +0000)]
2010-10-18  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Export QWebPage::ViewportAttributes class.
        https://bugs.webkit.org/show_bug.cgi?id=47845

        * Api/qwebpage.h:
        * symbian/eabi/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 05:36:59 +0000 (05:36 +0000)]
2010-10-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add Chromium Mac EWS to the list of queues at queues.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=47878

        * QueueStatusServer/model/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 05:35:14 +0000 (05:35 +0000)]
2010-10-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        queues.webkit.org/next_patch is always 404
        https://bugs.webkit.org/show_bug.cgi?id=47881

        With the addition of the Queue class, I changed most of the
        code to lookup WorkItems using get_or_insert with a key_name
        instead of WorkItems.all().filter(queue_name=).
        Because the new get_or_insert code uses an explicit key_name
        (which is obviously different from the previously autogenerated
        ones), there were new WorkItem records created for each queue.
        However, some parts of the code still use WorkItems.all().filter,
        thus some parts were getting the new record and some parts the old record.

        The same basic bug was occurring with ActiveWorkItems, because I
        changed the key_name for that class as well.

        To fix this I've moved more of the code over to using Queue.*work_items.
        I've also enabled the datastore_admin (new in GAE 1.3.8) so that
        we can go delete the old WorkItems records.
        I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).

        * QueueStatusServer/app.yaml:
        * QueueStatusServer/handlers/queuestatus.py:
        * QueueStatusServer/handlers/recentstatus.py:
        * QueueStatusServer/handlers/updatestatus.py:
        * QueueStatusServer/handlers/updateworkitems.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 19 Oct 2010 05:33:57 +0000 (05:33 +0000)]
2010-10-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Should not save state of a detached form control.
        https://bugs.webkit.org/show_bug.cgi?id=47811

        * fast/forms/state-save-of-detached-control-expected.txt: Added.
        * fast/forms/state-save-of-detached-control.html: Added.
2010-10-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Should not save state of a detached form control.
        https://bugs.webkit.org/show_bug.cgi?id=47811

        Test: fast/forms/state-save-of-detached-control.html

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState):
          If the node is detached, don't save the state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 19 Oct 2010 04:55:09 +0000 (04:55 +0000)]
2010-10-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Bump version numbers for 1.3.5 release.

        * configure.ac:

WebCore:

2010-10-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        * GNUmakefile.am: add missing files.

WebKit/gtk:

2010-10-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        * NEWS: update for 1.3.5 release.
        * docs/webkitgtk-sections.txt: add new APIs.

JavaScriptCore:

2010-10-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        * GNUmakefile.am: add missing file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 04:48:23 +0000 (04:48 +0000)]
2010-10-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Correct a bunch of typos in QueueStatusServer
        https://bugs.webkit.org/show_bug.cgi?id=47880

        These are all due to our complete lack of unit testing in QueueStatusServer.
        I added a couple unit tests to cover a few of these fixes, but most of these
        are still only caught by actually running the application.

        * QueueStatusServer/handlers/nextpatch.py:
        * QueueStatusServer/handlers/statusbubble.py:
        * QueueStatusServer/handlers/statusbubble_unittest.py: Added.
        * QueueStatusServer/handlers/updateworkitems.py:
        * QueueStatusServer/model/attachment.py:
        * QueueStatusServer/model/queuepropertymixin.py:
        * QueueStatusServer/model/queuepropertymixin_unittest.py:
        * QueueStatusServer/model/workitems.py:
        * QueueStatusServer/model/workitems_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 19 Oct 2010 04:25:10 +0000 (04:25 +0000)]
2010-10-18  Adam Barth  <abarth@webkit.org>

        Disable this test because it's failing on the bots and the authors
        aren't around to fix it.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 19 Oct 2010 04:11:01 +0000 (04:11 +0000)]
2010-10-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CC authors of flaky tests when the commit-queue hits a flaky test
        https://bugs.webkit.org/show_bug.cgi?id=47872

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 04:05:11 +0000 (04:05 +0000)]
2010-10-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make it possible to run a chromium-mac-ews builder
        https://bugs.webkit.org/show_bug.cgi?id=47876

        Since we can't run Mac OS X in a VM, we need to only run committer patches.
        There was a multiple inheritance problem which was holding this patch back,
        but I decided to just ignore the problem and go with a functional hack for now.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 19 Oct 2010 03:22:04 +0000 (03:22 +0000)]
2010-10-18  Kenneth Russell  <kbr@google.com>

        Reviewed by Tony Chang.

        Regression in run_webkit_tests_unittest from r70017
        https://bugs.webkit.org/show_bug.cgi?id=47875

        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 19 Oct 2010 02:44:21 +0000 (02:44 +0000)]
2010-10-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement webkit-patch suggest-reviewers
        https://bugs.webkit.org/show_bug.cgi?id=47866

        * Scripts/webkitpy/common/checkout/api.py:
            - The main logic.  We look at the last five changes to each
              modified (non-ChangeLog) file and collect up the reviewers of
              those changes as well as the authors of those changes who are
              reviewers.
        * Scripts/webkitpy/common/checkout/api_unittest.py:
            - Test the logic with some fun mocks.
        * Scripts/webkitpy/common/checkout/scm.py:
            - Fix a bug when you have local git commits.
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
            - Test that the bug is fixed.
        * Scripts/webkitpy/tool/commands/queries.py:
            - Add the query.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Kenneth Russell <kbr@google.com>
eric@webkit.org [Tue, 19 Oct 2010 02:37:49 +0000 (02:37 +0000)]
2010-10-18  Kenneth Russell  <kbr@google.com>

        Reviewed by Eric Seidel.

        new-run-webkit-tests produces corrupt PNG baselines on Windows
        https://bugs.webkit.org/show_bug.cgi?id=47867

        * Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 19 Oct 2010 02:33:33 +0000 (02:33 +0000)]
2010-10-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION: Feedly extension crashes Webkit
        https://bugs.webkit.org/show_bug.cgi?id=45811

        Make test cover large number of properties/string pairs, at two offsets to get the
        new allocation to occur at different locations.

        * fast/dom/Window/window-postmessage-clone-expected.txt:
        * fast/dom/Window/window-postmessage-clone.html:
2010-10-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION: Feedly extension crashes Webkit
        https://bugs.webkit.org/show_bug.cgi?id=45811

        The basic problem was the deserializer was holding a pointer into
        the constant pool, but if you were sufficiently unlucky then the
        constant pool would be moved while still relying on the pointer,
        which leads to badness.

        I looked at just making all the sites this could happen extract the
        right string/jsstring before any possible allocations, but it seemed
        too fragile so i've gone for a forwarding object as the solution.

        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::CloneDeserializer::CachedStringRef::CachedStringRef):
        (WebCore::CloneDeserializer::CachedStringRef::operator->):
        (WebCore::CloneDeserializer::readStringData):
        (WebCore::CloneDeserializer::readFile):
        (WebCore::CloneDeserializer::readTerminal):
        (WebCore::CloneDeserializer::deserialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 19 Oct 2010 02:32:09 +0000 (02:32 +0000)]
2010-10-18  Kenneth Russell  <kbr@google.com>

        Reviewed by Eric Seidel.

        new-run-webkit-tests produces corrupt PNG baselines on Windows
        https://bugs.webkit.org/show_bug.cgi?id=47867

        * Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Oct 2010 02:13:19 +0000 (02:13 +0000)]
2010-10-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Deploy Queue class in more places throughout QueueStatusServer
        https://bugs.webkit.org/show_bug.cgi?id=47855

        I also caught two typos from the previous change.  Unfortunately
        I don't yet know how to unittest request handlers yet.

        * QueueStatusServer/handlers/dashboard.py:
        * QueueStatusServer/handlers/statusbubble.py:
        * QueueStatusServer/handlers/updateworkitems.py:
        * QueueStatusServer/model/activeworkitems.py:
        * QueueStatusServer/model/attachment.py:
        * QueueStatusServer/model/queuepropertymixin.py: Added.
        * QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
        * QueueStatusServer/model/queuestatus.py:
        * QueueStatusServer/model/workitems.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Chris Rogers <crogers@google.com>
crogers@google.com [Tue, 19 Oct 2010 01:59:09 +0000 (01:59 +0000)]
2010-10-18  Chris Rogers  <crogers@google.com>

        Reviewed by Chris Fleizach.

        Add AudioResampler files
        https://bugs.webkit.org/show_bug.cgi?id=47623

        No new tests since audio API is not yet implemented.

        * platform/audio/AudioResampler.cpp: Added.
        (WebCore::AudioResampler::AudioResampler):
        (WebCore::AudioResampler::configureChannels):
        (WebCore::AudioResampler::process):
        (WebCore::AudioResampler::setRate):
        (WebCore::AudioResampler::reset):
        * platform/audio/AudioResampler.h: Added.
        (WebCore::AudioResampler::~AudioResampler):
        (WebCore::AudioResampler::rate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 19 Oct 2010 01:38:00 +0000 (01:38 +0000)]
2010-10-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        scm.py should be able tell us what revisions made changes to a given file
        https://bugs.webkit.org/show_bug.cgi?id=47863

        Look again, your SCM.py can now log files.

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 19 Oct 2010 01:02:35 +0000 (01:02 +0000)]
2010-10-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Siedel.

        new-run-webkit-tests: clean up the options-parsing code in the port
        classes.

        This change modifies the Port interface to have a get_option() and
        set_option_default() method for accessing the options argument
        passed to the constructor. If the constructor is not passed an
        options argument, we default to a MockOptions() argument from
        mocktool, which has the same semantics we want.

        Note that there is a disadvantage to port.get_option('foo') over
        port._options.foo, which is that you lose some of the checking
        for whether 'foo' is set (typos result in the default value, not
        an exception being raised. This is desired in this case, since the
        Port class is not allowed to assume that options does have any
        particular values set, and so this change ensures that all of
        the subclasses are following the same, intended, logic.

        Arguably this is the wrong semantics to have, and the Port
        classes should be able to assume a default set of
        attributes/arguments, but that change will need to wait for a
        different CL where we can modify new-run-webkit-tests to pull a
        list of arguments from the port factory routines.

        Also, add unit tests for webkitpy.tool.mocktool.MockOptions .

        https://bugs.webkit.org/show_bug.cgi?id=47510

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
        * Scripts/webkitpy/tool/mocktool_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 19 Oct 2010 00:40:58 +0000 (00:40 +0000)]
2010-10-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Re-submit a revised version of r69638 - enabling new-run-webkit-tests
        under cygwin. The initial version had a bug in base:uri_to_test_name
        that was causing tests to fail. This version corrects that bug, but
        also makes the code safer by calling cygpath more reliably, and
        leaving a long-running cygpath process open.

        This patch also corrects a couple of minor bugs in http_lock_unittest,
        chromium_unittest, and dedpulicate_tests_unittest that showed up
        while testing this.

        https://bugs.webkit.org/show_bug.cgi?id=47220

        * Scripts/webkitpy/common/system/path.py:
        * Scripts/webkitpy/common/system/path_unittest.py:
        * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 19 Oct 2010 00:06:10 +0000 (00:06 +0000)]
2010-10-18  James Robinson  <jamesr@chromium.org>

        Update chromium test expectations

        * platform/chromium-linux/svg/custom/text-linking-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/svg/custom/text-linking-expected.txt.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Mon, 18 Oct 2010 23:53:10 +0000 (23:53 +0000)]
2010-10-18  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Prevent the creation of very large textures for layers by switching
        to "large layer" mode when a texture is larger than some fixed reasonable size
        (set to 2000 pixels for now).
        https://bugs.webkit.org/show_bug.cgi?id=47751

        The code also changes the large layer logic to use the current scissor rect used
        by the compositor instead of the visible rect to determine how to clip large layers.
        This will provide additional texture savings. In addition, the various layer rects
        have been converted to use integers instead of floats to preserve uniformity in the code.

        Tests: Existing large layer layout tests including huge-layer and huge-layer-img

        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::requiresClippedUpdateRect):
        (WebCore::ContentLayerChromium::calculateClippedUpdateRect):
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::getDrawRect):
        * platform/graphics/chromium/LayerChromium.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::drawLayersRecursive):
        (WebCore::LayerRendererChromium::scissorToRect):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::currentScissorRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 18 Oct 2010 23:38:37 +0000 (23:38 +0000)]
2010-10-18  James Robinson  <jamesr@chromium.org>

        Move chromium xp specific baselines to right place.

        * platform/chromium-win-xp/svg/custom/text-linking-expected.checksum:
        * platform/chromium-win-xp/svg/custom/text-linking-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/custom/text-linking-expected.png.
        * platform/chromium-win-xp/svg/custom/text-linking-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/custom/text-linking-expected.txt.
        * platform/chromium-win/svg/custom/text-linking-expected.checksum: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 18 Oct 2010 23:28:58 +0000 (23:28 +0000)]
2010-10-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        Strict mode: Functions created with the function constructor don't implement strict mode semantics
        https://bugs.webkit.org/show_bug.cgi?id=47860

        When creating the FunctionExecutable for a new function the function constructor
        was always passing false for whether or not a function was strict, rather than
        using the information from the freshly parsed function itself.

        * runtime/Executable.cpp:
        (JSC::FunctionExecutable::fromGlobalCode):
2010-10-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        Strict mode: Functions created with the function constructor don't implement strict mode semantics
        https://bugs.webkit.org/show_bug.cgi?id=47860

        Test that the function constructor produces correct strict mode functions.

        * fast/js/basic-strict-mode-expected.txt:
        * fast/js/script-tests/basic-strict-mode.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoInitialize the API client.
andersca@apple.com [Mon, 18 Oct 2010 23:21:25 +0000 (23:21 +0000)]
Initialize the API client.

Reviewed by Sam Weinig.

* Shared/APIClient.h:
(WebKit::APIClient::APIClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 18 Oct 2010 23:08:33 +0000 (23:08 +0000)]
2010-10-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add Queue class and add minimal unittesting of QueueStatusServer code
        https://bugs.webkit.org/show_bug.cgi?id=47847

        * QueueStatusServer/handlers/dashboard.py:
        * QueueStatusServer/handlers/queuestatus.py:
        * QueueStatusServer/handlers/recentstatus.py:
        * QueueStatusServer/handlers/statusbubble.py:
        * QueueStatusServer/handlers/updateworkitems.py:
        * QueueStatusServer/model/attachment.py:
        * QueueStatusServer/model/queues.py:
        * QueueStatusServer/model/queues_unittest.py: Added.
        * QueueStatusServer/model/svnrevision.py:
        * Scripts/test-webkitpy:
        * Scripts/webkitpy/test/main.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 18 Oct 2010 22:44:03 +0000 (22:44 +0000)]
2010-10-18  James Robinson  <jamesr@chromium.org>

        Mark flaky SVG tests as flaky in chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit2 should handle dismissing the Find overlay on mouse-down
andersca@apple.com [Mon, 18 Oct 2010 22:40:38 +0000 (22:40 +0000)]
WebKit2 should handle dismissing the Find overlay on mouse-down
https://bugs.webkit.org/show_bug.cgi?id=47854

Reviewed by John Sullivan.

* WebProcess/WebPage/FindPageOverlay.cpp:
(WebKit::FindPageOverlay::mouseEvent):
Dismiss the find UI on MouseDown.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEvent):
If there's a page overlay, let it have a go at the event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Mon, 18 Oct 2010 22:29:33 +0000 (22:29 +0000)]
2010-10-18  Jia Pu  <jpu@apple.com>

        Reviewed by Stephanie Lewis.

        Correct the description of manual test: autocorrection-cancelled-by-typing-1.html
        https://bugs.webkit.org/show_bug.cgi?id=47722
        <rdar://problem/8556206>

        * manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Update description
          to match the test content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 18 Oct 2010 22:19:54 +0000 (22:19 +0000)]
2010-10-18  Mihai Parparita  <mihaip@chromium.org>

        Group Chromium DRT media test failures and add media/video-src.html,
        which became flaky around r68970.

        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix clang build.
andersca@apple.com [Mon, 18 Oct 2010 22:14:08 +0000 (22:14 +0000)]
Fix clang build.

* UIProcess/API/mac/FindIndicatorWindow.mm:
(-[WebFindIndicatorWindowAnimation _initWithFindIndicatorWindow:WebKit::animationProgressCallback:WebKit::FindIndicatorWindow::animationDidEndCallback:WebKit::FindIndicatorWindow::]):
(WebKit::FindIndicatorWindow::setFindIndicator):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPopupMenuProxy.h:
* WebProcess/WebCoreSupport/WebPopupMenu.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago70,000!
beidson@apple.com [Mon, 18 Oct 2010 22:13:10 +0000 (22:13 +0000)]
70,000!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Qt build.
weinig@apple.com [Mon, 18 Oct 2010 22:11:04 +0000 (22:11 +0000)]
Fix Qt build.

* WebKit2.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 18 Oct 2010 22:02:05 +0000 (22:02 +0000)]
2010-10-18  Martin Robinson  <mrobinson@igalia.com>

        Build fix for newer versions of GTK+ 2.0. Instead of using GDK_DISPLAY()
        use GDK_DRAWABLE_XDISPLAY(gdk_display_get_default()). GDK_DISPLAY() was
        recently deprecated and the latter method has been available since GTK+
        2.2.

        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::paint):
        (WebCore::PluginView::initXEvent):
        (WebCore::PluginView::platformGetValue):
        (WebCore::getVisualAndColormap):
        (WebCore::PluginView::platformStart):
        (WebCore::PluginView::platformDestroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't try to change accelerated compositing mode if the web page is closed
andersca@apple.com [Mon, 18 Oct 2010 21:55:21 +0000 (21:55 +0000)]
Don't try to change accelerated compositing mode if the web page is closed
https://bugs.webkit.org/show_bug.cgi?id=47852

Reviewed by Simon Fraser.

changeAcceleratedCompositingMode ends up sending a sync message to the UI process which is unnecessary if
the UI process is being torn down.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::changeAcceleratedCompositingMode):
(WebKit::WebPage::close):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Adrienne Walker <enne@google.com>
commit-queue@webkit.org [Mon, 18 Oct 2010 21:53:57 +0000 (21:53 +0000)]
2010-10-18  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        Update context attribute conformance test from updated Khronos source.
        https://bugs.webkit.org/show_bug.cgi?id=47697

        * fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
        * fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
        * platform/chromium/test_expectations.txt:
2010-10-18  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        Turn off antialiasing when using Mesa during testing.
        https://bugs.webkit.org/show_bug.cgi?id=47697

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 18 Oct 2010 21:42:37 +0000 (21:42 +0000)]
2010-10-18  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        elementCannotHaveEndTag should be a member function of MarkupAccumulator
        https://bugs.webkit.org/show_bug.cgi?id=47846

        Moved elementCannotHaveEndTag into MarkupAccumulator.

        No new tests are added since this is a cleanup.

        * editing/MarkupAccumulator.cpp:
        (WebCore::MarkupAccumulator::elementCannotHaveEndTag): Added.
        * editing/MarkupAccumulator.h: Added MarkupAccumulator::elementCannotHaveEndTag.
        * editing/markup.cpp: Removed elementCannotHaveEndTag.
        * editing/markup.h: Removed elementCannotHaveEndTag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 18 Oct 2010 21:41:13 +0000 (21:41 +0000)]
2010-10-18  James Robinson  <jamesr@chromium.org>

        Update the chromium DEPS from 62399 to 62813 to pick up skia fixes

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/8036034>
andersca@apple.com [Mon, 18 Oct 2010 21:28:01 +0000 (21:28 +0000)]
<rdar://problem/8036034>
WebKit2's WebProcess dies immediately on Mac due to DYLD_FRAMEWORK_PATH problem

Reviewed by Sam Weinig.

Pass the path to the WebKit2 framework along to the web process and don't rely on DYLD_FRAMEWORK_PATH being set.

* Shared/mac/CommandLineMac.cpp:
(WebKit::CommandLine::parse):
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
* mac/MainMac.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNeed a WebKit2 equivalent of the WebKit1 WebUserContentURLPattern.
jberlin@webkit.org [Mon, 18 Oct 2010 21:24:22 +0000 (21:24 +0000)]
Need a WebKit2 equivalent of the WebKit1 WebUserContentURLPattern.
https://bugs.webkit.org/show_bug.cgi?id=47783

Reviewed by Sam Weinig.

* Shared/API/c/WKBase.h:

* Shared/API/c/WKSharedAPICast.h:

* Shared/API/c/WKUserContentURLPattern.cpp: Added.
(WKUserContentURLPatternGetTypeID):
(WKUserContentURLPatternCreate):
(WKUserContentURLPatternMatchesURL):
* Shared/API/c/WKUserContentURLPattern.h: Added.

* Shared/APIObject.h:

* Shared/UserMessageCoders.h:
Use the original pattern string to encode and decode a UserContentURLPattern.
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

* Shared/WebUserContentURLPattern.h: Added.
(WebKit::WebUserContentURLPattern::create):
(WebKit::WebUserContentURLPattern::matchesURL):
Use WebCore::UserContentURLPattern::matches.
(WebKit::WebUserContentURLPattern::patternString):
Expose the pattern string used to create the UserContentURLPattern for the purpose of
encoding and decoding.
(WebKit::WebUserContentURLPattern::WebUserContentURLPattern):
(WebKit::WebUserContentURLPattern::type):

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add WKUserContentURLPattern.h/.cpp and WebUserContentURLPattern.h

* win/WebKit2Generated.make:
Copy over WKUsercontentURLPattern into the output directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Johnny Ding <jnd@chromium.org>
inferno@chromium.org [Mon, 18 Oct 2010 21:15:11 +0000 (21:15 +0000)]
2010-10-18  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        Set the right referent sourceURL for the script with force user gesture.
        https://bugs.webkit.org/show_bug.cgi?id=37138

        Because empty sourceURL indicates running script with force user gesture,
        make WebKit use document.url() as referent sourceURL (Since it uses blank
        URL instead empty if the input URL is empty) if WebKit isn't running the
        script from a hyper-link.

        Test: fast/events/popup-blocked-from-window-open.html

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeScript):
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::executeScriptInWorld):
2010-10-18  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        Set the right referent sourceURL for the script with force user gesture.
        https://bugs.webkit.org/show_bug.cgi?id=37138

        * fast/events/popup-blocked-from-window-open-expected.txt: Added.
        * fast/events/popup-blocked-from-window-open.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 18 Oct 2010 21:12:03 +0000 (21:12 +0000)]
2010-10-18  James Robinson  <jamesr@chromium.org>

        Update chromium expectations and baselines.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* dom/Node.h: Fix ancient typo in just-modified comment.
darin@apple.com [Mon, 18 Oct 2010 19:59:09 +0000 (19:59 +0000)]
* dom/Node.h: Fix ancient typo in just-modified comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 18 Oct 2010 19:52:27 +0000 (19:52 +0000)]
2010-10-18  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Remove some functions from class Node and make a few others non-virtual
        https://bugs.webkit.org/show_bug.cgi?id=47735

        Refactoring. No new tests.

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::markChildren): Added a FIXME about the use of the virtual
        ownerDocument function.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::removeChildren): Removed the unused return value.

        * dom/ContainerNode.h: Made insertBefore, replaceChild, removeChild, and
        appendChild non-virtual for clarity and performance. Made removeChildren
        non-virtual and removed its return value. Moved the inline Node functions
        that call through to ContainerNode into this file since the old way involved
        an extra level of inline function but otherwise had no advantages.

        * dom/Element.h: Moved isMathMLElement here because there is no call site
        that needs to call it on a Node*. We can always move it back if we need to,
        but it's better to have less in the Node class.

        * dom/Node.cpp:
        (WebCore::Node::insertBefore): Added an isContainerNode check so this can
        be non-virtual. There are very few callers who call this function on Node.
        If we want to optimize them further we can make the isContainerNode check
        inline in the future.
        (WebCore::Node::replaceChild): Ditto.
        (WebCore::Node::removeChild): Ditto.
        (WebCore::Node::appendChild): Ditto.
        (WebCore::Node::remove): Removed unneeded ref/unref because
        ContainerNode::removeChild already does this.
        (WebCore::Node::createRendererIfNeeded): Removed #if around call to
        childShouldCreateRenderer since it's needed even without SVG and XHTMLMP.

        * dom/Node.h: Moved definitions of inline functions that depend on
        ContainerNode to the ContainerNode.h header. They already required inclusion
        of that header, so there is no functional change. Made insertBefore,
        replaceChild, removeChild, and appendChild non-virtual. There are very few
        callers of these functions on this class. Moved isMathMLElement to Element.
        Added a FIXME about the name of eventAncestors. Fixed comment formatting.
        Eliminated unused isEditableBlock function. Moved the body of the
        enclosingInlineElement function to the editing file that was the only
        call site. Removed the previousEditable and nextEditable functions,
        incorporating their bodies into the one place they were called.
        Took the childShouldCreateRenderer function out of #if since it's
        now used by the implementation of the <noscript> element.

        * dom/Position.cpp:
        (WebCore::nextRenderedEditable): Rewrote the function to use nextLeafNode
        instead of nextEditable.
        (WebCore::previousRenderedEditable): Rewrote the function to use
        previousLeafNode instead of previousEditable.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::enclosingInline): Moved function here from the Node class. Also
        fixed an incorrect cast this function did, which assumed the function
        result was always an element, which the function does not guarantee.
        (WebCore::ReplaceSelectionCommand::doApply): Call the function above.

        * history/HistoryItem.cpp: Added include of MathExtras.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build.
andersca@apple.com [Mon, 18 Oct 2010 19:48:48 +0000 (19:48 +0000)]
Fix build.

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventCarbon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build.
andersca@apple.com [Mon, 18 Oct 2010 19:46:50 +0000 (19:46 +0000)]
Fix build.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformSetFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Yongjun Zhang <yongjun_zhang@apple.com>
commit-queue@webkit.org [Mon, 18 Oct 2010 19:33:58 +0000 (19:33 +0000)]
2010-10-18  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by Darin Adler.

        Missing support for document.createEvent("OrientationEvent")
        https://bugs.webkit.org/show_bug.cgi?id=32492

        Add support for document.createEvent("OrientationEvent") to help unit testing of
        onOrientationChange event.

        * fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt: Added.
        * fast/dom/DeviceOrientation/create-event-onorientationchange.html: Added.
        * fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js: Added.
2010-10-18  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by Darin Adler.

        Missing support for document.createEvent("OrientationEvent")
        https://bugs.webkit.org/show_bug.cgi?id=32492

        Add support for document.createEvent("OrientationEvent") to help unit testing of
        onOrientationChange event.

        Test: fast/dom/DeviceOrientation/create-event-onorientationchange.html

        * dom/Document.cpp:
        (WebCore::Document::createEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 18 Oct 2010 19:15:34 +0000 (19:15 +0000)]
2010-10-18  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.

        DOMStringList should return null if the index is out of range
        https://bugs.webkit.org/show_bug.cgi?id=47829

        Add tests for out of range behavior here since IndexedDB is the only user
        of DOMStringList.

        * storage/indexeddb/database-basics-expected.txt:
        * storage/indexeddb/database-basics.html:
        * storage/indexeddb/objectstore-basics-expected.txt:
        * storage/indexeddb/objectstore-basics.html:
2010-10-18  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.

        DOMStringList should return null if the index is out of range
        https://bugs.webkit.org/show_bug.cgi?id=47829

        When item() returns a null string, it needs to be passed to JS as
        null. The indexed getter will then magically do the right thing.
        So all that's left is having DOMStringList::item() return null when
        the index is out of bounds.

        * dom/DOMStringList.cpp:
        (WebCore::DOMStringList::item):
        * dom/DOMStringList.h:
        * dom/DOMStringList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 18 Oct 2010 19:14:13 +0000 (19:14 +0000)]
2010-10-18  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        dump-as-markup conversion: editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html
        https://bugs.webkit.org/show_bug.cgi?id=47784

        Converted editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html to dump-as-markup tests.

        * editing/execCommand/4920742-1-expected.txt: Added.
        * editing/execCommand/4920742-1.html:
        * editing/execCommand/5049671-expected.txt: Added.
        * editing/execCommand/5049671.html:
        * editing/execCommand/5573879-expected.txt: Added.
        * editing/execCommand/5573879.html:
        * platform/chromium-linux/editing/execCommand/4920742-1-expected.checksum: Removed.
        * platform/chromium-linux/editing/execCommand/4920742-1-expected.png: Removed.
        * platform/chromium-linux/editing/execCommand/5049671-expected.checksum: Removed.
        * platform/chromium-linux/editing/execCommand/5049671-expected.png: Removed.
        * platform/chromium-linux/editing/execCommand/5573879-expected.checksum: Removed.
        * platform/chromium-linux/editing/execCommand/5573879-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/4920742-1-expected.checksum: Removed.
        * platform/chromium-win/editing/execCommand/4920742-1-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/4920742-1-expected.txt: Removed.
        * platform/chromium-win/editing/execCommand/5049671-expected.checksum: Removed.
        * platform/chromium-win/editing/execCommand/5049671-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/5049671-expected.txt: Removed.
        * platform/chromium-win/editing/execCommand/5573879-expected.checksum: Removed.
        * platform/chromium-win/editing/execCommand/5573879-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/5573879-expected.txt: Removed.
        * platform/gtk/editing/execCommand/4920742-1-expected.txt: Removed.
        * platform/gtk/editing/execCommand/5049671-expected.txt: Removed.
        * platform/gtk/editing/execCommand/5573879-expected.txt: Removed.
        * platform/mac-leopard/editing/execCommand/4920742-1-expected.checksum: Removed.
        * platform/mac-leopard/editing/execCommand/4920742-1-expected.png: Removed.
        * platform/mac-leopard/editing/execCommand/5049671-expected.checksum: Removed.
        * platform/mac-leopard/editing/execCommand/5049671-expected.png: Removed.
        * platform/mac/editing/execCommand/4920742-1-expected.checksum: Removed.
        * platform/mac/editing/execCommand/4920742-1-expected.png: Removed.
        * platform/mac/editing/execCommand/4920742-1-expected.txt: Removed.
        * platform/mac/editing/execCommand/5049671-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5049671-expected.png: Removed.
        * platform/mac/editing/execCommand/5049671-expected.txt: Removed.
        * platform/mac/editing/execCommand/5573879-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5573879-expected.png: Removed.
        * platform/mac/editing/execCommand/5573879-expected.txt: Removed.
        * platform/qt/editing/execCommand/4920742-1-expected.txt: Removed.
        * platform/qt/editing/execCommand/5049671-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Implement Accelerated Composition for NPAPI Plugins.
girish@forwardbias.in [Mon, 18 Oct 2010 19:13:56 +0000 (19:13 +0000)]
[Qt] Implement Accelerated Composition for NPAPI Plugins.

Reviewed by Ariya Hidayat.

https://bugs.webkit.org/show_bug.cgi?id=35524

* plugins/PluginView.h:
(WebCore::PluginView::platformLayer):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::paint):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::invalidateRegion):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 18 Oct 2010 18:54:46 +0000 (18:54 +0000)]
2010-10-18  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        dump-as-markup conversion: editing/execCommand/4786404-1.html, 4786404-2.html, 4920488.html
        https://bugs.webkit.org/show_bug.cgi?id=47782

        Converted editing/execCommand/4786404-1.html, 4786404-2.html, 4920488.html to dump-as-markup tests.

        * editing/execCommand/4786404-1-expected.txt: Added.
        * editing/execCommand/4786404-1.html:
        * editing/execCommand/4786404-2-expected.txt: Added.
        * editing/execCommand/4786404-2.html:
        * editing/execCommand/4920488-expected.txt: Added.
        * editing/execCommand/4920488.html:
        * platform/chromium-linux/editing/execCommand/4786404-1-expected.checksum: Removed.
        * platform/chromium-linux/editing/execCommand/4786404-1-expected.png: Removed.
        * platform/chromium-linux/editing/execCommand/4786404-2-expected.checksum: Removed.
        * platform/chromium-linux/editing/execCommand/4786404-2-expected.png: Removed.
        * platform/chromium-linux/editing/execCommand/4920488-expected.checksum: Removed.
        * platform/chromium-linux/editing/execCommand/4920488-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/4786404-1-expected.checksum: Removed.
        * platform/chromium-win/editing/execCommand/4786404-1-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/4786404-1-expected.txt: Removed.
        * platform/chromium-win/editing/execCommand/4786404-2-expected.checksum: Removed.
        * platform/chromium-win/editing/execCommand/4786404-2-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/4786404-2-expected.txt: Removed.
        * platform/chromium-win/editing/execCommand/4920488-expected.checksum: Removed.
        * platform/chromium-win/editing/execCommand/4920488-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/4920488-expected.txt: Removed.
        * platform/gtk/editing/execCommand/4786404-1-expected.txt: Removed.
        * platform/gtk/editing/execCommand/4786404-2-expected.txt: Removed.
        * platform/gtk/editing/execCommand/4920488-expected.txt: Removed.
        * platform/mac-leopard/editing/execCommand/4786404-2-expected.checksum: Removed.
        * platform/mac-leopard/editing/execCommand/4786404-2-expected.png: Removed.
        * platform/mac-leopard/editing/execCommand/4920488-expected.checksum: Removed.
        * platform/mac-leopard/editing/execCommand/4920488-expected.png: Removed.
        * platform/mac/editing/execCommand/4786404-1-expected.checksum: Removed.
        * platform/mac/editing/execCommand/4786404-1-expected.png: Removed.
        * platform/mac/editing/execCommand/4786404-1-expected.txt: Removed.
        * platform/mac/editing/execCommand/4786404-2-expected.checksum: Removed.
        * platform/mac/editing/execCommand/4786404-2-expected.png: Removed.
        * platform/mac/editing/execCommand/4786404-2-expected.txt: Removed.
        * platform/mac/editing/execCommand/4920488-expected.checksum: Removed.
        * platform/mac/editing/execCommand/4920488-expected.png: Removed.
        * platform/mac/editing/execCommand/4920488-expected.txt: Removed.
        * platform/qt/editing/execCommand/4786404-1-expected.txt: Removed.
        * platform/qt/editing/execCommand/4786404-2-expected.txt: Removed.
        * platform/qt/editing/execCommand/4920488-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
commit-queue@webkit.org [Mon, 18 Oct 2010 18:54:06 +0000 (18:54 +0000)]
2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Eric Seidel.

        Switch to using the new Carbon NPAPI event declarations, and remove
        the old ones.

        https://bugs.webkit.org/show_bug.cgi?id=40784

        * bridge/npapi.h:
        * plugins/mac/PluginViewMac.mm:
        (WebCore::PluginView::setFocus):
        (WebCore::PluginView::handleMouseEvent):
2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Eric Seidel.

        Switch to using the new Carbon NPAPI event declarations, and remove
        the old ones.

        https://bugs.webkit.org/show_bug.cgi?id=40784

        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        (WebNetscapePluginEventHandlerCarbon::mouseEntered):
        (WebNetscapePluginEventHandlerCarbon::mouseExited):
        (WebNetscapePluginEventHandlerCarbon::mouseMoved):
        (WebNetscapePluginEventHandlerCarbon::focusChanged):
2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Eric Seidel.

        Switch to using the new Carbon NPAPI event declarations, and remove
        the old ones.

        https://bugs.webkit.org/show_bug.cgi?id=40784

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (handleEventCarbon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd matchCountDidChange callback
andersca@apple.com [Mon, 18 Oct 2010 18:46:51 +0000 (18:46 +0000)]
Add matchCountDidChange callback
https://bugs.webkit.org/show_bug.cgi?id=47840

Reviewed by Darin Adler.

* UIProcess/API/C/WKPage.h:
Add matchCountDidChange WKPageFindClient callback.

* UIProcess/WebFindClient.cpp:
(WebKit::WebFindClient::matchCountDidChange):
Call the WKPageFindClient callback.

* UIProcess/WebPageProxy.messages.in:
Add MatchCountDidChange message.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):
Move code here from WebPage.

(WebKit::FindController::findString):
Send the MatchCountDidChange message.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::countStringMatches):
Move this code over to FindController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 18 Oct 2010 18:32:39 +0000 (18:32 +0000)]
2010-10-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        Strict mode: |this| should be undefined if it is not explicitly provided
        https://bugs.webkit.org/show_bug.cgi?id=47833

        To make strict mode behave correctly we want to pass undefined instead of null
        as the default this value.  This has no impact on behaviour outside of strict
        mode as both values are replaced with the global object if necessary.

        * bytecompiler/NodesCodegen.cpp:
        (JSC::FunctionCallValueNode::emitBytecode):
        (JSC::FunctionCallResolveNode::emitBytecode):
        (JSC::CallFunctionCallDotNode::emitBytecode):
        (JSC::ApplyFunctionCallDotNode::emitBytecode):

2010-10-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        Strict mode: |this| should be undefined if it is not explicitly provided
        https://bugs.webkit.org/show_bug.cgi?id=47833

        Add tests to ensure that |this| is undefined rather than null when it has
        not been explicitly provided.

        * fast/js/basic-strict-mode-expected.txt:
        * fast/js/script-tests/basic-strict-mode.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 18 Oct 2010 18:17:28 +0000 (18:17 +0000)]
2010-10-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: comment out resource manager instantiation on front-end side.
        https://bugs.webkit.org/show_bug.cgi?id=47823

        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Robert Hogan <robert@webkit.org>
robert@webkit.org [Mon, 18 Oct 2010 18:08:10 +0000 (18:08 +0000)]
2010-10-18  Robert Hogan  <robert@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        Unskip:
         http/tests/navigation/no-referrer-reset.html
         http/tests/navigation/no-referrer-target-blank.html

        These tests now pass.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Andrei Popescu <andreip@google.com>
andreip@google.com [Mon, 18 Oct 2010 18:04:52 +0000 (18:04 +0000)]
2010-10-18  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        The description parameter of IDBFactory::open() should be mandatory.
        https://bugs.webkit.org/show_bug.cgi?id=47835

        * storage/indexeddb/basics-expected.txt:
        * storage/indexeddb/basics.html:
2010-10-18  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        The description parameter of IDBFactory::open() should be mandatory.
        https://bugs.webkit.org/show_bug.cgi?id=47835

        Makes the description parameter mandatory, as per the IndexedDatabase specification.
        Modified existing tests to cover this change.

        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::extractMetaData):
        (WebCore::setMetaData):
        (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
        * storage/IDBFactory.cpp:
        (WebCore::IDBFactory::open):
        * storage/IDBFactory.h:
        * storage/IDBFactory.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUse nullptr instead of 0.
andersca@apple.com [Mon, 18 Oct 2010 18:02:24 +0000 (18:02 +0000)]
Use nullptr instead of 0.

Reviewed by Darin Adler.

* UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::closeWindow):
* UIProcess/API/mac/WKView.mm:
(-[WKView renewGState]):
* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::removePluginProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Mon, 18 Oct 2010 17:41:19 +0000 (17:41 +0000)]
2010-10-18  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Levin.

        Code cleanup: Move most function members in TextRunWorker from inlined.
        https://bugs.webkit.org/show_bug.cgi?id=47732

        No functionality change, so no tests added.

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::setWordSpacingAdjustment):
        (WebCore::TextRunWalker::setLetterSpacingAdjustment):
        (WebCore::TextRunWalker::setXOffsetToZero):
        (WebCore::TextRunWalker::rtl):
        (WebCore::TextRunWalker::glyphs):
        (WebCore::TextRunWalker::length):
        (WebCore::TextRunWalker::xPositions):
        (WebCore::TextRunWalker::advances):
        (WebCore::TextRunWalker::width):
        (WebCore::TextRunWalker::logClusters):
        (WebCore::TextRunWalker::numCodePoints):
        (WebCore::TextRunWalker::fontPlatformDataForScriptRun):
        (WebCore::TextRunWalker::isCodepointSpace):
        (WebCore::TextRunWalker::TextRunWalker):
        (WebCore::TextRunWalker::~TextRunWalker):
        (WebCore::TextRunWalker::isWordBreak):
        (WebCore::TextRunWalker::setPadding):
        (WebCore::TextRunWalker::reset):
        (WebCore::TextRunWalker::setBackwardsIteration):
        (WebCore::TextRunWalker::nextScriptRun):
        (WebCore::TextRunWalker::widthOfFullRun):
        (WebCore::TextRunWalker::getTextRun):
        (WebCore::TextRunWalker::getNormalizedTextRun):
        (WebCore::TextRunWalker::setupFontForScriptRun):
        (WebCore::TextRunWalker::allocHarfbuzzFont):
        (WebCore::TextRunWalker::deleteGlyphArrays):
        (WebCore::TextRunWalker::createGlyphArrays):
        (WebCore::TextRunWalker::resetGlyphArrays):
        (WebCore::TextRunWalker::shapeGlyphs):
        (WebCore::TextRunWalker::setGlyphXPositions):
        (WebCore::TextRunWalker::mirrorCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 18 Oct 2010 17:27:44 +0000 (17:27 +0000)]
2010-10-18  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] AC rendering bugs
        There were a few missing connections in Qt AC between GraphicsLayer and plugins, like changing the plugin's geometry to the layer's
        contentsRect, and making sure media layers handle ParentChange events and setContentsNeedsDisplay. Now media layers behave correctly.

        https://bugs.webkit.org/show_bug.cgi?id=47571

        No new tests. This is in preparation for fixing AC+plugins, which already has tests that don't work yet with Qt.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::flushChanges):
        (WebCore::GraphicsLayerQt::setContentsNeedsDisplay):
        * platform/graphics/qt/GraphicsLayerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 18 Oct 2010 17:23:53 +0000 (17:23 +0000)]
2010-10-18  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Make a nullptr that works with OwnPtr and RefPtr
        https://bugs.webkit.org/show_bug.cgi?id=47756

        * JavaScriptCore.xcodeproj/project.pbxproj: Added NullPtr.h.

        * wtf/NullPtr.h: Added.

        * wtf/OwnArrayPtr.h: Add an overload of = taking nullptr.
        * wtf/OwnPtr.h: Ditto.
        * wtf/PassOwnArrayPtr.h: Ditto.
        * wtf/PassOwnPtr.h: Ditto.
        * wtf/PassRefPtr.h: Ditto.
        * wtf/RefPtr.h: Ditto.
        * wtf/RetainPtr.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 18 Oct 2010 17:21:37 +0000 (17:21 +0000)]
2010-10-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: disable private browsing for inspector
        https://bugs.webkit.org/show_bug.cgi?id=47827

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController init]):
2010-10-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: disable private browsing for inspector
        https://bugs.webkit.org/show_bug.cgi?id=47827

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::openInspectorFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 18 Oct 2010 17:08:57 +0000 (17:08 +0000)]
2010-10-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Simon Fraser.

        Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
        https://bugs.webkit.org/show_bug.cgi?id=46224

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/InspectorClient.cpp: Added.
        (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
        * inspector/InspectorClient.h:
        (WebCore::InspectorClient::InspectorClient):
2010-10-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Simon Fraser.

        Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
        https://bugs.webkit.org/show_bug.cgi?id=46224

        * WebCoreSupport/WebInspectorClientCF.cpp:
        (WebInspectorClient::sendMessageToFrontend):
2010-10-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Simon Fraser.

        Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
        https://bugs.webkit.org/show_bug.cgi?id=46224

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::sendMessageToFrontend):
2010-10-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Simon Fraser.

        Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
        https://bugs.webkit.org/show_bug.cgi?id=46224

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::sendMessageToFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 18 Oct 2010 17:07:48 +0000 (17:07 +0000)]
2010-10-18  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, skip test failing in the bots, bug opened to check the
        problem: https://bugs.webkit.org/show_bug.cgi?id=47832

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 18 Oct 2010 16:48:07 +0000 (16:48 +0000)]
2010-10-18  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] AC rendering bugs

        This fixes a regression that was introduced by making scrolling in accelerated compositing automatic,
        which made our explicit function to scroll the compositing layers superfluous, making the scrolling behavior
        when graphics layers are present incorrect. The fix simply removes those redundant functions.

        https://bugs.webkit.org/show_bug.cgi?id=47571

        * WebCoreSupport/PageClientQt.cpp:
        (WebCore::PageClientQGraphicsWidget::scroll):
        (WebCore::PageClientQGraphicsWidget::update):
        (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
        * WebCoreSupport/PageClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 18 Oct 2010 16:47:37 +0000 (16:47 +0000)]
2010-10-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        Strict mode: JIT doesn't check for |this| being an immediate before dereferencing
        https://bugs.webkit.org/show_bug.cgi?id=47826

        There's no guarantee that |this| will be a cell in a strict mode function, so
        don't claim that it is.

        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::isKnownNotImmediate):
2010-10-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        Strict mode: JIT doesn't check for |this| being an immediate before dereferencing
        https://bugs.webkit.org/show_bug.cgi?id=47826

        Add tests for accessing properties on |this| when |this| is not an object

        * fast/js/basic-strict-mode-expected.txt:
        * fast/js/script-tests/basic-strict-mode.js:
        (testThisDotAccess):
        (testThisBracketAccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Andrei Popescu <andreip@google.com>
andreip@google.com [Mon, 18 Oct 2010 16:35:27 +0000 (16:35 +0000)]
2010-10-18  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        IDBKeyTree.h is no longer used.
        https://bugs.webkit.org/show_bug.cgi?id=47824

        No new tests, just removing unused files.

        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * storage/IDBKeyTree.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Zoltan Herczeg <zherczeg@webkit.org>
zherczeg@webkit.org [Mon, 18 Oct 2010 16:30:12 +0000 (16:30 +0000)]
2010-10-18  Zoltan Herczeg  <zherczeg@webkit.org>

        Reviewed by Oliver Hunt.

        if (0) throw "x" ; else { } throws parse error after r69906
        https://bugs.webkit.org/show_bug.cgi?id=47807

        r69906 introduced a bug: the semicolon is not parsed after a throw
        expression anymore. Thus, the semicolon terminates the "if" parsing
        in the example above, and the else token results a parse error.

        * parser/JSParser.cpp:
        (JSC::JSParser::parseThrowStatement):
2010-10-18  Zoltan Herczeg  <zherczeg@webkit.org>

        Reviewed by Oliver Hunt.

        if (0) throw "x" ; else { } throws parse error after r69906
        https://bugs.webkit.org/show_bug.cgi?id=47807

        Adding a new test case to break-ASI.js

        * fast/js/break-ASI-expected.txt:
        * fast/js/script-tests/break-ASI.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix the build with MSVC.
jocelyn.turcotte@nokia.com [Mon, 18 Oct 2010 16:16:54 +0000 (16:16 +0000)]
[Qt] Fix the build with MSVC.

Reviewed by nobody, build fix.

Splitting the condition in two to prevent qmake parentheses issues.

* Api/DerivedSources.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Mon, 18 Oct 2010 15:41:14 +0000 (15:41 +0000)]
2010-10-18  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Antonio Gomes.

        [QT] Unable to load pages on QtTestBrowser after canceling a page load.
        https://bugs.webkit.org/show_bug.cgi?id=43827

        * Api/qwebpage.cpp:
        (QWebPage::triggerAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 18 Oct 2010 15:39:27 +0000 (15:39 +0000)]
2010-10-18  Andreas Kling  <kling@webkit.org>

        Unreviewed buildfix for Qt + V8.
        Add missing <wtf/text/CString.h> include.

        * inspector/InspectorInstrumentation.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 18 Oct 2010 15:24:18 +0000 (15:24 +0000)]
2010-10-18  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: toJSON serialization for Numbers should be fixed.
        DecimalNumber is used instead of printf.

        https://bugs.webkit.org/show_bug.cgi?id=43832

        * inspector/InspectorValues.cpp:
        (WebCore::InspectorBasicValue::writeJSON):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Add platform specific expected results for new passing tests.
ossy@webkit.org [Mon, 18 Oct 2010 13:29:44 +0000 (13:29 +0000)]
[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

* platform/qt/editing/input: Added.
* platform/qt/editing/input/emacs-ctrl-o-expected.checksum: Added.
* platform/qt/editing/input/emacs-ctrl-o-expected.png: Added.
* platform/qt/editing/input/emacs-ctrl-o-expected.txt: Added.
* platform/qt/fast/blockflow: Added.
* platform/qt/fast/blockflow/block-level-images-expected.checksum: Added.
* platform/qt/fast/blockflow/block-level-images-expected.png: Added.
* platform/qt/fast/blockflow/block-level-images-expected.txt: Added.
* platform/qt/fast/blockflow/fieldsets-expected.checksum: Added.
* platform/qt/fast/blockflow/fieldsets-expected.png: Added.
* platform/qt/fast/blockflow/fieldsets-expected.txt: Added.
* platform/qt/fast/blockflow/floats-in-block-layout-expected.checksum: Added.
* platform/qt/fast/blockflow/floats-in-block-layout-expected.png: Added.
* platform/qt/fast/blockflow/floats-in-block-layout-expected.txt: Added.
* platform/qt/fast/blockflow/inline-direction-positioning-expected.checksum: Added.
* platform/qt/fast/blockflow/inline-direction-positioning-expected.png: Added.
* platform/qt/fast/blockflow/inline-direction-positioning-expected.txt: Added.
* platform/qt/fast/blockflow/margin-collapse-expected.checksum: Added.
* platform/qt/fast/blockflow/margin-collapse-expected.png: Added.
* platform/qt/fast/blockflow/margin-collapse-expected.txt: Added.
* platform/qt/fast/blockflow/root-lr-basic-expected.checksum: Added.
* platform/qt/fast/blockflow/root-lr-basic-expected.png: Added.
* platform/qt/fast/blockflow/root-lr-basic-expected.txt: Added.
* platform/qt/fast/blockflow/self-collapsing-block-expected.checksum: Added.
* platform/qt/fast/blockflow/self-collapsing-block-expected.png: Added.
* platform/qt/fast/blockflow/self-collapsing-block-expected.txt: Added.
* platform/qt/fast/css/first-letter-punctuation-expected.checksum: Added.
* platform/qt/fast/css/first-letter-punctuation-expected.png: Added.
* platform/qt/fast/css/first-letter-punctuation-expected.txt: Added.
* platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
* platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
* platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
* platform/qt/fast/css/rtl-to-viewport-expected.checksum: Added.
* platform/qt/fast/css/rtl-to-viewport-expected.png: Added.
* platform/qt/fast/css/rtl-to-viewport-expected.txt: Added.
* platform/qt/fast/forms/input-button-sizes-expected.checksum: Added.
* platform/qt/fast/forms/input-button-sizes-expected.png: Added.
* platform/qt/fast/forms/input-button-sizes-expected.txt: Added.
* platform/qt/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
* platform/qt/fast/forms/input-placeholder-focus-twice-expected.png: Added.
* platform/qt/fast/forms/input-placeholder-focus-twice-expected.txt: Added.
* platform/qt/fast/images/gif-large-checkerboard-expected.checksum: Added.
* platform/qt/fast/images/gif-large-checkerboard-expected.png: Added.
* platform/qt/fast/images/gif-large-checkerboard-expected.txt: Added.
* platform/qt/fast/multicol/border-padding-pagination-expected.checksum: Added.
* platform/qt/fast/multicol/border-padding-pagination-expected.png: Added.
* platform/qt/fast/multicol/border-padding-pagination-expected.txt: Added.
* platform/qt/fast/multicol/column-break-with-balancing-expected.checksum: Added.
* platform/qt/fast/multicol/column-break-with-balancing-expected.png: Added.
* platform/qt/fast/multicol/column-break-with-balancing-expected.txt: Added.
* platform/qt/fast/multicol/float-paginate-complex-expected.checksum: Added.
* platform/qt/fast/multicol/float-paginate-complex-expected.png: Added.
* platform/qt/fast/multicol/float-paginate-complex-expected.txt: Added.
* platform/qt/fast/multicol/margin-collapse-expected.checksum: Added.
* platform/qt/fast/multicol/margin-collapse-expected.png: Added.
* platform/qt/fast/multicol/margin-collapse-expected.txt: Added.
* platform/qt/fast/multicol/shadow-breaking-expected.checksum: Added.
* platform/qt/fast/multicol/shadow-breaking-expected.png: Added.
* platform/qt/fast/multicol/shadow-breaking-expected.txt: Added.
* platform/qt/fast/multicol/table-margin-collapse-expected.checksum: Added.
* platform/qt/fast/multicol/table-margin-collapse-expected.png: Added.
* platform/qt/fast/multicol/table-margin-collapse-expected.txt: Added.
* platform/qt/fast/multicol/table-vertical-align-expected.checksum: Added.
* platform/qt/fast/multicol/table-vertical-align-expected.png: Added.
* platform/qt/fast/multicol/table-vertical-align-expected.txt: Added.
* platform/qt/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
* platform/qt/fast/multicol/unsplittable-inline-block-expected.png: Added.
* platform/qt/fast/multicol/unsplittable-inline-block-expected.txt: Added.
* platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
* platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
* platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
* platform/qt/scrollbars: Added.
* platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
* platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
* platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
* platform/qt/svg/custom/fill-opacity-hsl-expected.checksum: Added.
* platform/qt/svg/custom/fill-opacity-hsl-expected.png: Added.
* platform/qt/svg/custom/fill-opacity-hsl-expected.txt: Added.
* platform/qt/svg/custom/fill-opacity-rgba-expected.checksum: Added.
* platform/qt/svg/custom/fill-opacity-rgba-expected.png: Added.
* platform/qt/svg/custom/fill-opacity-rgba-expected.txt: Added.
* platform/qt/svg/custom/recursive-filter-expected.checksum: Added.
* platform/qt/svg/custom/recursive-filter-expected.png: Added.
* platform/qt/svg/custom/recursive-filter-expected.txt: Added.
* platform/qt/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
* platform/qt/svg/custom/repaint-on-constant-size-change-expected.png: Added.
* platform/qt/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
* platform/qt/svg/custom/text-rotation-expected.checksum: Added.
* platform/qt/svg/custom/text-rotation-expected.png: Added.
* platform/qt/svg/custom/text-rotation-expected.txt: Added.
* platform/qt/svg/custom/text-x-dy-lists-expected.checksum: Added.
* platform/qt/svg/custom/text-x-dy-lists-expected.png: Added.
* platform/qt/svg/custom/text-x-dy-lists-expected.txt: Added.
* platform/qt/svg/in-html/by-reference-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Peter Varga <pvarga@inf.u-szeged.hu>
commit-queue@webkit.org [Mon, 18 Oct 2010 13:20:25 +0000 (13:20 +0000)]
2010-10-18  Peter Varga  <pvarga@inf.u-szeged.hu>

        Reviewed by Andreas Kling.

        Remove some unnecessary lines of code from Parser.cpp
        https://bugs.webkit.org/show_bug.cgi?id=47816

        * parser/Parser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 18 Oct 2010 12:46:12 +0000 (12:46 +0000)]
2010-10-18  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [REGRESSION] Inspector window visible during run-webkit-tests.
        The initial state of an inspector setting should stay untouched
        if the profile has no value for it.

        https://bugs.webkit.org/show_bug.cgi?id=47785

        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::loadFromSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 David Levin <levin@chromium.org>
levin@chromium.org [Mon, 18 Oct 2010 12:29:01 +0000 (12:29 +0000)]
2010-10-18  David Levin  <levin@chromium.org>

        Reviewed by Adam Barth.

        check-webkit-style should treat the GObject binding directory like other GTK directories.
        https://bugs.webkit.org/show_bug.cgi?id=47796

        * Scripts/webkitpy/style/checker.py: Added the GObject binding directory
        with the other gtk directories (and fixed typo).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 18 Oct 2010 12:13:23 +0000 (12:13 +0000)]
2010-10-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: tab headers on resource panel are 1px off on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=47798

        * inspector/front-end/inspector.css:
        (.tabbed-pane-header li):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 David Levin <levin@chromium.org>
levin@chromium.org [Mon, 18 Oct 2010 11:57:36 +0000 (11:57 +0000)]
2010-10-18  David Levin  <levin@chromium.org>

        Reviewed by Oliver Hunt.

        check-webkit-style needs to ignore underscores in opcode names and vm_throw
        https://bugs.webkit.org/show_bug.cgi?id=47789

        * Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
        * Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 18 Oct 2010 11:46:15 +0000 (11:46 +0000)]
2010-10-18  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=47659

        Changed the reciever of hasSpellingMarkers from
        textInputController to layoutTestController.

        * editing/spelling/design-mode-spellcheck-off.html:
        * editing/spelling/script-tests/spelling-backspace-between-lines.js:
        (testWithDelete):
        (testWithForwardDelete):
        * editing/spelling/spelling-backspace-between-lines-expected.txt:
        * editing/spelling/spelling-contenteditable.html:
        * editing/spelling/spelling-textarea.html:
2010-10-18  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=47659

        Moved hasSpellingMarkers() from TextInputController to
        LayoutTestController.  Currently the implementation is available
        only for Mac and for Chromium.

        * DumpRenderTree/LayoutTestController.cpp:
        (hasSpellingMarkerCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::hasSpellingMarker):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/TextInputController.cpp:
        (TextInputController::TextInputController):
        (TextInputController::makeAttributedString):
        * DumpRenderTree/chromium/TextInputController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::hasSpellingMarker):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::hasSpellingMarker):
        * DumpRenderTree/mac/TextInputController.m:
        (+[TextInputController isSelectorExcludedFromWebScript:]):
        (+[TextInputController webScriptNameForSelector:]):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::hasSpellingMarker):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::hasSpellingMarker):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::hasSpellingMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 18 Oct 2010 11:42:26 +0000 (11:42 +0000)]
2010-10-18  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        commit-queue's flaky test notice is very Pythony
        https://bugs.webkit.org/show_bug.cgi?id=47790

        This patch make the list of tests delimted by \n instead of just
        converting the array to a string.

        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 18 Oct 2010 10:42:59 +0000 (10:42 +0000)]
2010-10-18  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, skip another mathml flaky test, check bug:
        https://bugs.webkit.org/show_bug.cgi?id=47727

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 18 Oct 2010 10:39:11 +0000 (10:39 +0000)]
2010-10-18  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Build fix.

        * inspector/InspectorResourceAgent.cpp:
        (WebCore::cachedResourceTypeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 18 Oct 2010 10:14:56 +0000 (10:14 +0000)]
2010-10-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
        fill network panel with data.
        https://bugs.webkit.org/show_bug.cgi?id=47779

        InspectorResourceAgent instance / JS part are introduced in this patch. Agent's lifetime is equal
        to the front-end's. This new resource agent does not have state, instead it covers two functions:
         1) forwards loader client messages to the front-end 2) is capable of building a tree of cached resources.
        (1) feeds network panel with data, (2) shows the resource tree in the new ResourcesPanel concept.
        This bug is for extracting this new InspectorResourceAgent class and its javascript counterpart.
        Once resources panel is refactored for the new concept, InspectorResource, InspectorController's
        resource-related routines, inspector.js's code dealing with resources, they all will be gone.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:
        * inspector/InspectorApplicationCacheAgent.cpp:
        (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::releaseFrontendLifetimeAgents):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::frameDetachedFromParent):
        (WebCore::InspectorController::didLoadResourceFromMemoryCache):
        (WebCore::InspectorController::identifierForInitialRequest):
        (WebCore::InspectorController::willSendRequest):
        (WebCore::InspectorController::markResourceAsCached):
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didReceiveContentLength):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorController::scriptImported):
        (WebCore::InspectorController::didCreateWebSocket):
        (WebCore::InspectorController::willSendWebSocketHandshakeRequest):
        (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse):
        (WebCore::InspectorController::didCloseWebSocket):
        * inspector/InspectorController.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::updateResponse):
        (WebCore::cachedResourceType):
        (WebCore::InspectorResource::type):
        (WebCore::InspectorResource::sourceString):
        (WebCore::InspectorResource::sourceBytes):
        (WebCore::InspectorResource::endTiming):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::resourceContent):
        (WebCore::InspectorResourceAgent::resourceContentBase64):
        (WebCore::InspectorResourceAgent::resourceData):
        (WebCore::InspectorResourceAgent::cachedResource):
        (WebCore::buildObjectForHeaders):
        (WebCore::buildObjectForTiming):
        (WebCore::buildObjectForResourceRequest):
        (WebCore::buildObjectForResourceResponse):
        (WebCore::buildObjectForMainResource):
        (WebCore::cachedResourceTypeString):
        (WebCore::buildObjectForCachedResource):
        (WebCore::buildObjectForFrameResources):
        (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
        (WebCore::InspectorResourceAgent::identifierForInitialRequest):
        (WebCore::InspectorResourceAgent::willSendRequest):
        (WebCore::InspectorResourceAgent::markResourceAsCached):
        (WebCore::InspectorResourceAgent::didReceiveResponse):
        (WebCore::InspectorResourceAgent::didReceiveContentLength):
        (WebCore::InspectorResourceAgent::didFinishLoading):
        (WebCore::InspectorResourceAgent::didFailLoading):
        (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
        (WebCore::InspectorResourceAgent::setOverrideContent):
        (WebCore::InspectorResourceAgent::didCommitLoad):
        (WebCore::InspectorResourceAgent::frameDetachedFromParent):
        (WebCore::createReadableStringFromBinary):
        (WebCore::InspectorResourceAgent::didCreateWebSocket):
        (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
        (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
        (WebCore::InspectorResourceAgent::didCloseWebSocket):
        (WebCore::InspectorResourceAgent::cachedResources):
        (WebCore::InspectorResourceAgent::InspectorResourceAgent):
        * inspector/InspectorResourceAgent.h:
        (WebCore::InspectorResourceAgent::create):
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::resourceStyleSheetText):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
        (WebInspector.ExtensionServer.prototype._onGetResourceContent):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.get responseReceivedTime):
        (WebInspector.Resource.prototype.set endTime):
        * inspector/front-end/Settings.js:
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (.tabbed-pane-header li):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::didReceiveResponse):

2010-10-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
        fill network panel with data.
        https://bugs.webkit.org/show_bug.cgi?id=47779

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::didReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 18 Oct 2010 09:18:29 +0000 (09:18 +0000)]
2010-10-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: brush up URL parsing on the front-end.
        https://bugs.webkit.org/show_bug.cgi?id=47772

        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::updateScriptObject):
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.getDomainToResourcesMap):
        (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
        (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
        (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
        (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
        (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.Cookies.cookieMatchesResourceURL):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource):
        (WebInspector.Resource.prototype.set url):
        (WebInspector.Resource.prototype.get displayName):
        * inspector/front-end/ResourceCategory.js:
        (WebInspector.ResourceCategory.prototype.addResource):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView):
        * inspector/front-end/inspector.js:
        (WebInspector.documentClick.followLink):
        (WebInspector.documentClick):
        (WebInspector.updateResource):
        (WebInspector.linkifyStringAsFragment):
        (WebInspector.resourceURLForRelatedNode):
        (WebInspector.completeURL):
        * inspector/front-end/utilities.js:
        (String.prototype.asParsedURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-17 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 18 Oct 2010 08:15:25 +0000 (08:15 +0000)]
2010-10-17  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Support custom open() verbs/methods in XMLHttpRequest
        https://bugs.webkit.org/show_bug.cgi?id=40476

        Fall back to QNetworkAccessManager::CustomOperation for any HTTP verb
        that's not specifically supported by QNetworkAccessManager.

        This prevents the infinite loop that otherwise occurs after sending
        an UnknownOperation request.

        This change is covered by existing (skipped) tests that will be
        unskipped once the Qt bots are running Qt 4.7.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::httpMethod):
        (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
        * platform/network/qt/QNetworkReplyHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 18 Oct 2010 07:53:10 +0000 (07:53 +0000)]
2010-10-18  Adam Barth  <abarth@webkit.org>

        Add more Skipped list entries because WebP requires an external decoder
        library.

        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-18 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 18 Oct 2010 07:39:45 +0000 (07:39 +0000)]
2010-10-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Csaba Osztrogonác.

        Build broken with JIT disabled
        https://bugs.webkit.org/show_bug.cgi?id=47801

        This is a regression caused by r69940.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::resolveBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChange FastAllocBase implementation into a macro
zoltan@webkit.org [Mon, 18 Oct 2010 07:25:32 +0000 (07:25 +0000)]
Change FastAllocBase implementation into a macro
https://bugs.webkit.org/show_bug.cgi?id=42998

Reviewed by Darin Adler.

It was investigated in bug #33896 that inheriting classes from FastAllocBase
can result in objects getting larger which leads to memory regressions.
Using a macro instead of inheriting classes from FastAllocBase would solve the issue.

* wtf/FastAllocBase.h: Add a WTF_MAKE_FAST_ALLOCATED macro

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-17 Pascal Massimino <pascal.massimino@gmail.com>
commit-queue@webkit.org [Mon, 18 Oct 2010 06:51:34 +0000 (06:51 +0000)]
2010-10-17  Pascal Massimino  <pascal.massimino@gmail.com>

        Reviewed by Adam Barth.

        Add support for WebP image decoding in ImageDecoder
        using library libwebp-decode library available from
        http://www.webmproject.org/code/

        https://bugs.webkit.org/show_bug.cgi?id=47512

        Tests: fast/images/webp-image-decoding.html

        * CMakeLists.txt:
            add platform/image-decoders/webp files and directory
        * GNUmakefile.am:
            add platform/image-decoders/webp directory
        * WebCore.gyp/WebCore.gyp:
            add platform/image-decoders/webp directory
        * WebCore.gypi:
            add platform/image-decoders/webp directory
        * features.gypi:
            add WTF_USE_WEBP=1
        * platform/image-decoders/ImageDecoder.cpp:
        (WebCore::ImageDecoder::create):
            instantiate webp decoder for file starting with 'RIFF????WEBP'
        * platform/image-decoders/webp: Added.
        * platform/image-decoders/webp/WEBPImageDecoder.cpp: Added.
        (WebCore::WEBPImageDecoder::WEBPImageDecoder):
        (WebCore::WEBPImageDecoder::~WEBPImageDecoder):
        (WebCore::WEBPImageDecoder::isSizeAvailable):
        (WebCore::WEBPImageDecoder::frameBufferAtIndex):
        (WebCore::WEBPImageDecoder::decode):
            sub-class handling decoding of webp images
        * platform/image-decoders/webp/WEBPImageDecoder.h: Added.
        (WebCore::WEBPImageDecoder::filenameExtension):
        (WebCore::WEBPImageDecoder::supportsAlpha):
            header for webp-decoder sub-class
2010-10-17  Pascal Massimino  <pascal.massimino@gmail.com>

         Reviewed by Adam Barth.

         Add support for decoding WebP image
         https://bugs.webkit.org/show_bug.cgi?id=47512

         * DEPS:
           - Add dependency to libwebp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-17 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 18 Oct 2010 05:42:26 +0000 (05:42 +0000)]
2010-10-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        Strict mode: arguments is not valid as the base expression for pre- or post-fix expressions
        https://bugs.webkit.org/show_bug.cgi?id=47791

        Simple fix, check for arguments in addition to eval.

        * parser/JSParser.cpp:
        (JSC::JSParser::parseUnaryExpression):
2010-10-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        Strict mode: arguments is not valid as the base expression for pre- or post-fix expressions
        https://bugs.webkit.org/show_bug.cgi?id=47791

        Add arguments tests, and make pre-/post-fix expression tests cover another case I was
        needlessly worried about.

        * fast/js/basic-strict-mode-expected.txt:
        * fast/js/script-tests/basic-strict-mode.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-17 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 18 Oct 2010 04:08:37 +0000 (04:08 +0000)]
2010-10-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        Strict mode: Assignment that would create a global should be a late ReferenceError, not a syntax failure
        https://bugs.webkit.org/show_bug.cgi?id=47788

        Fixing this required a couple of changes:
         * resolve_base now has a flag to indicate whether it is being used for a put in strict mode.
           this allows us to throw an exception when we're doing a completely generic resolve for
           assignment, and that assignment would create a new global.
         * There is a new opcode 'op_ensure_property_exists' that is used to determine whether
           the property being assigned to already exists on the global object.  This currently
           has no caching, but such caching could be added relatively trivially.  It is only used
           in the case where we know that a property will be placed on the global object, and
           we cannot verify that the property already exists.

        In the jit we plant a call to cti_op_resolve_base_strict_put in the effected case rather
        than making op_resolve_base have an additional runtime branch.

        There's also a new helper function to create the exception for the invalid assignment.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * bytecode/Opcode.h:
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitResolveBase):
        (JSC::BytecodeGenerator::emitResolveBaseForPut):
        * bytecompiler/BytecodeGenerator.h:
        * bytecompiler/NodesCodegen.cpp:
        (JSC::AssignResolveNode::emitBytecode):
        (JSC::ForInNode::emitBytecode):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::resolveBase):
        (JSC::Interpreter::privateExecute):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        * jit/JIT.h:
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_resolve_base):
        (JSC::JIT::emit_op_ensure_property_exists):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_resolve_base):
        (JSC::JIT::emit_op_ensure_property_exists):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        * jit/JITStubs.h:
        * parser/JSParser.cpp:
        (JSC::JSParser::parseProgram):
        * runtime/ExceptionHelpers.cpp:
        (JSC::createErrorForInvalidGlobalAssignment):
        * runtime/ExceptionHelpers.h:
        * runtime/Operations.h:
        (JSC::resolveBase):
2010-10-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        Strict mode: Assignment that would create a global should be a late ReferenceError, not a syntax failure
        https://bugs.webkit.org/show_bug.cgi?id=47788

        Update test to check for the correct behaviour.

        * fast/js/basic-strict-mode-expected.txt:
        * fast/js/script-tests/basic-strict-mode.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-17 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Mon, 18 Oct 2010 04:02:16 +0000 (04:02 +0000)]
2010-10-17  Antonio Gomes  <agomes@rim.com>

        Reviewed by Simon Fraser.

        Enrich /fast/dom/nodesFromRect-basic.html test
        https://bugs.webkit.org/show_bug.cgi?id=47766

        The patch makes fast/dom/nodesFromRect-basic.html test more precise:
        instead of calling nodesFromRect always with equal vertical (up and down) and
        horizontal (right and left) padding values, it are now tests it by passing
        different padding values on the various directions.

        It is now possible due to the work on bug 46336: Make Document::nodesFromRect more flexible.

        * fast/dom/nodesFromRect-basic-expected.txt:
        * fast/dom/nodesFromRect-basic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69939 268f45cc-cd09-0410-ab3c-d52691b4dbfc