mrowe@apple.com [Mon, 12 Jul 2010 21:58:21 +0000 (21:58 +0000)]
Update WebKitSystemInterface.
Rubber-stamped by Sam Weinig.
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 12 Jul 2010 21:45:59 +0000 (21:45 +0000)]
2010-07-12 Eric Seidel <eric@webkit.org>
Unreviewed, build fix.
Update HTMLTreeBuilder now that MathMLNames is always generated
https://bugs.webkit.org/show_bug.cgi?id=42059
Fix the Windows project file to build MathMLNames.*.
Also added MathMLElementFactory.* which is a NOOP now, but will
prevent folks from breaking the build when they turn MathML on.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 12 Jul 2010 21:38:42 +0000 (21:38 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401
https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown
Enable xmlhttprequest/failed-auth.html on Windows. It now passes on my machine.
* platform/win/Skipped: Also removed two userscript tests that don't exist (run-webkit-tests
loudly complained about those).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Mon, 12 Jul 2010 21:33:24 +0000 (21:33 +0000)]
Windows build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 12 Jul 2010 21:32:34 +0000 (21:32 +0000)]
2010-07-09 Darin Adler <darin@apple.com>
Reviewed by Geoffrey Garen.
String to number coercion is not spec compliant
https://bugs.webkit.org/show_bug.cgi?id=31349
ToNumber should ignore NBSP (\u00a0)
https://bugs.webkit.org/show_bug.cgi?id=25490
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseIntOverflow): Added a version that works on UChar.
* runtime/JSGlobalObjectFunctions.h: Ditto.
* runtime/UString.cpp:
(JSC::isInfinity): Added helper functions.
(JSC::UString::toDouble): Use isStrWhiteSpace instead of
isSASCIISpace to define what we should skip. Got rid of the
code that used CString and UTF8String, instead processing the
UChar of the string directly, except for when we call strtod.
For strtod, use our own home-grown conversion function that
does not try to do any UTF-16 processing. Tidied up the logic
a bit as well.
2010-07-09 Darin Adler <darin@apple.com>
Reviewed by Geoffrey Garen.
String to number coercion is not spec compliant
https://bugs.webkit.org/show_bug.cgi?id=31349
* fast/js/ToNumber-expected.txt: Updated to expect more tests to pass.
* fast/js/parseFloat-expected.txt: Ditto.
* fast/js/sputnik/Conformance/09_Type_Conversion/9.3_ToNumber/9.3.1_ToNumber_from_String/S9.3.1_A2-expected.txt: Ditto.
* fast/js/sputnik/Conformance/09_Type_Conversion/9.3_ToNumber/9.3.1_ToNumber_from_String/S9.3.1_A3_T1-expected.txt: Ditto.
* fast/js/sputnik/Conformance/09_Type_Conversion/9.3_ToNumber/9.3.1_ToNumber_from_String/S9.3.1_A3_T2-expected.txt: Ditto.
* fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T10-expected.txt: Ditto.
* fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T3-expected.txt: Ditto.
* fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T8-expected.txt: Ditto.
* fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T9-expected.txt: Ditto.
* fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A6-expected.txt: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Mon, 12 Jul 2010 21:26:27 +0000 (21:26 +0000)]
2010-07-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Update media element's handling of empty 'src' attribute
https://bugs.webkit.org/show_bug.cgi?id=42001
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::src): Return getNonEmptyURLAttribute().
(WebCore::HTMLMediaElement::selectMediaResource): Call noneSupported() for empty 'src'.
(WebCore::HTMLMediaElement::selectNextSourceChild): Use getNonEmptyURLAttribute() to convert
'src' to URL instead of document()->completeURL(). Don't consider a <source> with an empty 'src'.
* html/HTMLMediaElement.idl: Add 'NonEmpty' option to 'src' attribute.
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::src): Return getNonEmptyURLAttribute().
(WebCore::HTMLSourceElement::isURLAttribute): New, 'src' is a URL attribute.
* html/HTMLSourceElement.h:
* html/HTMLSourceElement.idl: Add 'NonEmpty' option to 'src' attribute.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::parseMappedAttribute): Use getNonEmptyURLAttribute() to convert
'poster' to URL instead of document()->completeURL().
* html/HTMLVideoElement.idl: Add 'NonEmpty' option to 'poster' attribute.
2010-07-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY (OOPS!).
Update media element's handling of empty 'src' attribute
https://bugs.webkit.org/show_bug.cgi?id=42001
* fast/dom/URL-attribute-reflection-expected.txt: Update results now that audio, video, and
source return 'non-empty URL'.
* media/video-poster-expected.txt:
* media/video-poster.html: Test empty poster url.
* media/video-source-error-no-candidate-expected.txt:
* media/video-source-error-no-candidate.html: Empty 'src' should fires an error event.
* media/video-source-expected.txt:
* media/video-source.html: Test <source> element's 'src' attribute and property as well
as currentSrc.
* media/video-src-empty-expected.txt: Removed.
* media/video-src-empty.html: Removed, the test is no longer valid.
* media/video-src-none-expected.txt:
* media/video-src-none.html: Updated to test empty 'src'. Add tests to ensure that an error
is fired when load() is called and the 'src' is empty, but not when 'src' is missing.
* media/video-src.html:
* media/video-src-expected.txt: Test 'src' attribute and property as well as currentSrc.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 12 Jul 2010 21:24:32 +0000 (21:24 +0000)]
2010-07-12 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] make dist is broken because of missing headers and other miscellaneous reasons
https://bugs.webkit.org/show_bug.cgi?id=42107
* GNUmakefile.am: Add missing header to the sources list.
2010-07-12 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] make dist is broken because of missing headers and other miscellaneous reasons
https://bugs.webkit.org/show_bug.cgi?id=42107
* GNUmakefile.am: Remove InspectorFrontend2.idl from the list of IDL files, so
that it is not built into libWebCoreJS. Add missing header to the source list.
Make sure to distribute the new file: WebCore/inspector/CodeGeneratorInspector.pm.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 12 Jul 2010 21:20:45 +0000 (21:20 +0000)]
2010-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump to 1.3.3
* configure.ac:
WebKit/gtk:
2010-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update for 1.3.3
* NEWS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 12 Jul 2010 21:13:09 +0000 (21:13 +0000)]
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTMLTreeBuilder needs to support mixing SVG and MathML content
https://bugs.webkit.org/show_bug.cgi?id=42096
* html5lib/runner-expected-html5.txt:
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTMLTreeBuilder needs to support mixing SVG and MathML content
https://bugs.webkit.org/show_bug.cgi?id=42096
This is just a direct transcription of another paragraph of the
HTML5 spec.
This improved a couple results in html5lib/runner.html, but more
work to do yet to pass all the foreign content tests.
* html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processUsingSecondaryInsertionModeAndAdjustInsertionMode):
* html/HTMLTreeBuilder.h:
* mathml/mathtags.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 12 Jul 2010 21:09:17 +0000 (21:09 +0000)]
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Update HTMLTreeBuilder now that MathMLNames is always generated
https://bugs.webkit.org/show_bug.cgi?id=42059
We pass a bunch more tests now that our MathML code path is enabled.
* html5lib/runner-expected-html5.txt:
2010-07-12 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Update HTMLTreeBuilder now that MathMLNames is always generated
https://bugs.webkit.org/show_bug.cgi?id=42059
Fix the HTMLTreeBuilder MathML code path to compile and remove
the MathML and SVG guards now that SVGNames and MathMLNames are
always compiled into ever port after:
https://bugs.webkit.org/show_bug.cgi?id=42050
This fixed a whole bunch of libhtml5 tests now that we have the
mathml code paths enabled.
* html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTag):
* page/Frame.cpp:
(WebCore::Frame::Frame):
- Always init SVGNames and MathML names.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 12 Jul 2010 21:06:37 +0000 (21:06 +0000)]
2010-07-12 Adam Barth <abarth@webkit.org>
Unreviewed.
Remove stray "raise e" that got included in a previous patch. This
caused the EWS bots to turn red instead of purple when a patch failed
to apply.
* Scripts/webkitpy/tool/commands/stepsequence.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Mon, 12 Jul 2010 21:06:25 +0000 (21:06 +0000)]
Windows build fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 12 Jul 2010 21:02:22 +0000 (21:02 +0000)]
2010-07-12 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Need to do a layout when RenderLayers come and go because of compositing
https://bugs.webkit.org/show_bug.cgi?id=42108
If we create or destroy RenderLayers for reasons other than style changes
(e.g. because of composited iframes or plugins), then we need to ensure
that we do a layout.
Test: compositing/iframes/layout-on-compositing-change.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::adjustStyleDifference):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 12 Jul 2010 20:53:58 +0000 (20:53 +0000)]
2010-07-11 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Always generate SVGNames and MathMLNames for all ports (to support HTML5)
https://bugs.webkit.org/show_bug.cgi?id=42050
Historically, FOONames has only been generate when ENABLE(FOO) is defined.
However, for HTML5 parser support, we need to have access to the SVG
and MathML tag names regardless of whether we the engine is configured
to render SVG or MathML content.
This change enables generation of SVGNames and MathMLNames on all ports and
makes it so that ports can include FOOElementFactory.* regardless of whether
ENABLE(FOO) is defined (and have it do the right thing).
No functional change (yet) so no tests.
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.pri:
* dom/make_names.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 12 Jul 2010 20:53:45 +0000 (20:53 +0000)]
2010-07-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63101.
http://trac.webkit.org/changeset/63101
https://bugs.webkit.org/show_bug.cgi?id=42103
Broke one API test (Requested by xan_ on #webkit).
* Scripts/old-run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63110
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 12 Jul 2010 20:50:45 +0000 (20:50 +0000)]
2010-07-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
make_names.pl should always generate all names in Names.* files
https://bugs.webkit.org/show_bug.cgi?id=42023
Only the *ElementFactory files need to have conditional contents
based on enabled features. WebCore should always have all known
names for SVG, MathML, XML, XLink, HTML, etc. generated in the
various *Names files, even if features are disabled.
make_names.pl is kinda a big hack at this point. I tried to clean
up a little as I went. The way I made *Names include all names was to
read the .in files twice, once using the preprocessor and once without.
* dom/make_names.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 12 Jul 2010 20:39:47 +0000 (20:39 +0000)]
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401
https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown
Fix crashes in Windows DumpRenderTree.
* DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
again on a destroyed sender.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 12 Jul 2010 20:33:54 +0000 (20:33 +0000)]
Windows failure-to-launch fix
* DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
we already do for CoreFoundation, CFNetwork, etc.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ajwong@chromium.org [Mon, 12 Jul 2010 20:18:53 +0000 (20:18 +0000)]
Unreviewed, build fix
[chromium] update test_expectations, and rebaseline a changed svg test.
* platform/chromium-win/fast/gradients/radial-centered-expected.checksum:
* platform/chromium-win/fast/gradients/radial-centered-expected.png:
* platform/chromium-win/fast/gradients/radial-centered-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 12 Jul 2010 20:05:52 +0000 (20:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401
https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown
The fix doesn't help Tiger, update results of one test and skip another.
* platform/mac-tiger/Skipped: Skip 401-alternative-content.php.
* platform/mac-tiger/http/tests/xmlhttprequest/failed-auth-expected.txt:
Copied from http/tests/xmlhttprequest/failed-auth-expected.txt, updated for failure result
in async case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 12 Jul 2010 19:22:17 +0000 (19:22 +0000)]
Move WebKit2.vcproj's settings into .vsprops files
This makes it easier to make changes that affect all configurations.
Fixes <http://webkit.org/b/42097> WebKit2 should use .vsprops files
Reviewed by Steve Falkenburg.
* win/WebKit2.vcproj: Moved settings from here to the files below.
* win/WebKit2Apple.vsprops: Added. Links against Apple-specific
libraries.
* win/WebKit2CFLite.vsprops: Added. Links against CFLite.
* win/WebKit2Common.vsprops: Added. Contains settings shared by all
configurations.
* win/WebKit2DirectX.vsprops: Added. Contains settings to help with
linking against DirectX.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 12 Jul 2010 19:21:56 +0000 (19:21 +0000)]
Stop generating stripped symbols for Release builds
It turns out we can strip the symbols after-the-fact using PDBCopy.
Fixes <http://webkit.org/b/42085>.
Reviewed by Steve Falkenburg.
JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
Removed the pre-link event, which just created the public\sym
directory.
WebKit2:
* win/WebKit2.vcproj: Removed the no-longer-needed Release override of
the StripPrivateSymbols attribute. (This attribute is no longer set in
release.vsprops, so doesn't need to be overridden.)
WebKitLibraries:
* win/tools/vsprops/release.vsprops: Removed the StripPrivateSymbols
attribute, which caused link.exe to generate a stripped PDB file for
each project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 12 Jul 2010 18:34:15 +0000 (18:34 +0000)]
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Oliver Hunt.
Canvas: Move fillRect() save/restore into GraphicsContext implementations
https://bugs.webkit.org/show_bug.cgi?id=42088
Saving the platform painter state is an expensive operation,
so don't do it in fillRect() for platforms that don't need it. (CG, Qt)
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fillRect):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillRect):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::fillRect):
* platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::fillRect):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::fillRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 12 Jul 2010 18:18:32 +0000 (18:18 +0000)]
2010-07-12 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
Ensure DRT loads GAIL (Gtk+ module), for a11y tests
https://bugs.webkit.org/show_bug.cgi?id=38648
Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port
* Scripts/old-run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63101
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Mon, 12 Jul 2010 18:14:17 +0000 (18:14 +0000)]
2010-07-12 Nate Chapin <japhet@chromium.org>
Reviewed by Darin Fisher.
Ensure that a cache policy that forces validation is cleared once
the load event is fired, rather than only doing so at the next
navigation. This leads to a lot of unnecessary load on AJAX-y
websites.
https://bugs.webkit.org/show_bug.cgi?id=41813
Test: http/tests/xmlhttprequest/cache-headers-after-reload.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::handledOnloadEvents): Reset m_loadType to FrameLoadTypeStandard.
(WebCore::FrameLoader::addExtraFieldsToRequest): Only respect the original request's cache policy if the
DocumentLoader is still loading, and handle the other cache policy settings that were scattered around the loader.
(WebCore::FrameLoader::loadResourceSynchronously): Merge cachePolicy setting into FrameLoader::addExtraFieldsToRequest.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create): Merge cachePolicy setting into FrameLoader::addExtraFieldsToRequest.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63100
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 12 Jul 2010 18:00:52 +0000 (18:00 +0000)]
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Oliver Hunt.
CSS color parsing optimizations
https://bugs.webkit.org/show_bug.cgi?id=42073
- Avoid instantiating a CSSParser in parseColor() unless necessary.
- Fixed hex color fast-path to support strings starting with '#'.
- Avoid allocating a new string for the value part of a '#' color.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseColor):
* platform/graphics/Color.cpp:
(WebCore::Color::parseHexColor):
(WebCore::Color::Color):
* platform/graphics/Color.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63099
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 12 Jul 2010 17:42:54 +0000 (17:42 +0000)]
2010-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Suffix .mo files with the GTK+ API version so that they can be
parallel installable.
* configure.ac:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Mon, 12 Jul 2010 17:31:37 +0000 (17:31 +0000)]
WebKit2 build fix for Windows.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp: Remove some stub function definitions.
* win/WebKit2.vcproj: Add PluginController.h to the vcproj.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 12 Jul 2010 17:28:07 +0000 (17:28 +0000)]
Unreviewed.
[Qt] Some inspector test fail intermittently
https://bugs.webkit.org/show_bug.cgi?id=42090
Add tests to the Skipped list until fix to avoid false positive alarms.
* platform/qt/Skipped:
- inspector/timeline-layout.html skipped.
- inspector/timeline-parse-html.html skipped.
- inspector/timeline-recalculate-styles.html skipped.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 12 Jul 2010 16:57:21 +0000 (16:57 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401
https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 12 Jul 2010 16:52:46 +0000 (16:52 +0000)]
Add a PluginController class, use it for invalidation and getting the user agent
https://bugs.webkit.org/show_bug.cgi?id=42084
Reviewed by Adam Roben.
WebCore:
* WebCore.exp.in:
Export Widget::convertToContainingWindow.
WebKit2:
* WebKit2.xcodeproj/project.pbxproj:
Add PluginController.h
* WebProcess/Plugins/DummyPlugin.cpp:
(WebKit::DummyPlugin::initialize):
* WebProcess/Plugins/DummyPlugin.h:
Pass the PluginController to initialize.
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
Implement NPN_UserAgent, NPN_MemAlloc, NPN_MemFree, NPN_InvalidateRect and NPN_InvalidateRegion.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_pluginController to null.
(WebKit::NetscapePlugin::invalidate):
Ask the plug-in controller to invalidate.
(WebKit::NetscapePlugin::userAgent):´
Ask the plug-in controller for the user agent.
(WebKit::NetscapePlugin::initialize):
Set the m_pluginController member variable.
* WebProcess/Plugins/Plugin.h:
Make initialize take a PluginController.
* WebProcess/Plugins/PluginController.h: Added.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::initializePlugin):
Pass the PluginController to initialize.
(WebKit::PluginView::invalidateRect):
Tell the host window to invalidate the given rect.
(WebKit::PluginView::invalidate):
Call invalidateRect.
(WebKit::PluginView::userAgent):
Ask the frame loader client for the user agent.
* WebProcess/Plugins/PluginView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 12 Jul 2010 16:41:13 +0000 (16:41 +0000)]
Add WARN_UNUSED_RETURN to the smart pointer "leak" member functions
https://bugs.webkit.org/show_bug.cgi?id=42086
Reviewed by Dan Bernstein.
* wtf/OwnPtr.h:
* wtf/PassOwnPtr.h:
* wtf/PassRefPtr.h:
(WTF::PassRefPtr::releaseRef):
(WTF::NonNullPassRefPtr::leakRef):
(WTF::NonNullPassRefPtr::releaseRef):
* wtf/RetainPtr.h:
(WTF::RetainPtr::releaseRef):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 12 Jul 2010 16:07:17 +0000 (16:07 +0000)]
2010-07-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium test expectations updated.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 12 Jul 2010 15:48:39 +0000 (15:48 +0000)]
2010-07-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium test expectations updated.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 12 Jul 2010 15:40:22 +0000 (15:40 +0000)]
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=42082
* QtTestBrowser/main.cpp:
(LauncherWindow::createChrome):
* QtTestBrowser/mainwindow.cpp:
(MainWindow::openLocation):
* QtTestBrowser/mainwindow.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 12 Jul 2010 15:18:01 +0000 (15:18 +0000)]
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Dragging within webkit with a drag created via Javascript ends up misinterpreting the data
https://bugs.webkit.org/show_bug.cgi?id=41457
Rebaseline test now that Qt doesn't corrupt non-breaking spaces on clipboard roundtrip.
* platform/qt/editing/pasteboard/onpaste-text-html-expected.txt:
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Dragging within webkit with a drag created via Javascript ends up misinterpreting the data
https://bugs.webkit.org/show_bug.cgi?id=41457
Treat non-special-cased mime-types as Unicode strings in ClipboardQt's getData()
Fixes corruption when retrieving data that was set with anything other than text/plain
Also use QMimeData::setHtml() when applicable to be consistent with PasteboardQt.
* platform/qt/ClipboardQt.cpp:
(WebCore::isHtmlMimeType):
(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::setData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Mon, 12 Jul 2010 15:06:28 +0000 (15:06 +0000)]
2010-07-12 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
add ANDROID to STORE_FONT_CUSTOM_PLATFORM_DATA
https://bugs.webkit.org/show_bug.cgi?id=32273
Tested by existing tests, just adding ANDROID to the list of platforms that use this feature.
* loader/CachedFont.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 12 Jul 2010 14:58:21 +0000 (14:58 +0000)]
Make the Python autoinstaller not use a dead SourceForge server
Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
offline SourceForge server
Reviewed by Anders Carlsson.
* Scripts/webkitpy/thirdparty/__init__.py: Use
surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
which seems to be down.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 12 Jul 2010 14:54:25 +0000 (14:54 +0000)]
2010-07-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rebaseline chromium layout tests.
* platform/chromium-linux/fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
* platform/chromium-linux/fast/gradients/radial-centered-expected.checksum:
* platform/chromium-linux/fast/gradients/radial-centered-expected.png:
* platform/chromium-linux/fast/gradients/radial-centered-expected.txt: Added.
* platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.checksum: Added.
* platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.png: Added.
* platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.txt: Added.
* platform/chromium-mac/fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
* platform/chromium-mac/fast/gradients/radial-centered-expected.checksum: Removed.
* platform/chromium-mac/fast/gradients/radial-centered-expected.png: Removed.
* platform/chromium-mac/fast/gradients/radial-centered-expected.txt: Removed.
* platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.checksum: Added.
* platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.png: Added.
* platform/chromium-win-vista/fast/gradients/radial-centered-expected.checksum: Added.
* platform/chromium-win-vista/fast/gradients/radial-centered-expected.png: Added.
* platform/chromium-win-vista/fast/gradients/radial-centered-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 12 Jul 2010 14:49:52 +0000 (14:49 +0000)]
Make run-webkit-tests print how many tests timed out when exiting early
The number of timed-out tests is taken into account when deciding
whether to exit early. Leaving it out of the output just makes the
script look buggy (because it might say something like "Exiting early
after 0 crashes.").
Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
messages when exiting early due to crashes and time-outs
Reviewed by Anders Carlsson.
* Scripts/old-run-webkit-tests:
(stopRunningTestsEarlyIfNeeded): When stopping, print the number of
timed-out tests, too.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandro@webkit.org [Mon, 12 Jul 2010 14:27:02 +0000 (14:27 +0000)]
2010-07-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed.
[EFL] Move ScriptConcotrollerEfl.cpp from CMakeLists.txt to
CMakeListsEfl.txt.
* CMakeLists.txt:
* CMakeListsEfl.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandro@webkit.org [Mon, 12 Jul 2010 14:23:22 +0000 (14:23 +0000)]
2010-07-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix after r60050.
* CMakeLists.txt: Add WebCore/bindings to the include path.
2010-07-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix after r60050.
* CMakeLists.txt: Add WebCore/bindings to the include path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 12 Jul 2010 14:19:06 +0000 (14:19 +0000)]
2010-07-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Crashes when going back with page cache in unknown circunstances
https://bugs.webkit.org/show_bug.cgi?id=41710
Could not yet find a way to reproduce this in a layout test. The
issue is document being NULL, so this NULL-check should be enough
to get rid of the crash. We are working on trying to find a better
solution for these null cases, like attaching the document earlier
when openning a cached page.
* page/EventHandler.cpp:
(WebCore::EventHandler::sendScrollEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 12 Jul 2010 14:13:15 +0000 (14:13 +0000)]
Windows build fix
* WebProcess/Plugins/Netscape/win/NetscapePluginModuleWin.cpp: Added.
(WebKit::NetscapePluginModule::tryLoad):
(WebKit::NetscapePluginModule::unload):
Stubbed these out.
* win/WebKit2.vcproj: Added a Netscape filter beneath
WebProcess/Plugins, and moved NetscapePlugin into it. Added
NetscapePluginModule to the new Netscape filter. Added
WebProcess/Plugins to the include path for all configurations (it was
only added to Release and Debug_Internal previously) and added
WebProcess/Plugins/Netscape to the include path for all
configurations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 12 Jul 2010 14:07:07 +0000 (14:07 +0000)]
2010-07-12 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] Crash when stepping on a breakpoint while debugging Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=41958
WebCore:
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
* page/PageGroupLoadDeferrer.h:
WebKit/chromium:
* src/WebViewImpl.cpp:
(WebKit::WebView::willEnterModalLoop):
(WebKit::WebView::didExitModalLoop):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 12 Jul 2010 13:20:50 +0000 (13:20 +0000)]
2010-07-12 François Sausset <sausset@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
Test the mathsize MathML attribute.
https://bugs.webkit.org/show_bug.cgi?id=42067
* mathml/presentation/attributes.xhtml:
* platform/mac/mathml/presentation/attributes-expected.checksum:
* platform/mac/mathml/presentation/attributes-expected.png:
* platform/mac/mathml/presentation/attributes-expected.txt:
2010-07-12 François Sausset <sausset@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
Make the mathsize MathML attribute handle values in em, px, pt,...
https://bugs.webkit.org/show_bug.cgi?id=42067
Test: mathml/presentation/attributes.xhtml
* css/mathml.css:
(math[mathsize="small"], mstyle[mathsize="small"], mo[mathsize="small"], mn[mathsize="small"], mi[mathsize="small"], mtext[mathsize="small"], mspace[mathsize="small"], ms[mathsize="small"]):
(math[mathsize="normal"], mstyle[mathsize="normal"], mo[mathsize="normal"], mn[mathsize="normal"], mi[mathsize="normal"], mtext[mathsize="normal"], mspace[mathsize="normal"], ms[mathsize="normal"]):
(math[mathsize="big"], mstyle[mathsize="big"], mo[mathsize="big"], mn[mathsize="big"], mi[mathsize="big"], mtext[mathsize="big"], mspace[mathsize="big"], ms[mathsize="big"]):
* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::parseMappedAttribute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 12 Jul 2010 12:52:43 +0000 (12:52 +0000)]
WebCore:
2010-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix compilation with sealed GTK+.
* platform/gtk/GtkVersioning.h:
* platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillDataObjectFromDropData):
WebKit/gtk:
2010-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix compilation with sealed GTK+.
* webkit/webkitwebview.cpp:
(webkit_web_view_drag_motion):
(webkit_web_view_drag_data_received):
(webkit_web_view_drag_drop):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 12 Jul 2010 12:51:12 +0000 (12:51 +0000)]
2010-07-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Add another include path to the scanner to avoid warnings related
to undefined types. It wasn't picking up <webkit/foo.h>-like
headers.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 12 Jul 2010 12:45:16 +0000 (12:45 +0000)]
2010-07-12 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Fix duplicate test expectations
https://bugs.webkit.org/show_bug.cgi?id=42072
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 12 Jul 2010 12:43:37 +0000 (12:43 +0000)]
2010-07-12 François Sausset <sausset@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
Update of the results to the test introduced here:
https://bugs.webkit.org/show_bug.cgi?id=41626
as they were outdated in the commit.
* platform/mac/mathml/presentation/tokenElements-expected.checksum:
* platform/mac/mathml/presentation/tokenElements-expected.png:
* platform/mac/mathml/presentation/tokenElements-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 12 Jul 2010 12:31:36 +0000 (12:31 +0000)]
2010-07-12 François Sausset <sausset@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
Update tests to check that msqrt and mfrac use style color to draw themselves
https://bugs.webkit.org/show_bug.cgi?id=41889
* mathml/presentation/fractions.xhtml:
* mathml/presentation/roots.xhtml:
* platform/mac/mathml/presentation/fractions-expected.checksum:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/roots-expected.checksum:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
2010-07-12 François Sausset <sausset@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
Fix a bug preventing msqrt and mfrac to use style color to draw themselves.
In mfrac, the fraction bar is now using the color defined by the element style instead of black.
In msqrt, the radical was always drawn in black due to a colorSpace problem.
https://bugs.webkit.org/show_bug.cgi?id=41889
Test: mathml/presentation/roots.xhtml
Test: mathml/presentation/fractions.xhtml
* mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::paint):
* mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 12 Jul 2010 12:17:40 +0000 (12:17 +0000)]
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antti Koivisto.
Canvas: arc() with startAngle == endAngle shouldn't add to the path
https://bugs.webkit.org/show_bug.cgi?id=41420
Unskip (for Qt) test that now passes:
- canvas/philip/tests/2d.path.stroke.prune.arc.html
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-stroke
* platform/qt/Skipped:
2010-07-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antti Koivisto.
Canvas: arc() with startAngle == endAngle shouldn't add to the path
https://bugs.webkit.org/show_bug.cgi?id=41420
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-stroke
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::arc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Mon, 12 Jul 2010 12:08:24 +0000 (12:08 +0000)]
2010-07-12 Jeremy Orlow <jorlow@chromium.org>
Somehow the updated expectations got dropped form the original patch. Added.
* storage/indexeddb/idb-objectstore-request-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Mon, 12 Jul 2010 11:46:34 +0000 (11:46 +0000)]
2010-07-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Ojan Vafai.
Update padding on Windows?
https://bugs.webkit.org/show_bug.cgi?id=38016
* platform/chromium/test_expectations.txt:
* platform/win/Skipped:
2010-07-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Ojan Vafai.
Update padding on Windows?
https://bugs.webkit.org/show_bug.cgi?id=38016
Remove internal padding and add 1px vertical padding for Windows.
* css/themeWin.css:
(input[type="button"], input[type="submit"], input[type="reset"], input[type="file"]::-webkit-file-upload-button, button):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::setupInnerStyle):
* rendering/RenderTheme.h:
* rendering/RenderThemeWin.cpp:
* rendering/RenderThemeWin.h:
* rendering/RenderThemeWince.cpp:
* rendering/RenderThemeWince.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Mon, 12 Jul 2010 11:18:42 +0000 (11:18 +0000)]
2010-07-12 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Put the expected result for Win.
REGRESSION: printing is broken if stylesheet has @page
https://bugs.webkit.org/show_bug.cgi?id=40452
* platform/win/printing/page-rule-in-media-query-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Mon, 12 Jul 2010 11:15:58 +0000 (11:15 +0000)]
2010-07-12 Jeremy Orlow <jorlow@chromium.org>
Speculative fix for visual studio retardedness.
* public/WebCommon.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Mon, 12 Jul 2010 11:10:38 +0000 (11:10 +0000)]
2010-07-12 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Put wrong results for Mac and Win instead of Skipped list.
Results for editing/pasteboard/5761530-1.html are wrong
https://bugs.webkit.org/show_bug.cgi?id=38437
* platform/mac/Skipped:
* platform/mac/editing/pasteboard/5761530-1-expected.txt: Copied from LayoutTests/platform/chromium/editing/pasteboard/5761530-1-expected.txt.
* platform/win/editing/pasteboard/5761530-1-expected.txt: Copied from LayoutTests/platform/chromium/editing/pasteboard/5761530-1-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 12 Jul 2010 10:50:28 +0000 (10:50 +0000)]
2010-07-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium tests fix.
[Chromium, V8] r63057 regressed url tests.
https://bugs.webkit.org/show_bug.cgi?id=42063
* bindings/scripts/CodeGeneratorV8.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Mon, 12 Jul 2010 10:42:38 +0000 (10:42 +0000)]
2010-07-12 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
XPath substring function does not correctly handle non-positive values for the position argument
https://bugs.webkit.org/show_bug.cgi?id=41913
This patch changes the behavior of the XPath evaluate function when a non-positive
position argument is supplied and no length argument is supplied. In this case,
we reset the position to 1. This follows the spec and matches the current behaviour
when a length argument is supplied.
Test: fast/xpath/substring-non-positive-postion.html
* xml/XPathFunctions.cpp:
(WebCore::XPath::FunSubstring::evaluate):
2010-07-12 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
XPath substring function does not correctly handle non-positive values for the position argument
https://bugs.webkit.org/show_bug.cgi?id=41913
* fast/xpath/substring-non-positive-postion-expected.txt: Added.
* fast/xpath/substring-non-positive-postion.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Mon, 12 Jul 2010 10:39:21 +0000 (10:39 +0000)]
2010-07-12 Jeremy Orlow <jorlow@chromium.org>
Build fix. Add an include.
* public/WebCommon.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Mon, 12 Jul 2010 10:00:45 +0000 (10:00 +0000)]
2010-06-27 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dumitru Daniliuc.
Implement IDBObjectStore.get/set/remove
https://bugs.webkit.org/show_bug.cgi?id=41250
Modify existing test to provide basic coverage for get/put/remove functions.
* storage/indexeddb/script-tests/idb-objectstore-request.js:
(test):
(openSuccess):
(createSuccess):
(addSuccess):
(getSuccess):
(removeSuccess):
2010-06-27 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dumitru Daniliuc.
Implement IDBObjectStore.get/set/remove
https://bugs.webkit.org/show_bug.cgi?id=41250
Implement these functions in IDBObjectStore,
add plumbing, teach IDBAny/Callbacks how to deal
with IDBKey, and a few small bits of cleanup.
Test: Modified existing test to provide basic coverage.
Will add much more extensive layout test coverage
in future patches.
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.jscbindings.mk:
* Android.mk:
* Android.v8bindings.mk:
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* storage/IDBAny.cpp:
(WebCore::IDBAny::idbKey):
(WebCore::IDBAny::set):
* storage/IDBAny.h:
(WebCore::IDBAny::):
* storage/IDBAny.idl:
* storage/IDBCallbacks.h:
* storage/IDBDatabaseRequest.h:
* storage/IDBDatabaseRequest.idl:
* storage/IDBKeyRange.h:
* storage/IDBObjectStore.h:
(WebCore::IDBObjectStore::):
* storage/IDBObjectStoreImpl.cpp:
(WebCore::IDBObjectStoreImpl::IDBObjectStoreImpl):
(WebCore::IDBObjectStoreImpl::get):
(WebCore::IDBObjectStoreImpl::set):
(WebCore::IDBObjectStoreImpl::remove):
* storage/IDBObjectStoreImpl.h:
* storage/IDBObjectStoreRequest.cpp:
(WebCore::IDBObjectStoreRequest::get):
(WebCore::IDBObjectStoreRequest::add):
(WebCore::IDBObjectStoreRequest::modify):
(WebCore::IDBObjectStoreRequest::addOrModify):
(WebCore::IDBObjectStoreRequest::remove):
* storage/IDBObjectStoreRequest.h:
* storage/IDBObjectStoreRequest.idl:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
* storage/IDBRequest.h:
2010-06-27 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dumitru Daniliuc.
Implement IDBObjectStore.get/set/remove
https://bugs.webkit.org/show_bug.cgi?id=41250
Plumbing for new features, IDBKey, and added support
for both invalid (i.e. not serializable) and null
(i.e. the RefPtr was 0) to SerializedScriptValue.
* WebKit.gyp:
* public/WebIDBCallbacks.h:
(WebKit::WebIDBCallbacks::onSuccess):
* public/WebIDBKey.h: Added.
(WebKit::WebIDBKey::WebIDBKey):
(WebKit::WebIDBKey::operator=):
(WebKit::WebIDBKey::):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::get):
(WebKit::WebIDBObjectStore::set):
(WebKit::WebIDBObjectStore::remove):
(WebKit::WebIDBObjectStore::createIndex):
(WebKit::WebIDBObjectStore::index):
(WebKit::WebIDBObjectStore::removeIndex):
* public/WebSerializedScriptValue.h:
* src/IDBCallbacksProxy.cpp:
(WebCore::IDBCallbacksProxy::onSuccess):
* src/IDBCallbacksProxy.h:
* src/IDBObjectStoreProxy.cpp:
(WebCore::IDBObjectStoreProxy::get):
(WebCore::IDBObjectStoreProxy::set):
(WebCore::IDBObjectStoreProxy::remove):
* src/IDBObjectStoreProxy.h:
* src/WebIDBCallbacksImpl.cpp:
(WebCore::WebIDBCallbacksImpl::onSuccess):
* src/WebIDBCallbacksImpl.h:
* src/WebIDBKey.cpp: Added.
(WebKit::WebIDBKey::~WebIDBKey):
(WebKit::WebIDBKey::createNull):
(WebKit::WebIDBKey::createInvalid):
(WebKit::WebIDBKey::assign):
(WebKit::WebIDBKey::assignNull):
(WebKit::WebIDBKey::assignInvalid):
(WebKit::WebIDBKey::type):
(WebKit::WebIDBKey::string):
(WebKit::WebIDBKey::number):
(WebKit::WebIDBKey::WebIDBKey):
(WebKit::WebIDBKey::operator=):
(WebKit::WebIDBKey::operator PassRefPtr<IDBKey>):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::get):
(WebKit::WebIDBObjectStoreImpl::set):
(WebKit::WebIDBObjectStoreImpl::remove):
* src/WebIDBObjectStoreImpl.h:
* src/WebSerializedScriptValue.cpp:
(WebKit::WebSerializedScriptValue::createInvalid):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Mon, 12 Jul 2010 07:57:13 +0000 (07:57 +0000)]
2010-07-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement animation-related methods for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42053
* WebCore.exp.in: Export Document::getElementById for WebKit2's benefit.
2010-07-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement animation-related methods for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42053
Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
animation tests were hanging otherwise.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::numberOfActiveAnimations):
(WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(WTR::numberOfActiveAnimationsCallback):
(WTR::pauseAnimationAtTimeOnElementWithIdCallback):
(WTR::LayoutTestController::staticFunctions):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2010-07-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement animation-related methods for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42053
Implemented some helpers for WebKitTestRunner;
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetNumberOfActiveAnimations):
(WKBundleFramePauseAnimationOnElementWithId):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::numberOfActiveAnimations):
(WebKit::WebFrame::pauseAnimationOnElementWithId):
* WebProcess/WebPage/WebFrame.h:
* mac/WebKit2.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Mon, 12 Jul 2010 06:29:06 +0000 (06:29 +0000)]
2010-07-11 Daniel Bates <dbates@rim.com>
Reviewed by David Kilzer.
Enable executable support for svn-apply and svn-unapply
https://bugs.webkit.org/show_bug.cgi?id=39409
Connect up the Git and SVN executable bit support in parseDiff() so that
executable bit changes are propagated via the returned diff hash to the
patch function in svn-apply and svn-unapply.
* Scripts/VCSUtils.pm:
- Modified parseDiff() to call parseSvnDiffProperties when
it finds the start of an SVN property change diff.
- Removed FIXME comment above parseSvnDiffProperties() since
it is now being used by parseDiff().
- Export method scmToggleExecutableBit() now that we added the
executableBitDelta hash key. (This should have been exported
when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
* Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Updated results for:
"rename (with executable bit change)"
- Test value of executableBitDelta (now that we have support).
"SVN: binary file (isBinary true)"
- Remove the property change diff from svnConvertedText. We plan
to remove svnConvertedText in the future. So, we decided
against adding such support to any new code, such as the
property parsing routines. Therefore, we do not keep SVN
converted text for property change diffs.
- Added unit tests:
"SVN: file change diff with property change diff"
"SVN: file change diff, followed by property change diff on different file"
"SVN: property diff, followed by file change diff"
"SVN: copied file with property change"
"SVN: two consecutive property diffs"
"SVN: binary file with executable bit change"
"SVN: binary file followed by property change on different file"
"SVN: binary file followed by file change on different file"
"SVN: file change diff with property change, followed by property change diff"
"SVN: file change diff with property change, followed by file change diff"
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Mon, 12 Jul 2010 03:41:11 +0000 (03:41 +0000)]
2010-07-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement waitUntilDone and notifyDone for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42049
With this fix, most of the DOM tests pass.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didCreatePage): Track the main page. Not
a great way to do it in the future case where we may get multiple
pages - we really need a way to send it over from the ui process.
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::page): A way to get the main page.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
are loading.
(WTR::InjectedBundlePage::dump): Factor into a method so this can be
called by the layout test controller. Also, cancel any pending watchdogs.
(WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
to false.
(WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate
the watchdog.
(WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
(WTR::LayoutTestController::setWaitToDump): Set the flag.
(WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
where waitUntilDone times out.
(WTR::LayoutTestController::notifyDone): Dump, if loading is done.
(WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
(WTR::notifyDoneCallback): JS glue for notifyDone.
(WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
to the layoutController.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 12 Jul 2010 02:35:16 +0000 (02:35 +0000)]
2010-07-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Adam Barth.
[EFL] Fix style errors in ewk_private.h.
https://bugs.webkit.org/show_bug.cgi?id=41742
* efl/ewk/ewk_private.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 12 Jul 2010 00:09:30 +0000 (00:09 +0000)]
2010-07-11 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel
Add a complete list of the HTML5 entities in JSON format.
* html/HTMLEntityNames.json: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sun, 11 Jul 2010 17:37:25 +0000 (17:37 +0000)]
2010-07-11 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKitWebView should support drops
https://bugs.webkit.org/show_bug.cgi?id=39843
Add support for dropping content onto GTK+ WebViews.
No new tests, as the DRT does not support simulating drops yet.
* platform/gtk/ClipboardUtilitiesGtk.cpp:
(WebCore::dragOperationToGdkDragAction): Added.
(WebCore::gdkDragActionToDragOperation): Properly detect DragOperationEvery.
* platform/gtk/ClipboardUtilitiesGtk.h: Add declaration for dragOperationToGdkDragAction.
* platform/gtk/PasteboardHelper.cpp:
Add new target atom and rename the markup target type to match the others.
Add a method which fills a data object from drop data.
(WebCore::PasteboardHelper::initializeTargetList): Add support for new atoms.
(WebCore::selectionDataToUTF8String): Added this helper.
(WebCore::PasteboardHelper::getClipboardContents): Use the selectionDataToUTF8String helper.
(WebCore::PasteboardHelper::targetListForDataObject): Change to reflect markup atom rename.
(WebCore::PasteboardHelper::fillDataObjectFromDropData): Added.
(WebCore::PasteboardHelper::dropAtoms): Added.
* platform/gtk/PasteboardHelper.h: Add declarations of new methods.
2010-07-11 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKitWebView should support drops
https://bugs.webkit.org/show_bug.cgi?id=39843
Add support for dropping content onto GTK+ WebViews.
* webkit/webkitprivate.h:
Add a DroppingContext struct to keep track of drop data while the drop is
in progress. Have WebKitWebView keep a map of GdkDragContexts to DroppingContexts.
* webkit/webkitwebview.cpp: Add necessary includes and globalPointForClientPoint helper.
(webkit_web_view_popup_menu_handler): Use globalPointForClientPoint helper.
(webkit_web_view_dispose): Properly clean up droppingContexts member.
(webkit_web_view_finalize): Delete droppingContext member.
(globalPointForClientPoint): Added.
(doDragLeaveLater): Added.
(webkit_web_view_drag_leave): Added.
(webkit_web_view_drag_motion): Added.
(webkit_web_view_drag_data_received): Added.
(webkit_web_view_drag_drop): Added.
(webkit_web_view_class_init): Connect new drop signal handlers to the widget definition.
(webkit_web_view_init): Set up the widget as a drop destination and initialize droppingContexts.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 11 Jul 2010 06:54:44 +0000 (06:54 +0000)]
2010-07-10 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
Enhance content attribute reflection for URL attributes, including adding a non-empty option
https://bugs.webkit.org/show_bug.cgi?id=42040
Test: fast/dom/URL-attribute-reflection.html
Changed syntax from [ReflectURL] to [Reflect,URL] and also added support for
a new option, NonEmpty, which implements the non-empty URL concept from the
HTML5 specification.
* bindings/scripts/CodeGenerator.pm: Changed code to expect the Reflect and URL
extended attributes to come in separately. The URL one simply means "the string
of this attribute is a URL", since we don't have a distinct type for URL. Also
added a new NonEmpty extended attribute.
* bindings/scripts/CodeGeneratorJS.pm: Removed now-unneeded code to handle ReflectURL.
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated for new added test cases
and the fix I made to the reflectedCustomURLAttr test.
* bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
* bindings/scripts/test/JS/JSTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto. Also, for some reason the V8
bindig writes out the keywords into the generated file as comments, so the keyword
change had a direct efffect on the output file.
* bindings/scripts/test/TestObj.idl: Changed the test cases for ReflectURL to use
the new syntax. Added test cases for NonEmpty. Fixed the name of
reflectedNonEmptyURLAttr, which accidentally was repeating reflectedURLAttr
instead; never noticed because we never compile the test output.
* dom/Element.cpp:
(WebCore::Element::getNonEmptyURLAttribute): Added. For use by NonEmpty and also
by any code that wants to implement the non-empty URL content attribute semantic.
* dom/Element.h: Ditto.
* html/HTMLAnchorElement.idl: Use Reflect,URL instead of ReflectURL.
* html/HTMLAreaElement.idl: Ditto.
* html/HTMLFrameElement.idl: Ditto.
* html/HTMLImageElement.idl: Ditto.
* html/HTMLInputElement.idl: Ditto.
* html/HTMLLinkElement.idl: Ditto.
* html/HTMLMediaElement.idl: Ditto.
* html/HTMLObjectElement.idl: Ditto.
* html/HTMLScriptElement.idl: Ditto.
* html/HTMLVideoElement.idl: Ditto.
2010-07-10 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
Enhance content attribute reflection for URL attributes, including adding a non-empty option
https://bugs.webkit.org/show_bug.cgi?id=42040
The current test results show many failures, and we should follow up with fixes
either to the DOM implementation, or to the test result expectations.
* fast/dom/URL-attribute-reflection-expected.txt: Added.
* fast/dom/URL-attribute-reflection.html: Added.
* fast/dom/script-tests/URL-attribute-reflection.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sun, 11 Jul 2010 01:14:47 +0000 (01:14 +0000)]
2010-07-10 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
HAVE_COMPUTED_GOTO is dependent on the interpreter being enabled
https://bugs.webkit.org/show_bug.cgi?id=42039
Separate the existence of computed goto support in the compiler
from whether or not we are using the interpreter. All the current
HAVE(COMPUTED_GOTO) guards are for the interpreter, but I'd like
the option of using it elsewhere. The interpreter now uses
ENABLE(COMPUTED_GOTO_INTERPRETER)
* bytecode/Instruction.h:
(JSC::Instruction::Instruction):
* bytecode/Opcode.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sun, 11 Jul 2010 00:11:08 +0000 (00:11 +0000)]
2010-07-10 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Remove switches from inner expression loops in the parser
https://bugs.webkit.org/show_bug.cgi?id=42035
Use bitmasks and flags on the token types to identify unary and
binary operators, rather than switching on the token type to
identify them.
* parser/JSParser.cpp:
(JSC::isUnaryOp):
(JSC::JSParser::isBinaryOperator):
* parser/JSParser.h:
(JSC::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 10 Jul 2010 23:11:16 +0000 (23:11 +0000)]
2010-07-10 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Adler.
Add missing derrived sources to xcode project
https://bugs.webkit.org/show_bug.cgi?id=42034
This allows --web-timing to work with build-webkit on OSX with JSC.
This should have been done in bug 41442.
No new tests because no new functionality.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 10 Jul 2010 22:28:39 +0000 (22:28 +0000)]
Don't initialize plug-ins until allowed by the page
https://bugs.webkit.org/show_bug.cgi?id=42033
Reviewed by Sam Weinig.
WebCore:
* WebCore.exp.in:
Export Document::addMediaCanStartListener and Document::removeMediaCanStartListener.
WebKit2:
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::paint):
(WebKit::NetscapePlugin::geometryDidChange):
Assert that the plug-in is started.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
Initialize m_isWaitingUntilMediaCanStart.
(WebKit::PluginView::~PluginView):
If necessary, remove the plug-in view as a MediaCanStartListener.
(WebKit::PluginView::initializePlugin):
If we're not allowed to initialize the plug-in, add the plug-in view as a MediaCanStartListener.
(WebKit::PluginView::paint):
Check that the plug-in is initialized.
(WebKit::PluginView::viewGeometryDidChange):
Ditto.
(WebKit::PluginView::mediaCanStart):
Initialize the plug-in.
* WebProcess/Plugins/PluginView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 10 Jul 2010 21:47:14 +0000 (21:47 +0000)]
Have the plug-in view initialize the plug-in
https://bugs.webkit.org/show_bug.cgi?id=42030
Reviewed by Dan Bernstein.
* WebProcess/Plugins/DummyPlugin.cpp:
(WebKit::DummyPlugin::initialize):
* WebProcess/Plugins/DummyPlugin.h:
Plugin::initialize now takes a struct.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::initialize):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Plugin::initialize now takes a struct.
* WebProcess/Plugins/Plugin.h:
Add Parameters struct.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
Add Parameters parameter.
(WebKit::PluginView::~PluginView):
Add m_plugin null check.
(WebKit::PluginView::initializePlugin):
Try to initialize the plug-in and zero out the plug-in if initialization fails.
(WebKit::PluginView::paint):
Add m_plugin null check.
(WebKit::PluginView::setParent):
Initialize the plug-in.
* WebProcess/Plugins/PluginView.h:
(WebKit::PluginView::create):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
Don't initialize the plug-in here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 10 Jul 2010 21:38:36 +0000 (21:38 +0000)]
WebCore: Patch for https://bugs.webkit.org/show_bug.cgi?id=42021
isEqualNode should work for DocumentType nodes
Reviewed by Anders Carlsson.
Test: fast/dom/Node/isEqualNode.html
* dom/Node.cpp:
(WebCore::Node::isEqualNode): Add DocumentType logic from the DOM3 spec.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=42021
isEqualNode should work for DocumentType nodes
Reviewed by Anders Carlsson.
* fast/dom/Node/isEqualNode-expected.txt: Added.
* fast/dom/Node/isEqualNode.html: Added.
* fast/dom/Node/script-tests/isEqualNode.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63051
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sat, 10 Jul 2010 21:18:58 +0000 (21:18 +0000)]
2010-07-10 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
Move enum ReasonForCallingCanExecuteScripts to header ScriptControllerBase.h
https://bugs.webkit.org/show_bug.cgi?id=39339
Moved the enum ReasonForCallingCanExecuteScripts, which was
defined in both the JSC and V8 ScriptController.h file, into
a shared file called ScriptControllerBase.h.
No functionality was changed, so no new tests.
* GNUmakefile.am: Added file bindings/ScriptControllerBase.h.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.vcproj/WebCoreCommon.vsprops: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/ScriptControllerBase.h: Added.
(WebCore::):
* bindings/js/ScriptController.h: #include ScriptControllerBase.h
* bindings/v8/ScriptController.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63050
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 10 Jul 2010 19:39:42 +0000 (19:39 +0000)]
Call Page::canStartMedia when the WKView is added to/removed from a window
https://bugs.webkit.org/show_bug.cgi?id=42029
Reviewed by Oliver Hunt.
* Shared/CoreIPCSupport/WebPageMessageKinds.h:
(WebPageMessage::):
Add SetIsInWindow.
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:pageNamespaceRef:]):
Call setIsInWindow.
(-[WKView _updateVisibility]):
Call setIsInWindow.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Initialize m_isInWindow.
(WebKit::WebPageProxy::setIsInWindow):
Send WebPageMessage::SetIsInWindow.
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setIsInWindow):
Call Page::canStartMedia.
(WebKit::WebPage::didReceiveMessage):
Handle the SetIsInWindow message.
* WebProcess/WebPage/WebPage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 10 Jul 2010 17:57:15 +0000 (17:57 +0000)]
<rdar://problem/8153214> Continuation outlines in layers do not paint correctly
Reviewed by Anders Carlsson.
WebCore:
Test: fast/inline/continuation-outlines-with-layers-2.html
Continuation outlines are normally painted by the containing block. However, when the
block and the inline are not enclosed by the same self-painting layer, the inline has to
paint its own outlines. This was handled correctly only for the case where the inline had
its own self-painting layer, but now when an ancestor inline had the self-painting layer.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint): Instead of testing for having a self-painting layer, test
whether any intermediate box between the inline and the containing block has a self-painting
layer.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject): Ditto.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingBoxModelObject): Added this utility method.
* rendering/RenderObject.h:
LayoutTests:
* fast/inline/continuation-outlines-with-layers-2.html: Added.
* platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.checksum: Added.
* platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.png: Added.
* platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 10 Jul 2010 17:33:29 +0000 (17:33 +0000)]
Reuse initialized NetscapePluginModules, pass parameters to NPP_New
https://bugs.webkit.org/show_bug.cgi?id=42028
Reviewed by Dan Bernstein.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
Let the plug-in module know that a plug-in has been created.
(WebKit::NetscapePlugin::~NetscapePlugin):
Let the plug-in module know that a plug-in has been destroyed.
(WebKit::NetscapePlugin::initialize):
Pass the MIME type and parameters to the plug-in.
* WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::initializedNetscapePluginModules):
Add list of initialized plug-in modules.
(WebKit::NetscapePluginModule::NetscapePluginModule):
Initialize m_pluginCount to 0.
(WebKit::NetscapePluginModule::~NetscapePluginModule):
Assert that we're not in the list of initialized plug-ins.
(WebKit::NetscapePluginModule::pluginCreated):
Increment the plug-in count.
(WebKit::NetscapePluginModule::pluginDestroyed):
Decrement the plug-in count and call shutdown if it's 0.
(WebKit::NetscapePluginModule::shutdown):
Call NP_Shutdown and remove the plug-in from the list of initialized plug-ins.
(WebKit::NetscapePluginModule::getOrCreate):
Look for an already initialized plug-in module before creating one.
(WebKit::NetscapePluginModule::load):
Set m_isInitialized to true.
* WebProcess/Plugins/Netscape/mac/NetscapePluginModuleMac.cpp:
(WebKit::NetscapePluginModule::unload):
Leak the CFBundleRef to avoid possible crashes.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
Call getOrCreate instead of create.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 10 Jul 2010 16:02:02 +0000 (16:02 +0000)]
2010-07-10 François Sausset <sausset@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
Build fix: syntax and typo issues
https://bugs.webkit.org/show_bug.cgi?id=41859
* html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 10 Jul 2010 09:01:35 +0000 (09:01 +0000)]
2010-07-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTMLTreeBuilder needs adjustForeignAttributes support
https://bugs.webkit.org/show_bug.cgi?id=42022
* html5lib/runner-expected-html5.txt:
- We now pass 3 more tests.
2010-07-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTMLTreeBuilder needs adjustForeignAttributes support
https://bugs.webkit.org/show_bug.cgi?id=42022
To add adjust foreign attributes support I had to add an
AtomicString (prefixed name) to QualifiedName hash. Once I had
done that, I decided it would be best for the other "adjust" functions
to share the same hash logic, so I moved them to using the same
AtomicString -> QualifiedName hash as well.
Tested by html5lib/runner.html
* dom/Attribute.h:
(WebCore::Attribute::parserSetName):
* html/HTMLTreeBuilder.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Sat, 10 Jul 2010 08:14:48 +0000 (08:14 +0000)]
2010-07-10 Rob Buis <rwlbuis@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=41978
Remove namespace prefixes from idl files
No new tests, idl syntax fixes.
* css/CSSImportRule.idl:
* css/CSSMediaRule.idl:
* css/CSSStyleSheet.idl:
* css/CSSVariablesRule.idl:
* svg/SVGAnimatedString.idl:
* svg/SVGColor.idl:
* svg/SVGDocument.idl:
* svg/SVGLangSpace.idl:
* svg/SVGSVGElement.idl:
* svg/SVGStringList.idl:
* svg/SVGStylable.idl:
* svg/SVGStyleElement.idl:
* svg/SVGTests.idl:
* svg/SVGZoomEvent.idl:
* xml/XPathEvaluator.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Sat, 10 Jul 2010 07:59:39 +0000 (07:59 +0000)]
Unreviewed, GTK build fix.
* bindings/gobject/GObjectEventListener.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Sat, 10 Jul 2010 07:24:31 +0000 (07:24 +0000)]
Remove unnecessary includes in header files in WebCore/dom.
https://bugs.webkit.org/show_bug.cgi?id=41941
Reviewed by Darin Adler.
* css/StyleMedia.h:
* dom/BeforeLoadEvent.h:
* dom/CustomEvent.h:
* dom/DOMStringMap.h:
* dom/DeviceOrientationEvent.h:
* dom/EventListener.h:
* dom/MessagePort.h:
* dom/Node.cpp:
* dom/NodeFilter.h:
* dom/NodeRareData.h:
* dom/RegisteredEventListener.h:
* dom/SelectorNodeList.cpp:
* dom/SelectorNodeList.h:
* dom/StyleElement.h:
* dom/Traversal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Sat, 10 Jul 2010 05:01:36 +0000 (05:01 +0000)]
Windows testers running Windows 7 were hanging during test_kill_process. Changing the
number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
slow down the tests).
Rubber-stamped by Dan Bernstein.
* Scripts/webkitpy/common/system/executive.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jam@chromium.org [Sat, 10 Jul 2010 04:32:27 +0000 (04:32 +0000)]
2010-07-09 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium] Take out WebPlugin::supportsFind since we can accomplish the same thing by having a return value on startFind
https://bugs.webkit.org/show_bug.cgi?id=42011
* public/WebPlugin.h:
(WebKit::WebPlugin::startFind):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Sat, 10 Jul 2010 04:20:50 +0000 (04:20 +0000)]
2010-07-09 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting pre
https://bugs.webkit.org/show_bug.cgi?id=38231
* editing/execCommand/indent-pre-expected.txt: Added.
* editing/execCommand/indent-pre.html: Added.
2010-07-09 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting pre
https://bugs.webkit.org/show_bug.cgi?id=38231
Test: editing/execCommand/indent-pre.html
* editing/IndentOutdentCommand.cpp:
(WebCore::countParagraphs):
(WebCore::IndentOutdentCommand::indentRegion): Split text nodes into one node per paragraph
so moveParagraph doesn't get confused.
(WebCore::IndentOutdentCommand::splitTextNodes):
* editing/IndentOutdentCommand.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Sat, 10 Jul 2010 04:08:32 +0000 (04:08 +0000)]
2010-07-09 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler.
Computed style is not implemented for padding-start, padding-end, margin-start, margin-end
https://bugs.webkit.org/show_bug.cgi?id=41496
* fast/css/margin-start-end-expected.txt:
* fast/css/padding-start-end-expected.txt:
* fast/css/script-tests/margin-start-end.js: Added tests for computed style.
* fast/css/script-tests/padding-start-end.js: Added tests for computed style.
2010-07-09 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler.
Computed style is not implemented for padding-start, padding-end, margin-start, margin-end
https://bugs.webkit.org/show_bug.cgi?id=41496
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::resolveDirectionAwareProperty): This function resolves the property ID for a direction aware property.
* css/CSSProperty.h:
* css/CSSStyleSelector.cpp: Use helper function.
(WebCore::CSSStyleSelector::applyProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 10 Jul 2010 03:47:55 +0000 (03:47 +0000)]
2010-07-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 tree builder should pass some LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=41991
Before this patch, we weren't attaching text nodes to the render tree,
which turns out to be important. :)
This patch fixes more than 10,000 LayoutTests.
* html/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attach):
(WebCore::HTMLConstructionSite::attachAtSite):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 10 Jul 2010 03:36:19 +0000 (03:36 +0000)]
2010-07-09 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
[WINCE] Buildfix for TextEncodingRegistry
https://bugs.webkit.org/show_bug.cgi?id=41992
Renamed TextCodecWince to TextCodecWinCE.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 10 Jul 2010 03:20:56 +0000 (03:20 +0000)]
2010-07-09 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Mac build fix
https://bugs.webkit.org/show_bug.cgi?id=41967
Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sat, 10 Jul 2010 03:13:03 +0000 (03:13 +0000)]
2010-07-09 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Clean up: Move dump-list.js utility script from LayoutTests/fast/lists
to LayoutTests/fast/lists/resources
https://bugs.webkit.org/show_bug.cgi?id=42016
Move fast/lists/dump-list.js to fast/lists/resources since it
is a utility script and not a test case.
* fast/lists/dump-list.js: Removed. Moved to fast/lists/resources.
* fast/lists/ol-nested-items-dynamic-insert.html: Modified to look
for dump-list.js in new location.
* fast/lists/ol-nested-items-dynamic-remove.html: Ditto.
* fast/lists/ol-nested-items.html: Ditto.
* fast/lists/ol-nested-list-dynamic-insert.html: Ditto.
* fast/lists/ol-nested-list-dynamic-remove.html: Ditto.
* fast/lists/ol-nested-list.html: Ditto.
* fast/lists/resources/dump-list.js: Copied from LayoutTests/fast/lists/dump-list.js.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
diegohcg@webkit.org [Sat, 10 Jul 2010 03:02:42 +0000 (03:02 +0000)]
2010-07-09 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Antonio Gomes.
[Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
https://bugs.webkit.org/show_bug.cgi?id=41966
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 10 Jul 2010 02:41:10 +0000 (02:41 +0000)]
2010-07-09 Leon Clarke <leonclarke@google.com>
Reviewed by Adam Barth.
add support for link prefetching
https://bugs.webkit.org/show_bug.cgi?id=3652
* Configurations/FeatureDefines.xcconfig:
2010-07-09 Leon Clarke <leonclarke@google.com>
Reviewed by Adam Barth.
add support for link prefetching
https://bugs.webkit.org/show_bug.cgi?id=3652
* fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
* fast/dom/HTMLLinkElement/prefetch.html: Added.
* fast/dom/HTMLLinkElement/prefetch.link: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
2010-07-09 Leon Clarke <leonclarke@google.com>
Reviewed by Adam Barth.
add support for link prefetching
https://bugs.webkit.org/show_bug.cgi?id=3652
Test: fast/dom/HTMLLinkElement/prefetch.html
* Configurations/FeatureDefines.xcconfig:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::tokenizeRelAttribute):
(WebCore::HTMLLinkElement::process):
* html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
* loader/Cache.cpp:
(WebCore::createResource):
* loader/CachedResource.cpp:
(WebCore::CachedResource::data):
(WebCore::CachedResource::didAddClient):
* loader/CachedResource.h:
(WebCore::CachedResource::):
(WebCore::CachedResource::error):
(WebCore::CachedResource::isPrefetch):
(WebCore::CachedResource::schedule):
* loader/CachedScript.cpp:
* loader/CachedScript.h:
* loader/DocLoader.cpp:
(WebCore::DocLoader::requestLinkPrefetch):
(WebCore::DocLoader::canRequest):
(WebCore::DocLoader::incrementRequestCount):
(WebCore::DocLoader::decrementRequestCount):
* loader/DocLoader.h:
* loader/loader.cpp:
(WebCore::cachedResourceTypeToTargetType):
(WebCore::Loader::determinePriority):
(WebCore::Loader::load):
(WebCore::Loader::Host::servePendingRequests):
(WebCore::Loader::Host::didFinishLoading):
(WebCore::Loader::Host::didFail):
(WebCore::Loader::Host::didReceiveResponse):
(WebCore::Loader::Host::cancelPendingRequests):
* loader/loader.h:
(WebCore::Loader::):
* platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::):
2010-07-09 Leon Clarke <leonclarke@google.com>
Reviewed by Adam Barth.
add support for link prefetching
https://bugs.webkit.org/show_bug.cgi?id=3652
* public/WebURLRequest.h:
(WebKit::WebURLRequest::):
2010-07-09 Leon Clarke <leonclarke@google.com>
Reviewed by Adam Barth.
add support for link prefetching
https://bugs.webkit.org/show_bug.cgi?id=3652
* Configurations/FeatureDefines.xcconfig:
2010-07-09 Leon Clarke <leonclarke@google.com>
Reviewed by Adam Barth.
add support for link prefetching
https://bugs.webkit.org/show_bug.cgi?id=3652
* Configurations/FeatureDefines.xcconfig:
2010-07-09 Leon Clarke <leonclarke@google.com>
Reviewed by Adam Barth.
add support for link prefetching
https://bugs.webkit.org/show_bug.cgi?id=3652
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sat, 10 Jul 2010 02:30:43 +0000 (02:30 +0000)]
2010-07-09 James Robinson <jamesr@chromium.org>
Unreviewed build fix. Add #include to pick up ExceptionCode values for config (like Qt) where it's not picked up indirectly.
* html/HTMLCanvasElement.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sat, 10 Jul 2010 01:26:56 +0000 (01:26 +0000)]
2010-07-09 James Robinson <jamesr@chromium.org>
Reviewed by Darin Adler.
Removes CanvasSurface and moves all of its functionality to HTMLCanvasElement.
https://bugs.webkit.org/show_bug.cgi?id=42005
http://trac.webkit.org/changeset/55201 introduced a new base class for HTMLCanvasElement called CanvasSurface.
The intention was that this would allow for code sharing with the then-proposed OffscreenCanvas. However,
there is no OffscreenCanvas and there's unlikely to be one soon. Additionally CanvasSurface breaks
encapsulation pretty badly by doing "static_cast<HTMLCanvasElement* const>(this)". Until an abstraction is
really needed we should just use HTMLCanvasElement when we want to talk about a canvas.
This patch moves all of CanvasSurface's functionality back up to HTMLCanvasElement and reorders the header
to be a bit more logical.
Refactor with no behavior change, thus no new tests.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/CanvasSurface.cpp: Removed.
* dom/CanvasSurface.h: Removed.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::willDraw):
(WebCore::HTMLCanvasElement::setSurfaceSize):
(WebCore::HTMLCanvasElement::toDataURL):
(WebCore::HTMLCanvasElement::convertLogicalToDevice):
(WebCore::HTMLCanvasElement::securityOrigin):
(WebCore::HTMLCanvasElement::styleSelector):
(WebCore::HTMLCanvasElement::createImageBuffer):
(WebCore::HTMLCanvasElement::drawingContext):
(WebCore::HTMLCanvasElement::buffer):
(WebCore::HTMLCanvasElement::baseTransform):
* html/HTMLCanvasElement.h:
(WebCore::HTMLCanvasElement::setObserver):
(WebCore::HTMLCanvasElement::width):
(WebCore::HTMLCanvasElement::height):
(WebCore::HTMLCanvasElement::size):
(WebCore::HTMLCanvasElement::toDataURL):
(WebCore::HTMLCanvasElement::setOriginTainted):
(WebCore::HTMLCanvasElement::originClean):
(WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 10 Jul 2010 01:25:50 +0000 (01:25 +0000)]
Tidy up lexer token ids
https://bugs.webkit.org/show_bug.cgi?id=42014
Reviewed by Darin Adler
Stop using character literals to identify single character tokens
and instead use symbolic names for all tokens.
* parser/ASTBuilder.h:
(JSC::ASTBuilder::makeBinaryNode):
* parser/JSParser.cpp:
(JSC::JSParser::consume):
(JSC::JSParser::match):
(JSC::JSParser::autoSemiColon):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::allowAutomaticSemicolon):
(JSC::JSParser::parseDoWhileStatement):
(JSC::JSParser::parseWhileStatement):
(JSC::JSParser::parseVarDeclarationList):
(JSC::JSParser::parseConstDeclarationList):
(JSC::JSParser::parseForStatement):
(JSC::JSParser::parseReturnStatement):
(JSC::JSParser::parseWithStatement):
(JSC::JSParser::parseSwitchStatement):
(JSC::JSParser::parseSwitchClauses):
(JSC::JSParser::parseSwitchDefaultClause):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseDebuggerStatement):
(JSC::JSParser::parseStatement):
(JSC::JSParser::parseFormalParameters):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseExpressionOrLabelStatement):
(JSC::JSParser::parseIfStatement):
(JSC::JSParser::parseExpression):
(JSC::JSParser::parseAssignmentExpression):
(JSC::JSParser::parseConditionalExpression):
(JSC::isUnaryOp):
(JSC::JSParser::isBinaryOperator):
(JSC::JSParser::parseBinaryExpression):
(JSC::JSParser::parseProperty):
(JSC::JSParser::parseObjectLiteral):
(JSC::JSParser::parseStrictObjectLiteral):
(JSC::JSParser::parseArrayLiteral):
(JSC::JSParser::parsePrimaryExpression):
(JSC::JSParser::parseArguments):
(JSC::JSParser::parseMemberExpression):
(JSC::JSParser::parseUnaryExpression):
* parser/JSParser.h:
(JSC::):
* parser/Lexer.cpp:
(JSC::):
(JSC::Lexer::lex):
* parser/Lexer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sat, 10 Jul 2010 01:24:21 +0000 (01:24 +0000)]
Bug 42015 - Enable JSValue32_64 on ARMv7
Reviewed by Oliver Hunt.
* Configurations/JavaScriptCore.xcconfig:
* jit/JIT.h:
* jit/JITStubs.cpp:
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sat, 10 Jul 2010 01:17:55 +0000 (01:17 +0000)]
2010-07-09 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Calling layoutTestController.layerTreeAsText() should update layout
https://bugs.webkit.org/show_bug.cgi?id=41818
Need to call updateLayout() before we check for any layers, not after,
since layout will update compositing, and may create layers.
* page/Frame.cpp:
(WebCore::Frame::layerTreeAsText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 10 Jul 2010 01:14:03 +0000 (01:14 +0000)]
2010-07-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
r63004 broke some python tests
https://bugs.webkit.org/show_bug.cgi?id=42007
AbstractStep now checks options.no_squash and options.squash, so
they needed to have real values. Mock would return an object for those,
which would then act as if the values were True.
* Scripts/webkitpy/tool/commands/commandtest.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/commands/stepsequence.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
* Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
* Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Sat, 10 Jul 2010 00:47:59 +0000 (00:47 +0000)]
2010-07-09 Kenneth Russell <kbr@google.com>
Reviewed by Nate Chapin.
bufferSubData causes crash in WebGLBuffer::associateBufferSubData
https://bugs.webkit.org/show_bug.cgi?id=42004
Test: fast/canvas/webgl/index-validation-crash-with-buffer-sub-data.html
* html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferData):
- Allocate m_elementArrayBuffer for entry point taking only size.
Guard against allocation failures of m_elementArrayBuffer.
(WebCore::WebGLBuffer::associateBufferSubData):
- Guard against any possibility of crashes due to m_elementArrayBuffer being NULL.
2010-07-09 Kenneth Russell <kbr@google.com>
Reviewed by Nate Chapin.
bufferSubData causes crash in WebGLBuffer::associateBufferSubData
https://bugs.webkit.org/show_bug.cgi?id=42004
* fast/canvas/webgl/index-validation-crash-with-buffer-sub-data-expected.txt: Added.
* fast/canvas/webgl/index-validation-crash-with-buffer-sub-data.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log