WebKit-https.git
8 years ago[Win] TestWebKitAPI fails to link.
commit-queue@webkit.org [Thu, 12 Sep 2013 15:55:04 +0000 (15:55 +0000)]
[Win] TestWebKitAPI fails to link.
https://bugs.webkit.org/show_bug.cgi?id=121223

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-12
Reviewed by Brent Fulgham.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add required symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Compile errors, missing include.
commit-queue@webkit.org [Thu, 12 Sep 2013 15:52:10 +0000 (15:52 +0000)]
[WinCairo] Compile errors, missing include.
https://bugs.webkit.org/show_bug.cgi?id=121222

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-12
Reviewed by Brent Fulgham.

* platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: Include required header.
* platform/win/DragImageCairoWin.cpp: Include required header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: Inline PDF that are cached fail to appear in iframe.
zalan@apple.com [Thu, 12 Sep 2013 15:46:54 +0000 (15:46 +0000)]
REGRESSION: Inline PDF that are cached fail to appear in iframe.
https://bugs.webkit.org/show_bug.cgi?id=75449

Reviewed by Darin Adler.

Make sure 'frame is from page cache' flag is set for subframes too.

WebFrameLoaderClient::m_frameCameFromPageCache == true forces plugins
to be loaded manually. It ensures that the plugin raw data is fetched again
while the containing frame is being restored from the page cache.
(Plugins get destroyed when the frame goes to page cache.)

Source/WebKit2:

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
This gets called only on the frame where the actual history navigation happens.
(WebKit::WebFrameLoaderClient::didRestoreFromPageCache):
This gets called for all the restored frames.

LayoutTests:

* fast/history/history-back-while-pdf-in-pagecache-expected.html: Added.
* fast/history/history-back-while-pdf-in-pagecache.html: Added.
* fast/history/resources/history-back-for-pfd-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAuto GDB backtrace generation for EFL/GTK/Qt bots.
ossy@webkit.org [Thu, 12 Sep 2013 15:30:54 +0000 (15:30 +0000)]
Auto GDB backtrace generation for EFL/GTK/Qt bots.
https://bugs.webkit.org/show_bug.cgi?id=119338

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-12
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/port/efl.py:
(EflPort.check_sys_deps):
(EflPort):
(EflPort._get_crash_log):
* Scripts/webkitpy/port/efl_unittest.py:
(EflPortTest.test_show_results_html_file):
(EflPortTest):
(EflPortTest.test_get_crash_log):
* Scripts/webkitpy/port/gtk.py:
(GtkPort._get_crash_log):
* Scripts/webkitpy/port/gtk_unittest.py:
(GtkPortTest.test_get_crash_log):
* Scripts/webkitpy/port/linux_get_crash_log.py: Added.
(GDBCrashLogGenerator):
(GDBCrashLogGenerator.__init__):
(GDBCrashLogGenerator._get_gdb_output):
(GDBCrashLogGenerator.generate_crash_log):
(GDBCrashLogGenerator.generate_crash_log.match_filename):
* Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
(GDBCrashLogGeneratorTest):
(GDBCrashLogGeneratorTest.test_generate_crash_log):
(_mock_gdb_output):
* Scripts/webkitpy/port/qt.py:
(QtPort.default_child_processes):
(QtPort):
(QtPort._get_crash_log):
* Scripts/webkitpy/port/qt_unittest.py:
(QtPortTest.test_check_sys_deps):
(QtPortTest):
(QtPortTest.test_get_crash_log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd back c++11 features removed by buildfixes after all ports did the switch
ossy@webkit.org [Thu, 12 Sep 2013 15:28:14 +0000 (15:28 +0000)]
Add back c++11 features removed by buildfixes after all ports did the switch
https://bugs.webkit.org/show_bug.cgi?id=119266

Reviewed by Anders Carlsson.

* bytecode/GetByIdStatus.h:
(JSC::GetByIdStatus::GetByIdStatus):
* dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::~Worklist):
* interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::codeType):
(JSC::StackVisitor::Frame::functionName):
(JSC::StackVisitor::Frame::sourceURL):
(JSC::StackVisitor::Frame::print):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Moving myself to the commiters list.
galpeter@inf.u-szeged.hu [Thu, 12 Sep 2013 15:09:42 +0000 (15:09 +0000)]
Unreviewed. Moving myself to the commiters list.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Rebase after r155253.
kadam@inf.u-szeged.hu [Thu, 12 Sep 2013 14:56:07 +0000 (14:56 +0000)]
[Qt] Unreviewed gardening. Rebase after r155253.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-12

* platform/qt-wk2/editing/style/style-boundary-005-expected.png: Added.
* platform/qt/editing/pasteboard/4989774-expected.png:
* platform/qt/editing/pasteboard/4989774-expected.txt:
* platform/qt/editing/pasteboard/paste-match-style-001-expected.png:
* platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/qt/editing/selection/caret-ltr-2-expected.png:
* platform/qt/editing/selection/caret-ltr-2-expected.txt:
* platform/qt/editing/selection/caret-ltr-2-left-expected.png:
* platform/qt/editing/selection/caret-ltr-2-left-expected.txt:
* platform/qt/editing/selection/caret-ltr-expected.png:
* platform/qt/editing/selection/caret-ltr-expected.txt:
* platform/qt/editing/selection/caret-ltr-right-expected.png:
* platform/qt/editing/selection/caret-ltr-right-expected.txt:
* platform/qt/editing/selection/caret-rtl-2-expected.png:
* platform/qt/editing/selection/caret-rtl-2-expected.txt:
* platform/qt/editing/selection/caret-rtl-2-left-expected.png:
* platform/qt/editing/selection/caret-rtl-2-left-expected.txt:
* platform/qt/editing/selection/caret-rtl-expected.png:
* platform/qt/editing/selection/caret-rtl-expected.txt:
* platform/qt/editing/selection/caret-rtl-right-expected.png:
* platform/qt/editing/selection/caret-rtl-right-expected.txt:
* platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
* platform/qt/editing/style/style-boundary-005-expected.png:
* platform/qt/editing/style/style-boundary-005-expected.txt:
* platform/qt/fast/forms/formmove3-expected.txt:
* platform/qt/fast/forms/input-align-image-expected.png:
* platform/qt/fast/forms/input-align-image-expected.txt:
* platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.png:
* platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.txt:
* platform/qt/fast/invalid/003-expected.png:
* platform/qt/fast/invalid/003-expected.txt:
* platform/qt/tables/mozilla/bugs/bug647-expected.png:
* platform/qt/tables/mozilla/bugs/bug647-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add jhbuild-wayland.modules
changseok.oh@collabora.com [Thu, 12 Sep 2013 14:51:46 +0000 (14:51 +0000)]
[GTK] Add jhbuild-wayland.modules
https://bugs.webkit.org/show_bug.cgi?id=120455

Reviewed by Gustavo Noronha Silva.

Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
WEBKIT_EXTRA_MODULESETS.

* gtk/jhbuild-wayland.modules: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoXMLSerializer.serializeToString() should throw exception for invalid node value.
vivek.vg@samsung.com [Thu, 12 Sep 2013 14:41:49 +0000 (14:41 +0000)]
XMLSerializer.serializeToString() should throw exception for invalid node value.
https://bugs.webkit.org/show_bug.cgi?id=121209

Reviewed by Darin Adler.

Source/WebCore:

FF and Opera 12 (pre blink/webkit) throw exception in case the node value is invalid.
Blink sends an empty string as the result of serializeToString operation with invalid node.
We should match with other browsers for throwing it as an exception.

Blink review URL: https://chromiumcodereview.appspot.com/23532055/

Test: fast/dom/xmlserializer-serialize-to-string-exception.html

* xml/XMLSerializer.cpp:
(WebCore::XMLSerializer::serializeToString):

LayoutTests:

* fast/dom/xmlserializer-serialize-to-string-exception-expected.txt: Added.
* fast/dom/xmlserializer-serialize-to-string-exception.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in ScrollingStateStickyNode::updateConstraints
zalan@apple.com [Thu, 12 Sep 2013 14:27:43 +0000 (14:27 +0000)]
Crash in ScrollingStateStickyNode::updateConstraints
https://bugs.webkit.org/show_bug.cgi?id=119638

Reviewed by Simon Fraser.

Ensure when a scrolling state node is removed from the state tree,
we remove both the current node and all its children from the
associated m_stateNodeMap lookup table.

Source/WebCore:

Test: fast/css/sticky/multiple-layers-sticky-crash.html

* page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::removeChild):
(WebCore::ScrollingStateNode::willBeRemovedFromStateTree):
* page/scrolling/ScrollingStateNode.h:

LayoutTests:

* fast/css/sticky/multiple-layers-sticky-crash-expected.txt: Added.
* fast/css/sticky/multiple-layers-sticky-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r132516): Javascript menu text incorrectly disappearing and reappearing
zalan@apple.com [Thu, 12 Sep 2013 14:03:21 +0000 (14:03 +0000)]
REGRESSION (r132516): Javascript menu text incorrectly disappearing and reappearing
https://bugs.webkit.org/show_bug.cgi?id=101047

Reviewed by Simon Fraser.

Compositing layers keep track of ancestors' clipping by constructing the RenderLayerBacking::m_ancestorClippingLayer.
It helps setting up the proper clipping context for the corresponding graphics layer.
When a RenderObject's clipping style changes, it needs to propagate this change not only
to the associated RenderLayer, but also to the descendants', if applicable.
Before r132516, it was mainly covered by initiating full style recalcs, which ensured that
style recalc on the descendant rendering tree took care of creating/destroying
RenderLayerBacking::m_ancestorClippingLayer at every compositing layer node. Without the full
recalc, the clipping of the compositing render layers and the corresponding render subtrees can get out of sync.
This patch updates the clipping context on the descendant subtree, when the clipping behaviour
changes on a render node.

Source/WebCore:

Tests: compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html
       compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateDescendantClippingContext):
(WebCore::RenderLayer::styleChanged):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateAncestorClippingLayer):
(WebCore::RenderLayerBacking::updateDescendantClippingLayer):
* rendering/RenderLayerBacking.h:

LayoutTests:

* compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added.
* compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html: Added.
* compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added.
* compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][WK2] a11y tests unconditionally launching a11y daemons
commit-queue@webkit.org [Thu, 12 Sep 2013 11:15:47 +0000 (11:15 +0000)]
[GTK][WK2] a11y tests unconditionally launching a11y daemons
https://bugs.webkit.org/show_bug.cgi?id=120299

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-09-12
Reviewed by Carlos Garcia Campos.

Use the right variable name to store a reference to the at-spi2
bus launcher process, so we can be sure we are terminating it when
calling _tear_down_testing_environment().

* Scripts/run-gtk-tests:
(TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
instead of _ally_bus_launcher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is...
carlosgc@webkit.org [Thu, 12 Sep 2013 10:54:50 +0000 (10:54 +0000)]
[GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
https://bugs.webkit.org/show_bug.cgi?id=121218

Reviewed by Philippe Normand.

Skipping the entire suite was added to skip tests when they can't
be run because of the environment, for example to skip the a11y
tests when the at-spi daemons fail to start. This is no longer
true for all the cases, so we can disable the tests that are
impossible to run instead of skipping them.

* Scripts/run-gtk-tests:
(TestRunner.__init__): Initialize the skipped tests list.
(TestRunner._setup_testing_environment): Add
TestWebKitAccessibility path to the list of disabled tests when
at-spi daemon fail to start.
(TestRunner._should_run_test_program): Check first if the test
program is disabled and then whether it's skipped honoring the
skipped command line option.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove home-brewed nullptr
mikhail.pozdnyakov@intel.com [Thu, 12 Sep 2013 10:42:08 +0000 (10:42 +0000)]
Remove home-brewed nullptr
https://bugs.webkit.org/show_bug.cgi?id=119624

Reviewed by Anders Carlsson.

The standard C++11 nullptr and std::nullptr_t type should be used now.

Source/JavaScriptCore:

* heap/PassWeak.h:
* heap/Weak.h:

Source/WebCore:

* bindings/js/JSDOMBinding.h:

Source/WebKit/efl:

* tests/UnitTestUtils/EWKTestView.cpp:

Source/WTF:

* GNUmakefile.list.am:
* WTF.pro:
* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/NullPtr.cpp: Removed.
* wtf/NullPtr.h: Removed.
* wtf/OwnArrayPtr.h:
* wtf/OwnPtr.h:
* wtf/PassOwnPtr.h:
* wtf/PassRefPtr.h:
* wtf/RetainPtr.h:
* wtf/win/GDIObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<meter> element text value exposed as AXTitle; should be exposing AXValueDescription
commit-queue@webkit.org [Thu, 12 Sep 2013 10:24:52 +0000 (10:24 +0000)]
<meter> element text value exposed as AXTitle; should be exposing AXValueDescription
https://bugs.webkit.org/show_bug.cgi?id=117651

Patch by Samuel White <samuel_white@apple.com> on 2013-09-12
Reviewed by Mario Sanchez Prada.

Source/WebCore:

No new tests, updated accessibility/meter-element to handle platform specific output.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isMeter):
* accessibility/AccessibilityObject.h:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools:

Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::valueDescription):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::valueDescription):

LayoutTests:

Updated existing meter element test to cover platform specific output.

* accessibility/meter-element.html:
* platform/mac/accessibility/aria-valuetext-on-native-slider-expected.txt:
* platform/mac/accessibility/aria-valuetext-on-native-slider.html:
* platform/mac/accessibility/aria-valuetext.html:
* platform/mac/accessibility/meter-element-expected.txt: Renamed from LayoutTests/accessibility/meter-element-expected.txt.
* platform/mac/accessibility/spinbutton-valuedescription-expected.txt:
* platform/mac/accessibility/spinbutton-valuedescription.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoclass WeekInputType invokes wrong constructor
commit-queue@webkit.org [Thu, 12 Sep 2013 09:54:52 +0000 (09:54 +0000)]
class WeekInputType invokes wrong constructor
https://bugs.webkit.org/show_bug.cgi?id=120768

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-12
Reviewed by Andreas Kling.

Correcting wrong constuctor invocation.

* html/WeekInputType.h:
(WebCore::WeekInputType::WeekInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: Self-referencing aria-labelledby only uses contents.
commit-queue@webkit.org [Thu, 12 Sep 2013 09:51:25 +0000 (09:51 +0000)]
AX: Self-referencing aria-labelledby only uses contents.
https://bugs.webkit.org/show_bug.cgi?id=120814

Patch by Samuel White <samuel_white@apple.com> on 2013-09-12
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Implemented additional 'Text Alternative Computation' steps documented at:
http://www.w3.org/WAI/PF/aria/complete#textalternativecomputation. This allows us to remove
our raw text node iteration that was previously forcing us to do our computation incorrectly.
Element content is now sourced using textUnderElement (step 2C of the computation).

Test: accessibility/self-referencing-aria-labelledby.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):

LayoutTests:

Test to verify that self-referencing aria-labelledby behavior works as expected.

* accessibility/self-referencing-aria-labelledby-expected.txt: Added.
* accessibility/self-referencing-aria-labelledby.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r155597.
commit-queue@webkit.org [Thu, 12 Sep 2013 09:38:59 +0000 (09:38 +0000)]
Unreviewed, rolling out r155597.
http://trac.webkit.org/changeset/155597
https://bugs.webkit.org/show_bug.cgi?id=121220

broke windows build because there's no ews :( (Requested by
thorton on #webkit).

* WebCore.exp.in:
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::isBitmapImage):
* platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::create):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawPattern):
* platform/graphics/CrossfadeGeneratedImage.h:
(WebCore::CrossfadeGeneratedImage::setContainerSize):
(WebCore::CrossfadeGeneratedImage::usesContainerSize):
(WebCore::CrossfadeGeneratedImage::hasRelativeWidth):
(WebCore::CrossfadeGeneratedImage::hasRelativeHeight):
(WebCore::CrossfadeGeneratedImage::size):
* platform/graphics/GeneratedImage.h:
(WebCore::GeneratedImage::hasSingleSecurityOrigin):
(WebCore::GeneratedImage::setContainerSize):
(WebCore::GeneratedImage::usesContainerSize):
(WebCore::GeneratedImage::hasRelativeWidth):
(WebCore::GeneratedImage::hasRelativeHeight):
(WebCore::GeneratedImage::size):
(WebCore::GeneratedImage::destroyDecodedData):
(WebCore::GeneratedImage::decodedSize):
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
* platform/graphics/GeneratorGeneratedImage.h:
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):
* svg/graphics/SVGImage.h:
(WebCore::SVGImage::isSVGImage):
(WebCore::SVGImage::usesContainerSize):
(WebCore::SVGImage::destroyDecodedData):
(WebCore::SVGImage::decodedSize):
* svg/graphics/SVGImageForContainer.h:
(WebCore::SVGImageForContainer::destroyDecodedData):
(WebCore::SVGImageForContainer::decodedSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r154781): accessibility/notification-listeners.html is failing
commit-queue@webkit.org [Thu, 12 Sep 2013 09:31:28 +0000 (09:31 +0000)]
REGRESSION(r154781): accessibility/notification-listeners.html is failing
https://bugs.webkit.org/show_bug.cgi?id=120669

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-12
Reviewed by Chris Fleizach.

Tools:

Fixed 4 problems that were causing notification-listeners.html to fail.

Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
implemented in axObjectEventListener().

A notification for AXFocusedUIElementChanged was incorrectly sent when
the element lost focus.

Global notification was not dispatched if an element notification was
present in the HashMap.

connectAccessibilityCallbacks() was connecting signals to callbacks
multiple times because it was not checking if
disconnectAccessibilityCallbacks() had an early return if there were
active handlers.

* DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
disconnectAccessibilityCallbacks() to inform if the callbacks were
successfully disconnected.
* DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
(axObjectEventListener): Implemented notifications for
AXFocusedUIElementChanged and AXValueChanged. Fixed the global
notification, which was not dispatched if an element notification
existed. Fixed the notification for AXFocusedUIElementChanged that was
incorrectly sent when the element lost focus. In addition, fixed a typo
where TRUE should be true.
(connectAccessibilityCallbacks): Added early return if
disconnectAccessibilityCallbacks() did not disconnect the callbacks.
(disconnectAccessibilityCallbacks): Added a return value to inform if
callbacks were successfully disconnected.

LayoutTests:

Updated the expectation for notification-listeners.html, which was
failing before this fix.

* platform/gtk/TestExpectations: Removed notification-listeners.html.
* platform/gtk/accessibility/notification-listeners-expected.txt:
Updated the expectation for notification-listeners.html. There is one
difference from the results on the Mac port, which was used as
reference. The element role for <select> is AXComboBox while on Mac
is AXPopUpButton.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderWidget elements are always HTMLFrameOwnerElement subclasses.
akling@apple.com [Thu, 12 Sep 2013 09:12:29 +0000 (09:12 +0000)]
RenderWidget elements are always HTMLFrameOwnerElement subclasses.
<https://webkit.org/b/121217>

Reviewed by Antti Koivisto.

Make RenderWidget constructor take HTMLFrameOwnerElement* and update subclasses
with even tighter types where possible.

Also added RenderWidget::frameOwnerElement() and deleted element().
Removed a handful of unnecessary type checks that were exposed by this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoApply OVERRIDE and FINAL to Image subclasses and clean them up
timothy_horton@apple.com [Thu, 12 Sep 2013 09:03:55 +0000 (09:03 +0000)]
Apply OVERRIDE and FINAL to Image subclasses and clean them up
https://bugs.webkit.org/show_bug.cgi?id=121086

Reviewed by Alexey Proskuryakov.

Everything other than the copious application of OVERRIDE and FINAL
is explicitly called out below.

* WebCore.exp.in:
Export the correct version of getCGImageRef for use by WebKit2.

* platform/graphics/BitmapImage.cpp:
* platform/graphics/BitmapImage.h:
Drive-by inline isBitmapImage.
Move create(HBITMAP) to be near the other create() functions.
Move all of the members and quite a few functions from protected to private.
Devirtualize frameCount().
Move notSolidColor() near the other solid color functions.

* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawPattern):
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
Use size() and setContainerSize() instead of directly accessing a
superclass' (now private, previously protected) members.

* platform/graphics/CrossfadeGeneratedImage.h:
* platform/graphics/GeneratedImage.h:
Make m_size private, I don't think we do protected members.

* platform/graphics/GeneratorGeneratedImage.h:
Make all the members private.

* svg/graphics/SVGImage.h:
* svg/graphics/SVGImageForContainer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCanvas fillText and measureText handle ideographic spaces differently
commit-queue@webkit.org [Thu, 12 Sep 2013 06:21:47 +0000 (06:21 +0000)]
Canvas fillText and measureText handle ideographic spaces differently
https://bugs.webkit.org/show_bug.cgi?id=108881

Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-09-11
Reviewed by Darin Adler.

Source/WebCore:

According to spec for text preparation algorithm
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#text-preparation-algorithm
all the space characters mentioned in the spec
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#space-character
should be replaced by U+0020 space character.
The canvas functions fillText and measureText should run the text preparation algorithm.
This patch modifies the canvas functions drawTextInternal and measureText to conform to the above spec.

Tests: fast/canvas/canvas-measureText-ideographicSpace.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::shouldSpaceBeReplaced):
(WebCore::replaceCharacterInString):
(WebCore::CanvasRenderingContext2D::measureText):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

According to the text preparation algorithm defined in the spec
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#text-preparation-algorithm
all the spaces listed in the spec
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#space-character
should be replaced by +U0020 space character.
The below listed layout tests verify the conformance to above spec.
These tests are passing on Ubuntu-Firefox 23.0.

* fast/canvas/canvas-measureText-ideographicSpace-expected.txt: Added.
* fast/canvas/canvas-measureText-ideographicSpace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename initInteger() to initInt32()
fpizlo@apple.com [Thu, 12 Sep 2013 05:55:10 +0000 (05:55 +0000)]
Rename initInteger() to initInt32()

Rubber stamped by Mark Hahnenberg.

* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::initInt32):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::integerResult):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename IntegerOperand to Int32Operand and fillInteger() to fillInt32().
fpizlo@apple.com [Thu, 12 Sep 2013 05:52:06 +0000 (05:52 +0000)]
Rename IntegerOperand to Int32Operand and fillInteger() to fillInt32().

Rubber stamped by Mark Hahnenberg.

* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::fillInt32):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::Int32Operand::Int32Operand):
(JSC::DFG::Int32Operand::~Int32Operand):
(JSC::DFG::Int32Operand::gpr):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixupPhase should always call fixEdge() exactly once for every edge
fpizlo@apple.com [Thu, 12 Sep 2013 05:46:49 +0000 (05:46 +0000)]
FixupPhase should always call fixEdge() exactly once for every edge
https://bugs.webkit.org/show_bug.cgi?id=121211

Reviewed by Geoffrey Garen.

Previously we only call fixEdge() on edges that we want to make typed. UntypedUse
edges don't get fixEdge() called. This makes it difficult to add functionality in
fixEdge() that runs for UntypedUses. It's difficult to remember to call fixEdge()
for every edge that we don't want to turn into a typed edge; in an alternative
universe where we did this, it would mean that every case in FixupPhase would
have to make a fixEdge() call for *every* edge even ones that it doesn't want to
modify.

This patch takes a different path. fixEdge() must never be called explicitly with
UntypedUse. fixEdge() should be used to set the UseKind of edges. Consequently,
all that FixupPhase has to do is call fixEdge<UntypedUse>(edge) for every edge
that was still UntypedUse after we are done processing a node.

This is cheap and easy to implement and ought to be easy to maintain. We won't
have a need to call fixEdge<UntypedUse>(edge) explicitly, so depending on that is
only natural.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::observeUntypedEdge):
(JSC::DFG::FixupPhase::observeUseKindOnNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Windows build.
akling@apple.com [Thu, 12 Sep 2013 05:36:36 +0000 (05:36 +0000)]
Fix Windows build.

* rendering/RenderingAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMerge RenderPart into RenderWidget.
akling@apple.com [Thu, 12 Sep 2013 05:21:14 +0000 (05:21 +0000)]
Merge RenderPart into RenderWidget.
<https://webkit.org/b/121200>

Reviewed by Anders Carlsson.

Remove the RenderPart class and move its functionality into RenderWidget.
It was acting as a pointless extra layer between RenderWidget and renderers
for embedded objects, frames and iframes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixupPhase's setUseKindAndUnboxBlahbittyblah and fixDoubleEdge methods should be...
fpizlo@apple.com [Thu, 12 Sep 2013 04:48:13 +0000 (04:48 +0000)]
FixupPhase's setUseKindAndUnboxBlahbittyblah and fixDoubleEdge methods should be merged and given intuitive names
https://bugs.webkit.org/show_bug.cgi?id=121202

Reviewed by Geoffrey Garen.

Got rid of a method whose name was so descriptive that I couldn't ever remember
it. And despite the descriptive name, I always had to look at its implementation
to remind myself what it did, anyway.

Now that method is called fixEdge(). This is a good name because we're in a phase
called FixupPhase, and we call this fixEdge() method on pretty much every edge.
For the Int48 work, it makes more sense for this method to be a kind of hook into
which we can place various things: it's just a way of observing edges that need
attention.

As part of this refactoring, I also fold fixDoubleEdge into fixEdge. This makes
sense because previously it was never correct to call fixDoubleEdge with non-
double use kinds; and conversely it was never correct to call fixEdge with double
use kinds.

Also I found that isDouble() in DFGUseKind.h would return true for KnownInt32Use.
That's almost certainly wrong, and removing that behavior doesn't fail any tests.
I'm assuming that was just a bug.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToPrimitive):
(JSC::DFG::FixupPhase::fixupToString):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixEdge):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):
(JSC::DFG::FixupPhase::convertToGetArrayLength):
(JSC::DFG::FixupPhase::attemptToMakeGetTypedArrayByteOffset):
* dfg/DFGUseKind.h:
(JSC::DFG::isDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved some unused functions from the debugger interface
ggaren@apple.com [Thu, 12 Sep 2013 03:08:25 +0000 (03:08 +0000)]
Removed some unused functions from the debugger interface
https://bugs.webkit.org/show_bug.cgi?id=121194

Reviewed by Joseph Pecoraro.

We plan to use the "evaluate" API and debugger activation property access for all the features we need.

Source/WebCore:

* inspector/JavaScriptCallFrame.idl: These are the interfaces I removed.

* bindings/js/JSJavaScriptCallFrameCustom.cpp:
* inspector/InjectedScript.cpp:
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setScriptSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/JavaScriptCallFrame.idl:
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.):
(WebInspector.RemoteObject.prototype.setPropertyValue): These files are mechanical removals of code that used
or implemented the interfaces I removed.

Source/WebInspectorUI:

* UserInterface/InspectorBackendCommands.js: Updated by script.

LayoutTests:

* inspector/debugger/debugger-change-variable-expected.txt: Removed.
* inspector/debugger/debugger-change-variable.html: Removed. This test was failing
because we don't support this API.

* platform/mac/inspector/console/command-line-api-expected.txt: This test changed line numbers
because I changed inspector .js files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTry to fix GCC builds.
andersca@apple.com [Thu, 12 Sep 2013 02:52:19 +0000 (02:52 +0000)]
Try to fix GCC builds.

* TestWebKitAPI/Tests/WTF/MoveOnly.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTry to fix the build.
andersca@apple.com [Thu, 12 Sep 2013 02:26:48 +0000 (02:26 +0000)]
Try to fix the build.

Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
file in the Tests/ directory in the first place.

* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed indentation in JSC Debugger header files.
mark.lam@apple.com [Thu, 12 Sep 2013 02:26:14 +0000 (02:26 +0000)]
Fixed indentation in JSC Debugger header files.
https://bugs.webkit.org/show_bug.cgi?id=121203.

Reviewed by Ryosuke Niwa.

* debugger/Debugger.h:
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::create):
(JSC::DebuggerActivation::createStructure):
* debugger/DebuggerCallFrame.h:
(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::callFrame):
(JSC::DebuggerCallFrame::dynamicGlobalObject):
(JSC::DebuggerCallFrame::scope):
(JSC::DebuggerCallFrame::exception):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse the new C++11 function declaration syntax throughout our hash collection classes
andersca@apple.com [Thu, 12 Sep 2013 02:16:57 +0000 (02:16 +0000)]
Use the new C++11 function declaration syntax throughout our hash collection classes
https://bugs.webkit.org/show_bug.cgi?id=121195

Reviewed by Andreas Kling.

* wtf/HashMap.h:
* wtf/HashSet.h:
* wtf/HashTable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDOMParser.parseFromString() should support creating HTML Document with mime-type...
vivek.vg@samsung.com [Thu, 12 Sep 2013 01:41:46 +0000 (01:41 +0000)]
DOMParser.parseFromString() should support creating HTML Document with mime-type text/html
https://bugs.webkit.org/show_bug.cgi?id=120826

Reviewed by Darin Adler.

Source/WebCore:

The specification http://domparsing.spec.whatwg.org/#the-domparser-interface for DOMParser.parseFromString()
allows the document creation if the mimeType is one of the supported types:
["text/html", "text/xml", "application/xml", "application/xhtml+xml", "image/svg+xml"]

Also script elements get marked unexecutable and the contents of noscript get parsed as markup.

blink review URL: https://codereview.chromium.org/23903014/

Test: fast/dom/domparser-parsefromstring-mimetype-support.html

* xml/DOMParser.cpp:
(WebCore::DOMParser::parseFromString):

LayoutTests:

* fast/dom/domparser-parsefromstring-mimetype-support-expected.txt: Added.
* fast/dom/domparser-parsefromstring-mimetype-support.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Shapes] Improve the performance of image valued shapes
hmuller@adobe.com [Thu, 12 Sep 2013 01:21:43 +0000 (01:21 +0000)]
[CSS Shapes] Improve the performance of image valued shapes
https://bugs.webkit.org/show_bug.cgi?id=120211

Reviewed by Alexandru Chiculita.

Replaced the implementation of RasterShapeIntervals with one based on the
new ShapeInterval<int> class. This eliminates the dependency the Region class
and delivers a 10X layout speedup for large image valued shapes.

This a just an implementation refactoring, no new tests were needed.

* rendering/shapes/RasterShape.cpp:
(WebCore::RasterShapeIntervals::appendInterval): Renamed this method, it was called addInterval().
(WebCore::shapeIntervalsContain):
(WebCore::RasterShapeIntervals::contains):
(WebCore::RasterShapeIntervals::getIntervalsInLine):
(WebCore::compareX1):
(WebCore::RasterShapeIntervals::firstIncludedIntervalY):
(WebCore::RasterShapeIntervals::getIncludedIntervals):
(WebCore::RasterShapeIntervals::getExcludedIntervals):
(WebCore::RasterShape::getExcludedIntervals):
(WebCore::RasterShape::getIncludedIntervals):
* rendering/shapes/RasterShape.h:
(WebCore::RasterShapeIntervals::RasterShapeIntervals): The constructor now takes a size argument which is used to allocate IntShapeIntervals storage.
(WebCore::RasterShapeIntervals::size):
(WebCore::RasterShapeIntervals::bounds):
(WebCore::RasterShapeIntervals::isEmpty):
(WebCore::RasterShapeIntervals::getIntervals):
* rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape): Use appendInterval() instead of addInterval() (see above) and the new RasterShapeIntervals constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake sure that layout is up-to-date when moving a WKView into a window, to avoid...
simon.fraser@apple.com [Thu, 12 Sep 2013 00:51:38 +0000 (00:51 +0000)]
Make sure that layout is up-to-date when moving a WKView into a window, to avoid !needsLayout() assertions in RenderView::paint()
https://bugs.webkit.org/show_bug.cgi?id=121196

Reviewed by Tim Horton.

When a WKView was moved into a window, it was possible for us to paint
without ensuring that layout is up-to-date. Fix this by having
WebPage::setIsInWindow() update layout if we are moving to a window.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setIsInWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Build fix for MoveOnly
bfulgham@apple.com [Thu, 12 Sep 2013 00:40:15 +0000 (00:40 +0000)]
[Windows] Build fix for MoveOnly

* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
Tests to include search path.
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd HashSet::take
andersca@apple.com [Thu, 12 Sep 2013 00:30:48 +0000 (00:30 +0000)]
Add HashSet::take
https://bugs.webkit.org/show_bug.cgi?id=121192

Reviewed by Darin Adler.

Source/WTF:

This is mostly done to see if we can use the new C++11 function declaration syntax,
and for parity with HashMap::take.

* wtf/HashMap.h:
* wtf/HashSet.h:

Tools:

Add a test for HashSet::take.

* TestWebKitAPI/Tests/WTF/HashSet.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[MediaStream API] Updating NavigatorUserMediaError to match the spec
eric.carlson@apple.com [Wed, 11 Sep 2013 23:46:44 +0000 (23:46 +0000)]
[MediaStream API] Updating NavigatorUserMediaError to match the spec
https://bugs.webkit.org/show_bug.cgi?id=120880

Reviewed by Darin Adler.

Merge https://chromium.googlesource.com/chromium/blink/+/f07305e49ddebaa166f5dee514bcc881a8efd341
by Tommy Widenflycht.

The Blink change did not have any test changes because they don't appear to have any tests
for NavigatorUserMediaError. I can't add tests now because the MediaStream feature isn't enabled
yet, so https://bugs.webkit.org/show_bug.cgi?id=121182 tracks adding tests.

* Modules/mediastream/NavigatorUserMediaError.h:
(WebCore::NavigatorUserMediaError::create):
(WebCore::NavigatorUserMediaError::name):
(WebCore::NavigatorUserMediaError::message):
(WebCore::NavigatorUserMediaError::constraintName):
(WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
* Modules/mediastream/NavigatorUserMediaError.idl:
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::fail):
(WebCore::UserMediaRequest::failConstraint):
* Modules/mediastream/UserMediaRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove needsDataFormatConversion because it is unused.
fpizlo@apple.com [Wed, 11 Sep 2013 23:46:31 +0000 (23:46 +0000)]
Remove needsDataFormatConversion because it is unused.

Rubber stamped by Mark Hahnenberg.

* bytecode/DataFormat.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHashSet should work with move only types
andersca@apple.com [Wed, 11 Sep 2013 23:36:39 +0000 (23:36 +0000)]
HashSet should work with move only types
https://bugs.webkit.org/show_bug.cgi?id=121188

Reviewed by Geoffrey Garen.

Source/WTF:

* wtf/HashSet.h:
(WTF::HashSet::add):
Add a new rvalue reference overload and use std::move when calling HashTable::add.

* wtf/HashTable.h:
(WTF::IdentityHashTranslator::translate):
Change this to take an rvalue reference for the value so we can invoke the move assignment operator.

(WTF::HashTable::add):
Call the add member function template, using std::move to move the value.

(WTF::HashTable::add):
Add std::forward so we'll potentially move extra.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/MoveOnly.h: Added.
Move the MoveOnly class from Vector out into its own header.

* TestWebKitAPI/Tests/WTF/HashSet.cpp:
(TestWebKitAPI::TEST):
Add aHashSet<MoveOnly> test.

* TestWebKitAPI/Tests/WTF/Vector.cpp:
Include MoveOnly.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename fillSpeculateInt to fillSpeculateInt32.
fpizlo@apple.com [Wed, 11 Sep 2013 23:34:35 +0000 (23:34 +0000)]
Rename fillSpeculateInt to fillSpeculateInt32.

Rubber stamped by Mark Hahnenberg.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculateInt32Operand::gpr):
(JSC::DFG::SpeculateStrictInt32Operand::gpr):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32):
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32Strict):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32):
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32Strict):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename DataFormatInteger to DataFormatInt32.
fpizlo@apple.com [Wed, 11 Sep 2013 23:28:09 +0000 (23:28 +0000)]
Rename DataFormatInteger to DataFormatInt32.

Rubber stamped by Mark Hahnenberg.

* bytecode/DataFormat.h:
(JSC::dataFormatToString):
(JSC::needDataFormatConversion):
(JSC::isJSInt32):
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::displacedInJSStack):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::initInteger):
(JSC::DFG::GenerationInfo::isJSInt32):
(JSC::DFG::GenerationInfo::fillInteger):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::integerResult):
(JSC::DFG::SpeculativeJIT::jsValueResult):
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::IntegerOperand::format):
(JSC::DFG::SpeculateInt32Operand::format):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGValueSource.h:
(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFlaky Test: http/tests/inspector/inspect-element.html
joepeck@webkit.org [Wed, 11 Sep 2013 22:58:39 +0000 (22:58 +0000)]
Flaky Test: http/tests/inspector/inspect-element.html
https://bugs.webkit.org/show_bug.cgi?id=78869

Reviewed by Alexey Proskuryakov.

Add a check to fix flakiness when multiple inspector tests run. The
issue is with the old frontend, and does not affect the new frontend.

* http/tests/inspector/inspect-element.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: Remove LocalMediaStream
commit-queue@webkit.org [Wed, 11 Sep 2013 22:32:26 +0000 (22:32 +0000)]
MediaStream API: Remove LocalMediaStream
https://bugs.webkit.org/show_bug.cgi?id=120875

blink merge: https://chromium.googlesource.com/chromium/blink/+/81643ee3fe048a64fa8931132e1294fa2c8e821a

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-11
Reviewed by Eric Carlson.

Source/WebCore:

Existing tests were updated.

* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.list.am:
* Modules/mediastream/LocalMediaStream.cpp: Removed.
* Modules/mediastream/LocalMediaStream.h: Removed.
* Modules/mediastream/LocalMediaStream.idl: Removed.
* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::stop):
* Modules/mediastream/MediaStream.h:
* Modules/mediastream/MediaStream.idl:
* Modules/mediastream/NavigatorUserMediaSuccessCallback.h:
* Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::succeed):
* Modules/mediastream/UserMediaRequest.h:
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource):
* Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
* WebCore.xcodeproj/project.pbxproj:
* dom/EventTarget.h:
* dom/EventTargetFactory.in:
* platform/mediastream/MediaStreamDescriptor.h:

LayoutTests:

* fast/mediastream/LocalMediaStream-onended-expected.txt: Removed.
* fast/mediastream/LocalMediaStream-onended.html: Removed.
* fast/mediastream/MediaStream-onended-expected.txt:
* fast/mediastream/MediaStream-onended.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove PlatformInstrumentation since we don't show decode or resize in the new Web...
timothy@apple.com [Wed, 11 Sep 2013 22:31:05 +0000 (22:31 +0000)]
Remove PlatformInstrumentation since we don't show decode or resize in the new Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=121181

Reviewed by Joseph Pecoraro.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.order:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::clearRecordStack):
* inspector/InspectorTimelineAgent.h:
* platform/PlatformInstrumentation.cpp: Removed.
* platform/PlatformInstrumentation.h: Removed.
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::frameBufferAtIndex):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameBufferAtIndex):
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::frameBufferAtIndex):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::frameBufferAtIndex):
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::frameBufferAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAvoid copying a hash table bucket when inserting causes a rehash
andersca@apple.com [Wed, 11 Sep 2013 22:27:23 +0000 (22:27 +0000)]
Avoid copying a hash table bucket when inserting causes a rehash
https://bugs.webkit.org/show_bug.cgi?id=121185

Reviewed by Darin Adler.

Allow rehashing to track a hash bucket and return the new pointer to it, thus avoiding
having to do a copy of a hash table bucket as well as an extra hash lookup.

* wtf/HashTable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [Windows] Avoid converting from IntSize->SIZE->IntSize.
bfulgham@apple.com [Wed, 11 Sep 2013 22:17:49 +0000 (22:17 +0000)]
Source/WebCore: [Windows] Avoid converting from IntSize->SIZE->IntSize.
https://bugs.webkit.org/show_bug.cgi?id=121180

Reviewed by Anders Carlsson.

* platform/graphics/BitmapImage.h: Take const IntSize* as
argument, rather than LPSIZE.
* platform/graphics/Image.h: Ditto.
(WebCore::Image::getHBITMAPOfSize):
* platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize): Use passed-in
IntSize, rather than converting from SIZE.
* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize): Ditto.

Source/WebKit: [Windows] Avoid converting from IntSize->SIZE->IntSize
https://bugs.webkit.org/show_bug.cgi?id=121180

Reviewed by Anders Carlsson.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Remove unused symbol export.

Source/WebKit/win: [Windows] Avoid converting from IntSize->SIZE->IntSize
https://bugs.webkit.org/show_bug.cgi?id=121180

Reviewed by Anders Carlsson.

* WebIconDatabase.cpp:
(WebIconDatabase::iconForURL): Guard against null SIZE argument.
This was dereferenced with checking before! Use IntSize arguments.
(WebIconDatabase::defaultIconWithSize): Used passed-in IntSize.
(createDIB): Take an IntSize argument.
(WebIconDatabase::getOrCreateSharedBitmap): Take IntSize argument.
(WebIconDatabase::getOrCreateDefaultIconBitmap): Ditto.
* WebIconDatabase.h: Update for IntSize arguments.
* WebView.cpp:
(WebView::dispatchDidReceiveIconFromWebFrame): Pass address of
IntSize directly, rather than casting to SIZE first.

Tools: [Windows] Avoid converting from IntSize->SIZE->IntSize
https://bugs.webkit.org/show_bug.cgi?id=121180

Reviewed by Anders Carlsson.

* TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
(TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed debug build fix after r155567.
zoltan@webkit.org [Wed, 11 Sep 2013 22:08:45 +0000 (22:08 +0000)]
Unreviewed debug build fix after r155567.

* rendering/LineWidth.cpp:
(WebCore::LineWidth::LineWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r155561): extract-localizable-strings can miss strings
mitz@apple.com [Wed, 11 Sep 2013 22:07:12 +0000 (22:07 +0000)]
REGRESSION (r155561): extract-localizable-strings can miss strings
https://bugs.webkit.org/show_bug.cgi?id=121184

Reviewed by Darin Adler.

* Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
parenthesis or bracket.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInt32ToDouble should be predicted SpecInt48 and predictions should have nothing to...
fpizlo@apple.com [Wed, 11 Sep 2013 21:49:47 +0000 (21:49 +0000)]
Int32ToDouble should be predicted SpecInt48 and predictions should have nothing to do with constant folding
https://bugs.webkit.org/show_bug.cgi?id=121141

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Just changing Int32ToDouble to be predicted SpecInt48 breaks constant folding on that
node because of soooper old code that prevented constant folding on mismatched
predictions. Kill that code.

* dfg/DFGAbstractInterpreter.h:
(JSC::DFG::AbstractInterpreter::setConstant):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):

LayoutTests:

Reviewed by Oliver Hunt.

Fixing this means that this test no longer recompiles.

* js/script-tests/dfg-constant-fold-misprediction.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Unreviewed build fix.
bfulgham@apple.com [Wed, 11 Sep 2013 21:40:59 +0000 (21:40 +0000)]
[Windows] Unreviewed build fix.

* wtf/win/GDIObject.h:
(WTF::GDIObject::GDIObject): I forgot to check in as part of
r155557 by using webkit-patch land in a sub-directory!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove LineWidth out of RenderBlockLineLayout
zoltan@webkit.org [Wed, 11 Sep 2013 21:29:37 +0000 (21:29 +0000)]
Move LineWidth out of RenderBlockLineLayout
https://bugs.webkit.org/show_bug.cgi?id=121107

Reviewed by David Hyatt.

Move LineWidth class and related code into LineWidth.{h,cpp}.

No new tests, no behavior change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/LineWidth.cpp: Added.
(WebCore::LineWidth::applyOverhang):
(WebCore::LineWidth::fitBelowFloats):
* rendering/LineWidth.h: Added.
(WebCore::logicalHeightForLine):
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineIncludingExtraWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::currentWidth):
(WebCore::LineWidth::uncommittedWidth):
(WebCore::LineWidth::committedWidth):
(WebCore::LineWidth::availableWidth):
(WebCore::LineWidth::addUncommittedWidth):
(WebCore::LineWidth::commit):
(WebCore::LineWidth::setTrailingWhitespaceWidth):
(WebCore::LineWidth::shouldIndentText):
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
* rendering/RenderBlockLineLayout.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVariableAccessData::flushFormat() should be the universal way of deciding how to...
fpizlo@apple.com [Wed, 11 Sep 2013 21:24:34 +0000 (21:24 +0000)]
VariableAccessData::flushFormat() should be the universal way of deciding how to speculate on stores to locals and how locals are formatted
https://bugs.webkit.org/show_bug.cgi?id=121142

Reviewed by Geoffrey Garen.

Make everyone rely on VariableAccessData::flushFormat() instead of trying to
compute that information from scratch. The FTL already used flushFormat(), now
the DFG does, too.

* dfg/DFGArgumentPosition.h:
(JSC::DFG::ArgumentPosition::someVariable):
(JSC::DFG::ArgumentPosition::flushFormat):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::forFlushFormat):
* dfg/DFGVariableAccessDataDump.cpp:
(JSC::DFG::VariableAccessDataDump::dump):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPartial Information Leakage in Hash Table implementations (PrivateName)
oliver@apple.com [Wed, 11 Sep 2013 21:22:00 +0000 (21:22 +0000)]
Partial Information Leakage in Hash Table implementations (PrivateName)
https://bugs.webkit.org/show_bug.cgi?id=120663

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Undo change to the PropertyTable in my last patch, instead lets just
use a random value as the initial hash for unique strings.

* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::find):
(JSC::PropertyTable::findWithString):
(JSC::PropertyTable::rehash):

Source/WTF:

Unique strings now just generate a completely random value as their
hash, rather than using their this pointer.

* wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build correction.
bfulgham@apple.com [Wed, 11 Sep 2013 21:19:05 +0000 (21:19 +0000)]
Unreviewed build correction.

* WTF.vcxproj/copy-files.cmd: Touch file to force WTFGenerated
build to copy updated GDIObject.h header file on build machines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoupdate-webkit-localizable-strings is at least 5.8x slower than it should be
mitz@apple.com [Wed, 11 Sep 2013 21:02:36 +0000 (21:02 +0000)]
update-webkit-localizable-strings is at least 5.8x slower than it should be
https://bugs.webkit.org/show_bug.cgi?id=121178

Reviewed by Darin Adler.

* Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
Note that this does not change functionality, because the script already does not understand
the line continuation sequence (backslash followed by a newline).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPartial Information Leakage in Hash Table implementations (PrivateName)
oliver@apple.com [Wed, 11 Sep 2013 20:56:31 +0000 (20:56 +0000)]
Partial Information Leakage in Hash Table implementations (PrivateName)
https://bugs.webkit.org/show_bug.cgi?id=120663

Reviewed by Michael Saboff.

These hashtables mix keys that are hashed on pointers or user controlled
data.  To prevent any potential information leak we mask the keys with
a per table entropy value.

* runtime/MapData.cpp:
(JSC::MapData::MapData):
(JSC::MapData::find):
(JSC::MapData::add):
(JSC::MapData::remove):
* runtime/MapData.h:
* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::find):
(JSC::PropertyTable::findWithString):
(JSC::PropertyTable::rehash):
* runtime/PropertyTable.cpp:
(JSC::PropertyTable::PropertyTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTMLEntityTable could use char to reduce binary size
rniwa@webkit.org [Wed, 11 Sep 2013 20:47:01 +0000 (20:47 +0000)]
HTMLEntityTable could use char to reduce binary size
https://bugs.webkit.org/show_bug.cgi?id=121176

Reviewed by Anders Carlsson.

Use LChar instead.

* html/parser/HTMLEntityParser.cpp:
(WebCore::HTMLEntityParser::consumeNamedEntity):
* html/parser/HTMLEntityTable.h:
(WebCore::HTMLEntityTableEntry::lastCharacter):
* html/parser/create-html-entity-table:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMapData and WeakMapData don't need to be objects
commit-queue@webkit.org [Wed, 11 Sep 2013 20:34:09 +0000 (20:34 +0000)]
MapData and WeakMapData don't need to be objects
https://bugs.webkit.org/show_bug.cgi?id=121167

Patch by Sam Weinig <sam@webkit.org> on 2013-09-11
Reviewed by Geoffrey Garen.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::mapStructure):
Remove MapData and WeakMapData structures (they moved to VM with other non-object Structures).

* runtime/JSMap.cpp:
(JSC::JSMap::finishCreation):
* runtime/JSMap.h:
(JSC::JSMap::create):
* runtime/JSSet.cpp:
(JSC::JSSet::finishCreation):
* runtime/JSSet.h:
(JSC::JSSet::create):
* runtime/JSWeakMap.cpp:
(JSC::JSWeakMap::finishCreation):
* runtime/JSWeakMap.h:
(JSC::JSWeakMap::create):
Update to not pass a global object to the MapData or WeakMapData Structure.

* runtime/MapData.cpp:
(JSC::MapData::MapData):
* runtime/MapData.h:
(JSC::MapData::create):
(JSC::MapData::createStructure):
* runtime/WeakMapData.cpp:
(JSC::WeakMapData::WeakMapData):
(JSC::WeakMapData::set): Change to take a VM rather than a CallFrame, as that it all it needs.
* runtime/WeakMapData.h:
(JSC::WeakMapData::create):
(JSC::WeakMapData::createStructure):
Instead of inheriting from JSDestructibleObject, inherit from JSCell and mark self as needing destruction
and having an immortal structure.

* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
Add MapData and WeakMapData Structures.

* runtime/WeakMapPrototype.cpp:
(JSC::protoFuncWeakMapSet):
Pass a VM rather than an ExecState.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Revise GDI Create Functions to use GDIObject Smart Pointer.
bfulgham@apple.com [Wed, 11 Sep 2013 20:27:46 +0000 (20:27 +0000)]
[Windows] Revise GDI Create Functions to use GDIObject Smart Pointer.
https://bugs.webkit.org/show_bug.cgi?id=121100

Reviewed by Anders Carlsson.

* platform/graphics/FontPlatformData.h: Use GDIObject instead of bare pointer.
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::createGDIFont): No longer need to leak the pointer; use move semantic
to pass ownership to FontPlatformData.
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Use move operation.
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Ditto.
* platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Ditto.
* platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Ditto.
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Ditto.
* platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp:
(WebCore::GlyphPage::fill): Use HWndDC smart pointer instead of bare HDC.
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Use move operation.
* platform/win/DragImageCGWin.cpp:
(WebCore::allocImage): Change to use GDIObject.
(WebCore::scaleDragImage): Use smart pointers to avoid manual deallocs.
(WebCore::createDragImageFromImage): Ditto.
* platform/win/DragImageCairoWin.cpp:
(WebCore::allocImage): Change to use GDIObject.
(WebCore::scaleDragImage): Use smart pointers to avoid manual deallocs.
(WebCore::createDragImageFromImage): Ditto.
* platform/win/DragImageWin.cpp:
(WebCore::createDragImageForLink): Update for GDIObject.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::PopupMenuWin): Switch to GDIObject.
(WebCore::PopupMenuWin::~PopupMenuWin): Remove uneeded deallocs.
(WebCore::PopupMenuWin::paint): Update for GDIObject.
* platform/win/PopupMenuWin.h: Use smart pointers instead of bare GDI objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix animations with !USE(ACCELERATED_COMPOSITING) after r147792.
paroga@webkit.org [Wed, 11 Sep 2013 20:18:15 +0000 (20:18 +0000)]
Fix animations with !USE(ACCELERATED_COMPOSITING) after r147792.
https://bugs.webkit.org/show_bug.cgi?id=121159

Reviewed by Simon Fraser.

CSSPropertyAnimation::blendProperties() is available always
and needs to be called to make the animations work.

* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::animate):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove all collapsing margin code out of RenderBlock and into RenderBlockFlow.
hyatt@apple.com [Wed, 11 Sep 2013 19:50:03 +0000 (19:50 +0000)]
Move all collapsing margin code out of RenderBlock and into RenderBlockFlow.
https://bugs.webkit.org/show_bug.cgi?id=121049

Reviewed by Dean Jackson.

This patch begins the migration of the rare data struct of RenderBlock into
RenderBlockFlow. During this process we will temporarily have rare data structs
in both places, but ultimately all of the members are going to move down into
RenderBlockFlow, and if any don't, they will get forced into a hash.

For this patch, the margin information is being shifted out of RenderBlock and into
RenderBlockFlow. Any functions that refer to MarginValues or to MarginInfo also got
moved down into RenderBlockFlow. Most of block child layout is now in RenderBlockFlow
after this patch.

Note that in many cases the code didn't simply move. There is some type tightening
that happened as well, i.e., places that look for RenderBlock can now look for
RenderBlockFlow instead and let RenderBlock execute the base RenderBox functions.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::setPageLogicalOffset):
(WebCore::RenderBlock::setBreakAtLineToAvoidWidow):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::setLineGridBox):
(WebCore::RenderBlock::setShapeInsideInfo):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::MarginInfo::MarginInfo):
(WebCore::RenderBlockFlow::RenderBlockFlow):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::adjustPositionedBlock):
(WebCore::RenderBlockFlow::adjustFloatingBlock):
(WebCore::RenderBlockFlow::marginValuesForChild):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::marginBeforeEstimateForChild):
(WebCore::RenderBlockFlow::estimateLogicalTopPosition):
(WebCore::RenderBlockFlow::setCollapsedBottomMargin):
(WebCore::RenderBlockFlow::handleAfterSideOfBlock):
(WebCore::RenderBlockFlow::setMaxMarginBeforeValues):
(WebCore::RenderBlockFlow::setMaxMarginAfterValues):
(WebCore::RenderBlockFlow::setMustDiscardMarginBefore):
(WebCore::RenderBlockFlow::setMustDiscardMarginAfter):
(WebCore::RenderBlockFlow::mustDiscardMarginBefore):
(WebCore::RenderBlockFlow::mustDiscardMarginAfter):
(WebCore::RenderBlockFlow::mustDiscardMarginBeforeForChild):
(WebCore::RenderBlockFlow::mustDiscardMarginAfterForChild):
(WebCore::RenderBlockFlow::mustSeparateMarginBeforeForChild):
(WebCore::RenderBlockFlow::mustSeparateMarginAfterForChild):
(WebCore::inNormalFlow):
(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
* rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::MarginValues::MarginValues):
(WebCore::RenderBlockFlow::MarginValues::positiveMarginBefore):
(WebCore::RenderBlockFlow::MarginValues::negativeMarginBefore):
(WebCore::RenderBlockFlow::MarginValues::positiveMarginAfter):
(WebCore::RenderBlockFlow::MarginValues::negativeMarginAfter):
(WebCore::RenderBlockFlow::MarginValues::setPositiveMarginBefore):
(WebCore::RenderBlockFlow::MarginValues::setNegativeMarginBefore):
(WebCore::RenderBlockFlow::MarginValues::setPositiveMarginAfter):
(WebCore::RenderBlockFlow::MarginValues::setNegativeMarginAfter):
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::positiveMarginAfterDefault):
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::negativeMarginAfterDefault):
(WebCore::RenderBlockFlow::MarginInfo::setAtBeforeSideOfBlock):
(WebCore::RenderBlockFlow::MarginInfo::setAtAfterSideOfBlock):
(WebCore::RenderBlockFlow::MarginInfo::clearMargin):
(WebCore::RenderBlockFlow::MarginInfo::setHasMarginBeforeQuirk):
(WebCore::RenderBlockFlow::MarginInfo::setHasMarginAfterQuirk):
(WebCore::RenderBlockFlow::MarginInfo::setDeterminedMarginBeforeQuirk):
(WebCore::RenderBlockFlow::MarginInfo::setPositiveMargin):
(WebCore::RenderBlockFlow::MarginInfo::setNegativeMargin):
(WebCore::RenderBlockFlow::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlockFlow::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlockFlow::MarginInfo::setMargin):
(WebCore::RenderBlockFlow::MarginInfo::setCanCollapseMarginAfterWithChildren):
(WebCore::RenderBlockFlow::MarginInfo::setDiscardMargin):
(WebCore::RenderBlockFlow::MarginInfo::atBeforeSideOfBlock):
(WebCore::RenderBlockFlow::MarginInfo::canCollapseWithMarginBefore):
(WebCore::RenderBlockFlow::MarginInfo::canCollapseWithMarginAfter):
(WebCore::RenderBlockFlow::MarginInfo::canCollapseMarginBeforeWithChildren):
(WebCore::RenderBlockFlow::MarginInfo::canCollapseMarginAfterWithChildren):
(WebCore::RenderBlockFlow::MarginInfo::quirkContainer):
(WebCore::RenderBlockFlow::MarginInfo::determinedMarginBeforeQuirk):
(WebCore::RenderBlockFlow::MarginInfo::hasMarginBeforeQuirk):
(WebCore::RenderBlockFlow::MarginInfo::hasMarginAfterQuirk):
(WebCore::RenderBlockFlow::MarginInfo::positiveMargin):
(WebCore::RenderBlockFlow::MarginInfo::negativeMargin):
(WebCore::RenderBlockFlow::MarginInfo::discardMargin):
(WebCore::RenderBlockFlow::MarginInfo::margin):
(WebCore::RenderBlockFlow::maxPositiveMarginBefore):
(WebCore::RenderBlockFlow::maxNegativeMarginBefore):
(WebCore::RenderBlockFlow::maxPositiveMarginAfter):
(WebCore::RenderBlockFlow::maxNegativeMarginAfter):
(WebCore::RenderBlockFlow::initMaxMarginValues):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix nested unicode-bidi: isolate
commit-queue@webkit.org [Wed, 11 Sep 2013 19:23:58 +0000 (19:23 +0000)]
Fix nested unicode-bidi: isolate
https://bugs.webkit.org/show_bug.cgi?id=120504

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-09-11
Reviewed by Darin Adler.

Source/WebCore:

When we have a nested isolate renderer if the outer isolate has a text
and this text is not the first child, the isolated chain is not
rendered correctly. This happens because constructBidiRunsForSegment
uses always the first inner isolated renderer as isolated inline
container. This patch fixes the behavior described changing
containingIsolate to find the right isolated container.

Blink: https://chromium.googlesource.com/chromium/blink/+/840a57050eade39dd04dde0c6603e129b783151c
Tests: fast/text/international/unicode-bidi-isolate-nested-first-child-text.html
       fast/text/international/unicode-bidi-isolate-nested-simple.html

* rendering/InlineIterator.h:
(WebCore::containingIsolate):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRunsForSegment):

LayoutTests:

* fast/text/international/unicode-bidi-isolate-nested-first-child-text-expected.html: Added.
* fast/text/international/unicode-bidi-isolate-nested-first-child-text.html: Added.
* fast/text/international/unicode-bidi-isolate-nested-simple-expected.html: Added.
* fast/text/international/unicode-bidi-isolate-nested-simple.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=121169
ap@apple.com [Wed, 11 Sep 2013 19:18:40 +0000 (19:18 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=121169
media/track/track-cue-rendering-vertical.html is flaky on Mac

Reviewed by Eric Carlson.

Source/WebCore:

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Added a FIXME.

LayoutTests:

* media/media-reparent.html: Changed to use setTimeout directly.

* media/video-test.js:
(endTest): Added a zero delay timer to let text track layout do its work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Stop using deleteAllValues in SVG code
andersca@apple.com [Wed, 11 Sep 2013 19:17:19 +0000 (19:17 +0000)]
Source/WebCore: Stop using deleteAllValues in SVG code
https://bugs.webkit.org/show_bug.cgi?id=121172

Reviewed by Antti Koivisto.

Use OwnPtr for values instead.

* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper):
(WebCore::RenderSVGResourceClipper::removeAllClientsFromCache):
(WebCore::RenderSVGResourceClipper::removeClientFromCache):
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/svg/RenderSVGResourceClipper.h:
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter):
(WebCore::RenderSVGResourceFilter::removeAllClientsFromCache):
(WebCore::RenderSVGResourceFilter::removeClientFromCache):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
* rendering/svg/RenderSVGResourceFilter.h:
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker):
(WebCore::RenderSVGResourceMasker::removeAllClientsFromCache):
(WebCore::RenderSVGResourceMasker::removeClientFromCache):
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/svg/RenderSVGResourceMasker.h:

Source/WTF: Vector::append doesn't work if element type has overloaded operator&
https://bugs.webkit.org/show_bug.cgi?id=121175

Reviewed by Brent Fulgham.

Use std::addressof to get the address of the given object.

* wtf/Vector.h:
(WTF::::appendSlowCase):
(WTF::::uncheckedAppend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVector::append doesn't work if element type has overloaded operator&
andersca@apple.com [Wed, 11 Sep 2013 19:08:39 +0000 (19:08 +0000)]
Vector::append doesn't work if element type has overloaded operator&
https://bugs.webkit.org/show_bug.cgi?id=121175

Reviewed by Brent Fulgham.

Source/WTF:

Use std::addressof to get the address of the given object.

* wtf/Vector.h:
(WTF::::appendSlowCase):
(WTF::::uncheckedAppend):

Tools:

Add a test case.

* TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake the table static const.
rniwa@webkit.org [Wed, 11 Sep 2013 19:02:48 +0000 (19:02 +0000)]
Make the table static const.

* css/makeprop.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove TimelineTraceEventProcessor since no current ports use it
timothy@apple.com [Wed, 11 Sep 2013 18:59:41 +0000 (18:59 +0000)]
Remove TimelineTraceEventProcessor since no current ports use it
https://bugs.webkit.org/show_bug.cgi?id=121171

Reviewed by Joseph Pecoraro.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorClient.h:
* inspector/InspectorInstrumentation.cpp:
* inspector/InspectorInstrumentation.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineTraceEventProcessor.cpp: Removed.
* inspector/TimelineTraceEventProcessor.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r155519.
commit-queue@webkit.org [Wed, 11 Sep 2013 18:53:55 +0000 (18:53 +0000)]
Unreviewed, rolling out r155519.
http://trac.webkit.org/changeset/155519
https://bugs.webkit.org/show_bug.cgi?id=121174

Included regression test fails, and an existing test started
to crash (Requested by ap on #webkit).

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::hoveredElementDidDetach):
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::scheduleHoverStateUpdate):
(WebCore::EventHandler::hoverTimerFired):
* page/EventHandler.h:

LayoutTests:

* fast/events/mouseenterleave-detached-element-expected.txt: Removed.
* fast/events/mouseenterleave-detached-element.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStop using deleteAllValues in SVG code
andersca@apple.com [Wed, 11 Sep 2013 18:39:09 +0000 (18:39 +0000)]
Stop using deleteAllValues in SVG code
https://bugs.webkit.org/show_bug.cgi?id=121172

Reviewed by Antti Koivisto.

Use OwnPtr for values instead.

* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper):
(WebCore::RenderSVGResourceClipper::removeAllClientsFromCache):
(WebCore::RenderSVGResourceClipper::removeClientFromCache):
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/svg/RenderSVGResourceClipper.h:
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter):
(WebCore::RenderSVGResourceFilter::removeAllClientsFromCache):
(WebCore::RenderSVGResourceFilter::removeClientFromCache):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
* rendering/svg/RenderSVGResourceFilter.h:
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker):
(WebCore::RenderSVGResourceMasker::removeAllClientsFromCache):
(WebCore::RenderSVGResourceMasker::removeClientFromCache):
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/svg/RenderSVGResourceMasker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (143483): overflow:hidden doesn't quash big repaints from text-indent...
simon.fraser@apple.com [Wed, 11 Sep 2013 18:33:05 +0000 (18:33 +0000)]
REGRESSION (143483): overflow:hidden doesn't quash big repaints from text-indent: -9999px
https://bugs.webkit.org/show_bug.cgi?id=121137

Source/WebCore:

Reviewed by Ryosuke Niwa.

The change in r143483 made it so that negative text-indent gets added
to visual oveflow even when we have overflow:hidden, which is really bad
because it causes large repaints (and large layers) for a common-on-the-web
pattern.

Revert the change, and add a new test to make sure it doesn't regress.

I can't reproduce the bug it was trying to fix with the change reverted.

Tests: compositing/geometry/negative-text-indent-with-overflow-hidden-layer.html
       fast/repaint/negative-text-indent-with-overflow-hidden.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):

LayoutTests:

Reviewed by Ryosuke Niwa.

Text-based repaint test, and test for compositing layer geometry.

* compositing/geometry/negative-text-indent-with-overflow-hidden-layer-expected.txt: Added.
* compositing/geometry/negative-text-indent-with-overflow-hidden-layer.html: Added.
* fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt: Added.
* fast/repaint/negative-text-indent-with-overflow-hidden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOptionally show visual and layout overflow rects in layer tree dumps
simon.fraser@apple.com [Wed, 11 Sep 2013 18:33:02 +0000 (18:33 +0000)]
Optionally show visual and layout overflow rects in layer tree dumps
https://bugs.webkit.org/show_bug.cgi?id=121135

Reviewed by Beth Dakin.

When calling showLayerTree() from the debugger, show overflow rects
(visaul and layout) for renderers.

Does not affect test output.

* rendering/RenderLayer.cpp:
(showLayerTree): Pass the new flag to show overflow rects.
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject): Print the rects.
(WebCore::write): Don't force layout on subframes if the "dont' layout"
flag is set.
* rendering/RenderTreeAsText.h: New flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Unreviewed build correction after r155507.
bfulgham@apple.com [Wed, 11 Sep 2013 18:30:13 +0000 (18:30 +0000)]
[Windows] Unreviewed build correction after r155507.

* WebCoreSupport/WebChromeClient.cpp: Add missing header include
to define isHTMLVideoElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: WebKit exposes AXTitleUIElement incorrectly on checkboxes and radio buttons
cfleizach@apple.com [Wed, 11 Sep 2013 18:25:46 +0000 (18:25 +0000)]
AX: WebKit exposes AXTitleUIElement incorrectly on checkboxes and radio buttons
https://bugs.webkit.org/show_bug.cgi?id=121039

Reviewed by Sam Weinig.

Source/WebCore:

Stop hiding <label> elements for radio buttons and checkboxes (and using the text inside them for the AXTitle).
Instead, expose the <label> element as the titleUIElement if appropriate for the input.

This implies:
   1) The web will no longer match MacOS behavior exactly (the text and the checkbox control are combined on MacOS into one element)
   2) But, the user will now be able to explore the <label> element which may include links or other important controls.
I think sacrificing 1) here is a good tradeoff. The user will likely never know the difference in terms of output.

Test: platform/mac/accessibility/label-elements-exposed-as-title-ui-elements.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::title):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::hasTextAlternative):
(WebCore::AccessibilityRenderObject::exposesTitleUIElement):

LayoutTests:

* accessibility/label-for-control-hittest-expected.txt: Removed.
* accessibility/label-for-control-hittest.html: Removed.
      We no longer need this test since we are not combining label + control into one element anymore.
* accessibility/radio-button-group-members.html:
      Rewrite this test to be more modern (don't just dump attributes).
      Instead test for what we want to know (whether radio button group members can identify their siblings)
* accessibility/radio-button-title-label-expected.txt:
* accessibility/radio-button-title-label.html:
      Rewrite this test so that it understands that controls won't hide their <label> elements.
* platform/mac/accessibility/label-element-with-hidden-control-expected.txt:
* platform/mac/accessibility/label-element-with-hidden-control.html:
      Update test to reflect that title UI elements are exposed for some controls.
* platform/mac/accessibility/label-elements-exposed-as-title-ui-elements-expected.txt: Added.
* platform/mac/accessibility/label-elements-exposed-as-title-ui-elements.html: Added.
      New test to explicitly confirm that <label> is exposed as a title UI element.
* platform/mac/accessibility/radio-button-group-members-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVectorBuffer::swap doesn't need to use std::swap_ranges
andersca@apple.com [Wed, 11 Sep 2013 18:07:54 +0000 (18:07 +0000)]
VectorBuffer::swap doesn't need to use std::swap_ranges
https://bugs.webkit.org/show_bug.cgi?id=121164

Reviewed by Darin Adler.

There's a std::swap overload for swapping arrays, just use it instead.

* wtf/Vector.h:
(WTF::VectorBuffer::swap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement Vector::append for move-only types
andersca@apple.com [Wed, 11 Sep 2013 17:57:36 +0000 (17:57 +0000)]
Implement Vector::append for move-only types
https://bugs.webkit.org/show_bug.cgi?id=120805

Source/WTF:

Reviewed by Andreas Kling.

* wtf/Vector.h:
(WTF::::expandCapacity):
Remove const from the pointer passed to expandCapacity, it can be non-const if we're moving.

(WTF::::append):
Change append to take U&& and use std::forward when constructing the element and when passing
the element along to appendSlowCase if that's necessary.

(WTF::::appendSlowCase):
Use std::forward.

(WTF::::uncheckedAppend):
Rename val to value.

Tools:

Reviewed by Sam Weinig.

Add a test for Vector<MoveOnly>::append.

* TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unnecessary Document::frame() null checks in rendererIsNeeded().
akling@apple.com [Wed, 11 Sep 2013 17:43:14 +0000 (17:43 +0000)]
Remove unnecessary Document::frame() null checks in rendererIsNeeded().
<https://webkit.org/b/121166>

Reviewed by Anders Carlsson.

rendererIsNeeded() is only called during style resolve, which only happens
while there's a Frame present.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::rendererIsNeeded):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::rendererIsNeeded):
* html/HTMLObjectElement.cpp:
* html/HTMLObjectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoARM buildfix after r155491
ossy@webkit.org [Wed, 11 Sep 2013 17:38:52 +0000 (17:38 +0000)]
ARM buildfix after r155491
https://bugs.webkit.org/show_bug.cgi?id=121152

Reviewed by Anders Carlsson.

FELightingNEON.cpp and FELightingNEON.h is inside COMPILER(GCC) guard, so it's safe to use GCC attribute.

* platform/graphics/cpu/arm/filters/FELightingNEON.cpp: Use __aligned__ GCC attribute directly.
* platform/graphics/cpu/arm/filters/FELightingNEON.h: Use __aligned__ GCC attribute instead of ugly template magic.
(WebCore::FELighting::platformApplyNeon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix the indentation after r105848. Typo fix after r155523.
ossy@webkit.org [Wed, 11 Sep 2013 17:28:04 +0000 (17:28 +0000)]
Unreviewed. Fix the indentation after r105848. Typo fix after r155523.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunAndUploadPerfTests):
(RunAndUploadPerfTests.start):
(RunAndUploadPerfTests.getText2):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Compile errors.
commit-queue@webkit.org [Wed, 11 Sep 2013 16:50:39 +0000 (16:50 +0000)]
[WinCairo] Compile errors.
https://bugs.webkit.org/show_bug.cgi?id=121153

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-11
Reviewed by Brent Fulgham.

* page/win/FrameCairoWin.cpp:
(WebCore::imageFromRect): Return empty GDIObject.
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Get actual handle from GDIObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRework CSS parser, eliminating "floating" concept and using %destructor
darin@apple.com [Wed, 11 Sep 2013 16:48:20 +0000 (16:48 +0000)]
Rework CSS parser, eliminating "floating" concept and using %destructor
https://bugs.webkit.org/show_bug.cgi?id=121161

Reviewed by Antti Koivisto.

This is some basic improvement, but there is still room for a lot more
consistent approach and formatting in this file. There is a mix of code that
works by side effects in the CSSParser class and code that works with the
values that bison generates in the union that is more or less random. And
the data structures seem too costly, with too much heap allocation. And the
CSSParser class has grown massive, with a mix of both function for use by
code that wants to trigger parsing, and helper functions called by code in
the grammar file. All of that can benefit from more refinement in the future.

* css/CSSGrammar.y.in: Made some incremental improvements to the structure
of the grammar file, including:
- Breaking up the %union so types are declared next to their use
- Eliminating one shift/reduce conflict caused by two "maybe_space" in a row
- Breaking the conditional sections out into their own sections instead of
  scattering them in with the other code.
- Eliminating unused return values in productions such as charset,
  ignored_charset, namespace, margin_box, invalid_rule, save_block,
  invalid_at, and declarations_and_margins.
- Adding %destructor to productions that return values that need to be deleted
  or deref'd. This removes the need for CSSParser to separately track these
  as "floating" to clean up in case of errors.
- Removing unneeded productions such as media_feature, region_selector,
  attr_name, and medium.
- Removing explicit code blocks that just say "$$ = $1" or empty blocks when
  there is no return type, since those are default.
- Formatting many productions on single lines since I find them easier to read.
  Later I think we could make many more CSSParser functions and make even
  more of the production single lines in the grammar file.
- Using adoptPtr, adoptRef, delete, deref, leakPtr, and leakRef to put
  heap allocated values into and out of the union without storage leaks.

* css/CSSParser.cpp:
(WebCore::CSSParser::~CSSParser): Remove the now-unneeded deleteAllValues for
the various colections of floating things.
(WebCore::CSSParser::createFilterRule): Don't put the rule into m_parsedRules,
just return a PassRefPtr instead.
(WebCore::CSSParser::createImportRule): Ditto.
(WebCore::CSSParser::createMediaRule): Ditto.
(WebCore::CSSParser::createEmptyMediaRule): Ditto.
(WebCore::CSSParser::createSupportsRule): Ditto.
(WebCore::CSSParser::createKeyframesRule): Ditto.
(WebCore::CSSParser::createStyleRule): Ditto.
(WebCore::CSSParser::createFontFaceRule): Ditto.
(WebCore::CSSParser::createHostRule): Ditto.
(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded): Got rid of the
unused return value from this function and changed it to to take a reference
instead of a pointer.
(WebCore::CSSParser::rewriteSpecifiersWithElementName): Ditto.
(WebCore::CSSParser::rewriteSpecifiers): Changed this to take and return OwnPtr.
(WebCore::CSSParser::createPageRule): Don't put rule into m_parsedRules, return
PassRefPtr instead.
(WebCore::CSSParser::createSelectorVector): Added. Used to implement the
optimization where we recycle a single selector vector. Not sure we still need
this, or maybe we need more optimizations like it, but for now keep it.
(WebCore::CSSParser::recycleSelectorVector): Ditto.
(WebCore::CSSParser::createRegionRule): Don't put rule into m_parsedRules, return
PassRefPtr instead.
(WebCore::CSSParser::createMarginAtRule): Got rid of unused return value.
When this function is implemented for real, we might add a return value.
(WebCore::CSSParser::createKeyframe): Don't put keyframe into m_parsedKeyframes,
return PassRefPtr instead.
(WebCore::CSSParser::createViewportRule): Don't put rule into m_parsedRules, return
PassRefPtr instead.

* css/CSSParser.h: Removed many now-needed functions to manage floating items.
Changed rule creation functions to return PassRefPtr. Other changes as mentioned above.

* css/CSSParserValues.cpp:
(WebCore::destroy): Added.
(WebCore::CSSParserValueList::~CSSParserValueList): Updated to call destroy.
* css/CSSParserValues.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe style checker shouldn't complain about returning or passing OwnPtr
andersca@apple.com [Wed, 11 Sep 2013 16:43:29 +0000 (16:43 +0000)]
The style checker shouldn't complain about returning or passing OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=121163

Reviewed by Antti Koivisto.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_function_definition_and_pass_ptr):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(PassPtrTest.test_pass_ref_ptr_return_value):
(PassPtrTest.test_own_ptr_parameter_value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Remove Gail dependency from build system for GTK3
mario@webkit.org [Wed, 11 Sep 2013 16:25:19 +0000 (16:25 +0000)]
[GTK] Remove Gail dependency from build system for GTK3
https://bugs.webkit.org/show_bug.cgi?id=119673

Reviewed by Gustavo Noronha Silva.

.:

* Source/autotools/FindDependencies.m4: Don't look for GAIL at all.
* Source/autotools/Versions.m4: Removed any reference to GAIL.
* Source/cmake/FindGAIL3.cmake: Removed.
* Source/cmake/OptionsGTK.cmake: Don't look for the GAIL package.

Source/WebCore:

* GNUmakefile.am: Removed GAIL_CFLAGS.
* PlatformGTK.cmake: Removed GAIL3_INCLUDE_DIRS and GAIL3_LIBRARIES.

Source/WebKit/gtk:

* GNUmakefile.am: Removed GAIL_CFLAGS and GAIL_LIBS.

Source/WebKit2:

* GNUmakefile.am: Removed GAIL_LIBS.

Tools:

* EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
* TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() returns...
berto@igalia.com [Wed, 11 Sep 2013 16:15:33 +0000 (16:15 +0000)]
[WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() returns null
https://bugs.webkit.org/show_bug.cgi?id=120892

Reviewed by Martin Robinson.

If the GL context cannot be created then m_isValid is set to false
during the initialization of LayerTreeHostGtk.

This is not really necessary since the rest of the code already
deals with that situation, so it doesn't have any effect other
than breaking the assertion in invalidate().

* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r154899.
commit-queue@webkit.org [Wed, 11 Sep 2013 15:55:13 +0000 (15:55 +0000)]
Unreviewed, rolling out r154899.
http://trac.webkit.org/changeset/154899
https://bugs.webkit.org/show_bug.cgi?id=121162

It didn't fix the problem and broke other unit tests
(Requested by KaL on #webkit).

* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::resizeView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Changed expected results after r155253
commit-queue@webkit.org [Wed, 11 Sep 2013 15:34:13 +0000 (15:34 +0000)]
[EFL] Changed expected results after r155253
https://bugs.webkit.org/show_bug.cgi?id=121157

Unreviewed EFL gardening.

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-11

* platform/efl/editing/deleting/delete-br-004-expected.png:
* platform/efl/editing/deleting/delete-br-004-expected.txt:
* platform/efl/editing/deleting/delete-br-005-expected.png:
* platform/efl/editing/deleting/delete-br-005-expected.txt:
* platform/efl/editing/deleting/delete-br-006-expected.png:
* platform/efl/editing/deleting/delete-br-006-expected.txt:
* platform/efl/editing/selection/caret-ltr-right-expected.png:
* platform/efl/editing/selection/caret-ltr-right-expected.txt:
* platform/efl/editing/selection/caret-rtl-2-left-expected.png:
* platform/efl/editing/selection/caret-rtl-2-left-expected.txt:
* platform/efl/editing/selection/caret-rtl-right-expected.png:
* platform/efl/editing/selection/caret-rtl-right-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove Widget::widgetPositionsUpdated().
akling@apple.com [Wed, 11 Sep 2013 15:25:58 +0000 (15:25 +0000)]
Remove Widget::widgetPositionsUpdated().
<https://webkit.org/b/121160>

Reviewed by Anders Carlsson.

Remove this no-op virtual that was only used by chromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPage::backForward() should return a reference.
akling@apple.com [Wed, 11 Sep 2013 15:24:45 +0000 (15:24 +0000)]
Page::backForward() should return a reference.
<https://webkit.org/b/121151>

Reviewed by Anders Carlsson.

There is always a BackForwardController, so make backForward() return a reference.
Also made it store a Page& internally since it's tied to the lifetime of Page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWTF::OwnPtr should behave similarly with the rest of WTF smart pointers
mikhail.pozdnyakov@intel.com [Wed, 11 Sep 2013 14:43:03 +0000 (14:43 +0000)]
WTF::OwnPtr should behave similarly with the rest of WTF smart pointers
https://bugs.webkit.org/show_bug.cgi?id=120773

Reviewed by Anders Carlsson.

Before the change OwnPtr could take either the pointer type or the pointed-to type, which was bad
for the following reasons:
- It distinguished OwnPtr behaviour from other WTF smart pointer classes behaviour (so it was confusing for the Client).
- It was potential error-prone as it actually modified the type given by the Client in opaque way.

Source/WebCore:

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::PropertyWrapperShadow::blendSimpleOrMatchedShadowLists):
(WebCore::PropertyWrapperShadow::blendMismatchedShadowLists):

Source/WebKit2:

* UIProcess/API/efl/ewk_database_manager.cpp:
(getDatabaseOriginsCallback):
* UIProcess/API/efl/ewk_storage_manager.cpp:
(getStorageOriginsCallback):

Source/WTF:

* wtf/OwnPtr.h:
* wtf/PassOwnPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOwnPtr: Use copy/move-and-swap for assignment operators
mikhail.pozdnyakov@intel.com [Wed, 11 Sep 2013 14:33:00 +0000 (14:33 +0000)]
OwnPtr: Use copy/move-and-swap for assignment operators
https://bugs.webkit.org/show_bug.cgi?id=121154

Reviewed by Anders Carlsson.

Rationals:
- decrease of repeated code
- consistency with RefPtr

* wtf/OwnPtr.h:
(WTF::=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Win] Compile error when VIDEO is not enabled.
commit-queue@webkit.org [Wed, 11 Sep 2013 14:26:41 +0000 (14:26 +0000)]
[Win] Compile error when VIDEO is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=121156

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-11
Reviewed by Andreas Kling.

* WebView.cpp:
(WebView::enterFullscreenForNode): Protect isHTMLVideoElement() function with ENABLE(VIDEO) guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFrameView: Tighten widget handling code.
akling@apple.com [Wed, 11 Sep 2013 14:16:31 +0000 (14:16 +0000)]
FrameView: Tighten widget handling code.
<https://webkit.org/b/121155>

Reviewed by Antti Koivisto.

Harden typing in this code to work with RenderEmbeddedObject& instead of RenderObject*.
Functions and members renamed to reflect that they only deal with embedded objects.

* html/HTMLPlugInImageElement.h:
(WebCore::toHTMLPlugInImageElement):

    Add a toHTMLPlugInImageElement that takes an Element&.

* html/HTMLTagNames.in:

    Generate type helpers for applet and embed elements.

* page/FrameView.h:
* page/FrameView.cpp:
(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::removeEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObjects):
(WebCore::FrameView::updateEmbeddedObject):

    Re-ordered this function in early return style. Change locals into references.

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::~RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::layout):
* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::layout):

    Updated for new FrameView function signatures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPerformance tester bots should report the number of failing tests
commit-queue@webkit.org [Wed, 11 Sep 2013 14:07:26 +0000 (14:07 +0000)]
Performance tester bots should report the number of failing tests
https://bugs.webkit.org/show_bug.cgi?id=120462

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-11
Reviewed by Csaba Osztrogonác.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunAndUploadPerfTests.start.getText):
(RunAndUploadPerfTests.start):
(RunAndUploadPerfTests):
(RunAndUploadPerfTests.start.getText2):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
changseok.oh@collabora.com [Wed, 11 Sep 2013 13:53:38 +0000 (13:53 +0000)]
Unreviewed build fix.

* GNUmakefile.list.am: Duplicated NetscapePluginModuleNone.cpp & NetscapePluginNone.cpp.
They cause build breaks of multiple definitions when targeting wayland build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Split out generic Windows files into its own file
paroga@webkit.org [Wed, 11 Sep 2013 13:44:29 +0000 (13:44 +0000)]
[CMake] Split out generic Windows files into its own file
https://bugs.webkit.org/show_bug.cgi?id=119514

Reviewed by Gyuyoung Kim.

This allows us to add smaller CMakeLists.txt files when
adding additional Windows ports.

.:

* Source/cmake/OptionsWinCE.cmake:
* Source/cmake/WebKitMacros.cmake:

Source/WebCore:

* PlatformWin.cmake: Copied from Source/WebCore/PlatformWinCE.cmake.
* PlatformWinCE.cmake:

Source/WTF:

* wtf/PlatformWin.cmake: Renamed from Source/WTF/wtf/PlatformWinCE.cmake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Get rid of Pango/Gail dependencies in accessibility for ATK
mario@webkit.org [Wed, 11 Sep 2013 12:05:10 +0000 (12:05 +0000)]
[GTK] Get rid of Pango/Gail dependencies in accessibility for ATK
https://bugs.webkit.org/show_bug.cgi?id=114867

Reviewed by Martin Robinson.

Removed all trace of Gail and Pango specific code from the AtkText
implementation, now everything has been reimplemented.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextForOffset): Removed fallback code
relying in Gail/Pango, now all the related code has been
removed. Also, replaced the collection of if statements with a
switch, for better readability of the code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMouseenter/-leave not triggered when element under cursor is moved/removed
allan.jensen@digia.com [Wed, 11 Sep 2013 11:44:58 +0000 (11:44 +0000)]
Mouseenter/-leave not triggered when element under cursor is moved/removed
https://bugs.webkit.org/show_bug.cgi?id=120786

Reviewed by Antonio Gomes.

Source/WebCore:

When a hovered element is detached it will now emit a fake mousemove event
similar to what happens when a hovered element has CSS display set to none.

Test: fast/events/mouseenterleave-detached-element.html

* dom/Document.cpp:
(WebCore::Document::hoveredElementDidDetach):
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMouseMoveEvent):
* page/EventHandler.h:

LayoutTests:

Test of mouseenter/mouseleave events when a hovered element is removed.

* fast/events/mouseenterleave-detached-element-expected.txt: Added.
* fast/events/mouseenterleave-detached-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[ATK] Adds mapping MenuItemRadioRole to ATK
commit-queue@webkit.org [Wed, 11 Sep 2013 11:31:14 +0000 (11:31 +0000)]
[ATK] Adds mapping MenuItemRadioRole to ATK
https://bugs.webkit.org/show_bug.cgi?id=121149

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-11
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Adds mapping MenuItemRadioRole to ATK.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):

Tools:

Adds mapping MenuItemRadioRole to ATK.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(roleToString):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::roleToString):

LayoutTests:

Corrected expectations so that they can properly test MenuItemRadioRole.

* platform/efl/accessibility/aria-menubar-menuitems-expected.txt:
* platform/gtk/accessibility/aria-menubar-menuitems-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoautogen.sh: fix removal of autom4te.cache
berto@igalia.com [Wed, 11 Sep 2013 11:15:54 +0000 (11:15 +0000)]
autogen.sh: fix removal of autom4te.cache
https://bugs.webkit.org/show_bug.cgi?id=121150

Reviewed by Carlos Garcia Campos.

The removal of autom4te.cache is wrong, it uses 'rm -f' instead of
'rm -rf' and it relies on an undefined variable.

In addition to that, it should be done after running autoreconf,
which is when it's no longer needed.

* autogen.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155517 268f45cc-cd09-0410-ab3c-d52691b4dbfc