abarth@webkit.org [Mon, 17 Jan 2011 05:04:17 +0000 (05:04 +0000)]
Move WebKit into Source
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 17 Jan 2011 05:02:09 +0000 (05:02 +0000)]
2011-01-16 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530
* WebKit.grd:
* WebKit.gyp:
2011-01-16 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530
* Api/DerivedSources.pro:
* declarative/declarative.pro:
* docs/docs.pri:
* tests/tests.pri:
2011-01-16 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530
* GNUmakefile.am:
2011-01-16 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530
* GNUmakefile.am:
2011-01-16 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530
* Makefile:
* scripts/generate-webkitversion.pl:
2011-01-16 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.sln:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
2011-01-16 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530
* Android.mk:
* CMakeLists.txt:
* DerivedSources.pro:
* GNUmakefile.am:
* Makefile:
* WebKit.pri:
* WebKit.pro:
* configure.ac:
* wscript:
2011-01-16 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530
* DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/GCControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/PlainTextControllerQt.cpp:
* DumpRenderTree/qt/TextInputControllerQt.cpp:
* DumpRenderTree/wscript:
* QtTestBrowser/launcherwindow.h:
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
2011-01-16 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-01-16 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530
* WebCore.gyp/WebCore.gyp:
* WebCore.pri:
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 17 Jan 2011 04:21:50 +0000 (04:21 +0000)]
Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
https://bugs.webkit.org/show_bug.cgi?id=52550
Reviewed by Simon Fraser.
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 17 Jan 2011 03:49:59 +0000 (03:49 +0000)]
2011-01-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
frame-removed-during-resize.html test crashes (shows up as image-map-2.html crash)
https://bugs.webkit.org/show_bug.cgi?id=52549
Fix regression from r75900; m_widget->setFrameRect() can run script that
clears m_widget, so null-check it before calling setBoundsSize().
Tested by fast/replaced/frame-removed-during-resize.html
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 17 Jan 2011 02:01:04 +0000 (02:01 +0000)]
2011-01-16 Simon Fraser <simon.fraser@apple.com>
Keep Leopard build happy.
* platform/mac/WidgetMac.mm:
(WebCore::Widget::setBoundsSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 17 Jan 2011 01:52:16 +0000 (01:52 +0000)]
2011-01-16 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
[jsfunfuzz] Parser doesn't correctly validate for-loop syntax
https://bugs.webkit.org/show_bug.cgi?id=52516
Add test for the case where a syntax error immediately follows
multiple declarations in a for-loop initialiser.
* fast/js/parser-syntax-check-expected.txt:
* fast/js/script-tests/parser-syntax-check.js:
2011-01-16 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
[jsfunfuzz] Parser doesn't correctly validate for-loop syntax
https://bugs.webkit.org/show_bug.cgi?id=52516
Ensure that we always check for a semicolon after encountering
multiple declarations in the initialiser portion of a for-loop.
* parser/JSParser.cpp:
(JSC::JSParser::parseForStatement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 17 Jan 2011 01:07:24 +0000 (01:07 +0000)]
2011-01-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Issues with iframes and plugins when the WebView is scaled.
<rdar://problem/
6213380>
When _scaleWebView has been called on a WebView, iframes
in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
This is caused by AppKit NSViews not playing nicely with the scale
applied through style.
Work around most of these issues by adjusting the bounds size
of widgets to allow iframe contents to paint with the correct scale,
and fix various places in the code where we relied on coordinate
transforms via NSViews (which ignore CSS transforms).
* WebCore.exp.in:
* platform/Widget.cpp:
(WebCore::Widget::setBoundsSize):
* platform/Widget.h:
* platform/mac/WidgetMac.mm:
(WebCore::Widget::setBoundsSize):
(WebCore::Widget::paint):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
* rendering/RenderWidget.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sun, 16 Jan 2011 23:54:40 +0000 (23:54 +0000)]
2011-01-16 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Strict mode restrictions on arguments and eval usage aren't complete
https://bugs.webkit.org/show_bug.cgi?id=52528
Add a helper function to aid parse failure tests by testing both direct
eval/global code, and nested code (so that we test the syntax checker
mode as well)
* fast/js/basic-strict-mode-expected.txt:
* fast/js/script-tests/basic-strict-mode.js:
(shouldBeSyntaxError):
2011-01-16 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Strict mode restrictions on arguments and eval usage aren't complete
https://bugs.webkit.org/show_bug.cgi?id=52528
Fix a few bugs in strict mode where we incorrect allow mutation of
arguments and eval in the parser.
Alas the "optimisation" used by the syntax checker for validating
binary and unary expressions was too aggressive: we do actually need
a stack for operations and operands although it needn't be as complete
as that used for the full AST builder.
Also disallow assignment to arguments in all cases as allowing arguments
to be assignable is always an error in strict mode, regardless of context.
* parser/ASTBuilder.h:
(JSC::ASTBuilder::BinaryExprContext::BinaryExprContext):
(JSC::ASTBuilder::UnaryExprContext::UnaryExprContext):
* parser/JSParser.cpp:
(JSC::JSParser::parseAssignmentExpression):
(JSC::JSParser::parseBinaryExpression):
(JSC::JSParser::parseUnaryExpression):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::BinaryExprContext::BinaryExprContext):
(JSC::SyntaxChecker::BinaryExprContext::~BinaryExprContext):
(JSC::SyntaxChecker::UnaryExprContext::UnaryExprContext):
(JSC::SyntaxChecker::UnaryExprContext::~UnaryExprContext):
(JSC::SyntaxChecker::appendBinaryExpressionInfo):
(JSC::SyntaxChecker::operatorStackPop):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sun, 16 Jan 2011 22:08:41 +0000 (22:08 +0000)]
2011-01-16 Robert Hogan <robert@webkit.org>
Unreviewed, re-skip test after r75894.
[Qt] plugins/keyboard-events.html fails after r72717
Re-skip plugins/keyboard-events.html.
Using XKeysymToKeycode(QX11Info::display(), ..) doesn't work on
a headless build, such as the buildbot. So need to solve this a
different way.
https://bugs.webkit.org/show_bug.cgi?id=50050
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sun, 16 Jan 2011 21:08:28 +0000 (21:08 +0000)]
2011-01-16 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] plugins/keyboard-events.html fails after r72717
https://bugs.webkit.org/show_bug.cgi?id=50050
* platform/qt/Skipped: Unskip plugins/keyboard-events.html
2011-01-16 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] plugins/keyboard-events.html fails after r72717
https://bugs.webkit.org/show_bug.cgi?id=50050
* plugins/qt/PluginViewQt.cpp:
(WebCore::setXKeyEventSpecificFields): map event text to keycode
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Sun, 16 Jan 2011 20:59:28 +0000 (20:59 +0000)]
Fix for <rdar://problem/
8871204>
Reviewed by Kevin Decker.
Don't try to save elasticity state. Just rely on
NSScrollElasticityAutomatic to restore the correct state.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::WebFrameLoaderClient):
(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::provisionalLoadStarted):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sun, 16 Jan 2011 18:04:01 +0000 (18:04 +0000)]
2011-01-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
RenderView needs to take transforms on its layer into account
https://bugs.webkit.org/show_bug.cgi?id=52536
The RenderView's coordinate mapping methods failed to
take into account a transform on the RenderView's layer.
No tests because it's not possible to get a transform
on the RenderView's layer through content.
* rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sun, 16 Jan 2011 05:11:14 +0000 (05:11 +0000)]
2011-01-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Rolled back in r75886.
https://bugs.webkit.org/show_bug.cgi?id=52527
r75886 broke the GTK Linux bot because Linux was -- quite surprisingly --
set up to use the constants for embedded devices.
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::maybeModifyVMPoolSize): Separated Linux constants from embedded
constants.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 16 Jan 2011 04:22:30 +0000 (04:22 +0000)]
2011-01-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75886.
http://trac.webkit.org/changeset/75886
https://bugs.webkit.org/show_bug.cgi?id=52526
"Broke GTK+ 64bit" (Requested by xan_ on #webkit).
* jit/ExecutableAllocatorFixedVMPool.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sun, 16 Jan 2011 02:14:39 +0000 (02:14 +0000)]
Skip fast/dom/Range/range-clone-contents.html on Windows
Not reviewed.
Filed: <https://bugs.webkit.org/show_bug.cgi?id=52524>
* platform/win/Skipped: Skip test on Windows. The test passes
on all other bots.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 15 Jan 2011 23:48:46 +0000 (23:48 +0000)]
<rdar://problem/
8870429> Shrink the executable pool on embedded devices
Reviewed by Sam Weinig.
* jit/ExecutableAllocatorFixedVMPool.cpp: Dropped the pool size from 32MB
to 16MB.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 15 Jan 2011 23:41:48 +0000 (23:41 +0000)]
2011-01-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75708.
http://trac.webkit.org/changeset/75708
https://bugs.webkit.org/show_bug.cgi?id=52521
Breaks Qt build if mobility is not installed. (Requested by
benjaminp on #webkit).
* WebCore.pro:
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(WebCore::MediaPlayerPrivateQt::supportsFullscreen):
2011-01-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75708.
http://trac.webkit.org/changeset/75708
https://bugs.webkit.org/show_bug.cgi?id=52521
Breaks Qt build if mobility is not installed. (Requested by
benjaminp on #webkit).
* Api/qwebkitplatformplugin.h:
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):
* WebCoreSupport/ChromeClientQt.h:
* WebCoreSupport/FullScreenVideoQt.cpp: Removed.
* WebCoreSupport/FullScreenVideoQt.h: Removed.
* WebCoreSupport/QtPlatformPlugin.cpp:
* WebCoreSupport/QtPlatformPlugin.h:
* examples/platformplugin/WebPlugin.cpp:
(WebPlugin::supportsExtension):
(WebPlugin::createExtension):
* examples/platformplugin/WebPlugin.h:
* examples/platformplugin/platformplugin.pro:
* examples/platformplugin/qwebkitplatformplugin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 15 Jan 2011 23:39:36 +0000 (23:39 +0000)]
2011-01-15 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Incorrect behavior changing attributes of an accessor
https://bugs.webkit.org/show_bug.cgi?id=52515
defineProperty doesn't correctly handle changing attributes of an accessor
property. This is because we don't pass the full descriptor to the
putDescriptor helper function, which means we have insufficient information
to do the right thing. Once that's passed the correct behavior is relatively
simple to implement.
* runtime/JSObject.cpp:
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sat, 15 Jan 2011 20:44:35 +0000 (20:44 +0000)]
<webkit.org/b/52512> REGRESSION(r73818): range.cloneContents() ignores end offset
Reviewed by Adele Peterson.
WebCore:
The fix for Bug 50710 in r73799 introduced an off-by-one error
when copying nodes to a local NodeVector for processing. A fix
was attempted for Bug 50854 in r73818, but instead of stopping
at the end offset, it iterates through all the sibling nodes
because the loop variable (i) is never incremented. To clean
this up, revert back to the code in r73799 and fix the
off-by-one error.
Test: fast/dom/Range/range-clone-contents.html
* dom/Range.cpp:
(WebCore::Range::processContents): Fix the loop that copies
nodes to a local NodeVector by restoring the code from r73799
and fixing the off-by-one error.
LayoutTests:
* fast/dom/Range/range-clone-contents-expected.txt: Added.
* fast/dom/Range/range-clone-contents.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 15 Jan 2011 20:04:11 +0000 (20:04 +0000)]
2011-01-15 Adam Barth <abarth@webkit.org>
Teach svn-apply about WebKit2 move.
* Scripts/VCSUtils.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 15 Jan 2011 20:02:03 +0000 (20:02 +0000)]
Move WebKit2 into Source
https://bugs.webkit.org/show_bug.cgi?id=52438
Rubber-stamped by Eric Seidel.
.:
Update reference to WebKit2.
* DerivedSources.pro:
* GNUmakefile.am:
* Makefile:
* Source/cmake/WebKitPackaging.cmake:
* WebKit.pro:
* configure.ac:
Source/WebCore:
* WebCore.pro:
Source/WebKit2:
* DerivedSources.pro:
* GNUmakefile.am:
* WebKit2.pro:
* WebProcess.pro:
* win/WebKit2.vcproj:
* win/WebKit2WebProcess.vcproj:
Tools:
* MiniBrowser/qt/MiniBrowser.pro:
* Scripts/build-webkit:
* Scripts/do-file-rename:
* Scripts/do-webcore-rename:
* Scripts/test-webkitpy:
* Scripts/webkitdirs.pm:
* Scripts/webkitpy/style/checker.py:
* WebKitTestRunner/DerivedSources.pro:
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/qt/WebKitTestRunner.pro:
WebKit/win:
Update reference to WebKit2.
* WebKit.vcproj/WebKit.sln:
Websites/bugs.webkit.org:
Remove WebKit2 from the list of top-level source directories.
* PrettyPatch/PrettyPatch.rb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 15 Jan 2011 19:26:32 +0000 (19:26 +0000)]
2011-01-15 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Linux build with FileSystem API enabled fails
https://bugs.webkit.org/show_bug.cgi?id=43878
This patch allows WebKitGtk+ to build with FileSystem API option.
No new tests because no new functionality.
* GNUmakefile.am: Included AsyncFileSystem.h,cpp and Excluded duplicated JSFileException.h,cpp.
* bindings/js/JSDirectoryEntryCustom.cpp: Included ExceptionCode.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sat, 15 Jan 2011 14:51:56 +0000 (14:51 +0000)]
2011-01-15 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] plugins/no-mime-with-valid-extension.html fails
Check extension of resource against installed
plugins when determining mime-type.
https://bugs.webkit.org/show_bug.cgi?id=52288
https://bugs.webkit.org/show_bug.cgi?id=50657
* platform/qt/Skipped:
2011-01-15 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] plugins/no-mime-with-valid-extension.html fails
Check extension of resource against installed
plugins when determining mime-type.
https://bugs.webkit.org/show_bug.cgi?id=52288
https://bugs.webkit.org/show_bug.cgi?id=50657
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::objectContentType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Sat, 15 Jan 2011 14:17:00 +0000 (14:17 +0000)]
2011-01-15 Stephen White <senorblanco@chromium.org>
Unreviewed; updated chromium test expectations.
* platform/chromium-gpu/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Sat, 15 Jan 2011 14:11:12 +0000 (14:11 +0000)]
2011-01-15 Stephen White <senorblanco@chromium.org>
Unreviewed; updated chromium test expectations.
* platform/chromium-gpu/test_expectations.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Sat, 15 Jan 2011 09:33:09 +0000 (09:33 +0000)]
2011-01-15 Jochen Eisinger <jochen@chromium.org>
Reviewed by David Levin.
[chromium] remove obsolete createView method
https://bugs.webkit.org/show_bug.cgi?id=52437
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createView):
* DumpRenderTree/chromium/WebViewHost.h:
2011-01-15 Jochen Eisinger <jochen@chromium.org>
Reviewed by David Levin.
[chromium] remove obsolete createView method
https://bugs.webkit.org/show_bug.cgi?id=52437
* public/WebViewClient.h:
(WebKit::WebViewClient::createView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Sat, 15 Jan 2011 08:58:24 +0000 (08:58 +0000)]
2011-01-15 Tony Chang <tony@chromium.org>
Unreviewed, add new test to GTK+ Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=52508
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sat, 15 Jan 2011 06:48:32 +0000 (06:48 +0000)]
2011-01-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Plugins render incorrectly with transformed ancestors
https://bugs.webkit.org/show_bug.cgi?id=52507
-[NSView visibleRect] gives the wrong answer if there are CSS transforms
in the ancestor chain of a plugin.
So use of this method with calls to -actualVisibleRectInWindow, which
maps rects through the render tree to compute the correct rect,
clipping via windowClipRect() if necessary.
Not testable, because doing so relies on the behavior of some
plugins, which stop rendering if setWindow passes an empty rect.
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView updateAndSetWindow]):
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 15 Jan 2011 06:35:13 +0000 (06:35 +0000)]
2011-01-14 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
[jsfunfuzz] Incorrect handling of consecutive duplicate labels
https://bugs.webkit.org/show_bug.cgi?id=52505
Add a few tests of consecutive labels containing duplicates to the parser check.
* fast/js/parser-syntax-check-expected.txt:
* fast/js/script-tests/parser-syntax-check.js:
2011-01-14 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
[jsfunfuzz] Incorrect handling of consecutive duplicate labels
https://bugs.webkit.org/show_bug.cgi?id=52505
Compare StringImpl*'s instead of Identifier*'s when looking for duplicate
labels.
* parser/JSParser.cpp:
(JSC::JSParser::parseExpressionOrLabelStatement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 15 Jan 2011 06:01:15 +0000 (06:01 +0000)]
2011-01-14 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Darin Fisher.
Prepare Linux WebThemeEngine interface to support new theme parts.
https://bugs.webkit.org/show_bug.cgi?id=52413
* public/linux/WebThemeEngine.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 15 Jan 2011 05:38:48 +0000 (05:38 +0000)]
2011-01-14 Sam Magnuson <smagnuso@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Compile with QT_NO_GRAPHICSVIEW
https://bugs.webkit.org/show_bug.cgi?id=49750
* platform/graphics/qt/GraphicsLayerQt.cpp:
* platform/graphics/qt/GraphicsLayerQt.h:
* platform/qt/PlatformMouseEventQt.cpp:
2011-01-14 Sam Magnuson <smagnuso@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Compile with QT_NO_GRAPHICSVIEW
https://bugs.webkit.org/show_bug.cgi?id=49750
* Api/qgraphicswebview.cpp:
* Api/qgraphicswebview.h:
* Api/qwebpage.cpp:
(QWebPage::event):
* Api/qwebpage_p.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
* WebCoreSupport/PageClientQt.cpp:
* WebCoreSupport/PageClientQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Sat, 15 Jan 2011 04:20:20 +0000 (04:20 +0000)]
Not reviewed, update of Chromium test expectations.
Update of files affected by mass rebaseline in r75828 and r75838
* platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.checksum:
* platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png:
* platform/chromium-mac/plugins/embed-attributes-style-expected.txt: Removed.
* platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
* platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sat, 15 Jan 2011 03:53:29 +0000 (03:53 +0000)]
2011-01-14 Simon Fraser <simon.fraser@apple.com>
No review.
Initialize m_operationInProgress after r75855.
* runtime/Heap.cpp:
(JSC::Heap::Heap):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 15 Jan 2011 03:32:19 +0000 (03:32 +0000)]
Reverted accidentally committed code from my last checkin.
* runtime/Heap.cpp:
(JSC::Heap::markRoots):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 15 Jan 2011 03:28:16 +0000 (03:28 +0000)]
Try to fix the GTK bot.
Reviewed by Sam Weinig.
* runtime/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::markRoots): Kids, remember to initialize your data members.
Knowing is half the battle.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Sat, 15 Jan 2011 02:33:53 +0000 (02:33 +0000)]
Not reviewed, update of test expectations.
Ignore new test fast/js/js-continue-break-restrictions.html, it fails for V8.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ericu@chromium.org [Sat, 15 Jan 2011 02:26:35 +0000 (02:26 +0000)]
2011-01-14 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Add tests for FileWriterSync
https://bugs.webkit.org/show_bug.cgi?id=50720
* fast/filesystem/resources/file-writer-sync-truncate-extend.js: Added.
* fast/filesystem/workers/file-writer-sync-truncate-extend.html: Added.
* fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Added.
* fast/filesystem/resources/file-writer-sync-write-overlapped.js: Added.
* fast/filesystem/workers/file-writer-sync-write-overlapped.html: Added.
* fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Added.
* fast/filesystem/resources/file-writer-utils.js:
(assert): Make assert throw, rather than continue.
(cleanUp): Always call finishJSTest, even without fileEntryForCleanup.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 15 Jan 2011 02:22:03 +0000 (02:22 +0000)]
2011-01-14 Patrick Gansterer <paroga@webkit.org>
Unreviewed. Try to fix EFL build.
* ewk/ewk_frame.cpp:
(ewk_frame_scroll_add): Added WebCore namespace to IntSize.
* ewk/ewk_view.cpp:
(_ewk_view_viewport_attributes_compute): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 15 Jan 2011 02:14:45 +0000 (02:14 +0000)]
2011-01-14 Oliver Hunt <oliver@apple.com>
Reviewed by Stephanie Lewis.
[jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
https://bugs.webkit.org/show_bug.cgi?id=52501
Add checks for correct behaviour when the strict mode token is immediately followed
by a value that needs a temporary buffer in the lexer.
* fast/js/basic-strict-mode-expected.txt:
* fast/js/script-tests/basic-strict-mode.js:
2011-01-14 Oliver Hunt <oliver@apple.com>
Reviewed by Stephanie Lewis.
[jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
https://bugs.webkit.org/show_bug.cgi?id=52501
Clear the temporary character buffers used for reading escaped characters and
numbers.
* parser/Lexer.h:
(JSC::Lexer::setOffset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Sat, 15 Jan 2011 02:06:08 +0000 (02:06 +0000)]
2011-01-14 Tony Chang <tony@chromium.org>
Reviewed by Alexey Proskuryakov.
Strip NUL character when copying text on Windows
https://bugs.webkit.org/show_bug.cgi?id=52236
* editing/pasteboard/copy-null-characters-expected.txt: Added.
* editing/pasteboard/copy-null-characters.html: Added.
2011-01-14 Tony Chang <tony@chromium.org>
Reviewed by Alexey Proskuryakov.
Strip NUL character when copying text on Windows
https://bugs.webkit.org/show_bug.cgi?id=52236
Test: editing/pasteboard/copy-null-characters.html
* editing/Editor.cpp:
(WebCore::Editor::selectedText):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection): Use editor()->selectedText() which matches the other platforms.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Sat, 15 Jan 2011 01:59:05 +0000 (01:59 +0000)]
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
No new tests because the behavior remains the same.
* WebCore.exp.in:
* WebCore.order:
* history/PageCache.cpp:
(WebCore::PageCache::releaseAutoreleasedPagesNow):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::cachedResource):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::data):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::setDecodedSize):
(WebCore::CachedResource::setEncodedSize):
(WebCore::CachedResource::didAccessDecodedData):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::clearPreloads):
(WebCore::CachedResourceLoader::printPreloadStats):
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::load):
(WebCore::CachedResourceRequest::didFail):
(WebCore::CachedResourceRequest::didReceiveResponse):
* loader/cache/MemoryCache.cpp:
(WebCore::memoryCache):
* loader/cache/MemoryCache.h:
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
* src/WebCache.cpp:
(WebKit::WebCache::setCapacities):
(WebKit::WebCache::clear):
(WebKit::WebCache::getUsageStats):
(WebKit::WebCache::getResourceTypeStats):
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
* webkit/webkitglobals.cpp:
(webkit_set_cache_model):
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
* Misc/WebCache.mm:
(+[WebCache statistics]):
(+[WebCache setDisabled:]):
(+[WebCache isDisabled]):
* WebView/WebView.mm:
(+[WebView _setCacheModel:]):
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
* Api/qwebpage.cpp:
(QWebPagePrivate::_q_cleanupLeakMessages):
* Api/qwebsettings.cpp:
(QWebSettings::clearMemoryCaches):
(QWebSettings::setObjectCacheCapacities):
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
* WebCache.cpp:
(WebCache::statistics):
(WebCache::empty):
(WebCache::setDisabled):
(WebCache::disabled):
* WebView.cpp:
(WebView::setCacheModel):
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
* WebView.cpp:
(wxWebView::SetCachePolicy):
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shutdownIfPossible):
(WebKit::WebProcess::didClose):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformSetCacheModel):
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformSetCacheModel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 15 Jan 2011 01:52:28 +0000 (01:52 +0000)]
Try to fix non-Dtrace builds: #include Tracing.h instead of TracingDtrace.h.
* runtime/Heap.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 15 Jan 2011 01:43:29 +0000 (01:43 +0000)]
2011-01-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Split out a MarkedSpace strategy object from Heap.
https://bugs.webkit.org/show_bug.cgi?id=52421
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics memoryStatistics]): Updated for class move.
2011-01-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Split out a MarkedSpace strategy object from Heap.
https://bugs.webkit.org/show_bug.cgi?id=52421
SunSpider reports no change.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Updated our 7 build systems. Which is cool.
* runtime/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::destroy):
(JSC::Heap::recordExtraCost):
(JSC::Heap::allocate):
(JSC::Heap::markConservatively):
(JSC::Heap::markRoots):
(JSC::Heap::objectCount):
(JSC::Heap::statistics):
(JSC::Heap::size):
(JSC::Heap::isBusy):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::primaryHeapBegin):
(JSC::Heap::primaryHeapEnd):
* runtime/Heap.h:
(JSC::Heap::globalData):
(JSC::Heap::markedSpace):
(JSC::Heap::isCellMarked):
(JSC::Heap::checkMarkCell):
(JSC::Heap::markCell): Moved all code pertaining to managing chunks of
collector memory out of this class. Heap now just delegates to MarkedSpace.
* runtime/JSCell.h:
(JSC::JSCell::Heap::heap): Updated for MarkedSpace delegation.
* runtime/JSValue.h: Moved the ValueStringPair typedef to help with #includes.
* runtime/MarkedSpace.cpp: Copied from runtime/Heap.cpp.
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::destroy):
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::freeBlock):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::resizeBlocks):
(JSC::MarkedSpace::growBlocks):
(JSC::MarkedSpace::shrinkBlocks):
(JSC::MarkedSpace::markConservatively):
(JSC::MarkedSpace::clearMarkBits):
(JSC::MarkedSpace::markedCells):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::addToStatistics):
(JSC::MarkedSpace::statistics):
(JSC::MarkedSpace::size):
(JSC::MarkedSpace::reset):
(JSC::MarkedSpace::primaryHeapBegin):
(JSC::MarkedSpace::primaryHeapEnd):
* runtime/MarkedSpace.h: Copied from runtime/Heap.h.
(JSC::MarkedSpace::globalData):
(JSC::MarkedSpace::didShrink):
(JSC::MarkedSpace::cellBlock):
(JSC::MarkedSpace::cellOffset):
(JSC::MarkedSpace::isCellMarked):
(JSC::MarkedSpace::checkMarkCell):
(JSC::MarkedSpace::markCell): Moved all code pertaining to managing chunks of
collector memory into this class.
* runtime/MemoryStatistics.cpp:
(JSC::heapStatistics):
* runtime/MemoryStatistics.h: Updated for MarkedSpace delegation.
2011-01-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Split out a MarkedSpace strategy object from Heap.
https://bugs.webkit.org/show_bug.cgi?id=52421
* Shared/mac/WebMemorySampler.mac.mm:
(WebKit::WebMemorySampler::sampleWebKit): Updated for class move.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Sat, 15 Jan 2011 01:40:28 +0000 (01:40 +0000)]
2011-01-14 Nico Weber <thakis@chromium.org>
Unreviewed, test expectations.
Rebaseline gradient test due to updated skia. reed checked the test and
says the new look is right and is an intentional change.
https://bugs.webkit.org/show_bug.cgi?id=52105
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.checksum:
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-win/svg/batik/paints/gradientLimit-expected.checksum:
* platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 15 Jan 2011 01:31:09 +0000 (01:31 +0000)]
2011-01-14 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Add a new PageClient::displayView function and expose it on WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=52500
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::displayView):
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::displayView):
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::displayView):
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::displayView):
* UIProcess/win/WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 15 Jan 2011 01:22:58 +0000 (01:22 +0000)]
2011-01-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
[jsfunfuzz] parser doesn't enforce continue restrictions correctly.
https://bugs.webkit.org/show_bug.cgi?id=52493
Add a few tests for continue to cover the cases where continue
isn't syntactically valid.
* fast/js/js-continue-break-restrictions-expected.txt: Added.
* fast/js/js-continue-break-restrictions.html: Added.
* fast/js/script-tests/js-continue-break-restrictions.js: Added.
2011-01-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
[jsfunfuzz] parser doesn't enforce continue restrictions correctly.
https://bugs.webkit.org/show_bug.cgi?id=52493
This patch reworks handling of break, continue and label statements
to correctly handle all the valid and invalid cases. Previously certain
errors would be missed by the parser in strict mode, but the bytecode
generator needed to handle those cases for non-strict code so nothing
failed, it simply became non-standard behaviour.
Now that we treat break and continue errors as early faults in non-strict
mode as well that safety net has been removed so the parser bugs result in
crashes at codegen time.
* parser/JSParser.cpp:
(JSC::JSParser::ScopeLabelInfo::ScopeLabelInfo):
(JSC::JSParser::next):
(JSC::JSParser::nextTokenIsColon):
(JSC::JSParser::continueIsValid):
Continue is only valid in loops so we can't use breakIsValid()
(JSC::JSParser::pushLabel):
We now track whether the label is for a loop (and is therefore a
valid target for continue.
(JSC::JSParser::popLabel):
(JSC::JSParser::getLabel):
Replace hasLabel with getLabel so that we can validate the target
when parsing continue statements.
(JSC::JSParser::Scope::continueIsValid):
(JSC::JSParser::Scope::pushLabel):
(JSC::JSParser::Scope::getLabel):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseBreakStatement):
(JSC::JSParser::parseContinueStatement):
(JSC::LabelInfo::LabelInfo):
(JSC::JSParser::parseExpressionOrLabelStatement):
Consecutive labels now get handled iteratively so that we can determine
whether they're valid targets for continue.
* parser/Lexer.cpp:
(JSC::Lexer::nextTokenIsColon):
* parser/Lexer.h:
(JSC::Lexer::setOffset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 15 Jan 2011 01:20:45 +0000 (01:20 +0000)]
Source/WebCore: WebCore part of <rdar://problem/
8441312> Crash in -[NSView _invalidateGStatesForTree]
Reviewed by Simon Fraser.
* WebCore.exp.in: Export RenderWidget::suspendWidgetHierarchyUpdates() and
RenderWidget::resumeWidgetHierarchyUpdates().
* manual-tests/plug-in-mutates-NSView-hierarchy-during-resize.html: Added.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry): Removed the assertion that widget hierarchy updates
are disabled. When this assertion was added, this condition was a subset of the “calling out to
plug-in code is forbidden” condition, hence the assertion was valid. The WebKit part of this
change now suspends widget hierarchy updates even at times where plug-in code is expected to be
called, which invalidates the assertion.
WebKit/mac: WebKit/mac part of <rdar://problem/
8441312> Crash in -[NSView _invalidateGStatesForTree]
Reviewed by Simon Fraser.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
that the NSView tree doesn’t change from under AppKit as it traverses it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 15 Jan 2011 01:19:57 +0000 (01:19 +0000)]
2011-01-14 Ahmad Sharif <asharif.tools@gmail.com>
Reviewed by Darin Fisher.
When inlining is performed, the progress variable is
declared as uninitialized.
https://bugs.webkit.org/show_bug.cgi?id=51084
* WebCore: Copied from WebCore.
* WebCore/page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::getAnimatedStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 15 Jan 2011 01:18:58 +0000 (01:18 +0000)]
2011-01-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement the "should paint bounds instead of indiviual rects" algorithm from WebKit1
https://bugs.webkit.org/show_bug.cgi?id=52499
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::shouldPaintBoundsRect):
Port code from -[WebView _mustDrawUnionedRect:singleRects:count:].
(WebKit::DrawingAreaImpl::display):
If shouldPaintBoundsRect returns true, clear the rects vector and append the bounds rect.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 15 Jan 2011 01:17:16 +0000 (01:17 +0000)]
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* rendering/style/StyleRareInheritedData.cpp:
* rendering/style/StyleRareNonInheritedData.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Sat, 15 Jan 2011 01:15:05 +0000 (01:15 +0000)]
2011-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix expanded lines in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52498
Fixes them to work now that we have wrapper divs.
Also fixes the long-standing bug that the line numbers
were incorrect sometimes.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 15 Jan 2011 01:08:11 +0000 (01:08 +0000)]
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* rendering/style/RenderStyle.cpp:
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* ewk/ewk_view.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Sat, 15 Jan 2011 01:02:18 +0000 (01:02 +0000)]
2011-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
put remove lines to the left of add lines in sidebyside view
https://bugs.webkit.org/show_bug.cgi?id=52458
Also, sneaking in a fix to make long lines with no whitespace wrap.
* PrettyPatch/PrettyPatch.rb:
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 15 Jan 2011 01:00:21 +0000 (01:00 +0000)]
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* editing/EditorCommand.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 15 Jan 2011 00:55:15 +0000 (00:55 +0000)]
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* editing/ApplyStyleCommand.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 15 Jan 2011 00:44:33 +0000 (00:44 +0000)]
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* css/CSSStyleSelector.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Sat, 15 Jan 2011 00:42:13 +0000 (00:42 +0000)]
2011-01-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Fix a few things in the WebKit2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=52484
* platform/mac-wk2/Skipped: Add/remove some tests to the WK2 skipped list.
* editing/style/stylewithcss-without-selection.html: Fix this test to avoid
referencing an undefined variable in the failure case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 15 Jan 2011 00:35:26 +0000 (00:35 +0000)]
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* rendering/InlineFlowBox.h:
* rendering/RenderBoxModelObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 15 Jan 2011 00:29:29 +0000 (00:29 +0000)]
2011-01-14 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
https://bugs.webkit.org/show_bug.cgi?id=45186
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scheduleScavenger): Added missing this pointer to CreateTimerQueueTimer().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Sat, 15 Jan 2011 00:28:51 +0000 (00:28 +0000)]
2011-01-14 Mihai Parparita <mihaip@chromium.org>
Update the svg/ pixel expectations for the chromium-mac port.
For the pixel tests that currently fail on Snow Leopard, this moves the
current pixel results to platform/chromium-mac-leopard and adds new
results to platform/chromium-mac.
List of files omitted due to length but composed entirely of moves from
platform/chromium-mac to platform/chromium-mac-leopard and newly added
files in platform/chromium-mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 15 Jan 2011 00:27:07 +0000 (00:27 +0000)]
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Reviewed by David Levin.
Do some forward declaration in RenderStyle.h
https://bugs.webkit.org/show_bug.cgi?id=52453
No new tests because no new functionality.
* css/CSSComputedStyleDeclaration.cpp:
* css/CSSStyleSelector.cpp:
* editing/Editor.cpp:
* page/EventHandler.cpp:
* rendering/EllipsisBox.cpp:
* rendering/InlineBox.cpp:
* rendering/InlineTextBox.cpp:
* rendering/RenderBlock.cpp:
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
* rendering/RenderBox.h:
* rendering/RenderEmbeddedObject.cpp:
* rendering/RenderFieldset.cpp:
* rendering/RenderFileUploadControl.cpp:
* rendering/RenderFrameSet.cpp:
* rendering/RenderHTMLCanvas.cpp:
* rendering/RenderImageResource.cpp:
* rendering/RenderInputSpeech.cpp:
* rendering/RenderLayer.h:
* rendering/RenderLineBoxList.cpp:
* rendering/RenderListBox.cpp:
* rendering/RenderMediaControlsChromium.cpp:
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
* rendering/RenderObjectChildList.cpp:
* rendering/RenderProgress.cpp:
* rendering/RenderScrollbarPart.cpp:
* rendering/RenderTable.cpp:
* rendering/RenderTable.h:
* rendering/RenderTableCell.cpp:
* rendering/RenderTableRow.cpp:
* rendering/RenderTableSection.cpp:
* rendering/RenderTheme.cpp:
* rendering/RenderThemeChromiumSkia.cpp:
* rendering/RenderThemeChromiumWin.cpp:
* rendering/RootInlineBox.cpp:
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareInheritedData.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Sat, 15 Jan 2011 00:19:27 +0000 (00:19 +0000)]
2011-01-14 Jochen Eisinger <jochen@chromium.org>
Unreviewed, roll chromium deps to r71432.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sat, 15 Jan 2011 00:16:47 +0000 (00:16 +0000)]
2011-01-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Stop instantiating legacy editing positions in AccessibilityRenderObject.cpp, Element.cpp,
BreakBlockquoteCommand.cpp, CompositeEditCommand.cpp, and DeleteButtonController.cpp
https://bugs.webkit.org/show_bug.cgi?id=52481
Removed instantiation of legacy editing positions.
Calls to Position::Position are replaced by calls to Position's convenience functions.
Also fixed firstPositionInOrBeforeNode and lastPositionInOrAfterNode so that
they instantiate right positions for text nodes.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setSelectedTextRange):
* dom/Element.cpp:
(WebCore::Element::updateFocusAppearance):
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::inputText):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
(WebCore::CompositeEditCommand::moveParagraphs):
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
(WebCore::CompositeEditCommand::splitTreeToNode):
* editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
* editing/htmlediting.h:
(WebCore::firstPositionInOrBeforeNode): Instantiates firstPositionInNode instead of
positionBeforeNode for a text node.
(WebCore::lastPositionInOrAfterNode): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 14 Jan 2011 23:46:58 +0000 (23:46 +0000)]
2011-01-14 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
Shadow is not drawn when filling a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=51982
This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::fillPath(const Path& path). We need to draw the
gradient clipped to the path on a CGLayer first, and then draw the
layer on the GraphicsContext.
* fast/canvas/canvas-fillPath-gradient-shadow-expected.txt: Added.
* fast/canvas/canvas-fillPath-gradient-shadow.html: Added.
* fast/canvas/script-tests/canvas-fillPath-gradient-shadow.js: Added.
* platform/chromium/test_expectations.txt: Skipping new test since it fails.
* platform/qt/Skipped: Ditto.
2011-01-14 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
Shadow is not drawn when filling a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=51982
This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::fillPath(const Path& path). We need to draw the
gradient clipped to the path on a CGLayer first, and then draw the
layer on the GraphicsContext.
Test: fast/canvas/canvas-fillPath-gradient-shadow.html
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 14 Jan 2011 23:45:17 +0000 (23:45 +0000)]
2011-01-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
Layer syncing should go through the compositor
https://bugs.webkit.org/show_bug.cgi?id=52486
Rather than have FrameView go directly to GraphicsLayer to
sync pending changes, route the call through RenderLayerCompositor.
Add a FIXME about an existing issue with flushing and subframes.
No behavior change, so no tests.
* page/FrameView.cpp:
(WebCore::FrameView::syncCompositingStateForThisFrame):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::notifySyncRequired):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scheduleLayerFlush):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::notifySyncRequired):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 14 Jan 2011 23:37:14 +0000 (23:37 +0000)]
2011-01-14 Ojan Vafai <ojan@chromium.org>
Fix bad merge in r75816.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 14 Jan 2011 23:36:39 +0000 (23:36 +0000)]
2011-01-14 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
https://bugs.webkit.org/show_bug.cgi?id=45186
r75819 accidentally changed the initial state of the scavenge timer.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::initializeScavenger): Changed initial state of m_scavengingSuspended to true.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 14 Jan 2011 23:35:20 +0000 (23:35 +0000)]
Fix for <rdar://problem/
7793902> Artifacts when scrolling
page in Safari while page is loading
Reviewed by Mark Rowe.
Call setDrawsBackground:YES on the scrollView in
dispatchDidFirstLayout() rather than waiting until
frameLoadCompleted(). Also suspend scrolling elasticity
between provisionalLoadStarted() and dispatchDidFirstLayout()
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::WebFrameLoaderClient):
(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::provisionalLoadStarted):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 14 Jan 2011 23:04:40 +0000 (23:04 +0000)]
2011-01-14 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for the chromium-mac port.
For the pixel tests that currently fail on Snow Leopard, this moves the
current pixel results to platform/chromium-mac-leopard and adds new
results to platform/chromium-mac.
List of files omitted due to length but composed entirely of moves from
platform/chromium-mac to platform/chromium-mac-leopard and newly added
files in platform/chromium-mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 14 Jan 2011 22:57:51 +0000 (22:57 +0000)]
2011-01-14 Patrick Gansterer <paroga@webkit.org>
Unreviewed Windows Release build fix.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scavengerTimerFired):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 14 Jan 2011 22:57:10 +0000 (22:57 +0000)]
ShouldLoadResourceForFrame should use strings, not URLs.
https://bugs.webkit.org/show_bug.cgi?id=52476
Reviewed by Geoff Garen.
Tools:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
WebKit2:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::shouldLoadResourceForFrame): Pass resourceURL as a string instead of
a URL, and rename from subresourceURL to resourceURL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 14 Jan 2011 22:49:09 +0000 (22:49 +0000)]
2011-01-14 Patrick Gansterer <paroga@webkit.org>
Unreviewed Windows Release build fix.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scavengerTimerFired):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 14 Jan 2011 22:45:22 +0000 (22:45 +0000)]
2011-01-14 Steve Lacey <sjl@chromium.org>
Reviewed by Simon Fraser.
Update media/video-zoom-controls.html to set the video source before initializing the test.
https://bugs.webkit.org/show_bug.cgi?id=52461
* media/video-zoom-controls.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 14 Jan 2011 22:40:17 +0000 (22:40 +0000)]
2011-01-14 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Fix parent block calculation when trying to find top most node
containing "this" float.
https://bugs.webkit.org/show_bug.cgi?id=51711
Replace use of containingBlock and traverse the parents directly
to check for float existence. containingBlock can skip parents and
jump to the RenderView directly which will cause floats to not get
cleared from intermediate parents.
Test: fast/block/float/floats-not-cleared-crash.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
2011-01-14 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Tests that we do not crash due to uncleared floats in parent nodes.
https://bugs.webkit.org/show_bug.cgi?id=51711
* fast/block/float/floats-not-cleared-crash-expected.txt: Added.
* fast/block/float/floats-not-cleared-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 14 Jan 2011 22:39:30 +0000 (22:39 +0000)]
Fix for <rdar://problem/
8711576> The web process should be able to read resources from the UI process.
Reviewed by Sam Weinig.
Based on a patch by Ivan Krstić. This also makes the NSURLCache path a sandbox parameter.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
Encode and decode the uiProcessBundleResourcePath member variable.
* Shared/WebProcessCreationParameters.h:
Add uiProcessBundleResourcePath member variable.
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
Set the uiProcessBundleResourcePath member variable.
* WebProcess/com.apple.WebProcess.sb:
Allow read-only access to UI_PROCESS_BUNDLE_RESOURCE_DIR and all subdirectories.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
When initializing the sandbox, pass UI_PROCESS_BUNDLE_RESOURCE_DIR.
(WebKit::WebProcess::platformInitializeWebProcess):
Remove the code that would consume a sandbox extension for the url cache path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 14 Jan 2011 22:32:53 +0000 (22:32 +0000)]
REGRESSION (r75660): compositing/reflections/load-video-in-reflection.html crashes on Windows 7
https://bugs.webkit.org/show_bug.cgi?id=52397
Unskipping tests that no longer fail on Windows 7 Release. Unreviewed.
* platform/win/Skipped:
Un-skip compositing/reflections/load-video-in-reflection.html, which appears to be fixed by
http://trac.webkit.org/changeset/75807
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ericu@chromium.org [Fri, 14 Jan 2011 22:27:12 +0000 (22:27 +0000)]
Add ericu@chromium.org [me] to the committers file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 14 Jan 2011 22:21:58 +0000 (22:21 +0000)]
2011-01-14 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
https://bugs.webkit.org/show_bug.cgi?id=45186
Use CreateTimerQueueTimer() to start periodicScavenge() and stop it with DeleteTimerQueueTimer().
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::initializeScavenger):
(WTF::TCMalloc_PageHeap::isScavengerSuspended):
(WTF::TCMalloc_PageHeap::scheduleScavenger):
(WTF::TCMalloc_PageHeap::rescheduleScavenger):
(WTF::TCMalloc_PageHeap::suspendScavenger):
(WTF::scavengerTimerFired):
(WTF::TCMalloc_PageHeap::periodicScavenge):
(WTF::TCMalloc_PageHeap::signalScavenger):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Fri, 14 Jan 2011 22:15:06 +0000 (22:15 +0000)]
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Reviewed by David Levin.
Add Tony Gentilcore as a reviewer
https://bugs.webkit.org/show_bug.cgi?id=52480
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 14 Jan 2011 22:13:36 +0000 (22:13 +0000)]
2011-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
improve line selection with fast drags
https://bugs.webkit.org/show_bug.cgi?id=52477
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 14 Jan 2011 22:00:55 +0000 (22:00 +0000)]
2011-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
tweak line selection in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52462
-Improve handling of data-comment-base-line code to deal with
lines that have multiple values.
-Make it so that if you click on the line immediately above
a line that has a comment it will add a new comment instead of
adding lines to the following comment. If the last selected line
overlaps existing comment lines though they will still get
added to the existing comment.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 14 Jan 2011 21:59:45 +0000 (21:59 +0000)]
2011-01-14 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42237
Remove Chromium-specific implementation from WebCore.
No tests added; this refactor should be covered by existing history-exercising tests.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* history/BackForwardListChromium.cpp: Removed.
* history/BackForwardListImpl.h:
2011-01-14 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42237
Replace Chromium-specific BackForwardListClient in WebCore with a Chromium impl
of the BackForwardList interface.
* WebKit.gyp:
* src/BackForwardListChromium.cpp: Copied from WebKit/chromium/src/BackForwardListClientImpl.cpp.
(WebKit::BackForwardListChromium::create):
(WebKit::BackForwardListChromium::BackForwardListChromium):
(WebKit::BackForwardListChromium::~BackForwardListChromium):
(WebKit::BackForwardListChromium::addItem):
(WebKit::BackForwardListChromium::goToItem):
(WebKit::BackForwardListChromium::itemAtIndex):
(WebKit::BackForwardListChromium::backListCount):
(WebKit::BackForwardListChromium::forwardListCount):
(WebKit::BackForwardListChromium::isActive):
(WebKit::BackForwardListChromium::close):
* src/BackForwardListChromium.h: Copied from WebKit/chromium/src/BackForwardListClientImpl.h.
* src/BackForwardListClientImpl.cpp: Removed.
* src/BackForwardListClientImpl.h: Removed.
* src/FrameLoaderClientImpl.cpp:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadHistoryItem):
(WebKit::WebFrameImpl::currentHistoryItem):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
* src/WebViewImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 14 Jan 2011 21:51:53 +0000 (21:51 +0000)]
Delay initializing the sandbox until we get the InitializeWebProcess message.
Reviewed by Sam Weinig.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
(WebKit::WebProcess::platformInitializeWebProcess):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 14 Jan 2011 21:30:09 +0000 (21:30 +0000)]
2011-01-14 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
check-webkit-style: _FunctionState should keep track of where the function name starts.
https://bugs.webkit.org/show_bug.cgi?id=52454
* Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
_FunctionState and logic for setting it correctly.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 14 Jan 2011 20:43:49 +0000 (20:43 +0000)]
2011-01-14 Konstantin Tokarev <annulen@yandex.ru>
Reviewed by Laszlo Gombos.
[Qt] Fixed compilation when QT_NO_SHORTCUT is defined
https://bugs.webkit.org/show_bug.cgi?id=52460
This patch fixes compilation when QT_NO_SHORTCUT is defined in Qt
configuration.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleKeyboardEvent): Added QT_NO_SHORTCUT guards
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Fri, 14 Jan 2011 20:39:09 +0000 (20:39 +0000)]
2011-01-12 Satish Sampath <satish@chromium.org>
Reviewed by Dimitri Glazkov.
Fix a crash when accessing speech input from script.
https://bugs.webkit.org/show_bug.cgi?id=52325
Added a layout test to check enabling/disabling speech input from script.
* fast/speech/speech-input-scripting-expected.txt: Added.
* fast/speech/speech-input-scripting.html: Added.
2011-01-12 Satish Sampath <satish@chromium.org>
Reviewed by Dimitri Glazkov.
Fix a crash when accessing speech input from script.
https://bugs.webkit.org/show_bug.cgi?id=52325
Test: fast/speech/speech-input-scripting.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute): Recreate renderer when speech input is enabled/disabled.
* rendering/RenderTextControlSingleLine.cpp: Remove unused code.
* rendering/RenderTextControlSingleLine.h:
* rendering/TextControlInnerElements.cpp: Take self references before firing events and check for renderer validity after.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
(WebCore::InputFieldSpeechButtonElement::detach):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 14 Jan 2011 20:35:01 +0000 (20:35 +0000)]
2011-01-14 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Prevent merging of anonymous blocks if one of them is already getting
destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52402
Test: fast/block/merge-anonymous-block-remove-child-crash2.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock): initialize m_beingDestroyed to false.
(WebCore::RenderBlock::destroy): set m_beingDestroyed to true.
(WebCore::canMergeContiguousAnonymousBlocks): do not merge if any or prev or next is being destroyed.
(WebCore::RenderBlock::removeChild): remove the hack previously done for preventing oldChild merging with nextBlock's next sibling.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::beingDestroyed): public function for m_beingDestroyed.
2011-01-14 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Tests that we do not crash when trying to merge anonymous blocks, one of which
is already getting destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52402
* fast/block/merge-anonymous-block-remove-child-crash2-expected.txt: Added.
* fast/block/merge-anonymous-block-remove-child-crash2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 14 Jan 2011 20:30:45 +0000 (20:30 +0000)]
2011-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Roben.
fix bugs going back and forth between unified and sidebyside
https://bugs.webkit.org/show_bug.cgi?id=52470
Now that we're appending DOM nodes directly, we only want to
get the first ".text" element in the subtree. In the cases
where there are multiple, their contents are the same.
Also, when making side-by-side expansion lines, we need to
clone the contents so we have a second copy to append to the DOM.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 14 Jan 2011 20:27:53 +0000 (20:27 +0000)]
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Follow up to r75791: fix missing dispatch.
https://bugs.webkit.org/show_bug.cgi?id=52442
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 14 Jan 2011 20:01:24 +0000 (20:01 +0000)]
2011-01-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
Issues with contentsScale in GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=52463
Fix various issues with the recent contentsScale changes:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_contentsScale to 1.
(WebCore::GraphicsLayerCA::updateContentsScale): Only do a setNeedsDisplay()
if the layer draws content, otherwise we'll create backing store for empty layers.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Be sure to set contentsScale
on the new (tiled or untiled) layer.
(WebCore::GraphicsLayerCA::cloneLayer): Clones need contentsScale too.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Fri, 14 Jan 2011 19:50:47 +0000 (19:50 +0000)]
2011-01-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Align import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52208
* API/JSBase.h: Align import/export directives with
WebKit2/Shared/API/c/WKBase.h
2011-01-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Align import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52208
* Shared/API/c/WKBase.h: Align import/export directives with
JavaScriptCore/API/JSBase.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 14 Jan 2011 19:16:53 +0000 (19:16 +0000)]
2011-01-14 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] WebKit API: Add a function for form interactive validation setting
https://bugs.webkit.org/show_bug.cgi?id=52430
* public/WebSettings.h: Add a pure setInteractiveFormValidationEnabled().
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setInteractiveFormValidationEnabled): Implemented.
* src/WebSettingsImpl.h: Add a declaration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 14 Jan 2011 18:54:52 +0000 (18:54 +0000)]
2011-01-14 Simon Fraser <simon.fraser@apple.com>
Let Xcode have it's way with the project file.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 14 Jan 2011 18:53:12 +0000 (18:53 +0000)]
2011-01-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
Refactor some FrameView::syncCompositingState code
https://bugs.webkit.org/show_bug.cgi?id=52459
Refactor some code in FrameView related to synchronizing
compositing layer state.
* page/FrameView.cpp:
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::syncCompositingStateRecursive):
(WebCore::FrameView::paintContents):
* page/FrameView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 14 Jan 2011 18:38:25 +0000 (18:38 +0000)]
2011-01-14 Tony Chang <tony@chromium.org>
Unreviewed, updating baselines.
[chromium] rebaseline vertical tests on linux
https://bugs.webkit.org/show_bug.cgi?id=52457
After updating fonts.conf, these tests are now passing.
* platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.png:
* platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.png:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.checksum:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/chromium-linux/svg/batik/text/verticalText-expected.checksum:
* platform/chromium-linux/svg/batik/text/verticalText-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 14 Jan 2011 18:30:16 +0000 (18:30 +0000)]
2011-01-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Eric Seidel.
[Qt] Fix build problem introduced by http://trac.webkit.org/changeset/75713
https://bugs.webkit.org/show_bug.cgi?id=30179
* plugins/symbian/PluginViewSymbian.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 14 Jan 2011 18:09:10 +0000 (18:09 +0000)]
2011-01-14 Vincent Scheib <scheib@chromium.org>
Reviewed by David Levin.
Add support to DumpRenderTree to use the GPU rather than software renderer
https://bugs.webkit.org/show_bug.cgi?id=52333
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2011-01-14 Vincent Scheib <scheib@chromium.org>
Reviewed by David Levin.
Add support to DumpRenderTree to use the GPU rather than software renderer
https://bugs.webkit.org/show_bug.cgi?id=52333
* DEPS: Moved forward to take required support from webkit_support.h
* WebKit.gyp: DumpRenderTree depends on Angle on windows
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 14 Jan 2011 17:35:48 +0000 (17:35 +0000)]
2011-01-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] update fonts.conf to fix 6 linux tests in drt
https://bugs.webkit.org/show_bug.cgi?id=52411
* platform/chromium/test_expectations.txt:
2011-01-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] update fonts.conf to fix 6 linux tests in drt
https://bugs.webkit.org/show_bug.cgi?id=52411
* DumpRenderTree/chromium/fonts.conf: Update to match the copy in
chromium's src/webkit/tools/test_shell/resources/fonts.conf
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 14 Jan 2011 17:27:45 +0000 (17:27 +0000)]
2011-01-14 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add volume slider to media player
https://bugs.webkit.org/show_bug.cgi?id=51532
* platform/gtk/Skipped:
* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/controls-after-reload-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-display-toggle-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-volume-slider-expected.txt: Added.
2011-01-14 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add volume slider to media player
https://bugs.webkit.org/show_bug.cgi?id=51532
* css/mediaControlsGtk.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb):
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 14 Jan 2011 17:03:45 +0000 (17:03 +0000)]
2011-01-14 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by David Levin.
[GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=52434
No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.
* platform/gtk/FileSystemGtk.cpp:
(WebCore::filenameToString): Use GOwnPtr instead of gchar pointer.
(WebCore::fileSystemRepresentation): Ditto.
(WebCore::filenameForDisplay): Ditto.
(WebCore::pathGetFileName): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc