zimmermann@webkit.org [Tue, 22 Jan 2008 11:10:45 +0000 (11:10 +0000)]
Reviewed by Eric.
- fix http://bugs.webkit.org/show_bug.cgi?id=16967
<rdar://problem/
5699344> Reproducible crash when navigating back to a page using SVG fonts
Test: svg/custom/font-platformDestroy-crash.svg
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 22 Jan 2008 10:03:54 +0000 (10:03 +0000)]
Lars Knoll <lars@trolltech.com>
setup a family for cursive and fantasy fonts as well.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 22 Jan 2008 10:03:40 +0000 (10:03 +0000)]
Lars Knoll <lars@trolltech.com>
cleanup the CookieJarQt implementation and implement cookiesEnabled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 22 Jan 2008 10:03:26 +0000 (10:03 +0000)]
Simon Hausmann <hausmann@webkit.org>
Don't compile the ICO plugin when building against Qt >= 4.4
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 22 Jan 2008 10:03:14 +0000 (10:03 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>
Implement ChromeClientQt::setToolTip
Implement ChromeClientQt::mouseDidMoveOverElement
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 22 Jan 2008 08:38:52 +0000 (08:38 +0000)]
Lars Knoll <lars@trolltech.com>
Ported the font implementation to use the new QFont features of Qt 4.4.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 22 Jan 2008 06:48:57 +0000 (06:48 +0000)]
Reviewed by Nikolas & Oliver.
Tested by svg/custom/svg-features.html
* dom/DOMImplementation.cpp:
(WebCore::isSVG10Feature): use ENABLE(SVG_*) conditionals
(WebCore::isSVG11Feature): use ENABLE(SVG_*) conditionals
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Tue, 22 Jan 2008 06:18:10 +0000 (06:18 +0000)]
JavaScriptCore:
Reviewed by Maciej Stachowiak.
Fixed http://bugs.webkit.org/show_bug.cgi?id=16909
REGRESSION: Amazon.com crash (ActivationImp)
(and a bunch of other crashes)
Plus, a .7% SunSpider speedup to boot.
Replaced the buggy currentExec and savedExec mechanisms with an
explicit ExecState stack.
* kjs/collector.cpp:
(KJS::Collector::collect): Explicitly mark the ExecState stack.
(KJS::Collector::reportOutOfMemoryToAllExecStates): Slight change in
behavior: We no longer throw an exception in any global ExecStates,
since global ExecStates are more like pseudo-ExecStates, and aren't
used for script execution. (It's unclear what would happen if you left
an exception waiting around in a global ExecState, but it probably
wouldn't be good.)
WebCore:
Reviewed by Maciej Stachowiak.
Adapted WebCore to the fix for http://bugs.webkit.org/show_bug.cgi?id=16909
REGRESSION: Amazon.com crash (ActivationImp)
* bindings/js/kjs_proxy.cpp:
(WebCore::KJSProxy::~KJSProxy): No convenient way to make this assertion
anymore. (It wasn't firing for anyone, anyway, so it's no big loss.)
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject throwException:]): Use the ExecState stack, instead
of currentExec.
(-[WebScriptObject setException:]): ditto. Also, a slight change in
behavior: If no ExecStates are active, we no longer throw an exception
in the global ExecState. The JavaScriptCore ChangeLog explains why.
This also matches the behavior of +throwException.
LayoutTests:
Layout test for http://bugs.webkit.org/show_bug.cgi?id=16909
REGRESSION: Amazon.com crash (ActivationImp)
* fast/js/exec-state-marking-expected.txt: Added.
* fast/js/exec-state-marking.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 22 Jan 2008 00:52:38 +0000 (00:52 +0000)]
Not reviewed. Try to fix Qt build, after the rmdir() fixes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 22 Jan 2008 00:49:41 +0000 (00:49 +0000)]
Not reviewed. Another Wx build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 22 Jan 2008 00:30:41 +0000 (00:30 +0000)]
- try to fix Qt build
* platform/qt/FileSystemQt.cpp:
(WebCore::deleteEmptyDirectory): QDir::root().rmdir() instead of QDir::rmdir().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 22 Jan 2008 00:05:28 +0000 (00:05 +0000)]
Not reviewed. Yet another win/gtk build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 21 Jan 2008 23:43:32 +0000 (23:43 +0000)]
Not reviewed. Another build fix for Gtk/Linux & Wx/Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 21 Jan 2008 23:26:06 +0000 (23:26 +0000)]
Not reviewed. Build fix for Qt/Gtk & Wx.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 21 Jan 2008 23:16:59 +0000 (23:16 +0000)]
Not reviewed. Build fix for ports that don't build SVG: wx.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 21 Jan 2008 23:12:25 +0000 (23:12 +0000)]
Not reviewed. (First) Build fix for Qt/Gtk.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 21 Jan 2008 23:06:23 +0000 (23:06 +0000)]
2008-01-21 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16955
Get errors when cross-compile webkit-gtk
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 21 Jan 2008 22:56:53 +0000 (22:56 +0000)]
Reviewed by Eric. Older parts reviewed by Dan.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16880 (SVGCSSFontFace should die, instead integrate within the FontCache.)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16784 (In-document fonts work only as the first child to font-face-src)
Proper integration of SVG Fonts within the existing custom font concept, removing the need for a custom SVGCSSFontFace.
Integrate within the CSSFontFaceSource logic for caching support, as well as the framework for external SVG Fonts.
Proper handling of missing glyphs, using <missing-glyph> element. If that is not specified in a font, fallback to non-SVG font rendering.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 21 Jan 2008 22:43:52 +0000 (22:43 +0000)]
2008-01-21 Alp Toker <alp@atoker.com>
GTK+ build fix for breakage introduced in r29698.
* WebCoreSupport/ChromeClientGtk.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 21 Jan 2008 22:23:28 +0000 (22:23 +0000)]
WebCore:
Reviewed by John Sullivan.
- fix <rdar://problem/
5644324> Delegate-less WebKit clients should have no databases
- remove the default database quota setting
- simplify the quota-related client calls by merging the one for a new database with
the one for an existing database, adding a feature where you can get details about
a database being created using the same functions that work on the other databases,
and removing the parameters and return values, instead having clients use a function
to set the quota
- fix unsafe multi-thread access to the database tracker's quota map
- fix bug in deleteAllDatabases where it would iterate a HashMap while modifying it
The tracker database is now only created when we set the quota for a database origin.
Thus asking for info about databases won't cause anything to be written to disk.
* WebCore.base.exp: Updated.
* bindings/js/GCController.cpp: Added an #if to get rid of an unused function warning.
* page/Chrome.cpp: Removed database-related functions. There's no problem having the
code deal directly with the client.
* page/Chrome.h: Ditto. Also made Chrome inherit from Noncopyable.
* page/ChromeClient.h: Replaced the two quota-related functions with a single one.
The details about the state of databases in the origin are now available by asking
for database details. There's also no need to pass the security origin, since
it's easy to get that from the frame's document.
* page/Settings.cpp: Removed the default quota setting.
* page/Settings.h: Ditto.
* platform/FileSystem.h: Added deleteEmptyDirectory.
* platform/gtk/FileSystemGtk.cpp:
(WebCore::deleteEmptyDirectory): Added.
* platform/posix/FileSystemPOSIX.cpp:
(WebCore::deleteEmptyDirectory): Added.
* platform/qt/FileSystemQt.cpp:
(WebCore::deleteEmptyDirectory): Added.
* platform/win/FileSystemWin.cpp:
(WebCore::deleteEmptyDirectory): Added.
* platform/wx/FileSystemWx.cpp:
(WebCore::deleteEmptyDirectory): Added placeholder.
* storage/DatabaseDetails.h: Removed the isValid() function since its name is
confusing -- we removed our other isValid() functions. For the few callers that
need this, it's fine to just check name().isEmpty(). Made the member functions
all const.
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::DatabaseTracker): Removed m_defaultQuota initialization.
Added m_proposedDatabase and m_thread.
(WebCore::DatabaseTracker::setDatabaseDirectoryPath): Got rid of code that would
open the tracker database here. This might slightly speed up launch time, since
we won't do the I/O until we have to, and before we were actually creating an SQL
database in this code that's run when we go to the first webpage.
(WebCore::DatabaseTracker::trackerDatabasePath): Added.
(WebCore::DatabaseTracker::openTrackerDatabase): Added a boolean parameter telling
this function whether to create the database. Made this function safe to call if
the database is already open. Also made the function fail quietly if the path has
not been set yet.
(WebCore::DatabaseTracker::canEstablishDatabase): Got rid of the call to the
establishEntryForOrigin function. The origin is now put in the tracker database
when the quota is set to a non-zero value. When judging if there's enough space
for the new database, require at least one byte even if estimatedSize is 0, and
check for overflow. Also added code here to populate the origins map, which
guarantees it will be ready when the database uses it on another thread later.
Also changed this to call the new ChromeClient function.
(WebCore::DatabaseTracker::hasEntryForDatabase): Added code to open the
tracker database, since that's no longer done by setDatabaseDirectoryPath.
(WebCore::DatabaseTracker::originPath): Added.
(WebCore::DatabaseTracker::fullPathForDatabase): Added code so that this will
return a null string for the proposed database if called from within the
ChromeClient function. Also switched from empty string to null string for the
error cases.
(WebCore::DatabaseTracker::populateOrigins): Added code to open the tracker
database.
(WebCore::DatabaseTracker::databaseNamesForOrigin): Ditto.
(WebCore::DatabaseTracker::detailsForNameAndOrigin): Ditto. Also added code that
will return the details of the proposed database if called from within the
ChromeClient function. This is how the client can learn of the display name and
the estimated size of the new database.
(WebCore::DatabaseTracker::setDatabaseDetails): Added code to open the tracker
database.
(WebCore::DatabaseTracker::quotaForOrigin): Made this code OK to call on a non-main
thread by using m_quotaMapGuard to guard access to the map. Other code runs on the
main thread only, and only functions that write to the map use the lock.
(WebCore::DatabaseTracker::setQuota): Changed this function so it can insert the
initial quota as well as updating an existing quota. Added locking since this
function modifies the quota map. Added code to open the tracker database. Added
an early exit if the quota is already correct, which is guarantees that if you
set a quota to 0 it won't trigger creation of a tracker database.
(WebCore::DatabaseTracker::addDatabase): Added code to open the tracker database.
(WebCore::DatabaseTracker::deleteAllDatabases): Made a copy of the quota map before
iterating it to find all the origins. This fixes a problem with the old code where
it would modify the map while iterating it, which gives assertions in debug builds
and unpredictable results.
(WebCore::DatabaseTracker::deleteOrigin): Replaced deleteDatabasesWithOrigin with
this function. Added code to open the tracker database if needed. Added code to
delete the origin from the tracker database, and to close the tracker database
and delete files and directories as needed if we are deleting the final origin.
(WebCore::DatabaseTracker::deleteDatabase): Added code to open the tracker database
if needed.
* storage/DatabaseTracker.h: Renamed databasePath to databaseDirectoryPath for
clarity, including the data member, and the getter and setter functions.
Replaced deleteDatabasesWithOrigin with deleteOrigin. Removed the functions
dealing with default origin quota. There is no default any more; origins start
with no quota and the client must set a quota. Added trackerDatabasePath and
originPath helper functions. Added a boolean parameter to openTrackerDatabase
to tell it whether to create the database or not. Removed the
establishEntryForOrigin function. Renamed m_originQuotaMap to just m_quotaMap,
and added m_quotaMapGuard. Added a QuotaMap typedef. Added m_proposedDatabase,
which holds the origin and details for the current proposed database during
the client callback function that must decide whether to grant quota. Added a
m_thread data member for debugging use to assert if functions that can only
be called on a single thread are misused.
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback): Changed to call the
new exceededDatabaseQuota function instead of the old one.
* svg/graphics/SVGImageEmptyClients.h: Updated for the change to ChromeClient.
WebKit/gtk:
Reviewed by John Sullivan.
- updated for changes to database functions
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::exceededDatabaseQuota):
* WebCoreSupport/ChromeClientGtk.h:
* WebView/webkitprivate.cpp:
(webkit_init):
WebKit/mac:
Reviewed by John Sullivan.
- fix <rdar://problem/
5644324> Delegate-less WebKit clients should have no databases
- add a missing export of WebDatabaseExpectedSizeKey
- implement deleteOrigin: and remove deleteDatabasesWithOrigin:
* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null
name instead of calling isValid().
(-[WebDatabaseManager deleteOrigin:]): Implemented.
(WebKitInitializeDatabasesIfNecessary): Updated for name change.
* Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
* WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions
we had before with a single one.
* WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
* WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
* WebView/WebPreferences.m:
(+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
* WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and
setDefaultDatabaseQuota:.
* WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate
methods we had before with a single one.
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]): Removed the code to set the
default database origin quota in WebCore::Settings based on WebPreferences.
* WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual
types of parameters that the database UI delegate methods had before.
WebKit/qt:
Reviewed by John Sullivan.
- updated for changes to ChromeClient database functions
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::exceededDatabaseQuota):
* WebCoreSupport/ChromeClientQt.h:
WebKit/win:
Reviewed by John Sullivan.
- fix <rdar://problem/
5644324> Delegate-less WebKit clients should have no databases
- fix incorrect value for WebDatabaseDisplayNameKey in header
* Interfaces/IWebDatabaseManager.idl: Renamed detailsForDatabaseWithOrigin to
detailsForDatabase. Replaced deleteDatabasesWithOrigin with deleteOrigin.
Renamed deleteDatabaseWithOrigin to deleteDatabase. Fixed incorrect value for
WebDatabaseDisplayNameKey.
* Interfaces/IWebPreferencesPrivate.idl: Removed defaultDatabaseQuota and
setDefaultDatabaseQuota.
* Interfaces/IWebUIDelegatePrivate.idl: Replaced the two database quota functions
with a single one.
* WebChromeClient.cpp:
(WebChromeClient::exceededDatabaseQuota): Replaced the two database quota functions
with a single one.
* WebChromeClient.h: Ditto.
* WebDatabaseManager.cpp:
(WebDatabaseManager::detailsForDatabase): Changed to check for a name of null to
detect a nonexistent database rather than using isValid.
(WebDatabaseManager::deleteOrigin): Updated for name change (actually a semantic
change too, but both have the same name).
(WebDatabaseManager::deleteDatabase): Updated for name change.
(WebKitSetWebDatabasesPathIfNecessary): Ditto.
* WebDatabaseManager.h: Updated for name changes.
* WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Removed the default for
WebKitDefaultDatabaseQuotaKey.
* WebPreferences.h: Removed defaultDatabaseQuota and setDefaultDatabaseQuota.
* WebView.cpp:
(WebView::notifyPreferencesChanged): Removed the code to set the
default database origin quota in WebCore::Settings based on IWebPreferencesPrivate.
WebKit/wx:
Reviewed by John Sullivan.
- updated for changes to ChromeClient database functions
* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::exceededDatabaseQuota):
* WebKitSupport/ChromeClientWx.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 21 Jan 2008 21:52:09 +0000 (21:52 +0000)]
Rubber stamped by Oliver.
Add missing layout test results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 21 Jan 2008 21:19:30 +0000 (21:19 +0000)]
WebCore:
Fix for http://bugs.webkit.org/show_bug.cgi?id=16935
Fix a bug in layers where the positioned ancestor was being computed incorrectly (the root should not
automatically be included).
Reviewed by olliej
Added fast/layers/positioned-inside-root-with-margins.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::stackingContext):
(WebCore::RenderLayer::enclosingPositionedAncestor):
LayoutTests:
http://bugs.webkit.org/show_bug.cgi?id=16935
Reviewed by olliej
* fast/layers/positioned-inside-root-with-margins.html: Added.
* platform/mac/fast/layers/positioned-inside-root-with-margins-expected.checksum: Added.
* platform/mac/fast/layers/positioned-inside-root-with-margins-expected.png: Added.
* platform/mac/fast/layers/positioned-inside-root-with-margins-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Mon, 21 Jan 2008 19:00:08 +0000 (19:00 +0000)]
Adding media/{audio,video}-controls-rendering.html back to the skipped list, since they're still failing on some machines.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 21 Jan 2008 16:59:24 +0000 (16:59 +0000)]
Reviewed by Mitz and Adam.
* Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
sorting speed by doing all sort criteria in a single pass instead of three sorts.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 21 Jan 2008 11:06:20 +0000 (11:06 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>
Change QWebHistoryInterface::addHistoryEntry() from const to non-const
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 21 Jan 2008 11:06:06 +0000 (11:06 +0000)]
Adam Treat <treat@kde.org>
* Don't leak the d-pointer in QWebSettings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 21 Jan 2008 10:47:15 +0000 (10:47 +0000)]
Simon Hausmann <hausmann@webkit.org>
Update the WebKit version number from WebKit/win/WebKit.vcproj/VERSION.
This has the fortunate side-effect that gmail sends us sensible HTML/JS again :)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 21 Jan 2008 10:41:43 +0000 (10:41 +0000)]
Fix KURL to QUrl conversion.
Stick to the encoded version of the URL and in addition to KURL we encode the
characters mentioned in section 2.4.3 of RFC 2396 as QUrl requires these, too.
This fixes fast/css/import-rule-regression-11590.html,
fast/css/import-style-update.html, svg/hixie/processing-model/003.xml and
svg/hixie/processing-model/004.xml.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 21 Jan 2008 10:40:53 +0000 (10:40 +0000)]
Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
* Fix GraphicsContext::drawFocusRing to also draw single focus rects.
* Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
and make the return value depend on whether we successfully determined a focusable
node or not.
* Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
if we could not handle the focus chain ourselves.
* Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
* Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
used to control the situation of stepping out of the focus chain inside the page.
* Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
The layout tests expect this to be disabled but for the user it seems sensible to have it
on by default, hence the default in qwebsettings.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 21 Jan 2008 10:40:16 +0000 (10:40 +0000)]
Fix access key support and fast/forms/legend-access-key.html
SVN revision 26664 changed the default access key for the non-mac build to Alt
while this test relies on Ctrl.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 21 Jan 2008 10:39:57 +0000 (10:39 +0000)]
Fix error reporting when parsing X(HT)ML fragments.
We use the regular XMLTokenizer write()/.../end() sequence to parse those
fragments, but we should not report any parsing errors inline inside the
content. Instead we should just return the error and the DOM layer will take
care of throwing an exception.
This fixes fast/innerHTML/innerHTML-changing-document-properties.xhtml
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 21 Jan 2008 09:10:10 +0000 (09:10 +0000)]
Holger Freyther <holger.freyther@trolltech.com>
Fix some issues with redirections.
* Ensure that we deliver the response to the ResourceHandleClient only once by
setting m_responseSent back to false only before calling start() for the
redirection
* Added 307 as another HTTP status code that causes a redirection after POST to
become get, just like in MainResourceLoader::isPostOrRedirectAfterPost
* Also set the HTTP method on the ResourceRequest to GET before passing it to
willSendRequest.
* willSendRequest's newRequest argument is actually an in/out argument and could be
modified in theory, so set m_request accordingly after the call.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 21 Jan 2008 09:09:44 +0000 (09:09 +0000)]
Holger Freyther <holger.freyther@trolltech.com>
Fixed WebCore::cookies() to return all cookies, not only the first one.
Fixes login into mail.yahoo.com.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 21 Jan 2008 09:01:09 +0000 (09:01 +0000)]
Try to make the test less timing dependent to fix occasional test bot failures.
* media/video-seek-past-end-paused-expected.txt:
* media/video-seek-past-end-paused.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 21 Jan 2008 07:07:20 +0000 (07:07 +0000)]
2008-01-20 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Attach the widget's style to its window and set the background to the
base background to avoid black flicker when repainting. This is
similar to what GtkTextView does.
* WebView/webkitwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 21 Jan 2008 05:34:54 +0000 (05:34 +0000)]
Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer interested in supporting Safari 2 with TOT WebKit.
Reviewed by Dan Bernstein.
* WebKit.xcodeproj/project.pbxproj: Don't define REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as it is no longer used.
* mac/WebView/WebView.mm:
(+[WebView initialize]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 21 Jan 2008 04:30:09 +0000 (04:30 +0000)]
Fix bugs.webkit.org/show_bug.cgi?id=16816 , rdar://problem/
5682985
Reviewed by Mitz
Correctly trigger willPerformDragDestinationAction when a drop causes a
load to occur. The logic that originally did this was lost during the
great drag migration of '07.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 21 Jan 2008 04:04:41 +0000 (04:04 +0000)]
- update Tiger-specific results for r29667
* platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 21 Jan 2008 02:01:26 +0000 (02:01 +0000)]
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=16951
Assertion failure in FrameView::scheduleRelayout (!m_frame->document() || !m_frame->document()->inPageCache()) when going back from a page with a focused popup
* dom/Document.cpp:
(WebCore::Document::setFocusedNode): Bail out if the document is in the
page cache. Documents in the back/forward cache are "frozen" and should
not change state.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 20 Jan 2008 23:18:32 +0000 (23:18 +0000)]
WebCore:
Reviewed by Sam Weinig.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16775
We now use frame()->loader()->url() for postMessage, preventing a
malicious sender from overwriting the uri property (using a <base> tag,
for example). Also, use frame->loader()->url().host() instead of
instead of document()->SecurityOrigin()->domain() to reflect a recent
clarification in the HTML5 spec.
Tests: http/tests/security/postMessage/domain-affected-by-document-domain.html
http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag.html
http/tests/security/postMessage/javascript-page-still-sends-domain.html
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::postMessage):
LayoutTests:
Reviewed by Sam Weinig.
Tests for http://bugs.webkit.org/show_bug.cgi?id=16775
* http/tests/security/postMessage: Added.
* http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag-expected.txt: Added.
* http/tests/security/postMessage/domain-and-uri-unaffected-by-base-tag.html: Added.
* http/tests/security/postMessage/domain-unaffected-by-document-domain-expected.txt: Added.
* http/tests/security/postMessage/domain-unaffected-by-document-domain.html: Added.
* http/tests/security/postMessage/javascript-page-still-sends-domain-expected.txt: Added.
* http/tests/security/postMessage/javascript-page-still-sends-domain.html: Added.
* http/tests/security/postMessage/resources: Added.
* http/tests/security/postMessage/resources/javascript-post-message-sender.html: Added.
* http/tests/security/postMessage/resources/post-message-listener.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sun, 20 Jan 2008 21:22:06 +0000 (21:22 +0000)]
WebCore:
Reviewed by Adele.
Fix <rdar://problem/
5695451>
Middle part of the media timeline missing on Windows if load failed
Add some null checking to avoid getting garbage results from the functions.
* platform/graphics/MediaPlayer.cpp:
* platform/graphics/win/QTMovieWin.cpp:
(QTMovieWin::duration):
(QTMovieWin::currentTime):
(QTMovieWin::setCurrentTime):
(QTMovieWin::maxTimeLoaded):
LayoutTests:
Reviewed by Adele.
Update test so it checks the state of time related properties after the failure.
* media/video-error-does-not-exist-expected.txt:
* media/video-error-does-not-exist.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 20 Jan 2008 04:53:25 +0000 (04:53 +0000)]
Fix 'Reviewed by' typo in ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 20 Jan 2008 04:49:11 +0000 (04:49 +0000)]
2008-01-19 Alp Toker <alp@atoker.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16944
Use of GST_PLUGIN_DEFINE_STATIC results in a module-level constructor
http://bugzilla.gnome.org/show_bug.cgi?id=510547
Epiphany/Webkit fails to start due to initializing threads twice
Don't call GST_PLUGIN_DEFINE_STATIC() as it performs g_thread_init()
in the global initializer, breaking subsequent calls to
g_thread_init() in applications.
* platform/graphics/gtk/VideoSinkGStreamer.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 19 Jan 2008 18:51:36 +0000 (18:51 +0000)]
Allow the --http flag to run-webkit-tests to override
the default behaviour of disabling HTTP tests for Qt,
Gtk and Wx.
Reviewed by Alp Toker.
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 19 Jan 2008 18:34:01 +0000 (18:34 +0000)]
2008-01-19 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Remove any fragment part from the URL to be requested just before
passing it to curl, otherwise curl sends it as part of the HTTP/local
file request, causing page loads to fail.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::startJob):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 19 Jan 2008 18:27:17 +0000 (18:27 +0000)]
Set svn:eol-style=native on .idl and .c files that were missed in r29663.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 19 Jan 2008 18:10:55 +0000 (18:10 +0000)]
2008-01-19 Mark Rowe <mrowe@apple.com>
Fix inconsistent line endings and set svn:eol-style=native
on IDL files that did not have it set.
* Interfaces/IGEN_DOMObject.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 19 Jan 2008 15:46:23 +0000 (15:46 +0000)]
2008-01-19 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
Add svg foreign object and svg experimental to the GTK+/autotools
build system.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 19 Jan 2008 13:58:44 +0000 (13:58 +0000)]
2008-01-19 Christian Dywan <christian@imendio.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16882
[GTK] ChromeClientGtk is incompete
Implement these functions.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::windowRect):
(WebKit::ChromeClient::pageRect):
(WebKit::ChromeClient::scaleFactor):
(WebKit::ChromeClient::focus):
(WebKit::ChromeClient::unfocus):
(WebKit::ChromeClient::canTakeFocus):
(WebKit::ChromeClient::takeFocus):
(WebKit::ChromeClient::canRunBeforeUnloadConfirmPanel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sat, 19 Jan 2008 10:43:32 +0000 (10:43 +0000)]
<rdar://problem/
5695344> check-for-global-initializers script never checks any object files
Reviewed by Darin.
We now touch a check-for-global-initializers.timestamp file in
the TARGET_TEMP_DIR directory to determine when new object files
have been compiled and thus need to be checked. If the timestamp
file doesn't exist, all object files will be checked.
Previously the modification time of the "executable" (the
framework binary, e.g., WebKit.framework/WebKit) was used, but
since this was the last file modified at the end of the compile
phase, no object files would ever get checked!
Also added JSCustomSQLTransactionCallback.o to the list of files
since it has static initializers in Debug builds of WebCore.
* Scripts/check-for-global-initializers:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 19 Jan 2008 10:12:48 +0000 (10:12 +0000)]
WebCore:
Reviewed by Maciej Stachowiak.
- fix <rdar://problem/
5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
Test: editing/selection/inconsistent-in-removeChildNode.html
* editing/SelectionController.cpp:
(WebCore::SelectionController::nodeWillBeRemoved): If the selection
base or extent are not visible any more, adjust the selection.
LayoutTests:
Reviewed by Maciej Stachowiak.
- test and updated results for <rdar://problem/
5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
* editing/selection/inconsistent-in-removeChildNode.html: Added.
* platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
* platform/mac-leopard/editing/selection: Added.
* platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.checksum: Added.
* platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.png: Added.
* platform/mac/editing/deleting/collapse-whitespace-
3587601-fix-expected.txt:
* platform/mac/editing/deleting/delete-
3608462-fix-expected.txt:
* platform/mac/editing/deleting/delete-
4083333-fix-expected.txt:
* platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
* platform/mac/editing/deleting/delete-line-011-expected.txt:
* platform/mac/editing/execCommand/find-after-replace-expected.txt:
* platform/mac/editing/execCommand/paste-1-expected.txt:
* platform/mac/editing/execCommand/paste-2-expected.txt:
* platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
* platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt: Added.
* platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
* platform/mac/editing/selection/replace-selection-1-expected.txt:
* platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
* platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
* platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
* platform/mac/editing/style/remove-underline-expected.txt:
* platform/mac/editing/style/remove-underline-in-bold-expected.txt:
* platform/mac/editing/style/unbold-in-bold-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 19 Jan 2008 09:43:52 +0000 (09:43 +0000)]
Build fix for --svg-foreign-object path
Reviewed by Eric Seidel
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 19 Jan 2008 07:49:53 +0000 (07:49 +0000)]
2008-01-18 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16910
[GTK] REGRESSION: keyboard cursor doesn't blink
http://bugs.webkit.org/show_bug.cgi?id=16863
[GTK] REGRESSION: tab focusing doesn't work
* WebView/webkitwebview.cpp:
(webkit_web_view_focus_in_event): Added. Set the active frame.
(webkit_web_view_class_init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Sat, 19 Jan 2008 06:01:28 +0000 (06:01 +0000)]
2008-01-18 Stephanie <slewis@apple.com>
Reviewed by Oliver.
Workaround for rdar:
5695848. Set mime_type for local files based on file extension.
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::doUpdateResourceResponse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 19 Jan 2008 05:49:02 +0000 (05:49 +0000)]
set eol-style to native on tons of files to head off future mixed-line-ending problems
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Sat, 19 Jan 2008 01:44:02 +0000 (01:44 +0000)]
Reviewed by Oliver.
Fix for <rdar://
5683527> media/{audio,video|-controls-rendering.html failing
Remove platform specific results from media directory, since they should match the mac. Also, remove these tests from the skipped list.
* platform/win/Skipped:
* platform/win/media: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Sat, 19 Jan 2008 01:30:01 +0000 (01:30 +0000)]
Updating these results again. I accidently checked in the other results with some local changes.
* platform/mac/media/audio-controls-rendering-expected.checksum:
* platform/mac/media/audio-controls-rendering-expected.png:
* platform/mac/media/video-controls-rendering-expected.checksum:
* platform/mac/media/video-controls-rendering-expected.png:
* platform/mac/media/video-display-toggle-expected.checksum:
* platform/mac/media/video-display-toggle-expected.png:
* platform/mac/media/video-seek-past-end-playing-expected.checksum:
* platform/mac/media/video-seek-past-end-playing-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Sat, 19 Jan 2008 01:11:07 +0000 (01:11 +0000)]
- Build fix.
* kjs/ustring.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Sat, 19 Jan 2008 00:58:19 +0000 (00:58 +0000)]
Rubber stamped by Darin.
These are updated test results after http://bugs.webkit.org/
show_bug.cgi?id=15765 ASSERTION FAILED: m_frame->page() in
FrameLoader::tokenizerProcessedData using the new GMail interface
was checked in. This is a TEMPORARY fix until http://
bugs.webkit.org/show_bug.cgi?id=16853 really addresses this
problem.
* http/tests/loading/gmail-assert-on-load-expected.txt:
* http/tests/loading/onload-vs-immediate-refresh-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Sat, 19 Jan 2008 00:55:02 +0000 (00:55 +0000)]
Rubber stamped by Geoff.
- <rdar://
5667267> editing/selection/
5131716-1.html is failing
The problem is when the fonts are not present, but they should be
available now. This may have failed for other reasons in the past
that are now fixed.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Sat, 19 Jan 2008 00:24:41 +0000 (00:24 +0000)]
<rdar://problem/
5682340> REGRESSION (r28188): Context menu appears at wrong place when clicking in iframe whose parent is scrolled (16827)
Calling absolutePosition() in EventHandler::hitTestResultAtPoint() is extremely inefficient and passing in
true as fixed before was wrong. Use HitTestResult::localPoint() instead, and take into account border and padding widths.
Reviewed by Hyatt and Darin.
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::operator=):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Sat, 19 Jan 2008 00:09:40 +0000 (00:09 +0000)]
Reviewed by Antti.
Adding pixel results for media tests.
* platform/mac/media/audio-constructor-expected.checksum: Added.
* platform/mac/media/audio-constructor-expected.png: Added.
* platform/mac/media/audio-constructor-src-expected.checksum: Added.
* platform/mac/media/audio-constructor-src-expected.png: Added.
* platform/mac/media/broken-video-expected.checksum: Added.
* platform/mac/media/broken-video-expected.png: Added.
* platform/mac/media/constructors-expected.checksum: Added.
* platform/mac/media/constructors-expected.png: Added.
* platform/mac/media/fallback-expected.checksum: Added.
* platform/mac/media/fallback-expected.png: Added.
* platform/mac/media/progress-event-expected.checksum: Added.
* platform/mac/media/progress-event-expected.png: Added.
* platform/mac/media/remove-from-document-expected.checksum: Added.
* platform/mac/media/remove-from-document-expected.png: Added.
* platform/mac/media/unsupported-rtsp-expected.checksum: Added.
* platform/mac/media/unsupported-rtsp-expected.png: Added.
* platform/mac/media/unsupported-tracks-expected.checksum: Added.
* platform/mac/media/unsupported-tracks-expected.png: Added.
* platform/mac/media/video-append-source-expected.checksum: Added.
* platform/mac/media/video-append-source-expected.png: Added.
* platform/mac/media/video-autoplay-expected.checksum: Added.
* platform/mac/media/video-autoplay-expected.png: Added.
* platform/mac/media/video-buffered-expected.checksum: Added.
* platform/mac/media/video-buffered-expected.png: Added.
* platform/mac/media/video-controls-expected.checksum: Added.
* platform/mac/media/video-controls-expected.png: Added.
* platform/mac/media/video-currentTime-expected.checksum: Added.
* platform/mac/media/video-currentTime-expected.png: Added.
* platform/mac/media/video-currentTime-set-expected.checksum: Added.
* platform/mac/media/video-currentTime-set-expected.png: Added.
* platform/mac/media/video-currentTime-set2-expected.checksum: Added.
* platform/mac/media/video-currentTime-set2-expected.png: Added.
* platform/mac/media/video-dom-autoplay-expected.checksum: Added.
* platform/mac/media/video-dom-autoplay-expected.png: Added.
* platform/mac/media/video-dom-end-expected.checksum: Added.
* platform/mac/media/video-dom-end-expected.png: Added.
* platform/mac/media/video-dom-loopcount-expected.checksum: Added.
* platform/mac/media/video-dom-loopcount-expected.png: Added.
* platform/mac/media/video-dom-loopend-expected.checksum: Added.
* platform/mac/media/video-dom-loopend-expected.png: Added.
* platform/mac/media/video-dom-loopstart-expected.checksum: Added.
* platform/mac/media/video-dom-loopstart-expected.png: Added.
* platform/mac/media/video-dom-src-expected.checksum: Added.
* platform/mac/media/video-dom-src-expected.png: Added.
* platform/mac/media/video-dom-start-expected.checksum: Added.
* platform/mac/media/video-dom-start-expected.png: Added.
* platform/mac/media/video-end-expected.checksum: Added.
* platform/mac/media/video-end-expected.png: Added.
* platform/mac/media/video-error-abort-expected.checksum: Added.
* platform/mac/media/video-error-abort-expected.png: Added.
* platform/mac/media/video-error-does-not-exist-expected.checksum: Added.
* platform/mac/media/video-error-does-not-exist-expected.png: Added.
* platform/mac/media/video-load-networkState-expected.checksum: Added.
* platform/mac/media/video-load-networkState-expected.png: Added.
* platform/mac/media/video-load-readyState-expected.checksum: Added.
* platform/mac/media/video-load-readyState-expected.png: Added.
* platform/mac/media/video-loopcount-expected.checksum: Added.
* platform/mac/media/video-loopcount-expected.png: Added.
* platform/mac/media/video-loopend-expected.checksum: Added.
* platform/mac/media/video-loopend-expected.png: Added.
* platform/mac/media/video-loopstart-expected.checksum: Added.
* platform/mac/media/video-loopstart-expected.png: Added.
* platform/mac/media/video-muted-expected.checksum: Added.
* platform/mac/media/video-muted-expected.png: Added.
* platform/mac/media/video-no-autoplay-expected.checksum: Added.
* platform/mac/media/video-no-autoplay-expected.png: Added.
* platform/mac/media/video-pause-empty-events-expected.checksum: Added.
* platform/mac/media/video-pause-empty-events-expected.png: Added.
* platform/mac/media/video-play-empty-events-expected.checksum: Added.
* platform/mac/media/video-play-empty-events-expected.png: Added.
* platform/mac/media/video-play-pause-events-expected.checksum: Added.
* platform/mac/media/video-play-pause-events-expected.png: Added.
* platform/mac/media/video-play-pause-exception-expected.checksum: Added.
* platform/mac/media/video-play-pause-exception-expected.png: Added.
* platform/mac/media/video-poster-expected.checksum: Added.
* platform/mac/media/video-poster-expected.png: Added.
* platform/mac/media/video-seek-past-end-paused-expected.checksum: Added.
* platform/mac/media/video-seek-past-end-paused-expected.png: Added.
* platform/mac/media/video-seek-past-end-playing-expected.checksum: Added.
* platform/mac/media/video-seek-past-end-playing-expected.png: Added.
* platform/mac/media/video-seekable-expected.checksum: Added.
* platform/mac/media/video-seekable-expected.png: Added.
* platform/mac/media/video-seeking-expected.checksum: Added.
* platform/mac/media/video-seeking-expected.png: Added.
* platform/mac/media/video-size-expected.checksum: Added.
* platform/mac/media/video-size-expected.png: Added.
* platform/mac/media/video-source-expected.checksum: Added.
* platform/mac/media/video-source-expected.png: Added.
* platform/mac/media/video-source-media-expected.checksum: Added.
* platform/mac/media/video-source-media-expected.png: Added.
* platform/mac/media/video-source-type-expected.checksum: Added.
* platform/mac/media/video-source-type-expected.png: Added.
* platform/mac/media/video-src-change-expected.checksum: Added.
* platform/mac/media/video-src-change-expected.png: Added.
* platform/mac/media/video-src-expected.checksum: Added.
* platform/mac/media/video-src-expected.png: Added.
* platform/mac/media/video-src-remove-expected.checksum: Added.
* platform/mac/media/video-src-remove-expected.png: Added.
* platform/mac/media/video-src-set-expected.checksum: Added.
* platform/mac/media/video-src-set-expected.png: Added.
* platform/mac/media/video-src-source-expected.checksum: Added.
* platform/mac/media/video-src-source-expected.png: Added.
* platform/mac/media/video-start-expected.checksum: Added.
* platform/mac/media/video-start-expected.png: Added.
* platform/mac/media/video-volume-expected.checksum: Added.
* platform/mac/media/video-volume-expected.png: Added.
* platform/mac/media/video-width-height-expected.checksum: Added.
* platform/mac/media/video-width-height-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Sat, 19 Jan 2008 00:04:08 +0000 (00:04 +0000)]
WebCore:
Reviewed by Darin, landed by Beth.
- fixed http://bugs.webkit.org/show_bug.cgi?id=15765
The call to HTMLTokenizer::write might result in a call to ::end which will invoke
HTMLParser::finished() or Document::finishedParsing(). HTMLParser::finished() will eventually
call Document::finishedParsing. The Document will delete the calling HTMLTokenizer and from the deleted
tokenizer we will call into FrameLoader::tokenizerProcessedData.
-) FrameLoader::tokenizerProcessedData calls FrameLoader::checkCompleted which gets called from the Document::finishedParsing
(FrameLoader::finishedParsing).
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::timerFired):
LayoutTests:
Reviewed by Darin, landed by Beth.
-test for http://bugs.webkit.org/show_bug.cgi?id=15765
Gmail hitting an assert in FrameLoader::tokenizerProcessedData
* http/tests/loading/gmail-assert-on-load-expected.txt: Added.
* http/tests/loading/gmail-assert-on-load.html: Added.
* http/tests/loading/resources/gmail-assert-on-load-frame.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 19 Jan 2008 00:01:01 +0000 (00:01 +0000)]
Reviewed by Beth Dakin.
Fix for <rdar://problem/
5683524> http/tests/security/cross-frame-access-get.html is failing
- Guard against possible timing related failures using polling.
* http/tests/security/:
* http/tests/security/resources/cross-frame-iframe-for-get-test.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Sat, 19 Jan 2008 00:00:25 +0000 (00:00 +0000)]
- Build fix.
* kjs/ustring.cpp:
* kjs/ustring.h:
(KJS::UString::cost):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 18 Jan 2008 23:33:07 +0000 (23:33 +0000)]
Remove incorrect addition of ChangeLog as changed in the ChangeLog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 18 Jan 2008 23:20:30 +0000 (23:20 +0000)]
Update inline results after previous checkins. New results match Firefox more closely.
* platform/mac/fast/inline/001-expected.checksum:
* platform/mac/fast/inline/001-expected.png:
* platform/mac/fast/inline/002-expected.checksum:
* platform/mac/fast/inline/002-expected.png:
* platform/mac/fast/inline/br-text-decoration-expected.checksum:
* platform/mac/fast/inline/br-text-decoration-expected.png:
* platform/mac/fast/inline/continuation-outlines-expected.checksum:
* platform/mac/fast/inline/continuation-outlines-expected.png:
* platform/mac/fast/inline/continuation-outlines-with-layers-expected.checksum:
* platform/mac/fast/inline/continuation-outlines-with-layers-expected.png:
* platform/mac/fast/inline/dirtyLinesForInline-expected.checksum:
* platform/mac/fast/inline/dirtyLinesForInline-expected.png:
* platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum:
* platform/mac/fast/inline/drawStyledEmptyInlines-expected.png:
* platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
* platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum:
* platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
* platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum:
* platform/mac/fast/inline/emptyInlinesWithinLists-expected.png:
* platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt:
* platform/mac/fast/inline/inline-borders-with-bidi-override-expected.checksum:
* platform/mac/fast/inline/inline-borders-with-bidi-override-expected.png:
* platform/mac/fast/inline/outline-continuations-expected.checksum:
* platform/mac/fast/inline/outline-continuations-expected.png:
* platform/mac/fast/inline/positionedLifetime-expected.checksum:
* platform/mac/fast/inline/positionedLifetime-expected.png:
* platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum:
* platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 18 Jan 2008 23:10:51 +0000 (23:10 +0000)]
Don't apply the border/margin/padding check to root line boxes, since their renderers
are blocks.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesVertically):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 18 Jan 2008 22:59:29 +0000 (22:59 +0000)]
WebCore:
Not reviewed: rolling out a previous patch.
Fixed <rdar://problem/
5695439> Crash during GCController destructor on
quitting browser
Used svn merge to roll out r29603 because it introduced some crashes
on quit.
GC relies on static hash tables, so it's not safe to GC from a static
destructor, which might run after the static hash tables' destructors.
* bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectNow):
* bindings/js/GCController.h:
LayoutTests:
Fix for http://bugs.webkit.org/show_bug.cgi?id=15665
Reviewed by Beth
* fast/inline/inline-padding-disables-text-quirk.html: Added.
* platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.checksum: Added.
* platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.png: Added.
* platform/mac/fast/inline/inline-padding-disables-text-quirk-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 18 Jan 2008 22:50:13 +0000 (22:50 +0000)]
Not reviewed: rolling out a previous patch.
Fixed <rdar://problem/
5695439> Crash during GCController destructor on
quitting browser
Used svn merge to roll out r29603 because it introduced some crashes
on quit.
GC relies on static hash tables, so it's not safe to GC from a static
destructor, which might run after the static hash tables' destructors.
* bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectNow):
* bindings/js/GCController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 18 Jan 2008 21:56:31 +0000 (21:56 +0000)]
WebCore:
Fix for http://bugs.webkit.org/show_bug.cgi?id=14975
Computed size of padding is incorrect because we default padding to auto. This is a made-up value that
was only used to implement cellpadding on tables. We needed this made-up value in order to tell that
padding wasn't set so that we could then apply cellpadding.
This patch rewrites cellpadding to be like other browsers. Instead of being a setting on the table
renderer that applies to all cells (even ones that were not <td>s), cellpadding is now mapped into the
style of <td>s. With this change it effectively becomes a content model feature and not a rendering
feature.
For example, a <td> will pick up cellpadding even when it is not a cell and/or the enclosing <table> is
not a table. Anonymous cells and CSS-display-type cells will now never pick up cellpadding. This behavior
is all consistent with other browsers.
Reviewed by Antti
Added fast/css/padding-no-renderer.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
* css/CSSStyleSelector.h:
* dom/StyledElement.cpp:
* dom/StyledElement.h:
(WebCore::StyledElement::canHaveAdditionalAttributeStyleDecls):
(WebCore::StyledElement::additionalAttributeStyleDecls):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyleDecls):
* html/HTMLTableCellElement.h:
(WebCore::HTMLTableCellElement::canHaveAdditionalAttributeStyleDecls):
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyleDecls):
* html/HTMLTableColElement.h:
(WebCore::HTMLTableColElement::canHaveAdditionalAttributeStyleDecls):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::parseMappedAttribute):
(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedCellPaddingDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):
(WebCore::HTMLTableElement::attach):
* html/HTMLTableElement.h:
(WebCore::HTMLTableElement::canHaveAdditionalAttributeStyleDecls):
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyleDecls):
* html/HTMLTableSectionElement.h:
(WebCore::HTMLTableSectionElement::canHaveAdditionalAttributeStyleDecls):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paddingTop):
(WebCore::RenderObject::paddingBottom):
(WebCore::RenderObject::paddingLeft):
(WebCore::RenderObject::paddingRight):
* rendering/RenderStyle.cpp:
(WebCore::StyleSurroundData::StyleSurroundData):
* rendering/RenderStyle.h:
(WebCore::RenderStyle::initialPadding):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
* rendering/RenderTable.h:
LayoutTests:
Updated results for http://bugs.webkit.org/show_bug.cgi?id=14975
Reviewed by Antti
* fast/css/computed-style-without-renderer-expected.txt:
* fast/css/padding-no-renderer-expected.txt: Added.
* fast/css/padding-no-renderer.html: Added.
* platform/mac/fast/css/acid2-expected.checksum:
* platform/mac/fast/css/acid2-expected.png:
* platform/mac/fast/css/acid2-expected.txt:
* platform/mac/fast/css/acid2-pixel-expected.checksum:
* platform/mac/fast/css/acid2-pixel-expected.png:
* platform/mac/fast/css/acid2-pixel-expected.txt:
* platform/mac/fast/frames/viewsource-attribute-expected.checksum:
* platform/mac/fast/frames/viewsource-attribute-expected.png:
* platform/mac/fast/frames/viewsource-attribute-expected.txt:
* platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.checksum:
* platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.png:
* platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
* platform/mac/fast/table/add-before-anonymous-child-expected.checksum:
* platform/mac/fast/table/add-before-anonymous-child-expected.png:
* platform/mac/fast/table/add-before-anonymous-child-expected.txt:
* platform/mac/fast/table/cell-absolute-child-expected.checksum:
* platform/mac/fast/table/cell-absolute-child-expected.png:
* platform/mac/fast/table/cell-absolute-child-expected.txt:
* platform/mac/fast/table/frame-and-rules-expected.checksum:
* platform/mac/fast/table/frame-and-rules-expected.png:
* platform/mac/fast/table/frame-and-rules-expected.txt:
* platform/mac/http/tests/misc/acid2-expected.checksum:
* platform/mac/http/tests/misc/acid2-expected.png:
* platform/mac/http/tests/misc/acid2-expected.txt:
* platform/mac/http/tests/misc/acid2-pixel-expected.checksum:
* platform/mac/http/tests/misc/acid2-pixel-expected.png:
* platform/mac/http/tests/misc/acid2-pixel-expected.txt:
* platform/mac/tables/mozilla/bugs/bug30985-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug30985-expected.png:
* platform/mac/tables/mozilla/bugs/bug30985-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 18 Jan 2008 21:52:57 +0000 (21:52 +0000)]
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/
5615307> Repro crash in WebKit!WebCore::RenderContainer::destroyLeftoverChildren
Test: fast/table/insert-row-before-form.html
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild): Changed to ensure that the
object a new cell is inserted before is a child of the row, and
added an assertion that that object is either a cell or a form.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild): Changed to ensure that the
object a new row is inserted before is a child of the table section, and
added an assertion that that object is either a table row or a form.
LayoutTests:
Reviewed by Dave Hyatt.
- tests for <rdar://problem/
5615307> Repro crash in WebKit!WebCore::RenderContainer::destroyLeftoverChildren
* fast/table/insert-cell-before-form.html: Added.
* fast/table/insert-row-before-form.html: Added.
* platform/mac-leopard/fast/table: Added.
* platform/mac-leopard/fast/table/insert-cell-before-form-expected.checksum: Added.
* platform/mac-leopard/fast/table/insert-cell-before-form-expected.png: Added.
* platform/mac-leopard/fast/table/insert-row-before-form-expected.checksum: Added.
* platform/mac-leopard/fast/table/insert-row-before-form-expected.png: Added.
* platform/mac/fast/table/insert-cell-before-form-expected.txt: Added.
* platform/mac/fast/table/insert-row-before-form-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 18 Jan 2008 21:50:14 +0000 (21:50 +0000)]
Fixed date.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 18 Jan 2008 21:35:50 +0000 (21:35 +0000)]
Checked in new results for another test affected by disabling SVG
foreign object.
* platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Removed.
* platform/mac/svg/custom/stroke-width-click-expected.checksum: Removed.
* platform/mac/svg/custom/stroke-width-click-expected.png: Removed.
* svg/custom/stroke-width-click-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 18 Jan 2008 21:33:45 +0000 (21:33 +0000)]
Reviewed by Brady Eidson.
Fixed <rdar://problem/
5622424> World Leak dialog when closing a page
that has a Database
The problem was that each transaction and SQL statement would hold on
to its callback indefinitely. By design, callbacks often establish
reference cycles to temporarily protect their execution environments.
To break the cycle, we need to explicitly release each callback as soon
as it is no longer needed.
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::performCallback): Release our callback objects
after performing our callback.
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit): Release our callback
objects after the transaction has terminated.
(WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 18 Jan 2008 21:20:26 +0000 (21:20 +0000)]
Fix typo in comment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Fri, 18 Jan 2008 21:05:16 +0000 (21:05 +0000)]
JavaScriptCore:
Reviewed by Geoff.
- Correctly report cost of appended strings to trigger GC.
* kjs/ustring.cpp:
(KJS::):
(KJS::UString::Rep::create):
(KJS::UString::UString): Don't create unnecssary objects.
(KJS::UString::cost): Report cost if necessary but also keep track of
reported cost.
* kjs/ustring.h:
LayoutTests:
Reviewed by Geoff.
- Correctly report cost of appended strings to trigger GC.
* fast/js/garbage-collect-after-string-appends-expected.txt: Added.
* fast/js/garbage-collect-after-string-appends.html: Added.
* fast/js/resources/garbage-collect-after-string-appends.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Fri, 18 Jan 2008 20:58:08 +0000 (20:58 +0000)]
Reviewed by Antti.
Fix for <rdar://problem/
5679490> media controls fade in and out too jerkily and too slowly
* rendering/RenderMedia.cpp: Shorten the duration for the fade in/out animation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Jan 2008 20:54:03 +0000 (20:54 +0000)]
Build fix
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 18 Jan 2008 20:16:43 +0000 (20:16 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 18 Jan 2008 20:06:33 +0000 (20:06 +0000)]
WebCore:
Reviewed by Oliver.
Disables SVG foreign object for <rdar://problem/
5686989> turn off
SVG foreignobject because it does not repaint/dirty correctly
* DerivedSources.make:
* WebCore.SVG.ForeignObject.exp: Added.
* WebCore.SVG.exp:
* bindings/js/JSSVGElementWrapperFactory.cpp:
(WebCore::createJSSVGWrapper):
* rendering/RenderForeignObject.cpp:
* rendering/RenderForeignObject.h:
* svg/SVGForeignObjectElement.cpp:
* svg/SVGForeignObjectElement.h:
* svg/SVGForeignObjectElement.idl:
* svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::nearestViewportElement):
(WebCore::SVGLocatable::farthestViewportElement):
* svg/SVGUseElement.cpp:
(WebCore::isDisallowedElement):
* svg/svgtags.in:
WebKitTools:
Reviewed by Oliver.
Update build-webkit to account for foreign-object being disabled by
default.
* Scripts/build-webkit:
LayoutTests:
Reviewed by Oliver.
Changed test results from disabling SVG foreign object for <rdar://
problem/
5686989> turn off SVG foreignobject because it does not
repaint/dirty correctly
* platform/mac/svg/custom/baseval-animval-equality-expected.checksum: Replaced.
* platform/mac/svg/custom/baseval-animval-equality-expected.png: Replaced.
* platform/mac/svg/custom/baseval-animval-equality-expected.txt: Replaced.
* platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum: Replaced.
* platform/mac/svg/custom/dominant-baseline-hanging-expected.png: Replaced.
* platform/mac/svg/custom/dominant-baseline-hanging-expected.txt: Replaced.
* platform/mac/svg/custom/dynamic-svg-document-creation-expected.checksum: Replaced.
* platform/mac/svg/custom/dynamic-svg-document-creation-expected.png: Replaced.
* platform/mac/svg/custom/dynamic-svg-document-creation-expected.txt: Replaced.
* platform/mac/svg/custom/fill-SVGPaint-interface-expected.checksum: Replaced.
* platform/mac/svg/custom/fill-SVGPaint-interface-expected.png: Replaced.
* platform/mac/svg/custom/fill-SVGPaint-interface-expected.txt: Replaced.
* platform/mac/svg/custom/foreign-object-skew-expected.checksum: Replaced.
* platform/mac/svg/custom/foreign-object-skew-expected.png: Replaced.
* platform/mac/svg/custom/foreign-object-skew-expected.txt: Replaced.
* platform/mac/svg/custom/foreignObject-crash-on-hover-expected.checksum: Replaced.
* platform/mac/svg/custom/foreignObject-crash-on-hover-expected.png: Replaced.
* platform/mac/svg/custom/foreignObject-crash-on-hover-expected.txt: Replaced.
* platform/mac/svg/custom/getPresentationAttribute-expected.checksum: Replaced.
* platform/mac/svg/custom/getPresentationAttribute-expected.png: Replaced.
* platform/mac/svg/custom/getPresentationAttribute-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.png: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.png: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.png: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.png: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.png: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.png: Replaced.
* platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Replaced.
* platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Replaced.
* platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.checksum: Replaced.
* platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.png: Replaced.
* platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt: Replaced.
* platform/mac/svg/hixie/mixed/006-expected.checksum: Replaced.
* platform/mac/svg/hixie/mixed/006-expected.png: Replaced.
* platform/mac/svg/hixie/mixed/006-expected.txt: Replaced.
* platform/mac/svg/hixie/mixed/007-expected.checksum: Replaced.
* platform/mac/svg/hixie/mixed/007-expected.png: Replaced.
* platform/mac/svg/hixie/mixed/007-expected.txt: Replaced.
* platform/mac/svg/hixie/mixed/008-expected.checksum: Replaced.
* platform/mac/svg/hixie/mixed/008-expected.png: Replaced.
* platform/mac/svg/hixie/mixed/008-expected.txt: Replaced.
* platform/mac/svg/hixie/mixed/009-expected.checksum: Replaced.
* platform/mac/svg/hixie/mixed/009-expected.png: Replaced.
* platform/mac/svg/hixie/mixed/009-expected.txt: Replaced.
* platform/mac/svg/hixie/mixed/011-expected.checksum: Replaced.
* platform/mac/svg/hixie/mixed/011-expected.png: Replaced.
* platform/mac/svg/hixie/mixed/011-expected.txt: Replaced.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 18 Jan 2008 19:58:46 +0000 (19:58 +0000)]
2008-01-18 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Adam Roben.
Fix mixed line endings in FileSystemWin.cpp and set svn:eol-style to native
to try and keep them consistent in the future.
* platform/win/FileSystemWin.cpp:
(WebCore::fileSize):
(WebCore::fileExists):
(WebCore::deleteFile):
(WebCore::pathByAppendingComponent):
(WebCore::fileSystemRepresentation):
(WebCore::makeAllDirectories):
(WebCore::homeDirectoryPath):
(WebCore::bundleName):
(WebCore::storageDirectory):
(WebCore::cachedStorageDirectory):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 18 Jan 2008 19:51:25 +0000 (19:51 +0000)]
Reviewed by Adam.
Fix unreachable code warning in RenderVideo on Windows.
Make switch cases explicit.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::isWidthSpecified):
(WebCore::RenderImage::isHeightSpecified):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::isWidthSpecified):
(WebCore::RenderVideo::isHeightSpecified):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 18 Jan 2008 19:49:37 +0000 (19:49 +0000)]
WebCore:
Reviewed by Adam Roben.
<rdar://problem/
5693558> REGRESSION (r29581): no form field focus
rings and inactive text selection after loading a page
Bug 16910: [GTK] REGRESSION: keyboard cursor doesn't blink
Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
* page/FocusController.cpp:
(WebCore::FocusController::setActive): Use focusedOrMainFrame() instead of focusedFrame()
to call selectionController()->pageActivationChanged() for cases when the focusedFrame()
has not been set yet.
WebKit/mac:
Reviewed by Adam Roben.
<rdar://problem/
5693558> REGRESSION (r29581): no form field focus rings
and inactive text selection after loading a page
Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
The problem was other frames were changing the FocusController's active
status to false after the first responder frame set it to true. The last
frame to call _updateActiveState would win.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive()
if the first responder is the current WebHTMLView or the WebFrameView.
(-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 18 Jan 2008 18:47:59 +0000 (18:47 +0000)]
Reviewed by Brady.
Database origin tracking is broken.
* storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::populateOrigins):
Move reading from statement back into the loop (broken in r29386).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 18 Jan 2008 18:44:31 +0000 (18:44 +0000)]
Fix <rdar://
5693854> REGRESSION (r29581): fast/events/frame-click-focus.html failing
WebKit/mac:
Rename _updateActiveState to _updateFocusedAndActiveState
Also renamed any related methods/members similarly.
Reviewed by Adele.
* WebView/WebHTMLView.mm:
(-[WebHTMLViewPrivate dealloc]):
(-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]):
(-[WebHTMLView close]):
(_updateFocusedAndActiveStateTimerCallback):
(-[WebHTMLView viewWillMoveToWindow:]):
(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView windowDidBecomeKey:]):
(-[WebHTMLView windowDidResignKey:]):
(-[WebHTMLView becomeFirstResponder]):
(-[WebHTMLView resignFirstResponder]):
* WebView/WebHTMLViewInternal.h:
* WebView/WebHTMLViewPrivate.h:
WebKit/win:
Fix <rdar://
5693854> REGRESSION (r29581): fast/events/frame-click-focus.html failing
Restored the previous behavior of IWebViewPrivate::updateActiveState,
which DRT depends on, and renamed it to
IWebViewPrivate::updateFocusedAndActiveState to be clearer about its
side-effects.
Reviewed by Adele.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebViewWndProc): Removed some FIXMEs that we no longer want to fix
because the current design is better.
(WebView::updateActiveState): This is now just a method of WebView,
not any of its public interfaces.
(WebView::updateFocusedAndActiveState): Performs the tasks that the
old IWebViewPrivate::updateActiveState performed.
* WebView.h:
WebKitTools:
Updated for method renames
Reviewed by Adele.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMainFrameIsFirstResponder):
(LayoutTestController::setWindowIsKey):
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webViewFocus:]):
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::didCommitLoadForFrame):
LayoutTests:
Reviewed by Adele.
* platform/win/Skipped: Removed a fixed test, and a test that passes
for me locally.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 18 Jan 2008 14:21:56 +0000 (14:21 +0000)]
Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
between DRT and TestNetscapePlugin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 11:57:01 +0000 (11:57 +0000)]
Coding style fixes and added a comment about the order of includes in the PCH.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 11:30:30 +0000 (11:30 +0000)]
Marius Storm-Olsen <marius@trolltech.com>
Add use of precompiled header, when building inside Qt.
Compiling WebKit was taking forever; 17 minutes on my machine for _one_ build! Adding the PCH at least brings it down to 12 minutes for one build, for me.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:55:39 +0000 (10:55 +0000)]
Fix fast/forms/button-state-restore.html
Similar to the fix for fast/forms/form-post-urlencoded.html transform POST
requests to data urls into GET.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:55:23 +0000 (10:55 +0000)]
Fix LayoutTests/fast/cookies/local-file-can-set-cookies.html
In WebCore::cookies() don't return the full raw form but only the name=value
part. This fixes the getter part of the above test. The above test also
requires a parsing fix in Qt 4.4's QNetworkCookie to fully pass.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:55:06 +0000 (10:55 +0000)]
Fix fast/dom/Window/window-resize.html
In DRT connect the page's geometryChangeRequest signal to a slot that
sets the geometry of the view widget.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:54:52 +0000 (10:54 +0000)]
Fix return type conversions from Qt slots to JS values.
This also fixes fast/dom/open-and-close-by-DOM.html, which called
layoutTestController.windowCount().
When constructing the QVariant that holds the return type we cannot
use the QVarian(Type) constuctor as that will create a null variant.
We have to use the QVariant(Type, void *) constructor instead, just
like in QMetaObject::read() for example.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:54:36 +0000 (10:54 +0000)]
Fix svg/custom/path-getTotalLength.svg
Path::apply creates a PathElement and its points array on the stack,
to fill it in from the QPainterPath data and then use the platform
independent path applier functions to calculate properties such as
the length. For converting a QPainterPath::CurveToElement we need
three points in the path element. However we allocated only two
on the stack and as a result we got memory corruption and the
failing test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:54:20 +0000 (10:54 +0000)]
Fix LayoutTests/fast/dom/document-attribute-js-null.html
Don't crash when trying to get/set cookies without a frameloader.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:54:03 +0000 (10:54 +0000)]
Fix fast/dom/xmlhttprequest-get.xhtml
For local file requests remove the content length and the last-modified
headers in the response.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:53:45 +0000 (10:53 +0000)]
Fix fast/forms/form-post-urlencoded.html.
Post requests on files don't really make sense, but for
fast/forms/form-post-urlencoded.html we still need to retrieve the file,
which means we map it to a Get instead.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:37:50 +0000 (10:37 +0000)]
Simon Hausmann <hausmann@webkit.org>
Make QNetworkReplyHandler::abort() more robust against multiple invocations.
During DRT runs I see cancel() being called on the same handle multiple times. Guard
against this a bit better by setting m_reply to 0 after we called abort() on it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:37:33 +0000 (10:37 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* Ask the WebCore::IconDatabase only if our URL is not empty. Otherwise
we will see a crash in a HashSet.
* It is crashing there because the StringImpl of an empty String is 0.
* We avoid this crash by checking for isEmpty() in WebKit as there is no
use to ask the iconDatabase for an empty string. We will fallback to the
defaultIcon.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jan 2008 10:37:18 +0000 (10:37 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
* httpBody() can return 0 and other ports (cf/mac) check for this condition
* Looking at the cf/mac implementation we might need to call setHTTPBody somewhere
as well.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc