abarth@webkit.org [Mon, 5 Mar 2012 18:17:58 +0000 (18:17 +0000)]
Geolocation should use a ScriptExecutionContext as its context object
https://bugs.webkit.org/show_bug.cgi?id=80248
Reviewed by Kentaro Hara.
Source/WebCore:
This patch updates Geolocation to use some more modern WebCore
mechanisms. Previously, Geolocation used a Frame as a context object,
which required a bunch of manual integration with the PageCache as well
as custom signaling for Geolocation::reset(). After this patch,
Geolocation subclasses ActiveDOMObject, which does all this work
automatically.
* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::create):
(WebCore):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::document):
(WebCore::Geolocation::frame):
(WebCore::Geolocation::page):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::setIsAllowed):
* Modules/geolocation/Geolocation.h:
(WebCore):
(Geolocation):
* Modules/geolocation/NavigatorGeolocation.cpp:
(WebCore):
(WebCore::NavigatorGeolocation::geolocation):
* Modules/geolocation/NavigatorGeolocation.h:
(NavigatorGeolocation):
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(Document):
* history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
Source/WebKit/chromium:
Rather than indirecting through the Frame to get the SecurityOrigin, we
should get the SecurityOrigin directly from ScriptExecutionContext.
* src/WebGeolocationPermissionRequest.cpp:
(WebKit::WebGeolocationPermissionRequest::securityOrigin):
Source/WebKit/mac:
* WebView/WebFrame.mm:
(-[WebFrame _cacheabilityDictionary]):
- We no longer special-case Geolocation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 5 Mar 2012 18:15:32 +0000 (18:15 +0000)]
[soup] Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238
Reviewed by Philippe Normand.
.:
* configure.ac: Bumped the libsoup dependency to 2.37.90.
Source/WebCore:
Test: http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html
When running synchronous XMLHttpRequests, push a new inner thread default
context, so that other sources from timers and network activity do not run.
This will make synchronous requests truly synchronous with the rest of
WebCore.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCoreSynchronousLoader): Clean up the method definitions a bit by writing them inline.
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Push a new thread default
context to prevent other sources from running.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Pop the inner thread default context.
(WebCore::closeCallback): If the client is synchronous call didFinishLoading now.
(WebCore::readCallback): Only call didFinishLoading if the client isn't synchronous.
(WebCore::ResourceHandle::defaultSession): Activate use-thread-context so that the soup session
respects the inner thread context.
(ResourceHandleClient):
(WebCore::ResourceHandleClient::isSynchronousClient): Added this virtual method.
Tools:
* gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
in the jhbuild file.
LayoutTests:
* http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added.
* http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 5 Mar 2012 17:15:48 +0000 (17:15 +0000)]
Unreviewed, rolling out r109748.
http://trac.webkit.org/changeset/109748
https://bugs.webkit.org/show_bug.cgi?id=80296
Made some tests crash, will fix and recommit (Requested by
noamr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-05
Source/WebKit2:
* Target.pri:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::PageProxyNode):
(PageProxyNode):
(PageProxyNode::changedStates):
(PageProxyNode::render):
(PageProxyNode::~PageProxyNode):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::updateSize):
(QQuickWebPagePrivate::resetPaintNode):
(QQuickWebPagePrivate::~QQuickWebPagePrivate):
* UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
* UIProcess/DrawingAreaProxy.h:
(WebKit):
(WebKit::DrawingAreaProxy::layerTreeHostProxy):
(DrawingAreaProxy):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::syncAnimations):
(WebKit::LayerTreeHostProxy::updateViewport):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::flushLayerChanges):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::purgeGLResources):
* UIProcess/qt/QtWebPageSGNode.cpp: Removed.
* UIProcess/qt/QtWebPageSGNode.h: Removed.
Tools:
* MiniBrowser/qt/main.cpp:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joone.hur@collabora.co.uk [Mon, 5 Mar 2012 16:55:37 +0000 (16:55 +0000)]
[GTK] zlib link error with --enable-webkit2
https://bugs.webkit.org/show_bug.cgi?id=79877
Reviewed by Martin Robinson.
zlib should be linked properly.
* GNUmakefile.am: Link $(ZLIB_LIBS) with libwebkit2gtk instead of
linking it with WebKitWebProcess.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 5 Mar 2012 16:54:58 +0000 (16:54 +0000)]
[GTK] plugins/netscape-plugin-page-cache-works.html fails
https://bugs.webkit.org/show_bug.cgi?id=74409
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-05
Reviewed by Martin Robinson.
Source/WebKit/gtk:
Add a method to override page-cache-for-plugins preference.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setPageCacheSupportsPlugins):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
Add support for overriding the page-cache-for-plugins preference
through DumpRenderTreeSupport.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(booleanFromValue): A helper function to convert a string to boolean.
(LayoutTestController::overridePreference):
LayoutTests:
Unskip one new passing test and reclassify one failure.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 5 Mar 2012 16:38:57 +0000 (16:38 +0000)]
[Qt] Unreviewed gardening.
* platform/qt/Skipped: Skip a new flakey test, unskip a passing test.
* platform/qt/svg/custom/bug78807-expected.txt: Added. (https://bugs.webkit.org/show_bug.cgi?id=80156)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jpetsovits@rim.com [Mon, 5 Mar 2012 16:37:29 +0000 (16:37 +0000)]
Make accelerated compositing work again with direct rendering.
https://bugs.webkit.org/show_bug.cgi?id=80181
RIM PR: 139110
Reviewed by Antonio Gomes.
Internally reviewed by Arvid Nilsson.
The significant amount of refactoring and optimization work
that has gone into accelerated compositing missed out on
some of the code paths that are being used in direct rendering.
Animations were relying on blitVisibleContents() only (which
is a no-op in direct rendering mode). There were early returns
which are suitable to determine whether screen contents need
to be updated at all; however, when we're already forcing a
re-render then those checks would cause the composition surface
not to appear at all, or avoid drawing new animation frames.
We went through dispatchMessage(), potentially causing
mismatches between rendered (but not yet posted) back content
and layers composited on top of it. As we're rendering onto
the sole target surface (the window) directly and posting
from the same thread, we have to wait for compositing on the
UI thread to finish before posting the window.
In turn, this patch combines both drawSubLayers() and
blendCompositingSurface() calls into one method, reducing
the number of messages to the UI thread within
renderDirectToWindow() to one.
blendCompositingMessage() in renderDirectToScreen() was called
with contents coordinates rather than viewport coordinates.
That caused some of the composited content to be cut off when
the scroll position wasn't (0, 0).
We called copyPreviousContentsToBackSurfaceOfWindow() twice for
one frame, in both renderDirectToWindow() and invalidateWindow().
Only one of those (the latter one) is necessary.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
(BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
* Api/BackingStore.h:
(WebKit):
* Api/BackingStore_p.h:
(BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::isDirectRenderingAnimationMessageScheduled):
(BlackBerry::WebKit::BackingStorePrivate::setDirectRenderingAnimationMessageScheduled):
* Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::isAcceleratedCompositingActive):
(WebPagePrivate):
* WebKitSupport/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::drawLayers):
(BlackBerry::WebKit::WebPageCompositor::animationTimerFired):
* WebKitSupport/WebPageCompositor.h:
(WebPageCompositor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 5 Mar 2012 16:34:29 +0000 (16:34 +0000)]
[WK2] WKPageGetContextMenuFromProposedContextMenuCallback should pass a HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=77208
Reviewed by Anders Carlsson.
A HitTestResultData is now passed to ShowContextMenu WebPageProxy
message instead of the ContextMenuState. ContextMenu client has
been updated to pass the HitTestResult to the
getContextMenuFromProposedMenu callback.
* GNUmakefile.am: Remove ContextMenuState.h.
* Shared/APIClientTraits.h:
* Shared/ContextMenuState.h: Removed.
* Shared/WebHitTestResult.h:
(WebKit::WebHitTestResult::Data::Data): Add constructor that takes
a WebCore::HitTestResult.
* UIProcess/API/C/WKPage.h: Add HitTestResult parameter to
getContextMenuFromProposedMenu callback and deprecate the old
version.
* UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
Pass a HitTestResult to getContextMenuFromProposedMenu or use the
deprecated one if client version is an old one.
* UIProcess/WebPageContextMenuClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::internalShowContextMenu): Save the
WebHitTestResult::Data to use it for handling context menu actions.
(WebKit::WebPageProxy::contextMenuItemSelected): Use the saved
WebHitTestResult::Data.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebKit2.xcodeproj/project.pbxproj: Remove ContextMenuState.h.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::mouseDidMoveOverElement): Use the new
WebHitTestResult::Data constructor that takes a WebCore::HitTestResult.
* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show): Create a WebHitTestResult::Data
instead of a ContextMenuState and pass it to ShowContextMenu message.
* win/WebKit2.vcproj: ContextMenuState.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Mon, 5 Mar 2012 16:26:55 +0000 (16:26 +0000)]
[BlackBerry] Update Tools/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=80287
Reviewed by Antonio Gomes.
Update so we are sure we can build our implementation of DRT.
* DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
* DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
* DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
(AccessibilityController::addNotificationListener): add missing hook.
(AccessibilityController::removeNotificationListener): add missing hook.
* DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
(AccessibilityUIElement::isSelectedOptionActive): add missing hook.
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
(LayoutTestController::simulateDesktopNotificationClick): add missing hook.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Mon, 5 Mar 2012 15:52:16 +0000 (15:52 +0000)]
[Qt] [WK2] Support threaded renderer in WK2
https://bugs.webkit.org/show_bug.cgi?id=76661
Source/WebKit2:
Made the appropriate fixes in the UI process code to make rendering thread-safe.
- Separated the scenegraph node code to QtWebPageSGNode. QtWebPageSGNode has direct access
to LayerTreeHostProxy.
- Each function in LayerTreeHostProxy can be either called from the main thread (handling
messages from the web process), or from the renderer thread (handling the GL context).
The render-queue is locked with a mutex, and messages back to the web process are sent
via callOnMainThread.
- LayerTreeHostProxy is now ThreadSafeRefCounted. That is done to make sure that the GL
resources it creates are only freed when the QtWebPageSGNode is deleted, which can be
before or after the owning DrawingAreaProxy is deleted. This ensures that the class is
deleted only after its GL resources are freed, otherwise those resources may leak.
Based on a patch by Viatcheslav Ostapenko.
Reviewed by Kenneth Rohde Christiansen.
* Target.pri: Added new files.
* UIProcess/API/qt/qquickwebpage.cpp: Moved QtWebPageSGNode out.
(QQuickWebPage::updatePaintNode): Call QtWebPageSGNode
(QQuickWebPagePrivate::updateSize): Call QtWebPageSGNode
(QQuickWebPagePrivate::didDeleteSGWebPageNode): Override QtWebPageSGNode::Client
(QQuickWebPagePrivate::~QQuickWebPagePrivate):
* UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
* UIProcess/DrawingAreaProxy.h:
(WebKit):
(WebKit::DrawingAreaProxy::layerTreeHostProxy): Made LayerTreeHostProxy ref-counted.
(DrawingAreaProxy):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
* UIProcess/LayerTreeHostProxy.h:
(WebKit):
(WebKit::LayerTreeHostProxy::create):
(LayerTreeHostProxy):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit):
(MainThreadGuardedInvoker):
A class that allows invoking functions in the main thread, while guarding a ref-
counted object.
(WebKit::MainThreadGuardedInvoker::call):
(WebKit::MainThreadGuardedInvoker::MainThreadGuardedInvoker):
(WebKit::MainThreadGuardedInvoker::invoke):
(WebKit::LayerTreeHostProxy::syncAnimations):
(WebKit::LayerTreeHostProxy::updateViewport):
(WebKit::LayerTreeHostProxy::detachDrawingArea):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::setShouldRenderNextFrame):
(WebKit::LayerTreeHostProxy::flushLayerChanges):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::purgeGLResources):
* UIProcess/qt/QtWebPageSGNode.cpp: Added.
* UIProcess/qt/QtWebPageSGNode.h: Added.
Tools:
Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
Reviewed by Kenneth Rohde Christiansen.
* MiniBrowser/qt/main.cpp:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 5 Mar 2012 15:37:19 +0000 (15:37 +0000)]
[BlackBerry] DOMSupport visibleSelectionForRangeInputElement incorrectly dereferences a null range.
https://bugs.webkit.org/show_bug.cgi?id=80274
Patch by George Staikos <gstaikos@rim.com> on 2012-03-05
Reviewed by Antonio Gomes.
A null range can be returned so we should not blindly deref it.
Reviewed Internally by Mike Fenton.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::visibleSelectionForRangeInputElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Mon, 5 Mar 2012 15:36:19 +0000 (15:36 +0000)]
Remove pointer to timer and use the timers directly in the tiled backing store https://bugs.webkit.org/show_bug.cgi?id=80283
Patch by Kenneth Rohde Christiansen and Alexander Færøy.
Reviewed by Simon Hausmann.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::~TiledBackingStore):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):
(WebCore::TiledBackingStore::startTileCreationTimer):
* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 5 Mar 2012 15:35:13 +0000 (15:35 +0000)]
Web Inspector: [Styles] Tabbing an empty new property in the middle of style moves the editor to the next section
https://bugs.webkit.org/show_bug.cgi?id=80264
Reviewed by Pavel Feldman.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection.alreadyNew):
(WebInspector.StylePropertyTreeElement.prototype):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Mon, 5 Mar 2012 15:30:54 +0000 (15:30 +0000)]
[BlackBerry] Update LocalizedStringsBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80278
Reviewed by Antonio Gomes.
Update LocalizedStringsBlackBerry.cpp to current HEAD.
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::inputElementAltText): fall back to "Submit".
(WebCore::imageTitle): choose the format "filename(widthxheight)" like Chrome does.
(WebCore::fileButtonNoFilesSelectedLabel): fall back to "No File Chosen" translation like Chrome does.
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 5 Mar 2012 15:24:45 +0000 (15:24 +0000)]
Web Inspector: [chromium] introduce HeapSnapshot performance test.
https://bugs.webkit.org/show_bug.cgi?id=80280
Reviewed by Pavel Feldman.
PerformanceTests:
* inspector/detailed-heapshots-smoke-test.html: Added.
Source/WebCore:
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype._callLoadCallbacks):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 5 Mar 2012 15:14:38 +0000 (15:14 +0000)]
Web Inspector: cannot be launched when localStorage is disabled
https://bugs.webkit.org/show_bug.cgi?id=80252
Reviewed by Vsevolod Vlasov.
* inspector/front-end/Settings.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 5 Mar 2012 15:07:50 +0000 (15:07 +0000)]
Web Inspector: check for the number of parsed css properties.
https://bugs.webkit.org/show_bug.cgi?id=80268
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: inspector/styles/set-property-boundaries.html
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
LayoutTests:
* inspector/styles/set-property-boundaries-expected.txt: Added.
* inspector/styles/set-property-boundaries.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Mon, 5 Mar 2012 15:00:52 +0000 (15:00 +0000)]
Web Inspector: Tabbed pane should redraw tab elements when tab is closed.
https://bugs.webkit.org/show_bug.cgi?id=80273
Reviewed by Pavel Feldman.
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.closeTab):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Mon, 5 Mar 2012 14:54:54 +0000 (14:54 +0000)]
Improve comments in the tiled backing store https://bugs.webkit.org/show_bug.cgi?id=80279
Patch by Kenneth Rohde Christiansen and Alexander Færøy.
Reviewed by Simon Hausmann.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Mon, 5 Mar 2012 14:26:00 +0000 (14:26 +0000)]
TiledBackingStore.{h,cpp} contains unclear variable names https://bugs.webkit.org/show_bug.cgi?id=80276
Patch by Kenneth Rohde Christiansen and Alexander Færøy.
Reviewed by Simon Hausmann.
This patch renames some of the variables in TiledBackingStore.cpp to
enhance the clearity and for consistence.
The visibleContentsRect is renamed to visibleRect as it is not in
contents coordinates.
The panningTrajectoryVector and m_visibleRectTrajectoryVector are
renamed to just *[m_]trajectoryVector, as that is descriptive enough.
The previous prefix has also been removed, as it is being used as the
current one in the code. This avoids confusion.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::coverWithTilesIfNeeded):
(WebCore::TiledBackingStore::visibleRect):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):
* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 5 Mar 2012 14:16:15 +0000 (14:16 +0000)]
[Qt] Fix build with Qt 5 and OpenGL ES 2.0
Reviewed by Noam Rosenthal.
* platform/graphics/texmap/TextureMapper.h: Since we don't do QT += opengl with Qt 5 anymore
here in WebCore, we cannot check for QT_OPENGL_LIB. But since this is Qt5, we know that the
GLES setting comes qconfig.h and we can rely on it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Mon, 5 Mar 2012 14:00:22 +0000 (14:00 +0000)]
Whitespace clean-up of TiledBackingStore.cpp.
Rubber-stamped by Kenneth Rohde Christiansen.
Already covered by existing tests.
* platform/graphics/TiledBackingStore.cpp:
(WebCore):
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 5 Mar 2012 13:57:12 +0000 (13:57 +0000)]
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
* GNUmakefile.list.am: Add missing header file.
Source/WebCore:
* GNUmakefile.list.am: Add missing header file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Mon, 5 Mar 2012 13:29:47 +0000 (13:29 +0000)]
Unreviewed. Add myself to committer list.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 5 Mar 2012 13:00:09 +0000 (13:00 +0000)]
[Qt] Use config test to determine if the compiler supports -MD
We used to assume that unix systems building against Qt5 would have
a compiler that supported -MD. Although this was usually the case,
we failed to take into account broken tools for distributed builds
(e.g. teambuilder or icecream) which would end up producing .d files
in the root of the build dir instead of along-side the object file.
Now that we use a config-test to determine the support, we'll capture
those cases, unless distributed builds are enabled after the initial
build-webkit run.
Reviewed by Csaba Osztrogonác.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 5 Mar 2012 12:03:53 +0000 (12:03 +0000)]
Web Inspector: Incorrect appropriateSelectorFor() suggestion for when a DOMNode has more than 2 CSS classes
https://bugs.webkit.org/show_bug.cgi?id=80258
Reviewed by Pavel Feldman.
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.appropriateSelectorFor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wingo@igalia.com [Mon, 5 Mar 2012 11:55:53 +0000 (11:55 +0000)]
WTF: Micro-optimize cleanup of empty vectors and hash tables
https://bugs.webkit.org/show_bug.cgi?id=79903
Reviewed by Michael Saboff and Geoffrey Garen.
This patch speeds up cleanup of vectors and hash tables whose
backing store was never allocated. This is the case by default
for most vectors / hash tables that never had any entries added.
The result for me is that calling checkSyntax 1000 times on
concat-jquery-mootools-prototype.js goes from 6.234s to 6.068s, a
2.4% speedup.
* wtf/HashTable.h:
(WTF::HashTable::~HashTable):
(WTF::::clear): Don't deallocate the storage or frob member
variables if there is no backing storage.
* wtf/Vector.h:
(WTF::VectorBufferBase::deallocateBuffer): Likewise.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 5 Mar 2012 10:44:40 +0000 (10:44 +0000)]
Web Inspector: [Styles] [CRASH] Handle rule addition and inline style editing failure due to Content-Security-Policy in the page
https://bugs.webkit.org/show_bug.cgi?id=80024
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/styles/add-new-rule-inline-style-csp.html
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
* inspector/InspectorCSSAgent.h:
(InlineStyleOverrideScope):
(WebCore::InspectorCSSAgent::InlineStyleOverrideScope::InlineStyleOverrideScope):
(WebCore::InspectorCSSAgent::InlineStyleOverrideScope::~InlineStyleOverrideScope):
(InspectorCSSAgent):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::setOverrideAllowInlineStyle):
(WebCore):
* page/ContentSecurityPolicy.h:
(ContentSecurityPolicy):
LayoutTests:
* inspector/styles/add-new-rule-inline-style-csp-expected.txt: Added.
* inspector/styles/add-new-rule-inline-style-csp.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 5 Mar 2012 10:26:53 +0000 (10:26 +0000)]
[Forms] The "optgroup" element should not be a form-associated element
https://bugs.webkit.org/show_bug.cgi?id=80234
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-05
Reviewed by Kent Tamura.
This patch changes base class of HTMLOptGroup to HTMLElement from
HTMLFormControlElement to avoid the "optgroup" element in form-associate
elements collection.
This patch doesn't affect HTMLOptionElement::disabled's static_cast. However,
it doesn't good at coding style. This patch also fix it.
No new tests. No behavior changes.
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::HTMLOptGroupElement): Remove "form" parameter.
(WebCore::HTMLOptGroupElement::create): Remove "form" parameter.
(WebCore::HTMLOptGroupElement::childrenChanged): Replace base method call.
(WebCore::HTMLOptGroupElement::parseAttribute): Replace base method call.
(WebCore::HTMLOptGroupElement::attach): Replace base method call.
(WebCore::HTMLOptGroupElement::detach): Replace base method call.
* html/HTMLOptGroupElement.h:
(HTMLOptGroupElement): Change base class to HTMLElement.
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::disabled): Replace static_cast<HTMLFormControlElement*> to static_cast<HTMLElement*> with checking isHTMLElement.
* html/HTMLTagNames.in: Remove "constructorNeedsFormElement" for not passing "form" parameter in HTMLElementFactory.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 5 Mar 2012 10:01:11 +0000 (10:01 +0000)]
Web Inspector: fix extensions-resource.html test.
https://bugs.webkit.org/show_bug.cgi?id=80183
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 5 Mar 2012 09:49:15 +0000 (09:49 +0000)]
[Chromium] Rebaseline search-field-cancel.html for r109503.
Fix an error of the previous rebaseline.
* platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Removed.
* platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 5 Mar 2012 09:24:50 +0000 (09:24 +0000)]
Qt API test buildstep throws exception after buildmaster update
https://bugs.webkit.org/show_bug.cgi?id=80249
Reviewed by Zoltan Herczeg.
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
(BuildAndTestFactory.__init__):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 5 Mar 2012 09:05:57 +0000 (09:05 +0000)]
Unreviewed gardening, skip a new failing test.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 5 Mar 2012 08:48:29 +0000 (08:48 +0000)]
Add instrumentation for frame start/end on timeline.
Web Inspector: add timeline instrumentation for frame events
https://bugs.webkit.org/show_bug.cgi?id=80127
Reviewed by Pavel Feldman.
Source/WebCore:
- display frame boundaries when vertical overview mode is on
- aggregate by frame in vertical overview mode
- switched event filtering criteria from index to time in vertical overview mode
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didBeginFrameImpl):
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didBeginFrame):
(WebCore):
* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
(WebInspector.TimelineOverviewPane.prototype.updateEventDividers):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype.accept):
(WebInspector.TimelineOverviewPane.prototype.windowStartTime):
(WebInspector.TimelineOverviewPane.prototype.windowEndTime):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineStartAtZeroOverview):
(WebInspector.TimelineStartAtZeroOverview.prototype.reset):
(WebInspector.TimelineStartAtZeroOverview.prototype.update):
(WebInspector.TimelineStartAtZeroOverview.prototype._aggregateFrames):
(WebInspector.TimelineStartAtZeroOverview.prototype._aggregateFrameStatistics):
(WebInspector.TimelineStartAtZeroOverview.prototype._aggregateRecords):
(WebInspector.TimelineStartAtZeroOverview.prototype._buildBar):
(WebInspector.TimelineStartAtZeroOverview.prototype.getWindowTimes):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineCategoryFilter.prototype.accept):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.get _recordStyles):
* inspector/front-end/inspectorCommon.css:
* inspector/front-end/timelinePanel.css:
(#timeline-container):
(.timeline .resources-event-divider):
(.timeline.timeline-start-at-zero .resources-divider):
(.timeline .resources-event-divider.timeline-frame-divider):
Source/WebKit/chromium:
- expose an instrumentation method from WebWidget to mark frame update start
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::instrumentBeginFrame):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::instrumentBeginFrame):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
LayoutTests:
* inspector/timeline/timeline-enum-stability-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 5 Mar 2012 08:44:56 +0000 (08:44 +0000)]
Unreviewed build fix for !ENABLE(SHADOW_DOM).
* html/shadow/HTMLContentElement.cpp:
(WebCore::contentTagName):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 5 Mar 2012 08:42:06 +0000 (08:42 +0000)]
[GTK] Unit tests are noisy when run under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=80241
Reviewed by Philippe Normand.
Force the 'memory' backend in GSettings so that each unit
test doesn't produce a warning when it's forced to fall back
to the 'memory' backend.
* Scripts/run-gtk-tests:
(TestRunner.run): Force the 'memory' backend.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 5 Mar 2012 08:37:51 +0000 (08:37 +0000)]
Internally used HTMLContentElement subclasses should have correct wrapper.
https://bugs.webkit.org/show_bug.cgi?id=80237
Reviewed by Kent Tamura.
Source/WebCore:
DetailsContentElement and DetailsSummaryElement used to use
<div> as their tag name. But this means they are wrapped by
wrapper objects for HTMLDivElement, which is wrong. This happened
to work though because HTMLDivElement has no extra state or API.
This change introduces "noConstructor" keyword for make_name.pl
sources. This keyword allows a tag name to specify its own
wrapper without making the tag name visible from the parser, or
HTMLElementFactory in precise.
Following this addition, this change also adds a new tag name
"webkitShadowContent" for DetailsContentElement and DetailsSummaryElement,
which has no constructor, and whose wrapper type is HTMLElement.
This change isn't visible from the page author and only matters for testing.
Test: fast/dom/shadow/content-element-user-agent-shadow.html
* dom/make_names.pl:
(defaultTagPropertyHash):
(buildConstructorMap):
(printConstructors):
(printFunctionInits):
* html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
* html/HTMLTagNames.in:
* html/shadow/HTMLContentElement.cpp:
(WebCore::contentTagName):
LayoutTests:
* fast/dom/shadow/content-element-user-agent-shadow-expected.txt: Added.
* fast/dom/shadow/content-element-user-agent-shadow.html: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 5 Mar 2012 08:35:15 +0000 (08:35 +0000)]
[GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
https://bugs.webkit.org/show_bug.cgi?id=80235
Reviewed by Philippe Normand.
Source/WebKit/gtk:
Wait to inspect the WebView until the page has finished loading. Also
clean up some minor style errors.
* tests/testwebinspector.c:
(closeInspector): Small style fixes.
(showInspector): Ditto.
(loadFinished): Ditto.
(test_webkit_web_inspector_close_and_inspect): Wait to inspect until the page has loaded.
(test_webkit_web_inspector_destroy_inspected_web_view): Ditto.
(main): Small style fixes.
Tools:
* Scripts/run-gtk-tests:
(TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
inspector resources path determination is shared by all tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 5 Mar 2012 08:28:59 +0000 (08:28 +0000)]
[GTK] REGRESSION: r108278 broke some tests that expect focus
https://bugs.webkit.org/show_bug.cgi?id=79084
Reviewed by Philippe Normand.
Source/WebKit/gtk:
Grab focus before running the test. This ensures that if the
WebView lost focus, it has it before sending events.
* tests/testcopyandpaste.c:
(test_copy_and_paste): Grab focus.
Tools:
Grab focus when dumping test results and also when sending
events. During the course of testing, the WebView may lose
focus and this seems to snap it back when tests demand it.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump): Grab focus.
* DumpRenderTree/gtk/EventSender.cpp:
(dispatchEvent): Ditto.
LayoutTests:
* platform/gtk/Skipped: Unskip passing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Mon, 5 Mar 2012 08:22:33 +0000 (08:22 +0000)]
Refactoring: Move HTMLContentElement::attach to InsertionPoint::attach.
https://bugs.webkit.org/show_bug.cgi?id=80243
Reviewed by Hajime Morita.
Since the current code in HTMLContentElement::attach() will be used for coming <shadow>
elements, it is natural that InsertionPoint::attach() has such code.
No new tests, no change in behavior.
* html/shadow/HTMLContentElement.cpp:
* html/shadow/HTMLContentElement.h:
(HTMLContentElement):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::attach):
(WebCore):
(WebCore::InsertionPoint::detach):
* html/shadow/InsertionPoint.h:
(InsertionPoint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 5 Mar 2012 08:18:11 +0000 (08:18 +0000)]
[Chromium] Rebaseline search-field-cancel.html for r109503.
* platform/chromium-linux/fast/repaint/search-field-cancel-expected.png:
* platform/chromium-mac-leopard/fast/repaint/search-field-cancel-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Added.
* platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
* platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 5 Mar 2012 08:13:42 +0000 (08:13 +0000)]
allowDatabaseAccess and databaseExceededQuota should be part of DatabaseContext not ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=80178
Reviewed by Eric Seidel.
These functions are only used by SQLDatabase, which means we can move
them to DatabaseContext, removing one more tendril of the SQLDatabase
code.
* dom/Document.cpp:
(WebCore):
* dom/Document.h:
(Document):
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
* storage/DatabaseContext.cpp:
(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::from):
(WebCore::DatabaseContext::allowDatabaseAccess):
(WebCore):
(WebCore::DatabaseContext::databaseExceededQuota):
* storage/DatabaseContext.h:
(DatabaseContext):
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::canEstablishDatabase):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::executeSQL):
* storage/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didExceedQuota):
* storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::executeSQL):
* workers/WorkerContext.cpp:
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 5 Mar 2012 08:03:08 +0000 (08:03 +0000)]
Unreviewed, mark two tests as flaky in GTK.
* platform/gtk/test_expectations.txt:
editing/selection/select-line-break-with-opposite-directionality.html
and fast/css/hover-update.html are flaky.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 5 Mar 2012 07:57:36 +0000 (07:57 +0000)]
Unreviewed, rolling out r107551.
http://trac.webkit.org/changeset/107551
https://bugs.webkit.org/show_bug.cgi?id=80245
caused incorrect style sharing (Requested by kling on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-04
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Mon, 5 Mar 2012 06:57:40 +0000 (06:57 +0000)]
Remove unused macro HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE_WITH_VALUE.
https://bugs.webkit.org/show_bug.cgi?id=80236
Reviewed by Eric Seidel.
No new tests / unused code deletion only.
* css/CSSStyleSelector.cpp:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 5 Mar 2012 06:52:44 +0000 (06:52 +0000)]
JIT heuristics should be hyperbolic
https://bugs.webkit.org/show_bug.cgi?id=80055
<rdar://problem/
10922260>
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
Added tracking of the amount of executable memory typically used for a bytecode
instruction. Modified the execution counter scheme to use this, and the amount
of free memory, to determine how long to wait before invoking the JIT.
The result is that even if we bomb the VM with more code than can fit in our
executable memory pool, we still keep running and almost never run out of
executable memory - which ensures that if we have to JIT something critical, then
we'll likely have enough memory to do so. This also does not regress performance
on the three main benchmarks.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::predictedMachineCodeSize):
(JSC):
(JSC::CodeBlock::usesOpcode):
* bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::checkIfJITThresholdReached):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::addressOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecutionActiveThreshold):
(JSC::CodeBlock::offsetOfJITExecutionTotalCount):
(JSC::CodeBlock::jitExecuteCounter):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
* bytecode/ExecutionCounter.cpp: Added.
(JSC):
(JSC::ExecutionCounter::ExecutionCounter):
(JSC::ExecutionCounter::checkIfThresholdCrossedAndSet):
(JSC::ExecutionCounter::setNewThreshold):
(JSC::ExecutionCounter::deferIndefinitely):
(JSC::ExecutionCounter::applyMemoryUsageHeuristics):
(JSC::ExecutionCounter::applyMemoryUsageHeuristicsAndConvertToInt):
(JSC::ExecutionCounter::hasCrossedThreshold):
(JSC::ExecutionCounter::setThreshold):
(JSC::ExecutionCounter::reset):
* bytecode/ExecutionCounter.h: Added.
(JSC):
(ExecutionCounter):
(JSC::ExecutionCounter::formattedTotalCount):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* jit/ExecutableAllocator.cpp:
(JSC::DemandExecutableAllocator::allocateNewSpace):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC):
(JSC::ExecutableAllocator::memoryPressureMultiplier):
* jit/ExecutableAllocator.h:
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::memoryPressureMultiplier):
(JSC):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
* llint/LowLevelInterpreter32_64.asm:
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
* runtime/Options.h:
(Options):
* wtf/SimpleStats.h: Added.
(WTF):
(SimpleStats):
(WTF::SimpleStats::SimpleStats):
(WTF::SimpleStats::add):
(WTF::SimpleStats::operator!):
(WTF::SimpleStats::count):
(WTF::SimpleStats::sum):
(WTF::SimpleStats::sumOfSquares):
(WTF::SimpleStats::mean):
(WTF::SimpleStats::variance):
(WTF::SimpleStats::standardDeviation):
Source/WebCore:
Reviewed by Oliver Hunt.
No new tests, since there's no new functionality.
* ForwardingHeaders/wtf/SimpleStats.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Mon, 5 Mar 2012 06:30:22 +0000 (06:30 +0000)]
Source/WebCore: Methods like firstRendererOf of NodeRenderingContext should be extracted.
https://bugs.webkit.org/show_bug.cgi?id=79902
Reviewed by Hajime Morita.
firstRendererOfInsertionPoint should return the first renderer of its child, however
it returns next renderer of parent. The same thing happens lastRendererOfInsertionPoint.
Test: content-element-move.html has another test case.
* dom/NodeRenderingContext.cpp:
(WebCore):
(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
LayoutTests: Refactoring: Methods like firstRendererOf of NodeRenderingContext should be extracted.
https://bugs.webkit.org/show_bug.cgi?id=79902
Reviewed by Hajime Morita.
Added a new test case.
* fast/dom/shadow/content-element-move-expected.txt:
* fast/dom/shadow/content-element-move.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 5 Mar 2012 04:43:00 +0000 (04:43 +0000)]
Unreviewed build fix for ENABLE(MATHML).
* mathml/MathMLElement.h:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 5 Mar 2012 04:09:39 +0000 (04:09 +0000)]
WebKit needs toHTMLUnknownElement() and isUnknown() for sanity check.
https://bugs.webkit.org/show_bug.cgi?id=80229
Reviewed by Kent Tamura.
The code generator has naked static_cast<> which could be unsafe.
We can turn it into toHTMLUnknownElement() and the like.
No new tests. Just added a sanity check.
* dom/make_names.pl:
(printWrapperFactoryCppFile):
* html/HTMLElement.h:
(HTMLElement):
(WebCore::HTMLElement::isHTMLUnknownElement):
* html/HTMLUnknownElement.h:
(HTMLUnknownElement):
(WebCore::toHTMLUnknownElement):
(WebCore):
* mathml/MathMLElement.h:
(toMathMLElement):
* svg/SVGElement.h:
(WebCore::toSVGElement):
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
charles.wei@torchmobile.com.cn [Mon, 5 Mar 2012 04:02:12 +0000 (04:02 +0000)]
Unreviewed, Add myself to committer list.
https://bugs.webkit.org/show_bug.cgi?id=80232
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Mon, 5 Mar 2012 03:38:58 +0000 (03:38 +0000)]
Handle CSSPropertyWebkitColumnBreakAfter, CSSPropertyWebkitColumnBreakBefore and CSSPropertyWebkitColumnBreakInside in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80226
Reviewed by Eric Seidel.
No new tests / refactoring only.
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 5 Mar 2012 03:29:28 +0000 (03:29 +0000)]
[BlackBerry] upstream CredentialManager and CredentialTransformData implementation
https://bugs.webkit.org/show_bug.cgi?id=80107
Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-04
Reviewed by Antonio Gomes.
Initial upstream of CredentialManager.[h|cpp] and
CredentialTransformData.[h|cpp].
No new test.
Source/WebKit:
* PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
* WebCoreSupport/CredentialManager.cpp: Added.
(WebCore):
(WebCore::CredentialManager::CredentialManager):
(WebCore::CredentialManager::autofillAuthenticationChallenge):
(WebCore::CredentialManager::autofillPasswordForms):
(WebCore::CredentialManager::saveCredentialIfConfirmed):
* WebCoreSupport/CredentialManager.h: Added.
(WebKit):
(WebCore):
(CredentialManager):
* WebCoreSupport/CredentialTransformData.cpp: Added.
(WebCore::CredentialTransformData::CredentialTransformData):
(WebCore):
(WebCore::CredentialTransformData::url):
(WebCore::CredentialTransformData::credential):
(WebCore::CredentialTransformData::setCredential):
(WebCore::CredentialTransformData::findPasswordFormFields):
* WebCoreSupport/CredentialTransformData.h: Added.
(WebCore):
(CredentialTransformData):
(WebCore::CredentialTransformData::isValid):
(WebCore::CredentialTransformData::protectionSpace):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 5 Mar 2012 03:23:58 +0000 (03:23 +0000)]
[BlackBerry] Credential backing store implementation
https://bugs.webkit.org/show_bug.cgi?id=79650
Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-04
Reviewed by Antonio Gomes.
Opened Credential database in CedentialBackingStore::instance().
Added never_remember table and associated sql statment
members to store the never remember sites.
Removed CredentialStorage initialize codes because that
won't give users a chance to re-enter the new credential
information for an already stored site.
Changed login update and has statement to support
autofill feature of multiple credential forms in the
same page; Also added url as a parameter of hasLogin() function.
Added calling reset() after each statement calls step(),
to make it work correctly next time.
Also fixed a macro typo in HANDLE_SQL_EXEC_FAILURE.
No new tests.
* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::instance):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::close):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::hasLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore):
(WebCore::CredentialBackingStore::removeLogin):
(WebCore::CredentialBackingStore::addNeverRemember):
(WebCore::CredentialBackingStore::hasNeverRemember):
(WebCore::CredentialBackingStore::getNeverRemember):
(WebCore::CredentialBackingStore::removeNeverRemember):
(WebCore::CredentialBackingStore::clearLogins):
(WebCore::CredentialBackingStore::clearNeverRemember):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 5 Mar 2012 03:15:18 +0000 (03:15 +0000)]
[EFL] Evas_GL initialization and destruction in GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=80211
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-04
Reviewed by Noam Rosenthal.
This patch adds initialization and destruction codes using Evas_GL APIs to GC3DPrivate.
No new tests. No behavior change.
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::createSurface):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
* platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kubo@profusion.mobi [Mon, 5 Mar 2012 03:01:38 +0000 (03:01 +0000)]
[CMake] Libraries are installed to /usr/lib and not /usr/lib64 on x86_64
https://bugs.webkit.org/show_bug.cgi?id=71507
Reviewed by Antonio Gomes.
.:
* Source/cmake/OptionsCommon.cmake: Provide two variables which
can be changed via CMake: LIB_SUFFIX, which is often used in CMake
projects to let the user choose whether a suffix should be added
to the library installation directory (such as 32 or 64), and
LIB_INSTALL_DIR, which takes LIB_SUFFIX into account to determine
whether to install libraries.
Source/JavaScriptCore:
* CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Source/WebCore:
No new tests, buildsystem change.
* CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Source/WebKit:
* CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Source/WebKit2:
* CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 5 Mar 2012 02:43:37 +0000 (02:43 +0000)]
[EFL] Implementation of missing functions in GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=79759
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-04
Reviewed by Noam Rosenthal.
The initial patch (Bug 62961) only contains implementations for simple functions
which call GL functions through Evas_GL_API.
This patch implements a little complicated functions such as getActiveAttrib(),
getShaderSource() and so on.
No new tests. No behavior change.
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getError):
(WebCore::GraphicsContext3DPrivate::getIntegerv):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 5 Mar 2012 02:33:21 +0000 (02:33 +0000)]
Revert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80139
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl.
No tests. No change in behavior.
* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* page/DOMWindow.idl:
* svg/DOMWindowSVG.idl: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 5 Mar 2012 02:32:00 +0000 (02:32 +0000)]
[Chromium] We should reset mouse position before calling eventSender.mouseMove in LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=79748
* platform/chromium/test_expectations.txt: Removed flaky expectations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 5 Mar 2012 02:24:20 +0000 (02:24 +0000)]
Revert WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80144
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl.
No tests. No change in behavior.
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* html/canvas/DOMWindowWebGL.idl: Removed.
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 5 Mar 2012 02:01:45 +0000 (02:01 +0000)]
Unreviewed, gardening.
* platform/chromium/fast/files/xhr-response-blob-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 5 Mar 2012 01:59:51 +0000 (01:59 +0000)]
Unreviewed build fix.
* rendering/RenderButton.cpp:
(WebCore::RenderButton::canHaveGeneratedChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 5 Mar 2012 01:39:47 +0000 (01:39 +0000)]
REGRESSION(r108758): Assertion failure in WebCore::RenderMenuList::addChild
https://bugs.webkit.org/show_bug.cgi?id=80096
Reviewed by Dimitri Glazkov.
Source/WebCore:
After r108758 RenderBlock allowed <select> to have generated
contents. But it shouldn't. This change stops allowing it again by
replacing some canHaveChildren() invocations with
less permissive canHaveGeneratedChildren().
This change also pulls back original canHaveChildren() logic to
RenderButton to allow <button> to have generated contents.
Then RenderDeprecatedFlexibleBox::buttonText() is morphed to
more intention revealing canHaveGeneratedChildren().
Test: fast/forms/select-generated-content.html
* rendering/RenderBlock.cpp:
(WebCore):
(WebCore::canHaveGeneratedChildren):
(WebCore::RenderBlock::styleDidChange):
(WebCore::findFirstLetterBlock):
(WebCore::RenderBlock::updateFirstLetter):
* rendering/RenderButton.cpp:
* rendering/RenderButton.h:
(RenderButton):
* rendering/RenderDeprecatedFlexibleBox.h:
(WebCore::RenderDeprecatedFlexibleBox::canHaveGeneratedChildren):
* rendering/RenderMenuList.h:
LayoutTests:
* fast/forms/select-generated-content-expected.txt: Added.
* fast/forms/select-generated-content.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Mon, 5 Mar 2012 01:34:22 +0000 (01:34 +0000)]
2012-03-04 Antonio Gomes <agomes@rim.com>
Fixed positioned element not correctly positioned after orientation change,
when viewport metatag is used with "initial-scale=1" MKS_2992596
PR #138865
Reviewed by George Staikos.
Viewport size changes in two main scenarios:
- orientation changes;
- virtual keyboard pop up/hide.
When we are setting a new viewport size, we need to
update the FixedReportedSize of the mainframe. This size
is used to return innerWidth|Heigth as well as to calculate
the fixed position elements height relative to the RenderView [1].
[1] RenderBox::containingBlockLogicalHeightForPositioned.
When we are rotating, we need to delay setting the new FixedReportedSize
till we layout and are able to figure out the new contents size. At this
time we call setFixedReportedSize, but we do not reposition the fixed elemts
afterwards.
Patch adds a call to FrameView::repaintFixedElementsAfterScrolling, after
setting the new size.
Source/WebKit/blackberry:
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
Source/WebCore:
* manual-tests/blackberry/meta-viewport-fixed-position-preserved-on-rotation.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 5 Mar 2012 01:09:02 +0000 (01:09 +0000)]
Unreviewed, gardening.
* platform/chromium-mac-leopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 5 Mar 2012 00:44:28 +0000 (00:44 +0000)]
Unreviewed, gardening.
* platform/chromium-mac-leopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 5 Mar 2012 00:30:01 +0000 (00:30 +0000)]
Unreviewed, gardening.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 5 Mar 2012 00:23:47 +0000 (00:23 +0000)]
Unreviewed, gardening.
* platform/chromium/fast/js/function-dot-arguments-and-caller-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 4 Mar 2012 21:35:38 +0000 (21:35 +0000)]
[BlackBerry] Upstream two helper files from platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=80125
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-04
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
* platform/graphics/blackberry/InstrumentedPlatformCanvas.h: Added.
(WebCore):
(InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::~InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::isSolidColor):
(WebCore::InstrumentedPlatformCanvas::solidColor):
(WebCore::InstrumentedPlatformCanvas::save):
(WebCore::InstrumentedPlatformCanvas::saveLayer):
(WebCore::InstrumentedPlatformCanvas::restore):
(WebCore::InstrumentedPlatformCanvas::translate):
(WebCore::InstrumentedPlatformCanvas::scale):
(WebCore::InstrumentedPlatformCanvas::rotate):
(WebCore::InstrumentedPlatformCanvas::skew):
(WebCore::InstrumentedPlatformCanvas::concat):
(WebCore::InstrumentedPlatformCanvas::setMatrix):
(WebCore::InstrumentedPlatformCanvas::clipRect):
(WebCore::InstrumentedPlatformCanvas::clipPath):
(WebCore::InstrumentedPlatformCanvas::clipRegion):
(WebCore::InstrumentedPlatformCanvas::clear):
(WebCore::InstrumentedPlatformCanvas::drawPaint):
(WebCore::InstrumentedPlatformCanvas::drawPoints):
(WebCore::InstrumentedPlatformCanvas::drawRect):
(WebCore::InstrumentedPlatformCanvas::drawPath):
(WebCore::InstrumentedPlatformCanvas::drawBitmap):
(WebCore::InstrumentedPlatformCanvas::drawBitmapRect):
(WebCore::InstrumentedPlatformCanvas::drawBitmapMatrix):
(WebCore::InstrumentedPlatformCanvas::drawSprite):
(WebCore::InstrumentedPlatformCanvas::drawText):
(WebCore::InstrumentedPlatformCanvas::drawPosText):
(WebCore::InstrumentedPlatformCanvas::drawPosTextH):
(WebCore::InstrumentedPlatformCanvas::drawTextOnPath):
(WebCore::InstrumentedPlatformCanvas::drawPicture):
(WebCore::InstrumentedPlatformCanvas::drawVertices):
(WebCore::InstrumentedPlatformCanvas::drawData):
* platform/graphics/blackberry/LayerMessage.h: Added.
(WebCore):
(WebCore::isCompositingThread):
(WebCore::compositingThread):
(WebCore::isWebKitThread):
(WebCore::webKitThread):
(WebCore::dispatchCompositingMessage):
(WebCore::dispatchSyncCompositingMessage):
(WebCore::dispatchWebKitMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sun, 4 Mar 2012 20:46:32 +0000 (20:46 +0000)]
Newer versions of clang fail to compile WebKit.
Fix build.
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(descriptionOfValue):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::selectedTextRange):
* DumpRenderTree/mac/EditingDelegate.mm:
(-[DOMRange dump]):
* DumpRenderTree/mac/PolicyDelegate.mm:
(-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[NSError _drt_descriptionSuitableForTestResult]):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::descriptionOfValue):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::selectedTextRange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mikelawther@chromium.org [Sun, 4 Mar 2012 20:43:42 +0000 (20:43 +0000)]
table tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75898
Reviewed by Julien Chaffraix.
Tests CSS3 calc() (see http://webkit.org/b/16662) on some simple examples with tables.
* css3/calc/table-calcs-expected.txt: Added.
* css3/calc/table-calcs.html: Added.
* css3/calc/table-empty-cells-expected.html: Added.
* css3/calc/table-empty-cells.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sun, 4 Mar 2012 19:07:52 +0000 (19:07 +0000)]
Introduce SMIL overrideStyle, to make SVG stop mutating CSS styles directly
https://bugs.webkit.org/show_bug.cgi?id=79790
Reviewed by Dirk Schulze.
Source/WebCore:
Restore SMIL animation behavior back to pre-r109342.
1) Always animate presentation attributes as CSS properties, regardless of the
attributeTypes value. Matches Opera/FF, and makes the attribute optional again
as specified in both SMIL & SVG.
Extend existing svg/animations/attributesTypes.html to verify this.
2) Switch setInstancesUpdatesBlocked calls to the right locations again, to
avoid chromium assertions (and/or extra work being done). Fixing that reveals another
problem: in the instance updating code path, we always called setTargetAttributeAnimatedCSSValue
even for XML animations.
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::shouldApplyAnimation): Restore old logic.
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): Fix typo, move setInstancesUpdatesBlocked calls.
LayoutTests:
Extended attributesTypes.html test case to check that presentation attributes are
always animated as CSS properties, regardless of their attributeTypes value.
* platform/chromium/test_expectations.txt: Remove animate-elem-32-t.svg suppression.
* svg/animations/attributeTypes-expected.txt: Updated expectations.
* svg/animations/resources/attributeTypes.svg: Fix comment.
* svg/animations/script-tests/attributeTypes.js: Extend test.
(sample1):
(sample2):
(sample3):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sun, 4 Mar 2012 18:53:51 +0000 (18:53 +0000)]
Fix build when the classic interpreter is enabled
Reviewed by Gavin Barraclough.
Fixes the following build error when running the "Generate
Derived Sources" build phase script:
offlineasm: Parsing JavaScriptCore/llint/LowLevelInterpreter.asm and ../../JSCLLIntOffsetsExtractor and creating assembly file LLIntAssembly.h.
./JavaScriptCore/offlineasm/offsets.rb:145:in `offsetsAndConfigurationIndex': unhandled exception
from JavaScriptCore/offlineasm/asm.rb:131
Command /bin/sh failed with exit code 1
Gavin's fix in r109674 avoided the #error statement in
JITStubs.h when compiling LLIntOffsetsExtractor.cpp, but it
caused the "Generate Derived Sources" build phase script to fail
when JavaScriptCore/offlineasm/asm.rb was run. The solution is
to detect when the classic interpreter is being built and simply
exit early from asm.rb in that case.
* llint/LLIntOffsetsExtractor.cpp:
(JSC::LLIntOffsetsExtractor::dummy): Return NULL pointer if the
JIT is disabled. Note that offsets.rb doesn't care about the
return value here, but instead it cares about finding the magic
values in the binary. The magic values are no longer present
when the JIT is disabled.
* offlineasm/asm.rb: Catch MissingMagicValuesException and exit
early with a status message.
* offlineasm/offsets.rb:
(MissingMagicValuesException): Add new exception class.
(offsetsAndConfigurationIndex): Throw
MissingMagicValuesException when no magic values are found.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 4 Mar 2012 17:11:45 +0000 (17:11 +0000)]
[BlackBerry] upstream MediaPlayerPrivateBlackBerry.[cpp|h]
https://bugs.webkit.org/show_bug.cgi?id=79729
Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-04
Reviewed by Rob Buis and Antonio Gomes.
Implementation of MediaPlayerPrivate for BlackBerry porting.
Initial upstream, No new tests.
* PlatformBlackBerry.cmake:
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp: Added.
(WebCore):
(WebCore::MediaPlayerPrivate::create):
(WebCore::MediaPlayerPrivate::registerMediaEngine):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::notifyAppActivatedEvent):
(WebCore::MediaPlayerPrivate::setCertificatePath):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::prepareToPlay):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin):
(WebCore::MediaPlayerPrivate::movieLoadType):
(WebCore::MediaPlayerPrivate::userAgent):
(WebCore::MediaPlayerPrivate::resizeSourceDimensions):
(WebCore::MediaPlayerPrivate::setFullscreenWebPageClient):
(WebCore::MediaPlayerPrivate::getWindow):
(WebCore::MediaPlayerPrivate::getPeerWindow):
(WebCore::MediaPlayerPrivate::getWindowPosition):
(WebCore::MediaPlayerPrivate::mmrContextName):
(WebCore::MediaPlayerPrivate::percentLoaded):
(WebCore::MediaPlayerPrivate::sourceWidth):
(WebCore::MediaPlayerPrivate::sourceHeight):
(WebCore::MediaPlayerPrivate::setAllowPPSVolumeUpdates):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::onStateChanged):
(WebCore::MediaPlayerPrivate::onMediaStatusChanged):
(WebCore::MediaPlayerPrivate::onError):
(WebCore::MediaPlayerPrivate::onDurationChanged):
(WebCore::MediaPlayerPrivate::onTimeChanged):
(WebCore::MediaPlayerPrivate::onPauseStateChanged):
(WebCore::MediaPlayerPrivate::onRateChanged):
(WebCore::MediaPlayerPrivate::onVolumeChanged):
(WebCore::MediaPlayerPrivate::onRepaint):
(WebCore::MediaPlayerPrivate::onSizeChanged):
(WebCore::MediaPlayerPrivate::onPlayNotified):
(WebCore::MediaPlayerPrivate::onPauseNotified):
(WebCore::MediaPlayerPrivate::onBuffering):
(WebCore::MediaPlayerPrivate::showErrorDialog):
(WebCore::MediaPlayerPrivate::frameView):
(WebCore::MediaPlayerPrivate::platformWindow):
(WebCore::MediaPlayerPrivate::isFullscreen):
(WebCore::MediaPlayerPrivate::platformMedia):
(WebCore::MediaPlayerPrivate::platformLayer):
(WebCore::loadBufferingImageData):
(WebCore::MediaPlayerPrivate::bufferingTimerFired):
(WebCore::MediaPlayerPrivate::setBuffering):
(WebCore::allocateTextureId):
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h: Added.
(WebKit):
(WebCore):
(MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Sun, 4 Mar 2012 15:42:54 +0000 (15:42 +0000)]
SPARC also needs aligned accesses.
Patch by Jurij Smakov <jurij@wooyd.org> on 2012-03-04
Rubber-stamped by Gustavo Noronha Silva.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sun, 4 Mar 2012 09:04:00 +0000 (09:04 +0000)]
Unreviewed build fix.
* jit/JITStubs.h:
- Move ENABLE(JIT) to head of file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sun, 4 Mar 2012 05:56:24 +0000 (05:56 +0000)]
Split JSArray's [[Put]] & [[DefineOwnProperty]] traps.
https://bugs.webkit.org/show_bug.cgi?id=80217
Reviewed by Filip Pizlo.
putByIndex() provides similar behavior to put(), but for indexed property names.
Many places in ArrayPrototype call putByIndex() where they really mean to call
[[DefineOwnProperty]]. This is only okay due to a bug – putByIndex should be
calling numeric accessors (& respecting numeric read only properties) on the
prototype chain, but isn't. Add a new putDirectIndex (matching JSObject's
putDirect* methods), to correctly provide a fast [[DefineOwnProperty]] interface.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
* runtime/JSArray.cpp:
(JSC):
(JSC::reject):
(JSC::SparseArrayValueMap::putDirect):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
* runtime/JSArray.h:
(SparseArrayValueMap):
(JSArray):
(JSC::JSArray::putDirectIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sun, 4 Mar 2012 05:04:16 +0000 (05:04 +0000)]
Remove the unused function WebCore::protocolIsInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=80218
Reviewed by Anders Carlsson.
* WebCore.order:
* platform/KURL.cpp:
* platform/KURL.h:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sun, 4 Mar 2012 03:49:19 +0000 (03:49 +0000)]
Implement the basis of KURLWTFURL
https://bugs.webkit.org/show_bug.cgi?id=79600
Reviewed by Adam Barth.
Source/JavaScriptCore:
Add an API to know if a ParsedURL is valid.
* wtf/url/api/ParsedURL.cpp:
(WTF::ParsedURL::ParsedURL):
(WTF):
(WTF::ParsedURL::isolatedCopy): This is needed by APIs moving URL objects between thread
and by KURL's detach() on write.
(WTF::ParsedURL::baseAsString):
(WTF::ParsedURL::segment):
Add a stronger constraint on accessors: the client of this API should never ask for the segments
on an invalid URL.
* wtf/url/api/ParsedURL.h:
(WTF):
(WTF::ParsedURL::ParsedURL):
(ParsedURL):
(WTF::ParsedURL::isValid):
Source/WebCore:
Add a simple, non-optimized, implementation for the main methods of KURL based
on ParsedURL.
* platform/KURLWTFURL.cpp:
(WebCore):
(WebCore::detach):
(WebCore::KURL::KURL):
(WebCore::KURL::copy):
(WebCore::KURL::isEmpty):
(WebCore::KURL::isValid):
(WebCore::KURL::string):
(WebCore::KURL::protocol):
(WebCore::KURL::host):
(WebCore::KURL::hasPort):
(WebCore::KURL::port):
(WebCore::KURL::user):
(WebCore::KURL::pass):
(WebCore::KURL::hasPath):
(WebCore::KURL::path):
(WebCore::KURL::lastPathComponent):
(WebCore::KURL::query):
(WebCore::KURL::hasFragmentIdentifier):
(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::baseAsString):
(WebCore::KURL::fileSystemPath):
(WebCore::KURL::protocolIs):
(WebCore::KURL::protocolIsInHTTPFamily):
(WebCore::KURL::setProtocol):
(WebCore::KURL::setHost):
(WebCore::KURL::removePort):
(WebCore::KURL::setPort):
(WebCore::KURL::setHostAndPort):
(WebCore::KURL::setUser):
(WebCore::KURL::setPass):
(WebCore::KURL::setPath):
(WebCore::KURL::setQuery):
(WebCore::KURL::setFragmentIdentifier):
(WebCore::KURL::removeFragmentIdentifier):
(WebCore::protocolHostAndPortAreEqual):
* platform/KURLWTFURLImpl.h:
(KURLWTFURLImpl):
(WebCore::KURLWTFURLImpl::copy):
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sun, 4 Mar 2012 03:26:27 +0000 (03:26 +0000)]
Remove the redundant method KURL::protocolInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=80216
Reviewed by Anders Carlsson.
Source/WebCore:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::addExtraFieldsToRequest):
* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::hostForURL):
(WebCore::ResourceLoadScheduler::scheduleLoad):
* loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::freshnessLifetime):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
* loader/icon/IconController.cpp:
(WebCore::IconController::defaultURL):
* platform/KURL.h:
(KURL):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
* platform/network/CredentialStorage.cpp:
(WebCore::CredentialStorage::set):
(WebCore::findDefaultProtectionSpaceForURL):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::clearHTTPReferrer):
(WebCore::ResourceRequestBase::clearHTTPOrigin):
(WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
(WebCore::ResourceRequestBase::setHTTPBody):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::ResourceRequestBase::setPriority):
(WebCore::ResourceRequestBase::addHTTPHeaderField):
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
Source/WebKit/chromium:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect):
* src/WebPageSerializer.cpp:
(WebCore::retrieveResourcesForElement):
Source/WebKit/mac:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
Source/WebKit/win:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
* WebHistory.cpp:
(WebHistory::visitedURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 4 Mar 2012 03:08:45 +0000 (03:08 +0000)]
[Qt] Fix static_libs_as_shared build
https://bugs.webkit.org/show_bug.cgi?id=80214
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-03-03
Reviewed by Tor Arne Vestbø.
Source/WebKit/qt:
Add helper function to be called by WebProcess main
to potentially initialize the QStyle theme.
* WebCoreSupport/InitWebCoreQt.cpp:
(WebKit):
(WebKit::initializeWebKit2Theme):
Source/WebKit2:
Replace (static) link time dependency to WK1 with entrypoint
in the separate WebProcess for activating the QStyle theme if
necessary.
* Target.pri:
* UIProcess/Launcher/ProcessLauncher.h:
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
* qt/MainQt.cpp:
(WebKit):
(main):
Tools:
* WebKitTestRunner/qt/main.cpp:
(main): Set the correct environment variable for choosing the theme in the
web process.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 4 Mar 2012 03:04:59 +0000 (03:04 +0000)]
[BlackBerry] Upstream LayerWebKitThread and its derived classes
https://bugs.webkit.org/show_bug.cgi?id=79871
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-03
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
* platform/graphics/blackberry/CanvasLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::setCanvas):
(WebCore::CanvasLayerWebKitThread::setNeedsDisplay):
(WebCore::CanvasLayerWebKitThread::updateTextureContentsIfNeeded):
* platform/graphics/blackberry/CanvasLayerWebKitThread.h: Added.
(WebCore):
(CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::create):
* platform/graphics/blackberry/LayerData.h: Added.
(WebCore):
(LayerData):
(WebCore::LayerData::LayerData):
(WebCore::LayerData::~LayerData):
(WebCore::LayerData::anchorPoint):
(WebCore::LayerData::anchorPointZ):
(WebCore::LayerData::backgroundColor):
(WebCore::LayerData::borderColor):
(WebCore::LayerData::borderWidth):
(WebCore::LayerData::bounds):
(WebCore::LayerData::doubleSided):
(WebCore::LayerData::frame):
(WebCore::LayerData::masksToBounds):
(WebCore::LayerData::opacity):
(WebCore::LayerData::opaque):
(WebCore::LayerData::position):
(WebCore::LayerData::sublayerTransform):
(WebCore::LayerData::transform):
(WebCore::LayerData::preserves3D):
(WebCore::LayerData::getTextureID):
(WebCore::LayerData::setTextureID):
(WebCore::LayerData::needsTexture):
(WebCore::LayerData::layerProgramShader):
(WebCore::LayerData::isFixedPosition):
(WebCore::LayerData::hasFixedContainer):
(WebCore::LayerData::hasFixedAncestorInDOMTree):
(WebCore::LayerData::pluginView):
(WebCore::LayerData::holePunchRect):
(WebCore::LayerData::hasHolePunchRect):
(WebCore::LayerData::mediaPlayer):
(WebCore::LayerData::canvas):
(WebCore::LayerData::replicate):
(WebCore::LayerData::layerType):
(WebCore::LayerData::includeVisibility):
* platform/graphics/blackberry/LayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::LayerWebKitThread::create):
(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::contentsVisible):
(WebCore::LayerWebKitThread::createFrontBufferLock):
(WebCore::LayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::LayerWebKitThread::setContents):
(WebCore::LayerWebKitThread::setDrawable):
(WebCore::LayerWebKitThread::setNeedsCommit):
(WebCore::LayerWebKitThread::notifyAnimationStarted):
(WebCore::LayerWebKitThread::commitOnWebKitThread):
(WebCore::LayerWebKitThread::startAnimations):
(WebCore::LayerWebKitThread::updateTextureContents):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore::LayerWebKitThread::addSublayer):
(WebCore::LayerWebKitThread::insertSublayer):
(WebCore::LayerWebKitThread::removeFromSuperlayer):
(WebCore::LayerWebKitThread::removeSublayer):
(WebCore::LayerWebKitThread::replaceSublayer):
(WebCore::LayerWebKitThread::indexOfSublayer):
(WebCore::LayerWebKitThread::setBounds):
(WebCore::LayerWebKitThread::setFrame):
(WebCore::LayerWebKitThread::rootLayer):
(WebCore::LayerWebKitThread::removeAllSublayers):
(WebCore::LayerWebKitThread::setSublayers):
(WebCore::LayerWebKitThread::setNeedsDisplayInRect):
(WebCore::LayerWebKitThread::setNeedsDisplay):
(WebCore::LayerWebKitThread::updateLayerHierarchy):
(WebCore::LayerWebKitThread::setIsMask):
* platform/graphics/blackberry/LayerWebKitThread.h: Added.
(WebCore):
(LayerWebKitThread):
(WebCore::LayerWebKitThread::setAnchorPoint):
(WebCore::LayerWebKitThread::setAnchorPointZ):
(WebCore::LayerWebKitThread::setBackgroundColor):
(WebCore::LayerWebKitThread::setBorderColor):
(WebCore::LayerWebKitThread::setBorderWidth):
(WebCore::LayerWebKitThread::setDoubleSided):
(WebCore::LayerWebKitThread::setMasksToBounds):
(WebCore::LayerWebKitThread::setMaskLayer):
(WebCore::LayerWebKitThread::maskLayer):
(WebCore::LayerWebKitThread::setReplicaLayer):
(WebCore::LayerWebKitThread::replicaLayer):
(WebCore::LayerWebKitThread::setNeedsDisplayOnBoundsChange):
(WebCore::LayerWebKitThread::setOpacity):
(WebCore::LayerWebKitThread::setOpaque):
(WebCore::LayerWebKitThread::setPosition):
(WebCore::LayerWebKitThread::getSublayers):
(WebCore::LayerWebKitThread::setSublayerTransform):
(WebCore::LayerWebKitThread::superlayer):
(WebCore::LayerWebKitThread::setTransform):
(WebCore::LayerWebKitThread::setPreserves3D):
(WebCore::LayerWebKitThread::setFixedPosition):
(WebCore::LayerWebKitThread::setHasFixedContainer):
(WebCore::LayerWebKitThread::setHasFixedAncestorInDOMTree):
(WebCore::LayerWebKitThread::contents):
(WebCore::LayerWebKitThread::setOwner):
(WebCore::LayerWebKitThread::drawsContent):
(WebCore::LayerWebKitThread::layerCompositingThread):
(WebCore::LayerWebKitThread::setAbsoluteOffset):
(WebCore::LayerWebKitThread::contentsScale):
(WebCore::LayerWebKitThread::setRunningAnimations):
(WebCore::LayerWebKitThread::setSuspendedAnimations):
(WebCore::LayerWebKitThread::setNeedsTexture):
(WebCore::LayerWebKitThread::setLayerProgramShader):
(WebCore::LayerWebKitThread::isDrawable):
(WebCore::LayerWebKitThread::boundsChanged):
(WebCore::LayerWebKitThread::setSuperlayer):
(WebCore::LayerWebKitThread::numSublayers):
* platform/graphics/blackberry/PluginLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::PluginLayerWebKitThread::PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::~PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::setPluginView):
(WebCore::PluginLayerWebKitThread::setHolePunchRect):
(WebCore::PluginLayerWebKitThread::setNeedsDisplay):
(WebCore::PluginLayerWebKitThread::updateTextureContentsIfNeeded):
* platform/graphics/blackberry/PluginLayerWebKitThread.h: Added.
(WebCore):
(PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::create):
* platform/graphics/blackberry/VideoLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::VideoLayerWebKitThread::VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::~VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::setMediaPlayer):
(WebCore::VideoLayerWebKitThread::setHolePunchRect):
(WebCore::VideoLayerWebKitThread::setNeedsDisplay):
(WebCore::VideoLayerWebKitThread::boundsChanged):
(WebCore::VideoLayerWebKitThread::updateTextureContentsIfNeeded):
* platform/graphics/blackberry/VideoLayerWebKitThread.h: Added.
(WebCore):
(VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Sun, 4 Mar 2012 01:06:09 +0000 (01:06 +0000)]
Implement Speech JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=80019
Reviewed by Adam Barth.
.:
Add ENABLE_SCRIPTED_SPEECH.
* configure.ac:
Source/JavaScriptCore:
Add ENABLE_SCRIPTED_SPEECH.
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Add ENABLE_SCRIPTED_SPEECH and runtime flag.
No functionality yet, so no new tests.
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* Target.pri:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setScriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::scriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarListEnabled):
Source/WebKit/chromium:
Add ENABLE_SCRIPTED_SPEECH and runtime flag.
* features.gypi:
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableScriptedSpeech):
(WebKit):
(WebKit::WebRuntimeFeatures::isScriptedSpeechEnabled):
Source/WebKit/mac:
Add ENABLE_SCRIPTED_SPEECH.
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Add ENABLE_SCRIPTED_SPEECH.
* Configurations/FeatureDefines.xcconfig:
Tools:
Add ENABLE_SCRIPTED_SPEECH.
* Scripts/build-webkit:
* qmake/mkspecs/features/features.prf:
WebKitLibraries:
Add ENABLE_SCRIPTED_SPEECH.
* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 3 Mar 2012 22:48:55 +0000 (22:48 +0000)]
DelayNode has a fixed one second max delay time
https://bugs.webkit.org/show_bug.cgi?id=78758
Source/WebCore:
Change DelayNode to accept an optional parameter to specify the
maximum delay allowed. If not specified, the default is 1 sec.
Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
Reviewed by Chris Rogers.
Test: webaudio/delaynode-maxdelay.html
webaudio/delaynode-maxdelay-expected.txt
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createDelayNode): Allow maxDelayTime
parameter to specify max delay.
* webaudio/AudioContext.h: Allow maxDelayTime
parameter to specify max delay but default to 1.
(AudioContext):
* webaudio/AudioContext.idl: createDelayNode takes optional max
delay time parameter.
* webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::DelayDSPKernel): Remove unused
DefaultMaxDelayTime. Set m_maxDelayTime from processor
maxDelayTime.
* webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode): Add maxDelayTime parameter.
* webaudio/DelayNode.h:
(WebCore::DelayNode::create): Add maxDelayTime parameter.
(DelayNode): Add maxDelayTime parameter.
* webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::DelayProcessor): Add maxDelayTime
parameter.
* webaudio/DelayProcessor.h:
(DelayProcessor): Add maxDelayTime parameter.
(WebCore::DelayProcessor::maxDelayTime): New slot to hold
maxDelayTime.
LayoutTests:
Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
Reviewed by Chris Rogers.
* webaudio/resources/delay-testing.js: Added more informative
messages.
* webaudio/delaynode-expected.txt: Updated result for more
informative messages
* webaudio/delaynode-scheduling-expected.txt: Updated result for
more informative messages.
* webaudio/delaynode-maxdelay-expected.txt: Added
* webaudio/delaynode-maxdelay.html: Added
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 3 Mar 2012 22:30:23 +0000 (22:30 +0000)]
Simplified discreteTimeConstantForSampleRate
https://bugs.webkit.org/show_bug.cgi?id=78051
Remove hardcoded constant and simplify computation of discrete
time constant.
Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
Reviewed by Chris Rogers.
No new tests needed. Covered by existing AudioParam tests.
* platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
Simplify formula.
* platform/audio/AudioUtilities.h:
(AudioUtilities): Update function signature.
* platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
cast to float to avoid warnings.
* webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): cast to
float to avoid warnings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Sat, 3 Mar 2012 19:26:39 +0000 (19:26 +0000)]
[Qt] Use the existing inheritedOpacity/matrix properties of QSGNode
https://bugs.webkit.org/show_bug.cgi?id=79543
Use QSGNode::inheritedOpacity() and QSGNode::matrix().
Also, remove flags from changedStates() that we don't actually touch.
This is covered by existing API tests.
Reviewed by Kenneth Rohde Christiansen.
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::changedStates):
(PageProxyNode::render):
* UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 3 Mar 2012 19:13:56 +0000 (19:13 +0000)]
Fix build with newer versions of clang.
Source/WebCore:
* bindings/objc/DOM.mm:
(-[DOMNode description]):
Remove an unused parameter.
* bridge/objc/objc_instance.mm:
(ObjcInstance::getClass):
Use object_getClass instead of accessing isa directly.
* platform/LocalizedStrings.cpp:
(WebCore::formatLocalizedString):
Disable the -Wformat-nonliteral warning around the call to CFStringCreateWithFormatAndArguments.
* platform/graphics/mac/WebLayer.mm:
(-[CALayer _descriptionWithPrefix:]):
Use %p for the CALayer pointer, and use %lu for the number of sublayers.
* platform/mac/HTMLConverter.mm:
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
Cast the NSAttachmentCharacte enum to unichar.
Source/WebKit/mac:
* Panels/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForChallenge:]):
Use %ld and cast to long.
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView getVariable:value:]):
Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.
Source/WebKit2:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 3 Mar 2012 18:55:49 +0000 (18:55 +0000)]
Biquad getFrequencyResponse needs a layout test.
https://bugs.webkit.org/show_bug.cgi?id=79503
Add simple test for getFrequencyResponse.
Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
Reviewed by Chris Rogers.
* webaudio/biquad-getFrequencyResponse-expected.txt: Added.
* webaudio/biquad-getFrequencyResponse.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bbudge@chromium.org [Sat, 3 Mar 2012 18:49:50 +0000 (18:49 +0000)]
Fixes AssociatedURLLoader support for Access-Control-Expose-Headers field in response.
https://bugs.webkit.org/show_bug.cgi?id=80198
Reviewed by Adam Barth.
* src/AssociatedURLLoader.cpp:
* tests/AssociatedURLLoaderTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 3 Mar 2012 12:34:40 +0000 (12:34 +0000)]
Unreviewed, rolling out r109343.
http://trac.webkit.org/changeset/109343
https://bugs.webkit.org/show_bug.cgi?id=80212
Int32array can't handle values for native nodes because they
have int64 ids (Requested by loislo1 on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-03
Source/WebCore:
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
LayoutTests:
* inspector/profiler/heap-snapshot-loader.html:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Sat, 3 Mar 2012 09:16:57 +0000 (09:16 +0000)]
Unreviewed, GTK tests_expectations update.
* platform/gtk/Skipped:
* platform/gtk/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 3 Mar 2012 09:12:21 +0000 (09:12 +0000)]
Free up a bit in RenderObject.
http://webkit.org/b/80208
Patch by Andreas Kling <awesomekling@apple.com> on 2012-03-03
Reviewed by Anders Carlsson.
Move m_hasMarkupTruncation to RenderBlock, stealing one bit from m_lineHeight.
This flag is only used by RenderBlock.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::setHasMarkupTruncation):
(WebCore::RenderBlock::hasMarkupTruncation):
(RenderBlock):
* rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Sat, 3 Mar 2012 09:09:54 +0000 (09:09 +0000)]
Unreviewed, rebaseline after r109623.
* editing/selection/select-line-break-with-opposite-directionality-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 3 Mar 2012 08:35:36 +0000 (08:35 +0000)]
Implement vw/vh/vmin (viewport sizes) from CSS 3 Values and Units
https://bugs.webkit.org/show_bug.cgi?id=27160
The specification related to this implementation is located at http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths.
vw/vh/vmin are implemented as primitive length units. Added the parsing logic for these new units and creation of primitive values.
Added new Length types such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin for viewport-relative lengths
and included the support for fetching the value of these relative length units based on the current viewport size.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-03
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html
* css/CSSComputedStyleDeclaration.cpp: Modified to support viewport relative Length types.
(WebCore::getPositionOffsetValue): Ditto.
(WebCore::getBorderRadiusCornerValues): Ditto.
(WebCore::getBorderRadiusCornerValue): Ditto.
(WebCore::getBorderRadiusShorthandValue): Ditto.
(WebCore::lineHeightFromStyle): Ditto.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
* css/CSSGrammar.y: Added vw/vh/vmin support.
* css/CSSParser.cpp: Parsing of relative units and creation of CSSPrimitiveValue.
(WebCore::CSSParser::validUnit): Added vw/vh/vmin to the valid units.
(WebCore::CSSParser::createPrimitiveNumericValue): Added vw/vh/vmin as valid primitive units.
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive): Creation of CSSPrimitiveValue for vw/vh/vmin.
(WebCore::CSSParser::detectNumberToken): Parsing the vw/vh/vmin tokens.
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion): Added support for vw/vh/vmin.
(WebCore::unitCategory): Ditto.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): Added support for vw/vh/vmin.
(WebCore::CSSPrimitiveValue::customCssText): Ditto.
(WebCore::CSSPrimitiveValue::viewportRelativeLength): Function to create the Length structure for the viewport-relative unit types.
(WebCore):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportRelativeLength): Checks whether the primitive value is ViewportRelative Lengths.
(CSSPrimitiveValue):
* css/CSSPrimitiveValue.idl: Added support for vw/vh/vmin.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue): Applying relative viewport length units to the specific CSS property.
(WebCore::ApplyPropertyBorderRadius::applyValue): Ditto.
(WebCore::ApplyPropertyFontSize::applyValue): Ditto.
(WebCore::ApplyPropertyLineHeight::applyValue): Ditto.
(WebCore::ApplyPropertyVerticalAlign::applyValue): Ditto.
* css/CSSStyleSelector.cpp:
(WebCore::convertToLength): Added support for viewport relative units.
(WebCore::createGridTrackBreadth): Ditto.
(WebCore::CSSStyleSelector::mapFillSize): Ditto.
(WebCore::CSSStyleSelector::mapFillXPosition): Ditto.
(WebCore::CSSStyleSelector::mapFillYPosition): Ditto.
* dom/Document.cpp:
(WebCore::Document::pageSizeAndMarginsInPixels): Modified to support viewport relative Length types.
(WebCore::Document::viewportSize): New function to fetch the current viewport size.
(WebCore):
* dom/Document.h: Ditto.
(Document):
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getRegion): Modified to support viewport relative Length types.
* platform/Length.h: New LengthTypes such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin added.
(WebCore::Length::calcValue): Modified to support viewport relative Length types.
(WebCore::Length::calcMinValue): Ditto.
(WebCore::Length::calcFloatValue): Ditto.
(Length):
(WebCore::Length::isViewportRelative): To check the Length is of type ViewportRelative.
(WebCore::Length::viewportRelativeLength): To get the relative value.
* rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight): Modified to support viewport relative Length types.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight): Ditto.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::reflectionOffset): Ditto.
(WebCore::RenderBox::paintBoxDecorations): Ditto.
(WebCore::RenderBox::clipRect): Ditto.
(WebCore::RenderBox::computeLogicalWidthInRegion): Ditto.
(WebCore::RenderBox::computeLogicalWidthInRegionUsing): Ditto.
(WebCore::RenderBox::computeInlineDirectionMargins): Ditto.
(WebCore::RenderBox::computeLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computePercentageLogicalHeight): Ditto.
(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computeBlockDirectionMargins): Ditto.
(WebCore::RenderBox::computePositionedLogicalWidthUsing): Ditto.
(WebCore::RenderBox::computePositionedLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Ditto.
(WebCore::RenderBox::computePositionedLogicalHeightReplaced): Ditto.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX): Ditto.
(WebCore::RenderBoxModelObject::relativePositionOffsetY): Ditto.
(WebCore::RenderBoxModelObject::paddingTop): Ditto.
(WebCore::RenderBoxModelObject::paddingBottom): Ditto.
(WebCore::RenderBoxModelObject::paddingLeft): Ditto.
(WebCore::RenderBoxModelObject::paddingRight): Ditto.
(WebCore::RenderBoxModelObject::paddingBefore): Ditto.
(WebCore::RenderBoxModelObject::paddingAfter): Ditto.
(WebCore::RenderBoxModelObject::paddingStart): Ditto.
(WebCore::RenderBoxModelObject::paddingEnd): Ditto.
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect): Ditto.
(WebCore::RenderBoxModelObject::calculateFillTileSize): Ditto.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Ditto.
(WebCore::computeBorderImageSide): Ditto.
(WebCore::RenderBoxModelObject::paintNinePieceImage): Ditto.
(WebCore::RenderBoxModelObject::paintBorder): Ditto.
(WebCore::RenderBoxModelObject::paintBoxShadow): Ditto.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Ditto.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Ditto.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Ditto.
* rendering/RenderInline.cpp:
(WebCore::computeMargin): Ditto.
(WebCore::RenderInline::lineHeight): Ditto.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth): Ditto.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded): Ditto.
* rendering/RenderObject.h:
(WebCore::RenderObject::viewportSize): New function to fetch the current viewport size.
(RenderObject):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint): Modified to support viewport relative Length types.
* rendering/RenderScrollbarPart.cpp:
(WebCore::calcScrollbarThicknessUsing): Ditto.
(WebCore::RenderScrollbarPart::computeScrollbarWidth): Ditto.
(WebCore::RenderScrollbarPart::computeScrollbarHeight): Ditto.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth): Ditto.
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth): Ditto.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::logicalHeightForRowSizing): Ditto.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight): Ditto.
* rendering/RenderText.h:
(WebCore::RenderText::marginLeft): Ditto.
(WebCore::RenderText::marginRight): Ditto.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients): Ditto.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint): Ditto.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox): Ditto.
* rendering/style/RenderStyle.cpp:
(WebCore::calcRadiiFor): Ditto.
(WebCore::RenderStyle::getRoundedBorderFor): Ditto.
* rendering/style/RenderStyle.h: Ditto.
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::resolveLengthAttributeForSVG): Ditto.
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Ditto.
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
LayoutTests:
* css3/viewport-relative-lengths: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Added.
* css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Added.
* fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/win/fast/dom/Window/window-properties-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 3 Mar 2012 07:43:53 +0000 (07:43 +0000)]
[Qt] Unreviewed gardening, skip a new crashing test.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 3 Mar 2012 07:34:34 +0000 (07:34 +0000)]
[Qt] Unreviewed gardening, updated expected files.
* platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.png: Added.
* platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.txt: Added.
* platform/qt/fast/dom/prototype-inheritance-2-expected.png:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 3 Mar 2012 05:48:54 +0000 (05:48 +0000)]
Editor's default paragraph separator is not reset when a frame's document is changed
https://bugs.webkit.org/show_bug.cgi?id=80065
Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: editing/execCommand/reset-values-after-navigation.html
* editing/Editor.cpp:
(WebCore::Editor::clear):
LayoutTests:
* editing/execCommand/default-paragraph-separator.html: Last line of the test did a manual reset of the value to work around this problem. Removed.
* editing/execCommand/reset-values-after-navigation-expected.txt: Added.
* editing/execCommand/reset-values-after-navigation.html: Added.
* editing/execCommand/resources/reset-default-values-helper-1.html: Added.
* editing/execCommand/resources/reset-default-values-helper-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sat, 3 Mar 2012 05:31:13 +0000 (05:31 +0000)]
Have a copy of plug-in sandboxing API header in WebCore
https://bugs.webkit.org/show_bug.cgi?id=80185
<rdar://problem/
8242128>
Reviewed by Anders Carlsson.
* plugins/npapi-sandbox.h: Added.
* WebCore.xcodeproj/project.pbxproj: Added as unused file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Sat, 3 Mar 2012 03:28:41 +0000 (03:28 +0000)]
:empty should apply to elements made empty via page dynamics
https://bugs.webkit.org/show_bug.cgi?id=79734
Reviewed by Antonio Gomes.
* fast/css/pseudo-empty-dynamic-empty-expected.txt: Added.
* fast/css/pseudo-empty-dynamic-empty.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sat, 3 Mar 2012 03:18:34 +0000 (03:18 +0000)]
Fix commit queue, remove duplicate entry.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 3 Mar 2012 02:41:36 +0000 (02:41 +0000)]
[BlackBerry] Expose WebInspector state to client and clean up WebSettings
https://bugs.webkit.org/show_bug.cgi?id=80177
Patch by Mike Fenton <mifenton@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Expose the Web Inspector state to WebPage client's and
re-order initialization of WebSettings to be alphabetical
matching their definitions.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::isWebInspectorEnabled):
* Api/WebPage.h:
* Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc