WebKit-https.git
8 years ago[EFL] fast/forms/input-text-scroll-left-on-blur.html is passing now
commit-queue@webkit.org [Fri, 15 Feb 2013 09:02:22 +0000 (09:02 +0000)]
[EFL] fast/forms/input-text-scroll-left-on-blur.html is passing now
https://bugs.webkit.org/show_bug.cgi?id=109896

Unreviewed efl gardening.

The expectations are added by r140250 and the test seems to be passing now.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-15

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChangeLog fix for bug 109689.
zherczeg@webkit.org [Fri, 15 Feb 2013 09:00:51 +0000 (09:00 +0000)]
ChangeLog fix for bug 109689.
https://bugs.webkit.org/show_bug.cgi?id=109689

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: always show memory size in Mb on the native memory graph
yurys@chromium.org [Fri, 15 Feb 2013 07:45:16 +0000 (07:45 +0000)]
Web Inspector: always show memory size in Mb on the native memory graph
https://bugs.webkit.org/show_bug.cgi?id=109813

Reviewed by Pavel Feldman.

Memory size vlue is alway shown in Mb on the native memory graph.

* inspector/front-end/NativeMemoryGraph.js:
(WebInspector.NativeMemoryCounterUI.prototype.updateCurrentValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Rename from scrollOffset to scrollDelta in WebChromeClient.
commit-queue@webkit.org [Fri, 15 Feb 2013 07:15:01 +0000 (07:15 +0000)]
[WK2] Rename from scrollOffset to scrollDelta in WebChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=109885

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-14
Reviewed by Simon Fraser.

Chrome sends a scroll delta to WebChromeClient but WebChromeClient names it
scrollOffset. So this patch corrects this misnaming.

In addition, all subclasses of LayerTreeHost don't use the misnamed
scrollOffset in scrollNonCompositedContents(), so this patch removes the
scrollOffset argument.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scroll):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
* WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scroll):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
* WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::scrollNonCompositedContents):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
* WebProcess/WebPage/mac/LayerTreeHostMac.h:
(LayerTreeHostMac):
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::scrollNonCompositedContents):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(RemoteLayerTreeDrawingArea):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::scroll):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse GL typedefs in WebGLRenderingContext.idl
aandrey@chromium.org [Fri, 15 Feb 2013 07:01:31 +0000 (07:01 +0000)]
Use GL typedefs in WebGLRenderingContext.idl
https://bugs.webkit.org/show_bug.cgi?id=109060

Reviewed by Kenneth Russell.

Use GL typedefs in WebGLRenderingContext.idl according to the specs.
Added a FIXME about inconsistency with the current WebGL spec for getAttribLocation.

Tested manually that generators V8, JS, ObjC, GObject, CPP produce same output.

* html/canvas/WebGLRenderingContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMerged the global function cache into the source code cache
ggaren@apple.com [Fri, 15 Feb 2013 06:41:10 +0000 (06:41 +0000)]
Merged the global function cache into the source code cache
https://bugs.webkit.org/show_bug.cgi?id=108660

Reviewed by Sam Weinig.

This has a few benefits:

    (*) Saves a few kB by removing a second cache data structure.

    (*) Reduces the worst case memory usage of the cache by 1.75X. (Heavy
    use of 'new Function' and other techniques could cause us to fill
    both root caches, and they didn't trade off against each other.)

    (*) Paves the way for future improvements based on a non-trivial
    cache key (for example, shrinkable pointer to the key string, and
    more precise cache size accounting).

Also cleaned up the cache implementation and simplified it a bit.

* heap/Handle.h:
(HandleBase):
* heap/Strong.h:
(Strong): Build!

* runtime/CodeCache.cpp:
(JSC):
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode): Updated for three interface changes:

    (*) SourceCodeKey is a class, not a pair.

    (*) Table values are abstract pointers, since they can be executables
    or code blocks. (In a future patch, I'd like to change this so we
    always store only code blocks. But that's too much for one patch.)

    (*) The cache function is named "set" because it always overwrites
    unconditionally.

* runtime/CodeCache.h:
(CacheMap):
(JSC::CacheMap::find):
(JSC::CacheMap::set):
(JSC::CacheMap::clear): Added support for specifying hash traits, so we
can use a SourceCodeKey.

Removed side table and random number generator to save space and reduce
complexity. Hash tables are already random, so we don't need another source
of randomness.

(SourceCodeKey):
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(JSC::SourceCodeKeyHash::hash):
(JSC::SourceCodeKeyHash::equal):
(SourceCodeKeyHash):
(SourceCodeKeyHashTraits):
(JSC::SourceCodeKeyHashTraits::isEmptyValue): A SourceCodeKey is just a
fancy triplet: source code string; function name (or null, for non-functions);
and flags. Flags and function name distinguish between functions and programs
with identical code, so they can live in the same cache.

I chose to use the source code string as the primary hashing reference
because it's likely to be unique. We can use profiling to choose another
technique in future, if collisions between functions and programs prove
to be hot. I suspect they won't.

(JSC::CodeCache::clear):
(CodeCache): Removed the second cache.

* heap/Handle.h:
(HandleBase):
* heap/Strong.h:
(Strong):
* runtime/CodeCache.cpp:
(JSC):
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode):
* runtime/CodeCache.h:
(JSC):
(CacheMap):
(JSC::CacheMap::find):
(JSC::CacheMap::set):
(JSC::CacheMap::clear):
(SourceCodeKey):
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(JSC::SourceCodeKeyHash::hash):
(JSC::SourceCodeKeyHash::equal):
(SourceCodeKeyHash):
(SourceCodeKeyHashTraits):
(JSC::SourceCodeKeyHashTraits::isEmptyValue):
(JSC::CodeCache::clear):
(CodeCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Copy-pasting selected text over itself should be an undoable state.
vsevik@chromium.org [Fri, 15 Feb 2013 06:39:03 +0000 (06:39 +0000)]
Web Inspector: Copy-pasting selected text over itself should be an undoable state.
https://bugs.webkit.org/show_bug.cgi?id=109830

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):

LayoutTests:

* inspector/editor/text-editor-undo-redo-expected.txt:
* inspector/editor/text-editor-undo-redo.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove a test expectation now that the culprit has been rolled out in r142962.
rniwa@webkit.org [Fri, 15 Feb 2013 06:33:14 +0000 (06:33 +0000)]
Remove a test expectation now that the culprit has been rolled out in r142962.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium test fix: incorrect field was used for UISourceCode url.
vsevik@chromium.org [Fri, 15 Feb 2013 06:29:40 +0000 (06:29 +0000)]
Unreviewed chromium test fix: incorrect field was used for UISourceCode url.

* src/js/Tests.js:
(.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
(.TestSuite.prototype.uiSourceCodesToString_):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r142889.
commit-queue@webkit.org [Fri, 15 Feb 2013 06:26:36 +0000 (06:26 +0000)]
Unreviewed, rolling out r142889.
http://trac.webkit.org/changeset/142889
https://bugs.webkit.org/show_bug.cgi?id=109891

It caused an assertion failure in scrollbars/overflow-
scrollbar-combinations.html (Requested by tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::borderWidthChanged):
(WebCore::RenderBox::styleDidChange):

LayoutTests:

* fast/block/dynamic-padding-border-expected.txt: Removed.
* fast/block/dynamic-padding-border.html: Removed.
* fast/table/border-collapsing/cached-change-row-border-width-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd assertion failure expectations on Mac per bugs 109869 and 109890.
rniwa@webkit.org [Fri, 15 Feb 2013 06:21:16 +0000 (06:21 +0000)]
Add assertion failure expectations on Mac per bugs 109869 and 109890.

* platform/mac/TestExpectations:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCaret positioned at the end of a text line (followed by an empty block) in vertical...
commit-queue@webkit.org [Fri, 15 Feb 2013 05:59:02 +0000 (05:59 +0000)]
Caret positioned at the end of a text line (followed by an empty block) in vertical writing mode disappears when pressing the right/down arrow key.
https://bugs.webkit.org/show_bug.cgi?id=106452

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2013-02-14
Reviewed by Ryosuke Niwa.

Source/WebCore:

Pressing the down or the right arrow key at the end of a text line in
vertical writing mode would make the caret dissapear. This occurs only
when the text line is followed by an empty block.

When trying to compute the next position for placing the caret (for
down/right key), we try to ascertain whether the renderer (in this
case the empty block) is a valid candidate or not. For blockFlow
elements we check against their height.
In vertical writing mode though we would fail such a check since we
should instead be comparing against the renderer's width and not
it's height. Thus, a valid position for the placement of the caret
was not found in such a case.

Test: editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html

* dom/Position.cpp:
(WebCore::Position::isCandidate):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
Instead of checking against the height(), check against the
logicalHeight() of the renderer has been added. logicalHeight()
on blockFlow renderer's returns a value in accordance with
the writing mode.

LayoutTests:

* editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode-expected.txt: Added.
* editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html: Added.
Layout test case added for verifying that pressing the down or the right arrow
key at the end of the text line in vertical writing mode will not make the caret
dissapear.
Caret positions at the start, the end, and after pressing the right and the down
arrow keys at the end of the text line, are compared for verification.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix after r142957.
rniwa@webkit.org [Fri, 15 Feb 2013 05:55:36 +0000 (05:55 +0000)]
Windows build fix after r142957.

* dom/DOMAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a typo introduced in r142705.
rniwa@webkit.org [Fri, 15 Feb 2013 05:47:52 +0000 (05:47 +0000)]
Fix a typo introduced in r142705.

Without this fix, text-input-controller.html can fail when DeleteButtonController is enabled.
e.g. "run-webkit-tests platform/mac/editing/deleting/deletionUI-single-instance.html
    platform/mac/editing/input/text-input-controller.html --child-processes=1"

* editing/Editor.cpp:
(WebCore::Editor::avoidIntersectionWithDeleteButtonController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFactor Event retargeting code.
hayato@chromium.org [Fri, 15 Feb 2013 04:38:39 +0000 (04:38 +0000)]
Factor Event retargeting code.
https://bugs.webkit.org/show_bug.cgi?id=109156

Reviewed by Dimitri Glazkov.

To supoort Touch event retargeting (bug 107800), we have to factor
event retargeting code so that it can support not only MouseEvent,
but also other events.

New class, EventRetargeter, was introduced. From now,
EventDispatchMediator (and its subclasses) should call, if event
retargeting is required, an appropriate function provided in
EventRetargeter rather than calling
EventDispatcher::adjustRelatedTarget(), which was removed in this
patch.

No tests. No change in behavior.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/EventDispatchMediator.cpp:
* dom/EventDispatcher.cpp:
(WebCore):
(WebCore::EventDispatcher::ensureEventPath): Changed to return an EventPath, which will be used by EventRetargeter.
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchEventPostProcess):
* dom/EventDispatcher.h:
(WebCore):
(EventDispatcher):
* dom/EventRetargeter.cpp: Added.
(WebCore):
(WebCore::inTheSameScope):
(WebCore::determineDispatchBehavior):
(WebCore::EventRetargeter::calculateEventPath): Factored out from EventDispatcher::ensureEventPath().
(WebCore::EventRetargeter::adjustForMouseEvent):
(WebCore::EventRetargeter::adjustForFocusEvent):
(WebCore::EventRetargeter::adjustForRelatedTarget):
(WebCore::EventRetargeter::calculateAdjustedNodes): Factored out from EventRelatedTargetAjuster::adjustRelatedTarget().
(WebCore::EventRetargeter::buildRelatedNodeMap): Factored out from EventRelatedTargetAjuster::adjustRelatedTarget().
(WebCore::EventRetargeter::findRelatedNode):
* dom/EventRetargeter.h: Added.
(WebCore):
(EventRetargeter):
(WebCore::EventRetargeter::eventTargetRespectingTargetRules):
* dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent): Changed to call EventRetargeter::adjustForFocusEvent().
(WebCore::BlurEventDispatchMediator::dispatchEvent): Ditto.
(WebCore::FocusInEventDispatchMediator::dispatchEvent): Ditto.
(WebCore::FocusOutEventDispatchMediator::dispatchEvent): Ditto.
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent): Changed to call EventRetargeter::adjustForMouseEvent().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReverting r142861. Hit testing inside of style recalc is fundamentally wrong
simon.fraser@apple.com [Fri, 15 Feb 2013 04:28:45 +0000 (04:28 +0000)]
Reverting r142861. Hit testing inside of style recalc is fundamentally wrong

Source/WebCore:

* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseMoveEvent):
* page/EventHandler.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
(WebCore::areNonIdenticalCursorListsEqual):
(WebCore::areCursorsEqual):
(WebCore::RenderObject::styleDidChange):

LayoutTests:

* fast/events/mouse-cursor-change-expected.txt: Removed.
* fast/events/mouse-cursor-change.html: Removed.
* fast/events/mouse-cursor-no-mousemove-expected.txt: Removed.
* fast/events/mouse-cursor-no-mousemove.html: Removed.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[SVG] Cached filter results are not invalidated on repaint rect change
fmalita@chromium.org [Fri, 15 Feb 2013 03:58:18 +0000 (03:58 +0000)]
[SVG] Cached filter results are not invalidated on repaint rect change
https://bugs.webkit.org/show_bug.cgi?id=106221

Reviewed by Dean Jackson.

Source/WebCore:

Since the cached filter results are not invalidated for different repaint rects, we need
to render the content of the whole filter region upfront (otherwise elements not visible
during the initial paint due to scrolling/window size/etc. are never redrawn).

Tests: svg/filters/filter-hidden-content-expected.svg
       svg/filters/filter-hidden-content.svg

* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::drawingRegion):
(WebCore):
* rendering/svg/RenderSVGResourceFilter.h:
(FilterData):
(RenderSVGResourceFilter):
Track the filter drawing region in FilterData.

* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
* rendering/svg/SVGRenderingContext.h:
Update paintInfo.rect to cover the whole drawing region while rendering filter content, and
restore it when done.

LayoutTests:

* svg/filters/filter-hidden-content-expected.svg: Added.
* svg/filters/filter-hidden-content.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Some final touch-ups to the VS2010 WebKit solution before nuking the...
roger_fong@apple.com [Fri, 15 Feb 2013 03:57:57 +0000 (03:57 +0000)]
Unreviewed. Some final touch-ups to the VS2010 WebKit solution before nuking the VS2005 solution.
Remove un-needed include directories and force includes.
Update exports file.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
* WebKit.vcxproj/common.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
* WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
* win/record-memory/record-memoryCommon.props:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
* JavaScriptCore.vcxproj/jsc/jscCommon.props:
* JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
* JavaScriptCore.vcxproj/testapi/testapi.vcxproj:
* WTF.vcxproj/WTFCommon.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaselining following r142940.
morrita@google.com [Fri, 15 Feb 2013 03:07:49 +0000 (03:07 +0000)]
Unreviewed rebaselining following r142940.

* fast/events/onerror-no-constructor-expected.txt:
* platform/chromium/fast/events/onerror-no-constructor-expected.txt: Copied from LayoutTests/fast/events/onerror-no-constructor-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Correct the mismatched cursor map
commit-queue@webkit.org [Fri, 15 Feb 2013 02:38:02 +0000 (02:38 +0000)]
[EFL] Correct the mismatched cursor map
https://bugs.webkit.org/show_bug.cgi?id=109655

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-02-14
Reviewed by Laszlo Gombos.

Correct the mismatched ECORE_X_CURSOR values in the cursor map.

* platform/efl/EflScreenUtilities.cpp:
(WebCore::CursorMap::CursorMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaselined run-bindings-tests.
haraken@chromium.org [Fri, 15 Feb 2013 02:07:25 +0000 (02:07 +0000)]
Unreviewed. Rebaselined run-bindings-tests.

* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::anyAttribute):
(WebDOMTestObj::setAnyAttribute):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_any_attribute):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClamp):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::funcWithClampCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoadding myself as a committer
kareng@chromium.org [Fri, 15 Feb 2013 02:02:18 +0000 (02:02 +0000)]
adding myself as a committer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoadding myself as a committer
kareng@chromium.org [Fri, 15 Feb 2013 02:00:50 +0000 (02:00 +0000)]
adding myself as a committer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCommented out code meant to be deleted.
roger_fong@apple.com [Fri, 15 Feb 2013 01:42:21 +0000 (01:42 +0000)]
Commented out code meant to be deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert media controls from DeprecatedFlexibleBox to FlexibleBox
commit-queue@webkit.org [Fri, 15 Feb 2013 01:39:18 +0000 (01:39 +0000)]
Convert media controls from DeprecatedFlexibleBox to FlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=109775

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-14
Reviewed by Ojan Vafai.

Source/WebCore:

Covered by existing tests in media/.

* css/mediaControls.css:
* css/mediaControlsBlackBerry.css:
* css/mediaControlsChromium.css:
* css/mediaControlsChromiumAndroid.css:
* css/mediaControlsEfl.css:
* css/mediaControlsGtk.css:
* css/mediaControlsQt.css:
* css/mediaControlsQuickTime.css:
Automated search and replace of old flexbox CSS rules to new ones.
Minor tuning of the chromium rules.

* rendering/RenderMediaControlElements.cpp:
(WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
(WebCore::RenderMediaControlTimeDisplay::layout):
* rendering/RenderMediaControlElements.h:
Make media controls inherit from RenderFlexibleBox

LayoutTests:

Rebaselined lots of tests. There were two kinds of changes:
- Replaced the RenderDeprecatedFlexibleBox class name with
RenderFlexibleBox, and minor printing differences
- Slight positioning/size changes due to a different algorithm for
shrinking elements (old flexbox shrinks elements evenly, new flexbox
shrinks in proportion to the size of the flex item)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix for Windows.
roger_fong@apple.com [Fri, 15 Feb 2013 01:28:57 +0000 (01:28 +0000)]
Build fix for Windows.

* Modules/webdatabase/SQLTransactionStateMachine.cpp:
(WebCore::nameForSQLTransactionState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac rebaseline after r142931.
rniwa@webkit.org [Fri, 15 Feb 2013 01:23:50 +0000 (01:23 +0000)]
Mac rebaseline after r142931.

* platform/chromium-mac/fast/replaced/width100percent-image-expected.txt: Added.
* platform/chromium/fast/replaced/width100percent-image-expected.txt: Removed.
* platform/mac/fast/replaced/width100percent-image-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInspector doesn't show rules from pluginsStyleSheet
dino@apple.com [Fri, 15 Feb 2013 01:19:55 +0000 (01:19 +0000)]
Inspector doesn't show rules from pluginsStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=109872

Reviewed by Darin Adler.

Make sure getWrapperForRuleInSheets collects the rules
from CSSDefaultStyleSheets::plugInsStyleSheet.

Making a test for this is difficult because the rules in
this sheet only apply to snapshotted plugins at the moment,
which are disabled in DRT, and would require a fairly long
timeout in the test.

* css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClicking outside captions menu should dismiss it
dino@apple.com [Fri, 15 Feb 2013 01:19:33 +0000 (01:19 +0000)]
Clicking outside captions menu should dismiss it
https://bugs.webkit.org/show_bug.cgi?id=109648

Unreviewed. Adding the files I forgot to commit in r142774.

* media/video-controls-captions-trackmenu-hide-on-click.html: Added.
* platform/mac/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRecover edge names used in MemoryInstrumentation for DocumentRuleSets.
hayato@chromium.org [Fri, 15 Feb 2013 01:01:34 +0000 (01:01 +0000)]
Recover edge names used in MemoryInstrumentation for DocumentRuleSets.
https://bugs.webkit.org/show_bug.cgi?id=109800

Reviewed by Hajime Morita.

This is a following patch for r142573.
r142563 accidentally removes edge names for MemoryInstrumentation. We should recover edge names.

No tests. No change in behavior.

* css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonew-run-webkit-tests needs a shared TestExpectations between all WebKit ports
commit-queue@webkit.org [Fri, 15 Feb 2013 00:56:23 +0000 (00:56 +0000)]
new-run-webkit-tests needs a shared TestExpectations between all WebKit ports
https://bugs.webkit.org/show_bug.cgi?id=37565

Introduce generic TestExpectations file that applies as a fallback for all ports, the location of which
is LayoutTests/TestExpectations.

Patch by Glenn Adams <glenn@skynav.com> on 2013-02-14
Reviewed by Dirk Pranke.

Tools:

* Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
(FakePort.path_to_generic_test_expectations_file):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.__init__):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.path_to_generic_test_expectations_file):
(Port):
(Port._port_specific_expectations_files):
(Port.expectations_files):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._port_specific_expectations_files):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort._port_specific_expectations_files):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_expectations_files):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._port_specific_expectations_files):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._port_specific_expectations_files):
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest.test_expectations_files):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._port_specific_expectations_files):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_expectations_ordering):
(test_expectations_files):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._port_specific_expectations_files):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_expectations_files):
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest.test_expectations_files):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_paths):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._update_expectations_file):

LayoutTests:

* TestExpectations: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Assertion failure on an exception is thrown
morrita@google.com [Fri, 15 Feb 2013 00:42:03 +0000 (00:42 +0000)]
[V8] Assertion failure on an exception is thrown
https://bugs.webkit.org/show_bug.cgi?id=109129

Source/WebCore:

An assertion in V8AbstractEventListener is wrong. This change turns it into an error check.

Reviewed by Kentaro Hara.

Test: fast/events/onerror-no-constructor.html

* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):

LayoutTests:

Reviewed by Kentaro Hara.

* fast/events/onerror-no-constructor-expected.txt: Added.
* fast/events/onerror-no-constructor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] CodeGeneratorV8.pm can assume that DOMWindow has [CheckSecurity]
haraken@chromium.org [Fri, 15 Feb 2013 00:38:19 +0000 (00:38 +0000)]
[V8] CodeGeneratorV8.pm can assume that DOMWindow has [CheckSecurity]
https://bugs.webkit.org/show_bug.cgi?id=109788

Reviewed by Adam Barth.

There is code like this:

  if ($extendedAttr{"CheckSecurity"} || $interfaceName eq "DOMWindow")

This check is redundant. DOMWindow has [CheckSecurity]. We can remove the
DOMWindow check.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateReplaceableAttrSetter):
(GenerateFunctionCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] IndexedDB: Remove unused creationContext paramter from idbKeyToV8Value
jsbell@chromium.org [Fri, 15 Feb 2013 00:36:52 +0000 (00:36 +0000)]
[V8] IndexedDB: Remove unused creationContext paramter from idbKeyToV8Value
https://bugs.webkit.org/show_bug.cgi?id=109870

Reviewed by Kentaro Hara.

This parameter was left over from when the function was toV8(IDBKey). Remove it.

No new tests - just removing dead code.

* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::idbKeyToV8Value): Remove unused parameter.
(WebCore::injectIDBKeyIntoScriptValue): No need for dummy handle.
(WebCore::idbKeyToScriptValue): No need for dummy handle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebGL][Qt] regression:r142786 Qt Build fix for Arm and Windows.
commit-queue@webkit.org [Fri, 15 Feb 2013 00:35:13 +0000 (00:35 +0000)]
[WebGL][Qt] regression:r142786 Qt Build fix for Arm and Windows.
https://bugs.webkit.org/show_bug.cgi?id=109797

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-14
Reviewed by Csaba Osztrogon√°c.

After r142786, we use OpenGLShims to load necessary GL functions
exposed by ARB_vertex_array_object extension. Qt uses OpenGLShims
to load functions with GLES too. This patch adds support for loading the
equivalent functions on GLES exposed by OES_vertex_array_object.

* platform/graphics/OpenGLShims.cpp:
(WebCore::initializeOpenGLShims):
* platform/graphics/OpenGLShims.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago <rdar://problem/13210723> CORS preflight broken with NetworkProcess
ap@apple.com [Fri, 15 Feb 2013 00:27:57 +0000 (00:27 +0000)]
    <rdar://problem/13210723> CORS preflight broken with NetworkProcess
        https://bugs.webkit.org/show_bug.cgi?id=109753

        Reviewed by Brady Eidson.

        * loader/DocumentThreadableLoader.h:
        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
        (WebCore::DocumentThreadableLoader::cancel):
        (WebCore::DocumentThreadableLoader::didReceiveResponse):
        (WebCore::DocumentThreadableLoader::dataReceived):
        (WebCore::DocumentThreadableLoader::didReceiveData):
        (WebCore::DocumentThreadableLoader::notifyFinished):
        (WebCore::DocumentThreadableLoader::didFinishLoading):
        (WebCore::DocumentThreadableLoader::didFail):
        (WebCore::DocumentThreadableLoader::preflightFailure): Notify InspectorInstrumentation
        immediately. In addition to keeping up eith other changes, this means that an accurate
        error will be passed now, not a cancellation.
        (WebCore::DocumentThreadableLoader::loadRequest):
        Get rid of m_preflightRequestIdentifier. Every loader has an identifier, and tracking
        identifiers twice is wrong.
        Pass identifier explicitly to more internal functions, so that they would not have to
        second-guess callers.

        * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest):
        Create an identifier for all loaders, not just those that we expect to have client
        callbacks about. Both Inspector and NetworkProcess need identifiers everywhere.

        * loader/TextTrackLoader.cpp: (WebCore::TextTrackLoader::deprecatedDidReceiveCachedResource):
        * loader/TextTrackLoader.h:
        * loader/cache/CachedResourceClient.h:
        (WebCore::CachedResourceClient::deprecatedDidReceiveCachedResource):
        * loader/cache/CachedTextTrack.cpp: (WebCore::CachedTextTrack::data):
        Renamed didReceiveData to avoid conflict with the new DocumentThreadableLoader::didReceiveData.
        And we should really get rid of this CachedResourceClient function anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace 'DOMObject' with 'any'
haraken@chromium.org [Fri, 15 Feb 2013 00:25:17 +0000 (00:25 +0000)]
Replace 'DOMObject' with 'any'
https://bugs.webkit.org/show_bug.cgi?id=109793

Reviewed by Dimitri Glazkov.

In the Web IDL spec, there is no type named 'DOMObject'.
It should be 'any'. We should replace all 'DOMObject's in WebKit IDLs with 'any's.

* Modules/webdatabase/SQLResultSetRowList.idl:
* bindings/scripts/CodeGeneratorCPP.pm:
(GetClassName):
(AddIncludesForType):
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(GenerateImplementation):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm:
(GetNativeType):
(JSValueToNative):
(GetV8HeaderName):
* dom/CustomEvent.idl:
* dom/MessageEvent.idl:
* dom/PopStateEvent.idl:
* fileapi/FileReader.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLElement.idl:
* html/canvas/DataView.idl:
* inspector/InjectedScriptHost.idl:
* inspector/InspectorFrontendHost.idl:
* inspector/JavaScriptCallFrame.idl:
* page/DOMWindow.idl:
* page/Location.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Remove GenerateEventListenerCallback() from CodeGeneratorV8.pm
haraken@chromium.org [Fri, 15 Feb 2013 00:17:51 +0000 (00:17 +0000)]
[V8] Remove GenerateEventListenerCallback() from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=109786

Reviewed by Adam Barth.

Some code is duplicated between GenerateEventListenerCallback()
and GenerateFunctionCallback(). By inlining GenerateEventListenerCallback()
into GenerateFunctionCallback(), we can remove the duplication.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago <rdar://problem/13161700> REGRESSION: Safari is unable to make SSL connections
ap@apple.com [Fri, 15 Feb 2013 00:16:43 +0000 (00:16 +0000)]
    <rdar://problem/13161700> REGRESSION: Safari is unable to make SSL connections
        when running from recovery partition

        Reviewed by Sam Weinig.

        * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
        * WebProcess/com.apple.WebProcess.sb.in:
        Re-added /private/var/db/mds/system rules lost in r141445.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline 9 SVG tests after r142765
pdr@google.com [Fri, 15 Feb 2013 00:08:37 +0000 (00:08 +0000)]
Rebaseline 9 SVG tests after r142765

Unreviewed rebaseline of test expectations.

* platform/chromium-linux/svg/as-background-image/animated-svg-as-background-expected.png:
* platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-6-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-background-partial-redraw-expected.png:
* platform/chromium-mac-lion/svg/as-background-image/animated-svg-as-background-expected.png:
* platform/chromium-mac-lion/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-mac-lion/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-mac-lion/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium-mac-lion/svg/as-background-image/svg-as-background-4-expected.png:
* platform/chromium-mac-lion/svg/as-background-image/svg-as-background-6-expected.png:
* platform/chromium-mac-lion/svg/as-background-image/svg-background-partial-redraw-expected.png:
* platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-background-partial-redraw-expected.png:
* platform/chromium-mac/svg/as-background-image/animated-svg-as-background-expected.png:
* platform/chromium-mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-2-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-4-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-6-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-background-partial-redraw-expected.png:
* platform/chromium-win-xp/svg/as-background-image: Removed.
* platform/chromium-win-xp/svg/as-background-image/svg-as-background-1-expected.png: Removed.
* platform/chromium-win-xp/svg/as-background-image/svg-as-background-3-expected.png: Removed.
* platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
* platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
* platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntrinsic and preferred widths on replaced elements are wrong in many cases
ojan@chromium.org [Thu, 14 Feb 2013 23:58:02 +0000 (23:58 +0000)]
Intrinsic and preferred widths on replaced elements are wrong in many cases
https://bugs.webkit.org/show_bug.cgi?id=109859

Reviewed by Levi Weintraub.

Source/WebCore:

Test: fast/replaced/preferred-widths.html

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeIntrinsicLogicalWidths):
Separate out computing the intrinsic widths. Eventually,
we should be able to share computePreferredLogicalWidth implementations
for all replaced elements and form controls since only the intrinsic width
changes.

(WebCore::RenderReplaced::computePreferredLogicalWidths):
-Apply min-width and max-width constraints and then add borderAndPaddingLogicalWidth
at the end to make sure it's always applied. This matches all our other
computePreferredLogicalWidths override and makes use match Gecko's/Opera's rendering.
-Only set the minPreferredLogicalWidth to 0 if the width or max-width is a percent value.
Doing it for height values and for min-width doesn't make any sense and doesn't
match other browsers. Doing this for max-width still doesn't match other browsers,
but it sounds like Gecko at least would like to change that.

* rendering/RenderReplaced.h:
(WebCore::RenderReplaced::hasRelativeIntrinsicLogicalWidth):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::hasRelativeIntrinsicLogicalWidth):
Add a way to check if the logicalWidth is relative so that we only check
the width in computePreferredLogicalWidths instead of also checking the height.

* rendering/svg/RenderSVGRoot.h:

LayoutTests:

* fast/replaced/preferred-widths-expected.txt: Added.
* fast/replaced/preferred-widths.html: Added.
These results match Gecko and Opera except for the 3rd container div.
Talking to dbaron and bz and Mozilla they sound likely to match our behavior there.
See https://bugzilla.mozilla.org/show_bug.cgi?id=823483 for example.

The width of the containers is wrong in some of these cases because our
computePreferredLogicalWidths methods don't currently account for
intrinsic sizes (e.g. min-content, max-content, etc).

* platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-win/fast/replaced/width100percent-image-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
These new results are more correct. The width100percent-image case now
matches other browsers and is due to not setting the minPreferrredLogicalWidth to
0 if the height is a percentage. The bugs85016 case is different because we
now correctly add the border and padding width to the preferred width of the image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a crash test expectation to media/media-captions.html on Mac per bug 109869.
rniwa@webkit.org [Thu, 14 Feb 2013 23:51:45 +0000 (23:51 +0000)]
Add a crash test expectation to media/media-captions.html on Mac per bug 109869.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] move pixel generation logic to TestRunner library
jochen@chromium.org [Thu, 14 Feb 2013 23:49:53 +0000 (23:49 +0000)]
[chromium] move pixel generation logic to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109686

Reviewed by Stephen White.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::~TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::proxy):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebTestRunner):
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::setWebView):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::display):
(WebTestRunner::TestRunner::displayInvalidatedRegion):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner):
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::setWebView):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::reset):
(WebTestRunner::WebTestProxyBase::capturePixels):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::paintRect):
(WebTestRunner::WebTestProxyBase::paintInvalidatedRegion):
(WebTestRunner::WebTestProxyBase::paintPagesWithBoundaries):
(WebTestRunner::WebTestProxyBase::canvas):
(WebTestRunner::WebTestProxyBase::displayRepaintMask):
(WebTestRunner::WebTestProxyBase::display):
(WebTestRunner::WebTestProxyBase::displayInvalidatedRegion):
(WebTestRunner::WebTestProxyBase::discardBackingStore):
(WebTestRunner::WebTestProxyBase::setWindowRect):
(WebTestRunner::WebTestProxyBase::userMediaClient):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::showDevTools):
(TestShell::closeDevTools):
(TestShell::dump):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setWindowRect):
(WebViewHost::setDeviceScaleFactor):
(WebViewHost::reset):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash when selecting a HarfBuzz text run with SVG fonts included
schenney@chromium.org [Thu, 14 Feb 2013 23:45:07 +0000 (23:45 +0000)]
Crash when selecting a HarfBuzz text run with SVG fonts included
https://bugs.webkit.org/show_bug.cgi?id=109833

Reviewed by Tony Chang.

Source/WebCore:

There is an assert in SimpleFontData::applyTransforms that should not
be there, as the code is valid for SVG fonts. If we get past this,
then the HarfBuzz text run shaping code assumes that font data has a
SkTypeface member, and SVG fonts do not. So we crash there too.

For now, we fix the crashes. This still leaves incorrect selection
rectangles in this situation, on all platforms, tracked in
https://bugs.webkit.org/show_bug.cgi?id=108133

Test: svg/css/font-face-crash.html

* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::applyTransforms): Remove ASSERT_NOT_REACHED as the code can legally be reached for SVG fonts.
* platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Check for SVG fonts in the text run, and abort if we find them.

LayoutTests:

Only known to crash on Chromium Linux (without the patch), but other platforms may be affected.

* svg/css/font-face-crash-expected.txt: Added.
* svg/css/font-face-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] No triggering autofill on unfocus
commit-queue@webkit.org [Thu, 14 Feb 2013 23:42:05 +0000 (23:42 +0000)]
[chromium] No triggering autofill on unfocus
https://bugs.webkit.org/show_bug.cgi?id=109735

Patch by David Trainor <dtrainor@chromium.org> on 2013-02-14
Reviewed by James Robinson.

Need to notify the autofill client to not process text changes when we're setting
focus to false and are trying to commit a composition.

* public/WebAutofillClient.h:
(WebAutofillClient):
(WebKit::WebAutofillClient::setIgnoreTextChanges):
(WebKit::WebAutofillClient::~WebAutofillClient):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setFocus):
* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Notify platform layer of failing to get authentication credentials
commit-queue@webkit.org [Thu, 14 Feb 2013 23:14:45 +0000 (23:14 +0000)]
[BlackBerry] Notify platform layer of failing to get authentication credentials
https://bugs.webkit.org/show_bug.cgi?id=109751

Patch by Joe Mason <jmason@rim.com> on 2013-02-13
Reviewed by Yong Li.
Reviewed internally by Leo Yang
Internal PR: 181302

The BlackBerry platform network layer needs to know if a stream failed to get authentication credentials.
This patch is using newly added stream API to do it.

No functionality changed no new tests.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):
* platform/network/blackberry/NetworkJob.h:
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::protectionSpaceToPlatformAuth):
(WebCore):
(WebCore::setAuthCredentials):
* platform/network/blackberry/NetworkManager.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Fix indentation in GNUmakefile.list.am.
commit-queue@webkit.org [Thu, 14 Feb 2013 22:54:43 +0000 (22:54 +0000)]
[GTK] Fix indentation in GNUmakefile.list.am.
https://bugs.webkit.org/show_bug.cgi?id=109854

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-14
Reviewed by Martin Robinson.

This patch fixes indentation in GNUmakefile.list.am.

* GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNo easy way to use a RetainPtr as a key in a HashMap using object (rather than pointe...
mitz@apple.com [Thu, 14 Feb 2013 22:50:37 +0000 (22:50 +0000)]
No easy way to use a RetainPtr as a key in a HashMap using object (rather than pointer) equality
https://bugs.webkit.org/show_bug.cgi?id=109864

Reviewed by Sam Weinig and Benjamin Poulain.

Added RetainPtrObjectHashTraits and RetainPtrObjectHash, which use CFEqual
and CFHash.

* wtf/RetainPtr.h:
(RetainPtrObjectHashTraits):
(WTF::RetainPtrObjectHashTraits::emptyValue):
(WTF::RetainPtrObjectHashTraits::constructDeletedValue):
(WTF::RetainPtrObjectHashTraits::isDeletedValue):
(WTF):
(WTF::RetainPtrObjectHash::hash):
(WTF::RetainPtrObjectHash::equal):
(RetainPtrObjectHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, set svn:eol-style native for .sln, .vsprops, and .vcproj files.
tony@chromium.org [Thu, 14 Feb 2013 22:46:57 +0000 (22:46 +0000)]
Unreviewed, set svn:eol-style native for .sln, .vsprops, and .vcproj files.
https://bugs.webkit.org/show_bug.cgi?id=96934

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBad cast in RenderBlock::splitBlocks.
inferno@chromium.org [Thu, 14 Feb 2013 22:34:44 +0000 (22:34 +0000)]
Bad cast in RenderBlock::splitBlocks.
https://bugs.webkit.org/show_bug.cgi?id=108691

Reviewed by Levi Weintraub.

Source/WebCore:

Test: fast/multicol/remove-child-split-flow-crash.html

* rendering/RenderBlock.cpp:
(WebCore):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): rename gIsInColumnFlowSplit to gColumnFlowSplitEnabled
and use it to decide when to do the column flow split or not.
(WebCore::RenderBlock::removeChild): Do not allow column flow split inside removeChild
since we might be merging anonymous blocks.

LayoutTests:

* fast/multicol/remove-child-split-flow-crash-expected.txt: Added.
* fast/multicol/remove-child-split-flow-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSplit SQLTransaction work between the frontend and backend.
mark.lam@apple.com [Thu, 14 Feb 2013 22:31:20 +0000 (22:31 +0000)]
Split SQLTransaction work between the frontend and backend.
https://bugs.webkit.org/show_bug.cgi?id=104750.

Reviewed by Sam Weinig.

This is part of the webdatabase refactoring for webkit2.

1. Changed how transactions are created.

   - Database::runTransaction() first creates a SQLTransaction frontend
     which encapsulates the 3 script callbacks. It then passes the
     SQLTransaction to the backend database to create the
     SQLTransactionBackend.
   - The SQLTransactionBackend manages all SQLiteTransaction work.

2. Introduced SQLTransactionState and SQLTransactionStateMachine.

   - Instead of tracking the transaction phases as "steps" in m_nextStep,
     we now use m_nextState which is of enum class SQLTransactionState.
     Unlike m_nextStep which is a pointer to a "step" function,
     m_nextState is a state variable which is used to index into a
     state dispatch table.

   - Both SQLTransaction and SQLTransactionBackend now extends
     SQLTransactionStateMachine, and uses its dispatch mechanism based on
     the SQLTransactionState.

   - Instead of having 1 state machine instances, there are 2: 1 in the
     frontend, and 1 in the backend. The 2 have mirrored states, and
     transfers work to the other state machine when needed.

   - Previously, state functions can be called inline from other states.
     They are now only called from the state machines runStateMachine()
     method. This makes it possible to isolate the state transition
     mechanism going between the sides (frontend and backend) to 2
     functions only: SQLTransaction::sendToBackendState() and
     SQLTransactionBackend::sendToFrontendState().

3. Consolidated cleanup work (mostly) to a unified cleanup function.

4. Changed the frontend Database::runTransaction() to use a
   ChangeVersionData* (instead of a ChangeVersionWrapper ref ptr).

   - This is necessary because ChangeVersionWrapper contains functionality
     used in processing a transaction (to be invoked in the backend).
     Instead, what we want is to simply pass the 2 old and new version
     strings to the backend. The new ChangeVersionData simply packages up
     these 2 strings.
   - This makes ChangeVersionData easy to serialize for IPC messaging later.

5. Moved some transaction functions back to the frontend SQLTransaction
   because they belong there.

6. Moved some Database functions to its DatabaseBackendAsync backend
   now that the transaction has been split up.

   - This is driven naturally by those functions being used exclusively
     in the backend for transaction work.
   - SQLTransactionClient, SQLTransactionCoordinator, and
     SQLTransactionWrapper are now exclusively backend data structures.
     SQLTransactionClient still has some frontend "pollution" that I'll
     fix later.

7. Made the few database report functions used only by Chromium conditional
   on PLATFORM(chromium).

   - The report functions gets re-routed to Chromium's DatabaseObserver
     which further routes them elsewhere. It is unclear how Chromium uses
     these routed messages, and I am therefore not able to determine how
     they should work in a frontend/backend world. So, I'm #ifdef'ing
     them out. They still work like in the old way for Chromium.

8. Added new files to the build / project files.

9. Updated / added comments about how the transaction and its states work.

No new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/webdatabase/AbstractDatabaseServer.h:
* Modules/webdatabase/ChangeVersionData.h: Added.
(ChangeVersionData):
(WebCore::ChangeVersionData::ChangeVersionData):
(WebCore::ChangeVersionData::oldVersion):
(WebCore::ChangeVersionData::newVersion):
* Modules/webdatabase/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):
(WebCore::ChangeVersionWrapper::handleCommitFailedAfterPostflight):
* Modules/webdatabase/ChangeVersionWrapper.h:
(ChangeVersionWrapper):
* Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::close):
(WebCore::Database::changeVersion):
(WebCore::Database::transaction):
(WebCore::Database::readTransaction):
(WebCore::Database::runTransaction):
(WebCore::Database::reportStartTransactionResult):
(WebCore::Database::reportCommitTransactionResult):
(WebCore::Database::reportExecuteStatementResult):
* Modules/webdatabase/Database.h:
(WebCore::Database::databaseContext):
(Database):
(WebCore::Database::reportStartTransactionResult):
(WebCore::Database::reportCommitTransactionResult):
(WebCore::Database::reportExecuteStatementResult):
* Modules/webdatabase/DatabaseBackend.cpp:
* Modules/webdatabase/DatabaseBackend.h:
(DatabaseBackend):
(WebCore::DatabaseBackend::reportOpenDatabaseResult):
(WebCore::DatabaseBackend::reportChangeVersionResult):
(WebCore::DatabaseBackend::reportStartTransactionResult):
(WebCore::DatabaseBackend::reportCommitTransactionResult):
(WebCore::DatabaseBackend::reportExecuteStatementResult):
(WebCore::DatabaseBackend::reportVacuumDatabaseResult):
* Modules/webdatabase/DatabaseBackendAsync.cpp:
(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):
(WebCore::DatabaseBackendAsync::runTransaction):
(WebCore::DatabaseBackendAsync::inProgressTransactionCompleted): Moved from frontend.
(WebCore::DatabaseBackendAsync::scheduleTransaction): Moved from frontend.
(WebCore::DatabaseBackendAsync::scheduleTransactionStep): Moved from frontend.
(WebCore::DatabaseBackendAsync::transactionClient): Moved from frontend.
(WebCore::DatabaseBackendAsync::transactionCoordinator): Moved from frontend.
* Modules/webdatabase/DatabaseBackendAsync.h:
(DatabaseBackendAsync):
* Modules/webdatabase/DatabaseBackendContext.cpp:
(WebCore::DatabaseBackendContext::frontend):
* Modules/webdatabase/DatabaseBackendContext.h:
(DatabaseBackendContext):
* Modules/webdatabase/DatabaseManager.cpp:
* Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
* Modules/webdatabase/DatabaseServer.cpp:
* Modules/webdatabase/DatabaseServer.h:
* Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::doPerformTask):
* Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::create):
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::setBackend):
(WebCore::SQLTransaction::stateFunctionFor):
(WebCore::SQLTransaction::requestTransitToState):
(WebCore::SQLTransaction::nextStateForTransactionError):
    - was handleTransactionError(). There's also a backend version.
(WebCore::SQLTransaction::deliverTransactionCallback): Moved from backend.
(WebCore::SQLTransaction::deliverTransactionErrorCallback): Moved from backend.
(WebCore::SQLTransaction::deliverStatementCallback): Moved from backend.
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback): Moved from backend.
(WebCore::SQLTransaction::deliverSuccessCallback): Moved from backend.
(WebCore::SQLTransaction::unreachableState):
(WebCore::SQLTransaction::sendToBackendState):
(WebCore::SQLTransaction::performPendingCallback): Moved from backend.
(WebCore::SQLTransaction::executeSQL): Moved from backend.
(WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransaction::clearCallbackWrappers):
* Modules/webdatabase/SQLTransaction.h:
(SQLTransaction):
(WebCore::SQLTransaction::database):
(WebCore::SQLTransaction::hasCallback):
(WebCore::SQLTransaction::hasSuccessCallback):
(WebCore::SQLTransaction::hasErrorCallback):
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::transactionError):
(WebCore::SQLTransactionBackend::setShouldRetryCurrentStatement):
(WebCore::SQLTransactionBackend::stateFunctionFor):
(WebCore::SQLTransactionBackend::enqueueStatement):
(WebCore::SQLTransactionBackend::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransactionBackend::performNextStep):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransactionBackend::acquireLock):
(WebCore::SQLTransactionBackend::lockAcquired):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):
    - was runCurrentStatement().
(WebCore::SQLTransactionBackend::nextStateForCurrentStatementError):
    - was handleCurrentStatementError().
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::cleanupAndTerminate):
(WebCore::SQLTransactionBackend::nextStateForTransactionError):
    - was handleTransactionError(). There's also a frontend version.
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
(WebCore::SQLTransactionBackend::requestTransitToState):
(WebCore::SQLTransactionBackend::unreachableState):
(WebCore::SQLTransactionBackend::sendToFrontendState):
* Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionWrapper):
(SQLTransactionBackend):
(WebCore::SQLTransactionBackend::database):
* Modules/webdatabase/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
* Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
* Modules/webdatabase/SQLTransactionState.h: Added.
* Modules/webdatabase/SQLTransactionStateMachine.cpp: Added.
(WebCore::nameForSQLTransactionState):
    - was debugStepName().
* Modules/webdatabase/SQLTransactionStateMachine.h: Added.
(SQLTransactionStateMachine):
(WebCore::SQLTransactionStateMachine::~SQLTransactionStateMachine):
(WebCore::::SQLTransactionStateMachine):
(WebCore::::setStateToRequestedState):
(WebCore::::runStateMachine):
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorDatabaseAgent.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd WKContextIsPlugInUpdateAvailable
andersca@apple.com [Thu, 14 Feb 2013 22:27:52 +0000 (22:27 +0000)]
Add WKContextIsPlugInUpdateAvailable
https://bugs.webkit.org/show_bug.cgi?id=109862
<rdar://problem/13173140>

Reviewed by Sam Weinig.

Source/WebKit2:

* UIProcess/API/C/mac/WKContextPrivateMac.h:
* UIProcess/API/C/mac/WKContextPrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.cpp.
(WKContextGetProcessSuppressionEnabled):
(WKContextSetProcessSuppressionEnabled):
(WKContextIsPlugInUpdateAvailable):
* WebKit2.xcodeproj/project.pbxproj:

WebKitLibraries:

Roll WebKitSystemInterface DEPS.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceMountainLion.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEME: replace MediaKeySession.addKey() -> update()
jer.noble@apple.com [Thu, 14 Feb 2013 22:26:53 +0000 (22:26 +0000)]
EME: replace MediaKeySession.addKey() -> update()
https://bugs.webkit.org/show_bug.cgi?id=109461

Source/WebCore:

Reviewed by Eric Carlson.

No new tests; updated media/encrypted-media/encrypted-media-v2-syntax.html test.

In the latest draft of the Encrypted Media Spec, the addKeys() method has been replaced
with update().

* Modules/encryptedmedia/CDM.h:
* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::update):
(WebCore::MediaKeySession::addKeyTimerFired):
* Modules/encryptedmedia/MediaKeySession.h:
* Modules/encryptedmedia/MediaKeySession.idl:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitAddKey):
* testing/MockCDM.cpp:
(WebCore::MockCDMSession::update):

LayoutTests:

Rebaseline after API change.

Reviewed by Eric Carlson.

* media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
* media/encrypted-media/encrypted-media-v2-syntax.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove all .props files from WebKitLibraries folder to WebKit Source folder.
roger_fong@apple.com [Thu, 14 Feb 2013 22:04:11 +0000 (22:04 +0000)]
Move all .props files from WebKitLibraries folder to WebKit Source folder.
https://bugs.webkit.org/show_bug.cgi?id=109761

Reviewed by Brent Fulgham.

* win/tools/vsprops/FeatureDefines.props: Removed.
* win/tools/vsprops/common.props: Removed.
* win/tools/vsprops/debug.props: Removed.
* win/tools/vsprops/release.props: Removed.
* win/tools/vsprops/releaseproduction.props: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, set svn:eol-style CRLF for .sln files.
tony@chromium.org [Thu, 14 Feb 2013 22:00:53 +0000 (22:00 +0000)]
Unreviewed, set svn:eol-style CRLF for .sln files.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property
* svn:eol-style.

Source/ThirdParty:

* gtest/msvc/gtest-md.sln: Added property svn:eol-style.
* gtest/msvc/gtest.sln: Added property svn:eol-style.

Source/WebCore:

* WebCore.vcproj/WebCore.sln: Modified property svn:eol-style.
* WebCore.vcproj/WebCore.submit.sln: Modified property svn:eol-style.

Source/WebKit:

* WebKit.vcxproj/WebKit.sln: Modified property svn:eol-style.

Source/WebKit/win:

* WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
* WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.

Source/WTF:

* WTF.vcproj/WTF.sln: Added property svn:eol-style.

Tools:

* CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
* DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
* MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
* WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, set svn:eol-style CRLF for .sln files.
tony@chromium.org [Thu, 14 Feb 2013 21:58:41 +0000 (21:58 +0000)]
Unreviewed, set svn:eol-style CRLF for .sln files.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property svn:eol-style.

Source/ThirdParty:

* gtest/msvc/gtest-md.sln: Added property svn:eol-style.
* gtest/msvc/gtest.sln: Added property svn:eol-style.

Source/WebCore:

* WebCore.vcproj/WebCore.sln: Modified property svn:eol-style.
* WebCore.vcproj/WebCore.submit.sln: Modified property svn:eol-style.

Source/WebKit:

* WebKit.vcxproj/WebKit.sln: Modified property svn:eol-style.

Source/WebKit/win:

* WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
* WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.

Source/WTF:

* WTF.vcproj/WTF.sln: Added property svn:eol-style.

Tools:

* CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
* DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
* MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
* WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try
aelias@chromium.org [Thu, 14 Feb 2013 21:56:03 +0000 (21:56 +0000)]
[chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try
https://bugs.webkit.org/show_bug.cgi?id=109671

Reviewed by James Robinson.

My patch 142571 broke a bunch of things in handleGestureEvent that
assumed the event came in scaled, most notably tap highlight and
double-tap zoom. Switch those to PlatformGestureEvent.

142808 was an earlier version of this patch that was reverted
due to fling events asserting they can't be converted to
PlatformGestureEvent. This version moves fling earlier in the
function to avoid that.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTapNode):
(WebKit::WebViewImpl::enableTapHighlight):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/LinkHighlightTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r142901.
dpranke@chromium.org [Thu, 14 Feb 2013 21:54:28 +0000 (21:54 +0000)]
Unreviewed, rolling out r142901.
http://trac.webkit.org/changeset/142901

r182258 introduces a dependency on chrome.gyp that breaks the win
build. Rolling back to r182150 until I can work up a workaround.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] adjust caption color user preference calculation
eric.carlson@apple.com [Thu, 14 Feb 2013 21:51:49 +0000 (21:51 +0000)]
[Mac] adjust caption color user preference calculation
https://bugs.webkit.org/show_bug.cgi?id=109840

Reviewed by Dean Jackson.

No new tests, it isn't possible to test this with DRT.

* page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::captionsWindowCSS): The color is "important" if either the
    color or opacity are supposed to override.
(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Ditto.
(WebCore::CaptionUserPreferencesMac::captionsTextColor): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNumeric identifiers of events are not guaranteed to be unique
commit-queue@webkit.org [Thu, 14 Feb 2013 21:49:20 +0000 (21:49 +0000)]
Numeric identifiers of events are not guaranteed to be unique
https://bugs.webkit.org/show_bug.cgi?id=103259

Patch by Cosmin Truta <ctruta@rim.com> on 2013-02-14
Reviewed by Alexey Proskuryakov.

The results of setTimeout, setInterval and navigator.geolocation.watchPosition
are positive integer values extracted from a simple circular sequential number
generator, whose uniqueness can be guaranteed for no more than 2^31 calls to
any of these functions. In order to provide this guarantee beyond this limit,
we repeatedly ask for the next sequential id until we get one that's not used
already.

This solution works instantly under normal circumstances, when there are few
live timeout ids or geolocation ids at any given moment. Handling millions of
live ids will require another solution.

No new tests. Brief tests of uniqueness already exist.
Moreover, reproducing this particular issue would require 2^31 set/clear
function calls, which is prohibitively expensive.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::Watchers::add): Rename from Watchers::set; return false if watch id already exists.
(WebCore::Geolocation::watchPosition): Repeat until the new watch id is unique.
* Modules/geolocation/Geolocation.h:
(Watchers): Rename Watchers::set to Watchers::add.
* Modules/geolocation/Geolocation.idl: Rename the argument of Geolocation::clearWatch to WatchID.
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext): Update initialization.
(WebCore::ScriptExecutionContext::circularSequentialID): Rename from newUniqueID; remove FIXME note.
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext): Rename ScriptExecutionContext::newUniqueID to ScriptExecutionContext::circularSequentialID.
(WebCore::ScriptExecutionContext::addTimeout): Return false (do not assert) if timeout id already exists.
* page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer): Repeat until the new timeout id is unique.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Errors when building WebKit2 with Clang
zandobersek@gmail.com [Thu, 14 Feb 2013 21:40:14 +0000 (21:40 +0000)]
[GTK] Errors when building WebKit2 with Clang
https://bugs.webkit.org/show_bug.cgi?id=109603

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

* UIProcess/API/gtk/WebKitUIClient.cpp:
(setWindowFrame): Cast the position parameters to the integer type when constructing the GdkRectangle.
* UIProcess/Authentication/WebCredential.cpp: Add an empty implementation of the newly specified destructor.
* UIProcess/Authentication/WebCredential.h: Work around the incomplete WebCertificateInfo type errors thrown in the inline
RefPtr destructor of the m_certificateInfo class member by defining a destructor in the class.
* WebProcess/WebCoreSupport/WebEditorClient.h: The GTK-specific methods are not virtual and as such cannot be overriden.
The OVERRIDE keywords are thus unnecessary.

Tools:

* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::resizeTo): Cast the width and height parameters to the integer
type when constructing the GtkAllocation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r142825.
commit-queue@webkit.org [Thu, 14 Feb 2013 21:34:00 +0000 (21:34 +0000)]
Unreviewed, rolling out r142825.
http://trac.webkit.org/changeset/142825
https://bugs.webkit.org/show_bug.cgi?id=109856

Causes some inspector tests to time out (Requested by anttik
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14

* platform/mac/SharedTimerMac.mm:
(WebCore):
(WebCore::PowerObserver::restartSharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport the ch unit from css3-values
commit-queue@webkit.org [Thu, 14 Feb 2013 21:18:49 +0000 (21:18 +0000)]
Support the ch unit from css3-values
https://bugs.webkit.org/show_bug.cgi?id=85755

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-02-14
Reviewed by David Hyatt.

Original patch by Sumedha Widyadharma <sumedha.widyadharma@basyskom.com>.

Source/WebCore:

Test: fast/css/css3-ch-unit.html

* css/CSSCalculationValue.cpp:
(WebCore::unitCategory):
* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::detectNumberToken):
* css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isLength):
* platform/graphics/FontMetrics.h:
(WebCore::FontMetrics::FontMetrics):
(WebCore::FontMetrics::zeroWidth):
(WebCore::FontMetrics::setZeroWidth):
(FontMetrics):
(WebCore::FontMetrics::hasZeroWidth):
(WebCore::FontMetrics::setHasZeroWidth):
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit):
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::zeroGlyph):
(WebCore::SimpleFontData::setZeroGlyph):
(SimpleFontData):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformInit):

LayoutTests:

* fast/css/css3-ch-unit-expected.txt: Added.
* fast/css/css3-ch-unit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Clean up WARNING_CFLAGS
ddkilzer@apple.com [Thu, 14 Feb 2013 21:16:47 +0000 (21:16 +0000)]
[Mac] Clean up WARNING_CFLAGS
<http://webkit.org/b/109747>
<rdar://problem/13208373>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

* Configurations/Base.xcconfig: Use
GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.

Source/WebCore:

* Configurations/Base.xcconfig: Use
GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.

Source/WebKit/mac:

* Configurations/Base.xcconfig: Use
GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.

Source/WebKit2:

* Configurations/Base.xcconfig: Use
GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.

Source/WTF:

* Configurations/Base.xcconfig: Use
GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd addHTTPHeaderField() method to ResourceResponse
ch.dumez@sisa.samsung.com [Thu, 14 Feb 2013 21:11:21 +0000 (21:11 +0000)]
Add addHTTPHeaderField() method to ResourceResponse
https://bugs.webkit.org/show_bug.cgi?id=109844

Reviewed by Adam Barth.

ResourceRequestBase provides both setHTTPHeaderField() and addHTTPHeaderField(). However,
ResourceResponseBase only provides setHTTPHeaderField(). This is a bit inconsistent. As a
result, the addHTTPHeaderField() functionality's implementation is duplicated in several
ports (at least chromium and soup).

This patch introduces addHTTPHeaderField() to ResourceResponseBase and makes use of it
in Chromium and Soup backends.

No new tests, no behavior change.

* platform/chromium/support/WebURLResponse.cpp:
(WebKit::WebURLResponse::addHTTPHeaderField): Use ResourceResponseBase::addHTTPHeaderField().
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::updateHeaderParsedState): Move headers' parsed state update code
from setHTTPHeaderField() to a new updateHeaderParsedState() method to avoid code duplication.
(WebCore):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::addHTTPHeaderField):
* platform/network/ResourceResponseBase.h:
(ResourceResponseBase):
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessageHeaders): Use ResourceResponseBase::addHTTPHeaderField().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, chromium roll 182150 -> 182448
dpranke@chromium.org [Thu, 14 Feb 2013 21:08:50 +0000 (21:08 +0000)]
Unreviewed, chromium roll 182150 -> 182448

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd conversions between ObjC and C DOM wrappers
weinig@apple.com [Thu, 14 Feb 2013 20:53:22 +0000 (20:53 +0000)]
Add conversions between ObjC and C DOM wrappers
<rdar://problem/13205468>
https://bugs.webkit.org/show_bug.cgi?id=109851

Reviewed by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:
(WKBundleRangeHandleCreate):
* WebProcess/InjectedBundle/API/c/WKBundleRangeHandlePrivate.h: Added.
* WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
(-[WKDOMNode _copyBundleNodeHandleRef]):
* WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h: Added.
* WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:
(-[WKDOMRange _copyBundleRangeHandleRef]):
* WebProcess/InjectedBundle/API/mac/WKDOMRangePrivate.h: Added.
* WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::getOrCreate):
* WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
(InjectedBundleRangeHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPrevent inconsistent firstChild during document destruction
pdr@google.com [Thu, 14 Feb 2013 20:16:48 +0000 (20:16 +0000)]
Prevent inconsistent firstChild during document destruction
https://bugs.webkit.org/show_bug.cgi?id=106530

Reviewed by Abhishek Arya.

Source/WebCore:

During document destruction, addChildNodesToDeletionQueue can allow a container
node to have an invalid first child, causing a crash. This patch updates
addChildNodesToDeletionQueue to maintain a valid value for firstChild() even
while updating its children.

Test: svg/custom/animateMotion-path-change-crash.svg

* dom/ContainerNodeAlgorithms.h:
(WebCore::Private::addChildNodesToDeletionQueue):
    To ensure prevoiusSibling() is also valid, this code was slightly refactored
    to call setPreviousSibling(0) on the next node instead of the current node.

LayoutTests:

* svg/custom/animateMotion-path-change-crash-expected.txt: Added.
* svg/custom/animateMotion-path-change-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Grid Layout] Add an internal 2D grid representation to RenderGrid
jchaffraix@webkit.org [Thu, 14 Feb 2013 20:15:30 +0000 (20:15 +0000)]
[CSS Grid Layout] Add an internal 2D grid representation to RenderGrid
https://bugs.webkit.org/show_bug.cgi?id=109714

Reviewed by Ojan Vafai.

This change introduces a 2D grid representation of the grid areas. Our implementation
is a straight Vector of Vectors for the grid areas, each grid area able to hold an
arbitrary number of RenderBox* so they hold a Vector of RenderBoxes. As an optimization,
each grid area has enough inline storage to hold one grid item which should cover
most cases.

In order to keep the code readable, a GridIterator was introduced to hide the new grid.

Refactoring, covered by existing tests.

* rendering/RenderGrid.cpp:
(RenderGrid::GridIterator):
(WebCore::RenderGrid::GridIterator::GridIterator):
(WebCore::RenderGrid::GridIterator::nextGridItem):
Added a mono-directional iterator. In order to be more aligned with the rest of the code,
this iterator actually walks orthogonally to the |direction| (ie fixing the |direction|'s track).

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computePreferredLogicalWidths):
(WebCore::RenderGrid::layoutGridItems):
Updated these 2 functions to place the items on the grid and clear it at the end.

(WebCore::RenderGrid::computePreferredTrackWidth):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Updated to use the GridIterator to walk over the rows / columns.

(WebCore::RenderGrid::placeItemsOnGrid):
Added this function that inserts the grid items into the right grid area.

* rendering/RenderGrid.h:
(WebCore::RenderGrid::gridColumnCount):
(WebCore::RenderGrid::gridRowCount):
Added these helper functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r141990.
commit-queue@webkit.org [Thu, 14 Feb 2013 19:53:11 +0000 (19:53 +0000)]
Unreviewed, rolling out r141990.
http://trac.webkit.org/changeset/141990
https://bugs.webkit.org/show_bug.cgi?id=109850

~5% regression on intl2 page cycler (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14

* platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::create):
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):
(GlyphPage):
(WebCore::GlyphPage::copyFrom):
(WebCore::GlyphPage::clear):
(WebCore::GlyphPage::clearForFontData):
(WebCore::GlyphPage::GlyphPage):
* platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move PlatformMessagePortChannel to WebCore
pilgrim@chromium.org [Thu, 14 Feb 2013 19:31:47 +0000 (19:31 +0000)]
[Chromium] Move PlatformMessagePortChannel to WebCore
https://bugs.webkit.org/show_bug.cgi?id=109845

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* dom/default/chromium: Added.
* dom/default/chromium/PlatformMessagePortChannelChromium.cpp: Added.
(WebCore):
(WebCore::MessagePortChannel::create):
(WebCore::MessagePortChannel::createChannel):
(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::~MessagePortChannel):
(WebCore::MessagePortChannel::entangleIfOpen):
(WebCore::MessagePortChannel::disentangle):
(WebCore::MessagePortChannel::postMessageToRemote):
(WebCore::MessagePortChannel::tryGetMessageFromRemote):
(WebCore::MessagePortChannel::close):
(WebCore::MessagePortChannel::isConnectedTo):
(WebCore::MessagePortChannel::hasPendingActivity):
(WebCore::MessagePortChannel::locallyEntangledPort):
(WebCore::PlatformMessagePortChannel::create):
(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
(WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel):
(WebCore::PlatformMessagePortChannel::createChannel):
(WebCore::PlatformMessagePortChannel::messageAvailable):
(WebCore::PlatformMessagePortChannel::entangleIfOpen):
(WebCore::PlatformMessagePortChannel::disentangle):
(WebCore::PlatformMessagePortChannel::postMessageToRemote):
(WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
(WebCore::PlatformMessagePortChannel::close):
(WebCore::PlatformMessagePortChannel::isConnectedTo):
(WebCore::PlatformMessagePortChannel::hasPendingActivity):
(WebCore::PlatformMessagePortChannel::setEntangledChannel):
(WebCore::PlatformMessagePortChannel::webChannelRelease):
* dom/default/chromium/PlatformMessagePortChannelChromium.h: Added.
(WebKit):
(WebCore):
(PlatformMessagePortChannel):

Source/WebKit/chromium:

* WebKit.gyp:
* src/PlatformMessagePortChannel.cpp: Removed.
* src/PlatformMessagePortChannel.h: Removed.
* src/SharedWorkerRepository.cpp:
* src/WebDOMMessageEvent.cpp:
* src/WebFrameImpl.cpp:
* src/WebSharedWorkerImpl.cpp:
* src/WebWorkerClientImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove Leopard Accessibility support from WebCore (now that no port builds on Leopard)
cfleizach@apple.com [Thu, 14 Feb 2013 19:22:10 +0000 (19:22 +0000)]
Remove Leopard Accessibility support from WebCore (now that no port builds on Leopard)
https://bugs.webkit.org/show_bug.cgi?id=90250

Reviewed by Eric Seidel.

The Leopard era checks for accessibility lists and accessibility tables can be removed now.

* accessibility/AccessibilityARIAGrid.cpp:
(WebCore):
* accessibility/AccessibilityARIAGrid.h:
(AccessibilityARIAGrid):
(WebCore::AccessibilityARIAGrid::isTableExposableThroughAccessibility):
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::computeAccessibilityIsIgnored):
* accessibility/AccessibilityList.h:
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::AccessibilityTable):
(WebCore::AccessibilityTable::init):
* accessibility/AccessibilityTable.h:
(AccessibilityTable):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoString(Vector) behaves differently from String(vector.data(), vector.size()) for...
eric@webkit.org [Thu, 14 Feb 2013 19:17:12 +0000 (19:17 +0000)]
String(Vector) behaves differently from String(vector.data(), vector.size()) for vectors with inline capacity in the size=0 case
https://bugs.webkit.org/show_bug.cgi?id=109784

Reviewed by Darin Adler.

This makes String(Vector) never return null strings.
Which matches behavior of String(UChar*, size_t)
for vectors with inlineCapacity, but differs from
String(UChar*, size_t) in the no-inlineCapacity case.

This incidentally will fix a behavioral regression
in the html threaded parser which came from converting
many String(UChar*, size_t) callsites to using String(Vector).

* wtf/text/WTFString.h:
(String):
(WTF::String::String):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake outside-shape the default value for shape-inside
commit-queue@webkit.org [Thu, 14 Feb 2013 19:09:41 +0000 (19:09 +0000)]
Make outside-shape the default value for shape-inside
https://bugs.webkit.org/show_bug.cgi?id=109605

Patch by Bear Travis <betravis@adobe.com> on 2013-02-14
Reviewed by Levi Weintraub.

Source/WebCore:

Creating a single reference outside-shape value and setting it as the default
for shape-inside.

Existing tests cover the default value, just updating them to use outside-shape.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::initialShapeInside): Define a local static outside-shape
value.
(WebCore):
* rendering/style/RenderStyle.h: Move the initialShapeInside method to the .cpp
file.

LayoutTests:

Updating tests to account for the new default value of shape-inside.

* fast/exclusions/css-exclusions-disabled-expected.txt:
* fast/exclusions/css-exclusions-disabled.html:
* fast/exclusions/parsing-wrap-shape-inside-expected.txt:
* fast/exclusions/parsing-wrap-shape-lengths-expected.txt:
* fast/exclusions/parsing-wrap-shape-lengths.html:
* fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
(negative_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd eol-style=native to solution files. Add a new solution file.
roger_fong@apple.com [Thu, 14 Feb 2013 19:06:26 +0000 (19:06 +0000)]
Add eol-style=native to solution files. Add a new solution file.

* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added property svn:eol-style.
* TestWebKitAPI/TestWebKitAPI.vcxproj: Added property svn:eol-style. Modified property svn:ignore.
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPassing alpha to DeferredImageDecoder once decoding completes
commit-queue@webkit.org [Thu, 14 Feb 2013 18:49:27 +0000 (18:49 +0000)]
Passing alpha to DeferredImageDecoder once decoding completes
https://bugs.webkit.org/show_bug.cgi?id=108892

Patch by Min Qin <qinmin@chromium.org> on 2013-02-14
Reviewed by Stephen White.

Source/WebCore:

We should pass hasAlpha value back to the DeferredImageDecoder once decoding is completed
Added unit tests in ImageFrameGeneratorTest.

* platform/graphics/chromium/DeferredImageDecoder.cpp:
(WebCore::DeferredImageDecoder::frameHasAlphaAtIndex):
* platform/graphics/chromium/ImageFrameGenerator.cpp:
(WebCore::ImageFrameGenerator::tryToScale):
(WebCore::ImageFrameGenerator::decode):
* platform/graphics/chromium/LazyDecodingPixelRef.cpp:
(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):
* platform/graphics/chromium/LazyDecodingPixelRef.h:
(WebCore::LazyDecodingPixelRef::hasAlpha):
(LazyDecodingPixelRef):
* platform/graphics/chromium/ScaledImageFragment.cpp:
(WebCore::ScaledImageFragment::ScaledImageFragment):
* platform/graphics/chromium/ScaledImageFragment.h:
(WebCore::ScaledImageFragment::create):
(ScaledImageFragment):
(WebCore::ScaledImageFragment::hasAlpha):

Source/WebKit/chromium:

Add test to check that alpha value is passed from the decoder to ImageFrameGenerator.

* tests/ImageFrameGeneratorTest.cpp:
(WebCore::MockImageDecoderFactory::create):
(WebCore::TEST_F):
* tests/MockImageDecoder.h:
(WebCore::MockImageDecoder::MockImageDecoder):
(WebCore::MockImageDecoder::setFrameHasAlpha):
(MockImageDecoder):
(WebCore::MockImageDecoder::frameHasAlphaAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Add a few more histogram calls
dgrogan@chromium.org [Thu, 14 Feb 2013 18:17:54 +0000 (18:17 +0000)]
IndexedDB: Add a few more histogram calls
https://bugs.webkit.org/show_bug.cgi?id=109762

Reviewed by Tony Chang.

A few places where commits could fail weren't being logged.

* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::Transaction::commit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPadding and border changes doesn't trigger relayout of children
tony@chromium.org [Thu, 14 Feb 2013 17:53:16 +0000 (17:53 +0000)]
Padding and border changes doesn't trigger relayout of children
https://bugs.webkit.org/show_bug.cgi?id=109639

Reviewed by Kent Tamura.

Source/WebCore:

In RenderBlock::layoutBlock, we only relayout our children if our logical width
changes. This misses cases where our logical width doesn't change (i.e., padding
or border changes), but our content width does change.

This is a more general case of bug 104997.

Test: fast/block/dynamic-padding-border.html

* rendering/RenderBox.cpp:
(WebCore::borderOrPaddingLogicalWidthChanged): Only check if the logical width changed.
(WebCore::RenderBox::styleDidChange): Drop the border-box condition since this can happen
even without border-box box sizing.

LayoutTests:

* fast/block/dynamic-padding-border-expected.txt: Added.
* fast/block/dynamic-padding-border.html: Added.
* fast/table/border-collapsing/cached-change-row-border-width-expected.txt: We should have been relaying
out the table when the border changed. The pixel results in this case is the same, but the
render tree shows the difference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: fix closure compilation warnings caused by setVariableValue change
commit-queue@webkit.org [Thu, 14 Feb 2013 17:52:04 +0000 (17:52 +0000)]
Web Inspector: fix closure compilation warnings caused by setVariableValue change
https://bugs.webkit.org/show_bug.cgi?id=109488

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-14
Reviewed by Pavel Feldman.

Annotations are fixed as required by closure compiler.
Parameters in Inspector.json are reordered as required.

* inspector/InjectedScriptExterns.js:
(InjectedScriptHost.prototype.setFunctionVariableValue):
(JavaScriptCallFrame.prototype.setVariableValue):
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setVariableValue):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: RTCDataChannel triggers a use-after-free
tommyw@google.com [Thu, 14 Feb 2013 17:47:36 +0000 (17:47 +0000)]
MediaStream API: RTCDataChannel triggers a use-after-free
https://bugs.webkit.org/show_bug.cgi?id=109806

Reviewed by Adam Barth.

Making sure RTCPeerConnection::stop() is always called at least once.
Also making sure that RTCDataChannels state gets set to Closed correctly.

Hard to test in WebKit but covered by Chromium tests.

* Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::stop):
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Regression] When several consecutive characters are typed each of...
vsevik@chromium.org [Thu, 14 Feb 2013 17:38:42 +0000 (17:38 +0000)]
Web Inspector: [Regression] When several consecutive characters are typed each of them is marked as undoable state.
https://bugs.webkit.org/show_bug.cgi?id=109823

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):

LayoutTests:

* inspector/editor/text-editor-undo-redo-expected.txt:
* inspector/editor/text-editor-undo-redo.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r142820.
commit-queue@webkit.org [Thu, 14 Feb 2013 17:23:48 +0000 (17:23 +0000)]
Unreviewed, rolling out r142820.
http://trac.webkit.org/changeset/142820
https://bugs.webkit.org/show_bug.cgi?id=109839

Causing crashes on chromium canaries (Requested by atwilson_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::updateLayout):
(WebCore::Document::implicitClose):
* rendering/RenderQuote.h:
(RenderQuote):
* rendering/RenderView.cpp:
* rendering/RenderView.h:

LayoutTests:

* fast/block/float/float-not-removed-from-pre-block-expected.txt:
* fast/css-generated-content/quote-layout-focus-crash-expected.txt: Removed.
* fast/css-generated-content/quote-layout-focus-crash.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Update keyboard event details to match platform details.
mifenton@rim.com [Thu, 14 Feb 2013 17:21:28 +0000 (17:21 +0000)]
[BlackBerry] Update keyboard event details to match platform details.
https://bugs.webkit.org/show_bug.cgi?id=109693

Reviewed by Yong Li.

PR 220170.

When re-creating the Platform::Keyboard event ensure
all values are updated.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Missing call to g_object_ref while retrieving accessible table cells
mario@webkit.org [Thu, 14 Feb 2013 17:15:52 +0000 (17:15 +0000)]
[GTK] Missing call to g_object_ref while retrieving accessible table cells
https://bugs.webkit.org/show_bug.cgi?id=106903

Reviewed by Martin Robinson.

Source/WebCore:

Add missing extra ref to implementation of atk_table_ref_at().

Test: accessibility/table-cell-for-column-and-row-crash.html

* accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableRefAt): This method transfers full ownership
over the returned AtkObject, so an extra reference is needed here.

Tools:

Both DRT and WKTR need to call g_object_unref() now that an extra
reference is added in the implementation of atk_table_ref_at().

* DumpRenderTree/atk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::cellForColumnAndRow): Call g_object_unref
before returning the new instance of AccessibilityUIElement.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.

LayoutTests:

Added new test. It should work fine at least in Mac and GTK ports,
but will need specific results for chromium and windows.

* accessibility/table-cell-for-column-and-row-crash.html: Added.
* accessibility/table-cell-for-column-and-row-crash-expected.txt: Added.
* platform/chromium/TestExpectations: Skipped test.
* platform/win/TestExpectations: Ditto.
* platform/wincairo/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Update keyboard event details to match platform details.
mifenton@rim.com [Thu, 14 Feb 2013 17:11:13 +0000 (17:11 +0000)]
[BlackBerry] Update keyboard event details to match platform details.
https://bugs.webkit.org/show_bug.cgi?id=109693

Reviewed by Yong Li.

PR 220170.

Source/WebCore:

Update the keyboard event details to match the
platform details available.

Rename helper function to better describe the conversion.

Reviewed Internally by Nima Ghanavatian and Gen Mak.

* platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
(WebCore::windowsKeyCodeForBlackBerryKeycode):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

Source/WebKit/blackberry:

Update keyboard event details.

Reviewed Internally by Nima Ghanavatian and Gen Mak.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::keyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Reviewing TestExpectations. Added platform specific expected files and unskip...
kadam@inf.u-szeged.hu [Thu, 14 Feb 2013 17:06:11 +0000 (17:06 +0000)]
[Qt] Reviewing TestExpectations. Added platform specific expected files and unskip them.
https://bugs.webkit.org/show_bug.cgi?id=59334.

* platform/qt-5.0-wk2/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
* platform/qt/TestExpectations:
* platform/qt/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
* platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
* platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed rebaseline after brightness filter update.
fmalita@chromium.org [Thu, 14 Feb 2013 16:47:39 +0000 (16:47 +0000)]
[Chromium] Unreviewed rebaseline after brightness filter update.

* platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png:
* platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.png:
* platform/chromium-linux/css3/filters/effect-brightness-expected.png:
* platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png:
* platform/chromium-linux/css3/filters/effect-combined-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-hw-expected.png:
* platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png:
* platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png:
* platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.png:
* platform/chromium-win/css3/filters/effect-brightness-expected.png:
* platform/chromium-win/css3/filters/effect-brightness-hw-expected.png:
* platform/chromium-win/css3/filters/effect-combined-expected.png:
* platform/chromium-win/css3/filters/effect-combined-hw-expected.png:
* platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToo...
caseq@chromium.org [Thu, 14 Feb 2013 16:39:23 +0000 (16:39 +0000)]
Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToolsAgent
https://bugs.webkit.org/show_bug.cgi?id=109192

Reviewed by Pavel Feldman.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

- remove frame and compositing instrumentation methods from InspectorInstrumentation;
- expose those methods on InspectorController instead.

* WebCore.exp.in:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didBeginFrame):
(WebCore):
(WebCore::InspectorController::didCancelFrame):
(WebCore::InspectorController::willComposite):
(WebCore::InspectorController::didComposite):
* inspector/InspectorController.h:
(InspectorController):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
* testing/Internals.cpp:
(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore::Internals::emitInspectorDidCancelFrame):

Source/WebKit/blackberry:

- invoke frame instrumentation methods on InspectorController, not on InspectorInstrumentation.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
(BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):

Source/WebKit/chromium:

- expose frame and compositing insturmentation methods on WebDevToolsAgent;
- temporarily route them from WebViewImpl to WebDevToolsAgent;

* public/WebDevToolsAgent.h:
(WebDevToolsAgent):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::didBeginFrame):
(WebKit):
(WebKit::WebDevToolsAgentImpl::didCancelFrame):
(WebKit::WebDevToolsAgentImpl::willComposite):
(WebKit::WebDevToolsAgentImpl::didComposite):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::instrumentBeginFrame):
(WebKit::WebViewImpl::instrumentCancelFrame):
(WebKit::WebViewImpl::didBeginFrame):
(WebKit::WebViewImpl::willCommit):

Source/WebKit/win:

* WebKit.vcproj/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Fixed a layout regression in CanvasProfileView.
commit-queue@webkit.org [Thu, 14 Feb 2013 16:15:21 +0000 (16:15 +0000)]
Web Inspector: Fixed a layout regression in CanvasProfileView.
https://bugs.webkit.org/show_bug.cgi?id=109835

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-14
Reviewed by Pavel Feldman.

Changed splitView.css to supported nested SplitView instances.

* inspector/front-end/splitView.css:
(.split-view-vertical > .split-view-contents):
(.split-view-vertical > .split-view-contents-first):
(.split-view-vertical > .split-view-contents-first.maximized):
(.split-view-vertical > .split-view-contents-second):
(.split-view-vertical > .split-view-contents-second.maximized):
(.split-view-horizontal > .split-view-contents):
(.split-view-horizontal > .split-view-contents-first):
(.split-view-horizontal > .split-view-contents-first.maximized):
(.split-view-horizontal > .split-view-contents-second):
(.split-view-horizontal > .split-view-contents-second.maximized):
(.split-view-vertical > .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-vertical > .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-horizontal > .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-horizontal > .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-vertical > .split-view-resizer):
(.split-view-horizontal > .split-view-resizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnskip mediastream tests that are passing after webkit_support update
jochen@chromium.org [Thu, 14 Feb 2013 16:05:25 +0000 (16:05 +0000)]
Unskip mediastream tests that are passing after webkit_support update

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Color picker should not be available in Computed Styles pane.
commit-queue@webkit.org [Thu, 14 Feb 2013 15:15:17 +0000 (15:15 +0000)]
Web Inspector: Color picker should not be available in Computed Styles pane.
https://bugs.webkit.org/show_bug.cgi?id=109697

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-14
Reviewed by Alexander Pavlov.

Changed the parentPane parameter of WebInspector.ComputedStylePropertiesSection to the correct value
(the ComputedStyleSidebarPane instance).

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Add a setting to control scaling content to fit viewport
mnaganov@chromium.org [Thu, 14 Feb 2013 13:53:30 +0000 (13:53 +0000)]
[Chromium] Add a setting to control scaling content to fit viewport
https://bugs.webkit.org/show_bug.cgi?id=109584

Adds a setting called 'initializeAtMinimumPageScale'. By default,
it is set to 'true' which corresponds to Chrome on Android behavior--
adjust the page scale to make the content fit into the viewport
by width. When set to false, the setting instructs ChromeClientImpl to
set page scale to 1.0, unless the scale value is set by the page
in the viewport meta-tag.

Reviewed by Adam Barth.

* public/WebSettings.h:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setInitializeAtMinimumPageScale):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::initializeAtMinimumPageScale):
* tests/WebFrameTest.cpp:
* tests/data/viewport-2x-initial-scale.html: Added.
* tests/data/viewport-auto-initial-scale.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Skip flaky test after r140689.
kadam@inf.u-szeged.hu [Thu, 14 Feb 2013 13:39:54 +0000 (13:39 +0000)]
[Qt] Unreviewed gardening. Skip flaky test after r140689.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: don't create static local string for program literal in InspectorTimel...
yurys@chromium.org [Thu, 14 Feb 2013 13:19:18 +0000 (13:19 +0000)]
Web Inspector: don't create static local string for program literal in InspectorTimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=109811

Reviewed by Pavel Feldman.

Use const char* constant value instead of creating String from it in thread-unsafe
static local variable.

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r142808.
commit-queue@webkit.org [Thu, 14 Feb 2013 13:08:26 +0000 (13:08 +0000)]
Unreviewed, rolling out r142808.
http://trac.webkit.org/changeset/142808
https://bugs.webkit.org/show_bug.cgi?id=109816

Crashes on chromium webkit canary bots (Requested by atwilson_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTouchLinkNode):
(WebKit::WebViewImpl::enableTouchHighlight):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/LinkHighlightTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Web Inspector] Fix initiator name issue in reload scenario for Network Panel.
commit-queue@webkit.org [Thu, 14 Feb 2013 13:01:50 +0000 (13:01 +0000)]
[Web Inspector] Fix initiator name issue in reload scenario for Network Panel.
https://bugs.webkit.org/show_bug.cgi?id=108746.

Patch by Pan Deng <pan.deng@intel.com> on 2013-02-14
Reviewed by Vsevolod Vlasov.

WebInspector.displayNameForURL() does not work as expected in the reload scenario,
for example, "http://www.yahoo.com/" was trimed to "/" at one time, but at another,
the full host name will be displayed.
This fix return host + "/" in the issue scenario, and keep with get displayName() in ParsedURL.

No new tests.

* inspector/front-end/ParsedURL.js:
(WebInspector.ParsedURL.prototype.get displayName): append "/" in the display host scenario.
* inspector/front-end/ResourceUtils.js:
(WebInspector.displayNameForURL): add host in the head if url trimed as a "/".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: fix to record button remaining red after heap snapshot is taken
commit-queue@webkit.org [Thu, 14 Feb 2013 12:57:58 +0000 (12:57 +0000)]
Web Inspector: fix to record button remaining red after heap snapshot is taken
https://bugs.webkit.org/show_bug.cgi?id=109804

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-14
Reviewed by Yury Semikhatsky.

Revert part of r142243 fix. Namely heap snapshot taking button made
stateless as it was before.

* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Consistently use SecurityOrigin::toRawString() for serialization acros...
apavlov@chromium.org [Thu, 14 Feb 2013 12:47:16 +0000 (12:47 +0000)]
Web Inspector: Consistently use SecurityOrigin::toRawString() for serialization across the backend code
https://bugs.webkit.org/show_bug.cgi?id=109801

Reviewed by Yury Semikhatsky.

No new tests, as existing tests cover the change.

* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::notifyContextCreated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd logging support to IndexedDB for non-Chromium platforms
sergio@webkit.org [Thu, 14 Feb 2013 12:35:09 +0000 (12:35 +0000)]
Add logging support to IndexedDB for non-Chromium platforms
https://bugs.webkit.org/show_bug.cgi?id=109809

Reviewed by Kentaro Hara.

Enable logging of IndexedDB through the StorageAPI log channel for
non-Chromium architectures.

No new tests required, we're just enabling logging for IndexedDB
using the currently available logging framework.

* Modules/indexeddb/IDBTracing.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Remove uriForFile and fileForURI methods from FileSystemMapping.
vsevik@chromium.org [Thu, 14 Feb 2013 12:27:16 +0000 (12:27 +0000)]
Web Inspector: Remove uriForFile and fileForURI methods from FileSystemMapping.
https://bugs.webkit.org/show_bug.cgi?id=109704

Reviewed by Alexander Pavlov.

Source/WebCore:

Replaced this methods with one line implementation on the only call site.

* inspector/front-end/FileSystemMapping.js:
* inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype._filePathForURI):
(WebInspector.FileSystemProjectDelegate.prototype.setFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype._populate):

LayoutTests:

* inspector/file-system-mapping-expected.txt:
* inspector/file-system-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142867 268f45cc-cd09-0410-ab3c-d52691b4dbfc