WebKit-https.git
9 years agoUnreviewed, rolling out r112199.
commit-queue@webkit.org [Tue, 27 Mar 2012 05:32:16 +0000 (05:32 +0000)]
Unreviewed, rolling out r112199.
http://trac.webkit.org/changeset/112199
https://bugs.webkit.org/show_bug.cgi?id=82295

Breaks Chromium Win compilation (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-26

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
(GetDomMapFunction):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore):
* bindings/v8/V8DOMWrapper.h:
(WebCore):
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable CCLayerTreeHostTestSetSingleLostContext.runMultiThread.
senorblanco@chromium.org [Tue, 27 Mar 2012 05:09:25 +0000 (05:09 +0000)]
Disable CCLayerTreeHostTestSetSingleLostContext.runMultiThread.
https://bugs.webkit.org/show_bug.cgi?id=82285

Reviewed by James Robinson.

* tests/CCLayerTreeHostTest.cpp:
(WTF::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove WebMediaElement from Chromium WebKit API.
scherkus@chromium.org [Tue, 27 Mar 2012 04:41:38 +0000 (04:41 +0000)]
[chromium] Remove WebMediaElement from Chromium WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=82277

Reviewed by James Robinson.

This was added in r63859 but is no longer used by anyone.

* WebKit.gyp:
* public/WebMediaElement.h: Removed.
* src/WebMediaElement.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix flaky test fast/eventsource/eventsource-url-attribute.html
commit-queue@webkit.org [Tue, 27 Mar 2012 04:25:16 +0000 (04:25 +0000)]
Fix flaky test fast/eventsource/eventsource-url-attribute.html
https://bugs.webkit.org/show_bug.cgi?id=82257

Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-26
Reviewed by Ryosuke Niwa.

The test used http://localhost, chosen as a semi-random url, but since
it doesn't return a text/event-stream mime-type sometimes a console
warning would appear. Moved the test to the http folder and changed it
to use a resource with the correct mime-type.

* http/tests/eventsource/eventsource-url-attribute-expected.txt: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute-expected.txt.
* http/tests/eventsource/eventsource-url-attribute.html: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild system prep work for upstreaming iOS changes
ddkilzer@apple.com [Tue, 27 Mar 2012 03:58:35 +0000 (03:58 +0000)]
Build system prep work for upstreaming iOS changes
<http://webkit.org/b/82267>

Reviewed by Mark Rowe.

* DerivedSources.make: Move 'bison' into a variable and use
xcrun to find it on Mac OS X.
* bindings/scripts/preprocessor.pm:
(applyPreprocessor): Add local @args variable.  On iOS, the
compiler needs additional "-isysroot $(SDKROOT)" arguments when
invoked, so it's easier to add them to an array, especially if
$SDKROOT contains a space in the path.  Remove now-redundant
$gccLocation variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExtract logic of indexeddb html layout tests into js files that can
dgrogan@chromium.org [Tue, 27 Mar 2012 03:50:43 +0000 (03:50 +0000)]
Extract logic of indexeddb html layout tests into js files that can
be run from either a worker or a window.

The two changed -expected.txt files are just for line numbers in JS
error messages.

Skipped were:
- transaction-abort-with-js-recursion.html
- transaction-abort-with-js-recursion-cross-frame.html
- noblobs.html
- structured-clone.html
- tutorial.html
The first four simulate mouse events and the last isn't really a test.
structured-clone.html will be refactored for worker compatibility in a
future patch.

https://bugs.webkit.org/show_bug.cgi?id=81440

Reviewed by Tony Chang.

* storage/indexeddb/constants.html:
* storage/indexeddb/create-and-remove-object-store.html:
* storage/indexeddb/create-object-store-options.html:
... every html file in storage/indexeddb except the ones listed above

* storage/indexeddb/exception-in-event-aborts-expected.txt:
line number in javascript error message changed
* storage/indexeddb/version-change-abort-expected.txt:
line number in javascript error message changed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove duplicate error() impls in CachedResource subclasses
japhet@chromium.org [Tue, 27 Mar 2012 03:50:00 +0000 (03:50 +0000)]
Remove duplicate error() impls in CachedResource subclasses
https://bugs.webkit.org/show_bug.cgi?id=81161

Reviewed by Alexey Proskuryakov.

No new tests, refactor only.

* loader/cache/CachedCSSStyleSheet.cpp:
* loader/cache/CachedCSSStyleSheet.h:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedFont.h:
* loader/cache/CachedImage.cpp:
* loader/cache/CachedResource.h: Make checkNotify()
     virtual, so the right checkNotify() gets called in error().
* loader/cache/CachedScript.cpp:
* loader/cache/CachedScript.h:
* loader/cache/CachedXSLStyleSheet.cpp:
* loader/cache/CachedXSLStyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssert failure from capitalized RenderTextFragment
commit-queue@webkit.org [Tue, 27 Mar 2012 03:16:34 +0000 (03:16 +0000)]
Assert failure from capitalized RenderTextFragment
https://bugs.webkit.org/show_bug.cgi?id=82096

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-03-26
Reviewed by Ryosuke Niwa.

Source/WebCore:

The cause of this bug was the call to RenderTextFragment::setTextInternal
resulting from a style change from RenderObject::addChild. The idea here
is to better separate the code path for transforming existing text from
the code path for replacing the underlying text of a node. For
RenderTextFragment this has to be clear because only in the latter case
does the first-letter get reset.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild): Added call to transformText
* rendering/RenderText.cpp:
(WebCore::RenderText::styleDidChange): Added call to transformText
(WebCore::RenderText::transformText): Added
* rendering/RenderText.h:
(WebCore::RenderText::setText): Changed to virtual so RenderTextFragment can override
(WebCore::RenderText::transformText): Added
* rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::styleDidChange): Removed references to
m_allowFragmentReset which was the previous approach to separating the
code paths
(WebCore::RenderTextFragment::setTextInternal): Deleted
(WebCore::RenderTextFragment::setText): Added with most of logic that was
previously in setTextInternal
(WebCore::RenderTextFragment::transformText): Added
* rendering/RenderTextFragment.h:
(WebCore::RenderTextFragment::setText): Added
(WebCore::RenderTextFragment::transformText): Added
(WebCore::RenderTextFragment::setTextInternal): Deleted

LayoutTests:

Test that exercises failure condition in bug 82096.

* fast/css/first-letter-capitalized-edit-select-crash-expected.txt: Added
* fast/css/first-letter-capitalized-edit-select-crash.html: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAlways set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap...
adamk@chromium.org [Tue, 27 Mar 2012 02:58:28 +0000 (02:58 +0000)]
Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
https://bugs.webkit.org/show_bug.cgi?id=82256

Reviewed by Adam Barth.

This moves leakRef() calls out of generated code, centralizing them in
V8DOMWrapper implementation. Ideally, WeakReferenceMap::set would take
PassRefPtrs, but that's tricky given that some WeakReferenceMap's KeyType is 'void'
(which clearly can't be wrapped in a PassRefPtr).

Updated binding tests to reflect changes in CodeGeneratorV8.pm, no change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback): Use GetDomMapFunction instead of custom logic.
(GenerateNamedConstructorCallback): ditto.
(GenerateToV8Converters): Call V8DOMWrapper::setJSWrapper* method
instead of directly accessing the wrapper maps and calling set.
(GetDomMapFunction): Refactored to call new GetDomWrapperMapName function.
(GetDomWrapperMapName): Helper pulled out of GetDomMapFunction.
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
* bindings/v8/V8DOMWrapper.cpp: Moved setJSWrapperForDOMNode method to header to inline it.
* bindings/v8/V8DOMWrapper.h:
(WebCore): Forward decls.
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Made inline.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): ditto.
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Refactored into two methods;
this one handles non-active Nodes.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): Pulled out of previouse
DOMNode method, now handles only active Nodes.
(WebCore::V8DOMWrapper::setJSWrapperForDOMSVGElementInstance): New helper method for SVGElementInstances.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typo in method name - WebCore::miminumValueForLength should be WebCore::minimumVa...
psolanki@apple.com [Tue, 27 Mar 2012 02:45:03 +0000 (02:45 +0000)]
Fix typo in method name - WebCore::miminumValueForLength should be WebCore::minimumValueForLength
https://bugs.webkit.org/show_bug.cgi?id=82254

Reviewed by Benjamin Poulain.

Source/WebCore:

No new tests because no functional changes.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/LengthFunctions.cpp:
(WebCore::minimumValueForLength):
(WebCore::valueForLength):
* css/LengthFunctions.h:
(WebCore):
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getRegion):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::paint):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
* rendering/RenderInline.cpp:
(WebCore::computeMargin):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
* rendering/RenderScrollbarPart.cpp:
(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
* rendering/RenderText.h:
(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):
* rendering/style/RenderStyle.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTriggers assertion if dragging from outside of <meter> in a shadow tree to inside...
shinyak@chromium.org [Tue, 27 Mar 2012 02:42:48 +0000 (02:42 +0000)]
Triggers assertion if dragging from outside of <meter> in a shadow tree to inside of it.
https://bugs.webkit.org/show_bug.cgi?id=82177

Reviewed by Dimitri Glazkov.

Source/WebCore:

VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries has moved the start position or
the end position to the invalid position, i.e. position after (before) the non-existing node.

This patch fixes the problem, and adds assertion that the selection does not cross shadow boundaries.

Test: fast/dom/shadow/drag-to-meter-in-shadow-crash.html

* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):

LayoutTests:

* fast/dom/shadow/drag-to-meter-in-shadow-crash-expected.txt: Added.
* fast/dom/shadow/drag-to-meter-in-shadow-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable layout testing of the scroll animator.
commit-queue@webkit.org [Tue, 27 Mar 2012 02:41:20 +0000 (02:41 +0000)]
Enable layout testing of the scroll animator.
https://bugs.webkit.org/show_bug.cgi?id=81858
Add a call to the InternalSettings that layout tests can use to
turn on scroll animation. Enable animation updates for the
Chromium platform DRT when scroll animation has been turned on in
a test. This should be a no-op for all current layout tests.

Patch by Scott Byer <scottbyer@chromium.org> on 2012-03-26
Reviewed by James Robinson.

Source/WebCore:

No new tests. Layout test results should be unchanged.

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setEnableScrollAnimator):
(WebCore):
(WebCore::InternalSettings::scrollAnimatorEnabled):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::scrollAnimatorEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::serviceAnimation):
(WebViewHost::scheduleAnimation):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Support multi-file upload
commit-queue@webkit.org [Tue, 27 Mar 2012 02:29:41 +0000 (02:29 +0000)]
[Qt][WK2] Support multi-file upload
https://bugs.webkit.org/show_bug.cgi?id=81589

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-26
Reviewed by Simon Hausmann.

Source/WebKit2:

Added 'allowMutipleFiles' property to filePicker context property to indicate whether to allow
multiple file selections.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::chooseFiles):
* UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_multiFileUpload.qml: Added.
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_singleFileUpload.qml:
* UIProcess/API/qt/tests/qmltests/common/multifileupload.html: Added.
* UIProcess/API/qt/tests/qmltests/common/singlefileupload.html:
* UIProcess/API/qt/tests/qmltests/common/titleupdate.js: Added.
(updateTitle):
* UIProcess/qt/QtDialogRunner.cpp:
(FilePickerContextObject):
(FilePickerContextObject::FilePickerContextObject):
(FilePickerContextObject::allowMultipleFiles):
(FilePickerContextObject::accept):
(QtDialogRunner::initForFilePicker):
* UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner):

Tools:

Modified filePicker to support multi-file upload.

* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/icons/checkbox_checked.png: Added.
* MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
* MiniBrowser/qt/js/MultiSelect.js: Added.
(values):
(isSelected):
(removeValue):
* MiniBrowser/qt/qml/CheckBox.qml: Added.
* MiniBrowser/qt/qml/FilePicker.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix minor spell error in DocumentLoader.h
charles.wei@torchmobile.com.cn [Tue, 27 Mar 2012 02:17:23 +0000 (02:17 +0000)]
Fix minor spell error in DocumentLoader.h
https://bugs.webkit.org/show_bug.cgi?id=82141

Reviewed by Nate Chapin.

Just fix spell error, no new tests.

* loader/DocumentLoader.h:
(WebCore::DocumentLoader::setClientRedirectSourceForHistory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Skia] Remove use of deprecated Skia constant and struct field names
commit-queue@webkit.org [Tue, 27 Mar 2012 02:13:08 +0000 (02:13 +0000)]
[Skia] Remove use of deprecated Skia constant and struct field names
https://bugs.webkit.org/show_bug.cgi?id=81034

Patch by Brian Salomon <bsalomon@google.com> on 2012-03-26
Reviewed by James Robinson.

No behavior change, so no tests. The modified code is executed by many existing tests.

* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::createAcceleratedCanvas):
* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
(WebCore::CCRenderSurfaceFilters::apply):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnaligned userspace access for SH4 platforms
commit-queue@webkit.org [Tue, 27 Mar 2012 02:03:47 +0000 (02:03 +0000)]
Unaligned userspace access for SH4 platforms
https://bugs.webkit.org/show_bug.cgi?id=79104

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-03-26
Reviewed by Gavin Barraclough.

* assembler/AbstractMacroAssembler.h:
(Jump):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::load32WithUnalignedHalfWords):
(JSC::MacroAssemblerSH4::branchDouble):
(JSC::MacroAssemblerSH4::branchTrue):
(JSC::MacroAssemblerSH4::branchFalse):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::extraInstrForBranch):
(SH4Assembler):
(JSC::SH4Assembler::bra):
(JSC::SH4Assembler::linkJump):
* jit/JIT.h:
(JIT):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add isInputThrottled/didBecomeReadyForAdditionalInput to WebWidget
nduca@chromium.org [Tue, 27 Mar 2012 02:01:42 +0000 (02:01 +0000)]
[chromium] Add isInputThrottled/didBecomeReadyForAdditionalInput to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=82265

Source/Platform:

Reviewed by James Robinson.

* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
* chromium/public/WebLayerTreeViewClient.h:
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::didCommit):

Source/WebCore:

In threaded compositing mode, the WebWidget is self-scheduled,
receiving damage and processing it without forwarding that damage
up to the embedding WebWidgetClient. In Chromium's case, the
client uses the presence of damage to perform input flow
control. This patch exposes the need for input flow control to the
embedder, while keeping the actual logic about what exactly
warrants input flow control inside the implementation.

Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::commitRequested):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHostClient):
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::commitRequested):
(WebCore):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitRequested):
(WebCore):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

In threaded compositing mode, the WebWidget is self-scheduled,
receiving damage and processing it without forwarding that damage
up to the embedding WebWidgetClient. In Chromium's case, the
client uses the presence of damage to perform input flow
control. This patch exposes the need for input flow control to the
embedder, while keeping the actual logic about what exactly
warrants input flow control inside the implementation.

Reviewed by James Robinson.

* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::isInputThrottled):
* public/WebWidgetClient.h:
(WebWidgetClient):
(WebKit::WebWidgetClient::didBecomeReadyForAdditionalInput):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::commitRequested):
(WebKit):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::didCommit):
(WebKit):
* src/WebLayerTreeViewImpl.h:
(WebLayerTreeViewImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::isInputThrottled):
(WebKit):
(WebKit::WebViewImpl::didCommit):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::didCommit):
(MockLayerTreeHostClient):
* tests/FakeCCLayerTreeHostClient.h:
(FakeCCLayerTreeHostClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhen <img crossorigin> fails the CORS check, we should fire the error event
abarth@webkit.org [Tue, 27 Mar 2012 01:59:06 +0000 (01:59 +0000)]
When <img crossorigin> fails the CORS check, we should fire the error event
https://bugs.webkit.org/show_bug.cgi?id=81998

Reviewed by Nate Chapin.

Source/WebCore:

The spec says we're supposed to fire the error event when the CORS
check fails, but we haven't been.  This patch is larger than it might
otherwise be because we're firing the event asynchronously, but that
seems like the right thing to do.

Tests: http/tests/security/img-with-failed-cors-check-fails-to-load.html

* dom/Document.cpp:
(WebCore::Document::implicitClose):
* loader/ImageLoader.cpp:
(WebCore::errorEventSender):
(WebCore):
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::dispatchPendingEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvents):
* loader/ImageLoader.h:
(ImageLoader):

LayoutTests:

Check that we're firing the error event in this case.

* http/tests/security/img-with-failed-cors-check-fails-to-load-expected.txt:
* http/tests/security/img-with-failed-cors-check-fails-to-load.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRetry crashing tests serially at the end of NRWT on Apple Mac
mhahnenberg@apple.com [Tue, 27 Mar 2012 01:56:17 +0000 (01:56 +0000)]
Retry crashing tests serially at the end of NRWT on Apple Mac
https://bugs.webkit.org/show_bug.cgi?id=82233

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.should_retry_crashes):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.should_retry_crashes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline after r112177.
rniwa@webkit.org [Tue, 27 Mar 2012 01:32:23 +0000 (01:32 +0000)]
Rebaseline after r112177.

* fast/dom/css-dom-read-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake filters and the threaded compositor play well together.
senorblanco@chromium.org [Tue, 27 Mar 2012 01:31:50 +0000 (01:31 +0000)]
Make filters and the threaded compositor play well together.
https://bugs.webkit.org/show_bug.cgi?id=78139

Use a dedicated GraphicsContext3D instance for all filters calls in
the threaded case.  Clone all FilterOperations for thread safety
in the threaded case.

Reviewed by James Robinson.

Covered by tests in LayoutTests/css3/filters.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setFilters):
Set a global flag if we've seen content with filters, so we know
we need to create the filter context.
(WebCore::LayerChromium::pushPropertiesTo):
Clone all filter operations if we're in the threaded case.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::needsFilterContext):
(WebCore::CCLayerTreeHost::setNeedsFilterContext):
(CCLayerTreeHost):
Add flag and accessors for needsFilterContext.
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::applyFilters):
Pick up the appropriate context from SharedGraphicsContext3D,
depending if we're in the threaded case or not.
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::recreateContext):
For the threaded compositor re-create the filter context
alongside the main compositor context on lost context, if requested.
(WebCore::CCThreadProxy::beginFrame):
Create the filter context in beginFrame, if it was resquested and is
NULL.  This handles the first-use case.
* platform/graphics/filters/CustomFilterOperation.h:
(WebCore::CustomFilterOperation::clone):
Assert if trying to clone the custom filter operation (it has
non-threadsafe members).
* platform/graphics/filters/FilterOperation.h:
(WebCore::DefaultFilterOperation::clone):
(WebCore::PassthroughFilterOperation::clone):
(WebCore::ReferenceFilterOperation::clone):
(WebCore::BasicColorMatrixFilterOperation::clone):
(WebCore::BasicComponentTransferFilterOperation::clone):
(WebCore::GammaFilterOperation::clone):
(WebCore::BlurFilterOperation::clone):
(WebCore::DropShadowFilterOperation::clone):
Add clone methods for all FilterOperations.
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3DImpl::getOrCreateContext):
(WebCore::SharedGraphicsContext3DImpl::getContext):
(WebCore::SharedGraphicsContext3DImpl::createContext):
(WebCore::SharedGraphicsContext3D::get):
(WebCore::getOrCreateContextForImplThread):
(WebCore::SharedGraphicsContext3D::getForImplThread):
(WebCore::SharedGraphicsContext3D::haveForImplThread):
(WebCore::SharedGraphicsContext3D::createForImplThread):
Split out context creation, lost context recovery, and retrieval
into separate functions, so the impl thread can use only the parts
it wants on the threads it wants (create and have on main, get on impl).
Add asserts to ensure that's how they're called.
* platform/graphics/gpu/SharedGraphicsContext3D.h:
(SharedGraphicsContext3D):
Reuse the SharedGraphicsContext infrastructure to create a new
context singleton for filter use in the threaded compositor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSet eol-style: native on WTF.sln per Ryan Sleevi's request.
rniwa@webkit.org [Tue, 27 Mar 2012 01:21:51 +0000 (01:21 +0000)]
Set eol-style: native on WTF.sln per Ryan Sleevi's request.

* WTF.vcproj/WTF.sln: Added property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium build fix; add BitVector.h/cpp to gypi.
rniwa@webkit.org [Tue, 27 Mar 2012 01:12:31 +0000 (01:12 +0000)]
Chromium build fix; add BitVector.h/cpp to gypi.

* WTF.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFrameLoader::shouldAllowNavigation uses Frame for context rather than Document
abarth@webkit.org [Tue, 27 Mar 2012 01:09:43 +0000 (01:09 +0000)]
FrameLoader::shouldAllowNavigation uses Frame for context rather than Document
https://bugs.webkit.org/show_bug.cgi?id=81020

Reviewed by Eric Seidel.

Source/WebCore:

The vast majority of security checks in the browser should use a
ScriptExecutionContext (aka a Document) to designate "who" is
attempting to perform a given action.  Unfortunately,
shouldAllowNavigation was using a Frame to designate "who" is
attempting the navigation.

In cases when the executing script is "inactive" (i.e., belongs to a
document that is not currently displayed in a Frame), using the Frame
can cause us to grant the script the privileges of the document that's
currently displayed in the Frame rather than the one that contains the
script.

This patch moves shouldAllowNavigation from FrameLoader to Document
(and renames it to canNavigate), effectively change the context object
from a Frame to a Document.

Test: http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html

* bindings/generic/BindingSecurity.h:
(BindingSecurity):
(WebCore):
* bindings/v8/V8Utilities.cpp:
(WebCore):
* bindings/v8/V8Utilities.h:
(WebCore):
    - Deletes unused code.
* dom/Document.cpp:
(WebCore::canAccessAncestor):
(WebCore):
(WebCore::Document::canNavigate):
    - canNavigate is copied from FrameLoader::shouldAllowNavigation.
      I've added a null-check bailout if the document is inactive.
* dom/Document.h:
(Document):
* loader/FormState.cpp:
(WebCore::FormState::FormState):
(WebCore::FormState::create):
* loader/FormState.h:
(WebCore):
(FormState):
(WebCore::FormState::sourceDocument):
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
    - Changes the context object from Frame to Document.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore):
(WebCore::FrameLoader::findFrameForNavigation):
    - FrameLoader::findFrameForNavigation still incorrectly uses Frame
      as the context object, but that's a bug for another patch.
(WebCore::createWindow):
* loader/FrameLoader.h:
(FrameLoader):
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledFormSubmission::fire):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::open):
* page/History.cpp:
(WebCore::History::go):

Source/WebKit/mac:

Update call site to new function name.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchWillSubmitForm):

Source/WebKit/win:

Update call site to new function name.

* WebFrame.cpp:
(WebFrame::dispatchWillSubmitForm):

Source/WebKit2:

Update call site to new function name.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

LayoutTests:

Test that a script from an inactive document doesn't inherit the
navigation privileges of the document that currently occupies the
frame.

* http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child-expected.txt: Added.
* http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html: Added.
* http/tests/security/frameNavigation/resources/fail.html: Added.
* http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html:
* http/tests/security/frameNavigation/resources/popup-ready-to-navigate-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTrigger a build on Chromium Linux boxes to see if clean builds succeed or not.
rniwa@webkit.org [Tue, 27 Mar 2012 01:02:54 +0000 (01:02 +0000)]
Trigger a build on Chromium Linux boxes to see if clean builds succeed or not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Simplify and fix CCLayerSorter
vangelis@chromium.org [Tue, 27 Mar 2012 00:16:30 +0000 (00:16 +0000)]
[chromium] Simplify and fix CCLayerSorter
https://bugs.webkit.org/show_bug.cgi?id=82114

Source/WebCore:

A significant cleanup, simplification and improvement of the CCLayerSorter code.
Simplified the LayerShape structure to use WebCore's FloatQuad for all overlap tests.
By treating every layer as two triangles, the old overlap code did a lot of redundant work
including testing two of the vertices of the layer and its diagonal twice. The new overlap
tests check:
1. The four corners of each of the two layers against the other layer.
2. The four edges of each layer against the edges of the other layer.
Unlike the old code, the new code has no early-outs in the overlap tests as those where causing
us to miss legitimate overlaps.
A new technique for breaking dependency cycles introduced by intersecting layers is implemented.
Instead of arbitrarily breaking cycles by choosing the node in the graph with the smallest number of
incoming edges (i.e. layers that need to be drawn before it) we chose the one with the smallest sum
of graph edge weights (defined as the max depth difference between two layers). Layers that intersect
have their respective graph edge weight set to zero, making them more likely to be picked for breaking
the cycles (it's not a perfect solution but it seems to perform much better than the previous one).

In addition to being overly complex and doing reduntant work, the old code was missing a
perspective divide when computing the coordinates of the layer's corners in the projected plane
which was the source of a lot of mis-sorted results.

In all, these improvements, fix a lot of outstanding issues with layer sorting, on pages such as:
http://www.keithclark.co.uk/labs/3dcss/demo/
http://2012.beercamp.com
https://developer.mozilla.org/fr/demos/detail/the-box/launch

Tests: CCLayerSorter unit tests.

Reviewed by Kenneth Russell.

* platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore):
(WebCore::perpProduct):
(WebCore::edgeEdgeTest):
(WebCore::CCLayerSorter::checkOverlap):
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::LayerShape::layerZFromProjectedPoint):
(WebCore::CCLayerSorter::createGraphNodes):
(WebCore::CCLayerSorter::createGraphEdges):
(WebCore::CCLayerSorter::sort):
* platform/graphics/chromium/cc/CCLayerSorter.h:
(WebCore::CCLayerSorter::CCLayerSorter):
(CCLayerSorter):
(LayerShape):
(WebCore::CCLayerSorter::GraphNode::GraphNode):
(GraphNode):
(WebCore::CCLayerSorter::GraphEdge::GraphEdge):
(GraphEdge):

Source/WebKit/chromium:

Adjustments to the CCLayerSorter unit tests to account for API changes in the
CCLayerSorter class.

Reviewed by Kenneth Russell.

* tests/CCLayerSorterTest.cpp:
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNRWT should retry failures serially
mhahnenberg@apple.com [Tue, 27 Mar 2012 00:12:49 +0000 (00:12 +0000)]
NRWT should retry failures serially
https://bugs.webkit.org/show_bug.cgi?id=82241

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests): Add another parameter to specify the number of workers to use.
(Manager.run): Run the failures serially.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTouch BitVector as a speculative fix for Chromium Linux.
rniwa@webkit.org [Tue, 27 Mar 2012 00:12:20 +0000 (00:12 +0000)]
Touch BitVector as a speculative fix for Chromium Linux.

* wtf/BitVector.h:
(BitVector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore Chromium rebaselines for assorted failing tests. Almost all of the differences
ojan@chromium.org [Tue, 27 Mar 2012 00:10:21 +0000 (00:10 +0000)]
More Chromium rebaselines for assorted failing tests. Almost all of the differences
are text rendering or antialiasing. Some of them are imperceptibly different shades
of a color for tests that aren't testing that (e.g the test tests clipping).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Using WebViewPlugins with --force-compositing-mode causes an ASSERT to...
fsamuel@chromium.org [Tue, 27 Mar 2012 00:09:12 +0000 (00:09 +0000)]
[Chromium] Using WebViewPlugins with --force-compositing-mode causes an ASSERT to fail
https://bugs.webkit.org/show_bug.cgi?id=81954

Reviewed by James Robinson.

A static variable s_inPaintContents is set when painting, and it ensures
that we don't delete GraphicsLayers or create GraphicsLayers while painting.

However, because this variable is static, it does not permit the existence
of multiple WebViews in different stages (one laying out and one painting).

This manifests itself if one attempts to use the --force-compositing-mode
in Chromium and attempts to navigate to a page with a missing or old plugin
or a browser plugin (which uses a WebViewPlugin as a placeholder until it's
done loading).

The solution to simplify debugging is to make this flag per-Page.
We can access Page from RenderLayerBacking which is a GraphicsLayerClient.
We add a new method GraphicsLayerClient::verifyNotPainting with a default
(do nothing) implementation and override it in RenderLayerBacking to
test the flag set in Page.

* page/Page.cpp:
(WebCore::Page::Page):
* page/Page.h:
(Page):
(WebCore::Page::setIsPainting):
(WebCore::Page::isPainting):
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
* platform/graphics/GraphicsLayerClient.h:
(GraphicsLayerClient):
(WebCore::GraphicsLayerClient::verifyNotPainting):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):
(WebCore):
(WebCore::RenderLayerBacking::verifyNotPainting):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocssText should use shorthand notations
rniwa@webkit.org [Mon, 26 Mar 2012 23:59:27 +0000 (23:59 +0000)]
cssText should use shorthand notations
https://bugs.webkit.org/show_bug.cgi?id=81737

Reviewed by Enrica Casucci.

Source/JavaScriptCore:

Export symbols of BitVector on Windows.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Source/WebCore:

Use shorthand properties to serialize style properties for cssText.

The overall algorithm is to look for any property that has a shorthand, and then check if
the shorthand value could be obtained (the condition is quite complicated for border properties).
If it could, then append that value to the string builder, and set the corresponding entries in
shorthandPropertyAppeared and shorthandPropertyUsed. If not, only turn on the bit in
shorthandPropertyAppeared on to avoid calling getPropertyValue again for longhand properties
that use the same shorthand property when we cannot use the shorthand.

Test: fast/css/cssText-shorthand.html

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):

Source/WTF:

* wtf/BitVector.h:
(BitVector):
(WTF::BitVector::ensureSizeAndSet): Added.

LayoutTests:

Rebaseline existing tests and add a regression test for unprefixed CSS properties with
the exception of -webkit-border-horizontal/vertical-spacing (the shorthand version of
these properties (border-spacing) is unprefixed.

* editing/pasteboard/paste-and-sanitize-expected.txt: Uses border instead of longhand
properties as desired.
* editing/pasteboard/paste-and-sanitize.html:
* editing/style/non-inheritable-styles-expected.txt: Ditto.
* fast/css/background-position-serialize-expected.txt: No longer emits "background-*:
initial" as desired.
* fast/css/cssText-shorthand-expected.txt: Added.
* fast/css/cssText-shorthand.html: Added.
* fast/css/remove-shorthand-expected.txt:
* fast/css/remove-shorthand.html: Modified to do elaborative comparison of the lists of
properties before and after removing a shorthand since now removing a shorthand property
may end up adding new longhand property.
* fast/css/uri-token-parsing-expected.txt:
* fast/css/uri-token-parsing.html: Uses shorthand properties instead of longhand equivalents.
* inspector/styles/styles-update-from-js-expected.txt: Ditto.
* printing/page-rule-css-text-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow expectations on directories in virtual test suites
enne@google.com [Mon, 26 Mar 2012 23:53:59 +0000 (23:53 +0000)]
Allow expectations on directories in virtual test suites
https://bugs.webkit.org/show_bug.cgi?id=82250

Reviewed by Dirk Pranke.

lookup_virtual_test_base was only returning valid results for files
and not directories. Fix by falling back to the virtual test suite
mapping if possible.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.lookup_virtual_test_base):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.skipped_tests):
(TestPort.virtual_test_suites):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNever remove root compositing layers in the web process
andersca@apple.com [Mon, 26 Mar 2012 23:42:17 +0000 (23:42 +0000)]
Never remove root compositing layers in the web process
https://bugs.webkit.org/show_bug.cgi?id=82255
<rdar://problem/11058521>

Reviewed by Sam Weinig.

Since we never leave accelerated compositing mode when using tiled drawing, we should
never remove root compositing layers in the web process.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add Android keycodes
commit-queue@webkit.org [Mon, 26 Mar 2012 23:39:27 +0000 (23:39 +0000)]
[Chromium] Add Android keycodes
https://bugs.webkit.org/show_bug.cgi?id=81950

Add the missing Android keycodes listed in the bug.

Patch by Bolin Hsu <bhsu@google.com> on 2012-03-26
Reviewed by Adam Barth.

* platform/chromium/KeyCodeConversionAndroid.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
* platform/chromium/KeyboardCodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix duplicated ChangeLog entry from r112171.
dpranke@chromium.org [Mon, 26 Mar 2012 23:39:02 +0000 (23:39 +0000)]
Fix duplicated ChangeLog entry from r112171.

Unreviewed, build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch ColumnInfo::addForcedBreak to LayoutUnits
leviw@chromium.org [Mon, 26 Mar 2012 23:37:44 +0000 (23:37 +0000)]
Switch ColumnInfo::addForcedBreak to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=82210

Reviewed by Eric Seidel.

Forced breaks are added by local offsets, which should be in LayoutUnits.

No new tests. No change in behavior.

* rendering/ColumnInfo.h:
(WebCore::ColumnInfo::addForcedBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotest-webkitpy: split test-finding code into a different module
dpranke@chromium.org [Mon, 26 Mar 2012 23:36:06 +0000 (23:36 +0000)]
test-webkitpy: split test-finding code into a different module
https://bugs.webkit.org/show_bug.cgi?id=82253

Reviewed by Adam Barth.

Per suggestion from abarth, this change splits all the
filesystem-crawling, test-finding code in test-webkitpy out into
a separate module and switches to using a FileSystem object.
This makes things much more testable, so we also add tests :).

We also add a realpath() method to the Filesystem object, since
test-webkitpy needs that in order to be able to resolve symlinks
properly to determine whether a file is under a particular tree
or not.

* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.realpath):
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.realpath):
* Scripts/webkitpy/test/main.py:
(Tester.__init__):
(Tester.add_tree):
(Tester.run):
(Tester._run_tests):
(Tester._log_exception):
* Scripts/webkitpy/test/test_finder.py: Added.
(TestDirectoryTree):
(TestDirectoryTree.__init__):
(TestDirectoryTree.find_modules):
(TestDirectoryTree.find_modules.file_filter):
(TestDirectoryTree.to_module):
(TestDirectoryTree.clean):
(TestFinder):
(TestFinder.__init__):
(TestFinder.add_tree):
(TestFinder.additional_paths):
(TestFinder.clean_trees):
(TestFinder.is_module):
(TestFinder.to_module):
(TestFinder.find_names):
(TestFinder._exclude):
* Scripts/webkitpy/test/test_finder_unittest.py: Added.
(TestFinderTest):
(TestFinderTest.setUp):
(TestFinderTest.tearDown):
(TestFinderTest.test_additional_system_paths):
(TestFinderTest.test_is_module):
(TestFinderTest.test_to_module):
(TestFinderTest.test_clean):
(TestFinderTest.test_find_names):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate LayoutUnit usage in ContainerNode, Element, and ElementRareData
leviw@chromium.org [Mon, 26 Mar 2012 23:35:04 +0000 (23:35 +0000)]
Update LayoutUnit usage in ContainerNode, Element, and ElementRareData
https://bugs.webkit.org/show_bug.cgi?id=82219

Reviewed by Eric Seidel.

No new tests. No change in behavior.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::getLowerRightCorner): linesBoundingBox returns the enclosing IntRect
of the contained lines. Inline's aren't bounded in LayoutUnits nor pixel snapped.
* dom/Element.cpp:
(WebCore::Element::boundsInRootViewSpace): Coordinates in root view space are akin to absolute
coordinates, which are always expressed in integers.
* dom/Element.h:
(Element):
* dom/ElementRareData.h:
(WebCore::defaultMinimumSizeForResizing): Using numeric_limits<LayoutUnit>::max instead of
INT_MAX to avoid overflowing when LayoutUnits are sub-pixel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test_expectations update for chromium.
eae@chromium.org [Mon, 26 Mar 2012 23:33:58 +0000 (23:33 +0000)]
Unreviewed test_expectations update for chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotest-webkitpy: split test-finding code into a different module
dpranke@chromium.org [Mon, 26 Mar 2012 23:31:05 +0000 (23:31 +0000)]
test-webkitpy: split test-finding code into a different module
https://bugs.webkit.org/show_bug.cgi?id=82253

Reviewed by Adam Barth.

Per suggestion from abarth, this change splits all the
filesystem-crawling, test-finding code in test-webkitpy out into
a separate module and switches to using a FileSystem object.
This makes things much more testable, so we also add tests :).

We also add a realpath() method to the Filesystem object, since
test-webkitpy needs that in order to be able to resolve symlinks
properly to determine whether a file is under a particular tree
or not.

* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.realpath):
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.realpath):
* Scripts/webkitpy/test/main.py:
(Tester.__init__):
(Tester.add_tree):
(Tester.run):
(Tester._run_tests):
(Tester._log_exception):
* Scripts/webkitpy/test/test_finder.py: Added.
(TestDirectoryTree):
(TestDirectoryTree.__init__):
(TestDirectoryTree.find_modules):
(TestDirectoryTree.find_modules.file_filter):
(TestDirectoryTree.to_module):
(TestDirectoryTree.clean):
(TestFinder):
(TestFinder.__init__):
(TestFinder.add_tree):
(TestFinder.additional_paths):
(TestFinder.clean_trees):
(TestFinder.is_module):
(TestFinder.to_module):
(TestFinder.find_names):
(TestFinder._exclude):
* Scripts/webkitpy/test/test_finder_unittest.py: Added.
(TestFinderTest):
(TestFinderTest.setUp):
(TestFinderTest.tearDown):
(TestFinderTest.test_additional_system_paths):
(TestFinderTest.test_is_module):
(TestFinderTest.test_to_module):
(TestFinderTest.test_clean):
(TestFinderTest.test_find_names):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate binding test output for V8 after r112163.
adamk@chromium.org [Mon, 26 Mar 2012 23:05:29 +0000 (23:05 +0000)]
Update binding test output for V8 after r112163.

* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::constructorCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate localSelectionRect to return a LayoutRect
leviw@chromium.org [Mon, 26 Mar 2012 23:01:23 +0000 (23:01 +0000)]
Update localSelectionRect to return a LayoutRect
https://bugs.webkit.org/show_bug.cgi?id=82183

Reviewed by Eric Seidel.

localSelectionRect returns a rectangle in the coordinate space of its renderer,
and therefor should remain LayoutUnits until being promoted to absolute
coordinates or painted. Also fixing an incorrect conversion of startPos and
endPos in selectionRectForRepaint.

No new tests. No change in behavior.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::localSelectionRect): Continuing to use enclosingIntRect
for the value being returned from the font engine since these floating point
values should not be pixel snapped.
* rendering/InlineTextBox.h:
(InlineTextBox):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::localSelectionRect):
* rendering/RenderReplaced.h:
(RenderReplaced):
* rendering/RenderText.cpp:
(WebCore::localQuadForTextBox):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::selectionRectForRepaint): Fixing an incorrect conversion of
start/endPos to LayoutUnits. These values represent a range of selected characters,
not layout values!
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::localSelectionRect):
* rendering/svg/SVGInlineTextBox.h:
(SVGInlineTextBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Crash in Canvas2DLayerChromium::pushPropertiesTo
commit-queue@webkit.org [Mon, 26 Mar 2012 22:59:53 +0000 (22:59 +0000)]
[Chromium] Crash in Canvas2DLayerChromium::pushPropertiesTo
https://bugs.webkit.org/show_bug.cgi?id=82243

Patch by Justin Novosad <junov@chromium.org> on 2012-03-26
Reviewed by James Robinson.

Adding null pointer check to prevent crash and texture object
validity check to prevent potential graphics glitch

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG should assert that argument value recoveries can only be
fpizlo@apple.com [Mon, 26 Mar 2012 22:58:35 +0000 (22:58 +0000)]
DFG should assert that argument value recoveries can only be
AlreadyInRegisterFile or Constant
https://bugs.webkit.org/show_bug.cgi?id=82249

Reviewed by Michael Saboff.

Made the assertions that the DFG makes for argument value recoveries match
what Arguments expects.

* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::isConstant):
(ValueRecovery):
(JSC::ValueRecovery::isAlreadyInRegisterFile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse PassRefPtr in V8DOMWrapper interface to avoid explicit ref() calls
adamk@chromium.org [Mon, 26 Mar 2012 22:57:22 +0000 (22:57 +0000)]
Use PassRefPtr in V8DOMWrapper interface to avoid explicit ref() calls
https://bugs.webkit.org/show_bug.cgi?id=82238

Reviewed by Adam Barth.

The setJSWrapper* methods previously featured a comment that asked
callers to ref the objects before passing them in. This change makes
that contract explicit (and allows the removal of the comment).

In addition, for ConstructorCallbacks, this change slightly reduces
refcount churn by passing on the initial ref via RefPtr::release().

No new tests, no change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref() call.
(GenerateNamedConstructorCallback): ditto.
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow): Cast to a PassRefPtr and remove explicit ref call.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Pass leaked refs into the DOMNodeMaps.
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper): Make the setJSWrapperFor* methods take PassRefPtr<T>.
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Pass leaked ref into the DOMObjectMap.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): Pass leaked ref into the ActiveDOMObjectMap.
* bindings/v8/V8Proxy.h:
(WebCore::toV8): Remove explicit ref.
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Cast to a PassRefPTr and remove explicit ref call.
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref.
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::constructorCallback): ditto.
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback): ditto.
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Remove obsolete FormDataStreamMac code
ap@apple.com [Mon, 26 Mar 2012 22:51:32 +0000 (22:51 +0000)]
    Remove obsolete FormDataStreamMac code
        https://bugs.webkit.org/show_bug.cgi?id=82244

        Reviewed by Brady Eidson.

        * platform/network/ResourceHandle.h:
        Removed ResourceHandle::didSendBodyDataDelegateExists().

        * platform/network/mac/FormDataStreamMac.h:
        * platform/network/mac/FormDataStreamMac.mm:
        Removed code that was needed to call ResourceLoaderClient::didSendData() before Foundation
        added support for it.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::cancel):
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
        (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
        (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
        We no longer need to associate streams with ResourceHandles!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoV8RecursionScope should not hold a raw pointer to ScriptExecutionContext
adamk@chromium.org [Mon, 26 Mar 2012 22:49:27 +0000 (22:49 +0000)]
V8RecursionScope should not hold a raw pointer to ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=82222

Reviewed by Eric Seidel.

Source/WebCore:

Instead of holding onto ScriptExecutionContext, cache the boolean value we
care about (context->isDocument()). This avoids problems if the
context goes away as a result of the script we just ran.

Test: fast/frames/subframe-load-js-url-crash.html

* bindings/v8/V8RecursionScope.cpp:
(WebCore::V8RecursionScope::didLeaveScriptContext): Check the cached
bool instead of calling into the context.
* bindings/v8/V8RecursionScope.h:
(WebCore::V8RecursionScope::V8RecursionScope): Call isDocument from
the constructor and cache the result.
(WebCore::V8RecursionScope::~V8RecursionScope): No longer need to pass
anything to didLeaveScriptContext since it's now a member.
(V8RecursionScope): Make didLeaveScriptContext a member function and
remove its argument. Add member bool to hold the value of isDocument.

LayoutTests:

* fast/frames/resources/subframe-load-js-url-crash-iframe.html: Added.
* fast/frames/subframe-load-js-url-crash-expected.txt: Added.
* fast/frames/subframe-load-js-url-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unreviewed gardening i fast/frames, fast/html and
kubo@profusion.mobi [Mon, 26 Mar 2012 22:47:29 +0000 (22:47 +0000)]
[EFL] Unreviewed gardening i fast/frames, fast/html and
fast/lists.

* platform/efl/Skipped:
* platform/efl/fast/frames/001-expected.png:
* platform/efl/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png:
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png:
* platform/efl/fast/frames/flattening/iframe-flattening-nested-expected.png:
* platform/efl/fast/frames/frame-navigation-expected.png:
* platform/efl/fast/frames/frame-scrolling-attribute-expected.png:
* platform/efl/fast/frames/frameset-style-recalc-expected.png:
* platform/efl/fast/frames/iframe-scrolling-attribute-expected.png:
* platform/efl/fast/frames/iframe-with-frameborder-expected.png:
* platform/efl/fast/frames/onlyCommentInIFrame-expected.png:
* platform/efl/fast/frames/viewsource-attribute-expected.png:
* platform/efl/fast/frames/viewsource-on-image-file-expected.png:
* platform/efl/fast/html/details-add-child-1-expected.png: Added.
* platform/efl/fast/html/details-add-child-2-expected.png: Added.
* platform/efl/fast/html/details-add-details-child-1-expected.png: Added.
* platform/efl/fast/html/details-add-details-child-2-expected.png: Added.
* platform/efl/fast/html/details-add-summary-1-and-click-expected.png: Copied from LayoutTests/platform/efl/fast/lists/li-br-expected.png.
* platform/efl/fast/html/details-add-summary-1-expected.png: Copied from LayoutTests/platform/efl/fast/lists/li-br-expected.png.
* platform/efl/fast/html/details-add-summary-10-and-click-expected.png: Added.
* platform/efl/fast/html/details-add-summary-10-expected.png: Added.
* platform/efl/fast/html/details-add-summary-2-and-click-expected.png: Added.
* platform/efl/fast/html/details-add-summary-2-expected.png: Copied from LayoutTests/platform/efl/fast/lists/li-br-expected.png.
* platform/efl/fast/html/details-add-summary-3-and-click-expected.png: Added.
* platform/efl/fast/html/details-add-summary-3-expected.png: Added.
* platform/efl/fast/html/details-add-summary-4-and-click-expected.png: Added.
* platform/efl/fast/html/details-add-summary-4-expected.png: Added.
* platform/efl/fast/html/details-add-summary-5-and-click-expected.png: Added.
* platform/efl/fast/html/details-add-summary-5-expected.png: Copied from LayoutTests/platform/efl/fast/lists/li-br-expected.png.
* platform/efl/fast/html/details-add-summary-6-and-click-expected.png: Added.
* platform/efl/fast/html/details-add-summary-6-expected.png: Added.
* platform/efl/fast/html/details-add-summary-7-and-click-expected.png: Added.
* platform/efl/fast/html/details-add-summary-7-expected.png: Added.
* platform/efl/fast/html/details-add-summary-8-and-click-expected.png: Added.
* platform/efl/fast/html/details-add-summary-8-expected.png: Added.
* platform/efl/fast/html/details-add-summary-9-and-click-expected.png: Added.
* platform/efl/fast/html/details-add-summary-9-expected.png: Added.
* platform/efl/fast/html/details-add-summary-child-1-expected.png: Added.
* platform/efl/fast/html/details-add-summary-child-2-expected.png: Added.
* platform/efl/fast/html/details-nested-1-expected.png: Added.
* platform/efl/fast/html/details-nested-2-expected.png: Added.
* platform/efl/fast/html/details-no-summary1-expected.png: Added.
* platform/efl/fast/html/details-no-summary2-expected.png: Added.
* platform/efl/fast/html/details-no-summary3-expected.png: Added.
* platform/efl/fast/html/details-no-summary4-expected.png: Added.
* platform/efl/fast/html/details-open-javascript-expected.png: Added.
* platform/efl/fast/html/details-open1-expected.png: Added.
* platform/efl/fast/html/details-open2-expected.png: Added.
* platform/efl/fast/html/details-open3-expected.png: Added.
* platform/efl/fast/html/details-open4-expected.png: Added.
* platform/efl/fast/html/details-open5-expected.png: Added.
* platform/efl/fast/html/details-open6-expected.png: Added.
* platform/efl/fast/html/details-position-expected.png: Added.
* platform/efl/fast/html/details-remove-child-1-expected.png: Added.
* platform/efl/fast/html/details-remove-child-2-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-1-and-click-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-1-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-2-and-click-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-2-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-3-and-click-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-3-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-4-and-click-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-4-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-5-and-click-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-5-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-6-and-click-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-6-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-child-1-expected.png: Added.
* platform/efl/fast/html/details-remove-summary-child-2-expected.png: Added.
* platform/efl/fast/html/details-replace-summary-child-expected.png: Added.
* platform/efl/fast/html/details-replace-text-expected.png: Added.
* platform/efl/fast/html/details-writing-mode-expected.png: Added.
* platform/efl/fast/html/link-rel-stylesheet-expected.png:
* platform/efl/fast/html/listing-expected.png:
* platform/efl/fast/html/marquee-scroll-expected.png:
* platform/efl/fast/html/marquee-scrollamount-expected.png:
* platform/efl/fast/lists/001-expected.png:
* platform/efl/fast/lists/001-vertical-expected.png:
* platform/efl/fast/lists/002-expected.png:
* platform/efl/fast/lists/002-vertical-expected.png:
* platform/efl/fast/lists/003-expected.png:
* platform/efl/fast/lists/003-vertical-expected.png:
* platform/efl/fast/lists/005-expected.png:
* platform/efl/fast/lists/005-vertical-expected.png:
* platform/efl/fast/lists/007-expected.png:
* platform/efl/fast/lists/007-vertical-expected.png:
* platform/efl/fast/lists/008-expected.png:
* platform/efl/fast/lists/008-vertical-expected.png:
* platform/efl/fast/lists/anonymous-items-expected.png:
* platform/efl/fast/lists/big-list-marker-expected.png:
* platform/efl/fast/lists/dynamic-marker-crash-expected.png:
* platform/efl/fast/lists/li-br-expected.png:
* platform/efl/fast/lists/li-style-alpha-huge-value-crash-expected.png:
* platform/efl/fast/lists/marker-before-empty-inline-expected.png:
* platform/efl/fast/lists/marker-image-error-expected.png:
* platform/efl/fast/lists/markers-in-selection-expected.png:
* platform/efl/fast/lists/ol-display-types-expected.png:
* platform/efl/fast/lists/ol-start-parsing-expected.png:
* platform/efl/fast/lists/olstart-expected.png:
* platform/efl/fast/lists/ordered-list-with-no-ol-tag-expected.png:
* platform/efl/fast/lists/scrolled-marker-paint-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] assertion being hit in CCLayerTreeHost::updateCompositorResources
commit-queue@webkit.org [Mon, 26 Mar 2012 22:43:43 +0000 (22:43 +0000)]
[chromium] assertion being hit in CCLayerTreeHost::updateCompositorResources
https://bugs.webkit.org/show_bug.cgi?id=82239

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-26
Reviewed by Adrienne Walker.

The assert is incorrect and should check the animation state on
the surface, not the owning layer.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateCompositorResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect LayoutUnit usage in RenderFieldSet and RenderMenuItem
leviw@chromium.org [Mon, 26 Mar 2012 22:41:28 +0000 (22:41 +0000)]
Correct LayoutUnit usage in RenderFieldSet and RenderMenuItem
https://bugs.webkit.org/show_bug.cgi?id=82179

Reviewed by Julien Chaffraix.

Correcting small misuses of ints vs LayoutUnits in RenderFieldSet and RenderMenuItem. Also
adding zeroLayoutUnit where necessary to fix the sub-pixel build. See below for details.

No new tests. No change in behavior.

* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations): Clip rects need to be pixel snapped to mirror
the actual coordinates we paint.
(WebCore::RenderFieldset::paintMask): Using zeroLayoutUnit for ternary operation to fix the
sub-pixel build.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::showPopup): Correctly using an IntRect for absoluteBoundingBoxRect.
(WebCore::RenderMenuList::clientPaddingLeft): Correcting mismatched return type with header.
(WebCore::RenderMenuList::clientPaddingRight): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium rebaselines for test failing due to text rendering or antialiasing differences.
ojan@chromium.org [Mon, 26 Mar 2012 22:39:33 +0000 (22:39 +0000)]
Chromium rebaselines for test failing due to text rendering or antialiasing differences.
Changes to non-chromium results were from "webkit-patch optimize-baselines".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTried to fix an unused parameter warning after r112154.
mitz@apple.com [Mon, 26 Mar 2012 22:39:18 +0000 (22:39 +0000)]
Tried to fix an unused parameter warning after r112154.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Changed to not pass relayoutChildren to
layoutFlexItems.
(WebCore::RenderFlexibleBox::layoutFlexItems): Removed the unused relayoutChildren parameter.
* rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSyntheticStyleCalc on an element should not force recalculation on its children
commit-queue@webkit.org [Mon, 26 Mar 2012 22:32:47 +0000 (22:32 +0000)]
SyntheticStyleCalc on an element should not force recalculation on its children
https://bugs.webkit.org/show_bug.cgi?id=79389

Patch by Rob Arnold <robarnold@fb.com> on 2012-03-26
Reviewed by Simon Fraser.

No new tests. Existing tests cover correctness, not sure how to test for performance.

* dom/Element.cpp:
(WebCore::Element::recalcStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoapply cross axis constraints before aligning children in flexbox
tony@chromium.org [Mon, 26 Mar 2012 22:26:02 +0000 (22:26 +0000)]
apply cross axis constraints before aligning children in flexbox
https://bugs.webkit.org/show_bug.cgi?id=82240

Reviewed by Ojan Vafai.

Source/WebCore:

We weren't applying max-height constraints before aligning children.
This would cause center, end, stretch alignment to be wrong if we hit
a max-height on a flexbox.

This patch also moves the repositioning logic to happen after
computeLogicalHeight, which will be useful for flex-line-pack.

New test case in css3/flexbox/flex-align.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
* rendering/RenderFlexibleBox.h:

LayoutTests:

* css3/flexbox/flex-align-expected.txt:
* css3/flexbox/flex-align.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[jhbuild] Use $MAKE if it is defined to build jhbuild itself.
kubo@profusion.mobi [Mon, 26 Mar 2012 22:14:38 +0000 (22:14 +0000)]
[jhbuild] Use $MAKE if it is defined to build jhbuild itself.
https://bugs.webkit.org/show_bug.cgi?id=82209

Reviewed by Martin Robinson.

Respecting the $MAKE environment variable when it is defined makes
building jhbuild more portable, as some platforms may have GNU
make as gmake, for example.

* jhbuild/jhbuild-wrapper:
(install_jhbuild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTried to fix the Windows build.
mitz@apple.com [Mon, 26 Mar 2012 22:04:22 +0000 (22:04 +0000)]
Tried to fix the Windows build.

* yarr/YarrPattern.cpp:
(JSC::Yarr::CharacterClassConstructor::putRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe css3/selectors3/xml tests are flaky on Leopard as well.
ojan@chromium.org [Mon, 26 Mar 2012 21:59:54 +0000 (21:59 +0000)]
The css3/selectors3/xml tests are flaky on Leopard as well.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoadd a Tree abstraction to test-webkitpy to better encapsulate things
dpranke@chromium.org [Mon, 26 Mar 2012 21:58:15 +0000 (21:58 +0000)]
add a Tree abstraction to test-webkitpy to better encapsulate things
https://bugs.webkit.org/show_bug.cgi?id=82158

Reviewed by Adam Barth.

There are no functional changes in this patch, but adding a
basic abstraction for the trees we are looking in for python
tests will allow me to add some features later on more easily
(like ignoring certain directories like webkitpy/thirdparty),
and it makes things slightly less hard-coded.

* Scripts/test-webkitpy:
* Scripts/webkitpy/test/main.py:
(Tester.__init__):
(Tester):
(Tester.add_tree):
(Tester._parse_args):
(Tester._configure):
(Tester.run):
(Tester._find_modules):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):
(TestDirectoryTree):
(TestDirectoryTree.__init__):
(TestDirectoryTree.find_modules):
(TestDirectoryTree.clean):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic should special case reftests
ojan@chromium.org [Mon, 26 Mar 2012 21:56:01 +0000 (21:56 +0000)]
garden-o-matic should special case reftests
https://bugs.webkit.org/show_bug.cgi?id=81812

Reviewed by Adam Barth.

On the examine page, don't show a rebaseline button for reftests.
We still show it on the failure summary page because tests are grouped
together. Long-term, we should make sure webkit-patch rebaseline-test
never tries to rebaseline reftests.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFind in page overlay and bouncy are not always positioned correctly
andersca@apple.com [Mon, 26 Mar 2012 21:43:55 +0000 (21:43 +0000)]
Find in page overlay and bouncy are not always positioned correctly
https://bugs.webkit.org/show_bug.cgi?id=82247
<rdar://problem/10866139>

Reviewed by Sam Weinig.

In WebCore, a lot of code depends on scroll position updates to happen synchronously, so
update the frame view scroll position before asking the scrolling thread to scroll.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed - speculative Windows build fix.
barraclough@apple.com [Mon, 26 Mar 2012 21:40:33 +0000 (21:40 +0000)]
Unreviewed - speculative Windows build fix.

* yarr/YarrCanonicalizeUCS2.h:
(JSC::Yarr::getCanonicalPair):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed builds with assertions disabled.
mitz@apple.com [Mon, 26 Mar 2012 21:30:45 +0000 (21:30 +0000)]
Fixed builds with assertions disabled.

* yarr/YarrCanonicalizeUCS2.h:
(JSC::Yarr::areCanonicallyEquivalent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed - errk! - accidentally the whole pbxproj.
barraclough@apple.com [Mon, 26 Mar 2012 21:06:08 +0000 (21:06 +0000)]
Unreviewed - errk! - accidentally the whole pbxproj.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify setting loading state in DocumentLoader
japhet@chromium.org [Mon, 26 Mar 2012 20:34:00 +0000 (20:34 +0000)]
Simplify setting loading state in DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=82099

Reviewed by Adam Barth.

The logic for deciding what to return for DocumentLoader::isLoading()
is crazy. It's indirectly based on the ResourceLoaders that have
registered themselves with the DocumentLoader, but we can make that
relationship more direct.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::checkLoadComplete): Renamed from updateLoading, since it's not actually
    updating anything anymore. It now calls DOMWindow::finishedLoading() if loading is in fact done.
(WebCore::DocumentLoader::startLoadingMainResource): The only reason this had a return value was to call
    updateLoading() if loading failed. Just call checkLoadComplete() directly (this allows it to
    be private, whereas updateLoading() was public).
(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::isLoading): Rather than holding a separate bool, return based on the presence
    of non-multipart ResourceLoaders directly.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::isLoading): Depend on DocumentLoader::isLoading() for the activeDocumentLoader(),
    rather than indirectly the other way around.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Remove several assertions that should now be
    absolutely identical to the remaining !pdl->isLoading().
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGreek sigma is handled wrong in case independent regexp.
barraclough@apple.com [Mon, 26 Mar 2012 20:13:39 +0000 (20:13 +0000)]
Greek sigma is handled wrong in case independent regexp.
https://bugs.webkit.org/show_bug.cgi?id=82063

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

The bug here is that we assume that any given codepoint has at most one additional value it
should match under a case insensitive match, and that the pair of codepoints that match (if
a codepoint does not only match itself) can be determined by calling toUpper/toLower on the
given codepoint). Life is not that simple.

Instead, pre-calculate a set of tables mapping from a UCS2 codepoint to the set of characters
it may match, under the ES5.1 case-insensitive matching rules. Since unicode is fairly regular
we can pack this table quite nicely, and get it down to 364 entries. This means we can use a
simple binary search to find an entry in typically eight compares.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* yarr/yarr.pri:
    - Added new files to build systems.
* yarr/YarrCanonicalizeUCS2.cpp: Added.
    - New - autogenerated, UCS2 canonicalized comparison tables.
* yarr/YarrCanonicalizeUCS2.h: Added.
(JSC::Yarr::rangeInfoFor):
    - Look up the canonicalization info for a UCS2 character.
(JSC::Yarr::getCanonicalPair):
    - For a UCS2 character with a single equivalent value, look it up.
(JSC::Yarr::isCanonicallyUnique):
    - Returns true if no other UCS2 code points are canonically equal.
(JSC::Yarr::areCanonicallyEquivalent):
    - Compare two values, under canonicalization rules.
* yarr/YarrCanonicalizeUCS2.js: Added.
    - script used to generate YarrCanonicalizeUCS2.cpp.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::tryConsumeBackReference):
    - Use isCanonicallyUnique, rather than Unicode toUpper/toLower.
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
    - Use isCanonicallyUnique, rather than Unicode toUpper/toLower.
* yarr/YarrPattern.cpp:
(JSC::Yarr::CharacterClassConstructor::putChar):
    - Updated to determine canonical equivalents correctly.
(JSC::Yarr::CharacterClassConstructor::putUnicodeIgnoreCase):
    - Added, used to put a non-ascii, non-unique character in a case-insensitive match.
(JSC::Yarr::CharacterClassConstructor::putRange):
    - Updated to determine canonical equivalents correctly.
(JSC::Yarr::YarrPatternConstructor::atomPatternCharacter):
    - Changed to call putUnicodeIgnoreCase, instead of putChar, avoid a double lookup of rangeInfo.

LayoutTests:

* fast/regex/script-tests/unicodeCaseInsensitive.js: Added.
(shouldBeTrue.ucs2CodePoint):
* fast/regex/unicodeCaseInsensitive-expected.txt: Added.
* fast/regex/unicodeCaseInsensitive.html: Added.
    - Added test cases for case-insensitive matches of non-ascii characters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScrollable plugins not registered properly in ScrollingCoordinator
jamesr@google.com [Mon, 26 Mar 2012 19:43:16 +0000 (19:43 +0000)]
Scrollable plugins not registered properly in ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=82163

Reviewed by Anders Carlsson.

Source/WebCore:

Plugins may be scrollable, so we have to add them in the non-fast scrollable region. Tested manually.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::nonFastScrollableRegion):
(WebCore):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* plugins/PluginViewBase.h:
(WebCore::PluginViewBase::scrollable):
(PluginViewBase):

Source/WebKit/chromium:

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::scrollable):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Build fix for Accelerated Compositing with Clutter
joone.hur@collabora.co.uk [Mon, 26 Mar 2012 19:41:38 +0000 (19:41 +0000)]
[GTK] Build fix for Accelerated Compositing with Clutter
https://bugs.webkit.org/show_bug.cgi?id=81785

Reviewed by Martin Robinson.

Source/WebCore:

AcceleratedCompositingContext was introduced to isolate different accelerated
compositing implementations(r104194), but the Clutter implementation doesn't
build with it. This includes an initial implementation of GraphicsContext3D
and fixes the build error.

* GNUmakefile.list.am:
* platform/graphics/clutter/DrawingBufferClutter.cpp: Added.
(WebCore):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/clutter/GraphicsContext3DClutter.cpp: Added.
(WebCore):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::getImageData):
(WebCore::GraphicsContext3D::paintToCanvas):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::platformLayer):
* platform/graphics/clutter/GraphicsContext3DPrivate.cpp: Added.
(WebCore):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
(WebCore::GraphicsContext3DPrivate::platformContext):
(WebCore::GraphicsContext3DPrivate::paintToGraphicsLayerActor):
* platform/graphics/clutter/GraphicsContext3DPrivate.h: Added.
(WebCore):
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):

Source/WebKit/gtk:

AcceleratedCompositingContext was introduced to isolate different accelerated
compositing implementations(r104194), but the Clutter implementation doesn't
build with it. This fixes the build error.

* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
* WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::renderLayersToWindow):
(WebKit::AcceleratedCompositingContext::resizeRootLayer):
(WebKit::AcceleratedCompositingContext::syncLayersNow):
(WebKit::AcceleratedCompositingContext::syncLayersTimeout):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoclean up NRWT logging/metering, be less verbose
dpranke@chromium.org [Mon, 26 Mar 2012 19:41:00 +0000 (19:41 +0000)]
clean up NRWT logging/metering, be less verbose
https://bugs.webkit.org/show_bug.cgi?id=73846

Reviewed by Ojan Vafai.

Re-land r112014 with a build fix for Python 2.6 compatibility.

* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_http_locking):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(AbstractWorker.run):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.__init__):
(Worker._set_up_logging):
(Worker):
(Worker._set_up_host_and_port):
(Worker.run):
(Worker.cleanup):
* Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
(WorkerTest.test_default_platform_in_worker):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
* Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream):
(MeteredStream.implements):
(MeteredStream._erasure):
(MeteredStream._ensure_newline):
(MeteredStream.__init__):
(MeteredStream.__del__):
(MeteredStream.cleanup):
(MeteredStream.write_throttled_update):
(MeteredStream.write_update):
(MeteredStream.write):
(MeteredStream.writeln):
(MeteredStream._erase_last_partial_line):
(_LogHandler):
(_LogHandler.__init__):
(_LogHandler.emit):
* Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(RegularTest):
(RegularTest.setUp):
(RegularTest.tearDown):
(RegularTest.time_fn):
(RegularTest.test_logging_not_included):
(RegularTest._basic):
(RegularTest.test_basic):
(RegularTest._log_after_update):
(RegularTest.test_log_after_update):
(TtyTest):
(TtyTest.test_basic):
(TtyTest.test_log_after_update):
(VerboseTest):
(VerboseTest.test_basic):
(VerboseTest.test_log_after_update):
* Scripts/webkitpy/layout_tests/views/printing.py:
(parse_print_options):
(Printer.__init__):
(Printer.cleanup):
(Printer.print_progress):
(Printer.print_update):
(Printer._write):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_printer):
(Testprinter.test_print_progress):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_pause_before_testing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[jhbuild] Revert $MAKE environment hack introduced in r101929.
kubo@profusion.mobi [Mon, 26 Mar 2012 19:31:02 +0000 (19:31 +0000)]
[jhbuild] Revert $MAKE environment hack introduced in r101929.
https://bugs.webkit.org/show_bug.cgi?id=82234

Reviewed by Martin Robinson.

The problem it was supposedly fixing was fixed in jhbuild itself
in git revision da8944d8ca987ca48c91b350257a530050406092, so we
can remove the workaround added to the script.

* jhbuild/jhbuild-wrapper:
(install_jhbuild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Expose InspectorTypeBuilder.h to other components
vsevik@chromium.org [Mon, 26 Mar 2012 19:28:44 +0000 (19:28 +0000)]
Web Inspector: Expose InspectorTypeBuilder.h to other components
https://bugs.webkit.org/show_bug.cgi?id=82226

Patch by Peter Rybin <prybin@chromium.org> on 2012-03-26
Reviewed by Vsevolod Vlasov.

This is a provisional commit that simplifies passing ealy warning system
for the main patch https://bugs.webkit.org/show_bug.cgi?id=81558

* WebCore.xcodeproj/project.pbxproj: config file is changed in Xcode UI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test_expectations update for chromium.
eae@chromium.org [Mon, 26 Mar 2012 19:19:59 +0000 (19:19 +0000)]
Unreviewed test_expectations update for chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rebaseline for fast/forms/textfield-overflow.
eae@chromium.org [Mon, 26 Mar 2012 18:56:53 +0000 (18:56 +0000)]
Unreviewed rebaseline for fast/forms/textfield-overflow.

* platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Removed.
* platform/chromium-mac/fast/forms/textfield-overflow-expected.png: Added.
* platform/chromium-mac/fast/forms/textfield-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test_expectations update for chromium.
eae@chromium.org [Mon, 26 Mar 2012 18:54:25 +0000 (18:54 +0000)]
Unreviewed test_expectations update for chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAn <area> element remains focusable even though its associated <img> is not rendered.
commit-queue@webkit.org [Mon, 26 Mar 2012 18:51:52 +0000 (18:51 +0000)]
An <area> element remains focusable even though its associated <img> is not rendered.
https://bugs.webkit.org/show_bug.cgi?id=71788

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-03-26
Reviewed by Andy Estes.

Source/WebCore:

HTMLAreaElement::isFocusable() needs to consider the display and
visibility state.

Test: fast/events/tab-test-not-visible-imagemap.html

* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::imageElement):
(WebCore::HTMLAreaElement::isFocusable):
* html/HTMLAreaElement.h: Make imageElement() const.
(HTMLAreaElement):

LayoutTests:

Test sequential focus navigation.

* fast/events/tab-test-not-visible-imagemap-expected.txt: Added.
* fast/events/tab-test-not-visible-imagemap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTrim the set of flaky css3/selectors3/xml tests on SnowLeopard to
ojan@chromium.org [Mon, 26 Mar 2012 18:44:26 +0000 (18:44 +0000)]
Trim the set of flaky css3/selectors3/xml tests on SnowLeopard to
the set that are actually flaky on the bots.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] default families are not set in QWebPreferences
vestbo@webkit.org [Mon, 26 Mar 2012 18:39:08 +0000 (18:39 +0000)]
[Qt][WK2] default families are not set in QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=81933

This is a build-fix after r112116.

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-03-26
Reviewed by Tor Arne Vestbø.

* UIProcess/API/qt/qwebpreferences_p_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt after r112113 and r112112.
jchaffraix@webkit.org [Mon, 26 Mar 2012 18:26:54 +0000 (18:26 +0000)]
Fix Qt after r112113 and r112112.

Unreviewed.

* platform/qt/Skipped:
Skipped a new test that is failing.

* platform/qt/fast/forms/textfield-overflow-expected.txt:
Updated the baseline as it matches other ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a typo in IDL
antonm@chromium.org [Mon, 26 Mar 2012 18:12:38 +0000 (18:12 +0000)]
Fix a typo in IDL
https://bugs.webkit.org/show_bug.cgi?id=82215

Reviewed by Adam Barth.

No new tests, just a typo fix.

* notifications/WorkerContextNotifications.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed: chromium baselines for c543-txt-decor-000.
pfeldman@chromium.org [Mon, 26 Mar 2012 18:11:17 +0000 (18:11 +0000)]
Not reviewed: chromium baselines for c543-txt-decor-000.

* platform/chromium-linux/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
* platform/chromium-mac/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
* platform/chromium-win/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
* platform/chromium-win/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved Mac WebKit2-specific expected results for this test, which were added in...
mitz@apple.com [Mon, 26 Mar 2012 17:55:48 +0000 (17:55 +0000)]
Removed Mac WebKit2-specific expected results for this test, which were added in r90097.

* platform/mac-wk2/fast/forms/textfield-overflow-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Change handleGestureFling() to use CCInputHandlerClient::Wheel.
wjmaclean@chromium.org [Mon, 26 Mar 2012 17:52:44 +0000 (17:52 +0000)]
[chromium] Change handleGestureFling() to use CCInputHandlerClient::Wheel.
https://bugs.webkit.org/show_bug.cgi?id=82133

Reviewed by James Robinson.

Source/WebCore:

Covered by existing unit tests.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::scrollBegin):

Source/WebKit/chromium:

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS3 calc: mixed percent/absolute for box-reflect
mikelawther@chromium.org [Mon, 26 Mar 2012 17:48:45 +0000 (17:48 +0000)]
CSS3 calc: mixed percent/absolute for box-reflect
https://bugs.webkit.org/show_bug.cgi?id=82161

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: css3/calc/box-reflect-expected.html
       css3/calc/box-reflect.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

* css3/calc/box-reflect-expected.html: Added.
* css3/calc/box-reflect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS3 calc: mixed percent/absolute support for vertical-align
mikelawther@chromium.org [Mon, 26 Mar 2012 17:45:20 +0000 (17:45 +0000)]
CSS3 calc: mixed percent/absolute support for vertical-align
https://bugs.webkit.org/show_bug.cgi?id=82152

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: css3/calc/vertical-align-expected.html
       css3/calc/vertical-align.html

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyVerticalAlign::applyValue):

LayoutTests:

* css3/calc/vertical-align-expected.html: Added.
* css3/calc/vertical-align.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Accelerated compositing updates
commit-queue@webkit.org [Mon, 26 Mar 2012 17:43:05 +0000 (17:43 +0000)]
[BlackBerry] Accelerated compositing updates
https://bugs.webkit.org/show_bug.cgi?id=82058

Patch by Filip Spacek <fspacek@rim.com> on 2012-03-26
Reviewed by Rob Buis.

* platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::setDevice):
(WebCore::CanvasLayerWebKitThread::updateTextureContentsIfNeeded):
* platform/graphics/blackberry/CanvasLayerWebKitThread.h:
(WebCore::CanvasLayerWebKitThread::create):
(CanvasLayerWebKitThread):
* platform/graphics/blackberry/InstrumentedPlatformCanvas.h:
(WebCore::InstrumentedPlatformCanvas::InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::save):
(WebCore::InstrumentedPlatformCanvas::saveLayer):
(WebCore::InstrumentedPlatformCanvas::restore):
(WebCore::InstrumentedPlatformCanvas::translate):
(WebCore::InstrumentedPlatformCanvas::scale):
(WebCore::InstrumentedPlatformCanvas::rotate):
(WebCore::InstrumentedPlatformCanvas::skew):
(WebCore::InstrumentedPlatformCanvas::concat):
(WebCore::InstrumentedPlatformCanvas::setMatrix):
(WebCore::InstrumentedPlatformCanvas::clipRect):
(WebCore::InstrumentedPlatformCanvas::clipPath):
(WebCore::InstrumentedPlatformCanvas::clipRegion):
(WebCore::InstrumentedPlatformCanvas::clear):
(WebCore::InstrumentedPlatformCanvas::drawPaint):
(WebCore::InstrumentedPlatformCanvas::drawPoints):
(WebCore::InstrumentedPlatformCanvas::drawRect):
(WebCore::InstrumentedPlatformCanvas::drawPath):
(WebCore::InstrumentedPlatformCanvas::drawBitmap):
(WebCore::InstrumentedPlatformCanvas::drawBitmapRect):
(WebCore::InstrumentedPlatformCanvas::drawBitmapMatrix):
(WebCore::InstrumentedPlatformCanvas::drawSprite):
(WebCore::InstrumentedPlatformCanvas::drawText):
(WebCore::InstrumentedPlatformCanvas::drawPosText):
(WebCore::InstrumentedPlatformCanvas::drawPosTextH):
(WebCore::InstrumentedPlatformCanvas::drawTextOnPath):
(WebCore::InstrumentedPlatformCanvas::drawPicture):
(WebCore::InstrumentedPlatformCanvas::drawVertices):
(WebCore::InstrumentedPlatformCanvas::drawData):
* platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::LayerData):
(WebCore::LayerData::needsTexture):
(LayerData):
* platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::setDrawable):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::loadBufferingImageData):
* platform/graphics/blackberry/skia/ImageBufferDataSkia.h: Renamed from Source/WebCore/platform/graphics/blackberry/skia/ImageBufferData.h.
(WebCore):
(ImageBufferData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Add the build outputs dir to the list of build dirs, so...
kevino@webkit.org [Mon, 26 Mar 2012 17:38:49 +0000 (17:38 +0000)]
[wx] Unreviewed build fix. Add the build outputs dir to the list of build dirs, so we make sure it finds the API headers on all platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Failure to invalidate text position attributes when DOM changes
schenney@chromium.org [Mon, 26 Mar 2012 17:25:09 +0000 (17:25 +0000)]
Source/WebCore: Failure to invalidate text position attributes when DOM changes
https://bugs.webkit.org/show_bug.cgi?id=81464

Reviewed by Nikolas Zimmermann.

The text positioning elements data structure in RenderSVGText must be
updated when either the children of the corresponding element are
modified, or the length of the text inside the elements changes.
Previously, the call to clear the text positioning elements (to force
recomputation) was guarded by a flag. If code tried to invalidate when
the flag was not set, then something set the flag, the elements would
be invalid at use time.

This patch modifies the method that invalidates the positining
attributes so that the action always happens. It also renames the
method to more accurately reflect its function.

Test: svg/custom/delete-modified-text-in-defs-crash.svg

* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::setTextInternal): Rename textDOMChanged to invalidateTextPositioningElements
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::invalidateTextPositioningElements): Rename
textDOMChanged to invalidateTextPositioningElements and remove the check against the needsPosition... flag.
* rendering/svg/RenderSVGText.h:
(RenderSVGText): Rename textDOMChanged to invalidateTextPositioningElements
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::childrenChanged): Rename textDOMChanged to invalidateTextPositioningElements
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::childrenChanged): Rename textDOMChanged to invalidateTextPositioningElements

LayoutTests: Failure to invalidate text position attributes when DOM changes
https://bugs.webkit.org/show_bug.cgi?id=81464

Reviewed by Nikolas Zimmermann.

* svg/custom/delete-modified-text-in-defs-crash-expected.txt: Added.
* svg/custom/delete-modified-text-in-defs-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] default families are not set in QWebPreferences
pierre.rossi@gmail.com [Mon, 26 Mar 2012 17:04:39 +0000 (17:04 +0000)]
[Qt][WK2] default families are not set in QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=81933

This would result in an attempt to create FontPlatformData
with the -webkit- prefixed family name.
Logic adapted from QWebSettings.

Patch by Pierre Rossi <pierre.rossi@nokia.com> on 2012-03-26
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::createPreferences):
(QWebPreferencesPrivate::initFontDefaults):
* UIProcess/API/qt/qwebpreferences_p_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline zoom-foreignObject.svg CR results
commit-queue@webkit.org [Mon, 26 Mar 2012 16:55:26 +0000 (16:55 +0000)]
Rebaseline zoom-foreignObject.svg CR results
https://bugs.webkit.org/show_bug.cgi?id=82205

Unreviewed Chromium rebaseline.

Patch by Florin Malita <fmalita@google.com> on 2012-03-26

* platform/chromium-mac-leopard/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-mac-leopard/svg/zoom/text/zoom-foreignObject-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-mac/svg/zoom/text/zoom-foreignObject-expected.png:
* platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r110065-r110080): fast/forms/placeholder-set-attribute.html is failing...
jchaffraix@webkit.org [Mon, 26 Mar 2012 16:52:01 +0000 (16:52 +0000)]
REGRESSION (r110065-r110080): fast/forms/placeholder-set-attribute.html is failing intermittently because WebKit fails to repaint after setting the placeholder attribute
https://bugs.webkit.org/show_bug.cgi?id=81802

Reviewed by Dan Bernstein.

Source/WebCore:

Covered by fast/forms/placeholder-set-attribute.html which should be less flaky.

Unfortunately no new test case as this bug requires a very specific set of conditions that I couldn't reproduce deterministically.

This is a regression from r110072: RenderTextControlSingleLine would rely on the placeholder's RenderLayer to properly repaint during
the first layout as the placeholder has overflow: hidden set. r110072 removed the layer in this case and thus we miss a repaint.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
For our first layout, we need to make sure our placeholder is painted. layoutBlockChild has a very similar logic to force repaint
on a first layout. We don't hit this logic as the placeholder is explicitly skipped in RenderTextControl::layoutSpecialExcludedChild.

LayoutTests:

* platform/mac/Skipped: Unskip the test on Mac. The other platforms are either
skipping it for other reasons or did not have a specific entry for the flakiness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r110072): fast/forms/textfield-overflow.html is failing
jchaffraix@webkit.org [Mon, 26 Mar 2012 16:46:17 +0000 (16:46 +0000)]
REGRESSION(r110072): fast/forms/textfield-overflow.html is failing
https://bugs.webkit.org/show_bug.cgi?id=80531

Reviewed by Ojan Vafai.

Source/WebCore:

Tested by fast/forms/textfield-overflow.html (re-enabled after this change).

The existing code would happily query layout information before calling layout (FTW!).
The solution is to properly layout our object, then modify some dimensions as needed while
marking ourself as needing layout and then layouting again.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
Implemented a proper 2 pass layout algorithm. Removed the |relayoutChildren| logic as:
- layoutBlock handles automatically logical height changes.
- we were not modifying the logical width between layouts so we don't need to force a
child relayout in this case.

LayoutTests:

* platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
* platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
This is a progression. The <input> now takes the full cell's space instead of
being shrunk.

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:
* platform/gtk/Skipped:
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
Re-enable fast/forms/textfield-overflow.html as it should be passing.
Also disabled colspanMinWidth-vertical.html on platforms without a rebaseline.

* platform/chromium/test_expectations.txt:
Ditto and marked fast/repaint/search-field-cancel.html as failing image only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupersede t1504-c543-txt-decor-00-d-g.html with c543-txt-decor-000.html
pfeldman@chromium.org [Mon, 26 Mar 2012 16:43:20 +0000 (16:43 +0000)]
Supersede t1504-c543-txt-decor-00-d-g.html with c543-txt-decor-000.html
https://bugs.webkit.org/show_bug.cgi?id=82120

Patch by SravanKumar Sandela <ssandela@innominds.com> on 2012-03-26
Reviewed by Pavel Feldman.

Test css2.1/t1504-c543-txt-decor-00-d-g.html is outdated and had
some issues, hence removed and superseding it with c543-txt-decor-000.html. Also,
copied two support png files from css2.1/support to css2.1/20110323/support.

* css2.1/20110323/c543-txt-decor-000-expected.png: Added.
* css2.1/20110323/c543-txt-decor-000-expected.txt: Added.
* css2.1/20110323/c543-txt-decor-000.html: Added.
* css2.1/20110323/support/square-purple.png: Added.
* css2.1/20110323/support/square-teal.png: Added.
* css2.1/t1504-c543-txt-decor-00-d-g.html: Removed.
* platform/chromium-linux/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
* platform/chromium-mac-leopard/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
* platform/chromium-mac-snowleopard/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
* platform/chromium-mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
* platform/chromium-win/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
* platform/chromium-win/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
* platform/efl/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
* platform/efl/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
* platform/gtk/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
* platform/gtk/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
* platform/mac-leopard/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
* platform/mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
* platform/mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
* platform/qt/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitWebView signals with GError parameters cause crashes when using GObject Introsp...
mrobinson@webkit.org [Mon, 26 Mar 2012 16:24:49 +0000 (16:24 +0000)]
WebKitWebView signals with GError parameters cause crashes when using GObject Introspection
https://bugs.webkit.org/show_bug.cgi?id=81977

Patch by Gary Kramlich <grim@reaperworld.com> on 2012-03-26
Reviewed by Martin Robinson.

Added marshalers for BOOLEAN:OBJECT,STRING,BOXED and VOID:OBJECT,OBJECT,BOXED
and changed the signal signatures for WebKitWebView::load-fail and
WebKitWebView::resource-load-failed to use the new marshalers since
GError has been a GBoxed type since Gtk 2.26.  This fixes these signals
for the gobject-introspection bindings.

* webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
* webkitmarshal.list:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream LayerCompositingThread.{h, cpp}
commit-queue@webkit.org [Mon, 26 Mar 2012 16:24:43 +0000 (16:24 +0000)]
[BlackBerry] Upstream LayerCompositingThread.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79873

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-26
Reviewed by Rob Buis.

Initial upstream, no new tests.

* platform/graphics/blackberry/LayerCompositingThread.cpp: Added.
(WebCore):
(WebCore::LayerCompositingThread::create):
(WebCore::LayerCompositingThread::LayerCompositingThread):
(WebCore::LayerCompositingThread::~LayerCompositingThread):
(WebCore::LayerCompositingThread::destroyOnCompositingThread):
(WebCore::LayerCompositingThread::setLayerRenderer):
(WebCore::LayerCompositingThread::deleteTextures):
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::getTransformedRect):
(WebCore::LayerCompositingThread::getTransformedHolePunchRect):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
(WebCore::LayerCompositingThread::drawMissingTextures):
(WebCore::LayerCompositingThread::releaseTextureResources):
(WebCore::LayerCompositingThread::setPluginView):
(WebCore::LayerCompositingThread::setMediaPlayer):
(WebCore::LayerCompositingThread::clearAnimations):
(WebCore::LayerCompositingThread::removeSublayer):
(WebCore::LayerCompositingThread::indexOfSublayer):
(WebCore::LayerCompositingThread::rootLayer):
(WebCore::LayerCompositingThread::removeFromSuperlayer):
(WebCore::LayerCompositingThread::setSublayers):
(WebCore::LayerCompositingThread::updateTextureContentsIfNeeded):
(WebCore::LayerCompositingThread::setVisible):
(WebCore::LayerCompositingThread::setNeedsCommit):
(WebCore::LayerCompositingThread::scheduleCommit):
(WebCore::LayerCompositingThread::updateAnimations):
(WebCore::LayerCompositingThread::hasVisibleHolePunchRect):
(WebCore::LayerCompositingThread::createLayerRendererSurface):
* platform/graphics/blackberry/LayerCompositingThread.h: Added.
(Graphics):
(WebCore):
(LayerCompositingThread):
(WebCore::LayerCompositingThread::bindContentsTexture):
(WebCore::LayerCompositingThread::getSublayers):
(WebCore::LayerCompositingThread::setSuperlayer):
(WebCore::LayerCompositingThread::superlayer):
(WebCore::LayerCompositingThread::drawTransform):
(WebCore::LayerCompositingThread::setDrawOpacity):
(WebCore::LayerCompositingThread::drawOpacity):
(WebCore::LayerCompositingThread::layerRendererSurface):
(WebCore::LayerCompositingThread::clearLayerRendererSurface):
(WebCore::LayerCompositingThread::setMaskLayer):
(WebCore::LayerCompositingThread::maskLayer):
(WebCore::LayerCompositingThread::setReplicaLayer):
(WebCore::LayerCompositingThread::replicaLayer):
(WebCore::LayerCompositingThread::getDrawRect):
(WebCore::LayerCompositingThread::getTransformedBounds):
(WebCore::LayerCompositingThread::hasMissingTextures):
(WebCore::LayerCompositingThread::isDirty):
(WebCore::LayerCompositingThread::isVisible):
(WebCore::LayerCompositingThread::setOpacity):
(WebCore::LayerCompositingThread::setTransform):
(WebCore::LayerCompositingThread::hasRunningAnimations):
(WebCore::LayerCompositingThread::numSublayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a notification function for detaching to TextFieldDecorator
tkent@chromium.org [Mon, 26 Mar 2012 16:19:02 +0000 (16:19 +0000)]
Add a notification function for detaching to TextFieldDecorator
https://bugs.webkit.org/show_bug.cgi?id=82142

Reviewed by Dimitri Glazkov.

Add willDetach() functio to TextFieldDecorator. This will be
needed if a decorator opens a popup UI on handleClick(), and the
popup UI should be closed when the attaching text field is
detached.

No new tests because of no behavior changes in any platforms.

* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::hostInput):
Added. A utilify function to get an HTMLInputElement*.
(WebCore::TextFieldDecorationElement::updateImage): Use hostInput().
(WebCore::TextFieldDecorationElement::customStyleForRenderer): ditto.
(WebCore::TextFieldDecorationElement::detach): Added. Calls TextFieldDecorator::willDetach().
(WebCore::TextFieldDecorationElement::defaultEventHandler): Use hostInput().
* html/shadow/TextFieldDecorationElement.h:
(TextFieldDecorator):
(TextFieldDecorationElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTried to fix the 32-bit build after r112021.
mitz@apple.com [Mon, 26 Mar 2012 16:16:32 +0000 (16:16 +0000)]
Tried to fix the 32-bit build after r112021.

* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper _convertToNSRange:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening, add Qt specific expected results for new passsing tests.
ossy@webkit.org [Mon, 26 Mar 2012 16:11:16 +0000 (16:11 +0000)]
[Qt] Unreviewed gardening, add Qt specific expected results for new passsing tests.

* platform/qt/Skipped: Skip a new failing test.
* platform/qt/editing/selection/selection-button-text-expected.png: Added.
* platform/qt/editing/selection/selection-button-text-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
* platform/qt/svg/custom/use-extern-href-expected.png: Added.
* platform/qt/svg/custom/use-extern-href-expected.txt: Added.
* platform/qt/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
* platform/qt/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
leo.yang@torchmobile.com.cn [Mon, 26 Mar 2012 15:51:32 +0000 (15:51 +0000)]
[BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=82157

Reviewed by Rob Buis.

.:

* Source/cmake/OptionsBlackBerry.cmake: Turn on ENABLE_FILE_SYSTEM for blackberry.

Source/WebCore:

AsyncFileSystemBlackBerry is responsible for asynchronous operating
on file system for the blackberry porting. It's just skeleton code
containing no implementation yet.

No new tests because of skeleton code.

* PlatformBlackBerry.cmake: Add AsyncFileSystemBlackBerry.cpp if ENABLE_FILE_SYSTEM is on.
* platform/AsyncFileSystem.cpp:
(WebCore):
* platform/blackberry/AsyncFileSystemBlackBerry.cpp: Added.
(WebCore):
(WebCore::AsyncFileSystem::isAvailable):
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::~AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::toURL):
(WebCore::AsyncFileSystemBlackBerry::move):
(WebCore::AsyncFileSystemBlackBerry::copy):
(WebCore::AsyncFileSystemBlackBerry::remove):
(WebCore::AsyncFileSystemBlackBerry::removeRecursively):
(WebCore::AsyncFileSystemBlackBerry::readMetadata):
(WebCore::AsyncFileSystemBlackBerry::createFile):
(WebCore::AsyncFileSystemBlackBerry::createDirectory):
(WebCore::AsyncFileSystemBlackBerry::fileExists):
(WebCore::AsyncFileSystemBlackBerry::directoryExists):
(WebCore::AsyncFileSystemBlackBerry::readDirectory):
(WebCore::AsyncFileSystemBlackBerry::createWriter):
(WebCore::AsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):
* platform/blackberry/AsyncFileSystemBlackBerry.h: Added.
(WebCore):
(AsyncFileSystemBlackBerry):

Tools:

* Scripts/build-webkit:
Make ENABLE_FILE_SYSTEM default on for blackberry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt WK2] Disable/enable mouse events when displaying dialogs only for desktop view
commit-queue@webkit.org [Mon, 26 Mar 2012 15:50:09 +0000 (15:50 +0000)]
[Qt WK2] Disable/enable mouse events when displaying dialogs only for desktop view
https://bugs.webkit.org/show_bug.cgi?id=80542

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-26
Reviewed by Simon Hausmann.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::enableMouseEvents):
(QQuickWebViewLegacyPrivate::disableMouseEvents):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewLegacyPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] CredentialBackingStore implement encryptString() and decryptString()
commit-queue@webkit.org [Mon, 26 Mar 2012 15:37:11 +0000 (15:37 +0000)]
[BlackBerry] CredentialBackingStore implement encryptString() and decryptString()
https://bugs.webkit.org/show_bug.cgi?id=82204

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-26
Reviewed by Rob Buis.

Implemented encryptedString() and decryptedString() in class CredentialBackingStore
by calling BlackBerry::Platform::Encryptor::encryptString() and
BlackBerry::Platform::Encryptor::encryptString() respectively.

No new tests.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::encryptedString):
(WebCore::CredentialBackingStore::decryptedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Skip failing tests to paint the bot green.
ossy@webkit.org [Mon, 26 Mar 2012 15:36:27 +0000 (15:36 +0000)]
[Qt][Mac] Skip failing tests to paint the bot green.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112103 268f45cc-cd09-0410-ab3c-d52691b4dbfc