WebKit-https.git
12 years ago<http://webkit.org/b/49867> MediaPlayerPrivateQTKit::setPreservesPitch(bool) leaks...
ddkilzer@apple.com [Sat, 20 Nov 2010 20:12:14 +0000 (20:12 +0000)]
<webkit.org/b/49867> MediaPlayerPrivateQTKit::setPreservesPitch(bool) leaks an NSDictionary

Reviewed by Dan Bernstein.

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch): Use
RetainPtr<NSDictionary> for movieAttributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<http://webkit.org/b/49848> Make it possible to display the last character of a secur...
ddkilzer@apple.com [Sat, 20 Nov 2010 18:54:43 +0000 (18:54 +0000)]
<webkit.org/b/49848> Make it possible to display the last character of a secure text field unobscured

Reviewed by Darin Adler.

* JavaScriptCore.exp:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::secure): Added argument that controls whether
the last character is obscured or not.  Implemented behavior.
* wtf/text/StringImpl.h:
(WTF::StringImpl::LastCharacterBehavior): Added enum.
(WTF::StringImpl::secure): Updated method signature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-20 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 20 Nov 2010 17:40:10 +0000 (17:40 +0000)]
2010-11-20  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Use String::fromUTF8 instead of UTF8Encoding().decode
        in the libxml XMLDocumentParser
        https://bugs.webkit.org/show_bug.cgi?id=45488

        * dom/XMLDocumentParser.cpp:
        (WebCore::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-20 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sat, 20 Nov 2010 17:33:26 +0000 (17:33 +0000)]
2010-11-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72471.
        http://trac.webkit.org/changeset/72471
        https://bugs.webkit.org/show_bug.cgi?id=49865

        broke two IME tests on Qt (Requested by kling on #webkit).

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFilterPrimitives should have a pointer to its Filter object.
reni@webkit.org [Sat, 20 Nov 2010 14:21:43 +0000 (14:21 +0000)]
FilterPrimitives should have a pointer to its Filter object.
https://bugs.webkit.org/show_bug.cgi?id=49863

Reviewed by Dirk Schulze.

FilterPrimitives should have a renderer, and they need a member pointer to their Filter objects for Layout() calls.
This patch adds this member to FilterEffect.

No new test is needed because these modifications are covered by all of SVG Filter tests.

* platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::FEBlend):
(WebCore::FEBlend::create):
(WebCore::FEBlend::apply):
* platform/graphics/filters/FEBlend.h:
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::FEColorMatrix):
(WebCore::FEColorMatrix::create):
(WebCore::FEColorMatrix::apply):
* platform/graphics/filters/FEColorMatrix.h:
* platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::FEComponentTransfer):
(WebCore::FEComponentTransfer::create):
(WebCore::FEComponentTransfer::apply):
* platform/graphics/filters/FEComponentTransfer.h:
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::FEComposite):
(WebCore::FEComposite::create):
(WebCore::FEComposite::determineAbsolutePaintRect):
(WebCore::FEComposite::apply):
* platform/graphics/filters/FEComposite.h:
* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::FEConvolveMatrix):
(WebCore::FEConvolveMatrix::create):
(WebCore::FEConvolveMatrix::apply):
* platform/graphics/filters/FEConvolveMatrix.h:
(WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
* platform/graphics/filters/FEDiffuseLighting.cpp:
(WebCore::FEDiffuseLighting::FEDiffuseLighting):
(WebCore::FEDiffuseLighting::create):
* platform/graphics/filters/FEDiffuseLighting.h:
* platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::FEDisplacementMap):
(WebCore::FEDisplacementMap::create):
(WebCore::FEDisplacementMap::apply):
* platform/graphics/filters/FEDisplacementMap.h:
(WebCore::FEDisplacementMap::determineAbsolutePaintRect):
* platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::FEFlood):
(WebCore::FEFlood::create):
(WebCore::FEFlood::apply):
* platform/graphics/filters/FEFlood.h:
(WebCore::FEFlood::determineAbsolutePaintRect):
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::FEGaussianBlur):
(WebCore::FEGaussianBlur::create):
(WebCore::FEGaussianBlur::determineAbsolutePaintRect):
(WebCore::FEGaussianBlur::apply):
* platform/graphics/filters/FEGaussianBlur.h:
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::FELighting):
(WebCore::FELighting::apply):
* platform/graphics/filters/FELighting.h:
(WebCore::FELighting::determineAbsolutePaintRect):
* platform/graphics/filters/FEMerge.cpp:
(WebCore::FEMerge::FEMerge):
(WebCore::FEMerge::create):
(WebCore::FEMerge::apply):
* platform/graphics/filters/FEMerge.h:
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::FEMorphology):
(WebCore::FEMorphology::create):
(WebCore::FEMorphology::determineAbsolutePaintRect):
(WebCore::FEMorphology::apply):
* platform/graphics/filters/FEMorphology.h:
* platform/graphics/filters/FEOffset.cpp:
(WebCore::FEOffset::FEOffset):
(WebCore::FEOffset::create):
(WebCore::FEOffset::determineAbsolutePaintRect):
(WebCore::FEOffset::apply):
* platform/graphics/filters/FEOffset.h:
* platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::FESpecularLighting):
(WebCore::FESpecularLighting::create):
* platform/graphics/filters/FESpecularLighting.h:
* platform/graphics/filters/FETile.cpp:
(WebCore::FETile::FETile):
(WebCore::FETile::create):
(WebCore::FETile::apply):
* platform/graphics/filters/FETile.h:
(WebCore::FETile::determineAbsolutePaintRect):
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::FETurbulence):
(WebCore::FETurbulence::create):
(WebCore::FETurbulence::apply):
* platform/graphics/filters/FETurbulence.h:
(WebCore::FETurbulence::determineAbsolutePaintRect):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::determineAbsolutePaintRect):
(WebCore::FilterEffect::effectContext):
* platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::filter):
* platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::create):
(WebCore::SourceAlpha::determineAbsolutePaintRect):
(WebCore::SourceAlpha::apply):
* platform/graphics/filters/SourceAlpha.h:
(WebCore::SourceAlpha::SourceAlpha):
* platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::create):
(WebCore::SourceGraphic::determineAbsolutePaintRect):
(WebCore::SourceGraphic::apply):
* platform/graphics/filters/SourceGraphic.h:
(WebCore::SourceGraphic::SourceGraphic):
* rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
* rendering/RenderSVGResourceFilter.h:
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGResourceContainer):
* svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::build):
* svg/SVGFEBlendElement.h:
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::build):
* svg/SVGFEColorMatrixElement.h:
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::build):
* svg/SVGFEComponentTransferElement.h:
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::build):
* svg/SVGFECompositeElement.h:
* svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::build):
* svg/SVGFEConvolveMatrixElement.h:
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::build):
* svg/SVGFEDiffuseLightingElement.h:
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::build):
* svg/SVGFEDisplacementMapElement.h:
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::build):
* svg/SVGFEFloodElement.h:
* svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::build):
* svg/SVGFEGaussianBlurElement.h:
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
* svg/SVGFEImageElement.h:
* svg/SVGFEMergeElement.cpp:
(WebCore::SVGFEMergeElement::build):
* svg/SVGFEMergeElement.h:
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::build):
* svg/SVGFEMorphologyElement.h:
* svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::build):
* svg/SVGFEOffsetElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::build):
* svg/SVGFESpecularLightingElement.h:
* svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::build):
* svg/SVGFETileElement.h:
* svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::build):
* svg/SVGFETurbulenceElement.h:
* svg/SVGFilterPrimitiveStandardAttributes.h:
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::FEImage):
(WebCore::FEImage::create):
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::apply):
* svg/graphics/filters/SVGFEImage.h:
* svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::SVGFilterBuilder):
* svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-20 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Sat, 20 Nov 2010 10:25:25 +0000 (10:25 +0000)]
2010-11-20  Helder Correia  <helder@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] GraphicsContext::strokeArc() is not necessary any more
        https://bugs.webkit.org/show_bug.cgi?id=49859

        Remove strokeArc() from the Qt port.

        No test is needed.

        * platform/graphics/qt/GraphicsContextQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-20 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Sat, 20 Nov 2010 10:09:56 +0000 (10:09 +0000)]
2010-11-20  Helder Correia  <helder@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] Path fill lacks blur shadow support
        https://bugs.webkit.org/show_bug.cgi?id=49491

        Add new test for checking path fill blur shadow.

        * fast/canvas/canvas-fillPath-shadow-expected.txt: Added.
        * fast/canvas/canvas-fillPath-shadow.html: Added.
        * fast/canvas/script-tests/canvas-fillPath-shadow.js: Added.
2010-11-20  Helder Correia  <helder@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] Path fill lacks blur shadow support
        https://bugs.webkit.org/show_bug.cgi?id=49491

        Add blur shadow support to fillPath().

        Test: fast/canvas/canvas-fillPath-shadow.html

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Kristian Amlie <kristian.amlie@nokia.com>
andreas.kling@nokia.com [Sat, 20 Nov 2010 08:15:10 +0000 (08:15 +0000)]
2010-11-19  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Fixed handling of QInputMethodEvents with nonzero replacementLength.

        These types of events replace text that is already in the widget, but
        WebKit did not check for replacementLength at all.

        Also made sure that the preeditString is always respected, even if
        there is committed text. This is how QLineEdit does it.

        https://bugs.webkit.org/show_bug.cgi?id=49787

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 W. James MacLean <wjmaclean@chromium.org>
commit-queue@webkit.org [Sat, 20 Nov 2010 07:56:22 +0000 (07:56 +0000)]
2010-11-19  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by James Robinson.

        Scaled Resized images are blurred when sent to Skia
        https://bugs.webkit.org/show_bug.cgi?id=42370

        * platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/image-rescale-expected.png: Added.
        * platform/chromium-linux/svg/custom/image-rescale-expected.txt: Added.
        * platform/chromium-linux/svg/custom/image-rescale-scroll-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png: Added.
        * platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/svg/custom/image-rescale-expected.checksum: Added.
        * platform/mac/svg/custom/image-rescale-expected.png: Added.
        * platform/mac/svg/custom/image-rescale-expected.txt: Added.
        * platform/mac/svg/custom/image-rescale-scroll-expected.checksum: Added.
        * platform/mac/svg/custom/image-rescale-scroll-expected.png: Added.
        * platform/mac/svg/custom/image-rescale-scroll-expected.txt: Added.
        * platform/mac/test_expectations.txt:
        * svg/custom/image-rescale-scroll.html: Added.
        * svg/custom/image-rescale.svg: Added.
        * svg/custom/resources/image-rescale.jpg: Added.
2010-11-19  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by James Robinson.

        Scaled Resized images are blurred when sent to Skia
        https://bugs.webkit.org/show_bug.cgi?id=42370

        This patch modifies ImageSkia.cpp to fix the calculation of resampled
        bitmap sizes so as to include the transform matrix of the canvas.
        Includes a new test to catch a regression that occured the first time
        this patch was applied.

        Tests: svg/custom/image-rescale-scroll.html
               svg/custom/image-rescale.svg

        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::computeResamplingMode):
        (WebCore::drawResampledBitmap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Sat, 20 Nov 2010 07:25:54 +0000 (07:25 +0000)]
2010-11-19  Jia Pu  <jpu@apple.com>

        Reviewed by Dan Bernstein.

        Regression: contraction is considered misspelling.
        https://bugs.webkit.org/show_bug.cgi?id=49423
        <rdar://problem/8654206>

        * platform/mac-leopard/Skipped:
        * platform/mac-snowleopard/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/mac/editing/spelling/autocorrection-contraction-expected.checksum: Added.
        * platform/mac/editing/spelling/autocorrection-contraction-expected.png: Added.
        * platform/mac/editing/spelling/autocorrection-contraction-expected.txt: Added.
        * platform/mac/editing/spelling/autocorrection-contraction.html: Added.
2010-11-19  Jia Pu  <jpu@apple.com>

        Reviewed by Dan Bernstein.

        Regression: contraction is considered misspelling.
        https://bugs.webkit.org/show_bug.cgi?id=49423
        <rdar://problem/8654206>

        Test: platform/mac/editing/spelling/autocorrection-contraction.html
              manual-tests/autocorrection/autocorrection-contraction.html

        * editing/Editor.cpp:
        (WebCore::isAmbiguousBoundaryCharacter): Moved function to the top of the file so that it can
          be used by all other functions in the file.
        (WebCore::Editor::markMisspellingsAfterTypingToWord): Renamed markMisspellingsAfterTypingToPosition()
          to improve readability, and to pass in additional argument. Before we apply pending
          autocorrection, we check to see if currently typed character makes current word a partial
          contraction, for instance "wouldn'". If that's the case, we would not apply the pending
          correction.
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Make sure currently typed word
          is not a partial contraction, such as "wouldn'", before mark it as misspelled. Also update
          the location of ambiguous boundary if other replacements have changed the length of the
          paragraph.
        * editing/Editor.h:
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::markMisspellingsAfterTyping): Adopt renamed function.
        * manual-tests/autocorrection/autocorrection-contraction.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Zalan Bujtas <zbujtas@gmail.com>
commit-queue@webkit.org [Sat, 20 Nov 2010 06:27:25 +0000 (06:27 +0000)]
2010-11-19  Zalan Bujtas  <zbujtas@gmail.com>

        Reviewed by Andreas Kling.

        WebUIClient::createNewPage() expects a retained WKPageRef.
        https://bugs.webkit.org/show_bug.cgi?id=48549

        * UIProcess/API/qt/ClientImpl.cpp:
        (qt_wk_createNewPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Sat, 20 Nov 2010 05:48:04 +0000 (05:48 +0000)]
2010-11-19  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Transition and animation do not work with QWebView anymore
        https://bugs.webkit.org/show_bug.cgi?id=49797

        Accelerated compositing should not be enabled on QWebView without
        texture mapper.

        * WebCoreSupport/PageClientQt.h:
        (WebCore::PageClientQWidget::allowsAcceleratedCompositing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Sat, 20 Nov 2010 05:20:29 +0000 (05:20 +0000)]
2010-11-19  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Memory leak in QWebInspector
        https://bugs.webkit.org/show_bug.cgi?id=49765

        Delete QWebInspectorPrivate in ~QWebInspector()

        * Api/qwebinspector.cpp:
        (QWebInspector::~QWebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sat, 20 Nov 2010 04:51:48 +0000 (04:51 +0000)]
2010-11-19  Andreas Kling  <kling@webkit.org>

        Reviewed by Antonio Gomes.

        ScrollView: Make delegatesScrolling() and avoidScrollbarCreation() const.
        https://bugs.webkit.org/show_bug.cgi?id=49854

        * page/FrameView.cpp:
        (WebCore::FrameView::delegatesScrolling):
        (WebCore::FrameView::avoidScrollbarCreation):
        * page/FrameView.h:
        * platform/ScrollView.h:
        (WebCore::ScrollView::delegatesScrolling):
        (WebCore::ScrollView::avoidScrollbarCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 William Chan <willchan@chromium.org>
commit-queue@webkit.org [Sat, 20 Nov 2010 04:40:32 +0000 (04:40 +0000)]
2010-11-19  William Chan  <willchan@chromium.org>

        Reviewed by David Levin.

        Add USE(CHROMIUM_NET)

        Indicates the use of Chromium's network stack.  Chromium's network
        stack performs better when it has full view of all resource requests,
        so USE(CHROMIUM_NET) can be used to bypass throttles.

        https://bugs.webkit.org/show_bug.cgi?id=49778

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTouch file to force build.
sfalken@apple.com [Sat, 20 Nov 2010 03:24:38 +0000 (03:24 +0000)]
Touch file to force build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Sat, 20 Nov 2010 03:09:47 +0000 (03:09 +0000)]
2010-11-19  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: scripts panel should be shown before execution line is scrolled into view.
        https://bugs.webkit.org/show_bug.cgi?id=49792

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.debuggerPaused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a didFail WKContextDownloadClient callback
andersca@apple.com [Sat, 20 Nov 2010 02:20:27 +0000 (02:20 +0000)]
Add a didFail WKContextDownloadClient callback
https://bugs.webkit.org/show_bug.cgi?id=49847

Reviewed by Sam Weinig.

* UIProcess/API/C/WKContext.h:
Add didFail callback.

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didFail):
Call WebDownloadClient::didFail.

* UIProcess/WebDownloadClient.cpp:
(WebKit::WebDownloadClient::didFail):
Call the didFail client function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 20 Nov 2010 02:12:00 +0000 (02:12 +0000)]
2010-11-19  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Rebaseline server: checksum-only differences and prefetching
        https://bugs.webkit.org/show_bug.cgi?id=49841

        Add support for image test results where the only difference is in the
        checksum.

        Add prefetching of the image results from the next test.

        * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 James Simonsen <simonjam@chromium.org>
commit-queue@webkit.org [Sat, 20 Nov 2010 01:52:03 +0000 (01:52 +0000)]
2010-11-19  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Fix whitespace character handling in complex text on linux
        https://bugs.webkit.org/show_bug.cgi?id=49771

        * platform/chromium-linux/fast/text/international/bidi-linebreak-001-expected.checksum: Remove null glyph from expected output.
        * platform/chromium-linux/fast/text/international/bidi-linebreak-001-expected.png: Ditto.
        * platform/chromium-linux/fast/text/international/bidi-linebreak-001-expected.txt: Ditto.
        * platform/chromium-linux/fast/text/international/bidi-linebreak-002-expected.checksum: Ditto.
        * platform/chromium-linux/fast/text/international/bidi-linebreak-002-expected.png: Ditto.
        * platform/chromium-linux/fast/text/international/bidi-linebreak-002-expected.txt: Ditto.
        * platform/chromium-linux/fast/text/international/bidi-linebreak-003-expected.checksum: Ditto.
        * platform/chromium-linux/fast/text/international/bidi-linebreak-003-expected.png: Ditto.
        * platform/chromium-linux/fast/text/international/bidi-linebreak-003-expected.txt: Ditto.
        * platform/chromium-linux/fast/text/wide-zero-width-space-expected.checksum: Added. Now passes on Linux.
        * platform/chromium-linux/fast/text/wide-zero-width-space-expected.png: Added.
        * platform/chromium-linux/fast/text/wide-zero-width-space-expected.txt: Added.
        * platform/chromium/test_expectations.txt: Removed LINUX from wide-zero-width-space.
2010-11-19  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Fix whitespace character handling in complex text on linux
        https://bugs.webkit.org/show_bug.cgi?id=49771

        * platform/graphics/SimpleFontData.h:
        (WebCore::SimpleFontData::isZeroWidthSpaceGlyph): Added.
        (WebCore::SimpleFontData::boundsForGlyph): Use isZeroWidthSpaceGlyph().
        (WebCore::SimpleFontData::widthForGlyph): Use isZeroWidthSpaceGlyph().
        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::nextScriptRun): Cache currently used font data.
        (WebCore::TextRunWalker::setGlyphXPositions): Skip zero width spaces.
        (WebCore::TextRunWalker::normalizeSpacesAndMirrorChars): Normalize zero width spaces.
        (WebCore::TextRunWalker::getNormalizedTextRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 20 Nov 2010 01:49:50 +0000 (01:49 +0000)]
2010-11-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread

        Add the 'worker number' and 'worker name' concepts to the
        TestShellThread objects, and move test_types and test_args from
        the TestRunner to the TestShellThread.

        https://bugs.webkit.org/show_bug.cgi?id=49768

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 20 Nov 2010 01:48:12 +0000 (01:48 +0000)]
2010-11-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        Do some minor cleanup and bug fixing.

        https://bugs.webkit.org/show_bug.cgi?id=49777

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoExtend sandbox when downloading files
andersca@apple.com [Sat, 20 Nov 2010 01:43:52 +0000 (01:43 +0000)]
Extend sandbox when downloading files
https://bugs.webkit.org/show_bug.cgi?id=49844

Reviewed by Sam Weinig.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add new overload.

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
Create a sandbox extension handle if necessary.

* UIProcess/Downloads/DownloadProxy.messages.in:
Add a sandbox extension handle out parameter to the DecideDestinationWithSuggestedFilename message.

* WebProcess/Downloads/Download.cpp:
(WebKit::Download::decideDestinationWithSuggestedFilename):
Create and consume the returned sandbox extension handle.

(WebKit::Download::didFinish):
(WebKit::Download::didFail):
Invalidate the sandbox extension handles.

* WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:shouldDecodeSourceDataOfMIMEType:]):
Whoops, fix inverted logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 20 Nov 2010 01:39:32 +0000 (01:39 +0000)]
2010-11-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        nrwt - config.build_directory() is busted

        Fixes a typo that was causing us to usually return the top level
        directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
        bug was hidden by test stubs that were too simplistic :(.

        https://bugs.webkit.org/show_bug.cgi?id=49815

        * Scripts/webkitpy/common/system/executive_mock.py:
        * Scripts/webkitpy/layout_tests/port/config.py:
        * Scripts/webkitpy/layout_tests/port/config_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Sat, 20 Nov 2010 01:15:17 +0000 (01:15 +0000)]
2010-11-19  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
        https://bugs.webkit.org/show_bug.cgi?id=49819

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.vcproj/testapi/testapi.vcproj:
2010-11-19  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
        https://bugs.webkit.org/show_bug.cgi?id=49819

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKit.sln:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:
2010-11-19  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
        https://bugs.webkit.org/show_bug.cgi?id=49819

        * WebCore.vcproj/QTMovieWin.vcproj:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/WebCoreGenerated.vcproj:
2010-11-19  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
        https://bugs.webkit.org/show_bug.cgi?id=49819

        * DumpRenderTree/DumpRenderTree.sln:
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:
        * FindSafari/FindSafari.vcproj:
        * MiniBrowser/MiniBrowser.vcproj:
        * TestWebKitAPI/win/TestWebKitAPI.sln:
        * TestWebKitAPI/win/TestWebKitAPI.vcproj:
        * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
        * WebKitAPITest/WebKitAPITest.vcproj:
        * WebKitLauncherWin/WebKitLauncherWin.vcproj:
        * WebKitTestRunner/win/InjectedBundle.vcproj:
        * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
        * WebKitTestRunner/win/WebKitTestRunner.vcproj:
        * WinLauncher/WinLauncher.vcproj:
        * record-memory-win/record-memory-win.vcproj:
2010-11-19  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
        https://bugs.webkit.org/show_bug.cgi?id=49819

        * win/WebKit2.vcproj:
        * win/WebKit2Generated.vcproj:
        * win/WebKit2WebProcess.vcproj:
        * win/WebKit2WebProcessCommon.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd Lucas De Marchi's blog to Planet WebKit
aroben@apple.com [Sat, 20 Nov 2010 00:40:25 +0000 (00:40 +0000)]
Add Lucas De Marchi's blog to Planet WebKit

Reviewed by Jon Honeycutt.

* config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd some more Windows slaves
aroben@apple.com [Sat, 20 Nov 2010 00:33:17 +0000 (00:33 +0000)]
Add some more Windows slaves

This is probably more than we will be using in the immediate future,
but having some extra slave names makes experimenting with different
configurations easier.

Reviewed by Jon Honeycutt.

* BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
Windows slaves and distributed them among the three different Test
builders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMore of <rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=49836
beidson@apple.com [Sat, 20 Nov 2010 00:32:57 +0000 (00:32 +0000)]
More of <rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=49836
Add WebKit2 API relevant to customization of context menus

Reviewed by Darin Adler.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameAllowsFollowingLink):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::allowsFollowingLink):
* WebProcess/WebPage/WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 20 Nov 2010 00:24:55 +0000 (00:24 +0000)]
2010-11-19  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium/Mac rebaseline.

        Rebaseline tests in fast/events that have different scrollbar rendering.

        * platform/chromium-mac/fast/events/autoscroll-expected.checksum: Added.
        * platform/chromium-mac/fast/events/autoscroll-expected.png: Added.
        * platform/chromium-mac/fast/events/pointer-events-2-expected.checksum: Added.
        * platform/chromium-mac/fast/events/pointer-events-2-expected.png: Added.
        * platform/chromium-mac/fast/events/reveal-link-when-focused-expected.checksum: Added.
        * platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 20 Nov 2010 00:21:04 +0000 (00:21 +0000)]
2010-11-19  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium/Mac rebaseline.

        Rebaseline tests in fast/frames that have different scrollbar rendering.

        * platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.checksum: Added.
        * platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.png: Added.
        * platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Added.
        * platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.png: Added.
        * platform/chromium-mac/fast/frames/invalid-expected.checksum: Added.
        * platform/chromium-mac/fast/frames/invalid-expected.png: Added.
        * platform/chromium-mac/fast/frames/valid-expected.checksum: Added.
        * platform/chromium-mac/fast/frames/valid-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 20 Nov 2010 00:13:25 +0000 (00:13 +0000)]
2010-11-19  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium/Mac rebaseline of transforms/2d/zoom-menulist.html.

        * platform/chromium-mac/transforms/2d/zoom-menulist-expected.checksum: Added.
        * platform/chromium-mac/transforms/2d/zoom-menulist-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 20 Nov 2010 00:05:27 +0000 (00:05 +0000)]
2010-11-19  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        http/tests/loading/bad-server-subframe.html had chromium-win baselines
        that made it fail consistently on Windows and Linux. It should pass with
        the regular upstream baselines.

        * platform/chromium-win/http/tests/loading/bad-server-subframe-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=49836
beidson@apple.com [Fri, 19 Nov 2010 23:41:02 +0000 (23:41 +0000)]
<rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=49836
Add WebKit2 API relevant to customization of context menus

Reviewed by Darin Adler.

WebCore:

* WebCore.exp.in:

WebKit2:

Most of this is just exposing already-existing concepts in API.

* Shared/API/c/WKURLRequest.cpp:
(WKURLRequestCreateWithWKURL):
* Shared/API/c/WKURLRequest.h:

* Shared/WebURLRequest.cpp:
(WebKit::WebURLRequest::create):
* Shared/WebURLRequest.h:

* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultCopyAbsoluteImageURL):
(WKBundleHitTestResultCopyAbsoluteMediaURL):
(WKBundleHitTestResultGetImageRect):
(WKBundleHitTestResultGetIsSelected):
* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageHasLocalDataForURL):
(WKBundlePageCanHandleRequest):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:

* WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::absoluteImageURL):
(WebKit::InjectedBundleHitTestResult::absoluteMediaURL):
(WebKit::InjectedBundleHitTestResult::imageRect):
(WebKit::InjectedBundleHitTestResult::isSelected):
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:

* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::hasLocalDataForURL):
(WebKit::WebPage::canHandleRequest):
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::hasLocalDataForURL): Stubbed for now.
(WebKit::WebPage::canHandleRequest): Ditto.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::hasLocalDataForURL): Ditto.
(WebKit::WebPage::canHandleRequest): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Fri, 19 Nov 2010 23:08:28 +0000 (23:08 +0000)]
2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Ojan Vafai.

        [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
        https://bugs.webkit.org/show_bug.cgi?id=49702

        Re-landing r72357 with a test fix.

        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, adding TIMEOUT for inspector/styles-disable-then-delete.html.
jparent@chromium.org [Fri, 19 Nov 2010 22:59:24 +0000 (22:59 +0000)]
Not reviewed, adding TIMEOUT for inspector/styles-disable-then-delete.html.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 19 Nov 2010 22:59:14 +0000 (22:59 +0000)]
2010-11-19  Michael Saboff  <msaboff@apple.com>

        Reviewed by Sam Weinig

        Remove DOMSVGAnimatedPathData.h from all: target to fix build.

        * MigrateHeaders.make:

2010-11-19  Michael Saboff  <msaboff@apple.com>

        Reviewed by Sam Weinig

        Remove DOMSVGAnimatedPathData.h from all: target to fix build.

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 19 Nov 2010 22:40:12 +0000 (22:40 +0000)]
2010-11-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Don't check for constant registers when we can guarantee that the register won't be in the constant pool
        https://bugs.webkit.org/show_bug.cgi?id=49814

        Add uncheckedR(int) to CallFrame, and replace all the uses of r() with uncheckedR()
        when we can guarantee that the register is not referring to a constant.
        This makes the interpreter about 0.5% faster, and makes the CallFrame initialisation
        logic correct when we're using a faked callframe (as in the case of the globalExec).

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::createActivation):
        * debugger/DebuggerCallFrame.cpp:
        (JSC::DebuggerCallFrame::thisObject):
        * interpreter/CallFrame.h:
        (JSC::ExecState::uncheckedR):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::resolve):
        (JSC::Interpreter::resolveSkip):
        (JSC::Interpreter::resolveGlobal):
        (JSC::Interpreter::resolveGlobalDynamic):
        (JSC::Interpreter::resolveBase):
        (JSC::Interpreter::resolveBaseAndProperty):
        (JSC::Interpreter::callEval):
        (JSC::Interpreter::unwindCallFrame):
        (JSC::Interpreter::throwException):
        (JSC::Interpreter::execute):
        (JSC::Interpreter::executeCall):
        (JSC::Interpreter::executeConstruct):
        (JSC::Interpreter::prepareForRepeatCall):
        (JSC::Interpreter::createExceptionScope):
        (JSC::Interpreter::privateExecute):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::argumentsGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Avi Drissman <avi@google.com>
commit-queue@webkit.org [Fri, 19 Nov 2010 22:37:06 +0000 (22:37 +0000)]
2010-11-19  Avi Drissman  <avi@google.com>

        Reviewed by Antonio Gomes.

        Complete support for Unix editing mode
        https://bugs.webkit.org/show_bug.cgi?id=49757

        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
2010-11-19  Avi Drissman  <avi@google.com>

        Reviewed by Antonio Gomes.

        Complete support for Unix editing mode
        https://bugs.webkit.org/show_bug.cgi?id=49757

        * DumpRenderTree/LayoutTestController.cpp:
        (setEditingBehaviorCallback):
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setEditingBehavior):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 19 Nov 2010 22:23:24 +0000 (22:23 +0000)]
2010-11-19  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Need a way to clear disk cache from WebContext
        https://bugs.webkit.org/show_bug.cgi?id=49820

        * UIProcess/API/C/WKContext.cpp:
        (WKContextClearResourceCaches): Added.
        (WKContextClearApplicationCache): Added.
        * UIProcess/API/C/WKContext.h:
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::clearResourceCaches): Added.
        (WebKit::WebContext::clearApplicationCache): Added.
        * UIProcess/WebContext.h:
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::clearResourceCaches): Added.
        (WebKit::WebProcess::clearApplicationCache): Added.
        * WebProcess/WebProcess.h:
        * WebProcess/WebProcess.messages.in: Added messages.
        * WebProcess/mac/WebProcessMac.mm:
        (WebKit::WebProcess::platformClearResourceCaches): Added.
        * WebProcess/qt/WebProcessQt.cpp:
        (WebKit::WebProcess::platformClearResourceCaches): Added.
        * WebProcess/win/WebProcessWin.cpp:
        (WebKit::WebProcess::platformClearResourceCaches): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 19 Nov 2010 22:22:55 +0000 (22:22 +0000)]
2010-11-19  Zhenyao Mo  <zmo@google.com>

        Unreviewed, update webgl test expectations.

        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:
        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplement support for loading local files
andersca@apple.com [Fri, 19 Nov 2010 22:15:14 +0000 (22:15 +0000)]
Implement support for loading local files
https://bugs.webkit.org/show_bug.cgi?id=49828
<rdar://problem/8447121>

Reviewed by Sam Weinig.

* UIProcess/WebPageProxy.cpp:
(WebKit::initializeSandboxExtensionHandle):
Given an URL, create a sandbox extension if it's a local file URL.

(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
Pass along sandbox extension handles to the LoadURL and LoadURLRequest messages.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
Call SandboxExtensionTracker::didStartProvisionalLoad.

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
Call SandboxExtensionTracker::didCommitProvisionalLoad.

(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
Call SandboxExtensionTracker::didFailProvisionalLoad.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::~WebPage):
Invalidate the sandbox extension tracker.

(WebKit::WebPage::close):
Invalidate the sandbox extension tracker.

(WebKit::WebPage::loadURL):
(WebKit::WebPage::loadURLRequest):
Pass the sandbox extension handle to the sandbox extension tracker.

(WebKit::WebPage::SandboxExtensionTracker::~SandboxExtensionTracker):
Invalidate the sandbox extension tracker.

(WebKit::WebPage::SandboxExtensionTracker::invalidate):
invalidate ell the sandbox extensions.

(WebKit::WebPage::SandboxExtensionTracker::beginLoad):
Create a sandbox extension and store it as the "pending provisional extension".

(WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
Consume the pending provisional extension and make it the provisional extension.

(WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
Invalidate the committed extension and make the provisional extension the committed extension.

(WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
Invalidate the provisional extension.

* WebProcess/WebPage/WebPage.messages.in:
Add SandboxExtension::Handle parameters to LoadURL and LoadURLRequest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 19 Nov 2010 22:14:55 +0000 (22:14 +0000)]
2010-11-19  Zhenyao Mo  <zmo@google.com>

        Unreviewed, update webgl test expectations.

        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Fri, 19 Nov 2010 22:13:55 +0000 (22:13 +0000)]
2010-11-19  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Darin Fisher.

        Expose default value of maxLength in Chromium API
        https://bugs.webkit.org/show_bug.cgi?id=49723

        * public/WebInputElement.h: Added constant defaultMaximumLength
        * src/WebInputElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Fri, 19 Nov 2010 21:52:06 +0000 (21:52 +0000)]
2010-11-19  Nate Chapin  <japhet@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Test for https://bugs.webkit.org/show_bug.cgi?id=49693

        * fast/loader/subresource-willSendRequest-null-expected.txt: Added.
        * fast/loader/subresource-willSendRequest-null.html: Added.
2010-11-19  Nate Chapin  <japhet@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Remove requests from ResourceLoadScheduler's queue before
        actually starting them.  We're holding a RefPtr anyway, and
        the load might be terminated and removed from the queue synchronously.
        https://bugs.webkit.org/show_bug.cgi?id=49693

        Test: fast/loader/subresource-willSendRequest-null.html

        * loader/ResourceLoadScheduler.cpp:
        (WebCore::ResourceLoadScheduler::servePendingRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake it possible to encode null SandboxExtension handles
andersca@apple.com [Fri, 19 Nov 2010 21:50:21 +0000 (21:50 +0000)]
Make it possible to encode null SandboxExtension handles
https://bugs.webkit.org/show_bug.cgi?id=49825

Reviewed by Darin Adler.

* Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::Handle::encode):
If there's no underlying sandbox extension, just encode an empty byte array.

(WebKit::SandboxExtension::Handle::decode):
If the decoded byte array is empty, don't try to create a sandbox extension.

(WebKit::SandboxExtension::create):
If the handle is null, return null.

(WebKit::SandboxExtension::consume):
Consuming shuld not null out the underlying sandbox extension object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-18 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 19 Nov 2010 21:48:46 +0000 (21:48 +0000)]
2010-11-18  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Make sure is* return false if the name is never bound
        https://bugs.webkit.org/show_bug.cgi?id=49767

        * html/canvas/WebGLBuffer.h: Add function to check whether the buffer has been bound before.
        (WebCore::WebGLBuffer::hasEverBeenBound):
        * html/canvas/WebGLFramebuffer.cpp: Ditto.
        (WebCore::WebGLFramebuffer::WebGLFramebuffer):
        * html/canvas/WebGLFramebuffer.h: Ditto.
        (WebCore::WebGLFramebuffer::hasEverBeenBound):
        (WebCore::WebGLFramebuffer::setBound):
        * html/canvas/WebGLRenderbuffer.cpp: Ditto.
        (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
        * html/canvas/WebGLRenderbuffer.h: Ditto.
        (WebCore::WebGLRenderbuffer::hasEverBeenBound):
        (WebCore::WebGLRenderbuffer::setBound):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::bindFramebuffer): Set bound status to true.
        (WebCore::WebGLRenderingContext::bindRenderbuffer): Ditto.
        (WebCore::WebGLRenderingContext::isBuffer): Return false if it's never bound.
        (WebCore::WebGLRenderingContext::isFramebuffer): Ditto.
        (WebCore::WebGLRenderingContext::isRenderbuffer): Ditto.
        (WebCore::WebGLRenderingContext::isTexture): Ditto.
        * html/canvas/WebGLTexture.h: Add function to check whether the texture has been bound before.
        (WebCore::WebGLTexture::hasEverBeenBound):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Fri, 19 Nov 2010 21:15:43 +0000 (21:15 +0000)]
2010-11-19  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] mask-box-image renders wrong in certain conditions
        https://bugs.webkit.org/show_bug.cgi?id=43476

        Qt does not follow the same convention as the other port
        when rendering a pixmap with null width of height. When one
        of those dimension is null, we should ignore the painting call
        to behave like the other ports.

        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-18 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 19 Nov 2010 21:03:50 +0000 (21:03 +0000)]
2010-11-18  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        GraphicsContext3D::reshape is clearing using current clear color instead of transparent
        https://bugs.webkit.org/show_bug.cgi?id=44064

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::reshape): Use 0 as clear values.
2010-11-18  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        GraphicsContext3D::reshape is clearing using current clear color instead of transparent
        https://bugs.webkit.org/show_bug.cgi?id=44064

        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::reset): Use 0 as clear values.
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
        (WebCore::GraphicsContext3D::reshape): Ditto.
2010-11-18  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        GraphicsContext3D::reshape is clearing using current clear color instead of transparent
        https://bugs.webkit.org/show_bug.cgi?id=44064

        * fast/canvas/webgl/renderbuffer-initialization-expected.txt:
        * fast/canvas/webgl/renderbuffer-initialization.html: Test that o is used as the clear values instead of the current gl clear values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRebaseline fast/blockflow results for Windows after r72347.
bweinstein@apple.com [Fri, 19 Nov 2010 20:59:35 +0000 (20:59 +0000)]
Rebaseline fast/blockflow results for Windows after r72347.

* platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
* platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
* platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix failing Windows ruby tests by removing the Windows-specific results. These were...
bweinstein@apple.com [Fri, 19 Nov 2010 20:48:14 +0000 (20:48 +0000)]
Fix failing Windows ruby tests by removing the Windows-specific results. These were the same as the Mac
results before r72347, and that change rebaselined the results in LayoutTests/platform/mac, making these
not match anymore, and causing the Windows tests to fail.

* platform/win/fast/ruby/ruby-empty-rt-expected.checksum: Removed.
* platform/win/fast/ruby/ruby-empty-rt-expected.png: Removed.
* platform/win/fast/ruby/ruby-empty-rt-expected.txt: Removed.
* platform/win/fast/ruby/ruby-length-expected.checksum: Removed.
* platform/win/fast/ruby/ruby-length-expected.png: Removed.
* platform/win/fast/ruby/ruby-length-expected.txt: Removed.
* platform/win/fast/ruby/ruby-run-break-expected.checksum: Removed.
* platform/win/fast/ruby/ruby-run-break-expected.png: Removed.
* platform/win/fast/ruby/ruby-run-break-expected.txt: Removed.
* platform/win/fast/ruby/ruby-runs-expected.checksum: Removed.
* platform/win/fast/ruby/ruby-runs-expected.png: Removed.
* platform/win/fast/ruby/ruby-runs-expected.txt: Removed.
* platform/win/fast/ruby/ruby-runs-spans-expected.checksum: Removed.
* platform/win/fast/ruby/ruby-runs-spans-expected.png: Removed.
* platform/win/fast/ruby/ruby-runs-spans-expected.txt: Removed.
* platform/win/fast/ruby/ruby-simple-expected.checksum: Removed.
* platform/win/fast/ruby/ruby-simple-expected.png: Removed.
* platform/win/fast/ruby/ruby-simple-expected.txt: Removed.
* platform/win/fast/ruby/ruby-simple-rp-expected.checksum: Removed.
* platform/win/fast/ruby/ruby-simple-rp-expected.png: Removed.
* platform/win/fast/ruby/ruby-simple-rp-expected.txt: Removed.
* platform/win/fast/ruby/ruby-trailing-expected.checksum: Removed.
* platform/win/fast/ruby/ruby-trailing-expected.png: Removed.
* platform/win/fast/ruby/ruby-trailing-expected.txt: Removed.
* platform/win/fast/ruby/rubyDOM-insert-rt-expected.checksum: Removed.
* platform/win/fast/ruby/rubyDOM-insert-rt-expected.png: Removed.
* platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt: Removed.
* platform/win/fast/ruby/rubyDOM-insert-text1-expected.checksum: Removed.
* platform/win/fast/ruby/rubyDOM-insert-text1-expected.png: Removed.
* platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt: Removed.
* platform/win/fast/ruby/rubyDOM-insert-text2-expected.checksum: Removed.
* platform/win/fast/ruby/rubyDOM-insert-text2-expected.png: Removed.
* platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt: Removed.
* platform/win/fast/ruby/rubyDOM-insert-text3-expected.checksum: Removed.
* platform/win/fast/ruby/rubyDOM-insert-text3-expected.png: Removed.
* platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt: Removed.
* platform/win/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Removed.
* platform/win/fast/ruby/rubyDOM-remove-rt1-expected.png: Removed.
* platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt: Removed.
* platform/win/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Removed.
* platform/win/fast/ruby/rubyDOM-remove-rt2-expected.png: Removed.
* platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt: Removed.
* platform/win/fast/ruby/rubyDOM-remove-text1-expected.checksum: Removed.
* platform/win/fast/ruby/rubyDOM-remove-text1-expected.png: Removed.
* platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt: Removed.
* platform/win/fast/ruby/rubyDOM-remove-text2-expected.checksum: Removed.
* platform/win/fast/ruby/rubyDOM-remove-text2-expected.png: Removed.
* platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix run-javascriptcore-tests when there's a space in the path to testapi
aroben@apple.com [Fri, 19 Nov 2010 20:47:26 +0000 (20:47 +0000)]
Fix run-javascriptcore-tests when there's a space in the path to testapi

Reviewed by Sam Weinig.

* Scripts/run-javascriptcore-tests: Use an indirect object when calling
system() to force it to interpret spaces in the path correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate scripts for .exe name changes after r72327
aroben@apple.com [Fri, 19 Nov 2010 20:46:55 +0000 (20:46 +0000)]
Update scripts for .exe name changes after r72327

As of r72327, the "_debug" suffix is only used in Debug_All builds.

Reviewed by Sam Weinig.

* Scripts/run-javascriptcore-tests:
(testapiPath):

* Scripts/sunspider-compare-results:
(pathToBuiltJSC):

* Scripts/webkitdirs.pm:
(jscPath):
(safariPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 19 Nov 2010 20:27:05 +0000 (20:27 +0000)]
2010-11-19  Chris Rogers  <crogers@google.com>

        Reviewed by Darin Adler.

        AudioContext should not include "HTMLNames.h"
        https://bugs.webkit.org/show_bug.cgi?id=49680

        No new tests since audio API is not yet implemented.

        * webaudio/AudioContext.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Fri, 19 Nov 2010 20:22:15 +0000 (20:22 +0000)]
2010-11-19  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Normalize Cairo/CFLite project/solution configuration names
        https://bugs.webkit.org/show_bug.cgi?id=49818

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.vcproj/testapi/testapi.vcproj:
2010-11-19  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Normalize Cairo/CFLite project/solution configuration names
        https://bugs.webkit.org/show_bug.cgi?id=49818

        * WebKit.vcproj/WebKit.sln:
        * WebKit.vcproj/WebKit.vcproj:
2010-11-19  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Normalize Cairo/CFLite project/solution configuration names
        https://bugs.webkit.org/show_bug.cgi?id=49818

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/WebCoreGenerated.vcproj:
2010-11-19  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Normalize Cairo/CFLite project/solution configuration names
        https://bugs.webkit.org/show_bug.cgi?id=49818

        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:
        * MiniBrowser/MiniBrowser.vcproj:
        * TestWebKitAPI/win/TestWebKitAPI.sln:
        * TestWebKitAPI/win/TestWebKitAPI.vcproj:
        * WebKitAPITest/WebKitAPITest.vcproj:
        * WebKitTestRunner/win/InjectedBundle.vcproj:
        * WebKitTestRunner/win/WebKitTestRunner.vcproj:
        * WinLauncher/WinLauncher.vcproj:
        * Scripts/webkitdirs.pm: Updated cairo build configs.
2010-11-19  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Normalize Cairo/CFLite project/solution configuration names
        https://bugs.webkit.org/show_bug.cgi?id=49818

        * win/WebKit2.vcproj:
        * win/WebKit2WebProcess.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, remove suppression for svg/dom/fuzz-path-parser.html
jparent@chromium.org [Fri, 19 Nov 2010 20:20:38 +0000 (20:20 +0000)]
Not reviewed, remove suppression for svg/dom/fuzz-path-parser.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Fri, 19 Nov 2010 20:08:20 +0000 (20:08 +0000)]
2010-11-19  Daniel Bates  <dbates@rim.com>

        Reviewed by Antonio Gomes.

        Replace null checks of newParent in Frame::transferChildFrameToNewDocument() with ASSERT
        https://bugs.webkit.org/show_bug.cgi?id=49489

        Substitute ASSERT(newParent) for null-checks for newParent in
        Frame::transferChildFrameToNewDocument() since newParent is
        never null.

        When Frame::transferChildFrameToNewDocument() is called the child
        frame's owner element has already been transferred to the new
        document D and D is attached (i.e. has a frame).

        * page/Frame.cpp:
        (WebCore::Frame::transferChildFrameToNewDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd SandboxExtension abstraction and use it for the injected bundle extension
andersca@apple.com [Fri, 19 Nov 2010 20:01:27 +0000 (20:01 +0000)]
Add SandboxExtension abstraction and use it for the injected bundle extension
https://bugs.webkit.org/show_bug.cgi?id=49817

Reviewed by Sam Weinig.

WebCore:

Export fileSystemRepresentation symbol needed by WebKit2.

* WebCore.exp.in:

WebKit2:

* Shared/SandboxExtension.h:
Add SandboxExtension abstraction.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
Instead of encoding/decoding a token, encode/decode the sandbox extension handle.

* Shared/mac/SandboxExtensionMac.mm: Added.
Add Mac implementation of SandboxExtension.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
Create a SandboxExtension::Handle object.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

* WebProcess/InjectedBundle/InjectedBundle.h:
(WebKit::InjectedBundle::setSandboxExtension):
Set the sandbox extension.

* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
(WebKit::InjectedBundle::load):
Consume the sandbox extension.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Create a sandbox extension and set it on the injected bundle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 19 Nov 2010 19:21:42 +0000 (19:21 +0000)]
2010-11-19  Tony Chang  <tony@chromium.org>

        Unreviewed, updating Chromium DEPS to try and fix the chromium win build.

        * DEPS: r66792

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fix. Remove leftover Debug_Internal use.
sfalken@apple.com [Fri, 19 Nov 2010 19:06:17 +0000 (19:06 +0000)]
Windows build fix. Remove leftover Debug_Internal use.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, remove suppression for fast/repaint/inline-block-overflow.html.
antonm@chromium.org [Fri, 19 Nov 2010 18:52:03 +0000 (18:52 +0000)]
Not reviewed, remove suppression for fast/repaint/inline-block-overflow.html.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-18 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Fri, 19 Nov 2010 18:37:11 +0000 (18:37 +0000)]
2010-11-18  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Windows vcproj configuration names should be normalized across projects
        https://bugs.webkit.org/show_bug.cgi?id=49776

        * JavaScriptCore.vcproj/JavaScriptCore.sln:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
2010-11-18  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Windows vcproj configuration names should be normalized across projects
        https://bugs.webkit.org/show_bug.cgi?id=49776

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKit.sln:
2010-11-18  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Windows vcproj configuration names should be normalized across projects
        https://bugs.webkit.org/show_bug.cgi?id=49776

        * WebCore.vcproj/WebCore.sln:
        * WebCore.vcproj/WebCore.submit.sln:
        * WebCore.vcproj/WebCoreGenerated.vcproj:
        * WebCore.vcproj/WebCoreGeneratedCairo.vsprops: Added.
        * WebCore.vcproj/WebCoreGeneratedCommon.vsprops: Added.
2010-11-18  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Windows vcproj configuration names should be normalized across projects
        https://bugs.webkit.org/show_bug.cgi?id=49776

        * DumpRenderTree/DumpRenderTree.sln:
        * FindSafari/FindSafari.vcproj:
        * TestWebKitAPI/win/TestWebKitAPI.sln:
        * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
        * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
        * WebKitAPITest/WebKitAPITest.vcproj:
        * WebKitAPITest/WebKitAPITestCommon.vsprops:
        * WebKitLauncherWin/WebKitLauncherWin.vcproj:
        * WebKitTestRunner/WebKitTestRunner.sln:
        * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
        * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
        * record-memory-win/record-memory-win.vcproj:
2010-11-18  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Windows vcproj configuration names should be normalized across projects
        https://bugs.webkit.org/show_bug.cgi?id=49776

        * win/WebKit2.submit.sln:
        * win/WebKit2Generated.vcproj:
        * win/WebKit2GeneratedCommon.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 19 Nov 2010 18:29:35 +0000 (18:29 +0000)]
2010-11-19  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Enable webkit's TestNetscapePlugIn for DRT on win and linux
        https://bugs.webkit.org/show_bug.cgi?id=49706

        * platform/chromium/drt_expectations.txt:
2010-11-19  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Enable webkit's TestNetscapePlugIn for DRT on win and linux
        https://bugs.webkit.org/show_bug.cgi?id=49706

        It is enabled simply by copying the plugin into
        {Debug,Release}/plugins.  This change also rolls in a version of
        Chromium that disables the old plugin.

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 19 Nov 2010 18:23:24 +0000 (18:23 +0000)]
2010-11-19  Mihai Parparita  <mihaip@chromium.org>

        Add recent upstream Chromium dependencies to .gitignore.

        * .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 James Simonsen <simonjam@chromium.org>
commit-queue@webkit.org [Fri, 19 Nov 2010 18:19:30 +0000 (18:19 +0000)]
2010-11-19  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] Add unloadEventStart
        https://bugs.webkit.org/show_bug.cgi?id=49101

        * fast/dom/Window/window-properties-performance-expected.txt:
        * fast/dom/script-tests/webtiming.js:
        (checkTimingBeforeLoad):
        (checkTimingWhileDeferred):
        (checkWebTimingWhileAsync):
        (checkWebTimingOnLoad):
        (checkWebTimingAfterLoad):
        * fast/dom/webtiming-document-open-expected.txt:
        * fast/dom/webtiming-expected.txt:
        * fast/dom/webtiming-navigate-within-document-expected.txt:
2010-11-19  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] Add unloadEventStart
        https://bugs.webkit.org/show_bug.cgi?id=49101

        * loader/DocumentLoadTiming.h:
        (WebCore::DocumentLoadTiming::DocumentLoadTiming):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading): Use dispatchTimedEvent().
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent): Use dispatchTimedEvent().
        (WebCore::DOMWindow::dispatchTimedEvent): Added.
        * page/DOMWindow.h:
        * page/Timing.cpp:
        (WebCore::Timing::unloadEventStart):
        * page/Timing.h:
        * page/Timing.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, remove a suppression for svg/dom/svglist-exception-on-out-bounds-error...
antonm@chromium.org [Fri, 19 Nov 2010 18:08:52 +0000 (18:08 +0000)]
Not reviewed, remove a suppression for svg/dom/svglist-exception-on-out-bounds-error.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 19 Nov 2010 18:02:40 +0000 (18:02 +0000)]
2010-11-19  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Daniel Bates.

        [GTK] fast/text/international tests are flaky on the bots
        https://bugs.webkit.org/show_bug.cgi?id=49781

        Beef up the == operator overload for Freetype FontPlatformData. Before
        if two FontPlatformDatas had hash values which fell into the same bucket
        and were similar enough, they would be evaluated as being equal, leading
        to failures.

        No new tests for this change. It's very hard to test, because it depends
        on the memory address of new allocations. Hopefully flakiness on the bots
        will go away after patch.

        * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
        (WebCore::FontPlatformData::operator==): Beef up the == operator overload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Fri, 19 Nov 2010 17:34:14 +0000 (17:34 +0000)]
2010-11-19  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] mask-box-image renders wrong in certain conditions
        https://bugs.webkit.org/show_bug.cgi?id=43476

        When rendering a pixmap with a dest rect having a null dimension,
        Qt uses the dimension of the Pixmap. The other ports do not render
        anything by convention.

        This patch change BitmapImage to follow the convention of other ports and do not
        paint anything.

        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 19 Nov 2010 17:16:54 +0000 (17:16 +0000)]
2010-11-19  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed, build fix after r72360.

        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::bytecodeOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTemporary suppression for fast/repaint/inline-block-overflow.html
antonm@chromium.org [Fri, 19 Nov 2010 17:01:00 +0000 (17:01 +0000)]
Temporary suppression for fast/repaint/inline-block-overflow.html
See r72405.
It needs Chromium's images.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Sam Magnuson <smagnuso@gmail.com>
commit-queue@webkit.org [Fri, 19 Nov 2010 16:51:52 +0000 (16:51 +0000)]
2010-11-19  Sam Magnuson  <smagnuso@gmail.com>

        Reviewed by Andreas Kling.

        [Qt] Compile with QT_NO_UNDOCOMMAND
        https://bugs.webkit.org/show_bug.cgi?id=49752

        * WebCoreSupport/EditCommandQt.cpp:
        (EditCommandQt::EditCommandQt):
        * WebCoreSupport/EditCommandQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agosvg/batik/text/smallFonts.svg needs Leopard-specific results after
aestes@apple.com [Fri, 19 Nov 2010 16:51:13 +0000 (16:51 +0000)]
svg/batik/text/smallFonts.svg needs Leopard-specific results after
r72141.

* platform/mac-leopard/svg/batik/text/smallFonts-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTemporary suppression for fast/images/imagemap-focus-ring-zoom.html.
antonm@chromium.org [Fri, 19 Nov 2010 16:45:11 +0000 (16:45 +0000)]
Temporary suppression for fast/images/imagemap-focus-ring-zoom.html.
See r72402.
It needs Chromium's images.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSkip failing tests on the Leopard bots.
aestes@apple.com [Fri, 19 Nov 2010 16:41:22 +0000 (16:41 +0000)]
Skip failing tests on the Leopard bots.

* platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 19 Nov 2010 16:27:54 +0000 (16:27 +0000)]
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Don't call invalidateSVGAttributes() from the setFooBaseValue() methods
        https://bugs.webkit.org/show_bug.cgi?id=49807

        Covered by existing tests.

        * svg/SVGComponentTransferFunctionElement.cpp:
        (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): Use setFooBaseValue(newList) instead of fooBaseValue() = newList;
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): Ditto.
        * svg/SVGFEConvolveMatrixElement.cpp:
        (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): Ditto.
        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::parseMappedAttribute): Ditto.
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::parseMappedAttribute): Ditto.
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::parseMappedAttribute): Ditto.
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::parseMappedAttribute): Ditto.
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::parseMappedAttribute): Ditto.
        * svg/properties/SVGAnimatedPropertyMacros.h: Don't call invalidateSVGAttributes() in setFooBaseValue().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, nuking now unnecessary suppression.
antonm@chromium.org [Fri, 19 Nov 2010 16:21:31 +0000 (16:21 +0000)]
Not reviewed, nuking now unnecessary suppression.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 19 Nov 2010 16:16:24 +0000 (16:16 +0000)]
2010-11-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72399.
        http://trac.webkit.org/changeset/72399
        https://bugs.webkit.org/show_bug.cgi?id=49805

        Broke Chromium build (Requested by antonm_ on #webkit).

        * page/chromium/ChromeClientChromium.h:
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showPopup):
        (WebCore::PopupContainer::showExternal):
        (WebCore::PopupListBox::layout):
        (WebCore::PopupMenuChromium::show):
        * platform/chromium/PopupMenuChromium.h:
2010-11-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72399.
        http://trac.webkit.org/changeset/72399
        https://bugs.webkit.org/show_bug.cgi?id=49805

        Broke Chromium build (Requested by antonm_ on #webkit).

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::popupOpened):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Fri, 19 Nov 2010 16:05:13 +0000 (16:05 +0000)]
2010-11-19  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Focus ring in image maps does not take zooming into account
        https://bugs.webkit.org/show_bug.cgi?id=49625

        * fast/images/imagemap-focus-ring-zoom.html: Added.
        * platform/mac/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
        * platform/mac/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
        * platform/mac/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
2010-11-19  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Focus ring in image maps does not take zooming into account
        https://bugs.webkit.org/show_bug.cgi?id=49625

        Take pageZoomFactor into account when calculating the path of the focus ring.

        Test: fast/images/imagemap-focus-ring-zoom.html

        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::getPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCrash in WebKit::PluginView::manualLoadDidReceiveResponse when navigating to a .wav...
andersca@apple.com [Fri, 19 Nov 2010 15:47:12 +0000 (15:47 +0000)]
Crash in WebKit::PluginView::manualLoadDidReceiveResponse when navigating to a .wav file in WebKit2 on Mac
https://bugs.webkit.org/show_bug.cgi?id=48559
<rdar://problem/8606622>

Reviewed by Adam Roben.

Add null checks for m_plugin.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::manualLoadDidReceiveResponse):
(WebKit::PluginView::manualLoadDidReceiveData):
(WebKit::PluginView::manualLoadDidFinishLoading):
(WebKit::PluginView::manualLoadDidFail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 19 Nov 2010 15:44:35 +0000 (15:44 +0000)]
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGTransformList::consolidate() fails on empty lists
        https://bugs.webkit.org/show_bug.cgi?id=49619

        Return null in consolidate() when the list is empty, according to SVG 1.1.

        Test: svg/dom/SVGTransformList-empty-list-consolidation.html

        * svg/properties/SVGTransformListPropertyTearOff.h:
        (WebCore::SVGTransformListPropertyTearOff::consolidate):

2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGTransformList::consolidate() fails on empty lists
        https://bugs.webkit.org/show_bug.cgi?id=49619

        * svg/dom/SVGTransformList-empty-list-consolidation-expected.txt: Added.
        * svg/dom/SVGTransformList-empty-list-consolidation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Fri, 19 Nov 2010 15:38:58 +0000 (15:38 +0000)]
2010-11-19  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        [chromium] Removing the now unused code to show popup externally on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=49747

        * page/chromium/ChromeClientChromium.h:
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showPopup):
        (WebCore::PopupListBox::layout):
        (WebCore::PopupMenuChromium::show):
        * platform/chromium/PopupMenuChromium.h:
2010-11-19  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Removing unused code to show popup externally on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=49747

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::popupOpened):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-18 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 19 Nov 2010 15:34:10 +0000 (15:34 +0000)]
2010-11-18  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: reduce the footprint of InspectorBackendDispatcher.
        InspectorBackendDispatcher is a generated file.
        Its content is not optimal and loc may be reduced by a quarter.
        In each generated function we have a code for getting 'in' values from
        the arguments properties object. I've extracted this code into separate getters.
        The side effect is better readability of the generated code.

        https://bugs.webkit.org/show_bug.cgi?id=49729

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed.
ossy@webkit.org [Fri, 19 Nov 2010 15:14:14 +0000 (15:14 +0000)]
Unreviewed.

[Qt] REGRESSION (r72351): fast/profiler/throw-exception-from-eval.html fails
https://bugs.webkit.org/show_bug.cgi?id=49801

[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=49802

* platform/qt/Skipped: Add failing tests to the Skipped list until fix.
 - fast/profiler/throw-exception-from-eval.html
 - http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html
 - http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html
 - http/tests/security/aboutBlank/xss-DENIED-set-opener.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 John Knottenbelt <jknotten@chromium.org>
commit-queue@webkit.org [Fri, 19 Nov 2010 15:06:41 +0000 (15:06 +0000)]
2010-11-19  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Reentrant Geolocation tests crash with an assertion.
        https://bugs.webkit.org/show_bug.cgi?id=39908

        PositionErrors should not be sent to Geolocation watches or one
        shots that are due to receive a valid cached position. Re-enable
        fast/dom/Geolocation/maximum-age.html on Mac WebKit.

        * platform/mac/Skipped:
2010-11-19  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Reentrant Geolocation tests crash with an assertion.
        https://bugs.webkit.org/show_bug.cgi?id=39908

        PositionErrors should not be sent to Geolocation watches or one shots
        that are due to receive a valid cached position.

        Test: fast/dom/Geolocation/maximum-age.html

        * page/Geolocation.cpp:
        (WebCore::Geolocation::sendError):
        (WebCore::Geolocation::copyCachedNotifiers):
        (WebCore::Geolocation::handleError):
        * page/Geolocation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, next batch of Chromium suppressions for layout test failures after
antonm@chromium.org [Fri, 19 Nov 2010 14:57:23 +0000 (14:57 +0000)]
Not reviewed, next batch of Chromium suppressions for layout test failures after
http://trac.webkit.org/changeset/72381.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Sam Magnuson <smagnuso@gmail.com>
commit-queue@webkit.org [Fri, 19 Nov 2010 14:42:30 +0000 (14:42 +0000)]
2010-11-19  Sam Magnuson  <smagnuso@gmail.com>

        Reviewed by Laszlo Gombos.

        [Qt] Compile with QT_NO_CLIPBOARD
        https://bugs.webkit.org/show_bug.cgi?id=49742

        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::canSmartReplace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, removing duplicate expectation.
antonm@chromium.org [Fri, 19 Nov 2010 14:38:52 +0000 (14:38 +0000)]
Not reviewed, removing duplicate expectation.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 19 Nov 2010 14:26:35 +0000 (14:26 +0000)]
2010-11-19  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: flip chromium version to mitigate two-sided patch impact.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpstreaming Chromium suppressions.
antonm@chromium.org [Fri, 19 Nov 2010 14:21:25 +0000 (14:21 +0000)]
Upstreaming Chromium suppressions.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 19 Nov 2010 14:15:23 +0000 (14:15 +0000)]
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Andreas Kling.

        Remove more unused V8/SVG code
        https://bugs.webkit.org/show_bug.cgi?id=49800

        Remove DOMSVGObjectWithContextMap and all usages.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/DOMDataStore.cpp:
        (WebCore::DOMDataStore::DOMDataStore):
        (WebCore::DOMDataStore::getDOMWrapperMap):
        * bindings/v8/DOMDataStore.h:
        (WebCore::DOMDataStore::domSvgElementInstanceMap):
        * bindings/v8/ScopedDOMDataStore.cpp:
        (WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
        (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
        * bindings/v8/StaticDOMDataStore.cpp:
        (WebCore::StaticDOMDataStore::StaticDOMDataStore):
        * bindings/v8/StaticDOMDataStore.h:
        * bindings/v8/V8DOMMap.cpp:
        (WebCore::removeAllDOMObjectsInCurrentThread):
        * bindings/v8/V8DOMMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agocreateImageBuffer fail should be handled in the same way as other fails
zherczeg@webkit.org [Fri, 19 Nov 2010 14:13:43 +0000 (14:13 +0000)]
createImageBuffer fail should be handled in the same way as other fails
https://bugs.webkit.org/show_bug.cgi?id=49799

Reviewed by Nikolas Zimmermann.

WebCore:

When createImageBuffer fails (i.e the image width or height is less than
0.5, which is rounded to 0) it just returs with false. Since the m_filter
hash map is not updated in this case, the filter image is not drawn.

Test: svg/filters/filter-rounding-issues.svg

* rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):

LayoutTests:

* platform/mac/svg/filters/filter-rounding-issues-expected.checksum: Added.
* platform/mac/svg/filters/filter-rounding-issues-expected.png: Added.
* svg/filters/filter-rounding-issues-expected.txt: Added.
* svg/filters/filter-rounding-issues.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, next batch of Chromium suppressions for layout test failures after
antonm@chromium.org [Fri, 19 Nov 2010 14:08:31 +0000 (14:08 +0000)]
Not reviewed, next batch of Chromium suppressions for layout test failures after
http://trac.webkit.org/changeset/72381.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 19 Nov 2010 13:58:10 +0000 (13:58 +0000)]
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Andreas Kling.

        Remove old style SVG DOM JS bindings and DeprecatedSVGAnimated* files
        https://bugs.webkit.org/show_bug.cgi?id=49796

        Just remove the old style SVG DOM JS bindings, now that everything has been converted to the new concept.

        * GNUmakefile.am: Remove SVGList/SVGListTraits/JSSVGPODListCustom/JSSVGPODTypeWrapper/JSSVGContextCache and V8SVGPODTypeWrapper files.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/js/JSSVGContextCache.h: Removed.
        * bindings/js/JSSVGPODListCustom.h: Removed.
        * bindings/js/JSSVGPODTypeWrapper.h: Removed.
        * bindings/v8/V8Proxy.cpp: Remove SVG specific context cache code, which is no longer needed.
        * bindings/v8/V8Proxy.h: Ditto.
        * bindings/v8/V8SVGPODTypeWrapper.h: Removed.
        * svg/DeprecatedSVGAnimatedProperty.h: Removed.
        * svg/DeprecatedSVGAnimatedPropertyTraits.h: Removed.
        * svg/DeprecatedSVGAnimatedTemplate.h: Removed.
        * svg/SVGElement.h: Remove DeprecatedSVGAnimated* include, which pulled in SVGNames.h for every file.
        * svg/SVGList.h: Removed.
        * svg/SVGListTraits.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 19 Nov 2010 13:33:04 +0000 (13:33 +0000)]
2010-11-19  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] Crash on opening WebInspector for a page with CSS containing @media with nested rules
        https://bugs.webkit.org/show_bug.cgi?id=49731

        Temporarily disable building of styles for nested rules.

        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::buildObjectForRule):
        (WebCore::InspectorStyleSheet::buildObjectForStyle):
        (WebCore::InspectorStyleSheet::ensureParsedDataReady):
        (WebCore::InspectorStyleSheet::ensureSourceData):
        * inspector/InspectorStyleSheet.h:
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
        (WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
        (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, suppressing Chromium layout test failures after
antonm@chromium.org [Fri, 19 Nov 2010 13:30:11 +0000 (13:30 +0000)]
Not reviewed, suppressing Chromium layout test failures after
http://trac.webkit.org/changeset/72381.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 19 Nov 2010 13:20:30 +0000 (13:20 +0000)]
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix Qt build.

        * WebCore.pro: Move SVGPathSegListPropertyTearOff.cpp from HEADERS to SOURCES list. This got lost, when reapplying the patch from the bug - I only fixed it locally before landing the first time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, rebaselining vertical text tests for Chromium.
antonm@chromium.org [Fri, 19 Nov 2010 13:19:42 +0000 (13:19 +0000)]
Not reviewed, rebaselining vertical text tests for Chromium.

* platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
* platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
* platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
* platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
* platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
* platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
* platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
* platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
* platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
* platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.txt: Added.
* platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
* platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 19 Nov 2010 13:00:49 +0000 (13:00 +0000)]
2010-11-19  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, added the font-size-zero.html test to skipped and
        uploaded the bug: https://bugs.webkit.org/show_bug.cgi?id=49793

        It was added with r72327.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 19 Nov 2010 12:54:11 +0000 (12:54 +0000)]
2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
        https://bugs.webkit.org/show_bug.cgi?id=49580

        SVGPathElement.cloneNode loses generated pathSegList
        https://bugs.webkit.org/show_bug.cgi?id=43388

        SVG Path elements are not correctly updated through pathSegList manipulation on relative values
        https://bugs.webkit.org/show_bug.cgi?id=30219

        Changing an SVGPathSeg does not update a following Smooth Cubic Curveto
        https://bugs.webkit.org/show_bug.cgi?id=19741

        SVGPathElement should only build SVGPathSeg* list on demand
        https://bugs.webkit.org/show_bug.cgi?id=10827

        Tests: svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg
               svg/dom/SVGPathSegList-appendItem.xhtml
               svg/dom/SVGPathSegList-clear-and-initialize.xhtml
               svg/dom/SVGPathSegList-cloning.html
               svg/dom/SVGPathSegList-insertItemBefore.xhtml
               svg/dom/SVGPathSegList-removeItem.xhtml
               svg/dom/SVGPathSegList-replaceItem.xhtml
               svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml
               svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml
               svg/dom/SVGPathSegList-segment-modification.svg

        Convert SVGPathSeg*/SVGPathSegList to the new SVG(Animated)PropertyTearOff concept.
        Unlike all other SVG* types that use the SVGPropertyTearOff concept, SVGPathSegs are already refcounted,
        and don't need to be wrapped in SVGPropertyTearOff objects. The consequence is that SVGPathSegs need to track
        themselves to which list and path element they belong. Introduce new SVGAnimatedPathSegListPropertyTearOff
        and SVGPathSegListPropertyTearOff classes, that encapsulate the special needed for SVGPathSegList.

        Each SVGPathSeg now needs to store a RefPtr<SVGPathElement> - this makes it impossible to use SVGPathSegList
        to represent the 'd' attribute internally in SVGPathElement. SVGPathSegList is now only used in the SVG DOM bindings
        if someone explicitely requests 'pathElement.pathSegList' (eg. via JS). Switch to use SVGPathByteStream to store
        the 'd' attribute data in SVGPathElement, which is much more compact, and less memory intensive.
        Dirk already prepared SVGPathParserFactory some months ago, which allows easy conversion between
        String/Path/SVGPathSegList/SVGPathByteStream in all directions, including normalizing the lists, when requested.

        As consequence SVGPathSegList is now only built on demand, when explicitely requested. Using the SVGAnimatedProperty
        concept gives us 'd' attribute <-> SVGPathSegList synchronization for free, fixing several bugs, listed above.

        * Android.mk: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
        * CMakeLists.txt: Ditto.
        * DerivedSources.make: Remove SVGAnimatedPathData IDL generation.
        * GNUmakefile.am: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
        * WebCore.gyp/WebCore.gyp: Remove SVGAnimatedPathData IDL generation.
        * WebCore.gypi: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
        * WebCore.order: Remove no-longer existant SVGAnimatedPathData symbols.
        * WebCore.pro:  Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp / JSSVGPathSegCustom.* from build.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/js/JSBindingsAllInOne.cpp: Remove JSSVGPathSegCustom.cpp from build.
        * bindings/js/JSDOMBinding.cpp: Adapt to toJS() changes, remove context parameter.
        (WebCore::setDOMException):
        * bindings/js/JSDOMBinding.h: Remove obsolete CREATE_SVG_OBJECT_WRAPPER macro, the context parameter is not existant anymore.
        * bindings/js/JSSVGPathSegCustom.cpp: Replace CREATE_SVG_OBJECT_WRAPPER by CREATE_DOM_OBJECT_WRAPPER. Remove context parameter/handling.
        (WebCore::toJS):
        * bindings/js/JSSVGPathSegListCustom.cpp: Removed.
        * bindings/scripts/CodeGenerator.pm: Map 'SVGPathSegList' IDL type to SVG 'SVGPathSegListPropertyTearOff' native type.
        * bindings/scripts/CodeGeneratorJS.pm: Remove IsSVGTypeNeedingContextParameter() methods and usages. Handle SVGPathSegListPropertyTearOff.
        * bindings/scripts/CodeGeneratorObjC.pm: Handle SVGPathSegListPropertyTearOff.
        * bindings/scripts/CodeGeneratorV8.pm: Remove IsSVGTypeNeedingContextParameter() methods and usages.
        * rendering/SVGRenderTreeAsText.cpp: Build path string from byte stream, not path segment list.
        (WebCore::operator<<):
        * svg/SVGAllInOne.cpp: Remove obsolete cpp files.
        * svg/SVGAnimatedPathData.cpp: Removed.
        * svg/SVGAnimatedPathData.h: Removed.
        * svg/SVGAnimatedPathData.idl: Removed.
        * svg/SVGPathElement.cpp: Build SVGPathList on demand. Use SVGPathByteStream to parse/store the 'd' attribute content.
        (WebCore::SVGPathElement::SVGPathElement):
        (WebCore::SVGPathElement::getPathSegAtLength): Use SVGPathByteStream, not SVGPathSegList to determine the getPathSegAtLength() information.
        (WebCore::SVGPathElement::createSVGPathSegClosePath): Pass SVGPathElement to SVGPathSeg and a SVGPathSegRole parameter and store it to track the list origin.
        (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegMovetoRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegLinetoRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegArcAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegArcRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): Ditto.
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): Ditto.
        (WebCore::SVGPathElement::parseMappedAttribute): Build SVGPathByteStream from 'd' attribute, not a SVGPathSegList.
        (WebCore::SVGPathElement::svgAttributeChanged): If a SVGPathSegList object has been built, synchronize it with the 'd' attribute.
        (WebCore::SVGPathElement::synchronizeProperty): Synchronize 'd' attribute with the SVGPathSegList, if needed.
        (WebCore::SVGPathElement::synchronizeD): Added.
        (WebCore::SVGPathElement::pathSegList): Use same trick as in SVGPolyElement to expose the 'pathSegList' / 'animatedPathSegList' object to the SVG DOM bindings.
        (WebCore::SVGPathElement::normalizedPathSegList): Ditto.
        (WebCore::SVGPathElement::animatedPathSegList): Ditto.
        (WebCore::SVGPathElement::animatedNormalizedPathSegList): Ditto.
        (WebCore::SVGPathElement::toPathData): Build 'Path' object from SVGPathByteStream, not from SVGPathSegList.
        (WebCore::SVGPathElement::pathSegListChanged): Used to synchronize the SVGPathSegLists and the d attribute, as well as any changes from any SVGPathSeg associated with this SVGPathElement.
        * svg/SVGPathElement.h: Add new accessors...
        (WebCore::SVGPathElement::pathByteStream): ... needed by SVGRenderTreeAsText.
        (WebCore::SVGPathElement::animatablePathSegList): ... needed by SVGPathSegListPropertyTearOff.
        * svg/SVGPathElement.idl: Merge SVGAnimatedPathData interface into SVGPathElement.
        * svg/SVGPathParserFactory.cpp: Cleanup SVGPathParserFactory, remove obsolete methods, now that SVGPathElement switched to using SVGPathByteStream internally.
        (WebCore::globalSVGPathSegListBuilder):
        (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList):
        (WebCore::SVGPathParserFactory::buildPathFromByteStream):
        (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream):
        (WebCore::SVGPathParserFactory::buildStringFromSVGPathSegList):
        (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
        (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):
        (WebCore::SVGPathParserFactory::getSVGPathSegAtLengthFromSVGPathByteStream):
        * svg/SVGPathParserFactory.h:
        * svg/SVGPathSeg.cpp: Removed.
        * svg/SVGPathSeg.h: Add new SVGPathSegRole enum, identifying to which list a path segment belongs.
        (WebCore::SVGPathSeg::SVGPathSeg):
        * svg/SVGPathSeg.idl: Reindented.
        * svg/SVGPathSegArc.cpp: Removed.
        * svg/SVGPathSegArc.h: All setters now call the commitChange() method.
        * svg/SVGPathSegArcAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegArcRel.idl: Ditto.
        * svg/SVGPathSegClosePath.cpp: Removed.
        * svg/SVGPathSegClosePath.h:
        * svg/SVGPathSegCurvetoCubic.cpp: Removed.
        * svg/SVGPathSegCurvetoCubic.h: All setters now call the commitChange() method.
        * svg/SVGPathSegCurvetoCubicAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegCurvetoCubicRel.idl: Ditto.
        * svg/SVGPathSegCurvetoCubicSmooth.cpp: Removed.
        * svg/SVGPathSegCurvetoCubicSmooth.h: All setters now call the commitChange() method.
        * svg/SVGPathSegCurvetoCubicSmoothAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegCurvetoCubicSmoothRel.idl: Ditto.
        * svg/SVGPathSegCurvetoQuadratic.cpp: Removed.
        * svg/SVGPathSegCurvetoQuadratic.h: All setters now call the commitChange() method.
        * svg/SVGPathSegCurvetoQuadraticAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegCurvetoQuadraticRel.idl: Ditto.
        * svg/SVGPathSegCurvetoQuadraticSmooth.cpp: Removed.
        * svg/SVGPathSegCurvetoQuadraticSmooth.h: All setters now call the commitChange() method.
        * svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegCurvetoQuadraticSmoothRel.idl: Ditto.
        * svg/SVGPathSegLineto.cpp: Removed.
        * svg/SVGPathSegLineto.h: All setters now call the commitChange() method.
        * svg/SVGPathSegLinetoAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegLinetoHorizontal.cpp: Removed.
        * svg/SVGPathSegLinetoHorizontal.h: All setters now call the commitChange() method.
        * svg/SVGPathSegLinetoHorizontalAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegLinetoHorizontalRel.idl: Ditto.
        * svg/SVGPathSegLinetoRel.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegLinetoVertical.cpp: Removed.
        * svg/SVGPathSegLinetoVertical.h: All setters now call the commitChange() method.
        * svg/SVGPathSegLinetoVerticalAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegLinetoVerticalRel.idl: Ditto.
        * svg/SVGPathSegList.cpp: Switch from SVGList<RefPtr<SVGPathSeg> > to a plain Vector<RefPtr<SVGPathSeg> >.
        (WebCore::SVGPathSegList::valueAsString): Utilize SVGPathParserFactory to build a String from a SVGPathSegList.
        (WebCore::SVGPathSegList::commitChange): Call SVGPathElement::pathSegListChanged().
        * svg/SVGPathSegList.h:
        (WebCore::SVGPathSegList::SVGPathSegList):
        * svg/SVGPathSegList.idl: Remove [JSCCustom] flags, no longer needed.
        * svg/SVGPathSegListBuilder.cpp: Adapt to SVGPathSegList API changes.
        (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder):
        (WebCore::SVGPathSegListBuilder::moveTo):
        (WebCore::SVGPathSegListBuilder::lineTo):
        (WebCore::SVGPathSegListBuilder::lineToHorizontal):
        (WebCore::SVGPathSegListBuilder::lineToVertical):
        (WebCore::SVGPathSegListBuilder::curveToCubic):
        (WebCore::SVGPathSegListBuilder::curveToCubicSmooth):
        (WebCore::SVGPathSegListBuilder::curveToQuadratic):
        (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth):
        (WebCore::SVGPathSegListBuilder::arcTo):
        (WebCore::SVGPathSegListBuilder::closePath):
        * svg/SVGPathSegListBuilder.h: Ditto.
        (WebCore::SVGPathSegListBuilder::setCurrentSVGPathElement):
        (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList):
        (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegRole):
        (WebCore::SVGPathSegListBuilder::cleanup):
        * svg/SVGPathSegListSource.cpp: Ditto.
        (WebCore::SVGPathSegListSource::SVGPathSegListSource):
        (WebCore::SVGPathSegListSource::parseSVGSegmentType):
        (WebCore::SVGPathSegListSource::nextCommand):
        (WebCore::SVGPathSegListSource::parseMoveToSegment):
        (WebCore::SVGPathSegListSource::parseLineToSegment):
        (WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment):
        * svg/SVGPathSegListSource.h: Ditto.
        (WebCore::SVGPathSegListSource::create):
        * svg/SVGPathSegMoveto.cpp: Removed.
        * svg/SVGPathSegMoveto.h: All setters now call the commitChange() method.
        * svg/SVGPathSegMovetoAbs.idl: Enable StrictTypeChecking.
        * svg/SVGPathSegMovetoRel.idl: Ditto.
        * svg/SVGPathSegWithContext.h: Added. This is the new base class for all SVGPathSeg derived types, that's associated with a SVGPathElement and a 'role' (normalized/unaltered segment list).
        (WebCore::SVGPathSegWithContext::SVGPathSegWithContext):
        (WebCore::SVGPathSegWithContext::animatedProperty):
        (WebCore::SVGPathSegWithContext::setContextAndRole):
        (WebCore::SVGPathSegWithContext::commitChange):
        (WebCore::SVGPathSegSingleCoordinate::x):
        (WebCore::SVGPathSegSingleCoordinate::setX):
        (WebCore::SVGPathSegSingleCoordinate::y):
        (WebCore::SVGPathSegSingleCoordinate::setY):
        (WebCore::SVGPathSegSingleCoordinate::SVGPathSegSingleCoordinate):
        * svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Added.
        (WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal):
        (WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal):
        (WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList):
        (WebCore::SVGAnimatedPathSegListPropertyTearOff::create):
        (WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):
        * svg/properties/SVGPathSegListPropertyTearOff.cpp: Added.
        (WebCore::SVGPathSegListPropertyTearOff::clear): Added in the cpp file, not in the header, as it needs access to SVGPathSegWithContext, which we can't include from the header.
        (WebCore::SVGPathSegListPropertyTearOff::getItem): Ditto.
        (WebCore::SVGPathSegListPropertyTearOff::removeItem): Ditto.
        (WebCore::SVGPathSegListPropertyTearOff::contextElement): Needs access to SVGPathElement, that's why it lives in the cpp file.
        (WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemValue): Needs access to SVGPathSegWithContext.
        * svg/properties/SVGPathSegListPropertyTearOff.h: Added.
        (WebCore::SVGPathSegListPropertyTearOff::create):
        (WebCore::SVGPathSegListPropertyTearOff::removeItemFromList):
        (WebCore::SVGPathSegListPropertyTearOff::numberOfItems):
        (WebCore::SVGPathSegListPropertyTearOff::initialize):
        (WebCore::SVGPathSegListPropertyTearOff::insertItemBefore):
        (WebCore::SVGPathSegListPropertyTearOff::replaceItem):
        (WebCore::SVGPathSegListPropertyTearOff::appendItem):
        (WebCore::SVGPathSegListPropertyTearOff::SVGPathSegListPropertyTearOff):
        (WebCore::SVGPathSegListPropertyTearOff::commitChange):
        (WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemWrapper):

2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
        https://bugs.webkit.org/show_bug.cgi?id=49580

        Add several new tests covering SVGPathSegList usage.

        * platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
        * platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
        * platform/mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-cloning-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
        * platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
        * platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
        * platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
        * platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
        * svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg: Added.
        * svg/dom/SVGPathSegList-appendItem-expected.txt: Added.
        * svg/dom/SVGPathSegList-appendItem.xhtml: Added.
        * svg/dom/SVGPathSegList-clear-and-initialize-expected.txt: Added.
        * svg/dom/SVGPathSegList-clear-and-initialize.xhtml: Added.
        * svg/dom/SVGPathSegList-cloning.html: Added.
        * svg/dom/SVGPathSegList-insertItemBefore-expected.txt: Added.
        * svg/dom/SVGPathSegList-insertItemBefore.xhtml: Added.
        * svg/dom/SVGPathSegList-removeItem-expected.txt: Added.
        * svg/dom/SVGPathSegList-removeItem.xhtml: Added.
        * svg/dom/SVGPathSegList-replaceItem-expected.txt: Added.
        * svg/dom/SVGPathSegList-replaceItem.xhtml: Added.
        * svg/dom/SVGPathSegList-segment-modification.svg: Added.
        * svg/dom/SVGPathSegList-xml-dom-synchronization-expected.txt: Added.
        * svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml: Added.
        * svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml: Added.
        * svg/dom/fuzz-path-parser-expected.txt:
        * svg/dom/path-parser-expected.txt:
        * svg/dom/script-tests/path-parser.js:
        ():
        * svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
        * svg/dom/svglist-exception-on-out-bounds-error.html:
        * svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 19 Nov 2010 12:42:26 +0000 (12:42 +0000)]
2010-11-19  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, GTK expectations update after r72347

        * platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
        * platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
        * platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-11-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 19 Nov 2010 12:41:37 +0000 (12:41 +0000)]
2010-11-19  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: one line follow up to r72376.

        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForResourceResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72379 268f45cc-cd09-0410-ab3c-d52691b4dbfc