WebKit-https.git
9 years agoUpdate expectations after gdi->skia switch.
dglazkov@chromium.org [Thu, 13 Oct 2011 22:01:15 +0000 (22:01 +0000)]
Update expectations after gdi->skia switch.

* platform/chromium-cg-mac-snowleopard/svg/batik/text/textFeatures-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png.
* platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png: Added.
* platform/chromium-mac-leopard/svg/css/text-shadow-multiple-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/css/text-shadow-multiple-expected.png.
* platform/chromium-mac/svg/batik/text/textFeatures-expected.png: Removed.
* platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Added.
* platform/chromium-win/svg/batik/text/textFeatures-expected.png:
* platform/chromium-win/svg/css/text-shadow-multiple-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSync requestAnimationFrame callback to CVDisplayLink on Mac
cmarrin@apple.com [Thu, 13 Oct 2011 21:59:25 +0000 (21:59 +0000)]
Sync requestAnimationFrame callback to CVDisplayLink on Mac
https://bugs.webkit.org/show_bug.cgi?id=68911

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Add REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for implementations
that use the DisplayRefreshMonitor logic.

* wtf/Platform.h:

Source/WebCore:

Test: fast/animation/request-animation-frame-iframe.html

Implement CVDisplayLink which checks to see if any scheduleAnimation requests
have come in. If so, remember the timestamp and do a callOnMainThread to fire
the callbacks. A DisplayRefreshMonitorManager is a singleton which has a list
of DisplayRefreshMonitors, one for each display. Each monitor has one or more
DisplayRefreshMonitorClients, which is a abstract virtual class implemented
by ScriptAnimationController. When an animation is scheduled, the
displayRefreshFired method is called on the client, which in turn calls the
requestAnimationFrame callbacks.

DisplayRefreshMonitor and therefore the CVDisplayLink it owns is discarded
when it no longer has any clients. This minimizes the number of concurrent
CVDisplayLink threads.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::windowScreenDidChange):
(WebCore::Document::webkitRequestAnimationFrame):
* dom/Document.h:
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
* dom/ScriptedAnimationController.h:
(WebCore::ScriptedAnimationController::displayRefreshFired):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::windowScreenDidChange):
* page/Page.h:
(WebCore::Page::displayID):
* platform/PlatformScreen.h:
* platform/graphics/DisplayRefreshMonitor.cpp: Added.
(WebCore::DisplayRefreshMonitorClient::DisplayRefreshMonitorClient):
(WebCore::DisplayRefreshMonitorClient::~DisplayRefreshMonitorClient):
(WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded):
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::refreshDisplayOnMainThread):
(WebCore::DisplayRefreshMonitorManager::sharedManager):
(WebCore::DisplayRefreshMonitorManager::findMonitor):
(WebCore::DisplayRefreshMonitorManager::registerClient):
(WebCore::DisplayRefreshMonitorManager::unregisterClient):
(WebCore::DisplayRefreshMonitorManager::scheduleAnimation):
(WebCore::DisplayRefreshMonitorManager::windowScreenDidChange):
* platform/graphics/DisplayRefreshMonitor.h: Added.
(WebCore::DisplayRefreshMonitorClient::scheduleAnimation):
(WebCore::DisplayRefreshMonitor::hasClients):
(WebCore::DisplayRefreshMonitor::addClient):
(WebCore::DisplayRefreshMonitor::removeClient):
(WebCore::DisplayRefreshMonitor::displayID):
(WebCore::DisplayRefreshMonitorManager::DisplayRefreshMonitorManager):
* platform/graphics/mac/DisplayRefreshMonitorMac.cpp: Added.
(WebCore::DisplayRefreshMonitor::displayLinkCallback):
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::scheduleAnimation):

Source/WebKit/mac:

Add windowDidChangeScreen function which listens for the window changing
screens and passes the new displayID along to WebCore::Page. It also sends
one on windowWillOrderOnScreen, so the Page has a fresh displayID after it's
created.

* WebView/WebView.mm:
(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
(-[WebView _windowDidChangeScreen:]):
(-[WebView _windowWillOrderOnScreen:]):

Source/WebKit2:

Add windowDidChangeScreen function which listens for the window changing
screens and passes the new displayID along to WebCore::Page. It also sends
one on windowDidBecomeKey, so the Page has a fresh displayID after it's
created. Event is generated in the UIProcess and then sent over to the
WebProcess, which actually sends it to WebCore::Page.

* UIProcess/API/mac/WKView.mm:
(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
(-[WKView _windowDidChangeScreen:]):
(-[WKView _windowDidBecomeKey:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::windowScreenDidChange):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowScreenDidChange):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

LayoutTests:

Test to make sure requestAnimationFrame events fire inside iframe

* fast/animation/request-animation-frame-iframe-expected.txt: Added.
* fast/animation/request-animation-frame-iframe.html: Added.
* fast/animation/script-tests/request-animation-frame-subframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Qt compile fix.
inferno@chromium.org [Thu, 13 Oct 2011 21:52:12 +0000 (21:52 +0000)]
Unreviewed. Qt compile fix.

* css/CSSFontFaceSource.cpp: include Document.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Register custom fonts at their creation time,
inferno@chromium.org [Thu, 13 Oct 2011 21:37:04 +0000 (21:37 +0000)]
Source/WebCore: Register custom fonts at their creation time,
rather than at retirement time.
https://bugs.webkit.org/show_bug.cgi?id=68929

Reviewed by Dan Bernstein.

Test: fast/text/custom-font-data-crash2.html

* css/CSSFontFace.cpp:
* css/CSSFontFace.h: remove function added in r94508,
which is no longer needed. We now register custom fonts
at creation time.
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::pruneTable): no longer need
to delete/retire font data here, it will be handled in ~Document.
(WebCore::CSSFontFaceSource::getFontData): register custom
font to document's m_customFonts.
* css/CSSFontSelector.cpp:
* css/CSSFontSelector.h: remove function added in r94508,
which is no longer needed. We now register custom fonts
at creation time.
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::pruneTable): no longer need
to delete/retire font data here, it will be handled in ~Document.
(WebCore::CSSSegmentedFontFace::getFontData): register custom
font to document's m_customFonts.
* dom/Document.cpp: Change function names to registerCustomFont
, deleteCustomFonts and local to m_customFont.
(WebCore::Document::~Document):
(WebCore::Document::recalcStyle): yanking out the comment. We
no longer keep retired custom fonts. We clear all custom fonts
on Document destruction.
(WebCore::Document::registerCustomFont):
(WebCore::Document::deleteCustomFonts):
* dom/Document.h:

LayoutTests: Register custom fonts at their creation time,
rather than at retirement time.
https://bugs.webkit.org/show_bug.cgi?id=68929

Reviewed by Dan Bernstein.

* fast/text/custom-font-data-crash2-expected.txt: Added.
* fast/text/custom-font-data-crash2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd results to keep the bots quiet.
simon.fraser@apple.com [Thu, 13 Oct 2011 21:28:13 +0000 (21:28 +0000)]
Add results to keep the bots quiet.

* fast/images/color-jpeg-with-color-profile-expected.png: Added.
* fast/images/color-jpeg-with-color-profile-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTweak flakiness expectation.
dglazkov@chromium.org [Thu, 13 Oct 2011 21:25:29 +0000 (21:25 +0000)]
Tweak flakiness expectation.

* platform/chromium/test_expectations.txt: Tweaked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] WebErrorsQt.cpp duplicates code from WKError.h and WebError.h
jesus@webkit.org [Thu, 13 Oct 2011 21:20:59 +0000 (21:20 +0000)]
[Qt][WK2] WebErrorsQt.cpp duplicates code from WKError.h and WebError.h
https://bugs.webkit.org/show_bug.cgi?id=70053

Reviewed by Kenneth Rohde Christiansen.

Now we will be aligned with WKError.h and WebError.h by using the shared
and pre-defined enum for error codes and WebError::webkitErrorDomain().

* WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::pluginWillHandleLoadError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] WebViews are emitting loadFailed for "private" error codes
jesus@webkit.org [Thu, 13 Oct 2011 21:16:27 +0000 (21:16 +0000)]
[Qt][WK2] WebViews are emitting loadFailed for "private" error codes
https://bugs.webkit.org/show_bug.cgi?id=70047

Reviewed by Kenneth Rohde Christiansen.

Both QDesktopWebView and QTouchWebView are emitting loadFailed for private errors
like the ones defined in Source/WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp.

We now filter these by not emitting this signal for FrameLoadInterruptedByPolicyChange,
PlugInWillHandleLoad and Cancellation, following previous decisions from WebKit 1.

* UIProcess/qt/ClientImpl.cpp:
(dispatchLoadFailed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd GPU crashes that cropped up.
dglazkov@chromium.org [Thu, 13 Oct 2011 21:11:17 +0000 (21:11 +0000)]
Add GPU crashes that cropped up.

* platform/chromium/test_expectations.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove expectations of failure after r97149.
dglazkov@chromium.org [Thu, 13 Oct 2011 21:05:33 +0000 (21:05 +0000)]
Remove expectations of failure after r97149.

* platform/chromium/test_expectations.txt: Yipee.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in DeleteSelectionCommand::handleGeneralDelete
rniwa@webkit.org [Thu, 13 Oct 2011 20:58:42 +0000 (20:58 +0000)]
Crash in DeleteSelectionCommand::handleGeneralDelete
https://bugs.webkit.org/show_bug.cgi?id=70045

Reviewed by Darin Adler.

Exit early when m_upstreamStart is null.

No new tests because we don't have a reduction.

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update expectations after r97378.
dglazkov@chromium.org [Thu, 13 Oct 2011 20:54:53 +0000 (20:54 +0000)]
[Chromium] Update expectations after r97378.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoterminateSpeculativeExecution for fillSpeculateDouble with DataFormatCell
barraclough@apple.com [Thu, 13 Oct 2011 20:51:20 +0000 (20:51 +0000)]
terminateSpeculativeExecution for fillSpeculateDouble with DataFormatCell

Rubber stamped by Filip Pizlo

This is breaking fast/canvas/canvas-composite-alpha.html on 32_64 DFG JIT.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update expectations after r97369.
dglazkov@chromium.org [Thu, 13 Oct 2011 20:48:00 +0000 (20:48 +0000)]
[Chromium] Update expectations after r97369.

* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
* platform/chromium-win/fast/repaint/region-painting-via-layout-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
* platform/chromium/fast/repaint/region-painting-via-layout-expected.png: Added.
* platform/chromium/test_expectations.txt: Removed failure expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=70049
hyatt@apple.com [Thu, 13 Oct 2011 20:37:28 +0000 (20:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70049

[CSS Regions] Add a test of a float being pushed down because it can't fit
next to another float and make sure it re-evaluates its position when it changes
regions as a result of the push.

Reviewed by Sam Weinig.

Source/WebCore:

Added new test in fast/regions.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat):

LayoutTests:

* fast/regions/float-pushed-width-change.html: Added.
* platform/mac/fast/regions/float-pushed-width-change-expected.png: Added.
* platform/mac/fast/regions/float-pushed-width-change-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPlatform-specific results for r97378
robert@webkit.org [Thu, 13 Oct 2011 20:22:35 +0000 (20:22 +0000)]
Platform-specific results for r97378

Unreviewed, new platform-specific results.

* platform/gtk/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
* platform/gtk/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
* platform/gtk/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
* platform/mac/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
* platform/mac/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
* platform/mac/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
* platform/qt/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
* platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
* platform/qt/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline for webkit bug 69503
commit-queue@webkit.org [Thu, 13 Oct 2011 20:18:19 +0000 (20:18 +0000)]
Rebaseline for webkit bug 69503
https://bugs.webkit.org/show_bug.cgi?id=69818

Patch by Ben Wells <benwells@chromium.org> on 2011-10-13
Reviewed by Tony Chang.

* platform/chromium-cg-mac-leopard/fast/css/text-transform-select-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/css/text-transform-select-expected.png: Added.
* platform/chromium-linux/fast/css/text-transform-select-expected.txt: Added.
* platform/chromium-mac-leopard/fast/css/text-transform-select-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/text-transform-select-expected.png: Added.
* platform/chromium-win/fast/css/text-transform-select-expected.png: Added.
* platform/chromium-win/fast/css/text-transform-select-expected.txt: Added.
* platform/chromium/fast/css/text-transform-select-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove XSTL to script-src in Content-Security-Policy
abarth@webkit.org [Thu, 13 Oct 2011 20:03:36 +0000 (20:03 +0000)]
Move XSTL to script-src in Content-Security-Policy
https://bugs.webkit.org/show_bug.cgi?id=63637

Reviewed by Eric Seidel.

Source/WebCore:

The spec was unclear about how to treat XSLT.  My reading was that they
should fall under style-src, but further discussion on the mailing list
settled on using script-src because an XSLT can inject arbitrary DOM
and script into a page, which is more risky than including style.

Tests: http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php
       http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2.php

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):

LayoutTests:

* http/tests/security/contentSecurityPolicy/xsl-allowed.php:
* http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/xsl-blocked.php:
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php: Added.
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QtWebKit build error for Mac 32bit
commit-queue@webkit.org [Thu, 13 Oct 2011 19:47:27 +0000 (19:47 +0000)]
[Qt] QtWebKit build error for Mac 32bit
https://bugs.webkit.org/show_bug.cgi?id=69914

In WebCore.pro and QtWebKit.pro we define NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES
when compiling with ENABLE_VIDEO and with WTF_USE_QTKIT.
But this is meant to be defined in NSGeometry.h under certain preconditions.
Without setting NS_BUILD_32_LIKE_64 none of these preconditions is
met and therefore NSGeometry.h will create several conflicting type definitions.

With this patch we create consistent definitions again.
Due to the order of include files we cannot remove
NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES from WebCore.pro.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-13
Reviewed by Andreas Kling.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert border radius clips (r95239) for Chromium due to performance issues. Update...
commit-queue@webkit.org [Thu, 13 Oct 2011 19:37:57 +0000 (19:37 +0000)]
Revert border radius clips (r95239) for Chromium due to performance issues. Update test expectations to skip border radius clip layout tests.
https://bugs.webkit.org/show_bug.cgi?id=69844

Patch by Tom Hudson <tomhudson@google.com> on 2011-10-13
Reviewed by Simon Fraser.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect): Only process border radius clips #if !PLATFORM(CHROMIUM)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement TextChecker for WebKit2 GTK+
commit-queue@webkit.org [Thu, 13 Oct 2011 19:36:34 +0000 (19:36 +0000)]
Implement TextChecker for WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=68548

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-10-13
Reviewed by Anders Carlsson.

Added implementation for all functions in TextCheckerGtk.cpp removing earlier stubbed implementations.
Moved couple of API earlier specific to win port to common section and added stubbed implementation
of the same for remaining ports of Qt, Efl and Mac.

* GNUmakefile.am: Added TextChecker implementation files.
* UIProcess/TextChecker.h: Moved spellCheckingEnabled and grammarCheckingEnabled API outside of win port.
* UIProcess/efl/TextCheckerEfl.cpp: Stubbed implementation of API which was moved outside win port.
* UIProcess/gtk/TextCheckerGtk.cpp: Implementation of all TextChecker API.
(WebKit::TextChecker::state):
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::uniqueSpellDocumentTag):
(WebKit::TextChecker::closeSpellDocumentWithTag):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::learnWord):
(WebKit::TextChecker::ignoreWord):
* UIProcess/mac/TextCheckerMac.mm: Implementation of API which was moved outside win port.
* UIProcess/qt/TextCheckerQt.cpp: Stubbed implementation of API which was moved outside win port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebase some editing/spelling results for Lion.
simon.fraser@apple.com [Thu, 13 Oct 2011 19:30:41 +0000 (19:30 +0000)]
Rebase some editing/spelling results for Lion.

* platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
* platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
* platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
* platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix layout test result on Lion to account for content-order removal patch.
hyatt@apple.com [Thu, 13 Oct 2011 19:29:28 +0000 (19:29 +0000)]
Fix layout test result on Lion to account for content-order removal patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd regression test: canvas.toDataURL("image/jpeg") should not crash
noel.gordon@gmail.com [Thu, 13 Oct 2011 19:24:53 +0000 (19:24 +0000)]
Add regression test: canvas.toDataURL("image/jpeg") should not crash
https://bugs.webkit.org/show_bug.cgi?id=69991

Reviewed by Kenneth Russell.

* fast/canvas/canvas-toDataURL-jpeg-crash-expected.txt: Added.
* fast/canvas/canvas-toDataURL-jpeg-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDe-virtualized JSCell::toNumber
mhahnenberg@apple.com [Thu, 13 Oct 2011 19:24:53 +0000 (19:24 +0000)]
De-virtualized JSCell::toNumber
https://bugs.webkit.org/show_bug.cgi?id=69858

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Removed JSCallbackObject::toNumber because its no longer necessary since
JSObject::toNumber now suffices since we implicitly add valueOf to an object's
prototype whenever a convertToType callback is provided.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

De-virtualized JSCell::toNumber, JSObject::toNumber, and JSString::toNumber.
* runtime/JSCell.cpp:
(JSC::JSCell::toNumber):
* runtime/JSCell.h:
* runtime/JSObject.h:
* runtime/JSString.h:

Removed JSNotAnObject::toNumber because its result doesn't matter and it implements
defaultValue, therefore JSObject::toNumber can cover its case.
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:

Source/JavaScriptGlue:

Removed UserObjectImp::toNumber because it's no longer necessary since
JSObject::toNumber can cover this case.
* UserObjectImp.cpp:
* UserObjectImp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDeprecate event.layerX and event.layerY in WebKit
jchaffraix@webkit.org [Thu, 13 Oct 2011 19:07:00 +0000 (19:07 +0000)]
Deprecate event.layerX and event.layerY in WebKit
https://bugs.webkit.org/show_bug.cgi?id=69951

Reviewed by Darin Adler.

Source/WebCore:

layerX and layerY were concepts of the old Netscape code that stayed
in WebKit for a long time without changes. Now the code is completely
wrong and Mozilla has expressed some interest in removing it from their
API too.

This is a first step in the removal as layerX and layerY are exposed
in some APIs. Chromium and Win are fine with removing the property
directly, but ObjC needs to deprecate them first.

* bindings/objc/PublicDOMInterfaces.h: Mark the API as deprecated.

* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::layerX):
(WebCore::MouseRelatedEvent::layerY):
* dom/UIEvent.cpp:
(WebCore::UIEvent::layerX):
(WebCore::UIEvent::layerY):
Added a call to warnDeprecatedLayerXYUsage in the previous functions.

(WebCore::UIEvent::warnDeprecatedLayerXYUsage): Print a warning in the
console about the removal of event.layerX and event.layerY in the near future.

* dom/UIEvent.h: Added warnDeprecatedLayerXYUsage.

LayoutTests:

* fast/dom/Window/window-xy-properties-expected.txt:
* fast/events/init-events-expected.txt:
* fast/events/mouse-relative-position-expected.txt:
* fast/events/mouseclick-target-and-positioning-expected.txt:
* fast/events/simulated-click-coords-expected.txt:
* jquery/events-expected.txt:
Updated those tests with the console messages to keep our existing
coverage until we remove the 2 properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Allow building without speech input enabled.
jknotten@chromium.org [Thu, 13 Oct 2011 19:06:43 +0000 (19:06 +0000)]
[Chromium] Allow building without speech input enabled.
https://bugs.webkit.org/show_bug.cgi?id=69867

Reviewed by Darin Fisher.

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:
* src/WebSpeechInputControllerMockImpl.cpp:
(WebKit::WebSpeechInputControllerMock::create):
* src/WebSpeechInputControllerMockImpl.h:
* src/WebSpeechInputResult.cpp:

Tools:

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::addMockSpeechInputResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS 2.1 failure: inline-replaced-height-008.htm
robert@webkit.org [Thu, 13 Oct 2011 19:04:43 +0000 (19:04 +0000)]
CSS 2.1 failure: inline-replaced-height-008.htm
https://bugs.webkit.org/show_bug.cgi?id=69273

Reviewed by Simon Fraser.

Source/WebCore:

Test: css2.1/20110323/inline-block-replaced-height-008.html

Per http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-height,  if 'height' has computed value of
'auto', the replaced element has an intrinsic ratio and its used width is known or resolved, then
the used value of 'height' is determined by the equation (used width) / (intrinsic ratio).

* rendering/RenderImage.cpp:
(WebCore::RenderImage::computeReplacedLogicalHeight):
* rendering/RenderReplaced.h:

LayoutTests:

* css2.1/20110323/floating-replaced-height-008.htm: Added.
* css2.1/20110323/inline-block-replaced-height-008.htm: Added.
* css2.1/20110323/inline-replaced-height-008.htm: Added.
* css2.1/20110323/support/60x60-green.png: Added
* platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip MutationObserver tests on wincairo.
adamk@chromium.org [Thu, 13 Oct 2011 19:02:03 +0000 (19:02 +0000)]
Unreviewed, skip MutationObserver tests on wincairo.
These tests are not yet enabled on any platform.

* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd stallFor URL parameter for http/tests/media/video-play-stall.html test.
scherkus@chromium.org [Thu, 13 Oct 2011 18:51:16 +0000 (18:51 +0000)]
Add stallFor URL parameter for http/tests/media/video-play-stall.html test.
https://bugs.webkit.org/show_bug.cgi?id=69974

Without the call to sleep(), the test server will issue a TCP
connection close earlier than the 3 second wait time required to issue
a stalled event.

Reviewed by Eric Carlson.

* http/tests/media/video-play-stall.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Implement decidePolicyForResponse in our PolicyClient
commit-queue@webkit.org [Thu, 13 Oct 2011 18:44:02 +0000 (18:44 +0000)]
[Qt][WK2] Implement decidePolicyForResponse in our PolicyClient
https://bugs.webkit.org/show_bug.cgi?id=69832

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-10-13
Reviewed by Kenneth Rohde Christiansen.

We implement decidePolicyForResponse in our PolicyClient in order to
decide whether a given ResourceResponse should be downloaded or loaded.

* UIProcess/qt/ClientImpl.cpp:
(qt_wk_decidePolicyForResponse):
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac test expectation update for the bug 69999.
rniwa@webkit.org [Thu, 13 Oct 2011 18:31:26 +0000 (18:31 +0000)]
Mac test expectation update for the bug 69999.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update expectations while waiting on results from bots.
dglazkov@chromium.org [Thu, 13 Oct 2011 18:28:32 +0000 (18:28 +0000)]
[Chromium] Update expectations while waiting on results from bots.

* platform/chromium/test_expectations.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r97362.
commit-queue@webkit.org [Thu, 13 Oct 2011 18:02:10 +0000 (18:02 +0000)]
Unreviewed, rolling out r97362.
http://trac.webkit.org/changeset/97362
https://bugs.webkit.org/show_bug.cgi?id=70039

Relies on V8 APIs that have been reverted upstream. (Requested
by dglazkov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-13

Source/WebCore:

* English.lproj/localizedStrings.js:
* bindings/js/ScriptProfiler.cpp:
* bindings/js/ScriptProfiler.h:
* bindings/v8/ScriptProfiler.cpp:
* bindings/v8/ScriptProfiler.h:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
* inspector/InspectorProfilerAgent.h:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._showStringContentPopover):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.updateStaticData):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
* inspector/front-end/HeapSnapshotProxy.js:
* inspector/front-end/RemoteObject.js:
* inspector/front-end/heapProfiler.css:

LayoutTests:

* inspector/profiler/heap-snapshot-expected.txt:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):
* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse realloc() to expand/shrink StringBuilder buffer
commit-queue@webkit.org [Thu, 13 Oct 2011 17:00:59 +0000 (17:00 +0000)]
Use realloc() to expand/shrink StringBuilder buffer
https://bugs.webkit.org/show_bug.cgi?id=69913

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-10-13
Reviewed by Darin Adler.

* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::reallocateBuffer):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::shrinkToFit):
* wtf/text/StringBuilder.h:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::reallocate): Added to allow StringBuilder to reallocate the buffer.
* wtf/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=69932
hyatt@apple.com [Thu, 13 Oct 2011 16:55:13 +0000 (16:55 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=69932

Layout repainting messed up for objects in regions. There were two bugs here.
The first is that the regionOverflowRect needs to at least be the size of the
region's rect. When you're in the middle of layout, you haven't computed the
overflow rect for the flow thread yet (the flow thread's height could even be 0),
and so you just need to enforce a minimum size. Also removed the region-overflow:break
clipping behavior, since it was established that was wrong.

The second bug is that when you tell a region to repaint, you need to disable layout state,
since applying layout deltas from the flow thread makes no sense. The region is in a totally
different place in the render tree, so the current flow thread layout state can't be used
to determine your coordinate offset.

Reviewed by Dan Bernstein.

Added fast/repaint test.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOverflowRect):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=69932

Layout repainting messed up for objects in regions. Add a repaint test to
illustrate the issue.

Reviewed by Dan Bernstein.

* fast/repaint/region-painting-via-layout.html: Added.
* platform/mac/fast/regions/region-overflow-break-expected.png:
* platform/mac/fast/repaint/region-painting-via-layout-expected.png: Added.
* platform/mac/fast/repaint/region-painting-via-layout-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFEComponentTransfer element doesn't support dynamic invalidation
reni@webkit.org [Thu, 13 Oct 2011 16:33:19 +0000 (16:33 +0000)]
FEComponentTransfer element doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=69747

Source/WebCore:

The dynamic changes are captured by the svgAttributeChange() function, and
invalidate the filter primitive if necessary.
invalidateFilterPrimitiveParent() is a new free function in
SVGFilterPrimitiveStanardAttributes what makes the invalidation possible
by objects not inherited from SVGFilterPrimitiveStanardAttributes too.
This solution was used in SVGFEMergeNodeElement::svgAttributeChanged()
previously and now it can use this new function too.

Reviewed by Nikolas Zimmermann.

Tests: svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop.html

* svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::svgAttributeChanged):
* svg/SVGComponentTransferFunctionElement.h:
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::build):
* svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::invalidateFilterPrimitiveParent):
* svg/SVGFilterPrimitiveStandardAttributes.h:

LayoutTests:

Adding new tests for feComponentTransfer dynamic changes.

Reviewed by Nikolas Zimmermann.

* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-amplitude-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-exponent-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-intercept-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-offset-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-slope-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-tableValues-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-type-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-amplitude-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-exponent-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-intercept-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-offset-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-slope-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-tableValues-prop.js: Added.
(SVGNumberListToString):
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-type-prop.js: Added.
(executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add a selectionBounds() method to WebWidget.
commit-queue@webkit.org [Thu, 13 Oct 2011 16:12:48 +0000 (16:12 +0000)]
[chromium] Add a selectionBounds() method to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=69028

Patch by Peng Huang <shawn.p.huang@gmail.com> on 2011-10-13
Reviewed by Darin Fisher.

* public/WebWidget.h:
(WebKit::WebWidget::selectionBounds):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::selectionRange):
(WebKit::WebViewImpl::selectionBounds):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r95381): Standalone video can be focused and draws a focus ring.
commit-queue@webkit.org [Thu, 13 Oct 2011 15:57:09 +0000 (15:57 +0000)]
REGRESSION (r95381): Standalone video can be focused and draws a focus ring.
https://bugs.webkit.org/show_bug.cgi?id=69097

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-10-13
Reviewed by Eric Carlson.

Source/WebCore:

We don't want to focus a media element in a standalone document.

Test: fast/events/media-focus-in-standalone-media-document.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsFocus): return false if media element is in a standalone media document.

LayoutTests:

New test to check that media element in a standalone document are not focussed.

* fast/events/media-focus-in-standalone-media-document-expected.txt: Added.
* fast/events/media-focus-in-standalone-media-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add WebKitTestServer class to WebKit2 GTK+ unit tests library
carlosgc@webkit.org [Thu, 13 Oct 2011 15:28:38 +0000 (15:28 +0000)]
[GTK] Add WebKitTestServer class to WebKit2 GTK+ unit tests library
https://bugs.webkit.org/show_bug.cgi?id=70010

Reviewed by Martin Robinson.

With this class tests using a soup server only need to implement
the soup server callback.

* UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp: Use WebKitTestServer.
(testLoadingStatus):
(testLoadingError):
(testLoadAlternateContent):
(testWebViewReload):
(testLoadProgress):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/tests/WebKitTestServer.cpp: Added.
(WebKitTestServer::WebKitTestServer):
(WebKitTestServer::~WebKitTestServer):
(WebKitTestServer::run): Run the soup server and adds the given
soup server callback to handle requests.
(WebKitTestServer::getURIForPath): Returns the server absolute URI
for the given relative path.
* UIProcess/API/gtk/tests/WebKitTestServer.h: Added.
(WebKitTestServer::baseURI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; revert some changes introduced in r97329 which are
leandro@webkit.org [Thu, 13 Oct 2011 14:31:38 +0000 (14:31 +0000)]
Unreviewed; revert some changes introduced in r97329 which are
unrelated to the patch and reverted other patches themselves.

* ewk/ewk_frame.cpp:
(_ewk_frame_smart_del): Remove warning again.
(ewk_frame_contents_size_get): Check for Frame and FrameView again.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new): Revert back default font size change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WebKit2][gtk] Fix warnings while generating WebKit2-GTK+ documentation.
commit-queue@webkit.org [Thu, 13 Oct 2011 13:58:48 +0000 (13:58 +0000)]
[WebKit2][gtk] Fix warnings while generating WebKit2-GTK+ documentation.
https://bugs.webkit.org/show_bug.cgi?id=69928

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-13
Reviewed by Philippe Normand.

Patch fixes the warnings reported by gtk-doc while generating
WebKit2-GTK+ documentation.

* UIProcess/API/gtk/WebKitWebContext.h: Correct the documentation comment.
* UIProcess/API/gtk/WebKitWebView.cpp: Parameter name correction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rebaselined GTK SVG test result.
sergio@webkit.org [Thu, 13 Oct 2011 11:13:32 +0000 (11:13 +0000)]
Unreviewed, rebaselined GTK SVG test result.

* platform/gtk/svg/hixie/cascade/002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Chromium] Add an ability to look up and explore an object from a...
mnaganov@chromium.org [Thu, 13 Oct 2011 11:08:49 +0000 (11:08 +0000)]
Web Inspector: [Chromium] Add an ability to look up and explore an object from a heap profile.
https://bugs.webkit.org/show_bug.cgi?id=61179

This is exteremely helpful when dealing with DOM wrappers, as
their properties are mostly implemented with getters and thus not
stored in heap snapshots.

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
* bindings/js/ScriptProfiler.h:
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
* bindings/v8/ScriptProfiler.h:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
* inspector/InspectorProfilerAgent.h:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._showObjectPopover):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get canBeQueried):
(WebInspector.HeapSnapshotNode.prototype.get flags):
(WebInspector.HeapSnapshotNode.prototype.get isDOMWindow):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype._flagsOfNode):
(WebInspector.HeapSnapshot.prototype._calculateFlags):
(WebInspector.HeapSnapshot.prototype.updateStaticData):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.get nodeFlags):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.fromError):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view tr:not(.selected) td.object-column span.highlight):

* inspector/profiler/heap-snapshot-expected.txt:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):
* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fix test expectations.
tkent@chromium.org [Thu, 13 Oct 2011 10:59:31 +0000 (10:59 +0000)]
[Chromium] Fix test expectations.

* platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause.png.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoscript-src * should allow all URLs
abarth@webkit.org [Thu, 13 Oct 2011 10:16:40 +0000 (10:16 +0000)]
script-src * should allow all URLs
https://bugs.webkit.org/show_bug.cgi?id=70011

Reviewed by Eric Seidel.

Source/WebCore:

This patch gets us slightly ahead of the spec.  Technically, script-src
means "any host" and inherits the current scheme.  However, that's not
what developers expect and it's even contradicted by examples in the
spec itself.  After this patch, * matches all URLs.

Test: http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSourceList::CSPSourceList):
(WebCore::CSPSourceList::matches):
(WebCore::CSPSourceList::parseSource):
(WebCore::CSPSourceList::addSourceStar):

LayoutTests:

Test that using * in script-src matches URLs with other schemes.

* http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update test expectation.
tkent@chromium.org [Thu, 13 Oct 2011 10:12:34 +0000 (10:12 +0000)]
[Chromium] Update test expectation.

* fast/borders/border-radius-different-width-001-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-different-width-001-expected.txt.
* fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Renamed from LayoutTests/platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt.
* platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-complex-inner-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-different-width-001-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/borders/mixed-border-styles-radius-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/border-radius-different-width-001-expected.png: Removed.
* platform/chromium-cg-mac/fast/borders/mixed-border-styles-radius-expected.png: Removed.
* platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/border-radius-complex-inner-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/border-radius-different-width-001-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-radius-expected.png: Added.
* platform/chromium-mac/fast/borders/border-radius-different-width-001-expected.png: Removed.
* platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png: Removed.
* platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.png: Added.
* platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/border-conflict-style-079-expected.txt.
* platform/chromium-win/css2.1/20110323/border-conflict-style-088-expected.png: Added.
* platform/chromium-win/css2.1/20110323/border-conflict-style-088-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/border-conflict-style-088-expected.txt.
* platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png: Added.
* platform/chromium-win/fast/borders/border-radius-different-width-001-expected.png:
* platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-win/fast/css/outline-narrowLine-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/css/outline-narrowLine-expected.png.
* platform/chromium-win/fast/css/outline-narrowLine-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/css/outline-narrowLine-expected.txt.
* platform/chromium-win/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
* platform/chromium-win/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt.
* platform/chromium/fast/css/outline-narrowLine-expected.png: Added.
* platform/chromium/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/borders/border-radius-different-width-001-expected.txt: Removed.
* platform/mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Removed.
* platform/qt/fast/borders/border-radius-different-width-001-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update test expectation.
tkent@chromium.org [Thu, 13 Oct 2011 09:50:45 +0000 (09:50 +0000)]
[Chromium] Update test expectation.

* platform/chromium-gpu-linux/media/video-playing-and-pause.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate expectation of xss-DENIED-contentWindow-eval.html for r97353
tkent@chromium.org [Thu, 13 Oct 2011 09:30:37 +0000 (09:30 +0000)]
Update expectation of xss-DENIED-contentWindow-eval.html for r97353

* http/tests/security/xss-DENIED-contentWindow-eval-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement an OverflowEvent constructor for JSC
haraken@chromium.org [Thu, 13 Oct 2011 09:13:47 +0000 (09:13 +0000)]
Implement an OverflowEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=69907

Reviewed by Adam Barth.

Source/WebCore:

There is no spec for the OverflowEvent constructor
since it is WebKit-specific. However, judging from the current
IDL of initOverflowEvent(), the constructor IDL should be as follows.

[Constructor(DOMString type, optional OverflowEventInit eventInitDict)]
interface OverflowEvent : Event {
    ...;
}

dictionary OverflowEventInit : EventInit {
    unsigned short orient;
    boolean horizontalOverflow;
    boolean verticalOverflow;
}

Note: In initOverflowEvent(), we cannot specify |bubbles| and |cancelable|.
I do not know why, but we can find a comment in fast/events/script-tests/init-events.js
that says "initOverflowEvent has an interface that has a design that's
inconsistent with the init functions from other events".
On the other hand, the above constructor enables to specify |bubbles| and |cancelable|,
which is consistent with other constructors.

Test: fast/events/constructors/overflow-event-constructor.html

* bindings/generic/EventConstructors.h: Added a definition for the OverflowEvent constructor.
* bindings/js/JSEventConstructors.cpp: Added #includes for OverflowEvent.
* dom/OverflowEvent.cpp:
(WebCore::OverflowEventInit::OverflowEventInit):
(WebCore::OverflowEvent::OverflowEvent):
(WebCore::OverflowEvent::initOverflowEvent):
* dom/OverflowEvent.h: Added a definition for OverflowEventInit.
(WebCore::OverflowEvent::create):
(WebCore::OverflowEvent::orient):
(WebCore::OverflowEvent::horizontalOverflow):
(WebCore::OverflowEvent::verticalOverflow):
* dom/OverflowEvent.idl: Makes OverflowEvent constructible.

LayoutTests:

overflow-event-constructor.html checks the behavior of the OverflowEvent constructor.

* fast/dom/constructed-objects-prototypes-expected.txt: Added inner.OverflowEvent().
* fast/dom/dom-constructors-expected.txt: Updated the test result.
* fast/dom/dom-constructors.html: Removed OverflowEvent from test cases, since now OverflowEvent has a constructor.
* fast/events/constructors/overflow-event-constructor-expected.txt: Added.
* fast/events/constructors/overflow-event-constructor.html: Added.
* platform/chromium/test_expectations.txt: Skipped overflow-event-constructor.html, since V8 does not yet have the OverflowEvent constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleanup of HTMLSelectElement
tkent@chromium.org [Thu, 13 Oct 2011 09:08:18 +0000 (09:08 +0000)]
Cleanup of HTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=69908

Reviewed by Darin Adler.

Source/WebCore:

- Change the m_listItems type: Vector<Element*> -> Vector<HTMLElement*>
- Rename a member: m_recalcListItems -> m_shouldRecalcListItems
- Fold checkListItems() into listItems()
- Style fixes

No new tests, just a cleanup.

* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::addChildren):
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::addChildren):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(optionFromSelection):
(webkit_accessible_selection_get_selection_count):
* dom/OptionElement.cpp:
(WebCore::OptionElement::optionIndex):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::HTMLSelectElement):
(WebCore::HTMLSelectElement::add):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::parseMappedAttribute):
(WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
(WebCore::HTMLSelectElement::setOption):
(WebCore::HTMLSelectElement::setLength):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::firstSelectableListIndex):
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway):
(WebCore::HTMLSelectElement::selectAll):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::listItems):
(WebCore::HTMLSelectElement::setRecalcListItems):
(WebCore::HTMLSelectElement::recalcListItemsInternal):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::setSelectedIndexInternal):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::dispatchFocusEvent):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState): Use StringBuilder.
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
Optimize the code by iterating in the reverse order.
(WebCore::HTMLSelectElement::typeAheadFind):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):
(WebCore::toSelectElement):
* html/HTMLSelectElement.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
(WebCore::RenderListBox::nodeAtPoint):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemAccessibilityText):
(WebCore::RenderMenuList::itemToolTip):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::itemBackgroundColor):
(WebCore::RenderMenuList::itemIsSeparator):
(WebCore::RenderMenuList::itemIsLabel):
(WebCore::RenderMenuList::itemIsSelected):

Source/WebKit/chromium:

Change the HTMLSelectElement::listItems() return type:
  Vector<Element*> -> Vector<HTMLElement*>

* src/WebSearchableFormData.cpp:
(HTMLNames::IsSelectInDefaultState):
* src/WebSelectElement.cpp:
(WebKit::WebSelectElement::listItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDOMWindow subobjects can be re-created after navigation
abarth@webkit.org [Thu, 13 Oct 2011 08:53:50 +0000 (08:53 +0000)]
DOMWindow subobjects can be re-created after navigation
https://bugs.webkit.org/show_bug.cgi?id=68849

Reviewed by Sam Weinig.

Source/WebCore:

Test: http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html

* page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
    - Add ASSERTs to show that we're not recreating these objects.
    - Add a call to clear() as defense in depth in case we have any of
      these objects hanging around.
(WebCore::DOMWindow::clear):
    - Clear out a couple of objects that weren't getting cleared.
      These are actually not likely to cause problems, but clearing
      them out is the safe thing to do.
(WebCore::DOMWindow::isActive):
    - Add a concept of whether the DOMWindow is "active" in its frame.
      We had this concept in a couple places already, but centralizing
      it into a helper function make it easier to use and talk about.
(WebCore::DOMWindow::orientation):
    - Whitespace nit.
(WebCore::DOMWindow::screen):
(WebCore::DOMWindow::history):
(WebCore::DOMWindow::crypto):
(WebCore::DOMWindow::locationbar):
(WebCore::DOMWindow::menubar):
(WebCore::DOMWindow::personalbar):
(WebCore::DOMWindow::scrollbars):
(WebCore::DOMWindow::statusbar):
(WebCore::DOMWindow::toolbar):
(WebCore::DOMWindow::console):
(WebCore::DOMWindow::applicationCache):
(WebCore::DOMWindow::navigator):
(WebCore::DOMWindow::performance):
(WebCore::DOMWindow::location):
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
(WebCore::DOMWindow::webkitNotifications):
(WebCore::DOMWindow::webkitIndexedDB):
(WebCore::DOMWindow::getSelection):
(WebCore::DOMWindow::styleMedia):
(WebCore::DOMWindow::webkitURL):
(WebCore::DOMWindow::webkitStorageInfo):
    - Avoid creating these objects when we're not active.  That can
      only lead to sadness.
(WebCore::DOMWindow::webkitRequestFileSystem):
(WebCore::DOMWindow::webkitResolveLocalFileSystemURL):
(WebCore::DOMWindow::openDatabase):
(WebCore::DOMWindow::postMessage):
    - While not techincally creating subobjects, these functions also
      seem unwise when the DOMWindow is inactive.
(WebCore::DOMWindow::find):
(WebCore::DOMWindow::length):
(WebCore::DOMWindow::getMatchedCSSRules):
    - These functions operate on the active Document.  When we're not
      active, that's not us!
(WebCore::DOMWindow::document):
    - Update to use the new concept of being active rather than having
      this function roll its own implementation.
(WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
(WebCore::DOMWindow::webkitConvertPointFromPageToNode):
(WebCore::DOMWindow::scrollBy):
(WebCore::DOMWindow::scrollTo):
    - These functions also look unwise to run when inactive because
      they're reading information from the active document.
    - I added a RefPtr for node because the call to
      updateLayoutIgnorePendingStylesheets() seems likely to be able to
      run script somehow.
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::dispatchLoadEvent):
(WebCore::DOMWindow::dispatchEvent):
    - I don't think these functions worked when inactive anyway, but
      explicitly blocking them seems wise.
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::isInsecureScriptAccess):
(WebCore::DOMWindow::open):
(WebCore::DOMWindow::showModalDialog):
    - These already have checks for being active, but it can't hurt to
      be explicit at the top of the function.
* page/DOMWindow.h:

LayoutTests:

* http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow-expected.txt: Added.
* http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fix errors in test_expectations.txt.
tkent@chromium.org [Thu, 13 Oct 2011 07:50:55 +0000 (07:50 +0000)]
[Chromium] Fix errors in test_expectations.txt.

* platform/chromium/test_expectations.txt:
Remove duplicated entries for MAC DEBUG.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r89915): <input type=email multiple> don't show the default value
tkent@chromium.org [Thu, 13 Oct 2011 07:34:55 +0000 (07:34 +0000)]
REGRESSION(r89915): <input type=email multiple> don't show the default value
https://bugs.webkit.org/show_bug.cgi?id=69895

Reviewed by Hajime Morita.

Source/WebCore:

m_valueIfDirty became unexpectedly empty because
EmailInputType::sanitizeValue() returned an empty string for a
null input string.

To solve this issue, HTMLInputElement::sanitizeValue() checks
nullness, and remove the null check of sanitizeValue() of
InputType subclasses.
Also, we make InputType::sanitizeValue() const.

* html/ColorInputType.cpp:
(WebCore::ColorInputType::sanitizeValue):
- Make this const.
- Remove null check.
* html/ColorInputType.h: Make sanitizeValue() const.
* html/EmailInputType.cpp:
(WebCore::EmailInputType::sanitizeValue): Make this const.
* html/EmailInputType.h: Make sanitizeValue() const.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::sanitizeValue):
(WebCore::HTMLInputElement::updateValueIfNeeded):
* html/InputType.cpp:
(WebCore::InputType::sanitizeValue):
Returns a null string if the input string is null, and
don't call InputType::sanitizeValue() in this case.
* html/InputType.h: Make sanitizeValue() const.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::sanitizeValue): Make this const.
* html/NumberInputType.h: Make sanitizeValue() const.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::sanitizeValue):
- Make this const.
- Remove null check.
* html/RangeInputType.h: Make sanitizeValue() const.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::sanitizeValue): Make this const.
* html/TextFieldInputType.h: Make sanitizeValue() const.

LayoutTests:

* fast/forms/input-value-sanitization-expected.txt:
* fast/forms/input-value-sanitization.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] A DRT fix for r97348.
tkent@chromium.org [Thu, 13 Oct 2011 07:32:31 +0000 (07:32 +0000)]
[Chromium] A DRT fix for r97348.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::overridePreference):
Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
print an error message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 13 Oct 2011 07:07:15 +0000 (07:07 +0000)]
[Qt] Unreviewed gardening.

Web Inspector: REGRESSION(r97267): It made 3 tests fail on the Qt bot
https://bugs.webkit.org/show_bug.cgi?id=70005

* platform/qt/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTests don't override the WebKitWebAudioEnabled runtime preference
philn@webkit.org [Thu, 13 Oct 2011 06:52:56 +0000 (06:52 +0000)]
Tests don't override the WebKitWebAudioEnabled runtime preference
https://bugs.webkit.org/show_bug.cgi?id=69830

Rubber-stamped by Eric Carlson.

Override WebKitWebAudioEnabled in the WebAudio tests so the audio
context can be created even for the WebKit ports not enabling the
runtime WebAudio preference by default.

* webaudio/biquadfilternode-basic.html:
* webaudio/delaynode-scheduling.html:
* webaudio/delaynode.html:
* webaudio/mediaelementaudiosourcenode-gc.html:
* webaudio/mediaelementaudiosourcenode.html:
* webaudio/realtimeanalyser-fft-sizing.html:
* webaudio/resources/audio-testing.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Test expectation udpate.
tkent@chromium.org [Thu, 13 Oct 2011 06:14:27 +0000 (06:14 +0000)]
[Chromium] Test expectation udpate.

Add baseline files for ruby-base-merge-block-children.html, and
color-jpeg-with-color-profile.html only for Mac.

* fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Renamed from LayoutTests/platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.txt.
* platform/chromium-cg-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
* platform/chromium-linux-x86/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
* platform/chromium-linux/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
* platform/chromium-linux/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
* platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
* platform/chromium-win-vista/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
* platform/chromium-win-xp/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
* platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
* platform/chromium-win/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
* platform/chromium/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Test expectation update.
tkent@chromium.org [Thu, 13 Oct 2011 05:40:24 +0000 (05:40 +0000)]
[Chromium] Test expectation update.
Add baseline files for media/video-playing-and-pause.html.

* platform/chromium-cg-mac-leopard/media/video-playing-and-pause-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/media/video-playing-and-pause-expected.png: Added.
* platform/chromium-gpu-cg-mac/media/video-playing-and-pause-expected.png: Added.
* platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png: Added.
* platform/chromium-gpu-win/media/video-playing-and-pause-expected.png: Added.
* platform/chromium-linux/media/video-playing-and-pause-expected.png: Added.
* platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png: Added.
* platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png: Added.
* platform/chromium-win/media/video-playing-and-pause-expected.png: Added.
* platform/chromium-win/media/video-playing-and-pause-expected.txt: Added.
* platform/chromium/media/video-playing-and-pause-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip some more tests for WK2.
simon.fraser@apple.com [Thu, 13 Oct 2011 05:33:11 +0000 (05:33 +0000)]
Skip some more tests for WK2.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac test expectation update. The failure is tracked by the bug 69999.
rniwa@webkit.org [Thu, 13 Oct 2011 05:17:17 +0000 (05:17 +0000)]
Mac test expectation update. The failure is tracked by the bug 69999.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Test expectation update.
tkent@chromium.org [Thu, 13 Oct 2011 05:14:55 +0000 (05:14 +0000)]
[Chromium] Test expectation update.

* platform/chromium/test_expectations.txt:
plugins/refcount-leaks.html is flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIf an Arguments object is being used to copy the arguments, then
fpizlo@apple.com [Thu, 13 Oct 2011 05:01:36 +0000 (05:01 +0000)]
If an Arguments object is being used to copy the arguments, then
make this explicit
https://bugs.webkit.org/show_bug.cgi?id=69995

Reviewed by Sam Weinig.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveArguments):
* runtime/Arguments.h:
(JSC::Arguments::createAndCopyRegisters):
(JSC::Arguments::finishCreationButDontCopyRegisters):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndCopyRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate kill-old-processes logic.
rniwa@webkit.org [Thu, 13 Oct 2011 04:09:44 +0000 (04:09 +0000)]
Update kill-old-processes logic.
https://bugs.webkit.org/show_bug.cgi?id=63651

Patch by Lucas Forschler <lforschler@apple.com> on 2011-10-12
Reviewed by Ryosuke Niwa.

Remove unused mac platform specific folder.
Update master.config to use new kill-old-processes.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* BuildSlaveSupport/kill-old-processes:
* BuildSlaveSupport/mac: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline Mac region results after r97308.
simon.fraser@apple.com [Thu, 13 Oct 2011 03:59:44 +0000 (03:59 +0000)]
Rebaseline Mac region results after r97308.

* platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
* platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt:
* platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt:
* platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.txt:
* platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt:
* platform/mac/fast/regions/positioned-objects-spanning-regions-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[NRWT] New tests without expected files are reported as flakey tests
rniwa@webkit.org [Thu, 13 Oct 2011 03:18:40 +0000 (03:18 +0000)]
[NRWT] New tests without expected files are reported as flakey tests
https://bugs.webkit.org/show_bug.cgi?id=67268

Reviewed by Dirk Pranke.

The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
for missing results in retry_summary.

Fixed the bug by treating missing results separately.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients
joepeck@webkit.org [Thu, 13 Oct 2011 02:51:19 +0000 (02:51 +0000)]
<webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients

Part 3 - Add acceptMIMETypes, a parsed list of MIME types, to FileChooserSettings for WebKit ports

Reviewed by David Kilzer.

Source/WebCore:

No new tests. No new functionality in WebCore, just
exposing more information to the WebKit port.

* html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::receiveDropForDirectoryUpload):
Set the MIME type list on the FileChooser settings.

* html/HTMLInputElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::acceptMIMETypes):
Accessor for a parsed list of MIME types from the accept attribute.

* platform/FileChooser.h:
Add a slot for a MIME type list on the chooser settings.

Source/WebKit2:

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients
joepeck@webkit.org [Thu, 13 Oct 2011 02:51:06 +0000 (02:51 +0000)]
<webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients

Part 2 - Switch a WebKit2 mirror struct of WebCore::FileChooserSettings to just use FileChooserSettings

Reviewed by Anders Carlsson.

The WebOpenPanelParameters::Data struct was a mirror of
the already existing WebCore::FileChooserSettings struct.
So eliminate the excess struct and generate default
WebCore coders for the WebCore::FileChooserSettings struct.

* Scripts/webkit2/messages.py:
Switch to the new type. FileChooserSetting's header needs
to be special cased to FileChooser.h.

* Shared/WebCoreArgumentCoders.h:
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
Encode and decode all, non-deprecated, values. So we
ignore deprecatedAcceptTypes. A follow-up patch will add it.

* Shared/WebOpenPanelParameters.cpp:
(WebKit::WebOpenPanelParameters::create):
(WebKit::WebOpenPanelParameters::WebOpenPanelParameters):
Switch to the new type.

* Shared/WebOpenPanelParameters.h:
(WebKit::WebOpenPanelParameters::allowMultipleFiles):
(WebKit::WebOpenPanelParameters::selectedFileNames):
FileChooserSettings had different property names.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runOpenPanel):
Generate the WebOpenPanelParameters object here, before
passing into the WebUIClient. This seems to be the convention
to not have WebCore types in WebUIClient.

* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::runOpenPanel):
* UIProcess/WebUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::runOpenPanel):
Switch to the new type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients
joepeck@webkit.org [Thu, 13 Oct 2011 02:50:50 +0000 (02:50 +0000)]
<webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients

Part 1 - Deprecate String version of acceptTypes

Reviewed by Kent Tamura.

Source/WebCore:

Deprecate the old String version of getting the "accept"
mime type values. Instead we will change to include a
list of MIME types.

* html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::receiveDropForDirectoryUpload):
* platform/FileChooser.h:

Source/WebKit/chromium:

Chromium uses the deprecated accept string. Switching to
the new approach will require coordination with their port.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::runOpenPanel):

Source/WebKit/efl:

EFL uses the deprecated accept string. They can switch
to an Eina_List if they want to update their API.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::runOpenPanel):

Source/WebKit2:

Switch to deprecated for now, but the next patches will
remove the deprecated version from the WebKit2 path.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::runOpenPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Test expectation update
tkent@chromium.org [Thu, 13 Oct 2011 02:43:25 +0000 (02:43 +0000)]
[Chromium] Test expectation update

* platform/chromium/test_expectations.txt:
More slow tests for Mac Debug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG CFA does not filter structures aggressively enough.
fpizlo@apple.com [Thu, 13 Oct 2011 02:20:42 +0000 (02:20 +0000)]
DFG CFA does not filter structures aggressively enough.
https://bugs.webkit.org/show_bug.cgi?id=69989

Reviewed by Oliver Hunt.

* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::checkConsistency):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove ENABLE(XHTMLMP) and associated code
abarth@webkit.org [Thu, 13 Oct 2011 02:04:36 +0000 (02:04 +0000)]
Remove ENABLE(XHTMLMP) and associated code
https://bugs.webkit.org/show_bug.cgi?id=69729

Reviewed by David Levin.

.:

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev, we are removing this feature as part of our
cleanup of unmaintained code in WebKit.

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::isMediaDocument):
* dom/Node.cpp:
* dom/make_names.pl:
(usesDefaultJSWrapper):
* features.pri:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::rendererIsNeeded):
* html/HTMLElementsAllInOne.cpp:
* html/HTMLNoScriptElement.cpp: Removed.
* html/HTMLNoScriptElement.h: Removed.
* html/HTMLTagNames.in:
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::createParser):
* loader/FrameLoader.cpp:
* platform/wince/MIMETypeRegistryWinCE.cpp:
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
* xml/parser/XMLDocumentParser.h:
(WebCore::XMLDocumentParser::isXHTMLDocument):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::endDocument):
(WebCore::XMLDocumentParser::internalSubset):
(WebCore::getEntityHandler):
(WebCore::externalSubsetHandler):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseEndElement):
(WebCore::XMLDocumentParser::endDocument):
(WebCore::XMLDocumentParser::parseDtd):

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:
* Scripts/old-run-webkit-tests:
* Scripts/webkitperl/features.pm:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

These tests are not needed anymore (and they are currently not run).

* fast/xhtmlmp: Removed.
* fast/xhtmlmp/check-doctype-declaration.xhtml: Removed.
* fast/xhtmlmp/check-rootelement.xhtml: Removed.
* fast/xhtmlmp/noscript-basic-expected.txt: Removed.
* fast/xhtmlmp/noscript-basic.xhtml: Removed.
* fast/xhtmlmp/noscript-in-multiscripts.xhtml: Removed.
* fast/xhtmlmp/noscript-nested.xhtml: Removed.
* fast/xhtmlmp/noscript.xhtml: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix CCThreadTest.startPostAndWaitOnCondition
commit-queue@webkit.org [Thu, 13 Oct 2011 01:50:41 +0000 (01:50 +0000)]
Fix CCThreadTest.startPostAndWaitOnCondition
https://bugs.webkit.org/show_bug.cgi?id=69967

Patch by Antoine Labour <piman@chromium.org> on 2011-10-12
Reviewed by Darin Fisher.

* tests/CCThreadTest.cpp:
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMacroAssemblerX86 8-bit register ops unsafe on CPU(X86)
barraclough@apple.com [Thu, 13 Oct 2011 01:44:14 +0000 (01:44 +0000)]
MacroAssemblerX86 8-bit register ops unsafe on CPU(X86)
https://bugs.webkit.org/show_bug.cgi?id=69978

Reviewed by Filip Pizlo.

Certain ops are unsafe if the register passed is esp..edi (will instead test/set the ).

compare32/test8/test32 Call setCC, which sets an 8-bit register - we can fix this by adding
a couple of xchg instructions.

branchTest8 with a register argument is also affected. In all cases this is currently used
this is testing a value that is correct to 32 or more bits, so we can simply switch these
to branchTest32 & remove the corresponding branchTest8 (this is desirable anyway, since the
32-bit form is cheaper to implement on platforms that don't have an 8-bit compare instruction).

This fixes the remaining fast/js failures with the DFG JIT 32_64.

* assembler/MacroAssemblerARMv7.h
    - removed branchTest8.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::compare32):
(JSC::MacroAssemblerX86Common::test8):
(JSC::MacroAssemblerX86Common::test32):
(JSC::MacroAssemblerX86Common::set32):
    - added set32 helper that is 'h' register safe.
    - removed branchTest8.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
    - switch uses of branchTest8 to branchTest32.
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
    - switch uses of branchTest8 to branchTest32.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
    - switch uses of branchTest8 to branchTest32.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
    - switch uses of branchTest8 to branchTest32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoKill old run-webkit-tests processes in kill-process on Mac
rniwa@webkit.org [Thu, 13 Oct 2011 01:33:57 +0000 (01:33 +0000)]
Kill old run-webkit-tests processes in kill-process on Mac
https://bugs.webkit.org/show_bug.cgi?id=69976

Reviewed by Dirk Pranke.

Add a system call to remove all python processes running run-webkit-tests.

* BuildSlaveSupport/kill-old-processes:
* BuildSlaveSupport/mac: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Change efl style parameter variables with WebKit coding Style
gyuyoung.kim@samsung.com [Thu, 13 Oct 2011 01:23:06 +0000 (01:23 +0000)]
[EFL] Change efl style parameter variables with WebKit coding Style
https://bugs.webkit.org/show_bug.cgi?id=69073

Reviewed by Antonio Gomes.

This is a third step in order to be more compliant with WebKit coding style.
We have used one-letter| two-letter parameter according to efl style. However, it's more difficult
for other reviewers to review EFL patches. So, this patch changes efl style parameters
with meaningful one.

Majors changes are listed below,

- Use ewkFrame instead of o parameter in ewk_frame.cpp.
- Use ewkView instead of o parameter in ewk_view.cpp.
- Use menu and item instead of o parameter in ewk_contextmenu.cpp.
- Use ewkTile instead of o parameter in ewk_tile_xxx.cpp.
- Use tile parameter name instead of t parameter in ewk_tile_xxx.cpp.
- Use smartData instead of sd parameter for Ewk_XXXX_Smart_Data struct.
- Use width, height instead of w, h parameter.
- Use xxxEvent instead of ev parameter for event. (e.g. downEvent, upEvent, wheelEvent)
- Use scrollX, scrollY, scrollWidth, scrollHeight, centerX, centerY, deltaX, deltaY instead of sx, xy, sw,
sh, cx, cy, dx, dy.
- Use tileUnusedCache instead of tuc parameter in tiled backing store.
- Use red, green, blue and alpha instead of r,g,b,a.
- Remove "_" from parameter variable.
- Run demarchi's coding style script for ewk_tile_xxx.cpp files.
- Remove *void* parameter in ewk_tile_xxx.cpp's internal functions.

* ewk/ewk_auth_soup.cpp:
* ewk/ewk_contextmenu.cpp:
* ewk/ewk_cookies.cpp:
* ewk/ewk_frame.cpp:
* ewk/ewk_history.cpp:
* ewk/ewk_js.cpp:
* ewk/ewk_protocol_handler_soup.cpp:
* ewk/ewk_settings.cpp:
* ewk/ewk_tiled_backing_store.cpp:
* ewk/ewk_tiled_backing_store.h:
* ewk/ewk_tiled_matrix.cpp:
* ewk/ewk_tiled_matrix.h:
* ewk/ewk_tiled_model.cpp:
* ewk/ewk_tiled_model.h:
* ewk/ewk_view.cpp:
* ewk/ewk_view_single.cpp:
* ewk/ewk_view_tiled.cpp:
* ewk/ewk_window_features.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Test expectation update.
tkent@chromium.org [Thu, 13 Oct 2011 01:07:16 +0000 (01:07 +0000)]
[Chromium] Test expectation update.

* platform/chromium/test_expectations.txt:
Try marking SLOW for Mac Debug timeouts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMany WK2 snapshots are blank
simon.fraser@apple.com [Thu, 13 Oct 2011 00:57:11 +0000 (00:57 +0000)]
Many WK2 snapshots are blank
https://bugs.webkit.org/show_bug.cgi?id=69953

Reviewed by Beth Dakin.

Two fixes:
1. negating a size_t in CGContextTranslateCTM() fails, because
size_t is unsigned. Fix by casing to CGFloat before negation.

2. Turn on window autodisplay, so that compositing tests snapshot correctly.
Autodisplay is necessary to kick off Core Animation rendering.

* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement a WebKitTransitionEvent constructor for V8
haraken@chromium.org [Thu, 13 Oct 2011 00:50:54 +0000 (00:50 +0000)]
Implement a WebKitTransitionEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=69911

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/webkit-transition-event-constructor.html

* bindings/v8/custom/V8EventConstructors.cpp: Added a WebKitTransitionEvent constructor.
* dom/WebKitTransitionEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.

LayoutTests:

Enabled webkit-transition-event-constructor.html, since now V8 has the WebKitTransitionEvent constructor.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomake fast/writing-mode/margins.html a reftest to avoid cross-platform differences
ojan@chromium.org [Thu, 13 Oct 2011 00:37:40 +0000 (00:37 +0000)]
make fast/writing-mode/margins.html a reftest to avoid cross-platform differences
https://bugs.webkit.org/show_bug.cgi?id=69977

Reviewed by Tony Chang.

* fast/writing-mode/margins-expected.html: Added.
* fast/writing-mode/margins-expected.png: Removed.
* fast/writing-mode/margins-expected.txt: Removed.
* fast/writing-mode/margins.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement a BeforeLoadEvent constructor for JSC
haraken@chromium.org [Thu, 13 Oct 2011 00:35:15 +0000 (00:35 +0000)]
Implement a BeforeLoadEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=69893

Reviewed by Adam Barth.

Source/WebCore:

There is no spec for the BeforeLoadEvent constructor
since it is WebKit-specific. However, judging from the current
IDL of initBeforeLoadEvent(), the constructor IDL
should be as follows.

[Constructor(DOMString type, optional BeforeLoadEventInit eventInitDict)]
interface BeforeLoadEvent : Event {
    ...;
}

dictionary BeforeLoadEventInit : EventInit {
    DOMString url;
}

Test: fast/events/constructors/before-load-event-constructor.html

* bindings/generic/EventConstructors.h: Added a definition for the BeforeLoadEvent constructor.
* bindings/js/JSEventConstructors.cpp: Added #includes for BeforeLoadEvent.
* dom/BeforeLoadEvent.h: Added a definition for BeforeLoadEventInit.
(WebCore::BeforeLoadEventInit::BeforeLoadEventInit):
(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::initBeforeLoadEvent):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):
* dom/BeforeLoadEvent.idl: Makes BeforeLoadEvent constructible.

LayoutTests:

before-load-event-constructor.html checks the behavior of the BeforeLoadEvent constructor.

* fast/dom/constructed-objects-prototypes-expected.txt: Added inner.BeforeLoadEvent().
* fast/events/constructors/before-load-event-constructor-expected.txt: Added.
* fast/events/constructors/before-load-event-constructor.html: Added.
* platform/chromium/test_expectations.txt: Skipped before-load-event-constructor.html, since V8 does not yet have the BeforeLoadEvent constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoC4481 warning should be disabled for OVERRIDE and FINAL.
tkent@chromium.org [Thu, 13 Oct 2011 00:34:35 +0000 (00:34 +0000)]
C4481 warning should be disabled for OVERRIDE and FINAL.
https://bugs.webkit.org/show_bug.cgi?id=69904

Reviewed by Adam Roben.

* win/tools/vsprops/common.vsprops: Disable C4481.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocommit-queue doesn't have a friendly error message when the reviewer line is messed up
abarth@webkit.org [Thu, 13 Oct 2011 00:21:40 +0000 (00:21 +0000)]
commit-queue doesn't have a friendly error message when the reviewer line is messed up
https://bugs.webkit.org/show_bug.cgi?id=69979

Reviewed by Eric Seidel.

Rather than combining the ChangeLog validation with a more complicated
command, this patch has the commit-queue run it as a separate command,
which will give us more control over the error message.

* Scripts/webkitpy/tool/bot/commitqueuetask.py:
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/steps/validatechangelogs.py:
* Scripts/webkitpy/tool/steps/validatereviewer.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayout tests asserting in LayoutTestController::pathToLocalResource()
eric@webkit.org [Thu, 13 Oct 2011 00:14:53 +0000 (00:14 +0000)]
Layout tests asserting in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=69898

Reviewed by Simon Fraser.

old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.

* Scripts/old-run-webkit-tests:
(openDumpTool):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe commit-queue doesn't tell me which tests my patch broke
abarth@webkit.org [Thu, 13 Oct 2011 00:13:31 +0000 (00:13 +0000)]
The commit-queue doesn't tell me which tests my patch broke
https://bugs.webkit.org/show_bug.cgi?id=69975

Reviewed by Eric Seidel.

We now print the list of newly failing tests, like we do for the EWS.

* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[skia] Implement Path.currentPoint for skia
commit-queue@webkit.org [Wed, 12 Oct 2011 23:59:48 +0000 (23:59 +0000)]
[skia] Implement Path.currentPoint for skia
https://bugs.webkit.org/show_bug.cgi?id=69817

Replace FIXME with implementation.

Patch by Ben Wells <benwells@chromium.org> on 2011-10-12
Reviewed by Kenneth Russell.

* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::currentPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncorrect rendering with one-sided thick border and border-radius
commit-queue@webkit.org [Wed, 12 Oct 2011 23:44:10 +0000 (23:44 +0000)]
Incorrect rendering with one-sided thick border and border-radius
https://bugs.webkit.org/show_bug.cgi?id=38787

Patch by Ben Wells <benwells@chromium.org> on 2011-10-12
Reviewed by Simon Fraser.

Source/WebCore:

Incorrect rendering resulted when the inner border could not be properly represented as a rounded
rectangle. When this happens, and the inner border is clipped out, the clipping code clips out the
enclosing rectangle instead.

This change addresses this by clipping in a different way in this case only. The inside is clipped
out one side at a time with a rounded rect created by adjusting the unrenderable inner border
rounded rectangle. The side polygon which is clipped to is also increased in this case to include
the inside of the border so that no areas are missing.

Test: fast/borders/border-radius-complex-inner.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::calculateSideRectIncludingInner):
(WebCore::calculateAdjustedInnerBorder):
(WebCore::RenderBoxModelObject::clipBorderSideForComplexInnerPath):
* rendering/RenderBoxModelObject.h:

LayoutTests:

* fast/borders/border-radius-complex-inner.html: Added.
* platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png: Added.
* platform/chromium-linux/fast/borders/border-radius-different-width-001-expected.png:
* platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac/fast/borders/border-radius-complex-inner-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded myself as a committer.
aboxhall@chromium.org [Wed, 12 Oct 2011 23:14:16 +0000 (23:14 +0000)]
Added myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Wed, 12 Oct 2011 23:02:26 +0000 (23:02 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-12

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip accessibility/menu-list-sends-change-notification.html on Mac.
dmazzoni@google.com [Wed, 12 Oct 2011 22:57:19 +0000 (22:57 +0000)]
Skip accessibility/menu-list-sends-change-notification.html on Mac.
https://bugs.webkit.org/show_bug.cgi?id=69970

Reviewed by Simon Fraser.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up CSSPropertyTextDecoration implementation and ETextDecoration usage.
macpherson@chromium.org [Wed, 12 Oct 2011 22:51:17 +0000 (22:51 +0000)]
Clean up CSSPropertyTextDecoration implementation and ETextDecoration usage.
https://bugs.webkit.org/show_bug.cgi?id=67625

Reviewed by Eric Seidel.

No new tests - no functionality changed.

The implementation of CSSPropertyTextDecoration is simlified because
1) CSSValueListIterator produces a valid iterator when no results available.
2) CSSParser only allows CSSValueNone or a list of appropriate idents.
3) CSSParser will treat a zero-length list as invalid at parse time.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator ETextDecoration):
Implement cast from CSSPrimitiveValue to ETextDecoration.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
Use ETextDecoration enum instead of int throughout.
(WebCore::InheritedFlags::textDecorationsInEffect):
(WebCore::InheritedFlags::textDecoration):
(WebCore::InheritedFlags::addToTextDecorationsInEffect):
(WebCore::InheritedFlags::setTextDecorationsInEffect):
(WebCore::InheritedFlags::setTextDecoration):
* rendering/style/RenderStyleConstants.h:
Introduce constant for number of bits required to represent enum.
(WebCore::operator|):
Implement | operator for bitfield enum.
(WebCore::operator|=):
Implement |= operator for bitfield enum.
* rendering/style/StyleVisualData.h:
Use ETextDecoration instead of int.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement -webkit-flex-align for cross axis alignment in flex-flow: row
tony@chromium.org [Wed, 12 Oct 2011 22:49:25 +0000 (22:49 +0000)]
Implement -webkit-flex-align for cross axis alignment in flex-flow: row
https://bugs.webkit.org/show_bug.cgi?id=69808

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/flex-align-percent-height.html
       css3/flexbox/flex-align-vertical-writing-mode.html
       css3/flexbox/flex-align.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::isFlowAwareLogicalHeightAuto):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareBorderAndPaddingLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareMarginLogicalHeightForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalLocationForChild):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::availableLogicalHeightForChild):
(WebCore::RenderFlexibleBox::marginBoxAscent):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
(WebCore::RenderFlexibleBox::adjustLocationLogicalTopForChild):
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):
* rendering/RenderFlexibleBox.h:

LayoutTests:

* css3/flexbox/flex-align-expected.txt: Added.
* css3/flexbox/flex-align-percent-height-expected.txt: Added.
* css3/flexbox/flex-align-percent-height.html: Added.
* css3/flexbox/flex-align-vertical-writing-mode-expected.txt: Added.
* css3/flexbox/flex-align-vertical-writing-mode.html: Added.
* css3/flexbox/flex-align.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpected result accidentally left out of http://trac.webkit.org/changeset/97222/.
ojan@chromium.org [Wed, 12 Oct 2011 22:47:05 +0000 (22:47 +0000)]
Expected result accidentally left out of trac.webkit.org/changeset/97222/.

* fast/writing-mode/margins-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago_run_tests is a confusing variable name in webkitpy
abarth@webkit.org [Wed, 12 Oct 2011 22:44:46 +0000 (22:44 +0000)]
_run_tests is a confusing variable name in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=69971

Reviewed by Eric Seidel.

Eric and I thought this was a function.

* Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChanged the order of my email addresses so that it autocompletes the correct one.
dmazzoni@google.com [Wed, 12 Oct 2011 22:30:39 +0000 (22:30 +0000)]
Changed the order of my email addresses so that it autocompletes the correct one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix test-webkitpy after r97307 and r97293.
tony@chromium.org [Wed, 12 Oct 2011 22:20:54 +0000 (22:20 +0000)]
Fix test-webkitpy after r97307 and r97293.

* Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms
  is None during tests so add back the check.
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The
  output directory is now build/Debug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Regions]Remove -webkit-content-order property
mihnea@adobe.com [Wed, 12 Oct 2011 22:14:33 +0000 (22:14 +0000)]
[CSS Regions]Remove -webkit-content-order property
https://bugs.webkit.org/show_bug.cgi?id=69848

Reviewed by Tony Chang.

-webkit-content-order property is removed from latest CSS Regions spec.

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* dom/Node.cpp:
(WebCore::Node::diff):
* rendering/RenderFlowThread.cpp:
(WebCore::compareRenderRegions):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderFlowThreads):
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/regions/content-flowed-into-regions-with-dyn-index-expected.txt: Removed.
* fast/regions/content-flowed-into-regions-with-dyn-index.html: Removed.
* fast/regions/content-flowed-into-regions-with-index-dom-expected.txt: Removed.
* fast/regions/content-flowed-into-regions-with-index-dom.html: Removed.
* fast/regions/content-flowed-into-regions-with-index-expected.txt: Removed.
* fast/regions/content-flowed-into-regions-with-index.html: Removed.
* fast/regions/script-tests/webkit-content-order-parsing.js: Removed.
* fast/regions/webkit-content-order-parsing-expected.txt: Removed.
* fast/regions/webkit-content-order-parsing.html: Removed.
* platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
* platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
* platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt:
* platform/mac/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Removed.
* platform/mac/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Removed.
* platform/mac/fast/regions/content-flowed-into-regions-with-index-expected.png: Removed.
* platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/flow-content-basic-expected.txt:
* platform/mac/fast/regions/flow-content-basic-vertical-expected.txt:
* platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt:
* platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt:
* platform/mac/fast/regions/flows-dependency-same-flow-expected.txt:
* platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/outline-sides-in-region-expected.txt:
* platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
* platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt:
* platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
* platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt:
* platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt:
* platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt:
* platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.txt:
* platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt:
* platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt:
* platform/mac/fast/regions/positioned-objects-in-regions-expected.txt:
* platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.txt:
* platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt:
* platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt:
* platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt:
* platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt:
* platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt:
* platform/mac/fast/regions/region-overflow-break-expected.txt:
* platform/mac/fast/regions/render-region-renderer-expected.txt:
* platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
* platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
* platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt:
* platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
* platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt:
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt:
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
* platform/mac/fast/regions/webkit-flow-renderer-expected.txt:
* platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt:
* platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
* platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
* platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] remove old build dirs on chromium-win
tony@chromium.org [Wed, 12 Oct 2011 22:07:07 +0000 (22:07 +0000)]
[chromium] remove old build dirs on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=69961

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now
  always in build and never in chrome or webkit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] More timeouts after V8 roll.
dglazkov@chromium.org [Wed, 12 Oct 2011 21:50:42 +0000 (21:50 +0000)]
[Chromium] More timeouts after V8 roll.

* platform/chromium/test_expectations.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate PeerConnection to use WebCore platform interfaces
commit-queue@webkit.org [Wed, 12 Oct 2011 21:37:41 +0000 (21:37 +0000)]
Update PeerConnection to use WebCore platform interfaces
https://bugs.webkit.org/show_bug.cgi?id=68462

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-10-12
Reviewed by Adam Barth.

Currently not testable.

* WebCore.gypi:
* WebCore.pro:
* bindings/js/JSPeerConnectionCustom.cpp:
(WebCore::JSPeerConnectionConstructor::constructJSPeerConnection):
* bindings/v8/custom/V8PeerConnectionCustom.cpp: Removed.
* dom/MediaStreamList.cpp:
(WebCore::MediaStreamList::item):
(WebCore::MediaStreamList::append):
(WebCore::MediaStreamList::remove):
(WebCore::MediaStreamList::contains):
* dom/MediaStreamList.h:
* p2p/PeerConnection.cpp:
(WebCore::PeerConnection::create):
(WebCore::PeerConnection::PeerConnection):
(WebCore::PeerConnection::processSignalingMessage):
(WebCore::PeerConnection::readyState):
(WebCore::PeerConnection::send):
(WebCore::PeerConnection::addStream):
(WebCore::PeerConnection::removeStream):
(WebCore::PeerConnection::localStreams):
(WebCore::PeerConnection::remoteStreams):
(WebCore::PeerConnection::close):
(WebCore::PeerConnection::iceProcessingCompleted):
(WebCore::PeerConnection::sdpGenerated):
(WebCore::PeerConnection::dataStreamMessageReceived):
(WebCore::PeerConnection::remoteStreamAdded):
(WebCore::PeerConnection::remoteStreamRemoved):
(WebCore::PeerConnection::scriptExecutionContext):
(WebCore::PeerConnection::stop):
(WebCore::PeerConnection::scheduleInitialNegotiation):
(WebCore::PeerConnection::initialNegotiationTimerFired):
(WebCore::PeerConnection::ensureStreamChangeScheduled):
(WebCore::PeerConnection::streamChangeTimerFired):
(WebCore::PeerConnection::scheduleReadyStateChange):
(WebCore::PeerConnection::readyStateChangeTimerFired):
(WebCore::PeerConnection::changeReadyState):
* p2p/PeerConnection.h:
(WebCore::PeerConnection::refEventTarget):
(WebCore::PeerConnection::derefEventTarget):
* p2p/PeerConnection.idl:
* page/MediaStreamClient.h:
* page/MediaStreamController.cpp:
(WebCore::MediaStreamController::MediaStreamController):
* page/MediaStreamController.h:
* page/MediaStreamFrameController.cpp:
* page/MediaStreamFrameController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97305 268f45cc-cd09-0410-ab3c-d52691b4dbfc