WebKit-https.git
11 years ago2010-07-27 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 27 Jul 2010 13:55:51 +0000 (13:55 +0000)]
2010-07-27  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        LayoutTests/fast/dom/DeviceOrientation/window-property.html assumes use of V8
        https://bugs.webkit.org/show_bug.cgi?id=43025

        This change modifies window-property.html and its expected result to work with JSC.
        A V8-specific expected result is added for Android.

        * fast/dom/DeviceOrientation/script-tests/window-property.js:
        * fast/dom/DeviceOrientation/window-property-expected.txt:
        * platform/android-v8: Added.
        * platform/android-v8/fast: Added.
        * platform/android-v8/fast/dom: Added.
        * platform/android-v8/fast/dom/DeviceOrientation: Added.
        * platform/android-v8/fast/dom/DeviceOrientation/window-property-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 27 Jul 2010 13:41:20 +0000 (13:41 +0000)]
2010-07-27  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Current implementation of message based inspector
        transport generated by CodeGeneratorInspector should be upstreamed
        from WebKit/chromium to WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=42983

        * Android.derived.v8bindings.mk:
        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/ScriptObject.cpp:
        * bindings/js/ScriptObject.h:
        * bindings/v8/ScriptObject.cpp:
        * bindings/v8/ScriptObject.h:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InspectorBackend.idl: Removed.
        * inspector/InspectorFrontendClient.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
        (WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
        * inspector/InspectorFrontendClientLocal.h:
        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::sendMessageToBackend):
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub):
        (.WebInspector.InspectorBackendStub.prototype._registerDelegate):
        (.WebInspector.InspectorBackendStub.prototype.sendMessageToBackend):

2010-07-27  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Current implementation of message based inspector
        transport generated by CodeGeneratorInspector should be upstreamed
        from WebKit/chromium to WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=42983

        * WebKit.gypi:
        * src/InspectorFrontendClientImpl.cpp:
        (WebKit::InspectorFrontendClientImpl::sendMessageToBackend):
        * src/InspectorFrontendClientImpl.h:
        * src/ToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController):
        (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost):
        * src/WebDevToolsAgentImpl.h:
        * src/js/InspectorControllerImpl.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-25 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
andreas.kling@nokia.com [Tue, 27 Jul 2010 13:01:04 +0000 (13:01 +0000)]
2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=42947
        Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw
        error. Without which dumpRenderTree crashes.

        * Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Balazs Kelemen <kb@inf.u-szeged.hu>
commit-queue@webkit.org [Tue, 27 Jul 2010 12:27:29 +0000 (12:27 +0000)]
2010-07-27  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] WebKit::PageClient implementation needs a dedicated class

        https://bugs.webkit.org/show_bug.cgi?id=42974

        * UIProcess/API/qt/qwkpage.cpp:
        (PageClientImpl::PageClientImpl): Added.
        (PageClientImpl::pageDidEnterAcceleratedCompositing): Moved from QWKPagePrivate.
        (PageClientImpl::pageDidLeaveAcceleratedCompositing): Ditto.
        (PageClientImpl::processDidExit): Ditto.
        (PageClientImpl::processDidRevive): Ditto.
        (PageClientImpl::setCursor): Ditto.
        (PageClientImpl::takeFocus): Ditto.
        (PageClientImpl::toolTipChanged): Ditto.
        (QWKPagePrivate::QWKPagePrivate): Set a new instance of the PageClientImpl as PageClient rather than 'this'.
        * UIProcess/API/qt/qwkpage_p.h: Removed PageClient implementation methods from QWKPagePrivate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Tue, 27 Jul 2010 12:08:36 +0000 (12:08 +0000)]
2010-07-27  Anton Muhin  <antonm@chromium.org>

        Reviewed by Darin Adler.

        Extend a test checking access to nested elements on the document to cover recent regression in Chromium
        https://bugs.webkit.org/show_bug.cgi?id=42980

        See http://code.google.com/p/chromium/issues/detail?id=48804 for more details.

        * fast/dom/HTMLDocument/document-special-properties-expected.txt:
        * fast/dom/HTMLDocument/document-special-properties.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Incorrect input method hints
hausmann@webkit.org [Tue, 27 Jul 2010 10:55:56 +0000 (10:55 +0000)]
[Qt] Incorrect input method hints
https://bugs.webkit.org/show_bug.cgi?id=43037

Reviewed by Tor Arne Vestbø.

Properly set or reset all input method hints when
activating input fields.

* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::focusInputTypes): Extended unit test to verify that we
reset hints.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix failing layout-tests after r64114
vestbo@webkit.org [Tue, 27 Jul 2010 10:05:22 +0000 (10:05 +0000)]
[Qt] Fix failing layout-tests after r64114

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Kim Grönholm <kim.1.gronholm@nokia.com>
kim.1.gronholm@nokia.com [Tue, 27 Jul 2010 09:51:48 +0000 (09:51 +0000)]
2010-07-27  Kim Grönholm  <kim.1.gronholm@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Decouple QTouchEvent's accepted flag from JS prevent default
        https://bugs.webkit.org/show_bug.cgi?id=42892

        We need to always accept the QTouchEvents in order to get TouchUpdate and
        TouchEnd events. QWebPage::event() return value is used to indicate
        whether the default action was prevented for the touch events.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebView::sceneEvent):
        * Api/qwebpage.cpp:
        (QWebPagePrivate::touchEvent):
        (QWebPage::event):
        * Api/qwebpage_p.h:
        * Api/qwebview.cpp:
        (QWebView::event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed. Trivial test fix.
tkent@chromium.org [Tue, 27 Jul 2010 09:36:05 +0000 (09:36 +0000)]
Unreviewed. Trivial test fix.

* fast/forms/script-tests/input-number-events.js:
 Adjust pixel values in order to work on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate expected result as well to match r64115.
vestbo@webkit.org [Tue, 27 Jul 2010 09:29:03 +0000 (09:29 +0000)]
Update expected result as well to match r64115.

Reviewed by NOBODY.

* fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix GTK layout-test break after r64114
vestbo@webkit.org [Tue, 27 Jul 2010 09:12:40 +0000 (09:12 +0000)]
Fix GTK layout-test break after r64114

Reviewed by NOBODY.

Skipping the test for Qt until we can find a non-fragile way to write
the test.

* fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Change default font from sans-serif to serif
vestbo@webkit.org [Tue, 27 Jul 2010 08:38:23 +0000 (08:38 +0000)]
[Qt] Change default font from sans-serif to serif

Reviewed by Simon Hausmann.

This matches what other ports and browser engines do.

We now also use QFont's defaultFontFamily() to resolve the
correct fonts for each platform. For Qt >= 4.7 we can take
advantage of the new enums for generic font families.

The spatial-navigation test had to be changed due to the
fragile nature of the down-action. By changing the font we
hit the case where the two down actions were not enough to
scroll the link into view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Dominic Mazzoni <dmazzoni@google.com>
commit-queue@webkit.org [Tue, 27 Jul 2010 08:33:42 +0000 (08:33 +0000)]
2010-07-27  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Chris Fleizach.

        Add accessors for node and document to WebAccessibilityObject,
        needed to support some Windows screenreader functionality.

        https://bugs.webkit.org/show_bug.cgi?id=43001

        * public/WebAccessibilityObject.h:
        * src/WebAccessibilityObject.cpp:
        (WebKit::WebAccessibilityObject::node):
        (WebKit::WebAccessibilityObject::document):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Dominic Mazzoni <dmazzoni@google.com>
commit-queue@webkit.org [Tue, 27 Jul 2010 08:07:50 +0000 (08:07 +0000)]
2010-07-27  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Chris Fleizach.

        For Windows accessibility, have WebElement provide access
        to its attributes.

        https://bugs.webkit.org/show_bug.cgi?id=43004

        * WebKit.gyp:
        * public/WebAttribute.h: Added.
        (WebKit::WebAttribute::~WebAttribute):
        (WebKit::WebAttribute::WebAttribute):
        (WebKit::WebAttribute::operator=):
        * public/WebElement.h:
        * public/WebNamedNodeMap.h: Added.
        (WebKit::WebNamedNodeMap::~WebNamedNodeMap):
        (WebKit::WebNamedNodeMap::WebNamedNodeMap):
        (WebKit::WebNamedNodeMap::operator=):
        * src/WebAttribute.cpp: Added.
        (WebKit::WebAttribute::reset):
        (WebKit::WebAttribute::assign):
        (WebKit::WebAttribute::WebAttribute):
        (WebKit::WebAttribute::localName):
        (WebKit::WebAttribute::value):
        * src/WebElement.cpp:
        (WebKit::WebElement::attributes):
        * src/WebNamedNodeMap.cpp: Added.
        (WebKit::WebNamedNodeMap::reset):
        (WebKit::WebNamedNodeMap::assign):
        (WebKit::WebNamedNodeMap::WebNamedNodeMap):
        (WebKit::WebNamedNodeMap::length):
        (WebKit::WebNamedNodeMap::attributeItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Satish Sampath <satish@chromium.org>
commit-queue@webkit.org [Tue, 27 Jul 2010 07:50:57 +0000 (07:50 +0000)]
2010-07-27  Satish Sampath  <satish@chromium.org>

        Reviewed by Kent Tamura.

        Simplify speech input plumbing in webcore and webkit
        https://bugs.webkit.org/show_bug.cgi?id=43008

        No new tests as functionality is not changed.

        * GNUmakefile.am: Removed a header file.
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/Page.cpp:
        (WebCore::Page::speechInput): Creates and returns SpeechInput when needed.
        * page/Page.h:
        * page/SpeechInput.cpp: Added methods to proxy and callbacks between input elements and WebKit
        (WebCore::SpeechInput::SpeechInput):
        (WebCore::SpeechInput::didCompleteRecording):
        (WebCore::SpeechInput::didCompleteRecognition):
        (WebCore::SpeechInput::setRecognitionResult):
        (WebCore::SpeechInput::startRecognition):
        (WebCore::SpeechInput::stopRecording):
        * page/SpeechInput.h:
        * page/SpeechInputClient.h:
        * page/SpeechInputClientListener.h: Removed.
        * page/SpeechInputListener.h:
        * rendering/TextControlInnerElements.cpp: Added one more callback.
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
        (WebCore::InputFieldSpeechButtonElement::speechInput):
        (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition):
        * rendering/TextControlInnerElements.h:
2010-07-27  Satish Sampath  <satish@chromium.org>

        Reviewed by Kent Tamura.

        Simplify speech input plumbing in webcore and webkit
        https://bugs.webkit.org/show_bug.cgi?id=43008

        * src/SpeechInputClientImpl.cpp: Move functionality to WebCore::SpeechInput and make this a dummy proxy.
        (WebKit::SpeechInputClientImpl::startRecognition):
        (WebKit::SpeechInputClientImpl::cancelRecognition):
        (WebKit::SpeechInputClientImpl::didCompleteRecording):
        (WebKit::SpeechInputClientImpl::didCompleteRecognition):
        (WebKit::SpeechInputClientImpl::setRecognitionResult):
        * src/SpeechInputClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a runtime setting for interactive form validation.
tkent@chromium.org [Tue, 27 Jul 2010 07:31:39 +0000 (07:31 +0000)]
Add a runtime setting for interactive form validation.
https://bugs.webkit.org/show_bug.cgi?id=40520

Reviewed by Ojan Vafai.

WebCore:

The interactive validation feature was disabled for non-strict
modes by r61059 to avoid a compatibility issue. This removes the
mode checking and introduce a runtime setting to enable/disable
the feature instead.
The default value is 'disable' and we'll remove the setting when
the compatibility issue is resolved and interactive validation
implementation is completed.

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setInteractiveFormValidationEnabled):
(WebCore::Settings::interactiveFormValidationEnabled):

LayoutTests:

Remove the mode-specific tests and skip tests which don't work
without the interactive validation feature.

* fast/forms/interactive-validation-compat-mode-expected.txt: Removed.
* fast/forms/interactive-validation-compat-mode.html: Removed.
* fast/forms/interactive-validation-html4-expected.txt: Removed.
* fast/forms/interactive-validation-html4.html: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-27 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 27 Jul 2010 07:05:28 +0000 (07:05 +0000)]
2010-07-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=42956
        [DRT/Chromium] Fix "out of sync" assertion error

        Fix an assertion error on Windows like the following:
        100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
        |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
        |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        If the url matches with "file:///[a-z]:", does case-ignore comparison.
        GURL capitalize the driver letter of a file: URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix from Chromium/GTK build fix!
barraclough@apple.com [Tue, 27 Jul 2010 06:04:19 +0000 (06:04 +0000)]
Windows build fix from Chromium/GTK build fix!

* wtf/PageAllocation.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChromium/GTK build fix
barraclough@apple.com [Tue, 27 Jul 2010 05:51:10 +0000 (05:51 +0000)]
Chromium/GTK build fix

* wtf/PageAllocation.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for !Mac platforms.
barraclough@apple.com [Tue, 27 Jul 2010 05:23:28 +0000 (05:23 +0000)]
Build fix for !Mac platforms.

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 43009 - Abstract out page allocation from executable allocators
barraclough@apple.com [Tue, 27 Jul 2010 05:02:09 +0000 (05:02 +0000)]
Bug 43009 - Abstract out page allocation from executable allocators

Reviewed by Oliver Hunt.

JavaScriptCore:

It would be great to have a single platform abstraction for block allocation, rather than copy/paste code.

In this initial implementation I've made Symbian fall back to use malloc/free for non-executable memory.
I think this will match current behaviour for the next client we will want to port across (RegisterFile &
Collector).

* CMakeListsEfl.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
* jit/ExecutableAllocatorPosix.cpp: Removed.
* jit/ExecutableAllocatorSymbian.cpp: Removed.
* jit/ExecutableAllocatorWin.cpp: Removed.
* wscript:
* wtf/PageAllocator.cpp: Added.
(WTF::protection):
(WTF::PageAllocation::commit):
(WTF::PageAllocation::decommit):
(WTF::PageAllocator::allocate):
(WTF::PageAllocator::reserve):
(WTF::PageAllocator::deallocate):
(WTF::PageAllocator::pagesize):
* wtf/PageAllocator.h: Added.
(WTF::PageAllocation::PageAllocation):
(WTF::PageAllocation::base):
(WTF::PageAllocation::size):
(WTF::PageAllocation::chunk):
(WTF::PageAllocation::operator!):
(WTF::PageAllocator::):

JavaScriptGlue:

* ForwardingHeaders/wtf/PageAllocation.h: Added.

WebCore:

* ForwardingHeaders/wtf/PageAllocation.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Yuta Kitamura <yutak@chromium.org>
commit-queue@webkit.org [Tue, 27 Jul 2010 04:51:38 +0000 (04:51 +0000)]
2010-07-26  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Pavel Feldman.

        Add WebSocket resource type to Web Inspector.

        When a new WebSocket connection is established, a line for that connection
        will appear in Web Inspector's Resources tab. If the resource name is
        clicked, the details of handshake request and response will be shown.

        Web Inspector: WebSocket in Resources tab
        https://bugs.webkit.org/show_bug.cgi?id=40768

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addResource): WebSocket resource does not
        have an associated loader, thus frame might be null. Need to check it.
        (WebCore::InspectorController::removeResource): Ditto.
        (WebCore::InspectorController::didCreateWebSocket):
        (WebCore::InspectorController::willSendWebSocketHandshakeRequest):
        (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse):
        (WebCore::InspectorController::didCloseWebSocket):
        * inspector/InspectorController.h:
        * inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame,
        because WebSocket does not have a loader and we need to allow null for
        these variables.
        (WebCore::createReadableStringFromBinary):
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::InspectorResource::create): Factory function of
        regular (non-WebSocket) resources.
        (WebCore::InspectorResource::createWebSocket): Factory function of
        WebSocket resources.
        (WebCore::InspectorResource::updateWebSocketRequest):
        (WebCore::InspectorResource::updateWebSocketResponse):
        (WebCore::InspectorResource::updateScriptObject): m_frame->document() becomes
        available when Frame::setDocument() is called. We cannot obtain documentURL
        during the constructor or updateRequest() function, because m_frame->document()
        is not available yet at that point and documentURL will contain a wrong URL.
        As far as I know, updateScriptObject() is the only place where we can safely
        obtain documentURL.
        (WebCore::InspectorResource::cachedResource):
        (WebCore::InspectorResource::type):
        (WebCore::InspectorResource::resourceData):
        * inspector/InspectorResource.h:
        (WebCore::InspectorResource::):
        (WebCore::InspectorResource::markWebSocket):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.Type.toString):
        (WebInspector.Resource.prototype.set type):
        (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.prototype._refreshRequestHeaders):
        (WebInspector.ResourceView.prototype._refreshResponseHeaders):
        (WebInspector.ResourceView.prototype._refreshHeaders):
        * inspector/front-end/inspector.css:
        (.resources-category-websockets, .resources-category-other):
        (.resources-category-websockets .resources-graph-bar):
        (.resources-category-websockets.resource-cached .resources-graph-bar):
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):
        (WebInspector.updateResource):
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::WebSocketChannel):
        (WebCore::WebSocketChannel::disconnect):
        (WebCore::WebSocketChannel::didOpen):
        (WebCore::WebSocketChannel::didClose):
        (WebCore::WebSocketChannel::processBuffer):
        (WebCore::WebSocketChannel::identifier):
        * websockets/WebSocketChannel.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Cosmin Truta <ctruta@chromium.org>
commit-queue@webkit.org [Tue, 27 Jul 2010 04:34:13 +0000 (04:34 +0000)]
2010-07-26  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Eric Seidel.

        Some SVGs with empty <g> elements crash Chromium on Linux
        https://bugs.webkit.org/show_bug.cgi?id=41175

        Remove the suppression of this bug's test on Chromium. The new fix in WebKit no longer requires
        an update in Chromium, making this test safe to expose.

        * platform/chromium/test_expectations.txt:
2010-07-26  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Eric Seidel.

        Some SVGs with empty <g> elements crash Chromium on Linux
        https://bugs.webkit.org/show_bug.cgi?id=41175

        Redo the old fix using a different approach, to avoid regressing
        svg/batik/filters/filterRegions.svg with Chromium on Linux.
        Specifically, handle empty SkBitmap objects by exiting early upon
        encountering unconfigured (i.e. empty) bitmaps.

        No new tests. This bug's old test (svg/filters/filter-empty-g.svg)
        and the above-mentioned regressed test are expected to pass.

        * WebCore/platform/graphics/skia/ImageBufferSkia.cpp:
        (ImageBuffer::ImageBuffer): Undo the old fix.
        (getImageData): The new fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 27 Jul 2010 03:43:10 +0000 (03:43 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Fix a couple of test results after r64095.

        * compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
        * compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRolling out r64097:64100, oops, more b0rked than I relized by my last changes, sorry!
barraclough@apple.com [Tue, 27 Jul 2010 02:53:06 +0000 (02:53 +0000)]
Rolling out r64097:64100, oops, more b0rked than I relized by my last changes, sorry!

* CMakeListsEfl.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::reprotectRegion):
(JSC::ExecutableAllocator::cacheFlush):
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
* jit/ExecutableAllocatorPosix.cpp: Added.
(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):
* jit/ExecutableAllocatorSymbian.cpp: Added.
(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):
* jit/ExecutableAllocatorWin.cpp: Added.
(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):
* wscript:
* wtf/PageAllocation.cpp: Removed.
* wtf/PageAllocation.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpeculative !debug build fix II.
barraclough@apple.com [Tue, 27 Jul 2010 02:39:12 +0000 (02:39 +0000)]
Speculative !debug build fix II.

* wtf/PageAllocation.h:
(WTF::PageAllocation::PageAllocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpeculative !debug build fix.
barraclough@apple.com [Tue, 27 Jul 2010 02:37:53 +0000 (02:37 +0000)]
Speculative !debug build fix.

* wtf/PageAllocation.h:
(WTF::PageAllocation::PageAllocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 43009 - Abstract out page allocation from executable allocators
barraclough@apple.com [Tue, 27 Jul 2010 02:12:40 +0000 (02:12 +0000)]
Bug 43009 - Abstract out page allocation from executable allocators

Reviewed by Oliver Hunt.

It would be great to have a single platform abstraction for block allocation, rather than copy/paste code.

In this initial implementation I've made Symbian fall back to use malloc/free for non-executable memory.
I think this will match current behaviour for the next client we will want to port across (RegisterFile &
Collector).

* CMakeListsEfl.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
* jit/ExecutableAllocatorPosix.cpp: Removed.
* jit/ExecutableAllocatorSymbian.cpp: Removed.
* jit/ExecutableAllocatorWin.cpp: Removed.
* wscript:
* wtf/PageAllocator.cpp: Added.
(WTF::protection):
(WTF::PageAllocation::commit):
(WTF::PageAllocation::decommit):
(WTF::PageAllocator::allocate):
(WTF::PageAllocator::reserve):
(WTF::PageAllocator::deallocate):
(WTF::PageAllocator::pagesize):
* wtf/PageAllocator.h: Added.
(WTF::PageAllocation::PageAllocation):
(WTF::PageAllocation::base):
(WTF::PageAllocation::size):
(WTF::PageAllocation::chunk):
(WTF::PageAllocation::operator!):
(WTF::PageAllocator::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Tue, 27 Jul 2010 02:10:17 +0000 (02:10 +0000)]
2010-07-26  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Move CMakeListsEfl.txt to WebKit/efl/
        https://bugs.webkit.org/show_bug.cgi?id=43002

        This should reduce the noise in WebKit/ChangeLog that comes from EFL
        port. Most of the changes on EFL port should be logged in
        WebKit/efl/ChangeLog.

        * CMakeLists.txt: Just change the path from where to include the file.
2010-07-26  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Move CMakeListsEfl.txt to WebKit/efl/
        https://bugs.webkit.org/show_bug.cgi?id=43002

        This should reduce the noise in WebKit/ChangeLog that comes from EFL
        port. Most of the changes on EFL port should be logged in
        WebKit/efl/ChangeLog.

        * CMakeListsEfl.txt: Renamed from WebKit/CMakeListsEfl.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKitTestRunner needs to support layoutTestController.counterValueForElementById
darin@apple.com [Tue, 27 Jul 2010 01:17:48 +0000 (01:17 +0000)]
WebKitTestRunner needs to support layoutTestController.counterValueForElementById
https://bugs.webkit.org/show_bug.cgi?id=42537

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.markerTextForListItem
https://bugs.webkit.org/show_bug.cgi?id=42549

WebKit2:

* UIProcess/API/C/WKString.cpp:
(WKStringIsEmpty): Added.
* UIProcess/API/C/WKString.h: Added WKStringIsEmpty.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(copiedString): Added. Helper for functions that return a
WKStringRef that follows the copy rule.
(WKBundleFrameCopyName): Use copiedString.
(WKBundleFrameCopyCounterValue): Added. Calls counterValue.
(WKBundleFrameCopyMarkerText): Added. Calls markerText.
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
Added WKBundleFrameCopyCounterValue and WKBundleFrameCopyMarkerText.

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::computedStyleIncludingVisitedInfo):
Renamed argument to streamline function a bit.
(WebKit::WebFrame::counterValue): Added.
(WebKit::WebFrame::markerText): Added.
* WebProcess/WebPage/WebFrame.h: Added counterValue and markerText.

WebKitTools:

* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
Fixed _paramterExpression typo. Improved support for string type as a
return value, so we don't try to include DOMString.h and we can convert
the string to a JSValue by calling JSValueMakeStringOrNull.

* WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
Added JSValueMakeStringOrNull, used by the code generator.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Added counterValueForElementById and markerTextForListItem.

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
Moved constant to the top of the file.
(WTR::toCF): Added. Converts strings to CFStringRef.
(WTR::toWK): Added. Converts strings to WKStringRef.
(WTR::toJS): Added. Converts strings to JSStringRef.
(WTR::setProperty): Moved this function to the top of the file
rather than having it down where it's used inside the class. Also
renamed it so it's a separate function rather than an overload of
JSObjectSetProperty.
(WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
Should move it somewhere we can share it.
(WTR::propertyObject): Ditto.
(WTR::getElementById): Added. Calls getElementById through the magic
of JavaScript.
(WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
Chagned to use toWK instead of four local variables.
(WTR::LayoutTestController::counterValueForElementById): Added.
Calls WKBundleFrameCopyCounterValue.
(WTR::LayoutTestController::markerTextForListItem): Added.
Calls WKBundleFrameCopyMarkerText.

* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
Added counterValueForElementById and markerTextForListItem.

LayoutTests:

* platform/mac-wk2/Skipped: Removed tests that were failing due to one of the above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 27 Jul 2010 00:21:41 +0000 (00:21 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Google image search results broken on pages with Flash
        https://bugs.webkit.org/show_bug.cgi?id=43014

        The test for overflow added in r63452 is wrong in that it ignores the effects
        of positioning on overflow.

        The correct approach is to start by using RenderView's layoutOverflowRect as the largest bounds,
        then getting the oveflow rect via backgroundClipRect() relative to the root layer.

        Test: compositing/geometry/limit-layer-bounds-overflow-root.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::layerOrAncestorIsTransformed):
        (WebCore::RenderLayerBacking::updateCompositedBounds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPlug-in views should be able to return JSObjects directly
andersca@apple.com [Tue, 27 Jul 2010 00:09:07 +0000 (00:09 +0000)]
Plug-in views should be able to return JSObjects directly
https://bugs.webkit.org/show_bug.cgi?id=43019

Reviewed by Sam Weinig.

* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::putDelegate):
(WebCore::JSHTMLAppletElement::getCallData):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::putDelegate):
(WebCore::JSHTMLEmbedElement::getCallData):
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::putDelegate):
(WebCore::JSHTMLObjectElement::getCallData):
runtimeObjectCustomPut and runtimeObjectGetCallData now take a JSHTMLElement instead of a HTMLElement.

* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginScriptObject):
First, ask the PluginViewBase for a JSObject and fall back to getting the JSObject from the instance.

(WebCore::runtimeObjectPropertyGetter):
(WebCore::runtimeObjectCustomGetOwnPropertySlot):
(WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):
Call pluginScriptObject.

(WebCore::runtimeObjectCustomPut):
Change to take a JSHTMLElement. Call pluginScriptObject.

(WebCore::runtimeObjectGetCallData):
Change to take a JSHTMLElement.

* bridge/jsc/BridgeJSC.cpp:
* bridge/jsc/BridgeJSC.h:
(JSC::Bindings::Instance::createRuntimeObject):
Change this to return a JSObject.

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::getInstance):
Call pluginWidget.

(WebCore::HTMLPlugInElement::pluginWidget):
Return the plug-in widget for this element.

* html/HTMLPlugInElement.h:
* plugins/PluginViewBase.h:
(WebCore::PluginViewBase::scriptObject):
Add default implementation of scriptObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Dominic Mazzoni <dmazzoni@google.com>
commit-queue@webkit.org [Tue, 27 Jul 2010 00:01:07 +0000 (00:01 +0000)]
2010-07-26  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Chris Fleizach.

        Add accessor to get the doctype of a WebDocument, needed to
        implement Windows accessibility.

        https://bugs.webkit.org/show_bug.cgi?id=43003

        * WebKit.gyp:
        * public/WebDocument.h:
        * public/WebDocumentType.h: Added.
        (WebKit::WebDocumentType::WebDocumentType):
        (WebKit::WebDocumentType::operator=):
        (WebKit::WebDocumentType::assign):
        * src/WebDocument.cpp:
        (WebKit::WebDocument::doctype):
        * src/WebDocumentType.cpp: Added.
        (WebKit::WebDocumentType::name):
        (WebKit::WebDocumentType::WebDocumentType):
        (WebKit::WebDocumentType::operator=):
        (WebKit::WebDocumentType::operator PassRefPtr<DocumentType>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPart 2 of https://bugs.webkit.org/show_bug.cgi?id=43013
weinig@apple.com [Tue, 27 Jul 2010 00:00:51 +0000 (00:00 +0000)]
Part 2 of https://bugs.webkit.org/show_bug.cgi?id=43013
<rdar://problem/8152434>
Add support for scrolling using the keyboard in WebKit2

Reviewed by Anders Carlsson.

Add support for scrolling with the space bar and ensure that we don't scroll
if WebCore is handling the event in another way.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::keyEvent):
(WebKit::getScrollMapping):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX: Safari does not support ARIA mixed checkboxes
cfleizach@apple.com [Mon, 26 Jul 2010 23:33:31 +0000 (23:33 +0000)]
AX: Safari does not support ARIA mixed checkboxes
https://bugs.webkit.org/show_bug.cgi?id=43016

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/mixed-checkbox.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::checkboxOrRadioValue):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityRenderObject::checkboxOrRadioValue):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

* platform/mac/accessibility/mixed-checkbox-expected.txt: Added.
* platform/mac/accessibility/mixed-checkbox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Shimeng (Simon) Wang <swang@google.com>
commit-queue@webkit.org [Mon, 26 Jul 2010 23:11:55 +0000 (23:11 +0000)]
2010-07-26  Shimeng (Simon) Wang  <swang@google.com>

        Reviewed by Darin Adler.

        Add android specific expected test results for auto hyphenation
        tests.

        * platform/android: Added.
        * platform/android/fast: Added.
        * platform/android/fast/text: Added.
        * platform/android/fast/text/hyphenate-character-expected.txt: Added.
        * platform/android/fast/text/hyphens-expected.txt: Added.
2010-07-26  Shimeng (Simon) Wang  <swang@google.com>

        Reviewed by Darin Adler.

        Add auto hyphenation support for Android.
        https://bugs.webkit.org/show_bug.cgi?id=42800

        * platform/text/android/HyphenationAndroid.cpp: Added.
        (WebCore::loadHyphenationDictionary):
        (WebCore::lastHyphenLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=43013
weinig@apple.com [Mon, 26 Jul 2010 23:06:34 +0000 (23:06 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=43013
Part of <rdar://problem/8152434>
Add support for scrolling using the keyboard in WebKit2

Reviewed by Anders Carlsson.

WebCore:

Add a new export and make WindowsKeyboardCodes private.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:

WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::getScrollMapping):
(WebKit::WebPage::keyEvent):
Scroll the page in response to keyDown.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
Use WindowsKeyboardCodes.h instead of redefining the constants.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 Jul 2010 22:58:33 +0000 (22:58 +0000)]
2010-07-26  Darin Adler  <darin@apple.com>

        Reviewed by Eric Carlson.

        Don't handle empty URL attributes specially in reflection, even in cases such as <img src="">
        https://bugs.webkit.org/show_bug.cgi?id=42087

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::insertedIntoDocument): Check if the src attribute is empty
        by calling getAttribute instead of calling the src function. This keeps the behavior
        correct with the reflection change, and has a side benefit of being more efficient as
        well since there is no reason to resolve the URL.
        (WebCore::HTMLMediaElement::loadResource): Call getNonEmptyURLAttribute directly here
        instead of using the poster function.
        (WebCore::HTMLMediaElement::getPluginProxyParams): Ditto.

        * html/HTMLMediaElement.h: Removed the poster virtual function. The code that gets the
        poster attribute is already video-specific and uses generic attribute fetching code, so
        we no longer need a virtual function. Removed the src function. Since this would give
        a different result from the JavaScript reflected src attribute, it's safer not to have
        it, and it was easy to convert all the callers.

        * html/HTMLMediaElement.idl: Removed the NonEmpty extended attribute from the src
        attribute.

        * html/HTMLSourceElement.cpp: Removed the src function for the same reason as above.
        * html/HTMLSourceElement.h: Ditto.

        * html/HTMLSourceElement.idl: Removed the NonEmpty extended attribute from the src
        attribute.

        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::parseMappedAttribute): Removed code to update m_posterURL,
        which is no longer needed. Changed call site that used the poster() function to instead
        use getNonEmptyURLAttribute.
        (WebCore::HTMLVideoElement::updatePosterImage): Check if the poster attribute is empty
        by calling getAttribute instead of calling the poster function. This keeps the behavior
        correct with the reflection change, and has a side benefit of being more efficient as
        well since there is no reason to resolve the URL.

        * html/HTMLVideoElement.h: Removed the poster function for the same reason we removed
        the src function above. Also removed now-unneeded m_posterURL data member.

        * html/HTMLVideoElement.idl: Removed the NonEmpty extended attribute from the poster
        attribute.
2010-07-26  Darin Adler  <darin@apple.com>

        Reviewed by Eric Carlson.

        Don’t handle empty URL attributes specially in reflection, even in cases such as <img src="">
        https://bugs.webkit.org/show_bug.cgi?id=42087

        * fast/dom/URL-attribute-reflection-expected.txt: Updated.
        * fast/dom/script-tests/URL-attribute-reflection.js: Updated test expectations so that even
        for URLs where "" is invalid, we reflect the empty string resolved to the base URL.

        * media/video-poster-expected.txt: Updated.
        * media/video-poster.html: Updated to expect poster="" to reflect as the base URL.
        * media/video-source-error-no-candidate-expected.txt: Updated.
        * media/video-src-none-expected.txt: Updated.
        * media/video-src-none.html: Updated to expect src="" to reflect as the base URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX: remove intValue() hasIntValue() from AccessibilityObject
cfleizach@apple.com [Mon, 26 Jul 2010 22:49:18 +0000 (22:49 +0000)]
AX: remove intValue() hasIntValue() from AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=43006

Reviewed by Darin Adler.

These methods are very Mac centric. The mac centric code should be moved into the Mac wrapper.

No new tests, existing tests cover changes to logic.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::checkboxOrRadioValue):
* accessibility/AccessibilityObject.h:
(WebCore::):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::selectedRadioButton):
(WebCore::AccessibilityRenderObject::selectedTabItem):
(WebCore::AccessibilityRenderObject::checkboxOrRadioValue):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoApplying inline style to a text node whose parent is an inline editable root causes...
rniwa@webkit.org [Mon, 26 Jul 2010 22:47:21 +0000 (22:47 +0000)]
Applying inline style to a text node whose parent is an inline editable root causes crash
https://bugs.webkit.org/show_bug.cgi?id=39989

Reviewed by Darin Adler.

WebCore:

The crash was caused by splitTextElementAtStart and splitTextElementAtEnd assuming that the parent
and the grandparent of the specified text node is editable.

Modified splitTextElementAtStart and splitTextElementAtEnd so that they call splitTextAtStart
and splitTextAtEnd respectively when the grandparent is not editable.

Also modified SplitTextNodeContainingElement to exit early if the grandparent of m_text is not editable.

Test: editing/style/style-text-node-without-editable-parent.html

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::splitTextElementAtStart):
(WebCore::ApplyStyleCommand::splitTextElementAtEnd):
* editing/SplitTextNodeContainingElementCommand.cpp:
(WebCore::SplitTextNodeContainingElementCommand::doApply):

LayoutTests:

Added a test to apply inline styles to a text node which is a editable root's child.
The test should not crash.

Two tests require rebaseline for the editing delegates. However, the final selection is kept same.

* editing/execCommand/hilitecolor-expected.txt:
* editing/style/remove-underline-from-stylesheet-expected.txt:
* editing/style/style-text-node-without-editable-parent-expected.txt: Added.
* editing/style/style-text-node-without-editable-parent.html: Added.
* resources/dump-as-markup.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 26 Jul 2010 22:34:49 +0000 (22:34 +0000)]
2010-07-26  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] The EventSender should support simulating drop events
        https://bugs.webkit.org/show_bug.cgi?id=39844

        Unskip tests that are now passing and add baselines for new tests. Re-organize
        remaining failures so they can be unskipped more easily in the future.

        * platform/gtk/Skipped:
        * platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt: Added.
        * platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt: Added.
        * platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt: Added.
        * platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt: Added.
        * platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt: Added.
        * platform/gtk/editing/selection/drag-select-1-expected.txt: Added.
        * platform/gtk/editing/selection/drag-text-delay-expected.txt: Added.
        * platform/gtk/fast/events/bogus-dropEffect-effectAllowed-expected.txt: Removed.
        * platform/gtk/fast/forms/input-text-drag-down-expected.txt: Added.
        * platform/gtk/fast/lists/drag-into-marker-expected.txt: Added.
2010-07-26  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] The EventSender should support simulating drop events
        https://bugs.webkit.org/show_bug.cgi?id=39844

        Add initial dropping support to the GTK+ EventSender.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (createWebView): Listen for some new drag-and-drop signals.
        * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
        (dispatchEvent):
        Detect situations where a drag is either starting or ending and massage
        GTK+ into sending the appropriate signals to the WebView.
        (replaySavedEvents): Remove comment.
        (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
        (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
        (dragEndCallback): Clear the currentDragSourceContext when a drag ends.
        (dragFailedCallback): Disable the GTK+ drag failed animation.
        * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Mon, 26 Jul 2010 22:23:37 +0000 (22:23 +0000)]
2010-07-26  Victor Wang  <victorw@chromium.org>

        Unreviewed. Update chromium test expectations for flaky test on linux:
        tables/mozilla_expected_failures/bugs/bug89315.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 26 Jul 2010 22:11:13 +0000 (22:11 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Fix tests on Leopard.

        No need for these Leopard-specific results any more.

        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
        * platform/mac-leopard/compositing/iframes/iframe-resize-expected.txt: Removed.
        * platform/mac-leopard/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
        * platform/mac-leopard/compositing/iframes/overlapped-iframe-expected.txt: Removed.
        * platform/mac-leopard/compositing/iframes/scrolling-iframe-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix Windows build.
adachan@apple.com [Mon, 26 Jul 2010 22:03:31 +0000 (22:03 +0000)]
    Fix Windows build.

        * win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 26 Jul 2010 21:41:41 +0000 (21:41 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Gmail compose is upside-down after r64054
        https://bugs.webkit.org/show_bug.cgi?id=43000

        We need to call setGeometryOrientation() whenever the iframe compositing layer attachment changes,
        not just when requiresScrollLayer() returns false. This ensures that the orientation is updated
        correctly.

        Test: compositing/iframes/iframe-content-flipping.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Mon, 26 Jul 2010 21:36:47 +0000 (21:36 +0000)]
2010-07-26  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Fisher.

        Check history state against origin before setting
        https://bugs.webkit.org/show_bug.cgi?id=42858

        Tests: fast/loader/stateobjects/replacestate-base-illegal.html
               fast/loader/stateobjects/replacestate-base-legal.html

        * page/History.cpp:
        (WebCore::History::urlForState):
        (WebCore::History::stateObjectAdded):
2010-07-26  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Fisher.

        Check history state when base URL is changed
        https://bugs.webkit.org/show_bug.cgi?id=42858

        * fast/loader/stateobjects/replacestate-base-illegal-expected.txt: Added.
        * fast/loader/stateobjects/replacestate-base-illegal.html: Added.
        * fast/loader/stateobjects/replacestate-base-legal-expected.txt: Added.
        * fast/loader/stateobjects/replacestate-base-legal.html: Added.
        * fast/loader/stateobjects/resources/replacestate-base-pass.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Windows build.
andersca@apple.com [Mon, 26 Jul 2010 21:33:28 +0000 (21:33 +0000)]
Fix Windows build.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 26 Jul 2010 21:32:18 +0000 (21:32 +0000)]
2010-07-26  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Get rid of libgdom
        https://bugs.webkit.org/show_bug.cgi?id=42378

        Remove the need to build the libgdom intermediate library.

        * GNUmakefile.am: Move the source list for the GObject DOM bindings to
        the top-level GNUmakefile.am, since they are logically part of WebKit, instead
        of WebCore. List all auto-generated files statically and remove no-longer-
        used variables. Fix an issue where some places expected webkitenumtypes.cpp
        to be generated in different directories.
2010-07-26  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Get rid of libgdom
        https://bugs.webkit.org/show_bug.cgi?id=42378

        Remove all build steps for building GObject DOM bindings.

        * GNUmakefile.am: Remove GObject DOM bindings build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDisable a test that was added to verify the vendor prefix change that I rolled out...
mrowe@apple.com [Mon, 26 Jul 2010 21:20:47 +0000 (21:20 +0000)]
Disable a test that was added to verify the vendor prefix change that I rolled out in r64071.
It can be reenabled when the vendor prefix change is reintroduced in a more limited fashion.

* fast/css/limited-vendor-prefix-behavior.html-disabled: Renamed from LayoutTests/fast/css/limited-vendor-prefix-behavior.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoHandle mouseenter/mouseleave + focus events
andersca@apple.com [Mon, 26 Jul 2010 21:15:27 +0000 (21:15 +0000)]
Handle mouseenter/mouseleave + focus events
https://bugs.webkit.org/show_bug.cgi?id=42997

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::handleMouseEnterEvent):
Call platformHandleMouseEnterEvent.

(WebKit::NetscapePlugin::handleMouseLeaveEvent):
Call platformHandleMouseExitEvent.

(WebKit::NetscapePlugin::setFocus):
Call platformSetFocus.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::fillInCocoaEventFromMouseEvent):
Factor out code that fills in an NPCocoaEvent from a WebMouseEvent.

(WebKit::initializeMouseEvent):
Call fillInCocoaEventFromMouseEvent.

(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
Send an NPCocoaEventMouseEntered event.

(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Send an NPCocoaEventMouseExited event.

(WebKit::NetscapePlugin::platformSetFocus):
Send an NPCocoaEventFocusChanged.

* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent):
Dispatch mouse enter and mouse leave events. Call focusPluginElement on mousedown.

(WebKit::PluginView::focusPluginElement):
Focus the plug-in's containing frame and its element.

(WebKit::PluginView::setFocus):
Call Plugin::setFocus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Mon, 26 Jul 2010 20:58:03 +0000 (20:58 +0000)]
2010-07-26  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        svn-unapply warns of uninitialized variable when unapplying
        a patch that describes an svn move operation
        https://bugs.webkit.org/show_bug.cgi?id=42036

        Fixes Perl uninitialized variable warnings when un-applying
        a patch that moves a file.

        * Scripts/svn-unapply:
          - Modified patch() so that it initializes $patch to the empty
            string when we don't have svnConvertedText (such as when
            reversing a diff that represents a svn copy/move operation).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<http://webkit.org/b/42990> REGRESSION (r63854): Safari RSS layout is broken due...
mrowe@apple.com [Mon, 26 Jul 2010 20:53:02 +0000 (20:53 +0000)]
<webkit.org/b/42990> REGRESSION (r63854): Safari RSS layout is broken due to changes in vendor prefix handling

Reviewed by Dan Bernstein.

In r63854 support for properties with the -khtml vendor prefix was removed. This breaks the layout of
Safari's RSS interface, several Dashboard widgets that are included with Mac OS X, and at least one
popular third-party Mac OS X application. This change will need to be revisited in a manner that has
a clearer backwards-compatibility strategy. <http://webkit.org/b/42093> will be reopened to track that.

* css/CSSParser.cpp:
(WebCore::cssPropertyID): Revert the WebCore change from r63854.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 26 Jul 2010 20:37:56 +0000 (20:37 +0000)]
2010-07-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        Add ability for WK2 to register a scheme to always be displayed as an empty document
        https://bugs.webkit.org/show_bug.cgi?id=42995

        No new tests. (Currently not possible to test in WebKit1 DRT, can be testing in future WK2 tester)

        * WebCore.exp.in:

        * loader/MainResourceLoader.cpp:
        (WebCore::shouldLoadAsEmptyDocument):

        * platform/SchemeRegistry.cpp:
        (WebCore::emptyDocumentSchemes):
        (WebCore::SchemeRegistry::registerURLSchemeAsEmptyDocument):
        (WebCore::SchemeRegistry::shouldLoadURLSchemeAsEmptyDocument):
        * platform/SchemeRegistry.h:
2010-07-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        Add ability for WK2 to register a scheme to always be displayed as an empty document
        https://bugs.webkit.org/show_bug.cgi?id=42995

        * Shared/CoreIPCSupport/WebProcessMessageKinds.h:
        (WebProcessMessage::):

        * UIProcess/API/C/WKContext.cpp:
        (_WKContextRegisterURLSchemeAsEmptyDocument):
        * UIProcess/API/C/WKContextPrivate.h:

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::registerURLSchemeAsEmptyDocument):
        * UIProcess/WebContext.h:

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::registerURLSchemeAsEmptyDocument):
        (WebKit::WebProcess::didReceiveMessage):
        * WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
victorw@chromium.org [Mon, 26 Jul 2010 20:16:44 +0000 (20:16 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Fix compositing iframe tests on Leopard.

        Add Leopard-specific results where geometry flipping causes a different test output.

        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/iframe-resize-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/overlapped-iframe-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/scrolling-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoGet rid of the dummy plug-in.
andersca@apple.com [Mon, 26 Jul 2010 20:16:09 +0000 (20:16 +0000)]
Get rid of the dummy plug-in.

Reviewed by Adam Roben.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Plugins/DummyPlugin.cpp: Removed.
* WebProcess/Plugins/DummyPlugin.h: Removed.
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove some non-APIish functions into private headers.
weinig@apple.com [Mon, 26 Jul 2010 20:09:20 +0000 (20:09 +0000)]
Move some non-APIish functions into private headers.

Reviewed by Anders Carlsson.

WebKit2:

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
* WebProcess/InjectedBundle/API/c/WKBundle.h:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: Copied from WebProcess/InjectedBundle/API/c/WKBundleFrame.h.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Copied from WebProcess/InjectedBundle/API/c/WKBundle.h.
* win/WebKit2.vcproj:

WebKitTools:

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 26 Jul 2010 19:57:18 +0000 (19:57 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Fix compositing iframe tests on Leopard.

        Add Leopard-specific results where geometry flipping causes a different test output.

        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/iframe-resize-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/overlapped-iframe-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/scrolling-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=42986
weinig@apple.com [Mon, 26 Jul 2010 19:57:04 +0000 (19:57 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
Add prompt and confirm client functions to WebKit2

Reviewed by Anders Carlsson.

WebKit2:

* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
(WebPageProxyMessage::):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveSyncMessage):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):
* UIProcess/WebPageProxy.h:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::runJavaScriptAlert):
(WebKit::WebUIClient::runJavaScriptConfirm):
(WebKit::WebUIClient::runJavaScriptPrompt):
* UIProcess/WebUIClient.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDeliver mouse and wheel events to plug-ins
andersca@apple.com [Mon, 26 Jul 2010 19:41:59 +0000 (19:41 +0000)]
Deliver mouse and wheel events to plug-ins
https://bugs.webkit.org/show_bug.cgi?id=42988

Reviewed by Sam Weinig.

* Shared/WebEvent.h:
(WebKit::WebMouseEvent::WebMouseEvent):
(WebKit::WebMouseEvent::deltaX):
(WebKit::WebMouseEvent::deltaY):
(WebKit::WebMouseEvent::deltaZ):
* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebMouseEvent):
Add deltaX, deltaY and deltaZ member variables to WebMosueEvent.

* WebKit2.xcodeproj/project.pbxproj:
Rename NetscapePluginMac.cpp to NetscapePluginMac.mm.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NPP_HandleEvent):
Add NPP_ wrapper.

(WebKit::NetscapePlugin::handleMouseEvent):
(WebKit::NetscapePlugin::handleWheelEvent):
Call the platform variants.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Added.
(WebKit::modifierFlags):
(WebKit::buttonNumber):
(WebKit::initializeMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
Create an NPCocoaEvent and send it to the plug-in.

(WebKit::NetscapePlugin::platformHandleWheelEvent):
Ditto.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent):
Get the current WebEvent and send it to the plug-in if necessary.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::currentEvent):
(WebKit::CurrentEvent::CurrentEvent):
(WebKit::CurrentEvent::~CurrentEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):
* WebProcess/WebPage/WebPage.h:
Add RAII object for keeping track of the current event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Mon, 26 Jul 2010 19:30:38 +0000 (19:30 +0000)]
2010-07-26  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kent Tamura.

        [WINCE] Port ClipboardUtilities to WinCE
        https://bugs.webkit.org/show_bug.cgi?id=42929

        Make ClipboardUtilitiesWin more portable and remove the global namespace prefix
        from GlobalLock/GlobalUnlock, since they are only macros on WinCE.

        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::urlFromPath):
        (WebCore::getWebLocData):
        (WebCore::createGlobalData):
        (WebCore::getURL):
        (WebCore::getPlainText):
        (WebCore::fragmentFromHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Mon, 26 Jul 2010 19:22:07 +0000 (19:22 +0000)]
2010-07-26  Victor Wang  <victorw@chromium.org>

        Unreviewed. Update chromium test expectations fro flaky test.

        https://bugs.webkit.org/show_bug.cgi?id=42989

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Mon, 26 Jul 2010 19:10:59 +0000 (19:10 +0000)]
2010-07-26  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Buildfix for BitmapImage.h
        https://bugs.webkit.org/show_bug.cgi?id=42931

        Use AffineTransform insted of TransformationMatrix.

        * platform/graphics/BitmapImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix
aroben@apple.com [Mon, 26 Jul 2010 18:57:13 +0000 (18:57 +0000)]
Windows build fix

WebKit2:

* win/WebKit2.vcproj:
* win/WebKit2WebProcess.vcproj:
Removed empty attributes so the values will be picked up from the
vsprops files. (Also removed a couple of attributes that accidentally
duplicated values from the vsprops files.)

WebKitTools:

* MiniBrowser/MiniBrowser.vcproj:
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
Removed empty attributes so the values will be picked up from the
vsprops files. (Also removed a couple of attributes that accidentally
duplicated values from the vsprops files.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 26 Jul 2010 18:41:24 +0000 (18:41 +0000)]
2010-07-26  Dirk Schulze  <krit@webkit.org>

        Unreviewed sort of XCode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<http://webkit.org/b/42982> Streamline Inspector Source build phase script should...
ddkilzer@apple.com [Mon, 26 Jul 2010 18:32:01 +0000 (18:32 +0000)]
<webkit.org/b/42982> Streamline Inspector Source build phase script should use CONFIGURATION not BUILD_STYLE
<rdar://problem/6341764>

Reviewed by Mark Rowe.

* WebCore.xcodeproj/project.pbxproj: Switched Streamline
Inspector Source build phase script to use CONFIGURATION instead
of BUILD_STYLE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-23 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 26 Jul 2010 18:28:41 +0000 (18:28 +0000)]
2010-07-23  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        crash in insertParagraph in a contentEditable list
        https://bugs.webkit.org/show_bug.cgi?id=42919

        * editing/execCommand/crash-on-enter-in-contentEditable-list-expected.txt: Added.
        * editing/execCommand/crash-on-enter-in-contentEditable-list.html: Added.
2010-07-23  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        crash in insertParagraph in a contentEditable list
        https://bugs.webkit.org/show_bug.cgi?id=42919

        Don't try to break out of a list item if the list it's in
        is the rootEditableElement.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 26 Jul 2010 18:15:05 +0000 (18:15 +0000)]
2010-07-26  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Moves IDBKeyRange to use IDBKey rather than SerializedScriptValue / IDBAny.
        https://bugs.webkit.org/show_bug.cgi?id=42583

        Tests: existing storage/indexeddb/idb-keyrange.html must pass.

        * storage/IDBKeyRange.cpp:
        (WebCore::IDBKeyRange::IDBKeyRange):
        * storage/IDBKeyRange.h:
        (WebCore::IDBKeyRange::create):
        (WebCore::IDBKeyRange::left):
        (WebCore::IDBKeyRange::right):
        * storage/IDBKeyRange.idl:
        * storage/IndexedDatabaseRequest.cpp:
        (WebCore::IndexedDatabaseRequest::makeSingleKeyRange):
        (WebCore::IndexedDatabaseRequest::makeLeftBoundKeyRange):
        (WebCore::IndexedDatabaseRequest::makeRightBoundKeyRange):
        (WebCore::IndexedDatabaseRequest::makeBoundKeyRange):
        * storage/IndexedDatabaseRequest.h:
        * storage/IndexedDatabaseRequest.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 26 Jul 2010 17:48:13 +0000 (17:48 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Composited layers don't scroll in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=42771

        Rename two methods on RenderLayerCompositor to make their use more clear, and call them
        when the FrameView gets resized and scrolled.

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::setFrameRect): override so we know when the size of the FrameView changes, so that the
        RenderLayerCompositor can update its clipping layer.
        (WebCore::FrameView::scrollPositionChanged): Call compositor()->frameViewDidScroll().

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateAfterWidgetResize): updateContentLayerOffset() was renamed.

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::frameViewDidChangeSize): Renamed from updateContentLayerOffset().
        (WebCore::RenderLayerCompositor::frameViewDidScroll): Renamed from updateContentLayerScrollPosition().
        (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Propagate compositing on Mac
        for any FrameView that doesn't have a native widget, which is the case with WebKit2.
        (WebCore::RenderLayerCompositor::requiresScrollLayer): New method to tell us whether we need to handle
        scrolling (and clipping) ourselves.
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Do geometry flipping on the root platform
        layer only if we're not doing our own scrolling, and use the new requiresScrollLayer() method.
        (WebCore::RenderLayerCompositor::attachRootPlatformLayer): Send out the rootPlatformLayer(),
        so that it returns the clipping layer if we have one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 26 Jul 2010 17:37:50 +0000 (17:37 +0000)]
2010-07-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Ojan Vafai.

        Rename indexedDB tests to match new scheme
        https://bugs.webkit.org/show_bug.cgi?id=42375

        No changes to the tests themselves.

        * storage/indexeddb/script-tests/basics.js: Added.
        (openCallback):
        (test):
        * storage/indexeddb/script-tests/database-basics.js: Added.
        (openSuccess):
        (test):
        * storage/indexeddb/script-tests/idb-database-request.js: Removed.
        * storage/indexeddb/script-tests/idb-objectstore-request.js: Removed.
        * storage/indexeddb/script-tests/indexed-database-request.js: Removed.
        * storage/indexeddb/script-tests/keyrange.js: Renamed from LayoutTests/storage/indexeddb/script-tests/idb-keyrange.js.
        (checkSingleKeyRange):
        (checkLeftBoundKeyRange):
        ():
        * storage/indexeddb/script-tests/objectstore-basics.js: Added.
        (test):
        (openSuccess):
        (createSuccess):
        (addSuccess):
        (getSuccess):
        (removeSuccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTouch MiniBrowser's stdafx to fix the build.
bweinstein@apple.com [Mon, 26 Jul 2010 17:11:18 +0000 (17:11 +0000)]
Touch MiniBrowser's stdafx to fix the build.

Rubber-stamped by Adam Roben.

* MiniBrowser/win/stdafx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Mon, 26 Jul 2010 17:03:35 +0000 (17:03 +0000)]
2010-07-26  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Fisher.

        Move DocumentLoadTiming struct to a new file
        https://bugs.webkit.org/show_bug.cgi?id=42917

        Also makes DocumentLoadTiming Noncopyable.

        No new tests because no new functionality.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/DocumentLoadTiming.h: Added.
        (WebCore::DocumentLoadTiming::DocumentLoadTiming):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        * loader/FrameLoaderTypes.h:
        * loader/MainResourceLoader.cpp:
        * page/Timing.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoClean up event handling functions
andersca@apple.com [Mon, 26 Jul 2010 17:03:31 +0000 (17:03 +0000)]
Clean up event handling functions
https://bugs.webkit.org/show_bug.cgi?id=42977

Reviewed by Sam Weinig.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix an #if in WebCore.exp.in to correctly detect whether SVG filters are enabled.
mrowe@apple.com [Mon, 26 Jul 2010 16:24:18 +0000 (16:24 +0000)]
Fix an #if in WebCore.exp.in to correctly detect whether SVG filters are enabled.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Steve Block <steveblock@google.com>
steveblock@google.com [Mon, 26 Jul 2010 16:01:30 +0000 (16:01 +0000)]
2010-07-26  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        DeviceOrientation event listeners should never be called synchronously from addEventListener()
        https://bugs.webkit.org/show_bug.cgi?id=42304

        No new tests as there are currently no implementations to test. Tests will be
        added once LayoutTestController methods for providing a mock implementation are
        in place, see Bug 39589.

        * dom/DeviceOrientationController.cpp:
        (WebCore::DeviceOrientationController::DeviceOrientationController):
        (WebCore::DeviceOrientationController::timerFired):
        (WebCore::DeviceOrientationController::addListener):
        (WebCore::DeviceOrientationController::removeListener):
        (WebCore::DeviceOrientationController::removeAllListeners):
        * dom/DeviceOrientationController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Mon, 26 Jul 2010 15:56:50 +0000 (15:56 +0000)]
2010-07-26  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Canvas: Optimize GraphicsContext::addPath()

        Avoid "deep concatenating" the canvas path onto the GC path
        if the GC path has no elements.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::addPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-23 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Mon, 26 Jul 2010 15:43:55 +0000 (15:43 +0000)]
2010-07-23  Stephen White  <senorblanco@chromium.org>

        Reviewed by Darin Fisher.

        Implement OpenGLES2 helper classes.
        https://bugs.webkit.org/show_bug.cgi?id=42905

        GLES2Canvas and GLES2Texture are some simple OpenGLES2 helper classes
        for managing state, samplers and textures.

        When this is hooked up, it will be covered by many layout tests.

        * WebCore.gypi:
        Add new files to chromium build (contents are protected by #if's for now).
        * platform/graphics/chromium/GLES2Canvas.cpp: Added.
        (WebCore::affineTo3x3):
        (WebCore::GLES2Canvas::State::State):
        (WebCore::GLES2Canvas::GLES2Canvas):
        (WebCore::GLES2Canvas::~GLES2Canvas):
        (WebCore::GLES2Canvas::clearRect):
        (WebCore::GLES2Canvas::fillRect):
        (WebCore::GLES2Canvas::setFillColor):
        (WebCore::GLES2Canvas::setAlpha):
        (WebCore::GLES2Canvas::translate):
        (WebCore::GLES2Canvas::rotate):
        (WebCore::GLES2Canvas::scale):
        (WebCore::GLES2Canvas::concatCTM):
        (WebCore::GLES2Canvas::save):
        (WebCore::GLES2Canvas::restore):
        (WebCore::GLES2Canvas::drawTexturedRect):
        (WebCore::GLES2Canvas::setCompositeOperation):
        (WebCore::GLES2Canvas::applyCompositeOperator):
        (WebCore::GLES2Canvas::getQuadVertices):
        (WebCore::GLES2Canvas::getQuadIndices):
        (WebCore::loadShader):
        (WebCore::GLES2Canvas::getSimpleProgram):
        (WebCore::GLES2Canvas::getTexProgram):
        (WebCore::GLES2Canvas::createTexture):
        (WebCore::GLES2Canvas::getTexture):
        (WebCore::GLES2Canvas::checkGLError):
        * platform/graphics/chromium/GLES2Canvas.h: Added.
        (WebCore::GLES2Canvas::gles2Context):
        * platform/graphics/chromium/GLES2Texture.cpp: Added.
        (WebCore::GLES2Texture::GLES2Texture):
        (WebCore::GLES2Texture::~GLES2Texture):
        (WebCore::GLES2Texture::create):
        (WebCore::convertFormat):
        (WebCore::GLES2Texture::load):
        (WebCore::GLES2Texture::bind):
        * platform/graphics/chromium/GLES2Texture.h: Added.
        (WebCore::GLES2Texture::):
        (WebCore::GLES2Texture::format):
        (WebCore::GLES2Texture::width):
        (WebCore::GLES2Texture::height):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 26 Jul 2010 14:49:37 +0000 (14:49 +0000)]
2010-07-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Fix IndexedDB release build on mac
        https://bugs.webkit.org/show_bug.cgi?id=42377

        * storage/IDBDatabaseImpl.cpp:
        (WebCore::IDBDatabaseImpl::objectStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Hayato Ito <hayato@chromium.org>
commit-queue@webkit.org [Mon, 26 Jul 2010 13:47:05 +0000 (13:47 +0000)]
2010-07-26  Hayato Ito  <hayato@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Add pretty printer of WTF::Vector for GDB 7.

        https://bugs.webkit.org/show_bug.cgi?id=40909

        * gdb/wtf.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 26 Jul 2010 12:04:13 +0000 (12:04 +0000)]
2010-07-26  Marcus Bulach  <bulach@chromium.org>

        Unreviewed.  Add chromium expectations for failing tests.

        tables/mozilla/other/slashlogo.html fails after r63994
        https://bugs.webkit.org/show_bug.cgi?id=42964

        Adds a suppression for chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Satish Sampath <satish@chromium.org>
commit-queue@webkit.org [Mon, 26 Jul 2010 11:52:50 +0000 (11:52 +0000)]
2010-07-26  Satish Sampath  <satish@chromium.org>

        Reviewed by Steve Block.

        Add WebKit plumbing to connect speech requests and callbacks between WebCore and the embedder.
        https://bugs.webkit.org/show_bug.cgi?id=42367

        No new tests, the relevant LayoutTestController bindings will be added in the next patch.

        * page/SpeechInput.cpp: renamed a method.
        * page/SpeechInput.h: renamed a method.
        * page/SpeechInputClient.h: added an extra method to optionally let users stop recording once they have spoken.
        * page/SpeechInputClientListener.h: renamed a method.
        * page/SpeechInputListener.h: renamed a method.
2010-07-26  Satish Sampath  <satish@chromium.org>

        Reviewed by Steve Block.

        Add WebKit plumbing to connect speech requests and callbacks between WebCore and the embedder.
        https://bugs.webkit.org/show_bug.cgi?id=42367

        No new tests, the relevant LayoutTestController bindings and tests will be added in the next patch.

        * public/WebSpeechInputController.h: Added new interface, implemented by embedder and called by WebKit
        (WebKit::WebSpeechInputController::~WebSpeechInputController):
        * public/WebSpeechInputListener.h: Added new interface, implemented by WebKit and called by embedder.
        (WebKit::WebSpeechInputListener::~WebSpeechInputListener):
        * public/WebViewClient.h:
        (WebKit::WebViewClient::createSpeechInputClient): New method to get the embedder's speech input client interface.
        * src/SpeechInputClientImpl.cpp: Added new class, implementation of a two way connector between WebCore
        and the embedder for requests and responses.
        (WebKit::SpeechInputClientImpl::SpeechInputClientImpl):
        (WebKit::SpeechInputClientImpl::~SpeechInputClientImpl):
        (WebKit::SpeechInputClientImpl::startRecognition):
        (WebKit::SpeechInputClientImpl::stopRecording):
        (WebKit::SpeechInputClientImpl::didCompleteRecording):
        (WebKit::SpeechInputClientImpl::setRecognitionResult):
        (WebKit::SpeechInputClientImpl::didCompleteRecognition):
        * src/SpeechInputClientImpl.h: Added.
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl): Pass on the above mentioned speech input connector to WebCore.
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Mon, 26 Jul 2010 11:51:45 +0000 (11:51 +0000)]
2010-07-26  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] getImageData(): Single-pass RGB->BGR and un-premultiplication
        https://bugs.webkit.org/show_bug.cgi?id=42945

        Combine the two operations into a single loop over the pixel data.
        Yields a considerable FPS gain on http://www.semantix.gr/statue.html

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 26 Jul 2010 11:21:47 +0000 (11:21 +0000)]
2010-07-26  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Web Inspector: make sure proxy objects are JSON-stringifiable.

        https://bugs.webkit.org/show_bug.cgi?id=42961

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix feature detection regexp
vestbo@webkit.org [Mon, 26 Jul 2010 11:12:43 +0000 (11:12 +0000)]
[Qt] Fix feature detection regexp

Reviewed by Simon Hausmann.

We were missing the last feature

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
ossy@webkit.org [Mon, 26 Jul 2010 09:52:10 +0000 (09:52 +0000)]
Unreviewed.

[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578

* platform/qt/Skipped: Add tests to the Skipped list until fix.
 - http/tests/xmlhttprequest/authorization-header.html
 - http/tests/xmlhttprequest/null-auth.php

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 26 Jul 2010 09:37:38 +0000 (09:37 +0000)]
2010-07-26  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Joseph Pecoraro.

        Inspector should remember resources sorting set by the user
        https://bugs.webkit.org/show_bug.cgi?id=19208

        Sorting options both for time and size graphs are memorized in a single property,
        which makes them possible to retrieve in a single message (e.g. useful for remote debugging).

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.populateSidebar):
        (WebInspector.ResourcesPanel.prototype._settingsLoaded):
        (WebInspector.ResourcesPanel.prototype._loadSortOptions):
        (WebInspector.ResourcesPanel.prototype._loadSortOptionForGraph):
        (WebInspector.ResourcesPanel.prototype._graphSelected):
        (WebInspector.ResourcesPanel.prototype._changeSortingFunction):
        (WebInspector.ResourcesPanel.prototype._selectedOptionNameForGraph):
        (WebInspector.ResourcesPanel.prototype._doChangeSortingFunction):
        * inspector/front-end/Settings.js:
        (WebInspector.populateApplicationSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Use the default timeout interval for JS as the HTML tokenizer delay for setHtml()
hausmann@webkit.org [Mon, 26 Jul 2010 08:53:50 +0000 (08:53 +0000)]
[Qt] Use the default timeout interval for JS as the HTML tokenizer delay for setHtml()

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2009-10-30
Reviewed by Kenneth Rohde Christiansen.

This ensures that long-running JavaScript (for example due to a modal alert() dialog),
will not trigger a deferred load after only 500ms (the default tokenizer delay) while
still giving a reasonable timeout (10 seconds) to prevent deadlock.

https://bugs.webkit.org/show_bug.cgi?id=29381

JavaScriptCore:

* runtime/TimeoutChecker.h: Add getter for the timeout interval

WebKit/qt:

* Api/qwebframe.cpp: Document the behaviour
* WebCoreSupport/FrameLoaderClientQt.cpp: set the custom tokenizer delay for substitute loads
* tests/qwebframe/tst_qwebframe.cpp: Add test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-26 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 26 Jul 2010 08:29:21 +0000 (08:29 +0000)]
2010-07-26  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Chromium DevTools: refactor query params, add basic
        support for WebSocket-based backend.

        https://bugs.webkit.org/show_bug.cgi?id=42893

        * src/js/DevTools.js:
        (devtools.ToolsAgent.prototype.dispatchOnClient_):
        (WebInspector.loaded):
        (WebInspector.doLoadedDone):
        (devtools.domContentLoaded):
        * src/js/InspectorControllerImpl.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Redo fails after text node is split by SplitTextNodeCommand
rniwa@webkit.org [Mon, 26 Jul 2010 08:19:12 +0000 (08:19 +0000)]
WebCore: Redo fails after text node is split by SplitTextNodeCommand
https://bugs.webkit.org/show_bug.cgi?id=42941

Reviewed by Darin Adler.

The bug was caused by SplitTextNodeCommand not implementing doReapply.
Implemented doReapply and added insertText1AndTrimText2 to share the code between doApply and doReapply.

Test: editing/undo/redo-split-text-node.html
      editing/undo/redo-split-text-node-with-removal.html

* editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doApply): Calls executeApply.
(WebCore::SplitTextNodeCommand::doUnapply): Don't delete m_text1, which is later used in doReapply.
(WebCore::SplitTextNodeCommand::doReapply): Added.
(WebCore::SplitTextNodeCommand::insertText1AndTrimText2): Added.
* editing/SplitTextNodeCommand.h:

LayoutTests: Added a test that splits a text node by inserting a paragraph and applies inline style.
The test then ensures that the style is preserved after undos and redos.

Reviewed by Darin Adler.

Also added a test in which the text node is removed by the script after undo.

Redo fails after text node is split by SplitTextNodeCommand
https://bugs.webkit.org/show_bug.cgi?id=42941

* editing/undo/redo-split-text-node-expected.txt: Added.
* editing/undo/redo-split-text-node.html: Added.
* editing/undo/redo-split-text-with-removal-expected.txt: Added.
* editing/undo/redo-split-text-with-removal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-25 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 Jul 2010 06:57:55 +0000 (06:57 +0000)]
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
        https://bugs.webkit.org/show_bug.cgi?id=42326

        * platform/mac-wk2/Skipped: Removed all the tests from the list
        that were there only because they called dumpSelectionRect. Most of
        them pass now.
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
        https://bugs.webkit.org/show_bug.cgi?id=42326

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        Added dumpSelectionRect.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
        does nothing because its purpose is to change pixel test output and
        we do not have pixel tests implemented yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-23 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 26 Jul 2010 06:40:39 +0000 (06:40 +0000)]
2010-07-23  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GTK] media/media-can-play-mpeg-audio.html fails
        https://bugs.webkit.org/show_bug.cgi?id=42895

        Fixed advertizing of mp3, mpeg and mp4 mime-types in the player.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache):

LayoutTests:

2010-07-23  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GTK] media/media-can-play-mpeg-audio.html fails
        https://bugs.webkit.org/show_bug.cgi?id=42895

        * platform/gtk/Skipped: Unskip fixed test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-23 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 26 Jul 2010 06:35:44 +0000 (06:35 +0000)]
2010-07-23  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        LayoutTests/media/media-document-audio-size.html failure
        https://bugs.webkit.org/show_bug.cgi?id=38376

        Advertize audio/x-wav along with audio/wav when appropriate,
        otherwise WebKit attempts to use a plugin to play the media.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache):

LayoutTests:

2010-07-23  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        LayoutTests/media/media-document-audio-size.html failure
        https://bugs.webkit.org/show_bug.cgi?id=38376

        * platform/gtk/Skipped: Unskip fixed test on GTK port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-25 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 Jul 2010 06:13:56 +0000 (06:13 +0000)]
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Maciej Stachowiak.

        Need to support unsafe access console messages in WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=42320

        * platform/mac-wk2/Skipped: Since unsafe access console messages are
        working properly, moved the failing tests listed under this bug to
        other sections in the file based on the reason they are failing.
        Removed the tests that are passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-25 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 Jul 2010 06:03:36 +0000 (06:03 +0000)]
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Maciej Stachowiak.

        WebKitTestRunner needs to support layoutTestController.keepWebHistory
        https://bugs.webkit.org/show_bug.cgi?id=42323

        * platform/mac-wk2/Skipped: Removed the tests that needed only keepWebHistory
        and computedStyleIncludingVisitedInfo. Moved the other tests in the
        keepWebHistory section of the file into the other appropriate lists.
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Maciej Stachowiak.

        WebKitTestRunner needs to support layoutTestController.keepWebHistory
        https://bugs.webkit.org/show_bug.cgi?id=42323

        Added keepWebHistory and computedStyleIncludingVisitedInfo.

        Also fixed misspellings of the word "receive".

        Also tweaked the names of some of the LayoutTestController members.

        * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
        Added support for a type named "object" that is passed and returns as
        a JSValueRef.

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
        put setAcceptsEditing up nearer the top.

        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
        (WTR::InjectedBundle::initialize): Ditto.
        (WTR::InjectedBundle::didReceiveMessage): Ditto.
        (WTR::InjectedBundle::reset): Reset the state of visited links between
        tests. Also eliminated the unused argument to the LayoutTestController
        create function.
        (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
        * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
        instead of acceptsEditing.
        (WTR::InjectedBundlePage::shouldEndEditing): Ditto.
        (WTR::InjectedBundlePage::shouldInsertNode): Ditto.
        (WTR::InjectedBundlePage::shouldInsertText): Ditto.
        (WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
        (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
        (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::create): Removed uneeded argument.
        (WTR::LayoutTestController::LayoutTestController): Removed unneeded
        argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
        (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
        about the fact that this works on the main frame.
        (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
        (WTR::LayoutTestController::keepWebHistory): Added.
        (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
        (WTR::JSObjectSetProperty): Added. Helper to make the function below
        cleaner.
        (WTR::LayoutTestController::makeWindowObject): Changed to use the
        overload of JSObjectSetProperty above.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
        match above.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::initialize): Fixed mispellings of receive.
        (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
        (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
        * WebKitTestRunner/TestController.h: Ditto.
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
        * WebKitTestRunner/TestInvocation.h: Ditto.
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Maciej Stachowiak.

        WebKitTestRunner needs to support layoutTestController.keepWebHistory
        https://bugs.webkit.org/show_bug.cgi?id=42323

        Added WKBundleSetShouldTrackVisitedLinks, WKBundleRemoveAllVisitedLinks,
        and WKBundleFrameGetComputedStyleIncludingVisitedInfo.

        Also fixed misspellings of the word "receive".

        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundleSetShouldTrackVisitedLinks): Added.
        (WKBundleRemoveAllVisitedLinks): Added.
        * WebProcess/InjectedBundle/API/c/WKBundle.h: Added functions and
        fixed mispellings of receive.

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameGetJavaScriptContext): Moved the code from here into WebFrame,
        to be consistent with the rest of the functions in this file.
        (WKBundleFrameGetComputedStyleIncludingVisitedInfo): Added.
        * WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Added
        WKBundleFrameGetComputedStyleIncludingVisitedInfo and tried to rearrange the
        file to be more logically ordered and grouped.

        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::setShouldTrackVisitedLinks): Added.
        (WebKit::InjectedBundle::removeAllVisitedLinks): Added.
        (WebKit::InjectedBundle::didReceiveMessage): Fixed mispellings of receive.
        * WebProcess/InjectedBundle/InjectedBundle.h: Ditto.

        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::jsContext): Added. Contains the code that used to be in
        WKBundleFrameGetJavaScriptContext.
        (WebKit::WebFrame::computedStyleIncludingVisitedInfo): Added.
        * WebProcess/WebPage/WebFrame.h: Ditto.

        * UIProcess/API/C/WKContext.h: Fixed misspellings of receive.
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::didReceiveMessageFromInjectedBundle): Ditto.
        * UIProcess/WebContext.h: Ditto.
        * UIProcess/WebContextInjectedBundleClient.cpp:
        (WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle): Ditto.
        * UIProcess/WebContextInjectedBundleClient.h: Ditto.
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::forwardMessageToWebContext): Ditto.
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::forwardMessageToInjectedBundle): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agosplitTextAt*IfNeed and splitTextElementAt*IfNeed need to be cleaned up
rniwa@webkit.org [Mon, 26 Jul 2010 04:10:14 +0000 (04:10 +0000)]
splitTextAt*IfNeed and splitTextElementAt*IfNeed need to be cleaned up
https://bugs.webkit.org/show_bug.cgi?id=42937

Reviewed by Kent Tamura.

Isolated the code to decide whether or not text node should be split into isValidCaretPositionInTextNode.
Moved the condition check out of *IfNeeded methods to applyRelativeFontStyleChange and applyInlineStyle.

No new tests added since this is a clean up.

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Uses isValidCaretPositionInTextNode.
(WebCore::ApplyStyleCommand::applyInlineStyle): Uses isValidCaretPositionInTextNode.
(WebCore::ApplyStyleCommand::splitTextAtStart): Renamed from splitTextAtStartIfNeeded.
(WebCore::ApplyStyleCommand::splitTextAtEnd): Renamed from splitTextAtEndIfNeeded.
(WebCore::ApplyStyleCommand::splitTextElementAtStart): Renamed from splitTextElementAtStartIfNeeded.
(WebCore::ApplyStyleCommand::splitTextElementAtEnd): Renamed from splitTextElementAtEndIfNeeded.
(WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode): Returns true if the position lies within a text node.
* editing/ApplyStyleCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-25 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Mon, 26 Jul 2010 04:01:03 +0000 (04:01 +0000)]
2010-07-25  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kent Tamura.

        [WINCE] Buildfix for JSC in release mode
        https://bugs.webkit.org/show_bug.cgi?id=42934

        * jsc.cpp: Don't use __try on WinCE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-25 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Mon, 26 Jul 2010 03:48:44 +0000 (03:48 +0000)]
2010-07-25  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kent Tamura.

        [WINCE] Buildfix for ImageBufferWince
        https://bugs.webkit.org/show_bug.cgi?id=42928

        * platform/graphics/wince/ImageBufferWince.cpp:
        (WebCore::):
        (WebCore::BufferedImage::draw): Pass through ColorSpace parameter.
        (WebCore::BufferedImage::drawPattern): Ditto.
        (WebCore::ImageBuffer::platformTransformColorSpace): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-25 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Mon, 26 Jul 2010 03:33:33 +0000 (03:33 +0000)]
2010-07-25  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kent Tamura.

        [WINCE] Buildfix for PopupMenuWin.cpp
        https://bugs.webkit.org/show_bug.cgi?id=42932

        Add #if !OS(WINCE) around unsupported window messages.

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::wndProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 25 Jul 2010 21:51:04 +0000 (21:51 +0000)]
2010-07-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement adjustMathMLAttributes
        https://bugs.webkit.org/show_bug.cgi?id=42952

        Yay test progression.

        * html5lib/runner-expected-html5.txt:
2010-07-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement adjustMathMLAttributes
        https://bugs.webkit.org/show_bug.cgi?id=42952

        This is kind of mechanical overkill for adjusting one attribute name,
        but it's nice to use the same machinery as SVG.

        * html/HTMLTreeBuilder.cpp:
        * mathml/mathattrs.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 25 Jul 2010 21:36:32 +0000 (21:36 +0000)]
2010-07-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Functions supporting the legacy tree builder are confusing
        https://bugs.webkit.org/show_bug.cgi?id=42951

        This patch just inlines these functions into their one call site and
        removes the notImplemented() calls.  We thought we were going to grow
        these to support the new tree builder, but we took a different path.
        Previous to this patch, these functions were confusing because they
        looked like part of the new tree builder.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
        * html/HTMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 25 Jul 2010 20:05:54 +0000 (20:05 +0000)]
2010-07-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Recent HTML5 TreeBuilder Regression?  All canvas tests ASSERT
        https://bugs.webkit.org/show_bug.cgi?id=42948

        Remove ASSERT and replace with correct branch.  I put this ASSERT in
        to make sure we had test coverage for this branch.  I guess we do.  :)

        * html/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::attach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64022 268f45cc-cd09-0410-ab3c-d52691b4dbfc