WebKit-https.git
15 months agoTools:
commit-queue@webkit.org [Fri, 16 Oct 2020 14:46:00 +0000 (14:46 +0000)]
Tools:
Match webkitpy.port.base.Port's merging of .webarchive/.txt
https://bugs.webkit.org/show_bug.cgi?id=217795

Patch by Sam Sneddon <gsnedders@apple.com> on 2020-10-16
Reviewed by Alexey Proskuryakov.

* Scripts/check-for-duplicated-platform-test-results:
(check_duplicate): Check for both .webarchive and .txt
(check_platform): Don't call the function that probably just threw

LayoutTests:
Remove redundant baselines in platform/
https://bugs.webkit.org/show_bug.cgi?id=217795

Patch by Sam Sneddon <gsnedders@apple.com> on 2020-10-16
Reviewed by Alexey Proskuryakov.

* platform/glib/animations/steps-transform-rendering-updates-expected.txt: Removed.
* platform/glib/fast/canvas/fallback-content-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/close-before-open-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/close-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/extensions-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/invalid-encode-length-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/invalid-masked-frames-from-server-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/long-control-frame-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/long-invalid-header-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/network-process-crash-error-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/reserved-bits-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/too-long-payload-expected.txt: Removed.
* platform/glib/http/tests/websocket/tests/hybi/websocket-event-target-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/css/css-values/minmax-angle-computed-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-tail-expected.txt: Removed.
* platform/glib/webaudio/Analyser/realtimeanalyser-fftsize-reset-expected.txt: Removed.
* platform/glib/webaudio/Analyser/realtimeanalyser-multiple-calls-expected.txt: Removed.
* platform/gtk/fast/css/pseudo-invalid-form-invalidation-optimization-expected.txt: Removed.
* platform/gtk/fast/css/pseudo-valid-form-invalidation-optimization-expected.txt: Removed.
* platform/gtk/fast/events/js-keyboard-event-creation-expected.txt: Removed.
* platform/gtk/fast/events/nested-window-event-expected.txt: Removed.
* platform/gtk/http/tests/security/mixedContent/websocket/insecure-websocket-in-iframe-expected.txt: Removed.
* platform/gtk/http/tests/security/mixedContent/websocket/insecure-websocket-in-main-frame-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/telephone-expected.txt: Removed.
* platform/ios-wk2/compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/5002441-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-3778059-fix-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-br-at-tabspan-001-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-br-at-tabspan-002-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-br-at-tabspan-003-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-br-quoted-001-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-br-quoted-002-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-br-quoted-003-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-br-quoted-004-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-br-quoted-005-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-br-quoted-006-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-div-020-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-div-022-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-div-026-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/insert-text-with-newlines-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/paragraph-separator-01-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/paragraph-separator-in-table-2-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/return-key-with-selection-001-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/return-key-with-selection-002-expected.txt: Removed.
* platform/ios-wk2/editing/inserting/return-key-with-selection-003-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/5601583-1-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/8145-2-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/bad-placeholder-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-4038267-fix-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-line-endings-001-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-line-endings-002-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-line-endings-003-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-line-endings-004-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-line-endings-005-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-line-endings-006-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-line-endings-007-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-line-endings-008-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-line-endings-009-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-line-endings-010-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-match-style-001-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-match-style-002-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-text-016-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/paste-text-019-expected.txt: Removed.
* platform/ios-wk2/editing/pasteboard/quirks-mode-br-1-expected.txt: Removed.
* platform/ios-wk2/editing/selection/editable-html-element-expected.txt: Removed.
* platform/ios-wk2/editing/selection/paragraph-granularity-expected.txt: Removed.
* platform/ios-wk2/editing/selection/select-all-iframe-expected.txt: Removed.
* platform/ios-wk2/editing/selection/selection-actions-expected.txt: Removed.
* platform/ios-wk2/editing/selection/word-granularity-expected.txt: Removed.
* platform/ios-wk2/editing/style/5046875-2-expected.txt: Removed.
* platform/ios-wk2/editing/style/block-styles-007-expected.txt: Removed.
* platform/ios-wk2/editing/style/create-block-for-style-001-expected.txt: Removed.
* platform/ios-wk2/editing/style/create-block-for-style-002-expected.txt: Removed.
* platform/ios-wk2/editing/style/create-block-for-style-003-expected.txt: Removed.
* platform/ios-wk2/editing/style/create-block-for-style-004-expected.txt: Removed.
* platform/ios-wk2/editing/style/create-block-for-style-013-expected.txt: Removed.
* platform/ios-wk2/editing/style/style-3998892-fix-expected.txt: Removed.
* platform/ios-wk2/editing/style/style-boundary-001-expected.txt: Removed.
* platform/ios-wk2/editing/style/style-boundary-004-expected.txt: Removed.
* platform/ios-wk2/editing/unsupported-content/list-delete-003-expected.txt: Removed.
* platform/ios-wk2/editing/unsupported-content/list-type-after-expected.txt: Removed.
* platform/ios-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
* platform/ios-wk2/fast/dom/focus-contenteditable-expected.txt: Removed.
* platform/ios-wk2/fast/forms/basic-textareas-expected.txt: Removed.
* platform/ios-wk2/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Removed.
* platform/ios-wk2/fast/forms/textarea-scrollbar-expected.txt: Removed.
* platform/ios-wk2/fast/forms/textarea-scrolled-type-expected.txt: Removed.
* platform/ios-wk2/fast/forms/textfield-outline-expected.txt: Removed.
* platform/ios-wk2/fast/frames/onlyCommentInIFrame-expected.txt: Removed.
* platform/ios-wk2/fast/inline-block/tricky-baseline-expected.txt: Removed.
* platform/ios-wk2/fast/overflow/overflow-float-stacking-expected.txt: Removed.
* platform/ios-wk2/fast/overflow/overflow-stacking-expected.txt: Removed.
* platform/ios-wk2/fast/overflow/overflow-x-y-expected.txt: Removed.
* platform/ios-wk2/fast/overflow/position-fixed-transform-clipping-expected.txt: Removed.
* platform/ios-wk2/fast/text/international/thai-baht-space-expected.txt: Removed.
* platform/ios-wk2/fast/transforms/transformed-caret-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Removed.
* platform/ios/fast/canvas/set-colors-expected.txt: Removed.
* platform/ios/fast/scrolling/adjust-scroll-offset-on-zoom-expected.txt: Removed.
* platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt: Removed.
* platform/mac-catalina/fast/block/margin-collapse/103-expected.txt: Removed.
* platform/mac-catalina/fast/forms/button-table-styles-expected.txt: Removed.
* platform/mac-catalina/fast/forms/date/date-input-rendering-basic-expected.png: Removed.
* platform/mac-catalina/fast/forms/input-disabled-color-expected.txt: Removed.
* platform/mac-catalina/fast/forms/input-readonly-dimmed-expected.txt: Removed.
* platform/mac-catalina/fast/forms/select-change-popup-to-listbox-expected.txt: Removed.
* platform/mac-catalina/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.
* platform/mac-mojave/fast/block/basic/001-expected.txt: Removed.
* platform/mac-mojave/fast/block/margin-collapse/103-expected.txt: Removed.
* platform/mac-mojave/fast/forms/button-table-styles-expected.txt: Removed.
* platform/mac-mojave/fast/forms/date/date-input-rendering-basic-expected.png: Removed.
* platform/mac-mojave/fast/forms/input-disabled-color-expected.txt: Removed.
* platform/mac-mojave/fast/forms/input-readonly-dimmed-expected.txt: Removed.
* platform/mac-mojave/fast/forms/plaintext-mode-2-expected.txt: Removed.
* platform/mac-mojave/fast/forms/select-change-popup-to-listbox-expected.txt: Removed.
* platform/mac-mojave/fast/text/indic-expected.txt: Removed.
* platform/mac-mojave/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Removed.
* platform/mac-mojave/tables/mozilla/other/wa_table_tr_align-expected.txt: Removed.
* platform/mac-wk2/fast/forms/time/time-appearance-basic-expected.txt: Removed.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Removed.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter-expected.txt: Removed.
* platform/mac/fast/canvas/set-colors-expected.txt: Removed.
* platform/mac/http/tests/webarchive/test-preload-resources-expected.txt: Removed.
* platform/mac/svg/custom/image-with-prefix-in-webarchive-expected.txt: Removed.
* platform/mac/svg/webarchive/svg-feimage-subresources-expected.txt: Removed.
* platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.txt: Removed.
* platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.txt: Removed.
* platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.txt: Removed.
* platform/mac/webarchive/archive-empty-frame-dom-expected.txt: Removed.
* platform/mac/webarchive/archive-empty-frame-source-expected.txt: Removed.
* platform/mac/webarchive/archive-with-unencoded-url-expected.txt: Removed.
* platform/mac/webarchive/css-page-rule-crash-expected.txt: Removed.
* platform/mac/webarchive/doctype-expected.txt: Removed.
* platform/mac/webarchive/ignore-noscript-if-scripting-enabled-expected.txt: Removed.
* platform/mac/webarchive/test-body-background-expected.txt: Removed.
* platform/mac/webarchive/test-css-import-expected.txt: Removed.
* platform/mac/webarchive/test-duplicate-resources-expected.txt: Removed.
* platform/mac/webarchive/test-frameset-expected.txt: Removed.
* platform/mac/webarchive/test-img-src-expected.txt: Removed.
* platform/mac/webarchive/test-input-src-expected.txt: Removed.
* platform/mac/webarchive/test-link-href-expected.txt: Removed.
* platform/mac/webarchive/test-object-data-expected.txt: Removed.
* platform/mac/webarchive/test-script-src-expected.txt: Removed.
* platform/mac/webarchive/test-table-background-expected.txt: Removed.
* platform/mac/webarchive/test-td-background-expected.txt: Removed.
* platform/mac/webarchive/test-xml-stylesheet-expected.txt: Removed.
* platform/win/animations/steps-transform-rendering-updates-expected.txt: Removed.
* platform/win/editing/style/apply-through-end-of-document-expected.txt: Removed.
* platform/win/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Removed.
* platform/wincairo/animations/steps-transform-rendering-updates-expected.txt: Removed.
* platform/wincairo/editing/style/apply-through-end-of-document-expected.txt: Removed.
* platform/wpe/http/tests/storageAccess/aggregate-sorted-data-with-storage-access-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/css/css-sizing/percentage-height-in-flexbox-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoREGRESSION (r266932): [ Mojave+ wk2 ] fast/scrolling/latching/latched-scroll-into...
rackler@apple.com [Fri, 16 Oct 2020 14:17:44 +0000 (14:17 +0000)]
REGRESSION (r266932): [ Mojave+ wk2 ] fast/scrolling/latching/latched-scroll-into-nonfast-region.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217001

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoREGRESSION(r267727): Warning spam from JSC_DECLARE_CUSTOM_GETTER
commit-queue@webkit.org [Fri, 16 Oct 2020 14:12:08 +0000 (14:12 +0000)]
REGRESSION(r267727): Warning spam from JSC_DECLARE_CUSTOM_GETTER
https://bugs.webkit.org/show_bug.cgi?id=217585

Patch by Michael Catanzaro <mcatanzaro@gnome.org> on 2020-10-16
Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

A small number of source files now need to use JSC_DECLARE_CUSTOM_GETTER_WITHOUT_WTF_INTERNAL.

* b3/testb3_5.cpp:
* b3/testb3_7.cpp:
* tools/JSDollarVM.cpp:

Source/WebCore:

SelectorCompiler.cpp needs the new JSC_DECLARE_JIT_OPERATION_WITHOUT_WTF_INTERNAL.

* cssjit/SelectorCompiler.cpp:

Source/WTF:

The problem is that the declarations are static, so WTF_INTERNAL is redundant with that.
(File-static declarations are of course local to the current file, and apparently GCC really
wants us to not hide symbols that don't need to be hidden.)

I considered remove WTF_INTERNAL from JSC_DECLARE_JIT_OPERATION and ensuring all uses are
static, but it's not possible because it is frequently used in header files. It should only
be static when used in .cpp files.

So I decided to split JSC_DECLARE_JIT_OPERATION into two versions, the current one that uses
WTF_INTERNAL, and JSC_DECLARE_JIT_OPERATION_WITHOUT_WTF_INTERNAL that doesn't. That is not a
great name, but it's only used in a couple places, so I guess that's OK.
JSC_DECLARE_CUSTOM_GETTER and JSC_DECLARE_CUSTOM_SETTER use this new version, since those
are only used in static declarations in .cpp files. A small number of source files also need
the version without the WTF_INTERNAL. All other users can continue to use original
JSC_DECLARE_JIT_OPERATION with WTF_INTERNAL and not worry about the ugly name.

I'm not terribly happy with this solution, and it's a little fragile too (you probably won't
directly use JSC_DECLARE_JIT_OPERATION_WITHOUT_WTF_INTERNAL in a place that needs
WTF_INTERNAL, but you might use JSC_DECLARE_CUSTOM_GETTER and JSC_DECLARE_CUSTOM_SETTER in
such a way!), but at least it will avoid the warning spam and allow us to see warnings for
real problems.

* wtf/PlatformCallingConventions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoUnreviewed, follow-up to r268576
philn@webkit.org [Fri, 16 Oct 2020 13:21:27 +0000 (13:21 +0000)]
Unreviewed, follow-up to r268576

Revert a chunk of r268576 that introduced a regression in audio-related tests.

* platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::fillMimeTypeSetFromCapsMapping): Add an ASSERT and
modify mime-type and codec hashmaps in-place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoRefactor [WebAccessibilityObjectWrapper convertRectToSpace] so that the platform...
andresg_22@apple.com [Fri, 16 Oct 2020 13:03:49 +0000 (13:03 +0000)]
Refactor [WebAccessibilityObjectWrapper convertRectToSpace] so that the platform-specific code is in their corresponding AX object platform implementations.
https://bugs.webkit.org/show_bug.cgi?id=217785

Reviewed by Chris Fleizach.

No change in functionality, code refactor and cleanup.

[WebAccessibilityObjectWrapperBase convertRectToSpace] had two different
code paths for Mac and iOS, defeating the purpose of a base class.
This re-factoring Simplifies the wrapper code by moving the platform-
specific implementations to their corresponding AX object implementations
of convertRectToPlatformSpace.
Some code cleanup.

* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityObjectInterface.h:
* accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::AccessibilityObject::topDocumentFrameView const):
(WebCore::AccessibilityObject::convertRectToPlatformSpace const):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityWebDocumentView]):
* accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::convertRectToPlatformSpace const):
* accessibility/isolatedtree/AXIsolatedObject.h:
* accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::topDocumentFrameView const):
(WebCore::AccessibilityObject::convertRectToPlatformSpace const):
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase convertRectToSpace:space:]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper position]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoREGRESSION: [ Win10 wk1 ews ] transforms/2d/translate-change-composited.html is a...
rackler@apple.com [Fri, 16 Oct 2020 12:53:35 +0000 (12:53 +0000)]
REGRESSION: [ Win10 wk1 ews ] transforms/2d/translate-change-composited.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217812

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[GLIB] Unreviewed test gardening. Update test expectations after r268575.
dpino@igalia.com [Fri, 16 Oct 2020 12:51:58 +0000 (12:51 +0000)]
[GLIB] Unreviewed test gardening. Update test expectations after r268575.

Added several failures from new added tests.

* platform/glib/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoREGRESSION: [ Win10 wk1 ews ] transforms/2d/rotate-change-composited.html is a flaky...
rackler@apple.com [Fri, 16 Oct 2020 12:45:16 +0000 (12:45 +0000)]
REGRESSION: [ Win10 wk1 ews ] transforms/2d/rotate-change-composited.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217812

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoEnsure the tests are run with US/Pacific time zone
clopez@igalia.com [Fri, 16 Oct 2020 12:33:52 +0000 (12:33 +0000)]
Ensure the tests are run with US/Pacific time zone
https://bugs.webkit.org/show_bug.cgi?id=186612

Reviewed by Michael Catanzaro.

Some tests fail if the time zone is not set to US/Pacific, and
this causes issues for contributors living outside of that timezone.
Ideally we should fix those tests, but in the meantime setting this
environment variable before starting the layout tests seems like
an acceptable workaround. Note that something similar is also
already done for the JSC tests.

* Scripts/webkitpy/port/base.py:
(Port.setup_environ_for_server):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoREGRESSION: [ Win10 wk1 ews ] transforms/2d/scale-change-composited.html is a flaky...
rackler@apple.com [Fri, 16 Oct 2020 12:33:15 +0000 (12:33 +0000)]
REGRESSION: [ Win10 wk1 ews ] transforms/2d/scale-change-composited.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217812

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[GStreamer] Audio worklet support
philn@webkit.org [Fri, 16 Oct 2020 11:22:06 +0000 (11:22 +0000)]
[GStreamer] Audio worklet support
https://bugs.webkit.org/show_bug.cgi?id=217760

Reviewed by Xabier Rodriguez-Calvar.

This patch hooks WebAudio worklet rendering support into the GStreamer WebAudio backend.

* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::start): Set the render callback if it was provided.
* platform/audio/gstreamer/AudioDestinationGStreamer.h:
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcAllocateBuffersAndRenderAudio): Invoke the bus rendering through the
render callback if it was set.
(webkitWebAudioSourceSetDispatchToRenderThreadCallback):
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoRefactor WebGL implementation to use only GraphicsContextGL part 1
commit-queue@webkit.org [Fri, 16 Oct 2020 10:55:59 +0000 (10:55 +0000)]
Refactor WebGL implementation to use only GraphicsContextGL part 1
https://bugs.webkit.org/show_bug.cgi?id=217213
<rdar://problem/69876105>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2020-10-16
Reviewed by Dean Jackson.

Part 1 of work towards WebGL implementation which uses
GraphicsContextGL abstract base class instead of
GraphicsContextGLOpenGL concrete class.

Move pixel data related static helper funcions from
GraphicsContextGLOpenGL to GraphicsContextGL. These are
normal pixel format calculation functions that do not have
concrete class implementation details. Move pixel pack related
structures to GraphicsContextGL.

Rename GraphicsContextGLOpenGL::ImageExtractor to
GraphicsContextGLImageExtractor. The GraphicsContextGL class
interface is already quite lengthy and the image extractor
is not very tied to the context class.

Introduce a virtual member function in GraphicsContextGL for
each call that is likely needed for the WebGL implementation.

No new tests, a refactor.

* WebCore.xcodeproj/project.pbxproj:
* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getPackPixelStoreParams const):
(WebCore::WebGL2RenderingContext::getUnpackPixelStoreParams const):
* html/canvas/WebGL2RenderingContext.h:
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::texImageArrayBufferViewHelper):
(WebCore::WebGLRenderingContextBase::texImageImpl):
(WebCore::WebGLRenderingContextBase::getPackPixelStoreParams const):
(WebCore::WebGLRenderingContextBase::getUnpackPixelStoreParams const):
* html/canvas/WebGLRenderingContextBase.h:
* platform/graphics/GraphicsContextGL.cpp:
(WebCore::getDataFormat):
(WebCore::texelBytesForFormat):
(WebCore::packPixels):
(WebCore::GraphicsContextGL::computeFormatAndTypeParameters):
(WebCore::GraphicsContextGL::computeImageSizeInBytes):
(WebCore::GraphicsContextGL::possibleFormatAndTypeForInternalFormat):
(WebCore::GraphicsContextGL::packImageData):
(WebCore::GraphicsContextGL::extractImageData):
(WebCore::GraphicsContextGL::extractTextureData):
* platform/graphics/GraphicsContextGL.h:
(WebCore::GraphicsContextGL::Client::~Client):
(WebCore::GraphicsContextGL::addClient):
(WebCore::GraphicsContextGL::removeClient):
(WebCore::GraphicsContextGL::getInternalFramebufferSize const):
* platform/graphics/GraphicsContextGLImageExtractor.cpp: Copied from Source/WebCore/platform/graphics/win/GraphicsContextGLDirect2D.cpp.
(WebCore::GraphicsContextGLImageExtractor::GraphicsContextGLImageExtractor):
* platform/graphics/GraphicsContextGLImageExtractor.h: Added.
(WebCore::GraphicsContextGLImageExtractor::extractSucceeded):
(WebCore::GraphicsContextGLImageExtractor::imagePixelData):
(WebCore::GraphicsContextGLImageExtractor::imageWidth):
(WebCore::GraphicsContextGLImageExtractor::imageHeight):
(WebCore::GraphicsContextGLImageExtractor::imageSourceFormat):
(WebCore::GraphicsContextGLImageExtractor::imageAlphaOp):
(WebCore::GraphicsContextGLImageExtractor::imageSourceUnpackAlignment):
(WebCore::GraphicsContextGLImageExtractor::imageHtmlDomSource):
* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
* platform/graphics/cairo/GraphicsContextGLCairo.cpp:
(WebCore::GraphicsContextGLImageExtractor::extractImage):
* platform/graphics/cg/GraphicsContextGLCG.cpp:
(WebCore::GraphicsContextGLImageExtractor::extractImage):
* platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
(WebCore::GraphicsContextGLOpenGL::texImage2DResourceSafe):
* platform/graphics/opengl/GraphicsContextGLOpenGL.h:
* platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
* platform/graphics/win/GraphicsContextGLDirect2D.cpp:
(WebCore::GraphicsContextGLImageExtractor::extractImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoAdd support for GPUProcess WebAudio media element providers
youenn@apple.com [Fri, 16 Oct 2020 09:48:57 +0000 (09:48 +0000)]
Add support for GPUProcess WebAudio media element providers
https://bugs.webkit.org/show_bug.cgi?id=217704

Reviewed by Eric Carlson.

Source/WebCore:

Update AudioSourceProviderAVFObjC so that a specific ring buffer can be provided and to be notified of new samples being pushed.

Covered by existing web audio tests run with GPUProcess.

* WebCore.xcodeproj/project.pbxproj:
* platform/audio/AudioSourceProvider.h:
(WebCore::AudioSourceProvider::isHandlingAVPlayer const):
* platform/audio/cocoa/AudioSampleDataSource.mm:
(WebCore::AudioSampleDataSource::pullSamplesInternal):
When we are too close to the end of available data, do as if we are paused and keep the same time entry for the next read operation.
This will basically make us wait for the next push of data before restarting to read succesfully.
* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
(isType):
* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::prepare):
(WebCore::AudioSourceProviderAVFObjC::process):
(WebCore::AudioSourceProviderAVFObjC::setAudioCallback):
(WebCore::AudioSourceProviderAVFObjC::setRingBufferCreationCallback):
* platform/mediastream/mac/WebAudioSourceProviderCocoa.mm:
(WebCore::WebAudioSourceProviderCocoa::receivedNewAudioSamples):
We should use the input sample rate to compute the input media time.

Source/WebKit:

Introduce RemoteAudioSourceProviderManager which receives IPC messages from GPU process for web audio data.
RemoteAudioSourceProviderManager sends it to the identified RemoteAudioSourceProvider.

Introduce RemoteAudioSourceProviderProxy which is a client to the AV AudioSourceProviderAVFObjC.
RemoteAudioSourceProviderProxy will send IPC messages to RemoteAudioSourceProviderManager to send audio data and description.

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* GPUProcess/media/RemoteAudioSourceProviderProxy.cpp: Added.
(WebKit::RemoteAudioSourceProviderProxy::create):
(WebKit::RemoteAudioSourceProviderProxy::RemoteAudioSourceProviderProxy):
(WebKit::RemoteAudioSourceProviderProxy::createRingBuffer):
(WebKit::RemoteAudioSourceProviderProxy::newAudioSamples):
(WebKit::RemoteAudioSourceProviderProxy::storageChanged):
* GPUProcess/media/RemoteAudioSourceProviderProxy.h: Added.
* GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::~RemoteMediaPlayerProxy):
(WebKit::RemoteMediaPlayerProxy::createAudioSourceProvider):
(WebKit::RemoteMediaPlayerProxy::setShouldEnableAudioSourceProvider):
* GPUProcess/media/RemoteMediaPlayerProxy.h:
* GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
* SourcesCocoa.txt:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::audioSourceProviderManager):
* WebProcess/GPU/GPUProcessConnection.h:
* WebProcess/GPU/media/RemoteAudioSourceProvider.cpp:
(WebKit::RemoteAudioSourceProvider::create):
(WebKit::RemoteAudioSourceProvider::RemoteAudioSourceProvider):
(WebKit::RemoteAudioSourceProvider::close):
(WebKit::RemoteAudioSourceProvider::hasNewClient):
* WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp: Added.
(WebKit::RemoteAudioSourceProviderManager::RemoteAudioSourceProviderManager):
(WebKit::RemoteAudioSourceProviderManager::~RemoteAudioSourceProviderManager):
(WebKit::RemoteAudioSourceProviderManager::setConnection):
(WebKit::RemoteAudioSourceProviderManager::addProvider):
(WebKit::RemoteAudioSourceProviderManager::removeProvider):
(WebKit::RemoteAudioSourceProviderManager::dispatchToThread):
(WebKit::RemoteAudioSourceProviderManager::audioStorageChanged):
(WebKit::RemoteAudioSourceProviderManager::audioSamplesAvailable):
(WebKit::RemoteAudioSourceProviderManager::RemoteAudio::RemoteAudio):
(WebKit::RemoteAudioSourceProviderManager::RemoteAudio::setStorage):
(WebKit::RemoteAudioSourceProviderManager::RemoteAudio::audioSamplesAvailable):
* WebProcess/GPU/media/RemoteAudioSourceProviderManager.h: Added.
(WebKit::RemoteAudioSourceProviderManager::create):
* WebProcess/GPU/media/RemoteAudioSourceProviderManager.messages.in: Added.
* WebProcess/cocoa/RemoteCaptureSampleManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[GStreamer] Encoder probing support for the registry scanner
philn@webkit.org [Fri, 16 Oct 2020 08:52:38 +0000 (08:52 +0000)]
[GStreamer] Encoder probing support for the registry scanner
https://bugs.webkit.org/show_bug.cgi?id=217750

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The scanner is now able to probe for platform encoders for the most common formats: avc1,
av1, ogg, theora, aac and opus. The muxers for webm and mp4 are also checked.

No new tests, existing mediacapabilities test cover this change.

* platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::GStreamerRegistryScanner):
(WebCore::GStreamerRegistryScanner::~GStreamerRegistryScanner):
(WebCore::GStreamerRegistryScanner::mimeTypeSet):
(WebCore::GStreamerRegistryScanner::isContainerTypeSupported const):
(WebCore::GStreamerRegistryScanner::hasElementForMediaType const):
(WebCore::GStreamerRegistryScanner::fillMimeTypeSetFromCapsMapping):
(WebCore::GStreamerRegistryScanner::initializeDecoders):
(WebCore::GStreamerRegistryScanner::initializeEncoders):
(WebCore::GStreamerRegistryScanner::isCodecSupported const):
(WebCore::GStreamerRegistryScanner::isContentTypeSupported const):
(WebCore::GStreamerRegistryScanner::areAllCodecsSupported const):
(WebCore::GStreamerRegistryScanner::isAVC1CodecSupported const):
(WebCore::GStreamerRegistryScanner::configurationNameForLogging const):
(WebCore::GStreamerRegistryScanner::isConfigurationSupported const):
* platform/graphics/gstreamer/GStreamerRegistryScanner.h:
(WebCore::GStreamerRegistryScanner::isDecodingSupported const):
(WebCore::GStreamerRegistryScanner::isEncodingSupported const):
* platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
(WebCore::ImageDecoderGStreamer::supportsContainerType):
(WebCore::ImageDecoderGStreamer::canDecodeType):
* platform/graphics/gstreamer/MediaEngineConfigurationFactoryGStreamer.cpp:
(WebCore::createMediaPlayerEncodingConfigurationGStreamer):
* platform/graphics/gstreamer/MediaEngineConfigurationFactoryGStreamer.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes):
(WebCore::MediaPlayerPrivateGStreamer::supportsType):
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::getSupportedTypes):
(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType):
* platform/mediacapabilities/MediaEngineConfigurationFactory.cpp:
(WebCore::factories):

LayoutTests:

* platform/glib/media/mediacapabilities-types-expected.txt: Renamed from LayoutTests/platform/gtk/media/mediacapabilities/mediacapabilities-types-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[WebAuthn] Move AppAttestInternal related code from WKA to OpenSource
jiewen_tan@apple.com [Fri, 16 Oct 2020 07:52:45 +0000 (07:52 +0000)]
[WebAuthn] Move AppAttestInternal related code from WKA to OpenSource
https://bugs.webkit.org/show_bug.cgi?id=217790
<rdar://problem/59613406>

Reviewed by Brent Fulgham.

Source/WebKit:

Covered by manual testing.

* Platform/spi/Cocoa/AppAttestSPI.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.mm.
* SourcesCocoa.txt:
* UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.h: Added.
* UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.mm: Added.
* UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:
(WebKit::LocalConnection::getAttestation const):
* UIProcess/WebAuthentication/Cocoa/LocalService.mm:
(WebKit::LocalService::isAvailable):
* WebKit.xcodeproj/project.pbxproj:

Source/WTF:

* wtf/PlatformHave.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[GLIB][GTK] Unreviewed test gardening. Update test expectations after r268573.
dpino@igalia.com [Fri, 16 Oct 2020 07:22:15 +0000 (07:22 +0000)]
[GLIB][GTK] Unreviewed test gardening. Update test expectations after r268573.

* platform/glib/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[GTK] Update expectations for editing/pasteboard/drop-text-without-selection.html...
dpino@igalia.com [Fri, 16 Oct 2020 07:09:32 +0000 (07:09 +0000)]
[GTK] Update expectations for editing/pasteboard/drop-text-without-selection.html after r267997

Unreviewed test gardening.

r267997 removed GTK expected baseline for editing/pasteboard/drop-text-without-selection.html, which was stale
after the test was converted into a reftest. After this change, GTK test bot reported the baseline as Missing.
The reason was that the reference test was in platform Mac. Also remove stale GTK expected image.

* editing/pasteboard/drop-text-without-selection-expected.html: Renamed from LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.html.
* platform/gtk/TestExpectations:
* platform/gtk/editing/pasteboard/drop-text-without-selection-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoDon't assign a bogus register to Load/ForwardVarargs in AvailabilityAnalysis before...
sbarati@apple.com [Fri, 16 Oct 2020 03:11:51 +0000 (03:11 +0000)]
Don't assign a bogus register to Load/ForwardVarargs in AvailabilityAnalysis before stack layout
https://bugs.webkit.org/show_bug.cgi?id=217789
<rdar://problem/69285703>

Reviewed by Keith Miller.

JSTests:

* stress/dont-assign-bogus-virtual-register-in-availability-analysis-before-stack-layout-runs.js: Added.
(bar):
(foo):

Source/JavaScriptCore:

There is code inside AvailabilityAnalysis phase that was assuming the
Load/ForwardVarargs data was already stack allocated. However, this isn't
guaranteed to be the case. However, we were doing virtual register math on
invalid virtual registers, leading to wonky results. The fix here is to
model it like we do GetStack/PutStack, where we say, before we do stack
allocation, we just tell availability analysis the flush format, but not
where it's flushed.

This was causing validation errors when merging these invalid FlushedAts with
the FlushedAts from GetStack/PutStack.

* dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoAttempt to fix the build.
weinig@apple.com [Fri, 16 Oct 2020 01:51:40 +0000 (01:51 +0000)]
Attempt to fix the build.

* DumpRenderTree/DerivedSources.make: Don't use such fancy substitution, it wasn't working.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agov2: WebKit::XPCServiceEventHandler block should call exit() on the main thread
ddkilzer@apple.com [Fri, 16 Oct 2020 01:45:03 +0000 (01:45 +0000)]
v2: WebKit::XPCServiceEventHandler block should call exit() on the main thread
<https://webkit.org/b/217773>
<rdar://problem/70275659>

Reviewed by Geoff Garen.

* Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
- Use NSRunLoop instead of libdispatch to run code on the main
  thread since libdispatch can randomly pick a new main thread when
  exit() is called on the original main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoiPhone apps and iPad apps linked before iOS 13 running on macOS get desktop UA unexpe...
timothy_horton@apple.com [Fri, 16 Oct 2020 01:39:03 +0000 (01:39 +0000)]
iPhone apps and iPad apps linked before iOS 13 running on macOS get desktop UA unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=217798
<rdar://problem/70254509>

Reviewed by Wenson Hsieh.

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::desktopClassBrowsingRecommended):
Share more of the code with iOS, for compatibility and consistency's sake:
iOS apps running on macOS should use the mobile UA if they are iPhone-only,
or if they were linked on an SDK earlier than iOS 13. This matches their
behavior on iPad.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[WPE] Rebaseline after r268520
clopez@igalia.com [Fri, 16 Oct 2020 01:28:44 +0000 (01:28 +0000)]
[WPE] Rebaseline after r268520

Unreviewed gardening.

Rebaseline tests affected by r268520 for WPE.
For GTK this tests were rebaselined on r268545.

* platform/glib/fast/text/whitespace/029-expected.txt: Renamed from LayoutTests/platform/gtk/fast/text/whitespace/029-expected.txt.
* platform/wpe/css1/box_properties/float_on_text_elements-expected.txt:
* platform/wpe/css1/color_and_background/background_attachment-expected.txt:
* platform/wpe/css1/text_properties/text_indent-expected.txt:
* platform/wpe/fast/backgrounds/background-clip-text-expected.txt:
* platform/wpe/fast/block/basic/001-expected.txt:
* platform/wpe/fast/block/float/002-expected.txt:
* platform/wpe/fast/block/float/021-expected.txt:
* platform/wpe/fast/block/float/br-with-clear-2-expected.txt: Added.
* platform/wpe/fast/block/float/float-avoidance-expected.txt:
* platform/wpe/fast/block/margin-collapse/104-expected.txt:
* platform/wpe/fast/block/positioning/055-expected.txt:
* platform/wpe/fast/block/positioning/056-expected.txt:
* platform/wpe/fast/borders/inline-mask-overlay-image-outset-expected.txt:
* platform/wpe/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt:
* platform/wpe/fast/box-shadow/basic-shadows-expected.txt:
* platform/wpe/fast/clip/nestedTransparencyClip-expected.txt:
* platform/wpe/fast/clip/overflow-border-radius-combinations-expected.txt:
* platform/wpe/fast/clip/overflow-border-radius-composited-expected.txt:
* platform/wpe/fast/clip/overflow-border-radius-transformed-expected.txt:
* platform/wpe/fast/css-generated-content/inline-display-types-expected.txt:
* platform/wpe/fast/css/first-line-text-decoration-expected.txt:
* platform/wpe/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
* platform/wpe/fast/css/hsl-color-expected.txt:
* platform/wpe/fast/css/layerZOrderCrash-expected.txt:
* platform/wpe/fast/css/line-height-overflow-expected.txt:
* platform/wpe/fast/css/nth-child-dynamic-expected.txt:
* platform/wpe/fast/css/rtl-ordering-expected.txt:
* platform/wpe/fast/css/text-overflow-ellipsis-expected.txt:
* platform/wpe/fast/css/text-rendering-expected.txt:
* platform/wpe/fast/dom/HTMLElement/bdo-expected.txt:
* platform/wpe/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
* platform/wpe/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
* platform/wpe/fast/dom/HTMLTableElement/colSpan-expected.txt:
* platform/wpe/fast/dom/HTMLTableElement/createCaption-expected.txt:
* platform/wpe/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
* platform/wpe/fast/dom/children-nodes-expected.txt:
* platform/wpe/fast/dom/focus-contenteditable-expected.txt:
* platform/wpe/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.txt:
* platform/wpe/fast/encoding/utf-16-big-endian-expected.txt:
* platform/wpe/fast/encoding/utf-16-little-endian-expected.txt:
* platform/wpe/fast/encoding/xmacroman-encoding-test-expected.txt:
* platform/wpe/fast/frames/iframe-with-frameborder-expected.txt:
* platform/wpe/fast/frames/onlyCommentInIFrame-expected.txt:
* platform/wpe/fast/inline-block/contenteditable-baseline-expected.txt:
* platform/wpe/fast/inline-block/inline-block-vertical-align-expected.txt:
* platform/wpe/fast/inline/drawStyledEmptyInlines-expected.txt:
* platform/wpe/fast/invalid/021-expected.txt:
* platform/wpe/fast/layers/video-layer-expected.txt:
* platform/wpe/fast/line-grid/line-grid-contains-value-expected.txt:
* platform/wpe/fast/line-grid/line-grid-floating-expected.txt:
* platform/wpe/fast/line-grid/line-grid-inside-columns-expected.txt:
* platform/wpe/fast/line-grid/line-grid-into-columns-expected.txt:
* platform/wpe/fast/line-grid/line-grid-into-floats-expected.txt:
* platform/wpe/fast/line-grid/line-grid-positioned-expected.txt:
* platform/wpe/fast/multicol/float-paginate-complex-expected.txt:
* platform/wpe/fast/multicol/layers-in-multicol-expected.txt:
* platform/wpe/fast/multicol/max-height-columns-block-expected.txt:
* platform/wpe/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
* platform/wpe/fast/overflow/006-expected.txt:
* platform/wpe/fast/overflow/line-clamp-expected.txt:
* platform/wpe/fast/overflow/overflow-stacking-expected.txt:
* platform/wpe/fast/overflow/overflow-x-y-expected.txt:
* platform/wpe/fast/overflow/position-fixed-transform-clipping-expected.txt:
* platform/wpe/fast/overflow/table-overflow-float-expected.txt:
* platform/wpe/fast/replaced/selection-rect-transform-expected.txt:
* platform/wpe/fast/ruby/ruby-beforeafter-expected.txt:
* platform/wpe/fast/ruby/ruby-inline-table-expected.txt:
* platform/wpe/fast/ruby/ruby-length-expected.txt:
* platform/wpe/fast/ruby/ruby-run-break-expected.txt:
* platform/wpe/fast/ruby/ruby-runs-expected.txt:
* platform/wpe/fast/ruby/ruby-simple-expected.txt:
* platform/wpe/fast/ruby/ruby-simple-rp-expected.txt:
* platform/wpe/fast/table/009-expected.txt:
* platform/wpe/fast/table/040-expected.txt:
* platform/wpe/fast/table/040-vertical-expected.txt:
* platform/wpe/fast/table/cellindex-expected.txt:
* platform/wpe/fast/table/percent-heights-expected.txt:
* platform/wpe/fast/table/table-and-parts-outline-expected.txt:
* platform/wpe/fast/text/basic/012-expected.txt:
* platform/wpe/fast/text/basic/014-expected.txt:
* platform/wpe/fast/text/basic/generic-family-reset-expected.txt:
* platform/wpe/fast/text/capitalize-boundaries-expected.txt:
* platform/wpe/fast/text/complex-synthetic-bold-space-width-expected.txt:
* platform/wpe/fast/text/emoji-expected.txt:
* platform/wpe/fast/text/firstline/001-expected.txt:
* platform/wpe/fast/text/indic-expected.txt:
* platform/wpe/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
* platform/wpe/fast/text/international/bidi-layout-across-linebreak-expected.txt:
* platform/wpe/fast/text/international/bidi-listbox-atsui-expected.txt:
* platform/wpe/fast/text/international/bidi-listbox-expected.txt:
* platform/wpe/fast/text/international/bidi-menulist-expected.txt:
* platform/wpe/fast/text/international/hebrew-vowels-expected.txt:
* platform/wpe/fast/text/international/hindi-spacing-expected.txt:
* platform/wpe/fast/text/international/thai-baht-space-expected.txt:
* platform/wpe/fast/text/midword-break-after-breakable-char-expected.txt:
* platform/wpe/fast/text/svg-font-face-with-kerning-expected.txt:
* platform/wpe/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
* platform/wpe/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/wpe/fast/writing-mode/english-bt-text-expected.txt:
* platform/wpe/fast/writing-mode/english-lr-text-expected.txt:
* platform/wpe/fast/writing-mode/english-rl-text-expected.txt:
* platform/wpe/fast/writing-mode/fieldsets-expected.txt:
* platform/wpe/fast/writing-mode/text-orientation-basic-expected.txt:
* platform/wpe/fast/xsl/xslt-enc-cyr-expected.txt:
* platform/wpe/fast/xsl/xslt-enc-expected.txt:
* platform/wpe/fast/xsl/xslt-enc16-expected.txt:
* platform/wpe/fast/xsl/xslt-enc16to16-expected.txt:
* platform/wpe/fonts/cursive-expected.txt:
* platform/wpe/fonts/default-expected.txt:
* platform/wpe/fonts/fantasy-expected.txt:
* platform/wpe/fonts/monospace-expected.txt:
* platform/wpe/fonts/sans-serif-expected.txt:
* platform/wpe/fonts/serif-expected.txt:
* platform/wpe/http/tests/loading/simple-subframe-expected.txt:
* platform/wpe/http/tests/misc/favicon-as-image-expected.txt:
* platform/wpe/http/tests/misc/frame-access-during-load-expected.txt:
* platform/wpe/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/wpe/http/tests/navigation/postredirect-basic-expected.txt:
* platform/wpe/http/tests/navigation/postredirect-goback1-expected.txt:
* platform/wpe/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
* platform/wpe/scrollbars/overflow-scrollbar-combinations-expected.txt:
* platform/wpe/svg/custom/getsvgdocument-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug106158-1-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug10633-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug113235-1-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug1188-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug1224-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug131020-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug131020_iframe-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug1318-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug1430-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug16012-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug17138-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug19599-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug20579-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug20804-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug23235-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug23299-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug25663-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug28928-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug2962-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug30332-1-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug30559-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug30692-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug32205-2-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug32205-3-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug4382-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug43854-2-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug4427-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug4527-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug5538-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug55694-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug5799-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug82946-1-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug8858-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug9123-1-expected.txt:
* platform/wpe/tables/mozilla/bugs/bug92143-expected.txt:
* platform/wpe/tables/mozilla/core/bloomberg-expected.txt:
* platform/wpe/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
* platform/wpe/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_border_1-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_border_2-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_border_3-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_cellpadding-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_cellspacing-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_td_align_left-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_td_align_right-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_td_colspan-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_td_height-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_td_width-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_th_align_center-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_th_align_left-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_th_align_right-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_th_colspan-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_th_height-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
* platform/wpe/tables/mozilla/marvin/tables_th_width-expected.txt:
* platform/wpe/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
* platform/wpe/tables/mozilla/other/wa_table_tr_align-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/bugs/bug11331-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/bugs/bug1262-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/core/col_span2-expected.txt:
* platform/wpe/tables/mozilla_expected_failures/other/test4-expected.txt:
* platform/wpe/transforms/3d/hit-testing/backface-hit-test-expected.txt:
* platform/wpe/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt:
* platform/wpe/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
* platform/wpe/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt:
* platform/wpe/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt:
* platform/wpe/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
* platform/wpe/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
* platform/wpe/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
* platform/wpe/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt:
* platform/wpe/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[macOS] Issue temporary sandbox extension to the Launch Services daemon
pvollan@apple.com [Fri, 16 Oct 2020 01:07:27 +0000 (01:07 +0000)]
[macOS] Issue temporary sandbox extension to the Launch Services daemon
https://bugs.webkit.org/show_bug.cgi?id=217781
<rdar://problem/70350924>

Reviewed by Brent Fulgham.

To support blocking of the Launch Services daemon in the WebContent process, issue temporary sandbox extension to this service on macOS.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoLessen the reliance on VPATH in WebCore/DerivedSources.make
krollin@apple.com [Fri, 16 Oct 2020 01:01:22 +0000 (01:01 +0000)]
Lessen the reliance on VPATH in WebCore/DerivedSources.make
https://bugs.webkit.org/show_bug.cgi?id=217696
<rdar://problem/70279941>

Reviewed by Darin Adler.

Due to the way vpath/VPATH works in `make`, we can get into a
situation where necessarily IDL files are not copied to their correct
locations.

WebKit comes with many IDL files. When building for internal purposes,
Apple can add to or modify this set of IDL files. When creating
Engineering builds, these additional IDL files are copied to
.../WebKitBuild/<configuration>/usr/local/includes. When performing
Production builds, these IDL files are included in the SDK. This
arrangement can be seen in DerivedSources.make:

    vpath %.idl $(BUILT_PRODUCTS_DIR)/usr/local/include $(SDKROOT)/usr/local/include

In order to get these IDL files into a location where they can be
uniformly found and handled, there is a step in DerivedSources.make
that copies them to the current directory, which is
WebKitBuild/<configuration>/DerivedSources/WebCore:

    $(ADDITIONAL_BINDING_IDLS) : % : WebKitAdditions/%
    cp $< .

The IDL files specified in ADDITIONAL_BINDING_IDLS are specified as
bare files names, meaning that vpath and VPATH are employed to find
them. Given the vpath specification previously shown, if the IDL files
can be found in $(BUILT_PRODUCTS_DIR)/usr/local/include, they are
copied locally. Otherwise, they should be found in
$(SDKROOT)/usr/local/include and copied locally.

As it turns out, vpath/VPATH resolution is performed not only on the
prerequisites of the build rule, but also the target (see section
4.5.3 of the GNU `make` manual). This means that the files specified
on the left side of the `cp` rule above are also searched for. And
since the standard IDL files (the ones that are being replaced with
the Apple-specific versions) can be found on VPATH as it's defined in
DerivedSources.make (specifically, in $(WebCore)/dom), then those
files participate in determining if the `cp` rule is executed.

Consider the normal build case: repositories are checked out (applying
the current modification timestamp to the files). During the build,
the files in $(ADDITIONAL_BINDING_IDLS) are copied to either
BUILT_PRODUCTS_DIR or to SDKROOT, which again modifies their
timestamps. We eventually get to the build rule for the `cp`
operation. Because the files in WebKitAdditions (be it in the local
build directory or the SDK) are *newer* than the checked-out ones in
$(WebCore)/dom due to their having been copied after they were
checked-out, then the `cp` command is invoked and then files are
copied to the current build directory.

However, consider a slightly different build case. In this case,
projects are checked out and built one at a time. So the project
producing the files in ADDITIONAL_BINDING_IDLS is checked out and then
the IDL files are copied to their intermediate location and have their
timestamps set to that time. Later, WebCore is checked out, and
DerivedSources.make is eventually invoked. Now, the files in
$(WebCore)/dom are *newer* than those in WebKitAdditions. `make`
determines that the IDL files are up-to-date and does not execute the
`cp` commands. The IDL files are not copied, and the build then either
fails (because of missing files) or proceeds incorrectly (because the
wrong IDL files are found).

The solution to this issue is to lessen the reliance on vpath/VPATH in
DerivedSources.make. Instead, be more explicit about where files can
be found and trim down vpath/VPATH to it's bare minimum. With
vpath/VPATH reduced, we remove the issue of files being accidentally
discovered that we don't want discovered.

The modifications effected to make this change are:

- Remove the definition of VPATH.
- Dynamically build up an idl-only "VPATH" as needed with the "vpath"
  directive.
- Manually look for the additional IDL files at their expected
  locations without using vpath/VPATH.
- For the files that used to be found on VPATH, specify their actual
  locations (typically by prefixing them with $(WebCore).
- (Cleanup) Consistently refer to local files with bare names (that
  is, remove the "./" that some files were prefixed with).
- (Cleanup) Use consistent spacing around "<" and ">" redirection
  symbols.
- (Cleanup) Remove some redundant prerequisites from the build rule
  involving IDL_INTERMEDIATE_PATTERNS.

No new tests -- no new or changed functionality.

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoMove AudioContext-specific logic out of BaseAudioContext
cdumez@apple.com [Fri, 16 Oct 2020 00:34:30 +0000 (00:34 +0000)]
Move AudioContext-specific logic out of BaseAudioContext
https://bugs.webkit.org/show_bug.cgi?id=217794

Reviewed by Geoffrey Garen.

Move AudioContext-specific logic out of BaseAudioContext and into the
AudioContext class. This required having WebKitAudioContext subclass
AudioContext instead of BaseAudioContext.

No new tests, no Web-facing behavior change.

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::suspendRendering):
(WebCore::AudioContext::resumeRendering):
(WebCore::AudioContext::nodeWillBeginPlayback):
(WebCore::AudioContext::startRendering):
(WebCore::AudioContext::lazyInitialize):
(WebCore::AudioContext::willPausePlayback):
* Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::AudioContext):
* Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::lazyInitialize):
* Modules/webaudio/BaseAudioContext.h:
(WebCore::BaseAudioContext::nodeWillBeginPlayback):
(WebCore::BaseAudioContext::mediaSession const):
* Modules/webaudio/DefaultAudioDestinationNode.h:
* Modules/webaudio/WebKitAudioContext.cpp:
(WebCore::WebKitAudioContext::WebKitAudioContext):
* Modules/webaudio/WebKitAudioContext.h:
(WebCore::WebKitAudioContext::listener):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoCSSStyleDeclaration breaks JS spec (properties not showing up in Object.getOwnPropert...
weinig@apple.com [Fri, 16 Oct 2020 00:28:16 +0000 (00:28 +0000)]
CSSStyleDeclaration breaks JS spec (properties not showing up in Object.getOwnPropertyNames)
https://bugs.webkit.org/show_bug.cgi?id=217623

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* web-platform-tests/css/cssom/cssstyledeclaration-properties-expected.txt:
Update test result now that it is passing.

Source/WebCore:

Replace named getter/setter based implementation of access to CSSStyleDeclaration property values
with a generated partial interface that lists all the properties exactly.

To keep things consistent with existing behavior, in addition to the spec'd properties, we also
maintain additional properties such as Epub* (in addition to the epub* properties the spec says
we should), and Css, css, Pos, pos, Pixel, and Pixel prefixed properties. As a follow up, we should
consider removing these as they are not supported by the standard or other browsers.

* CMakeLists.txt:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
Generate CSSStyleDeclaration+PropertyNames.idl and ensure it is compile together with the other
bindings.

* css/makeprop.pl:
Add generation of CSSStyleDeclaration+PropertyNames.idl from CSSProperties.json.

* bindings/scripts/IDLAttributes.json:
Remove CallNamedSetterOnlyForSupportedProperties and DefaultDefineOwnProperty extended attributes,
which now have no users, and add the CSSProperty extended attribute, used to avoid unnecessary
implementation overhead for each property. Rather, in an analogous way to EventHandlers, the bindings
now directly pass in the associate CSSPropertyID to an appropriate CSSStyleDeclaration function.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateInvokeNamedPropertySetter):
(GeneratePut):
(GeneratePutByIndex):
(GenerateDefineOwnProperty):
Remove all use of CallNamedSetterOnlyForSupportedProperties.

(InstanceOverridesDefineOwnProperty):
Remove support for DefaultDefineOwnProperty, which is now unused.

(ToMethodName):
Match the actual setting name, and don't transform names that start with CSSOM.

(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):
Add support for the new CSSProperty extended attribute which uses the passsed
value to to directly call CSSStyleDeclaration functions with a CSSPropertyID.

* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::setPropertyValueInternal):
(WebCore::CSSStyleDeclaration::getPropertyValueInternalForPosOrPixelPrefixed):
(WebCore::CSSStyleDeclaration::setPropertyValueInternalForPosOrPixelPrefixed):
(WebCore::CSSStyleDeclaration::getCSSPropertyIDFromJavaScriptPropertyName):
(WebCore::CSSStyleDeclaration::namedItem): Deleted.
(WebCore::CSSStyleDeclaration::setNamedItem): Deleted.
(WebCore::CSSStyleDeclaration::supportedPropertyNames const): Deleted.
* css/CSSStyleDeclaration.h:
Replace old named getter/setter support code with new helpers which operate directly
on CSSPropertyIDs.

* css/CSSStyleDeclaration.idl:
Update to match the current spec (almost, still need to getPropertyPriority to not return
null) and remove custom named getter/setter operations.

LayoutTests:

* fast/css/style-enumerate-properties-expected.txt:
* fast/css/style-enumerate-properties.html:
* fast/dom/domListEnumeration-expected.txt:
* fast/dom/domListEnumeration.html:
Remove tests for iteration order, which is not standardized, and not consistent among
browsers.

* fast/dom/CSSStyleDeclaration/cssstyledeclaration-properties-descriptor-expected.txt:
* fast/dom/CSSStyleDeclaration/cssstyledeclaration-properties-descriptor.html:
Update now that the properties are proper attributes on the prototype.

* js/dom/put-override-should-not-use-ic.html:
Switch to using a DOMStringList as the object that overrides put, since CSSStyleDeclaration no longer does.

* transitions/transitions-parsing-expected.txt:
* transitions/transitions-parsing.html:
Remove Object.keys() aspect of the test, which is no longer meaningful since the
properties should no longer exist in the result set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[macOS] Add telemetry for distributed notification service
pvollan@apple.com [Fri, 16 Oct 2020 00:09:37 +0000 (00:09 +0000)]
[macOS] Add telemetry for distributed notification service
https://bugs.webkit.org/show_bug.cgi?id=217762
<rdar://problem/70341045>

Reviewed by Brent Fulgham.

Add telemetry with backtrace for the distributed notification service on macOS.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoPDFPlugin.mm:2303:139: error: type 'SEL _Nullable' cannot be narrowed to 'bool' in...
ddkilzer@apple.com [Fri, 16 Oct 2020 00:06:17 +0000 (00:06 +0000)]
PDFPlugin.mm:2303:139: error: type 'SEL _Nullable' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing]
<https://webkit.org/b/217791>
<rdar://problem/70349804>

Reviewed by Tim Horton.

* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::handleContextMenuEvent):
- Use `!!` to convert result to `bool`.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[Cocoa] Don't change the text matrix multiple times inside FontCascade::drawGlyphs()
mmaxfield@apple.com [Thu, 15 Oct 2020 23:51:06 +0000 (23:51 +0000)]
[Cocoa] Don't change the text matrix multiple times inside FontCascade::drawGlyphs()
https://bugs.webkit.org/show_bug.cgi?id=217749

Reviewed by Simon Fraser.

FontCascade::drawGlyphs() may actually call CTFontDrawGlyphs() 4 times:
2 for synthetic bold, times 2 for emulated shadows that we draw ourselves.
Previously, each of these calls can have a different text matrix, because
showGlyphsWithAdvances() called CGContextSetTextPosition(), which affects
the text matrix.

This makes https://bugs.webkit.org/show_bug.cgi?id=217506 difficult, because
we don't actually track the text matrix inside the GraphicsContext. In that
patch, we call FontCascade::drawGlyphs() and intercept the resulting CGContext
calls. However, if we detect a modified text matrix inside those CGContext
calls, we have no way of knowing whether it was modified by WebKit or
internally inside Core Text. We need to know this, though, because the
modifications Core Text makes have to be preserved across to the GPU process,
but the modifications WebKit makes need to not be preserved (since the GPU
process will make them naturally).

Tracking the text matrix in the CGContext (a la the CTM) is unnecessary; all
we need to know is whether WebKit changed it or Core Text changed it. Therefore,
this patch migrates all the text matrix computation into standalone functions
that can be called from GPU Process infrastructure, so we can know what WebKit
does there (and also what Core Text does, by omission).

This only works, though, if the text matrix is identical for all the calls to
CTFontDrawGlyphs() inside FontCascade::drawGlyphs(). This patch enforces this
by emulating CGContextSetTextPosition() ourselves by adding a constant to
all the glyph positions. Performance is not a conern because we already iterate
over all the glyphs inside showGlyphsWithAdvances(), so we're already paying
the cost of the loop.

No new tests because there is no behavior change.

* platform/graphics/FontCascade.h:
(WebCore::FontCascade::syntheticObliqueAngle): Deleted.
* platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::showLetterpressedGlyphsWithAdvances):
* platform/graphics/coretext/FontCascadeCoreText.cpp:
(WebCore::rotateLeftTransform):
(WebCore::fillVectorWithHorizontalGlyphPositions):
(WebCore::fillVectorWithVerticalGlyphPositions):
(WebCore::showGlyphsWithAdvances):
(WebCore::computeOverallTextMatrix):
(WebCore::computeVerticalTextMatrix):
(WebCore::FontCascade::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoCache JS arguments in AudioWorkletProcessor::process() for performance
cdumez@apple.com [Thu, 15 Oct 2020 23:41:51 +0000 (23:41 +0000)]
Cache JS arguments in AudioWorkletProcessor::process() for performance
https://bugs.webkit.org/show_bug.cgi?id=217685

Reviewed by Geoffrey Garen.

Cache JS arguments in AudioWorkletProcessor::process() for performance.
Blink has the same optimization here:
- https://github.com/chromium/chromium/blob/master/third_party/blink/renderer/modules/webaudio/audio_worklet_processor.cc

No new tests, no Web-facing behavior change.

* Modules/webaudio/AudioWorkletProcessor.cpp:
(WebCore::busChannelCount):
(WebCore::constructFrozenJSArray):
(WebCore::copyDataFromJSArrayToBuses):
(WebCore::copyDataFromBusesToJSArray):
(WebCore::copyDataFromParameterMapToJSObject):
(WebCore::busTopologyMatchesJSArray):
(WebCore::parameterMapTopologyMatchesJSObject):
(WebCore::zeroJSArray):
(WebCore::AudioWorkletProcessor::buildJSArguments):
(WebCore::AudioWorkletProcessor::process):
* Modules/webaudio/AudioWorkletProcessor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[Cocoa] Simplify logic for caching FFTSetups in FFTFrame
cdumez@apple.com [Thu, 15 Oct 2020 22:27:21 +0000 (22:27 +0000)]
[Cocoa] Simplify logic for caching FFTSetups in FFTFrame
https://bugs.webkit.org/show_bug.cgi?id=217782

Reviewed by Eric Carlson.

Simplify logic for caching FFTSetups in FFTFrame:
- Use a local static (NeverDestroyed) to cache the FFTSetups to avoid
  heap allocation and simplify logic a bit.
- Drop FFTFrame::cleanup() since it is dead code.

No new tests, no Web-facing behavior change.

* platform/audio/FFTFrame.h:
* platform/audio/FFTFrameStub.cpp:
* platform/audio/gstreamer/FFTFrameGStreamer.cpp:
* platform/audio/mac/FFTFrameMac.cpp:
(WebCore::FFTFrame::fftSetupForSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoUse std::fill_n() instead of for loops in ConstantSourceNode
cdumez@apple.com [Thu, 15 Oct 2020 22:24:27 +0000 (22:24 +0000)]
Use std::fill_n() instead of for loops in ConstantSourceNode
https://bugs.webkit.org/show_bug.cgi?id=217777

Reviewed by Eric Carlson.

Use std::fill_n() instead of for loops in ConstantSourceNode.

No new tests, no Web-facing behavior change.

* Modules/webaudio/ConstantSourceNode.cpp:
(WebCore::ConstantSourceNode::process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoAvoid double zero'ing of AudioArray in DelayDSPKernel constructors
cdumez@apple.com [Thu, 15 Oct 2020 22:02:32 +0000 (22:02 +0000)]
Avoid double zero'ing of AudioArray in DelayDSPKernel constructors
https://bugs.webkit.org/show_bug.cgi?id=217779

Reviewed by Darin Adler.

Avoid double zero'ing of AudioArray in DelayDSPKernel constructors.
The constructors were calling AudioArray::resize() to allocate the
array memory and then AudioArray::zero() to zero-out the memory.
The second step is unnecessary since AudioArray::resize() already
takes care of zeroing out the memory after allocation.

No new tests, no Web-facing behavior change.

* Modules/webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::DelayDSPKernel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoRebaseline tests for Catalina and iOS after the changes in r268520
tsavell@apple.com [Thu, 15 Oct 2020 21:59:52 +0000 (21:59 +0000)]
Rebaseline tests for Catalina and iOS after the changes in r268520
https://bugs.webkit.org/show_bug.cgi?id=209813

Unreviewed test gardening.

* platform/ios-wk2/fast/block/basic/001-expected.txt: Added.
* platform/mac-catalina/fast/block/basic/001-expected.txt: Added.
* platform/mac-catalina/fast/forms/button-table-styles-expected.txt:
* platform/mac-catalina/fast/forms/input-disabled-color-expected.txt:
* platform/mac-catalina/fast/forms/input-readonly-dimmed-expected.txt:
* platform/mac-catalina/fast/forms/plaintext-mode-2-expected.txt:
* platform/mac-catalina/fast/forms/select-change-popup-to-listbox-expected.txt:
* platform/mac-catalina/fast/text/indic-expected.txt: Added.
* platform/mac-catalina/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
* platform/mac-catalina/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoUse std::fill_n() instead of for loops in AudioParamTimeline
cdumez@apple.com [Thu, 15 Oct 2020 21:26:56 +0000 (21:26 +0000)]
Use std::fill_n() instead of for loops in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=217775

Reviewed by Darin Adler.

Use std::fill_n() instead of for loops in AudioParamTimeline.

No new tests, no Web facing behavior change.

* Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::fillWithValue):
(WebCore::AudioParamTimeline::valuesForFrameRange):
(WebCore::AudioParamTimeline::valuesForFrameRangeImpl):
(WebCore::AudioParamTimeline::processExponentialRamp):
(WebCore::AudioParamTimeline::processCancelValues):
(WebCore::AudioParamTimeline::processSetTarget):
(WebCore::AudioParamTimeline::processSetValueCurve):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoUse std::fill_n() instead of for loops in AudioParam::calculateFinalValues()
cdumez@apple.com [Thu, 15 Oct 2020 21:15:18 +0000 (21:15 +0000)]
Use std::fill_n() instead of for loops in AudioParam::calculateFinalValues()
https://bugs.webkit.org/show_bug.cgi?id=217766

Reviewed by Geoffrey Garen.

Use std::fill_n() instead of for loops in AudioParam::calculateFinalValues().

No new tests, no Web-facing behavior change.

* Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::calculateFinalValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoAdd a fast codepath to compute the bounding rect of an inline arc path
wenson_hsieh@apple.com [Thu, 15 Oct 2020 20:56:03 +0000 (20:56 +0000)]
Add a fast codepath to compute the bounding rect of an inline arc path
https://bugs.webkit.org/show_bug.cgi?id=217764

Reviewed by Tim Horton.

This is a followup to r268320, which added an implementation of `Path::fastBoundingRect` for the inline
`ArcData` case, but left `Path::boundingRect` as-is. This means that currently, a call to `Path::boundingRect`
in the case of a simple arc path (represented in `ArcData`) will cause a `CGPath` to be allocated and set up,
when we could instead just compute the exact bounds of the path using the center, radius, and start and end
angles.

* platform/graphics/Path.cpp:
(WebCore::computeArcBounds):

Add a helper function to compute the exact bounds of a circular arc. This helper works by first fitting the rect
to the start and end positions, and then extending to the top, left, bottom, or right edges as needed (i.e. if
the start and end angles intersect the top-, left-, bottom- or right-most points in the circle).

(WebCore::Path::boundingRectFromInlineData const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[WebIDL] Bindings do not support two attributes or functions with the same name only...
weinig@apple.com [Thu, 15 Oct 2020 20:40:34 +0000 (20:40 +0000)]
[WebIDL] Bindings do not support two attributes or functions with the same name only differing by case of first character
https://bugs.webkit.org/show_bug.cgi?id=217776

Reviewed by Chris Dumez.

Due to needing to support cases like CSSStyleDeclaration#webkitAlignSelf and CSSStyleDeclaration#WebkitAlignSelf,
the naming convention for the c-wrapper functions in the generated bindings had to be updated to not ignore the
case of the leading character. The new convention uses a leading _ (unless the identifier already starts with one)
changing a function such as jsDOMWindowInstanceFunctionShowModalDialog to jsDOMWindowInstanceFunction_showModalDialog.

* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSLocationCustom.cpp:
Update for new c-function naming convention.

* bindings/scripts/CodeGeneratorJS.pm:
(MangleAttributeOrFunctionName):
(GetAttributeGetterName):
(GetAttributeSetterName):
(GetFunctionName):
Add a leading underscore to all mangled attribute and function names and remove
leading capitalization. This allows us to have attributes and functions with the
same name except for the capitalization of the first letter.

* bindings/scripts/test/JS/*:
Update bindings test results for new c-function naming scheme.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[WinCairo] Unreviewed test gardening
Hironori.Fujii@sony.com [Thu, 15 Oct 2020 20:26:11 +0000 (20:26 +0000)]
[WinCairo] Unreviewed test gardening

* platform/wincairo/css1/box_properties/float_on_text_elements-expected.txt:
* platform/wincairo/css1/color_and_background/background_attachment-expected.txt:
* platform/wincairo/css1/text_properties/text_indent-expected.txt:
* platform/wincairo/editing/deleting/5272440-expected.txt:
* platform/wincairo/editing/deleting/delete-3608445-fix-expected.txt:
* platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
* platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
* platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
* platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
* platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
* platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
* platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
* platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
* platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
* platform/wincairo/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
* platform/wincairo/editing/deleting/delete-block-merge-contents-002-expected.txt:
* platform/wincairo/editing/deleting/delete-block-merge-contents-003-expected.txt:
* platform/wincairo/editing/deleting/delete-block-merge-contents-004-expected.txt:
* platform/wincairo/editing/deleting/delete-block-merge-contents-006-expected.txt:
* platform/wincairo/editing/deleting/delete-block-merge-contents-007-expected.txt:
* platform/wincairo/editing/deleting/delete-block-merge-contents-009-expected.txt:
* platform/wincairo/editing/deleting/delete-block-merge-contents-011-expected.txt:
* platform/wincairo/editing/deleting/delete-br-002-expected.txt:
* platform/wincairo/editing/deleting/delete-br-003-expected.txt:
* platform/wincairo/editing/deleting/delete-br-004-expected.txt:
* platform/wincairo/editing/deleting/delete-br-005-expected.txt:
* platform/wincairo/editing/deleting/delete-image-001-expected.txt:
* platform/wincairo/editing/deleting/delete-image-002-expected.txt:
* platform/wincairo/editing/deleting/delete-line-003-expected.txt:
* platform/wincairo/editing/deleting/delete-trailing-ws-002-expected.txt:
* platform/wincairo/editing/deleting/non-smart-delete-expected.txt:
* platform/wincairo/editing/execCommand/4641880-1-expected.txt:
* platform/wincairo/editing/execCommand/4641880-2-expected.txt:
* platform/wincairo/editing/execCommand/4916541-expected.txt:
* platform/wincairo/editing/execCommand/5080333-1-expected.txt:
* platform/wincairo/editing/execCommand/5080333-2-expected.txt:
* platform/wincairo/editing/execCommand/5569741-expected.txt:
* platform/wincairo/editing/execCommand/indent-selection-expected.txt:
* platform/wincairo/editing/execCommand/remove-list-from-range-selection-expected.txt:
* platform/wincairo/editing/input/emacs-ctrl-o-expected.txt:
* platform/wincairo/editing/inserting/4960120-2-expected.txt:
* platform/wincairo/editing/inserting/5002441-expected.txt:
* platform/wincairo/editing/inserting/5156401-2-expected.txt:
* platform/wincairo/editing/inserting/5510537-expected.txt:
* platform/wincairo/editing/inserting/5549929-3-expected.txt:
* platform/wincairo/editing/inserting/6703873-expected.txt:
* platform/wincairo/editing/inserting/break-blockquote-after-delete-expected.txt:
* platform/wincairo/editing/inserting/insert-3775316-fix-expected.txt:
* platform/wincairo/editing/inserting/insert-3778059-fix-expected.txt:
* platform/wincairo/editing/inserting/insert-br-001-expected.txt:
* platform/wincairo/editing/inserting/insert-br-002-expected.txt:
* platform/wincairo/editing/inserting/insert-br-003-expected.txt:
* platform/wincairo/editing/inserting/insert-br-004-expected.txt:
* platform/wincairo/editing/inserting/insert-br-005-expected.txt:
* platform/wincairo/editing/inserting/insert-br-007-expected.txt:
* platform/wincairo/editing/inserting/insert-br-at-tabspan-001-expected.txt:
* platform/wincairo/editing/inserting/insert-br-at-tabspan-002-expected.txt:
* platform/wincairo/editing/inserting/insert-br-at-tabspan-003-expected.txt:
* platform/wincairo/editing/inserting/insert-br-quoted-001-expected.txt:
* platform/wincairo/editing/inserting/insert-br-quoted-002-expected.txt:
* platform/wincairo/editing/inserting/insert-br-quoted-003-expected.txt:
* platform/wincairo/editing/inserting/insert-br-quoted-004-expected.txt:
* platform/wincairo/editing/inserting/insert-br-quoted-005-expected.txt:
* platform/wincairo/editing/inserting/insert-br-quoted-006-expected.txt:
* platform/wincairo/editing/inserting/insert-div-020-expected.txt:
* platform/wincairo/editing/inserting/insert-div-022-expected.txt:
* platform/wincairo/editing/inserting/insert-div-026-expected.txt:
* platform/wincairo/editing/inserting/insert-paragraph-03-expected.txt:
* platform/wincairo/editing/inserting/insert-text-with-newlines-expected.txt:
* platform/wincairo/editing/inserting/paragraph-separator-in-table-1-expected.txt:
* platform/wincairo/editing/inserting/paragraph-separator-in-table-2-expected.txt:
* platform/wincairo/editing/inserting/return-key-with-selection-001-expected.txt:
* platform/wincairo/editing/inserting/return-key-with-selection-002-expected.txt:
* platform/wincairo/editing/inserting/return-key-with-selection-003-expected.txt:
* platform/wincairo/editing/inserting/typing-around-br-001-expected.txt:
* platform/wincairo/editing/selection/3690703-2-expected.txt:
* platform/wincairo/editing/selection/3690703-expected.txt:
* platform/wincairo/editing/selection/3690719-expected.txt:
* platform/wincairo/editing/selection/4975120-expected.txt:
* platform/wincairo/editing/selection/5007143-2-expected.txt:
* platform/wincairo/editing/selection/5007143-expected.txt:
* platform/wincairo/editing/selection/drag-in-iframe-expected.txt:
* platform/wincairo/editing/selection/editable-html-element-expected.txt:
* platform/wincairo/editing/selection/extend-by-character-002-expected.txt:
* platform/wincairo/editing/selection/extend-by-character-004-expected.txt:
* platform/wincairo/editing/selection/extend-selection-bidi-expected.txt:
* platform/wincairo/editing/selection/focus_editable_html-expected.txt:
* platform/wincairo/editing/selection/image-before-linebreak-expected.txt:
* platform/wincairo/editing/selection/move-3875618-fix-expected.txt:
* platform/wincairo/editing/selection/move-backwords-by-word-001-expected.txt:
* platform/wincairo/editing/selection/move-by-character-002-expected.txt:
* platform/wincairo/editing/selection/move-by-character-004-expected.txt:
* platform/wincairo/editing/selection/move-by-sentence-linebreak-expected.txt:
* platform/wincairo/editing/selection/paragraph-granularity-expected.txt:
* platform/wincairo/editing/selection/replaced-boundaries-3-expected.txt:
* platform/wincairo/editing/selection/select-all-002-expected.txt:
* platform/wincairo/editing/selection/select-all-003-expected.txt:
* platform/wincairo/editing/selection/select-all-iframe-expected.txt:
* platform/wincairo/editing/selection/selectNode-expected.txt:
* platform/wincairo/editing/selection/selectNodeContents-expected.txt:
* platform/wincairo/editing/selection/selection-3748164-fix-expected.txt:
* platform/wincairo/editing/selection/selection-actions-expected.txt:
* platform/wincairo/editing/selection/word-granularity-expected.txt:
* platform/wincairo/editing/style/5046875-2-expected.txt:
* platform/wincairo/editing/style/block-styles-007-expected.txt:
* platform/wincairo/editing/style/create-block-for-style-001-expected.txt:
* platform/wincairo/editing/style/create-block-for-style-002-expected.txt:
* platform/wincairo/editing/style/create-block-for-style-003-expected.txt:
* platform/wincairo/editing/style/create-block-for-style-004-expected.txt:
* platform/wincairo/editing/style/create-block-for-style-013-expected.txt:
* platform/wincairo/editing/style/smoosh-styles-001-expected.txt:
* platform/wincairo/editing/style/smoosh-styles-003-expected.txt:
* platform/wincairo/editing/style/style-3998892-fix-expected.txt:
* platform/wincairo/editing/style/style-boundary-001-expected.txt:
* platform/wincairo/editing/style/style-boundary-002-expected.txt:
* platform/wincairo/editing/style/style-boundary-003-expected.txt:
* platform/wincairo/editing/style/style-boundary-004-expected.txt:
* platform/wincairo/editing/style/style-boundary-005-expected.txt:
* platform/wincairo/editing/unsupported-content/list-delete-001-expected.txt:
* platform/wincairo/editing/unsupported-content/list-delete-003-expected.txt:
* platform/wincairo/editing/unsupported-content/list-type-after-expected.txt:
* platform/wincairo/editing/unsupported-content/list-type-before-expected.txt:
* platform/wincairo/editing/unsupported-content/table-delete-002-expected.txt:
* platform/wincairo/editing/unsupported-content/table-type-after-expected.txt:
* platform/wincairo/editing/unsupported-content/table-type-before-expected.txt:
* platform/wincairo/fast/box-shadow/basic-shadows-expected.txt:
* platform/wincairo/fast/clip/nestedTransparencyClip-expected.txt:
* platform/wincairo/fast/clip/overflow-border-radius-combinations-expected.txt:
* platform/wincairo/fast/clip/overflow-border-radius-composited-expected.txt:
* platform/wincairo/fast/clip/overflow-border-radius-transformed-expected.txt:
* platform/wincairo/fast/css-generated-content/inline-display-types-expected.txt:
* platform/wincairo/fast/css-generated-content/table-row-group-to-inline-expected.txt:
* platform/wincairo/fast/css-generated-content/table-row-group-with-before-expected.txt:
* platform/wincairo/fast/css-generated-content/table-row-with-before-expected.txt:
* platform/wincairo/fast/css-generated-content/table-with-before-expected.txt:
* platform/wincairo/fast/css/001-expected.txt:
* platform/wincairo/fast/css/first-letter-first-line-hover-expected.txt:
* platform/wincairo/fast/css/first-line-text-decoration-expected.txt:
* platform/wincairo/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
* platform/wincairo/fast/css/focus-ring-detached-expected.txt:
* platform/wincairo/fast/css/font-smoothing-expected.txt:
* platform/wincairo/fast/css/hsl-color-expected.txt:
* platform/wincairo/fast/css/input-search-padding-expected.txt:
* platform/wincairo/fast/css/layerZOrderCrash-expected.txt:
* platform/wincairo/fast/css/line-height-overflow-expected.txt:
* platform/wincairo/fast/css/nth-child-dynamic-expected.txt:
* platform/wincairo/fast/css/outline-narrowLine-expected.txt:
* platform/wincairo/fast/css/rtl-ordering-expected.txt:
* platform/wincairo/fast/css/text-overflow-ellipsis-expected.txt:
* platform/wincairo/fast/css/text-rendering-expected.txt:
* platform/wincairo/fast/css/word-space-extra-expected.txt:
* platform/wincairo/fast/dom/HTMLElement/bdo-expected.txt:
* platform/wincairo/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
* platform/wincairo/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
* platform/wincairo/fast/dom/HTMLTableElement/colSpan-expected.txt:
* platform/wincairo/fast/dom/HTMLTableElement/createCaption-expected.txt:
* platform/wincairo/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
* platform/wincairo/fast/dom/children-nodes-expected.txt:
* platform/wincairo/fast/dom/focus-contenteditable-expected.txt:
* platform/wincairo/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.txt:
* platform/wincairo/fast/dynamic/genContentDestroyChildren-expected.txt:
* platform/wincairo/fast/events/standalone-image-drag-to-editable-expected.txt:
* platform/wincairo/fast/inline-block/001-expected.txt:
* platform/wincairo/fast/inline-block/006-expected.txt:
* platform/wincairo/fast/inline-block/contenteditable-baseline-expected.txt:
* platform/wincairo/fast/inline-block/inline-block-vertical-align-expected.txt:
* platform/wincairo/fast/inline-block/tricky-baseline-expected.txt:
* platform/wincairo/fast/line-grid/line-grid-contains-value-expected.txt:
* platform/wincairo/fast/line-grid/line-grid-floating-expected.txt:
* platform/wincairo/fast/line-grid/line-grid-inside-columns-expected.txt:
* platform/wincairo/fast/line-grid/line-grid-into-columns-expected.txt:
* platform/wincairo/fast/line-grid/line-grid-into-floats-expected.txt:
* platform/wincairo/fast/line-grid/line-grid-positioned-expected.txt:
* platform/wincairo/fast/reflections/reflection-direction-expected.txt:
* platform/wincairo/fast/text/basic/012-expected.txt:
* platform/wincairo/fast/text/basic/014-expected.txt:
* platform/wincairo/fast/text/basic/generic-family-reset-expected.txt:
* platform/wincairo/fast/text/capitalize-boundaries-expected.txt:
* platform/wincairo/fast/text/complex-synthetic-bold-space-width-expected.txt:
* platform/wincairo/fast/text/firstline/001-expected.txt:
* platform/wincairo/fast/text/indic-expected.txt:
* platform/wincairo/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
* platform/wincairo/fast/text/international/bidi-layout-across-linebreak-expected.txt:
* platform/wincairo/fast/text/international/bidi-listbox-atsui-expected.txt:
* platform/wincairo/fast/text/international/bidi-listbox-expected.txt:
* platform/wincairo/fast/text/international/bidi-menulist-expected.txt:
* platform/wincairo/fast/text/international/hebrew-vowels-expected.txt:
* platform/wincairo/fast/text/international/hindi-spacing-expected.txt:
* platform/wincairo/fast/text/international/thai-baht-space-expected.txt:
* platform/wincairo/fast/text/midword-break-after-breakable-char-expected.txt:
* platform/wincairo/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
* platform/wincairo/fonts/cursive-expected.txt:
* platform/wincairo/fonts/default-expected.txt:
* platform/wincairo/fonts/monospace-expected.txt:
* platform/wincairo/fonts/sans-serif-expected.txt:
* platform/wincairo/fonts/serif-expected.txt:
* platform/wincairo/http/tests/misc/favicon-as-image-expected.txt:
* platform/wincairo/http/tests/misc/frame-access-during-load-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[webkitpy] Use webkitcorepy's autoinstaller for mechanize
jbedard@apple.com [Thu, 15 Oct 2020 20:24:15 +0000 (20:24 +0000)]
[webkitpy] Use webkitcorepy's autoinstaller for mechanize
https://bugs.webkit.org/show_bug.cgi?id=217683
<rdar://problem/70272262>

Reviewed by Aakash Jain.

* Scripts/webkitpy/__init__.py: Add mechanize.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._get_browser):
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
* Scripts/webkitpy/common/net/ewsserver.py:
(EWSServer.__init__):
* Scripts/webkitpy/common/net/networktransaction_unittest.py:
(NetworkTransactionTest._raise_500_error):
(NetworkTransactionTest._raise_URLError):
(NetworkTransactionTest._raise_404_error):
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook.find_module): Remov _install_mechanize().
(AutoinstallImportHook._install_mechanize): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[WinCairo][GraphicsLayerTextureMapper] css3/filters/backdrop/backdrop-filter-with...
Hironori.Fujii@sony.com [Thu, 15 Oct 2020 19:55:00 +0000 (19:55 +0000)]
[WinCairo][GraphicsLayerTextureMapper] css3/filters/backdrop/backdrop-filter-with-border-radius-and-reflection-remove.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=217746

Reviewed by Don Olmstead.

If replica layers is removed, replicaLayer() and can be null in
commitLayerChanges(). Null checking is needed.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges): Added null checking for maskLayer() and replicaLayer().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoUpdating an individual transform CSS property has no visual change when composited
graouts@webkit.org [Thu, 15 Oct 2020 19:49:00 +0000 (19:49 +0000)]
Updating an individual transform CSS property has no visual change when composited
https://bugs.webkit.org/show_bug.cgi?id=217769
<rdar://problem/70344280>

Reviewed by Simon Fraser.

Source/WebCore:

Ensure that changes to the translate, scale and rotate CSS properties have the same
effect than when the transform property is changed for composited elements.

Tests: transforms/2d/rotate-change-composited.html
       transforms/2d/scale-change-composited.html
       transforms/2d/translate-change-composited.html

* platform/graphics/transforms/RotateTransformOperation.h:
* platform/graphics/transforms/ScaleTransformOperation.h:
* platform/graphics/transforms/TranslateTransformOperation.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::recompositeChangeRequiresGeometryUpdate):
(WebCore::styleHas3DTransformOperation):
(WebCore::styleTransformOperationsAreRepresentableIn2D):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform const):
(WebCore::RenderLayerCompositor::layerHas3DContent const):

LayoutTests:

Add new tests that check that changing the value of one of the individual transform
CSS properties when the element is composited yields a visual change.

* transforms/2d/rotate-change-composited-expected.html: Added.
* transforms/2d/rotate-change-composited.html: Added.
* transforms/2d/scale-change-composited-expected.html: Added.
* transforms/2d/scale-change-composited.html: Added.
* transforms/2d/translate-change-composited-expected.html: Added.
* transforms/2d/translate-change-composited.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[WinCairo][GraphicsLayerTextureMapper] A parent layer's filter isn't applied to its...
Hironori.Fujii@sony.com [Thu, 15 Oct 2020 19:48:05 +0000 (19:48 +0000)]
[WinCairo][GraphicsLayerTextureMapper] A parent layer's filter isn't applied to its child layer at the first paint
https://bugs.webkit.org/show_bug.cgi?id=217748

Reviewed by Don Olmstead.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setFilters): Removed
unnecessary checking of m_layer.textureMapper().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[GTK] Rebaseline after r268520
clopez@igalia.com [Thu, 15 Oct 2020 19:39:54 +0000 (19:39 +0000)]
[GTK] Rebaseline after r268520

Unreviewed gardening.

Merged some expectations on the general baseline that were common to GTK and Mac.
And added platform baselines for the others.

* fast/css/font-face-remote-expected.txt:
* fast/multicol/pagination-h-horizontal-bt-expected.txt:
* fast/multicol/pagination-h-horizontal-tb-expected.txt:
* fast/multicol/pagination-h-vertical-lr-expected.txt:
* fast/multicol/pagination-h-vertical-rl-expected.txt:
* fast/multicol/pagination-v-horizontal-bt-expected.txt:
* fast/multicol/pagination-v-horizontal-tb-expected.txt:
* fast/multicol/pagination-v-vertical-lr-expected.txt:
* fast/multicol/pagination-v-vertical-rl-expected.txt:
* fast/repaint/text-emphasis-h-expected.txt:
* fast/repaint/text-emphasis-v-expected.txt:
* fast/ruby/position-after-expected.txt:
* fast/text/decorations-transformed-expected.txt:
* fast/text/soft-hyphen-4-expected.txt:
* platform/glib/fast/backgrounds/border-radius-split-background-expected.txt:
* platform/glib/fast/backgrounds/border-radius-split-background-image-expected.txt:
* platform/glib/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
* platform/glib/fast/block/positioning/differing-writing-modes-expected.txt:
* platform/glib/fast/block/positioning/differing-writing-modes-replaced-expected.txt:
* platform/glib/fast/block/positioning/trailing-space-test-expected.txt:
* platform/glib/fast/borders/border-image-outset-split-inline-expected.txt:
* platform/glib/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt:
* platform/glib/fast/borders/border-styles-split-expected.txt:
* platform/glib/fast/css-generated-content/table-row-group-to-inline-expected.txt:
* platform/glib/fast/css-generated-content/table-row-group-with-before-expected.txt:
* platform/glib/fast/css-generated-content/table-row-with-before-expected.txt:
* platform/glib/fast/css-generated-content/table-with-before-expected.txt:
* platform/glib/fast/css/001-expected.txt:
* platform/glib/fast/css/first-letter-first-line-hover-expected.txt:
* platform/glib/fast/css/focus-ring-detached-expected.txt:
* platform/glib/fast/css/font-smoothing-expected.txt:
* platform/glib/fast/css/outline-narrowLine-expected.txt:
* platform/glib/fast/css/word-space-extra-expected.txt:
* platform/glib/fast/dynamic/genContentDestroyChildren-expected.txt:
* platform/glib/fast/frames/001-expected.txt:
* platform/glib/fast/hidpi/image-set-border-image-comparison-expected.txt:
* platform/glib/fast/inline-block/001-expected.txt:
* platform/glib/fast/inline-block/006-expected.txt:
* platform/glib/fast/inline-block/tricky-baseline-expected.txt:
* platform/glib/fast/inline/positionedLifetime-expected.txt:
* platform/glib/fast/invalid/010-expected.txt:
* platform/glib/fast/layers/overflow-scroll-auto-switch-expected.txt:
* platform/glib/fast/multicol/column-break-with-balancing-expected.txt:
* platform/glib/fast/multicol/column-count-with-rules-expected.txt:
* platform/glib/fast/multicol/float-paginate-empty-lines-expected.txt:
* platform/glib/fast/multicol/float-paginate-expected.txt:
* platform/glib/fast/multicol/paginate-block-replaced-expected.txt:
* platform/glib/fast/multicol/positioned-split-expected.txt:
* platform/glib/fast/multicol/table-vertical-align-expected.txt:
* platform/glib/fast/multicol/unsplittable-inline-block-expected.txt:
* platform/glib/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
* platform/glib/fast/multicol/vertical-lr/column-count-with-rules-expected.txt:
* platform/glib/fast/multicol/vertical-lr/float-paginate-expected.txt:
* platform/glib/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt:
* platform/glib/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
* platform/glib/fast/multicol/vertical-rl/column-count-with-rules-expected.txt:
* platform/glib/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
* platform/glib/fast/multicol/vertical-rl/float-paginate-expected.txt:
* platform/glib/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt:
* platform/glib/fast/overflow/002-expected.txt:
* platform/glib/fast/overflow/overflow-float-stacking-expected.txt:
* platform/glib/fast/reflections/reflection-direction-expected.txt:
* platform/glib/fast/replaced/007-expected.txt:
* platform/glib/fast/table/005-expected.txt:
* platform/glib/fast/table/039-expected.txt:
* platform/glib/fast/transforms/transformed-caret-expected.txt:
* platform/glib/fast/writing-mode/basic-vertical-line-expected.txt:
* platform/glib/fast/writing-mode/basic-vertical-line-mixed-expected.txt:
* platform/glib/fast/writing-mode/border-styles-vertical-lr-expected.txt:
* platform/glib/fast/writing-mode/border-styles-vertical-lr-mixed-expected.txt:
* platform/glib/fast/writing-mode/border-styles-vertical-rl-expected.txt:
* platform/glib/fast/writing-mode/border-styles-vertical-rl-mixed-expected.txt:
* platform/glib/scrollbars/basic-scrollbar-expected.txt:
* platform/glib/scrollbars/disabled-scrollbar-expected.txt:
* platform/glib/scrollbars/scrollbar-buttons-expected.txt:
* platform/glib/scrollbars/scrollbar-orientation-expected.txt:
* platform/glib/svg/as-image/animated-svg-as-image-expected.txt:
* platform/glib/svg/as-image/animated-svg-as-image-same-image-expected.txt:
* platform/glib/tables/mozilla/bugs/bug11026-expected.txt:
* platform/glib/tables/mozilla/bugs/bug149275-1-expected.txt:
* platform/glib/tables/mozilla/bugs/bug19061-1-expected.txt:
* platform/glib/tables/mozilla/bugs/bug19061-2-expected.txt:
* platform/glib/tables/mozilla/bugs/bug28341-expected.txt:
* platform/glib/tables/mozilla/bugs/bug4093-expected.txt:
* platform/glib/tables/mozilla/bugs/bug4284-expected.txt:
* platform/glib/tables/mozilla/bugs/bug43854-1-expected.txt:
* platform/glib/tables/mozilla/bugs/bug4849-2-expected.txt:
* platform/glib/tables/mozilla/bugs/bug5838-expected.txt:
* platform/glib/tables/mozilla/bugs/bug60992-expected.txt:
* platform/glib/tables/mozilla/bugs/bug625-expected.txt:
* platform/glib/tables/mozilla/bugs/bug6404-expected.txt:
* platform/glib/tables/mozilla/bugs/bug8950-expected.txt:
* platform/glib/tables/mozilla/bugs/bug92868-expected.txt:
* platform/glib/tables/mozilla/bugs/bug963-expected.txt:
* platform/glib/tables/mozilla/core/col_widths_fix_auto-expected.txt:
* platform/glib/tables/mozilla/marvin/table_row_align_center-expected.txt:
* platform/glib/tables/mozilla/marvin/table_row_align_left-expected.txt:
* platform/glib/tables/mozilla/marvin/table_row_align_right-expected.txt:
* platform/glib/tables/mozilla/marvin/tables_align_center-expected.txt:
* platform/glib/tables/mozilla/marvin/tables_align_left-expected.txt:
* platform/glib/tables/mozilla/marvin/tables_align_right-expected.txt:
* platform/glib/tables/mozilla/marvin/tables_border_0-expected.txt:
* platform/glib/tables/mozilla/marvin/tables_default-expected.txt:
* platform/glib/tables/mozilla/other/nestedTables-expected.txt:
* platform/glib/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
* platform/glib/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
* platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
* platform/gtk/css1/color_and_background/background_attachment-expected.txt:
* platform/gtk/css1/text_properties/text_indent-expected.txt:
* platform/gtk/editing/deleting/5272440-expected.txt:
* platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-002-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-003-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-004-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-006-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-007-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-009-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-011-expected.txt:
* platform/gtk/editing/deleting/delete-br-002-expected.txt:
* platform/gtk/editing/deleting/delete-br-003-expected.txt:
* platform/gtk/editing/deleting/delete-br-004-expected.txt:
* platform/gtk/editing/deleting/delete-br-005-expected.txt:
* platform/gtk/editing/deleting/delete-image-001-expected.txt:
* platform/gtk/editing/deleting/delete-image-002-expected.txt:
* platform/gtk/editing/deleting/delete-line-003-expected.txt:
* platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
* platform/gtk/editing/deleting/non-smart-delete-expected.txt:
* platform/gtk/editing/execCommand/4641880-1-expected.txt:
* platform/gtk/editing/execCommand/4641880-2-expected.txt:
* platform/gtk/editing/execCommand/4916541-expected.txt:
* platform/gtk/editing/execCommand/5080333-1-expected.txt:
* platform/gtk/editing/execCommand/5080333-2-expected.txt:
* platform/gtk/editing/execCommand/5569741-expected.txt:
* platform/gtk/editing/execCommand/indent-selection-expected.txt:
* platform/gtk/editing/execCommand/remove-list-from-range-selection-expected.txt:
* platform/gtk/editing/input/emacs-ctrl-o-expected.txt:
* platform/gtk/editing/inserting/4960120-2-expected.txt:
* platform/gtk/editing/inserting/5002441-expected.txt:
* platform/gtk/editing/inserting/5156401-2-expected.txt:
* platform/gtk/editing/inserting/5510537-expected.txt:
* platform/gtk/editing/inserting/5549929-3-expected.txt:
* platform/gtk/editing/inserting/6703873-expected.txt:
* platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
* platform/gtk/editing/inserting/insert-3778059-fix-expected.txt:
* platform/gtk/editing/inserting/insert-br-001-expected.txt:
* platform/gtk/editing/inserting/insert-br-002-expected.txt:
* platform/gtk/editing/inserting/insert-br-003-expected.txt:
* platform/gtk/editing/inserting/insert-br-004-expected.txt:
* platform/gtk/editing/inserting/insert-br-005-expected.txt:
* platform/gtk/editing/inserting/insert-br-007-expected.txt:
* platform/gtk/editing/inserting/insert-br-at-tabspan-001-expected.txt:
* platform/gtk/editing/inserting/insert-br-at-tabspan-002-expected.txt:
* platform/gtk/editing/inserting/insert-br-at-tabspan-003-expected.txt:
* platform/gtk/editing/inserting/insert-br-quoted-001-expected.txt:
* platform/gtk/editing/inserting/insert-br-quoted-002-expected.txt:
* platform/gtk/editing/inserting/insert-br-quoted-003-expected.txt:
* platform/gtk/editing/inserting/insert-br-quoted-004-expected.txt:
* platform/gtk/editing/inserting/insert-br-quoted-005-expected.txt:
* platform/gtk/editing/inserting/insert-br-quoted-006-expected.txt:
* platform/gtk/editing/inserting/insert-div-020-expected.txt:
* platform/gtk/editing/inserting/insert-div-022-expected.txt:
* platform/gtk/editing/inserting/insert-div-026-expected.txt:
* platform/gtk/editing/inserting/insert-paragraph-03-expected.txt:
* platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
* platform/gtk/editing/inserting/paragraph-separator-in-table-1-expected.txt:
* platform/gtk/editing/inserting/paragraph-separator-in-table-2-expected.txt:
* platform/gtk/editing/inserting/return-key-with-selection-001-expected.txt:
* platform/gtk/editing/inserting/return-key-with-selection-002-expected.txt:
* platform/gtk/editing/inserting/return-key-with-selection-003-expected.txt:
* platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
* platform/gtk/editing/pasteboard/5006779-expected.txt:
* platform/gtk/editing/pasteboard/5601583-1-expected.txt:
* platform/gtk/editing/pasteboard/8145-2-expected.txt:
* platform/gtk/editing/pasteboard/bad-placeholder-expected.txt:
* platform/gtk/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
* platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-003-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-004-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-005-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-007-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-008-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-009-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-010-expected.txt:
* platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/gtk/editing/pasteboard/paste-match-style-002-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-016-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-019-expected.txt:
* platform/gtk/editing/pasteboard/quirks-mode-br-1-expected.txt:
* platform/gtk/editing/selection/3690703-2-expected.txt:
* platform/gtk/editing/selection/3690703-expected.txt:
* platform/gtk/editing/selection/3690719-expected.txt:
* platform/gtk/editing/selection/4975120-expected.txt:
* platform/gtk/editing/selection/5007143-2-expected.txt:
* platform/gtk/editing/selection/5007143-expected.txt:
* platform/gtk/editing/selection/drag-in-iframe-expected.txt:
* platform/gtk/editing/selection/editable-html-element-expected.txt:
* platform/gtk/editing/selection/extend-by-character-002-expected.txt:
* platform/gtk/editing/selection/extend-by-character-004-expected.txt:
* platform/gtk/editing/selection/extend-selection-bidi-expected.txt:
* platform/gtk/editing/selection/focus_editable_html-expected.txt:
* platform/gtk/editing/selection/image-before-linebreak-expected.txt:
* platform/gtk/editing/selection/move-3875618-fix-expected.txt:
* platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt:
* platform/gtk/editing/selection/move-by-character-002-expected.txt:
* platform/gtk/editing/selection/move-by-character-004-expected.txt:
* platform/gtk/editing/selection/move-by-sentence-linebreak-expected.txt:
* platform/gtk/editing/selection/paragraph-granularity-expected.txt:
* platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
* platform/gtk/editing/selection/select-all-002-expected.txt:
* platform/gtk/editing/selection/select-all-003-expected.txt:
* platform/gtk/editing/selection/select-all-iframe-expected.txt:
* platform/gtk/editing/selection/selectNode-expected.txt:
* platform/gtk/editing/selection/selectNodeContents-expected.txt:
* platform/gtk/editing/selection/selection-3748164-fix-expected.txt:
* platform/gtk/editing/selection/selection-actions-expected.txt:
* platform/gtk/editing/selection/word-granularity-expected.txt:
* platform/gtk/editing/style/5046875-2-expected.txt:
* platform/gtk/editing/style/block-styles-007-expected.txt:
* platform/gtk/editing/style/create-block-for-style-001-expected.txt:
* platform/gtk/editing/style/create-block-for-style-002-expected.txt:
* platform/gtk/editing/style/create-block-for-style-003-expected.txt:
* platform/gtk/editing/style/create-block-for-style-004-expected.txt:
* platform/gtk/editing/style/create-block-for-style-013-expected.txt:
* platform/gtk/editing/style/style-3998892-fix-expected.txt:
* platform/gtk/editing/style/style-boundary-001-expected.txt:
* platform/gtk/editing/style/style-boundary-002-expected.txt:
* platform/gtk/editing/style/style-boundary-003-expected.txt:
* platform/gtk/editing/style/style-boundary-004-expected.txt:
* platform/gtk/editing/unsupported-content/list-delete-001-expected.txt:
* platform/gtk/editing/unsupported-content/list-delete-003-expected.txt:
* platform/gtk/editing/unsupported-content/list-type-after-expected.txt:
* platform/gtk/editing/unsupported-content/list-type-before-expected.txt:
* platform/gtk/editing/unsupported-content/table-delete-002-expected.txt:
* platform/gtk/editing/unsupported-content/table-type-after-expected.txt:
* platform/gtk/editing/unsupported-content/table-type-before-expected.txt:
* platform/gtk/fast/backgrounds/background-clip-text-expected.txt:
* platform/gtk/fast/block/basic/001-expected.txt:
* platform/gtk/fast/block/float/002-expected.txt:
* platform/gtk/fast/block/float/021-expected.txt:
* platform/gtk/fast/block/float/br-with-clear-2-expected.txt:
* platform/gtk/fast/block/float/float-avoidance-expected.txt:
* platform/gtk/fast/block/margin-collapse/104-expected.txt:
* platform/gtk/fast/block/positioning/055-expected.txt:
* platform/gtk/fast/block/positioning/056-expected.txt:
* platform/gtk/fast/borders/inline-mask-overlay-image-outset-expected.txt:
* platform/gtk/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt:
* platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
* platform/gtk/fast/clip/nestedTransparencyClip-expected.txt:
* platform/gtk/fast/clip/overflow-border-radius-combinations-expected.txt:
* platform/gtk/fast/clip/overflow-border-radius-composited-expected.txt:
* platform/gtk/fast/clip/overflow-border-radius-transformed-expected.txt:
* platform/gtk/fast/css-generated-content/inline-display-types-expected.txt:
* platform/gtk/fast/css/first-line-text-decoration-expected.txt:
* platform/gtk/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
* platform/gtk/fast/css/hsl-color-expected.txt:
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/css/layerZOrderCrash-expected.txt:
* platform/gtk/fast/css/line-height-overflow-expected.txt:
* platform/gtk/fast/css/nth-child-dynamic-expected.txt:
* platform/gtk/fast/css/rtl-ordering-expected.txt:
* platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
* platform/gtk/fast/css/text-rendering-expected.txt:
* platform/gtk/fast/dom/HTMLElement/bdo-expected.txt:
* platform/gtk/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
* platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
* platform/gtk/fast/dom/HTMLTableElement/colSpan-expected.txt:
* platform/gtk/fast/dom/HTMLTableElement/createCaption-expected.txt:
* platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
* platform/gtk/fast/dom/children-nodes-expected.txt:
* platform/gtk/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.txt:
* platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
* platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
* platform/gtk/fast/encoding/xmacroman-encoding-test-expected.txt:
* platform/gtk/fast/forms/007-expected.txt:
* platform/gtk/fast/forms/basic-inputs-expected.txt:
* platform/gtk/fast/forms/basic-textareas-expected.txt:
* platform/gtk/fast/forms/blankbuttons-expected.txt:
* platform/gtk/fast/forms/button-table-styles-expected.txt:
* platform/gtk/fast/forms/caret-rtl-expected.txt:
* platform/gtk/fast/forms/color/input-appearance-color-expected.txt:
* platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
* platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
* platform/gtk/fast/forms/hidden-listbox-expected.txt:
* platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
* platform/gtk/fast/forms/input-appearance-focus-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
* platform/gtk/fast/forms/input-appearance-selection-expected.txt:
* platform/gtk/fast/forms/input-appearance-width-expected.txt:
* platform/gtk/fast/forms/input-baseline-expected.txt:
* platform/gtk/fast/forms/input-disabled-color-expected.txt:
* platform/gtk/fast/forms/input-first-letter-expected.txt:
* platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
* platform/gtk/fast/forms/input-readonly-dimmed-expected.txt:
* platform/gtk/fast/forms/input-spaces-expected.txt:
* platform/gtk/fast/forms/input-type-text-min-width-expected.txt:
* platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.txt:
* platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
* platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
* platform/gtk/fast/forms/menulist-width-change-expected.txt:
* platform/gtk/fast/forms/negativeLineHeight-expected.txt:
* platform/gtk/fast/forms/option-index-expected.txt:
* platform/gtk/fast/forms/option-script-expected.txt:
* platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
* platform/gtk/fast/forms/option-text-clip-expected.txt:
* platform/gtk/fast/forms/placeholder-position-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
* platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt:
* platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/gtk/fast/forms/searchfield-heights-expected.txt:
* platform/gtk/fast/forms/select-baseline-expected.txt:
* platform/gtk/fast/forms/select-block-background-expected.txt:
* platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
* platform/gtk/fast/forms/select-change-popup-to-listbox-expected.txt:
* platform/gtk/fast/forms/select-initial-position-expected.txt:
* platform/gtk/fast/forms/select-style-expected.txt:
* platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
* platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
* platform/gtk/fast/forms/textfield-outline-expected.txt:
* platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
* platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
* platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
* platform/gtk/fast/inline-block/contenteditable-baseline-expected.txt:
* platform/gtk/fast/inline-block/inline-block-vertical-align-expected.txt:
* platform/gtk/fast/inline/drawStyledEmptyInlines-expected.txt:
* platform/gtk/fast/invalid/021-expected.txt:
* platform/gtk/fast/layers/video-layer-expected.txt:
* platform/gtk/fast/line-grid/line-grid-contains-value-expected.txt:
* platform/gtk/fast/line-grid/line-grid-floating-expected.txt:
* platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt:
* platform/gtk/fast/line-grid/line-grid-into-columns-expected.txt:
* platform/gtk/fast/line-grid/line-grid-into-floats-expected.txt:
* platform/gtk/fast/line-grid/line-grid-positioned-expected.txt:
* platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
* platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
* platform/gtk/fast/multicol/max-height-columns-block-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
* platform/gtk/fast/overflow/006-expected.txt:
* platform/gtk/fast/overflow/line-clamp-expected.txt:
* platform/gtk/fast/overflow/overflow-stacking-expected.txt:
* platform/gtk/fast/overflow/overflow-x-y-expected.txt:
* platform/gtk/fast/overflow/position-fixed-transform-clipping-expected.txt:
* platform/gtk/fast/overflow/table-overflow-float-expected.txt:
* platform/gtk/fast/repaint/block-selection-gap-stale-cache-2-expected.txt:
* platform/gtk/fast/repaint/block-selection-gap-stale-cache-expected.txt:
* platform/gtk/fast/repaint/make-children-non-inline-expected.txt:
* platform/gtk/fast/repaint/selection-after-remove-expected.txt:
* platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
* platform/gtk/fast/repaint/selection-gap-overflow-scroll-expected.txt:
* platform/gtk/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
* platform/gtk/fast/repaint/trailing-floats-root-line-box-overflow-expected.txt: Added.
* platform/gtk/fast/replaced/selection-rect-transform-expected.txt:
* platform/gtk/fast/ruby/ruby-inline-table-expected.txt:
* platform/gtk/fast/table/009-expected.txt:
* platform/gtk/fast/table/040-expected.txt:
* platform/gtk/fast/table/040-vertical-expected.txt:
* platform/gtk/fast/table/cellindex-expected.txt:
* platform/gtk/fast/table/percent-heights-expected.txt:
* platform/gtk/fast/table/table-and-parts-outline-expected.txt:
* platform/gtk/fast/text/basic/012-expected.txt:
* platform/gtk/fast/text/basic/014-expected.txt:
* platform/gtk/fast/text/basic/generic-family-reset-expected.txt:
* platform/gtk/fast/text/capitalize-boundaries-expected.txt:
* platform/gtk/fast/text/complex-synthetic-bold-space-width-expected.txt:
* platform/gtk/fast/text/firstline/001-expected.txt:
* platform/gtk/fast/text/indic-expected.txt:
* platform/gtk/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
* platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
* platform/gtk/fast/text/international/bidi-listbox-atsui-expected.txt:
* platform/gtk/fast/text/international/bidi-listbox-expected.txt:
* platform/gtk/fast/text/international/bidi-menulist-expected.txt:
* platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
* platform/gtk/fast/text/international/hindi-spacing-expected.txt:
* platform/gtk/fast/text/international/thai-baht-space-expected.txt:
* platform/gtk/fast/text/midword-break-after-breakable-char-expected.txt:
* platform/gtk/fast/text/whitespace/029-expected.txt: Added.
* platform/gtk/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
* platform/gtk/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/gtk/fast/writing-mode/english-bt-text-expected.txt:
* platform/gtk/fast/writing-mode/english-lr-text-expected.txt:
* platform/gtk/fast/writing-mode/english-rl-text-expected.txt:
* platform/gtk/fast/writing-mode/fieldsets-expected.txt:
* platform/gtk/fast/writing-mode/text-orientation-basic-expected.txt:
* platform/gtk/fast/xsl/xslt-enc-cyr-expected.txt:
* platform/gtk/fast/xsl/xslt-enc-expected.txt:
* platform/gtk/fast/xsl/xslt-enc16-expected.txt:
* platform/gtk/fast/xsl/xslt-enc16to16-expected.txt:
* platform/gtk/fonts/cursive-expected.txt:
* platform/gtk/fonts/default-expected.txt:
* platform/gtk/fonts/fantasy-expected.txt:
* platform/gtk/fonts/monospace-expected.txt:
* platform/gtk/fonts/sans-serif-expected.txt:
* platform/gtk/fonts/serif-expected.txt:
* platform/gtk/http/tests/loading/simple-subframe-expected.txt:
* platform/gtk/http/tests/local/file-url-sent-as-referer-expected.txt:
* platform/gtk/http/tests/misc/favicon-as-image-expected.txt:
* platform/gtk/http/tests/misc/frame-access-during-load-expected.txt:
* platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/video-display-toggle-expected.txt:
* platform/gtk/media/video-layer-crash-expected.txt:
* platform/gtk/media/video-transformed-expected.txt:
* platform/gtk/media/video-zoom-expected.txt:
* platform/gtk/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
* platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.txt:
* platform/gtk/svg/custom/getsvgdocument-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug106158-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug10633-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug113235-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1224-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug131020-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug131020_iframe-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug16012-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug17138-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug20579-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug20804-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug23235-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug23299-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug25663-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2962-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug30332-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug30559-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug30692-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug32205-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug32205-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug43854-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4427-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug5538-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55694-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug5799-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug82946-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug8858-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug9123-1-expected.txt:
* platform/gtk/tables/mozilla/core/bloomberg-expected.txt:
* platform/gtk/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
* platform/gtk/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_border_1-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_border_2-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_border_3-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_colspan-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_height-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_td_width-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_colspan-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_height-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_th_width-expected.txt:
* platform/gtk/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
* platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug11331-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/col_span2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
* platform/gtk/transforms/3d/hit-testing/backface-hit-test-expected.txt:
* platform/gtk/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt:
* platform/gtk/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
* platform/gtk/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt:
* platform/gtk/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt:
* platform/gtk/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
* platform/gtk/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
* platform/gtk/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
* platform/gtk/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt:
* platform/gtk/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
* platform/ios/fast/css/font-face-remote-expected.txt: Removed.
* platform/ios/fast/ruby/position-after-expected.txt: Removed.
* platform/mac/fast/css/font-face-remote-expected.txt: Removed.
* platform/mac/fast/multicol/pagination-h-horizontal-bt-expected.txt: Removed.
* platform/mac/fast/multicol/pagination-h-horizontal-tb-expected.txt: Removed.
* platform/mac/fast/multicol/pagination-h-vertical-lr-expected.txt: Removed.
* platform/mac/fast/multicol/pagination-h-vertical-rl-expected.txt: Removed.
* platform/mac/fast/multicol/pagination-v-horizontal-bt-expected.txt: Removed.
* platform/mac/fast/multicol/pagination-v-horizontal-tb-expected.txt: Removed.
* platform/mac/fast/multicol/pagination-v-vertical-lr-expected.txt: Removed.
* platform/mac/fast/multicol/pagination-v-vertical-rl-expected.txt: Removed.
* platform/mac/fast/repaint/text-emphasis-h-expected.txt: Removed.
* platform/mac/fast/repaint/text-emphasis-v-expected.txt: Removed.
* platform/mac/fast/ruby/position-after-expected.txt: Removed.
* platform/mac/fast/text/decorations-transformed-expected.txt: Removed.
* platform/mac/fast/text/soft-hyphen-4-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoScrolls in the passive event region only send one wheel event to the DOM
simon.fraser@apple.com [Thu, 15 Oct 2020 19:24:40 +0000 (19:24 +0000)]
Scrolls in the passive event region only send one wheel event to the DOM
https://bugs.webkit.org/show_bug.cgi?id=217719

Reviewed by Tim Horton.
Source/WebCore:

When we hit the scrolling thread latching codepath, we'd always use { WheelEventProcessingSteps::ScrollingThread }
for the steps, but that caused us to not send DOM events.

Latching has to store the steps from when latching occurs (we should not re-hit-test
to get the region state on every event), so fix up ScrollingTreeLatchingController to
do that.

Test: fast/scrolling/latching/latched-scroll-in-passive-region.html

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::determineWheelEventProcessing):
(WebCore::ScrollingTree::handleWheelEvent):
(WebCore::ScrollingTree::handleWheelEventWithNode):
* page/scrolling/ScrollingTree.h:
* page/scrolling/ScrollingTreeLatchingController.cpp:
(WebCore::ScrollingTreeLatchingController::receivedWheelEvent):
(WebCore::ScrollingTreeLatchingController::latchingDataForEvent const):
(WebCore::ScrollingTreeLatchingController::latchedNodeID const):
(WebCore::ScrollingTreeLatchingController::latchedNodeAndSteps const):
(WebCore::ScrollingTreeLatchingController::nodeDidHandleEvent):
(WebCore::ScrollingTreeLatchingController::nodeWasRemoved):
(WebCore::ScrollingTreeLatchingController::clearLatchedNode):
(WebCore::ScrollingTreeLatchingController::latchedNodeForEvent const): Deleted.
* page/scrolling/ScrollingTreeLatchingController.h:
* page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):

LayoutTests:

* fast/scrolling/latching/latched-scroll-in-passive-region-expected.txt: Added.
* fast/scrolling/latching/latched-scroll-in-passive-region.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoWeakObjCPtr.h is not safe to include in C++ source files
ddkilzer@apple.com [Thu, 15 Oct 2020 19:12:02 +0000 (19:12 +0000)]
WeakObjCPtr.h is not safe to include in C++ source files
<https://webkit.org/b/217712>
<rdar://problem/70250667>

Reviewed by Darin Adler.

* wtf/WeakObjCPtr.h:
(WTF::WeakObjCPtr::get const):
- Move implementation outside of the class and wrap it in
  #ifdef __OBJC__/#endif.  This makes the header safe to compile
  with other C++ sources, but will fail if get() is used in a
  C++ source file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[Flatpak SDK] Check for installed packages in setup_buildir
lmoura@igalia.com [Thu, 15 Oct 2020 19:09:01 +0000 (19:09 +0000)]
[Flatpak SDK] Check for installed packages in setup_buildir
https://bugs.webkit.org/show_bug.cgi?id=217768

Reviewed by Philippe Normand.

During a cleanup of one of the bots, setup_builddir failed with a null
self.sdk member, which is set in get_packages.

While I could not reproduce it again, this commit prevents this by
checking whether the packages are installed before continuing the
original setup_builddir steps.

* flatpak/flatpakutils.py:
(WebkitFlatpak.setup_builddir): Check for installed packages.
(WebkitFlatpak.run_in_sandbox): Check for setup_builddir return code.
(WebkitFlatpak.check_installed_packages): Extracted from
setup_dev_env.
(WebkitFlatpak.setup_dev_env): Call extracted method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoFix for multiple accessibility layout tests in isolated tree mode.
andresg_22@apple.com [Thu, 15 Oct 2020 18:43:29 +0000 (18:43 +0000)]
Fix for multiple accessibility layout tests in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=217745

Reviewed by Chris Fleizach.

Source/WebCore:

Fix for the following tests in accessibility isolated tree mode:
accessibility/mac/abbr-acronym-tags.html
accessibility/mac/aria-image-emits-object-replacement.html
accessibility/mac/attributed-string-includes-highlighting.html
accessibility/mac/attributed-string/attributed-string-for-range-with-options.html
accessibility/mac/attributed-string/attributed-string-for-range.html
accessibility/mac/character-offset-visible-position-conversion-with-emoji.html
accessibility/mac/element-for-text-marker.html
accessibility/mac/listmarker-suffix.html
accessibility/mac/media-emits-object-replacement.html
accessibility/mac/stale-textmarker-crash.html
accessibility/mac/string-range-contains-listmarker.html
accessibility/mac/text-marker-for-index.html
accessibility/mac/text-marker-length.html
accessibility/mac/text-marker-paragraph-nav.html
accessibility/mac/text-marker-range-for-node-without-children.html
accessibility/mac/text-marker-sentence-nav.html
accessibility/mac/text-marker-word-nav-collapsed-whitespace.html
accessibility/mac/text-marker-word-nav.html
accessibility/mac/text-markers-for-input-with-placeholder.html
accessibility/mac/webkit-scrollarea-position.html
accessibility/text-marker/text-marker-previous-next.html
accessibility/text-marker/text-marker-range-stale-node-crash.html
accessibility/text-marker/text-marker-range-with-removed-node-crash.html
accessibility/text-marker/text-marker-with-user-select-none.html

* accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::convertFrameToSpace const):
(WebCore::AXIsolatedObject::elementRange const):
* accessibility/isolatedtree/AXIsolatedObject.h:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper position]):

LayoutTests:

* accessibility/mac/attributed-string-includes-highlighting.html: Minor code cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoVectorize StereoPanner's panToTargetValue()
cdumez@apple.com [Thu, 15 Oct 2020 18:21:25 +0000 (18:21 +0000)]
Vectorize StereoPanner's panToTargetValue()
https://bugs.webkit.org/show_bug.cgi?id=217765

Reviewed by Geoffrey Garen.

Vectorize StereoPanner's panToTargetValue().

No new tests, no Web-facing behavior change.

* platform/audio/StereoPanner.cpp:
(WebCore::StereoPanner::panToTargetValue):
* platform/audio/VectorMath.cpp:
(WebCore::VectorMath::multiplyByScalar):
(WebCore::VectorMath::multiplyByScalarThenAddToOutput):
(WebCore::VectorMath::multiplyByScalarThenAddToVector):
* platform/audio/VectorMath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[webkitscmpy] Unconditionally extract git-svn-id from commit message
jbedard@apple.com [Thu, 15 Oct 2020 18:19:42 +0000 (18:19 +0000)]
[webkitscmpy] Unconditionally extract git-svn-id from commit message
https://bugs.webkit.org/show_bug.cgi?id=217740
<rdar://problem/70313868>

Reviewed by Dewei Zhu.

* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.commit): Unconditionally attempt to extract git-svn-id.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoCrash in -[WKDateTimePicker setDateTimePickerToInitialValue]
akeerthi@apple.com [Thu, 15 Oct 2020 18:17:40 +0000 (18:17 +0000)]
Crash in -[WKDateTimePicker setDateTimePickerToInitialValue]
https://bugs.webkit.org/show_bug.cgi?id=217763
<rdar://problem/68635008>

Reviewed by Wenson Hsieh.

Crash occurs due to the use of an autoreleased NSString in
setDateTimePickerToInitialValue. To fix, make the variable
a RetainPtr.

* UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePicker setDateTimePickerToInitialValue]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[webkitscmpy] Support <identifier>@ abbreviated idiom
jbedard@apple.com [Thu, 15 Oct 2020 17:37:30 +0000 (17:37 +0000)]
[webkitscmpy] Support <identifier>@ abbreviated idiom
https://bugs.webkit.org/show_bug.cgi?id=217716
<rdar://problem/70299119>

Rubber-stamped by Aakash Jain.

* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:
(Commit):
(Commit._parse_identifier): Support <identifier>@ shorthand.
* Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py:
(TestCommit.test_parse_identifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoREGRESSION (r268489): test/built-ins/Object/entries/order-after-define-property.js...
shvaikalesh@gmail.com [Thu, 15 Oct 2020 17:23:02 +0000 (17:23 +0000)]
REGRESSION (r268489): test/built-ins/Object/entries/order-after-define-property.js failing on test262 bots
https://bugs.webkit.org/show_bug.cgi?id=217738

Reviewed by Yusuke Suzuki.

JSTests:

* stress/object-entries.js:

Source/JavaScriptCore:

This change fixes an oversight of r268489 that caused Object.entries to
return a sparse array if its argument contained non-enumerable properties.

* builtins/ObjectConstructor.js:
(entries):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoREGRESSION (r267662): [ Mojave+ debug wk1 ] webgl/2.0.0/conformance/extensions/webgl...
rackler@apple.com [Thu, 15 Oct 2020 17:01:09 +0000 (17:01 +0000)]
REGRESSION (r267662): [ Mojave+ debug wk1 ] webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=217761

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoEWS bot should fail if a new test is missing its result
aakash_jain@apple.com [Thu, 15 Oct 2020 16:27:48 +0000 (16:27 +0000)]
EWS bot should fail if a new test is missing its result
https://bugs.webkit.org/show_bug.cgi?id=177723

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(RunWebKitTests.evaluateResult):
* BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoREGRESSION: [ iOS wk2 ews ] media/now-playing-status-without-media.html is a flaky...
rackler@apple.com [Thu, 15 Oct 2020 16:27:34 +0000 (16:27 +0000)]
REGRESSION: [ iOS wk2 ews ] media/now-playing-status-without-media.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217759

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoREGRESSION (r268178): [iOS] imported/w3c/web-platform-tests/html/semantics/embedded...
rackler@apple.com [Thu, 15 Oct 2020 15:43:02 +0000 (15:43 +0000)]
REGRESSION (r268178): [iOS] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217741

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[ Mojave wk1 ews ] media/remote-control-command-seek.html is a flaky timeout
rackler@apple.com [Thu, 15 Oct 2020 14:36:35 +0000 (14:36 +0000)]
[ Mojave wk1 ews ] media/remote-control-command-seek.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215325

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[GTK][WPE] Add support for smooth scrolling animation with async scrolling
clord@igalia.com [Thu, 15 Oct 2020 13:46:54 +0000 (13:46 +0000)]
[GTK][WPE] Add support for smooth scrolling animation with async scrolling
https://bugs.webkit.org/show_bug.cgi?id=210382

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Respect smooth-scrolling setting and fix deadlock issues with async
scrolling on nicosia path.

No new tests, no functional change.

* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::scrollAnimatorEnabled const):
* page/scrolling/AsyncScrollingCoordinator.h:
* page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::ThreadedScrollingTree):
* page/scrolling/ThreadedScrollingTree.h:
(WebCore::ThreadedScrollingTree::scrollAnimatorEnabled const):
* page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::ScrollingTreeFrameScrollingNodeNicosia):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateAfterChildren):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::ensureScrollAnimationKinetic):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::ensureScrollAnimationSmooth):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::handleWheelEvent):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::stopScrollAnimations):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionRelatedLayers):
* page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h:
* page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::ScrollingTreeOverflowScrollingNodeNicosia):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::commitStateAfterChildren):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::repositionScrollingLayers):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::ensureScrollAnimationKinetic):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::ensureScrollAnimationSmooth):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::handleWheelEvent):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::stopScrollAnimations):
* page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h:
* platform/PlatformWheelEvent.h:
* platform/ScrollAnimation.h:
* platform/ScrollAnimationKinetic.cpp:
(WebCore::ScrollAnimationKinetic::isActive const):
* platform/ScrollAnimationKinetic.h:
* platform/ScrollAnimationSmooth.cpp:
(WebCore::ScrollAnimationSmooth::scroll):
(WebCore::ScrollAnimationSmooth::isActive const):
* platform/ScrollAnimationSmooth.h:
* platform/generic/ScrollAnimatorGeneric.cpp:
(WebCore::ScrollAnimatorGeneric::ensureSmoothScrollingAnimation):

Source/WebKit:

Add hasPreciseScrollingDeltas to GTK/WPE wheel events.

No new tests needed.

* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
* Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode const):
(WebKit::WebWheelEvent::decode):
* Shared/WebWheelEvent.h:
* Shared/WebWheelEventCoalescer.cpp:
(WebKit::WebWheelEventCoalescer::canCoalesce):
(WebKit::WebWheelEventCoalescer::coalesce):
* Shared/gtk/NativeWebWheelEventGtk.cpp:
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
* Shared/gtk/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):
* Shared/libwpe/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoIntroduce a RemoteAudioSourceProvider to receive audio samples for web audio from...
youenn@apple.com [Thu, 15 Oct 2020 11:36:46 +0000 (11:36 +0000)]
Introduce a RemoteAudioSourceProvider to receive audio samples for web audio from GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=217710

Reviewed by Eric Carlson.

Source/WebCore:

Split WebAudioSourceProviderAVFObjC MediaStreamTrack specific bits in a separate MediaStreamTrackAudioSourceProviderAVFObjC class.
This allows reusing WebAudioSourceProviderAVFObjC for samples coming from audio playback living in GPUProcess.
No change of behavior.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/audio/cocoa/AudioSampleBufferList.cpp:
* platform/audio/cocoa/AudioSampleBufferList.h:
* platform/audio/cocoa/AudioSampleDataSource.h:
* platform/audio/cocoa/AudioSampleDataSource.mm:
* platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::audioSourceProvider):
* platform/mediastream/RealtimeMediaSource.h:
* platform/mediastream/WebAudioSourceProvider.h:
* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
* platform/mediastream/mac/MediaStreamTrackAudioSourceProviderCocoa.cpp: Added.
(WebCore::MediaStreamTrackAudioSourceProviderCocoa::create):
(WebCore::MediaStreamTrackAudioSourceProviderCocoa::MediaStreamTrackAudioSourceProviderCocoa):
(WebCore::MediaStreamTrackAudioSourceProviderCocoa::~MediaStreamTrackAudioSourceProviderCocoa):
(WebCore::MediaStreamTrackAudioSourceProviderCocoa::hasNewClient):
(WebCore::MediaStreamTrackAudioSourceProviderCocoa::trackEnabledChanged):
(WebCore::MediaStreamTrackAudioSourceProviderCocoa::audioSamplesAvailable):
* platform/mediastream/mac/MediaStreamTrackAudioSourceProviderCocoa.h: Added.
* platform/mediastream/mac/MockAudioSharedUnit.h:
* platform/mediastream/mac/MockAudioSharedUnit.mm:
* platform/mediastream/mac/WebAudioSourceProviderCocoa.h: Renamed from Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.h.
* platform/mediastream/mac/WebAudioSourceProviderCocoa.mm: Renamed from Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm.
(WebCore::WebAudioSourceProviderCocoa::WebAudioSourceProviderCocoa):
(WebCore::WebAudioSourceProviderCocoa::~WebAudioSourceProviderCocoa):
(WebCore::WebAudioSourceProviderCocoa::setClient):
(WebCore::WebAudioSourceProviderCocoa::provideInput):
(WebCore::WebAudioSourceProviderCocoa::prepare):
(WebCore::WebAudioSourceProviderCocoa::receivedNewAudioSamples):

Source/WebKit:

Make use of WebAudioSourceProviderAVFObjC to implement RemoteAudioSourceProvider.
RemoteAudioSourceProvider currently implements an AudioSourceProvider but it is not yet connected to GPUProcess media players.
This will be implemented in a follow-up.

* SourcesCocoa.txt:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::~MediaPlayerPrivateRemote):
(WebKit::MediaPlayerPrivateRemote::audioSourceProvider):
* WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
* WebProcess/GPU/media/RemoteAudioSourceProvider.cpp: Added.
(WebKit::RemoteAudioSourceProvider::create):
(WebKit::RemoteAudioSourceProvider::RemoteAudioSourceProvider):
(WebKit::RemoteAudioSourceProvider::~RemoteAudioSourceProvider):
(WebKit::RemoteAudioSourceProvider::close):
(WebKit::RemoteAudioSourceProvider::hasNewClient):
(WebKit::RemoteAudioSourceProvider::audioSamplesAvailable):
(WebKit::RemoteAudioSourceProvider::logChannel const):
* WebProcess/GPU/media/RemoteAudioSourceProvider.h: Added.
* WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoRemove <br> render tree dump quirk
antti@apple.com [Thu, 15 Oct 2020 11:32:32 +0000 (11:32 +0000)]
Remove <br> render tree dump quirk
https://bugs.webkit.org/show_bug.cgi?id=209813

Reviewed by Zalan Bujtas.

Source/WebCore:

Stop lying about <br> box dimensions.

* layout/integration/LayoutIntegrationRunIterator.h:
(WebCore::LayoutIntegration::PathRun::baseline const): Deleted.
(WebCore::LayoutIntegration::PathRun::useLineBreakBoxRenderTreeDumpQuirk const): Deleted.
* layout/integration/LayoutIntegrationRunIteratorLegacyPath.h:
(WebCore::LayoutIntegration::RunIteratorLegacyPath::isLineBreak const):
(WebCore::LayoutIntegration::RunIteratorLegacyPath::baseline const): Deleted.
(WebCore::LayoutIntegration::RunIteratorLegacyPath::useLineBreakBoxRenderTreeDumpQuirk const): Deleted.
* layout/integration/LayoutIntegrationRunIteratorModernPath.h:
(WebCore::LayoutIntegration::RunIteratorModernPath::baseline const): Deleted.
(WebCore::LayoutIntegration::RunIteratorModernPath::useLineBreakBoxRenderTreeDumpQuirk const): Deleted.
* rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::boundingBoxForRenderTreeDump const): Deleted.
* rendering/RenderLineBreak.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):

LayoutTests:

* platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
* platform/mac/css1/color_and_background/background_attachment-expected.txt:
* platform/mac/css1/text_properties/text_indent-expected.txt:
* platform/mac/editing/deleting/5272440-expected.txt:
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-002-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-003-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-004-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-006-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-007-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-009-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-011-expected.txt:
* platform/mac/editing/deleting/delete-br-003-expected.txt:
* platform/mac/editing/deleting/delete-image-001-expected.txt:
* platform/mac/editing/deleting/delete-image-002-expected.txt:
* platform/mac/editing/deleting/delete-line-003-expected.txt:
* platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
* platform/mac/editing/deleting/non-smart-delete-expected.txt:
* platform/mac/editing/execCommand/4641880-1-expected.txt:
* platform/mac/editing/execCommand/4641880-2-expected.txt:
* platform/mac/editing/execCommand/4916541-expected.txt:
* platform/mac/editing/execCommand/5080333-1-expected.txt:
* platform/mac/editing/execCommand/5080333-2-expected.txt:
* platform/mac/editing/execCommand/5569741-expected.txt:
* platform/mac/editing/execCommand/indent-selection-expected.txt:
* platform/mac/editing/execCommand/remove-list-from-range-selection-expected.txt:
* platform/mac/editing/input/emacs-ctrl-o-expected.txt:
* platform/mac/editing/inserting/4960120-2-expected.txt:
* platform/mac/editing/inserting/5002441-expected.txt:
* platform/mac/editing/inserting/5156401-2-expected.txt:
* platform/mac/editing/inserting/5510537-expected.txt:
* platform/mac/editing/inserting/5549929-3-expected.txt:
* platform/mac/editing/inserting/6703873-expected.txt:
* platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:
* platform/mac/editing/inserting/insert-3778059-fix-expected.txt:
* platform/mac/editing/inserting/insert-br-at-tabspan-001-expected.txt:
* platform/mac/editing/inserting/insert-br-at-tabspan-002-expected.txt:
* platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
* platform/mac/editing/inserting/insert-br-quoted-001-expected.txt:
* platform/mac/editing/inserting/insert-br-quoted-002-expected.txt:
* platform/mac/editing/inserting/insert-br-quoted-003-expected.txt:
* platform/mac/editing/inserting/insert-br-quoted-004-expected.txt:
* platform/mac/editing/inserting/insert-br-quoted-005-expected.txt:
* platform/mac/editing/inserting/insert-br-quoted-006-expected.txt:
* platform/mac/editing/inserting/insert-div-020-expected.txt:
* platform/mac/editing/inserting/insert-div-022-expected.txt:
* platform/mac/editing/inserting/insert-div-026-expected.txt:
* platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
* platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
* platform/mac/editing/inserting/paragraph-separator-in-table-1-expected.txt:
* platform/mac/editing/inserting/paragraph-separator-in-table-2-expected.txt:
* platform/mac/editing/inserting/return-key-with-selection-001-expected.txt:
* platform/mac/editing/inserting/return-key-with-selection-002-expected.txt:
* platform/mac/editing/inserting/return-key-with-selection-003-expected.txt:
* platform/mac/editing/pasteboard/4989774-expected.txt:
* platform/mac/editing/pasteboard/5006779-expected.txt:
* platform/mac/editing/pasteboard/5601583-1-expected.txt:
* platform/mac/editing/pasteboard/8145-2-expected.txt:
* platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
* platform/mac/editing/pasteboard/emacs-cntl-y-001-expected.txt:
* platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
* platform/mac/editing/pasteboard/paste-4038267-fix-expected.txt:
* platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-001-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-002-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-003-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-004-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-005-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-006-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-007-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-008-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-009-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-010-expected.txt:
* platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/mac/editing/pasteboard/paste-match-style-002-expected.txt:
* platform/mac/editing/pasteboard/paste-text-016-expected.txt:
* platform/mac/editing/pasteboard/paste-text-019-expected.txt:
* platform/mac/editing/pasteboard/quirks-mode-br-1-expected.txt:
* platform/mac/editing/selection/3690703-2-expected.txt:
* platform/mac/editing/selection/3690703-expected.txt:
* platform/mac/editing/selection/3690719-expected.txt:
* platform/mac/editing/selection/5007143-2-expected.txt:
* platform/mac/editing/selection/5007143-expected.txt:
* platform/mac/editing/selection/drag-in-iframe-expected.txt:
* platform/mac/editing/selection/editable-html-element-expected.txt:
* platform/mac/editing/selection/extend-by-character-002-expected.txt:
* platform/mac/editing/selection/extend-by-character-004-expected.txt:
* platform/mac/editing/selection/focus_editable_html-expected.txt:
* platform/mac/editing/selection/image-before-linebreak-expected.txt:
* platform/mac/editing/selection/move-3875618-fix-expected.txt:
* platform/mac/editing/selection/move-backwords-by-word-001-expected.txt:
* platform/mac/editing/selection/move-by-character-002-expected.txt:
* platform/mac/editing/selection/move-by-character-004-expected.txt:
* platform/mac/editing/selection/move-by-sentence-linebreak-expected.txt:
* platform/mac/editing/selection/paragraph-granularity-expected.txt:
* platform/mac/editing/selection/replaced-boundaries-3-expected.txt:
* platform/mac/editing/selection/select-all-002-expected.txt:
* platform/mac/editing/selection/select-all-003-expected.txt:
* platform/mac/editing/selection/select-all-iframe-expected.txt:
* platform/mac/editing/selection/selectNode-expected.txt:
* platform/mac/editing/selection/selectNodeContents-expected.txt:
* platform/mac/editing/selection/selection-3748164-fix-expected.txt:
* platform/mac/editing/selection/selection-actions-expected.txt:
* platform/mac/editing/selection/word-granularity-expected.txt:
* platform/mac/editing/style/5046875-2-expected.txt:
* platform/mac/editing/style/block-styles-007-expected.txt:
* platform/mac/editing/style/create-block-for-style-001-expected.txt:
* platform/mac/editing/style/create-block-for-style-002-expected.txt:
* platform/mac/editing/style/create-block-for-style-003-expected.txt:
* platform/mac/editing/style/create-block-for-style-004-expected.txt:
* platform/mac/editing/style/create-block-for-style-013-expected.txt:
* platform/mac/editing/style/smoosh-styles-001-expected.txt:
* platform/mac/editing/style/style-3998892-fix-expected.txt:
* platform/mac/editing/style/style-boundary-001-expected.txt:
* platform/mac/editing/style/style-boundary-004-expected.txt:
* platform/mac/editing/style/style-boundary-005-expected.txt:
* platform/mac/editing/unsupported-content/list-delete-001-expected.txt:
* platform/mac/editing/unsupported-content/list-delete-003-expected.txt:
* platform/mac/editing/unsupported-content/list-type-after-expected.txt:
* platform/mac/editing/unsupported-content/list-type-before-expected.txt:
* platform/mac/editing/unsupported-content/table-delete-002-expected.txt:
* platform/mac/editing/unsupported-content/table-type-after-expected.txt:
* platform/mac/editing/unsupported-content/table-type-before-expected.txt:
* platform/mac/fast/backgrounds/background-clip-text-expected.txt:
* platform/mac/fast/backgrounds/border-radius-split-background-image-expected.txt:
* platform/mac/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
* platform/mac/fast/block/float/002-expected.txt:
* platform/mac/fast/block/float/021-expected.txt:
* platform/mac/fast/block/margin-collapse/104-expected.txt:
* platform/mac/fast/block/positioning/056-expected.txt:
* platform/mac/fast/block/positioning/differing-writing-modes-expected.txt:
* platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.txt:
* platform/mac/fast/block/positioning/trailing-space-test-expected.txt:
* platform/mac/fast/borders/border-styles-split-expected.txt:
* platform/mac/fast/box-shadow/basic-shadows-expected.txt:
* platform/mac/fast/clip/nestedTransparencyClip-expected.txt:
* platform/mac/fast/clip/overflow-border-radius-combinations-expected.txt:
* platform/mac/fast/clip/overflow-border-radius-composited-expected.txt:
* platform/mac/fast/clip/overflow-border-radius-transformed-expected.txt:
* platform/mac/fast/css-generated-content/inline-display-types-expected.txt:
* platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.txt:
* platform/mac/fast/css-generated-content/table-row-group-with-before-expected.txt:
* platform/mac/fast/css-generated-content/table-row-with-before-expected.txt:
* platform/mac/fast/css-generated-content/table-with-before-expected.txt:
* platform/mac/fast/css/001-expected.txt:
* platform/mac/fast/css/first-letter-first-line-hover-expected.txt:
* platform/mac/fast/css/first-line-text-decoration-expected.txt:
* platform/mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
* platform/mac/fast/css/focus-ring-detached-expected.txt:
* platform/mac/fast/css/font-smoothing-expected.txt:
* platform/mac/fast/css/hsl-color-expected.txt:
* platform/mac/fast/css/layerZOrderCrash-expected.txt:
* platform/mac/fast/css/line-height-overflow-expected.txt:
* platform/mac/fast/css/nth-child-dynamic-expected.txt:
* platform/mac/fast/css/outline-narrowLine-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
* platform/mac/fast/css/text-rendering-expected.txt:
* platform/mac/fast/css/word-space-extra-expected.txt:
* platform/mac/fast/dom/HTMLElement/bdo-expected.txt:
* platform/mac/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
* platform/mac/fast/dom/HTMLTableElement/colSpan-expected.txt:
* platform/mac/fast/dom/HTMLTableElement/createCaption-expected.txt:
* platform/mac/fast/dom/children-nodes-expected.txt:
* platform/mac/fast/dom/focus-contenteditable-expected.txt:
* platform/mac/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.txt:
* platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
* platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
* platform/mac/fast/encoding/xmacroman-encoding-test-expected.txt:
* platform/mac/fast/events/standalone-image-drag-to-editable-expected.txt:
* platform/mac/fast/forms/007-expected.txt:
* platform/mac/fast/forms/basic-textareas-expected.txt:
* platform/mac/fast/forms/button-table-styles-expected.txt:
* platform/mac/fast/forms/caret-rtl-expected.txt:
* platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
* platform/mac/fast/forms/input-baseline-expected.txt:
* platform/mac/fast/forms/input-disabled-color-expected.txt:
* platform/mac/fast/forms/input-type-text-min-width-expected.txt:
* platform/mac/fast/forms/negativeLineHeight-expected.txt:
* platform/mac/fast/forms/option-index-expected.txt:
* platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/mac/fast/forms/range/slider-padding-expected.txt:
* platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
* platform/mac/fast/frames/001-expected.txt:
* platform/mac/fast/frames/iframe-with-frameborder-expected.txt:
* platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
* platform/mac/fast/hidpi/image-set-border-image-comparison-expected.txt:
* platform/mac/fast/inline-block/001-expected.txt:
* platform/mac/fast/inline-block/006-expected.txt:
* platform/mac/fast/inline-block/contenteditable-baseline-expected.txt:
* platform/mac/fast/inline-block/tricky-baseline-expected.txt:
* platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
* platform/mac/fast/invalid/010-expected.txt:
* platform/mac/fast/invalid/021-expected.txt:
* platform/mac/fast/layers/overflow-scroll-auto-switch-expected.txt:
* platform/mac/fast/layers/video-layer-expected.txt:
* platform/mac/fast/line-grid/line-grid-contains-value-expected.txt:
* platform/mac/fast/line-grid/line-grid-floating-expected.txt:
* platform/mac/fast/line-grid/line-grid-inside-columns-expected.txt:
* platform/mac/fast/line-grid/line-grid-into-columns-expected.txt:
* platform/mac/fast/line-grid/line-grid-into-floats-expected.txt:
* platform/mac/fast/line-grid/line-grid-positioned-expected.txt:
* platform/mac/fast/multicol/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/column-count-with-rules-expected.txt:
* platform/mac/fast/multicol/float-paginate-complex-expected.txt:
* platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt:
* platform/mac/fast/multicol/float-paginate-expected.txt:
* platform/mac/fast/multicol/layers-in-multicol-expected.txt:
* platform/mac/fast/multicol/max-height-columns-block-expected.txt:
* platform/mac/fast/multicol/paginate-block-replaced-expected.txt:
* platform/mac/fast/multicol/positioned-split-expected.txt:
* platform/mac/fast/multicol/table-vertical-align-expected.txt:
* platform/mac/fast/multicol/unsplittable-inline-block-expected.txt:
* platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/vertical-lr/column-count-with-rules-expected.txt:
* platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
* platform/mac/fast/multicol/vertical-lr/float-paginate-expected.txt:
* platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt:
* platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/vertical-rl/column-count-with-rules-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-paginate-expected.txt:
* platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt:
* platform/mac/fast/overflow/002-expected.txt:
* platform/mac/fast/overflow/006-expected.txt:
* platform/mac/fast/overflow/line-clamp-expected.txt:
* platform/mac/fast/overflow/overflow-float-stacking-expected.txt:
* platform/mac/fast/overflow/overflow-stacking-expected.txt:
* platform/mac/fast/overflow/position-fixed-transform-clipping-expected.txt:
* platform/mac/fast/overflow/table-overflow-float-expected.txt:
* platform/mac/fast/reflections/reflection-direction-expected.txt:
* platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.txt:
* platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.txt:
* platform/mac/fast/repaint/make-children-non-inline-expected.txt:
* platform/mac/fast/repaint/selection-after-remove-expected.txt:
* platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
* platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.txt:
* platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
* platform/mac/fast/replaced/007-expected.txt:
* platform/mac/fast/replaced/selection-rect-transform-expected.txt:
* platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
* platform/mac/fast/ruby/ruby-inline-table-expected.txt:
* platform/mac/fast/ruby/ruby-length-expected.txt:
* platform/mac/fast/ruby/ruby-run-break-expected.txt:
* platform/mac/fast/ruby/ruby-runs-expected.txt:
* platform/mac/fast/ruby/ruby-simple-expected.txt:
* platform/mac/fast/ruby/ruby-simple-rp-expected.txt:
* platform/mac/fast/table/005-expected.txt:
* platform/mac/fast/table/009-expected.txt:
* platform/mac/fast/table/039-expected.txt:
* platform/mac/fast/table/040-expected.txt:
* platform/mac/fast/table/040-vertical-expected.txt:
* platform/mac/fast/table/cellindex-expected.txt:
* platform/mac/fast/table/percent-heights-expected.txt:
* platform/mac/fast/table/table-and-parts-outline-expected.txt:
* platform/mac/fast/text/basic/012-expected.txt:
* platform/mac/fast/text/basic/014-expected.txt:
* platform/mac/fast/text/basic/generic-family-reset-expected.txt:
* platform/mac/fast/text/complex-synthetic-bold-space-width-expected.txt:
* platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
* platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
* platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
* platform/mac/fast/text/international/bidi-listbox-expected.txt:
* platform/mac/fast/text/international/hebrew-vowels-expected.txt:
* platform/mac/fast/text/international/thai-baht-space-expected.txt:
* platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
* platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
* platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/mac/fast/transforms/transformed-caret-expected.txt:
* platform/mac/fast/writing-mode/border-styles-vertical-lr-expected.txt:
* platform/mac/fast/writing-mode/border-styles-vertical-rl-expected.txt:
* platform/mac/fast/writing-mode/english-bt-text-expected.txt:
* platform/mac/fast/writing-mode/english-lr-text-expected.txt:
* platform/mac/fast/writing-mode/english-rl-text-expected.txt:
* platform/mac/fast/writing-mode/fieldsets-expected.txt:
* platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:
* platform/mac/fast/xsl/xslt-enc-cyr-expected.txt:
* platform/mac/fast/xsl/xslt-enc-expected.txt:
* platform/mac/fast/xsl/xslt-enc16-expected.txt:
* platform/mac/fast/xsl/xslt-enc16to16-expected.txt:
* platform/mac/fonts/default-expected.txt:
* platform/mac/fonts/fantasy-expected.txt:
* platform/mac/fonts/monospace-expected.txt:
* platform/mac/fonts/sans-serif-expected.txt:
* platform/mac/fonts/serif-expected.txt:
* platform/mac/http/tests/loading/simple-subframe-expected.txt:
* platform/mac/http/tests/local/file-url-sent-as-referer-expected.txt:
* platform/mac/http/tests/misc/favicon-as-image-expected.txt:
* platform/mac/http/tests/misc/frame-access-during-load-expected.txt:
* platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/mac/http/tests/navigation/postredirect-basic-expected.txt:
* platform/mac/http/tests/navigation/postredirect-goback1-expected.txt:
* platform/mac/media/video-transformed-expected.txt:
* platform/mac/scrollbars/basic-scrollbar-expected.txt:
* platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt:
* platform/mac/svg/as-image/animated-svg-as-image-expected.txt:
* platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.txt:
* platform/mac/svg/custom/getsvgdocument-expected.txt:
* platform/mac/tables/mozilla/bugs/bug106158-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug10633-expected.txt:
* platform/mac/tables/mozilla/bugs/bug11026-expected.txt:
* platform/mac/tables/mozilla/bugs/bug113235-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1224-expected.txt:
* platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
* platform/mac/tables/mozilla/bugs/bug131020_iframe-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1430-expected.txt:
* platform/mac/tables/mozilla/bugs/bug149275-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug16012-expected.txt:
* platform/mac/tables/mozilla/bugs/bug17138-expected.txt:
* platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug19599-expected.txt:
* platform/mac/tables/mozilla/bugs/bug20579-expected.txt:
* platform/mac/tables/mozilla/bugs/bug20804-expected.txt:
* platform/mac/tables/mozilla/bugs/bug23235-expected.txt:
* platform/mac/tables/mozilla/bugs/bug23299-expected.txt:
* platform/mac/tables/mozilla/bugs/bug25663-expected.txt:
* platform/mac/tables/mozilla/bugs/bug28341-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2962-expected.txt:
* platform/mac/tables/mozilla/bugs/bug30332-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
* platform/mac/tables/mozilla/bugs/bug32205-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug32205-3-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4093-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4284-expected.txt:
* platform/mac/tables/mozilla/bugs/bug43854-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug43854-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4427-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4849-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug5538-expected.txt:
* platform/mac/tables/mozilla/bugs/bug55694-expected.txt:
* platform/mac/tables/mozilla/bugs/bug5799-expected.txt:
* platform/mac/tables/mozilla/bugs/bug5838-expected.txt:
* platform/mac/tables/mozilla/bugs/bug60992-expected.txt:
* platform/mac/tables/mozilla/bugs/bug6404-expected.txt:
* platform/mac/tables/mozilla/bugs/bug82946-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug8858-expected.txt:
* platform/mac/tables/mozilla/bugs/bug8950-expected.txt:
* platform/mac/tables/mozilla/bugs/bug9123-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug92143-expected.txt:
* platform/mac/tables/mozilla/bugs/bug92868-expected.txt:
* platform/mac/tables/mozilla/bugs/bug963-expected.txt:
* platform/mac/tables/mozilla/core/bloomberg-expected.txt:
* platform/mac/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
* platform/mac/tables/mozilla/core/col_widths_fix_auto-expected.txt:
* platform/mac/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
* platform/mac/tables/mozilla/marvin/table_row_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/table_row_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/table_row_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_border_0-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_border_1-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_border_2-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_border_3-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_cellpadding-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_cellspacing-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_default-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_td_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_td_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_td_colspan-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_td_height-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_td_width-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_th_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_th_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_th_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_th_colspan-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_th_height-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
* platform/mac/tables/mozilla/marvin/tables_th_width-expected.txt:
* platform/mac/tables/mozilla/other/nestedTables-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug11331-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1262-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/col_span2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
* platform/mac/transforms/3d/hit-testing/backface-hit-test-expected.txt:
* platform/mac/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[GLIB] Unreviewed test gardening. Update baseline of fast/css/word-space-extra.html...
dpino@igalia.com [Thu, 15 Oct 2020 10:46:29 +0000 (10:46 +0000)]
[GLIB] Unreviewed test gardening. Update baseline of fast/css/word-space-extra.html after r268202.

* platform/glib/fast/css/word-space-extra-expected.png: Renamed from LayoutTests/platform/gtk/fast/css/word-space-extra-expected.png.
* platform/glib/fast/css/word-space-extra-expected.txt: Renamed from LayoutTests/platform/gtk/fast/css/word-space-extra-expected.txt.
* platform/wpe/fast/css/word-space-extra-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agowebkitpy: Fix remaining pytest autoinstall imports
lmoura@igalia.com [Thu, 15 Oct 2020 10:44:38 +0000 (10:44 +0000)]
webkitpy: Fix remaining pytest autoinstall imports
https://bugs.webkit.org/show_bug.cgi?id=217694

Reviewed by Carlos Garcia Campos.

* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump mini
version due to argument rename below.
* Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.__init__): Change argument name to communicate that the first
arg is the name of the package to be imported.
* Scripts/webkitpy/__init__.py: Some changes:
- Downgrade attr to a compatible version with the pytest used.
- Fix pytest_timeout import name
- Downgrade pytest to 3.x. Version 4.x deprecated direct invocation of
fixtures, which is still used by W3C webdriver test code.

* Scripts/webkitpy/webdriver_tests/pytest_runner.py:
(run): Avoid using pytest autoload features to ensure it would import
plugins like pytest_timeout, triggering their install.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoNon-unified build fixes, mid October 2020, take two
aperez@igalia.com [Thu, 15 Oct 2020 08:09:38 +0000 (08:09 +0000)]
Non-unified build fixes, mid October 2020, take two
https://bugs.webkit.org/show_bug.cgi?id=217734

Unreviewed build fix.

Source/WebCore:

No new tests needed.

* Modules/webaudio/AudioWorklet.cpp: Add missing AudioWorkletProcessor.h header.
* Modules/webaudio/AudioWorkletGlobalScope.cpp: Add missing BaseAudioContext.h header.
* Modules/webaudio/AudioWorkletNode.cpp: Add missing AudioParamDescriptor.h header.
* Modules/webaudio/AudioWorkletNode.h: Add missing forward declaration for the
JSC::JSGlobalObject type.
* workers/WorkerRunLoop.cpp: Add missing JavaScriptCore/JSRunLoopTimer.h header, move
inclusion of WorkerRunLoop.h header up to please the style checker.

Source/WebKit:

* UIProcess/WebProcessProxy.cpp: Add missing WebPreferencesKeys.h header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[css-flexbox] flex-grow property should be animatable
svillar@igalia.com [Thu, 15 Oct 2020 07:54:56 +0000 (07:54 +0000)]
[css-flexbox] flex-grow property should be animatable
https://bugs.webkit.org/show_bug.cgi?id=209872

Reviewed by Antoine Quint.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-flexbox/animation/flex-grow-interpolation-expected.txt: New expected PASS results.
* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt: Additional results.
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt: Ditto.
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt: Ditto.
* web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt: Ditto.

Source/WebCore:

Make flew-grow animatable as per spec. This allows us to pass a bunch of flexbox animation subtests.

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Add the wrapper for flex-grow.
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setFlexGrow): Clamp flex-grow to 0 as negative values are invalid.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[WinCairo] Unreviewed test gardening
Hironori.Fujii@sony.com [Thu, 15 Oct 2020 03:28:42 +0000 (03:28 +0000)]
[WinCairo] Unreviewed test gardening

* platform/wincairo/TestExpectations:
* platform/wincairo/fast/css/word-space-extra-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[iOS] Allow additional sysctl reads needed by image decoding
bfulgham@apple.com [Thu, 15 Oct 2020 03:24:20 +0000 (03:24 +0000)]
[iOS] Allow additional sysctl reads needed by image decoding
https://bugs.webkit.org/show_bug.cgi?id=217733
<rdar://problem/68649171>

Reviewed by Per Arne Vollan.

Telemetry on iOS 14 shows that we are hitting some sandbox violations during image decoding. We should
grant access to hw.byteorder, hw.cachelinesize_compat, and hw.vectorunit. We should silence warnings
about hw.cpufrequency_compat since it is not needed in web-facing use cases.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoRename VectorMath::multiplyThenAddScalar() for clarity
cdumez@apple.com [Thu, 15 Oct 2020 02:29:30 +0000 (02:29 +0000)]
Rename VectorMath::multiplyThenAddScalar() for clarity
https://bugs.webkit.org/show_bug.cgi?id=217744

Reviewed by Darin Adler.

Rename VectorMath::multiplyThenAddScalar() to VectorMath::multiplyByScalarThenAddToOutput()
for clarity. The previous name was a bit confusing and hopefully the new name makes it
clearer what the function actually does. If not, I also improved the comment next to the
function.

* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::speakersSumFromByDownMixing):
* platform/audio/VectorMath.cpp:
(WebCore::VectorMath::multiplyByScalarThenAddToOutput):
* platform/audio/VectorMath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoVectorize downmixing in AudioBus::createByMixingToMono()
cdumez@apple.com [Thu, 15 Oct 2020 02:23:21 +0000 (02:23 +0000)]
Vectorize downmixing in AudioBus::createByMixingToMono()
https://bugs.webkit.org/show_bug.cgi?id=217743

Reviewed by Darin Adler.

Vectorize downmixing in AudioBus::createByMixingToMono().

No new tests, no Web-facing behavior change.

* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::createByMixingToMono):
* platform/audio/VectorMath.cpp:
(WebCore::VectorMath::addVectorsThenMultiplyByScalar):
* platform/audio/VectorMath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoUnreviewed build fix for non-Cocoa platforms & release builds.
rniwa@webkit.org [Thu, 15 Oct 2020 01:43:42 +0000 (01:43 +0000)]
Unreviewed build fix for non-Cocoa platforms & release builds.

* Platform/IPC/Connection.cpp:
(IPC::Connection::dispatchSyncMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoSource/WebKit:
rniwa@webkit.org [Thu, 15 Oct 2020 00:33:30 +0000 (00:33 +0000)]
Source/WebKit:
IPC testing JS API should expose a reply and describe the list of arguments for each message
https://bugs.webkit.org/show_bug.cgi?id=217565

Reviewed by Geoffrey Garen.

This patch makes IPC.sendMessage and IPC.sendSyncMessage decode the reply. IPC.sendSyncMessage now returns
a dictionary with two keys: "buffer" and "arguments", the first of which returns ArrayBuffer of the decoded
message reply and the second of which is an array of decoded arguments where there was an appropriate JS
binding code existed for the argument type. IPC.sendMessage now returns a Promise which can either resolve
with the same dictionary as IPC.sendSyncMessage or reject when the decoding fails.

In addition, this patch exposes a dictionary describing each IPC message argument's type and parameter name.

In order to add these two functionalities, this patch adds a new step in generate-message-receiver.py to
generate MessageArgumentDescriptions.cpp, which contains functions which know how to decode arguments of
any IPC message and create a JS dictionary describing it as well as functions that return descriptions of
arguments or reply arguments.

Finally, this patch adds encoders for a few types found to be very common after r268239 had been landed.

Tests: TestWebKitAPI.IPCTestingAPI.DecodesReplyArgumentsForPrompt
       TestWebKitAPI.IPCTestingAPI.DecodesReplyArgumentsForAsyncMessage
       TestWebKitAPI.IPCTestingAPI.DescribesArguments

* CMakeLists.txt:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Platform/IPC/Decoder.h:
(IPC::Decoder::buffer const):
* Platform/IPC/JSIPCBinding.h: Added.
(jsValueForDecodedArgumentValue): Added. A template function to construct a JS value for a given C++ value.
(jsValueForDecodedNumericArgumentValue): Added. A helper for constructing a JS value for numeric values.
(jsValueForDecodedArgumentRect): Added. Ditto for IntRect and FloatRect.
(DecodedArgumentJSValueConverter): Added. A helper class to construct JS values for a tuple of values using
partial template specializations.
(DecodedArgumentJSValueConverter::convert): Added.
(jsValueForArgumentTuple): Added. A helper to construct a JS array for the decoded IPC arguments.
(jsValueForDecodedArguments): Added.
* Platform/IPC/MessageArgumentDescriptions.h: Added.
(IPC::ArgumentDescription): Added.
* Scripts/generate-message-receiver.py:
(main): Generate MessageArgumentDescriptions.cpp.
* Scripts/webkit/messages.py:
(headers_for_type): Removed the special case for PaymentMethodUpdate now that it's in its own header. Also
added made webrtc::WebKitEncodedFrameInfo include LibWebRTCEnumTraits.h as it uses webrtc::VideoFrameType.
(collect_header_conditions_for_receiver): Extracted from generate_message_handler.
(generate_header_includes_from_conditions): Ditto.
(generate_message_handler):
(generate_js_value_conversion_function): Added.
(generate_js_argument_descriptions): Added.
(generate_message_argument_description_implementation): Added.
* Shared/ApplePay/ApplePayPaymentSetupFeaturesWebKit.h: Fixed a bug that we were not forward declaring NSArray.
* SourcesCocoa.txt: Added MessageArgumentDescriptions.cpp as a non-unified cpp file as its size is around 1MB.
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSIPC::staticValues): Added the session ID and page ID as static variables.
(WebKit::IPCTestingAPI::encodePointType): Added.
(WebKit::IPCTestingAPI::encodeRectType): Fixed the bug was that this code wasn't checking for any exceptions.
(WebKit::IPCTestingAPI::encodeNumericType): Renamed from encodeIntegralType since this function is now used
to encode double and float, not just integral types.
(WebKit::IPCTestingAPI::encodeArgument): Added the support for IntPoint, FloatPoint, URL, RegistrableDomain,
double, and float all of which turned out to be in the top 20 most common types.
(WebKit::IPCTestingAPI::jsResultFromReplyDecoder): Added.
(WebKit::IPCTestingAPI::JSIPC::sendMessage): Added the code to return Promise when there is a reply and resolve
it with the JS object describing the decoded argument. We use messageReplyArgumentDescriptions to figure out
whether there is a reply or not.
(WebKit::IPCTestingAPI::JSIPC::sendSyncMessage): Decode the reply and return a JS object which describes it.
(WebKit::IPCTestingAPI::JSIPC::frameID): Renamed from frameIdentifier to be consistent.
(WebKit::IPCTestingAPI::JSIPC::pageID): Added.
(WebKit::IPCTestingAPI::JSIPC::sessionID): Added.
(WebKit::IPCTestingAPI::createJSArrayForArgumentDescriptions): Added.
(WebKit::IPCTestingAPI::JSIPC::messages): Added the code to generate descriptions for arguments.

Source/WTF:
Unreviewed build fix. Disable IPC testing API on non-Cocoa platforms.

* wtf/PlatformEnable.h:

Tools:
IPC testing JS API should expose a reply and describe the list of arguments for each message
https://bugs.webkit.org/show_bug.cgi?id=217565

Reviewed by Geoffrey Garen.

Added tests for decoding replies for sync and async messages and one for argument descriptions.

* TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:
(-[IPCTestingAPIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
(-[IPCTestingAPIDelegate _webView:webContentProcessDidTerminateWithReason:]):
(IPCTestingAPI.DecodesReplyArgumentsForPrompt):
(IPCTestingAPI.DecodesReplyArgumentsForAsyncMessage):
(IPCTestingAPI.DescribesArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoUnity RubysAdventure demo does not render properly if WebGL2 is enabled.
jdarpinian@chromium.org [Thu, 15 Oct 2020 00:24:05 +0000 (00:24 +0000)]
Unity RubysAdventure demo does not render properly if WebGL2 is enabled.
https://bugs.webkit.org/show_bug.cgi?id=215846

Reviewed by Kenneth Russell.

Source/WebCore:

uniform*v srcLength parameter needs to be divided by the uniform
component size before passing to OpenGL's count parameter.

Test: webgl/conformance2/uniforms/gl-uniform-arrays-sub-source.html

* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::uniform2uiv):
(WebCore::WebGL2RenderingContext::uniform3uiv):
(WebCore::WebGL2RenderingContext::uniform4uiv):
(WebCore::WebGL2RenderingContext::uniformMatrix2x3fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3x2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix2x4fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4x2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3x4fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4x3fv):
(WebCore::WebGL2RenderingContext::uniform2fv):
(WebCore::WebGL2RenderingContext::uniform3fv):
(WebCore::WebGL2RenderingContext::uniform4fv):
(WebCore::WebGL2RenderingContext::uniform2iv):
(WebCore::WebGL2RenderingContext::uniform3iv):
(WebCore::WebGL2RenderingContext::uniform4iv):
(WebCore::WebGL2RenderingContext::uniformMatrix2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4fv):

LayoutTests:

* webgl/conformance2/uniforms/gl-uniform-arrays-sub-source-expected.txt: Added.
* webgl/conformance2/uniforms/gl-uniform-arrays-sub-source.html: Added.
* webgl/resources/webgl_test_files/conformance2/uniforms/gl-uniform-arrays-sub-source.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoUpdate test262 (2020.10.14)
ross.kirsling@sony.com [Thu, 15 Oct 2020 00:11:53 +0000 (00:11 +0000)]
Update test262 (2020.10.14)
https://bugs.webkit.org/show_bug.cgi?id=217736

Reviewed by Yusuke Suzuki.

* test262/config.yaml:
* test262/expectations.yaml:
* test262/harness/:
* test262/latest-changes-summary.txt:
* test262/test/:
* test262/test262-Revision.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoREGRESSION(r268423) SHOULD NEVER BE REACHED: GPUConnectionToWebProcess::didReceiveMes...
cdumez@apple.com [Thu, 15 Oct 2020 00:09:17 +0000 (00:09 +0000)]
REGRESSION(r268423) SHOULD NEVER BE REACHED: GPUConnectionToWebProcess::didReceiveMessage(IPC::Connection &, IPC::Decoder &)
https://bugs.webkit.org/show_bug.cgi?id=217730
<rdar://problem/70308112>

Reviewed by Geoffrey Garen.

r268423 added support for registering IPC WorkQueueMessageReceivers & ThreadMessageReceivers with
a given identifier. When receiving an IPC message, we would look up the key [ReceiverName, ID] in
the receiver map and pass the message to this receiver.
This introduced a crash because of an existing ThreadMessageReceiver (RemoteAudioMediaStreamTrackRenderer)
was registering itself as a message receiver without an identifier (ID=0). However, the IPC senders
on GPU process side would pass a non-0 identifier when sending the IPC. As a result, we would fail to
look up the receiver in the map when receiving those IPC messages.

While existing code should probably be fixed so that senders and receivers agree on on identifier,
I have decided to fix the issue in this patch at IPC::Connection level. When receiving an IPC
message, we first check if there is a "global" receiver in the map by looking up key
[ReceiverName, 0]. If there is, we pass the IPC to this one. If there isn't, we look up the key
[ReceiverName, ID] in the map and use the more specific receiver.

The reason I chose to fix it this way is that the code in MessageReceiverMap (which is used for
receivers that are not using a WorkQueue or a Thread) behaves in this fashion. I believe it is
good to have consistency between all kinds of receivers.

No new tests, covered by existing test that is crashing on the bots.

* Platform/IPC/Connection.cpp:
(IPC::Connection::threadMessageReceiver):
(IPC::Connection::workQueueMessageReceiver):
(IPC::Connection::dispatchMessageToWorkQueueReceiver):
(IPC::Connection::dispatchMessageToThreadReceiver):
* Platform/IPC/Connection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoScrolls in the passive handler region should be reported as handled promptly
simon.fraser@apple.com [Wed, 14 Oct 2020 23:55:58 +0000 (23:55 +0000)]
Scrolls in the passive handler region should be reported as handled promptly
https://bugs.webkit.org/show_bug.cgi?id=217718

Reviewed by Tim Horton.

The UI process will enqueue wheel events to send later if the WebContent process doesn't
promptly respond that it has handled the previous event. When scrolling in the passive
event region, we want the WebContent process to appear responsive, so respond to the UI
process when we've scrolled (which is before the event has been dispatched for DOM events).

Hard to test because CPU-constrained bots don't send wheel events in a predictable way.

* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::wheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoUnreviewed, reverting r268474.
hector_i_lopez@apple.com [Wed, 14 Oct 2020 23:21:10 +0000 (23:21 +0000)]
Unreviewed, reverting r268474.

Revision is causing a number of test failures across iOS and
macOS

Reverted changeset:

"[Testing] Support configuring any preference from test
headers for WebKitTestRunner"
https://bugs.webkit.org/show_bug.cgi?id=217645
https://trac.webkit.org/changeset/268474

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoEnabling IPC testing API should prevent the termination of WebContent process which...
rniwa@webkit.org [Wed, 14 Oct 2020 23:14:55 +0000 (23:14 +0000)]
Enabling IPC testing API should prevent the termination of WebContent process which sends an invalid IPC
https://bugs.webkit.org/show_bug.cgi?id=217698

Reviewed by Geoffrey Garen.

Source/WebKit:

A part of this was landed in r268431 but this patch formally disables UI process' default behavior
to terminate a Web process upon receiving an invalid message from it.

Tests: IPCTestingAPI.CanSendInvalidAsyncMessageWithoutTermination
       IPCTestingAPI.CanSendInvalidMessageWithoutTermination

* Platform/IPC/Connection.cpp:
(IPC::Connection::dispatchSyncMessage): Disable the debug assertion if the IPC testing API is enabled.
* Platform/IPC/Connection.h:
(IPC::Connection::setIgnoreInvalidMessageForTesting): Added.
(IPC::Connection::ignoreInvalidMessageForTesting const): Added.
(IPC::Connection::m_ignoreInvalidMessageForTesting): Added.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Set the flag on WebProcessProxy to trigger the behavior.
(WebKit::WebPageProxy::launchProcess): Ditto.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveInvalidMessage): Use the flag on Connection instead of reaching
out to the default page group.
(WebKit::WebProcessProxy::setIgnoreInvalidMessageForTesting): Added. Remember the fact we've enabled IPC
testing API in a member variable and propagate the flag to Connection if a Web process is already running.
(WebKit::WebProcessProxy::didFinishLaunching): Propagte the flag to the newly launched Web process.
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::m_ignoreInvalidMessageForTesting): Added.

Tools:

Added regression tests.

* TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:
(IPCTestingAPI.CanSendInvalidAsyncMessageWithoutTermination):
(IPCTestingAPI.CanSendInvalidMessageWithoutTermination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[build.webkit.org] Add python 3 support - part 1
aakash_jain@apple.com [Wed, 14 Oct 2020 23:08:15 +0000 (23:08 +0000)]
[build.webkit.org] Add python 3 support - part 1
https://bugs.webkit.org/show_bug.cgi?id=217727

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/build.webkit.org-config/steps.py:
(UploadBuiltProduct.__init__): Changed 0644 to 0o644.
(UploadTestResults.__init__): Ditto.
* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Removed unused imports.
* BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py: Used .format() instead of % string formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[Testing] Generate test header key map for DumpRenderTree
weinig@apple.com [Wed, 14 Oct 2020 22:52:56 +0000 (22:52 +0000)]
[Testing] Generate test header key map for DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=217723

Reviewed by Tim Horton.

Copy test header command type generation from WebKitTestRunner to DumpRenderTree, to
begin support for using any WebPreference from DumpRenderTree. This does not actually
change any behavior yet, just updates the key mapping.

* DumpRenderTree/CMakeLists.txt:
* DumpRenderTree/DerivedSources-input.xcfilelist:
* DumpRenderTree/DerivedSources-output.xcfilelist:
* DumpRenderTree/DerivedSources.make:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/Scripts/PreferencesTemplates: Added.
* DumpRenderTree/Scripts/PreferencesTemplates/TestOptionsGeneratedKeys.h.erb: Added.
* DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::keyTypeMapping):
* DumpRenderTree/TestOptions.h:
* DumpRenderTree/mac/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoSupport AXCoreObject::elementPath for text elements.
andresg_22@apple.com [Wed, 14 Oct 2020 22:47:26 +0000 (22:47 +0000)]
Support AXCoreObject::elementPath for text elements.
https://bugs.webkit.org/show_bug.cgi?id=215206

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/text-element-path.html

Text elements now support returning a Path in those cases where the
element consists of the last part of a line and the beginning of the
next line. Heuristics were added to avoid to compute the element Path for those cases in which the bounding rectangle is suitable.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::supportsPath const):
(WebCore::AccessibilityRenderObject::elementPath const):

LayoutTests:

* accessibility/mac/bounds-for-range-expected.txt:
Since elementPath is now supported for text elements,
AccessibilityUIEelement::attributesOfLinkedUIElements also returns the
element path description.
* accessibility/mac/internal-link-anchors-expected.txt: Ditto.
* accessibility/text-element-path-expected.txt: Added.
* accessibility/text-element-path.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[macOS] Issue sandbox extension to additional icon service when attachment element...
pvollan@apple.com [Wed, 14 Oct 2020 22:19:18 +0000 (22:19 +0000)]
[macOS] Issue sandbox extension to additional icon service when attachment element is enabled.
https://bugs.webkit.org/show_bug.cgi?id=217706
<rdar://problem/70291100>

Reviewed by Brent Fulgham.

Issue sandbox extension to 'com.apple.iconservices.store' when attachment element is enabled on macOS.

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::attachmentElementServices):
(WebKit::WebPageProxy::creationParameters):
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoRebaseline editing/editable-region/iframe.html result
hector_i_lopez@apple.com [Wed, 14 Oct 2020 22:13:35 +0000 (22:13 +0000)]
Rebaseline editing/editable-region/iframe.html result
https://bugs.webkit.org/show_bug.cgi?id=158439

Unreviewed test gardening.

* editing/editable-region/iframe-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoRemove WebKitLauncher
ap@apple.com [Wed, 14 Oct 2020 22:10:11 +0000 (22:10 +0000)]
Remove WebKitLauncher
https://bugs.webkit.org/show_bug.cgi?id=217729

Reviewed by Darin Adler.

This is part of long defunct nightly build infrastructure.

* .gitattributes:
* BuildSlaveSupport/build-launcher-app: Removed.
* Scripts/webkitpy/style/checkers/sdkvariant.py:
* WebKitLauncher: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoUse @putByValDirect instead of Array.prototype.@push in built-ins
shvaikalesh@gmail.com [Wed, 14 Oct 2020 21:48:50 +0000 (21:48 +0000)]
Use @putByValDirect instead of Array.prototype.@push in built-ins
https://bugs.webkit.org/show_bug.cgi?id=175432

Reviewed by Yusuke Suzuki.

JSTests:

* stress/array-push-intrinsic.js: Added.
* test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

Before this patch, Array.prototype.@push was used to implement List spec type,
stacks / queues, and in place of CreateDataProperty [1].
It's undesirably observable since elements are pushed using [[Set]],
affecting indexed properties on prototypes [2].

This change introduces @arrayPush() intrinsic to use with lists / stacks / queues.
@arrayPush() should only be used with JSArray receivers because "length" isn't
incremented. Unlike Array.prototype.@push, it doesn't grow arrays beyond UINT_MAX,
which is OK for current use cases. Object.entries microbenchmark is neutral.

Despite Array.prototype.@shift also performing [[Set]], it's safe to use with
non-sparse receivers.

[1]: https://tc39.es/ecma262/#sec-createarrayfromlist (step 4.a)
[2]: https://tc39.es/ecma262/#sec-array.prototype.push (step 5.a)

* builtins/ArrayPrototype.js:
(globalPrivate.sortBucketSort):
* builtins/ObjectConstructor.js:
(entries):
* builtins/RegExpPrototype.js:
(globalPrivate.matchSlow):
(Symbol.replace):
(Symbol.split):
* builtins/TypedArrayPrototype.js:
(filter):
* bytecode/BytecodeIntrinsicRegistry.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::BytecodeIntrinsicNode::emit_intrinsic_arrayPush):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):

Source/WebCore:

Use @arrayPush() intrinsic instead of Array.prototype.@push.

No new tests, no behavior change.

* Modules/streams/ReadableByteStreamInternals.js:
(readableByteStreamControllerPull):
(readableByteStreamControllerEnqueueChunk):
(readableByteStreamControllerPullInto):
(readableStreamAddReadIntoRequest):
* Modules/streams/ReadableStreamInternals.js:
(readableStreamAddReadRequest):
* Modules/streams/StreamInternals.js:
(enqueueValueWithSize):
* Modules/streams/WritableStreamInternals.js:
(writableStreamAddWriteRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoREGRESSION (r267744): [ Debug WK2 ] fast/css-custom-paint/out-of-memory-while-adding...
cdumez@apple.com [Wed, 14 Oct 2020 21:19:02 +0000 (21:19 +0000)]
REGRESSION (r267744): [ Debug WK2 ] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=217549

Reviewed by Sam Weinig.

After r267744, Worklet.addModule() returns a promise and no longer throws exceptions.
Update the test accordingly to expect that a promise gets rejected with an out of
memory error, instead of expecting an exception to be thrown.

* fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt:
* fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoPaint CSS highlights over images
megan_gardner@apple.com [Wed, 14 Oct 2020 20:55:00 +0000 (20:55 +0000)]
Paint CSS highlights over images
https://bugs.webkit.org/show_bug.cgi?id=217417

Reviewed by Tim Horton.

* http/wpt/css/css-highlight-api/highlight-image-expected-mismatched.html: Removed.
* http/wpt/css/css-highlight-api/highlight-image-expected-mismatch.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoUnreviewed, reverting r268431 and r268443.
commit-queue@webkit.org [Wed, 14 Oct 2020 20:52:37 +0000 (20:52 +0000)]
Unreviewed, reverting r268431 and r268443.
https://bugs.webkit.org/show_bug.cgi?id=217728

Broke debug builds of GTK, WinCairo and Playstation ports

Reverted changesets:

"IPC testing JS API should expose a reply and describe the
list of arguments for each message"
https://bugs.webkit.org/show_bug.cgi?id=217565
https://trac.webkit.org/changeset/268431

"IPC testing JS API should expose a reply and describe the
list of arguments for each message"
https://bugs.webkit.org/show_bug.cgi?id=217565
https://trac.webkit.org/changeset/268443

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoNon-unified build fixes, mid October 2020
don.olmstead@sony.com [Wed, 14 Oct 2020 20:46:32 +0000 (20:46 +0000)]
Non-unified build fixes, mid October 2020
https://bugs.webkit.org/show_bug.cgi?id=217721

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

* API/JSContextRef.cpp:
* dfg/DFGDoesGCCheck.cpp:
* llint/LLIntExceptions.cpp:
* llint/LLIntExceptions.h:
* llint/LLIntThunks.h:

Source/WebCore:

* Modules/webgpu/WebGPUShaderModule.h:
* html/canvas/EXTTextureCompressionRGTC.cpp:
* layout/floats/FloatingContext.cpp:
* layout/floats/FloatingContext.h:
* layout/inlineformatting/InlineFormattingContextGeometry.cpp:
* layout/inlineformatting/InlineLine.cpp:
* platform/graphics/gpu/GPUDevice.cpp:
* rendering/RenderReplaced.cpp:
* workers/WorkerRunLoop.cpp:

Source/WebKit:

* NetworkProcess/Downloads/DownloadManager.cpp:
* UIProcess/Downloads/DownloadProxyMap.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoRefactor HighlightData
megan_gardner@apple.com [Wed, 14 Oct 2020 20:42:23 +0000 (20:42 +0000)]
Refactor HighlightData
https://bugs.webkit.org/show_bug.cgi?id=217711

Reviewed by Darin Adler.

HighlightData was renamed when it was used for more that selections, but
more than half the file was only supposed to be used to deal with the current
selection, so I've split it back out into a more reasonable set of files.
Also made offsets no longer optional, as there doesn't seem to be a need.
Extended the HighlightData setRenderRange into InlineTextBox, as it's a better
way to calculate that does not use deprecated functions.

No behavior change.

* Headers.cmake:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setNeedsSelectionUpdate):
(WebCore::DragCaretController::nodeWillBeRemoved):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::FrameSelection::willBeRemovedFromFrame):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::updateAppearance):
* page/FrameView.cpp:
(WebCore::FrameView::paintContentsForSnapshot):
* platform/DragImage.cpp:
(WebCore::ScopedFrameSelectionState::~ScopedFrameSelectionState):
(WebCore::createDragImageForRange):
* rendering/HighlightData.cpp:
(WebCore::RenderRangeIterator::RenderRangeIterator):
(WebCore::RenderRangeIterator::current const):
(WebCore::RenderRangeIterator::next):
(WebCore::RenderRangeIterator::checkForSpanner):
(WebCore::rendererAfterOffset):
(WebCore::HighlightData::highlightStateForRenderer):
(): Deleted.
(WebCore::isValidRendererForSelection): Deleted.
(WebCore::containingBlockBelowView): Deleted.
(WebCore::collectSelectionData): Deleted.
(WebCore::HighlightData::HighlightData): Deleted.
(WebCore::HighlightData::setSelection): Deleted.
(WebCore::HighlightData::clearSelection): Deleted.
(WebCore::HighlightData::repaintSelection const): Deleted.
(WebCore::HighlightData::collectBounds const): Deleted.
(WebCore::HighlightData::applySelection): Deleted.
* rendering/HighlightData.h:
(WebCore::RenderRange::RenderRange):
(WebCore::RenderRange::start const):
(WebCore::RenderRange::end const):
(WebCore::RenderRange::startOffset const):
(WebCore::RenderRange::endOffset const):
(WebCore::RenderRange::operator== const):
(WebCore::HighlightData::startOffset const):
(WebCore::HighlightData::endOffset const):
(WebCore::HighlightData::RenderRange::RenderRange): Deleted.
(WebCore::HighlightData::RenderRange::start const): Deleted.
(WebCore::HighlightData::RenderRange::end const): Deleted.
(WebCore::HighlightData::RenderRange::startOffset const): Deleted.
(WebCore::HighlightData::RenderRange::endOffset const): Deleted.
(WebCore::HighlightData::RenderRange::operator== const): Deleted.
(WebCore::HighlightData::bounds const): Deleted.
(WebCore::HighlightData::boundsClippedToVisibleContent const): Deleted.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::collectMarkedTextsForHighlights const):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::calculateHighlightColor const):
* rendering/RenderView.h:
* rendering/SelectionRangeData.cpp: Copied from Source/WebCore/rendering/HighlightData.cpp.
(WebCore::rendererAfterOffset):
(WebCore::isValidRendererForSelection):
(WebCore::containingBlockBelowView):
(WebCore::collectSelectionData):
(WebCore::SelectionRangeData::SelectionData):
(WebCore::SelectionRangeData::set):
(WebCore::SelectionRangeData::clear):
(WebCore::SelectionRangeData::repaint const):
(WebCore::SelectionRangeData::collectBounds const):
(WebCore::SelectionRangeData::apply):
* rendering/SelectionRangeData.h: Added.
(WebCore::SelectionRangeData::bounds const):
(WebCore::SelectionRangeData::boundsClippedToVisibleContent const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoSimplify management of LayerPropertyAnimation instances in GraphicsLayerCA
graouts@webkit.org [Wed, 14 Oct 2020 20:37:54 +0000 (20:37 +0000)]
Simplify management of LayerPropertyAnimation instances in GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=217707
<rdar://problem/70291140>

Reviewed by Dean Jackson.

The management of LayerPropertyAnimation instances in GraphicsLayerCA spread
those animations between different data structures. We now simplify this to
be a single Vector<LayerPropertyAnimation> with three new properties.

The m_playState property indicates:

- whether the animation has been added to the list but awaiting the next commit
to be played (PlayPending)
- whether the animation has been committed and playing (Playing)
- whether the animation has been marked to be paused but awaiting the next commit
to be paused (PausePending)
- whether the animation has been committed and paused (Paused)

The m_pendingRemoval property indicates whether the animation has been marked for
removal upon the next commit.

The m_beginTime property indicates the time at which the animation was first added,
ensuring that the animation can be removed and re-added while preserving the same
begin time.

As such, when GraphicsLayerCA::updateAnimations() is called we remove all animations
from the layer, filter m_animations to only have animations that are not marked
as pending removal, and add the now-current list of animations to the layer.

No new test since this change is refactoring only and should not have any change
in behavior.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::animationIsRunning const):
(WebCore::animationCanBeAccelerated):
(WebCore::GraphicsLayerCA::pauseAnimation):
(WebCore::GraphicsLayerCA::removeAnimation):
(WebCore::GraphicsLayerCA::platformCALayerAnimationStarted):
(WebCore::GraphicsLayerCA::updateAnimations):
(WebCore::GraphicsLayerCA::isRunningTransformAnimation const):
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::removeCAAnimationFromLayer):
(WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
(WebCore::animationIdentifier): Deleted.
(WebCore::GraphicsLayerCA::animationCanBeAccelerated const): Deleted.
(WebCore::GraphicsLayerCA::addProcessingActionForAnimation): Deleted.
(WebCore::GraphicsLayerCA::ensureLayerAnimations): Deleted.
* platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::hasAnimations const):
(WebCore::GraphicsLayerCA::LayerPropertyAnimation::animationIdentifier const):
(WebCore::GraphicsLayerCA::moveAnimations):
(WebCore::GraphicsLayerCA::copyAnimations):
(WebCore::GraphicsLayerCA::animationIsRunning const): Deleted.
(WebCore::GraphicsLayerCA::AnimationProcessingAction::AnimationProcessingAction): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoREGRESSION (r268384): ASSERTION FAILED: _startCount > 1 in -[WKMouseDeviceObserver...
drousso@apple.com [Wed, 14 Oct 2020 20:27:42 +0000 (20:27 +0000)]
REGRESSION (r268384): ASSERTION FAILED: _startCount > 1 in -[WKMouseDeviceObserver stop]
https://bugs.webkit.org/show_bug.cgi?id=217684
<rdar://problem/70272646>

Reviewed by Tim Horton.

The `ASSERT` was incorrect in that it's possible for `_startCount` to be equal to `1`. Also
add a check to make sure `_startCount` doesn't overflow.

* UIProcess/ios/WKMouseDeviceObserver.mm:
(-[WKMouseDeviceObserver stop]):
* UIProcess/ios/WKStylusDeviceObserver.mm:
(-[WKStylusDeviceObserver stop]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoDisallow ports in file URLs
achristensen@apple.com [Wed, 14 Oct 2020 20:00:44 +0000 (20:00 +0000)]
Disallow ports in file URLs
https://bugs.webkit.org/show_bug.cgi?id=217252

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* web-platform-tests/url/a-element-expected.txt:
* web-platform-tests/url/a-element-xhtml-expected.txt:
* web-platform-tests/url/failure-expected.txt:
* web-platform-tests/url/url-constructor-expected.txt:
* web-platform-tests/url/url-setters-expected.txt:

Source/WTF:

This matches Chrome and the URL specification.
Covered by newly passing web platform tests.

* wtf/URLParser.cpp:
(WTF::URLParser::parsePort):

Tools:

* TestWebKitAPI/Tests/WTF/URLParser.cpp:
(TestWebKitAPI::TEST_F):

LayoutTests:

* fast/loader/file-URL-with-port-number-expected.txt:
* fast/loader/file-URL-with-port-number.html:
Update test to reflect this new behavior.  The test was added in r24484 and
based on discussion in https://github.com/whatwg/url/issues/548 I've decided to try it and see if we can make this change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoUnreviewed. Update my status to "reviewer" and add WebIDL expertise.
shvaikalesh@gmail.com [Wed, 14 Oct 2020 19:46:29 +0000 (19:46 +0000)]
Unreviewed. Update my status to "reviewer" and add WebIDL expertise.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoMediaRecorder .stop should not throw in Inactive state
youenn@apple.com [Wed, 14 Oct 2020 18:56:04 +0000 (18:56 +0000)]
MediaRecorder .stop should not throw in Inactive state
https://bugs.webkit.org/show_bug.cgi?id=217705

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

fix-217705

* web-platform-tests/mediacapture-record/MediaRecorder-stop-expected.txt:
* web-platform-tests/mediacapture-record/MediaRecorder-stop.html:

Source/WebCore:

Update according spec changes in https://github.com/w3c/mediacapture-record/pull/158.
stop no longer throws if media recorder is inactive.
Covered by updated test.

* Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::stopRecording):
* Modules/mediarecorder/MediaRecorder.h:
* Modules/mediarecorder/MediaRecorder.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoAllow passive mouse wheel event listeners to not force synchronous scrolling
simon.fraser@apple.com [Wed, 14 Oct 2020 18:06:37 +0000 (18:06 +0000)]
Allow passive mouse wheel event listeners to not force synchronous scrolling
https://bugs.webkit.org/show_bug.cgi?id=158439
<rdar://problem/28265360>

Reviewed by Tim Horton.
Source/WebCore:

Turn on ENABLE_WHEEL_EVENT_REGIONS for macOS, and hit-test the passive and active regions
in ScrollingTree::determineWheelEventProcessin() to determine whether scrolling needs to
happen on the main thread, communicating via WheelEventProcessingSteps.

Now that we use EventRegion to store wheel event region information, we no longer need
to consult wheel event targets im ScrollingCoordinator::absoluteEventTrackingRegionsForFrame(),
but the non-fast region does still contain rectangles for non-fast-scrollable overflow
if async overflow scrolling is disabled.

Frame::invalidateContentEventRegionsIfNeeded() needs a fix to ensure that when wheel
event handlers in non-fast-scrollable subframes change we invalidate event regions.

RenderLayerBacking::updateEventRegion() needs a fix so that the event region for the root
(for handlers registered on the document or window) covers the entire root layer; painting
code only covered the RenderView, which is too small (and root background painting is complex).

Finally, when the processing steps given to EventHandler::handleWheelEvent() do not
include MainThreadForScrolling, then we shouldn't scroll here. The check in
EventHandler::handleWheelEvent() applies to frames, and the one in EventHandler::defaultWheelEventHandler()
applies to overflow:scroll.

Test: fast/scrolling/mac/slow-scrolling-overflow.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::defaultWheelEventHandler):
* page/Frame.cpp:
(WebCore::Frame::invalidateContentEventRegionsIfNeeded):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame const):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::determineWheelEventProcessing):

Source/WTF:

Define ENABLE_WHEEL_EVENT_REGIONS for macOS.

* wtf/PlatformEnableCocoa.h:

LayoutTests:

Change tests that relied on dumping the non-fast scrollable rects for wheel handlers
to dump layer trees with event regions instead. They also need to wait for a
rendering update, since wheel event regions are updated once per frame.

slow-scrolling-overflow.html tests that an overflow:scroll that's forced into slow
scrolling because of background-attachment:fixed still scrolls.

* fast/scrolling/mac/slow-scrolling-overflow-expected.txt: Added.
* fast/scrolling/mac/slow-scrolling-overflow.html: Added.
* fast/scrolling/mac/wheel-event-listener-region-inside-overflow-scroll-clipped-out-expected.txt:
* fast/scrolling/mac/wheel-event-listener-region-inside-overflow-scroll-expected.txt:
* platform/mac-wk2/TestExpectations:
* tiled-drawing/scrolling/non-fast-region/fixed-div-in-scrollable-page.html:
* tiled-drawing/scrolling/non-fast-region/handlers-in-iframes-expected.txt:
* tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html:
* tiled-drawing/scrolling/non-fast-region/non-fast-scrollable-region-hide-show-iframe-expected.txt:
* tiled-drawing/scrolling/non-fast-region/non-fast-scrollable-region-hide-show-iframe.html:
* tiled-drawing/scrolling/non-fast-region/resources/wheel-handler-region-helper.js:
(nonFastScrollableRects):
(dumpNonFastScrollableRects):
(async dumpRegionAndNotifyDone):
(rectsAsString): Deleted.
(dumpRegion): Deleted.
* tiled-drawing/scrolling/non-fast-region/top-content-inset-expected.txt:
* tiled-drawing/scrolling/non-fast-region/top-content-inset-header-expected.txt:
* tiled-drawing/scrolling/non-fast-region/top-content-inset-header.html:
* tiled-drawing/scrolling/non-fast-region/top-content-inset.html:
* tiled-drawing/scrolling/non-fast-region/wheel-event-plugin.html:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child-expected.txt:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child.html:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-in-columns-expected.txt:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-in-columns.html:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-in-overflow-scroll-expected.txt:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-in-overflow-scroll.html:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed-expected.txt:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed.html:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-on-document-expected.txt:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-on-document.html:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed-expected.txt:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed.html:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic-expected.txt:
* tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago'make debug' fails on the repository root if ccache is installed on mac after r262147
krollin@apple.com [Wed, 14 Oct 2020 18:03:36 +0000 (18:03 +0000)]
'make debug' fails on the repository root if ccache is installed on mac after r262147
https://bugs.webkit.org/show_bug.cgi?id=212469
<rdar://problem/70278783>

Reviewed by David Kilzer.

ccache is frequently installed in /usr/local/bin. However, when
running under XCBuild, $PATH does not include /usr/local/bin. This
leaves in a situation where the check for the existence of ccache in
Makefile.shared succeeds, but the use of ccache in ccache-wrapper
fails. To address this, look for ccache in a few well-known places
rather than just relying on $PATH. If it still can't be found, fall
back to compiling normally without ccache.

* ccache/ccache-wrapper:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[Testing] Support configuring any preference from test headers for WebKitTestRunner
weinig@apple.com [Wed, 14 Oct 2020 17:56:12 +0000 (17:56 +0000)]
[Testing] Support configuring any preference from test headers for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=217645

Reviewed by Tim Horton.

Support using any preference defined in any of the WebPreference*.yaml configuration files
as a test header command rather than limiting it to a hard coded subset by generating the
list of supported commands and their types from the yaml files themselves.

This currently only works for WebKitTestRunner, but will be made to work with DumpRenderTree
in subsequent changes.

* WebKitTestRunner/CMakeLists.txt:
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/DerivedSources-input.xcfilelist:
* WebKitTestRunner/DerivedSources-output.xcfilelist:
* WebKitTestRunner/DerivedSources.make:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/Scripts/PreferencesTemplates: Added.
* WebKitTestRunner/Scripts/PreferencesTemplates/TestOptionsGeneratedKeys.h.erb: Added.
Add generation of TestOptionsGeneratedKeys.h from the WebPreference*.yaml using
the shared GeneratePreferences.rb script in WTF.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
Move preference setting to the bottom of the file to allow any preference
to be overriden. Also adds in support for double, uint32_t, and string preferences
though none of those are currently being used.

* WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::keyTypeMapping):
Use generated macro GENERATED_WEB_PREFERENCE_KEY_TYPE_MAPPINGS rather than hardcoding
all the preferences types.

* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::boolWebPreferenceFeatures const):
(WTR::TestOptions::doubleWebPreferenceFeatures const):
(WTR::TestOptions::uint32WebPreferenceFeatures const):
(WTR::TestOptions::stringWebPreferenceFeatures const):
Expose accessors for preferences values for use in setting the actual preference
values. Rather than setting all preferences, we now only set preferences that have
been explicitly requested, using the default value for any that have not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agoWeb Inspector: REGRESSION(r267148): new Big Sur styles are not used
drousso@apple.com [Wed, 14 Oct 2020 17:50:54 +0000 (17:50 +0000)]
Web Inspector: REGRESSION(r267148): new Big Sur styles are not used
https://bugs.webkit.org/show_bug.cgi?id=217682
<rdar://problem/70269030>

Reviewed by Brian Burg.

r267148 changed `navigator.userAgent` from `11_0` to `10_15_7`. This breaks Web Inspector
styling, which relied on this value to know what OS version it was running on in order to
know which styles to use.

Source/WebCore:

* inspector/InspectorFrontendHost.idl:
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::platformVersionName const): Added.
Derive a lowercased kekab-cased platform version name from `__MAC_OS_X_VERSION_MIN_REQUIRED`.

Source/WebInspectorUI:

* UserInterface/Base/Platform.js:
* UserInterface/Views/Variables.css:
(body.mac-platform): Added.
(body.mac-platform:not(.sierra, .high-sierra)): Deleted.
Use `InspectorFrontendHost.platformVersionName` instead of `navigator.userAgent`. Remove
unnecessary platform version names and other unused data.

* UserInterface/Base/Main.js:
(WI.contentLoaded):
(WI.undockedTitleAreaHeight): Added.
* UserInterface/Views/Popover.js:
(WI.Popover.prototype._update):
Provide a way to get the undocked title area height for use in JavaScript calculations.

* UserInterface/Controllers/HARBuilder.js:
(WI.HARBuilder.creator):
The `WI.Platform.version.build` hasn't changed in a long time, so just remove it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months ago[GLIB] Fix linking error for systems not providing <sys/memfd.h>
svillar@igalia.com [Wed, 14 Oct 2020 17:44:54 +0000 (17:44 +0000)]
[GLIB] Fix linking error for systems not providing <sys/memfd.h>
https://bugs.webkit.org/show_bug.cgi?id=217514

Reviewed by Carlos Garcia Campos.

* UIProcess/Launcher/glib/BubblewrapLauncher.cpp: Unconditionally check for <sys/mman.h> which should always exist instead
of <sys/memfd.h>. Also define the fallback with syscall() only for linux systems (as it requires <linux/memfd.h>).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 months agobuiltins-generator-tests and bindings-generation-tests are reporting "Failed to insta...
stephan.szabo@sony.com [Wed, 14 Oct 2020 17:30:15 +0000 (17:30 +0000)]
builtins-generator-tests and bindings-generation-tests are reporting "Failed to install configparser-4.0.2!" since r268267 on WinCairo Buildbot
https://bugs.webkit.org/show_bug.cgi?id=217586

Reviewed by Jonathan Bedard.

Pass proxy environment variables to setup.py so wincairo bots
which need the proxy set can reach pypi.org.

* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:
* Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268471 268f45cc-cd09-0410-ab3c-d52691b4dbfc