WebKit-https.git
8 years agoSVG CSS property types with <number> don't support exponents
krit@webkit.org [Wed, 18 Jul 2012 15:42:40 +0000 (15:42 +0000)]
SVG CSS property types with <number> don't support exponents
https://bugs.webkit.org/show_bug.cgi?id=52542

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Parse numbers in SVG presentation attributes with SVG parser to support scientific notations.
The SVG parser is already well tested and has some extra checks for edge like protection from
overflow.

The patch is based upon a patch of Bear Travis.

Test: svg/css/scientific-numbers.html

* css/CSSParser.cpp:
(WebCore::CSSParser::lex): Use SVG parser to parse numbers of SVG attributes.
* svg/SVGParserUtilities.cpp:
(WebCore::parseSVGNumber): Added accessor to call from CSSParser with double value.
(WebCore):
* svg/SVGParserUtilities.h:
(WebCore):

LayoutTests:

Test scientific number values on SVG presentation attributes.

* svg/css/scientific-numbers-expected.txt: Added.
* svg/css/scientific-numbers.html: Added.
* svg/css/script-tests/scientific-numbers.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: beautify the paused in debugger message, make it configurable from...
pfeldman@chromium.org [Wed, 18 Jul 2012 15:39:19 +0000 (15:39 +0000)]
Web Inspector: beautify the paused in debugger message, make it configurable from the front-end.
https://bugs.webkit.org/show_bug.cgi?id=91628

Reviewed by Vsevolod Vlasov.

Made message smaller, using consistent font;
Made message configurable from the front-end.

* English.lproj/localizedStrings.js:
* inspector/DOMNodeHighlighter.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::setPausedInDebuggerMessage):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawPausedInDebugger):
* inspector/DOMNodeHighlighter.h:
(InspectorOverlay):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setOverlayMessage):
(WebCore):
(WebCore::InspectorDebuggerAgent::clear):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::setOverlayMessage):
* inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._setDebuggerPausedDetails):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebCore::StylePropertySet::addParsedProperties - crash
commit-queue@webkit.org [Wed, 18 Jul 2012 15:15:22 +0000 (15:15 +0000)]
WebCore::StylePropertySet::addParsedProperties - crash
https://bugs.webkit.org/show_bug.cgi?id=91153

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-18
Reviewed by Andreas Kling.

Source/WebCore:

WebKitCSSKeyframeRule::style exposed an immutable StylePropertySet.
Modified to create a mutable copy on demand.

Test: fast/css/css-keyframe-style-mutate-crash.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::mutableProperties): Added, creates a mutable copy of properties as required.
(WebCore::WebKitCSSKeyframeRule::style):
* css/WebKitCSSKeyframeRule.h:
(WebCore::StyleKeyframe::properties): Made const, use mutableProperties to mutate.

LayoutTests:

* fast/css/css-keyframe-style-mutate-crash-expected.txt: Added.
* fast/css/css-keyframe-style-mutate-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.
kseo@webkit.org [Wed, 18 Jul 2012 15:13:34 +0000 (15:13 +0000)]
[Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.
https://bugs.webkit.org/show_bug.cgi?id=91595

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-18
Reviewed by Noam Rosenthal.

Internal review by Kwang Yul Seo.

Currently, TextureMapperLayer creates an ImageBuffer as big as
m_state.needsDisplayRect if m_state.needsDispaly is false. The size of
m_state.needsDisplayRect can be bigger than the size of the layerRect, so we may
consume more memory than the size of the layerRect. It even can cause crash if
m_state.needsDisplayRect is too big.

No new tests, covered by existing tests.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
kbalazs@webkit.org [Wed, 18 Jul 2012 15:12:26 +0000 (15:12 +0000)]
Unreviewed gardening.
More pixel rebaseline in compositing for qt-5.0-wk2.

Added baselines, mark failing tests.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-expected.png: Added.
* platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
* platform/qt-5.0-wk2/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
* platform/qt-5.0-wk2/compositing/flat-with-transformed-child-expected.png: Added.
* platform/qt-5.0-wk2/compositing/images/content-image-change-expected.png: Added.
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake][EFL] Build and run TestWebKitAPI unit tests
commit-queue@webkit.org [Wed, 18 Jul 2012 15:07:34 +0000 (15:07 +0000)]
[CMake][EFL] Build and run TestWebKitAPI unit tests
https://bugs.webkit.org/show_bug.cgi?id=90671

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Daniel Bates.

This patch enables almost for free a significant amount of test for the
WebKit C API, WTF and KURL. It makes easy for CMake based ports to
enable TestWebKitAPI since the missing bits to implement are
relatively simple.

* CMakeLists.txt:
* TestWebKitAPI/CMakeLists.txt: Added.
* TestWebKitAPI/PlatformEfl.cmake: Added.
* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/config.h:
* TestWebKitAPI/efl/InjectedBundleController.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::InjectedBundleController::platformInitialize):
* TestWebKitAPI/efl/PlatformUtilities.cpp: Added.
(TestWebKitAPI):
(Util):
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::URLForNonExistentResource):
* TestWebKitAPI/efl/PlatformWebView.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::initEcoreEvas):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
* TestWebKitAPI/efl/main.cpp: Added.
(checkForUseX11WindowArgument):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] We should update the status in NetworkJob if there is a new one from...
jason.liu@torchmobile.com.cn [Wed, 18 Jul 2012 15:04:17 +0000 (15:04 +0000)]
[BlackBerry] We should update the status in NetworkJob if there is a new one from libcurl.
https://bugs.webkit.org/show_bug.cgi?id=91475

Reviewed by Yong Li.

Libcurl sometimes sends multiple status messages, we need to keep the last
one in NetworkJob.
We originally had the m_statusReceived check, then we found out that libcurl
sometimes sent additional 401 codes and added the 401 exception to the check,
and now we're removing the whole check(so we don't need the exception either).

RIM PR# 163172
Reviewed internally by Joe Mason.

No new tests. This is caused by libcurl's multiple status messages.
So we don't need to write a test case for webkit.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyStatusReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] fast/text tests needs update after rebaseline and new testfonts
commit-queue@webkit.org [Wed, 18 Jul 2012 14:52:05 +0000 (14:52 +0000)]
[Qt] fast/text tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91570

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-18
Reviewed by Simon Hausmann.

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use
'monospace' font when directed, fast/text tests directory needs to be updated.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.png:
* platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.txt:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/qt-5.0/fast/text/backslash-to-yen-sign-expected.txt:
* platform/qt-5.0/fast/text/basic/003-expected.png:
* platform/qt-5.0/fast/text/basic/003-expected.txt:
* platform/qt-5.0/fast/text/fallback-traits-fixup-expected.txt:
* platform/qt-5.0/fast/text/international/hindi-whitespace-expected.txt:
* platform/qt-5.0/fast/text/international/text-spliced-font-expected.png:
* platform/qt-5.0/fast/text/international/text-spliced-font-expected.txt:
* platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
* platform/qt-5.0/fast/text/large-text-composed-char-expected.png:
* platform/qt-5.0/fast/text/large-text-composed-char-expected.txt:
* platform/qt-5.0/fast/text/letter-spacing-negative-opacity-expected.png:
* platform/qt-5.0/fast/text/letter-spacing-negative-opacity-expected.txt:
* platform/qt-5.0/fast/text/softHyphen-expected.txt:
* platform/qt-5.0/fast/text/text-letter-spacing-expected.txt:
* platform/qt/fast/text/atsui-kerning-and-ligatures-expected.txt:
* platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png:
* platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
* platform/qt/fast/text/backslash-to-yen-sign-dynamic-expected.png:
* platform/qt/fast/text/backslash-to-yen-sign-dynamic-expected.txt:
* platform/qt/fast/text/basic/001-expected.png:
* platform/qt/fast/text/basic/001-expected.txt:
* platform/qt/fast/text/basic/002-expected.txt:
* platform/qt/fast/text/basic/004-expected.txt:
* platform/qt/fast/text/basic/005-expected.txt:
* platform/qt/fast/text/basic/006-expected.txt:
* platform/qt/fast/text/basic/007-expected.txt:
* platform/qt/fast/text/basic/008-expected.txt:
* platform/qt/fast/text/basic/009-expected.png:
* platform/qt/fast/text/basic/009-expected.txt:
* platform/qt/fast/text/basic/011-expected.txt:
* platform/qt/fast/text/basic/012-expected.txt:
* platform/qt/fast/text/basic/generic-family-changes-expected.png:
* platform/qt/fast/text/basic/generic-family-changes-expected.txt:
* platform/qt/fast/text/basic/generic-family-reset-expected.png:
* platform/qt/fast/text/basic/generic-family-reset-expected.txt:
* platform/qt/fast/text/break-word-expected.png:
* platform/qt/fast/text/break-word-expected.txt:
* platform/qt/fast/text/capitalize-empty-generated-string-expected.txt:
* platform/qt/fast/text/capitalize-preserve-nbsp-expected.txt:
* platform/qt/fast/text/cg-vs-atsui-expected.png:
* platform/qt/fast/text/cg-vs-atsui-expected.txt:
* platform/qt/fast/text/complex-preferred-logical-widths-expected.png:
* platform/qt/fast/text/complex-preferred-logical-widths-expected.txt:
* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png:
* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt:
* platform/qt/fast/text/delete-hard-break-character-expected.txt:
* platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.png:
* platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
* platform/qt/fast/text/fake-italic-expected.txt:
* platform/qt/fast/text/firstline/001-expected.txt:
* platform/qt/fast/text/firstline/002-expected.txt:
* platform/qt/fast/text/firstline/003-expected.txt:
* platform/qt/fast/text/font-initial-expected.txt:
* platform/qt/fast/text/hyphenate-limit-before-after-expected.png:
* platform/qt/fast/text/hyphenate-limit-before-after-expected.txt:
* platform/qt/fast/text/hyphenate-limit-lines-expected.png:
* platform/qt/fast/text/hyphenate-limit-lines-expected.txt:
* platform/qt/fast/text/justified-selection-at-edge-expected.txt:
* platform/qt/fast/text/justified-selection-expected.txt:
* platform/qt/fast/text/line-breaks-after-white-space-expected.png:
* platform/qt/fast/text/line-breaks-after-white-space-expected.txt:
* platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.txt:
* platform/qt/fast/text/midword-break-hang-expected.txt:
* platform/qt/fast/text/reset-emptyRun-expected.txt:
* platform/qt/fast/text/selection-hard-linebreak-expected.png:
* platform/qt/fast/text/selection-hard-linebreak-expected.txt:
* platform/qt/fast/text/shadow-no-blur-expected.png:
* platform/qt/fast/text/shadow-no-blur-expected.txt:
* platform/qt/fast/text/shadow-translucent-fill-expected.txt:
* platform/qt/fast/text/should-use-atsui-expected.txt:
* platform/qt/fast/text/stroking-decorations-expected.txt:
* platform/qt/fast/text/stroking-expected.txt:
* platform/qt/fast/text/text-shadow-no-default-color-expected.txt:
* platform/qt/fast/text/textIteratorNilRenderer-expected.png:
* platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
* platform/qt/fast/text/unicode-variation-selector-expected.png:
* platform/qt/fast/text/unicode-variation-selector-expected.txt:
* platform/qt/fast/text/updateNewFont-expected.txt:
* platform/qt/fast/text/wbr-expected.txt:
* platform/qt/fast/text/wbr-in-pre-crash-expected.txt:
* platform/qt/fast/text/wbr-pre-expected.png:
* platform/qt/fast/text/wbr-pre-expected.txt:
* platform/qt/fast/text/wbr-styled-expected.png:
* platform/qt/fast/text/wbr-styled-expected.txt:
* platform/qt/fast/text/whitespace/002-expected.png:
* platform/qt/fast/text/whitespace/002-expected.txt:
* platform/qt/fast/text/whitespace/003-expected.png:
* platform/qt/fast/text/whitespace/003-expected.txt:
* platform/qt/fast/text/whitespace/006-expected.txt:
* platform/qt/fast/text/whitespace/007-expected.txt:
* platform/qt/fast/text/whitespace/008-expected.txt:
* platform/qt/fast/text/whitespace/009-expected.txt:
* platform/qt/fast/text/whitespace/012-expected.png:
* platform/qt/fast/text/whitespace/012-expected.txt:
* platform/qt/fast/text/whitespace/013-expected.txt:
* platform/qt/fast/text/whitespace/014-expected.txt:
* platform/qt/fast/text/whitespace/018-expected.txt:
* platform/qt/fast/text/whitespace/019-expected.png:
* platform/qt/fast/text/whitespace/019-expected.txt:
* platform/qt/fast/text/whitespace/020-expected.txt:
* platform/qt/fast/text/whitespace/021-expected.txt:
* platform/qt/fast/text/whitespace/022-expected.png:
* platform/qt/fast/text/whitespace/022-expected.txt:
* platform/qt/fast/text/whitespace/023-expected.png:
* platform/qt/fast/text/whitespace/023-expected.txt:
* platform/qt/fast/text/whitespace/025-expected.txt:
* platform/qt/fast/text/whitespace/026-expected.txt:
* platform/qt/fast/text/whitespace/027-expected.txt:
* platform/qt/fast/text/whitespace/029-expected.png:
* platform/qt/fast/text/whitespace/029-expected.txt:
* platform/qt/fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt:
* platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
* platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
* platform/qt/fast/text/whitespace/nowrap-clear-float-expected.txt:
* platform/qt/fast/text/whitespace/pre-break-word-expected.png:
* platform/qt/fast/text/whitespace/pre-break-word-expected.txt:
* platform/qt/fast/text/whitespace/pre-newline-box-test-expected.png:
* platform/qt/fast/text/whitespace/pre-newline-box-test-expected.txt:
* platform/qt/fast/text/whitespace/pre-wrap-last-char-expected.txt:
* platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png:
* platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.txt:
* platform/qt/fast/text/whitespace/span-in-word-space-causes-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTOUCH_ADJUSTMENT is too aggressive when snapping to large elements.
commit-queue@webkit.org [Wed, 18 Jul 2012 14:47:40 +0000 (14:47 +0000)]
TOUCH_ADJUSTMENT is too aggressive when snapping to large elements.
https://bugs.webkit.org/show_bug.cgi?id=91262

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-18
Reviewed by Antonio Gomes.

Source/WebCore:

Constrains the extent to which the touch point can be adjusted when
generating synthetic mouse events when TOUCH_ADJUSTEMNT is enabled.
Previously, the target position snapped to the center of the target
element, which can be far removed from the touch position when tapping
on or near a large element.  The refined strategy is to leave the
adjusted position unchanged if tapping within the element or to snap
to the center of the overlap region if the touch point lies outside the
bounds of the element, but the touch area and element bounds overlap.
For non-rectilineary bounds, a point lying outside the element boundary
is pulled towards the center of the element, by an amount limited by
the radius of the touch area.

Tests: touchadjustment/big-div.html
       touchadjustment/rotated-node.html

* page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::contentsToWindow):
(TouchAdjustment):
(WebCore::TouchAdjustment::snapTo):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):

LayoutTests:

Adding a test case to ensure that the adjusted touch position is
within the bounds of the target element and the touch area.
Previously, the target position snapped to the center of the target
element, which can be far removed from the touch area.

The second test is for non-rectilinear elements, and verifies that
the touch area must overlap the true bounds of the element for an
adjustment to occur.

* touchadjustment/big-div-expected.txt: Added.
* touchadjustment/big-div.html: Added.
* touchadjustment/rotated-node-expected.txt: Added.
* touchadjustment/rotated-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Add Ewk class for cookie manager
commit-queue@webkit.org [Wed, 18 Jul 2012 14:41:22 +0000 (14:41 +0000)]
[EFL][WK2] Add Ewk class for cookie manager
https://bugs.webkit.org/show_bug.cgi?id=91053

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-18
Reviewed by Gustavo Noronha Silva.

Add new Ewk_Cookie_Manager class to allow the client
to set/get the cookie acceptance policy, support
persistent cookie storage and clear cookies.

The Ewk_Cookie_Manager instance can be retrieved
from the Ewk_Context API.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(_Ewk_Context::~_Ewk_Context):
(ewk_context_cookie_manager_get):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_cookie_manager.cpp: Added.
(_Ewk_Cookie_Manager):
(_Ewk_Cookie_Manager::_Ewk_Cookie_Manager):
(ewk_cookie_manager_persistent_storage_set):
(ewk_cookie_manager_accept_policy_set):
(Get_Policy_Async_Data):
(getAcceptPolicyCallback):
(ewk_cookie_manager_async_accept_policy_get):
(Get_Hostnames_Async_Data):
(getHostnamesWithCookiesCallback):
(ewk_cookie_manager_async_hostnames_with_cookies_get):
(ewk_cookie_manager_hostname_cookies_clear):
(ewk_cookie_manager_cookies_clear):
(ewk_cookie_manager_free):
(ewk_cookie_manager_new):
* UIProcess/API/efl/ewk_cookie_manager.h: Added.
* UIProcess/API/efl/ewk_cookie_manager_private.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, unskipped tests.
vsevik@chromium.org [Wed, 18 Jul 2012 14:38:32 +0000 (14:38 +0000)]
Unreviewed chromium gardening, unskipped tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] editing/input and editing/unsupported-content tests needs update after rebaselin...
kbalazs@webkit.org [Wed, 18 Jul 2012 14:06:11 +0000 (14:06 +0000)]
[Qt] editing/input and editing/unsupported-content tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91400

Unreviewed rebaseline.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-18

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
* platform/qt/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
* platform/qt/editing/input/emacs-ctrl-o-expected.png:
* platform/qt/editing/input/emacs-ctrl-o-expected.txt:
* platform/qt/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
* platform/qt/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
* platform/qt/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
* platform/qt/editing/unsupported-content/list-delete-001-expected.png:
* platform/qt/editing/unsupported-content/list-delete-001-expected.txt:
* platform/qt/editing/unsupported-content/list-delete-003-expected.png:
* platform/qt/editing/unsupported-content/list-delete-003-expected.txt:
* platform/qt/editing/unsupported-content/list-type-after-expected.png:
* platform/qt/editing/unsupported-content/list-type-after-expected.txt:
* platform/qt/editing/unsupported-content/list-type-before-expected.png:
* platform/qt/editing/unsupported-content/list-type-before-expected.txt:
* platform/qt/editing/unsupported-content/table-delete-001-expected.png:
* platform/qt/editing/unsupported-content/table-delete-001-expected.txt:
* platform/qt/editing/unsupported-content/table-delete-002-expected.png:
* platform/qt/editing/unsupported-content/table-delete-002-expected.txt:
* platform/qt/editing/unsupported-content/table-delete-003-expected.png:
* platform/qt/editing/unsupported-content/table-delete-003-expected.txt:
* platform/qt/editing/unsupported-content/table-type-after-expected.png:
* platform/qt/editing/unsupported-content/table-type-after-expected.txt:
* platform/qt/editing/unsupported-content/table-type-before-expected.png:
* platform/qt/editing/unsupported-content/table-type-before-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: adding pause icon for JavaScript debugging
caseq@chromium.org [Wed, 18 Jul 2012 14:04:58 +0000 (14:04 +0000)]
Web Inspector: adding pause icon for JavaScript debugging
https://bugs.webkit.org/show_bug.cgi?id=90880

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-07-18
Reviewed by Pavel Feldman.

Refactored DOMNodeHighlighter into InspectorOverlay class and added a feature to show a "pause" screen when
the Javascript debugger is paused.

* inspector/DOMNodeHighlighter.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::drawOutline):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::setPausedInDebugger):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore):
(WebCore::InspectorOverlay::highlightNode):
(WebCore::InspectorOverlay::setHighlightData):
(WebCore::InspectorOverlay::clearHighlightData):
(WebCore::InspectorOverlay::highlightedNode):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawHighlight):
(WebCore::InspectorOverlay::drawPausedInDebugger):
* inspector/DOMNodeHighlighter.h:
(WebCore):
(InspectorOverlay):
(WebCore::InspectorOverlay::create):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::drawHighlight):
(WebCore::InspectorController::getHighlight):
(WebCore::InspectorController::highlightedNode):
* inspector/InspectorController.h:
(WebCore):
(InspectorController):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::~InspectorDOMAgent):
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
(WebCore::InspectorDOMAgent::hideHighlight):
* inspector/InspectorDOMAgent.h:
(WebCore):
(WebCore::InspectorDOMAgent::create):
(InspectorDOMAgent):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::didPaint):
* inspector/InspectorPageAgent.h:
(WebCore):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::create):
(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::disable):
(WebCore):
(WebCore::PageDebuggerAgent::didPause):
(WebCore::PageDebuggerAgent::didContinue):
* inspector/PageDebuggerAgent.h:
(WebCore):
(PageDebuggerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, updated test expectations.
vsevik@chromium.org [Wed, 18 Jul 2012 13:51:45 +0000 (13:51 +0000)]
Unreviewed chromium gardening, updated test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: intern strings when processing timeline records
caseq@chromium.org [Wed, 18 Jul 2012 13:46:22 +0000 (13:46 +0000)]
Web Inspector: intern strings when processing timeline records
https://bugs.webkit.org/show_bug.cgi?id=91531

Reviewed by Pavel Feldman.

- added StringPool that is capable of interning strings;
- used it in TimelineModel to process all incoming records;

* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype.reset):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
commit-queue@webkit.org [Wed, 18 Jul 2012 13:42:57 +0000 (13:42 +0000)]
Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
https://bugs.webkit.org/show_bug.cgi?id=91548

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-18
Reviewed by Kentaro Hara.

Use cl.exe as preprocessor for IDL files rather than cygwin gcc. Cuts
two minute execution time on Windows by a bit better than 50%.

No new tests.

* WebCore.gyp/WebCore.gyp:
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: remove search replace from behind experiment, polish the behavior
pfeldman@chromium.org [Wed, 18 Jul 2012 13:41:07 +0000 (13:41 +0000)]
Web Inspector: remove search replace from behind experiment, polish the behavior
https://bugs.webkit.org/show_bug.cgi?id=91519

Reviewed by Vsevolod Vlasov.

- This change makes replace loop with no boundary, removes the loop parameter
  from jumpToNext/Previous;
- Lays out replace as a second row
- Fixes replace all with no search matches
- Splits Search and Search and Replace
- Introduces explicit Next / Previous buttons in the search mode
- Introduces editRange on the TextEditor so that it was preserving the undo stack
  (we'll need to fix editor so that it does not require it).

* English.lproj/localizedStrings.js:
* inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.performSearch):
(WebInspector.ConsolePanel.prototype.jumpToNextSearchResult):
(WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.performSearch):
(WebInspector.ExtensionPanel.prototype.jumpToNextSearchResult):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkPanel.prototype.jumpToNextSearchResult):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.performSearch):
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ProfilesPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ResourcesPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
(WebInspector.ScriptsPanel.prototype.replaceAllWith):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype.resetSearch):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._updateReplaceVisibility):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
(WebInspector.SearchController.prototype._updateReplaceDetailsVisibility):
(WebInspector.SearchController.prototype._replace):
(WebInspector.SearchController.prototype._replaceAll):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
(WebInspector.SourceFrame.prototype.replaceSearchMatchWith):
(WebInspector.SourceFrame.prototype.replaceAllWith):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.beforeTextChanged):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.editRange):
* inspector/front-end/inspector.css:
(.toolbar-search-replace .search-replace):
(.toolbar-search):
(.toolbar-search-replace):
(.toolbar-search-close-button):
(.toolbar-search-close-button:hover):
(.toolbar-search-close-button:active):
(.toolbar-search input[type="checkbox"]):
(.toolbar-search-replace .toolbar-replace-control):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add WebKitWebView::submit-form signal to WebKit2 GTK+ API
carlosgc@webkit.org [Wed, 18 Jul 2012 13:39:26 +0000 (13:39 +0000)]
[GTK] Add WebKitWebView::submit-form signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=91605

Reviewed by Gustavo Noronha Silva.

The signal is emitted when a form is about to submitted, with a
form submission request that can be used to get the text fields
and to continue the form submission wheh done.

* GNUmakefile.list.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitFormClient.cpp: Added.
(willSubmitForm): Create a WebKitFormSubmissionRequest and call
webkitWebViewSubmitFormRequest() with the request.
(attachFormClientToView): Add impementation for willSubmitForm
callback.
* UIProcess/API/gtk/WebKitFormClient.h: Added.
* UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp: Added.
(webkit_form_submission_request_init):
(webkitFormSubmissionRequestFinalize):
(webkit_form_submission_request_class_init):
(webkitFormSubmissionRequestCreate): Create a new
WebKitFormSubmissionRequest for the given values dictionary and
submission listener.
(webkit_form_submission_request_get_text_fields): Create a
GHashTable with the text fields values and return it.
(webkit_form_submission_request_submit): Continue the form
submission.
* UIProcess/API/gtk/WebKitFormSubmissionRequest.h: Added.
* UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Attach web view to form client.
(webkit_web_view_class_init): Add WebKitWebView::submit-form
signal.
(webkitWebViewSubmitFormRequest): Emit WebKitWebView::submit-form
signal.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitFormSubmissionRequest.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSubmitForm):
(beforeAll):
* UIProcess/API/gtk/webkit2.h: Include
WebKitFormSubmissionRequest.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] No main resource in WebView when page has been loaded from history cache
carlosgc@webkit.org [Wed, 18 Jul 2012 13:27:12 +0000 (13:27 +0000)]
[GTK] No main resource in WebView when page has been loaded from history cache
https://bugs.webkit.org/show_bug.cgi?id=91478

Reviewed by Gustavo Noronha Silva.

We are assuming that a resource loaded for the main frame that is
provisionally loading is the main resource of the web view. However
that's not true for pages loaded from history cache, so when you
go back/forward webkit_web_view_get_main_resource() always returns
NULL. We can assume that the first resource loaded for the main
frame is the main resource of the web view when
pageIsProvisionallyLoading is false.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewResourceLoadStarted): Make sure we always have a
main resource for the web view.
* UIProcess/API/gtk/tests/TestResources.cpp:
(testWebViewResourcesHistoryCache): Test we always have a main
resource even after going back/forward.
(beforeAll): Add new test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] editing/style and editing/undo tests needs update after rebaseline and new testfonts
kbalazs@webkit.org [Wed, 18 Jul 2012 13:19:21 +0000 (13:19 +0000)]
[Qt] editing/style and editing/undo tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91385

Unreviewed rebaseline.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-18

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/editing/style/4916887-expected.png:
* platform/qt/editing/style/4916887-expected.txt:
* platform/qt/editing/style/5017613-1-expected.png:
* platform/qt/editing/style/5017613-1-expected.txt:
* platform/qt/editing/style/5017613-2-expected.png:
* platform/qt/editing/style/5017613-2-expected.txt:
* platform/qt/editing/style/5046875-1-expected.png:
* platform/qt/editing/style/5046875-1-expected.txt:
* platform/qt/editing/style/5046875-2-expected.png:
* platform/qt/editing/style/5046875-2-expected.txt:
* platform/qt/editing/style/5065910-expected.png:
* platform/qt/editing/style/5065910-expected.txt:
* platform/qt/editing/style/5084241-expected.png:
* platform/qt/editing/style/5084241-expected.txt:
* platform/qt/editing/style/5228141-expected.png:
* platform/qt/editing/style/5228141-expected.txt:
* platform/qt/editing/style/5279521-expected.png:
* platform/qt/editing/style/5279521-expected.txt:
* platform/qt/editing/style/apple-style-editable-mix-expected.png:
* platform/qt/editing/style/apple-style-editable-mix-expected.txt:
* platform/qt/editing/style/block-style-001-expected.png:
* platform/qt/editing/style/block-style-001-expected.txt:
* platform/qt/editing/style/block-style-002-expected.png:
* platform/qt/editing/style/block-style-002-expected.txt:
* platform/qt/editing/style/block-style-003-expected.png:
* platform/qt/editing/style/block-style-003-expected.txt:
* platform/qt/editing/style/block-styles-007-expected.png:
* platform/qt/editing/style/block-styles-007-expected.txt:
* platform/qt/editing/style/create-block-for-style-001-expected.png:
* platform/qt/editing/style/create-block-for-style-001-expected.txt:
* platform/qt/editing/style/create-block-for-style-002-expected.png:
* platform/qt/editing/style/create-block-for-style-002-expected.txt:
* platform/qt/editing/style/create-block-for-style-003-expected.png:
* platform/qt/editing/style/create-block-for-style-003-expected.txt:
* platform/qt/editing/style/create-block-for-style-004-expected.png:
* platform/qt/editing/style/create-block-for-style-004-expected.txt:
* platform/qt/editing/style/create-block-for-style-005-expected.png:
* platform/qt/editing/style/create-block-for-style-005-expected.txt:
* platform/qt/editing/style/create-block-for-style-006-expected.png:
* platform/qt/editing/style/create-block-for-style-006-expected.txt:
* platform/qt/editing/style/create-block-for-style-007-expected.png:
* platform/qt/editing/style/create-block-for-style-007-expected.txt:
* platform/qt/editing/style/create-block-for-style-008-expected.png:
* platform/qt/editing/style/create-block-for-style-008-expected.txt:
* platform/qt/editing/style/create-block-for-style-009-expected.png:
* platform/qt/editing/style/create-block-for-style-009-expected.txt:
* platform/qt/editing/style/create-block-for-style-010-expected.png:
* platform/qt/editing/style/create-block-for-style-010-expected.txt:
* platform/qt/editing/style/create-block-for-style-011-expected.png:
* platform/qt/editing/style/create-block-for-style-011-expected.txt:
* platform/qt/editing/style/create-block-for-style-012-expected.png:
* platform/qt/editing/style/create-block-for-style-012-expected.txt:
* platform/qt/editing/style/create-block-for-style-013-expected.png:
* platform/qt/editing/style/create-block-for-style-013-expected.txt:
* platform/qt/editing/style/designmode-expected.png:
* platform/qt/editing/style/designmode-expected.txt:
* platform/qt/editing/style/font-family-with-space-expected.png:
* platform/qt/editing/style/font-family-with-space-expected.txt:
* platform/qt/editing/style/highlight-expected.png:
* platform/qt/editing/style/highlight-expected.txt:
* platform/qt/editing/style/relative-font-size-change-001-expected.png:
* platform/qt/editing/style/relative-font-size-change-001-expected.txt:
* platform/qt/editing/style/relative-font-size-change-002-expected.png:
* platform/qt/editing/style/relative-font-size-change-002-expected.txt:
* platform/qt/editing/style/relative-font-size-change-003-expected.png:
* platform/qt/editing/style/relative-font-size-change-003-expected.txt:
* platform/qt/editing/style/relative-font-size-change-004-expected.png:
* platform/qt/editing/style/relative-font-size-change-004-expected.txt:
* platform/qt/editing/style/smoosh-styles-001-expected.png:
* platform/qt/editing/style/smoosh-styles-001-expected.txt:
* platform/qt/editing/style/smoosh-styles-003-expected.png:
* platform/qt/editing/style/smoosh-styles-003-expected.txt:
* platform/qt/editing/style/style-3681552-fix-001-expected.png:
* platform/qt/editing/style/style-3681552-fix-001-expected.txt:
* platform/qt/editing/style/style-3681552-fix-002-expected.png:
* platform/qt/editing/style/style-3681552-fix-002-expected.txt:
* platform/qt/editing/style/style-3998892-fix-expected.png:
* platform/qt/editing/style/style-3998892-fix-expected.txt:
* platform/qt/editing/style/style-boundary-001-expected.png:
* platform/qt/editing/style/style-boundary-001-expected.txt:
* platform/qt/editing/style/style-boundary-002-expected.png:
* platform/qt/editing/style/style-boundary-002-expected.txt:
* platform/qt/editing/style/style-boundary-003-expected.png:
* platform/qt/editing/style/style-boundary-003-expected.txt:
* platform/qt/editing/style/style-boundary-004-expected.png:
* platform/qt/editing/style/style-boundary-004-expected.txt:
* platform/qt/editing/style/style-boundary-005-expected.png:
* platform/qt/editing/style/style-boundary-005-expected.txt:
* platform/qt/editing/style/table-selection-expected.png:
* platform/qt/editing/style/table-selection-expected.txt:
* platform/qt/editing/style/typing-style-001-expected.png:
* platform/qt/editing/style/typing-style-001-expected.txt:
* platform/qt/editing/style/typing-style-002-expected.png:
* platform/qt/editing/style/typing-style-002-expected.txt:
* platform/qt/editing/style/unbold-in-bold-expected.png:
* platform/qt/editing/style/unbold-in-bold-expected.txt:
* platform/qt/editing/undo/4063751-expected.png:
* platform/qt/editing/undo/4063751-expected.txt:
* platform/qt/editing/undo/redo-typing-001-expected.png:
* platform/qt/editing/undo/redo-typing-001-expected.txt:
* platform/qt/editing/undo/undo-combined-delete-boundary-expected.png:
* platform/qt/editing/undo/undo-combined-delete-boundary-expected.txt:
* platform/qt/editing/undo/undo-combined-delete-expected.png:
* platform/qt/editing/undo/undo-combined-delete-expected.txt:
* platform/qt/editing/undo/undo-delete-boundary-expected.png:
* platform/qt/editing/undo/undo-delete-boundary-expected.txt:
* platform/qt/editing/undo/undo-delete-expected.png:
* platform/qt/editing/undo/undo-delete-expected.txt:
* platform/qt/editing/undo/undo-forward-delete-boundary-expected.png:
* platform/qt/editing/undo/undo-forward-delete-boundary-expected.txt:
* platform/qt/editing/undo/undo-forward-delete-expected.png:
* platform/qt/editing/undo/undo-forward-delete-expected.txt:
* platform/qt/editing/undo/undo-typing-001-expected.png:
* platform/qt/editing/undo/undo-typing-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][EFL] Divide ENABLE(WEBGL) into ENABLE(WEBGL) and USE(3D_GRAPHICS) in CMakeLists.txt
commit-queue@webkit.org [Wed, 18 Jul 2012 13:19:13 +0000 (13:19 +0000)]
[WK2][EFL] Divide ENABLE(WEBGL) into ENABLE(WEBGL) and USE(3D_GRAPHICS) in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=91584

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-18
Reviewed by Noam Rosenthal.

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
Modified CMakeLists.txt so that the basic 3D-graphics sources can be compiled even when WebGL is disabled.

* CMakeLists.txt:
* PlatformEfl.cmake:
* platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D):
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::platformGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline of compositing tests on Qt-WebKit2.
kbalazs@webkit.org [Wed, 18 Jul 2012 13:11:01 +0000 (13:11 +0000)]
Unreviewed rebaseline of compositing tests on Qt-WebKit2.

Mark pixel tests with wrong output as failing (IMAGE) Rebaseline some pixel
results where only scrollbar theme or antialiasing was the difference
between actual and expected.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.png: Added.
* platform/qt-5.0-wk2/compositing/culling/clear-fixed-iframe-expected.png: Added.
* platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png: Added.
* platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.png: Added.
* platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.png: Added.
* platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.png: Added.
* platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Added.
* platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake][EFL] Building jsc causes reconfiguration
commit-queue@webkit.org [Wed, 18 Jul 2012 12:59:23 +0000 (12:59 +0000)]
[CMake][EFL] Building jsc causes reconfiguration
https://bugs.webkit.org/show_bug.cgi?id=91387

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Daniel Bates.

We should remove CMakeCache only when running build-webkit script,
otherwise it will cause a reconfiguration every time someone calls
generateBuildSystemFromCMakeProject(). We were re-building "jsc" and
not running WebKit2 unit tests on the bots because the project was
reconfigured with default values by the scripts that run these tests.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(removeCMakeCache):
(generateBuildSystemFromCMakeProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
commit-queue@webkit.org [Wed, 18 Jul 2012 12:59:21 +0000 (12:59 +0000)]
[EFL] Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=91585

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-18
Reviewed by Andreas Kling.

Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
since it implements the platform specific methods of WebInspectorProxy.

* PlatformEfl.cmake:
* UIProcess/efl/WebInspectorProxyEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp.
(WebKit):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformBringToFront):
(WebKit::WebInspectorProxy::platformIsFront):
(WebKit::WebInspectorProxy::platformInspectedURLChanged):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, updated test expectations.
vsevik@chromium.org [Wed, 18 Jul 2012 12:53:02 +0000 (12:53 +0000)]
Unreviewed chromium gardening, updated test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Modify the using of the QImage::Format enum to the appropriate functions from...
zoltan@webkit.org [Wed, 18 Jul 2012 12:50:36 +0000 (12:50 +0000)]
[Qt] Modify the using of the QImage::Format enum to the appropriate functions from NativeImageQt
https://bugs.webkit.org/show_bug.cgi?id=91600

Reviewed by Andreas Kling.

Use NativeImageQt::defaultFormatForAlphaEnabledImages() and NativeImageQt::defaultFormatForOpaqueImages()
instead of the direct imagetypes at the appropriate places.

Source/WebCore:

Covered by existing tests.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::paintToCanvas):
* platform/graphics/qt/PathQt.cpp:
(WebCore::scratchContext):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawRepaintCounter):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::updateContents):

Source/WebKit2:

* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createQImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
commit-queue@webkit.org [Wed, 18 Jul 2012 12:50:15 +0000 (12:50 +0000)]
[EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=87935

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-18
Reviewed by Andreas Kling.

Source/WebKit/efl:

Add implementation of DumpRenderTreeSupportEfl::evaluateInWebInspector().
Some scripts for test should be evaluated in frontend.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Web Inspector will be shown when path or url contains "inspector/".
Dumprendertree should wait util web inspector resources are loaded totally
and handle the signals for creating or removing a view of web inspector.
("inspector,view,create" and "inspector,view,close")

* DumpRenderTree/efl/DumpRenderTree.cpp:
(shouldOpenWebInspector):
(createLayoutTestController):
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::createWebInspectorView):
(DumpRenderTreeChrome::removeWebInspectorView):
(DumpRenderTreeChrome::waitInspectorLoadFinished):
(DumpRenderTreeChrome::onInspectorViewCreate):
(DumpRenderTreeChrome::onInspectorViewClose):
(DumpRenderTreeChrome::onInspectorFrameLoadFinished):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onConsoleMessage):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::showWebInspector):
(LayoutTestController::closeWebInspector):
(LayoutTestController::evaluateInWebInspector):

LayoutTests:

Remove the following tests from Skipped list.
LayoutTests/inspector
LayoutTests/http/test/inspector
LayoutTests/http/test/inspector-enabled
LayoutTests/http/tests/inspector/network/ping.html

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, unskipped tests.
vsevik@chromium.org [Wed, 18 Jul 2012 12:43:45 +0000 (12:43 +0000)]
Unreviewed chromium gardening, unskipped tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: create timeline detail records lazily
caseq@chromium.org [Wed, 18 Jul 2012 12:38:44 +0000 (12:38 +0000)]
Web Inspector: create timeline detail records lazily
https://bugs.webkit.org/show_bug.cgi?id=91513

Reviewed by Pavel Feldman.

- only create timeline record details when these are used;

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineRecordListRow.prototype.update):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
(WebInspector.TimelinePresentationModel.Record.prototype._refreshDetails):
(WebInspector.TimelinePresentationModel.Record.prototype.details):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, unskipped tests.
vsevik@chromium.org [Wed, 18 Jul 2012 12:16:05 +0000 (12:16 +0000)]
Unreviewed chromium gardening, unskipped tests.
https://bugs.webkit.org/show_bug.cgi?id=84764
https://bugs.webkit.org/show_bug.cgi?id=84767
https://bugs.webkit.org/show_bug.cgi?id=84768
https://bugs.webkit.org/show_bug.cgi?id=84769
https://bugs.webkit.org/show_bug.cgi?id=84775
https://bugs.webkit.org/show_bug.cgi?id=84776

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Caching of ShareableSurfaces breaks tiling.
zeno.albisser@nokia.com [Wed, 18 Jul 2012 11:53:47 +0000 (11:53 +0000)]
[Qt][WK2] Caching of ShareableSurfaces breaks tiling.
https://bugs.webkit.org/show_bug.cgi?id=91609

A ShareableSurface should only be cached,
when it is GraphicsSurface based.

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
* UIProcess/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[ANGLE] On QT, use Bison and Flex during ANGLE build
hausmann@webkit.org [Wed, 18 Jul 2012 11:41:33 +0000 (11:41 +0000)]
[ANGLE] On QT, use Bison and Flex during ANGLE build
https://bugs.webkit.org/show_bug.cgi?id=91108

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add derived source generators for the two angle bison parsers and flex based lexers.

* DerivedSources.pri:
* Target.pri:

Tools:

* qmake/mkspecs/features/default_post.prf: Add support for variable_out to our generators, to allow
generating not only for SOURCES but also ANGLE_SOURCES (in this bug)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Too early assertion failure if default theme is not available
commit-queue@webkit.org [Wed, 18 Jul 2012 11:30:37 +0000 (11:30 +0000)]
[EFL][WK2] Too early assertion failure if default theme is not available
https://bugs.webkit.org/show_bug.cgi?id=91608

Patch by Dominik R√∂ttsches <dominik.rottsches@intel.com> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

After bug 90107 we're setting a default theme path, which leads to a
themeChanged() call initializing edje in createEdje() - if that theme
path is not available we run into a premature assertion failure.
We need to give the embedder a chance to override the default theme path
before failing - so only the usages of m_edje should be guarded with assertions.

No new tests, no change in rendering behavior.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::themePartCacheEntryReset): Adding an assertion to ensure m_edje is present - so that all usages of m_edje are now guarded.
(WebCore::RenderThemeEfl::createEdje): Not hitting assertion if theme path doesn't contain the theme object file, allowing the embedder to override with a new path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Fix a crash due to an invalid assert
carlosgc@webkit.org [Wed, 18 Jul 2012 11:30:31 +0000 (11:30 +0000)]
[GTK] Fix a crash due to an invalid assert
https://bugs.webkit.org/show_bug.cgi?id=91614

Reviewed by Xan Lopez.

In webkitWebViewBaseContainerAdd() there's
ASSERT(priv->inspectorView); that should be the opposite, since we
shoulnd't have an inspector view when the inspector view is added.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseContainerAdd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] plugin tests should not be disabled for WebKit1
hausmann@webkit.org [Wed, 18 Jul 2012 11:25:54 +0000 (11:25 +0000)]
[Qt] plugin tests should not be disabled for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=91604

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2012-07-18
Reviewed by Simon Hausmann.

Instead of not building TestNetscapePlugIn, we could programatically
disable actually loading it from WTR until https://bugs.webkit.org/show_bug.cgi?id=86620
has been solved, so we can still test plugins on WebKit1.

* Tools.pro:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::initializeTestPluginDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Make gtest a shared library
commit-queue@webkit.org [Wed, 18 Jul 2012 11:15:41 +0000 (11:15 +0000)]
[CMake] Make gtest a shared library
https://bugs.webkit.org/show_bug.cgi?id=90973

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Daniel Bates.

.:

It's nicer to make it a shared library because it might improve
linking time and we don't need to force gtest users to link with gtest
dependencies like pthreads (which causes linking errors when it is not
available).

* Source/cmake/gtest/CMakeLists.txt:

Source/WebKit:

No need to link with gtest dependencies now since it is a shared library.

* PlatformEfl.cmake:

Source/WebKit2:

No need to link with gtest dependencies now since it is a shared library.

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: IDBLevelDBBackingStore compilation fails because of unused variable.
vsevik@chromium.org [Wed, 18 Jul 2012 10:54:21 +0000 (10:54 +0000)]
IndexedDB: IDBLevelDBBackingStore compilation fails because of unused variable.
https://bugs.webkit.org/show_bug.cgi?id=91612

Reviewed by Pavel Feldman.

Replaced ASSERT with ASSERT_UNUSED.

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getObjectStores):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][EFL] Add a common code using Color instead of QColor
commit-queue@webkit.org [Wed, 18 Jul 2012 10:31:12 +0000 (10:31 +0000)]
[WK2][EFL] Add a common code using Color instead of QColor
https://bugs.webkit.org/show_bug.cgi?id=91580

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-18
Reviewed by Simon Hausmann.

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
drawBorder's argument is QColor. So add a common code using Color to be used by Efl.

* UIProcess/texmap/LayerBackingStore.cpp:
(WebKit::LayerBackingStore::paintToTextureMapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK
mario@webkit.org [Wed, 18 Jul 2012 10:20:19 +0000 (10:20 +0000)]
[WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK
https://bugs.webkit.org/show_bug.cgi?id=89223

Reviewed by Chris Fleizach.

Tools:

Implemented AccessibilityUIElement in WKTR for GTK, based in the
implementation present in DumpRenderTree.

Added new files in gtk/ and updated the cross-platform ones.

* WebKitTestRunner/GNUmakefile.am:
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
* WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp: Added.
(WTR):
(WTR::attributeSetToString):
(WTR::checkElementState):
(WTR::indexRangeInTable):
(WTR::alterCurrentValue):
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::rowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::isActionSupported):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::hierarchicalLevel):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::ariaIsGrabbed):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild):
(WTR::AccessibilityUIElement::accessibilityValue):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::isVisible):
(WTR::AccessibilityUIElement::isOffScreen):
(WTR::AccessibilityUIElement::isCollapsed):
(WTR::AccessibilityUIElement::isIgnored):
(WTR::AccessibilityUIElement::hasPopup):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):

Add documentEncoding and documentURI to AccessibilityUIElement.idl.

* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:

LayoutTests:

Removed lines skipping all the accessibility tests and replace
them with the specific ones that are still not passing, which
are just a few now, and will hopefully get fixed later on.

* platform/gtk-wk2/Skipped: Reduce the list of skipped tests.

Updated two layout tests to consider nulls, something that didn't
happen with DumpRenderTree, but that we need to check now.

* accessibility/table-cell-spans.html: Update test.
* accessibility/table-cells.html: Update test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, unskipped test.
vsevik@chromium.org [Wed, 18 Jul 2012 09:55:35 +0000 (09:55 +0000)]
Unreviewed chromium gardening, unskipped test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, unskipped test.
vsevik@chromium.org [Wed, 18 Jul 2012 09:49:32 +0000 (09:49 +0000)]
Unreviewed chromium gardening, unskipped test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r117738) [Forms] Default step base should be 0 (=1970-01) for input type...
yosin@chromium.org [Wed, 18 Jul 2012 09:47:28 +0000 (09:47 +0000)]
REGRESSION(r117738) [Forms] Default step base should be 0 (=1970-01) for input type month
https://bugs.webkit.org/show_bug.cgi?id=91603

Reviewed by Kent Tamura.

This patch restores default step base value to 0 (=1970-01) as before
r117738.

No new tests. Existing test(fast/forms/month/month-stepup-stepdown-from-renderer.html)
covers this case, although it is disabled.

* html/MonthInputType.cpp:
(WebCore::MonthInputType::createStepRange): Changed default value of
step base to defaultMonthStepBase instead of DateComponents::minimumMonth().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Build fix in WebKitTestRunner.
alexis.menard@openbossa.org [Wed, 18 Jul 2012 08:57:47 +0000 (08:57 +0000)]
[EFL] Build fix in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=91567

Reviewed by Kentaro Hara.

sleep() is defined in unistd.h, we need to include it.

* WebKitTestRunner/efl/TestControllerEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, updated test expectations.
vsevik@chromium.org [Wed, 18 Jul 2012 08:51:53 +0000 (08:51 +0000)]
Unreviewed chromium gardening, updated test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Cursor is not drawn when opengl_x11 backend is choosen.
ryuan.choi@samsung.com [Wed, 18 Jul 2012 08:37:32 +0000 (08:37 +0000)]
[EFL] Cursor is not drawn when opengl_x11 backend is choosen.
https://bugs.webkit.org/show_bug.cgi?id=89142

Reviewed by Simon Hausmann.

If theme based cursor is not given, WebKit/Efl only uses Ecore_X based
cursor as a fallback after checked whether current engine is using EcoreX.
This patch adds opengl_x11 which is one of Ecore_X based engine in check
lists to draw fallback cursor.

* platform/efl/EflScreenUtilities.cpp:
(WebCore::isUsingEcoreX):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, unskipped test.
vsevik@chromium.org [Wed, 18 Jul 2012 08:28:17 +0000 (08:28 +0000)]
Unreviewed chromium gardening, unskipped test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[NRWT] Unreviewed gardening after r122913
kkristof@inf.u-szeged.hu [Wed, 18 Jul 2012 08:20:13 +0000 (08:20 +0000)]
[NRWT] Unreviewed gardening after r122913
https://bugs.webkit.org/show_bug.cgi?id=91601

* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TrivialMockPort.process_kill_time):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, unskipped test.
vsevik@chromium.org [Wed, 18 Jul 2012 08:19:41 +0000 (08:19 +0000)]
Unreviewed chromium gardening, unskipped test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r122345): HTMLCollection::length() sometimes returns a wrong value
rniwa@webkit.org [Wed, 18 Jul 2012 08:16:31 +0000 (08:16 +0000)]
REGRESSION(r122345): HTMLCollection::length() sometimes returns a wrong value
https://bugs.webkit.org/show_bug.cgi?id=91587

Reviewed by Benjamin Poulain.

Source/WebCore:

The bug was caused by my douchey code that set the length cache to be the *offset*
of the last item in a HTMLCollection. Clearly, the length of a collection that contains
the last item at offset n is n + 1. Fixed that.

Also removed the call to setLengthCache in HTMLCollection::length since it must have set
by previous calls to itemBeforeOrAfterCachedItem already. This will allow us to catch
regressions like this in ports that use JSC bindings as well.

Test: fast/dom/htmlcollection-length-after-item.html

* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::itemBeforeOrAfterCachedItem):

LayoutTests:

Add a regression test. It only fails on Chromium port before the patch is applied because JSC binding code
has a bug (?) that it always checks index > length() to throw an exception before accessing an item in HTMLCollection.

* fast/dom/htmlcollection-length-after-item-expected.txt: Added.
* fast/dom/htmlcollection-length-after-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, rebaselined tests.
vsevik@chromium.org [Wed, 18 Jul 2012 08:14:32 +0000 (08:14 +0000)]
Unreviewed chromium gardening, rebaselined tests.

* platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Removed.
* platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Removed.
* platform/chromium-win-xp/fast/inline-block/inline-block-vertical-align-expected.png: Removed.
* platform/chromium-win-xp/fast/inline/002-expected.png: Removed.
* platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
* platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.png:
* platform/chromium-win/fast/inline/002-expected.png:
* platform/chromium-win/fast/table/table-display-types-strict-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDecimal::toString should not round integer value.
yosin@chromium.org [Wed, 18 Jul 2012 08:09:45 +0000 (08:09 +0000)]
Decimal::toString should not round integer value.
https://bugs.webkit.org/show_bug.cgi?id=91481

Reviewed by Kent Tamura.

Source/WebCore:

This patch makes Decimal::toString not to round an integer value
before converting string.

Tests: WebKit/chromium/tests/DecimalTest.cpp: DecimalTest.toString

* platform/Decimal.cpp:
(WebCore::Decimal::toString): When the value is an integer, we don't
round coefficient to be DBL_DIG(15) digits because double can
represent an integer without rounding error.

Source/WebKit/chromium:

This patch adds a new test cases for Decimal::toString() for failed
value and maximum coefficient value with various exponent.

* tests/DecimalTest.cpp:
(TEST_F): DecimalTest.toString: Add test cases for big coefficient values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd copy constructor to WebSpeechGrammar.h
hans@chromium.org [Wed, 18 Jul 2012 08:08:50 +0000 (08:08 +0000)]
Add copy constructor to WebSpeechGrammar.h
https://bugs.webkit.org/show_bug.cgi?id=91484

Reviewed by Adam Barth.

Provide user-defined copy constructor (and assign function) for WebSpeechGrammar.
Without this, we were hitting the implicit copy constructor, which in
turn used the implicit copy constructor of WebPrivatePtr. This was bad,
because the implicit copy constructor wouldn't increace the reference
count on the wrapped object, causing us to crash.

Also add one for WebSpeechRecognitionResult; haven't seen any problems
here, but I noticed it was missing.

* public/WebSpeechGrammar.h:
(WebKit::WebSpeechGrammar::WebSpeechGrammar):
(WebSpeechGrammar):
* public/WebSpeechRecognitionResult.h:
(WebKit::WebSpeechRecognitionResult::WebSpeechRecognitionResult):
(WebSpeechRecognitionResult):
* src/WebSpeechGrammar.cpp:
(WebKit::WebSpeechGrammar::assign):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] REGRESSION(r122376): It made 68 tests flakey (TEXT PASS)
ossy@webkit.org [Wed, 18 Jul 2012 08:02:19 +0000 (08:02 +0000)]
[Qt][WK2] REGRESSION(r122376): It made 68 tests flakey (TEXT PASS)
https://bugs.webkit.org/show_bug.cgi?id=91063

* platform/qt-5.0-wk2/Skipped: Skip one more test.
* platform/qt/Skipped: Move a skipped test to the proper Skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Buildfix after r122870.
kkristof@inf.u-szeged.hu [Wed, 18 Jul 2012 07:51:41 +0000 (07:51 +0000)]
[Qt] Buildfix after r122870.
https://bugs.webkit.org/show_bug.cgi?id=89039

Reviewed by Csaba Osztrogon√°c

* src/compiler/preprocessor/new/MacroExpander.cpp:
(pp::MacroExpander::ungetToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Skip the new failing tests.
kkristof@inf.u-szeged.hu [Wed, 18 Jul 2012 07:10:26 +0000 (07:10 +0000)]
[Qt] Unreviewed gardening. Skip the new failing tests.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix null pointer dereference introduced by Changeset 121874.
macpherson@chromium.org [Wed, 18 Jul 2012 07:09:21 +0000 (07:09 +0000)]
Fix null pointer dereference introduced by Changeset 121874.
https://bugs.webkit.org/show_bug.cgi?id=91578

Reviewed by Pavel Feldman.

In http://trac.webkit.org/changeset/121874/trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp I introduced code that
dereferences the return value of ownerDocument() without doing a null check. This was a bad idea.

No new tests. I don't have a repro case, but it is clear from reading the code for ownerDocument() that it can return null.

* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::ensureSourceData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDecimal constructor with 99999999999999999 loses last digit
yosin@chromium.org [Wed, 18 Jul 2012 06:50:25 +0000 (06:50 +0000)]
Decimal constructor with 99999999999999999 loses last digit
https://bugs.webkit.org/show_bug.cgi?id=91579

Reviewed by Kent Tamura.

Source/WebCore:

This patch changes maximum coefficient value handling in Decimal::EncodedData
constructor not to lose the last digit. It was used ">=" operator for
comparison instead of ">" operator.

Tests: WebKit/chromium/tests/DecimalTest.cpp

* platform/Decimal.cpp:
(WebCore::Decimal::EncodedData::EncodedData): Replace ">=" to ">" for
not getting rid of the last digit for maximum coefficient value.

Source/WebKit/chromium:

This patch adds test cases for Decimal::EncodedData constructors for
testing edge cases in addition to common cases which they aren't
covered by other test cases.

* tests/DecimalTest.cpp:
(EXPECT_DECIMAL_ENCODED_DATA_EQ): Introduce a new macro for ease of
writing test cases for verifying components of Decimal::EncodedData.
(TEST_F): Added a new test entry DecimalTest.Constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Web Inspector: followup fix for r122920.
loislo@chromium.org [Wed, 18 Jul 2012 06:31:53 +0000 (06:31 +0000)]
Unreviewed Web Inspector: followup fix for r122920.

Add collected Loaders size to InspectorMemoryBlock

* inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: show loaders memory consumption on the memory chart.
loislo@chromium.org [Wed, 18 Jul 2012 05:58:49 +0000 (05:58 +0000)]
Web Inspector: show loaders memory consumption on the memory chart.
https://bugs.webkit.org/show_bug.cgi?id=90686

Reviewed by Pavel Feldman.

Size of FrameLoader, DocumentLoader, ResourceLoader and their resources should be shown on the memory pie chart.

It is covered by existing WebInspector performance tests infrastructure.

* WebCore.exp.in:
* dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addRawBuffer):
(WebCore::MemoryInstrumentation::addInstrumentedMemberImpl):
(WebCore):
(WebCore::MemoryClassInfo::addInstrumentedHashSet):
(WebCore::MemoryClassInfo::addRawBuffer):
(WebCore::MemoryInstrumentation::addInstrumentedHashSet):
(WebCore::MemoryInstrumentation::addVector):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
(WebCore::domTreeInfo):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore):
* loader/DocumentLoader.h:
(WebCore):
(DocumentLoader):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
(WebCore):
* loader/FrameLoader.h:
(WebCore):
(FrameLoader):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
(WebCore):
* loader/ResourceLoader.h:
(WebCore):
(ResourceLoader):
* page/Frame.cpp:
(WebCore::Frame::reportMemoryUsage):
(WebCore):
* page/Frame.h:
(WebCore):
(Frame):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
(WebCore):
* platform/SharedBuffer.h:
(WebCore):
(SharedBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG 32-bit PutById transition stub passes the payload/tag arguments to a DFG operatio...
fpizlo@apple.com [Wed, 18 Jul 2012 04:42:55 +0000 (04:42 +0000)]
DFG 32-bit PutById transition stub passes the payload/tag arguments to a DFG operation in the wrong order
https://bugs.webkit.org/show_bug.cgi?id=91576

Reviewed by Gavin Barraclough.

* dfg/DFGRepatch.cpp:
(JSC::DFG::emitPutTransitionStub):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix an assertion failure in CalendarPickerElement::hostInput().
tkent@chromium.org [Wed, 18 Jul 2012 04:18:19 +0000 (04:18 +0000)]
Fix an assertion failure in CalendarPickerElement::hostInput().
https://bugs.webkit.org/show_bug.cgi?id=91568

Reviewed by Hajime Morita.

Source/WebCore:

Test: fast/forms/date/calendar-picker-type-change-onclick.html

* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::defaultEventHandler):
It's possible that this function is called when the element is detached
from the document tree.

LayoutTests:

* fast/forms/date/calendar-picker-type-change-onclick-expected.txt: Added.
* fast/forms/date/calendar-picker-type-change-onclick.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoForm state: Make a new class handling HashMap<FormElementKey, Deque<>>
tkent@chromium.org [Wed, 18 Jul 2012 04:16:13 +0000 (04:16 +0000)]
Form state: Make a new class handling HashMap<FormElementKey, Deque<>>
https://bugs.webkit.org/show_bug.cgi?id=91480

Reviewed by Hajime Morita.

This is a preparation of Bug 91209, "Form state restore: Need to
identify a from by its content."

Make a new class which is responsible to handle "HashMap<FormElementKey,
Deque<FormControlState>, FormElementKeyHash, FormElementKeyHashTraits>."
Also, move the FormElementKey class declaration and related structs from
FormController.h to FormController.cpp because FormElementKey is used
only in FormController.cpp.

No new tests. Just a refactoring.

* html/FormController.cpp:
(WebCore::FormElementKey): Moeved from FormController.h.
(WebCore::FormElementKey::FormElementKey):
Moved from the bottom of FormController.cpp
(WebCore::FormElementKey::~FormElementKey): ditto.
(WebCore::FormElementKey::operator=): ditto.
(WebCore::FormElementKey::ref): ditto.
(WebCore::FormElementKey::deref): ditto.
(WebCore::operator==): Moved from FormController.h
(FormElementKeyHash): ditto.
(WebCore::FormElementKeyHash::equal): ditto.
(WebCore::FormElementKeyHash::hash):
Moved from the bottom of FormController.cpp
(WebCore::FormElementKeyHashTraits::constructDeletedValue):
Moved from FormController.h
(WebCore::FormElementKeyHashTraits::isDeletedValue): ditto.

(WebCore::SavedFormState): Added.
(WebCore::SavedFormState::isEmpty):
(WebCore::SavedFormState::SavedFormState): Added. The constructor.
(WebCore::SavedFormState::create): Added. A factory function.
(WebCore::SavedFormState::appendControlState):
Moved some code from FormController::setStateForNewFormElements.
(WebCore::SavedFormState::takeControlState):
Moved some code from FormController::takeStateForFormElement.

(WebCore::FormController::setStateForNewFormElements):
- Creates SavedFormState if needed.
- Uses SavedFormState::appendControlState.
(WebCore::FormController::takeStateForFormElement):
Uses SavedFormState.
* html/FormController.h:
(FormController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTest cases in DecimalTest should use EXPECT_STREQ for ease of debugging test case
yosin@chromium.org [Wed, 18 Jul 2012 04:09:04 +0000 (04:09 +0000)]
Test cases in DecimalTest should use EXPECT_STREQ for ease of debugging test case
https://bugs.webkit.org/show_bug.cgi?id=91572

Reviewed by Kent Tamura.

This patch introduces EXPECT_DECIMAL_STREQ macro to replace EXPECT_EQ
with String class for displaying text string rather than object dump
for ease of debugging test cases.

* tests/DecimalTest.cpp:
(DecimalTest::stepDown): Changed to return Decimal instead of String
to use EXPECT_DECIMAL_STREQ.
(DecimalTest::stepUp): ditto.
(TEST_F): Replaced EXPECT_EQ + String class to EXPECT_DECIMAL_STREQ.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow DOM] Some distribution invalidation can drop necessary reattachment.
morrita@google.com [Wed, 18 Jul 2012 04:05:24 +0000 (04:05 +0000)]
[Shadow DOM] Some distribution invalidation can drop necessary reattachment.
https://bugs.webkit.org/show_bug.cgi?id=88843

Reviewed by Dimitri Glazkov.

Source/WebCore:

Following scenario caused this problem:

- Inserting a Text node as a shadow child triggers invalidateDistribution(),
  which doen't reattach the shadow's host element.
- Then inserting a <content> element after that triggers another invalidateDistribution(),
  which should reattach its host because <content> can affect not only distribution of new nodes,
  but also existing distribution.
- Since the first invalidateDistribution() has marked the distribution as invalidated,
  the second invalidateDistribution() call returns early without any reattachment,
  even though it needs one.

This change adds InvalidationType parameter to invalidateDistribution(), which asks ElementShadow to
reattach the host regardless of its validity state. InsertionPoint::insertedInto() uses
this flag to ensure that its insertion always results a reattachment.

Test: fast/dom/shadow/content-after-style.html

* dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): Passes InvalidationType.
(WebCore::ElementShadow::removeAllShadowRoots): Passes InvalidationType.
(WebCore::ElementShadow::invalidateDistribution): Added a InvalidationType parameter.
* dom/ElementShadow.h:
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::insertedInto): Passes InvalidationType.

LayoutTests:

* fast/dom/shadow/content-after-style-expected.html: Added.
* fast/dom/shadow/content-after-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium-Android] Run ref tests together to avoid expensive driver restarts
wangxianzhu@chromium.org [Wed, 18 Jul 2012 02:45:46 +0000 (02:45 +0000)]
[Chromium-Android] Run ref tests together to avoid expensive driver restarts
https://bugs.webkit.org/show_bug.cgi?id=91533

Reviewed by Dirk Pranke.

Though DriverProxy maintains two drivers to support pixel tests and non-pixel tests,
chromium-android uses another way because it can't support multiple drivers.
It restarts the driver when pixel-test mode changes (e.g. when running a ref test after
a normal test in --no-pixel-tests mode). However restarting driver is expensive on
Android (several seconds each time). To reduce the cost, a command line option
'--shard-ref-tests' is added to group ref tests in dedicated shards.
The option is by default enabled on Android.

Will remove the option once DRT supports switching pixel test mode during one run.
(https://bugs.webkit.org/show_bug.cgi?id=91538, https://bugs.webkit.org/show_bug.cgi?id=91539)

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._shard_tests):
(Manager._shard_in_two):
(Manager._shard_by_directory):
(Manager._run_tests):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker._update_test_input):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNRWT The time before server_process kills DRT should be variable
commit-queue@webkit.org [Wed, 18 Jul 2012 01:26:24 +0000 (01:26 +0000)]
NRWT The time before server_process kills DRT should be variable
https://bugs.webkit.org/show_bug.cgi?id=91542

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-07-17
Reviewed by Dirk Pranke.

Added the ability to configure the amount of time
server_process waits before killing the DRT process
during the call to stop.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.variable.process_kill_time):
* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess.stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTeach CodeGenerator to support for static, readonly, attributes
jonlee@apple.com [Wed, 18 Jul 2012 01:16:14 +0000 (01:16 +0000)]
Teach CodeGenerator to support for static, readonly, attributes
https://bugs.webkit.org/show_bug.cgi?id=88920
<rdar://problem/11650330>

Reviewed by Oliver Hunt.

Update the parser to be able to accept the static keyword for attribute. We will treat static attributes
like custom static functions. They call the implementing class directly, and pass in the ExecState as a script context.

* bindings/scripts/CodeGeneratorJS.pm:
(GetAttributeGetterName): Factor out the construction of the attribute getter function name.
(GetAttributeSetterName): Factor out the construction of the attribute setter function name.
(GenerateHeader): Determine that a class has read-write properties only if there is a read-write attribute that
is not static.
(GenerateAttributesHashTable): Skip static attributes in the object hash table. They will be added to the constructor
hash table.
(GenerateImplementation): Look for static attributes to add to the constructor hash table. Make a call to the static
function in the class.
* bindings/scripts/IDLParser.pm:
(ParseInterface): Update the processing because of the regex change.
* bindings/scripts/IDLStructure.pm: Update the attribute regex.
* bindings/scripts/test/JS/JSTestObj.cpp: Update test results.
* bindings/scripts/test/JS/JSTestObj.h: Update test results.
* bindings/scripts/test/TestObj.idl: Add test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rename HarfBuzzFace to HarfBuzzNGFace
bashi@chromium.org [Wed, 18 Jul 2012 01:12:10 +0000 (01:12 +0000)]
[Chromium] Rename HarfBuzzFace to HarfBuzzNGFace
https://bugs.webkit.org/show_bug.cgi?id=91458

Reviewed by Tony Chang.

There are HarfbuzzFace class (for old-harfbuzz) and HarfBuzzFace (for harfbuzz-ng) class. The difference is too subtle. Make them more distinct.

No new tests. No changes in behavior.

* WebCore.gyp/WebCore.gyp: Rename HarfBuzzFace to HarfBuzzNGFace.
* WebCore.gypi: Ditto.
* platform/graphics/FontPlatformData.h: Ditto.
(FontPlatformData):
* platform/graphics/cocoa/FontPlatformDataCocoa.mm: Ditto.
(WebCore::FontPlatformData::harfbuzzFace):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Ditto.
(WebCore::FontPlatformData::harfbuzzFace):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Ditto.
(FontPlatformData):
* platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCoreText.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp.
(WebCore):
(WebCore::floatToHarfBuzzPosition):
(WebCore::getGlyph):
(WebCore::getGlyphHorizontalAdvance):
(WebCore::getGlyphHorizontalOrigin):
(WebCore::getGlyphExtents):
(WebCore::harfbuzzCoreTextGetFontFuncs):
(WebCore::releaseTableData):
(WebCore::harfbuzzCoreTextGetTable):
(WebCore::HarfBuzzNGFace::createFace):
(WebCore::HarfBuzzNGFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
* platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceSkia.cpp.
(WebCore):
(WebCore::SkiaScalarToHarfbuzzPosition):
(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzSkiaGetFontFuncs):
(WebCore::harfbuzzSkiaGetTable):
(WebCore::destroyPaint):
(WebCore::HarfBuzzNGFace::createFace):
(WebCore::HarfBuzzNGFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
* platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp.
(WebCore):
(WebCore::harfbuzzFaceCache):
(WebCore::HarfBuzzNGFace::HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::~HarfBuzzNGFace):
* platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFace.h.
(WebCore):
(HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::create):
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRecord metrics to measure the usage of Blob([ArrayBuffer]) to eventually deprecate it
kinuko@chromium.org [Wed, 18 Jul 2012 01:08:39 +0000 (01:08 +0000)]
Record metrics to measure the usage of Blob([ArrayBuffer]) to eventually deprecate it
https://bugs.webkit.org/show_bug.cgi?id=90534

Reviewed by Jian Li.

We are removing ArrayBuffer support in Blob constructor (in favor of
ArrayBufferView) but before doing that we should record its use relative to ArrayBufferView.
http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob

No new tests as this has no functional changes.

* fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Key generator state not maintained across connections
jsbell@chromium.org [Wed, 18 Jul 2012 01:07:27 +0000 (01:07 +0000)]
IndexedDB: Key generator state not maintained across connections
https://bugs.webkit.org/show_bug.cgi?id=91456

Reviewed by Tony Chang.

Source/WebCore:

Explicitly store key generator state for each object store in the backing store,
rather than deriving it from the maximum key in the data (which violates the spec
if data is deleted).

This change eliminates a (fragile) per-store cache of the value to simplify the
code. A cache could be re-introduced, requiring an "onbeforecommit" hook for
object stores, but it seems cleaner to save that for a follow-up patch.

Test: storage/indexeddb/key-generator.html

* Modules/indexeddb/IDBBackingStore.h: New APIs for getting/setting generator states.
(IDBBackingStore):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getObjectStores): Read generator state (but currently ignored).
(WebCore::IDBLevelDBBackingStore::createObjectStore): Write generator state.
(WebCore):
(WebCore::IDBLevelDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber): Update, optionally
checking to see if the new value is greater than the old. (If caller got the value via
getKeyGeneratorCurrentNumber it is safe to skip the check.)
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
* Modules/indexeddb/IDBLevelDBCoding.cpp:
* Modules/indexeddb/IDBLevelDBCoding.h:
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl): Ditch the cache.
(WebCore::IDBObjectStoreBackendImpl::put): No need for abort task.
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys): Ditto.
(WebCore::IDBObjectStoreBackendImpl::putInternal): Use the newfangled APIs below.
(WebCore::IDBObjectStoreBackendImpl::generateKey):
(WebCore::IDBObjectStoreBackendImpl::updateKeyGenerator):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):

Source/WebKit/chromium:

Add stub method implementations to test class.

* tests/IDBFakeBackingStore.h:

LayoutTests:

Added key generator test case that spans database connections.

* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/resources/key-generator.js:
(testAcrossConnections.request.onsuccess.request.onsuccess.request.onsuccess):
(testAcrossConnections.request.onsuccess.request.onsuccess):
(testAcrossConnections.request.onsuccess):
(testAcrossConnections.doFirstWrite.request.onsuccess):
(testAcrossConnections.doFirstWrite):
(testAcrossConnections.closeAndReopen.request.onsuccess):
(testAcrossConnections.closeAndReopen):
(testAcrossConnections.doSecondWrite.request.onsuccess):
(testAcrossConnections.doSecondWrite.trans.oncomplete):
(testAcrossConnections.doSecondWrite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitdirs.pm should fallback to uname -m if arch is not present.
alexis.menard@openbossa.org [Wed, 18 Jul 2012 00:58:47 +0000 (00:58 +0000)]
webkitdirs.pm should fallback to uname -m if arch is not present.
https://bugs.webkit.org/show_bug.cgi?id=91543

Reviewed by Martin Robinson.

It seems that coreutils is moving away from the 'arch' command. Archlinux
for example doesn't ship it anymore (coreutils 8.17). We can then fallback
to 'uname -m' to find out the architecture.

* Scripts/webkitdirs.pm:
(determineArchitecture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium windows rebaseline for r122883.
eae@chromium.org [Wed, 18 Jul 2012 00:49:59 +0000 (00:49 +0000)]
Unreviewed chromium windows rebaseline for r122883.

* platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
* platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Added.
* platform/chromium-win-xp/fast/inline-block/inline-block-vertical-align-expected.png: Added.
* platform/chromium-win-xp/fast/inline/002-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: createIndex should throw INVALID_ACCESS_ERR instead of NOT_SUPPORTED_ERR
commit-queue@webkit.org [Wed, 18 Jul 2012 00:35:25 +0000 (00:35 +0000)]
IndexedDB: createIndex should throw INVALID_ACCESS_ERR instead of NOT_SUPPORTED_ERR
https://bugs.webkit.org/show_bug.cgi?id=91553

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-17
Reviewed by Tony Chang.

Source/WebCore:

Update createIndex to throw an INVALID_ACCESS_ERR
as per the IndexedDB spec.

No new tests: existing tests have been updated

* Modules/indexeddb/IDBDatabaseException.cpp:
(WebCore):
* Modules/indexeddb/IDBDatabaseException.h:
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):

LayoutTests:

Update to match IndexedDB spec.

* storage/indexeddb/keypath-arrays-expected.txt:
* storage/indexeddb/resources/keypath-arrays.js:
(openSuccess.request.onsuccess):
(openSuccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: rename printer.print_update to printer.write_update to match metered_stream
dpranke@chromium.org [Wed, 18 Jul 2012 00:32:12 +0000 (00:32 +0000)]
nrwt: rename printer.print_update to printer.write_update to match metered_stream
https://bugs.webkit.org/show_bug.cgi?id=91557

Reviewed by Ojan Vafai.

Now that all of the printing logic is in printer.py, I want the
public interface to printer to follow the meteredstream
interface where possible. renaming write_update() gets us close.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
(Manager._set_up_run):
(Manager.start_servers_with_lock):
(Manager.stop_servers_with_lock):
(Manager._clobber_old_results):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.write_update):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_write_update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove entries in TestExpectations for passing non-scaling-stroke-pattern.svg
pdr@google.com [Wed, 18 Jul 2012 00:30:39 +0000 (00:30 +0000)]
Remove entries in TestExpectations for passing non-scaling-stroke-pattern.svg
https://bugs.webkit.org/show_bug.cgi?id=88230

Unreviewed update of test expecatations.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a bug where optimize-baselines would incorrectly fail to optimize
tony@chromium.org [Wed, 18 Jul 2012 00:26:25 +0000 (00:26 +0000)]
Fix a bug where optimize-baselines would incorrectly fail to optimize
https://bugs.webkit.org/show_bug.cgi?id=91551

Reviewed by Adam Barth.

In some cases, optimize-baseline would correctly optimize the results, but because
we weren't filtering the virtual ports out of _results_by_port_name, we thought
that we had failed to optimize.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer._find_optimal_result_placement): No virtual filtering here.
(BaselineOptimizer._filtered_results_by_port_name): New function that filters out virtual directories.
(BaselineOptimizer.optimize): Filter out virtual ports.
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(TestBaselineOptimizer._move_baselines): Add a stub so we don't actual move results.
(BaselineOptimizerTest._assertOptimization): Call optimize and verify that the right files were moved.
(BaselineOptimizerTest._assertOptimizationFailed): Add a method for when optimization should fail.
(BaselineOptimizerTest.test_common_directory_includes_root): Update since this test should fail.
(BaselineOptimizerTest.test_virtual_ports_filtered): New test case that demonstrates the bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Add --encode-binary command line option for DRT
wangxianzhu@chromium.org [Wed, 18 Jul 2012 00:21:45 +0000 (00:21 +0000)]
[Chromium] Add --encode-binary command line option for DRT
https://bugs.webkit.org/show_bug.cgi?id=91532

Reviewed by Adam Barth.

When the option presents, DRT will encode binary output data in base64.
ChromiumAndroidPort will pass the option because 'adb shell' doesn't support
binary data output.

This change is a refactoring to replace the original hard-coded code for Android.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestEventPrinter.cpp:
(TestEventPrinter::TestEventPrinter):
(TestEventPrinter::handleAudio): New function replacing the original handleAudioHeader
(TestEventPrinter::handleImage):
(TestEventPrinter::handleBinary): Extracted common function for handleAudio and handleImage
* DumpRenderTree/chromium/TestEventPrinter.h:
(TestEventPrinter):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::initialize):
(TestShell::dump):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
(TestShell::setEncodeBinary):
* Scripts/webkitpy/layout_tests/port/chromium_android.py: Add --encode-binary to additional_drt_flags
(ChromiumAndroidPort.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDragImageChromiumMac.cpp is never compiled and can be removed
abarth@webkit.org [Wed, 18 Jul 2012 00:16:01 +0000 (00:16 +0000)]
DragImageChromiumMac.cpp is never compiled and can be removed
https://bugs.webkit.org/show_bug.cgi?id=91545

Reviewed by Tony Chang.

This file would only be compiled on chromium-mac, but it's excluded
from that build. This is likely left over from the CG configuration.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/DragImageChromiumMac.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium lion/snowleopard rebaseline for r122883.
eae@chromium.org [Wed, 18 Jul 2012 00:12:40 +0000 (00:12 +0000)]
Unreviewed chromium lion/snowleopard rebaseline for r122883.

* platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.png:
* platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-mac/fast/block/basic/014-expected.png:
* platform/chromium-mac/fast/inline/002-expected.png:
* platform/chromium-mac/fast/table/table-display-types-strict-expected.png:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r122884.
tony@chromium.org [Wed, 18 Jul 2012 00:03:31 +0000 (00:03 +0000)]
Unreviewed, rolling out r122884.
http://trac.webkit.org/changeset/122884
https://bugs.webkit.org/show_bug.cgi?id=91408

Broke the chromium-win build.

* public/WebIDBMetadata.h:
(WebIDBMetadata):
(WebKit::WebIDBMetadata::WebIDBMetadata):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: move per-test result output into printing.py
dpranke@chromium.org [Tue, 17 Jul 2012 23:39:35 +0000 (23:39 +0000)]
nrwt: move per-test result output into printing.py
https://bugs.webkit.org/show_bug.cgi?id=91465

Reviewed by Ojan Vafai.

This moves the last substantive logging/printing code from the
manager into printing.py. Subsequent patches in this thread can
largely focus on cleaning up printing.py and will leave the rest
of the code alone.

This patch also removes manager.update() and
manager.update_summary(), two routines that were no longer being
used or needed (they have been dead for a long time but I didn't
notice them until now).

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.results_directory):
(Manager._look_for_new_crash_logs):
(Manager._update_summary_with_result):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_finished_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAssertion failure/crash on Windows when using a font in an SVG
commit-queue@webkit.org [Tue, 17 Jul 2012 23:27:05 +0000 (23:27 +0000)]
Assertion failure/crash on Windows when using a font in an SVG
element with an unresaonbly large font size
https://bugs.webkit.org/show_bug.cgi?id=91273
Radar: <rdar://problem/8355401>

Source/WebCore:

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-17
Reviewed by Tim Horton.

When using a font in an SVG element with an unreasonably large
font size in Windows, WebKit crashes. The problem has to do with
font sizes overflowing into negative values in the Windows specific code.
The fix is to cap the font sizes to something reasonable when the font style is getting processed.
The fix will apply to both CSS and SVG so that behaviour is consistent.

Test: svg/text/font-size-too-large-crash.svg

* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyFontSize::applyValue):
This is where the font size capping now occurs. Caps size to 1000000.
Both CSS and SVG reach the font size capping code here.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
Capping here removed, moved to StyleBuilder.cpp.

LayoutTests:

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-17
Reviewed by Tim Horton.

Test to make sure that having an overly large font size won't crash on Windows.

* svg/text/font-size-too-large-crash-expected.txt: Added.
* svg/text/font-size-too-large-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd parsing and style application for css3-images image-orientation
commit-queue@webkit.org [Tue, 17 Jul 2012 23:23:36 +0000 (23:23 +0000)]
Add parsing and style application for css3-images image-orientation
https://bugs.webkit.org/show_bug.cgi?id=89624

Patch by David Barr <davidbarr@chromium.org> on 2012-07-17
Reviewed by Tony Chang.

The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation

Source/WebCore:

Test: fast/css/image-orientation/image-orientation.html

* css/CSSComputedStyleDeclaration.cpp: Add computed style for image-orientation.
(WebCore): Add CSSPropertyImageOrientation to computedProperties.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Map CSSPropertyImageOrientation using cast operator from PrimitiveValueMappings.
* css/CSSParser.cpp: Add parsing rule for image-orientation.
(WebCore::CSSParser::parseValue): Parse the value of CSSPropertyImageOrientation as an angle.
* css/CSSPrimitiveValueMappings.h: Add mappings between CSSPrimitiveValue and ImageOrientationEnum.
(WebCore): Add conditional include for ImageOrientation.h.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Map the natural orientations to angles.
(WebCore::CSSPrimitiveValue::operator ImageOrientationEnum): Round angles away from zero to quarter turns and map to the natural orientations.
* css/CSSProperty.cpp: Add CSSPropertyImageOrientation.
(WebCore::CSSProperty::isInheritedProperty): Map CSSPropertyImageOrientation inherited.
* css/CSSPropertyNames.in: Add image-orientation.
* css/StyleBuilder.cpp: Add style application logic for CSSPropertyImageOrientation.
(WebCore::StyleBuilder::StyleBuilder): Map CSSPropertyImageOrientation to RenderStyle::imageOrientation with type ImageOrientationEnum.
* css/StyleResolver.cpp: Handle CSSPropertyImageOrientation.
(WebCore::StyleResolver::applyProperty): Expect CSSPropertyImageOrientation to be handled by StyleBuilder.
* rendering/style/RenderStyle.h: Add imageOrientation, setImageOrientation and initialImageOrientation.
* rendering/style/StyleRareInheritedData.cpp: Add m_imageOrientation.
(WebCore::StyleRareInheritedData::StyleRareInheritedData): Add m_imageOrientation to default and copy contructors.
(WebCore::StyleRareInheritedData::operator==): Include m_imageOrientation in comparison.
* rendering/style/StyleRareInheritedData.h: Add m_imageOrientation.
(StyleRareInheritedData): Add 4-bit field m_imageOrientation, mapping to ImageOrientationEnum.

LayoutTests:

* fast/css/image-orientation/image-orientation-expected.txt: Added.
* fast/css/image-orientation/image-orientation.html: Added.
* platform/chromium/TestExpectations: Skip tests until image-orientation implementation lands.
* platform/efl/TestExpectations: Skip tests until image-orientation implementation lands.
* platform/gtk/TestExpectations: Skip tests until image-orientation implementation lands.
* platform/mac/TestExpectations: Skip tests until image-orientation implementation lands.
* platform/qt/TestExpectations: Skip tests until image-orientation implementation lands.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: move config-specific logging to printing.py
dpranke@chromium.org [Tue, 17 Jul 2012 23:20:53 +0000 (23:20 +0000)]
nrwt: move config-specific logging to printing.py
https://bugs.webkit.org/show_bug.cgi?id=91450

Reviewed by Ojan Vafai.

More refactoring ... this moves the 'config' output to
printing.py.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._resize_shards):
(Manager._run_tests):
(Manager._upload_json_files):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.get_options):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_config):
(Printer.print_workers_and_shards):
(Printer._print_config):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_fallback_path_in_config):
(Testprinter.test_print_config):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix two mistakes I made when modifying TestExpectations.
aestes@apple.com [Tue, 17 Jul 2012 23:20:53 +0000 (23:20 +0000)]
Fix two mistakes I made when modifying TestExpectations.

Apparently the MAC modifier and the FAIL result don't do what I think they do.

* platform/mac/TestExpectations: Remove MAC and replace FAIL with IMAGE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: clean up logging when we're only running one chunk of the tests
dpranke@chromium.org [Tue, 17 Jul 2012 23:18:44 +0000 (23:18 +0000)]
nrwt: clean up logging when we're only running one chunk of the tests
https://bugs.webkit.org/show_bug.cgi?id=91447

Reviewed by Ojan Vafai.

Apparently we were creating a 'tests_run.txt' in the results
directory if we were only running one chunk of the tests; after
3+ years of hacking on this code, that was news to me, so I'm
guessing no one uses this. I'm removing this, and changing the
_print_expected calls to debug messages to simplify the
layering.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._split_into_chunks_if_necessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, optimize baselines for fast/block/float/02[68].html .
tony@chromium.org [Tue, 17 Jul 2012 23:15:59 +0000 (23:15 +0000)]
Unreviewed, optimize baselines for fast/block/float/02[68].html .

* fast/block/float/026-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/026-expected.txt.
* fast/block/float/028-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/028-expected.txt.
* platform/chromium-mac-snowleopard/fast/block/float/026-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/float/028-expected.txt: Removed.
* platform/gtk/fast/block/float/026-expected.txt: Removed.
* platform/gtk/fast/block/float/028-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] REGRESSION (r122494): Running platform/mac/plugins/root-object-premature-delete...
fpizlo@apple.com [Tue, 17 Jul 2012 23:13:23 +0000 (23:13 +0000)]
[Mac] REGRESSION (r122494): Running platform/mac/plugins/root-object-premature-delete-crash.html results in a crash
https://bugs.webkit.org/show_bug.cgi?id=91505

Skip this test so we don't see it in the results.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix regression in style checker introduced in r122868.
dpranke@chromium.org [Tue, 17 Jul 2012 23:12:36 +0000 (23:12 +0000)]
Fix regression in style checker introduced in r122868.
https://bugs.webkit.org/show_bug.cgi?id=91470

Unreviewed, build fix.

* Scripts/webkitpy/style/checkers/cpp.py:
(_FileState.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] REGRESSION(r122768, r122771): They broke jquery/data.html and inspector/elements...
fpizlo@apple.com [Tue, 17 Jul 2012 23:11:23 +0000 (23:11 +0000)]
[Qt] REGRESSION(r122768, r122771): They broke jquery/data.html and inspector/elements/edit-dom-actions.html
https://bugs.webkit.org/show_bug.cgi?id=91476

Reviewed by Mark Hahnenberg.

The 32-bit repatching code was not correctly adapted to the new world where there may not always
be an available scratch register. Fixed it by ensuring that the scratch register we select does
not overlap with the value tag.

* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: move the bulk of the "expected" output to printing.py
dpranke@chromium.org [Tue, 17 Jul 2012 23:08:10 +0000 (23:08 +0000)]
nrwt: move the bulk of the "expected" output to printing.py
https://bugs.webkit.org/show_bug.cgi?id=91442

Reviewed by Ojan Vafai.

More printing-related refactoring. This moves all of the code
that prints the results we expect to get, but doesn't move a few
dangling printfs (those'll get hit in a later patch).

No functional changes; covered by existing tests.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._split_into_chunks_if_necessary):
(Manager.prepare_lists_and_print_output):
(Manager.print_config):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_expected):
(Printer):
(Printer._print_expected_results_of_type):
(Printer._num_digits):
(Printer._print_expected):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_print_expected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r122215) - RenderObject::willRenderImage crashes on null view()
enne@google.com [Tue, 17 Jul 2012 23:06:38 +0000 (23:06 +0000)]
REGRESSION(r122215) - RenderObject::willRenderImage crashes on null view()
https://bugs.webkit.org/show_bug.cgi?id=91525

Reviewed by Julien Chaffraix.

Fix by doing an early out check.  This is intended to fix the crash in
http://crbug.com/137161.

No new test, because unfortunately a layout test is ill-suited to
reproing this kind of Document creation/destruction bug.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::willRenderImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] REGRESSION (r122651): fast/text/descent-clip-in-scaled-page.html fails
aestes@apple.com [Tue, 17 Jul 2012 23:05:24 +0000 (23:05 +0000)]
[Mac] REGRESSION (r122651): fast/text/descent-clip-in-scaled-page.html fails
https://bugs.webkit.org/show_bug.cgi?id=91552

* platform/mac/TestExpectations: Mark the test as expected to fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h
dgrogan@chromium.org [Tue, 17 Jul 2012 23:04:45 +0000 (23:04 +0000)]
IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h
https://bugs.webkit.org/show_bug.cgi?id=91408

Reviewed by Adam Barth.

This is in support of the new upgradeneeded versioning api.
intVersion will eventually replace the WebString version member.

* public/WebIDBMetadata.h:
(WebIDBMetadata): The spec uses unsigned long long for version
numbers but we use int64_t here so that we can use -1 as a sentinel.
It indicates that a database still uses a string version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agovertical-align: middle causes overflow with subpixel layout
eae@chromium.org [Tue, 17 Jul 2012 22:51:46 +0000 (22:51 +0000)]
vertical-align: middle causes overflow with subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=91464

Reviewed by Eric Seidel.

Source/WebCore:

Using vertical-align: middle in combination with an overflow value other
than visible can cause the overflow height to be computed incorrectly.

Test: fast/sub-pixel/vertical-align-middle-overflow.html

* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox):
Round verticalPosition after calculation instead of flooring the result
of the xHeight calculation. By flooring it the resulting value is in
effect rounded up which can cause the height of the box to grow by one.
By rounding the resulting value thevertical position is more accurate and
the off by one error is avoided.

LayoutTests:

Add new test for vertical-align: middle and adjust existing results to
reflect the improved alignment calculation.

* fast/sub-pixel/vertical-align-middle-overflow-expected.txt: Added.
* fast/sub-pixel/vertical-align-middle-overflow.html: Added.
* platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
* platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.png:
* platform/chromium-linux/fast/inline/002-expected.png:
* platform/chromium-linux/fast/table/table-display-types-strict-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-mac-snowleopard/fast/block/basic/014-expected.png:
* platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.png:
* platform/chromium-mac-snowleopard/fast/inline/002-expected.png:
* platform/chromium-mac-snowleopard/fast/table/table-display-types-strict-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac/css1/text_properties/vertical_align-expected.txt:
* platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
* platform/chromium-mac/fast/block/basic/014-expected.txt:
* platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/chromium-win/css1/text_properties/vertical_align-expected.txt:
* platform/chromium-win/fast/block/basic/014-expected.txt:
* platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.txt:
* platform/chromium-win/fast/inline/002-expected.txt:
* platform/chromium-win/fast/table/table-display-types-strict-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac/fast/inline/002-expected.txt:
* platform/mac/fast/replaced/008-expected.png:
* platform/mac/fast/table/table-display-types-strict-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoA couple of UI nits about the flagging feature in results.html
ojan@chromium.org [Tue, 17 Jul 2012 22:22:12 +0000 (22:22 +0000)]
A couple of UI nits about the flagging feature in results.html
https://bugs.webkit.org/show_bug.cgi?id=86798

Reviewed by Dirk Pranke.

-Clicking the flag unflags it now
-There's a flag all link for each test list
-Make the flag list always show up at the bottom of the viewport
when there are flagged tests. This makes it both less annoying
and easier to understand what's going on when you flag a test.
This required wrapping all the content in a div so that we could
make the body be a flexbox.
* fast/harness/resources/results-test.js:
(runSingleRowTest):
* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] fast/forms tests needs update after rebaseline and new testfonts
commit-queue@webkit.org [Tue, 17 Jul 2012 22:16:51 +0000 (22:16 +0000)]
[Qt] fast/forms tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91504

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-17
Reviewed by Alexis Menard.

Updated expected Qt results for most fast/forms layout tests, after testfonts changes made by bug 85203.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.png:
* platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.txt:
* platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.png:
* platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.txt:
* platform/qt-5.0/fast/forms/box-shadow-override-expected.png:
* platform/qt-5.0/fast/forms/box-shadow-override-expected.txt:
* platform/qt-5.0/fast/forms/form-element-geometry-expected.png:
* platform/qt-5.0/fast/forms/form-element-geometry-expected.txt:
* platform/qt-5.0/fast/forms/input-disabled-color-expected.png:
* platform/qt-5.0/fast/forms/input-disabled-color-expected.txt:
* platform/qt-5.0/fast/forms/listbox-bidi-align-expected.txt:
* platform/qt-5.0/fast/forms/menulist-separator-painting-expected.txt:
* platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.png:
* platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/qt-5.0/fast/forms/search-rtl-expected.png:
* platform/qt-5.0/fast/forms/search-rtl-expected.txt:
* platform/qt-5.0/fast/forms/select-background-none-expected.txt:
* platform/qt-5.0/fast/forms/select-baseline-expected.png:
* platform/qt-5.0/fast/forms/select-baseline-expected.txt:
* platform/qt-5.0/fast/forms/selectlist-minsize-expected.txt:
* platform/qt-5.0/fast/forms/textarea-align-expected.png:
* platform/qt-5.0/fast/forms/textarea-align-expected.txt:
* platform/qt-5.0/fast/forms/textarea-setinnerhtml-expected.png:
* platform/qt-5.0/fast/forms/textarea-setinnerhtml-expected.txt:
* platform/qt/fast/forms/003-expected.txt:
* platform/qt/fast/forms/004-expected.txt:
* platform/qt/fast/forms/006-expected.txt:
* platform/qt/fast/forms/007-expected.txt:
* platform/qt/fast/forms/HTMLOptionElement_label01-expected.txt:
* platform/qt/fast/forms/HTMLOptionElement_label02-expected.txt:
* platform/qt/fast/forms/HTMLOptionElement_label03-expected.txt:
* platform/qt/fast/forms/HTMLOptionElement_label04-expected.txt:
* platform/qt/fast/forms/HTMLOptionElement_label05-expected.txt:
* platform/qt/fast/forms/basic-inputs-expected.png:
* platform/qt/fast/forms/basic-inputs-expected.txt:
* platform/qt/fast/forms/basic-selects-expected.png:
* platform/qt/fast/forms/basic-selects-expected.txt:
* platform/qt/fast/forms/basic-textareas-quirks-expected.png:
* platform/qt/fast/forms/basic-textareas-quirks-expected.txt:
* platform/qt/fast/forms/blankbuttons-expected.png:
* platform/qt/fast/forms/blankbuttons-expected.txt:
* platform/qt/fast/forms/button-align-expected.png:
* platform/qt/fast/forms/button-align-expected.txt:
* platform/qt/fast/forms/button-cannot-be-nested-expected.png:
* platform/qt/fast/forms/button-cannot-be-nested-expected.txt:
* platform/qt/fast/forms/button-default-title-expected.txt:
* platform/qt/fast/forms/button-generated-content-expected.png:
* platform/qt/fast/forms/button-generated-content-expected.txt:
* platform/qt/fast/forms/button-inner-block-reuse-expected.png:
* platform/qt/fast/forms/button-inner-block-reuse-expected.txt:
* platform/qt/fast/forms/button-positioned-expected.png:
* platform/qt/fast/forms/button-positioned-expected.txt:
* platform/qt/fast/forms/button-sizes-expected.png:
* platform/qt/fast/forms/button-sizes-expected.txt:
* platform/qt/fast/forms/button-style-color-expected.png:
* platform/qt/fast/forms/button-style-color-expected.txt:
* platform/qt/fast/forms/button-submit-expected.txt:
* platform/qt/fast/forms/button-table-styles-expected.png:
* platform/qt/fast/forms/button-table-styles-expected.txt:
* platform/qt/fast/forms/button-text-transform-expected.png:
* platform/qt/fast/forms/button-text-transform-expected.txt:
* platform/qt/fast/forms/caret-rtl-expected.txt:
* platform/qt/fast/forms/control-clip-expected.txt:
* platform/qt/fast/forms/control-clip-overflow-expected.png:
* platform/qt/fast/forms/control-clip-overflow-expected.txt:
* platform/qt/fast/forms/control-restrict-line-height-expected.png:
* platform/qt/fast/forms/control-restrict-line-height-expected.txt:
* platform/qt/fast/forms/disabled-select-change-index-expected.png:
* platform/qt/fast/forms/disabled-select-change-index-expected.txt:
* platform/qt/fast/forms/encoding-test-expected.png:
* platform/qt/fast/forms/encoding-test-expected.txt:
* platform/qt/fast/forms/fieldset-align-expected.png:
* platform/qt/fast/forms/fieldset-align-expected.txt:
* platform/qt/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png:
* platform/qt/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
* platform/qt/fast/forms/fieldset-with-float-expected.txt:
* platform/qt/fast/forms/file/file-input-direction-expected.png:
* platform/qt/fast/forms/file/file-input-direction-expected.txt:
* platform/qt/fast/forms/file/file-input-disabled-expected.png:
* platform/qt/fast/forms/file/file-input-disabled-expected.txt:
* platform/qt/fast/forms/float-before-fieldset-expected.png:
* platform/qt/fast/forms/float-before-fieldset-expected.txt:
* platform/qt/fast/forms/floating-textfield-relayout-expected.png:
* platform/qt/fast/forms/floating-textfield-relayout-expected.txt:
* platform/qt/fast/forms/form-added-to-table-expected.txt:
* platform/qt/fast/forms/form-hides-table-expected.png:
* platform/qt/fast/forms/form-hides-table-expected.txt:
* platform/qt/fast/forms/form-in-malformed-markup-expected.txt:
* platform/qt/fast/forms/formmove-expected.txt:
* platform/qt/fast/forms/formmove2-expected.txt:
* platform/qt/fast/forms/formmove3-expected.png:
* platform/qt/fast/forms/formmove3-expected.txt:
* platform/qt/fast/forms/hidden-listbox-expected.txt:
* platform/qt/fast/forms/image-border-expected.txt:
* platform/qt/fast/forms/indeterminate-expected.txt:
* platform/qt/fast/forms/input-align-expected.png:
* platform/qt/fast/forms/input-align-expected.txt:
* platform/qt/fast/forms/input-align-image-expected.txt:
* platform/qt/fast/forms/input-appearance-bkcolor-expected.png:
* platform/qt/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/qt/fast/forms/input-appearance-default-bkcolor-expected.png:
* platform/qt/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/qt/fast/forms/input-appearance-disabled-expected.png:
* platform/qt/fast/forms/input-appearance-disabled-expected.txt:
* platform/qt/fast/forms/input-appearance-focus-expected.png:
* platform/qt/fast/forms/input-appearance-focus-expected.txt:
* platform/qt/fast/forms/input-appearance-preventDefault-expected.png:
* platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/qt/fast/forms/input-appearance-readonly-expected.png:
* platform/qt/fast/forms/input-appearance-readonly-expected.txt:
* platform/qt/fast/forms/input-appearance-selection-expected.png:
* platform/qt/fast/forms/input-appearance-selection-expected.txt:
* platform/qt/fast/forms/input-appearance-visibility-expected.png:
* platform/qt/fast/forms/input-appearance-visibility-expected.txt:
* platform/qt/fast/forms/input-baseline-expected.png:
* platform/qt/fast/forms/input-baseline-expected.txt:
* platform/qt/fast/forms/input-button-sizes-expected.png:
* platform/qt/fast/forms/input-button-sizes-expected.txt:
* platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/qt/fast/forms/input-field-text-truncated-expected.png:
* platform/qt/fast/forms/input-field-text-truncated-expected.txt:
* platform/qt/fast/forms/input-first-letter-expected.txt:
* platform/qt/fast/forms/input-no-renderer-expected.txt:
* platform/qt/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/qt/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/qt/fast/forms/input-readonly-dimmed-expected.png:
* platform/qt/fast/forms/input-readonly-dimmed-expected.txt:
* platform/qt/fast/forms/input-readonly-empty-expected.png:
* platform/qt/fast/forms/input-readonly-empty-expected.txt:
* platform/qt/fast/forms/input-spaces-expected.png:
* platform/qt/fast/forms/input-spaces-expected.txt:
* platform/qt/fast/forms/input-text-click-inside-expected.png:
* platform/qt/fast/forms/input-text-click-inside-expected.txt:
* platform/qt/fast/forms/input-text-double-click-expected.png:
* platform/qt/fast/forms/input-text-double-click-expected.txt:
* platform/qt/fast/forms/input-text-option-delete-expected.png:
* platform/qt/fast/forms/input-text-option-delete-expected.txt:
* platform/qt/fast/forms/input-text-self-emptying-click-expected.png:
* platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/qt/fast/forms/input-text-word-wrap-expected.png:
* platform/qt/fast/forms/input-text-word-wrap-expected.txt:
* platform/qt/fast/forms/input-width-expected.png:
* platform/qt/fast/forms/input-width-expected.txt:
* platform/qt/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
* platform/qt/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
* platform/qt/fast/forms/menulist-clip-expected.png:
* platform/qt/fast/forms/menulist-clip-expected.txt:
* platform/qt/fast/forms/menulist-deselect-update-expected.txt:
* platform/qt/fast/forms/menulist-no-overflow-expected.txt:
* platform/qt/fast/forms/menulist-option-wrap-expected.png:
* platform/qt/fast/forms/menulist-option-wrap-expected.txt:
* platform/qt/fast/forms/menulist-style-color-expected.png:
* platform/qt/fast/forms/menulist-style-color-expected.txt:
* platform/qt/fast/forms/minWidthPercent-expected.png:
* platform/qt/fast/forms/minWidthPercent-expected.txt:
* platform/qt/fast/forms/negativeLineHeight-expected.png:
* platform/qt/fast/forms/negativeLineHeight-expected.txt:
* platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png:
* platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt:
* platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
* platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
* platform/qt/fast/forms/option-index-expected.txt:
* platform/qt/fast/forms/option-script-expected.txt:
* platform/qt/fast/forms/option-strip-whitespace-expected.txt:
* platform/qt/fast/forms/option-text-clip-expected.txt:
* platform/qt/fast/forms/placeholder-position-expected.png:
* platform/qt/fast/forms/placeholder-position-expected.txt:
* platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.txt:
* platform/qt/fast/forms/range/input-appearance-range-expected.png:
* platform/qt/fast/forms/range/input-appearance-range-expected.txt:
* platform/qt/fast/forms/range/range-thumb-height-percentage-expected.png:
* platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt:
* platform/qt/fast/forms/range/slider-padding-expected.png:
* platform/qt/fast/forms/range/slider-padding-expected.txt:
* platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/qt/fast/forms/search-display-none-cancel-button-expected.png:
* platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/qt/fast/forms/search-styled-expected.png:
* platform/qt/fast/forms/search-styled-expected.txt:
* platform/qt/fast/forms/search-vertical-alignment-expected.png:
* platform/qt/fast/forms/search-vertical-alignment-expected.txt:
* platform/qt/fast/forms/select-align-expected.txt:
* platform/qt/fast/forms/select-block-background-expected.txt:
* platform/qt/fast/forms/select-change-listbox-size-expected.txt:
* platform/qt/fast/forms/select-change-listbox-to-popup-expected.txt:
* platform/qt/fast/forms/select-change-popup-to-listbox-expected.txt:
* platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt:
* platform/qt/fast/forms/select-disabled-appearance-expected.txt:
* platform/qt/fast/forms/select-display-none-style-resolve-expected.txt:
* platform/qt/fast/forms/select-empty-option-height-expected.txt:
* platform/qt/fast/forms/select-initial-position-expected.txt:
* platform/qt/fast/forms/select-item-background-clip-expected.txt:
* platform/qt/fast/forms/select-list-box-with-height-expected.txt:
* platform/qt/fast/forms/select-listbox-multiple-no-focusring-expected.png:
* platform/qt/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
* platform/qt/fast/forms/select-overflow-scroll-expected.png:
* platform/qt/fast/forms/select-overflow-scroll-expected.txt:
* platform/qt/fast/forms/select-overflow-scroll-inherited-expected.png:
* platform/qt/fast/forms/select-overflow-scroll-inherited-expected.txt:
* platform/qt/fast/forms/select-selected-expected.txt:
* platform/qt/fast/forms/select-size-expected.txt:
* platform/qt/fast/forms/select-style-expected.txt:
* platform/qt/fast/forms/stuff-on-my-optgroup-expected.txt:
* platform/qt/fast/forms/targeted-frame-submission-expected.png:
* platform/qt/fast/forms/targeted-frame-submission-expected.txt:
* platform/qt/fast/forms/text-style-color-expected.png:
* platform/qt/fast/forms/text-style-color-expected.txt:
* platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
* platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.png:
* platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
* platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.png:
* platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
* platform/qt/fast/forms/textarea-scrollbar-expected.png:
* platform/qt/fast/forms/textarea-scrollbar-expected.txt:
* platform/qt/fast/forms/textarea-scrolled-type-expected.png:
* platform/qt/fast/forms/textarea-scrolled-type-expected.txt:
* platform/qt/fast/forms/textfield-focus-ring-expected.png:
* platform/qt/fast/forms/textfield-focus-ring-expected.txt:
* platform/qt/fast/forms/textfield-outline-expected.png:
* platform/qt/fast/forms/textfield-outline-expected.txt:
* platform/qt/fast/forms/textfield-overflow-by-value-update-expected.txt:
* platform/qt/fast/forms/textfield-overflow-expected.png:
* platform/qt/fast/forms/textfield-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] svg/transforms tests needs update after rebaseline and new testfonts
commit-queue@webkit.org [Tue, 17 Jul 2012 22:08:52 +0000 (22:08 +0000)]
[Qt] svg/transforms tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91501

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-17
Reviewed by Alexis Menard.

Updated expected Qt results for most svg/transforms layout tests, after testfonts changes made by bug 85203.

* platform/qt-5.0/Skipped:
* platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.png:
* platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
* platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
* platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
* platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.txt:
* platform/qt/svg/transforms/svg-css-transforms-clip-path-expected.png:
* platform/qt/svg/transforms/svg-css-transforms-clip-path-expected.txt:
* platform/qt/svg/transforms/svg-css-transforms-expected.png:
* platform/qt/svg/transforms/svg-css-transforms-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Remove unnecessary clearWindow() calls and the method itself
jpetsovits@rim.com [Tue, 17 Jul 2012 21:47:50 +0000 (21:47 +0000)]
[BlackBerry] Remove unnecessary clearWindow() calls and the method itself
https://bugs.webkit.org/show_bug.cgi?id=91540
RIM PR 174365

Reviewed by Adam Treat.

If we resume the backingstore right afterwards with
RenderAndBlit then that'll fill the whole visible area
with content, making a clearWindow() call unnecessary.
This call is a remnant from ages ago, and is well suited
to disappear into nothingness.

(There is still a clearWindow() call, with rect argument,
which we continue using. This commit only removes the
rect-less version.)

* Api/BackingStore.cpp:
* Api/BackingStore_p.h:
(BackingStorePrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove zero-length-subpaths from RenderSVGShape to RenderSVGPath
pdr@google.com [Tue, 17 Jul 2012 21:43:02 +0000 (21:43 +0000)]
Move zero-length-subpaths from RenderSVGShape to RenderSVGPath
https://bugs.webkit.org/show_bug.cgi?id=90716

Reviewed by Nikolas Zimmermann.

Previously zero-length-subpath code was present in RenderSVGShape but it is
only needed in RenderSVGPath. This patch moves the zero-length-subpath code
to RenderSVGPath.

In this change, we gain:
1) Ellipses, Circles, and Rects will no longer carry an empty Vector nor
   checks for zero-length subpaths which (per the spec) they cannot have.
2) RenderSVGShape, the superclass of all shape rendering, has been
   drastically simplified by removing 70 lines of code that only applies
   to Path rendering. This generally aids in code understandability.

The patch is primarily a straightforward code move but useStrokeStyleToFill
needs further explanation:
Zero-length-subpaths are drawn using rectangular and circular paths which
are filled.
Previously in RenderSVGShape::fillAndStrokePath, strokePath was called for
the main path with ApplyToStrokeMode and then strokePath was called for
each zero-length-subpath with ApplyToFillMode.
ApplyToFillMode had the effect of setting the context's stroke style to
the fill style so zero-length-subpaths were "filled" with the stroke style.
After this patch, the context is only setup once (which is faster!) using
ApplyToStrokeMode so we manually set the stroke style to the fill style
using useStrokeStyleToFill.

No new tests, just a refactoring.

* rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::updateShapeFromElement):
(WebCore):
(WebCore::RenderSVGPath::calculateUpdatedStrokeBoundingBox):
(WebCore::useStrokeStyleToFill):
(WebCore::RenderSVGPath::strokeShape):
(WebCore::RenderSVGPath::shapeDependentStrokeContains):
(WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGPath::zeroLengthLinecapPath):
(WebCore::RenderSVGPath::zeroLengthSubpathRect):
(WebCore::RenderSVGPath::updateZeroLengthSubpaths):
* rendering/svg/RenderSVGPath.h:
(RenderSVGPath):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore::RenderSVGShape::strokeShape):
(WebCore::RenderSVGShape::strokeContains):
(WebCore):
(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::fillAndStrokeShape):
(WebCore::RenderSVGShape::paint):
(WebCore::RenderSVGShape::calculateStrokeBoundingBox):
* rendering/svg/RenderSVGShape.h:
(WebCore::RenderSVGShape::hasPath):
(WebCore::RenderSVGShape::hasNonScalingStroke):
(RenderSVGShape):
(WebCore::RenderSVGShape::strokeBoundingBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122875 268f45cc-cd09-0410-ab3c-d52691b4dbfc