WebKit-https.git
12 years ago2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 5 Mar 2009 22:58:55 +0000 (22:58 +0000)]
2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=24355
        Add InspectorController.idl and convert InspectorController.cpp to use
        JSC bindings.

        * DerivedSources.make: Added InspectorController.idl
        * WebCore.xcodeproj/project.pbxproj: Added idl, bindings files.
        * bindings/js/JSInspectorControllerCustom.cpp: Added.
        * bindings/scripts/CodeGeneratorJS.pm: Added Array to no-header types.
        * inspector/InspectorController.cpp: Removed hand-rolled bindings.
        * inspector/InspectorController.h: Added platform and addSourceToFrame methods.
        * inspector/InspectorController.idl: Added.
        * page/Page.h: Changed member to RefPtr since InspectorController is now ref-counted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 5 Mar 2009 22:56:52 +0000 (22:56 +0000)]
2009-03-05  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24400
        Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
        media element attributes

        Test: media/video-loop.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement):
        (WebCore::HTMLMediaElement::loadInternal):
        (WebCore::HTMLMediaElement::setNetworkState):
        (WebCore::HTMLMediaElement::seek):
        (WebCore::HTMLMediaElement::playInternal):
        (WebCore::HTMLMediaElement::loop):
        (WebCore::HTMLMediaElement::setLoop):
        (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
        (WebCore::HTMLMediaElement::endedPlayback):
        (WebCore::HTMLMediaElement::updatePlayState):
        * html/HTMLMediaElement.h:
        * html/HTMLMediaElement.idl:

2009-03-05  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24400
        Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
        media element attributes

        * media/loopend-limits-expected.txt: Removed.
        * media/loopend-limits.html: Removed.
        * media/loopstart-limits-expected.txt: Removed.
        * media/loopstart-limits.html: Removed.
        * media/video-dom-end-expected.txt: Removed.
        * media/video-dom-end.html: Removed.
        * media/video-dom-loopcount-expected.txt: Removed.
        * media/video-dom-loopcount.html: Removed.
        * media/video-dom-loopend-expected.txt: Removed.
        * media/video-dom-loopend.html: Removed.
        * media/video-dom-loopstart-expected.txt: Removed.
        * media/video-dom-loopstart.html: Removed.
        * media/video-dom-start-expected.txt: Removed.
        * media/video-dom-start.html: Removed.
        * media/video-end-expected.txt: Removed.
        * media/video-end.html: Removed.
        * media/video-loop.html: Added, test for new "loop" attribute.
        * media/video-loopcount-expected.txt: Removed.
        * media/video-loopcount.html: Removed.
        * media/video-loopend-expected.txt: Removed.
        * media/video-loopend.html: Removed.
        * media/video-loopstart-expected.txt: Removed.
        * media/video-loopstart.html: Removed.
        * media/video-seek-past-end-paused-expected.txt: Updated for loop changes, add more tests.
        * media/video-seek-past-end-paused.html: Ditto.
        * media/video-seek-past-end-playing-expected.txt: Ditto.
        * media/video-seek-past-end-playing.html: Ditto.
        * media/video-start-expected.txt: Removed.
        * media/video-start.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago <rdar://problem/6651112> Safari asks about re-posting a form even when page...
sfalken@apple.com [Thu, 5 Mar 2009 22:16:19 +0000 (22:16 +0000)]
    <rdar://problem/6651112> Safari asks about re-posting a form even when page is cached

        Reviewed by Ada Chan.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::willLoadFromCache): Ported from Mac version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 5 Mar 2009 22:11:51 +0000 (22:11 +0000)]
2009-03-05  Pamela Greene  <pam@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add test for potential crash in window.frames.length
        https://bugs.webkit.org/show_bug.cgi?id=24339

        * fast/dom/Window/window-collection-length-no-crash-expected.txt: Added.
        * fast/dom/Window/window-collection-length-no-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 5 Mar 2009 20:37:03 +0000 (20:37 +0000)]
2009-03-05  David Hyatt  <hyatt@apple.com>

        Reviewed by Eric Seidel

        https://bugs.webkit.org/show_bug.cgi?id=24248

        Make sure painting of overflow controls checks that visibility:visible is set on the block before
        painting.  Pixel tests caught this regression.

        Make sure resizer painting pushes a clip of the corner rect.  It was relying on the clip layers happened
        to do to their bounds (which had nothing to do with overflow).

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintResizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Thu, 5 Mar 2009 19:58:19 +0000 (19:58 +0000)]
2009-03-05  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24386
        A faster implementation of extractMIMETypeFromMediaType.

        * platform/network/HTTPParsers.cpp:
        (WebCore::extractMIMETypeFromMediaType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Thu, 5 Mar 2009 19:58:10 +0000 (19:58 +0000)]
2009-03-05  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Antti Koivisto.

        https://bugs.webkit.org/show_bug.cgi?id=24392
        Do not get the current time for unless we're doing PRELOAD_DEBUG as this
        can be unnecessarily expensive.

        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 5 Mar 2009 19:39:48 +0000 (19:39 +0000)]
2009-03-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24327

        When mapping points and hit testing through transforms, work
        correctly when acclerated animations of transforms are running.

        Tested by LayoutTests/animations/animation-hit-test-transform.html,
        which only failed when ACCELERATED_COMPOSITING was turned on.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::currentTransform):
        * rendering/RenderLayer.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::transformFromContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Mike Belshe <mike@belshe.com>
darin@chromium.org [Thu, 5 Mar 2009 19:17:16 +0000 (19:17 +0000)]
2009-03-05  Mike Belshe  <mike@belshe.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24391
        Frame.cpp uses JSC specific includes

        * page/Frame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 5 Mar 2009 18:40:21 +0000 (18:40 +0000)]
2009-03-05  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24389
        WebKitGTK+ crashes when cancelling plugin loads

        Remove bogus calls to the client's didFinishLoading method from
        our ResourceHandle::cancel implementation. Calling
        didFinishLoading here is mostly inoffensive for most loads, but
        causes crashes when plugin loads are cancelled.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Thu, 5 Mar 2009 18:34:30 +0000 (18:34 +0000)]
2009-03-05  Steve Falkenburg  <sfalken@apple.com>

        Windows build fix.

        * WebCore.vcproj/QTMovieWin.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Thu, 5 Mar 2009 18:16:33 +0000 (18:16 +0000)]
2009-03-05  Adam Treat  <adam.treat@torchmobile.com>

        Build fix for when ENABLE_NETSCAPE_PLUGIN_API = 0.  The method
        ScriptController::jsObjectForPluginElement(HTMLPlugInElement*); is not
        protected by an #if and uses HTMLPlugInElement so it must be included.

        * bindings/js/ScriptController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 5 Mar 2009 17:34:38 +0000 (17:34 +0000)]
2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>

        GTK Build fix.

        * inspector/ConsoleMessage.h: Use proper header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 5 Mar 2009 17:14:07 +0000 (17:14 +0000)]
2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=24376
        Split InspectorController.cpp file into separate classes.

        * GNUmakefile.am: Modified to include new files.
        * WebCore.pro: Ditto.
        * WebCore.scons: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.
        * inspector/ConsoleMessage.cpp: Added.
        * inspector/ConsoleMessage.h: Added.
        * inspector/InspectorController.cpp:
        * inspector/InspectorDOMStorageResource.cpp: Added.
        * inspector/InspectorDOMStorageResource.h: Added.
        * inspector/InspectorDatabaseResource.cpp: Added.
        * inspector/InspectorDatabaseResource.h: Added.
        * inspector/InspectorResource.cpp: Added.
        * inspector/InspectorResource.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 5 Mar 2009 17:12:08 +0000 (17:12 +0000)]
2009-03-05  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=24387
        Remove media element bufferingRate attribute. No test necessary as there
        were none for this attribute.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Don't initialize m_bufferingRate.
        (WebCore::HTMLMediaElement::loadInternal): Ditto.
        (WebCore::HTMLMediaElement::setNetworkState): Ditto.
        (WebCore::HTMLMediaElement::progressEventTimerFired): Don't calculate m_bufferingRate.
        * html/HTMLMediaElement.h: Remove m_bufferingRate.
        * html/HTMLMediaElement.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Xan Lopez <xan@gnome.org>
xan@webkit.org [Thu, 5 Mar 2009 12:47:28 +0000 (12:47 +0000)]
2009-03-05  Xan Lopez  <xan@gnome.org>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=24377
        [GTK] Comply better with coding style guidelines in ResourceHandleSoup

        Use C++ booleans, 0 instead of NULL, prefix boolean variables with
        'is', do not use 'else if' if the previous if had a return, delete
        trailing whitespace, etc.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
        (WebCore::fillResponseFromMessage):
        (WebCore::restartedCallback):
        (WebCore::finishedCallback):
        (WebCore::parseDataUrl):
        (WebCore::ensureSessionIsInitialized):
        (WebCore::ResourceHandle::startHttp):
        (WebCore::reportUnknownProtocolError):
        (WebCore::ResourceHandle::start):
        (WebCore::cleanupGioOperation):
        (WebCore::closeCallback):
        (WebCore::readCallback):
        (WebCore::openCallback):
        (WebCore::queryInfoCallback):
        (WebCore::ResourceHandle::startGio):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-05 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 5 Mar 2009 10:06:49 +0000 (10:06 +0000)]
2009-03-05  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] NPAPI plugins are supported, adjust the API documentation.

        * Api/qwebsettings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the build.
mrowe@apple.com [Thu, 5 Mar 2009 08:05:03 +0000 (08:05 +0000)]
Fix the build.

Sprinkle "static" around NumberConstructor.cpp in order to please the compiler.

* runtime/NumberConstructor.cpp:
(JSC::numberConstructorNaNValue):
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
(JSC::numberConstructorMaxValue):
(JSC::numberConstructorMinValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6206172> Adoption of new Cocoa API for dictionary contextual menu
mrowe@apple.com [Thu, 5 Mar 2009 07:28:07 +0000 (07:28 +0000)]
<rdar://problem/6206172> Adoption of new Cocoa API for dictionary contextual menu

Reviewed by Dan Bernstein.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _lookUpInDictionaryFromMenu:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6354858> FastMallocZone's enumeration code reports fragmented adminis...
mrowe@apple.com [Thu, 5 Mar 2009 06:04:18 +0000 (06:04 +0000)]
<rdar://problem/6354858> FastMallocZone's enumeration code reports fragmented administration space

Reviewed by Oliver Hunt.

The handling of MALLOC_ADMIN_REGION_RANGE_TYPE in FastMalloc's zone was incorrect.  It was attempting
to record the memory containing and individual span as an administrative region, when all memory
allocated via MetaDataAlloc should in fact be recorded.  This was causing memory regions allocated
via MetaDataAlloc to appear as "VM_ALLOCATE ?" in vmmap output.  They are now correctly reported as
"MALLOC_OTHER" regions associated with the JavaScriptCore FastMalloc zone.

Memory is allocated via MetaDataAlloc from two locations: PageHeapAllocator, and TCMalloc_PageMap{2,3}.
These two cases are handled differently.

PageHeapAllocator is extended to keep a linked list of memory regions that it has allocated.  The
first object in an allocated region contains the link to the previously allocated region. To record
the administrative regions of a PageHeapAllocator we can simply walk the linked list and record
each allocated region we encounter.

TCMalloc_PageMaps allocate memory via MetaDataAlloc to store each level of the radix tree.  To record
the administrative regions of a TCMalloc_PageMap we walk the tree and record the storage used for nodes
at each position rather than the nodes themselves.

A small performance improvement is achieved by coalescing adjacent memory regions inside the PageMapMemoryUsageRecorder
so that fewer calls in to the range recorder are necessary.  We further reduce the number of calls to the
range recorder by aggregating the in-use ranges of a given memory region into a local buffer before recording
them with a single call.  A similar approach is also used by AdminRegionRecorder.

* wtf/FastMalloc.cpp:
(WTF::PageHeapAllocator::Init):
(WTF::PageHeapAllocator::New):
(WTF::PageHeapAllocator::recordAdministrativeRegions):
(WTF::TCMallocStats::FreeObjectFinder::isFreeObject):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::~PageMapMemoryUsageRecorder):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::recordPendingRegions):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit):
(WTF::TCMallocStats::AdminRegionRecorder::AdminRegionRecorder):
(WTF::TCMallocStats::AdminRegionRecorder::recordRegion):
(WTF::TCMallocStats::AdminRegionRecorder::visit):
(WTF::TCMallocStats::AdminRegionRecorder::recordPendingRegions):
(WTF::TCMallocStats::AdminRegionRecorder::~AdminRegionRecorder):
(WTF::TCMallocStats::FastMallocZone::enumerate):
(WTF::TCMallocStats::FastMallocZone::FastMallocZone):
(WTF::TCMallocStats::FastMallocZone::init):
* wtf/TCPageMap.h:
(TCMalloc_PageMap2::visitValues):
(TCMalloc_PageMap2::visitAllocations):
(TCMalloc_PageMap3::visitValues):
(TCMalloc_PageMap3::visitAllocations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded a few more tests to ubench
oliver@apple.com [Thu, 5 Mar 2009 03:10:16 +0000 (03:10 +0000)]
Added a few more tests to ubench

RS=Gavin Barraclough

Adding a couple of test to cover too few and too many arguments.  This
is needed to prevent regressions in all call paths from my current refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 5 Mar 2009 02:36:05 +0000 (02:36 +0000)]
2009-03-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        https://bugs.webkit.org/show_bug.cgi?id=24328

        If an element has backface-visibility: hidden, hit testing should not
        hit the back sides of elements. Test for that by inverting the accumulated
        transform and looking at the z vector.

        Tested by transforms/3d/hit-testing/backface-hit-test.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 5 Mar 2009 02:11:26 +0000 (02:11 +0000)]
2009-03-04  Simon Fraser  <simon.fraser@apple.com>

        Rubber-stamped by Eric Seidel.

        New layout tests for point mapping and hit testing through 3d transforms.
        Not run by default yet.

        * platform/mac/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt: Added.
        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
        * transforms/3d/cssmatrix-3d-interface-expected.txt: Added.
        * transforms/3d/cssmatrix-3d-interface.xhtml: Added.
        * transforms/3d/hit-testing/backface-hit-test.html: Added.
        * transforms/3d/point-mapping/3d-point-mapping-2.html: Added.
        * transforms/3d/point-mapping/3d-point-mapping-deep.html: Added.
        * transforms/3d/point-mapping/3d-point-mapping-origins.html: Added.
        * transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html: Added.
        * transforms/3d/point-mapping/3d-point-mapping.html: Added.
        * transforms/3d/point-mapping/point-mapping-helpers.js: Added.
        (mousemoved):
        (dispatchEvent):
        (clicked):
        (log):
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-04 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 5 Mar 2009 01:13:05 +0000 (01:13 +0000)]
2009-03-04  Eric Carlson  <eric.carlson@apple.com>

        - Correct bogus result checked in as part of r41432.

        * media/video-can-play-type-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-04 Adam Langley <agl@google.com>
eric@webkit.org [Thu, 5 Mar 2009 00:57:14 +0000 (00:57 +0000)]
2009-03-04  Adam Langley  <agl@google.com>

        Reviewed by Darin Fisher.

        r41362 mistakenly added functions "RenderThemeWin::" into
        RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
        them to void return types. This patch switches them back to ints.

        https://bugs.webkit.org/show_bug.cgi?id=24360

        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft):
        (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight):
        (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop):
        (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-04 Adam Langley <agl@google.com>
eric@webkit.org [Thu, 5 Mar 2009 00:57:10 +0000 (00:57 +0000)]
2009-03-04  Adam Langley  <agl@google.com>

        Reviewed by Darin Fisher.

        Chromium Linux: change some metrics to better match Windows after
        r41416. Aesthetically this may be worse, but web-compat is king.

        Also, the previous code had an off by one error when drawing
        scrollbars which caused the scrollbar to overflow it's bounds by 1px
        at the right and bottom edges.

        https://bugs.webkit.org/show_bug.cgi?id=24369

        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::):
        (WebCore::RenderThemeChromiumLinux::systemFont):
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromium::paintTrackPiece):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-04 Pamela Greene <pam@chromium.org>
pam@chromium.org [Wed, 4 Mar 2009 23:48:34 +0000 (23:48 +0000)]
2009-03-04  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Fisher.

        Add test to ensure that window.frames is self-referential
        https://bugs.webkit.org/show_bug.cgi?id=24341

        * fast/dom/Window/window-frames-self-referential-expected.txt: Added.
        * fast/dom/Window/window-frames-self-referential.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
eric@webkit.org [Wed, 4 Mar 2009 22:58:23 +0000 (22:58 +0000)]
    Reviewed by Adam Roben.

        Add an ASSERT to better demonstrate the cause of the crash in
        https://bugs.webkit.org/show_bug.cgi?id=23736

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::~DocLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
levin@chromium.org [Wed, 4 Mar 2009 22:29:54 +0000 (22:29 +0000)]
WebCore:

2009-03-04  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
        <https://bugs.webkit.org/show_bug.cgi?id=24337>

        Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
               http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html

        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::willCacheResponse):
        An identifier is only asssigned if resource load callbacks are done.  So don't send
        willCacheResponse which uses identifier if resource load callbacks aren't being sent.

LayoutTests:

2009-03-04  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
        <https://bugs.webkit.org/show_bug.cgi?id=24337>

        * http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html: Added.
        * http/tests/xmlhttprequest/workers/resources/xmlhttprequest-file-not-found.js: Added.
        (log):
        (done):
        * http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found-expected.txt: Added.
        * http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
levin@chromium.org [Wed, 4 Mar 2009 22:29:46 +0000 (22:29 +0000)]
WebCore:

2009-03-04  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
        <https://bugs.webkit.org/show_bug.cgi?id=24330>

        Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html

        * dom/ExceptionCode.cpp:
        (WebCore::xmlHttpRequestExceptionNames):
        Added missing ABORT_ERR whose absence caused an assert.

        * loader/WorkerThreadableLoader.cpp:
        (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
        Add more logic to handle the termination case for sync xhr.

LayoutTests:

2009-03-04  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
        <https://bugs.webkit.org/show_bug.cgi?id=24330>

        Added test to verify to terminate a worker while it is doing a synchronous xhr.
        It does not verify that the exception is a ABORT_ERR because I couldn't figure out a way
        to actually do this.

        * http/tests/xmlhttprequest/workers/abort-exception-assert-expected.txt: Added.
        * http/tests/xmlhttprequest/workers/abort-exception-assert.html: Added.
        * http/tests/xmlhttprequest/workers/resources/endless-response.php: Copied from LayoutTests/http/tests/xmlhttprequest/resources/endlessxml.php.
        * http/tests/xmlhttprequest/workers/resources/endless-sync-xhr.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-04 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 4 Mar 2009 22:21:16 +0000 (22:21 +0000)]
2009-03-04  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Antti Koivisto.

        https://bugs.webkit.org/show_bug.cgi?id=24364
        Add support for HTMLMediaElement canPlayType method. Make
        MediaPlayer::supportsType take a ContentType instead of a
        separate mime type and codecs parameter.

        Test: media/video-can-play-type.html

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method.
        (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType.
        (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type.
        (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
        * html/HTMLMediaElement.h: Add prototype.
        * html/HTMLMediaElement.idl: Ditto.
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type.
        (WebCore::MediaPlayer::supportsType): Ditto.
        * platform/graphics/MediaPlayer.h:

2009-03-04  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Antti Koivisto.

        https://bugs.webkit.org/show_bug.cgi?id=24364
        Test HTMLMediaElement canPlayType method.

        * media/video-can-play-type-expected.txt: Added.
        * media/video-can-play-type.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
antti@apple.com [Wed, 4 Mar 2009 22:01:38 +0000 (22:01 +0000)]
JavaScriptCore:

2009-03-04  Antti Koivisto  <antti@apple.com>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=24359
        Repaint throttling mechanism

        Set ENABLE_REPAINT_THROTTLING to 0 by default.

        * wtf/Platform.h:

WebCore:

2009-03-04  Antti Koivisto  <antti@apple.com>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=24359
        Repaint throttling mechanism

        Excessive repainting can slow down page loadind. This implements a timer
        based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not
        enabled by default.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkCompleted):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchDragEvent):
        (WebCore::EventHandler::dispatchMouseEvent):
        (WebCore::EventHandler::keyEvent):
        (WebCore::EventHandler::handleTextInputEvent):
        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        (WebCore::FrameView::reset):
        (WebCore::FrameView::repaintContentRectangle):
        (WebCore::FrameView::beginDeferredRepaints):
        (WebCore::FrameView::endDeferredRepaints):
        (WebCore::FrameView::checkStopDelayingDeferredRepaints):
        (WebCore::FrameView::doDeferredRepaints):
        (WebCore::FrameView::updateDeferredRepaintDelay):
        (WebCore::FrameView::resetDeferredRepaintDelay):
        (WebCore::FrameView::adjustedDeferredRepaintDelay):
        (WebCore::FrameView::deferredRepaintTimerFired):
        (WebCore::FrameView::paintContents):
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 4 Mar 2009 21:53:36 +0000 (21:53 +0000)]
2009-03-04  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Antti Koivisto.

        Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        (WebCore::Document::haveStylesheetsLoaded):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptHandler):
        * loader/Cache.cpp:
        (WebCore::Cache::requestResource):
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::checkNotify):
        * loader/DocLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::requestFrame):
        (WebCore::FrameLoader::stopLoading):
        (WebCore::FrameLoader::begin):
        (WebCore::FrameLoader::write):
        (WebCore::FrameLoader::endIfNotLoadingMainResource):
        (WebCore::FrameLoader::checkCompleted):
        (WebCore::FrameLoader::requestObject):
        (WebCore::FrameLoader::loadItem):
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-04 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 4 Mar 2009 21:24:16 +0000 (21:24 +0000)]
2009-03-04  Kevin McCullough  <kmccullough@apple.com>

        - Build bot fix.

        * fast/profiler/many-calls-in-the-same-scope-expected.txt:
        * fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
        * fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
        * fast/profiler/nested-start-and-stop-profiler-expected.txt:
        * fast/profiler/profile-calls-in-included-file-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Xan Lopez <xan@gnome.org>
xan@webkit.org [Wed, 4 Mar 2009 20:57:38 +0000 (20:57 +0000)]
2009-03-02  Xan Lopez  <xan@gnome.org>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=24287
        [GTK] Move auth dialog feature to WebKit/

        Add WebKitSoupAuthDialog files to build.

        * GNUmakefile.am:

WebCore:

2009-03-02  Xan Lopez  <xan@gnome.org>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=24287
        [GTK] Move auth dialog feature to WebKit/

        Remove WebKitSoupAuthDialog files from build and stop using it.

        * GNUmakefile.am:
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ensureSessionIsInitialized):
        * platform/network/soup/webkit-soup-auth-dialog.c: Removed.
        * platform/network/soup/webkit-soup-auth-dialog.h: Removed.

WebKit/gtk:

2009-03-02  Xan Lopez  <xan@gnome.org>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=24287
        [GTK] Move auth dialog feature to WebKit/

        Add WebKitSoupAuthDialog and add it to the session in webkit_init.

        * webkit/webkitprivate.cpp:
        (currentToplevelCallback):
        (webkit_init):
        * webkit/webkitsoupauthdialog.c: Added.
        (webkit_soup_auth_dialog_class_init):
        (webkit_soup_auth_dialog_init):
        (webkit_soup_auth_dialog_session_feature_init):
        (free_authData):
        (set_password_callback):
        (response_callback):
        (table_add_entry):
        (show_auth_dialog):
        (find_password_callback):
        (session_authenticate):
        (attach):
        * webkit/webkitsoupauthdialog.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 4 Mar 2009 19:58:46 +0000 (19:58 +0000)]
2009-03-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24361

        Reinstate code that sets result.innerNode when hitTest() returns true,
        but never filled in the innerNode. Fixes hit testing of generated content.

        Test: fast/css-generated-content/hit-test-generated-content.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
abarth@webkit.org [Wed, 4 Mar 2009 19:56:27 +0000 (19:56 +0000)]
WebCore:

2009-03-04  Adam Barth  <abath@webkit.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24356

        Fix WebKit style for allowUniversalAccessFromFileURLs.

        * WebCore.base.exp:
        * dom/Document.cpp:
        (WebCore::Document::initSecurityContext):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
        * page/Settings.h:
        (WebCore::Settings::allowUniversalAccessFromFileURLs):

WebKit/mac:

2009-03-04  Adam Barth  <abath@webkit.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24356

        Fix WebKit style for allowUniversalAccessFromFileURLs.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences allowUniversalAccessFromFileURLs]):
        (-[WebPreferences setAllowUniversalAccessFromFileURLs:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

WebKit/qt:

2009-03-04  Adam Barth  <abath@webkit.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24356

        Fix WebKit style for allowUniversalAccessFromFileURLs.

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):

WebKit/win:

2009-03-04  Adam Barth  <abath@webkit.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24356

        Fix WebKit style for allowUniversalAccessFromFileURLs.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::allowUniversalAccessFromFileURLs):
        (WebPreferences::setAllowUniversalAccessFromFileURLs):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-04 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 4 Mar 2009 18:25:50 +0000 (18:25 +0000)]
2009-03-04  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.

        I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
        consolidated some of the various decision making pieces of the Cache into the new method
        FrameLoader::cachePolicy().

        Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader
        is reloading.  If it is, we'd evict any existing resource then recreate it.  Quick looks uses the
        same URL for this image every time and expects it to be reloaded with each new card.

        The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
        is "ReloadIgnoringCacheData".  This check was lost in the consolidation to the new method.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible
          condition for returning CachePolicyReload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * English.lproj/localizedStrings.js: Update strings to include "DATABASES",
timothy@apple.com [Wed, 4 Mar 2009 17:59:18 +0000 (17:59 +0000)]
    * English.lproj/localizedStrings.js: Update strings to include "DATABASES",
        "LOCAL STORAGE" and "SESSION STORAGE".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a regression where the Web Inspector console would not animate
timothy@apple.com [Wed, 4 Mar 2009 17:59:07 +0000 (17:59 +0000)]
    Fix a regression where the Web Inspector console would not animate
        in or out correctly.

        Reviewed by Anders Carlsson.

        * inspector/front-end/inspector.css: Move a z-index to a child element
        to get the correct stacking order during the animation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Wed, 4 Mar 2009 17:56:41 +0000 (17:56 +0000)]
WebCore:

2009-03-03  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.

        Make sure to factor clear deltas into y position estimates.  Also avoid doing the comparison of
        the final position against the y position estimate until after the clear has happened.  This gets rid
        of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.

        Reviewed by Dan Bernstein

        Added fast/block/float/nested-clearance.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::collapseMargins):
        (WebCore::RenderBlock::clearFloatsIfNeeded):
        (WebCore::RenderBlock::estimateVerticalPosition):
        (WebCore::RenderBlock::layoutBlockChildren):
        (WebCore::RenderBlock::getClearDelta):
        * rendering/RenderBlock.h:

LayoutTests:

2009-03-03  David Hyatt  <hyatt@apple.com>

        Test case for https://bugs.webkit.org/show_bug.cgi?id=24201

        Reviewed by Dan Bernstein

        * fast/block/float/nested-clearance.html: Added.
        * platform/mac/fast/block/float/nested-clearance-expected.checksum: Added.
        * platform/mac/fast/block/float/nested-clearance-expected.png: Added.
        * platform/mac/fast/block/float/nested-clearance-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 4 Mar 2009 17:39:14 +0000 (17:39 +0000)]
2009-03-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24340

        Expose AllowUniversalAccessFromFileUrls to Qt clients.

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
        (QWebSettings::QWebSettings):
        * Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Kim Grönholm <kim.gronholm@nomovok.com>
hausmann@webkit.org [Wed, 4 Mar 2009 14:42:32 +0000 (14:42 +0000)]
2009-03-02  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Simon Hausmann.

        Improvement to 3d transformations rendering in QtWebKit. QTransform is used
        instead of QMatrix. This allows perspective transformations since QTransform is
        a true 3x3 matrix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Wed, 4 Mar 2009 14:21:43 +0000 (14:21 +0000)]
2009-02-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=24151
        Fix Qt/S60 build break

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Mike Belshe <mike@belshe.com>
darin@chromium.org [Wed, 4 Mar 2009 07:20:07 +0000 (07:20 +0000)]
2009-03-03  Mike Belshe  <mike@belshe.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=21939
        Uninitialized ExceptionCode in DOMWindow::postMessage

        * dom/MessagePort.cpp:
        (WebCore::MessagePort::postMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago <rdar://problem/6581203> WebCore and WebKit should install the same set of...
ddkilzer@apple.com [Wed, 4 Mar 2009 06:49:29 +0000 (06:49 +0000)]
    <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase

        Reviewed by Mark Rowe.

JavaScriptCore:

        * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based
        on PLATFORM_NAME to work around the missing definition on Tiger.
        Updated HAVE_DTRACE to use REAL_PLATFORM_NAME.

WebCore:

        The fix is to add INSTALLHDRS_COPY_PHASE = YES and
        INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
        sure various build phase scripts work with the installhdrs build
        phase.

        * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
        based on PLATFORM_NAME to work around the missing definition on
        Tiger.
        * Configurations/WebCore.xcconfig: Added
        JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in
        the "Generate Derived Sources" script.  Added
        INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.

        * WebCore.xcodeproj/project.pbxproj:
        - Added shell code to prevent running "Check For Global
          Initializers", "Check For Exit Time Destructors" and "Check
          For Weak VTables" scripts during the installhdrs build phase.
        - Made "Generate Derived Sources" work for the installhdrs build
          phase.  Also simplified setting of CREATE_HASH_TABLE by using
          JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.

WebKit:

        The fix is to add INSTALLHDRS_COPY_PHASE = YES and
        INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
        make sure various build phase scripts work with the installhdrs
        build phase.

        * WebKit.xcodeproj/project.pbxproj:
        - Added shell code to prevent running "Check For Global
          Initializers", "Check For Exit Time Destructors" and "Check
          For Weak VTables" scripts during the installhdrs build phase.
        - Removed UMBRELLA_FRAMEWORKS_DIR from the Debug and Release
          targets since it's no longer needed after defining
          WEBCORE_PRIVATE_HEADERS_DIR in WebKit.xcconfig.

WebKit/mac:

        The fix is to add INSTALLHDRS_COPY_PHASE = YES and
        INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
        make sure various build phase scripts work with the installhdrs
        build phase.

        * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
        based on PLATFORM_NAME to work around the missing definition on
        Tiger.
        * Configurations/WebKit.xcconfig: Added
        WEBCORE_PRIVATE_HEADERS_DIR variable to remove definition of
        UMBRELLA_FRAMEWORKS_DIR for Debug and Release builds in the
        Xcode project file.  Added INSTALLHDRS_COPY_PHASE = YES and
        INSTALLHDRS_SCRIPT_PHASE = YES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Adam Langley <agl@google.com>
darin@chromium.org [Wed, 4 Mar 2009 06:09:20 +0000 (06:09 +0000)]
2009-03-02  Adam Langley  <agl@google.com>

        Reviewed by Darin Fisher.

        Chromium Linux: Switch to using Skia to render widgets.

        In order to sandbox the Chromium renderer on Linux we need to remove
        the X connection. GTK cannot render without an X connection so, for
        now, we render widgets ourselves.

        Previously didn't use anti-alias fonts in order to match Windows font
        rendering exactly. This was helpful when bootstrapping our layout
        tests. Now, however, we are ready to enable it.

        https://bugs.webkit.org/show_bug.cgi?id=24244

        * platform/chromium/ScrollbarThemeChromium.cpp:
        (WebCore::ScrollbarThemeChromium::buttonSize):
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromium::scrollbarThickness):
        (WebCore::ScrollbarThemeChromium::paintTrackPiece):
        (WebCore::ScrollbarThemeChromium::paintButton):
        (WebCore::ScrollbarThemeChromium::paintThumb):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::setupPaint):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::PlatformContextSkia):
        (PlatformContextSkia::~PlatformContextSkia):
        * platform/graphics/skia/PlatformContextSkia.h:
        * rendering/RenderThemeChromiumGtk.cpp: Removed.
        * rendering/RenderThemeChromiumGtk.h: Removed.
        * rendering/RenderThemeChromiumLinux.cpp: Added.
        * rendering/RenderThemeChromiumLinux.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 4 Mar 2009 05:39:44 +0000 (05:39 +0000)]
2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24261
        Fix return types.

        Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg

        * bindings/v8/V8Binding.h:
        (WebCore::toInt32): change return type to int
        (WebCore::toFloat): change return type to float.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Wed, 4 Mar 2009 01:10:12 +0000 (01:10 +0000)]
WebCore:

2009-03-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        https://bugs.webkit.org/show_bug.cgi?id=22884
        <rdar://problem/6449783>
        modified layout test crashes Safari

        Null check NPStream before dereferencing it.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::destroyStream):

WebKitTools:

2009-03-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        https://bugs.webkit.org/show_bug.cgi?id=22884
        <rdar://problem/6449783>
        modified layout test crashes Safari

        Add destroyNullStream test function to the test plug-in.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (destroyNullStream):
        (pluginInvoke):

LayoutTests:

2009-03-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        https://bugs.webkit.org/show_bug.cgi?id=22884
        <rdar://problem/6449783>
        modified layout test crashes Safari

        Update tests.
        * plugins/destroy-stream-twice-expected.txt:
        * plugins/destroy-stream-twice.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 4 Mar 2009 01:06:50 +0000 (01:06 +0000)]
2009-03-03  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24294
        Bug 24294: Improve media layout test logging

        Make all media layout tests log the condition that is being tested,
        success or failure, plus observed value when a test condition fails
        so it is possible to see exactly what failed without having to hack
        the test source. Consolidate some of the logic in the shared JavaScript file.

        * media/audio-constructor-expected.txt:
        * media/audio-constructor-src-expected.txt:
        * media/audio-constructor-src.html:
        * media/audio-constructor.html:
        * media/audio-mpeg-supported-expected.txt:
        * media/audio-mpeg-supported.html:
        * media/broken-video-expected.txt:
        * media/broken-video.html:
        * media/constructors-expected.txt:
        * media/constructors.html:
        * media/loopend-limits-expected.txt:
        * media/loopstart-limits-expected.txt:
        * media/progress-event-expected.txt:
        * media/progress-event-total-expected.txt:
        * media/progress-event-total.html:
        * media/progress-event.html:
        * media/remove-from-document-expected.txt:
        * media/remove-from-document-no-load-expected.txt:
        * media/remove-from-document-no-load.html:
        * media/remove-from-document.html:
        * media/unsupported-rtsp-expected.txt:
        * media/unsupported-rtsp.html:
        * media/unsupported-tracks-expected.txt:
        * media/unsupported-tracks.html:
        * media/video-append-source-expected.txt:
        * media/video-append-source.html:
        * media/video-autoplay-expected.txt:
        * media/video-autoplay.html:
        * media/video-buffered-expected.txt:
        * media/video-buffered.html:
        * media/video-controls-expected.txt:
        * media/video-controls-transformed-expected.txt:
        * media/video-controls-transformed.html:
        * media/video-controls.html:
        * media/video-currentTime-expected.txt:
        * media/video-currentTime-set.html:
        * media/video-currentTime-set2-expected.txt:
        * media/video-currentTime-set2.html:
        * media/video-currentTime.html:
        * media/video-dom-autoplay-expected.txt:
        * media/video-dom-autoplay.html:
        * media/video-dom-end-expected.txt:
        * media/video-dom-end.html:
        * media/video-dom-loopcount-expected.txt:
        * media/video-dom-loopcount.html:
        * media/video-dom-loopend-expected.txt:
        * media/video-dom-loopend.html:
        * media/video-dom-loopstart-expected.txt:
        * media/video-dom-loopstart.html:
        * media/video-dom-src-expected.txt:
        * media/video-dom-src.html:
        * media/video-dom-start-expected.txt:
        * media/video-dom-start.html:
        * media/video-end-expected.txt:
        * media/video-end.html:
        * media/video-error-abort-expected.txt:
        * media/video-error-abort.html:
        * media/video-error-does-not-exist-expected.txt:
        * media/video-error-does-not-exist.html:
        * media/video-load-networkState-expected.txt:
        * media/video-load-networkState.html:
        * media/video-load-readyState-expected.txt:
        * media/video-load-readyState.html:
        * media/video-loopcount-expected.txt:
        * media/video-loopcount.html:
        * media/video-loopend-expected.txt:
        * media/video-loopend.html:
        * media/video-loopstart-expected.txt:
        * media/video-loopstart.html:
        * media/video-muted-expected.txt:
        * media/video-muted.html:
        * media/video-no-autoplay-expected.txt:
        * media/video-no-autoplay.html:
        * media/video-pause-empty-events-expected.txt:
        * media/video-pause-empty-events.html:
        * media/video-play-empty-events-expected.txt:
        * media/video-play-empty-events.html:
        * media/video-play-pause-events-expected.txt:
        * media/video-play-pause-events.html:
        * media/video-poster-expected.txt:
        * media/video-poster.html:
        * media/video-seek-past-end-paused-expected.txt:
        * media/video-seek-past-end-paused.html:
        * media/video-seek-past-end-playing-expected.txt:
        * media/video-seek-past-end-playing.html:
        * media/video-seekable-expected.txt:
        * media/video-seekable.html:
        * media/video-seeking-expected.txt:
        * media/video-seeking.html:
        * media/video-size-expected.txt:
        * media/video-size.html:
        * media/video-source-expected.txt:
        * media/video-source-media-expected.txt:
        * media/video-source-media.html:
        * media/video-source-type-expected.txt:
        * media/video-source-type-params-expected.txt:
        * media/video-source-type-params.html:
        * media/video-source-type.html:
        * media/video-source.html:
        * media/video-src-change-expected.txt:
        * media/video-src-change.html:
        * media/video-src-expected.txt:
        * media/video-src-remove-expected.txt:
        * media/video-src-remove.html:
        * media/video-src-set-expected.txt:
        * media/video-src-set.html:
        * media/video-src-source-expected.txt:
        * media/video-src-source.html:
        * media/video-src.html:
        * media/video-start-expected.txt:
        * media/video-start.html:
        * media/video-test.js:
        (test):
        (testExpected):
        (waitForEvent._eventCallback):
        (waitForEvent):
        (waitForEventAndTest._eventCallback):
        (waitForEventAndTest):
        (testException):
        (logResult):
        * media/video-volume-expected.txt:
        * media/video-volume.html:
        * media/video-width-height-expected.txt:
        * media/video-width-height.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 4 Mar 2009 00:44:46 +0000 (00:44 +0000)]
2009-03-03  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Fix for <rdar://problem/6641045>
        Don't call QTKit to get movie properties until movie metadata has been loaded.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable.
        (WebCore::MediaPlayerPrivate::play): Ditto.
        (WebCore::MediaPlayerPrivate::pause): Ditto.
        (WebCore::MediaPlayerPrivate::duration): Ditto.
        (WebCore::MediaPlayerPrivate::currentTime): Ditto.
        (WebCore::MediaPlayerPrivate::seek): Ditto.
        (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto.
        (WebCore::MediaPlayerPrivate::paused): Ditto.
        (WebCore::MediaPlayerPrivate::seeking): Ditto.
        (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
        (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
        (WebCore::MediaPlayerPrivate::setVolume): Ditto.
        (WebCore::MediaPlayerPrivate::setRate): Ditto.
        (WebCore::MediaPlayerPrivate::dataRate): Ditto.
        (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
        (WebCore::MediaPlayerPrivate::totalBytes): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 4 Mar 2009 00:38:25 +0000 (00:38 +0000)]
2009-03-03  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6031674> JSProfiler: Multiple anonymous functions get
        the same entry in profiler if called from same function

        - This no longer happens but I thought I'd make a test case anyway.

        * fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Added.
        * fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Added.
        * fast/profiler/resources/profiler-test-JS-resources.js:
        (anotherAnonymousFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 4 Mar 2009 00:08:03 +0000 (00:08 +0000)]
2009-03-03  Kevin McCullough  <kmccullough@apple.com>

        - Spelling fix.

        * page/Console.cpp:
        (WebCore::Console::profile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Remove last vestiges of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR from WebKit
ddkilzer@apple.com [Tue, 3 Mar 2009 23:30:12 +0000 (23:30 +0000)]
    Remove last vestiges of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR from WebKit

        Reviewed by Adam Roben.

        Use of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR was removed in r37465
        since NPAPI headers had migrated from JavaScriptCore to WebCore
        before that.

WebKit:

        * WebKit.xcodeproj/project.pbxproj: Removed
        JAVASCRIPTCORE_PRIVATE_HEADERS_DIR build setting from from Debug
        and Release configurations.

WebKit/mac:

        * Configurations/WebKit.xcconfig: Removed definition of
        JAVASCRIPTCORE_PRIVATE_HEADERS_DIR used in Production builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 3 Mar 2009 22:57:21 +0000 (22:57 +0000)]
2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=23657
        Remove Database API callback IDLs from the project.
        They were removed in r40633.

        * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
kmccullough@apple.com [Tue, 3 Mar 2009 22:47:49 +0000 (22:47 +0000)]
JavaScriptCore:

2009-03-03  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6639110> console.profile() doesn't work without a title

        * profiler/Profiler.cpp:
        (JSC::Profiler::startProfiling): assert if there is not title to ensure
        we don't start profiling without one.

WebCore:

2009-03-03  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6639110> console.profile() doesn't work without a title

        * page/Console.cpp:
        (WebCore::Console::profile): If there is no title assume this is a user
        initiated profile and give it the next incremented title name.

LayoutTests:

2009-03-03  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6639110> console.profile() doesn't work without a title

        * fast/profiler/profile-with-no-title-expected.txt: Added.
        * fast/profiler/profile-with-no-title.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd bug URLs for my last commit.
timothy@apple.com [Tue, 3 Mar 2009 22:27:05 +0000 (22:27 +0000)]
Add bug URLs for my last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Pamela Greene <pam@chromium.org>
pam@chromium.org [Tue, 3 Mar 2009 22:25:32 +0000 (22:25 +0000)]
2009-03-03  Pamela Greene  <pam@chromium.org>

        Remove junk files that must have been accidentally committed.
        Submitted without review.

        * fast/block/float/t0905-c414-flt-fit-01-d-g.html.orig: Removed.
        * fast/block/float/t0905-c414-flt-fit-01-d-g.html.rej: Removed.
        * fast/block/float/t0905-c5525-fltblck-00-d-ag.html.orig: Removed.
        * fast/block/float/t0905-c5525-fltblck-00-d-ag.html.rej: Removed.
        * fast/block/float/t0905-c5526-flthw-00-c-g.html.orig: Removed.
        * fast/block/float/t0905-c5526-flthw-00-c-g.html.rej: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a regression that broke dirxml and caused an ASSERT in debug builds....
timothy@apple.com [Tue, 3 Mar 2009 22:24:14 +0000 (22:24 +0000)]
    Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
        the console code and refactored things to have fewer code paths and duplication.

        Reviewed by Kevin McCullough.

        Test: manual-tests/inspector/console-dir.html

        * bindings/js/JSInspectedObjectWrapper.cpp:
        (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject
        to fix an ASSERT about using a wrapper from the wrong ExecState.
        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto.
        (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat.
        When forceObjectFormat is true, the only formatter used is _formatobject.
        (WebInspector.Console.prototype._formatvalue): Remove the inline argument.
        (WebInspector.Console.prototype._formatstring): Ditto.
        (WebInspector.Console.prototype._formatregexp): Ditto.
        (WebInspector.Console.prototype._formatarray): Ditto.
        (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor.
        (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph.
        (WebInspector.Console.prototype._formaterror): Remove the inline argument.
        (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and
        simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter.
        (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline.
        (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat.
        (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments.
        (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
        * inspector/front-end/inspector.css: Tweak styles to look and work correctly.
        * inspector/front-end/utilities.js:
        (Object.type): Return "node" for Node objects.
        (Object.describe): Handle the "node" type.
        * page/Console.cpp:
        (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types.
        (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
        * page/Console.h:
        (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
dglazkov@chromium.org [Tue, 3 Mar 2009 21:07:36 +0000 (21:07 +0000)]
WebCore:

2009-03-03  Scott Violet  <sky@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24325
        Crash on replacing document contents during drop.

        Makes sure a node is in the document during a move before using it.

        Test: fast/events/crash-on-mutate-during-drop.html

        * editing/MoveSelectionCommand.cpp:
        (WebCore::MoveSelectionCommand::doApply):

LayoutTests:

2009-03-03  Scott Violet  <sky@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24325
        Crash on replacing document contents during drop

        Makes sure we don't crash during dnd with DOM mutation event listener
        that mutates the document on drop.

        * fast/events/crash-on-mutate-during-drop-expected.txt: Added.
        * fast/events/crash-on-mutate-during-drop.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Jungshik Shin <jshin@chromium.org>
dglazkov@chromium.org [Tue, 3 Mar 2009 19:53:25 +0000 (19:53 +0000)]
2009-03-03  Jungshik Shin <jshin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23028
        Enable dynamic web font support to Chromium on Windows.
        Files that were omitted by mistake in the latest patch
        that was landed.

        * loader/CachedFont.cpp:
        (WebCore::CachedFont::~CachedFont):
        (WebCore::CachedFont::ensureCustomFontData):
        (WebCore::CachedFont::platformDataFromCustomData):
        (WebCore::CachedFont::allClientsRemoved):
        * platform/graphics/chromium/FontCustomPlatformData.cpp:
        (WebCore::EOTStream::EOTStream):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/win/FontCustomPlatformData.cpp:
        (WebCore::EOTStream::EOTStream):
        (WebCore::createFontCustomPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Tue, 3 Mar 2009 19:48:22 +0000 (19:48 +0000)]
2009-03-03  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=16826
        [Gtk] Implement WebKitDownload

        Adding new files related to WebKitDownload to the GTK+ port.

        * GNUmakefile.am:

WebCore:

2009-03-03  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=16826
        [Gtk] Implement WebKitDownload

        Make the Soup backend able to handle requests without a frame,
        since we may have such things now that we support downloads.

        * platform/network/ResourceHandleInternal.h:
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::start):

WebKit/gtk:

2009-03-03  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=16826
        [Gtk] Implement WebKitDownload

        Implement download, and provide a nice object wrapping the
        download process. Initial work done by Marco Barisione and
        Pierre-Luc Beaudoin for Collabora.

        * WebCoreSupport/ContextMenuClientGtk.cpp:
        (WebKit::ContextMenuClient::downloadURL):
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::download):
        (WebKit::FrameLoaderClient::startDownload):
        * webkit/webkit.h:
        * webkit/webkitdefines.h:
        * webkit/webkitdownload.cpp: Added.
        (_WebKitDownloadPrivate::):
        (_WebKitDownloadPrivate::webkit_download_dispose):
        (_WebKitDownloadPrivate::webkit_download_finalize):
        (_WebKitDownloadPrivate::webkit_download_get_property):
        (_WebKitDownloadPrivate::webkit_download_set_property):
        (_WebKitDownloadPrivate::webkit_download_class_init):
        (_WebKitDownloadPrivate::webkit_download_init):
        (_WebKitDownloadPrivate::webkit_download_new):
        (_WebKitDownloadPrivate::webkit_download_open_stream_for_uri):
        (_WebKitDownloadPrivate::webkit_download_close_stream):
        (_WebKitDownloadPrivate::webkit_download_start):
        (_WebKitDownloadPrivate::webkit_download_cancel):
        (_WebKitDownloadPrivate::webkit_download_get_uri):
        (_WebKitDownloadPrivate::webkit_download_get_network_request):
        (_WebKitDownloadPrivate::webkit_download_set_response):
        (_WebKitDownloadPrivate::webkit_download_get_suggested_filename):
        (_WebKitDownloadPrivate::webkit_download_get_destination_uri):
        (_WebKitDownloadPrivate::webkit_download_set_destination_uri):
        (_WebKitDownloadPrivate::webkit_download_get_state):
        (_WebKitDownloadPrivate::webkit_download_get_total_size):
        (_WebKitDownloadPrivate::webkit_download_get_current_size):
        (_WebKitDownloadPrivate::webkit_download_get_progress):
        (_WebKitDownloadPrivate::webkit_download_get_elapsed_time):
        (_WebKitDownloadPrivate::webkit_download_received_data):
        (_WebKitDownloadPrivate::webkit_download_finished_loading):
        (_WebKitDownloadPrivate::webkit_download_error):
        (_WebKitDownloadPrivate::DownloadClient::DownloadClient):
        (_WebKitDownloadPrivate::DownloadClient::didReceiveResponse):
        (_WebKitDownloadPrivate::DownloadClient::didReceiveData):
        (_WebKitDownloadPrivate::DownloadClient::didFinishLoading):
        (_WebKitDownloadPrivate::DownloadClient::didFail):
        (_WebKitDownloadPrivate::DownloadClient::wasBlocked):
        (_WebKitDownloadPrivate::DownloadClient::cannotShowURL):
        * webkit/webkitdownload.h: Added.
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        * webkitmarshal.list:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 Mar 2009 19:29:58 +0000 (19:29 +0000)]
2009-03-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Fix <rdar://problem/6633834>.

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        Create a new plug-in instance if the plug-in host has crashed.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::invalidate):
        Add a null check for the plug-in host proxy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 3 Mar 2009 19:18:56 +0000 (19:18 +0000)]
2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24331
        Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.

        * bindings/v8/custom/V8AttrCustom.cpp: Added.
        * bindings/v8/custom/V8CustomBinding.cpp: Added.
        * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
        * bindings/v8/custom/V8ElementCustom.cpp: Added.
        * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
        * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Tue, 3 Mar 2009 19:08:56 +0000 (19:08 +0000)]
WebCore:

2009-03-03  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6616664> - Quick looks of various file types is broken

        In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
        for non-HTTP loads when the underlying ResourceRequest changed.  Unfortunately it was a little
        overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.

        Partially reverted behavior to always set the mainDocumentURL in situations when we would've
        before that patch.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::addExtraFieldsToRequest):

        * platform/network/ResourceRequestBase.cpp:
        (WebCore::ResourceRequestBase::setMainDocumentURL):

WebKitTools:

2009-03-03  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Support layout test covering <rdar://problem/6616664>

        Change NSURLRequest/IWebURLRequest dumping to include the mainDocumentURL

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[NSURLRequest _drt_descriptionSuitableForTestResult]): Return both the request URL and the
          mainDocumentURL.

        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
        (descriptionSuitableForTestResult): Return both the request URL and the mainDocumentURL.

LayoutTests:

2009-03-03  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Layout test covering <rdar://problem/6616664> - Quick looks of various file types is broken

        Added to test the changes:
        * fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
        * fast/loader/main-document-url-for-non-http-loads.html: Added.
        * fast/loader/resources/subframe-notify-done.html: Added.

        Updated the following for the new info from dumpResourceLoadCallbacks():
        * http/tests/misc/window-dot-stop-expected.txt:
        * http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt:
        * platform/mac-leopard/security/block-test-expected.txt:
        * platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
        * platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
        * platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
        * security/block-test-expected.txt:
        * webarchive/loading/test-loading-archive-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Simon Fraser.
cmarrin@apple.com [Tue, 3 Mar 2009 18:55:33 +0000 (18:55 +0000)]
    Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24256

        Added a WebCoreForceSoftwareAnimation flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
cmarrin@apple.com [Tue, 3 Mar 2009 18:48:41 +0000 (18:48 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=24257

        Added prototype properties for several classes with constructors that
        were missing them, including the one mentioned in the bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Tue, 3 Mar 2009 18:46:50 +0000 (18:46 +0000)]
2009-03-03  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Create and update the action for SelectAll.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::updateAction):
        (QWebPagePrivate::updateEditorActions):
        (QWebPage::action):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::textSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 3 Mar 2009 18:38:04 +0000 (18:38 +0000)]
2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24321
        Add V8 bindings headers.

        * bindings/v8/V8Binding.h: Added.
        * bindings/v8/V8Proxy.h: Added.
        * bindings/v8/custom/V8CustomBinding.h: Added.
        * bindings/v8/custom/V8CustomEventListener.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Jungshik Shin <jshin@chromium.org>
dglazkov@chromium.org [Tue, 3 Mar 2009 18:33:26 +0000 (18:33 +0000)]
2009-03-03  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Darin Adler.

        http://bugs.webkit.org/show_bug.cgi?id=23482
        Add the following CSS 2.1 tests, with YinYang character (U+262F)
        and SouthEast Arrow (U+2798) replaced by png images,
        to fast/block/float. Leftward white arrow (U+21E6) is also
        replaced by an ASCII-equivalent of '<-'.

              css2.1/t0905-c414-flt-fit-01-d-g.html
              css2.1/t0905-c5525-fltblck-00-d-ag.html
              css2.1/t0905-c5526-flthw-00-c-g.html

        On platforms where no font covers those characters (e.g. Windows),
        the above tests can be skipped and the new tests can be used, instead.
        They're equivalent in terms of what they test.

        * fast/block/float/resources/se_arrow.png: Added.
        * fast/block/float/resources/yinyang.png: Added.
        * fast/block/float/t0905-c414-flt-fit-01-d-g.html: Copied from LayoutTests/css2.1/t0905-c414-flt-fit-01-d-g.html.
        * fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Copied from LayoutTests/css2.1/t0905-c5525-fltblck-00-d-ag.html.
        * fast/block/float/t0905-c5526-flthw-00-c-g.html: Copied from LayoutTests/css2.1/t0905-c5526-flthw-00-c-g.html.
        * platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
        * platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Added.
        * platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Added.
        * platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Added.
        * platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Added.
        * platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
        * platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Added.
        * platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Added.
        * platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Jungshik Shin <jshin@chromium.org>
dglazkov@chromium.org [Tue, 3 Mar 2009 18:21:37 +0000 (18:21 +0000)]
2009-03-03  Jungshik Shin <jshin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23803
        Fix an 'off-by-1' error in ChromiumWin's font fallback.

        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix ChangeLog dates.
dglazkov@chromium.org [Tue, 3 Mar 2009 18:20:07 +0000 (18:20 +0000)]
Fix ChangeLog dates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Jungshik Shin <jshin@chromium.org>
dglazkov@chromium.org [Tue, 3 Mar 2009 18:18:38 +0000 (18:18 +0000)]
2009-03-03  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Eric Seidel.

        http://bugs.webkit.org/show_bug.cgi?id=23028
        Enable dynamic web font support to Chromium on Windows: Part 1
        - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype
          from platform/graphics/win because both Windows port and Chromium Windows
          port will use them.
        - Adjust WebCore.vcproj accordingly.

        * WebCore.vcproj/WebCore.vcproj:
        * platform/graphics/opentype: Added.
        * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
        * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
        * platform/graphics/win/OpenTypeUtilities.cpp: Removed.
        * platform/graphics/win/OpenTypeUtilities.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 3 Mar 2009 18:10:04 +0000 (18:10 +0000)]
2009-03-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24312

        Take 3D transforms into account when hit testing:

        1. Maintain a bit on each RenderLayer that is set when the layer
           has 3d descendants, so that we know when to fall into the slow
           hit testing path.

        2. Make a ref-counted HitTestingTransformState, which is used to store
           an accumulated transform, and the hit test point, and hitTestRect
           in the plane of the ancestor non-3d ('flattening') layer.

           It's ref-counted so we can heap allocate it (to avoid stack bloat),
           and avoid copying when hitTestLayer calls itself after applying the transform.

        3. Add logic to hitTestLayer to depth-test just direct descendants, if any have
           3D transforms, or to do deep depth-testing when traversing a preserves-3d
           hierarchy. When hit, layers compute a z-offset from the ancestor flattening
           layer, which allows for correct depth testing.

           The existing early-return codepath is unaffected when there are no 3d transforms
           and no preserve-3d.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix typo in ChangeLog from last commit.
brettw@chromium.org [Tue, 3 Mar 2009 17:54:40 +0000 (17:54 +0000)]
Fix typo in ChangeLog from last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 3 Mar 2009 17:52:55 +0000 (17:52 +0000)]
2009-03-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24312

        Factor the code that compute a transform relative to the container
        into RenderObject::transformFromContainer().

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::mapLocalToAbsolutePoint):
        (WebCore::RenderBox::mapAbsoluteToLocalPoint):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::transformFromContainer):
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Brett Wilson <brettw@chromium.org>
brettw@chromium.org [Tue, 3 Mar 2009 17:50:24 +0000 (17:50 +0000)]
2009-03-02  Brett Wilson  <brettw@chromium.org>

        Fix uninitialized memory reads in the Chromium Windows transparency
        code that were identified by Purify,

        Reviewed by Darin Disher.

        * platform/graphics/chromium/TransparencyWin.cpp:
        (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
        (WebCore::TransparencyWin::initializeNewContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 3 Mar 2009 17:43:34 +0000 (17:43 +0000)]
2009-03-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24317

        Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
        the superclass found a node, otherwise we set the innerNode of the
        HitTestResult, but don't actually report that we found a hit.

        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixing bug number for last ChangeLog entry; thanks to Ariya for
kov@webkit.org [Tue, 3 Mar 2009 17:31:07 +0000 (17:31 +0000)]
Fixing bug number for last ChangeLog entry; thanks to Ariya for
catching this problem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Onne Gorter <onne.gorter@avinity.net>
kov@webkit.org [Tue, 3 Mar 2009 17:26:57 +0000 (17:26 +0000)]
2009-03-03  Onne Gorter  <onne.gorter@avinity.net>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=27385
        resizing plugins does not work, because the plugin never gets informed

        Make gtk plugins resize correctly, by sending them the setwindow event
        correctly. Also ensure that all plugin eventing is done with correct
        locking/calling. Mostly copied from mac implementation.

        manual test: manual-tests/gtk/plugin-resize-scroll.html

        * plugins/PluginView.h:
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::dispatchNPEvent):
        ensure locking/calling for NPEvents
        (WebCore::PluginView::updatePluginWidget):
        if something changed, let setNPWindowIfNeeded handle it
        (WebCore::PluginView::paint):
        (WebCore::PluginView::handleKeyboardEvent):
        (WebCore::PluginView::handleMouseEvent):
        ensure calling conventions
        (WebCore::PluginView::setNPWindowRect):
        just pass control to setNPWindowIfNeeded
        (WebCore::PluginView::setNPWindowIfNeeded):
        event the plugin correctly of new window
        (WebCore::PluginView::init):
        init through the new setup

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
ap@webkit.org [Tue, 3 Mar 2009 16:45:54 +0000 (16:45 +0000)]
    Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=4343
        XMLHttpRequest doesn't work in a JavaScript-created window

        The problem was fixed a while ago (r34506), just adding a test.

        * http/tests/xmlhttprequest/request-from-popup-expected.txt: Added.
        * http/tests/xmlhttprequest/request-from-popup.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdding bug URL and title to ChangeLog for a recent check-in.
ap@webkit.org [Tue, 3 Mar 2009 16:44:39 +0000 (16:44 +0000)]
Adding bug URL and title to ChangeLog for a recent check-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Mike Belshe <mike@belshe.com>
darin@chromium.org [Tue, 3 Mar 2009 16:06:15 +0000 (16:06 +0000)]
2009-03-03  Mike Belshe  <mike@belshe.com>

        Reviewed by Darin Fisher.

        * dom/Document.idl:
        * html/HTMLCanvasElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 3 Mar 2009 06:15:51 +0000 (06:15 +0000)]
2009-03-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adele Peterson

        https://bugs.webkit.org/show_bug.cgi?id=24313

        If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
        HitTestResult, then it had better well return |true|. And m_innerBlock
        could never have been set as the hit node by the superclass, because
        the superclass knows nothing about m_innerBlock.

        Test: fast/forms/input-hit-test-border.html

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
weinig@apple.com [Tue, 3 Mar 2009 02:24:55 +0000 (02:24 +0000)]
JavaScriptCore:

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Enable Geolocation (except on Tiger and Leopard).

        * Configurations/JavaScriptCore.xcconfig:

WebCore:

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Enable Geolocation (except on Tiger and Leopard).

        * Configurations/WebCore.xcconfig:

WebKit/mac:

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Enable Geolocation (except on Tiger and Leopard).

        * Configurations/WebKit.xcconfig:

WebKitTools:

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Enable Geolocation (except on Tiger and Leopard).

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Ojan Vafai <ojan@chromium.org>
eric@webkit.org [Tue, 3 Mar 2009 02:12:49 +0000 (02:12 +0000)]
2009-03-02  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adele Peterson.

        Fix https://bugs.webkit.org/show_bug.cgi?id=24307
        Null out m_highlightedNode on hideHighlight().
        Ran WebCore/manual-tests/inspector/highlight-nodes.html.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::hideHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 Mar 2009 01:51:51 +0000 (01:51 +0000)]
2009-03-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        WebKit part of <rdar://problem/6638658>.

        * Plugins/Hosted/NetscapePluginHostManager.h:
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::createPropertyListFile):
        Spawn the plug-in host and wait for it to create the property list.

        * Plugins/WebBasePluginPackage.mm:
        (-[WebBasePluginPackage createPropertyListFile]):
        Factor code out into a new method.

        (-[WebBasePluginPackage pListForPath:createFile:]):
        Call the newly added createPropertyListFile method.

        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage createPropertyListFile]):
        Tell the plug-in host manager to create a property list file for us.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Tue, 3 Mar 2009 01:47:14 +0000 (01:47 +0000)]
WebCore:

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Fix for <rdar://problem/6507404> Add Geolocation support.

        This is not yet turned on for any Mac platform.

        * WebCore.xcodeproj/project.pbxproj:
        * page/Chrome.cpp:
        (WebCore::Chrome::shouldAllowGeolocationForFrame):
        * page/Chrome.h:
        * page/ChromeClient.h:
        (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
        * page/Geolocation.cpp:
        (WebCore::Geolocation::Geolocation):
        (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
        will not be alive at this point.
        (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
        return a PERMISSION_DENIED if not.
        (WebCore::Geolocation::watchPosition): Ditto.
        (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
        to allow geolocation and cache the result.
        * page/Geolocation.h:
        (WebCore::Geolocation::):
        * platform/GeolocationService.cpp:
        * platform/GeolocationService.h:
        (WebCore::GeolocationService::~GeolocationService):
        (WebCore::GeolocationService::stopUpdating):
        * platform/mac/GeolocationServiceMac.h: Added.
        (WebCore::GeolocationServiceMac::lastPosition):
        (WebCore::GeolocationServiceMac::lastError):
        * platform/mac/GeolocationServiceMac.mm: Added.
        (WebCore::GeolocationService::create):
        (WebCore::GeolocationServiceMac::GeolocationServiceMac):
        (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
        (WebCore::GeolocationServiceMac::startUpdating):
        (WebCore::GeolocationServiceMac::stopUpdating):
        (WebCore::GeolocationServiceMac::suspend):
        (WebCore::GeolocationServiceMac::resume):
        (WebCore::GeolocationServiceMac::positionChanged):
        (WebCore::GeolocationServiceMac::errorOccurred):
        (-[WebCoreCoreLocationObserver initWithCallback:]):
        (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
        (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):

WebKit/mac:

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Fix for <rdar://problem/6507404> Add Geolocation support.

        This is not yet turned on for any Mac platform.

        Add SPI to ask the embedding application whether to allow
        Geolocation for an origin.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::shouldAllowGeolocationForFrame):
        * WebView/WebUIDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 Mar 2009 01:36:51 +0000 (01:36 +0000)]
2009-03-02  Anders Carlsson  <andersca@apple.com>

        Fix PowerPC build.

        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage _tryLoad]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix tyop
andersca@apple.com [Tue, 3 Mar 2009 00:20:08 +0000 (00:20 +0000)]
Fix tyop

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 Mar 2009 00:14:45 +0000 (00:14 +0000)]
2009-03-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan, Ada Chan.

        Factor loading code out into its own method and get rid of a bunch of goots.

        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage _tryLoad]):
        (-[WebNetscapePluginPackage load]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 Mar 2009 00:00:46 +0000 (00:00 +0000)]
2009-03-02  Anders Carlsson  <andersca@apple.com>

        Build fix.

        * Plugins/WebNetscapeDeprecatedFunctions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 2 Mar 2009 23:58:35 +0000 (23:58 +0000)]
2009-03-02  Anders Carlsson  <andersca@apple.com>

        WebNetscapePluginPackage.mm is an Objective-C++ file.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit:
andersca@apple.com [Mon, 2 Mar 2009 23:53:50 +0000 (23:53 +0000)]
WebKit:

2009-03-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-03-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm

        * Plugins/WebNetscapePluginPackage.m: Removed.
        * Plugins/WebNetscapePluginPackage.mm: Copied from mac/Plugins/WebNetscapePluginPackage.m.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fixes for wxWidgets Mac trunk build.
kevino@webkit.org [Mon, 2 Mar 2009 23:29:23 +0000 (23:29 +0000)]
Build fixes for wxWidgets Mac trunk build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowxGTK missing header build fix.
kevino@webkit.org [Mon, 2 Mar 2009 23:25:33 +0000 (23:25 +0000)]
wxGTK missing header build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
mitz@apple.com [Mon, 2 Mar 2009 21:55:51 +0000 (21:55 +0000)]
    Reviewed by Adam Roben.

        - fix https://bugs.webkit.org/show_bug.cgi?id=21811
          REGRESSION: Windows Build Not Selecting Proper Font

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::createGDIFont): Added back code to verify that the created
        HFONT has the requested face name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes a regression caused by splitting the input and output of console commands.
timothy@apple.com [Mon, 2 Mar 2009 21:38:39 +0000 (21:38 +0000)]
    Fixes a regression caused by splitting the input and output of console commands.

        https://bugs.webkit.org/show_bug.cgi?id=24293

        Reviewed by Kevin McCullough.

        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
        normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make exception messages and logged Error objects display consistently.
timothy@apple.com [Mon, 2 Mar 2009 21:38:25 +0000 (21:38 +0000)]
    Make exception messages and logged Error objects display consistently.

        https://bugs.webkit.org/show_bug.cgi?id=18983

        Reviewed by Adam Roben.

        * English.lproj/localizedStrings.js: Remove a string for line numbers.
        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
        boolean to the ConsoleCommandResult constructor and don't pass level.
        (WebInspector.Console.prototype._formatnode): Fix a className typo.
        (WebInspector.Console.prototype._formaterror): Add an error-message
        classed span around the message to show in red and remove the
        console-message-url class from the link so it doesn't float right.
        Instead enclose the link in parentheses and use displayNameForURL
        to shorten the URL in the link.
        (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
        how line numbers are shown since link underlining a string with
        parentheses looks bad.
        (WebInspector.ConsoleCommandResult): Take an exception boolean flag
        instead of a level and get line and URL based on that flag.
        * inspector/front-end/inspector.css: Tweaks to the styles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Allow for multiline quoted text in JavaScript files when looking for function...
timothy@apple.com [Mon, 2 Mar 2009 21:38:11 +0000 (21:38 +0000)]
    Allow for multiline quoted text in JavaScript files when looking for function names.

        https://bugs.webkit.org/show_bug.cgi?id=24296

        Reviewed by David Kilzer.

        * Scripts/prepare-ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41363 268f45cc-cd09-0410-ab3c-d52691b4dbfc