WebKit GIT trees - WebKit-https.git/log

https://bugs.webkit.org/show_bug.cgi?id=64678
Fix bugs in Object.prototype this handling.

Reviewed by Darin Adler.

Source/JavaScriptCore:

Fix ES5.1 correctness issues identified by Mads Ager.

* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
    - ES5.1 expects toString of undefined/null to produce "[object Undefined]"/"[object Null]".

LayoutTests:

* fast/js/object-prototype-properties-expected.txt:
* fast/js/script-tests/object-prototype-properties.js:
    - Fix these tests to check Object.prototype explicitly, not the Global Object, and expect ES5.1 correct results.
* sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.1_The_this_Keyword/S11.1.1_A2-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.4_String.prototype.charAt/S15.5.4.4_A1_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.5_String.prototype.charCodeAt/S15.5.4.5_A1_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:
    - Slight change in expected results, these tests are all incorrect, were all FAILing, and are still all FAILing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Chromium test expectations for r91331.
Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Rebaseline test expectations for Windows after r91331.
platform/win/fast/dom/Window/window-property-descriptors-expected.txt
platform/win/fast/dom/prototype-inheritance-expected.txt
platform/win/fast/js/global-constructors-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Move platform independent expected.txts out of platform/mac
https://bugs.webkit.org/show_bug.cgi?id=64796

Reviewed by Rob Buis.

* fast/css/replaced-element-implicit-size-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/replaced-element-implicit-size-expected.txt.
* svg/custom/zero-path-square-cap-rendering-expected.txt: Renamed from LayoutTests/platform/mac/svg/custom/zero-path-square-cap-rendering-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Rebaseline JS and DOM test expectations after r91331.

fast/js/global-constructors-expected.txt
fast/dom/prototype-inheritance-2-expected.txt
fast/dom/prototype-inheritance-expected.txt
fast/dom/Window/window-properties-expected.txt
fast/dom/Window/window-property-descriptors-expected.txt
svg/custom/global-constructors-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Rebaseline test expectations for Mac after r91331.

platform/mac/svg/text/text-altglyph-01-b-expected.txt
platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Rebasline chromium test expectation after r91331.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Media player controls do not fade out.
https://bugs.webkit.org/show_bug.cgi?id=64837

Media controls were not fading out when the mouse leaves the video
due to underlying changes in webkit media controls.
Fix was to copy missing code from MediaControlRootElement to
MediaControlRootElementChromium.

Reviewed by Dimitri Glazkov.

* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::playbackProgressed):
(WebCore::MediaControlRootElementChromium::containsRelatedTarget):
(WebCore::MediaControlRootElementChromium::defaultEventHandler):
* html/shadow/MediaControlRootElementChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Implement CSSPropertyCounterIncrement and CounterReset in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=64846

Reviewed by Dimitri Glazkov.

No new tests / refactoring only.

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyCounter
Added class to handle counter properties.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize counter property handlers.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove old handlers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Improve documentation of QWebView::setPage()
https://bugs.webkit.org/show_bug.cgi?id=64827

Reviewed by Noam Rosenthal.

* Api/qwebview.cpp: Use the word 'page' to refer to a QWebPage instead of 'document'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] More chromium rebaseline for r91249.
Unreviewed.

* platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

REGRESSION(r89004): Video pauses and never resumes playing if scrubbed during playback.
https://bugs.webkit.org/show_bug.cgi?id=64314

Reviewed by Sam Weinig.

No new tests because it's hard to make a non-flaky test for this behavior.

* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
Don't call SliderThumbElement::dragFrom() for events on the thumb.
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler):
Do not call setDefaultHandled() for mouse events in order to
propagate them to ancestor elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add fast path for ImageBuffer::draw
https://bugs.webkit.org/show_bug.cgi?id=64535

Reviewed by Simon Fraser.

No new tests. This patch doesn't change behavior; current tests are sufficient.

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage): Moved the main method version next to wrapper versions.

* platform/graphics/ImageBuffer.h:
1) Added BackingStoreCopy enum for choosing to copy backing store or not in copyImage().
2) Added copyNativeImage() behind USE(CG) - same as copyImage() but gives NativeImagePtr.
* platform/graphics/cg/ImageBufferCG.cpp: Added new methods described above.

* platform/graphics/GraphicsContext.h: Adding drawNativeImage() for fast draw path.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage): Added. Draws a nativeImagePtr into context.

* platform/graphics/Image.h: Added imageWithColorSpace behind CG platform ifdef
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw): Refactored out actual image drawing code into GraphicsContext,
so that it can be used by more than just BitmapImage without having to copy code.
(WebCore::Image::imageWithColorSpace): Made into an Image class function.

Updated copyImage() to for BackingStoreCopy:
* platform/graphics/qt/ImageBufferQt.cpp
* platform/graphics/filters/FETile.cpp
* platform/graphics/cairo/ImageBufferCairo.cpp
* platform/graphics/skia/ImageBufferSkia.cpp
* platform/graphics/wx/ImageBufferWx.cpp
* platform/graphics/wince/ImageBufferWinCE.cpp
* svg/SVGFEImageElement.cpp
* svg/graphics/SVGImage.cpp
* html/HTMLCanvasElement.cpp
* html/canvas/WebGLRenderingContext.cpp
* rendering/svg/RenderSVGResourcePattern.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and <glyphRef>
https://bugs.webkit.org/show_bug.cgi?id=60850

Reviewed by Nikolas Zimmermann.

SVG spec: http://www.w3.org/TR/SVG/text.html#AlternateGlyphDefinitions.
This patch is to implement SVG <altGlyphDef>, <altGlyphItem> and <glyphRef>
elements for alternative glyph features.

Source/WebCore:

NOTE: x, y, dx, dy, format and glyphRef attributes on <glyphRef> are not
honored yet, so neither are the reaction of dynamic change of them. They
will be honored in separated patches.

Test: svg/W3C-SVG-1.1/text-altglyph-01-b.svg
With this patch this test works as expected.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
(WebCore::createElementClassMap):
* bindings/objc/DOMSVG.h:
* page/DOMWindow.idl:
* svg/SVGAllInOne.cpp:
* svg/SVGAltGlyphDefElement.cpp: Added.
(WebCore::SVGAltGlyphDefElement::SVGAltGlyphDefElement):
(WebCore::SVGAltGlyphDefElement::create):
(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):
* svg/SVGAltGlyphDefElement.h: Added.
* svg/SVGAltGlyphDefElement.idl: Added.
* svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::hasValidGlyphElements):
* svg/SVGAltGlyphElement.h:
* svg/SVGAltGlyphItemElement.cpp: Added.
(WebCore::SVGAltGlyphItemElement::SVGAltGlyphItemElement):
(WebCore::SVGAltGlyphItemElement::create):
(WebCore::SVGAltGlyphItemElement::hasValidGlyphElements):
* svg/SVGAltGlyphItemElement.h: Added.
* svg/SVGAltGlyphItemElement.idl: Added.
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
* svg/SVGGlyphRefElement.cpp: Added.
(WebCore::SVGGlyphRefElement::SVGGlyphRefElement):
(WebCore::SVGGlyphRefElement::create):
(WebCore::SVGGlyphRefElement::hasValidGlyphElement):
(WebCore::SVGGlyphRefElement::parseMappedAttribute):
(WebCore::SVGGlyphRefElement::glyphRef):
(WebCore::SVGGlyphRefElement::setGlyphRef):
(WebCore::SVGGlyphRefElement::setX):
(WebCore::SVGGlyphRefElement::setY):
(WebCore::SVGGlyphRefElement::setDx):
(WebCore::SVGGlyphRefElement::setDy):
* svg/SVGGlyphRefElement.h: Added.
* svg/SVGGlyphRefElement.idl: Added.
* svg/svgtags.in:

Source/WebKit/mac:

* MigrateHeaders.make:

LayoutTests:

Updated test expectation.

* platform/chromium-linux/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Chromium test expectation update. svg/custom/crash-textPath-attributes.html is hitting an assertion.
The failure is tracked by the bug 64844.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Skip some more tests on WebKit2 that rely on unimplemented test harness APIs

* platform/wk2/Skipped: Added svg/animations/svgtransform-animation-discrete.html and
fast/forms/input-search-press-escape-key.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Apparently my rebaseline was incorrect for r91294.

Remove expected results and skip compositing/scaling/tiled-layer-recursion.html on Chromium
because it's missing expected results.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove some unused code in FormDataStreamCFNet

Rubber-stamped by Steve Falkenburg.

* platform/network/cf/FormDataStreamCFNet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-07-19  Simon Fraser  <simon.fraser@apple.com>

        REGRESSION (r91136-r91146): 40 tests failing on Windows 7 Release (Tests)
        https://bugs.webkit.org/show_bug.cgi?id=64808

        Reviewed by Adam Roben.

        Initializing m_uncommittedChanges to a non-zero value
        caused the first call to noteLayerPropertyChanged() to
        not call m_client->notifySyncRequired(). This resulted in
        animations never getting committed on Windows, which broke
        a lot of tests.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::GraphicsLayerCA):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

parse-malloc-history always exits 1, causing NRWT to fail
https://bugs.webkit.org/show_bug.cgi?id=64835

Reviewed by Adam Barth.

ORWT just never checked the return code. :)

* Scripts/parse-malloc-history:
(main):
* Scripts/webkitpy/layout_tests/port/mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] LayerRendererChromium shouldn't be a friend of RenderSurfaceChromium
https://bugs.webkit.org/show_bug.cgi?id=64834

Reviewed by Kenneth Russell.

Uses setters and getters to access RenderSurfaceChromium's private member variables instead of directly
accessing them via a friend declaration. This cleans up a minor code smell and will be helpful for future
refactoring.

Refactor only, no change in behavior. Tested by compositing/ tests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::updateCompositorResources):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::setScissorToRect):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::clearLayerList):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::layerList):
(WebCore::RenderSurfaceChromium::contentRect):
(WebCore::RenderSurfaceChromium::setContentRect):
(WebCore::RenderSurfaceChromium::drawOpacity):
(WebCore::RenderSurfaceChromium::setDrawOpacity):
(WebCore::RenderSurfaceChromium::drawTransform):
(WebCore::RenderSurfaceChromium::setDrawTransform):
(WebCore::RenderSurfaceChromium::maskLayer):
(WebCore::RenderSurfaceChromium::setMaskLayer):
(WebCore::RenderSurfaceChromium::originTransform):
(WebCore::RenderSurfaceChromium::setOriginTransform):
(WebCore::RenderSurfaceChromium::replicaDrawTransform):
(WebCore::RenderSurfaceChromium::setReplicaDrawTransform):
(WebCore::RenderSurfaceChromium::scissorRect):
(WebCore::RenderSurfaceChromium::setScissorRect):
(WebCore::RenderSurfaceChromium::skipsDraw):
(WebCore::RenderSurfaceChromium::setSkipsDraw):
(WebCore::RenderSurfaceChromium::contentsTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-07-19  Simon Fraser  <simon.fraser@apple.com>

        Skip compositing/scaling/tiled-layer-recursion.html on chromium
        and Windows because it requires the scalePageBy DRT API.

        * platform/chromium/test_expectations.txt:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

GTK + QT build fix.

Rubber-stamped by Daniel Bates and Alexey Proskuryakov.

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix web audio compile on mac port
https://bugs.webkit.org/show_bug.cgi?id=64836

Unreviewed build fix.

* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContextConstructor::constructJSAudioContext):
(WebCore::JSAudioContext::createBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[wx] Unreviewed build fix, don't add the debug prefix as 2.9 no longer uses one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Build fix after r91307.

* Platform/Logging.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Work towards determining the cause of frequent crashes due to null frame below
ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache.
https://bugs.webkit.org/show_bug.cgi?id=62764

Reviewed by Alexey Proskuryakov.

Make these unexpected cases crash in the WebKit nightlies so we can gather more
information and potentially find a repro case.

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

new-run-webkit-tests should only enable MallocStackLogging for DRT
https://bugs.webkit.org/show_bug.cgi?id=64792

Reviewed by Adam Barth.

The previous code would enable it for all servers launched
by the port, which included Apache, the python websocket server
as well as ImageDiff. Now only DumpRenderTree will have
MallocStackLogging enabled or the GuardMalloc library injected.

I also cleaned up the websocket_server code to use filesystem
while I was in it.

I also made DRT restart every 1000 tests when running with
--leaks enabled. I believe this made the --leaks run slightly
faster, but it still takes over an hour on my machine. :(

* Scripts/webkitpy/layout_tests/controllers/worker.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/gtk.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/qt.py:
* Scripts/webkitpy/layout_tests/port/server_process.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/servers/http_server.py:
* Scripts/webkitpy/layout_tests/servers/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Nothing printed when specifying a very large maximum layout width
https://bugs.webkit.org/show_bug.cgi?id=64831

Reviewed by Beth Dakin.

I am not adding a test because the DumpRenderTree printing test machinery is based on PrintContext,
which does not exercise the code path on which this bug lies.

* page/FrameView.cpp:
(WebCore::FrameView::forceLayoutForPagination): Fixed an integer overflow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

remove the concept of platform fallbacks
https://bugs.webkit.org/show_bug.cgi?id=64829

Reviewed by Adam Barth.

In the process, wrote tests for this code and fixed a pretty major
bug (now covered by the test).

* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cleanup some of the PLATFORM logic in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=64821

Reviewed by Adam Barth.

* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Store line number on TestExpectationLine.
https://bugs.webkit.org/show_bug.cgi?id=64800

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored to store line number on TestExpectationLine instances.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Chromium rebaseline for r91294. Also filed the bug 64828 to track the crash on Chromium Mac.

* platform/chromium-gpu-linux/compositing/scaling: Added.
* platform/chromium-gpu-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
* platform/chromium-gpu-win/compositing/scaling: Added.
* platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png: Added.
* platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore: [V8] Wait until no v8 context is on the stack before
cancelling pending indexed db transactions.
https://bugs.webkit.org/show_bug.cgi?id=64552

Reviewed by Adam Barth.

Test: storage/indexeddb/transaction-abort-with-js-recursion.html

* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::didLeaveScriptContext):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=64552.

Reviewed by Adam Barth.

* storage/indexeddb/transaction-abort-with-js-recursion-expected.txt: Added.
* storage/indexeddb/transaction-abort-with-js-recursion.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore: Crash in CompositeEditCommand::replaceTextInNodePreservingMarkers.
https://bugs.webkit.org/show_bug.cgi?id=64738

Patch by MORITA Hajime <morrita@google.com> on 2011-07-19
Reviewed by Ryosuke Niwa.

Test: editing/undo/replace-text-in-node-preserving-markers-crash.html

* editing/CompositeEditCommand.cpp:
(WebCore::copyMarkers):
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):

LayoutTests: Sending a `Ping-From` header for cross-origin pings from non-HTTPS documents.
https://bugs.webkit.org/show_bug.cgi?id=64789

Also a drive-by cleanup of whitespace.

Patch by Mike West <mkwst@chromium.org> on 2011-07-19
Reviewed by Nate Chapin.

* http/tests/navigation/ping-cross-origin-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] [WK2] Implement missing initializeLogChannel function.
https://bugs.webkit.org/show_bug.cgi?id=63381

Patch by Lukasz Slachciak <lukasz.slachciak@gmail.com> on 2011-07-19
Reviewed by Martin Robinson.

Implemented logging for GTK platform in WebKit2 - function initializeLogChannel is called for all ports,
so added missing implementation. Aslo helper function added for getting channels from names.

* GNUmakefile.am: Added reference to new file LoggingGtk.cpp.
* Platform/Logging.cpp: Logging implementation for GTK port enabled.
(WebKit::getChannelFromName): Helper to connect name with WTFLogChannel.
* Platform/Logging.h: New helper method added.
* Platform/gtk/LoggingGtk.cpp: Added. GTK logging implementation.
(WebKit::initializeLogChannel): Channel is initialized if its name is found in WEBKIT_DEBUG.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Sending a `Ping-From` header for cross-origin pings from non-HTTPS documents.
https://bugs.webkit.org/show_bug.cgi?id=64789

Also a drive-by cleanup of whitespace.

Patch by Mike West <mkwst@chromium.org> on 2011-07-19
Reviewed by Nate Chapin.

Source/WebCore:

* loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):

LayoutTests:

* http/tests/navigation/ping-cross-origin-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64809
REGRESSION (r91114-r91116): fast/dom/error-to-string-stack-overflow.html failing on Windows 7 Release (Tests)

Reviewed by Adam Roben.

I think this just needs new results. The test deliberately triggers a stack overflow,
and doesn't catch it, so the error is printed to the console. Previously RangeError
had the wrong prototype, and didn't convert the error into a useful error message,
printing a blank line in the console. Since r91116 we inherit from Error correctly,
and print the error to the console.

* fast/dom/error-to-string-stack-overflow-expected.txt:
* fast/js/script-tests/object-prototype-properties.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fix flakiness dashboard for XP bots with XP in the name instead of WIN
https://bugs.webkit.org/show_bug.cgi?id=64826

Reviewed by Mihai Parparita.

* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

More Chromium rebaselines for r91277.

* platform/chromium-linux/fast/table/align-right-within-left-aligned-div-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/align-right-within-left-aligned-div-expected.png: Added.
* platform/chromium-win/fast/table/align-right-within-left-aligned-div-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Fix leak of QWebPage in errorPageExtension tests
https://bugs.webkit.org/show_bug.cgi?id=64814

Reviewed by Noam Rosenthal.

QWebView::setPage() doesn't take ownership, so the ErrorPages were leaking. So now
allocate them on the stack. This shouldn't change any behavior.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::errorPageExtension):
(tst_QWebPage::errorPageExtensionInIFrames):
(tst_QWebPage::errorPageExtensionInFrameset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] remove BUG_DRT tests that the flakiness dashboard say are passing
https://bugs.webkit.org/show_bug.cgi?id=64819

Reviewed by Ryosuke Niwa.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

   Bring V8's SerializedScriptValue implementation up to date.

https://bugs.webkit.org/show_bug.cgi?id=63481

Source/WebCore:

Patch by Luke Zarko <lukezarko@gmail.com> on 2011-07-15
Reviewed by David Levin.

The HTML5 Structured Clone algorithm (http://www.whatwg.org/specs/web-apps/current-work/multipage/urls.html#safe-passing-of-structured-data) has been updated since the V8 version of SerializedScriptValue was first implemented. This patch aims to bring this implementation up to date. It:

- Introduces the new HTML5 DOM error codes for TIMEOUT_ERR, INVALID_NODE_TYPE_ERR, DATA_CLONE_ERR
- Handles cyclic structures and equality of reference preservation for cloned values
- Allows DataViews to be constructed on the native side using the existing wrapper techniques
- Amends tests and introduces new ones to check for correctness (the bulk of the patch)
- Tolerates the old version of the serialized object format

The patch permits the cloning of JavaScript typed arrays. This functionality is in active use already and was supported (somewhat inefficiently) by the existing code through an artifact of implementation.

Tests: fast/dom/Window/window-postmessage-clone-deep-array.html
       fast/dom/Window/window-postmessage-clone-really-deep-array.html
       fast/dom/Window/window-postmessage-clone.html
       fast/canvas/webgl/array-message-passing.html

* bindings/v8/SerializedScriptValue.cpp:
(WebCore::V8ObjectMap::Writer::writeVersion):
(WebCore::V8ObjectMap::Writer::writeArrayBuffer):
(WebCore::V8ObjectMap::Writer::writeArrayBufferView):
(WebCore::V8ObjectMap::Writer::writeObjectReference):
(WebCore::V8ObjectMap::Writer::writeReferenceCount):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshObject):
(WebCore::V8ObjectMap::Writer::writeGenerateFreshArray):
(WebCore::V8ObjectMap::Writer::doWriteArrayBuffer):
(WebCore::V8ObjectMap::Serializer::Serializer):
(WebCore::V8ObjectMap::Serializer::serialize):
(WebCore::V8ObjectMap::Serializer::StateBase::execDepth):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::AbstractObjectState):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::advance):
(WebCore::V8ObjectMap::Serializer::AbstractObjectState::execDepth):
(WebCore::V8ObjectMap::Serializer::execDepth):
(WebCore::V8ObjectMap::Serializer::push):
(WebCore::V8ObjectMap::Serializer::pop):
(WebCore::V8ObjectMap::Serializer::handleError):
(WebCore::V8ObjectMap::Serializer::writeAndGreyArrayBufferView):
(WebCore::V8ObjectMap::Serializer::writeArrayBuffer):
(WebCore::V8ObjectMap::Serializer::greyObject):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::Reader):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Reader::readVersion):
(WebCore::V8ObjectMap::Reader::setVersion):
(WebCore::V8ObjectMap::Reader::undoReadTag):
(WebCore::V8ObjectMap::Reader::readArrayBufferViewSubTag):
(WebCore::V8ObjectMap::Reader::doReadArrayBuffer):
(WebCore::V8ObjectMap::Reader::readArrayBuffer):
(WebCore::V8ObjectMap::Reader::readArrayBufferView):
(WebCore::V8ObjectMap::Deserializer::Deserializer):
(WebCore::V8ObjectMap::Deserializer::deserialize):
(WebCore::V8ObjectMap::Deserializer::newArray):
(WebCore::V8ObjectMap::Deserializer::consumeTopOfStack):
(WebCore::V8ObjectMap::Deserializer::completeArray):
(WebCore::V8ObjectMap::Deserializer::newObject):
(WebCore::V8ObjectMap::Deserializer::completeObject):
(WebCore::V8ObjectMap::Deserializer::completeSparseArray):
(WebCore::V8ObjectMap::Deserializer::pushObjectReference):
(WebCore::V8ObjectMap::Deserializer::tryGetObjectFromObjectReference):
(WebCore::V8ObjectMap::Deserializer::objectReferenceCount):
(WebCore::V8ObjectMap::Deserializer::openComposite):
(WebCore::V8ObjectMap::Deserializer::closeComposite):
(WebCore::SerializedScriptValue::SerializedScriptValue):
* bindings/v8/V8Binding.cpp:
(WebCore::isHostObject):
* bindings/v8/V8Binding.h:
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallback):
* dom/DOMCoreException.idl:
* dom/ExceptionCode.cpp:
* dom/ExceptionCode.h:
* html/canvas/ArrayBuffer.cpp:
(WebCore::ArrayBuffer::create):
* html/canvas/ArrayBuffer.h:
* html/canvas/DataView.cpp:
(WebCore::DataView::create):
* html/canvas/DataView.h:

LayoutTests:

Patch by Luke Zarko <lukezarko@gmail.com> on 2011-07-15
Reviewed by David Levin.

This patch refactors window-postmessage-clone into a script test, checks additional functionality set forth in the standard, and fixes up expectations. It also checks for typed array message passing.

* fast/canvas/webgl/array-message-passing-expected.txt: Added.
* fast/canvas/webgl/array-message-passing.html: Added.
* fast/canvas/webgl/script-tests/array-message-passing.js: Added.
(classCompare):
(bufferCompare):
(viewCompare):
(typedArrayCompare):
(dataViewCompare):
(createBuffer):
(createTypedArray):
(createTypedArrayOverBuffer):
(testList):
(doneTest):
(windowHandleMessage):
* fast/dom/Window/script-tests/postmessage-clone-deep-array.js: Added.
* fast/dom/Window/script-tests/postmessage-clone-really-deep-array.js: Added.
* fast/dom/Window/script-tests/postmessage-clone.js: Added.
(thunk):
* fast/dom/Window/script-tests/postmessage-test.js: Copied from LayoutTests/fast/dom/Window/window-postmessage-clone.html.
():
(safeToString):
(shouldBe):
(shouldBeIdentical):
(doPass):
(doFail):
(window.doPassFail):
(onmessage):
(ConstructorWithPrototype):
(window.tryPostMessage):
* fast/dom/Window/window-postmessage-clone-deep-array-expected.txt: Added.
* fast/dom/Window/window-postmessage-clone-deep-array.html: Added.
* fast/dom/Window/window-postmessage-clone-expected.txt:
* fast/dom/Window/window-postmessage-clone-really-deep-array-expected.txt: Added.
* fast/dom/Window/window-postmessage-clone-really-deep-array.html: Added.
* fast/dom/Window/window-postmessage-clone.html:
* fast/dom/Window/window-properties-expected.txt: Also fixed this due to r91061.
* platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Added.
* platform/chromium/fast/dom/Window/window-postmessage-clone-deep-array-expected.txt: Added.
* platform/chromium/fast/dom/Window/window-postmessage-clone-expected.txt: Added.
* platform/chromium/fast/dom/Window/window-postmessage-clone-really-deep-array-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-07-19  Rob Buis  <rbuis@rim.com>

        REGRESSION (r91187-r91192): svg/W3C-SVG-1.1/animate-elem-80-t.svg failing on SnowLeopard Intel Debug (Tests)
        https://bugs.webkit.org/show_bug.cgi?id=64820

        Reviewed by Darin Adler.

        Update result after r91192.

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Chromium rebaseline after r91290.

* platform/chromium/fast/js/array-prototype-properties-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Adds some methods to retrieve accessible information from tables and
table cells. Also refactors WebAccessibilityObject to use WebPrivatePtr
instead of its own implementation that didn't allow access to subclasses
of AccessibilityObject.
https://bugs.webkit.org/show_bug.cgi?id=64805

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-07-19
Reviewed by Dimitri Glazkov.

* public/WebAccessibilityObject.h:
(WebKit::WebAccessibilityObject::WebAccessibilityObject):
(WebKit::WebAccessibilityObject::isNull):
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::reset):
(WebKit::WebAccessibilityObject::assign):
(WebKit::WebAccessibilityObject::equals):
(WebKit::WebAccessibilityObject::accessibilityDescription):
(WebKit::WebAccessibilityObject::actionVerb):
(WebKit::WebAccessibilityObject::canSetFocusAttribute):
(WebKit::WebAccessibilityObject::canSetValueAttribute):
(WebKit::WebAccessibilityObject::isValid):
(WebKit::WebAccessibilityObject::childCount):
(WebKit::WebAccessibilityObject::childAt):
(WebKit::WebAccessibilityObject::firstChild):
(WebKit::WebAccessibilityObject::focusedChild):
(WebKit::WebAccessibilityObject::lastChild):
(WebKit::WebAccessibilityObject::nextSibling):
(WebKit::WebAccessibilityObject::parentObject):
(WebKit::WebAccessibilityObject::previousSibling):
(WebKit::WebAccessibilityObject::canSetSelectedAttribute):
(WebKit::WebAccessibilityObject::isAnchor):
(WebKit::WebAccessibilityObject::isChecked):
(WebKit::WebAccessibilityObject::isCollapsed):
(WebKit::WebAccessibilityObject::isFocused):
(WebKit::WebAccessibilityObject::isEnabled):
(WebKit::WebAccessibilityObject::isHovered):
(WebKit::WebAccessibilityObject::isIndeterminate):
(WebKit::WebAccessibilityObject::isLinked):
(WebKit::WebAccessibilityObject::isMultiSelectable):
(WebKit::WebAccessibilityObject::isOffScreen):
(WebKit::WebAccessibilityObject::isPasswordField):
(WebKit::WebAccessibilityObject::isPressed):
(WebKit::WebAccessibilityObject::isReadOnly):
(WebKit::WebAccessibilityObject::isSelected):
(WebKit::WebAccessibilityObject::isVisible):
(WebKit::WebAccessibilityObject::isVisited):
(WebKit::WebAccessibilityObject::boundingBoxRect):
(WebKit::WebAccessibilityObject::helpText):
(WebKit::WebAccessibilityObject::headingLevel):
(WebKit::WebAccessibilityObject::hitTest):
(WebKit::WebAccessibilityObject::keyboardShortcut):
(WebKit::WebAccessibilityObject::performDefaultAction):
(WebKit::WebAccessibilityObject::roleValue):
(WebKit::WebAccessibilityObject::selectionEnd):
(WebKit::WebAccessibilityObject::selectionStart):
(WebKit::WebAccessibilityObject::setFocused):
(WebKit::WebAccessibilityObject::stringValue):
(WebKit::WebAccessibilityObject::title):
(WebKit::WebAccessibilityObject::url):
(WebKit::WebAccessibilityObject::node):
(WebKit::WebAccessibilityObject::document):
(WebKit::WebAccessibilityObject::hasComputedStyle):
(WebKit::WebAccessibilityObject::computedStyleDisplay):
(WebKit::WebAccessibilityObject::accessibilityIsIgnored):
(WebKit::WebAccessibilityObject::lineBreaks):
(WebKit::WebAccessibilityObject::columnCount):
(WebKit::WebAccessibilityObject::rowCount):
(WebKit::WebAccessibilityObject::cellForColumnAndRow):
(WebKit::WebAccessibilityObject::cellColumnIndex):
(WebKit::WebAccessibilityObject::cellColumnSpan):
(WebKit::WebAccessibilityObject::cellRowIndex):
(WebKit::WebAccessibilityObject::cellRowSpan):
(WebKit::WebAccessibilityObject::WebAccessibilityObject):
(WebKit::WebAccessibilityObject::operator=):
(WebKit::WebAccessibilityObject::operator WTF::PassRefPtr<WebCore::AccessibilityObject>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Chromium Windows rebaseline after r91277, and Chromium rebaseline for r91284.

* platform/chromium/fast/js/string-prototype-properties-expected.txt: Added.
* platform/chromium-win/fast/table/align-right-within-left-aligned-div-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Need to remove app/ from DEPS
https://bugs.webkit.org/show_bug.cgi?id=64750

Patch by Robert Sesek <rsesek@chromium.org> on 2011-07-19
Reviewed by Tony Chang.

.:

Remove Source/WebKit/chromium/app/ from .gitignore.

* .gitignore:

Source/WebKit/chromium:

Roll DEPS and remove dependencies on Chromium's /src/app.

* DEPS:
* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-07-19  Simon Fraser  <simon.fraser@apple.com>

        Possible recursion in GraphicsLayerCA::updateGeometry()
        https://bugs.webkit.org/show_bug.cgi?id=64815

        Reviewed by Sam Weinig.

        It was possible to recurse via updateGeometry/swapFromOrToTiledLayer/
        updateContentsScale because updateGeometry() and updateContentsScale()
        used different sizes; updateGeometry() used the scaled size, while
        updateContentsScale() used the unscaled size.

        Always use the unscaled size; the scaled size will be at most a couple
        of pixels bigger, and our threshold is not close to the max texture
        size limit, so using the slightly smaller size is OK.

        Test: compositing/scaling/tiled-layer-recursion.html

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::updateGeometry):
        (WebCore::GraphicsLayerCA::updateLayerDrawsContent):
        (WebCore::GraphicsLayerCA::updateContentsScale):
        (WebCore::GraphicsLayerCA::requiresTiledLayer):
        * platform/graphics/ca/GraphicsLayerCA.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-07-19  Rob Buis  <rbuis@rim.com>

        REGRESSION (r89951): svg/foreignObject/text-tref-02-b.svg failing on Leopard Intel Release (Tests)
        https://bugs.webkit.org/show_bug.cgi?id=64817

        Rubber stamped by Darin Adler.

        Remove outdated, incorrect test results, hopefully the generic mac results are good enough.

        * platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.png: Removed.
        * platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add platform-specific results for r91277.

Unreviewed, add platform-specific results.

* platform/gtk/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
* platform/mac/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
* platform/qt/fast/table/align-right-within-left-aligned-div-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

add myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=64816

No review needed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore: [JSC] WebKit allocates gigabytes of memory when doing repeated string concatenation
https://bugs.webkit.org/show_bug.cgi?id=63918

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-19
Reviewed by Darin Adler.

When allocating JSStrings during concatenation, we needed to call the Heap's reportExtraMemoryCost
method due to additional string copying within several of the constructors when dealing with
UStrings. This has been added to the UString version of the appendStringInConstruct method
within the JSString class.

* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendStringInConstruct):

LayoutTests: Chromium rebaselines r91269 and r91277.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-07-19

* platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
* platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.png: Added.
* platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[JSC] WebKit allocates gigabytes of memory when doing repeated string concatenation
https://bugs.webkit.org/show_bug.cgi?id=63918

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-19
Reviewed by Darin Adler.

When allocating JSStrings during concatenation, we needed to call the Heap's reportExtraMemoryCost
method due to additional string copying within several of the constructors when dealing with
UStrings. This has been added to the UString version of the appendStringInConstruct method
within the JSString class.

* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendStringInConstruct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Chromium rebaselines r91269 and r91277.

* platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
* platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.png: Added.
* platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[CSSRegions]Parse -webkit-region-overflow property
https://bugs.webkit.org/show_bug.cgi?id=64444

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-19
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/webkit-region-overflow-parsing.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator RegionOverflow):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::regionOverflow):
(WebCore::InheritedFlags::setRegionOverflow):
(WebCore::InheritedFlags::initialRegionOverflow):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

* fast/regions/script-tests/webkit-region-overflow-parsing.js: Added.
* fast/regions/webkit-region-overflow-parsing-expected.txt: Added.
* fast/regions/webkit-region-overflow-parsing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

hover then un-hover makes state change
https://bugs.webkit.org/show_bug.cgi?id=56401

Source/WebCore:

When a 'before' pseudo-element is re-added, we should check whether the insertion point is an anonymous
block with inline children. If it is, then we should change the insertion point to the first child of the
anonymous block, otherwise the 'before' pseudo-element ends up in a different block.

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-19
Reviewed by David Hyatt.

Test: fast/dynamic/hover-before-position-after-style-change.html

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-19
Reviewed by David Hyatt.

* fast/dynamic/hover-before-position-after-style-change-expected.txt: Added.
* fast/dynamic/hover-before-position-after-style-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64677
Fix bugs in String.prototype this handling.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

undefined/null this values should throw TypeErrors, not convert to
the global object, and primitive values should not be converted via
object types.

* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::trimString):
    - These methods should throw if this value is undefined,
      convert ToString directly, not via ToObject.

LayoutTests:

* fast/js/script-tests/string-prototype-properties.js: Added.
* fast/js/string-prototype-properties-expected.txt: Added.
* fast/js/string-prototype-properties.html: Added.
    - Added layout test for string prototype functions with undefined/number as this value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Implement CSSPropertyWebkitPerspectiveOrigin in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=64784

Reviewed by Simon Fraser.

No new tests / refactoring.

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rename variable isEmptyTextPatch in svn-{apply, unapply}
https://bugs.webkit.org/show_bug.cgi?id=64648

Reviewed by Adam Roben.

Rename the variable isEmptyTextPatch to hasTextChunks, which is
more descriptive and makes its usage read well in control statements.

* Scripts/svn-apply:
(patch):
* Scripts/svn-unapply:
(patch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Implement WaveShaperNode for Web Audio API
https://bugs.webkit.org/show_bug.cgi?id=64644

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

* DerivedSources.make:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWaveShaperNodeCustom.cpp: Added.
(WebCore::JSWaveShaperNode::setCurve):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createWaveShaper):
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
* webaudio/AudioNode.h:
* webaudio/WaveShaperDSPKernel.cpp: Added.
(WebCore::WaveShaperDSPKernel::process):
* webaudio/WaveShaperDSPKernel.h: Added.
(WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):
(WebCore::WaveShaperDSPKernel::reset):
(WebCore::WaveShaperDSPKernel::waveShaperProcessor):
* webaudio/WaveShaperNode.cpp: Added.
(WebCore::WaveShaperNode::WaveShaperNode):
(WebCore::WaveShaperNode::setCurve):
(WebCore::WaveShaperNode::curve):
* webaudio/WaveShaperNode.h: Added.
(WebCore::WaveShaperNode::create):
(WebCore::WaveShaperNode::waveShaperProcessor):
* webaudio/WaveShaperNode.idl: Added.
* webaudio/WaveShaperProcessor.cpp: Added.
(WebCore::WaveShaperProcessor::WaveShaperProcessor):
(WebCore::WaveShaperProcessor::~WaveShaperProcessor):
(WebCore::WaveShaperProcessor::createKernel):
(WebCore::WaveShaperProcessor::setCurve):
(WebCore::WaveShaperProcessor::process):
* webaudio/WaveShaperProcessor.h: Added.
(WebCore::WaveShaperProcessor::curve):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

DFG JIT sometimes emits spill code even when the respective values
are never needed.
https://bugs.webkit.org/show_bug.cgi?id=64774

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-19
Reviewed by Gavin Barraclough.

The main high-level change is that it is now easier to call use() on a
virtual register. JSValueOperand and its other-typed relatives now have
a handy use() method, and jsValueResult() and friends now make it easier to
pass UseChildrenCalledExplicitly.

The rest of this patch hoists the call to use() as high as possible for
all of those cases where either flushRegisters() or silentSpillAllRegisters()
may be called.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedGetMethod):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):
(JSC::DFG::JITCodeGenerator::emitBranch):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::integerResult):
(JSC::DFG::JITCodeGenerator::jsValueResult):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::DoubleOperand::use):
(JSC::DFG::JSValueOperand::use):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculateStrictInt32Operand::use):
(JSC::DFG::SpeculateCellOperand::use):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Make TestFailures show existing bugs and a new bug link for flaky tests

Fixes <http://webkit.org/b/63728> TestFailures page should make it easy to file bugs about
flaky tests
and
<http://webkit.org/b/63830> TestFailures page doesn't show related bugs for possibly-flaky
tests, but should

Reviewed by Sam Weinig.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
Added. This is what's used to file new bugs about flaky tests.
(FlakyTestBugForm): Calls up to the base class, stores the arguments, and sets our
title, description, and URL.

(FlakyTestBugForm.prototype._createBugDescription):
(FlakyTestBugForm.prototype._createBugTitle):
These do what they say.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
Added. Tests of the above.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(#failure-history > li):
(#possibly-flaky-tests > li):
(#failure-history > li, #possibly-flaky-tests > li):
(#possibly-flaky-tests > li > :first-child):
(.flakiness-examples-list):
Styling to account for the new elements.

(.expandable):
(.expanded > .expandable):
Generalized the .flakiness-example-list code to a generic .expandable class. Removed the
transition properties because we can't transition to/from 'auto' (but really would like
to!).

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder): Moved code to create the FailingTestsBugForm
here from _domForNewAndExistingBugs. Updated for changes to _domForPossiblyFlakyTests.
(ViewController.prototype._domForNewAndExistingBugs): Changed to take a NewBugForm as an
argument instead of creating one ourselves.
(ViewController.prototype._domForPossiblyFlakyTests): Changed to take all analyzed builds as
an argument instead of just the number of analyzed builds. Put the examples list inside a
container <div>, which is also used to hold the new/existing bugs UI. Removed code to deal
with animating the height of the examples list; we don't do this anymore because it's hard
to make it work correctly with the asynchronous loading of existing bugs. When we populate
the examples list, also set up the new/existing bug UI.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
FlakyTestBugForm.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
Pull in FlakyTestBugForm and its tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

REGRESSION: Incorrect layout at recline-online.com
https://bugs.webkit.org/show_bug.cgi?id=64030

Reviewed by David Hyatt.

Source/WebCore:

http://trac.webkit.org/changeset/68362 dropped the check for cases
where the render box is floating or inline. When the box is left or right
aligned it is considered to be floating and needs to its margins set appropriately.

Test: fast/table/align-right-within-left-aligned-div.html
created by Dominic Cooney <dominicc@chromium.org>

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeInlineDirectionMargins):

LayoutTests:

* fast/table/align-right-within-left-aligned-div-expected.png: Added.
* fast/table/align-right-within-left-aligned-div-expected.txt: Added.
* fast/table/align-right-within-left-aligned-div.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ARMv7 backend broken, lacks 3 parameter rshift32 method
https://bugs.webkit.org/show_bug.cgi?id=64571

Reviewed by Zoltan Herczeg.

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::rshift32): add missing rshift32 method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Reviewed by Tony Chang.

Added "missing results" label for tests that are missing results.

buildbot Now reports shows a label "X missing results" on a run when X tests were missing
expected results on that run.

Also rephrased "X failed" and "X were flaky" to "X failures" and "X flakes".

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Extract some of FailingTestsBugForm's code into a base class

Prep work for fixing <http://webkit.org/b/63728> TestFailures page should make it easy to
file bugs about flaky tests

Reviewed by Sam Weinig.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
Moved BugzillaConstants to new WebKitBugzilla file. Moved a bunch of other code from here to
TestRelatedBugForm.js.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
Moved some tests to TestRelatedBugForm_unittests.js.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Added.
(TestRelatedBugForm):
(TestRelatedBugForm.prototype.domElement):
(TestRelatedBugForm.prototype._computeOperatingSystem):
(TestRelatedBugForm.prototype._computePlatform):
Code came from FailingTestsBugForm.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
Added. Tests came from FailingTestsBugForm_unittests.js

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:
Added. Code came from FailingTestsBugForm.js.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
TestRelatedBugForm.js and WebKitBugzilla.js. Moved Bugzilla.js out of the list of files that
need to be pulled in early for parsing reasons.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
Pull in TestRelatedBugForm and tests and WebKitBugzilla.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add back a change that was accidentally removed in r91266.

Make sure to retain the WKPasteboardFilePromiseOwner before calling draggedImage because draggedImage releases
its responder. Also make the comment more explicit, to keep this mistake from being made in the future.

Rubber-stamped by Darin Adler.

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::dragEnded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore: Crash when removing unrenderered nodes in replacement fragment.
https://bugs.webkit.org/show_bug.cgi?id=64801

Reviewed by Ryosuke Niwa.

Test: editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::removeUnrenderedNodes):

LayoutTests: Tests that we do not crash when removing unrendering nodes
in a replacement fragment.
https://bugs.webkit.org/show_bug.cgi?id=64801

Reviewed by Ryosuke Niwa.

* editing/pasteboard/replacement-fragment-remove-unrendered-node-crash-expected.txt: Added.
* editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-07-19  Rob Buis  <rbuis@rim.com>

        https://bugs.webkit.org/show_bug.cgi?id=64673
        REGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/styling-pres-02-f.html

        Reviewed by Nikolas Zimmermann.

        Prevent calling back to the owning SVGTRefElement upon handling DOMSubtreeModified events.

        Test: svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg

        * svg/SVGTRefElement.cpp:
        (WebCore::SubtreeModificationEventListener::handleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

use more specific types in CSSFlexValue
https://bugs.webkit.org/show_bug.cgi?id=64763

Reviewed by Ojan Vafai.

No new tests because no change in functionality.

* css/CSSFlexValue.h:
(WebCore::CSSFlexValue::create):
(WebCore::CSSFlexValue::isFlexValue): Make it possible to tell if
    we're a flex value or not.  Will be needed when we're copying
    values to RenderStyle.
(WebCore::CSSFlexValue::positiveFlex): Use floats for positive and
    negative flex because in the render code, we use floats.
(WebCore::CSSFlexValue::negativeFlex): Add accessors for these since
    we'll need it when reading the flex values.
(WebCore::CSSFlexValue::preferredSize):
(WebCore::CSSFlexValue::CSSFlexValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValidPrimitive): Make the type more
    specific.
(WebCore::CSSParser::parseFlex):
* css/CSSParser.h:
* css/CSSValue.h:
(WebCore::CSSValue::isFlexValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

If the control associated with a <label> is hidden, the label is also hidden (incorrectly)
https://bugs.webkit.org/show_bug.cgi?id=64752

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/label-element-with-hidden-control.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::exposesTitleUIElement):

LayoutTests:

* platform/mac/accessibility/label-element-with-hidden-control-expected.txt: Added.
* platform/mac/accessibility/label-element-with-hidden-control.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Speculative fix for: Crash under WebPage::platformDragEnded when dragging on Mac
https://bugs.webkit.org/show_bug.cgi?id=64766
<rdar://problem/9548174>

Reviewed by Enrica Casucci.

I was unable to reproduce this bug, but Darin Adler and I discussed the probable issue. When starting the drag, we create
a WKPasteboardFilePromiseOwner, and a WKPasteboardOwner. When the drag is concluded, we call a method on the WKPasteboardFilePromiseOwner
which uses the WKPasteboardOwner. However, we are not guaranteeing that the WKPasteboardOwner will be around when the
WKPasteboardFilePromiseOwner method is called.

The fix is to retain both the WKPasteboardFilePromiseOwner and the WKPasteboardOwner that we need, making sure that we are keeping
both objects alive.

This patch also uses r91222 to replace WebPage::platformDragEnded, so WebPage doesn't need to know about the drag source.

* WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::dragEnded): Add a non-Mac stub method, since the Mac is the only platform that does something here.
* WebProcess/WebCoreSupport/WebDragClient.h:
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage): Use member variables instead of local variables.
(WebKit::WebDragClient::dragEnded): Move code from WebPageMac::platformDragEnded to here, and clear both member variables.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::dragEnded): Don't call platformDragEnded anymore. WebCore::DragController::dragEnded calls WebDragClient::dragEnded,
which does the same thing.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm: Remove platformDragEnded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove failing Chromium test expectations after r91224.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: Backend should provide network resource identifiers that are unique across navigation.
https://bugs.webkit.org/show_bug.cgi?id=64746

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::addToFrontend):
* inspector/ConsoleMessage.h:
* inspector/IdentifiersFactory.cpp:
(WebCore::IdentifiersFactory::createIdentifier):
(WebCore::IdentifiersFactory::resourceId):
(WebCore::IdentifiersFactory::addProcessIdPrefixTo):
* inspector/IdentifiersFactory.h:
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
* inspector/InspectorPageAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
(WebCore::InspectorResourceAgent::didReceiveXHRResponse):
(WebCore::InspectorResourceAgent::didCreateWebSocket):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::getResourceContent):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::resourceCreated):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceType):
(WebCore::NetworkResourcesData::resourceType):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::addCachedResource):
(WebCore::NetworkResourcesData::addResourceSharedBuffer):
(WebCore::NetworkResourcesData::data):
(WebCore::NetworkResourcesData::clear):
(WebCore::NetworkResourcesData::ensureNoDataForResourceId):
(WebCore::NetworkResourcesData::ensureFreeSpace):
* inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::resourceId):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createResourceSendRequestData):
(WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
(WebCore::TimelineRecordFactory::createResourceFinishData):
(WebCore::TimelineRecordFactory::createReceiveResourceData):
* inspector/TimelineRecordFactory.h:

LayoutTests:

* inspector/timeline/timeline-network-resource-expected.txt:
* platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix assertion failure seen in plugins/return-npobject.html on Windows XP Debug bots.

Rubber-stamped by Adam Roben.

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveData):
It is possible for a subclass to cancel the load from within didReceiveData, which would
set m_documentLoader to 0.
Remove the assertion I added that the DocumentLoader's frame is non-null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove obsolete Mac NRWT test bots
https://bugs.webkit.org/show_bug.cgi?id=64806

Reviewed by Adam Roben.

Remove "Leopard Intel Release (NRWT)" and "SnowLeopard Intel Release (NRWT)"
which have been disconnected for some time and have been obsoleted by
the main testers using NRWT.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

webkit-patch rebaseline crashes on use
https://bugs.webkit.org/show_bug.cgi?id=64775

Reviewed by Adam Roben.

Fix incorrectly spelled attribute name.

* Scripts/webkitpy/common/net/layouttestresults.py:
The attribute is test_name, not filename.

* Scripts/webkitpy/common/net/layouttestresults_unittest.py:
Add test for tests_matching_failure_types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

REGRESSION (r82194): jvalueToJavaValue() does not correctly set length of String property
https://bugs.webkit.org/show_bug.cgi?id=64730

Reviewed by Alexey Proskuryakov.

Covered by existing tests.

* bridge/jni/v8/JNIUtilityPrivate.cpp:
(JSC::Bindings::jvalueToJavaValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] rebaseline Chromium results after r91249 .
Unreviewed.

Patch by Jeremy Moskovich <jeremy@chromium.org> on 2011-07-19

* platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png: Added.
* platform/chromium-win/fast/speech/input-text-speechbutton-expected.txt: Added.
* platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png: Added.
* platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Web Inspector: add sanity test for shared worker inspector
https://bugs.webkit.org/show_bug.cgi?id=64799

Reviewed by Pavel Feldman.

* src/js/Tests.js:
(.TestSuite.prototype.testSharedWorker):
(.TestSuite.prototype.evaluateInConsole_):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Check in Leopard specific results for Selectors 3 tests.

* platform/mac-leopard/css3/selectors3: Added.
* platform/mac-leopard/css3/selectors3/html: Added.
* platform/mac-leopard/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt.
* platform/mac-leopard/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt.
* platform/mac-leopard/css3/selectors3/xhtml: Added.
* platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-174a-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-174a-expected.txt.
* platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-174b-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-174b-expected.txt.
* platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
* platform/mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
* platform/mac-leopard/css3/selectors3/xml: Added.
* platform/mac-leopard/css3/selectors3/xml/css3-modsel-174a-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-174a-expected.txt.
* platform/mac-leopard/css3/selectors3/xml/css3-modsel-174b-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-174b-expected.txt.
* platform/mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
* platform/mac-leopard/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-07-19  Vitaly Repeshko  <vitalyr@chromium.org>

        [V8] Don't put CSSRuleLists in object groups.
        https://bugs.webkit.org/show_bug.cgi?id=64798

        Reviewed by Pavel Feldman.

        Retention of CSSRuleLists should be implemented using hidden
        references from holder objects. By putting lists in groups we
        artificially extend their lifetimes much more than necessary.

        * bindings/v8/V8GCController.cpp:
        (WebCore::GrouperVisitor::visitDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL] Add ewk_network.cpp|h files.
https://bugs.webkit.org/show_bug.cgi?id=63315

Source/WebCore:

Enable setOnLine(bool) on EFL port as well as Android and Chromium.

Reviewed by Antonio Gomes.

* platform/network/NetworkStateNotifier.cpp:
* platform/network/NetworkStateNotifier.h:

Source/WebKit/efl:

ewk_network.cpp|h files are added to ewk in order to support APIs related to networking.
In addition, ewk_network_state_notifier_online_set() is added to ewk_network.cpp in order
to notify NetworkStateNotifier of network status.

Reviewed by Antonio Gomes.

* CMakeListsEfl.txt:
* ewk/EWebKit.h:
* ewk/ewk_network.cpp: Added.
(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):
(ewk_network_state_notifier_online_set):
* ewk/ewk_network.h:
* ewk/ewk_settings.cpp:
* ewk/ewk_settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] Google Calendar thinks we're mobile
https://bugs.webkit.org/show_bug.cgi?id=63994

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-07-11
Reviewed by Xan Lopez.

Further special-case Google Calendar, for it thinks WebKit+Linux
means mobile, so we also have to spoof the OS.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::userAgent): use the new WebKitGTK+
private API that centralizes the logic now.
* tests/testwebsettings.c: Add tests to make sure the Google
special-cases only apply for the expected domains and when quirks
special-casing is enabled.
(test_non_quirky_user_agents):
(test_webkit_web_settings_user_agent):
* webkit/webkitwebsettings.cpp:
(webkitUserAgent): make it static.
(safariUserAgent): returns a fake Safari in Mac OS X User-Agent.
(initializeDomainsList): moved from FrameLoaderClientGtk.
(isGoogleDomain):ditto.
(isGoogleCalendar): ditto.
(userAgentForURL): ditto.
(webkitWebSettingsUserAgentForUri): centralize the whole
user agent spoofing logic in this new private API that can be used
by the browser to know what's going to happen for a specific URI
and also allows our API testing.
* webkit/webkitwebsettingsprivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: implement import/export for timeline data.
https://bugs.webkit.org/show_bug.cgi?id=64601

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/timeline/timeline-load.html

* English.lproj/localizedStrings.js:
* inspector/InspectorFrontendHost.cpp:
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createFileSelector):
(WebInspector.TimelinePanel.prototype._contextMenu):
(WebInspector.TimelinePanel.prototype._exportToFile):
(WebInspector.TimelinePanel.prototype._importFromFile):
(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype._importNextChunk):
(WebInspector.TimelineModel.prototype._importFromFile):
(WebInspector.TimelineModel.prototype._importFromFile.onError):
(WebInspector.TimelineModel.prototype._exportToFile):
(WebInspector.TimelineModel.prototype._reset):
* inspector/front-end/utilities.js:
():

LayoutTests:

* inspector/timeline/timeline-load-expected.txt: Added.
* inspector/timeline/timeline-load.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add missing expected file after r91191

* platform/qt/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: Rename agentIdentifierPrefix to processId, move out from page agent and make static.
https://bugs.webkit.org/show_bug.cgi?id=64729

Reviewed by Pavel Feldman.

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/IdentifiersFactory.cpp: Added.
(WebCore::IdentifiersFactory::createIdentifier):
* inspector/IdentifiersFactory.h: Added.
(WebCore::IdentifiersFactory::setProcessId):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setProcessId):
* inspector/InspectorController.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameId):
(WebCore::InspectorPageAgent::loaderId):
* inspector/InspectorPageAgent.h:

Source/WebKit/chromium:

* public/WebDevToolsAgent.h:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::setAgentIdentifierPrefix):
(WebKit::WebDevToolsAgentImpl::setProcessId):
* src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix microphone icon placement in speech input control for dir=rtl.
https://bugs.webkit.org/show_bug.cgi?id=64668

Reviewed by Dimitri Glazkov.

Source/WebCore:

Modify default stylesheet to propagate dir=rtl from the outer input
control to the shadow DOM container. This makes the microphone
icon appear on the left for dir=rtl, which is the desired behavior.

Test: fast/speech/speech-bidi-rendering.html

* css/html.css:
(input[x-webkit-speech][dir=rtl]::-webkit-textfield-decoration-container):

LayoutTests:

Added test that verifies placement of microphone icon for dir=rtl.

* fast/speech/speech-bidi-rendering.html: Added.
* platform/mac/fast/speech/speech-bidi-rendering-expected.png: Added.
* platform/mac/fast/speech/speech-bidi-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt][WK2] Make QDesktopWebView::navigationAction method usable in QML.
https://bugs.webkit.org/show_bug.cgi?id=64690

Make the API usable with QML by declaring what's needed
with the macros.

Reviewed by Benjamin Poulain.

* UIProcess/API/qt/qdesktopwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL] Account for the invalid pointer case in WebCore::screenRect()
https://bugs.webkit.org/show_bug.cgi?id=64543

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-19
Reviewed by Antonio Gomes.

Fix a regression introduced in r88245: it assumes the pointer passed
to screenRect() is always valid.
fast/frames/crash-removed-iframe.html proves this is not always true,
so we need to do some sanity check on the pointer before using it.
No new tests as this has been caught by the current test suite.

* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Edit Chromium test expectation for http/tests/websocket/tests/hybi/reserved-opcodes.html.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

new-run-webkit-tests should support --leaks
https://bugs.webkit.org/show_bug.cgi?id=63832

Reviewed by Dirk Pranke.

This may not be sufficient to actually transition over the leaks bot,
but this is a huge step in the right direction.

I had to make parse-malloc-history understand being passed more than
one file (to avoid the silly cat | nonsense in old-run-webkit-tests).

I removed some dead code relating to previous iterations of our crash detection.

I created a new class "LeakDetector" to encapsulate all this logic.
Eventually we should consider pulling that class out of mac.py and
sharing with other ports.  However given that ORWT has had
--leaks support on Mac for almost 7 years and no other port has added
it, leaves me to believe we're in no rush to move LeakDetector.

I've tested --leaks locally.  I suspect there are more bugs to shake out
but it seems to work well enough to start.

I also added support for --guard-malloc, but have not tested it much.  It
should be viewed as experimental at this time.

I also fixed various os.path uses to self._filesystem as I was reading
through the various files to understand how best to fix this bug.

* Scripts/old-run-webkit-tests:
(parseLeaksandPrintUniqueLeaks):
* Scripts/parse-malloc-history:
(main):
* Scripts/webkitpy/common/system/crashlogs.py:
* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/controllers/worker.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/gtk.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/server_process.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Patch by Robin Qiu <robin.qiu@torchmobile.com.cn> on 2011-07-19
Reviewed by Antonio Gomes.

ScrollBar should initialize current position in constructor.
https://bugs.webkit.org/show_bug.cgi?id=39284

When ScrollBar is created, m_currentPos should be initialized to
m_scrollableArea's current scrollPosition. Because scrollbars may
be created after the content of m_scrollableArea has been scrolled.

Source/WebCore:

Test: scrollbars/scrollbar-initial-position.html

* platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar):

LayoutTests:

* scrollbars/scrollbar-initial-position-expected.png: Added.
* scrollbars/scrollbar-initial-position-expected.txt: Added.
* scrollbars/scrollbar-initial-position.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebSocket: Implement hybi framing
https://bugs.webkit.org/show_bug.cgi?id=64522

Reviewed by Kent Tamura.

Source/WebCore:

Implement WebSocket framing protocol which is mainly described in
<http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-4> and
<http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10#section-6>.

Hybi protocol introduces a new frame format which is drastically different from
the old one. Notable differences are:
- Binary data support.
- Fragmentation support: a single message can be fragmented to multiple frames.
- Ping-pong support.
- Masking: frame content of a client must be masked to prevent cross-protocol attacks.

This patch covers the following features:
- Send a pong frame when a ping frame is received.
- Receive fragmented frames.
- Receive masked frames. (Servers do not have to mask frames, but they may if they wish.)

The following features are NOT implemented yet:
- Send or receive binary messages.
- Send a ping message.
- Send fragmented frames. (It is unclear whether this is necessary.)
- Rewrite the frame content by WebSocket protocol extensions (like frame compression).

New tests: http/tests/websocket/tests/hybi/broken-utf8.html
           http/tests/websocket/tests/hybi/fragmented-control-frame.html
           http/tests/websocket/tests/hybi/fragmented-frames.html
           http/tests/websocket/tests/hybi/interleaved-fragments.html
           http/tests/websocket/tests/hybi/long-control-frame.html
           http/tests/websocket/tests/hybi/masked-frames.html
           http/tests/websocket/tests/hybi/pong.html
           http/tests/websocket/tests/hybi/reserved-bits.html
           http/tests/websocket/tests/hybi/reserved-opcodes.html
           http/tests/websocket/tests/hybi/too-long-payload.html

* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::send):
The original content of send() was moved to a private method sendFrameHixie76().
(WebCore::WebSocketChannel::fail):
Stop handling incoming data after the WebSocket connection is failed.
It was unclear to me whether we should do the same thing for hixie-76 connection;
for now, I kept the original behavior.
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::resumeTimerFired):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::closingTimerFired):
(WebCore::WebSocketChannel::parseFrame):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::processFrameHixie76):
(WebCore::WebSocketChannel::sendFrame):
(WebCore::WebSocketChannel::sendFrameHixie76):
* websockets/WebSocketChannel.h:
(WebCore::WebSocketChannel::isNonControlOpCode):
(WebCore::WebSocketChannel::isControlOpCode):
(WebCore::WebSocketChannel::isReservedOpCode):

LayoutTests:

Fix existing tests so they match the new frame format, and add tests for the new frame types
and error conditions related to the new frame format.

Unskip hybi tests on mac, win and chromium. Other ports (wk2, qt and gtk) still skip these tests
because they do not support changing the value of "WebKitHixie76WebSocketProtocolEnabled"
preference key via layoutTestController.overridePreferences() yet.

* http/tests/websocket/tests/hybi/broken-utf8-expected.txt: Added.
* http/tests/websocket/tests/hybi/broken-utf8.html: Added.
* http/tests/websocket/tests/hybi/broken-utf8_wsh.py: Added.
* http/tests/websocket/tests/hybi/client-close-expected.txt:
* http/tests/websocket/tests/hybi/client-close.html:
The format of a close frame has been changed. Currently, we do not include any payload
in a close frame, thus it must start with "\x88\x80" (see section 4.1 of hybi-10
specification for more details).
* http/tests/websocket/tests/hybi/client-close_wsh.py:
* http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt: Added.
* http/tests/websocket/tests/hybi/fragmented-control-frame.html: Added.
* http/tests/websocket/tests/hybi/fragmented-control-frame_wsh.py: Added.
* http/tests/websocket/tests/hybi/fragmented-frames-expected.txt: Added.
* http/tests/websocket/tests/hybi/fragmented-frames.html: Added.
* http/tests/websocket/tests/hybi/fragmented-frames_wsh.py: Added.
* http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt: Added.
* http/tests/websocket/tests/hybi/interleaved-fragments.html: Added.
* http/tests/websocket/tests/hybi/interleaved-fragments_wsh.py: Added.
* http/tests/websocket/tests/hybi/long-control-frame-expected.txt: Added.
* http/tests/websocket/tests/hybi/long-control-frame.html: Added.
* http/tests/websocket/tests/hybi/long-control-frame_wsh.py: Added.
* http/tests/websocket/tests/hybi/masked-frames-expected.txt: Added.
* http/tests/websocket/tests/hybi/masked-frames.html: Added.
* http/tests/websocket/tests/hybi/masked-frames_wsh.py: Added.
* http/tests/websocket/tests/hybi/pong-expected.txt: Added.
* http/tests/websocket/tests/hybi/pong.html: Added.
* http/tests/websocket/tests/hybi/pong_wsh.py: Added.
* http/tests/websocket/tests/hybi/reserved-bits-expected.txt: Added.
* http/tests/websocket/tests/hybi/reserved-bits.html: Added.
* http/tests/websocket/tests/hybi/reserved-bits_wsh.py: Added.
* http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt: Added.
* http/tests/websocket/tests/hybi/reserved-opcodes.html: Added.
* http/tests/websocket/tests/hybi/reserved-opcodes_wsh.py: Added.
* http/tests/websocket/tests/hybi/send2_wsh.py:
Send two text frames at once.
* http/tests/websocket/tests/hybi/too-long-payload-expected.txt: Added.
* http/tests/websocket/tests/hybi/too-long-payload.html: Added.
* http/tests/websocket/tests/hybi/too-long-payload_wsh.py: Added.
* platform/chromium/test_expectations.txt:
Derive test expectations of hixie76 tests, because these tests are likely to behave
the same way as hixie76 tests. Will be checked later whether they really do.
* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-07-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        REGRESSION (r88913): Preview in Safari's snippet editor has a fixed height instead of filling the entire pane
        https://bugs.webkit.org/show_bug.cgi?id=64059

        REGRESSION (r88913): <object> has wrong computed height
        https://bugs.webkit.org/show_bug.cgi?id=62769

        Reviewed by Rob Buis.

        Add new layout test in fast/css covering both bugs.
        Update svg/zoom/page results (this is a progression, but the test itself remains broken, see comment inline).

        * fast/css/replaced-element-implicit-size.html: Added.
        * platform/mac/fast/css/replaced-element-implicit-size-expected.png: Added.
        * platform/mac/fast/css/replaced-element-implicit-size-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png:
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt:

2011-07-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        REGRESSION (r88913): Preview in Safari's snippet editor has a fixed height instead of filling the entire pane
        https://bugs.webkit.org/show_bug.cgi?id=64059

        REGRESSION (r88913): <object> has wrong computed height
        https://bugs.webkit.org/show_bug.cgi?id=62769

        Reviewed by Rob Buis.

        Fix misinterpretation of CSS 2.1 - "10.5 Content height: the 'height' property".
        It says "If the height of the containing block is not specified explicitelz (i.e. it depends on the
        content height), and this element is not absolutely positioned, the value computes to 'auto'".

        Checking whether the containing block height depends on the content height is not equal to checking
        whether the height property is set on the containing block, there are other ways to implicitly specify
        the height by setting top & bottom. Fix that by checking whether the containing block has a height
        property or top & bottom set.

        While I was at it, make computeReplacedLogicalWidth/Height a bit more explicit to make it easier to compare
        the code with the spec quoatations - this doesn't change the functionality only the readability.

        Test: fast/css/replaced-element-implicit-size.html

        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::computeReplacedLogicalWidth): Cleanup comment, make code more explicit.
        (WebCore::RenderReplaced::logicalHeightIsAuto): Add helper method used by computeReplacedLogicalHeight.
        (WebCore::RenderReplaced::computeReplacedLogicalHeight): Fix height=auto detection.
        * rendering/RenderReplaced.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91242 268f45cc-cd09-0410-ab3c-d52691b4dbfc