commit-queue@webkit.org [Fri, 3 Sep 2010 06:03:38 +0000 (06:03 +0000)]
2010-09-02 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Do not override custom compile flags
https://bugs.webkit.org/show_bug.cgi?id=45125
Set a default build type if and only if user did not define one as
command line options and he did not give custom CFLAGS or CXXFLAGS.
Otherwise, flags from default build type would override user-defined
ones.
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 3 Sep 2010 05:41:27 +0000 (05:41 +0000)]
2010-09-02 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Fix double addition of -fPIC
https://bugs.webkit.org/show_bug.cgi?id=45122
When SHARED_CORE=ON, -fPIC is automatically added because all
libraries are dynamic. Only when static libraries are built that
-fPIC needs to be manually inserted (because the final library,
libewebkit.so, is dynamic).
* cmake/OptionsCommon.cmake: Remove -fPIC flag.
* cmake/WebKitHelpers.cmake: Add -fPIC flags iff SHARED_CORE=ON.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Fri, 3 Sep 2010 05:22:07 +0000 (05:22 +0000)]
2010-09-02 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Remove obsolete public/API methods in chromium port
https://bugs.webkit.org/show_bug.cgi?id=45108
* public/WebSpeechInputController.h:
(WebKit::WebSpeechInputController::startRecognition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 3 Sep 2010 05:05:44 +0000 (05:05 +0000)]
2010-09-02 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add page reload test to dom-breakpoints.html
https://bugs.webkit.org/show_bug.cgi?id=44837
* inspector/dom-breakpoints-expected.txt:
* inspector/dom-breakpoints.html:
2010-09-02 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: persist DOM breakpoints between page reloads
https://bugs.webkit.org/show_bug.cgi?id=44837
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointItem):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.path):
(WebInspector.DOMNode.prototype.setBreakpoint):
(WebInspector.DOMNode.prototype.hasBreakpoint):
(WebInspector.DOMNode.prototype.removeBreakpoint):
(WebInspector.DOMNode.prototype.removeBreakpoints):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMAgent.prototype._removeBreakpoints):
(WebInspector.DOMBreakpointManager):
(WebInspector.DOMBreakpointManager.prototype.setBreakpoint):
(WebInspector.DOMBreakpointManager.prototype.removeBreakpointsForNode):
(WebInspector.DOMBreakpointManager.prototype._breakpointRemoved):
(WebInspector.DOMBreakpointManager.prototype.restoreBreakpoints.restoreBreakpointsForNode):
(WebInspector.DOMBreakpointManager.prototype.restoreBreakpoints):
(WebInspector.DOMBreakpoint):
(WebInspector.DOMBreakpoint.prototype.get nodeId):
(WebInspector.DOMBreakpoint.prototype.get type):
(WebInspector.DOMBreakpoint.prototype.set enabled):
(WebInspector.DOMBreakpoint.prototype.remove):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.reset):
(WebInspector.ElementsPanel.prototype.setDocument):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 3 Sep 2010 04:49:14 +0000 (04:49 +0000)]
2010-09-02 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Move updateWidget into FrameView from RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=45065
I also made updateWidget() virtual on HTMLPlugInImageElement.
I'm not yet sure that updateWidget belongs on HTMLElement since
I'm not sure that HTMLMediaElement's use of the updateWidget
infrastructure is correct.
I also got rid of the strange !m_replacementText.isEmpty() checks
by making a pluginCrashedOrWasMissing() call which seems to embody
the idea behind that check and hides the screwy details.
I noticed a couple methods on HTMLPlugInImageElement were public
which did not need to be. Fixed.
No functional change, thus no tests.
* html/HTMLEmbedElement.h:
* html/HTMLObjectElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
* html/HTMLPlugInImageElement.h:
(WebCore::HTMLPlugInImageElement::serviceType):
(WebCore::HTMLPlugInImageElement::url):
* page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
(WebCore::FrameView::updateWidgets):
* page/FrameView.h:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::pluginCrashedOrWasMissing):
(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::paintReplaced):
* rendering/RenderEmbeddedObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 3 Sep 2010 04:28:12 +0000 (04:28 +0000)]
2010-09-02 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Move updateWidget implementations into the DOM
https://bugs.webkit.org/show_bug.cgi?id=45058
Unfortunately it's not yet possible to share an updateWidget
implementation between <embed> and <object>. That would amount to
(positive) functional changes for <embed> which I'd will separate
into a later patch. I will also have to untangle <object>'s <param>
walk from its url/serviceType calculations.
However after this patch it's slap-you-across-the-face obvious that
RenderEmbeddedObject::updateWidget was the wrong place for this code.
RenderEmbeddedObject::updateWidget still exists, but only as a
pseudo-virtual-method dispatcher. Unless we add updateWidget() to
HTMLElement, we won't be able to use real virtual dispatch.
I may need to consider making "having a widget" a has-a relationship
with some sort of WidgetContainer object which Media and Plugin can
share. Or its also possible that Media's use of the widget code here
is just wrong. Certainly now that updateWidget was moved into HTMLMediaElement
it becomes obvious that HTMLMediaElement has duplicate code for updating widgets.
No functional changes, thus no tests.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
* html/HTMLEmbedElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateWidget):
* html/HTMLMediaElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
* html/HTMLObjectElement.h:
(WebCore::HTMLObjectElement::useFallbackContent):
* html/HTMLPlugInImageElement.h:
(WebCore::HTMLPlugInImageElement::needsWidgetUpdate):
(WebCore::HTMLPlugInImageElement::setNeedsWidgetUpdate):
* loader/FrameLoader.cpp:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::updateWidget):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 3 Sep 2010 04:04:29 +0000 (04:04 +0000)]
2010-09-02 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Move more code from RenderEmbeddedObject into the DOM
https://bugs.webkit.org/show_bug.cgi?id=45055
No logic changes here, just taking the code which
I ripped out of RenderEmbeddedObject::updateWidget
into static methods before and moving it into
the applicable DOM classes.
HTMLObjectElement::parametersForPlugin does too much
but in order to fix it I may need to add a PluginParameters
class so we can ask things about the parameters. <object>
needs to get multiple bits of information out of its parameters
array. Right now it does it all in one walk. In order to share
code with HTMLEmbedElement, we need the "generate the params array"
code to be separate from the "make advanced <object> specific decision
from the params array". But that will need to be in a later patch.
No functional changes, thus no tests.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parametersForPlugin):
* html/HTMLEmbedElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::createClassIdToTypeMap):
(WebCore::serviceTypeForClassId):
(WebCore::mapDataParamToSrc):
(WebCore::HTMLObjectElement::parametersForPlugin):
(WebCore::HTMLObjectElement::hasFallbackContent):
* html/HTMLObjectElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):
(WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
(WebCore::HTMLPlugInImageElement::detach):
(WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
(WebCore::HTMLPlugInImageElement::updateWidgetCallback):
* html/HTMLPlugInImageElement.h:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::updateWidgetForObjectElement):
(WebCore::updateWidgetForEmbedElement):
(WebCore::RenderEmbeddedObject::updateWidget):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 3 Sep 2010 03:45:06 +0000 (03:45 +0000)]
2010-09-02 François Sausset <sausset@gmail.com>
Reviewed by Darin Adler.
MathML mo element should render "hyphen-minus" as "minus sign" (Unicode glyph names).
https://bugs.webkit.org/show_bug.cgi?id=43629
* mathml/presentation/mo.xhtml:
* platform/mac/mathml/presentation/mo-expected.checksum:
* platform/mac/mathml/presentation/mo-expected.png:
* platform/mac/mathml/presentation/mo-expected.txt:
2010-09-02 François Sausset <sausset@gmail.com>
Reviewed by Darin Adler.
MathML mo element should render "hyphen-minus" as "minus sign" (Unicode glyph names).
https://bugs.webkit.org/show_bug.cgi?id=43629
Test: mathml/presentation/mo.xhtml
* mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::updateFromElement):
* mathml/RenderMathMLOperator.h:
(WebCore::convertHyphenMinusToMinusSign):
* platform/text/CharacterNames.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 3 Sep 2010 03:16:13 +0000 (03:16 +0000)]
2010-09-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add a unit test for commit-queue retries
https://bugs.webkit.org/show_bug.cgi?id=45162
I think commit-queue retries are not correctly avoiding
build and test on retries. So I started testing the code.
Unfortunately this test did not find the bug. But now
that we have the test we might as well keep it.
I also fixed a broken import in validate-committer-lists.
* Scripts/validate-committer-lists:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 3 Sep 2010 02:16:58 +0000 (02:16 +0000)]
2010-09-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Actually parse a URL from ParsedURL
https://bugs.webkit.org/show_bug.cgi?id=45080
This patch only handles standard URLs. At some point we'll need to
distinguish between standard URLs and other kinds of URLs.
* wtf/url/api/ParsedURL.cpp:
(WTF::ParsedURL::ParsedURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 3 Sep 2010 02:11:37 +0000 (02:11 +0000)]
2010-09-02 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
* platform/chromium/drt_expectations.txt: Remove another duplicate.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 3 Sep 2010 02:10:37 +0000 (02:10 +0000)]
2010-09-02 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Add red-black tree capable of holding plain old data (POD)
https://bugs.webkit.org/show_bug.cgi?id=45059
Adding an augmentable red-black tree capable of holding Plain Old
Data (POD), or classes bottoming out into only POD, and an
associated PODArena. Note that the PODArena will be used by other
classes to allocate temporary structures, which is why it is not
just an implementation detail of the red-black tree.
These classes are being placed under WebCore/platform/graphics/gpu
for the time being. If they are generalized to hold even data
types which internally perform dynamic memory allocation, we may
consider moving them to WTF in the future.
Unit tests for the PODRedBlackTree will be integrated separately
under bug 45060.
* WebCore.gypi:
* platform/graphics/gpu/PODArena.h: Added.
(WebCore::PODArena::Allocator::~Allocator):
(WebCore::PODArena::FastMallocAllocator::create):
(WebCore::PODArena::FastMallocAllocator::allocate):
(WebCore::PODArena::FastMallocAllocator::free):
(WebCore::PODArena::FastMallocAllocator::FastMallocAllocator):
(WebCore::PODArena::create):
(WebCore::PODArena::allocateObject):
(WebCore::PODArena::~PODArena):
(WebCore::PODArena::PODArena):
(WebCore::PODArena::minAlignment):
(WebCore::PODArena::roundUp):
(WebCore::PODArena::Chunk::Chunk):
(WebCore::PODArena::Chunk::~Chunk):
(WebCore::PODArena::Chunk::allocate):
* platform/graphics/gpu/PODRedBlackTree.h: Added.
(WebCore::PODRedBlackTree::Visitor::~Visitor):
(WebCore::PODRedBlackTree::PODRedBlackTree):
(WebCore::PODRedBlackTree::~PODRedBlackTree):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::setNeedsFullOrderingComparisons):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):
(WebCore::PODRedBlackTree::setVerboseDebugging):
(WebCore::PODRedBlackTree::Node::Node):
(WebCore::PODRedBlackTree::Node::~Node):
(WebCore::PODRedBlackTree::Node::color):
(WebCore::PODRedBlackTree::Node::setColor):
(WebCore::PODRedBlackTree::Node::data):
(WebCore::PODRedBlackTree::Node::copyFrom):
(WebCore::PODRedBlackTree::Node::left):
(WebCore::PODRedBlackTree::Node::setLeft):
(WebCore::PODRedBlackTree::Node::right):
(WebCore::PODRedBlackTree::Node::setRight):
(WebCore::PODRedBlackTree::Node::parent):
(WebCore::PODRedBlackTree::Node::setParent):
(WebCore::PODRedBlackTree::root):
(WebCore::PODRedBlackTree::updateNode):
(WebCore::PODRedBlackTree::treeSearch):
(WebCore::PODRedBlackTree::treeSearchNormal):
(WebCore::PODRedBlackTree::treeSearchFullComparisons):
(WebCore::PODRedBlackTree::treeInsert):
(WebCore::PODRedBlackTree::treeSuccessor):
(WebCore::PODRedBlackTree::treeMinimum):
(WebCore::PODRedBlackTree::propagateUpdates):
(WebCore::PODRedBlackTree::leftRotate):
(WebCore::PODRedBlackTree::rightRotate):
(WebCore::PODRedBlackTree::insertNode):
(WebCore::PODRedBlackTree::deleteFixup):
(WebCore::PODRedBlackTree::deleteNode):
(WebCore::PODRedBlackTree::visitInorderImpl):
(WebCore::PODRedBlackTree::Counter::Counter):
(WebCore::PODRedBlackTree::Counter::visit):
(WebCore::PODRedBlackTree::Counter::count):
(WebCore::PODRedBlackTree::checkInvariantsFromNode):
(WebCore::PODRedBlackTree::logIfVerbose):
(WebCore::PODRedBlackTree::dumpFromNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 3 Sep 2010 01:58:10 +0000 (01:58 +0000)]
2010-09-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add ParsedURL and URLString to WTFURL API
https://bugs.webkit.org/show_bug.cgi?id=45078
Currently there's no actual URL parsing going on, but this patch is a
start to sketching out the API.
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/url/api/ParsedURL.cpp: Added.
(WTF::ParsedURL::ParsedURL):
(WTF::ParsedURL::scheme):
(WTF::ParsedURL::username):
(WTF::ParsedURL::password):
(WTF::ParsedURL::host):
(WTF::ParsedURL::port):
(WTF::ParsedURL::path):
(WTF::ParsedURL::query):
(WTF::ParsedURL::fragment):
(WTF::ParsedURL::segment):
* wtf/url/api/ParsedURL.h: Added.
(WTF::ParsedURL::spec):
* wtf/url/api/URLString.h: Added.
(WTF::URLString::URLString):
(WTF::URLString::string):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 3 Sep 2010 01:53:57 +0000 (01:53 +0000)]
2010-09-02 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
* platform/chromium/drt_expectations.txt:
Remove a duplicated entry I made in the prior commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 3 Sep 2010 01:51:23 +0000 (01:51 +0000)]
2010-09-02 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove dependency to base/task.h and base/timer.h
https://bugs.webkit.org/show_bug.cgi?id=45091
* DEPS: Roll Chromium revision to 58277 in order to have
webkit_support::PostDelayedTask().
2010-09-02 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove dependency to base/task.h and base/timer.h
https://bugs.webkit.org/show_bug.cgi?id=45091
Task.{cpp,h} introduces a simpler version of Chromium
base/task.h. It doesn't have TupleN and Method.
* DumpRenderTree/DumpRenderTree.gypi:
Add Task.cpp and Task.h
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
(DRTDevToolsAgent::DRTDevToolsAgent):
(DRTDevToolsAgent::reset):
(DRTDevToolsAgent::asyncCall):
(DRTDevToolsAgent::frontendLoaded):
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
(DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
* DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::DRTDevToolsClient):
(DRTDevToolsClient::~DRTDevToolsClient):
(DRTDevToolsClient::reset):
(DRTDevToolsClient::asyncCall):
* DumpRenderTree/chromium/DRTDevToolsClient.h:
(DRTDevToolsClient::taskList): Added to use MethodTask<T>.
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::reset):
(EventSender::scheduleAsynchronousClick):
* DumpRenderTree/chromium/EventSender.h:
(EventSender::taskList): Added to use MethodTask<T>.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::WorkQueue::processWorkSoon):
(LayoutTestController::waitUntilDone):
(LayoutTestController::notifyDone):
(LayoutTestController::reset):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::taskList): Added to use MethodTask<T>.
(LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
* DumpRenderTree/chromium/NotificationPresenter.cpp:
(deferredDisplayDispatch):
(NotificationPresenter::show):
* DumpRenderTree/chromium/Task.cpp: Added.
* DumpRenderTree/chromium/Task.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 3 Sep 2010 01:38:51 +0000 (01:38 +0000)]
2010-09-02 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Martin Robinson.
[Cairo] Remove glib dependency (caused by use of GOwnPtr)
https://bugs.webkit.org/show_bug.cgi?id=45053
Use OwnPtr instead of GOwnPtr to keep track of Fc* references
in FontCacheCairo.cpp.
No features added, so no new tests.
* CMakeListsEfl.txt: Updating build system to look for GOwnPtrCairo.*
* GNUmakefile.am: Ditto.
* platform/graphics/cairo/FontCacheCairo.cpp: Using OwnPtr instead of GOwnPtr.
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/cairo/GOwnPtrCairo.cpp: Removed.
* platform/graphics/cairo/GOwnPtrCairo.h: Removed.
* platform/graphics/cairo/OwnPtrCairo.cpp: Added.
(WTF::FcPattern):
(WTF::FcObjectSet):
(WTF::FcFontSet):
* platform/graphics/cairo/OwnPtrCairo.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 3 Sep 2010 01:20:00 +0000 (01:20 +0000)]
2010-09-02 Kent Tamura <tkent@chromium.org>
Unreviewed, update test expectation.
* platform/chromium/drt_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Fri, 3 Sep 2010 01:08:21 +0000 (01:08 +0000)]
2010-09-02 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, updating binding-tests expectations (for changeset 66521).
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::stringAttrAttrSetter):
(WebCore::TestObjInternal::reflectedStringAttrAttrSetter):
(WebCore::TestObjInternal::reflectedURLAttrAttrSetter):
(WebCore::TestObjInternal::reflectedNonEmptyURLAttrAttrSetter):
(WebCore::TestObjInternal::reflectedCustomURLAttrAttrSetter):
(WebCore::TestObjInternal::reflectedCustomNonEmptyURLAttrAttrSetter):
(WebCore::TestObjInternal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjInternal::stringAttrWithSetterExceptionAttrSetter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Fri, 3 Sep 2010 00:55:59 +0000 (00:55 +0000)]
2010-09-02 Zhenyao Mo <zmo@google.com>
Unreviewed.
Updateing chromium test_expectations for flaky http/tests/security/xssAuditor/dom-write-innerHTML.html.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Fri, 3 Sep 2010 00:47:38 +0000 (00:47 +0000)]
2010-09-02 Zhenyao Mo <zmo@google.com>
Unreviewed.
Updateing chromium test_expectations for flaky editing/selection/extend-selection.html.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 3 Sep 2010 00:01:28 +0000 (00:01 +0000)]
2010-09-02 James Robinson <jamesr@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37830
Fix an ordering issue in this test. The isSuccessfullyParsed
function is not defined until the onload event, so avoid running
the script body until this point.
* fast/events/touch/script-tests/send-oncancel-event.js:
(window.onload):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 2 Sep 2010 23:57:46 +0000 (23:57 +0000)]
2010-09-02 Tony Chang <tony@chromium.org>
Unreviewed, updating chromium test_expectations for a failure
introduced in r66689.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 2 Sep 2010 23:57:22 +0000 (23:57 +0000)]
Add ability to send WKDictionaryRefs via post message.
https://bugs.webkit.org/show_bug.cgi?id=45151
Reviewed by Anders Carlsson.
* Shared/ImmutableDictionary.cpp:
(WebKit::ImmutableDictionary::ImmutableDictionary):
* Shared/ImmutableDictionary.h:
(WebKit::ImmutableDictionary::adopt): Remove tag, it wasn't doing anything.
(WebKit::ImmutableDictionary::isMutable):
(WebKit::ImmutableDictionary::map): Add accessor of internal
map for encoder.
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encoder/decoder.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Thu, 2 Sep 2010 23:47:13 +0000 (23:47 +0000)]
Skip one time-out test for now.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Thu, 2 Sep 2010 23:26:58 +0000 (23:26 +0000)]
2010-09-02 Zhenyao Mo <zmo@google.com>
Unreviewed. Flag a few flaky tests:
fast/forms/select-baseline.html
fast/forms/input-spinbutton-capturing.html
fast/forms/input-number-events.html
fast/replaced/embed-display-none.html
media/video-timeupdate-during-playback.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Thu, 2 Sep 2010 23:14:50 +0000 (23:14 +0000)]
Improve tests for blob URL.
https://bugs.webkit.org/show_bug.cgi?id=45132
Reviewed by Darin Fisher.
Change apply-blob-url-to-xhr.html to produce text based result. Also
add the test case for revokeBlobURL in apply-blob-url-to-xhr.html
and work-apply-blob-url-to-xhr.html.
* fast/files/apply-blob-url-to-img-expected.txt: Added.
* fast/files/apply-blob-url-to-img.html:
* fast/files/apply-blob-url-to-xhr-expected.txt:
* fast/files/apply-blob-url-to-xhr.html:
* fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
(sendXMLHttpRequest):
(onmessage):
* fast/files/workers/worker-apply-blob-url-to-xhr-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/mac/Skipped:
* platform/mac/fast/files/apply-blob-url-to-img-expected.checksum: Removed.
* platform/mac/fast/files/apply-blob-url-to-img-expected.png: Removed.
* platform/mac/fast/files/apply-blob-url-to-img-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 2 Sep 2010 22:57:49 +0000 (22:57 +0000)]
2010-09-02 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
[chromium] fix memory corruption in Khmer rendering.
* fast/text/khmer-crash-expected.txt: Added.
* fast/text/khmer-crash.html: Added.
2010-09-02 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
[chromium] fix memory corruption in Khmer rendering.
https://bugs.webkit.org/show_bug.cgi?id=44960
Test: fast/text/khmer-crash.html
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::TextRunWalker::shapeGlyphs):
The Khmer shaper has a bug where it would request larger output
buffers, but request a zero increase in size. Because of this we add
one to the requested size.
(WebCore::TextRunWalker::setGlyphXPositions):
The Khmer shaper is outputing cluster logs which suggest that some
output glyphs appear from nowhere (i.e. have no input codepoints). I
don't know Khmer, so maybe that's correct, but it broke the
assumptions of this code, causing a read out-of-bounds.
* platform/graphics/chromium/HarfbuzzSkia.cpp:
(WebCore::stringToGlyphs):
The Harfbuzz interfaces aren't documented, but it appears that the
output array to stringToGlyphs isn't sized and that Harfbuzz expects
us to detect when the input is too long.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 2 Sep 2010 22:52:18 +0000 (22:52 +0000)]
Share the common parts of UserMessage coding between both processes.
https://bugs.webkit.org/show_bug.cgi?id=45139
Reviewed by Anders Carlsson.
Add base classes UserMessageEncoder and UserMessageDecoder which implement
encoding/decoding of ImmutableArray and String (soon to be others as well, such
as ImmutableDictionary, Data, etc.) and add derived classes which implement the
process specific bits such as Page -> BundlePage conversion.
* Shared/UserMessageCoders.h: Copied from WebProcess/InjectedBundle/InjectedBundle.cpp.
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageEncoder::UserMessageEncoder):
(WebKit::UserMessageDecoder::baseDecode):
(WebKit::UserMessageDecoder::UserMessageDecoder):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveMessage):
* UIProcess/WebContextUserMessageCoders.h: Copied from UIProcess/WebContext.cpp.
(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::WebContextUserMessageDecoder):
(WebKit::WebContextUserMessageDecoder::decode):
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::didReceiveMessage):
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h: Copied from WebProcess/InjectedBundle/InjectedBundle.cpp.
(WebKit::InjectedBundleUserMessageEncoder::InjectedBundleUserMessageEncoder):
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::InjectedBundleUserMessageDecoder):
(WebKit::InjectedBundleUserMessageDecoder::decode):
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Thu, 2 Sep 2010 22:24:01 +0000 (22:24 +0000)]
2010-09-02 Zhenyao Mo <zmo@google.com>
Unreviewed, add two failing tests (http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html) to platform/chromium/test_expectations.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 2 Sep 2010 21:35:40 +0000 (21:35 +0000)]
2010-09-02 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
dumpAsText conversion: editing/pasteboard/select-element-1.html, editing/deleting/delete-br-012.html, and editing/deleting/delete-select-all-001.html
https://bugs.webkit.org/show_bug.cgi?id=45121
Converted tests.
* editing/deleting/delete-br-012-expected.txt: Added.
* editing/deleting/delete-br-012.html:
* editing/deleting/delete-select-all-001-expected.txt: Added.
* editing/deleting/delete-select-all-001.html:
* editing/pasteboard/select-element-1-expected.txt: Added.
* editing/pasteboard/select-element-1.html:
* platform/chromium-linux/editing/deleting/delete-br-012-expected.checksum: Removed.
* platform/chromium-linux/editing/deleting/delete-br-012-expected.png: Removed.
* platform/chromium-linux/editing/deleting/delete-select-all-001-expected.checksum: Removed.
* platform/chromium-linux/editing/pasteboard/select-element-1-expected.checksum: Removed.
* platform/chromium-linux/editing/pasteboard/select-element-1-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/select-element-1-expected.txt: Removed.
* platform/chromium-win/editing/deleting/delete-br-012-expected.checksum: Removed.
* platform/chromium-win/editing/deleting/delete-br-012-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-br-012-expected.txt: Removed.
* platform/chromium-win/editing/deleting/delete-select-all-001-expected.checksum: Removed.
* platform/chromium-win/editing/deleting/delete-select-all-001-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/select-element-1-expected.checksum: Removed.
* platform/chromium-win/editing/pasteboard/select-element-1-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/select-element-1-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/select-element-1-expected.checksum: Removed.
* platform/mac-leopard/editing/pasteboard/select-element-1-expected.png: Removed.
* platform/mac/editing/deleting/delete-br-012-expected.checksum: Removed.
* platform/mac/editing/deleting/delete-br-012-expected.png: Removed.
* platform/mac/editing/deleting/delete-br-012-expected.txt: Removed.
* platform/mac/editing/deleting/delete-select-all-001-expected.checksum: Removed.
* platform/mac/editing/deleting/delete-select-all-001-expected.png: Removed.
* platform/mac/editing/deleting/delete-select-all-001-expected.txt: Removed.
* platform/mac/editing/pasteboard/select-element-1-expected.checksum: Removed.
* platform/mac/editing/pasteboard/select-element-1-expected.png: Removed.
* platform/mac/editing/pasteboard/select-element-1-expected.txt: Removed.
* platform/qt/editing/deleting/delete-br-012-expected.txt: Removed.
* platform/qt/editing/deleting/delete-select-all-001-expected.txt: Removed.
* platform/qt/editing/pasteboard/select-element-1-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Thu, 2 Sep 2010 21:22:57 +0000 (21:22 +0000)]
2010-09-02 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
https://bugs.webkit.org/show_bug.cgi?id=43181
* WebKit.xcodeproj/project.pbxproj:
2010-09-02 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
https://bugs.webkit.org/show_bug.cgi?id=43181
This patch hooks up the mock device orientation client on Mac for use
in DumpRenderTree.
The patch adds a new WebDeviceOrientationClient for Mac. This client acts
as a proxy to either a real or mock device orientation provider, both of
which implement a new WebDeviceOrientationProvider interface.
The provider is created by the embedder and passed to the WebView, from
where WebDeviceOrientationClient can access it.
The mock provider, WebDeviceOrientationProviderMock, is a wrapper around
the existing WebCore mock.
* WebCoreSupport/WebDeviceOrientationClient.h: Added.
* WebCoreSupport/WebDeviceOrientationClient.mm: Added.
(WebDeviceOrientationClient::WebDeviceOrientationClient):
(WebDeviceOrientationClient::setController):
(WebDeviceOrientationClient::startUpdating):
(WebDeviceOrientationClient::stopUpdating):
(WebDeviceOrientationClient::lastOrientation):
* WebKit.exp:
* WebView/WebDeviceOrientation.h: Added.
* WebView/WebDeviceOrientation.mm: Added.
(-[WebDeviceOrientation initWithCoreDeviceOrientation:WebCore::]):
(core):
(-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
(-[WebDeviceOrientation dealloc]):
* WebView/WebDeviceOrientationInternal.h: Added.
* WebView/WebDeviceOrientationProvider.h: Added.
* WebView/WebDeviceOrientationProviderMock.h: Added.
* WebView/WebDeviceOrientationProviderMock.mm: Added.
(-[WebDeviceOrientationProviderMockInternal setOrientation:]):
(-[WebDeviceOrientationProviderMockInternal setController:]):
(-[WebDeviceOrientationProviderMockInternal startUpdating]):
(-[WebDeviceOrientationProviderMockInternal stopUpdating]):
(-[WebDeviceOrientationProviderMockInternal lastOrientation]):
(-[WebDeviceOrientationProviderMock init]):
(-[WebDeviceOrientationProviderMock dealloc]):
(-[WebDeviceOrientationProviderMock setOrientation:]):
(-[WebDeviceOrientationProviderMock setController:]):
(-[WebDeviceOrientationProviderMock startUpdating]):
(-[WebDeviceOrientationProviderMock stopUpdating]):
(-[WebDeviceOrientationProviderMock lastOrientation]):
* WebView/WebDeviceOrientationProviderMockInternal.h: Added.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _setDeviceOrientationProvider:]):
(-[WebView _deviceOrientationProvider]):
* WebView/WebViewData.h:
* WebView/WebViewPrivate.h:
2010-09-02 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
https://bugs.webkit.org/show_bug.cgi?id=43181
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMockDeviceOrientation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 2 Sep 2010 20:45:25 +0000 (20:45 +0000)]
2010-09-02 Matthew Willis <lilmatt@flock.com>
Reviewed by Eric Seidel.
Attempt to fix flaxy test that contains setTimeout() by adding
layoutTestController.waitUntilDone() and ...notifyDone()
https://bugs.webkit.org/show_bug.cgi?id=45097
* fast/css/disabled-author-styles.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 2 Sep 2010 20:15:45 +0000 (20:15 +0000)]
Fill the scroll corner with white when shouldPaintCustomScrollbars is false
Previously we were only filling with white when
shouldPaintCustomScrollbars was true but the ChromeClient didn't paint
any custom scrollbars.
Reviewed by Sam Weinig.
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paintScrollCorner):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 2 Sep 2010 20:14:24 +0000 (20:14 +0000)]
Fix flashiness when resizing the browser window on Windows
Reviewed by Sam Weinig.
* MiniBrowser/win/BrowserWindow.cpp:
(BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
periodically fill the window with white.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 2 Sep 2010 20:10:42 +0000 (20:10 +0000)]
2010-09-02 Eric Seidel <eric@webkit.org>
Reviewed by Alexey Proskuryakov.
fast/loader/recursive-before-unload-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=43840
Removed the frame loader callbacks as Brady suggested in
https://bugs.webkit.org/show_bug.cgi?id=38928#c27
This should stop the flake. As an added bonus this test no longer
needs platform specific results.
* fast/loader/recursive-before-unload-crash-expected.txt:
* fast/loader/recursive-before-unload-crash.html:
* platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt: Removed.
* platform/mac-tiger/fast/loader/recursive-before-unload-crash-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 2 Sep 2010 19:16:31 +0000 (19:16 +0000)]
2010-09-02 Tony Chang <tony@chromium.org>
Unreviewed, update chromium test expectations.
* platform/chromium/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 2 Sep 2010 19:11:27 +0000 (19:11 +0000)]
Simplify ownership semantics of some WebKit2 types
https://bugs.webkit.org/show_bug.cgi?id=45120
Reviewed by Anders Carlsson.
- Make ImmutableArray and MutableArray use a Vector<RefPtr<APIObject> > and
therefore ref any items it takes in.
- Make the PostMessageDecoder operate on a RefPtr<APIObject>& to avoid the odd
leaking semantics.
* Shared/ImmutableArray.cpp:
(WebKit::ImmutableArray::ImmutableArray): This constructor now uses a for-loop
instead of memcpy to ref each item.
(WebKit::ImmutableArray::~ImmutableArray): No longer necessary to manually deref.
* Shared/ImmutableArray.h:
(WebKit::ImmutableArray::adopt):
(WebKit::ImmutableArray::at):
Changes to accommodate entries being changed to a Vector<RefPtr<APIObject> >.
* Shared/ImmutableDictionary.cpp:
(WebKit::ImmutableDictionary::keys):
Build a Vector<RefPtr<APIObject> >.
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
Ditto.
* UIProcess/WebContext.cpp:
(WebKit::PostMessageEncoder::PostMessageDecoder::PostMessageDecoder):
(WebKit::PostMessageEncoder::PostMessageDecoder::decode):
(WebKit::WebContext::didReceiveMessage):
APIObject>& to avoid the odd leaking semantics.
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::PostMessageEncoder::PostMessageDecoder::PostMessageDecoder):
(WebKit::PostMessageEncoder::PostMessageDecoder::decode):
(WebKit::InjectedBundle::didReceiveMessage):
Ditto.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::childFrames):
Build a Vector<RefPtr<APIObject> >.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 2 Sep 2010 19:06:47 +0000 (19:06 +0000)]
2010-09-02 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
dumpAsText/Markup conversion: editing/style/block-style-004.html through block-style-006.html and editing/style/fontsize-1.html
https://bugs.webkit.org/show_bug.cgi?id=45050
* editing/style/block-style-004-expected.txt: Added.
* editing/style/block-style-004.html:
* editing/style/block-style-005.html:
* editing/style/block-style-006.html:
* editing/style/fontsize-1.html:
* platform/chromium-linux/editing/style/block-style-004-expected.checksum: Removed.
* platform/chromium-linux/editing/style/block-style-004-expected.png: Removed.
* platform/chromium-linux/editing/style/block-style-005-expected.checksum: Removed.
* platform/chromium-linux/editing/style/block-style-005-expected.png: Removed.
* platform/chromium-linux/editing/style/block-style-006-expected.checksum: Removed.
* platform/chromium-linux/editing/style/block-style-006-expected.png: Removed.
* platform/chromium-linux/editing/style/fontsize-1-expected.checksum: Removed.
* platform/chromium-linux/editing/style/fontsize-1-expected.png: Removed.
* platform/chromium-win/editing/style/block-style-004-expected.checksum: Removed.
* platform/chromium-win/editing/style/block-style-004-expected.png: Removed.
* platform/chromium-win/editing/style/block-style-004-expected.txt: Removed.
* platform/chromium-win/editing/style/block-style-005-expected.checksum: Removed.
* platform/chromium-win/editing/style/block-style-005-expected.png: Removed.
* platform/chromium-win/editing/style/block-style-005-expected.txt: Removed.
* platform/chromium-win/editing/style/block-style-006-expected.checksum: Removed.
* platform/chromium-win/editing/style/block-style-006-expected.png: Removed.
* platform/chromium-win/editing/style/block-style-006-expected.txt: Removed.
* platform/chromium-win/editing/style/fontsize-1-expected.checksum: Removed.
* platform/chromium-win/editing/style/fontsize-1-expected.png: Removed.
* platform/chromium-win/editing/style/fontsize-1-expected.txt: Removed.
* platform/gtk/editing/style/fontsize-1-expected.txt: Removed.
* platform/mac-leopard/editing/style/fontsize-1-expected.checksum: Removed.
* platform/mac-leopard/editing/style/fontsize-1-expected.png: Removed.
* platform/mac/editing/style/block-style-004-expected.checksum: Removed.
* platform/mac/editing/style/block-style-004-expected.png: Removed.
* platform/mac/editing/style/block-style-004-expected.txt: Removed.
* platform/mac/editing/style/block-style-005-expected.checksum: Removed.
* platform/mac/editing/style/block-style-005-expected.png: Removed.
* platform/mac/editing/style/block-style-005-expected.txt: Removed.
* platform/mac/editing/style/block-style-006-expected.checksum: Removed.
* platform/mac/editing/style/block-style-006-expected.png: Removed.
* platform/mac/editing/style/block-style-006-expected.txt: Removed.
* platform/mac/editing/style/fontsize-1-expected.checksum: Removed.
* platform/mac/editing/style/fontsize-1-expected.png: Removed.
* platform/mac/editing/style/fontsize-1-expected.txt: Removed.
* platform/qt/editing/style/block-style-004-expected.txt: Removed.
* platform/qt/editing/style/block-style-005-expected.txt: Removed.
* platform/qt/editing/style/block-style-006-expected.txt: Removed.
* platform/qt/editing/style/fontsize-1-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Thu, 2 Sep 2010 18:55:02 +0000 (18:55 +0000)]
2010-09-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66671.
http://trac.webkit.org/changeset/66671
https://bugs.webkit.org/show_bug.cgi?id=45115
http/tests/misc/redirect-to-about-blank.html is failing on
several platforms (Requested by japhet on #webkit).
* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::updateURLForPushOrReplaceState):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::iconURL):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::didExplicitOpen):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::setURL):
(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::commitIconURLToIconDatabase):
(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::checkIfDisplayInsecureContent):
(WebCore::FrameLoader::checkIfRunInsecureContent):
(WebCore::FrameLoader::updateFirstPartyForCookies):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::shouldScrollToAnchor):
* loader/FrameLoader.h:
(WebCore::FrameLoader::url):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 2 Sep 2010 18:32:14 +0000 (18:32 +0000)]
Add WKMutableDictionary API for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=45117
Reviewed by Anders Carlsson.
Add WKMutableDictionary API that inherits from WKDictionaryRef
the same way WKMutableArrayRef inherits from WKArrayRef.
* Shared/ImmutableDictionary.h:
(WebKit::ImmutableDictionary::get):
(WebKit::ImmutableDictionary::isMutable):
* Shared/MutableDictionary.cpp: Added.
(WebKit::MutableDictionary::MutableDictionary):
(WebKit::MutableDictionary::~MutableDictionary):
(WebKit::MutableDictionary::add):
(WebKit::MutableDictionary::set):
* Shared/MutableDictionary.h: Added.
(WebKit::MutableDictionary::create):
(WebKit::MutableDictionary::isMutable):
* UIProcess/API/C/WKAPICast.h:
(toWK):
* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKMutableDictionary.cpp: Added.
(WKMutableDictionaryCreate):
(WKDictionaryIsMutable):
(WKDictionaryAddItem):
(WKDictionarySetItem):
* UIProcess/API/C/WKMutableDictionary.h: Added.
* UIProcess/API/C/WebKit2.h:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Thu, 2 Sep 2010 17:54:23 +0000 (17:54 +0000)]
2010-09-01 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Roll ANGLE under webkit to r402
https://bugs.webkit.org/show_bug.cgi?id=45004
* platform/graphics/mac/GraphicsContext3DMac.mm: Update the code to use newer ANGLE interface.
(WebCore::GraphicsContext3D::GraphicsContext3D):
2010-09-01 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Roll ANGLE under webkit to r402
https://bugs.webkit.org/show_bug.cgi?id=45004
* ANGLE.xcodeproj/project.pbxproj:
* include/GLES2/gl2ext.h:
* include/GLSLANG/ResourceLimits.h: Removed.
* include/GLSLANG/ShaderLang.h:
* src/compiler/BaseTypes.h:
(getPrecisionString):
(getBasicString):
(IsSampler):
(getQualifierString):
* src/compiler/Initialize.cpp:
(BuiltInConstants):
(IdentifyBuiltIns):
* src/compiler/Initialize.h:
* src/compiler/InitializeDll.cpp:
(InitProcess):
(DetachProcess):
(InitThread):
(DetachThread):
* src/compiler/InitializeDll.h:
* src/compiler/InitializeParseContext.h:
* src/compiler/Intermediate.cpp:
(GetHigherPrecision):
(TIntermediate::addBinaryMath):
(TIntermediate::setAggregateOperator):
(TIntermediate::addComma):
(TIntermediate::postProcess):
(TIntermBinary::promote):
(CompareStruct):
* src/compiler/OutputGLSL.cpp:
(TOutputGLSL::writeFunctionParameters):
(TOutputGLSL::visitUnary):
(TOutputGLSL::visitBranch):
* src/compiler/OutputHLSL.cpp:
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitBinary):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::addConstructor):
* src/compiler/ParseHelper.cpp:
(TParseContext::constructorErrorCheck):
(TParseContext::samplerErrorCheck):
(TParseContext::paramErrorCheck):
(TParseContext::findFunction):
(TParseContext::executeInitializer):
(TParseContext::addConstructor):
(TParseContext::addConstStruct):
(FreeParseContextIndex):
(GetGlobalParseContext):
* src/compiler/PoolAlloc.h:
(TPoolAllocator::tHeader::tHeader):
(pool_allocator::allocate):
(pool_allocator::deallocate):
* src/compiler/ShaderLang.cpp:
(ShInitialize):
(ShFinalize):
(ShInitBuiltInResource):
* src/compiler/SymbolTable.cpp:
(TType::getStructSize):
* src/compiler/SymbolTable.h:
(TVariable::setQualifier):
* src/compiler/Types.h:
(TType::TType):
(TType::getBasicType):
(TType::setBasicType):
(TType::getPrecision):
(TType::setPrecision):
(TType::getQualifier):
(TType::setQualifier):
(TType::getNominalSize):
(TType::setNominalSize):
(TType::isMatrix):
(TType::setMatrix):
(TType::isArray):
(TType::getArraySize):
(TType::setArraySize):
(TType::getMaxArraySize):
(TType::setMaxArraySize):
(TType::clearArrayness):
(TType::setArrayInformationType):
(TType::getArrayInformationType):
(TType::isVector):
(TType::isScalar):
(TType::setStruct):
(TType::getTypeName):
(TType::setTypeName):
(TType::isField):
(TType::getFieldName):
(TType::setFieldName):
(TType::getBasicString):
(TType::getPrecisionString):
(TType::getQualifierString):
* src/compiler/glslang.l:
* src/compiler/glslang.y:
* src/compiler/intermediate.h:
(TIntermNode::getLine):
(TIntermNode::setLine):
(TIntermTyped::getAsTyped):
(TIntermTyped::setType):
(TIntermTyped::getType):
(TIntermTyped::getTypePointer):
(TIntermTyped::getBasicType):
(TIntermTyped::getQualifier):
(TIntermTyped::getPrecision):
(TIntermTyped::getNominalSize):
(TIntermTyped::isMatrix):
(TIntermTyped::isArray):
(TIntermTyped::isVector):
(TIntermTyped::isScalar):
(TIntermTyped::getBasicString):
(TIntermTyped::getQualifierString):
(TIntermSymbol::getId):
(TIntermSymbol::getSymbol):
(TIntermOperator::setOp):
(TIntermBinary::setLeft):
(TIntermBinary::setRight):
(TIntermBinary::getLeft):
(TIntermBinary::getRight):
(TIntermUnary::setOperand):
(TIntermUnary::getOperand):
(TIntermAggregate::getAsAggregate):
(TIntermAggregate::getSequence):
(TIntermAggregate::setName):
(TIntermAggregate::getName):
(TIntermAggregate::setUserDefined):
(TIntermAggregate::isUserDefined):
(TIntermAggregate::getQualifier):
(TIntermAggregate::setOptimize):
(TIntermAggregate::setDebug):
(TIntermSelection::getCondition):
(TIntermSelection::getTrueBlock):
(TIntermSelection::getFalseBlock):
(TIntermSelection::getAsSelectionNode):
* src/compiler/parseConst.cpp:
(TConstTraverser::TConstTraverser):
* src/compiler/preprocessor/atom.c:
(InitAtomTable):
* src/compiler/preprocessor/atom.h:
* src/compiler/preprocessor/compile.h:
* src/compiler/preprocessor/cpp.c:
* src/compiler/preprocessor/cpp.h:
* src/compiler/preprocessor/cppstruct.c:
* src/compiler/preprocessor/memory.c:
* src/compiler/preprocessor/memory.h:
* src/compiler/preprocessor/parser.h:
* src/compiler/preprocessor/preprocess.h:
* src/compiler/preprocessor/scanner.c:
* src/compiler/preprocessor/scanner.h:
* src/compiler/preprocessor/slglobals.h:
* src/compiler/preprocessor/symbols.c:
(NewSymbol):
* src/compiler/preprocessor/symbols.h:
* src/compiler/preprocessor/tokens.c:
(RecordToken):
* src/compiler/preprocessor/tokens.h:
* src/libEGL/Display.cpp:
(egl::Display::Display):
(egl::Display::initialize):
(egl::Display::terminate):
(egl::Display::createDevice):
(egl::Display::createWindowSurface):
(egl::Display::createContext):
(egl::Display::getMultiSampleSupport):
(egl::Display::getCompressedTextureSupport):
* src/libEGL/Display.h:
* src/libEGL/Surface.cpp:
(egl::Surface::Surface):
(egl::Surface::resetSwapChain):
(egl::Surface::getWindowHandle):
(egl::Surface::writeRecordableFlipState):
(egl::Surface::applyFlipState):
(egl::Surface::releaseRecordedState):
(egl::Surface::checkForWindowResize):
(egl::Surface::swap):
* src/libEGL/Surface.h:
* src/libEGL/libEGL.cpp:
* src/libEGL/libEGL.vcproj:
* src/libGLESv2/Blit.cpp:
(gl::Blit::setVertexShader):
(gl::Blit::setPixelShader):
(gl::Blit::setFormatConvertShaders):
* src/libGLESv2/Buffer.cpp:
(gl::Buffer::Buffer):
* src/libGLESv2/Buffer.h:
* src/libGLESv2/Context.cpp:
(gl::Context::Context):
(gl::Context::~Context):
(gl::Context::makeCurrent):
(gl::Context::markAllStateDirty):
(gl::Context::getReadFramebufferHandle):
(gl::Context::getDrawFramebufferHandle):
(gl::Context::getRenderbufferHandle):
(gl::Context::getArrayBufferHandle):
(gl::Context::setVertexAttribState):
(gl::Context::createBuffer):
(gl::Context::createProgram):
(gl::Context::createShader):
(gl::Context::createTexture):
(gl::Context::createRenderbuffer):
(gl::Context::deleteBuffer):
(gl::Context::deleteShader):
(gl::Context::deleteProgram):
(gl::Context::deleteTexture):
(gl::Context::deleteRenderbuffer):
(gl::Context::getBuffer):
(gl::Context::getShader):
(gl::Context::getProgram):
(gl::Context::getTexture):
(gl::Context::getRenderbuffer):
(gl::Context::getReadFramebuffer):
(gl::Context::getDrawFramebuffer):
(gl::Context::bindArrayBuffer):
(gl::Context::bindElementArrayBuffer):
(gl::Context::bindTexture2D):
(gl::Context::bindTextureCubeMap):
(gl::Context::bindReadFramebuffer):
(gl::Context::bindDrawFramebuffer):
(gl::Context::bindRenderbuffer):
(gl::Context::useProgram):
(gl::Context::setFramebufferZero):
(gl::Context::setRenderbufferStorage):
(gl::Context::getFramebuffer):
(gl::Context::getArrayBuffer):
(gl::Context::getElementArrayBuffer):
(gl::Context::getCurrentProgram):
(gl::Context::getTexture2D):
(gl::Context::getTextureCubeMap):
(gl::Context::getSamplerTexture):
(gl::Context::getFloatv):
(gl::Context::getIntegerv):
(gl::Context::getQueryParameterInfo):
(gl::Context::applyRenderTarget):
(gl::Context::applyState):
(gl::Context::applyIndexBuffer):
(gl::Context::readPixels):
(gl::Context::clear):
(gl::Context::finish):
(gl::Context::flush):
(gl::Context::supportsShaderModel3):
(gl::Context::getMaxSupportedSamples):
(gl::Context::getNearestSupportedSamples):
(gl::Context::supportsCompressedTextures):
(gl::Context::detachBuffer):
(gl::Context::detachTexture):
(gl::Context::detachFramebuffer):
(gl::Context::detachRenderbuffer):
(gl::Context::getIncompleteTexture):
(gl::Context::initExtensionString):
(gl::Context::blitFramebuffer):
* src/libGLESv2/Context.h:
(gl::AttributeState::AttributeState):
* src/libGLESv2/Framebuffer.cpp:
(gl::Framebuffer::Framebuffer):
(gl::Framebuffer::~Framebuffer):
(gl::Framebuffer::lookupRenderbuffer):
(gl::Framebuffer::setColorbuffer):
(gl::Framebuffer::setDepthbuffer):
(gl::Framebuffer::setStencilbuffer):
(gl::Framebuffer::detachTexture):
(gl::Framebuffer::detachRenderbuffer):
(gl::Framebuffer::getRenderTargetSerial):
(gl::Framebuffer::getRenderTarget):
(gl::Framebuffer::getDepthStencil):
(gl::Framebuffer::getDepthbufferSerial):
(gl::Framebuffer::getStencilbufferSerial):
(gl::Framebuffer::getColorbuffer):
(gl::Framebuffer::getDepthbuffer):
(gl::Framebuffer::getStencilbuffer):
(gl::Framebuffer::getColorbufferHandle):
(gl::Framebuffer::getDepthbufferHandle):
(gl::Framebuffer::getStencilbufferHandle):
(gl::Framebuffer::hasStencil):
(gl::Framebuffer::isMultisample):
(gl::Framebuffer::completeness):
(gl::DefaultFramebuffer::DefaultFramebuffer):
(gl::Framebuffer::getSamples):
(gl::DefaultFramebuffer::completeness):
* src/libGLESv2/Framebuffer.h:
* src/libGLESv2/Program.cpp:
(gl::Program::Program):
(gl::Program::~Program):
(gl::Program::attachShader):
(gl::Program::detachShader):
(gl::Program::linkVaryings):
(gl::Program::link):
(gl::Program::unlink):
(gl::Program::release):
(gl::Program::addRef):
(gl::Program::getRefCount):
(gl::Program::getDxViewportLocation):
* src/libGLESv2/Program.h:
* src/libGLESv2/RefCountObject.cpp: Added.
(gl::RefCountObject::RefCountObject):
(gl::RefCountObject::~RefCountObject):
(gl::RefCountObject::addRef):
(gl::RefCountObject::release):
(gl::RefCountObjectBindingPointer::set):
* src/libGLESv2/RefCountObject.h: Added.
(gl::RefCountObject::id):
(gl::RefCountObjectBindingPointer::RefCountObjectBindingPointer):
(gl::RefCountObjectBindingPointer::~RefCountObjectBindingPointer):
(gl::RefCountObjectBindingPointer::get):
(gl::RefCountObjectBindingPointer::id):
(gl::RefCountObjectBindingPointer::operator ! ):
(gl::BindingPointer::set):
(gl::BindingPointer::get):
(gl::BindingPointer::operator -> ):
* src/libGLESv2/Renderbuffer.cpp:
(gl::Renderbuffer::Renderbuffer):
(gl::Renderbuffer::~Renderbuffer):
(gl::Renderbuffer::isColorbuffer):
(gl::Renderbuffer::isDepthbuffer):
(gl::Renderbuffer::isStencilbuffer):
(gl::Renderbuffer::getRenderTarget):
(gl::Renderbuffer::getDepthStencil):
(gl::Renderbuffer::getWidth):
(gl::Renderbuffer::getHeight):
(gl::Renderbuffer::getFormat):
(gl::Renderbuffer::getD3DFormat):
(gl::Renderbuffer::getSerial):
(gl::Renderbuffer::setStorage):
(gl::RenderbufferStorage::RenderbufferStorage):
(gl::RenderbufferStorage::~RenderbufferStorage):
(gl::RenderbufferStorage::isColorbuffer):
(gl::RenderbufferStorage::isDepthbuffer):
(gl::RenderbufferStorage::isStencilbuffer):
(gl::RenderbufferStorage::getRenderTarget):
(gl::RenderbufferStorage::getDepthStencil):
(gl::RenderbufferStorage::getWidth):
(gl::RenderbufferStorage::getHeight):
(gl::RenderbufferStorage::setSize):
(gl::RenderbufferStorage::getFormat):
(gl::RenderbufferStorage::getD3DFormat):
(gl::RenderbufferStorage::getSamples):
(gl::RenderbufferStorage::getSerial):
(gl::RenderbufferStorage::issueSerial):
(gl::Colorbuffer::Colorbuffer):
(gl::Colorbuffer::isColorbuffer):
(gl::Colorbuffer::getRedSize):
(gl::Colorbuffer::getGreenSize):
(gl::Colorbuffer::getBlueSize):
(gl::Colorbuffer::getAlphaSize):
(gl::DepthStencilbuffer::DepthStencilbuffer):
(gl::DepthStencilbuffer::~DepthStencilbuffer):
(gl::DepthStencilbuffer::isDepthbuffer):
(gl::DepthStencilbuffer::isStencilbuffer):
(gl::DepthStencilbuffer::getDepthSize):
(gl::DepthStencilbuffer::getStencilSize):
(gl::DepthStencilbuffer::getDepthStencil):
(gl::Depthbuffer::Depthbuffer):
(gl::Depthbuffer::~Depthbuffer):
(gl::Depthbuffer::isDepthbuffer):
(gl::Depthbuffer::isStencilbuffer):
(gl::Stencilbuffer::Stencilbuffer):
(gl::Stencilbuffer::~Stencilbuffer):
(gl::Stencilbuffer::isDepthbuffer):
(gl::Stencilbuffer::isStencilbuffer):
* src/libGLESv2/Renderbuffer.h:
(gl::Renderbuffer::getStorage):
* src/libGLESv2/ResourceManager.cpp: Added.
(gl::ResourceManager::ResourceManager):
(gl::ResourceManager::~ResourceManager):
(gl::ResourceManager::addRef):
(gl::ResourceManager::release):
(gl::ResourceManager::createBuffer):
(gl::ResourceManager::createShader):
(gl::ResourceManager::createProgram):
(gl::ResourceManager::createTexture):
(gl::ResourceManager::createRenderbuffer):
(gl::ResourceManager::deleteBuffer):
(gl::ResourceManager::deleteShader):
(gl::ResourceManager::deleteProgram):
(gl::ResourceManager::deleteTexture):
(gl::ResourceManager::deleteRenderbuffer):
(gl::ResourceManager::getBuffer):
(gl::ResourceManager::getShader):
(gl::ResourceManager::getTexture):
(gl::ResourceManager::getProgram):
(gl::ResourceManager::getRenderbuffer):
(gl::ResourceManager::setRenderbuffer):
(gl::ResourceManager::checkBufferAllocation):
(gl::ResourceManager::checkTextureAllocation):
(gl::ResourceManager::checkRenderbufferAllocation):
* src/libGLESv2/ResourceManager.h: Added.
* src/libGLESv2/Shader.cpp:
(gl::Shader::Shader):
(gl::Shader::addRef):
(gl::Shader::release):
(gl::Shader::getRefCount):
(gl::Shader::parseVaryings):
(gl::VertexShader::VertexShader):
(gl::FragmentShader::FragmentShader):
* src/libGLESv2/Shader.h:
* src/libGLESv2/Texture.cpp:
(gl::Texture::Image::Image):
(gl::Texture::Texture):
(gl::Texture::getBlitter):
(gl::Texture::selectFormat):
(gl::Texture::loadImageData):
(gl::Texture::loadAlphaImageData):
(gl::Texture::loadLuminanceImageData):
(gl::Texture::loadLuminanceAlphaImageData):
(gl::Texture::loadRGBUByteImageData):
(gl::Texture::loadRGB565ImageData):
(gl::Texture::loadRGBAUByteImageData):
(gl::Texture::loadRGBA4444ImageData):
(gl::Texture::loadRGBA5551ImageData):
(gl::Texture::loadBGRAImageData):
(gl::Texture::createSurface):
(gl::Texture::setImage):
(gl::Texture::setCompressedImage):
(gl::Texture::subImage):
(gl::Texture::subImageCompressed):
(gl::Texture2D::Texture2D):
(gl::Texture2D::getFormat):
(gl::Texture2D::setCompressedImage):
(gl::Texture2D::subImage):
(gl::Texture2D::subImageCompressed):
(gl::Texture2D::copyImage):
(gl::Texture2D::copySubImage):
(gl::Texture2D::isCompressed):
(gl::Texture2D::getColorbuffer):
(gl::TextureCubeMap::TextureCubeMap):
(gl::TextureCubeMap::getFormat):
(gl::TextureCubeMap::setCompressedImage):
(gl::TextureCubeMap::subImage):
(gl::TextureCubeMap::subImageCompressed):
(gl::TextureCubeMap::isCompressed):
(gl::TextureCubeMap::copyImage):
(gl::TextureCubeMap::copySubImage):
(gl::TextureCubeMap::getColorbuffer):
(gl::Texture::TextureColorbufferProxy::addRef):
(gl::Texture::TextureColorbufferProxy::release):
(gl::Texture::TextureColorbufferProxy::getWidth):
(gl::Texture::TextureColorbufferProxy::getHeight):
(gl::Texture::TextureColorbufferProxy::getFormat):
* src/libGLESv2/Texture.h:
* src/libGLESv2/libGLESv2.cpp:
* src/libGLESv2/libGLESv2.def:
* src/libGLESv2/libGLESv2.vcproj:
* src/libGLESv2/main.h:
* src/libGLESv2/utilities.cpp:
(gl::ComputeCompressedPitch):
(gl::ComputeCompressedSize):
(gl::IsCompressed):
(gl::ComputePixelSize):
(gl::CheckTextureFormatType):
(es2dx::ConvertRenderbufferFormat):
(es2dx::GetSamplesFromMultisampleType):
(es2dx::GetMultisampleTypeFromSamples):
* src/libGLESv2/utilities.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 2 Sep 2010 17:10:38 +0000 (17:10 +0000)]
2010-09-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: Timeline instrumentation code can crash browser.
Steps:
1) load the site
2) open inspector
3) start timeline recording
4) reload inspected page
got NPE
https://bugs.webkit.org/show_bug.cgi?id=45098
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 2 Sep 2010 16:31:31 +0000 (16:31 +0000)]
2010-09-02 Jessie Berlin <jberlin@apple.com>
Windows build fix. Unreviewed.
* UIProcess/API/win/WKAPICastWin.h:
(toWK):
* UIProcess/API/win/WKBaseWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 2 Sep 2010 16:30:09 +0000 (16:30 +0000)]
2010-09-02 Andrey Kosyakov <caseq@chromium.org>
Unreviewed test fix.
Add size & bodySize to list of non-deterministic fields for HAR tests, as those tend to vary by platform
in error responses.
Remove platform-specific expectations that were previously added because of this.
* http/tests/inspector/resource-har-conversion-expected.txt:
* http/tests/inspector/resource-har-conversion.html:
* http/tests/inspector/resource-test2.js:
* platform/chromium-win/inspector/resource-har-conversion-expected.txt: Removed.
* platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Thu, 2 Sep 2010 16:19:36 +0000 (16:19 +0000)]
2010-09-02 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Remove m_URL from FrameLoader and instead depend on Document's url.
FrameLoader::url() will be removed in a later patch.
http://bugs.webkit.org/show_bug.cgi?id=41165
No new tests, since this predominantly a refactor. Updating
fast/dom/early-frame-url.html.
* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::updateURLForPushOrReplaceState):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::iconURL):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::didExplicitOpen):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::url):
(WebCore::FrameLoader::setOutgoingReferrer):
(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::commitIconURLToIconDatabase):
(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::checkIfDisplayInsecureContent):
(WebCore::FrameLoader::checkIfRunInsecureContent):
(WebCore::FrameLoader::updateFirstPartyForCookies):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::shouldScrollToAnchor):
* loader/FrameLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 2 Sep 2010 15:45:43 +0000 (15:45 +0000)]
2010-09-01 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934
* fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Added.
* fast/dom/HTMLScriptElement/defer-double-defer-write.html: Added. Tests that a write of a deferred script from a deferred script will execute when the document is closed. The explicit close is necessary because this is a script created parser.
* fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Added.
* fast/dom/HTMLScriptElement/defer-double-write.html: Added. Tests that a script block written from a deferred script will write into the new document.
* fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Added.
* fast/dom/HTMLScriptElement/defer-inline-script.html: Added. Tests that inline scripts are not deferred. This is consistent with HTML5 and inconsistent with IE.
* fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Added.
* fast/dom/HTMLScriptElement/defer-onbeforeload.html: Added. Tests that the beforeload event is fired immediately and is cancellable.
* fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Added.
* fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Added. Tests that deferred scripts with invalid URLs are ignored and that subsequent deferred scripts will be run.
* fast/dom/HTMLScriptElement/defer-write-expected.txt: Added.
* fast/dom/HTMLScriptElement/defer-write.html: Added. Tests that a basic write from a deferred script blows away the document.
* fast/dom/HTMLScriptElement/resources/defer.js: Added.
* fast/dom/HTMLScriptElement/resources/external.js: Added.
* fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Added.
* fast/dom/HTMLScriptElement/shouldnotexecute.js: Added.
* fast/dom/HTMLScriptElement/two-defer-writes-expected.txt: Added.
* fast/dom/HTMLScriptElement/two-defer-writes.html: Added. Tests that when a document.write from the first deferred script blows away the document, subsequent deferred scripts are not executed.
* http/tests/misc/resources/defer-script.js: Added.
* http/tests/misc/resources/external-script.js: Added.
* http/tests/misc/resources/script-debug-body-background.js: Added.
* http/tests/misc/resources/script-write-slow-stylesheet.js: Added.
* http/tests/misc/resources/slow-defer-script.cgi: Added.
* http/tests/misc/resources/slow-stylesheet.cgi: Added.
* http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Added.
* http/tests/misc/script-defer-after-slow-stylesheet.html: Added. Tests that deferred scripts respect blocking stylesheets.
* http/tests/misc/script-defer-expected.txt: Added.
* http/tests/misc/script-defer.html: Added. Tests basic ordering of deferred scripts.
2010-09-01 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934
Tests: fast/dom/HTMLScriptElement/defer-double-defer-write.html
fast/dom/HTMLScriptElement/defer-double-write.html
fast/dom/HTMLScriptElement/defer-inline-script.html
fast/dom/HTMLScriptElement/defer-onbeforeload.html
fast/dom/HTMLScriptElement/defer-script-invalid-url.html
fast/dom/HTMLScriptElement/defer-write.html
fast/dom/HTMLScriptElement/two-defer-writes.html
http/tests/misc/script-defer-after-slow-stylesheet.html
http/tests/misc/script-defer.html
* dom/Document.cpp:
(WebCore::Document::open): Allow implicit open for writes() while executing deferred scripts.
* dom/DocumentParser.cpp:
(WebCore::DocumentParser::DocumentParser):
(WebCore::DocumentParser::startParsing):
(WebCore::DocumentParser::prepareToStopParsing): If called when stopped or detached, it shouldn't reset to stopping.
(WebCore::DocumentParser::stopParsing):
(WebCore::DocumentParser::detach):
* dom/DocumentParser.h:
(WebCore::DocumentParser::isParsing):
(WebCore::DocumentParser::isActive):
(WebCore::DocumentParser::isStopping):
(WebCore::DocumentParser::isDetached):
* dom/RawDataDocumentParser.h:
(WebCore::RawDataDocumentParser::finish):
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::append):
(WebCore::XMLDocumentParser::exitText):
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::characters):
(WebCore::XMLDocumentParser::error):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::internalSubset):
(WebCore::XMLDocumentParser::initializeParserContext):
(WebCore::XMLDocumentParser::doEnd):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::pumpTokenizerIfPossible):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::end):
(WebCore::HTMLDocumentParser::attemptToEnd):
(WebCore::HTMLDocumentParser::endIfDelayed):
(WebCore::HTMLDocumentParser::notifyFinished):
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::~HTMLScriptRunner):
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::requestDeferredScript):
(WebCore::HTMLScriptRunner::runScript):
* html/parser/HTMLScriptRunner.h:
* loader/ImageDocument.cpp:
(WebCore::ImageDocumentParser::finish):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 2 Sep 2010 15:29:03 +0000 (15:29 +0000)]
2010-09-02 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: HAR converter fails on POST requests with non-form content type.
https://bugs.webkit.org/show_bug.cgi?id=45109
* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype._buildPostData):
2010-09-02 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: HAR converter fails on POST requests with non-form content type.
Migrated HAR tests to inspector-test2.js, enabled resource tracking, added test for XHR POST request.
https://bugs.webkit.org/show_bug.cgi?id=45109
* http/tests/inspector/resource-har-conversion-expected.txt:
* http/tests/inspector/resource-har-conversion.html:
* http/tests/inspector/resource-parameters-expected.txt:
* http/tests/inspector/resource-test2.js: Added.
(initialize_ResourceTest.InspectorTest.resourceURLComparer):
(initialize_ResourceTest):
* platform/chromium-win/http/tests/inspector/resource-parameters-expected.txt:
* platform/chromium-win/http/tests/inspector/resource-har-conversion-expected.txt: Added.
* platform/win/http/tests/inspector/console-xhr-logging-expected.txt: Added.
* platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Added.
* platform/win/http/tests/inspector/resource-parameters-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 2 Sep 2010 13:35:54 +0000 (13:35 +0000)]
2010-09-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add WTFURL to the JavaScriptCore build on Mac
https://bugs.webkit.org/show_bug.cgi?id=45075
Building code is good.
* JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 2 Sep 2010 13:25:55 +0000 (13:25 +0000)]
2010-09-02 Andreas Kling <andreas.kling@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] REGRESSION(r62898): tst_QWebFrame crashing
https://bugs.webkit.org/show_bug.cgi?id=43039
Rolling out the offending change <http://trac.webkit.org/changeset/62898>
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::evalJSV):
2010-09-02 Andreas Kling <andreas.kling@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] REGRESSION(r62898): tst_QWebFrame crashing
https://bugs.webkit.org/show_bug.cgi?id=43039
Rolling out the offending change <http://trac.webkit.org/changeset/62898>
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::markAggregate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Sep 2010 13:14:24 +0000 (13:14 +0000)]
2010-09-02 Peter Kasting <pkasting@google.com>
Reviewed by Dimitri Glazkov.
Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
https://bugs.webkit.org/show_bug.cgi?id=45073
* platform/chromium/test_expectations.txt: Unskip tests that should now pass.
* platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html: Convert mouseWheelTo() to mouseScrollBy().
2010-09-02 Peter Kasting <pkasting@google.com>
Reviewed by Dimitri Glazkov.
Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
https://bugs.webkit.org/show_bug.cgi?id=45073
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::mouseScrollBy):
(EventSender::continuousMouseScrollBy):
(EventSender::sendCurrentTouchEvent):
(EventSender::handleMouseWheel):
* DumpRenderTree/chromium/EventSender.h:
* DumpRenderTree/gtk/EventSender.cpp:
(mouseScrollByCallback):
(continuousMouseScrollByCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 2 Sep 2010 12:57:58 +0000 (12:57 +0000)]
2010-09-02 Alexey Proskuryakov <ap@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=43230
<rdar://problem/
8254215> REGRESSION: Memory leak within JSParser::JSParser
One can't delete a ThreadSpecific object that has data in it. It's not even possible to
enumerate data objects in all threads, much less destroy them from a thread that's destroying
the ThreadSpecific.
* parser/JSParser.cpp:
(JSC::JSParser::JSParser):
* runtime/JSGlobalData.h:
* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
* wtf/WTFThreadData.h:
(WTF::WTFThreadData::approximatedStackStart):
Moved stack guard tracking from JSGlobalData to WTFThreadData.
* wtf/ThreadSpecific.h: Made destructor unimplemented. It's dangerous, and we probably won't
ever face a situation where we'd want to delete a ThreadSpecific object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 2 Sep 2010 12:29:00 +0000 (12:29 +0000)]
2010-09-02 Anton Muhin <antonm@chromium.org>
Reviewed by Tony Chang.
Fix indentation.
https://bugs.webkit.org/show_bug.cgi?id=44678
* bindings/scripts/CodeGeneratorV8.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 2 Sep 2010 12:09:07 +0000 (12:09 +0000)]
2010-09-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: protocol related Inspector's tests are failing in Chromium.
The expectation is different because Chromium tests use test_shell.
1) a lot of console messages automaticaly published by test_shell;
2) debugger was enabled by default;
3) for (i in an_array) produces some garbage.
The solution:
1) override reportProtocolError and console.error functions;
2) debugger was explicitly disabled;
3) just fixed.
https://bugs.webkit.org/show_bug.cgi?id=44996
* inspector/report-API-errors.html:
* inspector/report-protocol-errors.html:
* LayoutTests/platform/chromium/test_expectations.txt
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 2 Sep 2010 11:46:57 +0000 (11:46 +0000)]
2010-09-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66656.
http://trac.webkit.org/changeset/66656
https://bugs.webkit.org/show_bug.cgi?id=45105
won't pass after 66655 rollout (Requested by kling on
#webkit).
* fast/dom/Selection/script-tests/wrong-document-err.js: Removed.
* fast/dom/Selection/wrong-document-err-expected.txt: Removed.
* fast/dom/Selection/wrong-document-err.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 2 Sep 2010 11:45:15 +0000 (11:45 +0000)]
2010-09-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66655.
http://trac.webkit.org/changeset/66655
https://bugs.webkit.org/show_bug.cgi?id=45104
broke some editing tests (Requested by kling on #webkit).
* page/DOMSelection.cpp:
(WebCore::DOMSelection::collapse):
(WebCore::DOMSelection::selectAllChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Sep 2010 11:43:30 +0000 (11:43 +0000)]
2010-09-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66649.
http://trac.webkit.org/changeset/66649
https://bugs.webkit.org/show_bug.cgi?id=45103
It broke ~2000 tests on Qt bot (Requested by Ossy on #webkit).
* fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Removed.
* fast/dom/HTMLScriptElement/defer-double-defer-write.html: Removed.
* fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Removed.
* fast/dom/HTMLScriptElement/defer-double-write.html: Removed.
* fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Removed.
* fast/dom/HTMLScriptElement/defer-inline-script.html: Removed.
* fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Removed.
* fast/dom/HTMLScriptElement/defer-onbeforeload.html: Removed.
* fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Removed.
* fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Removed.
* fast/dom/HTMLScriptElement/defer-write-expected.txt: Removed.
* fast/dom/HTMLScriptElement/defer-write.html: Removed.
* fast/dom/HTMLScriptElement/resources/defer.js: Removed.
* fast/dom/HTMLScriptElement/resources/external.js: Removed.
* fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Removed.
* fast/dom/HTMLScriptElement/shouldnotexecute.js: Removed.
* fast/dom/HTMLScriptElement/two-defer-writes-expected.txt: Removed.
* fast/dom/HTMLScriptElement/two-defer-writes.html: Removed.
* http/tests/misc/resources/defer-script.js: Removed.
* http/tests/misc/resources/external-script.js: Removed.
* http/tests/misc/resources/script-debug-body-background.js: Removed.
* http/tests/misc/resources/script-write-slow-stylesheet.js: Removed.
* http/tests/misc/resources/slow-defer-script.cgi: Removed.
* http/tests/misc/resources/slow-stylesheet.cgi: Removed.
* http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Removed.
* http/tests/misc/script-defer-after-slow-stylesheet.html: Removed.
* http/tests/misc/script-defer-expected.txt: Removed.
* http/tests/misc/script-defer.html: Removed.
2010-09-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66649.
http://trac.webkit.org/changeset/66649
https://bugs.webkit.org/show_bug.cgi?id=45103
It broke ~2000 tests on Qt bot (Requested by Ossy on #webkit).
* dom/Document.cpp:
(WebCore::Document::open):
* dom/DocumentParser.cpp:
(WebCore::DocumentParser::DocumentParser):
(WebCore::DocumentParser::detach):
* dom/DocumentParser.h:
(WebCore::DocumentParser::isDetached):
(WebCore::DocumentParser::stopParsing):
* dom/RawDataDocumentParser.h:
(WebCore::RawDataDocumentParser::finish):
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::append):
(WebCore::XMLDocumentParser::exitText):
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::characters):
(WebCore::XMLDocumentParser::error):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::internalSubset):
(WebCore::XMLDocumentParser::initializeParserContext):
(WebCore::XMLDocumentParser::doEnd):
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::initializeParserContext):
(WebCore::XMLDocumentParser::doEnd):
(WebCore::XMLDocumentParser::parse):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizerIfPossible):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::end):
(WebCore::HTMLDocumentParser::attemptToEnd):
(WebCore::HTMLDocumentParser::endIfDelayed):
(WebCore::HTMLDocumentParser::notifyFinished):
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::~HTMLScriptRunner):
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::runScript):
* html/parser/HTMLScriptRunner.h:
* loader/ImageDocument.cpp:
(WebCore::ImageDocumentParser::finish):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 2 Sep 2010 11:29:26 +0000 (11:29 +0000)]
2010-09-02 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Share more code between HTMLObjectElement and HTMLEmbedElement
https://bugs.webkit.org/show_bug.cgi?id=45054
This pushes more of HTMLObjectElement code down into
HTMLPlugInImageElement so that it can be shared with
HTMLEmbedElement.
The most notable changes are:
- HTMLEmbedElement now "delays" updating the widget until
all of its children are parsed (this matches HTMLObjectElement).
However, since HTMLEmbedElement can't have children, this is actually
no delay.
- useFallbackContent is now virtual, allowing HTMLEmbedElement and
HTMLObjectElement to share the same code paths, and the <embed>
case to just always return false for useFallbackContent().
This is the final (fourth) part of this change.
No functional change, thus no tests.
* html/HTMLEmbedElement.cpp:
* html/HTMLEmbedElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::rendererIsNeeded):
* html/HTMLObjectElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::recalcStyle):
(WebCore::HTMLPlugInImageElement::attach):
(WebCore::HTMLPlugInImageElement::detach):
(WebCore::HTMLPlugInImageElement::finishParsingChildren):
* html/HTMLPlugInImageElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 2 Sep 2010 11:02:08 +0000 (11:02 +0000)]
2010-09-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move takeAllChildrenFrom to ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=45066
We're going to reuse this method for XMLDocumentLoader, so it's better
to put it in a more general location.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
* dom/ContainerNode.h:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 2 Sep 2010 10:58:04 +0000 (10:58 +0000)]
2010-09-02 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Share more code between HTMLObjectElement and HTMLEmbedElement
https://bugs.webkit.org/show_bug.cgi?id=45054
This pushes more of HTMLObjectElement code down into
HTMLPlugInImageElement so that it can be shared with HTMLEmbedElement.
This patch was originally written in one piece and reviewed by Dimitri.
I'm landing it as four separate changes for easier readability and less
chance of regression.
No functional change, thus no tests.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::HTMLEmbedElement):
(WebCore::HTMLEmbedElement::create):
* html/HTMLEmbedElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::HTMLObjectElement):
* html/HTMLObjectElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::detach):
(WebCore::HTMLPlugInImageElement::finishParsingChildren):
* html/HTMLPlugInImageElement.h:
* html/HTMLTagNames.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 2 Sep 2010 10:54:23 +0000 (10:54 +0000)]
2010-09-02 Andreas Kling <andreas.kling@nokia.com>
Unreviewed, forgot to add the new layout test in last commit.
* fast/dom/Selection/script-tests/wrong-document-err.js: Added.
* fast/dom/Selection/wrong-document-err-expected.txt: Added.
* fast/dom/Selection/wrong-document-err.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 2 Sep 2010 10:49:55 +0000 (10:49 +0000)]
2010-09-01 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
DOM Selection: collapse() and selectAllChildren() should throw WRONG_DOCUMENT_ERR if node belongs to other document
https://bugs.webkit.org/show_bug.cgi?id=44595
Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-collapse
http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-selectallchildren
Test: fast/dom/Selection/wrong-document-err.html
* page/DOMSelection.cpp:
(WebCore::DOMSelection::collapse):
(WebCore::DOMSelection::selectAllChildren):
2010-09-01 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
DOM Selection: collapse() and selectAllChildren() should throw WRONG_DOCUMENT_ERR if node belongs to other document
https://bugs.webkit.org/show_bug.cgi?id=44595
Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-collapse
http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-selectallchildren
* fast/dom/Selection/script-tests/wrong-document-err.js: Added.
* fast/dom/Selection/wrong-document-err-expected.txt: Added.
* fast/dom/Selection/wrong-document-err.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Thu, 2 Sep 2010 10:18:13 +0000 (10:18 +0000)]
[Chromium DevTools] Unreviewed DevTools tests fix after r66637.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 2 Sep 2010 10:05:36 +0000 (10:05 +0000)]
2010-09-02 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Share more code between HTMLObjectElement and HTMLEmbedElement
https://bugs.webkit.org/show_bug.cgi?id=45054
This pushes more of HTMLObjectElement code down into
HTMLPlugInImageElement so that it can be shared with HTMLEmbedElement.
I also moved a little code from HTMLPluginElement to HTMLPlugInImageElement
since HTMLAppletElement does not need to share this same widget update logic.
This is a small correction from the previous change.
This patch was originally written in one piece and reviewed by Dimitri.
I'm landing it as three separate changes for easier readability and less
chance of regression.
No functional change, thus no tests.
* html/HTMLEmbedElement.cpp:
* html/HTMLEmbedElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::attach):
(WebCore::HTMLObjectElement::finishParsingChildren):
(WebCore::HTMLObjectElement::detach):
(WebCore::HTMLObjectElement::recalcStyle):
(WebCore::HTMLObjectElement::childrenChanged):
(WebCore::HTMLObjectElement::renderFallbackContent):
* html/HTMLObjectElement.h:
(WebCore::HTMLObjectElement::useFallbackContent):
* html/HTMLPlugInElement.cpp:
* html/HTMLPlugInElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::createRenderer):
(WebCore::HTMLPlugInImageElement::updateWidget):
(WebCore::HTMLPlugInImageElement::updateWidgetCallback):
* html/HTMLPlugInImageElement.h:
(WebCore::HTMLPlugInImageElement::canLazyAttach):
(WebCore::HTMLPlugInImageElement::useFallbackContent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 2 Sep 2010 09:32:05 +0000 (09:32 +0000)]
2010-09-02 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
WebKit should not accept PDFs as video.
https://bugs.webkit.org/show_bug.cgi?id=45013
The code in MediaPlayerPrivate::createQTMovie has been re-arranged.
First, the component disabling is done only once. In 64-bit QTKit will
store the list of disabled components and disable them once QTKitServer
starts, so there is no need to disable them repeatedly. However,
because of a bug in 64-bit QTKit, additional requests of the exact same
component description will be ignored if QTKitServer is not yet running.
To work around this, we must provide the exact component flags for each
eat/PDF and grip/PDF component we wish to disable.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::disableComponentsOnce): Added.
(WebCore::MediaPlayerPrivate::createQTMovie): Moved the component
disabling code into disableComponentsOnce.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 2 Sep 2010 09:17:16 +0000 (09:17 +0000)]
2010-09-02 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK build fix.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 2 Sep 2010 09:10:21 +0000 (09:10 +0000)]
2010-09-02 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Share more code between HTMLObjectElement and HTMLEmbedElement
https://bugs.webkit.org/show_bug.cgi?id=45054
This pushes more of HTMLObjectElement code down into
HTMLPlugInImageElement so that it can be shared with HTMLEmbedElement.
I also moved a little code from HTMLPluginElement to HTMLPlugInImageElement
since HTMLAppletElement does not need to share this same widget update logic.
This is a small correction from the previous change.
This patch was originally written in one piece and reviewed by Dimitri.
I'm landing it as two separate changes for easier readability and less
chance of regression.
No functional change, thus no tests.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::HTMLEmbedElement):
(WebCore::HTMLEmbedElement::mapToEntry):
(WebCore::HTMLEmbedElement::parseMappedAttribute):
(WebCore::HTMLEmbedElement::rendererIsNeeded):
(WebCore::HTMLEmbedElement::attach):
(WebCore::HTMLEmbedElement::updateWidget):
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::removedFromDocument):
(WebCore::HTMLEmbedElement::attributeChanged):
* html/HTMLEmbedElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::HTMLObjectElement):
(WebCore::HTMLObjectElement::parseMappedAttribute):
(WebCore::HTMLObjectElement::rendererIsNeeded):
(WebCore::HTMLObjectElement::attach):
(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::finishParsingChildren):
(WebCore::HTMLObjectElement::detach):
(WebCore::HTMLObjectElement::insertedIntoDocument):
(WebCore::HTMLObjectElement::removedFromDocument):
(WebCore::HTMLObjectElement::recalcStyle):
(WebCore::HTMLObjectElement::childrenChanged):
(WebCore::HTMLObjectElement::renderFallbackContent):
* html/HTMLObjectElement.h:
* html/HTMLPlugInElement.cpp:
* html/HTMLPlugInElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::renderEmbeddedObject):
* html/HTMLPlugInImageElement.h:
(WebCore::HTMLPlugInImageElement::needsWidgetUpdate):
(WebCore::HTMLPlugInImageElement::setNeedsWidgetUpdate):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::loadPlugin):
* loader/SubframeLoader.h:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::updateWidgetForObjectElement):
(WebCore::updateWidgetForEmbedElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 2 Sep 2010 09:05:59 +0000 (09:05 +0000)]
2010-09-02 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934
* fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Added.
* fast/dom/HTMLScriptElement/defer-double-defer-write.html: Added. Tests that a write of a deferred script from a deferred script will execute when the document is closed. The explicit close is necessary because this is a script created parser.
* fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Added.
* fast/dom/HTMLScriptElement/defer-double-write.html: Added. Tests that a script block written from a deferred script will write into the new document.
* fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Added.
* fast/dom/HTMLScriptElement/defer-inline-script.html: Added. Tests that inline scripts are not deferred. This is consistent with HTML5 and inconsistent with IE.
* fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Added.
* fast/dom/HTMLScriptElement/defer-onbeforeload.html: Added. Tests that the beforeload event is fired immediately and is cancellable.
* fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Added.
* fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Added. Tests that deferred scripts with invalid URLs are ignored and that subsequent deferred scripts will be run.
* fast/dom/HTMLScriptElement/defer-write-expected.txt: Added.
* fast/dom/HTMLScriptElement/defer-write.html: Added. Tests that a basic write from a deferred script blows away the document.
* fast/dom/HTMLScriptElement/resources/defer.js: Added.
* fast/dom/HTMLScriptElement/resources/external.js: Added.
* fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Added.
* fast/dom/HTMLScriptElement/shouldnotexecute.js: Added.
* fast/dom/HTMLScriptElement/two-defer-writes-expected.txt: Added.
* fast/dom/HTMLScriptElement/two-defer-writes.html: Added. Tests that when a document.write from the first deferred script blows away the document, subsequent deferred scripts are not executed.
* http/tests/misc/resources/defer-script.js: Added.
* http/tests/misc/resources/external-script.js: Added.
* http/tests/misc/resources/script-debug-body-background.js: Added.
* http/tests/misc/resources/script-write-slow-stylesheet.js: Added.
* http/tests/misc/resources/slow-defer-script.cgi: Added.
* http/tests/misc/resources/slow-stylesheet.cgi: Added.
* http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Added.
* http/tests/misc/script-defer-after-slow-stylesheet.html: Added. Tests that deferred scripts respect blocking stylesheets.
* http/tests/misc/script-defer-expected.txt: Added.
* http/tests/misc/script-defer.html: Added. Tests basic ordering of deferred scripts.
2010-09-02 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934
Tests: fast/dom/HTMLScriptElement/defer-double-defer-write.html
fast/dom/HTMLScriptElement/defer-double-write.html
fast/dom/HTMLScriptElement/defer-inline-script.html
fast/dom/HTMLScriptElement/defer-onbeforeload.html
fast/dom/HTMLScriptElement/defer-script-invalid-url.html
fast/dom/HTMLScriptElement/defer-write.html
fast/dom/HTMLScriptElement/two-defer-writes.html
http/tests/misc/script-defer-after-slow-stylesheet.html
http/tests/misc/script-defer.html
* dom/Document.cpp:
(WebCore::Document::open): Allow implicit open for writes() while executing deferred scripts.
* dom/DocumentParser.cpp:
(WebCore::DocumentParser::DocumentParser):
(WebCore::DocumentParser::startParsing):
(WebCore::DocumentParser::prepareToStopParsing): If called when stopped or detached, it shouldn't reset to stopping.
(WebCore::DocumentParser::stopParsing):
(WebCore::DocumentParser::detach):
* dom/DocumentParser.h:
(WebCore::DocumentParser::isParsing):
(WebCore::DocumentParser::isActive):
(WebCore::DocumentParser::isStopping):
(WebCore::DocumentParser::isDetached):
* dom/RawDataDocumentParser.h:
(WebCore::RawDataDocumentParser::finish):
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::append):
(WebCore::XMLDocumentParser::exitText):
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::characters):
(WebCore::XMLDocumentParser::error):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::internalSubset):
(WebCore::XMLDocumentParser::initializeParserContext):
(WebCore::XMLDocumentParser::doEnd):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::pumpTokenizerIfPossible):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::end):
(WebCore::HTMLDocumentParser::attemptToEnd):
(WebCore::HTMLDocumentParser::endIfDelayed):
(WebCore::HTMLDocumentParser::notifyFinished):
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::~HTMLScriptRunner):
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::requestDeferredScript):
(WebCore::HTMLScriptRunner::runScript):
* html/parser/HTMLScriptRunner.h:
* loader/ImageDocument.cpp:
(WebCore::ImageDocumentParser::finish):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 2 Sep 2010 08:25:45 +0000 (08:25 +0000)]
2010-09-02 Philippe Normand <pnormand@igalia.com>
Unreviewed, skipping new failing media test.
[Qt] media/media-can-play-mpeg4-video.html fails
https://bugs.webkit.org/show_bug.cgi?id=45093
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Sep 2010 07:52:42 +0000 (07:52 +0000)]
2010-09-02 Ilya Sherman <isherman@google.com>
Reviewed by Eric Seidel.
Decompose computing an element's inherited language, expose this
capability to clients (in particular, for Chromium).
https://bugs.webkit.org/show_bug.cgi?id=44803
No new tests -- just refactoring + exposing code.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* dom/Element.cpp:
(WebCore::Element::computeInheritedLang):
* dom/Element.h:
2010-09-02 Ilya Sherman <isherman@google.com>
Reviewed by Eric Seidel.
Exposing computing an element's inherited language, per the DOM, in the
Chromium API -- primarily for use with autofill i18n.
https://bugs.webkit.org/show_bug.cgi?id=44803
* public/WebElement.h:
* src/WebElement.cpp:
(WebKit::WebElement::computeInheritedLanguage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 2 Sep 2010 07:07:27 +0000 (07:07 +0000)]
2010-08-31 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GStreamer] can't play m4v videos
https://bugs.webkit.org/show_bug.cgi?id=44951
Fixed registration of the m4v media type in the hashtable used by
the player to report if it supports a given media type.
Test: media/media-can-play-mpeg4-video.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache):
LayoutTests:
Reviewed by Eric Carlson.
[GStreamer] can't play m4v videos
https://bugs.webkit.org/show_bug.cgi?id=44951
Test similar to media-can-play-mpeg-audio.html but for videos. For
now only m4v and mp4 types are tested.
* media/media-can-play-mpeg4-video-expected.txt: Added.
* media/media-can-play-mpeg4-video.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 2 Sep 2010 06:49:23 +0000 (06:49 +0000)]
2010-09-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] warning: unused variable "queryResult"
https://bugs.webkit.org/show_bug.cgi?id=44998
Fix the misbehavior introduced in r66573. The gst_element_query()
call needs to be done whatever the GStreamer version used.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 2 Sep 2010 06:45:52 +0000 (06:45 +0000)]
Updated Radar link
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 2 Sep 2010 06:43:50 +0000 (06:43 +0000)]
Add support for autocorrection UI on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=44958
<rdar://problem/
7299621>
Patch by Jia Pu <jpu@apple.com> on 2010-09-01
Reviewed by Dan Bernstein.
WebCore:
Several new member methods are added to EditorClient for communication
between WebCore and WebKit. A new handler, executeCancelOperation(), is
added to EditorCommand.cpp so that WebCore can intercept the ESC key event
to dismiss autocorrection UI. A new DocumentMarker value, RejectedCorrection,
is added to keep track of the corrections that user has rejected, so that it
will not be suggested again later. The autocorrection is driven by a timer.
Every time the editor inserts a new letter, the timer is reset. If the timer
fires, it means neither has user entered any new letter for current word, nor
has he entered whitespace or punctuation to complete the word. In this case,
we query for autocorrection.
* WebCore.exp.in: Updated
* dom/DocumentMarker.h: Added RejectedCorrection to indicate word on which user
has rejected autocorrection.
* editing/Editor.cpp:
(WebCore::Editor::Editor): Initialize autocorrection timer.
(WebCore::Editor::~Editor): Make sure autocorrection UI is dismissed before
destroying Editor object.
(WebCore::Editor::markMisspellingsAfterTypingToPosition): Adopted new signature
of markAllMisspellingsAndBadGrammarInRanges().
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Consolidated all
boolean arguments into one bitfield. This improves readability and allows us to
pass in a bit to indicate whether we want to show autocorrection UI. Also added
code to show autocorrection UI if it is necessary.
(WebCore::Editor::markMisspellingsAndBadGrammar): Adopted new signature of
markAllMisspellingsAndBadGrammarInRanges().
(WebCore::Editor::correctionPanelTimerFired): Check to see if we should show
autocorrection UI when user pauses during typing.
(WebCore::Editor::handleRejectedCorrection): Update user dictionary when an autocorrection is rejected.
(WebCore::Editor::startCorrectionPanelTimer): Start autocorrection timer.
(WebCore::Editor::handleCancelOperation): Dismiss autocorrection UI when ESC key is pressed.
* editing/Editor.h: Added autocorrection related member methods and variables.
* editing/EditorCommand.cpp:
(WebCore::executeCancelOperation): Handle ESC key event. Dismiss autocorrection UI.
(WebCore::createCommandMap): Updated for executeCancelOperation().
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::markMisspellingsAfterTyping): Reset autocorrection timer after insertion.
* loader/EmptyClients.h:
(WebCore::EmptyEditorClient::showCorrectionPanel): Dummy implementation.
(WebCore::EmptyEditorClient::dismissCorrectionPanel): Ditto
* page/EditorClient.h: Added methods for communication between WebCore and WebKit regarding autocorrection.
* page/Frame.cpp:
(WebCore::Frame::respondToChangedSelection): Remove Replacement marker where we used to only remove Spelling
mark, because whenever we need to remove spelling underline we also should remove autocorrection underline.
* platform/graphics/GraphicsContext.h: Added enum TextCheckingLineStyle to specify the underline
for different type of text checking result. Replaced drawLineForMisspellingOrBadGrammar() with
drawLineForTextChecking(), which allows autocorrection to have different indication from misspelling
and grammatical error.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking): Replaced drawLineForMisspellingOrBadGrammar() with drawLineForTextChecking().
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking): Ditto
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForTextChecking): Ditto
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking): Ditto
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking): Ditto
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking): Ditto
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking): Ditto
* platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking): Ditto
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking): Ditto
* rendering/InlineTextBox.cpp:
(WebCore::textCheckingLineStyleForMarkerType): Return line style for a given document marker type.
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Replaced drawLineForMisspellingOrBadGrammar() with drawLineForTextChecking().
(WebCore::InlineTextBox::paintDocumentMarkers): Handle new marker value, RejectedCorrection.
WebKit/mac:
See detailed high level description in WebCore/ChangeLog.
* WebCoreSupport/WebEditorClient.h: Added new member methods declared in
EditorClient. Added m_correctionPanelTag to store the ID of current autocorrection UI object.
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::WebEditorClient): Initialize m_correctionPanelTag.
(WebEditorClient::~WebEditorClient): Make sure the autocorrection UI is
dismissed before destroying the object.
(WebEditorClient::respondToChangedSelection): Dismiss autocorrection UI whenever the selection changes.
(WebEditorClient::showCorrectionPanel): Show autocorrection UI.
(WebEditorClient::dismissCorrectionPanel): Dismiss autocorrection UI.
WebKit2:
See detailed high level description in WebCore/ChangeLog.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::showCorrectionPanel): Dummy implementation.
(WebKit::WebEditorClient::dismissCorrectionPanel): Ditto
* WebProcess/WebCoreSupport/WebEditorClient.h: Added new methods declared in base class.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Thu, 2 Sep 2010 06:17:52 +0000 (06:17 +0000)]
2010-09-01 Kinuko Yasuda <kinuko@google.com>
Reviewed by Adam Barth.
[V8] Support readonly Date attribute
https://bugs.webkit.org/show_bug.cgi?id=43943
Adds Date to non_wrapper_types in CodeGeneratorV8.pm.
New tests will be added for Metadata when we add FileSystem implementation.
* bindings/scripts/CodeGeneratorV8.pm:
* fileapi/Metadata.h:
* fileapi/Metadata.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Sep 2010 05:27:04 +0000 (05:27 +0000)]
2010-09-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by Chris Marrin.
animations/suspend-resume-animation.html does not pass when accelerated compositing is off
https://bugs.webkit.org/show_bug.cgi?id=45057
animations/suspend-resume-animation.html now passes with the Chromium DRT
(it still fails with test_shell, since that doesn't have the suspend/resumeAnimations
API implemented)
* platform/chromium/drt_expectations.txt:
* platform/chromium/test_expectations.txt:
2010-09-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by Chris Marrin.
animations/suspend-resume-animation.html does not pass when accelerated compositing is off
https://bugs.webkit.org/show_bug.cgi?id=45057
Fix incorrect logic when resuming the animation (KeyframeAnimation::startAnimation
and RenderLayerBacking::startAnimation return true when running an accelerated
animation).
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 2 Sep 2010 04:47:42 +0000 (04:47 +0000)]
2010-09-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
Land a patched version of r66542 - change TestRunner to have an
separate cleanup method and fix the ordering of cleanup between
TestRunner and the printing module, and then wrap everything in a
try/finally block to ensure reliable cleanup without needing to
rely on stuff happening in the destructor of the TestRunner.
Also refactor run_webkit_tests.run() to be much smaller and cleaner
by creating a bunch of helper methods and moving more stuff into
the TestRunner class.
This fixes the crash at the end of the linux test run of
new-run-webkit-tests (and undoes the rollout in 66547).
https://bugs.webkit.org/show_bug.cgi?id=44902
* Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
* Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
* Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
* Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
* Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/layout_package/printing.py:
* Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 2 Sep 2010 04:00:14 +0000 (04:00 +0000)]
Fix the build.
As with CF, const struct OpaqueType* should be the default type
so that const_casts are not necessary in user code.
* UIProcess/API/C/WKArray.cpp:
(WKArrayCreate):
* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKType.cpp:
(WKGetTypeID):
(WKRetain):
(WKRelease):
* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
(toWK):
* WebProcess/InjectedBundle/API/c/WKBundleBase.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 2 Sep 2010 03:37:10 +0000 (03:37 +0000)]
Add mutable array API to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=45082
Reviewed by Adam Roben.
Add a mutable API to WebKit2 called WKMutableArrayRef. Make it "inherit" from
WKArrayRef in the same way JSObjectRef can inherit from JSValueRef in the JSC
API, by abusing the c type system (WKArrayRef is defined as a const version of
WKMutableArrayRef). Add very basic mutable API to go along with it.
* Shared/ImmutableArray.h:
(WebKit::ImmutableArray::isMutable):
Add ability to ask it an array is mutable.
* Shared/MutableArray.cpp: Added.
(WebKit::MutableArray::MutableArray):
(WebKit::MutableArray::~MutableArray):
(WebKit::MutableArray::append):
* Shared/MutableArray.h: Added.
(WebKit::MutableArray::create):
(WebKit::MutableArray::isMutable):
Sketch out the mutable array interface.
* UIProcess/API/C/WKAPICast.h:
(toWK):
Now that the opaque types can be const, use template magic to const_cast
it away.
* UIProcess/API/C/WKBase.h:
Add new type and re-type WKArrayRef as const.
* UIProcess/API/C/WKMutableArray.cpp: Added.
(WKMutableArrayCreate):
(WKArrayIsMutable):
(WKArrayAppendItem):
* UIProcess/API/C/WKMutableArray.h: Added.
Fill in basic API.
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
Add files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Thu, 2 Sep 2010 03:31:03 +0000 (03:31 +0000)]
2010-09-01 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Remove dependency on JS files for V8 logs processing.
https://bugs.webkit.org/show_bug.cgi?id=45045
* WebKit.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Sep 2010 03:14:51 +0000 (03:14 +0000)]
2010-09-01 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement PluginInfoStore for UNIX
https://bugs.webkit.org/show_bug.cgi?id=45038
This implementation is generally just reusing the logic in WebCore since
there is no way to get informations from a UNIX plugin without loading it
- in contrast to mac bundles and windows dll-s.
* UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:
(WebKit::PluginInfoStore::pluginsDirectories):
(WebKit::PluginInfoStore::pluginPathsInDirectory):
(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::shouldUsePlugin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Sep 2010 02:57:05 +0000 (02:57 +0000)]
2010-09-01 Matthew Willis <lilmatt@flock.com>
Reviewed by Alexey Proskuryakov.
Add tests to ensure any h1-h6 element can close any other h1-h6 element.
https://bugs.webkit.org/show_bug.cgi?id=15136
<rdar://problem/
5762882>
* fast/html/numbered-header-element-expected.txt: Added.
* fast/html/numbered-header-element.html: Added.
* fast/html/script-tests/numbered-header-element.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 2 Sep 2010 02:23:10 +0000 (02:23 +0000)]
Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
Reviewed by Adam Roben.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 2 Sep 2010 02:23:06 +0000 (02:23 +0000)]
<rdar://problem/
8374711> WebKit needs to compile without access to QuickDraw private headers.
Reviewed by Adam Roben.
* Carbon/HIViewAdapter.m:
* Carbon/HIWebView.mm:
* Misc/QuickDrawCompatibility.h: Added.
* Plugins/WebNetscapePluginView.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Thu, 2 Sep 2010 02:13:48 +0000 (02:13 +0000)]
2010-09-01 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Question mark QuickTime icon when navigating to this MP3 file
https://bugs.webkit.org/show_bug.cgi?id=44846
Do not disable 'tmet' movie tracks, they carry meta data.
No DRT test because I am not sure it is possible to have one of these tracks in
non-streaming movie. I will add a test later if I figure out how to create a movie.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 2 Sep 2010 02:11:45 +0000 (02:11 +0000)]
2010-09-01 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Remove rendering types from SubframeLoader and split RenderEmbeddedObject::updateWidget in preparation for moving to DOM
https://bugs.webkit.org/show_bug.cgi?id=45007
This is just moving around code (and attempting to make it more sane).
I also tried to use more specific types where possible.
The SubframeLoader no longer uses any rendering types in its API.
I split RenderEmbeddedObject::updateWidget into a bunch of functions.
It was obvious before, but now super-obvious after the split that these
new functions do not belong in RenderEmbeddedObject. Instead they
need to be moved to their respective DOM classes. I've added FIXMEs
next to each of the functions which should be moved, but I've not moved
any of the logic out of RenderEmbeddedObject.cpp yet in an effort to
keep this patch as simple as possible.
No functional change, thus no tests.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::attach):
(WebCore::HTMLFrameElementBase::width):
(WebCore::HTMLFrameElementBase::height):
* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::renderPart):
* html/HTMLFrameOwnerElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderWidgetForJSBindings):
(WebCore::HTMLObjectElement::createRenderer):
(WebCore::HTMLObjectElement::updateWidget):
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::renderEmbeddedObject):
* html/HTMLPlugInElement.h:
* loader/PluginDocument.cpp:
(WebCore::PluginDocumentParser::appendBytes):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::document):
(WebCore::SubframeLoader::loadPlugin):
* loader/SubframeLoader.h:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::isNetscapePlugin):
(WebCore::hasFallbackContent):
(WebCore::parametersFromObject):
(WebCore::updateWidgetForObjectElement):
(WebCore::parametersFromEmbed):
(WebCore::updateWidgetForEmbedElement):
(WebCore::updateWidgetForMediaElement):
(WebCore::RenderEmbeddedObject::updateWidget):
* rendering/RenderEmbeddedObject.h:
(WebCore::RenderEmbeddedObject::setHasFallbackContent):
* rendering/RenderLayerCompositor.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Thu, 2 Sep 2010 02:03:45 +0000 (02:03 +0000)]
Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
and WebKitTestRunner.
Reviewed by Adam Roben.
* BuildSlaveSupport/win/kill-old-processes:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Thu, 2 Sep 2010 01:20:29 +0000 (01:20 +0000)]
2010-09-01 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
Add more FileError and FileException code for FileWriter and FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=45048
Adding SYNTAX_ERR for FileWriter.
http://dev.w3.org/2009/dap/file-system/file-writer.html
Adding INVALID_STATE_ERR, INVALID_MODIFICATION_ERR and QUOTA_EXCEEDED_ERR for FileSystem.
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html
Adding NO_MODIFICATION_ALLOWED_ERR (to FileException) for both.
* fileapi/FileError.idl:
* fileapi/FileException.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Sep 2010 01:00:51 +0000 (01:00 +0000)]
2010-09-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by Brady Eidson.
popstate event is not fired until document opts in by calling pushstate.
https://bugs.webkit.org/show_bug.cgi?id=41372
Add two tests to check how often popstate is being fired (for both
fragment changes and page changes, especially with the page cache
enabled).
Update existing state object tests to handle popstate being fired for
the page being navigated to (right after onload).
* fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
* fast/loader/stateobjects/document-destroyed-navigate-back.html:
* fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html:
* fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html:
* fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html:
* fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html:
* fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt: Added.
* fast/loader/stateobjects/popstate-fires-on-history-traversal.html: Added.
* fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt: Added.
* fast/loader/stateobjects/popstate-fires-with-page-cache.html: Added.
* fast/loader/stateobjects/pushstate-object-types.html:
* fast/loader/stateobjects/pushstate-then-replacestate.html:
* fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
* fast/loader/stateobjects/replacestate-in-iframe.html:
* fast/loader/stateobjects/replacestate-then-pushstate.html:
* fast/loader/stateobjects/resources/popstate-fires-with-page-cache-1.html: Added.
* fast/loader/stateobjects/resources/popstate-fires-with-page-cache-2.html: Added.
* fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html:
2010-09-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by Brady Eidson.
popstate event is not fired until document opts in by calling pushstate.
https://bugs.webkit.org/show_bug.cgi?id=41372
Fire popstate even when we don't have a state object when a page is
loaded (for both regular loads and those from the page cache). Also
fire popstate when doing in-document navigation via fragment changes.
This is consistent with both Gecko and recent the HTML5 spec change:
http://html5.org/tools/web-apps-tracker?from=5376&to=5377
Tests: fast/loader/stateobjects/popstate-fires-on-history-traversal.html
fast/loader/stateobjects/popstate-fires-with-page-cache.html
* bindings/js/SerializedScriptValue.cpp:
* bindings/js/SerializedScriptValue.h:
(WebCore::SerializedScriptValue::create):
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/SerializedScriptValue.h:
* dom/Document.cpp:
(WebCore::Document::implicitClose):
* dom/Document.h:
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::transitionToCommitted):
* loader/HistoryController.cpp:
(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 2 Sep 2010 00:25:40 +0000 (00:25 +0000)]
2010-09-01 Kent Tamura <tkent@chromium.org>
Unreviewed, rolling out r66576.
http://trac.webkit.org/changeset/66576
https://bugs.webkit.org/show_bug.cgi?id=45016
This change is not needed.
* public/WebKitClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 2 Sep 2010 00:20:54 +0000 (00:20 +0000)]
Allow the web process to load frameworks other than WebKit2.framework from the build directory
when running engineering builds.
Reviewed by Sam Weinig.
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain): Pass the path containing WebKit2.framework to the sandbox rather than
the path of the WebKit2.framework itself.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Wed, 1 Sep 2010 23:26:39 +0000 (23:26 +0000)]
2010-09-01 Matthew Willis <lilmatt@flock.com>
Reviewed by Joseph Pecoraro.
Fix failing test: inspector/console-format.html (regression from r66616)
https://bugs.webkit.org/show_bug.cgi?id=45067
* inspector/console-format-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 1 Sep 2010 23:18:52 +0000 (23:18 +0000)]
2010-09-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dimitri Glazkov.
REGRESSION(r66431): WebCore::Editor::selectionStartCSSPropertyValue crashes if no background color is specified
https://bugs.webkit.org/show_bug.cgi?id=45068
The crash was caused by the assumption that every node has an ancestor with some background color,
which was obviously false. Fixed this by adding a null for ancestor.
Test: editing/execCommand/backcolor-crash.html
* editing/Editor.cpp:
(WebCore::Editor::selectionStartCSSPropertyValue):
2010-09-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dimitri Glazkov.
REGRESSION(r66431): WebCore::Editor::selectionStartCSSPropertyValue crashes if no background color is specified
https://bugs.webkit.org/show_bug.cgi?id=45068
Added a test to ensure WebKit doesn't crash when backColor is queried on a node without any ancestors
with a background color.
* editing/execCommand/backcolor-crash-expected.txt: Added.
* editing/execCommand/backcolor-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 1 Sep 2010 23:14:53 +0000 (23:14 +0000)]
2010-09-01 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
WebViews should allow their parent windows to handle WM_MOUSEACTIVATE messages.
https://bugs.webkit.org/show_bug.cgi?id=45047
* WebView.cpp:
(WebView::WebViewWndProc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 1 Sep 2010 22:55:53 +0000 (22:55 +0000)]
2010-08-31 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
WebKit should not accept PDFs as video.
https://bugs.webkit.org/show_bug.cgi?id=45013
QuickTime will accept a PDF as the source for a movie, and happily
convert that PDF into a .mov. WebKit should disable the eat and grip
PDF components which allow this.
Test: http/tests/media/pdf-served-as-pdf.html
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::createQTMovie): Add PDF eat and grip
components to the components which are disabled before opening a
QTMovie.
2010-08-31 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
WebKit should not accept PDFs as video.
https://bugs.webkit.org/show_bug.cgi?id=45013
Added a new test, similar to the text-served-as-text.html test, which
expects an error thrown when a PDF is set as the source of a <video>
element.
* http/tests/media/pdf-served-as-pdf-expected.txt: Added.
* http/tests/media/pdf-served-as-pdf.html: Added.
* http/tests/media/resources/test.pdf: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 1 Sep 2010 22:35:34 +0000 (22:35 +0000)]
Change ImmutableArray to be backed by a Vector
https://bugs.webkit.org/show_bug.cgi?id=45064
Reviewed by John Sullivan.
Change ImmutableArray to be backed by a Vector to work toward having
a mutable subclass and to improve the API when working with it in WebKit2
itself.
- Also remove WKArrayCreateAdoptingValues which was confusing and unused.
* Shared/ImmutableArray.cpp:
(WebKit::ImmutableArray::ImmutableArray):
(WebKit::ImmutableArray::~ImmutableArray):
* Shared/ImmutableArray.h:
(WebKit::ImmutableArray::adopt):
(WebKit::ImmutableArray::at):
(WebKit::ImmutableArray::size):
* Shared/ImmutableDictionary.cpp:
(WebKit::ImmutableDictionary::keys):
* UIProcess/API/C/WKArray.cpp:
* UIProcess/API/C/WKArray.h:
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
* UIProcess/WebContext.cpp:
(WebKit::PostMessageEncoder::PostMessageDecoder::decode):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::PostMessageEncoder::PostMessageDecoder::decode):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::childFrames):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 1 Sep 2010 22:00:36 +0000 (22:00 +0000)]
2010-09-01 Tony Chang <tony@chromium.org>
Unreviewed, updating a chromium baseline, the only difference is in
the anti-aliasing of the rounded border (a result of r66615).
* platform/chromium-win/fast/borders/border-radius-huge-assert-expected.checksum:
* platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 1 Sep 2010 21:36:11 +0000 (21:36 +0000)]
Add URLResponse API for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=45062
Reviewed by Anders Carlsson.
Add WebURLResponse class and WKURLResponseRef C API to go with it. Right now,
instance of WKURLResponseRef are manipulated via platform types just like
WKURLRequestRef.
This just adds the type and conversion functions, no uses yet.
* Shared/APIObject.h:
* Shared/WebCoreArgumentCoders.h:
* Shared/WebURLResponse.cpp: Added.
(WebKit::WebURLResponse::WebURLResponse):
* Shared/WebURLResponse.h: Added.
(WebKit::WebURLResponse::create):
(WebKit::WebURLResponse::resourceResponse):
(WebKit::WebURLResponse::type):
* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::encodeWithNSKeyedArchiver):
(CoreIPC::decodeWithNSKeyedArchiver):
(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):
* Shared/mac/WebURLResponseMac.mm: Added.
(WebKit::WebURLResponse::WebURLResponse):
(WebKit::WebURLResponse::platformResponse):
* Shared/qt/WebURLResponseQt.cpp: Added.
(WebKit::WebURLResponse::WebURLResponse):
(WebKit::WebURLResponse::platformResponse):
* Shared/win/WebURLResponseWin.cpp: Added.
(WebKit::WebURLResponse::WebURLResponse):
(WebKit::WebURLResponse::platformResponse):
* UIProcess/API/C/WKURLResponse.cpp: Added.
(WKURLResponseGetTypeID):
* UIProcess/API/C/WKURLResponse.h: Added.
* UIProcess/API/C/cf/WKURLResponseCF.cpp: Added.
(WKURLResponseCreateWithCFURLResponse):
(WKURLResponseCopyCFURLResponse):
* UIProcess/API/C/cf/WKURLResponseCF.h: Added.
* UIProcess/API/C/mac/WKURLResponseNS.h: Added.
* UIProcess/API/C/mac/WKURLResponseNS.mm: Added.
(WKURLResponseCreateWithNSURLResponse):
(WKURLResponseCopyNSURLResponse):
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 1 Sep 2010 21:06:36 +0000 (21:06 +0000)]
2010-09-01 Tony Chang <tony@chromium.org>
Unreviewed, updating chromium test expectations.
* platform/chromium-mac/fast/js/kde/RegExp-expected.txt: Rebaseline
* platform/chromium-win/fast/forms/focus2-expected.txt: Removed because it's wrong.
* platform/chromium-win/fast/js/kde/RegExp-expected.txt: Rebaseline
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 1 Sep 2010 20:16:41 +0000 (20:16 +0000)]
JavaScriptCore: Ecma-262 15.11.1.1 states that if the argument is undefined then an
Error object's message property should be set to the empty string.
Rubber stamped by Oliver Hunt.
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
(JSC::ErrorInstance::create):
* runtime/ErrorInstance.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
LayoutTests: Fix three tests in fast/js/kde are failing; fix them.
Rubber stamped by Oliver Hunt.
exceptions.js:
This is failing because it redefines the method 'should be'.
Rename the test's version of this method.
RegExp.js:
This tests erroneously expects a failed match to update the
cached results on the RegExp object; these are only updated
on a successful match.
evil-n.js:
This test erroneously expects the message property of a newly
constructed Error with no arguments to be undefined; the ECMA
262-5 spec requires this to be "". Two sputnik tests contain
the same error (the sputnik tests is actually testing 262-3
compatibility, which is not what we're interested in).
* fast/js/kde/RegExp-expected.txt:
* fast/js/kde/evil-n-expected.txt:
* fast/js/kde/exceptions-expected.txt:
* fast/js/kde/script-tests/RegExp.js:
* fast/js/kde/script-tests/evil-n.js:
* fast/js/kde/script-tests/exceptions.js:
(kdeShouldBe):
(testThrow):
(testThrow2):
(testReferenceError):
(testFunctionError):
(testMathFunctionError):
(testWhileAbortion):
* fast/js/sputnik/Conformance/15_Native_Objects/15.11_Error/15.11.1/S15.11.1.1_A1_T1.html:
* fast/js/sputnik/Conformance/15_Native_Objects/15.11_Error/15.11.2/S15.11.2.1_A1_T1.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Wed, 1 Sep 2010 19:51:32 +0000 (19:51 +0000)]
2010-09-01 Rob Buis <rwlbuis@gmail.com>
Reviewed by Darin Adler.
Support for Percentage Values in border-radius
https://bugs.webkit.org/show_bug.cgi?id=38354
Support percentage values on the border-radius family
of CSS properties.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getBorderRadiusCornerValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseBorderRadius):
* css/CSSPrimitiveValue.cpp:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::ensurePropertyMap):
* platform/Length.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
* rendering/style/BorderData.h:
(WebCore::BorderData::BorderData):
(WebCore::BorderData::hasBorderRadius):
(WebCore::BorderData::topLeft):
(WebCore::BorderData::topRight):
(WebCore::BorderData::bottomLeft):
(WebCore::BorderData::bottomRight):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getBorderRadiiForRect):
(WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::borderTopLeftRadius):
(WebCore::InheritedFlags::borderTopRightRadius):
(WebCore::InheritedFlags::borderBottomLeftRadius):
(WebCore::InheritedFlags::borderBottomRightRadius):
(WebCore::InheritedFlags::setBorderTopLeftRadius):
(WebCore::InheritedFlags::setBorderTopRightRadius):
(WebCore::InheritedFlags::setBorderBottomLeftRadius):
(WebCore::InheritedFlags::setBorderBottomRightRadius):
(WebCore::InheritedFlags::setBorderRadius):
(WebCore::InheritedFlags::initialBorderRadius):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc