15 years agoWebCore:
bdakin@apple.com [Wed, 12 Dec 2007 03:23:35 +0000 (03:23 +0000)]

        Reviewed by Darin.

        Fix for <rdar://problem/5641255> SVGs with width and height 100%
        fail to render when used as background images

        CachedImage now has a setImageContainerSize function. It is only
        needed for SVG right now.
        * loader/CachedImage.cpp:
        * loader/CachedImage.h:

        Relatively sized SVGs have no intrinsic size. Because this call is
        low-level enough that we cannot pass in the container size and get
        the real size of the SVG, we need to know if it has relative
        dimensions, and if so, we need to get the size from scaledTileSize.
        * platform/graphics/Image.cpp:
        * platform/graphics/Image.h:

        Re-factored calculateBackgroundSize a bit so that it returns an
        IntSize. Made it a member function so that it can send m_width and
        m_height along to setImageContainerSize.
        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:

        Need to account for relatively sized SVGs in calcViewport()
        * rendering/RenderSVGRoot.cpp:

        Added new member variables to store the size of the SVG container.
        relativeWidthValue() and relativeHeightValue() use the stored SVG
        container size to correctly calculate the width and height of a
        relatively sized SVG.
        * svg/SVGSVGElement.cpp:
        * svg/SVGSVGElement.h:

        Re-factored size calculations to use the size of the container.
        * svg/graphics/SVGImage.cpp:
        * svg/graphics/SVGImage.h:


        Reviewed by Darin.

        Tests for <rdar://problem/5641255> SVGs with width and height 100%
        fail to render when used as background images

        * fast/backgrounds/resources/balloon.svg: Added.
        * fast/backgrounds/resources/eyes.svg: Added.
        * fast/backgrounds/resources/hearts.svg: Added.
        * fast/backgrounds/resources/linguistics.svg: Added.
        * fast/backgrounds/resources/map.svg: Added.
        * fast/backgrounds/resources/mouse-repel.svg: Added.
        * fast/backgrounds/svg-as-background-1.html: Added.
        * fast/backgrounds/svg-as-background-2.html: Added.
        * fast/backgrounds/svg-as-background-3.html: Added.
        * fast/backgrounds/svg-as-background-4.html: Added.
        * fast/backgrounds/svg-as-background-5.html: Added.
        * fast/backgrounds/svg-as-background-6.html: Added.
        * platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-1-expected.png: Added.
        * platform/mac/fast/backgrounds/svg-as-background-1-expected.txt: Added.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Added.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.txt: Added.
        * platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-3-expected.png: Added.
        * platform/mac/fast/backgrounds/svg-as-background-3-expected.txt: Added.
        * platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-4-expected.png: Added.
        * platform/mac/fast/backgrounds/svg-as-background-4-expected.txt: Added.
        * platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-5-expected.png: Added.
        * platform/mac/fast/backgrounds/svg-as-background-5-expected.txt: Added.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Added.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Added.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam Weinig.
ggaren@apple.com [Wed, 12 Dec 2007 01:32:11 +0000 (01:32 +0000)]
    Reviewed by Sam Weinig.

        Build fix: Note some variables that are used only for ASSERTs.

        * API/testapi.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
ggaren@apple.com [Wed, 12 Dec 2007 00:30:04 +0000 (00:30 +0000)]
    Reviewed by Darin Adler.

        Fixed: All JS tests crash on Windows.

        NDEBUG wasn't defined when compiling testkjs in release builds, so the
        HashTable definition in HashTable.h included an extra data member.

        The solution was to add NDEBUG to the release testkjs configuration on
        Windows and Mac.

        For giggles, I also added other missing #defines to testkjs on Windows.

        * Configurations/Base.xcconfig:
        * Configurations/JavaScriptCore.xcconfig:
        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/testkjs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-11 George Wright <george.wright@collabora.co.uk>
alp@webkit.org [Wed, 12 Dec 2007 00:05:08 +0000 (00:05 +0000)]
2007-12-11  George Wright  <george.wright@collabora.co.uk>

        Reviewed by Alp Toker.

        [GDK] Support input methods

        This patch adds infrastructure for input method support.

        It also adds Hildon features for the Maemo mobile platform sufficient
        to support the virtual keyboard.

        * WebCoreSupport/EditorClientGtk.cpp:
        * WebCoreSupport/EditorClientGtk.h:
        * WebView/webkitprivate.h:
        * WebView/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
andersca@apple.com [Tue, 11 Dec 2007 23:05:25 +0000 (23:05 +0000)]
    Reviewed by Darin.

        WebKit needs API to allow registering a protocol as local (RSS feeds appear unstyled)

        * Interfaces/IWebView.idl:
        * WebView.cpp:
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Updated the database SPI to take in IWebFrame.
adachan@apple.com [Tue, 11 Dec 2007 22:39:29 +0000 (22:39 +0000)]
    Updated the database SPI to take in IWebFrame.

        Reviewed by Adam.

        * Interfaces/IWebUIDelegatePrivate.idl:
        * WebChromeClient.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * editing/Editor.cpp:
darin@apple.com [Tue, 11 Dec 2007 22:33:57 +0000 (22:33 +0000)]
    * editing/Editor.cpp:
        (WebCore::Editor::yankFromKillRing): Try to fix non-Mac builds by adding
        a missing return statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows build fix.
ap@webkit.org [Tue, 11 Dec 2007 21:35:22 +0000 (21:35 +0000)]
    Windows build fix.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRubberstamped by Mark.
zimmermann@webkit.org [Tue, 11 Dec 2007 21:16:38 +0000 (21:16 +0000)]
Rubberstamped by Mark.
Add missing tests - their results have already been checked in over a month ago - I forgot to commit the tests itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRubberstamped by Mark.
zimmermann@webkit.org [Tue, 11 Dec 2007 21:14:52 +0000 (21:14 +0000)]
Rubberstamped by Mark.
Update pixel test results now that filters are disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
ggaren@apple.com [Tue, 11 Dec 2007 21:02:44 +0000 (21:02 +0000)]
    Reviewed by Darin Adler.

        Removed bogus ASSERT.

        ASSERT should only be used when we know that a code path will not be
        taken. This code path is taken often during the jsFunFuzz test.

        * pcre/pcre_exec.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin@apple.com [Tue, 11 Dec 2007 20:26:56 +0000 (20:26 +0000)]

        Reviewed by Geoff.

        - exposed many new commands to the DOM Document executeCommand function by
          merging the JSEditor and Editor executeCommand implementations
        - replaced the execCommand function with a EditorCommand class
        - replaced the WTF::StrHash<> class template with the WebCore::StringHash class
        - replaced the WTF::CaseInsensitiveHash<> class template with the
          WebCore::CaseFoldingHash class

        * WebCore.base.exp: Updated.
        * WebCore.pro: Added EditorCommand.cpp, removed JSEditor.cpp.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.

        * dom/Document.cpp:
        (WebCore::Document::Document): Removed code to set up m_jsEditor.
        (WebCore::Document::~Document): Removed code to delete m_jsEditor.
        (WebCore::command): Added. Helper function that gets an Editor::Command.
        (WebCore::Document::executeCommand): Changed to use Editor::Command instead of
        (WebCore::Document::queryCommandEnabled): Ditto.
        (WebCore::Document::queryCommandState): Ditto.
        (WebCore::Document::queryCommandSupported): Ditto.
        (WebCore::Document::queryCommandValue): Ditto.

        * dom/Document.h: Removed JSEditor, jsEditor, m_jsEditor. Changed to
        use CaseFoldingHash.

        * editing/Editor.cpp:
        (WebCore::Editor::selectionForCommand): Renamed from selectionForEvent and
        made into a member function so it is accessible from the new EditorCommand.cpp file.
        Also changed to get the selection from the passed-in frame instead of from the
        page, because this should work on the targeted frame unless the event overrides it.
        (WebCore::Editor::handleKeypress): Updated for selectionForCommand change.
        (WebCore::Editor::handleInputMethodKeypress): Ditto.
        (WebCore::imageElementFromImageDocument): Renamed and changed to return
        a HTMLImageElement instead of a Node*.
        (WebCore::Editor::canCopy): Updated for name change.
        (WebCore::Editor::selectionUnorderedListState): Updated for TriState change.
        (WebCore::Editor::selectionOrderedListState): Ditto.
        (WebCore::Editor::selectionStartHasStyle): Make type of local more specific.
        (WebCore::updateState): Moved here from Frame.
        (WebCore::Editor::selectionHasStyle): Ditto.
        (WebCore::Editor::Editor): Initialize m_shouldStartNewKillRingSequence.
        (WebCore::Editor::insertTextWithoutSendingTextEvent): Updated for
        selectionForCommand change.
        (WebCore::Editor::copy): Updated for imageElementFromImageDocument change.
        (WebCore::Editor::toggleBold): Call the ToggleBold command via the command
        machinery since it's no longer in this file as a local function.
        (WebCore::Editor::toggleUnderline): Call the ToggleUnderline command.
        (WebCore::Editor::setBaseWritingDirection): Change type of argument and of
        local variable.
        (WebCore::Editor::addToKillRing): Moved here from EditorMac. Not useful
        without a kill ring, but it's relatively straightforward to implement one.
        (WebCore::Editor::appendToKillRing): Put default implementation here for
        platforms other than Mac. We should probably put a simple kill ring
        implementation here -- doesn't need to be shared with the OS oh platforms
        other than Mac.
        (WebCore::Editor::prependToKillRing): Ditto.
        (WebCore::Editor::yankFromKillRing): Ditto.
        (WebCore::Editor::startNewKillRingSequence): Ditto.
        (WebCore::Editor::setKillRingToYankedState): Ditto.

        * editing/Editor.h: Moved the TriState enum here instead of inside the
        Frame class. Added EditorCommandSource enum. Moved selectionHasStyle
        here from the Frame class. Added Editor::Command class with five functions
        for the various things you can do with a command (execute it, check if it
        can be used, and its state and value). Changed hte parameter of
        setBaseWritingDirection to be a const String& rather than a String.
        Got rid of the kill-ring-related operations, but added the kill ring
        functions themselves. Made selectedRange() public. Made the
        m_startNewKillRingSequence not Mac-specific and added "should" to its

        * editing/EditorCommand.cpp: Copied from WebCore/editing/Editor.cpp.
        Retained only the editing commands.
        (WebCore::targetFrame): Moved to the top of the file.
        (WebCore::executeApplyStyle): Added. Helper function for commands
        that need to apply styles.
        (WebCore::executeToggleStyle): Added. Helper function for commands
        that need to toggle styles based on the style of the start of selection.
        (WebCore::executeApplyParagraphStyle): Added. Like executeApplyStyle, but
        for paragraph styles.
        (WebCore::executeInsertFragment): Added. Helper function for commands
        that need to insert a DOM fragment.
        (WebCore::executeInsertNode): Added. Helper function for commands that
        need to insert a tree rooted in a single DOM node.
        (WebCore::stateStyle): Added. Helper function for the state of commands
        that represent style.
        (WebCore::valueStyle): Added. Helper function for the value of commands
        that represent style.
        (WebCore::canScroll): Added. Helper functions for some move and scroll
        commands that need to determine if the renderer they are in can scroll.
        (WebCore::unionDOMRanges): Moved here from EditorMac.
        (WebCore::createCommandMap): Added lots of commands, including all the commands
        from JSEditor. A few commands needed different behavior based on whether they are
        invoked from the DOM or a keyboard binding.
        (WebCore::Editor::command): Added. Gets a command object given a name.
        (WebCore::Editor::Command::Command): Added.
        (WebCore::Editor::Command::execute): Added.
        (WebCore::Editor::Command::isSupported): Added.
        (WebCore::Editor::Command::isEnabled): Added.
        (WebCore::Editor::Command::state): Added.
        (WebCore::Editor::Command::value): Added.
        (WebCore::Editor::execCommand): Changed to call command().execute().

        * editing/JSEditor.cpp: Removed.
        * editing/JSEditor.h: Removed.

        * editing/mac/EditorMac.mm: Changed to provide kill ring primitives intead of
        kill ring commands, so the kill ring commands can be cross-platform.
        (WebCore::Editor::appendToKillRing): Added.
        (WebCore::Editor::prependToKillRing): Added.
        (WebCore::Editor::yankFromKillRing): Added.
        (WebCore::Editor::startNewKillRingSequence): Added.
        (WebCore::Editor::setKillRingToYankedState): Added.

        * page/Frame.cpp: Removed selectionHasStyle, TriState, and updateState.
        * page/Frame.h: Ditto.

        * page/mac/WebCoreFrameBridge.mm: Removed selectionHasStyle.
        * page/mac/WebCoreFrameBridge.h: Ditto.

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for TriState change.

        * platform/text/StringHash.h:
        (WebCore::StringHash::hash): Merged the StrHash<> template classes into this.
        (WebCore::StringHash::equal): Ditto.
        (WebCore::CaseFoldingHash::hash): Merged the CaseInsensitiveHash<> template
        classes into this.
        (WebCore::CaseFoldingHash::equal): Ditto.

        * platform/text/StringImpl.cpp:
        (WebCore::equal): Changed to invoke StringHash.
        (WebCore::equalIgnoringCase): Changed to invoke CaseFoldingHash.

        * dom/DOMImplementation.cpp:
        (WebCore::addString): Updated to use StringHash and CaseFoldingHash.
        (WebCore::isSVG10Feature): Ditto.
        (WebCore::isSVG11Feature): Ditto.
        * loader/FrameLoader.cpp:
        (WebCore::localSchemes): Ditto.
        * platform/graphics/FontCache.cpp:
        (WebCore::computeHash): Ditto.
        * platform/network/HTTPHeaderMap.h: Ditto.
        * platform/text/PlatformString.h: Ditto.
        * platform/text/StringImpl.h: Ditto.
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget): Ditto.
        * xml/XMLHttpRequest.cpp:
        (WebCore::canSetRequestHeader): Ditto.

        * rendering/RenderTreeAsText.cpp: Removed stray include of JSEditor.h.


        Reviewed by Geoff.

        - change more editing commands to use WebCore::Editor
        - change to use the new WebCore::Editor::command() function

        * WebView/WebHTMLView.mm: Changed alignCenter, alignJustified, alignLeft,
        alignRight, cut, copy, deleteToMark, indent, insertNewlineIgnoringFieldEditor,
        insertTabIgnoringFieldEditor, outdent, selectAll, selectToMark, setMark,
        subscript, superscript, swapWithMark, underline, unscript, yank, and yankAndSelect
        to use the "forward to WebCore" macro instead of having hand-written implementations.
        (kit): Added function to change a TriState to an AppKit-style tri-state value.
        (-[WebHTMLView coreCommandBySelector:]): Added. No longer converts case of the
        first character or copies the selector name, since the Editor commands are not case
        sensitive any more. Returns a command object.
        (-[WebHTMLView coreCommandByName:]): Added.
        (-[WebHTMLView executeCoreCommandBySelector:]): Renamed from callWebCoreCommand:,
        and changed to use the new coreCommandBySelector: method.
        (-[WebHTMLView executeCoreCommandByName:]): Added.
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Changed all the
        methods that call through to WebCore to also use the state() and isEnabled()
        functions on the commands for the menu item state and user interface item enabling.
        (-[WebHTMLView _handleStyleKeyEquivalent:]): Use ToggleBold and ToggleItalic by
        name rather than having local methods for them; no need for methods with a single
        call site.
        (-[WebHTMLView insertParagraphSeparator:]): Use executeCoreCommandByName: rather
        than the deprecated execCommand().
        (-[WebHTMLView doCommandBySelector:]): Changed to use command().execute() rather
        than the deprecated execCommand().
        * WebView/WebHTMLViewInternal.h: Removed some unneeded method declarations.


        * WebView.cpp:
        (WebView::handleEditingKeyboardEvent): Update for change to Editor API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * platform/wx/KeyboardEventWx.cpp:
darin@apple.com [Tue, 11 Dec 2007 20:24:34 +0000 (20:24 +0000)]
    * platform/wx/KeyboardEventWx.cpp:
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Another try at fixing the
        WX build. Changes the code around a little bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders
beidson@apple.com [Tue, 11 Dec 2007 20:00:28 +0000 (20:00 +0000)]
    Reviewed by Anders

        Make DumpRenderTree on mac use its own path for Databases testing

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree
          for future DRT-only use, then use it to construct the Databases path and set that default

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * platform/wx/KeyboardEventWx.cpp:
darin@apple.com [Tue, 11 Dec 2007 19:57:22 +0000 (19:57 +0000)]
    * platform/wx/KeyboardEventWx.cpp:
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Quick try at fixing build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * wtf/unicode/qt4/UnicodeQt4.h: Try to fix Qt build by adding U16_IS_SINGLE.
darin@apple.com [Tue, 11 Dec 2007 19:54:15 +0000 (19:54 +0000)]
    * wtf/unicode/qt4/UnicodeQt4.h: Try to fix Qt build by adding U16_IS_SINGLE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Tue, 11 Dec 2007 19:36:12 +0000 (19:36 +0000)]

        Reviewed by Darin Adler.

        - fix <rdar://problem/5631507> Text doesn't wrap properly at Tamil version of Wikipedia

        Test: fast/text/international/complex-character-based-fallback.html

        * platform/graphics/Font.cpp:
        (WebCore::Font::glyphDataForCharacter): Added a forceSmallCaps argument
        that forces this function to use the small caps font. It is used for
        combining marks that need to combine with a small cap.
        * platform/graphics/Font.h:
        * platform/win/UniscribeController.cpp:
        (WebCore::UniscribeController::advance): Changed to split the string
        into runs of characters that will be rendered using the same FontData.
        This is done by calling glyphDataForCharacter() for each cahracter to
        find the FontData it should be rendered with.
        (WebCore::UniscribeController::itemizeShapeAndPlace): Added a fontData
        argument that is passed on to shapeAndPlaceItem() instead of the
        smallCaps argument.
        (WebCore::UniscribeController::shapeAndPlaceItem): Added a fontData
        argument and removed the font fallback logic from this function, as
        it is now expected to be called with an item all of whose characters
        can be rendered with the given fontData.
        * platform/win/UniscribeController.h:


        Reviewed by Darin Adler.

        - test for <rdar://problem/5631507> Text doesn't wrap properly at Tamil version of Wikipedia

        * fast/text/international/complex-character-based-fallback.html: Added.
        * platform/mac-leopard/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
        * platform/mac-leopard/fast/text/international/complex-character-based-fallback-expected.png: Added.
        * platform/mac/fast/text/international/complex-character-based-fallback-expected.txt: Added.
        * platform/win/fast/text: Added.
        * platform/win/fast/text/international: Added.
        * platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
        * platform/win/fast/text/international/complex-character-based-fallback-expected.png: Added.
        * platform/win/fast/text/international/complex-character-based-fallback-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap@webkit.org [Tue, 11 Dec 2007 19:11:46 +0000 (19:11 +0000)]
    Reviewed by Darin.

        Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.

        JavaScript detects Tab as a character input on a textfield validation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele
sullivan@apple.com [Tue, 11 Dec 2007 19:06:31 +0000 (19:06 +0000)]
    Reviewed by Adele

        Tiger build fix -- don't call QTMovieView setDelegate: directly because it's not public

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
kmccullough@apple.com [Tue, 11 Dec 2007 18:46:06 +0000 (18:46 +0000)]
    Reviewed by Oliver.

        - <rdar://5599845> Drosera: Does not show loal files in the file list
        on the left side.

        * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
        * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
        so the open source community can build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap@webkit.org [Tue, 11 Dec 2007 17:30:50 +0000 (17:30 +0000)]
    Reviewed by Darin.

        <rdar://problem/5632997> REGRESSION: www.xerox.ru doesn't work

        Fix this on Windows, too!

        Test: http/tests/misc/empty-cookie.html

        * platform/network/win/CookieJarWin.cpp:
        Same fix as on Mac, translated into CF.

        * platform/win/CookieJarWin.cpp: Removed - the real one is in platform/network/win.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-11 Christian Dywan <christian@twotoasts.de>
alp@webkit.org [Tue, 11 Dec 2007 13:22:38 +0000 (13:22 +0000)]
2007-12-11  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Alp Toker.

        Implement additional mouse cursors for Gtk

        Added cursor bitmaps from Mozilla:

        * platform/gtk/CursorGtk.cpp:
        * platform/gtk/CursorGtk.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix character set used for dynamically loaded scripts.
oliver@apple.com [Tue, 11 Dec 2007 08:43:02 +0000 (08:43 +0000)]
Fix character set used for dynamically loaded scripts.

Reviewed by Weinig, Dan and Alexey.

Fix for:
    <rdar://problem/5333163> Safari can not display the mouse over pop menu on ChinaTimes News site correctly.
    <rdar://problem/5530048> [Safari]? :Leopard9A576: The typed CH characters displays as garbage in Sina website after reloading the webpage.
    <rdar://problem/5416588> All menus for chinese IBM site have wrong encoding

Use the same logic to determine the charset for a script loaded dynamically
as we do for a statically loaded script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
justin.garcia@apple.com [Tue, 11 Dec 2007 07:43:26 +0000 (07:43 +0000)]

        Reviewed by Oliver Hunt.

        <rdar://problem/5482023> GoogleDocs: After FormatBlock in an empty document, certain functions are disabled

        We were trying to insert a block of the requested type before the body element.

        * editing/FormatBlockCommand.cpp:
        Removed unnecessary ()s in the if condition.
        Removed "|| !upstreamStart.node()->isDescendantOf(root)" from the if condition, since
        a) upstreamStart will never be outside the root editable element, since in that case
        there would be no block inside the editable root to Format, and b) if upstreamStart.node()
        *is* the root, then refNode is the root, and we shouldn't insert before the root, we should insert
        at [root, 0].
        Added comments to explain the use of upstream() in the second if-clause.
        Added an early return for case where there is nothing selected, in that case, there is nothing
        to move.


        Reviewed by Oliver Hunt.

        <rdar://problem/5482023> GoogleDocs: After performing FormatBlock in an empty document, certain functions are disabled

        * editing/execCommand/5482023.html: Added.
        * platform/mac/editing/execCommand/5482023-expected.checksum: Added.
        * platform/mac/editing/execCommand/5482023-expected.png: Added.
        * platform/mac/editing/execCommand/5482023-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and partially fixed by Tim Hatcher.
adele@apple.com [Tue, 11 Dec 2007 07:24:17 +0000 (07:24 +0000)]
    Reviewed and partially fixed by Tim Hatcher.

        Remaining part of fix for <rdar://problem/5633400>
        Transformed <video> is not clipped correctly until a repaint is forced

        Replace the implementation of a QTKit method to avoid repaints from the NSView system associated with the QTMovie
        from clobbering the WebCore repaints.

        * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerRepaint): Added.
        * html/HTMLMediaElement.h:
        * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::repaint): Added.
        * platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRepaint): Added.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (method_setImplementation): Added for Tiger.

        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): Call detachQTMovieView, which now does more cleanup.
        (WebCore::MediaPlayerPrivate::cancelLoad): ditto.
        (WebCore::MediaPlayerPrivate::setVisible): ditto.
        (WebCore::MediaPlayerPrivate::detachQTMovieView): Clear the delegate as well as m_qtMovieView pointer.

        (WebCore::MediaPlayerPrivate::repaint): Added.  Triggers a repaint on the video renderer.
        (-[WebCoreMovieObserver repaint]): ditto.

        (WebCore::mainThreadSetNeedsDisplay): Added.
         Does a WebCore repaint instead of going through the view repaint system for QTMovieView.
        (WebCore::MediaPlayerPrivate::createQTMovieView): Replace the implementation of _mainThreadSetNeedsDisplay.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin@apple.com [Tue, 11 Dec 2007 06:08:24 +0000 (06:08 +0000)]

        Reviewed by Sam Weinig.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16379
          REGRESSION(r28525): Failures in http/tests/xmlhttprequest/response-encoding.html and
          and <rdar://problem/5640230> REGRESSION (306A4-ToT): Access violation in PCRE function

        Test: fast/js/regexp-find-first-asserted.html

        * pcre/pcre_compile.cpp:
        (compileBracket): Take out unnecessary initialization of out parameters.
        (branchFindFirstAssertedCharacter): Added. Broke out the half of the function that handles
        a branch.
        (bracketFindFirstAssertedCharacter): Renamed from find_firstassertedchar. Also removed the
        options parameter -- the caller can handle the options.
        (jsRegExpCompile): Changed call site to call the appropriate bracket or branch version of
        the find_firstassertedchar function. Also put the REQ_IGNORE_CASE code here instead of
        passing in the options.


        Reviewed by Sam Weinig.

        - test for http://bugs.webkit.org/show_bug.cgi?id=16379
          REGRESSION(r28525): Failures in http/tests/xmlhttprequest/response-encoding.html and
          and <rdar://problem/5640230> REGRESSION (306A4-ToT): Access violation in PCRE function

        * fast/js/regexp-find-first-asserted-expected.txt: Added.
        * fast/js/regexp-find-first-asserted.html: Added.
        * fast/js/resources/regexp-find-first-asserted.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren@apple.com [Tue, 11 Dec 2007 05:47:41 +0000 (05:47 +0000)]

        Reviewed by Sam Weinig.

        Split this:


        into this:

                ^                   ^                   ^
                |                   |                   |
        FunctionBodyNode        ProgramNode         EvalNode

        in preparation for specializing each class more while optimizing global
        variable access.

        Also removed some cruft from the FunctionBodyNode interface to simplify

        SunSpider says this patch is a .8% speedup, which seems reasonable,
        since it eliminates a few branches and adds KJS_FAST_CALL in a few

        Layout tests and JS tests pass. Also, this baby builds on Windows! (Qt
        mileage may vary...)


        Reviewed by Sam Weinig.

        Updated for rename in JavaScriptCore.

        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame scopeChain]):
        (-[WebCoreScriptCallFrame functionName]):
        (-[WebCoreScriptCallFrame evaluateWebScript:]):


        Reviewed by Sam Weinig.

        Updated for rename in JavaScriptCore.

        * WebScriptCallFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd bug reference.
ddkilzer@apple.com [Tue, 11 Dec 2007 04:55:15 +0000 (04:55 +0000)]
Add bug reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Use KJS::Window not the ambiguous Window
ddkilzer@apple.com [Tue, 11 Dec 2007 04:50:58 +0000 (04:50 +0000)]
    Use KJS::Window not the ambiguous Window

        Reviewed by ddkilzer.

        * bindings/js/kjs_dom.cpp (checkNodeSecurity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago RS by Mark Rowe.
ggaren@apple.com [Tue, 11 Dec 2007 03:09:25 +0000 (03:09 +0000)]
    RS by Mark Rowe.

        Mac build fix: added some exported symbols, now that Parser::parse is
        defined in the header.

        * JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
weinig@apple.com [Tue, 11 Dec 2007 02:37:58 +0000 (02:37 +0000)]
    Build fix.

        Template methods need to be in the header.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * kjs/Parser.cpp:
        * kjs/Parser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubberstamped by Sam Weinig
beidson@apple.com [Tue, 11 Dec 2007 02:26:20 +0000 (02:26 +0000)]
    Rubberstamped by Sam Weinig

        Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
        (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan
beidson@apple.com [Tue, 11 Dec 2007 01:22:00 +0000 (01:22 +0000)]
    Reviewed by John Sullivan

        Fix for <rdar://problem/5640080> - Database UI delegate calls need to specify WebFrame

        This is because a common UI case is to want to know the originating URL of a Database

        * WebCoreSupport/WebChromeClient.mm:

        * WebView/WebUIDelegatePrivate.h:

        * WebView/WebView.mm:
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
antti@apple.com [Tue, 11 Dec 2007 01:09:16 +0000 (01:09 +0000)]
    Reviewed by Adele.

        The load events could fire before the event listener was registered making these tests fail occasionally.

        No changes to test results.

        * media/video-source-media.html:
        * media/video-source-type.html:
        * media/video-source.html:
        * media/video-src-remove.html:
        * media/video-src-source.html:
        * media/video-src.html:
        * media/video-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam Weinig.
ggaren@apple.com [Tue, 11 Dec 2007 00:35:53 +0000 (00:35 +0000)]
    Reviewed by Sam Weinig.

        Merged different implementations of Parser::parse into a single,
        templatized implementation, in preparation for adding yet another
        implementation for "eval" code.

        JS and layout tests pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix non-mac builds.
weinig@apple.com [Tue, 11 Dec 2007 00:03:35 +0000 (00:03 +0000)]
    Fix non-mac builds.

        * page/WindowFeatures.cpp: #include <wtf/MathExtras.h> for isnan.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-09-05 Marvin Decker <marv.decker@gmail.com>
andrew@webkit.org [Mon, 10 Dec 2007 23:51:49 +0000 (23:51 +0000)]
2007-09-05  Marvin Decker  <marv.decker@gmail.com>

        Reviewed by Darin.

        Fix a divide by 0 in the progress tracker.

        * loader/ProgressTracker.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
weinig@apple.com [Mon, 10 Dec 2007 23:32:14 +0000 (23:32 +0000)]
    Reviewed by Darin.

        More cleanup of kjs_window.
        - Move WindowFeatures from bridge/ to page/
        - Move functions related to WindowFeatures (boolFeature,
          floatFeature, setWindowFeature, parseWindowFeatures) into the class.
        - Fix up whitespace.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_window.cpp:
        (KJS::LocationProtoFuncReplace::callAsFunction): Use better variable names.
        (KJS::LocationProtoFuncAssign::callAsFunction): Ditto.
        (KJS::LocationProtoFuncToString::callAsFunction): Remove extraneous calls to
        allowsAccessFrom, cleanup the function a little.
        * bridge/WindowFeatures.h: Removed.
        * page/WindowFeatures.cpp: Added.
        * page/WindowFeatures.h: Copied from WebCore/bridge/WindowFeatures.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
timothy@apple.com [Mon, 10 Dec 2007 23:06:23 +0000 (23:06 +0000)]

        Reviewed by Mark Rowe

        <rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x

        * Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR,
          so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.


        Reviewed by Mark Rowe.

        <rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x

        * Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR,
          so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.


        Reviewed by Mark Rowe.

        <rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x

        * Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR,
          so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.


        Reviewed by Mark Rowe.

        <rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x

        * Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR,
          so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCheck in correct results
slewis@apple.com [Mon, 10 Dec 2007 23:02:47 +0000 (23:02 +0000)]
Check in correct results

        * svg/custom/resource-client-removal-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-10 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 10 Dec 2007 20:39:26 +0000 (20:39 +0000)]
2007-12-10  Alp Toker  <alp@atoker.com>

        Reviewed by Niko.

        Cairo implementation of GraphicsContext::setUseAntialiasing().

        * platform/graphics/cairo/GraphicsContextCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
rwlbuis@webkit.org [Mon, 10 Dec 2007 20:14:46 +0000 (20:14 +0000)]
    Reviewed by Darin.

        SVG should disable antialiasing for shape-rendering="crispEdges"

        Turn off anti-aliasing of shapes when shape-rendering="crispEdges".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Niko.
rwlbuis@webkit.org [Mon, 10 Dec 2007 20:03:07 +0000 (20:03 +0000)]
    Reviewed by Niko.

        SVG crash in Node::setChanged() on Debug builds only (trashed parent)

        Fix the crash by properly unregistering as client from SVGResource
        when deleting a styled svg node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubberstamped by John
beidson@apple.com [Mon, 10 Dec 2007 19:38:06 +0000 (19:38 +0000)]
    Rubberstamped by John

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::canEstablishDatabase): If the UI Delegate returns *exactly* the estimated size
          for the new quota, we should allow the database to be created

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
kdecker@apple.com [Mon, 10 Dec 2007 18:47:39 +0000 (18:47 +0000)]
    Reviewed by Darin.

        Fixed: <rdar://problem/4290098> Right-mouse click on element doesn't call onmousedown handler

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView menuForEvent:]): Match behavior of other browsers by sending an onmousedown event for right clicks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug 9683: Implement select.options.remove() method
ddkilzer@apple.com [Mon, 10 Dec 2007 17:51:02 +0000 (17:51 +0000)]
Bug 9683: Implement select.options.remove() method


        Bug 9683: Implement select.options.remove() method

        Reviewed by Maciej.

        Implement select.options.remove() by calling select.remove()
        with the same arguments.  This is what MSIE 7 does, although its
        select.remove() method differs from WebKit's by throwing an
        exception when called with no arguments or with a negative
        integer argument.  Note that the DOM Level 1 documentation
        specifies that select.remove() does not throw an exception.

        Tests: fast/js/select-options-remove-gc.html

        * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
        (WebCore::JSHTMLOptionsCollection::remove): Added.
        * html/HTMLOptionsCollection.cpp:
        (WebCore::HTMLOptionsCollection::remove): Added.
        * html/HTMLOptionsCollection.h:
        * html/HTMLOptionsCollection.idl:


        Bug 9683: Implement select.options.remove() method

        Reviewed by Maciej.

        * fast/js/resources/select-options-remove.js: Added.
        * fast/js/select-options-remove-expected.txt: Added.
        * fast/js/select-options-remove-gc-expected.txt: Added.
        * fast/js/select-options-remove-gc.html: Added.
        * fast/js/select-options-remove.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix <rdar://5624866> CFStringRef UI_STRING should use a cache and follow...
aroben@apple.com [Mon, 10 Dec 2007 17:16:12 +0000 (17:16 +0000)]
     Fix <rdar://5624866> CFStringRef UI_STRING should use a cache and follow the CF "Get" model (current uses leak)

         Added a new class, LocalizedString, that wraps a CFStringRef and a
         WebCore::String. We store one LocalizedString for each key string.

         Reviewed by Steve.

         * WebLocalizableStrings.cpp: Changed our two HashMaps to map from
         WebCore::String to LocalizedString*.
         (LocalizedString::operator CFStringRef):
         (LocalizedString::operator LPCTSTR): Code moved here from
         (findCachedString): Changed to return a LocalizedString*.
         (cacheString): Changed to take a LocalizedString*.
         (localizedString): Changed to return a const LocalizedString&. We
         first try to find a cached LocalizedString. If there isn't one, we
         create a new one and cache it.
         (WebLocalizedLPCTSTRUTF8): Changed to call localizedString.
         (WebLocalizedLPCTSTR): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make WebLocalizableStrings work a little more like the Mac version
aroben@apple.com [Mon, 10 Dec 2007 17:15:33 +0000 (17:15 +0000)]
     Make WebLocalizableStrings work a little more like the Mac version

         Reviewed by Steve.

         * WebKit.vcproj/WebKit.def: Deprecated SetWebLocalizedStringMainBundle.
         * WebKit.vcproj/WebKit_debug.def: Ditto.
         * WebLocalizableStrings.cpp:
         (createWebKitBundle): Changed to only create the bundle once.
         (cfBundleForStringsBundle): Added. Code was factored out of
         copyLocalizedStringFromBundle. We now use the CFBundleGetMainBundle to
         get the main bundle and WebLocalizableStringsBundle's identifier to
         fetch the framework's bundle.
         (copyLocalizedStringFromBundle): Changed to call
         (cacheString): Cleaned up logic a bit with an early return.
         (SetWebLocalizedStringMainBundle): Moved down with the other
         deprecated functions and made into a no-op.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoTiger build fix.
mrowe@apple.com [Mon, 10 Dec 2007 13:38:36 +0000 (13:38 +0000)]
Tiger build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-10 Darin Adler <darin@apple.com>
mrowe@apple.com [Mon, 10 Dec 2007 13:15:00 +0000 (13:15 +0000)]
2007-12-10  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16375
          REGRESSION: Safari crashes on quit

        Probably a debug-only issue.

        * kjs/Parser.cpp:
        (KJS::parser): Create the parser and never destroy it by using a pointer instead
        of a global object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Removed fast/events/objc-keyboard-event-creation.html from skipped list,...
ap@webkit.org [Mon, 10 Dec 2007 08:55:48 +0000 (08:55 +0000)]
    Removed fast/events/objc-keyboard-event-creation.html from skipped list, as this test has
        been moved to platform/mac long ago.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam Weinig.
darin@apple.com [Mon, 10 Dec 2007 06:22:04 +0000 (06:22 +0000)]
    Reviewed by Sam Weinig.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16369
          REGRESSION (r28525): regular expression tests failing due to bad firstByte optimization

        * pcre/pcre_compile.cpp: Changed some names to use interCaps intead of under_scores.
        (branchIsAnchored): Broke is_anchored into two separate functions; this one works on a
        branch and the other on an anchor. The old function would only work on a bracket.
        Also removed unneeded parameters; the anchored check does not require the bracket
        map or the options any more because we have a reduced set of features.
        (bracketIsAnchored): Ditto.
        (branchNeedsLineStart): Broke canApplyFirstCharOptimization into two functions and gave
        both a better name. This is the function that was returning the wrong value. The failure
        was beacuse the old function would only work on a bracket.
        (bracketNeedsLineStart): Ditto.
        (jsRegExpCompile): Changed to call the appropriate branch or bracket flavor of the
        functions based on whether we compiled an outer bracket. Also removed inaccurate comments
        and unneeded parameters.

        - other small changes

        * pcre/pcre.h: Renumbered error codes, in a logical order. First, normal failure, then
        the recursion limit, then running out of memory, and finally an unexpected internal error.

        * pcre/pcre_exec.cpp: Fixed indentation.
        (jsRegExpExecute): Corrected an inaccurate comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin@apple.com [Mon, 10 Dec 2007 04:05:56 +0000 (04:05 +0000)]
    Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16370
          REGRESSION (r28540): source URL and line number no longer set for outer function/programs

        Test: fast/js/exception-linenums-in-html-1.html
        Test: fast/js/exception-linenums-in-html-2.html
        Test: fast/js/exception-linenums.html

        By the time the ProgramNode was constructed, the source URL was empty.

        * kjs/Parser.cpp:
        (KJS::Parser::parseProgram): Added code to set and clear m_sourceURL, which is now
        handled here instead of in the lexer; it needs to still be set when we create the
        program node. Call setLoc to set the first and last line number.
        (KJS::Parser::parseFunctionBody): Ditto, but for the body.
        (KJS::Parser::parse): Removed the sourceURL argument.

        * kjs/Parser.h: Added sourceURL(), m_sourceURL, and m_lastLine. Added a lastLine
        parameter to didFinishParsing, since the bison grammar knows the last line number
        and we otherwise do not know it. Removed the sourceURL parameter from parse, since
        that's now handled at a higher level.

        * kjs/grammar.y: Pass the last line number to didFinishParsing.

        * kjs/lexer.cpp:
        (KJS::Lexer::setCode): Removed the sourceURL argument and the code to set m_sourceURL.
        (KJS::Lexer::clear): Ditto.
        * kjs/lexer.h: More of the same.

        * kjs/nodes.cpp:
        (KJS::FunctionBodyNode::FunctionBodyNode): Get the source URL from the parser rather
        than from the lexer. Removed unneeded call to setLoc, since the line numbers already
        both default to -1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Mark Rowe.
weinig@apple.com [Mon, 10 Dec 2007 03:33:34 +0000 (03:33 +0000)]
    Rubber stamped by Mark Rowe.

        * WebCore.xcodeproj/project.pbxproj: Add missing DerivedSources files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoNeed to read the spec properly.
oliver@apple.com [Mon, 10 Dec 2007 01:12:34 +0000 (01:12 +0000)]
Need to read the spec properly.

Reviewed by Niko

Correction, 'z' and 'Z' are the only commands that cannot have an extended
list of arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoPrevent unlimited iteration in the case of invalid path data.
oliver@apple.com [Mon, 10 Dec 2007 00:44:18 +0000 (00:44 +0000)]
Prevent unlimited iteration in the case of invalid path data.

Reviewed by Niko.

The only path commands that can leave numbers trailing the command processing
are 'm' and 'M', in which trailing numbers are parsed as arguments to an
implicit lineto command.  In any case we should just terminate as an invalid

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-09 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Sun, 9 Dec 2007 21:52:55 +0000 (21:52 +0000)]
2007-12-09  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        [GTK] curl - slow dns causing hangs.

        Create a vector of jobs, to satisfy requests in the right order.
        Set a limit to the number of simultaneous connections.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::maxRunningJobs): added

        * platform/network/curl/ResourceHandleManager.h:
        (WebCore::ResourceHandleList): removed
        (WebCore::ResourceHandleManager::m_runningJobs): added
        (WebCore::ResourceHandleManager::m_resourceHandleListHead): removed
        (WebCore::ResourceHandleManager::m_resourceHandleList): added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
weinig@apple.com [Sun, 9 Dec 2007 07:56:34 +0000 (07:56 +0000)]
    Reviewed by Oliver.

        Cleanup kjs_window.h/cpp.

        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber-stamped by Adam Roben.
weinig@apple.com [Sun, 9 Dec 2007 07:48:24 +0000 (07:48 +0000)]
    Rubber-stamped by Adam Roben.

        * fast/dom/Window/window-resize-and-move-arguments.html: Make the window small enough
        that this test won't fail on systems with lower resolutions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
weinig@apple.com [Sun, 9 Dec 2007 00:47:41 +0000 (00:47 +0000)]

        Reviewed by Mitz.

        Move window scrolling, moving and resizing methods from KJS::Window
        to WebCore::DOMWindow so that there bindings can be autogenerated.

        Tests: fast/dom/Window/window-resize-and-move-arguments.html

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty): Remove extraneous allowsAccessFrom check.
        (KJS::WindowProtoFuncNotImplemented::callAsFunction): Remove extraneous allowsAccessFrom check.
        * bindings/js/kjs_window.h:
        * bindings/scripts/CodeGeneratorJS.pm: Add new extended attribute
        to ensure that the no less than the declared number of attributes
        is allowed.
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::adjustWindowRect): Moved from kjs_window.
        * page/DOMWindow.h:
        * page/DOMWindow.idl:


        Reviewed by Sam W.

        Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.

        Fixes <rdar://problem/5620249> Must disable SVG animation
        <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior

        These layout test changes are caused by some of the experimental
        features no longer being enabled by default.

        * fast/dom/Window/window-properties-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * platform/mac/svg/custom/empty-merge-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
        * platform/mac/svg/custom/filter-source-alpha-expected.txt:
        * platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/mac/svg/custom/invalid-css-expected.txt:
        * platform/mac/svg/custom/non-opaque-filters-expected.txt:
        * platform/mac/svg/custom/text-filter-expected.txt:
        * platform/mac/svg/custom/visibility-override-filter-expected.txt:
        * svg/batik/filters/filterRegions-expected.txt:
        * svg/batik/text/textEffect-expected.txt:
        * svg/batik/text/textEffect3-expected.txt:
        * svg/batik/text/textFeatures-expected.txt:
        * svg/batik/text/textProperties-expected.txt:
        * svg/custom/js-svg-constructors-expected.txt:
        * svg/dom/font-face-elements-expected.txt:
        * svg/webarchive/svg-feimage-subresources-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-08 Kevin Ollivier <kevino@theolliviers.com>
alp@webkit.org [Sun, 9 Dec 2007 00:32:55 +0000 (00:32 +0000)]
2007-12-08  Kevin Ollivier  <kevino@theolliviers.com>

        Reviewed by Alp Toker.

        [CURL] didReceiveResponse() only called for HTTP loads

        [GDK] file:// relative CSS include URLs handled incorrectly

        Make sure CURL sets the ResourceResponse URL and calls
        didReceiveResponse for local files too.

        * platform/network/curl/ResourceHandleManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoSplit the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
oliver@apple.com [Sun, 9 Dec 2007 00:27:57 +0000 (00:27 +0000)]
Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.

Reviewed by Sam W.

Fixes <rdar://problem/5620249> Must disable SVG animation
      <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior

In order to allow finer grained control over the set of SVG features
this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
distinct flags:

by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Sat, 8 Dec 2007 23:45:40 +0000 (23:45 +0000)]

        Reviewed by Adele Peterson.

        - fix two bugs in parsing of stylesheets in <style> elements created by
          the parser:
          1. each such stylesheet is parsed twice, once when the text node is
             added and again when the </style> tag is reached
          2. re-inserting such a <style> element into the document fails to
             re-parse and apply its stylesheet.

        Test for bug #2: fast/dom/HTMLStyleElement/insert-parser-generated.html

        * html/HTMLStyleElement.cpp:
        * svg/SVGStyleElement.cpp:


        Reviewed by Adele Peterson.

        - test that re-inserting a parser-generated <style> element applies its

        * fast/dom/HTMLStyleElement: Added.
        * fast/dom/HTMLStyleElement/insert-parser-generated.html: Added.
        * platform/mac/fast/dom/HTMLStyleElement: Added.
        * platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.checksum: Added.
        * platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.png: Added.
        * platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix ChangeLog
weinig@apple.com [Sat, 8 Dec 2007 21:02:32 +0000 (21:02 +0000)]
Fix ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
weinig@apple.com [Sat, 8 Dec 2007 18:03:43 +0000 (18:03 +0000)]

        Reviewed by Darin.

        - Rename isSafeScript to allowsAccess.

        * bindings/NP_jsobject.cpp:
        * kjs/JSGlobalObject.h:
        (KJS::JSGlobalObject::allowsAccessFrom): Reverse caller/argument of allowsAccessFrom to match
        the new call.


        Reviewed by Darin.

        - Removes the faulty isSafeScript implementation that was only
          used for plugins.
        - Renames isSafeScript to allowsAccessFrom.

        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/kjs_dom.cpp:
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject _isSafeScript]): Reverse caller/argument of allowsAccessFrom to match
        the new call.
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-08 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Sat, 8 Dec 2007 14:39:02 +0000 (14:39 +0000)]
2007-12-08  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        [GTK] Some webview parts must use the focused frame.

        Also update some old code.

        * WebView/webkitprivate.cpp:
        (getFrameFromView): removed

        * WebView/webkitprivate.h:
        (getFrameFromView): removed

        * WebView/webkitwebview.cpp:
        (webkit_web_view_key_press_event): use focused frame
        (webkit_web_view_key_release_event): use focused frame

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::handleKeypress): fix for page up and page down keys for editable contents

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
rwlbuis@webkit.org [Sat, 8 Dec 2007 12:27:03 +0000 (12:27 +0000)]
    Reviewed by Darin.

        SVGLengthList allows bad values

        Be more strict with svg lengths without a unit identifier.

        Test: svg/custom/invalid-lengthlist.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Mac Tiger build fix.
rwlbuis@webkit.org [Sat, 8 Dec 2007 12:11:34 +0000 (12:11 +0000)]
    Mac Tiger build fix.

        Use the wtf prefix when including MathExtras.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemove 'Reviewed by' from build fix ChangeLog entry
alp@webkit.org [Sat, 8 Dec 2007 11:35:51 +0000 (11:35 +0000)]
Remove 'Reviewed by' from build fix ChangeLog entry

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-08 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 8 Dec 2007 11:32:36 +0000 (11:32 +0000)]
2007-12-08  Alp Toker  <alp@atoker.com>

        Reviewed by Alp Toker.

        GTK+ build fix (for ENABLE_VIDEO builds):

        Include MathExtras.h to get isfinite().

        * rendering/RenderMedia.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
rwlbuis@webkit.org [Sat, 8 Dec 2007 08:53:33 +0000 (08:53 +0000)]
    Reviewed by Darin.

        svg_dynamic_cast should be removed

        Replace svg_dynamic_cast with a combination of
        isSVGElement and static_cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
antti@apple.com [Sat, 8 Dec 2007 06:49:14 +0000 (06:49 +0000)]

        Reviewed by Adele.

        Partial fix for <rdar://problem/5633400>
        Transformed <video>, <img>, <embed> are not clipped correctly until a repaint is forced

        Fix video painting when transform is applied.

        Test: media/video-transformed.html

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:


        Reviewed by Adele.

        Test video painting when transform is applied.

        * media/video-paint-test.js: Added.
        * media/video-transformed.html: Added.
        * platform/mac/media/video-transformed-expected.checksum: Added.
        * platform/mac/media/video-transformed-expected.png: Added.
        * platform/mac/media/video-transformed-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKit/win:
sfalken@apple.com [Sat, 8 Dec 2007 05:44:54 +0000 (05:44 +0000)]

        Fix version parsing.

        Rubber-stamped by Oliver.

        * WebKit.vcproj/auto-version.sh:


        Fix version parsing.

        Rubber-stamped by Oliver.

        * Drosera/win/Drosera.vcproj/auto-version.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build modifications for Drosera.
sfalken@apple.com [Sat, 8 Dec 2007 04:26:15 +0000 (04:26 +0000)]
    Build modifications for Drosera.

        Reviewed by Adam.

        * Drosera/DroseraWin.make: Added.
        * Drosera/win/Drosera.vcproj/Drosera.rc:
        * Drosera/win/Drosera.vcproj/Drosera.vcproj:
        * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
        * Drosera/win/Drosera.vcproj/VERSION: Added.
        * Drosera/win/Drosera.vcproj/auto-version.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Sat, 8 Dec 2007 01:48:50 +0000 (01:48 +0000)]

        Reviewed by Sam Weinig.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16348
          @font-face does not affect the default style

        Test: fast/css/font-face-default-font.html

        * dom/Document.cpp:
        (WebCore::Document::recalcStyle): Pass our font selector to
        Font::update() if we already have one.


        Reviewed by Sam Weinig.

        - test for http://bugs.webkit.org/show_bug.cgi?id=16348
          @font-face does not affect the default style

        * fast/css/font-face-default-font.html: Added.
        * platform/mac-leopard/fast/css: Added.
        * platform/mac-leopard/fast/css/font-face-default-font-expected.checksum: Added.
        * platform/mac-leopard/fast/css/font-face-default-font-expected.png: Added.
        * platform/mac/fast/css/font-face-default-font-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin Decker and Tim Hatcher.
darin@apple.com [Sat, 8 Dec 2007 01:37:05 +0000 (01:37 +0000)]
    Reviewed by Kevin Decker and Tim Hatcher.

        - speculative fix for <rdar://problem/5400159> CrashTracer: [USER] 726 crashes
          in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _frameOrBoundsChanged]): Only schedule the mouseover timer if we are in a window
        and not closed. That's because viewDidMoveToWindow and close are the entry points for cancelling.
        (-[WebHTMLView close]): Add code to cancel both timers. Needed for the case where the entire
        window goes away, and the view is never removed from the window.
        (-[WebHTMLView viewDidMoveToWindow]): Don't do work if the view is closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix build.
sfalken@apple.com [Sat, 8 Dec 2007 01:06:37 +0000 (01:06 +0000)]
    Fix build.

        * WebKit.vcproj/WebKit.vcproj:
        * WebScriptCallFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix build.
sfalken@apple.com [Sat, 8 Dec 2007 01:00:26 +0000 (01:00 +0000)]
    Fix build.

        * WebHistory.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam Weinig.
ggaren@apple.com [Sat, 8 Dec 2007 00:59:48 +0000 (00:59 +0000)]
    Reviewed by Sam Weinig.

        Refactored variable access optimization: Removed the assumption that
        the FunctionBodyNode holds the symbol table.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - try to fix build
darin@apple.com [Sat, 8 Dec 2007 00:56:14 +0000 (00:56 +0000)]
    - try to fix build

        * Api/qwebhistoryinterface.cpp:
        (WebCore::historyContains): There's a WebCore function here in WebKit! Needs to
        be updated, since WebCore changed, but this should not be here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix: added #include.
ggaren@apple.com [Sat, 8 Dec 2007 00:39:50 +0000 (00:39 +0000)]
    Build fix: added #include.

        * kjs/nodes.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix: added #include.
ggaren@apple.com [Sat, 8 Dec 2007 00:35:08 +0000 (00:35 +0000)]
    Build fix: added #include.

        * kjs/interpreter.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix: added #include.
ggaren@apple.com [Sat, 8 Dec 2007 00:30:42 +0000 (00:30 +0000)]
    Build fix: added #include.

        * kjs/grammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix: added #include.
ggaren@apple.com [Sat, 8 Dec 2007 00:24:51 +0000 (00:24 +0000)]
    Build fix: added #include.

        * kjs/function_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam Weinig.
ggaren@apple.com [Sat, 8 Dec 2007 00:23:31 +0000 (00:23 +0000)]
    Reviewed by Sam Weinig.

        Fixed crash seen running layout tests.

        Reverted a change I made earlier today. Added a comment to try to
        discourage myself from making this mistake a third time.

        * kjs/function.cpp:
        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix Windows build
darin@apple.com [Sat, 8 Dec 2007 00:22:27 +0000 (00:22 +0000)]
    - fix Windows build

        * bridge/win/GlobalHistoryWin.cpp:
        (WebCore::historyContains): Missed a rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders and Darin
beidson@apple.com [Sat, 8 Dec 2007 00:05:07 +0000 (00:05 +0000)]
    Reviewed by Anders and Darin

        When a statement bumps up against the quota and the UI Delegate grants more space, we need to
        actually set the new maximum size on the SQLiteDatabase (in addition to storing the new max quota
        in the DatabaseTracker, which was already done)

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::runStatements): If a statement is being retried, set the maximum size on
          the SQLiteDatabase to the new maximum size

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix Tiger build
darin@apple.com [Sat, 8 Dec 2007 00:02:56 +0000 (00:02 +0000)]
    - fix Tiger build

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Tiger didn't even have
        QTKIT_VERSION_MAX_ALLOWED, so add logic to work without that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin's rubberstamp
beidson@apple.com [Sat, 8 Dec 2007 00:02:46 +0000 (00:02 +0000)]
    Reviewed by Darin's rubberstamp

        When developing the Database feature and dealing with UI Delegate issues, it is important to have
        live examples on the web to help reproduce certain situations.

        This file is a dumping ground for such examples, and starts out with one function - the ability to add
        arbitrary amounts of data to a database to test the quota-related mechanisms of the UI

        * misc/DatabaseTester.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam Weinig.
ggaren@apple.com [Sat, 8 Dec 2007 00:01:13 +0000 (00:01 +0000)]
    Reviewed by Sam Weinig.

        Refactored parsing of global code: Removed the assumption that
        ProgramNode inherits from FunctionBodyNode from the parser.

        * kjs/Parser.cpp:
        * kjs/Parser.h:
        * kjs/function.cpp:
        * kjs/grammar.y:
        * kjs/nodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix 64-bit build, hopefully without breaking Tiger build
darin@apple.com [Fri, 7 Dec 2007 23:53:01 +0000 (23:53 +0000)]
    - fix 64-bit build, hopefully without breaking Tiger build

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        Don't use Movies.h constants that are nonexistent in 64-bit.
        Define the new QTMovie.h constants, though, when using an older QTKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Tried to fix build by suppressing warning.
ggaren@apple.com [Fri, 7 Dec 2007 23:22:32 +0000 (23:22 +0000)]
    Tried to fix build by suppressing warning.

        * WebScriptCallFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders
beidson@apple.com [Fri, 7 Dec 2007 23:00:01 +0000 (23:00 +0000)]
    Reviewed by Anders

        Fix <rdar://problem/5636115> - Prompted for quota increase to create database when it already existed

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::canEstablishDatabase): Check hasEntryForDatabase before doing any prompting
        (WebCore::DatabaseTracker::hasEntryForDatabase): Check and see if this database already exists
        * storage/DatabaseTracker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin@apple.com [Fri, 7 Dec 2007 22:58:09 +0000 (22:58 +0000)]

        Reviewed by Mitz.

        - http://bugs.webkit.org/show_bug.cgi?id=15981
          speed up visited-link code a bit

        * bridge/GlobalHistory.h: Change historyContains to take a character pointer plus length
        instead of requiring a DeprecatedString.

        * bridge/mac/GlobalHistoryMac.mm: (WebCore::historyContains): Updated for above change.
        Also removes pointless "fast Latin-1" case that was never used.
        * bridge/win/GlobalHistoryWin.cpp: (WebCore::historyContains): Ditto.
        * platform/gtk/TemporaryLinkStubs.cpp: (WebCore::historyContains): Ditto.
        * platform/wx/TemporaryLinkStubs.cpp: (WebCore::historyContains): Ditto.

        * css/CSSStyleSelector.cpp:
        (WebCore::findHash): Added. Helper for cleanpath.
        (WebCore::findSlashDotDotSlash): Ditto.
        (WebCore::findSlashSlash): Ditto.
        (WebCore::findSlashDotSlash): Ditto.
        (WebCore::cleanpath): Changed to use fast helper functions instead of slower general-purpose
        DeprecatedString find function.
        (WebCore::containsColonSlashSlash): Added. Helper for checkPseudoState.
        (WebCore::checkPseudoState): Got rid of reference count churn by using an AtomicString*
        instead of an AtomicString for the attribute value. Changed to use fast helper function
        instead of slower DeprecatedString::contains function, and also made the fast case not
        bother allocating a DeprecatedConstString.

        - unrelated tiny cleanup

        * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
        (WebCore::releaseCachedStops): Use static_cast instead of reinterpret_cast.
        (WebCore::cgGradientCallback): Ditto.


        Reviewed by Mitz.

        - http://bugs.webkit.org/show_bug.cgi?id=15981
          speed up visited-link code a bit

        * History/WebHistory.mm: Removed unused Latin-1 code path.
        (-[_WebCoreHistoryProvider containsURL:length:]): Updated for method name change.


        Reviewed by Mitz.

        - http://bugs.webkit.org/show_bug.cgi?id=15981
          speed up visited-link code a bit

        * WebHistory.cpp: Removed unused Latin-1 code path.
        (_WebCoreHistoryProvider::containsItem): Updated for function name change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix build on Tiger (Mark Rowe told me how).
darin@apple.com [Fri, 7 Dec 2007 22:45:23 +0000 (22:45 +0000)]
    Fix build on Tiger (Mark Rowe told me how).

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        Include <objc/objc-runtime.h>, which existed back on Tiger,
        rather than <objc/runtime.h>, which did not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix: added JSVariableObject.cpp to the .pri file.
ggaren@apple.com [Fri, 7 Dec 2007 22:45:17 +0000 (22:45 +0000)]
    Build fix: added JSVariableObject.cpp to the .pri file.

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix: added #include.
ggaren@apple.com [Fri, 7 Dec 2007 22:37:42 +0000 (22:37 +0000)]
    Build fix: added #include.

        * kjs/function.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix: rolling out last build fix to change #include path.
ggaren@apple.com [Fri, 7 Dec 2007 22:33:00 +0000 (22:33 +0000)]
    Build fix: rolling out last build fix to change #include path.


        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
sfalken@apple.com [Fri, 7 Dec 2007 22:30:26 +0000 (22:30 +0000)]

        Re-named our B&I flag from BUILDBOT to PRODUCTION.

        Reviewed by Sam Weinig.

        * JavaScriptCore.vcproj/JavaScriptCore.make:
        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:


        Re-named our B&I flag from BUILDBOT to PRODUCTION.

        Reviewed by Sam Weinig.

        * WebCore.vcproj/WebCore.make:


        Re-named our B&I flag from BUILDBOT to PRODUCTION.
        Fix our tiny versioning.
        Bump our product version.
        Use just the major version in the fallback VERSION files.
        Pick up the version numbers from the production builder.

        Reviewed by Sam Weinig.

        * Interfaces/WebKit.idl:
        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/PRODUCTVERSION:
        * WebKit.vcproj/VERSION:
        * WebKit.vcproj/WebKit.make:
        * WebKit.vcproj/WebKit.rc:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/auto-version.sh:
        * WebKitDLL.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix: corrected #include path.
ggaren@apple.com [Fri, 7 Dec 2007 22:26:11 +0000 (22:26 +0000)]
    Build fix: corrected #include path.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28530 268f45cc-cd09-0410-ab3c-d52691b4dbfc