loislo@chromium.org [Fri, 15 Oct 2010 09:04:22 +0000 (09:04 +0000)]
2010-10-15 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for Debug Leopard which is failng to compile after r69842.
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::ByteCompiler::emitDisjunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Fri, 15 Oct 2010 08:47:17 +0000 (08:47 +0000)]
2010-10-15 Alejandro G. Castro <alex@igalia.com>
Rebaseline some failing tests to the former results, apparently
they are flaky, skip if they continue failing.
* platform/gtk/mathml/presentation/fenced-expected.txt:
* platform/gtk/mathml/presentation/subsup-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Fri, 15 Oct 2010 08:33:53 +0000 (08:33 +0000)]
2010-10-15 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
compile fail with gtk >= 2.22
https://bugs.webkit.org/show_bug.cgi?id=47483
* platform/graphics/gtk/FontGtk.cpp: Removed the shrink operation,
it was added long time ago and currently it is not adding any real
area to the clip vertically, actually the gtk3 shrink version did
not work.
(WebCore::Font::drawComplexText):
* platform/gtk/gtk2drawing.c: Undef the deprecation flags, this
file is full of gtk2 stuff, and it does not seem interesting to
upgrade because we are already creating a new version of the file
for gtk3.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 15 Oct 2010 08:31:03 +0000 (08:31 +0000)]
2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspector settings/properties/states management
should be extracted into separate class.
We have a lot of flags/values in InspectorController.
Some flags are persisting into profile.
Others are part of inspector state for frontend.
All these flags should keep their values after navigation.
It'd be better to extract these flags/values into separate
class which will care about theirs lifetime.
https://bugs.webkit.org/show_bug.cgi?id=47275
WebCore:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectorStartsAttached):
(WebCore::InspectorController::setInspectorStartsAttached):
(WebCore::InspectorController::setInspectorAttachedHeight):
(WebCore::InspectorController::inspectorAttachedHeight):
(WebCore::InspectorController::searchingForNodeInPage):
(WebCore::InspectorController::resourceTrackingEnabled):
(WebCore::InspectorController::saveApplicationSettings):
(WebCore::InspectorController::getInspectorState):
(WebCore::InspectorController::restoreInspectorStateFromCookie):
(WebCore::InspectorController::getSettings):
(WebCore::InspectorController::storeLastActivePanel):
(WebCore::InspectorController::mouseDidMoveOverElement):
(WebCore::InspectorController::handleMousePress):
(WebCore::InspectorController::setSearchingForNode):
(WebCore::InspectorController::setMonitoringXHREnabled):
(WebCore::InspectorController::showPanel):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::restoreDebugger):
(WebCore::InspectorController::restoreProfiler):
(WebCore::InspectorController::getTrackedResource):
(WebCore::InspectorController::didLoadResourceFromMemoryCache):
(WebCore::InspectorController::identifierForInitialRequest):
(WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorController::scriptImported):
(WebCore::InspectorController::setResourceTrackingEnabled):
(WebCore::InspectorController::ensureSettingsLoaded):
(WebCore::InspectorController::startTimelineProfiler):
(WebCore::InspectorController::stopTimelineProfiler):
(WebCore::InspectorController::enableProfiler):
(WebCore::InspectorController::disableProfiler):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::loadBreakpoints):
(WebCore::InspectorController::saveBreakpoints):
* inspector/InspectorController.h:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
* inspector/InspectorState.cpp: Added.
(WebCore::InspectorState::InspectorState):
(WebCore::InspectorState::restoreFromInspectorCookie):
(WebCore::InspectorState::generateStateObjectForFrontend):
(WebCore::InspectorState::loadFromSettings):
(WebCore::InspectorState::updateCookie):
(WebCore::InspectorState::setValue):
(WebCore::InspectorState::getBoolean):
(WebCore::InspectorState::getString):
(WebCore::InspectorState::getLong):
(WebCore::InspectorState::registerBoolean):
(WebCore::InspectorState::registerString):
(WebCore::InspectorState::registerLong):
(WebCore::InspectorState::Property::create):
* inspector/InspectorState.h: Added.
(WebCore::InspectorState::setBoolean):
(WebCore::InspectorState::setString):
(WebCore::InspectorState::setLong):
WebKit/mac:
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]):
(-[WebInspectorWindowController attach]):
(-[WebInspectorWindowController detach]):
WebKit/win:
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::detachWindow):
(WebInspectorFrontendClient::showWindowWithoutNotifications):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 15 Oct 2010 08:20:54 +0000 (08:20 +0000)]
2010-10-15 Adam Barth <abarth@webkit.org>
Reviewed by Adam Barth.
test-webkitpy fails on Linux
https://bugs.webkit.org/show_bug.cgi?id=47713
The old code failed on Linux because the MacPort tries to read
something out of platform that doesn't make sense on Linux.
* Scripts/webkitpy/tool/mocktool.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Fri, 15 Oct 2010 07:59:17 +0000 (07:59 +0000)]
The parenthetical assertion checking isn't working in some cases with YARR
Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46893
Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-10-15
Reviewed by Gavin Barraclough.
Calculate the countToCheck value of a TypeParentheticalAssertion by
subtracting the number of characters which follows
a TypeParentheticalAssertion term with the number of characters which should
be matched by terms which are contained
in the TypeParentheticalAssertion term (minimumSize).
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::ByteCompiler::emitDisjunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Oct 2010 06:52:54 +0000 (06:52 +0000)]
2010-10-14 Jia Pu <jpu@apple.com>
Reviewed by Adele Peterson.
REGRESSION (r69548): Autocorrections are applied even after typing further characters in the word
https://bugs.webkit.org/show_bug.cgi?id=47689
<rdar://problem/
8552250>
The test requires using setTimeout(). So we put it in manual-tests.
* editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToPosition): Relpace release() with clear().
(WebCore::Editor::startCorrectionPanelTimer): Release previously set correction range before
start timer for next autocorrection check.
* manual-tests/autocorrection: Added.
* manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Oct 2010 06:33:46 +0000 (06:33 +0000)]
2010-10-14 Wei Jia <wjia@chromium.org>
Reviewed by Darin Fisher.
Retrieve info of lock keys from stashed currentInputEvent which
is stored by chromium when it passes input event to WebCore.
Retrieving only when stashed event is a keyboard event, which
means synthetic KeyboardEvent inherits lock key state from real
keyboard event.
https://bugs.webkit.org/show_bug.cgi?id=46518
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 15 Oct 2010 06:31:53 +0000 (06:31 +0000)]
2010-10-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] WTR is sloooow
https://bugs.webkit.org/show_bug.cgi?id=47695
* WebKitTestRunner/qt/TestControllerQt.cpp:
Change the timer interval of RunUntilConditionLoop from
50 milliseconds to 1 to avoid wasting time after the
test had been finished.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 15 Oct 2010 06:17:31 +0000 (06:17 +0000)]
2010-10-14 Martin Robinson <mrobinson@igalia.com>
Rebaseline some failing tests.
* platform/gtk/fast/events/keydown-1-expected.txt:
* platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt:
* platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
* platform/gtk/mathml/presentation/fenced-expected.txt:
* platform/gtk/mathml/presentation/subsup-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 15 Oct 2010 05:14:35 +0000 (05:14 +0000)]
Add guideline for constructors doing implicit type conversion to coding style.
https://bugs.webkit.org/show_bug.cgi?id=47646
Reviewed by Darin Adler.
* coding/coding-style.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 15 Oct 2010 04:09:48 +0000 (04:09 +0000)]
2010-10-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang and Darin Adler.
execCommand FormatBlock creates lots of blockquotes
https://bugs.webkit.org/show_bug.cgi?id=19795
The bug was caused by WebKit's not reusing the block node added by previous iteration
and its inserting block node at wrong places.
Fixed the bug by rewriting FormatBlockCommand::formatRange. New code resembles that of
IndentOutdentCommand::indentIntoBlockquote. The difference between two is that formatRange
avoids the existing block elements when replacing blocks and it also adds a placeholder
when removing the existing block caused paragraphs to collapse.
Also fixed a bug in moveParagraphWithClones where erroneous br is added to the start of
the block element to which the paragraph is moved if the block element is the start of a paragraph
and not the end of a paragraph.
Tests: editing/execCommand/format-block-multiple-paragraphs.html
editing/execCommand/format-block-table.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphWithClones): No longer adds erroneous br.
* editing/EditorCommand.cpp:
(WebCore::executeFormatBlock):
* editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::formatRange): Rewritten; see above.
(WebCore::FormatBlockCommand::isElementToApplyInFormatBlockCommand): Renamed from validBlockElement
and moved from htmlediting.cpp.
(WebCore::enclosingBlockToSplitTreeTo): Added.
* editing/FormatBlockCommand.h:
* editing/VisiblePosition.cpp:
(WebCore::enclosingBlockFlowElement): Changed the return type to Element*
* editing/VisiblePosition.h:
2010-10-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang and Darin Adler.
execCommand FormatBlock creates lots of blockquotes
https://bugs.webkit.org/show_bug.cgi?id=19795
Added tests to ensure WebKit does not add multiple block elements when applying block element to
multiple paragraphs. Also added a test to ensure formatBlock works with tables.
* fast/html/nav-element-expected.txt: Preserved new lines and removed redundant br.
* editing/execCommand/format-block-expected.txt: Preserved span and removed erroneous br.
* editing/execCommand/format-block-from-range-selection-expected.txt: Merged dl's and removed erroneous br.
* editing/execCommand/format-block-multiple-paragraphs-expected.txt: Added.
* editing/execCommand/format-block-multiple-paragraphs.html: Added.
* editing/execCommand/format-block-table-expected.txt: Added.
* editing/execCommand/format-block-table.html: Added.
* editing/execCommand/format-block-with-braces-expected.txt: Removed erroneous br.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Fri, 15 Oct 2010 03:08:27 +0000 (03:08 +0000)]
2010-10-14 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, asssigned a bug number to failing filesystem tests.
* platform/chromium/drt_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jam@chromium.org [Fri, 15 Oct 2010 02:54:40 +0000 (02:54 +0000)]
2010-10-14 John Abd-El-Malek <jam@chromium.org>
Reviewed by Tony Chang.
[chromium] null check the widget before sending it data as calling didReceiveData might delete it
https://bugs.webkit.org/show_bug.cgi?id=47708
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::committedLoad):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Oct 2010 02:45:03 +0000 (02:45 +0000)]
2010-10-14 Nathan Vander Wilt <nate@andyet.net>
Reviewed by Darin Adler.
Added parser for ECMAScript 5 standard date format, so Date.parse can handle RFC 3339 timestamps: https://bugs.webkit.org/show_bug.cgi?id=44632
* runtime/DateConversion.cpp:
(JSC::parseDate):
* wtf/DateMath.cpp:
(WTF::ymdhmsToSeconds):
(WTF::parseES5DateFromNullTerminatedCharacters):
* wtf/DateMath.h:
2010-10-14 Nathan Vander Wilt <nate@andyet.net>
Reviewed by Darin Adler.
Added tests for https://bugs.webkit.org/show_bug.cgi?id=44632
* fast/js/date-parse-test-expected.txt:
* fast/js/script-tests/date-parse-test.js:
(testDateParseExact):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 15 Oct 2010 01:54:24 +0000 (01:54 +0000)]
2010-10-14 Eric Seidel <eric@webkit.org>
Unreviewed, just fixing an exception seen on the commit-queue.
I should have unit tested this function before.
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Fri, 15 Oct 2010 01:50:40 +0000 (01:50 +0000)]
2010-10-14 Justin Schuh <jschuh@chromium.org>
Reviewed by James Robinson.
Crash in HTMLTextFormControlElement::selection()
https://bugs.webkit.org/show_bug.cgi?id=47522
Patch by Ryosuke Niwa <rniwa@webkit.org>
The bug was caused by our triggering layout inside RenderTextControl::selection.
Fixed it by changing the return type of RenderTextControl::selection to PassRefPtr<Range> from VisibleSelection.
Test: fast/forms/render-text-crash.html
* editing/Editor.cpp:
(WebCore::Editor::selectionForCommand): Calls HTMLTextFormControlElement::selection.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::selection): Calls RenderTextControl::selection.
* html/HTMLFormControlElement.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::selection): Changed the return type.
* rendering/RenderTextControl.h:
2010-10-14 Justin Schuh <jschuh@chromium.org>
Reviewed by James Robinson.
Crash in HTMLTextFormControlElement::selection()
https://bugs.webkit.org/show_bug.cgi?id=47522
Patch by Ryosuke Niwa <rniwa@webkit.org>
Added a test to ensure WebKit does not crash when moving selection between input elements.
* fast/forms/render-text-crash-expected.txt: Added.
* fast/forms/render-text-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 15 Oct 2010 00:51:07 +0000 (00:51 +0000)]
2010-10-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should not fail patches due to flaky tests
https://bugs.webkit.org/show_bug.cgi?id=47647
This patch makes it so that the *same* flaky test has to fail
twice in a row to have a false negative from a flaky test.
If different flaky tests fail (or if a test fails and then passes
in a second run) then we will warn in the bug that we encountered
a flaky test.
This patch grew to include moving port off of steps onto tool
(which Adam wrote and then I integrated), as well as removing the
use of tool from CommitQueueTask.
* Scripts/webkitpy/common/config/ports.py:
- Added a layout_test_results_path method. This covers old-run-webkit-tests
but doesn't cover NRWT. This is probably not the long term solution, but
putting this knowledge on port makes more sense than in LayoutTestResults.
* Scripts/webkitpy/common/net/buildbot.py:
- LayoutTestResults shouldn't know how to fetch from the network, make
the Build code do that instead.
* Scripts/webkitpy/common/net/buildbot_unittest.py:
- Code style fix.
* Scripts/webkitpy/common/net/layouttestresults.py:
- Remove code for reading from the network.
* Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- Test the new entrypoint.
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Make the delegate interface explicit.
- Remove the _tool member, since using the delegate for
everything is cleaner.
- Teach the testing logic how to deal with flaky tests.
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Update to match the CommitQueueTask changes.
* Scripts/webkitpy/tool/commands/queues.py:
- Use the new CommitQueueTaskDelegate interface.
* Scripts/webkitpy/tool/commands/queues_unittest.py:
- Fix the SecondThoughtsCommitQueue test which was broken.
- Add a new test to make sure the flaky test reporting works.
* Scripts/webkitpy/tool/main.py:
- Store the port on the tool object.
* Scripts/webkitpy/tool/mocktool.py:
- Add a port() accessor to MockTool
* Scripts/webkitpy/tool/steps/abstractstep.py:
- Move port() off of Step and onto Tool.
* Scripts/webkitpy/tool/steps/build.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/runtests.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
- Two tests with the same name! only the latter was being run.
* Scripts/webkitpy/tool/steps/update.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 15 Oct 2010 00:47:23 +0000 (00:47 +0000)]
2010-10-14 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
SelectElement should check if its renderer exists after calling Element::focus()
https://bugs.webkit.org/show_bug.cgi?id=47696
Tests that clicking on a listbox select with an element has a blur listener that causes
the listbox to become display:none does not crash.
* fast/forms/select-listbox-focus-displaynone.html: Added.
2010-10-14 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
SelectElement should check if its renderer exists after calling Element::focus()
https://bugs.webkit.org/show_bug.cgi?id=47696
Adds null checks for element->renderer() after calling element->focus(), since focus()
can dispatch an event and run arbitrary javascript that may cause the select element
to lose its renderer.
Test: fast/forms/select-listbox-focus-displaynone.html
* dom/SelectElement.cpp:
(WebCore::SelectElement::menuListDefaultEventHandler):
(WebCore::SelectElement::listBoxDefaultEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 15 Oct 2010 00:35:45 +0000 (00:35 +0000)]
2010-10-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
Plumb accelerated compositing prefs through WebKit2
https://bugs.webkit.org/show_bug.cgi?id=46860
<rdar://problem/
8495312>
Wire up the prefs to enable accelerated compositing, and
show debug borders and repaint counters.
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferencesPrivate.cpp:
(WKPreferencesSetAcceleratedCompositingEnabled):
(WKPreferencesGetAcceleratedCompositingEnabled):
(WKPreferencesSetCompositingBordersVisible):
(WKPreferencesGetCompositingBordersVisible):
(WKPreferencesSetCompositingRepaintCountersVisible):
(WKPreferencesGetCompositingRepaintCountersVisible):
* UIProcess/API/C/WKPreferencesPrivate.h:
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setAcceleratedCompositingEnabled):
(WebKit::WebPreferences::acceleratedCompositingEnabled):
(WebKit::WebPreferences::setCompositingBordersVisible):
(WebKit::WebPreferences::compositingBordersVisible):
(WebKit::WebPreferences::setCompositingRepaintCountersVisible):
(WebKit::WebPreferences::compositingRepaintCountersVisible):
* UIProcess/WebPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::preferencesDidChange):
(WebKit::WebPage::updatePreferences):
* WebProcess/WebPage/WebPage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Oct 2010 00:27:26 +0000 (00:27 +0000)]
2010-09-27 Dawit Alemayehu <adawit@kde.org>
Reviewed by Andreas Kling.
[Qt] Added functions for obtaining and checking the supported content types.
http://webkit.org/b/37880
* Api/qwebpage.cpp:
(extractContentTypeFromHash):
(extractContentTypeFromPluginVector):
(QWebPage::supportedContentTypes):
(QWebPage::supportsContentType):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::supportedContentType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Fri, 15 Oct 2010 00:24:01 +0000 (00:24 +0000)]
2010-10-14 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Document behaviour of href when document base URI is changed after href atribute has been set
https://bugs.webkit.org/show_bug.cgi?id=47665
* fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-prevents-rebase.js: Added.
* fast/dom/HTMLAnchorElement/set-href-attribute-prevents-rebase-expected.txt: Added.
* fast/dom/HTMLAnchorElement/set-href-attribute-prevents-rebase.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 14 Oct 2010 23:35:36 +0000 (23:35 +0000)]
This patch lays the groundwork for
https://bugs.webkit.org/show_bug.cgi?id=47514 CSS transforms should
affect scrolling
by adding topmostPosition().
Reviewed by Dave Hyatt.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::topmostPosition):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::topmostPosition):
* rendering/RenderBox.h:
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::topmostPosition):
* rendering/RenderMedia.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::topmostPosition):
* rendering/RenderTableSection.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 23:24:46 +0000 (23:24 +0000)]
2010-10-14 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] fix compilation warnings in imported libsoup code
https://bugs.webkit.org/show_bug.cgi?id=47674
Fixed some warnings caused by comparisons between signed and
unsigned integer expressions
* platform/network/soup/cache/soup-directory-input-stream.c:
(webkit_soup_directory_input_stream_read):
* platform/network/soup/cache/soup-request-data.c:
(webkit_soup_request_data_send):
* platform/network/soup/cache/soup-request-file.c:
(webkit_soup_request_file_ensure_file):
* platform/network/soup/cache/webkit/soup-cache.c:
(webkit_soup_cache_entry_is_fresh_enough):
(webkit_soup_cache_has_response):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 14 Oct 2010 23:22:53 +0000 (23:22 +0000)]
2010-10-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests will now handle missing Ruby installs (or
missing PrettyPatch scripts) more cleanly - previously this
would be detected when we actually tried to create the diff, and
the error message was obscure. Now we'll log a warning up front
and otherwise be silent.
This change also refactors some global variables to be class or
instance variables to be slightly more testable and more
modular. There are no cases where we create lots of port objects
and can't afford to test for configurations repeatedly, so
there's no performance concern here.
https://bugs.webkit.org/show_bug.cgi?id=47466
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 14 Oct 2010 23:20:03 +0000 (23:20 +0000)]
2010-10-14 Andreas Kling <kling@webkit.org>
Unreviewed buildfix, RetainPtr is a mac thing..
* platform/network/soup/ProxyServerSoup.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 14 Oct 2010 23:18:09 +0000 (23:18 +0000)]
2010-10-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Form controls do not respect GTK+ font size
https://bugs.webkit.org/show_bug.cgi?id=47134
Rebaseline tests which depend on form control font size.
* platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
* platform/gtk/editing/selection/drag-select-1-expected.txt:
* platform/gtk/editing/selection/drag-text-delay-expected.txt:
* platform/gtk/editing/selection/select-box-expected.txt:
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/gtk/fast/events/keydown-1-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/button-style-color-expected.txt:
* platform/gtk/fast/forms/input-button-sizes-expected.txt:
* platform/gtk/fast/forms/input-text-drag-down-expected.txt:
* platform/gtk/fast/forms/placeholder-stripped-expected.txt:
* platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
* platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/gtk/transforms/2d/zoom-menulist-expected.txt:
2010-10-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Form controls do not respect GTK+ font size
https://bugs.webkit.org/show_bug.cgi?id=47134
Have form controls use the font specified in GtkSettings. This font is
the default control font in GTK+ applications and Firefox. We need to
pass the string through Pango to get a valid font name and size.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::getScreenDPI): A helper function which returns
the DPI of the default screen or 96 as a fallback.
(WebCore::RenderThemeGtk::systemFont): Calculate the system font
by looking at the GtkSettings value and pushing it through Pango
to get the font family and font size.
2010-10-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Form controls do not respect GTK+ font size
https://bugs.webkit.org/show_bug.cgi?id=47134
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGtkFontSettings): Initialize the font control size when running
DumpRenderTree to a standard value.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 14 Oct 2010 23:12:21 +0000 (23:12 +0000)]
2010-10-14 Andreas Kling <kling@webkit.org>
Soup buildfix for r69808: add ProxyServer stub.
* GNUmakefile.am:
* platform/network/soup/ProxyServerSoup.cpp: Added.
(WebCore::proxyServersForURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 14 Oct 2010 23:04:26 +0000 (23:04 +0000)]
2010-10-14 Andreas Kling <kling@webkit.org>
Fix GTK+ build after r69808.
* GNUmakefile.am:
* platform/network/curl/ProxyServerCurl.cpp:
(WebCore::proxyServersForURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 14 Oct 2010 23:02:39 +0000 (23:02 +0000)]
2010-10-14 Simon Fraser <simon.fraser@apple.com>
Another build fix. Export FrameLoader::networkingContext()
* WebCore.exp.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 14 Oct 2010 22:56:16 +0000 (22:56 +0000)]
2010-10-14 Simon Fraser <simon.fraser@apple.com>
Fix the build after r69808.
* WebCore.xcodeproj/project.pbxproj:
* platform/network/cf/ProxyServerCFNet.cpp:
(WebCore::proxyServersForURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 14 Oct 2010 22:46:47 +0000 (22:46 +0000)]
Windows build fix following r69806.
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::markupToCFHTML):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 14 Oct 2010 22:32:49 +0000 (22:32 +0000)]
2010-10-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633
* WebKit.gyp: Add a mac specific target for compiling TestNetscapePlugIn
2010-10-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633
* DumpRenderTree/DumpRenderTree.gypi: files to compile
* DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
(NP_GetEntryPoints):
(NPP_New):
(NPP_Destroy):
(NPP_HandleEvent):
(NPP_GetValue):
* DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
* DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
* DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 22:16:34 +0000 (22:16 +0000)]
2010-10-14 Dawit Alemayehu <adawit@kde.org>
Reviewed by Andreas Kling
Implemented NPN_GetValueForURL and NPN_SetValueForURL and NPN_GetAuthenticationInfo.
https://bugs.webkit.org/show_bug.cgi?id=34539
These missing NPN functions cause Java applets to crash in ports such
as QtWebkit that rely on webkit for Java applet support.
* plugins/PluginDebug.cpp:
(WebCore::prettyNameForNPNURLVariable):
* plugins/PluginDebug.h:
* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::initializeBrowserFuncs):
* plugins/PluginView.cpp:
(WebCore::PluginView::getValueForURL):
(WebCore::PluginView::setValueForURL):
(WebCore::PluginView::getAuthenticationInfo):
* plugins/PluginView.h:
* plugins/npapi.cpp:
(NPN_GetValueForURL):
(NPN_SetValueForURL):
(NPN_GetAuthenticationInfo):
* platform/network/ProxyServer.h:
* platform/network/cf/ProxyServerCFNet.cpp:
(WebCore::proxyServersForURL):
* platform/network/qt/ProxyServerQt.cpp:
(WebCore::proxyServersForURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 14 Oct 2010 21:56:25 +0000 (21:56 +0000)]
Windows build fix following r69806.
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::markupToCFHTML):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Thu, 14 Oct 2010 21:45:01 +0000 (21:45 +0000)]
2010-10-14 Victor Wang <victorw@chromium.org>
Reviewed by Nate Chapin.
[Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff.
https://bugs.webkit.org/show_bug.cgi?id=47686
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 14 Oct 2010 21:18:03 +0000 (21:18 +0000)]
2010-10-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
test-webkitpy spews Delegate terminated queue messages
https://bugs.webkit.org/show_bug.cgi?id=47678
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Thu, 14 Oct 2010 21:11:52 +0000 (21:11 +0000)]
2010-10-14 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Cache link status at linkProgram and use it in useProgram instead of querying GPU
https://bugs.webkit.org/show_bug.cgi?id=47685
* html/canvas/WebGLProgram.cpp: Always cache link status at linkStatus and use it upon query.
(WebCore::WebGLProgram::WebGLProgram):
* html/canvas/WebGLProgram.h: Ditto.
(WebCore::WebGLProgram::getLinkStatus):
(WebCore::WebGLProgram::setLinkStatus):
* html/canvas/WebGLRenderingContext.cpp: Ditto.
(WebCore::WebGLRenderingContext::getProgramParameter):
(WebCore::WebGLRenderingContext::linkProgram):
(WebCore::WebGLRenderingContext::useProgram):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 21:05:38 +0000 (21:05 +0000)]
2010-10-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69795.
http://trac.webkit.org/changeset/69795
https://bugs.webkit.org/show_bug.cgi?id=47687
'See discussion at webkit.org/b/47609' (Requested by mwenge on
#webkit).
* platform/qt/Skipped:
2010-10-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69795.
http://trac.webkit.org/changeset/69795
https://bugs.webkit.org/show_bug.cgi?id=47687
'See discussion at webkit.org/b/47609' (Requested by mwenge on
#webkit).
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::canHandleRequest):
(WebCore::FrameLoaderClientQt::dispatchUnableToImplementPolicy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 14 Oct 2010 21:03:49 +0000 (21:03 +0000)]
Reviewed by Sam Weinig.
WebKit2: Store the certificate chain in PlatformCertificateInfo.
https://bugs.webkit.org/show_bug.cgi?id=47603
* Shared/API/c/win/WKCertificateInfoWin.cpp:
(WKCertificateInfoGetCertificateChainLength):
(WKCertificateInfoGetCertificateContextAtIndex):
* Shared/API/c/win/WKCertificateInfoWin.h:
* Shared/win/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Get the chain context from the response and duplicate the certificate contexts
in the chain to store in m_certificateChain.
(WebKit::PlatformCertificateInfo::~PlatformCertificateInfo): Free all the certificate contexts in the chain.
(WebKit::PlatformCertificateInfo::operator=): Duplicate the certificate contexts from the other PlatformCertificateInfo's certificate chain
to store in m_certificateChain.
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::PlatformCertificateInfo::clearCertificateChain): Free all the certificate contexts in the chain and clear the vector.
* Shared/win/PlatformCertificateInfo.h:
(WebKit::PlatformCertificateInfo::certificateChain):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Thu, 14 Oct 2010 20:48:18 +0000 (20:48 +0000)]
2010-10-14 Justin Schuh <jschuh@chromium.org>
Reviewed by James Robinson.
Style fix for r69735
https://bugs.webkit.org/show_bug.cgi?id=47684
No logic change. Existing tests apply.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 14 Oct 2010 19:52:41 +0000 (19:52 +0000)]
2010-10-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: encapsulate ScriptState into ConsoleMessage instead of passing it as additional parameter
https://bugs.webkit.org/show_bug.cgi?id=47675
No new tests. This refactoring is covered by existing inspector tests.
* bindings/js/JSConsoleCustom.cpp:
* bindings/js/ScriptCallFrame.cpp:
* bindings/js/ScriptCallFrame.h:
(WebCore::ScriptCallFrame::functionName):
(WebCore::ScriptCallFrame::sourceURL):
(WebCore::ScriptCallFrame::lineNumber):
(WebCore::ScriptCallFrame::argumentCount):
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::isEqual):
* inspector/ConsoleMessage.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::addMessageToConsole):
(WebCore::InspectorController::addConsoleMessage):
(WebCore::InspectorController::startGroup):
(WebCore::InspectorController::endGroup):
* inspector/InspectorController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 14 Oct 2010 19:48:45 +0000 (19:48 +0000)]
2010-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Gavin Barraclough.
Replace lots of String::format() usages by StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=47664
Add StringTypeAdapter<char> to accept single characters for makeString().
* wtf/text/StringConcatenate.h:
(WTF::makeString):
2010-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Gavin Barraclough.
Replace lots of String::format() usages by StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=47664
* ForwardingHeaders/wtf/text/StringConcatenate.h: Added.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::reportUnsafeAccessTo):
* dom/ExceptionBase.cpp:
(WebCore::ExceptionBase::ExceptionBase):
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::handleError):
* history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
* html/FTPDirectoryDocument.cpp:
(WebCore::processFileDateString):
* inspector/CodeGeneratorInspector.pm:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didReceiveResponse):
(WebCore::InspectorController::count):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::createBreakpointId):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::formatBreakpointId):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
(WebCore::InspectorProfilerAgent::getCurrentUserInitiatedProfileName):
(WebCore::InspectorProfilerAgent::takeHeapSnapshot):
* loader/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkIfDisplayInsecureContent):
(WebCore::FrameLoader::checkIfRunInsecureContent):
(WebCore::FrameLoader::shouldAllowNavigation):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createFromSelection):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessageTimerFired):
* page/PrintContext.cpp:
(WebCore::PrintContext::pageProperty):
(WebCore::PrintContext::pageSizeAndMarginsInPixels):
* page/XSSAuditor.cpp:
(WebCore::XSSAuditor::canLoadObject):
* platform/efl/PlatformKeyboardEventEfl.cpp:
(WebCore::createKeyMap):
(WebCore::createWindowsKeyMap):
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::animationNameForTransition):
* platform/graphics/brew/ImageBrew.cpp:
(WebCore::Image::loadPlatformResource):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/efl/ImageEfl.cpp:
(WebCore::loadResourceSharedBuffer):
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/haiku/ImageBufferHaiku.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/mac/GraphicsLayerCA.mm:
(WebCore::animationIdentifier):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/win/WebLayer.cpp:
(WebCore::WebLayer::drawInContext):
* platform/network/CredentialStorage.cpp:
(WebCore::originStringFromURL):
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::setSynchronous):
* platform/text/wince/TextCodecWinCE.cpp:
(WebCore::LanguageManager::LanguageManager):
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::markupToCFHTML):
* platform/win/Language.cpp:
(WebCore::defaultLanguage):
* plugins/PluginStream.cpp:
(WebCore::PluginStream::startStream):
* svg/SVGUseElement.cpp:
(WebCore::dumpInstanceTree):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::appendToBuffer):
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readServerHandshake):
2010-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Gavin Barraclough.
Replace lots of String::format() usages by StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=47664
Rebaseline two xssAuditor tests, that have been changed, after switching from String::format() -> makeString().
* http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 14 Oct 2010 19:47:32 +0000 (19:47 +0000)]
Rubber-stamped by Adam Roben.
Fix Windows build.
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:
* win/lib/WebKitSystemInterface_debug.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 19:40:54 +0000 (19:40 +0000)]
2010-10-14 Joone Hur <joone@kldp.org>
Reviewed by Andreas Kling.
[GTK] google.co.kr was missed when checking Google domains
https://bugs.webkit.org/show_bug.cgi?id=47652
WebKitGtk+ maintains a list of Google domains for working well with Google sites.
Add google.co.kr also to the list to be checked with other Google domains.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::initializeDomainsList): Added google.co.kr.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 14 Oct 2010 19:38:24 +0000 (19:38 +0000)]
2010-10-14 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Fix http/tests/misc/redirect-to-external-url.html
Support the test in FrameLoaderClientQt and unskip.
https://bugs.webkit.org/show_bug.cgi?id=47609
* platform/qt/Skipped:
2010-10-14 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Fix http/tests/misc/redirect-to-external-url.html
Support the test in FrameLoaderClientQt and unskip.
https://bugs.webkit.org/show_bug.cgi?id=47609
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::canHandleRequest):
(WebCore::FrameLoaderClientQt::dispatchUnableToImplementPolicy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 19:29:25 +0000 (19:29 +0000)]
2010-10-14 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Small cleanup in PluginViewGtk
https://bugs.webkit.org/show_bug.cgi?id=47588
Remove some dead code and use PlatformRefPtr for cairo surfaces.
No new tests, only refactoring.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 19:23:10 +0000 (19:23 +0000)]
2010-10-14 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Eric Seidel.
[EFL] Use data_set after data_get to keep refcount correct.
https://bugs.webkit.org/show_bug.cgi?id=47110
The call to evas_object_image_data_set was missed in this function,
which caused the refcount of the data being always increased on every
scroll.
* ewk/ewk_view_single.c:
(_ewk_view_single_smart_scrolls_process):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 19:22:38 +0000 (19:22 +0000)]
2010-10-14 Dawit Alemayehu <adawit@kde.org>
Reviewed by Andreas Kling.
Fix compile error when bulding webkit's Qt port using the "--v8" option.
https://bugs.webkit.org/show_bug.cgi?id=47455
* platform/qt/PlatformBridge.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 14 Oct 2010 19:22:27 +0000 (19:22 +0000)]
Make sure WebKit2 only loads each plugin once
Fixes <http://webkit.org/b/47677> <rdar://problem/
8552178> WebKit2 can
load the same plugin multiple times
Reviewed by Sam Weinig.
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::addFromVector): Helper function that adds all the elements
from a Vector to a HashSet.
(WebKit::PluginInfoStore::loadPluginsIfNecessary): Put all the plugin
paths into a HashSet, then load the plugins specified in the HashSet.
On Windows, the HashSet is case-insensitive, just like the file
system.
* UIProcess/Plugins/PluginInfoStore.h: Removed loadPluginsInDirectory,
which is no longer used.
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::addPluginPathsFromRegistry):
(WebKit::PluginInfoStore::individualPluginPaths):
Changed to store the paths in a Vector instead of a HashSet now that
loadPluginsIfNecessary will handle duplicates for us.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 14 Oct 2010 19:22:08 +0000 (19:22 +0000)]
Load plugins that are specified in the MozillaPlugins registry key
Fixes <http://webkit.org/b/44271> <rdar://problem/
8329750> WebKit2
should load plugins specified in the MozillaPlugins registry key (like
old WebKit does)
I couldn't think of a good way to test this.
Reviewed by Steve Falkenburg.
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPluginsIfNecessary): Also load plugins
specified by individualPluginPaths.
* UIProcess/Plugins/PluginInfoStore.h: Added individualPluginPaths and
some comments.
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::individualPluginPaths):
* UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:
(WebKit::PluginInfoStore::individualPluginPaths):
Stubbed out.
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::addPluginPathsFromRegistry):
(WebKit::PluginInfoStore::individualPluginPaths):
Ported this code from WebCore's PluginDatabaseWin.cpp. I slightly
cleaned it up and changed it to use a case-insensitive hash, since
paths on Windows are case-insensitive.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 14 Oct 2010 19:21:32 +0000 (19:21 +0000)]
Call ::DefWindowProcW for unhandled key events
::DefWindowProcW does important things for at least some key events
(e.g., it generates a WM_SYSCOMMAND message when the Alt key is
released), so we need to make sure to call it when we don't handle key
events.
Fixes <http://webkit.org/b/47671> <rdar://problem/
8435594> Pressing
the Alt key when MiniBrowser's WKView is focused doesn't send focus to
the menu bar
Reviewed by Steve Falkenburg.
WebKit2:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didNotHandleKeyEvent):
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::didNotHandleKeyEvent):
* UIProcess/API/qt/qwkpage_p.h:
Stubbed out didNotHandleKeyEvent.
* UIProcess/PageClient.h: Added didNotHandleKeyEvent.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Tell the PageClient about the
unhandled event.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::onKeyEvent): Added a comment.
(WebKit::WebView::didNotHandleKeyEvent): Pass the event to
::DefWindowProcW.
* UIProcess/win/WebView.h: Added didNotHandleKeyEvent.
WebKitTools:
Test that pressing the Alt key generates a WM_SYSCOMMAND message
* TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added
TestWebKitAPI/win to the include path so that WindowMessageObserver
can be found.
* TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and
Windows-specific members.
(TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver):
Added this simple setter.
* TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added.
(TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver):
Initialize our lone data member.
(TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand):
Simple getter.
(TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record
when a WM_SYSCOMMAND message is received.
(TestWebKitAPI::didNotHandleKeyEventCallback): Record when a
WM_SYSKEYUP message is not handled.
(TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate
pressing the Alt key and check that a WM_SYSCOMMAND message got sent
to the WKView's parent window.
* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a
member function so it could access PlatformWebView::wndProc. Use
PlatformWebView::wndProc as the WNDPROC.
(TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new
data member and pass the this pointer to CreateWindowEx so we can
store it on the HWND.
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some
constants from here to the top of the file.
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends
the same messages that Notepad receives when you press the Alt key.
(TestWebKitAPI::PlatformWebView::wndProc): Added.
- When WM_CREATE is received, we set the PlatformWebView instance
pointer as a property on the HWND so we can access it later.
- For other messages, we try to get the PlatformWebView instance
pointer from the HWND property.
- When WM_NCDESTROY is received (which is the last message we will
receive), we remove the PlatformWebView instance property.
- Pass messages to the parent window's message observer, if there is
one.
- Pass all messages through to ::DefWindowProcW.
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver
and AltKeyGeneratesWMSysCommand.
* TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be
used to observe messages sent to one or more windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 14 Oct 2010 19:19:17 +0000 (19:19 +0000)]
need way to measure size of JITed ARM code
https://bugs.webkit.org/show_bug.cgi?id=47121
Patch by David Goodwin <david_goodwin@apple.com> on 2010-10-14
Reviewed by Darin Adler.
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::dumpLinkStats):
(JSC::LinkBuffer::dumpCode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 14 Oct 2010 18:52:52 +0000 (18:52 +0000)]
2010-10-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Holger Freyther.
[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
https://bugs.webkit.org/show_bug.cgi?id=47033
Added a platform-specific test which verifies that if XSettings
specifies subpixel aliasing, it is the default rendering style.
* platform/gtk/fonts/xsettings_antialias_settings-expected.checksum: Added.
* platform/gtk/fonts/xsettings_antialias_settings-expected.png: Added.
* platform/gtk/fonts/xsettings_antialias_settings-expected.txt: Added.
* platform/gtk/fonts/xsettings_antialias_settings.html: Added.
2010-10-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Holger Freyther.
[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
https://bugs.webkit.org/show_bug.cgi?id=47033
Fix logic that merges XSettings defaults and FontConfig settings. If
FontConfig or XSettings specifies a subpixel order, we force subpixel
anti-aliasing on. If anti-aliasing is turned on explicitly, only
override the setting if it was previously off, otherwise we ignore
the user's preference for subpixel or gray antialiasing.
Test: platform/gtk/fonts/xsettings_antialias_settings.html
* platform/graphics/cairo/FontPlatformDataFreeType.cpp:
(WebCore::setCairoFontOptionsFromFontConfigPattern): Fix merging of XSettings
and FontConfig anti-aliasing settings.
(WebCore::getDefaultFontOptions): Added this helper.
(WebCore::FontPlatformData::FontPlatformData): Use the getDefaultFontOptions helper.
2010-10-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Holger Freyther.
[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
https://bugs.webkit.org/show_bug.cgi?id=47033
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGtkFontSettings): Added this method which initializes XSettings
font settings to consistent values before running a test. For the one test
in which we need subpixel aliasing turned on, do that.
(initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings.
(runTest): Pass the testURL to initializeFonts.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Thu, 14 Oct 2010 18:50:55 +0000 (18:50 +0000)]
2010-10-14 Nate Chapin <japhet@chromium.org>
Unreviewed, test tweaks.
Add Chromium win/linux results for http://trac.webkit.org/changeset/69774.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 14 Oct 2010 18:45:16 +0000 (18:45 +0000)]
Reviewed by Steve Falkenburg.
Add wkGetSSLCertificateChainContext for fetching the certificate chain.
Needed for https://bugs.webkit.org/show_bug.cgi?id=47603.
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:
* win/lib/WebKitSystemInterface_debug.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 18:36:47 +0000 (18:36 +0000)]
2010-10-14 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Eric Seidel.
[EFL] Add setting api for enabling encoding detector
https://bugs.webkit.org/show_bug.cgi?id=45427
Add settings api for enabling encoding detector.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_setting_encoding_detector_set):
(ewk_view_setting_encoding_detector_get):
* ewk/ewk_view.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Thu, 14 Oct 2010 18:30:00 +0000 (18:30 +0000)]
Support typed arrays in workers
https://bugs.webkit.org/show_bug.cgi?id=47616
Reviewed by David Levin.
To support typed arrays in workers, we need to expose constructors in
WorkerContext and add NoStaticTables attribute.
I also add File API feature guard to the constructors defined in
DOMWindow.
* bindings/js/JSDOMWindowCustom.cpp: Add File API feature guard to the
constructors defined in DOMWindow.
* html/canvas/ArrayBuffer.idl: Add NoStaticTables attribute.
* html/canvas/ArrayBufferView.idl: Add NoStaticTables attribute.
* html/canvas/Float32Array.idl: Add NoStaticTables attribute.
* html/canvas/Int16Array.idl: Add NoStaticTables attribute.
* html/canvas/Int32Array.idl: Add NoStaticTables attribute.
* html/canvas/Int8Array.idl: Add NoStaticTables attribute.
* html/canvas/Uint16Array.idl: Add NoStaticTables attribute.
* html/canvas/Uint32Array.idl: Add NoStaticTables attribute.
* html/canvas/Uint8Array.idl: Add NoStaticTables attribute.
* page/DOMWindow.idl: Add File API feature guard to the constructors
defined in DOMWindow.
* workers/WorkerContext.idl: Expose type array constructors.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 18:00:55 +0000 (18:00 +0000)]
2010-10-14 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
The backreference checking isn't working in some cases with YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46904
The Interpreter::matchBackReference() function returns true without matching
when a backreference points to the same parentheses where it is.
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::matchBackReference):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 14 Oct 2010 17:47:28 +0000 (17:47 +0000)]
Add baselines and pixel results for some new tests.
* platform/gtk/fast/forms/textfield-focus-ring-expected.checksum: Added.
* platform/gtk/fast/forms/textfield-focus-ring-expected.png: Added.
* platform/gtk/fast/forms/textfield-focus-ring-expected.txt: Added.
* platform/gtk/fast/images/imagemap-focus-ring-expected.checksum: Added.
* platform/gtk/fast/images/imagemap-focus-ring-expected.png: Added.
* platform/gtk/fast/images/imagemap-focus-ring-expected.txt: Added.
* platform/gtk/fast/inline/inline-focus-ring-expected.checksum: Added.
* platform/gtk/fast/inline/inline-focus-ring-expected.png: Added.
* platform/gtk/fast/inline/inline-focus-ring-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 14 Oct 2010 17:45:51 +0000 (17:45 +0000)]
2010-10-14 Andreas Kling <kling@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] Avoid creating empty transparency layers in ImageBuffer::clip()
We were creating empty layers for sub-1 height/width clips due to
using IntRect(FloatRect) instead of enclosingIntRect().
This lead to a bunch of QPainter warnings on the console since you
can't draw on an empty QPixmap.
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::clip):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Thu, 14 Oct 2010 17:31:47 +0000 (17:31 +0000)]
2010-10-14 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium test fix.
Expected results for tests added in http://trac.webkit.org/changeset/69766.
* platform/chromium-linux/fast/forms/textfield-focus-ring-expected.checksum: Added.
* platform/chromium-linux/fast/forms/textfield-focus-ring-expected.png: Added.
* platform/chromium-linux/fast/images/imagemap-focus-ring-expected.checksum: Added.
* platform/chromium-linux/fast/images/imagemap-focus-ring-expected.png: Added.
* platform/chromium-linux/fast/inline/inline-focus-ring-expected.checksum: Added.
* platform/chromium-linux/fast/inline/inline-focus-ring-expected.png: Added.
* platform/chromium-mac/fast/forms/textfield-focus-ring-expected.checksum: Added.
* platform/chromium-mac/fast/images/imagemap-focus-ring-expected.checksum: Added.
* platform/chromium-mac/fast/inline/inline-focus-ring-expected.checksum: Added.
* platform/chromium-win/fast/forms/textfield-focus-ring-expected.checksum: Added.
* platform/chromium-win/fast/forms/textfield-focus-ring-expected.png: Added.
* platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt: Added.
* platform/chromium-win/fast/images/imagemap-focus-ring-expected.checksum: Added.
* platform/chromium-win/fast/images/imagemap-focus-ring-expected.png: Added.
* platform/chromium-win/fast/images/imagemap-focus-ring-expected.txt: Added.
* platform/chromium-win/fast/inline/inline-focus-ring-expected.checksum: Added.
* platform/chromium-win/fast/inline/inline-focus-ring-expected.png: Added.
* platform/chromium-win/fast/inline/inline-focus-ring-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Thu, 14 Oct 2010 17:31:13 +0000 (17:31 +0000)]
2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070
Allow rendering of accelerated-compositing with TextureMapper, inside a QWebFrame. The frame will render the regular content,
either normally or through tiled backingstore, then let the TextureMapper layer render itself to the active context, and
then render the scrollbar and pan icon. This is different from the current implementation, which uses additional QGraphicsItems for AC
and the scrollbar overlay.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::paint):
* Api/qwebframe.cpp:
(QWebFramePrivate::renderFromTiledBackingStore):
(QWebFramePrivate::renderRelativeCoords):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 14 Oct 2010 17:23:55 +0000 (17:23 +0000)]
[cairo] Typo in determining fixed width fonts
https://bugs.webkit.org/show_bug.cgi?id=47470
It must be a single ampersand otherwise the
&& FT_FACE_FLAG_FIXED_WIDTH will always be true.
* platform/graphics/cairo/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 17:13:59 +0000 (17:13 +0000)]
2010-10-14 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] Failing test LayoutTests/editing/undo/orphaned-selection-crash-bug32823-2.html
https://bugs.webkit.org/show_bug.cgi?id=47666
Do a less strict decoding of base64 data url's as it was done
before. The actual problem is most likely
https://bugs.webkit.org/show_bug.cgi?id=47661 tough.
* platform/network/soup/cache/soup-request-data.c:
(webkit_soup_request_data_send):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 17:12:38 +0000 (17:12 +0000)]
2010-10-14 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Andreas Kling.
SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47660
Adding layout tests for feConvolveMatrix dynamic DOM changes. SVGDOM tests cases will be in the following patch because of patch-size limitation (2M in bugzilla).
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html: Added.
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-bias-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-divisor-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-edgeMode-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-in-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetX-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetY-attr.js: Added.
(executeTest):
2010-10-14 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Andreas Kling.
SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47660
The dynamic changes are captured by the svgAttributeChange function, and invalidate the filter primitive if necessary.
The patch also implements the simple setOrder and setKernelUnitLength methods.
Tests: svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html
* svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::setOrder):
(WebCore::SVGFEConvolveMatrixElement::setKernelUnitLength):
(WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
* svg/SVGFEConvolveMatrixElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Thu, 14 Oct 2010 16:57:00 +0000 (16:57 +0000)]
2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] Text breaking is slow: enable ICU as an opt-in
https://bugs.webkit.org/show_bug.cgi?id=40332
Added a config flag that enables ICU as an opt-in instead of the Qt specific code.
Because of the inclusion of ICU headers, some explicit casting was necessary in UnicodeQt4.h
* JavaScriptCore.pri:
* wtf/unicode/qt4/UnicodeQt4.h:
(WTF::Unicode::toLower):
(WTF::Unicode::toUpper):
(WTF::Unicode::toTitleCase):
(WTF::Unicode::foldCase):
(WTF::Unicode::isPrintableChar):
(WTF::Unicode::isSeparatorSpace):
(WTF::Unicode::isPunct):
(WTF::Unicode::isLower):
(WTF::Unicode::mirroredChar):
(WTF::Unicode::combiningClass):
(WTF::Unicode::direction):
(WTF::Unicode::category):
2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] Text breaking is slow: enable ICU as an opt-in
https://bugs.webkit.org/show_bug.cgi?id=40332
Added a config flag that enables ICU as an opt-in instead of the Qt specific code.
No new tests, this should be covered by existing tests.
* WebCore.pro:
* platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::currentTextBreakLocaleID):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Thu, 14 Oct 2010 16:52:57 +0000 (16:52 +0000)]
2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070
This patch enables compilation of TextureMapper with Media. It has an initial non-working implementation of a video layer, to be integrated
once other parts of TextureMapper are fully working.
No new tests: this is new implementation that's not enabled yet.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::TextureMapperVideoLayerQt::TextureMapperVideoLayerQt):
(WebCore::TextureMapperVideoLayerQt::setPlatformLayerClient):
(WebCore::TextureMapperVideoLayerQt::paint):
(WebCore::TextureMapperVideoLayerQt::size):
(WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged):
(WebCore::MediaPlayerPrivateQt::platformLayer):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering):
(WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged):
(WebCore::MediaPlayerPrivateQt::platformLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Thu, 14 Oct 2010 16:40:59 +0000 (16:40 +0000)]
2010-10-14 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 14 Oct 2010 16:40:08 +0000 (16:40 +0000)]
2010-10-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
https://bugs.webkit.org/show_bug.cgi?id=47655
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/common/config/ports_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 14 Oct 2010 16:18:31 +0000 (16:18 +0000)]
2010-10-14 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update expectations for some inspector tests.
* inspector/debugger-pause-in-eval-script-expected.txt:
* inspector/extensions-events-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Thu, 14 Oct 2010 16:13:06 +0000 (16:13 +0000)]
2010-10-14 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Fixed crashes in the GTK 64bits bot, we have to use NULL instead
of 0 when calling these glib APIs, 0 is compiled as a char and in
64bits systems it is not correct.
* platform/network/soup/cache/soup-requester.c:
(webkit_soup_requester_new):
(webkit_soup_requester_request_uri):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 14 Oct 2010 16:00:52 +0000 (16:00 +0000)]
2010-10-14 Daniel Bates <dbates@rim.com>
Attempt to fix the Qt and GTK builds based on the build bot results from <http://webkit.sed.hu>.
* rendering/RenderInline.cpp: Include header "RenderTheme.h"
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 14 Oct 2010 15:40:46 +0000 (15:40 +0000)]
2010-10-14 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Only draw focus ring in RenderInline and RenderImage if the theme
is not able to draw a focus ring
https://bugs.webkit.org/show_bug.cgi?id=47632
Fixes an issue where RenderInline::paintOutline() and RenderImage::paintFocusRings()
would draw a focus ring regardless of whether the port-specific theme is able to
draw a focus ring. Instead, these methods should only draw a focus ring if the
theme is unable to draw a focus ring.
Also, extracted common focus ring drawing code from RenderObject::paintOutline()
and RenderInline::paintOutline() into RenderObject::paintFocusRing().
Tests: fast/forms/textfield-focus-ring.html
fast/images/imagemap-focus-ring.html
fast/inline/inline-focus-ring.html
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintFocusRings): Modified to only draw a focus ring if the
the theme does not draw one.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline): Modified to call RenderObject::paintFocusRing().
* rendering/RenderObject.cpp:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): Added.
(WebCore::RenderObject::paintOutline): Modified to call RenderObject::paintFocusRing().
* rendering/RenderObject.h:
2010-10-14 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Only draw focus ring in RenderInline and RenderImage if the theme
is not able to draw a focus ring
https://bugs.webkit.org/show_bug.cgi?id=47632
Pixel tests to ensure that we don't regress focus ring drawing for RenderObject
(fast/forms/textfield-focus-ring.html), RenderImage (fast/images/imagemap-focus-ring.html)
and RenderInline (fast/inline/inline-focus-ring.html) on ports that support focus
ring drawing.
* fast/forms/textfield-focus-ring.html: Added.
* fast/images/imagemap-focus-ring.html: Added.
* fast/inline/inline-focus-ring.html: Added.
* platform/mac/fast/forms/textfield-focus-ring-expected.checksum: Added.
* platform/mac/fast/forms/textfield-focus-ring-expected.png: Added.
* platform/mac/fast/forms/textfield-focus-ring-expected.txt: Added.
* platform/mac/fast/images/imagemap-focus-ring-expected.checksum: Added.
* platform/mac/fast/images/imagemap-focus-ring-expected.png: Added.
* platform/mac/fast/images/imagemap-focus-ring-expected.txt: Added.
* platform/mac/fast/inline/inline-focus-ring-expected.checksum: Added.
* platform/mac/fast/inline/inline-focus-ring-expected.png: Added.
* platform/mac/fast/inline/inline-focus-ring-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Thu, 14 Oct 2010 15:16:51 +0000 (15:16 +0000)]
2010-10-14 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations update.
[chromium] Update test_expectations following Skia roll in chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Thu, 14 Oct 2010 14:14:19 +0000 (14:14 +0000)]
2010-10-14 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
DeviceOrientation crash when page is in page cache and is navigated while listener is registered
https://bugs.webkit.org/show_bug.cgi?id=47257
This crash is avoided now that pages using DeviceOrientation are not put in
the page cache. See https://bugs.webkit.org/show_bug.cgi?id=47408.
This test serves to document the fact that the underlying problem needs to
be addressed before the page cache is enabled for DeviceOrientation.
* fast/dom/DeviceOrientation/event-after-navigation-expected.txt: Added.
* fast/dom/DeviceOrientation/event-after-navigation.html: Added.
* fast/dom/DeviceOrientation/resources/event-after-navigation-new.html: Added.
* fast/dom/DeviceOrientation/script-tests/event-after-navigation.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 14 Oct 2010 13:48:00 +0000 (13:48 +0000)]
2010-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Move load and dom content event timers into InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=47668
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::mainResourceFiredDOMContentEvent):
(WebCore::InspectorController::mainResourceFiredLoadEvent):
* inspector/InspectorController.h:
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::InspectorResource):
(WebCore::InspectorResource::updateScriptObject):
* inspector/InspectorResource.h:
* inspector/front-end/inspector.js:
(WebInspector.updateResource):
(WebInspector.domContentEventFired):
(WebInspector.loadEventFired):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 14 Oct 2010 13:18:19 +0000 (13:18 +0000)]
2010-10-14 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Fix -Werror after r68637 on x86 platforms.
Qt's build system sets QT_ARCH statically to i386 or x86_64 accordingly,
so check for this instead of only checking for x86.
* WebKit.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 14 Oct 2010 13:03:06 +0000 (13:03 +0000)]
2010-10-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Re-landing r69757.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 14 Oct 2010 12:56:28 +0000 (12:56 +0000)]
2010-10-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: implement pausing on window events and timeouts
https://bugs.webkit.org/show_bug.cgi?id=47542
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willDispatchEventImpl):
(WebCore::InspectorInstrumentation::didDispatchEventImpl):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
(WebCore::InspectorInstrumentation::didDispatchEventOnWindowImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::didFireTimerImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
(WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
* inspector/InspectorInstrumentation.h:
* inspector/front-end/BreakpointManager.js:
(WebInspector.EventListenerBreakpoint.prototype.populateLabelElement):
(WebInspector.EventListenerBreakpoint.prototype.populateStatusMessageElement):
(WebInspector.EventListenerBreakpoint.prototype._condition):
(WebInspector.EventListenerBreakpoint.prototype._uiEventName):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._populate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 14 Oct 2010 12:43:22 +0000 (12:43 +0000)]
2010-10-14 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Andreas Kling.
Canvas: "currentColor" should inherit the canvas element's color
https://bugs.webkit.org/show_bug.cgi?id=40273
Warning fix after r69755. Missing default cases added.
* html/canvas/CanvasStyle.cpp:
(WebCore::parseColorOrCurrentColor):
(WebCore::CanvasStyle::createFromString):
(WebCore::CanvasStyle::createFromStringWithOverrideAlpha):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 14 Oct 2010 12:01:45 +0000 (12:01 +0000)]
2010-10-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out r69757.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 14 Oct 2010 11:38:58 +0000 (11:38 +0000)]
2010-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract content-related methods into InspectorResourceAgent.
https://bugs.webkit.org/show_bug.cgi?id=47415
This is needed for resource-tracking-less operation of resources panel.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* inspector/InspectorCSSAgent.cpp:
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::type):
(WebCore::InspectorResource::sourceString):
(WebCore::InspectorResource::sourceBytes):
* inspector/InspectorResource.h:
* inspector/InspectorResourceAgent.cpp: Added.
(WebCore::InspectorResourceAgent::resourceContent):
(WebCore::InspectorResourceAgent::resourceContentBase64):
(WebCore::InspectorResourceAgent::resourceData):
(WebCore::InspectorResourceAgent::cachedResourceType):
(WebCore::InspectorResourceAgent::cachedResource):
* inspector/InspectorResourceAgent.h: Added.
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
* inspector/InspectorUtilities.cpp: Removed.
* inspector/InspectorUtilities.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Thu, 14 Oct 2010 11:02:34 +0000 (11:02 +0000)]
2010-10-14 Hayato Ito <hayato@chromium.org>
Unreviewed, build fix.
Skip a test that does not have an expected result.
<http://trac.webkit.org/changeset/69751> lacked prefix of 'platform/gtk'.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 14 Oct 2010 10:47:24 +0000 (10:47 +0000)]
2010-10-14 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Canvas: "currentColor" should inherit the canvas element's color
https://bugs.webkit.org/show_bug.cgi?id=40273
Add support for "currentColor" in CanvasRenderingContext2D APIs.
If the canvas is in-document, "currentColor" is replaced by canvas.style.color,
otherwise we use fully opaque black.
For gradient addColorStop(), "currentColor" always means fully opaque black.
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#2dcontext
Test: fast/canvas/canvas-currentColor.html
* html/canvas/CanvasGradient.cpp:
(WebCore::CanvasGradient::addColorStop):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setStrokeStyle):
(WebCore::CanvasRenderingContext2D::setFillStyle):
(WebCore::CanvasRenderingContext2D::setShadowColor):
(WebCore::CanvasRenderingContext2D::setShadow):
* html/canvas/CanvasStyle.cpp:
(WebCore::parseColor):
(WebCore::currentColor):
(WebCore::parseColorOrCurrentColor):
(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::createFromString):
(WebCore::CanvasStyle::createFromStringWithOverrideAlpha):
(WebCore::CanvasStyle::isEquivalentColor):
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
* html/canvas/CanvasStyle.h:
(WebCore::CanvasStyle::isCurrentColor):
(WebCore::CanvasStyle::hasOverrideAlpha):
(WebCore::CanvasStyle::overrideAlpha):
2010-10-14 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Canvas: "currentColor" should inherit the canvas element's color
https://bugs.webkit.org/show_bug.cgi?id=40273
Added test to verify support for "currentColor" value in CanvasRenderingContext2D.
Also unskipped 3 tests which now pass:
- canvas/philip/tests/2d.fillStyle.parse.current.basic.html
- canvas/philip/tests/2d.fillStyle.parse.current.changed.html
- canvas/philip/tests/2d.fillStyle.parse.current.removed.html
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#2dcontext
* fast/canvas/canvas-currentColor-expected.txt: Added.
* fast/canvas/canvas-currentColor.html: Added.
* fast/canvas/script-tests/canvas-currentColor.js: Added.
(attachCanvasToDocument):
(tryLinearGradientColor):
(tryRadialGradientColor):
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 14 Oct 2010 09:20:49 +0000 (09:20 +0000)]
Unreviewed fix after r69749.
* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 09:13:10 +0000 (09:13 +0000)]
2010-10-14 Anton Faern <anton@bladehawke.com>
Reviewed by Csaba Osztrogonác.
https://bugs.webkit.org/show_bug.cgi?id=47658
NetBSD was not included in the WTF_PLATFORM_FOO to WTF_OS_FOO
change. This means that OS(NETBSD) is also undefined.
* wtf/Platform.h: s/_PLATFORM_/_OS_/ for NetBSD
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 14 Oct 2010 08:42:47 +0000 (08:42 +0000)]
2010-10-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
https://bugs.webkit.org/show_bug.cgi?id=47358
Test: inspector/debugger-eval-on-call-frame.html
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor.): don't embrace expression evaluated in the local scope
of a call frame into with(window) to avoid shadowing local variables by global ones.
2010-10-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
https://bugs.webkit.org/show_bug.cgi?id=47358
* inspector/debugger-eval-on-call-frame-expected.txt: Added.
* inspector/debugger-eval-on-call-frame.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Thu, 14 Oct 2010 08:39:04 +0000 (08:39 +0000)]
2010-10-14 Hayato Ito <hayato@chromium.org>
Unreviewed, build fix.
Skip a test that does not have an expected result.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 14 Oct 2010 08:18:05 +0000 (08:18 +0000)]
2010-10-14 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
svg/custom/use-on-symbol-inside-pattern.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=17393
Re-enable this test since the debugString() discrepancy issue
disappeared with <http://trac.webkit.org/changeset/69386>
* platform/mac-tiger/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 14 Oct 2010 08:02:13 +0000 (08:02 +0000)]
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Implement getParameter from the URL API
https://bugs.webkit.org/show_bug.cgi?id=46610
Test various interesting cases in parameter parsing.
* fast/dom/anchor-getParameter-expected.txt: Added.
* fast/dom/anchor-getParameter.html: Added.
* http/tests/misc/location-getParameter-expected.txt: Added.
* http/tests/misc/location-getParameter.html: Added.
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Implement getParameter from the URL API
https://bugs.webkit.org/show_bug.cgi?id=46610
Another API from
https://docs.google.com/document/edit?id=1r_VTFKApVOaNIkocrg0z-t7lZgzisTuGTXkdzAk4gLU&hl=en#
getParameter lets a web site easily read the value of a URL parameter.
This API is for the simple case of a non-repeated parameter name.
getParameterAll will handle repeated parameter names in a future patch.
Tests: fast/dom/anchor-getParameter.html
http/tests/misc/location-getParameter.html
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::getParameter):
* html/HTMLAnchorElement.h:
* html/HTMLAnchorElement.idl:
* page/Location.cpp:
(WebCore::Location::getParameter):
* page/Location.h:
* page/Location.idl:
* platform/KURL.cpp:
(WebCore::KURL::copyParsedQueryTo):
* platform/KURLGoogle.cpp:
(WebCore::KURL::copyParsedQueryTo):
* platform/KURL.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Thu, 14 Oct 2010 07:53:21 +0000 (07:53 +0000)]
2010-10-14 Alejandro G. Castro <alex@igalia.com>
Unreviewed. GTK build fix.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 07:18:18 +0000 (07:18 +0000)]
2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
https://bugs.webkit.org/show_bug.cgi?id=47016
* compositing/tiling/huge-layer-img.html: Added.
* platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
* platform/mac-wk2/Skipped:
* platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.
2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
https://bugs.webkit.org/show_bug.cgi?id=47016
Test: compositing/tiling
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::requiresClippedUpdateRect):
(WebCore::ContentLayerChromium::calculateClippedUpdateRect):
(WebCore::ContentLayerChromium::updateContents):
(WebCore::ContentLayerChromium::updateTextureRect):
(WebCore::ContentLayerChromium::draw):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContents):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::rootLayerContentRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Thu, 14 Oct 2010 07:10:31 +0000 (07:10 +0000)]
2010-10-14 Chris Rogers <crogers@google.com>
Reviewed by Chris Fleizach.
Add DelayDSPKernel files
https://bugs.webkit.org/show_bug.cgi?id=47518
No new tests since audio API is not yet implemented.
* webaudio/DelayDSPKernel.cpp: Added.
(WebCore::DelayDSPKernel::DelayDSPKernel):
(WebCore::DelayDSPKernel::process):
(WebCore::DelayDSPKernel::reset):
* webaudio/DelayDSPKernel.h: Added.
(WebCore::DelayDSPKernel::maxDelayTime):
(WebCore::DelayDSPKernel::setDelayFrames):
(WebCore::DelayDSPKernel::delayProcessor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 06:58:30 +0000 (06:58 +0000)]
2010-10-13 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Sync tests from html5lib.
https://bugs.webkit.org/show_bug.cgi?id=47627
* html5lib/resources/adoption02.dat: Copied from html5lib.
* html5lib/resources/entities01.dat: Ditto.
* html5lib/resources/pending-spec-changes.dat: Ditto.
* html5lib/resources/tests21.dat: Ditto.
* html5lib/runner-expected.txt: 2 tests now pass.
* platform/chromium/html5lib/runner-expected.txt: Ditto.
* platform/win/html5lib/runner-expected.txt: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 14 Oct 2010 06:55:51 +0000 (06:55 +0000)]
2010-10-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
beat diff_parser with the ugly stick
https://bugs.webkit.org/show_bug.cgi?id=47626
* Scripts/webkitpy/common/checkout/diff_parser.py:
* Scripts/webkitpy/style/patchreader.py:
* Scripts/webkitpy/style/patchreader_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 06:45:26 +0000 (06:45 +0000)]
2010-10-13 David Goodwin <david_goodwin@apple.com>
Reviewed by Oliver Hunt.
ARMv7 JIT should generated conditional branches when possible
https://bugs.webkit.org/show_bug.cgi?id=47384
Use different jump padding sizes for conditional and unconditional
jumps (12 bytes and 10 bytes respectively). This allows the JIT to
include the IT instruction as part of the conditional jump sequence
which in turn allows it to optimize away the IT using an ARMv7
conditional branch instruction. Use 2-byte B(T1) and 4-byte B(T3) for
conditional branches when displacement is in range. Also use IT/B(T4)
for conditional branch when displacement does not fit in B(T3).
For unconditional jump, instruction selection options are:
B(T2), B(T4), MOVW/MOVT/BX. For conditional jump, instruction selection
options are: B(T1), B(T3), IT/B(T4), ITTT/MOVW/MOVT/BX.
* assembler/ARMv7Assembler.cpp:
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::JmpSrc::JmpSrc):
(JSC::ARMv7Assembler::ifThenElse):
(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::canCompact):
(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::link):
(JSC::ARMv7Assembler::canBeJumpT1):
(JSC::ARMv7Assembler::canBeJumpT3):
(JSC::ARMv7Assembler::canBeJumpT4):
(JSC::ARMv7Assembler::linkJumpT1):
(JSC::ARMv7Assembler::linkJumpT3):
(JSC::ARMv7Assembler::linkJumpT4):
(JSC::ARMv7Assembler::linkConditionalJumpT4):
(JSC::ARMv7Assembler::linkBX):
(JSC::ARMv7Assembler::linkConditionalBX):
(JSC::ARMv7Assembler::linkJumpAbsolute):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::linkCode):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::canCompact):
(JSC::MacroAssemblerARMv7::computeJumpType):
(JSC::MacroAssemblerARMv7::jumpSizeDelta):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::ret):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):
(JSC::MacroAssemblerARMv7::makeJump):
(JSC::MacroAssemblerARMv7::makeBranch):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 14 Oct 2010 06:32:17 +0000 (06:32 +0000)]
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
WebKitGtk+ to use the new API from the imported SoupURILoader code
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
ResourceHandleSoup now does everything via SoupURILoader. This means
that all URLs are handled via the same code path, where WebCore simply
asks libsoup for a WebKitSoupRequest and the request returns an input
stream. Many of ResourceHandleSoup's data members are now PlatformRefPtr
as well, to simplify reference counting
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::~ResourceHandle):
(WebCore::restartedCallback):
(WebCore::gotChunkCallback):
(WebCore::parseDataUrl):
(WebCore::cleanupSoupRequestOperation):
(WebCore::sendRequestCallback):
(WebCore::startHttp):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
(WebCore::closeCallback):
(WebCore::readCallback):
(WebCore::startGio):
* platform/network/soup/ResourceRequest.h:
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessage):
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
WebKitGtk+ to use the new API from the imported SoupURILoader code
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
ResourceHandleInternal m_msg is now called m_soupMessage.
* webkit/webkitdownload.cpp:
(webkit_download_new_with_handle):
(webkit_download_start):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 14 Oct 2010 06:28:28 +0000 (06:28 +0000)]
2010-10-13 Martin Robinson <mrobinson@igalia.com>
Rebaseline canvas/philip/tests/2d.gradient.radial.negative.html. It seems
that the result for this test is only differing by two newlines. Also skip
a failing test on GTK+.
* canvas/philip/tests/2d.gradient.radial.negative-expected.txt: Rebaseline.
* platform/gtk/Skipped: Skip failing test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 14 Oct 2010 05:54:06 +0000 (05:54 +0000)]
2010-10-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Break LayoutTestResults out into its own file
https://bugs.webkit.org/show_bug.cgi?id=47637
* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/buildbot_unittest.py:
* Scripts/webkitpy/common/net/layouttestresults.py: Added.
* Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc