WebKit-https.git
9 years agoWeb Inspector: Timeline memory graph would have been more useful if it had used minUs...
loislo@chromium.org [Thu, 9 Feb 2012 13:04:13 +0000 (13:04 +0000)]
Web Inspector: Timeline memory graph would have been more useful if it had used minUsedHeapSize as the lower bound. Currently it uses zero as the lower bound.
https://bugs.webkit.org/show_bug.cgi?id=78222

Reviewed by Pavel Feldman.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.HeapGraph):
(WebInspector.HeapGraph.prototype.update):
* inspector/front-end/timelinePanel.css:
(.memory-graph-label):
(.max.memory-graph-label):
(.min.memory-graph-label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 9 Feb 2012 12:55:42 +0000 (12:55 +0000)]
2012-02-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Move platform dependant results where they belong, and add Qt specific ones.

        * platform/mac/svg/custom/glyph-selection-arabic-forms-expected.png: Renamed from LayoutTests/svg/custom/glyph-selection-arabic-forms-expected.png.
        * platform/mac/svg/custom/glyph-selection-arabic-forms-expected.txt: Renamed from LayoutTests/svg/custom/glyph-selection-arabic-forms-expected.txt.
        * platform/mac/svg/custom/glyph-selection-bidi-mirror-expected.png: Renamed from LayoutTests/svg/custom/glyph-selection-bidi-mirror-expected.png.
        * platform/mac/svg/custom/glyph-selection-bidi-mirror-expected.txt: Renamed from LayoutTests/svg/custom/glyph-selection-bidi-mirror-expected.txt.
        * platform/mac/svg/custom/glyph-selection-non-bmp-expected.png: Renamed from LayoutTests/svg/custom/glyph-selection-non-bmp-expected.png.
        * platform/mac/svg/custom/glyph-selection-non-bmp-expected.txt: Renamed from LayoutTests/svg/custom/glyph-selection-non-bmp-expected.txt.
        * platform/qt/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
        * platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
        * platform/qt/svg/custom/glyph-selection-non-bmp-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix compilation with newer Qt5
ossy@webkit.org [Thu, 9 Feb 2012 12:50:46 +0000 (12:50 +0000)]
[Qt] Fix compilation with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=77653

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-09
Reviewed by Tor Arne Vestbø.

* Api/qgraphicswebview.cpp: Removed unnecessary inclusion of removed header file.
* declarative/public.pri: Use quick1 instead of qtquick1. It's mandator with Qt 5.
* tests/tests.pri: Ditto.
* declarative/qdeclarativewebview_p.h: Fix includes, just use the module-less
version that works with all Qt versions.
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Update protocol and UI to follow bug 77204 (Kill per-Attribute style...
apavlov@chromium.org [Thu, 9 Feb 2012 12:41:37 +0000 (12:41 +0000)]
Web Inspector: Update protocol and UI to follow bug 77204 (Kill per-Attribute style declarations)
https://bugs.webkit.org/show_bug.cgi?id=77962

Reviewed by Pavel Feldman.

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getInlineStylesAsync):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.inlineCallback):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.get continue):

LayoutTests:

* inspector/elements/elements-panel-styles-expected.txt:
* inspector/styles/styles-computed-trace-expected.txt:
* inspector/styles/styles-new-API-expected.txt:
* inspector/styles/styles-new-API.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 9 Feb 2012 12:33:44 +0000 (12:33 +0000)]
2012-02-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add missing Mac/Lion result.

        * platform/mac/svg/carto.net/scrollbar-expected.png: Added.
        * svg/custom/glyph-selection-bidi-mirror-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 9 Feb 2012 12:26:17 +0000 (12:26 +0000)]
2012-02-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        Switch svg/custom tests to repaint harness
        https://bugs.webkit.org/show_bug.cgi?id=78115

        Not reviewed. Fix last minute typo, in nested-embedded-svg-size-changes.html, that may lead to flakiness.

        * svg/as-object/nested-embedded-svg-size-changes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: toggle Edit as HTML on F2, drag nodes up / down upon Ctrl(Cmd) Up...
pfeldman@chromium.org [Thu, 9 Feb 2012 12:24:27 +0000 (12:24 +0000)]
Web Inspector: toggle Edit as HTML on F2, drag nodes up / down upon Ctrl(Cmd) Up / Down.
https://bugs.webkit.org/show_bug.cgi?id=78123

Reviewed by Yury Semikhatsky.

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::undo):
(InspectorDOMAgent::SetOuterHTMLAction):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._registerShortcuts):
(WebInspector.ElementsPanel.prototype.handleShortcut):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._ondragstart):
(WebInspector.ElementsTreeOutline.prototype._ondragover):
(WebInspector.ElementsTreeOutline.prototype._doMove):
(WebInspector.ElementsTreeOutline.prototype._ondragend):
(WebInspector.ElementsTreeOutline.prototype._populateContextMenu):
(WebInspector.ElementsTreeOutline.prototype.handleShortcut):
(WebInspector.ElementsTreeOutline.prototype._toggleEditAsHTML):
(WebInspector.ElementsTreeOutline.prototype._selectNodeAfterEdit):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.commit):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
* inspector/front-end/UIUtils.js:

LayoutTests:

* inspector/elements/move-node.html:
* inspector/elements/undo-dom-edits-expected.txt:
* inspector/elements/undo-dom-edits.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 9 Feb 2012 12:02:56 +0000 (12:02 +0000)]
2012-02-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline some Qt svg results.

        * platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:
        * platform/qt/svg/custom/foreignObject-crash-on-hover-expected.txt:
        * platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.txt:
        * platform/qt/svg/custom/js-update-bounce-expected.txt:
        * platform/qt/svg/custom/js-update-stop-linked-gradient-expected.txt:
        * platform/qt/svg/custom/js-update-style-expected.txt:
        * platform/qt/svg/custom/mask-invalidation-expected.txt:
        * platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt:
        * platform/qt/svg/custom/text-repaint-including-stroke-expected.txt:
        * platform/qt/svg/custom/use-clipped-hit-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test expectation update.
bashi@chromium.org [Thu, 9 Feb 2012 11:58:27 +0000 (11:58 +0000)]
Unreviewed test expectation update.

* platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png: Renamed from LayoutTests/platform/chromium/platform/chromium/compositing/layout-width-change-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-09 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Thu, 9 Feb 2012 11:56:43 +0000 (11:56 +0000)]
2012-02-09  Roland Steiner  <rolandsteiner@chromium.org>

        SelectorChecker::checkSelector: move parameters into a struct
        https://bugs.webkit.org/show_bug.cgi?id=77525

        Added 'SelectorCheckingContext' struct to hold parameters for the function.
        Adapted calling sites.
        (fixing change log after the commit message got bungled up).

        Reviewed by Antti Koivisto.

        No new tests. (refactoring)

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::checkSelector):
        * css/SelectorChecker.cpp:
        (WebCore::SelectorChecker::checkSelector):
        (WebCore):
        (WebCore::SelectorChecker::checkOneSelector):
        * css/SelectorChecker.h:
        (SelectorCheckingContext):
        (WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
        (SelectorChecker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] REGRESSION(r106918): It made svg/as-object/nested-embedded-svg-size-changes...
zimmermann@webkit.org [Thu, 9 Feb 2012 11:44:55 +0000 (11:44 +0000)]
[Qt] REGRESSION(r106918): It made svg/as-object/nested-embedded-svg-size-changes.html fail in debug mode
https://bugs.webkit.org/show_bug.cgi?id=78026

[Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
https://bugs.webkit.org/show_bug.cgi?id=77183

Reviewed by Andreas Kling.

Rework testcases, to wait for the embedded SVG of the embedded HTML that we're loading.
Should fix the flakiness for both Qt/Chromium.

* platform/qt/Skipped: Unskip test.
* svg/as-object/nested-embedded-svg-size-changes.html: Wait for the embedded SVG to load, before trying to access it.
* svg/as-object/resources/nested-embedded-svg-size-changes-target.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix mirroring with SVG fonts
rolandsteiner@chromium.org [Thu, 9 Feb 2012 11:44:28 +0000 (11:44 +0000)]
Fix mirroring with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=77067

Patch by Philip Rogers <pdr@google.com> on 2012-02-09
Reviewed by Nikolas Zimmermann.

SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.

Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.

Tests: svg/custom/glyph-selection-arabic-forms.svg
       svg/custom/glyph-selection-bidi-mirror.svg
       svg/custom/glyph-selection-non-bmp.svg

* platform/graphics/SVGGlyph.cpp:
(WebCore::charactersWithArabicForm):
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
(WebCore::SVGFontData::createStringWithMirroredCharacters):
* svg/SVGFontData.h:
(SVGFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-09 Philip Rogers <pdr@google.com>
zimmermann@webkit.org [Thu, 9 Feb 2012 11:40:53 +0000 (11:40 +0000)]
2012-02-09  Philip Rogers  <pdr@google.com>

        Fix mirroring with SVG fonts
        https://bugs.webkit.org/show_bug.cgi?id=77067

        Reviewed by Nikolas Zimmermann.

        SVG fonts were incorrectly handling mirrored characters in bidi text.
        In this change I added the function createStringWithMirroredCharacters
        which handles mirroring the characters when selecting glyphs for SVG
        fonts. I also made a small cosmetic change in the function
        charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
        which better reflects what it actually does.

        Several new tests were added to test mirroring with SVG fonts in the
        presence of Arabic forms and non-BMP characters.

        * platform/gtk/test_expectations.txt:
        * platform/win/test_expectations.txt:
        * svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
        * svg/custom/glyph-selection-arabic-forms.svg: Added.
        * svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
        * svg/custom/glyph-selection-bidi-mirror.svg: Added.
        * svg/custom/glyph-selection-non-bmp-expected.png: Added.
        * svg/custom/glyph-selection-non-bmp-expected.txt: Added.
        * svg/custom/glyph-selection-non-bmp.svg: Added.

2012-02-09  Philip Rogers  <pdr@google.com>

        Fix mirroring with SVG fonts
        https://bugs.webkit.org/show_bug.cgi?id=77067

        Reviewed by Nikolas Zimmermann.

        SVG fonts were incorrectly handling mirrored characters in bidi text.
        In this change I added the function createStringWithMirroredCharacters
        which handles mirroring the characters when selecting glyphs for SVG
        fonts. I also made a small cosmetic change in the function
        charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
        which better reflects what it actually does.

        Several new tests were added to test mirroring with SVG fonts in the
        presence of Arabic forms and non-BMP characters.

        Tests: svg/custom/glyph-selection-arabic-forms.svg
               svg/custom/glyph-selection-bidi-mirror.svg
               svg/custom/glyph-selection-non-bmp.svg

        * platform/graphics/SVGGlyph.cpp:
        (WebCore::charactersWithArabicForm):
        * svg/SVGFontData.cpp:
        (WebCore::SVGFontData::applySVGGlyphSelection):
        (WebCore::SVGFontData::createStringWithMirroredCharacters):
        * svg/SVGFontData.h:
        (SVGFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r107207.
philn@webkit.org [Thu, 9 Feb 2012 11:37:16 +0000 (11:37 +0000)]
Unreviewed, GTK rebaseline after r107207.

* platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.txt:
* platform/gtk/svg/custom/foreignObject-crash-on-hover-expected.txt:
* platform/gtk/svg/custom/hit-test-unclosed-subpaths-expected.txt:
* platform/gtk/svg/custom/js-update-bounce-expected.txt:
* platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt:
* platform/gtk/svg/custom/js-update-style-expected.txt:
* platform/gtk/svg/custom/mask-invalidation-expected.txt:
* platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
* platform/gtk/svg/custom/text-repaint-including-stroke-expected.txt:
* platform/gtk/svg/custom/use-clipped-hit-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Scripts navigator fails to reopen previously closed script.
vsevik@chromium.org [Thu, 9 Feb 2012 11:28:57 +0000 (11:28 +0000)]
Web Inspector: Scripts navigator fails to reopen previously closed script.
https://bugs.webkit.org/show_bug.cgi?id=78212

Reviewed by Pavel Feldman.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._editorClosed):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._tabClosed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoASSERT_NO_EXCEPTION should be initialized with non-zero value.
commit-queue@webkit.org [Thu, 9 Feb 2012 11:21:46 +0000 (11:21 +0000)]
ASSERT_NO_EXCEPTION should be initialized with non-zero value.
https://bugs.webkit.org/show_bug.cgi?id=78194

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-09
Reviewed by Hajime Morita.

ExceptionCode should not be checked without initializing it.
However, we encountered a bug that breaks this rule.
It was missed until now because ExceptionCode is sometimes set to 0 even if it is not initialized.
This patch ensures it is initialized as non-zero value.

No new tests, no change in behavior.

* dom/ExceptionCodePlaceholder.cpp:
(WebCore::NoExceptionAssertionChecker::NoExceptionAssertionChecker):
(WebCore::NoExceptionAssertionChecker::~NoExceptionAssertionChecker):
* dom/ExceptionCodePlaceholder.h:
(NoExceptionAssertionChecker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch svg/custom tests to repaint harness
zimmermann@webkit.org [Thu, 9 Feb 2012 11:21:42 +0000 (11:21 +0000)]
Switch svg/custom tests to repaint harness
https://bugs.webkit.org/show_bug.cgi?id=78115

Reviewed by Andreas Kling.

Make all tests that exercise repainting use the fast/repaint/resources/repaint.js harness.

* platform/chromium/test_expectations.txt:
* platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
* platform/mac/svg/custom/absolute-sized-content-with-resources-expected.txt:
* platform/mac/svg/custom/animate-path-discrete-expected.png:
* platform/mac/svg/custom/animate-path-morphing-expected.png:
* platform/mac/svg/custom/animate-target-id-changed-expected.png:
* platform/mac/svg/custom/animate-target-removed-from-document-expected.png:
* platform/mac/svg/custom/circle-move-invalidation-expected.png:
* platform/mac/svg/custom/clip-path-child-changes-expected.png:
* platform/mac/svg/custom/clip-path-href-changes-expected.png:
* platform/mac/svg/custom/clip-path-id-changes-expected.png:
* platform/mac/svg/custom/clip-path-units-changes-expected.png:
* platform/mac/svg/custom/deep-dynamic-updates-expected.png:
* platform/mac/svg/custom/fill-opacity-update-expected.png:
* platform/mac/svg/custom/foreignObject-crash-on-hover-expected.png:
* platform/mac/svg/custom/foreignObject-crash-on-hover-expected.txt:
* platform/mac/svg/custom/gradient-add-stops-expected.png:
* platform/mac/svg/custom/gradient-stop-style-change-expected.png:
* platform/mac/svg/custom/hit-test-unclosed-subpaths-expected.png:
* platform/mac/svg/custom/hit-test-unclosed-subpaths-expected.txt:
* platform/mac/svg/custom/hit-test-with-br-expected.png:
* platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-clipPath-creation-expected.png:
* platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-gradient-creation-expected.png:
* platform/mac/svg/custom/js-late-marker-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-marker-creation-expected.png:
* platform/mac/svg/custom/js-late-mask-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-mask-creation-expected.png:
* platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-pattern-creation-expected.png:
* platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png:
* platform/mac/svg/custom/js-update-bounce-expected.png:
* platform/mac/svg/custom/js-update-bounce-expected.txt:
* platform/mac/svg/custom/js-update-container-expected.png:
* platform/mac/svg/custom/js-update-container2-expected.png:
* platform/mac/svg/custom/js-update-gradient-expected.png:
* platform/mac/svg/custom/js-update-image-expected.png:
* platform/mac/svg/custom/js-update-path-changes-expected.png:
* platform/mac/svg/custom/js-update-path-removal-expected.png:
* platform/mac/svg/custom/js-update-pattern-child-expected.png:
* platform/mac/svg/custom/js-update-pattern-expected.png:
* platform/mac/svg/custom/js-update-polygon-changes-expected.png:
* platform/mac/svg/custom/js-update-polygon-removal-expected.png:
* platform/mac/svg/custom/js-update-stop-expected.png:
* platform/mac/svg/custom/js-update-stop-linked-gradient-expected.png:
* platform/mac/svg/custom/js-update-stop-linked-gradient-expected.txt:
* platform/mac/svg/custom/js-update-style-expected.png:
* platform/mac/svg/custom/js-update-style-expected.txt:
* platform/mac/svg/custom/js-update-transform-addition-expected.png:
* platform/mac/svg/custom/js-update-transform-changes-expected.png:
* platform/mac/svg/custom/marker-child-changes-css-expected.png:
* platform/mac/svg/custom/marker-child-changes-expected.png:
* platform/mac/svg/custom/marker-strokeWidth-changes-expected.png:
* platform/mac/svg/custom/marker-viewBox-changes-expected.png:
* platform/mac/svg/custom/mask-child-changes-expected.png:
* platform/mac/svg/custom/mask-invalidation-expected.png:
* platform/mac/svg/custom/mask-invalidation-expected.txt:
* platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png:
* platform/mac/svg/custom/prevent-default-expected.png:
* platform/mac/svg/custom/relative-sized-content-expected.png:
* platform/mac/svg/custom/relative-sized-content-with-resources-expected.png:
* platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt:
* platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
* platform/mac/svg/custom/relative-sized-image-expected.png:
* platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
* platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.png:
* platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
* platform/mac/svg/custom/relative-sized-use-on-symbol-expected.png:
* platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
* platform/mac/svg/custom/repaint-moving-svg-and-div-expected.png:
* platform/mac/svg/custom/repaint-on-image-bounds-change-expected.png:
* platform/mac/svg/custom/resource-client-removal-expected.png:
* platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
* platform/mac/svg/custom/scroll-hit-test-expected.png:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
* platform/mac/svg/custom/stroke-opacity-update-expected.png:
* platform/mac/svg/custom/svg-absolute-children-expected.png:
* platform/mac/svg/custom/text-dom-removal-expected.png:
* platform/mac/svg/custom/text-repaint-including-stroke-expected.png:
* platform/mac/svg/custom/text-repaint-including-stroke-expected.txt:
* platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
* platform/mac/svg/custom/use-clipped-hit-expected.png:
* platform/mac/svg/custom/use-clipped-hit-expected.txt:
* platform/mac/svg/custom/use-detach-expected.png:
* platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
* platform/mac/svg/custom/use-elementInstance-event-target-expected.png:
* platform/mac/svg/custom/use-elementInstance-methods-expected.png:
* platform/mac/svg/custom/use-event-handler-on-referenced-element-expected.png:
* platform/mac/svg/custom/use-event-handler-on-use-element-expected.png:
* platform/mac/svg/custom/use-inherit-style-expected.png:
* platform/mac/svg/custom/use-instanceRoot-as-event-target-expected.png: Removed.
* platform/mac/svg/custom/use-instanceRoot-event-bubbling-expected.png:
* platform/mac/svg/custom/use-instanceRoot-event-listeners-expected.png:
* platform/mac/svg/custom/use-setAttribute-crash-expected.png:
* svg/custom/absolute-sized-content-with-resources.xhtml:
* svg/custom/animate-path-discrete.svg:
* svg/custom/animate-path-morphing.svg:
* svg/custom/animate-target-id-changed.svg:
* svg/custom/animate-target-removed-from-document.svg:
* svg/custom/circle-move-invalidation.svg:
* svg/custom/clip-path-child-changes.svg:
* svg/custom/clip-path-href-changes.svg:
* svg/custom/clip-path-id-changes.svg:
* svg/custom/clip-path-units-changes.svg:
* svg/custom/deep-dynamic-updates.svg:
* svg/custom/fill-opacity-update.svg:
* svg/custom/foreignObject-crash-on-hover.xml:
* svg/custom/gradient-add-stops.svg:
* svg/custom/gradient-stop-style-change.svg:
* svg/custom/hit-test-path-stroke.svg:
* svg/custom/hit-test-path.svg:
* svg/custom/hit-test-unclosed-subpaths.svg:
* svg/custom/hit-test-with-br.xhtml:
* svg/custom/js-late-clipPath-and-object-creation.svg:
* svg/custom/js-late-clipPath-creation.svg:
* svg/custom/js-late-gradient-and-object-creation.svg:
* svg/custom/js-late-gradient-creation.svg:
* svg/custom/js-late-marker-and-object-creation.svg:
* svg/custom/js-late-marker-creation.svg:
* svg/custom/js-late-mask-and-object-creation.svg:
* svg/custom/js-late-mask-creation.svg:
* svg/custom/js-late-pattern-and-object-creation.svg:
* svg/custom/js-late-pattern-creation.svg:
* svg/custom/js-repaint-rect-on-path-with-stroke.svg:
* svg/custom/js-update-bounce.svg:
* svg/custom/js-update-container.svg:
* svg/custom/js-update-container2.svg:
* svg/custom/js-update-gradient.svg:
* svg/custom/js-update-image.svg:
* svg/custom/js-update-path-changes.svg:
* svg/custom/js-update-path-removal.svg:
* svg/custom/js-update-pattern-child.svg:
* svg/custom/js-update-pattern.svg:
* svg/custom/js-update-polygon-changes.svg:
* svg/custom/js-update-polygon-removal.svg:
* svg/custom/js-update-stop-linked-gradient.svg:
* svg/custom/js-update-stop.svg:
* svg/custom/js-update-style.svg:
* svg/custom/js-update-transform-addition.svg:
* svg/custom/js-update-transform-changes.svg:
* svg/custom/linking-a-03-b-all.svg:
* svg/custom/linking-a-03-b-preserveAspectRatio.svg:
* svg/custom/linking-a-03-b-transform.svg:
* svg/custom/linking-a-03-b-viewBox-transform.svg:
* svg/custom/linking-a-03-b-viewBox.svg:
* svg/custom/linking-a-03-b-viewTarget.svg:
* svg/custom/linking-a-03-b-zoomAndPan.svg:
* svg/custom/marker-child-changes-css.svg:
* svg/custom/marker-child-changes.svg:
* svg/custom/marker-strokeWidth-changes.svg:
* svg/custom/marker-viewBox-changes.svg:
* svg/custom/mask-child-changes.svg:
* svg/custom/mask-invalidation.svg:
* svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml:
* svg/custom/pending-resource-after-removal-expected.png:
* svg/custom/pending-resource-after-removal.xhtml:
* svg/custom/pending-resource-leak-2.svg:
* svg/custom/pending-resource-leak-3.svg:
* svg/custom/prevent-default.svg:
* svg/custom/relative-sized-content-with-resources.xhtml:
* svg/custom/relative-sized-content.xhtml:
* svg/custom/relative-sized-deep-shadow-tree-content.xhtml:
* svg/custom/relative-sized-image.xhtml:
* svg/custom/relative-sized-inner-svg.xhtml:
* svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml:
* svg/custom/relative-sized-shadow-tree-content.xhtml:
* svg/custom/relative-sized-use-on-symbol.xhtml:
* svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml:
* svg/custom/repaint-moving-svg-and-div.xhtml:
* svg/custom/repaint-on-constant-size-change.svg:
* svg/custom/repaint-on-image-bounds-change.svg:
* svg/custom/repaint-shadow.svg:
* svg/custom/repaint-stroke-width-changes.svg:
* svg/custom/resource-client-removal.svg:
* svg/custom/resource-invalidate-on-target-update.svg:
* svg/custom/resources/use-instanceRoot-event-bubbling.js:
(repaintTest):
* svg/custom/resources/use-instanceRoot-event-listeners.js:
(repaintTest):
* svg/custom/scroll-hit-test.xhtml:
* svg/custom/scroll-to-anchor-in-symbol.svg:
* svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html:
* svg/custom/stroke-opacity-update.svg:
* svg/custom/svg-absolute-children.svg:
* svg/custom/svg-disallowed-in-dashboard-object.html:
* svg/custom/svg-fonts-in-html-linebreaks.html:
* svg/custom/text-dom-removal.svg:
* svg/custom/text-repaint-including-stroke.svg:
* svg/custom/text-xy-updates-SVGList.xhtml:
* svg/custom/use-animation-in-fill.html:
* svg/custom/use-clipped-hit.svg:
* svg/custom/use-crash-in-non-wellformed-document.svg:
* svg/custom/use-crash-when-href-change.svg:
* svg/custom/use-detach.svg:
* svg/custom/use-disappears-after-style-update.svg:
* svg/custom/use-elementInstance-event-target.svg:
* svg/custom/use-elementInstance-methods.svg:
* svg/custom/use-event-handler-on-referenced-element.svg:
* svg/custom/use-event-handler-on-use-element.svg:
* svg/custom/use-inherit-style.svg:
* svg/custom/use-instanceRoot-as-event-target.xhtml:
* svg/custom/use-instanceRoot-event-bubbling.xhtml:
* svg/custom/use-instanceRoot-event-listeners.xhtml:
* svg/custom/use-multiple-on-nested-disallowed-font.html:
* svg/custom/use-setAttribute-crash.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK baselines for new tests.
philn@webkit.org [Thu, 9 Feb 2012 10:28:29 +0000 (10:28 +0000)]
Unreviewed, GTK baselines for new tests.

* platform/gtk/fast/line-grid/line-grid-contains-value-expected.txt: Added.
* platform/gtk/fast/line-grid/line-grid-into-columns-expected.txt: Added.
* platform/gtk/svg/clip-path/clip-in-clip-expected.txt: Added.
* platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
* platform/gtk/svg/clip-path/clipper-placement-issue-expected.txt: Added.
* platform/gtk/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/gtk/svg/filters/feImage-change-target-id-expected.txt: Added.
* platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt: Added.
* platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Added.
* platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt: Added.
* platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt: Added.
* platform/gtk/svg/filters/feImage-late-indirect-update-expected.txt: Added.
* platform/gtk/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
* platform/gtk/svg/filters/feImage-position-expected.txt: Added.
* platform/gtk/svg/filters/feImage-remove-target-expected.txt: Added.
* platform/gtk/svg/filters/feImage-subregions-expected.txt: Added.
* platform/gtk/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.txt: Added.
* platform/gtk/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-add-to-document-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-attribute-change-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-changes-id-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-id-change-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-inline-style-change-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-property-change-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-reappend-to-document-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-remove-from-document-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-style-change-expected.txt: Added.
* platform/gtk/svg/filters/filter-placement-issue-expected.txt: Added.
* platform/gtk/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/gtk/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/gtk/svg/wicd/sizing-flakiness-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r107197.
rolandsteiner@chromium.org [Thu, 9 Feb 2012 10:21:42 +0000 (10:21 +0000)]
Unreviewed, rolling out r107197.
http://trac.webkit.org/changeset/107197
https://bugs.webkit.org/show_bug.cgi?id=77525

broke Chromium Linux

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkSelector):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
(WebCore):
(WebCore::SelectorChecker::checkOneSelector):
* css/SelectorChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r107182, r107186, r107189, r107191,
haraken@chromium.org [Thu, 9 Feb 2012 10:00:39 +0000 (10:00 +0000)]
Unreviewed, rolling out r107182, r107186, r107189, r107191,
and r107199.
http://trac.webkit.org/changeset/107182
http://trac.webkit.org/changeset/107186
http://trac.webkit.org/changeset/107189
http://trac.webkit.org/changeset/107191
http://trac.webkit.org/changeset/107199
https://bugs.webkit.org/show_bug.cgi?id=78200

Layout tests of JSC-related port are crashing

* Modules/gamepad/GamepadList.idl:
* Modules/intents/Intent.idl:
* bindings/js/JSDOMBinding.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateParametersCheck):
(NativeToJSValue):
(GenerateConstructorDefinition):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
(GenerateImplementationIndexer):
(RequiresCustomSignature):
(NativeToJSValue):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestInterface.idl:
* bindings/scripts/test/TestNamedConstructor.idl:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayInternal::fooCallback):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectInternal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectInternal::postMessageCallback):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetInternal::itemCallback):
(WebCore::TestEventTargetInternal::dispatchEventCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceInternal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerInternal::methodCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::optionsObjectCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::TestObjInternal::overloadedMethod6Callback):
(WebCore::TestObjInternal::overloadedMethod7Callback):
(WebCore::TestObjInternal::classMethodWithOptionalCallback):
(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjInternal::convert1Callback):
(WebCore::TestObjInternal::convert2Callback):
(WebCore::TestObjInternal::convert3Callback):
(WebCore::TestObjInternal::convert4Callback):
(WebCore::TestObjInternal::convert5Callback):
(WebCore::TestObjInternal::strictFunctionCallback):
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
* bindings/v8/V8Binding.h:
* bindings/v8/custom/V8BindingMacros.h:
* css/CSSCharsetRule.idl:
* css/CSSImportRule.idl:
* css/CSSMediaRule.idl:
* css/CSSPageRule.idl:
* css/CSSPrimitiveValue.idl:
* css/CSSRule.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleRule.idl:
* css/CSSStyleSheet.idl:
* css/CSSValue.idl:
* css/CSSValueList.idl:
* css/MediaList.idl:
* css/MediaQueryList.idl:
* css/MediaQueryListListener.idl:
* css/StyleMedia.idl:
* css/StyleSheet.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSMatrix.idl:
* dom/Attr.idl:
* dom/CharacterData.idl:
* dom/ClientRectList.idl:
* dom/Clipboard.idl:
* dom/CompositionEvent.idl:
* dom/CustomEvent.idl:
* dom/DOMImplementation.idl:
* dom/DOMStringList.idl:
* dom/DataTransferItem.idl:
* dom/DataTransferItemList.idl:
* dom/DeviceMotionEvent.idl:
* dom/DeviceOrientationEvent.idl:
* dom/Document.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Entity.idl:
* dom/Event.idl:
* dom/HashChangeEvent.idl:
* dom/KeyboardEvent.idl:
* dom/MessageEvent.idl:
* dom/MouseEvent.idl:
* dom/MutationEvent.idl:
* dom/MutationRecord.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeFilter.idl:
* dom/NodeList.idl:
* dom/Notation.idl:
* dom/OverflowEvent.idl:
* dom/ProcessingInstruction.idl:
* dom/Range.idl:
* dom/ShadowRoot.idl:
* dom/Text.idl:
* dom/TextEvent.idl:
* dom/TouchEvent.idl:
* dom/UIEvent.idl:
* dom/WheelEvent.idl:
* html/DOMFormData.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLAllCollection.idl:
* html/HTMLAudioElement.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLCollection.idl:
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTableRowElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLTextAreaElement.idl:
* html/TextTrackCue.idl:
* html/canvas/CanvasGradient.idl:
* html/canvas/CanvasRenderingContext2D.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/canvas/WebGLDebugShaders.idl:
* html/canvas/WebGLRenderingContext.idl:
* page/Console.idl:
* page/DOMSelection.idl:
* page/DOMWindow.idl:
* page/History.idl:
* page/Location.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:
* storage/IDBDatabase.idl:
* storage/IDBObjectStore.idl:
* storage/IDBRequest.idl:
* storage/Storage.idl:
* storage/StorageEvent.idl:
* svg/ElementTimeControl.idl:
* svg/SVGDocument.idl:
* svg/SVGElementInstanceList.idl:
* svg/SVGFEDropShadowElement.idl:
* svg/SVGFEGaussianBlurElement.idl:
* svg/SVGFEMorphologyElement.idl:
* svg/SVGFilterElement.idl:
* svg/SVGLocatable.idl:
* svg/SVGMarkerElement.idl:
* svg/SVGPathElement.idl:
* svg/SVGSVGElement.idl:
* svg/SVGStylable.idl:
* svg/SVGTests.idl:
* svg/SVGTextContentElement.idl:
* webaudio/AudioNode.idl:
* websockets/WebSocket.idl:
* workers/SharedWorker.idl:
* workers/WorkerContext.idl:
* xml/DOMParser.idl:
* xml/XMLHttpRequest.idl:
* xml/XMLSerializer.idl:
* xml/XPathEvaluator.idl:
* xml/XPathExpression.idl:
* xml/XPathNSResolver.idl:
* xml/XPathResult.idl:
* xml/XSLTProcessor.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, add chromium expectations for new tests added in r107160.
podivilov@chromium.org [Thu, 9 Feb 2012 09:55:51 +0000 (09:55 +0000)]
Unreviewed, add chromium expectations for new tests added in r107160.

* platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png:
* platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png:
* platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt:
* platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable adding a shadow root to elements having a dynamic built-in shadow root.
commit-queue@webkit.org [Thu, 9 Feb 2012 09:54:04 +0000 (09:54 +0000)]
Disable adding a shadow root to elements having a dynamic built-in shadow root.
https://bugs.webkit.org/show_bug.cgi?id=77935

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-09
Reviewed by Hajime Morita.

Source/WebCore:

We temporarily disable adding a shadow root in elements having a dynamic user agent shadow root.
These shadow roots are currently created using Element::ensureShadowRoot.
So we don't check the condition if a shadow root is created eaither using Element::ensureShadowRoot
or ShadowRoot::CreatingUserAgentShadowRoot is specified for ShadowRoot::create.

Test: fast/dom/shadow/shadow-disable.html

* dom/Element.cpp:
(WebCore::Element::ensureShadowRoot):
* dom/ShadowRoot.cpp:
(WebCore::allowsUserShadowRoot):
(WebCore):
(WebCore::ShadowRoot::create):
* dom/ShadowRoot.h:
(ShadowRoot):
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
  ShadowRoot::CreatingUserAgentShadowRoot is specified.
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement): ditto.
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree): ditto.
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree): ditto.
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree): ditto.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree): ditto.

LayoutTests:

* fast/dom/shadow/shadow-disable-expected.txt: Added.
* fast/dom/shadow/shadow-disable.html: Added.
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: hovering over element with :hover style halts inspector
apavlov@chromium.org [Thu, 9 Feb 2012 09:51:29 +0000 (09:51 +0000)]
Web Inspector: hovering over element with :hover style halts inspector
https://bugs.webkit.org/show_bug.cgi?id=78086

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/updates-throttled.html

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):

LayoutTests:

* inspector/styles/updates-throttled-expected.txt: Added.
* inspector/styles/updates-throttled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove http-equiv content-language parsing
commit-queue@webkit.org [Thu, 9 Feb 2012 09:50:06 +0000 (09:50 +0000)]
Improve http-equiv content-language parsing
https://bugs.webkit.org/show_bug.cgi?id=77724

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-02-09
Reviewed by Alexey Proskuryakov.

Add tests for mapping http-equiv content-language to -webkit-locale to cover dynamic changes to the meta
element and a comma-separated list of languages. The desired behavior of some of these is not yet decided, so
some of the tests currently fail and the expectations may change. See comments in bug and in the tests.

* fast/text/content-language-comma-separated-list-expected.txt: Added.
* fast/text/content-language-comma-separated-list.html: Added.
* fast/text/content-language-dynamically-added-expected.txt: Added.
* fast/text/content-language-dynamically-added.html: Added.
* fast/text/content-language-dynamically-changed-expected.txt: Added.
* fast/text/content-language-dynamically-changed.html: Added.
* fast/text/content-language-dynamically-removed-expected.txt: Added.
* fast/text/content-language-dynamically-removed.html: Added.
* fast/text/content-language-multiple.html: Fix to actually test http-equiv content-language.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix build failure caused by r107191.
haraken@chromium.org [Thu, 9 Feb 2012 09:46:17 +0000 (09:46 +0000)]
Unreviewed. Fix build failure caused by r107191.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-09 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 9 Feb 2012 09:42:47 +0000 (09:42 +0000)]
2012-02-09  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, gardening, remove stale chromium expectations for synthetic-bold-transformed.

        * platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Removed.
        * platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-09 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Thu, 9 Feb 2012 09:36:24 +0000 (09:36 +0000)]
2012-02-09  Roland Steiner  <rolandsteiner@chromium.org>

        SelectorChecker::checkSelector: move parameters into a struct
        https://bugs.webkit.org/show_bug.cgi?id=77525

        Added 'SelectorCheckingContext' struct to hold parameters for the function.
        Adapted calling sites.

        Reviewed by Antti Koivisto.

        No new tests. (refactoring)

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::checkSelector):
        * css/SelectorChecker.cpp:
        (WebCore::SelectorChecker::checkSelector):
        (WebCore):
        (WebCore::SelectorChecker::checkOneSelector):
        * css/SelectorChecker.h:
        (SelectorCheckingContext):
        (WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
        (SelectorChecker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDo not localize numbers in scientific notation
tkent@chromium.org [Thu, 9 Feb 2012 09:33:54 +0000 (09:33 +0000)]
Do not localize numbers in scientific notation
https://bugs.webkit.org/show_bug.cgi?id=78208

Reviewed by Hajime Morita.

.:

* ManualTests/input-number-localization.html: Updated for scientific notation.

Source/WebCore:

For a preparation of fixing http://wkb.ug/62939, we stop supporting
localized numbers in scientific notation in <input type=number>.

We're going to change number localization processing so that it replaces
letters one by one. It will be very hard to support scientific notation.

* html/NumberInputType.cpp:
(WebCore::isE): A helper functio for String::find() to detect scientific notation.
(WebCore::NumberInputType::visibleValue): Avoid localization for scientific notation.
(WebCore::NumberInputType::convertFromVisibleValue): ditto.
(WebCore::NumberInputType::isAcceptableValue):
Use convertFromVisibleValue, also stop accepting a standard format as a fallback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agokill-old-processes should kill gcc and clang
rniwa@webkit.org [Thu, 9 Feb 2012 09:18:37 +0000 (09:18 +0000)]
kill-old-processes should kill gcc and clang
https://bugs.webkit.org/show_bug.cgi?id=78189

Reviewed by Eric Seidel.

Added a bunch of processes names of gcc and clang to the list.

* BuildSlaveSupport/kill-old-processes:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEntryBase.cpp is missing in CMake build system when turning on ENABLE_FILE_SYSTEM
leo.yang@torchmobile.com.cn [Thu, 9 Feb 2012 09:05:44 +0000 (09:05 +0000)]
EntryBase.cpp is missing in CMake build system when turning on ENABLE_FILE_SYSTEM
https://bugs.webkit.org/show_bug.cgi?id=78190

Reviewed by Antonio Gomes.

EntryBase.cpp is not in the CMake build system, which causes build failure (undefined
symbols to EntryBase) when turning on ENABLE_FILE_SYSTEM.

Build system fix, no new tests.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r53878): Input elements don't share their styles if the document contains...
kling@webkit.org [Thu, 9 Feb 2012 09:03:38 +0000 (09:03 +0000)]
REGRESSION(r53878): Input elements don't share their styles if the document contains no validity style rules.
<http://webkit.org/b/69400>

Reviewed by Kent Tamura.

Don't reject style sharing candidates prematurely just because the document doesn't
have any :valid or :invalid selectors.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test_expectations change.
mikelawther@chromium.org [Thu, 9 Feb 2012 09:03:31 +0000 (09:03 +0000)]
Unreviewed test_expectations change.

[chromium] remove expectation for css3/calc/block-mask-overlay-image-outset.html
https://bugs.webkit.org/show_bug.cgi?id=78183

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Fcalc%2Fblock-mask-overlay
shows this test has not failed as far back as its history is recorded.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fixed typo in the following files. [TreatUndefinedAs] => [TreatAsUndefined].
haraken@chromium.org [Thu, 9 Feb 2012 08:55:51 +0000 (08:55 +0000)]
Unreviewed. Fixed typo in the following files. [TreatUndefinedAs] => [TreatAsUndefined].

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):

* bindings/scripts/test/TestObj.idl:

* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::methodWithOptionalIsUndefinedString):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_with_optional_is_undefined_string):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsUndefinedString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsNullStringString):
(WebCore::jsTestObjPrototypeFunctionConvert5):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj methodWithOptionalIsUndefinedString:]):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::methodWithOptionalIsUndefinedStringCallback):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMAKE] Change lowercase variable with uppercase's.
gyuyoung.kim@samsung.com [Thu, 9 Feb 2012 08:50:46 +0000 (08:50 +0000)]
[CMAKE] Change lowercase variable with uppercase's.
https://bugs.webkit.org/show_bug.cgi?id=78198

Reviewed by Daniel Bates.

CMake variable is only written by uppercase.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fixed typo in the following files. [TreatReturnedNullStringTo=] => [Treat...
haraken@chromium.org [Thu, 9 Feb 2012 08:16:25 +0000 (08:16 +0000)]
Unreviewed. Fixed typo in the following files. [TreatReturnedNullStringTo=] => [TreatReturnedNullStringAs=].

* bindings/scripts/test/TestObj.idl:
* css/CSSCharsetRule.idl:
* css/CSSImportRule.idl:
* css/CSSPageRule.idl:
* css/CSSRule.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleRule.idl:
* css/CSSValue.idl:
* css/MediaList.idl:
* css/StyleSheet.idl:
* css/WebKitCSSKeyframesRule.idl:
* dom/Attr.idl:
* dom/CharacterData.idl:
* dom/Clipboard.idl:
* dom/DOMStringList.idl:
* dom/Document.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Entity.idl:
* dom/MutationRecord.idl:
* dom/Node.idl:
* dom/Notation.idl:
* dom/ProcessingInstruction.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLMediaElement.idl:
* html/canvas/WebGLDebugShaders.idl:
* html/canvas/WebGLRenderingContext.idl:
* page/DOMWindow.idl:
* storage/IDBObjectStore.idl:
* storage/IDBRequest.idl:
* storage/Storage.idl:
* storage/StorageEvent.idl:
* websockets/WebSocket.idl:
* xml/XMLHttpRequest.idl:
* xml/XPathNSResolver.idl:
* xml/XSLTProcessor.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline.
philn@webkit.org [Thu, 9 Feb 2012 07:58:09 +0000 (07:58 +0000)]
Unreviewed, GTK rebaseline.

* platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
* platform/gtk/fast/forms/select-overflow-scroll-expected.txt:
* platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt:
* platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a typo for r107125
commit-queue@webkit.org [Thu, 9 Feb 2012 07:52:38 +0000 (07:52 +0000)]
Fix a typo for r107125
https://bugs.webkit.org/show_bug.cgi?id=77804

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-08
Reviewed by James Robinson.

* tests/WebCompositorInputHandlerImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
haraken@chromium.org [Thu, 9 Feb 2012 07:20:19 +0000 (07:20 +0000)]
Rename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
https://bugs.webkit.org/show_bug.cgi?id=78108

Reviewed by Adam Barth.

[ConvertNullStringTo=] is not descriptive. To clarify that it specifies
the behavior when the null string is returned by WebCore, this patch renames
[ConvertNullStringTo=] to [TreatReturnedNullStringAs=]. This change is also
for naming consistency with [TreatNullAs] and [TreatUndefinedAs].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementationIndexer):
(NativeToJSValue):

* bindings/scripts/test/TestObj.idl: No change in run-bindings-tests results.

* css/CSSCharsetRule.idl:
* css/CSSImportRule.idl:
* css/CSSPageRule.idl:
* css/CSSRule.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleRule.idl:
* css/CSSValue.idl:
* css/MediaList.idl:
* css/StyleSheet.idl:
* css/WebKitCSSKeyframesRule.idl:
* dom/Attr.idl:
* dom/CharacterData.idl:
* dom/Clipboard.idl:
* dom/DOMStringList.idl:
* dom/Document.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Entity.idl:
* dom/MutationRecord.idl:
* dom/Node.idl:
* dom/Notation.idl:
* dom/ProcessingInstruction.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLMediaElement.idl:
* html/canvas/WebGLDebugShaders.idl:
* html/canvas/WebGLRenderingContext.idl:
* page/DOMWindow.idl:
* storage/IDBObjectStore.idl:
* storage/IDBRequest.idl:
* storage/Storage.idl:
* storage/StorageEvent.idl:
* websockets/WebSocket.idl:
* xml/XMLHttpRequest.idl:
* xml/XPathNSResolver.idl:
* xml/XSLTProcessor.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify ownership of StyledElement::additionalAttributeStyles().
kling@webkit.org [Thu, 9 Feb 2012 07:14:55 +0000 (07:14 +0000)]
Simplify ownership of StyledElement::additionalAttributeStyles().
<http://webkit.org/b/78204>

Reviewed by Anders Carlsson.

Change additionalAttributeStyle() to return a raw pointer rather than a PassRefPtr.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
* dom/StyledElement.h:
(WebCore::StyledElement::additionalAttributeStyle):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyle):
* html/HTMLTableCellElement.h:
(HTMLTableCellElement):
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyle):
* html/HTMLTableColElement.h:
(HTMLTableColElement):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):
* html/HTMLTableElement.h:
(HTMLTableElement):
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyle):
* html/HTMLTableSectionElement.h:
(HTMLTableSectionElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[PerformanceTests] sunspider-crypto-md5.html and sunspider-crypto-sha1.html are timin...
commit-queue@webkit.org [Thu, 9 Feb 2012 07:14:24 +0000 (07:14 +0000)]
[PerformanceTests] sunspider-crypto-md5.html and sunspider-crypto-sha1.html are timing out on cr-mac perf bot
https://bugs.webkit.org/show_bug.cgi?id=78174

Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-08
Reviewed by Ryosuke Niwa.

Pulled back removed files.

* Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-md5.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-sha1.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry...
commit-queue@webkit.org [Thu, 9 Feb 2012 07:02:04 +0000 (07:02 +0000)]
[BlackBerry] Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry and IconDatabaseClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=78049

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-08
Reviewed by Rob Buis.

Initial upstream, no new tests.

* blackberry/WebCoreSupport/FrameNetworkingContextBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/FrameNetworkingContextBlackBerry.h: Added.
* blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [Optional=CallWithDefalutValue] and [Optional=CallWithNullValue]
haraken@chromium.org [Thu, 9 Feb 2012 06:58:35 +0000 (06:58 +0000)]
Rename [Optional=CallWithDefalutValue] and [Optional=CallWithNullValue]
https://bugs.webkit.org/show_bug.cgi?id=78200

Reviewed by Adam Barth.

[Optional=CallWithDefalutValue] and [Optional=CallWithNullValue] are confusing.

- [Optional=CallWithDefalutValue] indicates that a missing value should be treated
as if the JavaScript undefined is passed.
- [Optional=CallWithNullValue] indicates that a missing value should be treated as
the WebKit null value (i.e. JSValue() or v8::Local<v8::Value>()).
- Actually, the difference between [Optional=CallWithDefalutValue] and
[Optional=CallWithNullValue] appears only when the type of the missing value is DOMString.
In case of [Optional=CallWithDefalutValue], the missing value is converted to the string
"undefined". On the other hand, in case of [Optional=CallWithNullValue], the missing
value is converted to the WebKit null string.

With these observations, this patch renames them as follows:

- Rename [Optional=CallWithDefalutValue] to [Optional=TreatAsUndefined].
- Remove [Optional=CallWithNullValue]. Instead, we use
[Optional=TreatAsUndefined, TreatUndefinedAs=NullString].

Test: bindings/scripts/test/TestInterface.idl

* bindings/js/JSDOMBinding.h: Renamed MissingIsUndefined to MissingIsUndefinedValue,
renamed MissingIsEmpty to MissingIsNullValue.
* bindings/v8/V8Binding.h: Ditto.
* bindings/v8/custom/V8BindingMacros.h: Ditto.

* bindings/scripts/CodeGeneratorJS.pm: Modified to support the IDL attribute renaming.
(GenerateParametersCheck):
(GenerateConstructorDefinition):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateParametersCheck):
(RequiresCustomSignature):

* Modules/gamepad/GamepadList.idl: Renamed IDL attributes as described above.
* Modules/intents/Intent.idl:
* css/CSSMediaRule.idl:
* css/CSSPrimitiveValue.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleSheet.idl:
* css/CSSValueList.idl:
* css/MediaList.idl:
* css/MediaQueryList.idl:
* css/MediaQueryListListener.idl:
* css/StyleMedia.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSMatrix.idl:
* dom/CharacterData.idl:
* dom/ClientRectList.idl:
* dom/CompositionEvent.idl:
* dom/CustomEvent.idl:
* dom/DOMImplementation.idl:
* dom/DOMStringList.idl:
* dom/DataTransferItem.idl:
* dom/DataTransferItemList.idl:
* dom/DeviceMotionEvent.idl:
* dom/DeviceOrientationEvent.idl:
* dom/Document.idl:
* dom/Element.idl:
* dom/Event.idl:
* dom/HashChangeEvent.idl:
* dom/KeyboardEvent.idl:
* dom/MessageEvent.idl:
* dom/MouseEvent.idl:
* dom/MutationEvent.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeFilter.idl:
* dom/NodeList.idl:
* dom/OverflowEvent.idl:
* dom/Range.idl:
* dom/ShadowRoot.idl:
* dom/Text.idl:
* dom/TextEvent.idl:
* dom/TouchEvent.idl:
* dom/UIEvent.idl:
* dom/WheelEvent.idl:
* html/DOMFormData.idl:
* html/HTMLAllCollection.idl:
* html/HTMLAudioElement.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLCollection.idl:
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTableRowElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLTextAreaElement.idl:
* html/TextTrackCue.idl:
* html/canvas/CanvasGradient.idl:
* html/canvas/CanvasRenderingContext2D.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* page/Console.idl:
* page/DOMSelection.idl:
* page/DOMWindow.idl:
* page/History.idl:
* page/Location.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:
* storage/IDBDatabase.idl:
* storage/StorageEvent.idl:
* svg/ElementTimeControl.idl:
* svg/SVGDocument.idl:
* svg/SVGElementInstanceList.idl:
* svg/SVGFEDropShadowElement.idl:
* svg/SVGFEGaussianBlurElement.idl:
* svg/SVGFEMorphologyElement.idl:
* svg/SVGFilterElement.idl:
* svg/SVGLocatable.idl:
* svg/SVGMarkerElement.idl:
* svg/SVGPathElement.idl:
* svg/SVGSVGElement.idl:
* svg/SVGStylable.idl:
* svg/SVGTests.idl:
* svg/SVGTextContentElement.idl:
* webaudio/AudioNode.idl:
* workers/SharedWorker.idl:
* workers/WorkerContext.idl:
* xml/DOMParser.idl:
* xml/XMLSerializer.idl:
* xml/XPathEvaluator.idl:
* xml/XPathExpression.idl:
* xml/XPathNSResolver.idl:
* xml/XPathResult.idl:

* bindings/scripts/test/TestInterface.idl: Added test cases for [Optional],
[Optional=TreatAsUndefined] and [Optional=TreatAsUndefined, TreatUndefinedAs=NullString]
* bindings/scripts/test/TestNamedConstructor.idl: Renamed IDL attributes as described above.
* bindings/scripts/test/TestObj.idl: Ditto.

* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::methodWithOptionalString):
(WebDOMTestObj::methodWithOptionalIsTreatAsUndefinedString):
(WebDOMTestObj::methodWithOptionalIsNullStringString):
* bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
(webkit_dom_test_obj_method_with_optional_string):
(webkit_dom_test_obj_method_with_optional_is_treat_as_undefined_string):
(webkit_dom_test_obj_method_with_optional_is_null_string_string):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
* bindings/scripts/test/JS/JSFloat64Array.cpp: Ditto.
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Ditto.
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
* bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
* bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
(WebCore):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsTreatAsUndefinedString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsNullStringString):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
* bindings/scripts/test/JS/JSTestObj.h: Ditto.
(WebCore):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
* bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
(-[DOMTestObj methodWithOptionalString:]):
(-[DOMTestObj methodWithOptionalIsTreatAsUndefinedString:]):
(-[DOMTestObj methodWithOptionalIsNullStringString:]):
* bindings/scripts/test/V8/V8Float64Array.cpp: Ditto.
(WebCore::Float64ArrayInternal::fooCallback):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Ditto.
(WebCore::TestActiveDOMObjectInternal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectInternal::postMessageCallback):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto.
(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
* bindings/scripts/test/V8/V8TestEventTarget.cpp: Ditto.
(WebCore::TestEventTargetInternal::itemCallback):
(WebCore::TestEventTargetInternal::dispatchEventCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore::TestInterfaceInternal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Ditto.
(WebCore::TestMediaQueryListListenerInternal::methodCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp: Ditto.
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::optionsObjectCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithOptionalStringCallback):
(TestObjInternal):
(WebCore::TestObjInternal::methodWithOptionalIsTreatAsUndefinedStringCallback):
(WebCore::TestObjInternal::methodWithOptionalIsNullStringStringCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::TestObjInternal::overloadedMethod6Callback):
(WebCore::TestObjInternal::overloadedMethod7Callback):
(WebCore::TestObjInternal::classMethodWithOptionalCallback):
(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjInternal::convert1Callback):
(WebCore::TestObjInternal::convert2Callback):
(WebCore::TestObjInternal::convert3Callback):
(WebCore::TestObjInternal::convert4Callback):
(WebCore::TestObjInternal::convert5Callback):
(WebCore::TestObjInternal::strictFunctionCallback):
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Ditto.
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename [HasNumericIndexGetter] to [NumericIndexedGetter]
haraken@chromium.org [Thu, 9 Feb 2012 06:43:18 +0000 (06:43 +0000)]
Rename [HasNumericIndexGetter] to [NumericIndexedGetter]
https://bugs.webkit.org/show_bug.cgi?id=78096

Reviewed by Adam Barth.

This patch renames [HasNumericIndexGetter] to [NumericIndexedGetter],
for naming consistency with [IndexedGetter] and [CustomIndexedGetter].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):

* bindings/scripts/test/TestTypedArray.idl: No change in run-bindings-tests results.

* html/canvas/CanvasPixelArray.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][EFL] creating dummy class derived from ResourceHandleClient for Efl download...
commit-queue@webkit.org [Thu, 9 Feb 2012 06:12:47 +0000 (06:12 +0000)]
[WK2][EFL] creating dummy class derived from ResourceHandleClient for Efl download module.
https://bugs.webkit.org/show_bug.cgi?id=76171

Patch by Keunsoon Lee <keunsoon.lee@samsung.com> on 2012-02-08
Reviewed by Andreas Kling.

FileDownloaderEfl is a practical class to operate file download.
It communicates with Download class to start download
and to notify downloading states to user(e.g. client application).
Besides FileDownloaderEfl derives from ResourceHandleClient
and receives chunked data from ResourceHandle directly
or redirects data flow which is started from MainResourceLoader
by mean of exchanging ResourceHandle's existing client for FileDownloaderEfl.

This patch has only dummy functions to make easy to review.
Working patch will be uploaded on another bug thread.

* PlatformEfl.cmake: added new file to compile.
* WebProcess/Downloads/Download.h: added FileDownloaderEfl's instance as a form of OwnPtr<FileDownloaderEfl>.
(WebKit):
(Download):
* WebProcess/Downloads/efl/DownloadEfl.cpp:
(WebKit::Download::start): calling to FileDownloaderEfl::start() to start download for passing ResourceRequest.
* WebProcess/Downloads/efl/FileDownloaderEfl.cpp: Added. a practical class to operate file download.
(WebKit):
(WebKit::FileDownloaderEfl::create): create function, which returns PassOwnPtr<FileDownloaderEfl>.
(WebKit::FileDownloaderEfl::FileDownloaderEfl): constructor, which receives Download* as a parameter.
(WebKit::FileDownloaderEfl::~FileDownloaderEfl): deconstructor.
(WebKit::FileDownloaderEfl::start): a function to start downloading for passed ResourceRequest.
It does nothing for now, but shows how Download class can call FileDownloaderEfl's function.
(WebKit::FileDownloaderEfl::didReceiveResponse): virtual function for ResourceHandleClient.
It will receive response header information from ResourceHandle.
(WebKit::FileDownloaderEfl::didReceiveData): virtual function for ResourceHandleClient.
It will receive chunk data from ResourceHandle.
(WebKit::FileDownloaderEfl::didFinishLoading): virtual function for ResourceHandleClient.
It will be notified loading is finished from ResourceHandle.
(WebKit::FileDownloaderEfl::didFail): virtual function for ResourceHandleClient.
It will be notified loading is fail with ResourceError from ResourceHandle.
(WebKit::FileDownloaderEfl::shouldUseCredentialStorage): virtual function for ResourceHandleClient.
It returns whether to use credential storage or not.
(WebKit::FileDownloaderEfl::didReceiveAuthenticationChallenge): virtual function for ResourceHandleClient.
It will receive AuthenticationChallenge.
(WebKit::FileDownloaderEfl::didCancelAuthenticationChallenge): virtual function for ResourceHandleClient.
It will be notified AuthenticationChallenge is canceled.
(WebKit::FileDownloaderEfl::receivedCancellation): virtual function for ResourceHandleClient.
* WebProcess/Downloads/efl/FileDownloaderEfl.h: Added.
(WebCore):
(WebKit):
(FileDownloaderEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorefactor RenderFlexibleBox to return preferred sizes of all children
tony@chromium.org [Thu, 9 Feb 2012 05:57:14 +0000 (05:57 +0000)]
refactor RenderFlexibleBox to return preferred sizes of all children
https://bugs.webkit.org/show_bug.cgi?id=78169

Reviewed by Ojan Vafai.

This is in preparation for multi-line flexbox. We need the preferred
size of each child so we can compute where the multi-line breaks happen.

No new tests, just refactoring.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Renamed from preferredMainAxisContentExtentForFlexItem because
other methods are ForChild rather than ForFlexItem.
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop calling Element::ensureShadowRoot() if it is used in construction phase.
morrita@google.com [Thu, 9 Feb 2012 05:46:57 +0000 (05:46 +0000)]
Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-08
Reviewed by Hajime Morita.

ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.

No new tests, no change in behavior.

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
  Initialize exception code before calling appendChild.
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Avoid unnecessary full tile updates without breaking atomicity of commits.
commit-queue@webkit.org [Thu, 9 Feb 2012 05:26:00 +0000 (05:26 +0000)]
[Chromium] Avoid unnecessary full tile updates without breaking atomicity of commits.
https://bugs.webkit.org/show_bug.cgi?id=76740

Patch by David Reveman <reveman@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebCore:

Allow the final batch of texture uploads to be performed without
allocating new textures and re-painting complete tiles.

This patch is tested by the following unit test:
- CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread
- TiledLayerChromiumTest.partialUpdates

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::UpdatableTile):
(UpdatableTile):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::tileNeedsBufferedUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::requestPartialTextureUpdate):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::CCSingleThreadProxy::maxPartialTextureUpdates):
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::append):
(WebCore):
(WebCore::CCTextureUpdater::appendPartial):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):
* platform/graphics/chromium/cc/CCTextureUpdater.h:
(CCTextureUpdater):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WTF):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::maxPartialTextureUpdates):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

Add CCLayerTreeHostTestAtomicCommitWithPartialUpdate and
TiledLayerChromiumTest.partialUpdates tests that verifies
atomicity of commits with partial updates.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WTF::CCLayerTreeHostTestAtomicCommit::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::layout):
(CCLayerTreeHostTestAtomicCommit):
(CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::layout):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::afterTest):
(WTF):
(WTF::TEST_F):
* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeLayerTextureUpdater::Texture::Texture):
(WTF::FakeLayerTextureUpdater::Texture::updateRect):
(Texture):
(WTF::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(FakeLayerTextureUpdater):
(WTF::FakeLayerTextureUpdater::updateCount):
(WTF::FakeLayerTextureUpdater::clearUpdateCount):
(WTF::FakeLayerTextureUpdater::updateRect):
(WTF::FakeLayerTextureUpdater::createTexture):
(FakeTiledLayerChromium):
(WTF::TEST):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplacement text should be available from the marker.
morrita@google.com [Thu, 9 Feb 2012 05:23:21 +0000 (05:23 +0000)]
Replacement text should be available from the marker.
https://bugs.webkit.org/show_bug.cgi?id=77934

.:

Reviewed by Kent Tamura.

* Source/autotools/symbols.filter: Added an exporting symbol.

Source/WebCore:

Reviewed by Kent Tamura.

On spellchecking, TextCheckingResult can contain a replacement text
which is usable both for an automatic replacement and for showing a suggestion.

But when marking a misspelled word ragarding to returned
TextCheckingResult, Editor uses only the misspelled range data and
discards the replacement value. Then it asks the same value again
when showing suggestion/autocorrection.

It would be great if the marker holds the replacement text
and Editor can use it on suggesting a correction, without any re-request.
This is especially true in the case when it needs IPC messaging for spellchecking:
We can save one round-trip by this technique.

Here is actual change:

- Passed the replacement text to addMarker() for for misspelling markers.
  Note that this is done only for the unified checker path because legacy
  TextCheckerClient API doesn't provide such a replacement.
- Added an Internals API to retrieve a description text on a marker.

Test: editing/spelling/spelling-marker-description.html

* WebCore.exp.in:
* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
* testing/Internals.cpp:
(WebCore::Internals::markerAt):
(WebCore):
(WebCore::Internals::markerRangeForNode):
(WebCore::Internals::markerDescriptionForNode):
* testing/Internals.h:
(WebCore):
(Internals):
* testing/Internals.idl:

Source/WebKit/chromium:

didFinishCheckingText() accidentally dropped the description text
given from the backend. Fixed to copy it on the API-to-Core
convertion. The test won't work without this fix.

Reviewed by Kent Tamura.

* src/WebTextCheckingCompletionImpl.cpp:
(WebKit::toCoreResults):

Source/WebKit/win:

Reviewed by Kent Tamura.

* WebKit.vcproj/WebKit_Cairo.def:
* WebKit.vcproj/WebKit_Cairo_debug.def:

Source/WebKit2:

Reviewed by Kent Tamura.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

Tools:

Made the mock requestCheckingOfText() implementation to return
a replacement text for each misspelled word if available.

Reviewed by Kent Tamura.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::finishLastTextCheck):

LayoutTests:

Reviewed by Kent Tamura.

* editing/spelling/spelling-marker-description-expected.txt: Added.
* editing/spelling/spelling-marker-description.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove more cruft now that HTMLIsIndexElement is gone
eric@webkit.org [Thu, 9 Feb 2012 05:06:36 +0000 (05:06 +0000)]
Remove more cruft now that HTMLIsIndexElement is gone
https://bugs.webkit.org/show_bug.cgi?id=77887

Reviewed by Darin Adler.

Just removing dead code, thus no tests.
There is likely more to remove after this.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLInputElement.cpp:
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
(WebCore::createInputTypeFactoryMap):
* html/InputType.h:
(InputTypeNames):
* html/IsIndexInputType.cpp: Removed.
* html/IsIndexInputType.h: Removed.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isContentEditable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8][Chromium] Race between worker accessing WebDatabase and frame closing down.
commit-queue@webkit.org [Thu, 9 Feb 2012 04:49:08 +0000 (04:49 +0000)]
[V8][Chromium] Race between worker accessing WebDatabase and frame closing down.
https://bugs.webkit.org/show_bug.cgi?id=78150
Handle case when the frame is shut down under us gracefully.

Patch by Dmitry Lomov <dslomov@chromium.org> on 2012-02-08
Reviewed by David Levin.

* src/DatabaseObserver.cpp:
(WebCore::DatabaseObserver::canEstablishDatabase): Handle WebWorkerBase::view returning 0.
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::openFromWorker): Handle WebWorkerBase::view returning 0.
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::allowDatabase):
(WebKit::WebWorkerClientImpl::view):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncreased style sharing for elements with presentation attributes.
kling@webkit.org [Thu, 9 Feb 2012 04:41:19 +0000 (04:41 +0000)]
Increased style sharing for elements with presentation attributes.
<http://webkit.org/b/78199>

Reviewed by Antti Koivisto.

When determining whether two elements can share style, we can do a lot better.
Instead of comparing the attribute maps for exact equality, do a property-by-property
comparison of the attributeStyle() and the additionalAttributeStyle() (if any.)

This increases our style sharing hit rate and shaves 100ms off of each cycle on
Chromium's "Moz" page cycler test on my machine.

The function that compares attribute styles has O(n^2) runtime in the worst case,
where n is the number of properties in the styles. However, given the low number of
properties found in attribute styles, this should be fine, and it doesn't seem to
heat up in profiles.

* css/CSSStyleSelector.cpp:
(WebCore::attributeStylesEqual):
(WebCore::CSSStyleSelector::canShareStyleWithElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the caculation of preDelayFrames in DynamicsCompressorKernel
commit-queue@webkit.org [Thu, 9 Feb 2012 04:34:38 +0000 (04:34 +0000)]
Fix the caculation of preDelayFrames in DynamicsCompressorKernel
https://bugs.webkit.org/show_bug.cgi?id=78057

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-08
Reviewed by Chris Rogers.

No new tests required.

* platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::setPreDelayTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
commit-queue@webkit.org [Thu, 9 Feb 2012 04:04:54 +0000 (04:04 +0000)]
[Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
https://bugs.webkit.org/show_bug.cgi?id=78146

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-02-08
Reviewed by Ryosuke Niwa.

Our DumpRenderTree should support --no-timeout and --timeout options in order
to be able to use run-perf-tests and have a Performance Bot.
This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
and the necessary code to handle such command line arguments to our DumpRenderTree.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::setTimeout):
(WebCore):
(WebCore::DumpRenderTree::setShouldTimeout):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::waitUntilDone):
(LayoutTestController::notifyDone):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::setTimeout):
(LayoutTestController::setShouldTimeout):
(LayoutTestController):
* DumpRenderTree/qt/main.cpp:
(isOption):
(printUsage):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDOM mutations should not be delivered on worker threads
adamk@chromium.org [Thu, 9 Feb 2012 03:34:29 +0000 (03:34 +0000)]
DOM mutations should not be delivered on worker threads
https://bugs.webkit.org/show_bug.cgi?id=77898

Reviewed by Dmitry Titov.

Source/WebCore:

In V8RecursionScope, only call WebKitMutationObserver::deliverAllMutations
if in a Document context.

This is accomplished through a change to V8Proxy::instrumentedCallFunction
(which now takes a Frame* instead of a Page*), requiring an update to all
callers of that function (accounting for the majority of files changed
in this patch).

Added ASSERT(isMainThread()) in a deliverAllMutations to confirm that
it's no longer called on worker threads, and in enqueueMutationRecord,
where the same global store of active observers is accessed.

See also http://crbug.com/112586, where the problem was initially
reported.

* bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptCallback::call):
* bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::instrumentedCallFunction):
* bindings/v8/V8Proxy.h:
(WebCore):
(V8Proxy):
* bindings/v8/V8RecursionScope.cpp:
(WebCore::V8RecursionScope::didLeaveScriptContext):
* bindings/v8/V8RecursionScope.h:
(WebCore):
(WebCore::V8RecursionScope::V8RecursionScope):
(V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):
* bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
* bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):
* bindings/v8/custom/V8CustomXPathNSResolver.cpp:
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::enqueueMutationRecord):
(WebCore::WebKitMutationObserver::deliverAllMutations):

Source/WebKit/chromium:

* src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream InspectorClientBlackBerry.{h, cpp}
leo.yang@torchmobile.com.cn [Thu, 9 Feb 2012 03:20:41 +0000 (03:20 +0000)]
[BlackBerry] Upstream InspectorClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=78082

Reviewed by Rob Buis.

Initial upstream, no new tests.

* blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/InspectorClientBlackBerry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't use the wheel event handler count to track if a page has horizontal scrollbars
andersca@apple.com [Thu, 9 Feb 2012 03:02:25 +0000 (03:02 +0000)]
Don't use the wheel event handler count to track if a page has horizontal scrollbars
https://bugs.webkit.org/show_bug.cgi?id=78192

Reviewed by Andreas Kling.

Source/WebCore:

Stop calling Document::didAddWheelEventHandler and Document::didRemoveWheelEventHandler when
adding and removing scrollbars.

* page/FrameView.cpp:
* page/FrameView.h:
(FrameView):
* rendering/RenderLayer.cpp:
* rendering/RenderLayer.h:

Source/WebKit2:

Prior to this change, we were incrementing and decrementing the wheel event handler count
whenever a scrollable area gained or lost a horizontal scrollbar, so we could use the count
to determine if Safari can handle horizontal wheel events directly or whether they have to be sent
to the web process first.

What this meant was that whenever a page had horizontal scrollbars we'd have to send all scroll wheel events
to the main thread instead of the scrolling thread, regardless of whether there were any wheel event handlers.

After this change, we traverse the tree of scrollable areas after every layout and check if any of them
have a horizontal scrollbar. (We still also check if there are wheel event handlers).

If traversing the tree after every layout is deemed to slow we can go back to caching the number of horizontal scrollbars
in a page, but the number of subframes in a page is usually very small and the number of other scrollable areas is even smaller.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::willHandleHorizontalScrollEvents):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::setCanShortCircuitHorizontalWheelEvents):
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::numWheelEventHandlersChanged):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::numWheelEventHandlersChanged):
(WebKit):
(WebKit::hasEnabledHorizontalScrollbar):
(WebKit::pageContainsAnyHorizontalScrollbars):
(WebKit::WebPage::recomputeShortCircuitHorizontalWheelEventsState):
* WebProcess/WebPage/WebPage.h:
(WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll Chromium DEPS
commit-queue@webkit.org [Thu, 9 Feb 2012 02:45:47 +0000 (02:45 +0000)]
Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=78152

Patch by Scott Graham <scottmg@chromium.org> on 2012-02-08
Reviewed by Adam Barth.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRubber-stamped by Martin Robinson.
kov@webkit.org [Thu, 9 Feb 2012 02:38:47 +0000 (02:38 +0000)]
Rubber-stamped by Martin Robinson.

* gtk/common.py:
(get_build_path): Move test for current directory being a valid
directory up so it takes precedence over WebKitBuild/Release and
WebKitBuild/Debug when they exist as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] doc rebasing does not respect DESTDIR
kov@webkit.org [Thu, 9 Feb 2012 02:28:31 +0000 (02:28 +0000)]
[GTK] doc rebasing does not respect DESTDIR
https://bugs.webkit.org/show_bug.cgi?id=78177

Reviewed by Martin Robinson.

* GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
calling it for rebasing.
* gtk/generate-gtkdoc:
(get_common_options): Handle the new --virtual-root option.
* gtk/gtkdoc.py:
(GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Implement reverse animation direction
igor.o@sisa.samsung.com [Thu, 9 Feb 2012 02:07:11 +0000 (02:07 +0000)]
Source/WebCore: Implement reverse animation direction

Implement reverse animation direction
https://bugs.webkit.org/show_bug.cgi?id=60525

Implement reverse and alternate-reverse direction.

Reviewed by Dean Jackson.

Tests: animations/animation-direction-alternate-reverse.html
       animations/animation-direction-reverse.html
       animations/fill-mode-reverse.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationDirection):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapAnimationDirection):
* css/CSSValueKeywords.in:
* page/WebKitAnimation.cpp:
(WebCore::WebKitAnimation::direction):
* page/WebKitAnimation.h:
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::fractionalTime):
* platform/animation/Animation.h:
(Animation):
* platform/graphics/texmap/TextureMapperAnimation.cpp:
(WebCore):
(WebCore::shouldReverseAnimationValue):
(WebCore::normalizedAnimationValue):

LayoutTests: Implement reverse animation direction
https://bugs.webkit.org/show_bug.cgi?id=60525

Add test for the new animation-direction values.

Reviewed by Dean Jackson.

* animations/animation-direction-alternate-reverse-expected.txt: Added.
* animations/animation-direction-alternate-reverse.html: Added.
* animations/animation-direction-reverse-expected.txt: Added.
* animations/animation-direction-reverse.html: Added.
* animations/fill-mode-reverse-expected.txt: Added.
* animations/fill-mode-reverse.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Avoid creating a temporary GraphicsContext3D if someone requests the WebVi...
commit-queue@webkit.org [Thu, 9 Feb 2012 01:56:03 +0000 (01:56 +0000)]
[chromium] Avoid creating a temporary GraphicsContext3D if someone requests the WebView's GraphicsContext3D before initialization is complete
https://bugs.webkit.org/show_bug.cgi?id=78154

Patch by James Robinson <jamesr@chromium.org> on 2012-02-08
Reviewed by Kenneth Russell.

* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::context):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78157
hyatt@apple.com [Thu, 9 Feb 2012 01:50:05 +0000 (01:50 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78157

Make multi-column layout work with line grids that are outside of the multi-column
block.

Reviewed by Dan Bernstein.

Added new tests in fast/line-grid.

* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::propagateLineGridInfo):
(WebCore::LayoutState::establishLineGrid):
(WebCore):
(WebCore::LayoutState::computeLineGridPaginationOrigin):
* rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::lineGrid):
(WebCore::LayoutState::lineGridOffset):
(WebCore::LayoutState::lineGridPaginationOrigin):
(WebCore::LayoutState::needsBlockDirectionLocationSetBeforeLayout):
(LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineGridSnapAdjustment):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=78157

Make multi-column layout work with line grids that are outside of the multi-column
block.

Reviewed by Dan Bernstein.

* fast/line-grid/line-grid-into-columns.html: Added.
* platform/mac/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/mac/fast/line-grid/line-grid-into-columns-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove http-equiv content-language parsing
commit-queue@webkit.org [Thu, 9 Feb 2012 01:41:45 +0000 (01:41 +0000)]
Improve http-equiv content-language parsing
https://bugs.webkit.org/show_bug.cgi?id=77724

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-02-08
Reviewed by Alexey Proskuryakov.

Add more tests for mapping http-equiv content-language to -webkit-locale. The desired behavior of some
of these is not yet decided, so some of the tests currently fail and the expectations may change. See comments in bug and in the tests.

* fast/text/content-language-case-insensitivity-expected.txt:
* fast/text/content-language-case-insensitivity.html: Style fixes.
* fast/text/content-language-empty-expected.txt: Added.
* fast/text/content-language-empty.html: Added.
* fast/text/content-language-late-expected.txt: Added.
* fast/text/content-language-late.html: Added.
* fast/text/content-language-mapped-to-webkit-locale-expected.txt:
* fast/text/content-language-mapped-to-webkit-locale.html: Style fixes.
* fast/text/content-language-multiple-expected.txt: Added.
* fast/text/content-language-multiple.html: Added.
* fast/text/content-language-no-content-expected.txt: Added.
* fast/text/content-language-no-content.html: Added.
* fast/text/content-language-only-whitespace-expected.txt: Added.
* fast/text/content-language-only-whitespace.html: Added.
* fast/text/content-language-with-whitespace-expected.txt: Added.
* fast/text/content-language-with-whitespace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Remove EditCommandBlackBerry.cpp from build system
leo.yang@torchmobile.com.cn [Thu, 9 Feb 2012 01:41:32 +0000 (01:41 +0000)]
[BlackBerry] Remove EditCommandBlackBerry.cpp from build system
https://bugs.webkit.org/show_bug.cgi?id=78078

Reviewed by Rob Buis.

WebKit/blackberry/WebCoreSupport/EditCommandBlackBerry.cpp which hasn't
been upstreamed has been removed from the BlackBerry porting internally.
So we should remove it from the build system.

* blackberry/CMakeListsBlackBerry.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGeneratorGeneratedImage::drawPattern does not factor in its destination context's...
mdelaney@apple.com [Thu, 9 Feb 2012 01:30:54 +0000 (01:30 +0000)]
GeneratorGeneratedImage::drawPattern does not factor in its destination context's scale when generating its image tiles

https://bugs.webkit.org/show_bug.cgi?id=67729
<rdar://problem/10087050>

Reviewed by Beth Dakin.

No new tests, current pixel tests will cover this. Though some pixel results might improve to become less pixel-y.

* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw): Updated context to destContext for consistency.
(WebCore::GeneratorGeneratedImage::drawPattern): Taught drawPattern about the destination
scale factor to avoid having low-res generated images such as gradients in certain cases.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::createCompatibleBuffer): Have the image buffer match the
context acceleration setting as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove Python 2.5 support from WebKit
abarth@webkit.org [Thu, 9 Feb 2012 00:50:45 +0000 (00:50 +0000)]
Remove Python 2.5 support from WebKit
https://bugs.webkit.org/show_bug.cgi?id=71593

Reviewed by Eric Seidel.

This is the last vestige of our Python 2.5 support.

* Scripts/webkitpy/tool/commands/queues_unittest.py:
(AbstractQueueTest.test_log_from_script_error_for_upload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoversion_check.py should inform users that we don't support Python 2.5 anymore
abarth@webkit.org [Thu, 9 Feb 2012 00:46:10 +0000 (00:46 +0000)]
version_check.py should inform users that we don't support Python 2.5 anymore
https://bugs.webkit.org/show_bug.cgi?id=78179

Reviewed by Eric Seidel.

We don't support Python 2.5 anymore.

* Scripts/webkitpy/common/version_check.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove empty directory.
abarth@webkit.org [Thu, 9 Feb 2012 00:37:49 +0000 (00:37 +0000)]
Remove empty directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotest_configuration.py shouldn't re-implement itertools
abarth@webkit.org [Thu, 9 Feb 2012 00:32:08 +0000 (00:32 +0000)]
test_configuration.py shouldn't re-implement itertools
https://bugs.webkit.org/show_bug.cgi?id=78178

Reviewed by Eric Seidel.

* Scripts/webkitpy/layout_tests/models/test_configuration.py:
(TestConfigurationConverter.to_specifiers_list):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):
(TestConfigurationConverter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Thu, 9 Feb 2012 00:30:23 +0000 (00:30 +0000)]
Unreviewed gardening.

* platform/mac-future/svg/carto.net: Added.
* platform/mac-future/svg/carto.net/scrollbar-expected.png: Added.
* platform/mac/svg/carto.net/scrollbar-expected.png: Removed.
* platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
* platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt: Added.
Updated the baseline here, thanks to the text on the button...

* platform/chromium/test_expectations.txt:
Marked one test as failing as some output don't make much sense.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy should reply upon the multiprocessing package existing
abarth@webkit.org [Thu, 9 Feb 2012 00:27:36 +0000 (00:27 +0000)]
webkitpy should reply upon the multiprocessing package existing
https://bugs.webkit.org/show_bug.cgi?id=78176

Reviewed by Eric Seidel.

Now that we don't support Python 2.5, this import can't fail.

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get):
(_Process):
(_Process.__init__):
(_Process.run):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(FunctionTests.test_get__processes):
(MultiProcessBrokerTests.setUp):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.__init__):
(Port.default_worker_model):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.check_build):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_default_worker_model):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed typo fix that makes docs build again for the gtk2-based
kov@webkit.org [Thu, 9 Feb 2012 00:25:00 +0000 (00:25 +0000)]
Unreviewed typo fix that makes docs build again for the gtk2-based
library.

* gtk/generate-gtkdoc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify and correct mutation delivery timing for JSC
adamk@chromium.org [Thu, 9 Feb 2012 00:24:07 +0000 (00:24 +0000)]
Simplify and correct mutation delivery timing for JSC
https://bugs.webkit.org/show_bug.cgi?id=78172

Reviewed by Adam Barth.

Instead of keeping a static recursion counter in JSMainThreadExecState,
simply wait for a state change from non-null ExecState to null ExecState.
Because s_mainThreadState is initially null, this equivalent to
waiting for s_recursionLevel to rewind to zero.

This also properly handles the usage of JSMainThreadNullState (and
does not do mutation delivery), since that class is only used by
non-JS bindings. Now fast/mutation/end-of-task-delivery.html properly
fails, whereas it was passing before due to usage of the ObjC DOM API
from DumpRenderTree.

* bindings/js/JSMainThreadExecState.cpp:
(WebCore):
* bindings/js/JSMainThreadExecState.h: Added a comment explaining the purpose of JSMainThreadNullState.
(WebCore::JSMainThreadExecState::JSMainThreadExecState):
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
(JSMainThreadExecState):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove [ConvertToString] from CodeGeneratorCPP.pm and rename
haraken@chromium.org [Thu, 9 Feb 2012 00:21:20 +0000 (00:21 +0000)]
Remove [ConvertToString] from CodeGeneratorCPP.pm and rename
it to [ObjCImplementedAsUnsignedLong]
https://bugs.webkit.org/show_bug.cgi?id=78100

Reviewed by Eric Seidel.

Now [ConvertToString] is used by ObjC's HTMLElement.size only.
This patch removes [ConvertToString] code from CodeGeneratorCPP.pm,
and renames [ConvertToString] to [ObjCImplementedAsUnsignedLong].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* html/HTMLInputElement.idl: Removed FIXME comment, because the latest spec
says HTMLInputElement.size should be unsigned long.
(http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#the-input-element)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't re-implement ZipFile.extractall
abarth@webkit.org [Thu, 9 Feb 2012 00:10:04 +0000 (00:10 +0000)]
Don't re-implement ZipFile.extractall
https://bugs.webkit.org/show_bug.cgi?id=78173

Reviewed by Eric Seidel.

We can use ZipFile.extractall now that we don't support Python 2.5.

* Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._extract_targz):
(AutoInstaller._unzip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r84194): Build fails when turning on ENABLE_FILE_SYSTEM
leo.yang@torchmobile.com.cn [Thu, 9 Feb 2012 00:04:09 +0000 (00:04 +0000)]
REGRESSION(r84194): Build fails when turning on ENABLE_FILE_SYSTEM
https://bugs.webkit.org/show_bug.cgi?id=78088

Reviewed by Antonio Gomes.

WebCore::getDOMObjectWrapper was changed to WebCore::wrap in r84194.
Adapt to this change in JSEntryCustom.cpp and JSEntrySyncCustom.cpp.

Build fix, no new tests.

* bindings/js/JSEntryCustom.cpp:
(WebCore::toJS):
* bindings/js/JSEntrySyncCustom.cpp:
(WebCore::toJS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the ospath compat shim from webkitpy
abarth@webkit.org [Wed, 8 Feb 2012 23:59:04 +0000 (23:59 +0000)]
Remove the ospath compat shim from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78170

Reviewed by Eric Seidel.

We no longer need this compat shim now that we don't support Python 2.5.

* Scripts/webkitpy/common/checkout/scm/git.py:
* Scripts/webkitpy/common/checkout/scm/svn.py:
* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.relpath):
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.relpath):
* Scripts/webkitpy/common/system/ospath.py: Removed.
* Scripts/webkitpy/common/system/ospath_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix attempt after r107053.
rniwa@webkit.org [Wed, 8 Feb 2012 23:57:48 +0000 (23:57 +0000)]
Build fix attempt after r107053.

* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fix opaque tracking for box shadows and non-composited child elements
commit-queue@webkit.org [Wed, 8 Feb 2012 23:48:18 +0000 (23:48 +0000)]
[Chromium] Fix opaque tracking for box shadows and non-composited child elements
https://bugs.webkit.org/show_bug.cgi?id=78073

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-08
Reviewed by Stephen White.

Source/WebCore:

Tests: compositing/culling/scrolled-within-boxshadow.html
       compositing/culling/translated-boxshadow.html

Unit tests: PlatformContextSkiaTest.cpp

When painting a box shadow, a filter is applied to the skia canvas, that can make
pixels painted with an opaque color end up non-opaque. So consider image/mask/color
filters when deciding if a paint is opaque.

Also when painting the background of an element with a box shadow, the background is
painted with a transform on the skia canvas based on the size of the box shadow. This
transform needs to be considered when tracking an opaque paint.

However, when a layer's contentRect position is non-zero, we translate the GraphicsContext
to put the contentRect at 0,0 in the skia canvas. For tracking opaque regions in the resulting
layer, we need to unto this translation. Scaling can also occur which we must undo. So we pass
the transform in to PlatformContextSkia to go from the SkCanvas back to the layer's content
coordinate space. Opaque paints can then be tracked in the layer's content space rather than
in the skia canvas space.

* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
(WebCore::CanvasLayerTextureUpdater::paintContents):
* platform/graphics/chromium/CanvasLayerTextureUpdater.h:
(WebCore):
(CanvasLayerTextureUpdater):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
* platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):
* platform/graphics/skia/OpaqueRegionSkia.h:
(WebCore):
(OpaqueRegionSkia):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::didDrawRect):
(WebCore::PlatformContextSkia::didDrawPath):
(WebCore::PlatformContextSkia::didDrawPoints):
(WebCore::PlatformContextSkia::didDrawBounded):
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
(WebCore::PlatformContextSkia::setOpaqueRegionTransform):

Source/WebKit/chromium:

* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):

LayoutTests:

* compositing/culling/scrolled-within-boxshadow-expected.png: Added.
* compositing/culling/scrolled-within-boxshadow-expected.txt: Added.
* compositing/culling/scrolled-within-boxshadow.html: Added.
* compositing/culling/translated-boxshadow-expected.png: Added.
* compositing/culling/translated-boxshadow-expected.txt: Added.
* compositing/culling/translated-boxshadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove simplejson because it's no longer used by webkitpy
abarth@webkit.org [Wed, 8 Feb 2012 23:35:29 +0000 (23:35 +0000)]
Remove simplejson because it's no longer used by webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78164

Reviewed by Eric Seidel.

All the importers of this code were removed in a previous patch.

* Scripts/webkitpy/thirdparty/simplejson: Removed.
* Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
* Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
* Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
* Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
* Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
* Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
* Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
* Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
* Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
* Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Wed, 8 Feb 2012 23:34:09 +0000 (23:34 +0000)]
Unreviewed gardening.

* platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
Updated this baseline. It looks like an opacity difference of 1 that we could't really explain.

* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120364-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug22019-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug23151-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-1-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-2-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56405-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_td_nowrap-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Added.
* platform/chromium/tables/mozilla/bugs/bug56405-expected.txt: Removed.
Rebaselined those tests on snowleopard as we started taking up the new snow-leopard baselines from r107122.

* platform/chromium/test_expectations.txt:
Mark compositing/iframes/scrolling-iframe.html as flaky as seen on a snow-leopard or windows (debug) bot near you.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy still imports simplejson
abarth@webkit.org [Wed, 8 Feb 2012 23:26:32 +0000 (23:26 +0000)]
webkitpy still imports simplejson
https://bugs.webkit.org/show_bug.cgi?id=78161

Reviewed by Eric Seidel.

We no longer support Python 2.5, so we can rely upon Python's built-in
JSON package.

* Scripts/webkitpy/common/net/buildbot/buildbot.py:
* Scripts/webkitpy/common/net/resultsjsonparser.py:
* Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
* Scripts/webkitpy/style/checkers/jsonchecker.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
* Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
* Scripts/webkitpy/tool/servers/reflectionhandler.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fails to build docs with non-standard build directories
kov@webkit.org [Wed, 8 Feb 2012 23:20:31 +0000 (23:20 +0000)]
[GTK] Fails to build docs with non-standard build directories
https://bugs.webkit.org/show_bug.cgi?id=78118

* gtk/common.py:
(get_build_path): add comment to document changes done in r107098,
as requested by the reviewer and forgotten by me.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove [CustomHeader] from CanvasPixelArray and rename [CustomHeader] to [JSCustomHeader]
haraken@chromium.org [Wed, 8 Feb 2012 23:14:46 +0000 (23:14 +0000)]
Remove [CustomHeader] from CanvasPixelArray and rename [CustomHeader] to [JSCustomHeader]
https://bugs.webkit.org/show_bug.cgi?id=78089

Reviewed by Adam Barth.

This patch removes [CustomHeader] from CanvasPixelArray.idl, since CanvasPixelArrayCustom.h
does not exist. (The reason why missing CanvasPixelArrayCustom.h has not caused build failure
is that [CustomHeader] has been JSC-specific and JSC has not enabled CanvasPixelArray.)
Also, this patch renames [CustomHeader] to [JSCustomHeader], since whether a given class
should have custom header or not will depend on JavaScript bindings.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* dom/Node.idl:
* html/canvas/CanvasPixelArray.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop importing with_statement from the mysterious future
abarth@webkit.org [Wed, 8 Feb 2012 23:08:24 +0000 (23:08 +0000)]
Stop importing with_statement from the mysterious future
https://bugs.webkit.org/show_bug.cgi?id=78156

Reviewed by Eric Seidel.

The future is now!  (Well, at least 2008, when Python 2.6 was released,
is no longer the __future__.)

* Scripts/webkitpy/common/checkout/changelog_unittest.py:
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/common/net/credentials_unittest.py:
* Scripts/webkitpy/common/net/file_uploader.py:
* Scripts/webkitpy/common/newstringio_unittest.py:
* Scripts/webkitpy/common/system/autoinstall.py:
* Scripts/webkitpy/common/system/crashlogs.py:
* Scripts/webkitpy/common/system/fileset.py:
* Scripts/webkitpy/common/system/filesystem.py:
* Scripts/webkitpy/common/system/filesystem_unittest.py:
* Scripts/webkitpy/common/system/path.py:
* Scripts/webkitpy/common/thread/threadedmessagequeue.py:
* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/port/base.py:
(of):
* Scripts/webkitpy/layout_tests/port/gtk.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
* Scripts/webkitpy/style/filereader_unittest.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
* Scripts/webkitpy/tool/commands/analyzechangelog.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/servers/reflectionhandler.py:
* Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDispatch updateViewportArguments(), when Document is finished
commit-queue@webkit.org [Wed, 8 Feb 2012 22:44:00 +0000 (22:44 +0000)]
Dispatch updateViewportArguments(), when Document is finished
restoring from page cache.

https://bugs.webkit.org/show_bug.cgi?id=77943

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-02-08
Reviewed by Kenneth Rohde Christiansen.

Move updateViewportArguments() call from setPageInCache() to
documentDidResumeFromPageCache() to ensure, that the Document is
fully resumed from the page cache and attached to the mainframe,
when the viewport arguments are updated.

No tests. No change in behaviour.

* dom/Document.cpp:
(WebCore::Document::setInPageCache):
(WebCore::Document::documentDidResumeFromPageCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Wed, 8 Feb 2012 22:38:24 +0000 (22:38 +0000)]
Unreviewed gardening.

* platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
Add those 2 new baselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add a layout test for losing the compositor context with a video playing
jamesr@google.com [Wed, 8 Feb 2012 21:47:51 +0000 (21:47 +0000)]
[chromium] Add a layout test for losing the compositor context with a video playing
https://bugs.webkit.org/show_bug.cgi?id=78060

Reviewed by Eric Carlson.

Adds a test to prevent regressions with video playback when we lose the compositor context. This test loads up a
video, forces a frame to be displayed, simulates a lost context, then finishes the test (which causes another
frame to be displayed).

Prior to r106610 this test times out in debug and crashes in ASAN.

* platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
* platform/chromium/compositing/lost-compositor-context-with-video-expected.txt: Added.
* platform/chromium/compositing/lost-compositor-context-with-video.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhoops, fix the build.
oliver@apple.com [Wed, 8 Feb 2012 21:46:42 +0000 (21:46 +0000)]
Whoops, fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove incorrect early exit in CCDamageTracker
shawnsingh@chromium.org [Wed, 8 Feb 2012 21:41:47 +0000 (21:41 +0000)]
[chromium] Remove incorrect early exit in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=76924

Reviewed by James Robinson.

Source/WebCore:

New unit test added to CCDamageTrackerTest.cpp

This patch does three things: (1) adds unit test that demonstrates
that early exiting in CCDamageTracker is wrong, (2) removes the
early exit and cleans up the surrounding code, and (3) re-names
several functions in CCDamageTracker so that state updating is
implied by the name, and not just a bad side-effect of the functions.

* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::trackDamageFromActiveLayers):
(WebCore::CCDamageTracker::trackDamageFromSurfaceMask):
(WebCore::CCDamageTracker::trackDamageFromLeftoverRects):
* platform/graphics/chromium/cc/CCDamageTracker.h:
(CCDamageTracker):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):

Source/WebKit/chromium:

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::TEST_F):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream DumpRenderTreeBlackBerry
rwlbuis@webkit.org [Wed, 8 Feb 2012 21:37:31 +0000 (21:37 +0000)]
[BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042

Reviewed by Antonio Gomes.

Upstream more parts of our DRT implementation.

* DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
* DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
* DumpRenderTree/blackberry/EventSender.cpp: Added.
* DumpRenderTree/blackberry/EventSender.h: Added.
* DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
* DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix issue encountered while debugging stacktraces
oliver@apple.com [Wed, 8 Feb 2012 21:35:34 +0000 (21:35 +0000)]
Fix issue encountered while debugging stacktraces
https://bugs.webkit.org/show_bug.cgi?id=78147

Reviewed by Gavin Barraclough.

Debugging is easier if we always ensure that we have a non-null
inferred name.

* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Check that we can make the SharedGraphicsContext3D current before returning
jamesr@google.com [Wed, 8 Feb 2012 21:32:54 +0000 (21:32 +0000)]
[chromium] Check that we can make the SharedGraphicsContext3D current before returning
https://bugs.webkit.org/show_bug.cgi?id=78142

Reviewed by Stephen White.

If we can't make the context current, we can't use it.

* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoupdateTopCallframe in the baseline JIT doesn't provide enough information to the...
oliver@apple.com [Wed, 8 Feb 2012 21:22:49 +0000 (21:22 +0000)]
updateTopCallframe in the baseline JIT doesn't provide enough information to the stubs
https://bugs.webkit.org/show_bug.cgi?id=78145

Reviewed by Gavin Barraclough.

Fix the updateTopCallFrame helper to store additional information
that becomes necessary when we are trying to provide more stack
frame information.

* interpreter/CallFrame.h:
(JSC::ExecState::bytecodeOffsetForBaselineJIT):
(ExecState):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JIT):
* jit/JITInlineMethods.h:
(JSC::JIT::updateTopCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for pinch gesture processing in the MT compositor.
commit-queue@webkit.org [Wed, 8 Feb 2012 21:12:58 +0000 (21:12 +0000)]
Add support for pinch gesture processing in the MT compositor.
https://bugs.webkit.org/show_bug.cgi?id=77804

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-08
Reviewed by James Robinson.

* public/WebInputEvent.h:
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
* tests/WebCompositorInputHandlerImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocheck-webkit-style failing with "Path does not exist."
dpranke@chromium.org [Wed, 8 Feb 2012 21:02:53 +0000 (21:02 +0000)]
check-webkit-style failing with "Path does not exist."
https://bugs.webkit.org/show_bug.cgi?id=77873

Reviewed by Ojan Vafai.

This change fixes the way the style checker determines which
Port class to use for a given test_expectations.txt path; the
previous version used a heuristic that didn't really work in the
first place.

* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_expectations_path):
(TestExpectationsChecker.__init__):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase._expect_port_for_expectations_path):
(TestExpectationsTestCase.test_determine_port_from_expectations_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in Node::normalize.
inferno@chromium.org [Wed, 8 Feb 2012 20:53:54 +0000 (20:53 +0000)]
Crash in Node::normalize.
https://bugs.webkit.org/show_bug.cgi?id=78135

Reviewed by Ryosuke Niwa.

No new tests. Original testcase does not reduce to manageable
extent.

* dom/Node.cpp:
(WebCore::Node::normalize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate pixel table test expectations for mac to match new DRT scrollbars
eae@chromium.org [Wed, 8 Feb 2012 20:42:19 +0000 (20:42 +0000)]
Update pixel table test expectations for mac to match new DRT scrollbars
https://bugs.webkit.org/show_bug.cgi?id=76938

Rubber stamped by Eric Seidel.

* platform/mac/tables/mozilla/bugs/bug101674-expected.png:
* platform/mac/tables/mozilla/bugs/bug10296-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug113235-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug113235-3-expected.png:
* platform/mac/tables/mozilla/bugs/bug11944-expected.png:
* platform/mac/tables/mozilla/bugs/bug120364-expected.png:
* platform/mac/tables/mozilla/bugs/bug131020-expected.png:
* platform/mac/tables/mozilla/bugs/bug131020_iframe-expected.png:
* platform/mac/tables/mozilla/bugs/bug137388-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug149275-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug22019-expected.png:
* platform/mac/tables/mozilla/bugs/bug23151-expected.png:
* platform/mac/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug29314-expected.png:
* platform/mac/tables/mozilla/bugs/bug32205-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug38916-expected.png:
* platform/mac/tables/mozilla/bugs/bug43039-expected.png:
* platform/mac/tables/mozilla/bugs/bug43854-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug44505-expected.png:
* platform/mac/tables/mozilla/bugs/bug46480-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug46480-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug50695-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug56405-expected.png:
* platform/mac/tables/mozilla/bugs/bug67915-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug73321-expected.png:
* platform/mac/tables/mozilla/bugs/bug92143-expected.png:
* platform/mac/tables/mozilla/bugs/bug96334-expected.png:
* platform/mac/tables/mozilla/bugs/bug96343-expected.png:
* platform/mac/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
* platform/mac/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_height-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_nowrap-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_height-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_nowrap-expected.png:
* platform/mac/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
* platform/mac/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/backgrounds-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/col_span2-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/columns-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/conflicts-expected.png:
* platform/mac/tables/mozilla_expected_failures/core/standards1-expected.png:
* platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake WebGL context current early to check validity
jamesr@google.com [Wed, 8 Feb 2012 20:39:37 +0000 (20:39 +0000)]
Make WebGL context current early to check validity
https://bugs.webkit.org/show_bug.cgi?id=78141

Patch by Antoine Labour <piman@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Covered by existing tests

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Disable root layer clears on release builds.
commit-queue@webkit.org [Wed, 8 Feb 2012 20:35:06 +0000 (20:35 +0000)]
[chromium] Disable root layer clears on release builds.
https://bugs.webkit.org/show_bug.cgi?id=77478

Patch by Jonathan Backer <backer@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::drawRenderPass):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):

LayoutTests:

* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png:
* platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png:
* platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
* platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
* platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107120 268f45cc-cd09-0410-ab3c-d52691b4dbfc