WebKit-https.git
10 years agoRefactoring the fpu code generator for the ARM port
zherczeg@webkit.org [Fri, 13 Aug 2010 06:49:16 +0000 (06:49 +0000)]
Refactoring the fpu code generator for the ARM port
https://bugs.webkit.org/show_bug.cgi?id=43842

Reviewed by Gavin Barraclough.

Support up to 32 double precision registers, and the
recent VFP instruction formats. This patch is mainly
a style change which keeps the current functionality.

* assembler/ARMAssembler.h:
(JSC::ARMRegisters::):
(JSC::ARMAssembler::):
(JSC::ARMAssembler::emitInst):
(JSC::ARMAssembler::emitDoublePrecisionInst):
(JSC::ARMAssembler::emitSinglePrecisionInst):
(JSC::ARMAssembler::vadd_f64_r):
(JSC::ARMAssembler::vdiv_f64_r):
(JSC::ARMAssembler::vsub_f64_r):
(JSC::ARMAssembler::vmul_f64_r):
(JSC::ARMAssembler::vcmp_f64_r):
(JSC::ARMAssembler::vsqrt_f64_r):
(JSC::ARMAssembler::vmov_vfp_r):
(JSC::ARMAssembler::vmov_arm_r):
(JSC::ARMAssembler::vcvt_f64_s32_r):
(JSC::ARMAssembler::vcvt_s32_f64_r):
(JSC::ARMAssembler::vmrs_apsr):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::sqrtDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
ossy@webkit.org [Fri, 13 Aug 2010 06:42:16 +0000 (06:42 +0000)]
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65295.
        http://trac.webkit.org/changeset/65295
        https://bugs.webkit.org/show_bug.cgi?id=43950

        It broke 4 sputnik tests (Requested by Ossy on #webkit).

        * JavaScriptCore.exp:
        * bytecode/CodeBlock.cpp:
        (JSC::constantName):
        (JSC::idName):
        (JSC::CodeBlock::registerName):
        (JSC::regexpName):
        (JSC::printGlobalResolveInfo):
        (JSC::printStructureStubInfo):
        (JSC::CodeBlock::printStructure):
        (JSC::CodeBlock::printStructures):
        * jsc.cpp:
        (functionPrint):
        (functionDebug):
        (runInteractive):
        (fillBufferWithContentsOfFile):
        * pcre/pcre_exec.cpp:
        (Histogram::~Histogram):
        * profiler/CallIdentifier.h:
        (JSC::CallIdentifier::c_str):
        * profiler/Profile.cpp:
        (JSC::Profile::debugPrintDataSampleStyle):
        * profiler/ProfileGenerator.cpp:
        (JSC::ProfileGenerator::willExecute):
        (JSC::ProfileGenerator::didExecute):
        * profiler/ProfileNode.cpp:
        (JSC::ProfileNode::debugPrintData):
        (JSC::ProfileNode::debugPrintDataSampleStyle):
        * runtime/Arguments.cpp:
        (JSC::Arguments::getOwnPropertySlot):
        (JSC::Arguments::getOwnPropertyDescriptor):
        (JSC::Arguments::put):
        (JSC::Arguments::deleteProperty):
        * runtime/DateConversion.cpp:
        (JSC::parseDate):
        * runtime/Identifier.h:
        (JSC::Identifier::Identifier):
        (JSC::Identifier::toArrayIndex):
        * runtime/JSArray.cpp:
        (JSC::JSArray::getOwnPropertySlot):
        (JSC::JSArray::getOwnPropertyDescriptor):
        (JSC::JSArray::put):
        (JSC::JSArray::deleteProperty):
        * runtime/JSArray.h:
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::encode):
        (JSC::parseInt):
        (JSC::globalFuncJSCPrint):
        * runtime/JSString.h:
        (JSC::RopeBuilder::JSString):
        * runtime/UString.cpp:
        (JSC::UString::toDouble):
        (JSC::UString::UTF8String):
        * runtime/UString.h:
        (JSC::UString::isNull):
        (JSC::UString::isEmpty):
        (JSC::UString::impl):
        (JSC::UString::cost):
        (JSC::UString::~UString):
        (JSC::UString::toArrayIndex):
        * wtf/text/WTFString.cpp:
        (WTF::String::utf8):
        * wtf/text/WTFString.h:
        (WTF::String::String):
        (WTF::String::isHashTableDeletedValue):
        (WTF::String::length):
        (WTF::String::operator[]):
        (WTF::String::isNull):
        (WTF::String::isEmpty):
        (WTF::String::impl):
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65295.
        http://trac.webkit.org/changeset/65295
        https://bugs.webkit.org/show_bug.cgi?id=43950

        It broke 4 sputnik tests (Requested by Ossy on #webkit).

        * WebFrame.cpp:
        (wxWebFrame::RunScript):
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65295.
        http://trac.webkit.org/changeset/65295
        https://bugs.webkit.org/show_bug.cgi?id=43950

        It broke 4 sputnik tests (Requested by Ossy on #webkit).

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::enumerate):
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65295.
        http://trac.webkit.org/changeset/65295
        https://bugs.webkit.org/show_bug.cgi?id=43950

        It broke 4 sputnik tests (Requested by Ossy on #webkit).

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::getOwnPropertySlot):
        (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
        * bridge/NP_jsobject.cpp:
        (_NPN_Enumerate):
        * bridge/c/c_utility.cpp:
        (JSC::Bindings::convertValueToNPVariant):
        * bridge/jni/JNIBridge.cpp:
        (JavaParameter::JavaParameter):
        (JavaMethod::JavaMethod):
        (JavaMethod::signature):
        (JavaMethod::methodID):
        * bridge/jni/JNIBridge.h:
        (JSC::Bindings::JavaString::UTF8String):
        (JSC::Bindings::JavaParameter::type):
        (JSC::Bindings::JavaMethod::returnType):
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::call):
        (JavaJSObject::eval):
        (JavaJSObject::getMember):
        (JavaJSObject::setMember):
        (JavaJSObject::removeMember):
        (JavaJSObject::convertJObjectToValue):
        * bridge/jni/jsc/JNIBridgeJSC.cpp:
        (JavaField::JavaField):
        (JavaField::valueFromInstance):
        (JavaField::setValueToInstance):
        * bridge/jni/jsc/JNIBridgeJSC.h:
        (JSC::Bindings::JavaField::type):
        * bridge/jni/jsc/JavaInstanceJSC.cpp:
        (JavaInstance::invokeMethod):
        * bridge/jni/jsc/JavaStringJSC.h:
        (JSC::Bindings::JavaStringImpl::UTF8String):
        * bridge/runtime_array.cpp:
        (JSC::RuntimeArray::getOwnPropertySlot):
        (JSC::RuntimeArray::getOwnPropertyDescriptor):
        (JSC::RuntimeArray::put):
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65295.
        http://trac.webkit.org/changeset/65295
        https://bugs.webkit.org/show_bug.cgi?id=43950

        It broke 4 sputnik tests (Requested by Ossy on #webkit).

        * WebProcess/Plugins/JSNPObject.cpp:
        (WebKit::npIdentifierFromIdentifier):
        * WebProcess/Plugins/NPJSObject.cpp:
        (WebKit::NPJSObject::enumerate):
        * WebProcess/Plugins/NPRuntimeObjectMap.cpp:
        (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 13 Aug 2010 06:35:44 +0000 (06:35 +0000)]
2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Fixed typo in inspector js.
        Follow up to r65300.

        * inspector/front-end/inspector.js:
        (WebInspector.log.isLogAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 13 Aug 2010 06:31:41 +0000 (06:31 +0000)]
2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Make getPrototypes return objects, not names.
        https://bugs.webkit.org/show_bug.cgi?id=43934

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.callback):
        * inspector/front-end/inspector.js:
        (WebInspector.log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 13 Aug 2010 05:43:16 +0000 (05:43 +0000)]
2010-08-12  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r65284 and r65288.  Broke chromium compile.
        https://bugs.webkit.org/show_bug.cgi?id=43725
        http://trac.webkit.org/changeset/65284
        http://trac.webkit.org/changeset/65288

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::namedItemAdded):
        (WebCore::ScriptController::namedItemRemoved):
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        (WebCore::V8HTMLDocument::namedPropertyDeleter):
        (WebCore::V8HTMLDocument::namedPropertyGetter):
        (WebCore::V8HTMLDocument::indexedPropertyGetter):
        (WebCore::V8HTMLDocument::allAccessorSetter):
        (WebCore::toV8):
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::removeItemFromMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd more files to the WebKit2 skipped list.
weinig@apple.com [Fri, 13 Aug 2010 04:33:26 +0000 (04:33 +0000)]
Add more files to the WebKit2 skipped list.

Reviewed by Gavin Barraclough.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 13 Aug 2010 04:27:39 +0000 (04:27 +0000)]
2010-08-12  James Robinson  <jamesr@chromium.org>

        Unreviewed. Mark play-state.html and isindex-with-no-form.html as flaky because they are.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
barraclough@apple.com [Fri, 13 Aug 2010 04:09:26 +0000 (04:09 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnify UString::UTF8String() & String::utf8() methods,
barraclough@apple.com [Fri, 13 Aug 2010 03:58:37 +0000 (03:58 +0000)]
Unify UString::UTF8String() & String::utf8() methods,
remove UString::cost() & make atArrayIndex a free function.

Reviewed by Sam Weinig

JavaScriptCore:

* JavaScriptCore.exp:
* bytecode/CodeBlock.cpp:
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpName):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
* jsc.cpp:
(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):
* pcre/pcre_exec.cpp:
(Histogram::~Histogram):
* profiler/CallIdentifier.h:
(JSC::CallIdentifier::c_str):
* profiler/Profile.cpp:
(JSC::Profile::debugPrintDataSampleStyle):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
* profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
* runtime/DateConversion.cpp:
(JSC::parseDate):
* runtime/Identifier.h:
(JSC::Identifier::toStrictUInt32):
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):
* runtime/JSArray.h:
(JSC::toArrayIndex):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::parseInt):
(JSC::globalFuncJSCPrint):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
* runtime/UString.cpp:
(JSC::UString::toDouble):
(JSC::putUTF8Triple):
(JSC::UString::utf8):
* runtime/UString.h:
(JSC::UString::~UString):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):
* wtf/text/WTFString.cpp:
(WTF::String::utf8):
* wtf/text/WTFString.h:
(WTF::String::~String):
(WTF::String::swap):
(WTF::String::isNull):
(WTF::String::isEmpty):
(WTF::String::impl):
(WTF::String::length):
(WTF::String::String):
(WTF::String::isHashTableDeletedValue):

WebCore:

* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
* bridge/NP_jsobject.cpp:
(_NPN_Enumerate):
* bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
* bridge/jni/JNIBridge.cpp:
(JavaParameter::JavaParameter):
(JavaMethod::JavaMethod):
(JavaMethod::signature):
(JavaMethod::methodID):
* bridge/jni/JNIBridge.h:
(JSC::Bindings::JavaString::utf8):
(JSC::Bindings::JavaParameter::type):
(JSC::Bindings::JavaMethod::returnType):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
(JavaJSObject::convertJObjectToValue):
* bridge/jni/jsc/JNIBridgeJSC.cpp:
(JavaField::JavaField):
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):
* bridge/jni/jsc/JNIBridgeJSC.h:
(JSC::Bindings::JavaField::type):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::utf8):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::put):

WebKit/mac:

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate):

WebKit/wx:

* WebFrame.cpp:
(wxWebFrame::RunScript):

WebKit2:

* WebProcess/Plugins/JSNPObject.cpp:
(WebKit::npIdentifierFromIdentifier):
* WebProcess/Plugins/NPJSObject.cpp:
(WebKit::NPJSObject::enumerate):
* WebProcess/Plugins/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTestRunner does not correctly resize WebView for W3C SVG tests
jhoneycutt@apple.com [Fri, 13 Aug 2010 03:47:23 +0000 (03:47 +0000)]
WebKitTestRunner does not correctly resize WebView for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=43945

Reviewed by Sam Weinig.

* WebKitTestRunner/TestInvocation.cpp:
(WTR::sizeWebViewForCurrentTest):
Allow for a Windows-style path.

* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::resizeTo):
Call SetWindowPos to resize the view window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2 needs to initialize SafariTheme
jhoneycutt@apple.com [Fri, 13 Aug 2010 03:46:53 +0000 (03:46 +0000)]
WebKit2 needs to initialize SafariTheme
https://bugs.webkit.org/show_bug.cgi?id=43901

Reviewed by Sam Weinig.

* WebProcess/win/WebProcessMainWin.cpp:
(WebKit::initializeSafariTheme):
Copied from old WebKit.
(WebKit::WebProcessMain):
If we're using SafariTheme, initialize it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 13 Aug 2010 03:21:42 +0000 (03:21 +0000)]
2010-08-12  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        WebKit2 crashes when WebFrame outlives WebPage
        https://bugs.webkit.org/show_bug.cgi?id=43939

        * WebProcess/WebCoreSupport/WebChromeClient.h:
        (WebKit::WebChromeClient::page): Add this method, to allow
        WebFrame to retrieve its WebPage following WebCore pointers.
        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::WebFrame): Do not initialize m_page (it's gone).
        (WebKit::WebFrame::page): Don't use the data member, get it from
        WebCore.
        (WebKit::WebFrame::invalidate): Use method to get page() and null check.
        (WebKit::WebFrame::isMainFrame): ditto
        * WebProcess/WebPage/WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 13 Aug 2010 03:11:19 +0000 (03:11 +0000)]
2010-08-12  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed, fixing the previous commit.

        Added PASS CRASH expectation for editing/pasteboard/smart-paste-004.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 13 Aug 2010 03:05:33 +0000 (03:05 +0000)]
2010-08-12  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed.

        Added PASS CRASH expectation for editing/pasteboard/smart-paste-003.html and
        editing/pasteboard/smart-paste-004.html reported by japhet.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEeerk! - revert accidentally committed changes in UString!
barraclough@apple.com [Fri, 13 Aug 2010 02:29:31 +0000 (02:29 +0000)]
Eeerk! - revert accidentally committed changes in UString!

* JavaScriptCore.exp:
* runtime/UString.cpp:
(JSC::UString::UString):
* runtime/UString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpeculative build fix for chromium bindings (someone added the old include style!).
barraclough@apple.com [Fri, 13 Aug 2010 02:29:22 +0000 (02:29 +0000)]
Speculative build fix for chromium bindings (someone added the old include style!).

* bindings/v8/V8DOMWindowShell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 13 Aug 2010 01:44:51 +0000 (01:44 +0000)]
2010-08-12  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        [Refactoring] TextEvent class has to many flags
        https://bugs.webkit.org/show_bug.cgi?id=43893

        Turned TextEvent::m_isLineBreak, TextEvent::m_isBacktab, TextEvent::m_isPaste
        into single TextEvent::m_inputType enumeration.

        No functional change. No new tests.

        * dom/TextEvent.cpp:
        (WebCore::TextEvent::selectInputType):
        (WebCore::TextEvent::create):
        (WebCore::TextEvent::createForPlainTextPaste):
        (WebCore::TextEvent::createForFragmentPaste):
        (WebCore::TextEvent::TextEvent):
        * dom/TextEvent.h:
        (WebCore::TextEvent::):
        (WebCore::TextEvent::isLineBreak):
        (WebCore::TextEvent::isBackTab):
        (WebCore::TextEvent::isPaste):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTextInputEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange UString constructors to match those in WTF::String.
barraclough@apple.com [Fri, 13 Aug 2010 01:05:10 +0000 (01:05 +0000)]
Change UString constructors to match those in WTF::String.
This changes behaviour of UString((char*)0) to create null
strings, akin to UString() rather than UString::empty().
(This matches String).  Remove unused constructors from
UString, and add null-terminated UTF-16 constructor, to
match String.  Move String's constructor into the .cpp to
match UString.

Reviewed by Sam Weinig

* JavaScriptCore.exp:
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
* runtime/RegExpKey.h:
(JSC::RegExpKey::RegExpKey):
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::createSingleCharacterString):
* runtime/UString.cpp:
(JSC::UString::UString):
* runtime/UString.h:
(JSC::UString::UString):
(JSC::UString::swap):
(JSC::UString::adopt):
(JSC::UString::operator[]):
* wtf/text/WTFString.h:
(WTF::String::String):
(WTF::String::adopt):
(WTF::String::operator[]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Kenneth Russell <kbr@google.com>
kbr@google.com [Fri, 13 Aug 2010 00:12:25 +0000 (00:12 +0000)]
2010-08-12  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Delete obsolete CanvasNumberArray
        https://bugs.webkit.org/show_bug.cgi?id=38619

        Deleted unreferenced code. Built WebKit and Chromium to test.

        * Android.derived.jscbindings.mk:
        * Android.derived.v8bindings.mk:
        * Android.jscbindings.mk:
        * Android.mk:
        * bindings/js/JSCanvasNumberArrayCustom.cpp: Removed.
        * html/canvas/CanvasNumberArray.cpp: Removed.
        * html/canvas/CanvasNumberArray.h: Removed.
        * html/canvas/CanvasNumberArray.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Thu, 12 Aug 2010 23:57:29 +0000 (23:57 +0000)]
2010-08-12  Anton Muhin  <antonm@chromium.org>

        Reviewed by Nate Chapin.

        [v8] Create callbacks for named access of elements from document object on fly.
        https://bugs.webkit.org/show_bug.cgi?id=43725

        That should speed up access to methods on document as there is no need to
        consult with interceptor before invoking the method.

        This reapplies http://trac.webkit.org/changeset/60670 reverted with
        http://trac.webkit.org/changeset/63845.  The main difference is in treatment
        of removed named elements: we don't remove an accessor any more, but leave it.
        Therefore any accessor should be able to treat the case when there is no
        expando property.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::namedItemAdded):
        (WebCore::ScriptController::namedItemRemoved):
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::checkDocumentWrapper):
        (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
        (WebCore::getter):
        (WebCore::V8DOMWindowShell::namedItemAdded):
        (WebCore::V8DOMWindowShell::namedItemRemoved):
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        (WebCore::V8HTMLDocument::WrapInShadowObject):
        (WebCore::V8HTMLDocument::GetNamedProperty):
        (WebCore::V8HTMLDocument::allAccessorSetter):
        (WebCore::toV8):
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::removeItemFromMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 12 Aug 2010 23:30:28 +0000 (23:30 +0000)]
2010-08-12  Tony Chang  <tony@chromium.org>

        Unreviewed, landing google-chrome linux 64 test results.

        * platform/google-chrome-linux64/fast/borders/borderRadiusGroove01-expected.checksum: Added.
        * platform/google-chrome-linux64/fast/borders/borderRadiusGroove01-expected.png: Added.
        * platform/google-chrome-linux64/fast/borders/borderRadiusGroove02-expected.checksum: Added.
        * platform/google-chrome-linux64/fast/borders/borderRadiusGroove02-expected.png: Added.
        * platform/google-chrome-linux64/fast/borders/borderRadiusRidge01-expected.checksum: Added.
        * platform/google-chrome-linux64/fast/borders/borderRadiusRidge01-expected.png: Added.
        * platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum: Added.
        * platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
        * platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
        * platform/google-chrome-linux64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum: Added.
        * platform/google-chrome-linux64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
        * platform/google-chrome-linux64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
        * platform/google-chrome-linux64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
        * platform/google-chrome-linux64/svg/hixie/perf/001-expected.txt: Added.
        * platform/google-chrome-linux64/svg/hixie/perf/002-expected.txt: Added.
        * platform/google-chrome-linux64/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
        * platform/google-chrome-linux64/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 12 Aug 2010 23:26:33 +0000 (23:26 +0000)]
2010-08-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        Add more Chromium-related dependency directories to .gitignore.
        https://bugs.webkit.org/show_bug.cgi?id=43940

        * .gitignore: Added all existing that are created by update-webkit --chromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 12 Aug 2010 23:23:13 +0000 (23:23 +0000)]
2010-08-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Ensure that parser doesn't attach children that have been removed by JavaScript event handlers.
        https://bugs.webkit.org/show_bug.cgi?id=43813

        This patch re-fixes bug 40742 in a way that keeps allowing HTMLLinkElement
        to lazy-attach.

        * html/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::attach): Added parent check.
        * html/HTMLLinkElement.cpp: Basically undoes changes introduced by r61424.
        * html/HTMLLinkElement.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 12 Aug 2010 23:18:08 +0000 (23:18 +0000)]
2010-08-12  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dumitru Daniliuc.

        Clear PluginData's page pointer on page refresh
        https://bugs.webkit.org/show_bug.cgi?id=43888

        Test: plugins/access-after-page-destroyed.html

        * page/Page.cpp:
        (WebCore::Page::refreshPlugins):
2010-08-12  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dumitru Daniliuc.

        Clear PluginData's page pointer on page refresh
        https://bugs.webkit.org/show_bug.cgi?id=43888

        * plugins/access-after-page-destroyed.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 12 Aug 2010 23:14:19 +0000 (23:14 +0000)]
2010-08-12  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        getParameter(STENCIL_VALUE_MASK) (and others) returns the wrong value
        https://bugs.webkit.org/show_bug.cgi?id=31842

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getUnsignedLongParameter): Casting from int to unsigned long correctly.
2010-08-12  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        getParameter(STENCIL_VALUE_MASK) (and others) returns the wrong value
        https://bugs.webkit.org/show_bug.cgi?id=31842

        * fast/canvas/webgl/gl-get-calls-expected.txt: Bring back the commented out STENCIL tests.
        * fast/canvas/webgl/gl-get-calls.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 12 Aug 2010 23:06:38 +0000 (23:06 +0000)]
2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: mimic FireBug's array detection.
        https://bugs.webkit.org/show_bug.cgi?id=30974

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 12 Aug 2010 22:59:25 +0000 (22:59 +0000)]
2010-08-12  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        regression in generateMipmap
        https://bugs.webkit.org/show_bug.cgi?id=43873

        * html/canvas/WebGLTexture.cpp:
        (WebCore::WebGLTexture::generateMipmapLevelInfo): should set m_needToUseBlackTexture to false if generateMipmapLevelInfo runs through successfully.
2010-08-12  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        regression in generateMipmap
        https://bugs.webkit.org/show_bug.cgi?id=43873

        * fast/canvas/webgl/texture-npot-expected.txt: Add more test cases on NPOT/POT texture behaviors.
        * fast/canvas/webgl/texture-npot.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Thu, 12 Aug 2010 22:57:40 +0000 (22:57 +0000)]
2010-08-12  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by David Hyatt.

        [Qt] Split TransparencyLayer into its own header file.
        https://bugs.webkit.org/show_bug.cgi?id=43935

        * WebCore.pro: Include TransparencyLayer.h.
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * platform/graphics/qt/TransparencyLayer.h: Added.
        (WebCore::TransparencyLayer::TransparencyLayer):
        (WebCore::TransparencyLayer::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 François Sausset <sausset@gmail.com>
commit-queue@webkit.org [Thu, 12 Aug 2010 22:53:47 +0000 (22:53 +0000)]
2010-08-12  François Sausset  <sausset@gmail.com>

        Reviewed by Beth Dakin.

        Update the tests to take into account padding changes for the mrow element.
        https://bugs.webkit.org/show_bug.cgi?id=43908

        * platform/mac/mathml/presentation/fractions-expected.checksum:
        * platform/mac/mathml/presentation/fractions-expected.png:
        * platform/mac/mathml/presentation/fractions-expected.txt:
        * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
        * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
        * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
        * platform/mac/mathml/presentation/roots-expected.checksum:
        * platform/mac/mathml/presentation/roots-expected.png:
        * platform/mac/mathml/presentation/roots-expected.txt:
        * platform/mac/mathml/presentation/row-alignment-expected.checksum:
        * platform/mac/mathml/presentation/row-alignment-expected.png:
        * platform/mac/mathml/presentation/row-alignment-expected.txt:
        * platform/mac/mathml/presentation/row-expected.checksum:
        * platform/mac/mathml/presentation/row-expected.png:
        * platform/mac/mathml/presentation/row-expected.txt:
        * platform/mac/mathml/presentation/subsup-expected.checksum:
        * platform/mac/mathml/presentation/subsup-expected.png:
        * platform/mac/mathml/presentation/subsup-expected.txt:
        * platform/mac/mathml/presentation/underover-expected.checksum:
        * platform/mac/mathml/presentation/underover-expected.png:
        * platform/mac/mathml/presentation/underover-expected.txt:
2010-08-12  François Sausset  <sausset@gmail.com>

        Reviewed by Beth Dakin.

        Horizontal padding should be 0 on mrow elements.
        https://bugs.webkit.org/show_bug.cgi?id=43908

        Updated tests in /mathml

        * css/mathml.css:
        (mrow, mfenced):
        (mfenced):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild break fix.
levin@chromium.org [Thu, 12 Aug 2010 22:42:13 +0000 (22:42 +0000)]
Build break fix.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues): Removed usage
of a variable that doesn't exist in the class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Aaron Boodman <aa@chromium.org>
aa@chromium.org [Thu, 12 Aug 2010 22:40:56 +0000 (22:40 +0000)]
2010-08-12  Aaron Boodman  <aa@chromium.org>

        Reviewed by David Hyatt.

        Make the cascade level of "user" styles configurable
        https://bugs.webkit.org/show_bug.cgi?id=43457

        * WebCore.exp.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        * dom/Document.cpp:
        (WebCore::Document::pageGroupUserSheets):
        * page/PageGroup.cpp:
        (WebCore::PageGroup::addUserStyleSheetToWorld):
        * page/PageGroup.h:
        * page/UserStyleSheet.h:
        (WebCore::UserStyleSheet::):
        (WebCore::UserStyleSheet::UserStyleSheet):
        (WebCore::UserStyleSheet::level):
2010-08-12  Aaron Boodman  <aa@chromium.org>

        Reviewed by David Hyatt.

        Make the cascade level of "user" styles configurable
        https://bugs.webkit.org/show_bug.cgi?id=43457

        * src/WebViewImpl.cpp:
        (WebKit::WebView::addUserStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix qt build break.
jianli@chromium.org [Thu, 12 Aug 2010 22:32:58 +0000 (22:32 +0000)]
Fix qt build break.

* html/ThreadableBlobRegistry.cpp:
(WebCore::postTaskToMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd ThreadableBlobRegistry to support calling BlobRegistry methods in
jianli@chromium.org [Thu, 12 Aug 2010 22:16:10 +0000 (22:16 +0000)]
Add ThreadableBlobRegistry to support calling BlobRegistry methods in
main thread.
https://bugs.webkit.org/show_bug.cgi?id=43874

Reviewed by David Levin.

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::addBlob):
(WebCore::ScriptExecutionContext::removeBlob):
(WebCore::ScriptExecutionContext::createPublicBlobURL):
(WebCore::ScriptExecutionContext::revokePublicBlobURL):
* dom/ScriptExecutionContext.h:
* html/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::~Blob):
(WebCore::Blob::contextDestroyed):
* html/Blob.h:
* html/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::unregisterBlobURL):
(WebCore::BlobRegistryImpl::getBlobDataFromURL):
* html/ThreadableBlobRegistry.cpp: Added.
* html/ThreadableBlobRegistry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTestRunner needs to run tests without using native controls
jhoneycutt@apple.com [Thu, 12 Aug 2010 22:03:00 +0000 (22:03 +0000)]
WebKitTestRunner needs to run tests without using native controls
https://bugs.webkit.org/show_bug.cgi?id=43772

Reviewed by Sam Weinig.

WebKit2:

* Shared/CoreIPCSupport/WebProcessMessageKinds.h:
(WebProcessMessage::):
Add a new message.

* UIProcess/API/C/win/WKContextPrivateWin.h: Added.
Declare WKContextSetShouldPaintNativeControls().

* UIProcess/API/C/win/WKContextWin.cpp: Added.
(WKContextSetShouldPaintNativeControls):
Call the WebContext's setShouldPaintNativeControls().

* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
Initialize m_shouldPaintNativeControls.
(WebKit::WebContext::ensureWebProcess):
If we created a web process, call platformSetUpWebProcess().

* UIProcess/WebContext.h:
Declare new functions and a member to store whether we should paint
native controls.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformSetUpWebProcess):
Stubbed.

* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::setShouldPaintNativeControls):
Set m_shouldPaintNativeControls. If we have a valid web process, send a
SetShouldPaintNativeControls message.
(WebKit::WebContext::platformSetUpWebProcess):
Send a SetShouldPaintNativeControls message.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
If this is a SetShouldPaintNativeControls message, decode the argument,
and call Settings::setShouldPaintNativeControls().

* win/WebKit2.vcproj:
Add WKContextPrivateWin.h and WKContextWin.cpp to project.

* win/WebKit2Generated.make:
Copy WKContextPrivateWin.h.

WebKitTools:

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
Call platformInitializeContext().

* WebKitTestRunner/TestController.h:
Declare platformInitializeContext().

* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformInitializeContext):
Stubbed.

* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitializeContext):
Call WKContextSetShouldPaintNativeControls() to disable native control
drawing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Thu, 12 Aug 2010 21:55:44 +0000 (21:55 +0000)]
2010-08-12  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Darin Adler.

        generate-bindings.pl should generate warning free code
        https://bugs.webkit.org/show_bug.cgi?id=43353

        * bindings/scripts/CodeGeneratorJS.pm: Suggested parentheses added around && within ||

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* runtime/UString.h: Removed unneccessary #include.
levin@chromium.org [Thu, 12 Aug 2010 21:49:25 +0000 (21:49 +0000)]
* runtime/UString.h: Removed unneccessary #include.

Reviewed by NOBODY (build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTestRunner should be more aggressive about ensuring consistent state between...
weinig@apple.com [Thu, 12 Aug 2010 21:28:24 +0000 (21:28 +0000)]
WebKitTestRunner should be more aggressive about ensuring consistent state between tests
https://bugs.webkit.org/show_bug.cgi?id=43653

Reviewed by Alexey Proskuryakov.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::isTestRunning):
(WTR::InjectedBundle::):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::stopLoading):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
Don't do any work if we are not currently running a test.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
* WebKitTestRunner/StringFunctions.h:
(WTR::toCF):
Add conversion function for WKURLRef -> CFURLRef

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::runTest):
(WTR::TestController::didFinishLoadForFrame):
* WebKitTestRunner/TestController.h:
(WTR::TestController::):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
* WebKitTestRunner/TestInvocation.h:
Move resetting code to TestController.

* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::runUntil):
* WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::runUntil):
* WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
Move runUntil to TestController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert changes to ALWAYS_INLINEness of a couple of functions in UString.
barraclough@apple.com [Thu, 12 Aug 2010 21:20:06 +0000 (21:20 +0000)]
Revert changes to ALWAYS_INLINEness of a couple of functions in UString.
This appears to have degraded performance.

Reviewed by Sam Weinig

* runtime/UString.cpp:
(JSC::UString::ascii):
* runtime/UString.h:
(JSC::UString::length):
(JSC::UString::isEmpty):
(JSC::UString::~UString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 12 Aug 2010 21:06:42 +0000 (21:06 +0000)]
2010-08-11  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        merge MarkupAccumulator and MarkupAccumulatorWrapper
        https://bugs.webkit.org/show_bug.cgi?id=43834

        Removed MarkupAccumulator and added serializeNodesWithNamespaces to use MarkupAccumulatorWrapper
        in both versions of createMarkup.  Accumulation of nodes done manually in serializeNodes is
        now done by MarkupAccumulatorWrapper as done in the original MarkupAccumulator.

        No new tests added since this is a cleanup.

        * editing/markup.cpp:
        (WebCore::MarkupAccumulatorWrapper::MarkupAccumulatorWrapper): Takes vector of nodes and set it to m_nodes.
        (WebCore::MarkupAccumulatorWrapper::insertOpenTag): Adds node to m_nodes.
        (WebCore::MarkupAccumulatorWrapper::wrapWithNode): Adds node to m_nodes.
        (WebCore::serializeNodes): Adding node to nodes is moved into MarkupAccumulatorWrapper.
        (WebCore::createMarkup): Instantiates MarkupAccumulatorWrapper.
        (WebCore::serializeNodesWithNamespaces): Renamed from MarkupAccumulator::appendMarkup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Thu, 12 Aug 2010 20:28:18 +0000 (20:28 +0000)]
2010-08-12  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Fix warnings: unknown conversion type character 'l' in format
        https://bugs.webkit.org/show_bug.cgi?id=43359

        Qt port doesn't call any printf in String::format(...), consequently
        using __attribute__((format(printf,m,n))) is incorrect and causes
        false positive warnings on Windows if you build with MinGW.

        Qt port calls QString::vsprintf(...) , which is platform
        independent, and handles %lli, %llu and %llx on all platforms.
        (http://trac.webkit.org/changeset/35712)

        * wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaselining the test results for media controls on Mac to fix
hclam@chromium.org [Thu, 12 Aug 2010 20:05:50 +0000 (20:05 +0000)]
Rebaselining the test results for media controls on Mac to fix
a regression.

Submitted for Victoria Kirst (vrk@google.com).

Reviewed by David Levin.

* platform/chromium-mac/media/audio-controls-rendering-expected.checksum:
* platform/chromium-mac/media/audio-controls-rendering-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.checksum:
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-strict-expected.checksum:
* platform/chromium-mac/media/controls-strict-expected.png:
* platform/chromium-mac/media/video-controls-rendering-expected.checksum:
* platform/chromium-mac/media/video-controls-rendering-expected.png:
* platform/chromium-mac/media/video-display-toggle-expected.checksum:
* platform/chromium-mac/media/video-display-toggle-expected.png:
* platform/chromium-mac/media/video-no-audio-expected.checksum:
* platform/chromium-mac/media/video-no-audio-expected.png:
* platform/chromium-mac/media/video-volume-slider-expected.checksum:
* platform/chromium-mac/media/video-volume-slider-expected.png:
* platform/chromium-mac/media/video-volume-slider-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Rafael Antognolli <antognolli@profusion.mobi>
demarchi@webkit.org [Thu, 12 Aug 2010 19:16:53 +0000 (19:16 +0000)]
2010-08-11  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Adding new theme for widgets.
        https://bugs.webkit.org/show_bug.cgi?id=43860

        Original theme was there for a long time. This is a new
        fresh one.

        * DefaultTheme/default.edc:
        * DefaultTheme/widget/button/button.edc:
        * DefaultTheme/widget/button/img_button_focus.png:
        * DefaultTheme/widget/button/img_button_hover.png:
        * DefaultTheme/widget/button/img_button_normal.png:
        * DefaultTheme/widget/button/img_button_press.png:
        * DefaultTheme/widget/check/check.edc:
        * DefaultTheme/widget/check/img_check_off.png:
        * DefaultTheme/widget/check/img_check_off_focus.png:
        * DefaultTheme/widget/check/img_check_off_hover.png:
        * DefaultTheme/widget/check/img_check_on.png:
        * DefaultTheme/widget/check/img_check_on_focus.png:
        * DefaultTheme/widget/check/img_check_on_hover.png:
        * DefaultTheme/widget/combo/combo.edc:
        * DefaultTheme/widget/combo/combo_focus.png:
        * DefaultTheme/widget/combo/combo_focus_button.png:
        * DefaultTheme/widget/combo/combo_hover.png:
        * DefaultTheme/widget/combo/combo_hover_button.png:
        * DefaultTheme/widget/combo/combo_normal.png:
        * DefaultTheme/widget/combo/combo_normal_button.png:
        * DefaultTheme/widget/combo/combo_press.png:
        * DefaultTheme/widget/combo/combo_press_button.png:
        * DefaultTheme/widget/combo/icon.png:
        * DefaultTheme/widget/entry/img_focused.png:
        * DefaultTheme/widget/entry/img_hovered.png:
        * DefaultTheme/widget/entry/img_normal.png:
        * DefaultTheme/widget/file/file_focus.png:
        * DefaultTheme/widget/file/file_hover.png:
        * DefaultTheme/widget/file/file_normal.png:
        * DefaultTheme/widget/file/file_press.png:
        * DefaultTheme/widget/radio/img_radio_off.png:
        * DefaultTheme/widget/radio/img_radio_off_focus.png:
        * DefaultTheme/widget/radio/img_radio_off_hover.png:
        * DefaultTheme/widget/radio/img_radio_on.png:
        * DefaultTheme/widget/radio/img_radio_on_focus.png:
        * DefaultTheme/widget/radio/img_radio_on_hover.png:
        * DefaultTheme/widget/radio/radio.edc:
        * DefaultTheme/widget/scrollbar/scrollbar.edc:
        * DefaultTheme/widget/scrollbar/scrollbar_h.png:
        * DefaultTheme/widget/scrollbar/scrollbar_hilight.png: Removed.
        * DefaultTheme/widget/scrollbar/scrollbar_knob_h.png:
        * DefaultTheme/widget/scrollbar/scrollbar_knob_v.png:
        * DefaultTheme/widget/scrollbar/scrollbar_v.png:
        * DefaultTheme/widget/search/cancel/cancel_normal_button2.png:
        * DefaultTheme/widget/search/decoration/decoration_normal_button.png:
        * DefaultTheme/widget/search/field/field_focused.png:
        * DefaultTheme/widget/search/field/field_hovered.png:
        * DefaultTheme/widget/search/field/field_normal.png:
        * DefaultTheme/widget/slider/slider.edc:
        * DefaultTheme/widget/slider/slider_fill_h.png: Added.
        * DefaultTheme/widget/slider/slider_fill_v.png: Added.
        * DefaultTheme/widget/slider/slider_h.png:
        * DefaultTheme/widget/slider/slider_hilight.png: Removed.
        * DefaultTheme/widget/slider/slider_knob_h.png:
        * DefaultTheme/widget/slider/slider_knob_press_h.png: Added.
        * DefaultTheme/widget/slider/slider_knob_press_v.png: Added.
        * DefaultTheme/widget/slider/slider_knob_v.png:
        * DefaultTheme/widget/slider/slider_v.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 12 Aug 2010 19:13:17 +0000 (19:13 +0000)]
2010-08-12  Dirk Schulze  <krit@webkit.org>

        Unreviewed sort of XCode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Gabor Loki <loki@webkit.org>
loki@webkit.org [Thu, 12 Aug 2010 18:22:34 +0000 (18:22 +0000)]
2010-08-12  Gabor Loki  <loki@webkit.org>

        Reviewed by Geoffrey Garen.

        Fix the array subscript is above array bounds warning in ByteArray on ARM.
        https://bugs.webkit.org/show_bug.cgi?id=43358

        The warning is very similar to this one: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37861

        * wtf/ByteArray.cpp:
        (WTF::ByteArray::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 12 Aug 2010 18:04:33 +0000 (18:04 +0000)]
2010-08-12  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium expectations tweak.

        Remove a duplicate linux debug expectation.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Ben Murdoch <benm@google.com>
benm@google.com [Thu, 12 Aug 2010 17:51:48 +0000 (17:51 +0000)]
2010-08-12  Ben Murdoch  <benm@google.com>

        Reviewed by Pavel Feldman.

        InspectorController.h missing InspectorObject forward declaration
        https://bugs.webkit.org/show_bug.cgi?id=43913

        Build fix so no new tests.

        * inspector/InspectorController.h: Adds the necessary forward declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd file I forgot to add in r65255.
kov@webkit.org [Thu, 12 Aug 2010 17:47:52 +0000 (17:47 +0000)]
Add file I forgot to add in r65255.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Thu, 12 Aug 2010 17:39:02 +0000 (17:39 +0000)]
2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Unreviewed.

        Adding myself to the committers list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 12 Aug 2010 17:33:35 +0000 (17:33 +0000)]
2010-08-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Use GSettings to save/restore Web Inspector settings
        https://bugs.webkit.org/show_bug.cgi?id=43512

        * GNUmakefile.am: GSettings rules.
        * configure.ac: GSettings infrastructure, and check if we should
        use it by looking for an appropriate version of GIO.

JavaScriptCore

2010-08-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Use GSettings to save/restore Web Inspector settings
        https://bugs.webkit.org/show_bug.cgi?id=43512

        * wtf/gobject/GRefPtr.cpp: Added support for GVariant, used by our
        GSettings support.
        (WTF::refGPtr):
        (WTF::derefGPtr):
        * wtf/gobject/GRefPtr.h:

WebKit/gtk

2010-08-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Use GSettings to save/restore Web Inspector settings
        https://bugs.webkit.org/show_bug.cgi?id=43512

        Use GSettings to save/restore settings used by the Web Inspector.
        A few helper functions were added to have settings that use
        boolean values be actual booleans, and also to conform with the
        GSettings naming requirements for keys.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::toGSettingName):
        (WebKit::truthStringFromVariant):
        (WebKit::variantFromTruthString):
        (WebKit::InspectorClient::populateSetting):
        (WebKit::InspectorClient::storeSetting):
        * org.webkit.gtk.gschema.xml: Added.
        * webkit/webkitprivate.cpp:
        (inspectorGSettings):
        (webkit_init):
        * webkit/webkitprivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Hayato Ito <hayato@chromium.org>
commit-queue@webkit.org [Thu, 12 Aug 2010 17:32:31 +0000 (17:32 +0000)]
2010-08-12  Hayato Ito  <hayato@chromium.org>

        Reviewed by Tony Chang.

        Merge pretty printers for gdb.
        https://bugs.webkit.org/show_bug.cgi?id=43850

        We need to update webcore.py because basic string classes have moved to WTF from WebCore.
        It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
        webcore.py is left for backward compatibility.

        * gdb/webcore.py:
        * gdb/webkit.py: Added.
        * gdb/wtf.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Thu, 12 Aug 2010 17:16:22 +0000 (17:16 +0000)]
2010-08-12  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Making CMake keep track of theme dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=43862

        Removing unused macro GENERATE_EDJ.

        * cmake/WebKitEfl.cmake:
2010-08-12  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Making CMake keep track of theme dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=43862

        Adding theme source files and images as dependencies of the theme.

        * CMakeListsEfl.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 12 Aug 2010 17:03:50 +0000 (17:03 +0000)]
2010-08-12  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium expectations tweak.

        Comment out svg/hittest/svg-rect-hit.html, as the test
        was not landed with the relevant patch.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 John Gregg <johnnyg@google.com>
johnnyg@google.com [Thu, 12 Aug 2010 16:59:15 +0000 (16:59 +0000)]
2010-08-12  John Gregg  <johnnyg@google.com>

        Reviewed by Kent Tamura.

        [chromium] Add Notification::detachPresenter to the WebKit API.
        https://bugs.webkit.org/show_bug.cgi?id=43659

        * public/WebNotification.h:
        * src/WebNotification.cpp:
        (WebKit::WebNotification::detachPresenter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 12 Aug 2010 16:33:19 +0000 (16:33 +0000)]
2010-08-11  Tony Chang  <tony@chromium.org>

        Reviewed by David Levin.

        [chromium] add google-chrome layout test result directories
        https://bugs.webkit.org/show_bug.cgi?id=43889

        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/factory.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Hui Huang <hui.2.huang@nokia.com>
commit-queue@webkit.org [Thu, 12 Aug 2010 15:58:32 +0000 (15:58 +0000)]
2010-08-12  Hui Huang  <hui.2.huang@nokia.com>

        Reviewed by Eric Seidel.

        m_windowRect is not updated because parent of PluginView is not
        set when updatePluginWidget is called. plugin gets wrong window
        size on setwindow.
        https://bugs.webkit.org/show_bug.cgi?id=43635

        * plugins/symbian/PluginViewSymbian.cpp:
        (WebCore::PluginView::setParent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 12 Aug 2010 15:37:31 +0000 (15:37 +0000)]
2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed, re-apply r65241 and 65243.

        Web Inspector: brush up object proxies, introduce remote object model.
        https://bugs.webkit.org/show_bug.cgi?id=43847

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 12 Aug 2010 15:26:51 +0000 (15:26 +0000)]
2010-08-11  Stephen White  <senorblanco@chromium.org>

        Reviewed by David Levin.

        Add support for BGRA pixel format to GraphicsContext3D.
        https://bugs.webkit.org/show_bug.cgi?id=43858

        Although this has been standard in desktop GL since 1.2, it's an
        extension in GL ES 2.0, so a query function is provided to check
        for support.  The DefaultImpl returns false, since it does not yet
        implement the TexImage2D internalFormat quirks.

        * public/WebGraphicsContext3D.h:
        (WebKit::WebGraphicsContext3D::supportsBGRA):
        * src/GraphicsContext3D.cpp:
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
        * src/WebGraphicsContext3DDefaultImpl.h:
2010-08-11  Stephen White  <senorblanco@chromium.org>

        Reviewed by David Levin.

        Add support for BGRA pixel format to GraphicsContext3D.
        https://bugs.webkit.org/show_bug.cgi?id=43858

        Although this has been standard in desktop GL since 1.2, it's an
        extension in GL ES 2.0, so a query function is provided to check
        for support.  Since they differ on semantics (GL ES 2.0 requires
        TexImage2D()'s format and internalFormat to match, while desktop GL
        will not accept BGRA as an internalFormat), the stub implementation
        returns false until these quirks have been implemented and tested on
        each port.

        * platform/graphics/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::supportsBGRA):
        Add implementation for non-chromium platforms which returns false.
        * platform/graphics/GraphicsContext3D.h:
        (WebCore::GraphicsContext3D::):
        Add query function (supportsBGRA()) and the BGRA_EXT token.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 12 Aug 2010 15:11:54 +0000 (15:11 +0000)]
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65225.
        http://trac.webkit.org/changeset/65225
        https://bugs.webkit.org/show_bug.cgi?id=43918

        Broke EFL port build (Requested by acidx on #webkit).

        * cmake/WebKitGenerators.cmake:
        * cmake/WebKitMacros.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 12 Aug 2010 15:04:51 +0000 (15:04 +0000)]
2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Rolling out r65241 and 65243 for breaking inspector tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 12 Aug 2010 13:40:38 +0000 (13:40 +0000)]
2010-08-12  Nate Chapin  <japhet@chromium.org>

        Update chromium's test_expectations.txt and provide new baselines for
        http://trac.webkit.org/changeset/65229.

        (Text-only baseline for win/linux because there are real regressions in the
        image results.  See https://bugs.webkit.org/show_bug.cgi?id=43912)

        * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
        * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
        * platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 12 Aug 2010 13:38:32 +0000 (13:38 +0000)]
2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Adding the file missing in r65241.

        * inspector/front-end/RemoteObject.js: Added.
        (WebInspector.RemoteObjectId):
        (WebInspector.RemoteObject):
        (WebInspector.RemoteObject.fromPrimitiveValue):
        (WebInspector.RemoteObject.fromNode):
        (WebInspector.RemoteObject.fromPayload):
        (WebInspector.RemoteObject.type):
        (WebInspector.RemoteObject.prototype.get objectId):
        (WebInspector.RemoteObject.prototype.get type):
        (WebInspector.RemoteObject.prototype.get description):
        (WebInspector.RemoteObject.prototype.get hasChildren):
        (WebInspector.RemoteObject.prototype.isError):
        (WebInspector.RemoteObject.prototype.getPropertyValueDescriptions):
        (WebInspector.RemoteObject.prototype.getOwnProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThe scratch register should be saved in YARR with ARM JIT
loki@webkit.org [Thu, 12 Aug 2010 13:37:55 +0000 (13:37 +0000)]
The scratch register should be saved in YARR with ARM JIT
https://bugs.webkit.org/show_bug.cgi?id=43910

Reviewed by Simon Hausmann.

Reported by Jocelyn Turcotte.

* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter):
(JSC::Yarr::RegexGenerator::generateReturn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 12 Aug 2010 13:31:30 +0000 (13:31 +0000)]
2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: brush up object proxies, introduce remote object model.
        https://bugs.webkit.org/show_bug.cgi?id=43847

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.doEvalInWindow):
        (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
        (WebInspector.ConsoleView.prototype._enterKeyPressed):
        (WebInspector.ConsoleView.prototype._format):
        (WebInspector.ConsoleView.prototype._formatnode):
        (WebInspector.ConsoleView.prototype._formatarray):
        (WebInspector.ConsoleView.prototype._formatAsArrayEntry):
        (WebInspector.ConsoleMessage.prototype._format):
        (WebInspector.ConsoleCommandResult):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
        * inspector/front-end/EventListenersSidebarPane.js:
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertiesSection.prototype.update):
        (WebInspector.ObjectPropertiesSection.prototype.updateProperties):
        (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
        (WebInspector.ObjectPropertyTreeElement.prototype.update):
        (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
        * inspector/front-end/ObjectProxy.js: Removed.
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.callback):
        * inspector/front-end/RemoteObject.js: Added.
        (WebInspector.RemoteObjectId):
        (WebInspector.RemoteObject):
        (WebInspector.RemoteObject.fromPrimitiveValue):
        (WebInspector.RemoteObject.fromErrorMessage):
        (WebInspector.RemoteObject.fromNode):
        (WebInspector.RemoteObject.fromPayload):
        (WebInspector.RemoteObject.type):
        (WebInspector.RemoteObject.prototype.get objectId):
        (WebInspector.RemoteObject.prototype.get type):
        (WebInspector.RemoteObject.prototype.get description):
        (WebInspector.RemoteObject.prototype.get hasChildren):
        (WebInspector.RemoteObject.prototype.isError):
        (WebInspector.RemoteObject.prototype.getPropertyValueDescriptions):
        (WebInspector.RemoteObject.prototype.getOwnProperties):
        (WebInspector.RemoteObject.prototype.getProperties.remoteObjectBinder):
        (WebInspector.RemoteObjectProperty):
        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
        (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
        (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._showPopup.evaluateCallback):
        (WebInspector.SourceFrame.prototype._showPopup):
        (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSection.prototype.update):
        (WebInspector.WatchExpressionTreeElement.prototype.update):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.log.logMessage):
        (WebInspector.log):
        * inspector/front-end/utilities.js:

2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: brush up object proxies, introduce remote object model.
        https://bugs.webkit.org/show_bug.cgi?id=43847

        * inspector/console-dir-expected.txt:
        * inspector/console-dir-global.html:
        * inspector/console-dir.html:
        * inspector/console-format-collections-expected.txt:
        * inspector/console-format-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Ben Murdoch <benm@google.com>
benm@google.com [Thu, 12 Aug 2010 13:27:53 +0000 (13:27 +0000)]
2010-08-12  Ben Murdoch  <benm@google.com>

        Reviewed by Steve Block.

        V8 code generator does not add V8BindingMacros.h include in all places it is needed
        https://bugs.webkit.org/show_bug.cgi?id=43907

        Adds the V8BindingMacros.h header before using the STRING_TO_V8PARAMETER_EXCEPTION_BLOCK
        macro.

        Build fix so no new tests.

        * bindings/scripts/CodeGeneratorV8.pm: include the header at the right time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 12 Aug 2010 13:09:30 +0000 (13:09 +0000)]
2010-08-12  Philippe Normand  <pnormand@igalia.com>

        Unreviewed.

        Media test baseline forgotten in r65224.

        * platform/gtk/media/audio-no-installed-engines-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
hamaji@chromium.org [Thu, 12 Aug 2010 12:36:52 +0000 (12:36 +0000)]
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65181.
        http://trac.webkit.org/changeset/65181
        https://bugs.webkit.org/show_bug.cgi?id=43909

        It broke 35 layout tests fail on chromium-win (Requested by
        hamaji on #webkit).

        * public/WebFrameClient.h:
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::detachedFromParent3):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 12 Aug 2010 12:04:26 +0000 (12:04 +0000)]
2010-08-12  Shinichiro Hamaji  <hamaji@chromium.org>

        Update chromium's test_expectations.txt

        * platform/chromium/test_expectations.txt: Two failing video related tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Thu, 12 Aug 2010 12:00:06 +0000 (12:00 +0000)]
Unreviewed.

[Qt] animations/suspend-resume-animation.html fails
https://bugs.webkit.org/show_bug.cgi?id=43905

* platform/qt/Skipped: animations/suspend-resume-animation.html skipped until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 12 Aug 2010 11:52:40 +0000 (11:52 +0000)]
2010-08-12  Shinichiro Hamaji  <hamaji@chromium.org>

        Update chromium's test_expectations.txt

        * platform/chromium/test_expectations.txt: animations/play-state is flaky on Mac

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 12 Aug 2010 11:10:47 +0000 (11:10 +0000)]
2010-08-12  Jeremy Orlow  <jorlow@chromium.org>

        Revert for now
        https://bugs.webkit.org/show_bug.cgi?id=43794

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/GroupSettings.cpp: Removed.
        * page/GroupSettings.h: Removed.
        * page/PageGroup.cpp:
        (WebCore::PageGroup::PageGroup):
        (WebCore::PageGroup::localStorage):
        * page/PageGroup.h:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setLocalStorageQuota):
        (WebCore::Settings::setLocalStorageDatabasePath):
        * page/Settings.h:
        (WebCore::Settings::localStorageQuota):
        (WebCore::Settings::localStorageDatabasePath):
2010-08-12  Jeremy Orlow  <jorlow@chromium.org>

        Revert for now
        https://bugs.webkit.org/show_bug.cgi?id=43794

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        (-[WebView _preferencesChangedNotification:]):
2010-08-12  Jeremy Orlow  <jorlow@chromium.org>

        Revert for now
        https://bugs.webkit.org/show_bug.cgi?id=43794

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
2010-08-12  Jeremy Orlow  <jorlow@chromium.org>

        Revert for now
        https://bugs.webkit.org/show_bug.cgi?id=43794

        * WebView.cpp:
        (WebView::initWithFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 12 Aug 2010 10:37:07 +0000 (10:37 +0000)]
2010-08-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Delete a test that slipped in by accident.

        * svg/zoom/page/zoom-mask.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 12 Aug 2010 10:30:31 +0000 (10:30 +0000)]
2010-08-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Follow up to Jeremys fix, just remove the context parameter, it's not needed anymore.

        * rendering/RenderSVGResourceGradient.cpp:
        (WebCore::createMaskAndSwapContextForTextGradient):
        * rendering/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::applyResource):
        * rendering/SVGImageBufferTools.cpp:
        (WebCore::SVGImageBufferTools::createImageBuffer):
        * rendering/SVGImageBufferTools.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 12 Aug 2010 10:27:51 +0000 (10:27 +0000)]
2010-08-12  Jeremy Orlow  <jorlow@chromium.org>

        Build fix.

        * rendering/SVGImageBufferTools.cpp:
        (WebCore::SVGImageBufferTools::createImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 12 Aug 2010 10:21:09 +0000 (10:21 +0000)]
2010-08-12  Jeremy Orlow  <jorlow@chromium.org>

        Build fix.  Matches solutions in qt and mac ports for
        https://bugs.webkit.org/show_bug.cgi?id=43794

        * WebView.cpp:
        (WebView::initWithFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 12 Aug 2010 10:11:08 +0000 (10:11 +0000)]
2010-08-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVG masking performance very slow
        https://bugs.webkit.org/show_bug.cgi?id=43622

        Create ImageBuffers only as large as the final rendered size on screen. Only gradient on text on CG handled this correctly so far.
        Refactored the code into a new SVGImageBufferTools class, and use the code from RenderSVGResourceMasker -> makes the IE9 demo SVG dice usable.
        Clippers, Patterns and Filters remain to be converted.

        Test: svg/zoom/page/zoom-mask-with-percentages.svg

        * Android.mk: Add SVGImageBufferTools.* to build.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * rendering/RenderSVGAllInOne.cpp: Ditto.
        * rendering/RenderSVGResourceGradient.cpp: Refactored CG gradient specific "create image buffer in absolute coordinates" code into SVGImageBufferTools class.
        (WebCore::createMaskAndSwapContextForTextGradient):
        (WebCore::clipToTextMask):
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/RenderSVGResourceMasker.cpp: Use new SVGImageBufferTools class, to avoid pixelation when zooming and to create image buffers as big as the final rendered size on screen, not more.
        (WebCore::RenderSVGResourceMasker::invalidateClients):
        (WebCore::RenderSVGResourceMasker::applyResource):
        (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
        (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect):
        (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
        * rendering/RenderSVGResourceMasker.h:
        * rendering/SVGImageBufferTools.cpp: Added.
        (WebCore::SVGImageBufferTools::absoluteTransformFromContext):
        (WebCore::SVGImageBufferTools::createImageBuffer):
        (WebCore::SVGImageBufferTools::clipToImageBuffer):
        * rendering/SVGImageBufferTools.h: Added.
        (WebCore::SVGImageBufferTools::SVGImageBufferTools):
        (WebCore::SVGImageBufferTools::~SVGImageBufferTools):

2010-08-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVG masking performance very slow
        https://bugs.webkit.org/show_bug.cgi?id=43622

        Update mask results, now that mask image buffers are as big as the finaled rendered size on screen.
        Add new test covering zooming into masks, to show that it doesn't pixelate anymore.

        * platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
        * platform/mac/svg/batik/masking/maskRegions-expected.checksum:
        * platform/mac/svg/batik/masking/maskRegions-expected.png:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
        * svg/zoom/page/zoom-mask-with-percentages.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-10 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 12 Aug 2010 10:03:23 +0000 (10:03 +0000)]
2010-08-10  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        Some settings are linked to the PageGroup not the Page.  Create a new class for those.
        https://bugs.webkit.org/show_bug.cgi?id=43794

        Since persistient storage is shared between pages, there's no way to modify
        some settings related to it on a per page basis.  As such, it's not technically
        correct for these settings to be on the Page's settings.  Create a new class
        called GroupSettings, move the 2 group-wide local storage settings there, and
        add a new setting for IndexedDB's path (which is prompting this change).

        No behavior has changed, so no tests.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/PageGroup.cpp:
        (WebCore::PageGroup::PageGroup):
        (WebCore::PageGroup::localStorage):
        * page/PageGroup.h:
        (WebCore::PageGroup::groupSettings):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setSessionStorageQuota):
        * page/Settings.h:
2010-08-10  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        Some settings are linked to the PageGroup not the Page.  Create a new class for those.
        https://bugs.webkit.org/show_bug.cgi?id=43794

        Change WebView to use the new GroupSettings class rather than Settings for the
        settings that moved.  This is sub-optimal since the settings aren't really
        per-view, but we can't really change the API at this point.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        (-[WebView _preferencesChangedNotification:]):
2010-08-11  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        Some settings are linked to the PageGroup not the Page.  Create a new class for those.
        https://bugs.webkit.org/show_bug.cgi?id=43794

        Change WebSettings to use the new GroupSettings class rather than Settings for the
        settings that moved.  This is sub-optimal since the settings aren't really
        per-view, but I don't see how we can change the API at this point.

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Decode images directly to QPixmap
hausmann@webkit.org [Thu, 12 Aug 2010 09:43:50 +0000 (09:43 +0000)]
[Qt] Decode images directly to QPixmap
https://bugs.webkit.org/show_bug.cgi?id=40797

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2010-08-12
Reviewed by Simon Hausmann.

Use the new API of Qt 4.7 to decode data from the image
reader directly to QPixmap.

This allow us to use JDCT_IFAST when decoding jpeg images
to pixmap, and to decode animated GIF images, while still
using in-place conversion of color space.

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-14 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Thu, 12 Aug 2010 09:41:14 +0000 (09:41 +0000)]
2010-07-14  Marcus Bulach  <bulach@chromium.org>

        Reviewed by darin@apple.com.

        Removes DontCheckEnums from some IDLs and fixes the corresponding enums.
        https://bugs.webkit.org/show_bug.cgi?id=42278

        This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=42250: it fixes some IDL/.h and enables generating compile-time checks for enums.

        * fast/events/init-events-expected.txt:
        * fast/events/script-tests/init-events.js:
        (createEventHelper): splits event creation so that we can test without init.
        (testInitEvent): adds test for OverflowEvent creation.
2010-07-14  Marcus Bulach  <bulach@chromium.org>

        Reviewed by darin@apple.com.

        Removes DontCheckEnums from some IDLs and fixes the corresponding enums.
        https://bugs.webkit.org/show_bug.cgi?id=42278

        This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=42250: it fixes some IDL/.h and enables generating compile-time checks for enums.

        Tests: idls should generate valid code.

        * dom/Node.h:
        (WebCore::Node::):
        * dom/Node.idl:
        * dom/OverflowEvent.h:
        (WebCore::OverflowEvent::):
        * dom/OverflowEvent.idl:
        * html/FileReader.cpp:
        (WebCore::FileReader::readyState):
        * html/FileReader.h:
        (WebCore::FileReader::):
        * html/FileReader.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Thu, 12 Aug 2010 08:50:54 +0000 (08:50 +0000)]
2010-08-12  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Nikolas Zimmermann.

        [CMake] Cleanup generator code.
        https://bugs.webkit.org/show_bug.cgi?id=39164

        * cmake/WebKitGenerators.cmake:
        * cmake/WebKitMacros.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 12 Aug 2010 08:24:07 +0000 (08:24 +0000)]
2010-08-12  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] new media tests baselines needed
        https://bugs.webkit.org/show_bug.cgi?id=42444

        Visually check those tests, they seemed fine to me so I added
        their baselines.

        * platform/gtk/Skipped:
        * platform/gtk/media/audio-controls-rendering-expected.txt: Added.
        * platform/gtk/media/video-display-toggle-expected.txt: Added.
        * platform/gtk/media/video-empty-source-expected.txt: Added.
        * platform/gtk/media/video-layer-crash-expected.txt: Added.
        * platform/gtk/media/video-no-audio-expected.txt: Added.
        * platform/gtk/media/video-transformed-expected.txt: Added.
        * platform/gtk/media/video-zoom-controls-expected.txt: Added.
        * platform/gtk/media/video-zoom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 12 Aug 2010 08:06:57 +0000 (08:06 +0000)]
2010-08-12  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by David Levin.

        The #if clause enabling a feature should avoid the all includes of
        the feature
        https://bugs.webkit.org/show_bug.cgi?id=43866

        Modified the position of the guard to avoid including all the
        headers if the feature controlling the guard is not enabled.

        * dom/make_names.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 12 Aug 2010 07:18:31 +0000 (07:18 +0000)]
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65221.
        http://trac.webkit.org/changeset/65221
        https://bugs.webkit.org/show_bug.cgi?id=43896

        Broke snow leopard build. (Requested by dave_levin on
        #webkit).

        * platform/graphics/GraphicsContext3D.cpp:
        * platform/graphics/GraphicsContext3D.h:
        (WebCore::GraphicsContext3D::):
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65221.
        http://trac.webkit.org/changeset/65221
        https://bugs.webkit.org/show_bug.cgi?id=43896

        Broke snow leopard build. (Requested by dave_levin on
        #webkit).

        * public/WebGraphicsContext3D.h:
        * src/GraphicsContext3D.cpp:
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        * src/WebGraphicsContext3DDefaultImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 12 Aug 2010 07:00:33 +0000 (07:00 +0000)]
2010-08-11  Stephen White  <senorblanco@chromium.org>

        Reviewed by David Levin.

        Add support for BGRA pixel format to GraphicsContext3D.
        https://bugs.webkit.org/show_bug.cgi?id=43858

        Although this has been standard in desktop GL since 1.2, it's an
        extension in GL ES 2.0, so a query function is provided to check
        for support.  Since they differ on semantics (GL ES 2.0 requires
        TexImage2D()'s format and internalFormat to match, while desktop GL
        will not accept BGRA as an internalFormat), the stub implementation
        returns false until these quirks have been implemented and tested on
        each port.

        * platform/graphics/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::supportsBGRA):
        Add implementation for non-chromium platforms which returns false.
        * platform/graphics/GraphicsContext3D.h:
        (WebCore::GraphicsContext3D::):
        Add query function (supportsBGRA()) and the BGRA_EXT token.
2010-08-11  Stephen White  <senorblanco@chromium.org>

        Reviewed by David Levin.

        Add support for BGRA pixel format to GraphicsContext3D.
        https://bugs.webkit.org/show_bug.cgi?id=43858

        Although this has been standard in desktop GL since 1.2, it's an
        extension in GL ES 2.0, so a query function is provided to check
        for support.  The DefaultImpl returns false, since it does not yet
        implement the TexImage2D internalFormat quirks.

        * public/WebGraphicsContext3D.h:
        (WebKit::WebGraphicsContext3D::supportsBGRA):
        * src/GraphicsContext3D.cpp:
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
        * src/WebGraphicsContext3DDefaultImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Satish Sampath <satish@chromium.org>
commit-queue@webkit.org [Thu, 12 Aug 2010 06:42:44 +0000 (06:42 +0000)]
2010-08-11  Satish Sampath  <satish@chromium.org>

        Reviewed by Kent Tamura.

        Handle clicks and recognition events for the speech input button
        https://bugs.webkit.org/show_bug.cgi?id=43857

        * rendering/RenderInputSpeech.cpp:
        (WebCore::RenderInputSpeech::paintInputFieldSpeechButton): Selects the image based on current state.
        * rendering/TextControlInnerElements.cpp:
        (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
        (WebCore::InputFieldSpeechButtonElement::set_state): Switch to a new state and update the UI.
        (WebCore::InputFieldSpeechButtonElement::didCompleteRecording):
        (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition):
        * rendering/TextControlInnerElements.h:
        (WebCore::InputFieldSpeechButtonElement::):
        (WebCore::InputFieldSpeechButtonElement::state):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 12 Aug 2010 06:31:30 +0000 (06:31 +0000)]
2010-08-11  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION(65135): format specifier warnings
        https://bugs.webkit.org/show_bug.cgi?id=43876

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::appendToBuffer): cast size_t to unsigned long for %lu.
        (WebCore::WebSocketChannel::processBuffer): cast size_t to unsigned long for %lu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix, don't generate WebDOMEventTarget.h/.cpp as we use the ones in binding...
kevino@webkit.org [Thu, 12 Aug 2010 06:02:51 +0000 (06:02 +0000)]
[wx] Build fix, don't generate WebDOMEventTarget.h/.cpp as we use the ones in bindings/cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 12 Aug 2010 05:50:10 +0000 (05:50 +0000)]
2010-08-11  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Make PendingScript copyable so that it can be stored in containers
        https://bugs.webkit.org/show_bug.cgi?id=43875

        This will be useful for storing PendingScripts in a Vector or Deque for
        async and defer scripts.

        No new tests because no functional changes.

        * dom/PendingScript.h:
        (WebCore::PendingScript::PendingScript):
        (WebCore::PendingScript::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 12 Aug 2010 04:35:42 +0000 (04:35 +0000)]
2010-08-11  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Disable accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=43894

        Disable accelerated compositing because DRT is not ready for
        it. This change fixes hundreds of test crashes on Windows and
        Linux.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetWebSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Victoria Kirst <vrk@google.com>
commit-queue@webkit.org [Thu, 12 Aug 2010 03:56:40 +0000 (03:56 +0000)]
2010-08-11  Victoria Kirst  <vrk@google.com>

        Reviewed by David Levin.

        Fixing a regression in the UI for Mac default audio/video controls.
        https://bugs.webkit.org/show_bug.cgi?id=43750

        * rendering/RenderThemeChromiumMac.h:
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderContainer):
        (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
        (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd more files to the WebKit2 skipped list.
weinig@apple.com [Thu, 12 Aug 2010 03:53:16 +0000 (03:53 +0000)]
Add more files to the WebKit2 skipped list.

Rubber-stamped by Jon Honeycutt.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 12 Aug 2010 03:13:11 +0000 (03:13 +0000)]
2010-08-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML TreeBuilder hits ASSERT in fragment case with insertAdjacentHTML and colgroup
        https://bugs.webkit.org/show_bug.cgi?id=43758

        * html5lib/runner-expected-html5.txt:
2010-08-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML TreeBuilder hits ASSERT in fragment case with insertAdjacentHTML and colgroup
        https://bugs.webkit.org/show_bug.cgi?id=43758

        This patch conditionalizes some LegacyHTMLTreeBuilder-specific code in
        HTMLElement::createContextualFragment that interferes with the new
        HTMLTreeBuilder.  Doing that exposes the above ASSERT, which I've fixed
        in this patch too.  Fixing that ASSERT involved a small refactoring in
        ExternalCharacterTokenBuffer.

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::createContextualFragment):
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingNonWhitespace):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeading):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeading):
        (WebCore::HTMLTreeBuilder::processCharacterBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 12 Aug 2010 02:55:27 +0000 (02:55 +0000)]
2010-08-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Conditionalize wrong fragment parsing code to pass more HTML5lib tests
        https://bugs.webkit.org/show_bug.cgi?id=43877

        Test progression.

        * html5lib/runner-expected-html5.txt:
2010-08-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Conditionalize wrong fragment parsing code to pass more HTML5lib tests
        https://bugs.webkit.org/show_bug.cgi?id=43877

        This code exists to support the LegacyHTMLTreeBuilder.  Unfortunately,
        it causes problems for the new HTMLTreeBuilder (which is more
        self-contained).

        * dom/Element.cpp:
        (WebCore::Element::createContextualFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 12 Aug 2010 02:37:44 +0000 (02:37 +0000)]
2010-08-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
        https://bugs.webkit.org/show_bug.cgi?id=40725

        Qt and Tiger seem to have encoding problems that swallow the --
        characters that terminate the comment.  We can avoid those problems by
        inserting a space before the -->.  We're losing coverage of these
        issues, but I'm not sure we should be in the business of debugging
        these encoders unless there's a security problem.

        Thanks to ap for investigating and finding this workaround.

        * fast/encoding/japanese-encoding-mix.html:
        * platform/mac-tiger/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd SPI to stop loading from the InjectedBundle.
weinig@apple.com [Thu, 12 Aug 2010 02:36:45 +0000 (02:36 +0000)]
Add SPI to stop loading from the InjectedBundle.

Reviewed by Gavin Barraclough.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageStopLoading):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Joone Hur <joone@kldp.org>
commit-queue@webkit.org [Thu, 12 Aug 2010 02:09:17 +0000 (02:09 +0000)]
2010-08-11  Joone Hur  <joone@kldp.org>

        Reviewed by Martin Robinson.

        [GTK] Last Hangul letter is typed again when a composition is finished with mouse press
        https://bugs.webkit.org/show_bug.cgi?id=40518

        When a mouse press fires during a IME composition, the current composition character
        can be entered twice at the previous editing position and a new editing position.
        Because the IME commit signal is emitted after the mouse press event.
        This patch allows to prevent the commit signal during a composition when a mouse press fires.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::imContextCommitted):
        (WebKit::EditorClient::handleInputMethodKeydown): Allow to accept the next composition commit.
        (WebKit::EditorClient::handleInputMethodMousePress): Added for handling IME when a mouse press fires.
        (WebKit::EditorClient::EditorClient):  Initialize m_preventNextCompositionCommit
        * WebCoreSupport/EditorClientGtk.h:
        (WebKit::EditorClient::preventNextCompositionCommit): Added for checking whether skipping a commit.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_button_press_event): Call handleInputMethodMousePress()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 12 Aug 2010 02:05:11 +0000 (02:05 +0000)]
2010-08-11  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        Can't unbold text in div in font-weight span
        https://bugs.webkit.org/show_bug.cgi?id=26871

        The bug was caused by removeInlineStyle not being able to include styled inline nodes around the start.
        Solved this problem by pushing down all inline styles instead of just text-decorations.
        This approach allows removeInlineStyle to remove styled ancestors properly and generates compact markups.

        Test: editing/style/push-down-inline-styles.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::removeCSSStyle): No longer removes attributes or node when mode == RemoveNone.
        (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Calls shouldRemoveInlineStyleFromElement
        to determine the highest ancestor whose style needs to be pushed down.
        (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Renamed from extractTextDecorationStyle.
        Extracts all inline CSS properties specified instead of just text decorations.
        (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Renamed from applyTextDecorationStyle.
        Applies inline styles using addInlineStyleIfNeeded or adds inline CSS values.
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Renamed from pushDownTextDecorationStyleAroundNode.
        (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownTextDecorationStyleAroundNode.
        * editing/ApplyStyleCommand.h:
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs): Prevents moveParagraph from preserving
        the style of an empty paragraph when merged with the previous paragraph because we don't use that style anyways.
2010-08-11  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        Can't unbold text in div in font-weight span
        https://bugs.webkit.org/show_bug.cgi?id=26871

        Added a test to push down inline styles to the leaves of DOM tree.

        * editing/deleting/delete-br-011-expected.txt: Removed redundant style spans.
        * editing/execCommand/empty-span-removal-expected.txt: Removed a span without any attributes.
        * editing/style/push-down-inline-styles-expected.txt: Added.
        * editing/style/push-down-inline-styles.html: Added.
        * editing/style/script-tests/push-down-inline-styles.js: Added.
        (testSingleToggle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
barraclough@apple.com [Thu, 12 Aug 2010 01:56:29 +0000 (01:56 +0000)]
Windows build fix.

* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Forward.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 12 Aug 2010 01:50:08 +0000 (01:50 +0000)]
2010-08-11  Shinichiro Hamaji  <hamaji@chromium.org>

        Chromium test_expectations update.

        * platform/chromium/test_expectations.txt: http/tests/storage/callbacks-are-called-in-correct-context.html is SLOW, not PASS TIMEOUT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-11 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Thu, 12 Aug 2010 01:27:11 +0000 (01:27 +0000)]
2010-08-11  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Ariya Hidayat.

        Remove dead code in CSSStyleSelector.
        https://bugs.webkit.org/show_bug.cgi?id=43805

        * css/CSSStyleSelector.cpp: Remove some debugging code that
        was compiled out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: isNativeCheckbox does not work as advertised
cfleizach@apple.com [Thu, 12 Aug 2010 01:24:10 +0000 (01:24 +0000)]
AX: isNativeCheckbox does not work as advertised
https://bugs.webkit.org/show_bug.cgi?id=43872

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/native-vs-nonnative-checkboxes.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isInputImage):
    Only say it's an input image if its role has not been overriden
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
* dom/InputElement.h:
    Add methods to query if it's a checkbox or radio button type element.
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::isCheckbox):

LayoutTests:

* platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Added.
* platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65204 268f45cc-cd09-0410-ab3c-d52691b4dbfc