rniwa@webkit.org [Thu, 8 Oct 2015 03:12:17 +0000 (03:12 +0000)]
Unreviewed race condition fix. Exit early when xScale or yScale is not defined.
* public/v2/interactive-chart.js:
(App.InteractiveChartComponent._updateRangeBarRects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 8 Oct 2015 02:26:13 +0000 (02:26 +0000)]
script.text shouldn't include text from non-direct children of the script element
https://bugs.webkit.org/show_bug.cgi?id=148851
<rdar://problem/
22587759>
Patch by Keith Rollin <krollin@apple.com> on 2015-10-07
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Rebaseline several W3C HTML tests now that new checks are passing.
* web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-expected.txt:
* web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-xhtml-expected.txt:
Source/WebCore:
Don't include text from non-direct children in script.text. Per:
https://html.spec.whatwg.org/multipage/scripting.html#dom-script-text
Chrome and Firefox behavior match the spec.
Test: fast/dom/script-subtext-in-script-elements.html
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::scriptContent):
LayoutTests:
script-getElementById-during-insertion removed because it no longer
runs correctly with this change.
* fast/dom/script-getElementById-during-insertion-expected.txt: Removed.
* fast/dom/script-getElementById-during-insertion.html: Removed.
* fast/dom/script-subtext-in-script-elements-expected.txt: Added.
* fast/dom/script-subtext-in-script-elements.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 8 Oct 2015 02:06:40 +0000 (02:06 +0000)]
Add a page that cycles through v2 dashboards
https://bugs.webkit.org/show_bug.cgi?id=149907
Reviewed by Chris Dumez.
Add cycler.html that goes through each dashboard on v2 UI.
This allows the dashboards to be cycled through on a TV screen.
* public/cycler.html: Added.
(loadURLAt): Appends a new iframe to load the next URL (i is the index of the dashboard to be shown)
at the end of body. We don't immediately show the new iframe since it might take a while to load.
(showNewFrameIfLoaded): Remove the current iframe and show the next iframe if the next dashboard has
finished loading. We can't rely on DOMContentLoaded or load events because we use asynchronous XHR to
load each chart's data. Instead, wait until some chart becomes available or fails to load and none of
charts are still in progress to be shown.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Thu, 8 Oct 2015 02:06:37 +0000 (02:06 +0000)]
Partial revert of r187626 as it caused a PLT regression
https://bugs.webkit.org/show_bug.cgi?id=149898
Reviewed by Myles C. Maxfield.
Do a partial revert of r187626 as it caused a regression on PLT.
* platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::FontDescriptionKey): Deleted.
(WebCore::FontDescriptionKey::computeHash): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mmaxfield@apple.com [Thu, 8 Oct 2015 00:55:00 +0000 (00:55 +0000)]
Test font-variant-* and font-feature-settings with TrueType fonts
https://bugs.webkit.org/show_bug.cgi?id=149776
Unreviewed follow up to r190697.
* css3/font-variant-all-webfont-expected.html:
* css3/font-variant-all-webfont.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mark.lam@apple.com [Thu, 8 Oct 2015 00:47:59 +0000 (00:47 +0000)]
[Follow up 2] Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900
Rubber stamped by Saam Barati.
Also need to surpress JSC tail call tests.
* tests/es6.yaml:
* tests/stress/dfg-tail-calls.js:
(nonInlinedTailCall.callee):
* tests/stress/mutual-tail-call-no-stack-overflow.js:
(shouldThrow):
* tests/stress/tail-call-in-inline-cache.js:
(tail):
* tests/stress/tail-call-no-stack-overflow.js:
(shouldThrow):
* tests/stress/tail-call-recognize.js:
(callerMustBeRun):
* tests/stress/tail-call-varargs-no-stack-overflow.js:
(shouldThrow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@apple.com [Thu, 8 Oct 2015 00:35:57 +0000 (00:35 +0000)]
[Win] Support 64-bit Build and Testing
https://bugs.webkit.org/show_bug.cgi?id=149904
Reviewed by Daniel Bates.
Extend our existing scripts to support 64-bit build and test operations on
Windows.
* Scripts/build-dumprendertree: We don't need to build DRT on its own;
Windows always builds the whole stack.
* Scripts/webkit-build-directory: Add an option to return the location of
the executable files produced by a specific configuration. This change is
actually useful for Gtk and EFL, too.
* Scripts/webkitdirs.pm:
(executableProductDir): Added. This function appends the proper binary
path to the productDir. This is useful for Windows, Gtk, and EFL ports.
(jscProductDir): Use the new 'executableProductDir' method.
(setPathForRunningWebKitApp): Ditto.
(runSafari): Ditto.
(runMiniBrowser): Ditto.
* Scripts/webkitpy/port/factory.py:
(configuration_options): Add a 64-bit option, used on Windows to specify
which binary target should be used for testing.
* Scripts/webkitpy/port/win.py:
(WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
processes when needed.
(WinPort._build_path): Add the correct binary target path to _build_path.
(WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
64-bit paths for 64-bit tests.
(WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
NTSD debugger does not understand this argument.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mmaxfield@apple.com [Thu, 8 Oct 2015 00:33:55 +0000 (00:33 +0000)]
Test font-variant-* and font-feature-settings with TrueType fonts
https://bugs.webkit.org/show_bug.cgi?id=149776
Reviewed by Simon Fraser.
Tools:
This test extends our existing FontWithFeatures project to be able to generate a
TrueType font. This font is conceptually similar as the existing OpenType font,
except the feature -> character mapping is different.
The font itself only supports the following characters:
ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
However, the shape of these letters are either an X or a check mark.
The letter "A" always is a check mark.
The letter "B" always is an X.
Each font feature has an letter associated with it. When the font feature is enabled,
that letter is shown as a check mark. For example, when
"kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
mark.
Here are the mappings of font features to letters:
kLigaturesType / kCommonLigaturesOnSelector: C
kLigaturesType / kContextualLigaturesOnSelector: D
kLigaturesType / kRareLigaturesOnSelector: G
kLigaturesType / kHistoricalLigaturesOnSelector: I
kContextualAlternatesType / kContextualAlternatesOnSelector: L
kVerticalPositionType / kInferiorsSelector: O
kVerticalPositionType / kSuperiorsSelector: P
kLowerCaseType / kLowerCaseSmallCapsSelector: S
kUpperCaseType / kUpperCaseSmallCapsSelector: V
kLowerCaseType / kLowerCasePetiteCapsSelector: T
kUpperCaseType / kUpperCasePetiteCapsSelector: W
kLetterCaseType / 14: Y
kStyleOptionsType / kTitlingCapsSelector: a
kNumberCaseType / kUpperCaseNumbersSelector: c
kNumberCaseType / kLowerCaseNumbersSelector: d
kNumberSpacingType / kProportionalNumbersSelector: f
kNumberSpacingType / kMonospacedNumbersSelector: g
kFractionsType / kDiagonalFractionsSelector: i
kFractionsType / kVerticalFractionsSelector: j
kVerticalPositionType / kOrdinalsSelector: Q
kTypographicExtrasType / kSlashedZeroOnSelector: k
kLigaturesType / kHistoricalLigaturesOnSelector: K
kCharacterShapeType / kJIS1978CharactersSelector: m
kCharacterShapeType / kJIS1983CharactersSelector: n
kCharacterShapeType / kJIS1990CharactersSelector: o
kCharacterShapeType / kJIS2004CharactersSelector: p
kCharacterShapeType / kSimplifiedCharactersSelector: q
kCharacterShapeType / kTraditionalCharactersSelector: r
kTextSpacingType / kMonospacedTextSelector: t
kTextSpacingType / kProportionalTextSelector: u
kRubyKanaType / kRubyKanaOnSelector: v
* FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
* FontWithFeatures/FontWithFeatures/FontCreator.cpp:
(CFFBuilder::moveTo):
(CFFBuilder::lineTo):
(GLYFBuilder::GLYFBuilder):
(GLYFBuilder::takeResult):
(GLYFBuilder::moveTo):
(GLYFBuilder::lineTo):
(GLYFBuilder::closePath):
(GLYFBuilder::writePoint):
(GLYFBuilder::append16):
(generateBoxCharString):
(generateCheckCharString):
(generateXCharString):
(itemForGlyph):
(Generator::generate):
(Generator::insertSelector):
(Generator::insertFeature):
(Generator::generateFeatureDescription):
(Generator::appendCFFTable):
(Generator::appendGLYFTable):
(Generator::appendLOCATable):
(Generator::appendFEATTable):
(Generator::appendMetamorphosisChain):
(Generator::appendMORXTable):
(Generator::appendHEADTable):
(Generator::appendHMTXTable):
(Generator::appendNameSubtable):
(Generator::append2ByteASCIIString):
(Generator::appendNAMETable):
(generateFont):
(CFFBuilder::curveToCubic): Deleted.
(charStringForGlyph): Deleted.
* FontWithFeatures/FontWithFeatures/FontCreator.h:
* FontWithFeatures/FontWithFeatures/main.cpp:
(constructFontWithTrueTypeFeature):
(constructFontWithOpenTypeFeature):
(drawText):
(main):
(drawTextWithFeature): Deleted.
LayoutTests:
* css3/font-feature-settings-rendering-2-expected.html:
* css3/font-feature-settings-rendering-2.html:
* css3/resources/FontWithFeatures.ttf: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 8 Oct 2015 00:17:21 +0000 (00:17 +0000)]
Allow custom revisions to be specified in A/B testing
https://bugs.webkit.org/show_bug.cgi?id=149905
Reviewed by Chris Dumez.
Allow custom revision number on each "repository" when creating a test group.
* public/v2/app.css:
(form .analysis-group [name=customValue]): Added.
* public/v2/app.js:
(App.AnalysisTaskController._createConfiguration): Added "Custom" as a revision option.
Also added point labels such as (point 3) on "None" for when some points are missing revision info.
(App.AnalysisTaskController._labelForPoints): Extracted from _createConfiguration.
(App.AnalysisTaskController.actions.createTestGroup): Respect the custom revision number when custom
revision option is selected.
* public/v2/index.html: Added a text field for specifying a custom revision number.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mark.lam@apple.com [Wed, 7 Oct 2015 23:34:41 +0000 (23:34 +0000)]
Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900
Reviewed by Saam Barati.
Updating the expected test result because we disabled tail calls.
* js/caller-property-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 7 Oct 2015 23:10:20 +0000 (23:10 +0000)]
Unreviewed, rolling back in r190450
https://bugs.webkit.org/show_bug.cgi?id=149727
This time for sure?
The cause of the leak was an invalidated compilation.
There was vestigial manual memory management code that eagerly removed
a CodeBlock from the set of CodeBlocks if compilation was invalidated.
That's not cool since we rely on the set of CodeBlocks when we run
destructors.
The fix is to remove the vestigial code.
I ran the leaks, correctness, and performance tests locally and did not
see any problems.
Restored changesets:
"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 7 Oct 2015 22:56:21 +0000 (22:56 +0000)]
Add API for getting a group identifier from a bundle page
https://bugs.webkit.org/show_bug.cgi?id=149902
Reviewed by Tim Horton.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyGroupIdentifier):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mark.lam@apple.com [Wed, 7 Oct 2015 22:09:04 +0000 (22:09 +0000)]
Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900
Reviewed by Saam Barati.
This is until we fix whatever the breakage is.
* runtime/Options.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 7 Oct 2015 22:05:07 +0000 (22:05 +0000)]
URTBF after r190678 to fix GTK and EFL builds.
* WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:
(WebKit::InjectedBundle::setBundleParameters):
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
(WebKit::InjectedBundle::setBundleParameters):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sukolsak@gmail.com [Wed, 7 Oct 2015 21:57:22 +0000 (21:57 +0000)]
Add an LLVM IR generator for WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=149486
Reviewed by Mark Lam.
This patch adds initial support for an LLVM IR generator in WebAssembly
(polyfill-prototype-1 format). All the methods will be implemented in
subsequent patches.
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wasm/WASMFunctionLLVMIRGenerator.h: Added.
(JSC::WASMFunctionLLVMIRGenerator::MemoryAddress::MemoryAddress):
(JSC::WASMFunctionLLVMIRGenerator::startFunction):
(JSC::WASMFunctionLLVMIRGenerator::endFunction):
(JSC::WASMFunctionLLVMIRGenerator::buildSetLocal):
(JSC::WASMFunctionLLVMIRGenerator::buildSetGlobal):
(JSC::WASMFunctionLLVMIRGenerator::buildReturn):
(JSC::WASMFunctionLLVMIRGenerator::buildImmediateI32):
(JSC::WASMFunctionLLVMIRGenerator::buildImmediateF32):
(JSC::WASMFunctionLLVMIRGenerator::buildImmediateF64):
(JSC::WASMFunctionLLVMIRGenerator::buildGetLocal):
(JSC::WASMFunctionLLVMIRGenerator::buildGetGlobal):
(JSC::WASMFunctionLLVMIRGenerator::buildConvertType):
(JSC::WASMFunctionLLVMIRGenerator::buildLoad):
(JSC::WASMFunctionLLVMIRGenerator::buildStore):
(JSC::WASMFunctionLLVMIRGenerator::buildUnaryI32):
(JSC::WASMFunctionLLVMIRGenerator::buildUnaryF32):
(JSC::WASMFunctionLLVMIRGenerator::buildUnaryF64):
(JSC::WASMFunctionLLVMIRGenerator::buildBinaryI32):
(JSC::WASMFunctionLLVMIRGenerator::buildBinaryF32):
(JSC::WASMFunctionLLVMIRGenerator::buildBinaryF64):
(JSC::WASMFunctionLLVMIRGenerator::buildRelationalI32):
(JSC::WASMFunctionLLVMIRGenerator::buildRelationalF32):
(JSC::WASMFunctionLLVMIRGenerator::buildRelationalF64):
(JSC::WASMFunctionLLVMIRGenerator::buildMinOrMaxI32):
(JSC::WASMFunctionLLVMIRGenerator::buildMinOrMaxF64):
(JSC::WASMFunctionLLVMIRGenerator::buildCallInternal):
(JSC::WASMFunctionLLVMIRGenerator::buildCallIndirect):
(JSC::WASMFunctionLLVMIRGenerator::buildCallImport):
(JSC::WASMFunctionLLVMIRGenerator::appendExpressionList):
(JSC::WASMFunctionLLVMIRGenerator::discard):
(JSC::WASMFunctionLLVMIRGenerator::linkTarget):
(JSC::WASMFunctionLLVMIRGenerator::jumpToTarget):
(JSC::WASMFunctionLLVMIRGenerator::jumpToTargetIf):
(JSC::WASMFunctionLLVMIRGenerator::startLoop):
(JSC::WASMFunctionLLVMIRGenerator::endLoop):
(JSC::WASMFunctionLLVMIRGenerator::startSwitch):
(JSC::WASMFunctionLLVMIRGenerator::endSwitch):
(JSC::WASMFunctionLLVMIRGenerator::startLabel):
(JSC::WASMFunctionLLVMIRGenerator::endLabel):
(JSC::WASMFunctionLLVMIRGenerator::breakTarget):
(JSC::WASMFunctionLLVMIRGenerator::continueTarget):
(JSC::WASMFunctionLLVMIRGenerator::breakLabelTarget):
(JSC::WASMFunctionLLVMIRGenerator::continueLabelTarget):
(JSC::WASMFunctionLLVMIRGenerator::buildSwitch):
* wasm/WASMFunctionParser.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 7 Oct 2015 21:34:12 +0000 (21:34 +0000)]
Unreviewed, rolling out r190572, r190593, r190594, and
r190639.
https://bugs.webkit.org/show_bug.cgi?id=149897
Breaks Mavericks build (Requested by litherum on #webkit).
Reverted changesets:
"Allow WKRetainPtrs to be used as keys in hashing data
structures"
https://bugs.webkit.org/show_bug.cgi?id=149762
http://trac.webkit.org/changeset/190572
"REGRESSION(189668?): http/tests/notifications/events.html
flakily asserts or times out"
https://bugs.webkit.org/show_bug.cgi?id=149218
http://trac.webkit.org/changeset/190593
"Prospective Mavericks build fix."
http://trac.webkit.org/changeset/190594
"Post-review cleanup after r190572."
http://trac.webkit.org/changeset/190639
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bburg@apple.com [Wed, 7 Oct 2015 21:25:58 +0000 (21:25 +0000)]
Unreviewed, more Mac test gardening after r190629.
* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 7 Oct 2015 21:24:54 +0000 (21:24 +0000)]
Make the site name configurable in perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=149894
Reviewed by Chris Dumez.
Added "siteTitle" as a new configuration key to specify the site name.
* public/include/db.php:
(config): Now takes the default value as an argument.
* public/include/manifest.php:
(ManifestGenerator::generate): Include siteTitle in the manifest.
* public/index.html: Update the title and the heading when the manifest is loaded.
* public/v2/index.html: Use App.Manifest.siteTitle as the heading. document.title needs to be updated manually.
* public/v2/manifest.js:
(App.MetricSerializer.normalizePayload): Update document.title and App.Manifest.siteTitle.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 7 Oct 2015 21:19:15 +0000 (21:19 +0000)]
Provide a way to get a WKFrameInfoRef from a WKFrameRef
https://bugs.webkit.org/show_bug.cgi?id=149896
rdar://problem/
23016081
Reviewed by Dan Bernstein.
* UIProcess/API/C/WKFrame.cpp:
(WKFrameCreateFrameInfo):
* UIProcess/API/C/WKFrame.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zalan@apple.com [Wed, 7 Oct 2015 21:14:16 +0000 (21:14 +0000)]
RenderObject::computeRectForRepaint/computeFloatRectForRepaint should return the computed rectangle.
https://bugs.webkit.org/show_bug.cgi?id=149883
Reviewed by Simon Fraser.
Reduces code complexity at the calling sites.
No change in functionality.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderBox.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
* rendering/RenderInline.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::selectionRectForRepaint):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::computeFloatRectForRepaint):
* rendering/RenderObject.h:
(WebCore::RenderObject::computeAbsoluteRepaintRect):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::selectionRectForRepaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):
* rendering/RenderTableCell.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::collectSelectionRectsForLineBoxes):
* rendering/RenderView.cpp:
(WebCore::RenderView::computeRectForRepaint):
* rendering/RenderView.h:
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::computeFloatRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):
* rendering/svg/RenderSVGForeignObject.h:
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::computeFloatRectForRepaint):
* rendering/svg/RenderSVGInline.h:
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::computeFloatRectForRepaint):
* rendering/svg/RenderSVGModelObject.h:
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
* rendering/svg/RenderSVGRoot.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::computeRectForRepaint):
(WebCore::RenderSVGText::computeFloatRectForRepaint):
* rendering/svg/RenderSVGText.h:
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeFloatRectForRepaint):
* rendering/svg/SVGRenderSupport.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 7 Oct 2015 21:12:15 +0000 (21:12 +0000)]
Get rid of LLInt inline/out-of-line storage helpers, they are unused
https://bugs.webkit.org/show_bug.cgi?id=149892
Reviewed by Mark Lam.
Just killing dead code.
* llint/LowLevelInterpreter.asm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 7 Oct 2015 20:46:24 +0000 (20:46 +0000)]
Add unreachable URL to _WKObservablePageState
https://bugs.webkit.org/show_bug.cgi?id=149893
<rdar://problem/
23017235>
Reviewed by Dan Bernstein.
* UIProcess/API/C/mac/WKPagePrivateMac.h:
* UIProcess/API/C/mac/WKPagePrivateMac.mm:
(-[WKObservablePageState unreachableURL]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 7 Oct 2015 20:27:46 +0000 (20:27 +0000)]
Don't setOutOfBounds in JIT code for PutByVal, since the C++ slow path already does it
https://bugs.webkit.org/show_bug.cgi?id=149885
Reviewed by Geoffrey Garen.
This simplifies the slow path code, which will make it easier to put read barriers on all of
the butterflies.
* jit/JITOperations.cpp:
(JSC::getByVal):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_val):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 7 Oct 2015 20:25:29 +0000 (20:25 +0000)]
Get rid of JIT::compilePutDirectOffset
https://bugs.webkit.org/show_bug.cgi?id=149884
Reviewed by Andreas Kling.
I'm finding more dead code.
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::compilePutDirectOffset): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 7 Oct 2015 19:59:32 +0000 (19:59 +0000)]
Implement :host pseudo class
https://bugs.webkit.org/show_bug.cgi?id=149440
Source/WebCore:
rdar://problem/
22731953
Reviewed by Ryosuke Niwa.
This implements the basic non-function :host syntax.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchHostPseudoClassRules):
(WebCore::ElementRuleCollector::matchUserRules):
* css/ElementRuleCollector.h:
* css/RuleSet.cpp:
(WebCore::computeMatchBasedOnRuleHash):
(WebCore::RuleSet::addRule):
* css/RuleSet.h:
(WebCore::RuleSet::cuePseudoRules):
(WebCore::RuleSet::hostPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/SelectorPseudoClassAndCompatibilityElementMap.in:
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
LayoutTests:
Reviewed by Ryosuke Niwa.
* fast/shadow-dom/css-scoping-shadow-host-rule.html:
Fix and expand the test case.
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 7 Oct 2015 19:41:28 +0000 (19:41 +0000)]
Heap::isWriteBarrierEnabled is unused
https://bugs.webkit.org/show_bug.cgi?id=149881
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-07
Reviewed by Geoffrey Garen.
* heap/Heap.h:
* heap/HeapInlines.h:
(JSC::Heap::isWriteBarrierEnabled): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 7 Oct 2015 19:40:17 +0000 (19:40 +0000)]
Add -[WKProcessPool _setObjectsForBundleParametersWithDictionary:]
https://bugs.webkit.org/show_bug.cgi?id=149887
Reviewed by Tim Horton.
* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setObjectsForBundleParametersWithDictionary:]):
Copy the dictionary, archive it, and set the values on the UI side bundle parameter data struct.
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
Add new SPI.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.h:
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:
(-[WKWebProcessBundleParameters setParameter:forKey:]):
We can just call setValue:forKey: on the dictionary; it will do the right thing if value is nil.
(-[WKWebProcessBundleParameters setParametersForKeyWithDictionary:]):
Enumerate the dictionary and call setValue:forKey: on each key/value pair.
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::setBundleParameter):
If we fail to unarchive a parameter, don't set it to null.
(WebKit::InjectedBundle::setBundleParameters):
Unarchive the dictionary and update the bundle parameters.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setInjectedBundleParameters):
Call the injected bundle.
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
Add new message.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bburg@apple.com [Wed, 7 Oct 2015 19:28:29 +0000 (19:28 +0000)]
Unreviewed, more Mac test gardening after r190629.
* platform/mac-wk1/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 7 Oct 2015 18:38:07 +0000 (18:38 +0000)]
Perf dashboard doesn't show analysis tasks anchored at outliers
https://bugs.webkit.org/show_bug.cgi?id=149870
Reviewed by Chris Dumez.
The bug was caused by the computation of start and end times of analysis tasks being dependent on
time series provided to the interactive chart component even though they are already filtered.
Since the interactive chart component shouldn't be messing with the underlying data models, moved
the code to compute start and end times to App.Pane, to where it belongs, and made the moved code use
the unfiltered time series newly exposed on ChartData.
Also fixed a bug in fetch-from-remote.php which resulted in Ember endlessly fetching same JSON files.
* public/admin/fetch-from-remote.php:
(.): Use the full request URI for HTTP requests and caching. Otherwise, we're going to mix up caches
and Ember can start hanging browsers (took me three hours to debug this).
* public/v2/app.js:
(App.Pane._showOutlierChanged): Added. Resets chartData when showOutlier flag has been changed.
(App.Pane.fetchAnalyticRanges): The old code wasn't filtering analysis tasks by platforms and metrics
at all since it relied on the server-side REST API to do the filtering, which I haven't implemented yet.
Filter the results manually instead.
(App.Pane.ranges): Moved the logic to compute startTime and endTime here from InteractiveChartComponent.
(App.PaneController.toggleShowOutlier): Now that App.Pane responds to showOutlier changes, we don't
need to call a private method on it.
(App.AnalysisTaskController._chartDataChanged): When end points are not found, try showing outliers.
This will cause chartData to be modified so just exit early and wait for getting called again.
* public/v2/interactive-chart.js:
(App.InteractiveChartComponent._rangesChanged): The code to compute start and end time has been moved
to App.Pane.ranges.
* public/v2/manifest.js:
(App.Manifest._formatFetchedData): Added unfiltered time series as new properties as they are now used
to compute the end points of analysis tasks when their end points are outliers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 7 Oct 2015 18:26:19 +0000 (18:26 +0000)]
JIT::emitGetGlobalProperty/emitPutGlobalProperty are only called from one place
https://bugs.webkit.org/show_bug.cgi?id=149879
Reviewed by Saam Barati.
To simplify my work to insert barriers on loads of the butterfly, I want to reduce the amount
of abstraction we have around code that loads the butterfly.
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitLoadWithStructureCheck):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitPutGlobalVariable):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitGetGlobalProperty): Deleted.
(JSC::JIT::emitPutGlobalProperty): Deleted.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitLoadWithStructureCheck):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitPutGlobalVariable):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitGetGlobalProperty): Deleted.
(JSC::JIT::emitPutGlobalProperty): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
n_wang@apple.com [Wed, 7 Oct 2015 18:17:56 +0000 (18:17 +0000)]
AX: ARIA 1.1 @aria-placeholder
https://bugs.webkit.org/show_bug.cgi?id=148970
Reviewed by Chris Fleizach.
Source/WebCore:
Added support for aria-placeholder attribute.
Modified accessibility/placeholder.html test.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::placeholderValue):
* html/HTMLAttributeNames.in:
LayoutTests:
* accessibility/placeholder-expected.txt:
* accessibility/placeholder.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 7 Oct 2015 18:04:54 +0000 (18:04 +0000)]
JIT::compileGetDirectOffset is useless
https://bugs.webkit.org/show_bug.cgi?id=149878
Reviewed by Mark Lam.
Two of the overloads of this method were never called. The other was called only from one
place, in a manner that rendered most of its code dead. This change removes the dead code and
folds the method into its one caller.
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::emitGetGlobalProperty):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::compileGetDirectOffset): Deleted.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::emitGetGlobalProperty):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::compileGetDirectOffset): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 7 Oct 2015 17:28:38 +0000 (17:28 +0000)]
Inline caches should handle out-of-line offsets out-of-line
https://bugs.webkit.org/show_bug.cgi?id=149869
Reviewed by Saam Barati.
If we want to have a concurrent copying GC, then we need a read barrier on copied space
pointers. That makes the convertible load portion of the get_by_id/put_by_id inline caches
rather challenging. Currently we have a load instruction that we can turn into an add
instruction - the add case is when we have an inline offset, and the load case is when we
have an out-of-line offset and we need to load a copied space pointer. But if the load from
copied space requires a barrier, then there is no easy way to convert that back to the inline
case.
This patch removes the convertible load. The inline path of get_by_id/put_by_id only handles
the inline offsets. Out-of-line offsets are now handled using out-of-line stubs.
* bytecode/StructureStubInfo.h:
* ftl/FTLInlineCacheSize.cpp:
(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):
* jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::finalize):
(JSC::JITByIdGenerator::generateFastPathChecks):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITGetByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
(JSC::JITPutByIdGenerator::generateFastPath):
* jit/JITInlineCacheGenerator.h:
* jit/Repatch.cpp:
(JSC::repatchByIdSelfAccess):
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
* runtime/JSObject.h:
(JSC::JSObject::butterflyTotalSize):
(JSC::indexRelativeToBase):
(JSC::offsetRelativeToBase):
(JSC::maxOffsetRelativeToBase):
(JSC::makeIdentifier):
(JSC::offsetRelativeToPatchedStorage): Deleted.
(JSC::maxOffsetRelativeToPatchedStorage): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 7 Oct 2015 16:41:29 +0000 (16:41 +0000)]
Oops, did not mean to commit this.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 7 Oct 2015 16:39:49 +0000 (16:39 +0000)]
Expose the bundle parameter object on WKBundleRef
https://bugs.webkit.org/show_bug.cgi?id=149860
Reviewed by Tim Horton.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:
(-[WKWebProcessBundleParameters description]):
Add a description that includes the parameters.
* WebProcess/InjectedBundle/API/c/mac/WKBundleMac.h:
* WebProcess/InjectedBundle/API/c/mac/WKBundleMac.mm:
(WKBundleGetParameters):
Add getter.
* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::initialize):
Make sure to decode the bundle parameters before calling out to the bundle.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bshafiei@apple.com [Wed, 7 Oct 2015 16:29:18 +0000 (16:29 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 7 Oct 2015 16:11:46 +0000 (16:11 +0000)]
Unreviewed, rolling out r190664.
https://bugs.webkit.org/show_bug.cgi?id=149877
mac build is sometimes borken due to missing generated header
file (Requested by youenn on #webkit).
Reverted changeset:
"Automate WebCore JS builtins generation and build system"
https://bugs.webkit.org/show_bug.cgi?id=149751
http://trac.webkit.org/changeset/190664
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 7 Oct 2015 15:09:02 +0000 (15:09 +0000)]
will-change should trigger stacking context based purely on properties
https://bugs.webkit.org/show_bug.cgi?id=148068
Reviewed by Zalan Bujtas.
Source/WebCore:
Previously, our will-change implementation didn't trigger stacking context
on an inline if the will-change property didn't apply to inlines (like 'transform').
However, this doesn't agree with the CSS-WG consensus (https://lists.w3.org/Archives/Public/www-style/2015Sep/0112.html).
Change behavior to have stacking context creation behavior for will-change be
identical for inlines and blocks.
Test: fast/css/will-change/will-change-creates-stacking-context-inline.html
* rendering/RenderInline.cpp:
(WebCore::inFlowPositionedInlineAncestor):
* rendering/RenderInline.h:
(WebCore::RenderInline::willChangeCreatesStackingContext):
* rendering/style/WillChangeData.cpp:
(WebCore::propertyCreatesStackingContext):
(WebCore::WillChangeData::addFeature):
(WebCore::propertyCreatesStackingContextOnBoxesOnly): Deleted.
* rendering/style/WillChangeData.h:
(WebCore::WillChangeData::canCreateStackingContextOnInline): Deleted.
LayoutTests:
Previously, our will-change implementation didn't trigger stacking context
on an inline if the will-change property didn't apply to inlines (like 'transform').
However, this doesn't agree with the CSS-WG consensus (https://lists.w3.org/Archives/Public/www-style/2015Sep/0112.html).
Change behavior to have stacking context creation behavior for will-change be
identical for inlines and blocks.
* platform/mac/TestExpectations: Fails on Mavericks because no backdrop-filter there.
* fast/css/will-change/resources/will-change-stacking-helper.js:
(makeStackingInline):
* fast/css/will-change/will-change-creates-stacking-context-inline-expected.html: Added.
* fast/css/will-change/will-change-creates-stacking-context-inline.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 7 Oct 2015 14:59:11 +0000 (14:59 +0000)]
[EFL] fast/repaint/block-inputrange-repaint.html is failed.
https://bugs.webkit.org/show_bug.cgi?id=149517
Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2015-10-07
Reviewed by Zalan Bujtas.
EFL thumb size is different with mac port, it causes the difference of repaintRect.
So rebaseline the test with failure result.
* platform/efl/fast/repaint/block-inputrange-repaint-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jfernandez@igalia.com [Wed, 7 Oct 2015 13:14:11 +0000 (13:14 +0000)]
[CSS Grid Layout] Modify grid item height doesn't work
https://bugs.webkit.org/show_bug.cgi?id=149840
Reviewed by Sergio Villar Senin.
Source/WebCore:
When computing the logical height of content-sized grid tracks we
need to clear grid item's override height if it needs to be laid
out again.
Currently we are doing so only in the case of percentage heights
or when the grid track's width has changed; these situations would
obviously mark grid items as needing layout.
However, there are other situations, like the one defined in this
bug, which would imply a new layout of the grid items; hence we
need to clear its override value if we want the layout logic to be
computed correctly.
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalContentHeightForChild):
LayoutTests:
Added new tests cases to verify content-sized grid tracks are resized
appropriately whenever grid item's height is changed.
* fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change-expected.txt: Added new test cases.
* fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change.html: Added new test cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
youenn.fablet@crf.canon.fr [Wed, 7 Oct 2015 12:52:33 +0000 (12:52 +0000)]
Automate WebCore JS builtins generation and build system
https://bugs.webkit.org/show_bug.cgi?id=149751
Reviewed by Darin Adler.
Source/JavaScriptCore:
* generate-js-builtins: updating the part related to WebCore JS binding.
Source/WebCore:
Adding annotations to JS files to know whether they should be under a compilation flag and
whether they are JS internals or JS tied to WebIDL.
If a file is said as JS internals, all function names are exported automatically.
Added auto generation of WebCoreJSBuiltins.cpp
Added auto generation of JSBuiltinFunctions class inside WebCoreJSBuiltins that takes the role of
WebCoreJSClientData as wrapper for builtins. Renamed WebCoreJSClientData to JSClientData.
Added auto generation of PrivateWebCoreJSBuiltins that is a wrapper around all private functions, used by
JSDOMWindowBase. The class is named JSBuiltinInternalFunctions.
The remaining manual part for private functions is the pairing between private identifiers and
the private JS functions within JSDOMWindowBase::finishCreation.
Covered by existing tests.
* CMakeLists.txt:
* DerivedSources.make:
* Modules/streams/ByteLengthQueuingStrategy.js:
* Modules/streams/CountQueuingStrategy.js:
* Modules/streams/ReadableStream.js:
* Modules/streams/ReadableStreamInternals.js:
* WebCore.order:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::visitChildren):
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
* bindings/js/WebCoreJSClientData.h:
(WebCore::JSClientData::JSClientData):
(WebCore::JSClientData::~JSClientData):
(WebCore::JSClientData::builtinFunctions):
(WebCore::initNormalWorldClientData):
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::readableStreamBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamControllerBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamReaderBuiltins): Deleted.
(WebCore::WebCoreJSClientData::byteLengthQueuingStrategyBuiltins): Deleted.
(WebCore::WebCoreJSClientData::countQueuingStrategyBuiltins): Deleted.
* generate-js-builtins-allinone: Added.
(retrieveGenerationParameters):
(retrieveFilesWithParameters):
(retrieveFilesWithParameters.FileInput):
(writeConditional):
(JSBuiltinFunctions):
(Private):
(JSBuiltinInternalFunctions):
(copytempfile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
svillar@igalia.com [Wed, 7 Oct 2015 09:40:44 +0000 (09:40 +0000)]
[css-grid] Implement grid gutters
https://bugs.webkit.org/show_bug.cgi?id=149800
Reviewed by Darin Adler.
Source/WebCore:
Authors can now specify the gutters between grid lines, i.e.,
the space between two consecutive grid lines. This can be done
using the new '-webkit-grid-column-gap 'and
'-webkit-grid-row-gap' properties (or the '-webkit-grid-gap'
shorthand).
From the track sizing algorithm POV, gutters are treated as
fixed size columns. The primary consequence is that grids are
enlarged (depending on the number of tracks). Gutters also
affect the sizing of content-sized tracks and fr tracks as
long as the grid have spanning items. Those tracks will become
smaller as gutters will consume part of the item's size, so
the tracks won't need to grow as much as they used to.
Tests: fast/css-grid-layout/grid-gutters-and-alignment.html
fast/css-grid-layout/grid-gutters-and-flex-content.html
fast/css-grid-layout/grid-gutters-and-tracks.html
fast/css-grid-layout/grid-gutters-get-set.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridTrackList):
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridGapShorthand):
* css/CSSParser.h:
* css/CSSPropertyNames.in:
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::guttersSize):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
* rendering/RenderGrid.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
* rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):
LayoutTests:
Added several new test cases to verify that gutters are
properly considered when sizing and also to check that they do
not modify the current behavior. As many existing tests were
reused I took the chance to refactor some testing code related
to alignment so that it could be reused by many different
tests.
* fast/css-grid-layout/grid-align-content.html:
* fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-lr.html:
* fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-rl.html:
* fast/css-grid-layout/grid-align-justify-margin-border-padding.html:
* fast/css-grid-layout/grid-align.html:
* fast/css-grid-layout/grid-gutters-and-alignment-expected.txt: Added.
* fast/css-grid-layout/grid-gutters-and-alignment.html: Added.
* fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt: Added.
* fast/css-grid-layout/grid-gutters-and-flex-content.html: Added.
* fast/css-grid-layout/grid-gutters-and-tracks-expected.txt: Added.
* fast/css-grid-layout/grid-gutters-and-tracks.html: Added.
* fast/css-grid-layout/grid-gutters-get-set-expected.txt: Added.
* fast/css-grid-layout/grid-gutters-get-set.html: Added.
* fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html:
* fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html:
* fast/css-grid-layout/grid-justify-content.html:
* fast/css-grid-layout/resources/grid-alignment.css: Added.
(.alignSelfAuto):
(.alignSelfStretch):
(.alignSelfStart):
(.alignSelfEnd):
(.alignSelfCenter):
(.alignSelfRight):
(.alignSelfLeft):
(.alignSelfFlexStart):
(.alignSelfFlexEnd):
(.alignSelfSelfStart):
(.alignSelfSelfEnd):
(.alignItemsCenter):
(.alignContentBaseline):
(.alignContentLastBaseline):
(.alignContentStart):
(.alignContentEnd):
(.alignContentCenter):
(.alignContentLeft):
(.alignContentRight):
(.alignContentFlexStart):
(.alignContentFlexEnd):
(.justifyContentBaseline):
(.justifyContentLastBaseline):
(.justifyContentStart):
(.justifyContentEnd):
(.justifyContentCenter):
(.justifyContentLeft):
(.justifyContentRight):
(.justifyContentFlexStart):
(.justifyContentFlexEnd):
(.justifyContentSpaceBetween):
(.justifyContentSpaceAround):
(.justifyContentSpaceEvenly):
(.justifyContentStretch):
(.itemsCenter):
(.itemsEnd):
(.itemsLeft):
(.itemsRight):
(.itemsSelfStart):
(.itemsSelfEnd):
* fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:
(testGridGapDefinitionsValues):
* fast/css-grid-layout/resources/grid.css:
(.firstRowThirdColumn):
(.secondRowThirdColumn):
(.firstRowFourthColumn):
(.secondRowFourthColumn):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
changseok.oh@collabora.com [Wed, 7 Oct 2015 07:32:14 +0000 (07:32 +0000)]
[GTK] Progress bar is broken on recent GTK+
https://bugs.webkit.org/show_bug.cgi?id=149831
Reviewed by Carlos Garcia Campos.
Source/WebCore:
The gtk progress bar has been broken after bumping up to Gtk+-3.16. This is because
the way of rendering progress bar changed after gtk+-3.13.7. See more
https://mail.gnome.org/archives/commits-list/2014-August/msg03865.html
gtk_render_activity is no longer valid to paint a progress bar on a newer gtk+.
It should be done with gtk_render_background and gtk_render_frame.
Test: fast/dom/HTMLProgressElement/native-progress-bar.html
* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintProgressBar):
LayoutTests:
* fast/dom/HTMLProgressElement/native-progress-bar.html: Added.
* platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
* platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
* platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
* platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 7 Oct 2015 07:11:08 +0000 (07:11 +0000)]
Unreviewed. Fix a typo in r190645.
* public/include/db.php:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mcatanzaro@igalia.com [Wed, 7 Oct 2015 04:08:25 +0000 (04:08 +0000)]
[GTK] Add autocleanups
https://bugs.webkit.org/show_bug.cgi?id=149588
Reviewed by Darin Adler.
Source/WebCore:
* PlatformGTK.cmake:
* bindings/scripts/gobject-generate-headers.pl:
Source/WebKit2:
* PlatformGTK.cmake:
* UIProcess/API/gtk/WebKitAutocleanups.h: Added.
* UIProcess/API/gtk/webkit2.h:
* WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionAutocleanups.h: Added.
* WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:
Tools:
* TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
(AutocleanupsTest::create):
(AutocleanupsTest::testWebProcessAutocleanups):
(registerTests):
* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
* TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
(testUIProcessAutocleanups):
(testWebProcessAutocleanups):
(beforeAll):
(afterAll):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Wed, 7 Oct 2015 03:35:26 +0000 (03:35 +0000)]
Unreviewed iOS test gardening after r190629.
* platform/ios-simulator/TestExpectations:
* platform/ios-simulator-wk1/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zalan@apple.com [Wed, 7 Oct 2015 02:51:29 +0000 (02:51 +0000)]
Paint artifacts when hovering on jsfiddle.net/Sherbrow/T87Mn/
https://bugs.webkit.org/show_bug.cgi?id=149535
rdar://problem/
22874920
Reviewed by Simon Fraser.
When due to some style change, a renderer's self-painting layer is getting destroyed
and the parent's overflow is no longer set to visible, we don't clean up the overflow part.
When a renderer has a self-painting layer, the parent stops tracking the child's
visual overflow rect. All overflow painting is delegated to the self-painting layer.
However when this layer gets destroyed, no-one issues repaint to clean up
the overflow bits.
This patch ensures that we issue a repaint when the self-painting layer is destroyed
and the triggering style change requires full repaint.
Source/WebCore:
Test: fast/repaint/overflow-hidden-with-self-painting-child-layer.html
* rendering/RenderLayer.h:
* rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
LayoutTests:
* css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt: progression.
* fast/repaint/absolute-position-change-containing-block-expected.txt: progression.
* fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt: Added.
* fast/repaint/overflow-hidden-with-self-painting-child-layer.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Wed, 7 Oct 2015 02:11:09 +0000 (02:11 +0000)]
More unreviewed Windows test gardening after r190629.
* platform/win/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Wed, 7 Oct 2015 02:07:19 +0000 (02:07 +0000)]
Unreviewed Windows test gardening after r190629.
* platform/win/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 7 Oct 2015 01:24:54 +0000 (01:24 +0000)]
[Mac] REGRESSION(r173318): Seeks never complete for media loaded with QTKit.
https://bugs.webkit.org/show_bug.cgi?id=149845
Reviewed by Darin Adler.
When converting from time-as-double to MediaTime, a regression was introduced
when checking whether m_seekTo was set to a valid value or not. The clause
`time != -1` should be translated to `time.isValid()`, not `!time.isValid()`.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::timeChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Wed, 7 Oct 2015 01:12:54 +0000 (01:12 +0000)]
Unreviewed Mac test gardening after r190629.
* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 7 Oct 2015 00:06:59 +0000 (00:06 +0000)]
Rename IDBRequestIdentifier to IDBResourceIdentifier.
https://bugs.webkit.org/show_bug.cgi?id=149861
Reviewed by Alex Christensen.
No new tests (No change in behavior).
Turns out having an object representing a (connection ID + unique ID pair) is useful for more than just IDBRequests.
* CMakeLists.txt:
* Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::deleteDatabase):
(WebCore::IDBClient::IDBConnectionToServer::openDatabase):
* Modules/indexeddb/client/IDBConnectionToServer.h:
* Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::IDBRequest):
* Modules/indexeddb/client/IDBRequestImpl.h:
(WebCore::IDBClient::IDBRequest::resourceIdentifier):
(WebCore::IDBClient::IDBRequest::requestIdentifier): Deleted.
* Modules/indexeddb/shared/IDBRequestData.h:
(WebCore::IDBRequestData::requestIdentifier):
* Modules/indexeddb/shared/IDBResourceIdentifier.cpp: Renamed from Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.cpp.
(WebCore::nextResourceNumber):
(WebCore::IDBResourceIdentifier::IDBResourceIdentifier):
(WebCore::IDBResourceIdentifier::emptyValue):
(WebCore::IDBResourceIdentifier::deletedValue):
(WebCore::IDBResourceIdentifier::isHashTableDeletedValue):
* Modules/indexeddb/shared/IDBResourceIdentifier.h: Renamed from Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h.
(WebCore::IDBResourceIdentifier::isEmpty):
(WebCore::IDBResourceIdentifier::hash):
(WebCore::IDBResourceIdentifier::operator==):
(WebCore::IDBResourceIdentifier::connectionIdentifier):
(WebCore::IDBResourceIdentifierHash::hash):
(WebCore::IDBResourceIdentifierHash::equal):
(WebCore::IDBResourceIdentifierHashTraits::emptyValue):
(WebCore::IDBResourceIdentifierHashTraits::isEmptyValue):
(WebCore::IDBResourceIdentifierHashTraits::constructDeletedValue):
(WebCore::IDBResourceIdentifierHashTraits::isDeletedValue):
* Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::IDBResultData):
* Modules/indexeddb/shared/IDBResultData.h:
(WebCore::IDBResultData::requestIdentifier):
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bburg@apple.com [Wed, 7 Oct 2015 00:05:37 +0000 (00:05 +0000)]
Unreviewed, try to fix the iOS 8 build after r190368.
On older versions, IOHIDEventCreateForceEvent is not available.
* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nvasilyev@apple.com [Tue, 6 Oct 2015 23:22:39 +0000 (23:22 +0000)]
Web Inspector: Clicking on a stack trace link does not navigate to the corresponding line
https://bugs.webkit.org/show_bug.cgi?id=149405
lineNumber should be a number type but it was a string.
Reviewed by Timothy Hatcher.
* UserInterface/Base/Main.js:
(WebInspector.openURL):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
Keep lineNumber undefined when it isn't present in the string.
WebInspector.linkifyStringAsFragmentWithCustomLinkifier is only used by
WebInspector.linkifyStringAsFragment and it expects lineNumber to be undefined
when it wasn't found in the parsed string.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keith_miller@apple.com [Tue, 6 Oct 2015 22:40:45 +0000 (22:40 +0000)]
Add gmalloc option to run-javascriptcore-tests.
https://bugs.webkit.org/show_bug.cgi?id=149858
Reviewed by Geoffrey Garen.
run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
* Scripts/run-javascriptcore-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mark.lam@apple.com [Tue, 6 Oct 2015 22:29:27 +0000 (22:29 +0000)]
Factoring out op_sub baseline code generation into JITSubGenerator.
https://bugs.webkit.org/show_bug.cgi?id=149600
Reviewed by Geoffrey Garen.
We're going to factor out baseline code generation into snippet generators so
that we can later use them in the DFG and FTL to emit code for to perform the
JS operations where the operand types are predicted to be polymorphic.
We are starting in this patch with the implementation of op_sub.
What was done in this patch:
1. Created JITSubGenerator based on the baseline implementation of op_sub as
expressed in compileBinaryArithOp() and compileBinaryArithOpSlowCase().
I did not attempt to do write a more optimal version of op_sub. I'll
leave that to a later patch.
2. Convert the 32-bit op_sub baseline implementation to use the same
JITSubGenerator which was based on the 64-bit implementation. The
pre-existing 32-bit baseline op_sub had handling for more optimization cases.
However, a benchmark run shows that simply going with the 64-bit version
(foregoing those extra optimizations) did not change the performance.
Also, previously, the 32-bit version was able to move double results directly
into the result location on the stack directly. By using JITSubGenerator,
we now always move that result into a pair of GPRs before storing it into
the stack location.
3. Add some needed emitters to AssemblyHelpers that play nice with JSValueRegs.
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::boxDouble):
(JSC::AssemblyHelpers::unboxDouble):
(JSC::AssemblyHelpers::boxBooleanPayload):
* jit/JIT.h:
(JSC::JIT::linkDummySlowCase):
* jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_sub): Deleted.
(JSC::JIT::emitSub32Constant): Deleted.
(JSC::JIT::emitSlow_op_sub): Deleted.
* jit/JITInlines.h:
(JSC::JIT::linkSlowCaseIfNotJSCell):
(JSC::JIT::linkAllSlowCasesForBytecodeOffset):
(JSC::JIT::addSlowCase):
(JSC::JIT::emitLoad):
(JSC::JIT::emitGetVirtualRegister):
(JSC::JIT::emitPutVirtualRegister):
* jit/JITSubGenerator.h: Added.
(JSC::JITSubGenerator::JITSubGenerator):
(JSC::JITSubGenerator::generateFastPath):
(JSC::JITSubGenerator::slowPathJumpList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
n_wang@apple.com [Tue, 6 Oct 2015 21:46:08 +0000 (21:46 +0000)]
AX: ARIA 1.1: aria-orientation now defaults to undefined, supported on more elements, and role-specific defaults are defined.
https://bugs.webkit.org/show_bug.cgi?id=132177
Reviewed by Chris Fleizach.
Source/WebCore:
Added role-specific defaults and changed general default to undefined.
Also added more elements to support aria-orientation on Mac.
Test: accessibility/mac/aria-orientation.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::orientation):
(WebCore::AccessibilityObject::isDescendantOfObject):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isColorWell):
(WebCore::AccessibilityObject::isSplitter):
(WebCore::AccessibilityObject::isToolbar):
(WebCore::AccessibilityObject::isChecked):
(WebCore::AccessibilityObject::isEnabled):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::orientation):
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::scrollBar):
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::orientation):
(WebCore::AccessibilityScrollbar::isEnabled):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
LayoutTests:
* accessibility/mac/aria-orientation-expected.txt: Added.
* accessibility/mac/aria-orientation.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 6 Oct 2015 21:41:56 +0000 (21:41 +0000)]
V2 UI shouldn't sort dashboards lexicologically
https://bugs.webkit.org/show_bug.cgi?id=149856
Reviewed by Chris Dumez.
Don't sort the dashboards by name in App.Manifest.
* public/v2/app.js:
(App.IndexRoute.beforeModel): Don't transition to "undefined" (string) dashboard.
* public/v2/manifest.js:
(App.Manifest.._fetchedManifest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 6 Oct 2015 21:21:44 +0000 (21:21 +0000)]
V2 UI fails to show the data for the very first point in charts
https://bugs.webkit.org/show_bug.cgi?id=149857
Reviewed by Chris Dumez.
The bug was caused by seriesBetweenPoints returning null for when point.seriesIndex is 0.
Explicitly check the type of this property instead.
* public/v2/data.js:
(TimeSeries.prototype.seriesBetweenPoints):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 6 Oct 2015 21:04:03 +0000 (21:04 +0000)]
Perf dashboard should have the capability to test local UI with production data
https://bugs.webkit.org/show_bug.cgi?id=149834
Reviewed by Chris Dumez.
Added tools/run-with-remote-server.py which runs a local httpd server and pulls data from a remote server.
* Install.md: Added the instruction on how to use the script. Also updated the remaining instructions
for El Capitan.
* config.json: Added remote server configurations.
* public/admin/fetch-from-remote.php: Added. This script fetches JSON from the remote server specified in
config.json and caches the results in the location specified as "cacheDirectory" in config.json.
(main):
(fetch_remote):
* public/include/db.php:
(config_path): Extracted from generate_data_file.
(generate_data_file):
* tools/remote-server-relay.conf: Added. Apache 2.4 configuration file for a local http server launched by
run-with-remote-server.py.
* tools/run-with-remote-server.py: Added. Launches Apache with the right set of directives.
(main):
(abspath_from_root):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 6 Oct 2015 20:57:22 +0000 (20:57 +0000)]
Mark compositing/geometry/limit-layer-bounds-opacity-transition.html as failing
on iOS WK2.
* platform/ios-simulator-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
peavo@outlook.com [Tue, 6 Oct 2015 20:45:07 +0000 (20:45 +0000)]
[WinCairo] GStreamer compile errors.
https://bugs.webkit.org/show_bug.cgi?id=149839
Reviewed by Alex Christensen.
Help MSVC to resolve ambiguous calls.
* platform/graphics/MediaPlayer.h:
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged):
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::networkState):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::activeChanged):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcChangeState):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 20:43:36 +0000 (20:43 +0000)]
Take 2 on marking compositing/video/video-poster.html as flaky due to crashes.
https://bugs.webkit.org/show_bug.cgi?id=149819
Patch by Ryan Haddad <ryanhaddad@apple.com> on 2015-10-06
Reviewed by Alexey Proskuryakov.
* platform/mac-elcapitan/TestExpectations: Removed.
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Tue, 6 Oct 2015 20:40:52 +0000 (20:40 +0000)]
Refactor TokenPreloadScanner::StartTagScanner::processAttribute()
https://bugs.webkit.org/show_bug.cgi?id=149847
Reviewed by Antti Koivisto.
Refactor TokenPreloadScanner::StartTagScanner::processAttribute() to only
process attributes that make sense given the current tagId. In particular,
- We only process the charset parameter if the tag is a link or a script.
- We only process the sizes / srcset attributes if the tag is an img.
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::StartTagScanner::setUrlToLoad): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 20:28:25 +0000 (20:28 +0000)]
Web Inspector: Fix spacing of FindBanner prev/next buttons
https://bugs.webkit.org/show_bug.cgi?id=149717
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2015-10-06
Reviewed by Darin Adler.
The sizing and spacing of the previous and next buttons in the FindBanner
is slightly off and should be readjusted to ensure that both buttons are
the same size and have the same spacing.
* UserInterface/Views/FindBanner.css:
(.find-banner > button.segmented.right > .glyph):
(.find-banner > button.segmented):
(.find-banner > button.segmented > .glyph):
(.find-banner > button.segmented.left): Deleted.
(.find-banner > button.segmented.left > .glyph): Deleted.
(.find-banner > button.segmented.right): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mmaxfield@apple.com [Tue, 6 Oct 2015 20:26:32 +0000 (20:26 +0000)]
Post-review cleanup after r190572.
Unreviewed.
* TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 6 Oct 2015 20:26:17 +0000 (20:26 +0000)]
Try to fix the 32-bit build.
* UIProcess/API/C/mac/WKPagePrivateMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
youenn.fablet@crf.canon.fr [Tue, 6 Oct 2015 20:14:08 +0000 (20:14 +0000)]
Binding generator XXConstructor::finishCreation should take references as parameters
https://bugs.webkit.org/show_bug.cgi?id=149838
Reviewed by Darin Adler.
Updated the binding generator so that XXConstructor::finishCreation
takes a JSDOMGlobalObject& in lieu of a JSDOMGlobalObject*.
Covered by rebased binding tests.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::create):
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallbackConstructor::create):
(WebCore::JSTestCallbackConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::create):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::create):
(WebCore::JSTestEventTargetConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachableConstructor::create):
(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorConstructor::create):
(WebCore::JSTestJSBuiltinConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::create):
(WebCore::JSTestNamedConstructorNamedConstructor::create):
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::create):
(WebCore::JSTestNodeConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministicConstructor::create):
(WebCore::JSTestNondeterministicConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::create):
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltinsConstructor::create):
(WebCore::JSTestOverrideBuiltinsConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::create):
(WebCore::JSTestTypedefsConstructor::finishCreation):
* bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeConstructor::create):
(WebCore::JSattributeConstructor::finishCreation):
* bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyConstructor::create):
(WebCore::JSreadonlyConstructor::finishCreation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@apple.com [Tue, 6 Oct 2015 20:08:57 +0000 (20:08 +0000)]
[Win] Unreviewed build correction.
* TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
are soft-linked at runtime.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 19:48:24 +0000 (19:48 +0000)]
Fix crash in ApplyStyleCommand::applyRelativeFontStyleChange()
https://bugs.webkit.org/show_bug.cgi?id=149300
<rdar://problem/
22747046>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-06
Reviewed by Chris Dumez.
Source/WebCore:
This is a merge of Blink r167845 and r194944:
https://codereview.chromium.org/
177093016
https://codereview.chromium.org/
1124863003
Test: editing/style/apply-style-crash2.html
editing/style/apply-style-crash3.html
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
The issue was that we would traverse the DOM tree past the beyondEnd
under some circumstances and thus NodeTraversal::next() would return
null unexpectedly. This CL adds a check to make sure startNode != beyondEnd
before traversing to avoid the problem.
Besides that, this CL hardens changing font style over unknown elements.
When adjusting the start node position of where to apply a font style
command, check that we haven't stepped off the end.
This CL also adds a few more assertions to catch similar issues
more easily in the future.
LayoutTests:
* editing/style/apply-style-crash2-expected.txt: Added.
* editing/style/apply-style-crash2.html: Added.
* editing/style/apply-style-crash3-expected.txt: Added.
* editing/style/apply-style-crash3.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jfernandez@igalia.com [Tue, 6 Oct 2015 19:23:52 +0000 (19:23 +0000)]
[CSS Grid Layout] Don't need to reset auto-margins during grid items layout
https://bugs.webkit.org/show_bug.cgi?id=149764
Reviewed by Darin Adler.
Source/WebCore:
This patch implements a refactoring of the auto-margin alignment code for grid
items so it uses start/end and before/after margin logic terms.
I addition, it avoids resetting the auto-margin values, which requires an extra
layout, before applying the alignment logic.
No new tests because there is no behavior change.
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeMarginLogicalHeightForChild): Computing margins if child needs layout.
(WebCore::RenderGrid::availableAlignmentSpaceForChildBeforeStretching):
(WebCore::RenderGrid::updateAutoMarginsInRowAxisIfNeeded): Using start/end logical margins.
(WebCore::RenderGrid::updateAutoMarginsInColumnAxisIfNeeded): Using before/after logical margins.
(WebCore::RenderGrid::columnAxisOffsetForChild): Just added comment.
(WebCore::RenderGrid::rowAxisOffsetForChild): Just added comment.
LayoutTests:
Removed a duplicated layout tests.
* fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change-expected.txt: Removed.
* fast/css-grid-layout/grid-item-should-not-be-stretched-when-height-or-margin-change.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 19:13:46 +0000 (19:13 +0000)]
Web Inspector: Simplify TimelineRecordBar a bit
https://bugs.webkit.org/show_bug.cgi?id=149733
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-06
Reviewed by Timothy Hatcher.
* UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar.prototype.set records):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 6 Oct 2015 19:11:24 +0000 (19:11 +0000)]
WKPage needs to expose a KVO-compliant object, similar to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=149851
rdar://problem/
22382022
Reviewed by Dan Bernstein.
Move the PageLoadStateObserver object from WKBrowsingContextController out into a separate file and make it
work with any Objective-C object. Use it in WKObservablePageState and add a WKPageCreateObservableState function.
* UIProcess/API/C/mac/WKPagePrivateMac.h:
* UIProcess/API/C/mac/WKPagePrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.cpp.
(-[WKObservablePageState initWithPage:]):
(-[WKObservablePageState dealloc]):
(-[WKObservablePageState isLoading]):
(-[WKObservablePageState title]):
(-[WKObservablePageState URL]):
(-[WKObservablePageState hasOnlySecureContent]):
(-[WKObservablePageState estimatedProgress]):
(WKPageCreateObservableState):
(WKPageGetProcessIdentifier):
(WKPageIsURLKnownHSTSHost):
* UIProcess/API/Cocoa/PageLoadStateObserver.h: Added.
(WebKit::PageLoadStateObserver::PageLoadStateObserver):
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(PageLoadStateObserver::PageLoadStateObserver): Deleted.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keith_miller@apple.com [Tue, 6 Oct 2015 18:45:04 +0000 (18:45 +0000)]
Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
https://bugs.webkit.org/show_bug.cgi?id=149815
Reviewed by Filip Pizlo.
Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
so should just use one test runner.
* Scripts/run-javascriptcore-tests:
(runJSCStressTests):
(runMozillaTests): Deleted.
(defaultJsDriverArgsForMozillaTests): Deleted.
* Scripts/run-jsc-stress-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Tue, 6 Oct 2015 18:39:21 +0000 (18:39 +0000)]
Import some Blink layout tests.
https://bugs.webkit.org/show_bug.cgi?id=149768
These are a subset of tests that don't time out and whose expected
results in Blink match the results in WebKit when run under DRT and
WKTR.
Reviewed by Andy Estes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Tue, 6 Oct 2015 18:20:29 +0000 (18:20 +0000)]
Tile map shows a green rect when threaded scrolling is disabled
https://bugs.webkit.org/show_bug.cgi?id=149716
Reviewed by Darin Adler.
Green is supposed to indicate that we're using the fast path; if threaded
scrolling is disabled, we're definitely not doing that.
* platform/graphics/TiledBacking.h:
* platform/graphics/ca/TileController.cpp:
(WebCore::TileController::TileController):
* platform/graphics/ca/TileCoverageMap.cpp:
(WebCore::TileCoverageMap::update):
Default to the "we have no ScrollingCoordinator" purple indication;
if a ScrollingCoordinator comes along it will setScrollingModeIndication
and change it from this default.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zalan@apple.com [Tue, 6 Oct 2015 18:06:34 +0000 (18:06 +0000)]
Remove redundant isComposited() function and replace
hasLayer() && layer()->isComposited() with RenderObject::isComposited().
https://bugs.webkit.org/show_bug.cgi?id=149846
Reviewed by Simon Fraser.
No change in functionality.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
* rendering/RenderView.cpp:
(WebCore::rendererObscuresBackground):
(WebCore::isComposited): Deleted.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 17:36:44 +0000 (17:36 +0000)]
Unreviewed, rolling out r190619.
https://bugs.webkit.org/show_bug.cgi?id=149849
borke the binding tests on iOS at least (Requested by youenn
on #webkit).
Reverted changeset:
"Binding generator XXConstructor::finishCreation should take
references as parameters"
https://bugs.webkit.org/show_bug.cgi?id=149838
http://trac.webkit.org/changeset/190619
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wenson_hsieh@apple.com [Tue, 6 Oct 2015 17:28:02 +0000 (17:28 +0000)]
Slider knobs should scale when rendering while zoomed
https://bugs.webkit.org/show_bug.cgi?id=149835
<rdar://problem/
22897080>
Reviewed by Darin Adler.
Make slider knobs follow suit with the rest of the unscaled form controls
by rendering to an offscreen buffer when the page is zoomed or scaled and
then rendering a scaled version of the offscreen buffer onto the page.
* platform/mac/ThemeMac.mm:
(WebCore::drawCellOrFocusRingIntoRectWithView): Helper function for drawing
cells and/or focus rings.
(WebCore::ThemeMac::drawCellOrFocusRingWithViewIntoContext): Refactored to
handle drawing slider knobs as well.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSliderThumb): Use scaled rendering when necessary.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 17:21:22 +0000 (17:21 +0000)]
[GTK] Make update-webkitgtk-libs work behind firewall
update-webkitgtk-libs can work behind a firewall with changes to
a few packages. Where outbound git and active FTP connections
fail, using http protocol succeeds. Most packages are
already accessed using http.
https://bugs.webkit.org/show_bug.cgi?id=148941
Patch by Mark Salisbury <mark.salisbury@hp.com> on 2015-10-06
Reviewed by Martin Robinson.
Tools
* gtk/jhbuild.modules:
Replace git URLs with http. Remove no longer used ftp repositories.
Update argument for libxml2's autogen.sh script (--without-python
is ignored; --with-python=no is correct).
* jhbuild/jhbuild-wrapper:
Instead of connecting to git://git.gnome.org/jhbuild, connect to
http://git.gnome.org/browse/jhbuild.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Tue, 6 Oct 2015 17:20:23 +0000 (17:20 +0000)]
[Web IDL] 'length' property is wrong for variadic operations
https://bugs.webkit.org/show_bug.cgi?id=149714
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C DOM test as our behavior changed. The new failures are
temporary and are due to the test being wrong. The test will be fixed
via Bug 149645 and we will pass those checks again.
* web-platform-tests/dom/interfaces-expected.txt:
Source/WebCore:
The value of the 'length' property was wrong for variadic operations:
- https://heycam.github.io/webidl/#dfn-optional-argument
The final argument of a variadic operation is considered to be an
optional argument. Therefore, we should not account for it when
computing the value of the 'length' property. This patch fixes WebKit's
behavior to match the specification.
Test: fast/dom/variadic-operations-length.html
* bindings/scripts/CodeGeneratorJS.pm:
(GetFunctionLength):
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
LayoutTests:
Add a layout test to check that the value for the 'length' property of
variadic operations is correct.
* fast/dom/variadic-operations-length-expected.txt: Added.
* fast/dom/variadic-operations-length.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
youenn.fablet@crf.canon.fr [Tue, 6 Oct 2015 16:50:22 +0000 (16:50 +0000)]
Binding generator should add builtin header for JSBuiltin attributes
https://bugs.webkit.org/show_bug.cgi?id=149837
Reviewed by Darin Adler.
Ensured XXBuiltins.h header is included for builtin attributes.
Renamed AddIncludesForJSBuiltinMethods as AddJSBuiltinIncludesIfNeeded.
Test loop is done through all functions and attributes to handle conditional correctly.
Covered by existing and added binding tests.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(AddJSBuiltinIncludesIfNeeded):
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestObj.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
youenn.fablet@crf.canon.fr [Tue, 6 Oct 2015 16:37:31 +0000 (16:37 +0000)]
Binding generator XXConstructor::finishCreation should take references as parameters
https://bugs.webkit.org/show_bug.cgi?id=149838
Reviewed by Darin Adler.
Updated the binding generator so that XXConstructor::finishCreation
takes a JSDOMGlobalObject& in lieu of a JSDOMGlobalObject*.
Covered by rebased binding tests.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::create):
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallbackConstructor::create):
(WebCore::JSTestCallbackConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::create):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::create):
(WebCore::JSTestEventTargetConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachableConstructor::create):
(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorConstructor::create):
(WebCore::JSTestJSBuiltinConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::create):
(WebCore::JSTestNamedConstructorNamedConstructor::create):
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::create):
(WebCore::JSTestNodeConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministicConstructor::create):
(WebCore::JSTestNondeterministicConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::create):
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltinsConstructor::create):
(WebCore::JSTestOverrideBuiltinsConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::create):
(WebCore::JSTestTypedefsConstructor::finishCreation):
* bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeConstructor::create):
(WebCore::JSattributeConstructor::finishCreation):
* bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyConstructor::create):
(WebCore::JSreadonlyConstructor::finishCreation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 16:35:01 +0000 (16:35 +0000)]
[Cairo] fast/canvas/canvas-imageSmoothingFoo tests failed after r190383.
https://bugs.webkit.org/show_bug.cgi?id=149752
Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2015-10-06
Reviewed by Carlos Garcia Campos.
CG's low interpolation quality setting is equivalent to most other browsers default or high settings.
Source/WebCore:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
LayoutTests:
* platform/efl/fast/canvas/canvas-imageSmoothingQuality-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Tue, 6 Oct 2015 16:33:21 +0000 (16:33 +0000)]
Enable XSLT when building WebKit for iOS using the public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=149827
Patch by Daniel Bates <dbates@webkit.org> on 2015-10-06
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
Source/WTF:
* wtf/FeatureDefines.h:
Tools:
Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
run this script before building WebKit for iOS or the build will fail because one or more XSLT
headers cannot be found.
* Scripts/configure-xcode-for-ios-development:
(copyMissingXSLTHeadersToSDKIfNeeded): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@apple.com [Tue, 6 Oct 2015 16:28:38 +0000 (16:28 +0000)]
[Win] Correct positioning error introduced in r190235
https://bugs.webkit.org/show_bug.cgi?id=149631
<rdar://problem/
22635080>
Reviewed by Simon Fraser.
Covered by existing compositing tests:
css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html
fast/layers/no-clipping-overflow-hidden-added-after-transform.html
fast/layers/no-clipping-overflow-hidden-added-after-transition.html
fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
transforms/2d/preserve3d-not-fixed-container.html
* platform/graphics/ca/TileGrid.cpp:
(TileGrid::platformCALayerPaintContents): No need to do this extra flipping step
on Windows.
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::displayCallback): We should always flip the
coordinate system when drawing these layers on Windows.
(shouldInvertBeforeDrawingContent): Deleted.
* platform/graphics/ca/win/WebTiledBackingLayerWin.cpp:
(WebTiledBackingLayerWin::displayCallback): We do not need to flip coordinates
for these tiled layers; that's already accounted for in common tile drawing code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 16:21:04 +0000 (16:21 +0000)]
Fix ENABLE_OPENGL=OFF builds
https://bugs.webkit.org/show_bug.cgi?id=146511
Patch by Emanuele Aina <emanuele.aina@collabora.com> on 2015-10-06
Reviewed by Darin Adler.
.:
* Source/cmake/OptionsGTK.cmake: Make ENABLE_WAYLAND_TARGET depend on
ENABLE_OPENGL due to EGL usage.
Source/WebCore:
* platform/graphics/texmap/BitmapTextureGL.h:
* platform/graphics/texmap/BitmapTextureGL.cpp:
* platform/graphics/texmap/TextureMapperGL.h:
* platform/graphics/texmap/TextureMapperGL.cpp:
* platform/graphics/texmap/TextureMapperShaderProgram.h:
* platform/graphics/texmap/TextureMapperShaderProgram.cpp:
Fix TEXTURE_MAPPER_GL vs. TEXTURE_MAPPER guards to make sure that
ENABLE_OPENGL=OFF only disables the GL-related parts.
Source/WebKit2:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize):
(webkitWebViewBaseDraw):
(webkitWebViewBaseDidRelaunchWebProcess):
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
webkitWebViewRenderAcceleratedCompositingResults()
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::DrawingArea):
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/LayerTreeHost.h:
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
setNativeSurfaceHandleForCompositing().
* UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore):
Default to no AC if no GL support has been built.
* WebProcess/WebPage/DrawingArea.messages.in:
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
SetNativeSurfaceHandleForCompositing.
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
setNativeSurfaceHandleForCompositing().
(WebKit::DrawingAreaImpl::setNativeSurfaceHandleForCompositing):
Force setAcceleratedCompositingEnabled() only if a LayerTreeHost
implementation is available, to avoid crashing when building without
any GL support.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achristensen@apple.com [Tue, 6 Oct 2015 14:23:09 +0000 (14:23 +0000)]
Fix Windows build after r190611.
* PlatformWin.cmake:
Forward headers from contentextensions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 13:31:14 +0000 (13:31 +0000)]
Use modern for-loops in WebCore/html.
https://bugs.webkit.org/show_bug.cgi?id=149662
Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2015-10-06
Reviewed by Darin Adler.
No new tests because there is no behavior change.
* html/DOMFormData.cpp:
(WebCore::DOMFormData::DOMFormData):
* html/EmailInputType.cpp:
(WebCore::EmailInputType::typeMismatchFor):
* html/FileInputType.cpp:
(WebCore::FileInputType::receiveDroppedFiles):
* html/FormController.cpp:
(WebCore::FormControlState::serializeTo):
(WebCore::FormControlState::deserialize):
(WebCore::SavedFormState::serializeTo):
(WebCore::SavedFormState::getReferencedFilePaths):
(WebCore::FormController::createSavedFormStateMap):
(WebCore::FormController::formElementsState):
(WebCore::FormController::restoreControlStateIn):
(WebCore::FormController::getReferencedFilePaths):
* html/HTMLAnchorElement.cpp:
(WebCore::hasNonEmptyBox):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::~HTMLCanvasElement):
(WebCore::HTMLCanvasElement::notifyObserversCanvasChanged):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):
* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::length):
* html/HTMLFormControlsCollection.cpp:
(WebCore::firstNamedItem):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::formWouldHaveSecureSubmission):
(WebCore::HTMLFormElement::removedFrom):
(WebCore::HTMLFormElement::length):
(WebCore::HTMLFormElement::submitImplicitly):
(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::getTextFieldValues):
(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::reset):
(WebCore::HTMLFormElement::defaultButton):
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
(WebCore::HTMLFormElement::removeFromPastNamesMap):
(WebCore::HTMLFormElement::documentDidResumeFromPageCache):
* html/HTMLInputElement.cpp:
(WebCore::parseAcceptAttribute):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setMediaGroup):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::index):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setDefaultValue):
* html/InputType.cpp:
(WebCore::populateInputTypeFactoryMap):
* html/MediaController.cpp:
(MediaController::duration):
(MediaController::setCurrentTime):
(MediaController::play):
(MediaController::setPlaybackRate):
(MediaController::setVolume):
(MediaController::setMuted):
(playbackStateWaiting):
(MediaController::updateMediaElements):
(MediaController::bringElementUpToSpeed):
(MediaController::isBlocked):
(MediaController::hasEnded):
(MediaController::asyncEventTimerFired):
(MediaController::clearPositionTimerFired):
(MediaController::hasAudio):
(MediaController::hasVideo):
(MediaController::hasClosedCaptions):
(MediaController::setClosedCaptionsVisible):
(MediaController::supportsScanning):
(MediaController::beginScrubbing):
(MediaController::endScrubbing):
(MediaController::canPlay):
(MediaController::isLiveStream):
(MediaController::hasCurrentSrc):
(MediaController::returnToRealtime):
* html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::parseTimeFragment):
* html/PublicURLManager.cpp:
(WebCore::PublicURLManager::revoke):
(WebCore::PublicURLManager::stop):
* html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::getCachedMaxIndex):
(WebCore::WebGLBuffer::setCachedMaxIndex):
(WebCore::WebGLBuffer::setTarget):
* html/canvas/WebGLContextGroup.cpp:
(WebCore::WebGLContextGroup::loseContextGroup):
* html/canvas/WebGLDrawBuffers.cpp:
(WebCore::WebGLDrawBuffers::satisfiesWebGLRequirements):
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeAttachments):
(WebCore::WebGLFramebuffer::drawBuffers):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::~WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::deleteTexture):
* html/canvas/WebGLVertexArrayObject.cpp:
(WebCore::WebGLVertexArrayObject::deleteObjectImpl):
* html/canvas/WebGLVertexArrayObjectOES.cpp:
(WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):
* html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::initializeAttributes):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
* html/parser/HTMLFormattingElementList.cpp:
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
* html/parser/XSSAuditor.cpp:
(WebCore::semicolonSeparatedValueContainsJavaScriptURL):
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
(WebCore::MediaControlTextTrackContainerElement::updateActiveCuesFontSize):
* html/track/AudioTrackList.cpp:
(AudioTrackList::getTrackById):
* html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::newCuesAvailable):
(WebCore::LoadableTextTrack::newRegionsAvailable):
* html/track/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::getCueById):
(WebCore::TextTrackCueList::activeCues):
* html/track/TextTrackList.cpp:
(TextTrackList::getTrackIndexRelativeToRenderedTracks):
(TextTrackList::invalidateTrackIndexesAfterTrack):
* html/track/TrackListBase.cpp:
(TrackListBase::isAnyTrackEnabled):
* html/track/VideoTrackList.cpp:
(VideoTrackList::getTrackById):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 6 Oct 2015 09:41:00 +0000 (09:41 +0000)]
URTBF after r190611.
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 08:18:08 +0000 (08:18 +0000)]
Report error when main resource is blocked by content blocker
https://bugs.webkit.org/show_bug.cgi?id=149719
rdar://problem/
21970595
Patch by Alex Christensen <achristensen@webkit.org> on 2015-10-06
Reviewed by Brady Eidson.
Source/WebCore:
Test: http/tests/contentextensions/main-resource.html
* English.lproj/Localizable.strings:
* contentextensions/ContentExtensionActions.h:
* contentextensions/ContentExtensionError.h:
(WebCore::ContentExtensions::make_error_code):
* contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::globalDisplayNoneStyleSheet):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
Instead of nulling out the ResourceRequest, processContentExtensionRulesForLoad
now returns a status indicating whether the request should be blocked.
This is needed because the DocumentLoader needs a CachedResource with an error representing the blocking
(WebCore::ContentExtensions::ContentExtensionsBackend::displayNoneCSSRule):
* contentextensions/ContentExtensionsBackend.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
Dispatch an error if the resource is blocked by a content blocker.
* loader/EmptyClients.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
(WebCore::FrameLoader::cancelledError):
(WebCore::FrameLoader::blockedByContentBlockerError):
(WebCore::FrameLoader::connectionProperties):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequestInternal):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
* page/UserContentController.cpp:
(WebCore::UserContentController::removeAllUserContentExtensions):
(WebCore::UserContentController::processContentExtensionRulesForLoad):
(WebCore::UserContentController::actionsForResourceLoad):
* page/UserContentController.h:
* platform/efl/ErrorsEfl.cpp:
(WebCore::blockedError):
(WebCore::blockedByContentBlockerError):
(WebCore::cannotShowURLError):
* platform/efl/ErrorsEfl.h:
* platform/gtk/ErrorsGtk.cpp:
(WebCore::blockedError):
(WebCore::blockedByContentBlockerError):
(WebCore::cannotShowURLError):
* platform/gtk/ErrorsGtk.h:
Source/WebKit/mac:
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::blockedError):
(WebFrameLoaderClient::blockedByContentBlockerError):
(WebFrameLoaderClient::cannotShowURLError):
Add blockedByContentBlockerError so WebFrameLoaderClient is not an abstract class,
but it should be unused because content blockers are not enabled on WK1.
Source/WebKit/win:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::blockedError):
(WebFrameLoaderClient::blockedByContentBlockerError):
(WebFrameLoaderClient::cannotShowURLError):
* WebCoreSupport/WebFrameLoaderClient.h:
Added stub that should never be used.
Source/WebKit2:
* Shared/API/c/WKErrorRef.h:
* WebProcess/WebCoreSupport/WebErrors.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::blockedError):
(WebKit::WebFrameLoaderClient::blockedByContentBlockerError):
(WebKit::WebFrameLoaderClient::cannotShowURLError):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:
(WebKit::blockedError):
(WebKit::blockedByContentBlockerError):
(WebKit::cannotShowURLError):
* WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:
(WebKit::blockedError):
(WebKit::blockedByContentBlockerError):
(WebKit::cannotShowURLError):
* WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
(WebKit::blockedError):
(WebKit::blockedByContentBlockerError):
(WebKit::cannotShowURLError):
Make a new error type for loads that were blocked by a content blocker.
LayoutTests:
* http/tests/contentextensions/main-resource-expected.txt: Added.
* http/tests/contentextensions/main-resource.html: Added.
* http/tests/contentextensions/main-resource.html.json: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
calvaris@igalia.com [Tue, 6 Oct 2015 08:02:00 +0000 (08:02 +0000)]
JSBuiltinConstructor must always add builtin header
https://bugs.webkit.org/show_bug.cgi?id=149759
Reviewed by Darin Adler.
Covered by TestJSBuiltinConstructor.idl.
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForJSBuiltinMethods): Forces adding the builtin header when the JSBuiltinConstructor is present.
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp: Expectation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 06:54:48 +0000 (06:54 +0000)]
Unreviewed EFL Gardening
https://bugs.webkit.org/show_bug.cgi?id=149830
Remove "--lint-test-files warnings".
Patch by Byung Jun Kim <bj1987.kim@samsung.com> on 2015-10-05
* platform/efl/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
youenn.fablet@crf.canon.fr [Tue, 6 Oct 2015 06:20:58 +0000 (06:20 +0000)]
Migrate streams API to JS Builtins
https://bugs.webkit.org/show_bug.cgi?id=147092
Reviewed by Darin Adler.
Source/WebCore:
Moved ReadableStream implementation from C++ to JS Builtins.
Created specific private constructors for ReadableStreamReader and ReadableStreamController.
Added these constructors to JSDOMWindowBase.
Constructors are based on a template found in JSDOMConstructor which might serve to webidl-generated classes as well.
Covered by existing tests.
* CMakeLists.txt:
* DerivedSources.make:
* Modules/streams/ReadableStream.cpp: Removed.
* Modules/streams/ReadableStream.h: Removed.
* Modules/streams/ReadableStream.idl:
* Modules/streams/ReadableStream.js:
(strategy.size):
(initializeReadableStream):
(cancel):
(getReader):
(pipeTo):
(tee):
(locked):
* Modules/streams/ReadableStreamController.h:
* Modules/streams/ReadableStreamController.idl:
* Modules/streams/ReadableStreamController.js: Added.
(enqueue):
(error):
(close):
(desiredSize):
* Modules/streams/ReadableStreamInternals.js:
(privateInitializeReadableStreamReader):
(privateInitializeReadableStreamController):
(isReadableStream):
(isReadableStreamReader):
(isReadableStreamController):
(errorReadableStream):
(requestReadableStreamPull):
(getReadableStreamDesiredSize):
(releaseReadableStreamReader):
(cancelReadableStream):
(finishClosingReadableStream):
(closeReadableStream):
(closeReadableStreamReader):
(enqueueInReadableStream):
(readFromReadableStreamReader):
(invokeOrNoop):
(promiseInvokeOrNoop):
* Modules/streams/ReadableStreamReader.cpp: Removed.
* Modules/streams/ReadableStreamReader.h:
* Modules/streams/ReadableStreamReader.idl:
* Modules/streams/ReadableStreamReader.js: Copied from Source/WebCore/Modules/streams/ReadableStream.js.
(cancel):
(read):
(releaseLock):
(closed):
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMConstructor.h: Added.
(WebCore::JSBuiltinConstructor::create):
(WebCore::JSBuiltinConstructor::createStructure):
(WebCore::JSBuiltinConstructor::JSBuiltinConstructor):
(WebCore::JSBuiltinConstructor::initializeProperties):
(WebCore::JSBuiltinConstructor<JSClass>::finishCreation):
(WebCore::JSBuiltinConstructor<JSClass>::construct):
(WebCore::JSBuiltinConstructor<JSClass>::getConstructData):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::finishCreation):
* bindings/js/JSReadableStreamControllerCustom.cpp: Removed.
* bindings/js/JSReadableStreamCustom.cpp: Removed.
* bindings/js/JSReadableStreamPrivateConstructors.cpp: Added.
(WebCore::constructJSReadableStreamController):
(WebCore::constructJSReadableStreamReader):
(WebCore::JSBuiltinConstructor<JSReadableStreamReader>::createJSObject):
(WebCore::JSBuiltinConstructor<JSReadableStreamController>::createJSObject):
(WebCore::JSBuiltinReadableStreamReaderPrivateConstructor::createInitializeFunction):
(WebCore::JSBuiltinReadableStreamControllerPrivateConstructor::createInitializeFunction):
(WebCore::createReadableStreamReaderPrivateConstructor):
(WebCore::createReadableStreamControllerPrivateConstructor):
* bindings/js/JSReadableStreamPrivateConstructors.h: Added.
* bindings/js/JSReadableStreamReaderCustom.cpp: Removed.
* bindings/js/ReadableJSStream.cpp: Removed.
* bindings/js/ReadableJSStream.h: Removed.
* bindings/js/WebCoreBuiltinNames.h: Added.
(WebCore::WebCoreBuiltinNames::WebCoreBuiltinNames):
* bindings/js/WebCoreJSBuiltins.cpp:
* bindings/js/WebCoreJSClientData.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::builtinNames):
(WebCore::WebCoreJSClientData::readableStreamControllerBuiltins):
(WebCore::WebCoreJSClientData::readableStreamReaderBuiltins):
LayoutTests:
Rebasing some tests, one subtest passing, two others still failing but with different reasons.
* streams/reference-implementation/brand-checks-expected.txt:
* streams/reference-implementation/readable-stream-reader-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 06:15:11 +0000 (06:15 +0000)]
Unreviewed, rolling out r190599.
https://bugs.webkit.org/show_bug.cgi?id=149836
Made perf tests randomly crash (Requested by ap on #webkit).
Reverted changeset:
"GC shouldn't cancel every FTL compilation"
https://bugs.webkit.org/show_bug.cgi?id=149821
http://trac.webkit.org/changeset/190599
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 6 Oct 2015 05:51:34 +0000 (05:51 +0000)]
Unreviewed, rolling out r190589.
https://bugs.webkit.org/show_bug.cgi?id=149833
Caused lots of leaks, and possibly crashes (Requested by ap on
#webkit).
Reverted changeset:
"Unreviewed, rolling back in r190450"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190589
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Tue, 6 Oct 2015 05:43:03 +0000 (05:43 +0000)]
data: URLs should not be preloaded
https://bugs.webkit.org/show_bug.cgi?id=149829
Reviewed by Ryosuke Niwa.
Source/WebCore:
Update the HTMLPreloadScanner so that data: URLs do not get preloaded.
There is no need as the data is already available.
Test: fast/preloader/image-data-url.html
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
LayoutTests:
Add layout test to make sure that images with a data: URL do not
get preloaded.
* fast/preloader/image-data-url-expected.txt: Added.
* fast/preloader/image-data-url.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 6 Oct 2015 04:13:32 +0000 (04:13 +0000)]
[iOS] REGRESSION(r190434): Media continues to play when locking screen
https://bugs.webkit.org/show_bug.cgi?id=149822
Reviewed by Brent Fulgham.
Source/WebCore:
In MediaSessionManagerIOS.mm, both -applicationWillEnterForeground: and
-applicationDidBecomeActive: called
PlatformMediaSessionManager::applicationWillEnterForeground(), leading to the
PlatformMediaSession's m_interruptionCount becoming increasingly unbalanced.
Rename PlatformMediaSessionManager::applicationWillEnterForeground() to
applicationDidEnterForeground() to more correctly reflect when this notification will be
called. Add a new method, MediaSessionManagerIOS::applicationWillEnterForeground(bool),
whose paramater is whether the screen was locked. This allows the beginInterruption() and
endInterruption() methods to be correctly balanced.
Drive-by fix: remove the unimplemented declarations for application{will,did}Enter{Fore,Back}ground()
from PlatformMediaSession.h.
* platform/audio/PlatformMediaSession.h:
* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::applicationDidEnterForeground):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground): Deleted.
* platform/audio/PlatformMediaSessionManager.h:
* platform/audio/ios/MediaSessionManagerIOS.h:
* platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::applicationDidEnterBackground):
(WebCore::MediaSessionManageriOS::applicationWillEnterForeground):
(-[WebMediaSessionHelper applicationWillEnterForeground:]):
(-[WebMediaSessionHelper applicationDidBecomeActive:]):
* testing/Internals.cpp:
(WebCore::Internals::applicationDidEnterForeground):
(WebCore::Internals::applicationWillEnterForeground): Deleted.
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
Pass through isSuspendedUnderLock when notifying the WebPage that the
applicationWillEnterForeground, and pass that boolean in the userInfo of the
WebUIApplicationWillEnterForegroundNotification.
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applicationWillEnterForeground):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::applicationWillEnterForeground):
LayoutTests:
applicationWillEnterForeground() -> applicationDidEnterForeground().
* media/video-background-playback-expected.txt:
* media/video-background-playback.html:
* media/video-background-tab-playback-expected.txt:
* media/video-background-tab-playback.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nvasilyev@apple.com [Tue, 6 Oct 2015 03:00:36 +0000 (03:00 +0000)]
Modify the image to fit the width of the blog.
* blog-files/web-inspector-keyboard-shortcuts/debugger-shortcuts.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achristensen@apple.com [Tue, 6 Oct 2015 02:47:38 +0000 (02:47 +0000)]
Invalid CSS Selector for Content Blockers invalidates others
https://bugs.webkit.org/show_bug.cgi?id=148446
rdar://problem/
22918235
Reviewed by Benjamin Poulain.
Source/WebCore:
Test: http/tests/contentextensions/invalid-selector.html
* contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::loadTrigger):
(WebCore::ContentExtensions::isValidSelector):
(WebCore::ContentExtensions::loadAction):
(WebCore::ContentExtensions::loadRule):
Add a check to see if a selector is valid before adding it.
LayoutTests:
* http/tests/contentextensions/invalid-selector-expected.txt: Added.
* http/tests/contentextensions/invalid-selector.html: Added.
* http/tests/contentextensions/invalid-selector.html.json: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc